SemaDeclObjC.cpp revision 246e70f69cb8aeb67225c54690f1c6b25abd5a86 
1//===--- SemaDeclObjC.cpp - Semantic Analysis for ObjC Declarations -------===//
2//
3//                     The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10//  This file implements semantic analysis for Objective C declarations.
11//
12//===----------------------------------------------------------------------===//
13
14#include "Sema.h"
15#include "clang/AST/ASTContext.h"
16#include "clang/AST/DeclObjC.h"
17#include "clang/Basic/Diagnostic.h"
18#include "clang/Parse/DeclSpec.h"
19
20using namespace clang;
21
22/// ObjCActOnStartOfMethodDef - This routine sets up parameters; invisible
23/// and user declared, in the method definition's AST.
24void Sema::ObjCActOnStartOfMethodDef(Scope *FnBodyScope, DeclTy *D) {
25  assert(getCurMethodDecl() == 0 && "Method parsing confused");
26  ObjCMethodDecl *MDecl = dyn_cast_or_null<ObjCMethodDecl>((Decl *)D);
27
28  // If we don't have a valid method decl, simply return.
29  if (!MDecl)
30    return;
31
32  // Allow the rest of sema to find private method decl implementations.
33  if (MDecl->isInstance())
34    AddInstanceMethodToGlobalPool(MDecl);
35  else
36    AddFactoryMethodToGlobalPool(MDecl);
37
38  // Allow all of Sema to see that we are entering a method definition.
39  PushDeclContext(MDecl);
40
41  // Create Decl objects for each parameter, entrring them in the scope for
42  // binding to their use.
43
44  // Insert the invisible arguments, self and _cmd!
45  MDecl->createImplicitParams(Context);
46
47  PushOnScopeChains(MDecl->getSelfDecl(), FnBodyScope);
48  PushOnScopeChains(MDecl->getCmdDecl(), FnBodyScope);
49
50  // Introduce all of the other parameters into this scope.
51  for (unsigned i = 0, e = MDecl->getNumParams(); i != e; ++i) {
52    ParmVarDecl *PDecl = MDecl->getParamDecl(i);
53    IdentifierInfo *II = PDecl->getIdentifier();
54    if (II)
55      PushOnScopeChains(PDecl, FnBodyScope);
56  }
57}
58
59Sema::DeclTy *Sema::
60ActOnStartClassInterface(SourceLocation AtInterfaceLoc,
61                         IdentifierInfo *ClassName, SourceLocation ClassLoc,
62                         IdentifierInfo *SuperName, SourceLocation SuperLoc,
63                         DeclTy * const *ProtoRefs, unsigned NumProtoRefs,
64                         SourceLocation EndProtoLoc, AttributeList *AttrList) {
65  assert(ClassName && "Missing class identifier");
66
67  // Check for another declaration kind with the same name.
68  Decl *PrevDecl = LookupDecl(ClassName, Decl::IDNS_Ordinary, TUScope);
69  if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) {
70    Diag(ClassLoc, diag::err_redefinition_different_kind,
71         ClassName->getName());
72    Diag(PrevDecl->getLocation(), diag::err_previous_definition);
73  }
74
75  ObjCInterfaceDecl* IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl);
76  if (IDecl) {
77    // Class already seen. Is it a forward declaration?
78    if (!IDecl->isForwardDecl())
79      Diag(AtInterfaceLoc, diag::err_duplicate_class_def, IDecl->getName());
80    else {
81      IDecl->setLocation(AtInterfaceLoc);
82      IDecl->setForwardDecl(false);
83    }
84  } else {
85    IDecl = ObjCInterfaceDecl::Create(Context, AtInterfaceLoc,
86                                      ClassName, ClassLoc);
87    if (AttrList)
88      ProcessDeclAttributeList(IDecl, AttrList);
89
90    ObjCInterfaceDecls[ClassName] = IDecl;
91    // Remember that this needs to be removed when the scope is popped.
92    TUScope->AddDecl(IDecl);
93  }
94
95  if (SuperName) {
96    ObjCInterfaceDecl* SuperClassEntry = 0;
97    // Check if a different kind of symbol declared in this scope.
98    PrevDecl = LookupDecl(SuperName, Decl::IDNS_Ordinary, TUScope);
99    if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) {
100      Diag(SuperLoc, diag::err_redefinition_different_kind,
101           SuperName->getName());
102      Diag(PrevDecl->getLocation(), diag::err_previous_definition);
103    }
104    else {
105      // Check that super class is previously defined
106      SuperClassEntry = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl);
107
108      if (!SuperClassEntry || SuperClassEntry->isForwardDecl()) {
109        Diag(SuperLoc, diag::err_undef_superclass,
110             SuperClassEntry ? SuperClassEntry->getName()
111                             : SuperName->getName(),
112             ClassName->getName(), SourceRange(AtInterfaceLoc, ClassLoc));
113      }
114    }
115    IDecl->setSuperClass(SuperClassEntry);
116    IDecl->setSuperClassLoc(SuperLoc);
117    IDecl->setLocEnd(SuperLoc);
118  } else { // we have a root class.
119    IDecl->setLocEnd(ClassLoc);
120  }
121
122  /// Check then save referenced protocols
123  if (NumProtoRefs) {
124    IDecl->addReferencedProtocols((ObjCProtocolDecl**)ProtoRefs, NumProtoRefs);
125    IDecl->setLocEnd(EndProtoLoc);
126  }
127  return IDecl;
128}
129
130/// ActOnCompatiblityAlias - this action is called after complete parsing of
131/// @compatibility_alias declaration. It sets up the alias relationships.
132Sema::DeclTy *Sema::ActOnCompatiblityAlias(SourceLocation AtLoc,
133                                           IdentifierInfo *AliasName,
134                                           SourceLocation AliasLocation,
135                                           IdentifierInfo *ClassName,
136                                           SourceLocation ClassLocation) {
137  // Look for previous declaration of alias name
138  Decl *ADecl = LookupDecl(AliasName, Decl::IDNS_Ordinary, TUScope);
139  if (ADecl) {
140    if (isa<ObjCCompatibleAliasDecl>(ADecl)) {
141      Diag(AliasLocation, diag::warn_previous_alias_decl);
142      Diag(ADecl->getLocation(), diag::warn_previous_declaration);
143    }
144    else {
145      Diag(AliasLocation, diag::err_conflicting_aliasing_type,
146           AliasName->getName());
147      Diag(ADecl->getLocation(), diag::err_previous_declaration);
148    }
149    return 0;
150  }
151  // Check for class declaration
152  Decl *CDeclU = LookupDecl(ClassName, Decl::IDNS_Ordinary, TUScope);
153  ObjCInterfaceDecl *CDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDeclU);
154  if (CDecl == 0) {
155    Diag(ClassLocation, diag::warn_undef_interface, ClassName->getName());
156    if (CDeclU)
157      Diag(CDeclU->getLocation(), diag::warn_previous_declaration);
158    return 0;
159  }
160
161  // Everything checked out, instantiate a new alias declaration AST.
162  ObjCCompatibleAliasDecl *AliasDecl =
163    ObjCCompatibleAliasDecl::Create(Context, AtLoc, AliasName, CDecl);
164
165  ObjCAliasDecls[AliasName] = AliasDecl;
166  TUScope->AddDecl(AliasDecl);
167  return AliasDecl;
168}
169
170Sema::DeclTy *
171Sema::ActOnStartProtocolInterface(SourceLocation AtProtoInterfaceLoc,
172                                  IdentifierInfo *ProtocolName,
173                                  SourceLocation ProtocolLoc,
174                                  DeclTy * const *ProtoRefs,
175                                  unsigned NumProtoRefs,
176                                  SourceLocation EndProtoLoc,
177                                  AttributeList *AttrList) {
178  // FIXME: Deal with AttrList.
179  assert(ProtocolName && "Missing protocol identifier");
180  ObjCProtocolDecl *PDecl = ObjCProtocols[ProtocolName];
181  if (PDecl) {
182    // Protocol already seen. Better be a forward protocol declaration
183    if (!PDecl->isForwardDecl()) {
184      Diag(ProtocolLoc, diag::err_duplicate_protocol_def,
185           ProtocolName->getName());
186      // Just return the protocol we already had.
187      // FIXME: don't leak the objects passed in!
188      return PDecl;
189    }
190    // Make sure the cached decl gets a valid start location.
191    PDecl->setLocation(AtProtoInterfaceLoc);
192    PDecl->setForwardDecl(false);
193  } else {
194    PDecl = ObjCProtocolDecl::Create(Context, AtProtoInterfaceLoc,ProtocolName);
195    PDecl->setForwardDecl(false);
196    ObjCProtocols[ProtocolName] = PDecl;
197  }
198
199  if (NumProtoRefs) {
200    /// Check then save referenced protocols.
201    PDecl->addReferencedProtocols((ObjCProtocolDecl**)ProtoRefs, NumProtoRefs);
202    PDecl->setLocEnd(EndProtoLoc);
203  }
204  return PDecl;
205}
206
207/// FindProtocolDeclaration - This routine looks up protocols and
208/// issues an error if they are not declared. It returns list of
209/// protocol declarations in its 'Protocols' argument.
210void
211Sema::FindProtocolDeclaration(bool WarnOnDeclarations,
212                              const IdentifierLocPair *ProtocolId,
213                              unsigned NumProtocols,
214                              llvm::SmallVectorImpl<DeclTy*> &Protocols) {
215  for (unsigned i = 0; i != NumProtocols; ++i) {
216    ObjCProtocolDecl *PDecl = ObjCProtocols[ProtocolId[i].first];
217    if (!PDecl) {
218      Diag(ProtocolId[i].second, diag::err_undeclared_protocol,
219           ProtocolId[i].first->getName());
220      continue;
221    }
222
223    // If this is a forward declaration and we are supposed to warn in this
224    // case, do it.
225    if (WarnOnDeclarations && PDecl->isForwardDecl())
226      Diag(ProtocolId[i].second, diag::warn_undef_protocolref,
227           ProtocolId[i].first->getName());
228    Protocols.push_back(PDecl);
229  }
230}
231
232/// DiagnosePropertyMismatch - Compares two properties for their
233/// attributes and types and warns on a variety of inconsistencies.
234///
235void
236Sema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property,
237                               ObjCPropertyDecl *SuperProperty,
238                               const char *inheritedName) {
239  ObjCPropertyDecl::PropertyAttributeKind CAttr =
240  Property->getPropertyAttributes();
241  ObjCPropertyDecl::PropertyAttributeKind SAttr =
242  SuperProperty->getPropertyAttributes();
243  if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly)
244      && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite))
245    Diag(Property->getLocation(), diag::warn_readonly_property,
246               Property->getName(), inheritedName);
247  if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy)
248      != (SAttr & ObjCPropertyDecl::OBJC_PR_copy))
249    Diag(Property->getLocation(), diag::warn_property_attribute,
250         Property->getName(), "copy", inheritedName,
251         SourceRange());
252  else if ((CAttr & ObjCPropertyDecl::OBJC_PR_retain)
253           != (SAttr & ObjCPropertyDecl::OBJC_PR_retain))
254    Diag(Property->getLocation(), diag::warn_property_attribute,
255         Property->getName(), "retain", inheritedName,
256         SourceRange());
257
258  if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)
259      != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic))
260    Diag(Property->getLocation(), diag::warn_property_attribute,
261         Property->getName(), "atomic", inheritedName,
262         SourceRange());
263  if (Property->getSetterName() != SuperProperty->getSetterName())
264    Diag(Property->getLocation(), diag::warn_property_attribute,
265         Property->getName(), "setter", inheritedName,
266         SourceRange());
267  if (Property->getGetterName() != SuperProperty->getGetterName())
268    Diag(Property->getLocation(), diag::warn_property_attribute,
269         Property->getName(), "getter", inheritedName,
270         SourceRange());
271
272  if (Context.getCanonicalType(Property->getType()) !=
273          Context.getCanonicalType(SuperProperty->getType()))
274    Diag(Property->getLocation(), diag::warn_property_type,
275         Property->getType().getAsString(),
276         inheritedName);
277
278}
279
280/// ComparePropertiesInBaseAndSuper - This routine compares property
281/// declarations in base and its super class, if any, and issues
282/// diagnostics in a variety of inconsistant situations.
283///
284void
285Sema::ComparePropertiesInBaseAndSuper(ObjCInterfaceDecl *IDecl) {
286  ObjCInterfaceDecl *SDecl = IDecl->getSuperClass();
287  if (!SDecl)
288    return;
289  // FIXME: O(N^2)
290  for (ObjCInterfaceDecl::classprop_iterator S = SDecl->classprop_begin(),
291       E = SDecl->classprop_end(); S != E; ++S) {
292    ObjCPropertyDecl *SuperPDecl = (*S);
293    // Does property in super class has declaration in current class?
294    for (ObjCInterfaceDecl::classprop_iterator I = IDecl->classprop_begin(),
295         E = IDecl->classprop_end(); I != E; ++I) {
296      ObjCPropertyDecl *PDecl = (*I);
297      if (SuperPDecl->getIdentifier() == PDecl->getIdentifier())
298          DiagnosePropertyMismatch(PDecl, SuperPDecl, SDecl->getName());
299    }
300  }
301}
302
303/// MergeOneProtocolPropertiesIntoClass - This routine goes thru the list
304/// of properties declared in a protocol and adds them to the list
305/// of properties for current class if it is not there already.
306void
307Sema::MergeOneProtocolPropertiesIntoClass(ObjCInterfaceDecl *IDecl,
308                                          ObjCProtocolDecl *PDecl)
309{
310  llvm::SmallVector<ObjCPropertyDecl*, 16> mergeProperties;
311  for (ObjCProtocolDecl::classprop_iterator P = PDecl->classprop_begin(),
312       E = PDecl->classprop_end(); P != E; ++P) {
313    ObjCPropertyDecl *Pr = (*P);
314    ObjCInterfaceDecl::classprop_iterator CP, CE;
315    // Is this property already in  class's list of properties?
316    for (CP = IDecl->classprop_begin(), CE = IDecl->classprop_end();
317         CP != CE; ++CP)
318      if ((*CP)->getIdentifier() == Pr->getIdentifier())
319        break;
320    if (CP == CE)
321      // Add this property to list of properties for thie class.
322      mergeProperties.push_back(Pr);
323    else
324      // Property protocol already exist in class. Diagnose any mismatch.
325      DiagnosePropertyMismatch((*CP), Pr, PDecl->getName());
326    }
327  IDecl->mergeProperties(&mergeProperties[0], mergeProperties.size());
328}
329
330/// MergeProtocolPropertiesIntoClass - This routine merges properties
331/// declared in 'MergeItsProtocols' objects (which can be a class or an
332/// inherited protocol into the list of properties for class 'IDecl'
333///
334
335void
336Sema::MergeProtocolPropertiesIntoClass(ObjCInterfaceDecl *IDecl,
337                                       DeclTy *MergeItsProtocols) {
338  Decl *ClassDecl = static_cast<Decl *>(MergeItsProtocols);
339  if (ObjCInterfaceDecl *MDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) {
340    for (ObjCInterfaceDecl::protocol_iterator P = MDecl->protocol_begin(),
341         E = MDecl->protocol_end(); P != E; ++P)
342      // Merge properties of class (*P) into IDECL's
343      MergeOneProtocolPropertiesIntoClass(IDecl, *P);
344
345    // Go thru the list of protocols for this class and recursively merge
346    // their properties into this class as well.
347    for (ObjCInterfaceDecl::protocol_iterator P = IDecl->protocol_begin(),
348         E = IDecl->protocol_end(); P != E; ++P)
349      MergeProtocolPropertiesIntoClass(IDecl, *P);
350  } else {
351    ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl);
352    for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(),
353         E = MD->protocol_end(); P != E; ++P)
354      MergeOneProtocolPropertiesIntoClass(IDecl, (*P));
355  }
356}
357
358/// ActOnForwardProtocolDeclaration -
359Action::DeclTy *
360Sema::ActOnForwardProtocolDeclaration(SourceLocation AtProtocolLoc,
361                                      const IdentifierLocPair *IdentList,
362                                      unsigned NumElts) {
363  llvm::SmallVector<ObjCProtocolDecl*, 32> Protocols;
364
365  for (unsigned i = 0; i != NumElts; ++i) {
366    IdentifierInfo *Ident = IdentList[i].first;
367    ObjCProtocolDecl *&PDecl = ObjCProtocols[Ident];
368    if (PDecl == 0) // Not already seen?
369      PDecl = ObjCProtocolDecl::Create(Context, IdentList[i].second, Ident);
370
371    Protocols.push_back(PDecl);
372  }
373  return ObjCForwardProtocolDecl::Create(Context, AtProtocolLoc,
374                                         &Protocols[0], Protocols.size());
375}
376
377Sema::DeclTy *Sema::
378ActOnStartCategoryInterface(SourceLocation AtInterfaceLoc,
379                            IdentifierInfo *ClassName, SourceLocation ClassLoc,
380                            IdentifierInfo *CategoryName,
381                            SourceLocation CategoryLoc,
382                            DeclTy * const *ProtoRefs,
383                            unsigned NumProtoRefs,
384                            SourceLocation EndProtoLoc) {
385  ObjCInterfaceDecl *IDecl = getObjCInterfaceDecl(ClassName);
386
387  ObjCCategoryDecl *CDecl =
388    ObjCCategoryDecl::Create(Context, AtInterfaceLoc, CategoryName);
389  CDecl->setClassInterface(IDecl);
390
391  /// Check that class of this category is already completely declared.
392  if (!IDecl || IDecl->isForwardDecl())
393    Diag(ClassLoc, diag::err_undef_interface, ClassName->getName());
394  else {
395    /// Check for duplicate interface declaration for this category
396    ObjCCategoryDecl *CDeclChain;
397    for (CDeclChain = IDecl->getCategoryList(); CDeclChain;
398         CDeclChain = CDeclChain->getNextClassCategory()) {
399      if (CategoryName && CDeclChain->getIdentifier() == CategoryName) {
400        Diag(CategoryLoc, diag::warn_dup_category_def, ClassName->getName(),
401             CategoryName->getName());
402        break;
403      }
404    }
405    if (!CDeclChain)
406      CDecl->insertNextClassCategory();
407  }
408
409  if (NumProtoRefs) {
410    CDecl->addReferencedProtocols((ObjCProtocolDecl**)ProtoRefs, NumProtoRefs);
411    CDecl->setLocEnd(EndProtoLoc);
412  }
413  return CDecl;
414}
415
416/// ActOnStartCategoryImplementation - Perform semantic checks on the
417/// category implementation declaration and build an ObjCCategoryImplDecl
418/// object.
419Sema::DeclTy *Sema::ActOnStartCategoryImplementation(
420                      SourceLocation AtCatImplLoc,
421                      IdentifierInfo *ClassName, SourceLocation ClassLoc,
422                      IdentifierInfo *CatName, SourceLocation CatLoc) {
423  ObjCInterfaceDecl *IDecl = getObjCInterfaceDecl(ClassName);
424  ObjCCategoryImplDecl *CDecl =
425    ObjCCategoryImplDecl::Create(Context, AtCatImplLoc, CatName, IDecl);
426  /// Check that class of this category is already completely declared.
427  if (!IDecl || IDecl->isForwardDecl())
428    Diag(ClassLoc, diag::err_undef_interface, ClassName->getName());
429
430  /// TODO: Check that CatName, category name, is not used in another
431  // implementation.
432  return CDecl;
433}
434
435Sema::DeclTy *Sema::ActOnStartClassImplementation(
436                      SourceLocation AtClassImplLoc,
437                      IdentifierInfo *ClassName, SourceLocation ClassLoc,
438                      IdentifierInfo *SuperClassname,
439                      SourceLocation SuperClassLoc) {
440  ObjCInterfaceDecl* IDecl = 0;
441  // Check for another declaration kind with the same name.
442  Decl *PrevDecl = LookupDecl(ClassName, Decl::IDNS_Ordinary, TUScope);
443  if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) {
444    Diag(ClassLoc, diag::err_redefinition_different_kind,
445         ClassName->getName());
446    Diag(PrevDecl->getLocation(), diag::err_previous_definition);
447  }
448  else {
449    // Is there an interface declaration of this class; if not, warn!
450    IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl);
451    if (!IDecl)
452      Diag(ClassLoc, diag::warn_undef_interface, ClassName->getName());
453  }
454
455  // Check that super class name is valid class name
456  ObjCInterfaceDecl* SDecl = 0;
457  if (SuperClassname) {
458    // Check if a different kind of symbol declared in this scope.
459    PrevDecl = LookupDecl(SuperClassname, Decl::IDNS_Ordinary, TUScope);
460    if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) {
461      Diag(SuperClassLoc, diag::err_redefinition_different_kind,
462           SuperClassname->getName());
463      Diag(PrevDecl->getLocation(), diag::err_previous_definition);
464    }
465    else {
466      SDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl);
467      if (!SDecl)
468        Diag(SuperClassLoc, diag::err_undef_superclass,
469             SuperClassname->getName(), ClassName->getName());
470      else if (IDecl && IDecl->getSuperClass() != SDecl) {
471        // This implementation and its interface do not have the same
472        // super class.
473        Diag(SuperClassLoc, diag::err_conflicting_super_class,
474             SDecl->getName());
475        Diag(SDecl->getLocation(), diag::err_previous_definition);
476      }
477    }
478  }
479
480  if (!IDecl) {
481    // Legacy case of @implementation with no corresponding @interface.
482    // Build, chain & install the interface decl into the identifier.
483
484    // FIXME: Do we support attributes on the @implementation? If so
485    // we should copy them over.
486    IDecl = ObjCInterfaceDecl::Create(Context, AtClassImplLoc, ClassName,
487                                      ClassLoc, false, true);
488    ObjCInterfaceDecls[ClassName] = IDecl;
489    IDecl->setSuperClass(SDecl);
490    IDecl->setLocEnd(ClassLoc);
491
492    // Remember that this needs to be removed when the scope is popped.
493    TUScope->AddDecl(IDecl);
494  }
495
496  ObjCImplementationDecl* IMPDecl =
497    ObjCImplementationDecl::Create(Context, AtClassImplLoc, ClassName,
498                                   IDecl, SDecl);
499
500  // Check that there is no duplicate implementation of this class.
501  if (ObjCImplementations[ClassName])
502    // FIXME: Don't leak everything!
503    Diag(ClassLoc, diag::err_dup_implementation_class, ClassName->getName());
504  else // add it to the list.
505    ObjCImplementations[ClassName] = IMPDecl;
506  return IMPDecl;
507}
508
509void Sema::CheckImplementationIvars(ObjCImplementationDecl *ImpDecl,
510                                    ObjCIvarDecl **ivars, unsigned numIvars,
511                                    SourceLocation RBrace) {
512  assert(ImpDecl && "missing implementation decl");
513  ObjCInterfaceDecl* IDecl = getObjCInterfaceDecl(ImpDecl->getIdentifier());
514  if (!IDecl)
515    return;
516  /// Check case of non-existing @interface decl.
517  /// (legacy objective-c @implementation decl without an @interface decl).
518  /// Add implementations's ivar to the synthesize class's ivar list.
519  if (IDecl->ImplicitInterfaceDecl()) {
520    IDecl->addInstanceVariablesToClass(ivars, numIvars, RBrace);
521    return;
522  }
523  // If implementation has empty ivar list, just return.
524  if (numIvars == 0)
525    return;
526
527  assert(ivars && "missing @implementation ivars");
528
529  // Check interface's Ivar list against those in the implementation.
530  // names and types must match.
531  //
532  unsigned j = 0;
533  ObjCInterfaceDecl::ivar_iterator
534    IVI = IDecl->ivar_begin(), IVE = IDecl->ivar_end();
535  for (; numIvars > 0 && IVI != IVE; ++IVI) {
536    ObjCIvarDecl* ImplIvar = ivars[j++];
537    ObjCIvarDecl* ClsIvar = *IVI;
538    assert (ImplIvar && "missing implementation ivar");
539    assert (ClsIvar && "missing class ivar");
540    if (Context.getCanonicalType(ImplIvar->getType()) !=
541        Context.getCanonicalType(ClsIvar->getType())) {
542      Diag(ImplIvar->getLocation(), diag::err_conflicting_ivar_type,
543           ImplIvar->getIdentifier()->getName());
544      Diag(ClsIvar->getLocation(), diag::err_previous_definition,
545           ClsIvar->getIdentifier()->getName());
546    }
547    // TODO: Two mismatched (unequal width) Ivar bitfields should be diagnosed
548    // as error.
549    else if (ImplIvar->getIdentifier() != ClsIvar->getIdentifier()) {
550      Diag(ImplIvar->getLocation(), diag::err_conflicting_ivar_name,
551           ImplIvar->getIdentifier()->getName());
552      Diag(ClsIvar->getLocation(), diag::err_previous_definition,
553           ClsIvar->getIdentifier()->getName());
554      return;
555    }
556    --numIvars;
557  }
558
559  if (numIvars > 0)
560    Diag(ivars[j]->getLocation(), diag::err_inconsistant_ivar_count);
561  else if (IVI != IVE)
562    Diag((*IVI)->getLocation(), diag::err_inconsistant_ivar_count);
563}
564
565void Sema::WarnUndefinedMethod(SourceLocation ImpLoc, ObjCMethodDecl *method,
566                               bool &IncompleteImpl) {
567  if (!IncompleteImpl) {
568    Diag(ImpLoc, diag::warn_incomplete_impl);
569    IncompleteImpl = true;
570  }
571  Diag(ImpLoc, diag::warn_undef_method_impl, method->getSelector().getName());
572}
573
574/// FIXME: Type hierarchies in Objective-C can be deep. We could most
575/// likely improve the efficiency of selector lookups and type
576/// checking by associating with each protocol / interface / category
577/// the flattened instance tables. If we used an immutable set to keep
578/// the table then it wouldn't add significant memory cost and it
579/// would be handy for lookups.
580
581/// CheckProtocolMethodDefs - This routine checks unimplemented methods
582/// Declared in protocol, and those referenced by it.
583void Sema::CheckProtocolMethodDefs(SourceLocation ImpLoc,
584                                   ObjCProtocolDecl *PDecl,
585                                   bool& IncompleteImpl,
586                                   const llvm::DenseSet<Selector> &InsMap,
587                                   const llvm::DenseSet<Selector> &ClsMap,
588                                   ObjCInterfaceDecl *IDecl) {
589  ObjCInterfaceDecl *Super = IDecl->getSuperClass();
590
591  // If a method lookup fails locally we still need to look and see if
592  // the method was implemented by a base class or an inherited
593  // protocol. This lookup is slow, but occurs rarely in correct code
594  // and otherwise would terminate in a warning.
595
596  // check unimplemented instance methods.
597  for (ObjCProtocolDecl::instmeth_iterator I = PDecl->instmeth_begin(),
598       E = PDecl->instmeth_end(); I != E; ++I) {
599    ObjCMethodDecl *method = *I;
600    if (method->getImplementationControl() != ObjCMethodDecl::Optional &&
601        !InsMap.count(method->getSelector()) &&
602        (!Super || !Super->lookupInstanceMethod(method->getSelector())))
603      WarnUndefinedMethod(ImpLoc, method, IncompleteImpl);
604  }
605  // check unimplemented class methods
606  for (ObjCProtocolDecl::classmeth_iterator I = PDecl->classmeth_begin(),
607       E = PDecl->classmeth_end(); I != E; ++I) {
608    ObjCMethodDecl *method = *I;
609    if (method->getImplementationControl() != ObjCMethodDecl::Optional &&
610        !ClsMap.count(method->getSelector()) &&
611        (!Super || !Super->lookupClassMethod(method->getSelector())))
612      WarnUndefinedMethod(ImpLoc, method, IncompleteImpl);
613  }
614  // Check on this protocols's referenced protocols, recursively.
615  for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(),
616       E = PDecl->protocol_end(); PI != E; ++PI)
617    CheckProtocolMethodDefs(ImpLoc, *PI, IncompleteImpl, InsMap, ClsMap, IDecl);
618}
619
620void Sema::ImplMethodsVsClassMethods(ObjCImplementationDecl* IMPDecl,
621                                     ObjCInterfaceDecl* IDecl) {
622  llvm::DenseSet<Selector> InsMap;
623  // Check and see if instance methods in class interface have been
624  // implemented in the implementation class.
625  for (ObjCImplementationDecl::instmeth_iterator I = IMPDecl->instmeth_begin(),
626       E = IMPDecl->instmeth_end(); I != E; ++I)
627    InsMap.insert((*I)->getSelector());
628
629  bool IncompleteImpl = false;
630  for (ObjCInterfaceDecl::instmeth_iterator I = IDecl->instmeth_begin(),
631       E = IDecl->instmeth_end(); I != E; ++I)
632    if (!(*I)->isSynthesized() && !InsMap.count((*I)->getSelector()))
633      WarnUndefinedMethod(IMPDecl->getLocation(), *I, IncompleteImpl);
634
635  llvm::DenseSet<Selector> ClsMap;
636  // Check and see if class methods in class interface have been
637  // implemented in the implementation class.
638  for (ObjCImplementationDecl::classmeth_iterator I =IMPDecl->classmeth_begin(),
639       E = IMPDecl->classmeth_end(); I != E; ++I)
640    ClsMap.insert((*I)->getSelector());
641
642  for (ObjCInterfaceDecl::classmeth_iterator I = IDecl->classmeth_begin(),
643       E = IDecl->classmeth_end(); I != E; ++I)
644    if (!ClsMap.count((*I)->getSelector()))
645      WarnUndefinedMethod(IMPDecl->getLocation(), *I, IncompleteImpl);
646
647  // Check the protocol list for unimplemented methods in the @implementation
648  // class.
649  const ObjCList<ObjCProtocolDecl> &Protocols =
650    IDecl->getReferencedProtocols();
651  for (ObjCList<ObjCProtocolDecl>::iterator I = Protocols.begin(),
652       E = Protocols.end(); I != E; ++I)
653    CheckProtocolMethodDefs(IMPDecl->getLocation(), *I,
654                            IncompleteImpl, InsMap, ClsMap, IDecl);
655}
656
657/// ImplCategoryMethodsVsIntfMethods - Checks that methods declared in the
658/// category interface are implemented in the category @implementation.
659void Sema::ImplCategoryMethodsVsIntfMethods(ObjCCategoryImplDecl *CatImplDecl,
660                                            ObjCCategoryDecl *CatClassDecl) {
661  llvm::DenseSet<Selector> InsMap;
662  // Check and see if instance methods in category interface have been
663  // implemented in its implementation class.
664  for (ObjCCategoryImplDecl::instmeth_iterator I =CatImplDecl->instmeth_begin(),
665       E = CatImplDecl->instmeth_end(); I != E; ++I)
666    InsMap.insert((*I)->getSelector());
667
668  bool IncompleteImpl = false;
669  for (ObjCCategoryDecl::instmeth_iterator I = CatClassDecl->instmeth_begin(),
670       E = CatClassDecl->instmeth_end(); I != E; ++I)
671    if (!InsMap.count((*I)->getSelector()))
672      WarnUndefinedMethod(CatImplDecl->getLocation(), *I, IncompleteImpl);
673
674  llvm::DenseSet<Selector> ClsMap;
675  // Check and see if class methods in category interface have been
676  // implemented in its implementation class.
677  for (ObjCCategoryImplDecl::classmeth_iterator
678       I = CatImplDecl->classmeth_begin(), E = CatImplDecl->classmeth_end();
679       I != E; ++I)
680    ClsMap.insert((*I)->getSelector());
681
682  for (ObjCCategoryDecl::classmeth_iterator I = CatClassDecl->classmeth_begin(),
683       E = CatClassDecl->classmeth_end(); I != E; ++I)
684    if (!ClsMap.count((*I)->getSelector()))
685      WarnUndefinedMethod(CatImplDecl->getLocation(), *I, IncompleteImpl);
686
687  // Check the protocol list for unimplemented methods in the @implementation
688  // class.
689  for (ObjCCategoryDecl::protocol_iterator PI = CatClassDecl->protocol_begin(),
690       E = CatClassDecl->protocol_end(); PI != E; ++PI)
691    CheckProtocolMethodDefs(CatImplDecl->getLocation(), *PI, IncompleteImpl,
692                            InsMap, ClsMap, CatClassDecl->getClassInterface());
693}
694
695/// ActOnForwardClassDeclaration -
696Action::DeclTy *
697Sema::ActOnForwardClassDeclaration(SourceLocation AtClassLoc,
698                                   IdentifierInfo **IdentList, unsigned NumElts)
699{
700  llvm::SmallVector<ObjCInterfaceDecl*, 32> Interfaces;
701
702  for (unsigned i = 0; i != NumElts; ++i) {
703    // Check for another declaration kind with the same name.
704    Decl *PrevDecl = LookupDecl(IdentList[i], Decl::IDNS_Ordinary, TUScope);
705    if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) {
706      // GCC apparently allows the following idiom:
707      //
708      // typedef NSObject < XCElementTogglerP > XCElementToggler;
709      // @class XCElementToggler;
710      //
711      // FIXME: Make an extension?
712      TypedefDecl *TDD = dyn_cast<TypedefDecl>(PrevDecl);
713      if (!TDD || !isa<ObjCInterfaceType>(TDD->getUnderlyingType())) {
714        Diag(AtClassLoc, diag::err_redefinition_different_kind,
715             IdentList[i]->getName());
716        Diag(PrevDecl->getLocation(), diag::err_previous_definition);
717      }
718    }
719    ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl);
720    if (!IDecl) {  // Not already seen?  Make a forward decl.
721      IDecl = ObjCInterfaceDecl::Create(Context, AtClassLoc, IdentList[i],
722                                        SourceLocation(), true);
723      ObjCInterfaceDecls[IdentList[i]] = IDecl;
724
725      // Remember that this needs to be removed when the scope is popped.
726      TUScope->AddDecl(IDecl);
727    }
728
729    Interfaces.push_back(IDecl);
730  }
731
732  return ObjCClassDecl::Create(Context, AtClassLoc,
733                               &Interfaces[0], Interfaces.size());
734}
735
736
737/// MatchTwoMethodDeclarations - Checks that two methods have matching type and
738/// returns true, or false, accordingly.
739/// TODO: Handle protocol list; such as id<p1,p2> in type comparisons
740bool Sema::MatchTwoMethodDeclarations(const ObjCMethodDecl *Method,
741                                      const ObjCMethodDecl *PrevMethod) {
742  if (Context.getCanonicalType(Method->getResultType()) !=
743      Context.getCanonicalType(PrevMethod->getResultType()))
744    return false;
745  for (unsigned i = 0, e = Method->getNumParams(); i != e; ++i) {
746    ParmVarDecl *ParamDecl = Method->getParamDecl(i);
747    ParmVarDecl *PrevParamDecl = PrevMethod->getParamDecl(i);
748    if (Context.getCanonicalType(ParamDecl->getType()) !=
749        Context.getCanonicalType(PrevParamDecl->getType()))
750      return false;
751  }
752  return true;
753}
754
755void Sema::AddInstanceMethodToGlobalPool(ObjCMethodDecl *Method) {
756  ObjCMethodList &FirstMethod = InstanceMethodPool[Method->getSelector()];
757  if (!FirstMethod.Method) {
758    // Haven't seen a method with this selector name yet - add it.
759    FirstMethod.Method = Method;
760    FirstMethod.Next = 0;
761  } else {
762    // We've seen a method with this name, now check the type signature(s).
763    bool match = MatchTwoMethodDeclarations(Method, FirstMethod.Method);
764
765    for (ObjCMethodList *Next = FirstMethod.Next; !match && Next;
766         Next = Next->Next)
767      match = MatchTwoMethodDeclarations(Method, Next->Method);
768
769    if (!match) {
770      // We have a new signature for an existing method - add it.
771      // This is extremely rare. Only 1% of Cocoa selectors are "overloaded".
772      struct ObjCMethodList *OMI = new ObjCMethodList(Method, FirstMethod.Next);
773      FirstMethod.Next = OMI;
774    }
775  }
776}
777
778void Sema::AddFactoryMethodToGlobalPool(ObjCMethodDecl *Method) {
779  ObjCMethodList &FirstMethod = FactoryMethodPool[Method->getSelector()];
780  if (!FirstMethod.Method) {
781    // Haven't seen a method with this selector name yet - add it.
782    FirstMethod.Method = Method;
783    FirstMethod.Next = 0;
784  } else {
785    // We've seen a method with this name, now check the type signature(s).
786    bool match = MatchTwoMethodDeclarations(Method, FirstMethod.Method);
787
788    for (ObjCMethodList *Next = FirstMethod.Next; !match && Next;
789         Next = Next->Next)
790      match = MatchTwoMethodDeclarations(Method, Next->Method);
791
792    if (!match) {
793      // We have a new signature for an existing method - add it.
794      // This is extremely rare. Only 1% of Cocoa selectors are "overloaded".
795      struct ObjCMethodList *OMI = new ObjCMethodList(Method, FirstMethod.Next);
796      FirstMethod.Next = OMI;
797    }
798  }
799}
800
801// Note: For class/category implemenations, allMethods/allProperties is
802// always null.
803void Sema::ActOnAtEnd(SourceLocation AtEndLoc, DeclTy *classDecl,
804                      DeclTy **allMethods, unsigned allNum,
805                      DeclTy **allProperties, unsigned pNum) {
806  Decl *ClassDecl = static_cast<Decl *>(classDecl);
807
808  // FIXME: If we don't have a ClassDecl, we have an error. We should consider
809  // always passing in a decl. If the decl has an error, isInvalidDecl()
810  // should be true.
811  if (!ClassDecl)
812    return;
813
814  llvm::SmallVector<ObjCMethodDecl*, 32> insMethods;
815  llvm::SmallVector<ObjCMethodDecl*, 16> clsMethods;
816
817  llvm::DenseMap<Selector, const ObjCMethodDecl*> InsMap;
818  llvm::DenseMap<Selector, const ObjCMethodDecl*> ClsMap;
819
820  bool isInterfaceDeclKind =
821        isa<ObjCInterfaceDecl>(ClassDecl) || isa<ObjCCategoryDecl>(ClassDecl)
822         || isa<ObjCProtocolDecl>(ClassDecl);
823  bool checkIdenticalMethods = isa<ObjCImplementationDecl>(ClassDecl);
824
825  if (pNum != 0) {
826    if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl))
827      IDecl->addProperties((ObjCPropertyDecl**)allProperties, pNum);
828    else if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl))
829      CDecl->addProperties((ObjCPropertyDecl**)allProperties, pNum);
830    else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(ClassDecl))
831      PDecl->addProperties((ObjCPropertyDecl**)allProperties, pNum);
832    else
833      assert(false && "ActOnAtEnd - property declaration misplaced");
834  }
835
836  for (unsigned i = 0; i < allNum; i++ ) {
837    ObjCMethodDecl *Method =
838      cast_or_null<ObjCMethodDecl>(static_cast<Decl*>(allMethods[i]));
839
840    if (!Method) continue;  // Already issued a diagnostic.
841    if (Method->isInstance()) {
842      /// Check for instance method of the same name with incompatible types
843      const ObjCMethodDecl *&PrevMethod = InsMap[Method->getSelector()];
844      bool match = PrevMethod ? MatchTwoMethodDeclarations(Method, PrevMethod)
845                              : false;
846      if (isInterfaceDeclKind && PrevMethod && !match
847          || checkIdenticalMethods && match) {
848          Diag(Method->getLocation(), diag::error_duplicate_method_decl,
849               Method->getSelector().getName());
850          Diag(PrevMethod->getLocation(), diag::err_previous_declaration);
851      } else {
852        insMethods.push_back(Method);
853        InsMap[Method->getSelector()] = Method;
854        /// The following allows us to typecheck messages to "id".
855        AddInstanceMethodToGlobalPool(Method);
856      }
857    }
858    else {
859      /// Check for class method of the same name with incompatible types
860      const ObjCMethodDecl *&PrevMethod = ClsMap[Method->getSelector()];
861      bool match = PrevMethod ? MatchTwoMethodDeclarations(Method, PrevMethod)
862                              : false;
863      if (isInterfaceDeclKind && PrevMethod && !match
864          || checkIdenticalMethods && match) {
865        Diag(Method->getLocation(), diag::error_duplicate_method_decl,
866             Method->getSelector().getName());
867        Diag(PrevMethod->getLocation(), diag::err_previous_declaration);
868      } else {
869        clsMethods.push_back(Method);
870        ClsMap[Method->getSelector()] = Method;
871        /// The following allows us to typecheck messages to "Class".
872        AddFactoryMethodToGlobalPool(Method);
873      }
874    }
875  }
876
877  if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) {
878    // Compares properties declared in this class to those of its
879    // super class.
880    ComparePropertiesInBaseAndSuper(I);
881    MergeProtocolPropertiesIntoClass(I, I);
882    for (ObjCInterfaceDecl::classprop_iterator i = I->classprop_begin(),
883           e = I->classprop_end(); i != e; ++i)
884      I->addPropertyMethods(Context, *i, insMethods);
885    I->addMethods(&insMethods[0], insMethods.size(),
886                  &clsMethods[0], clsMethods.size(), AtEndLoc);
887
888  } else if (ObjCProtocolDecl *P = dyn_cast<ObjCProtocolDecl>(ClassDecl)) {
889    for (ObjCProtocolDecl::classprop_iterator i = P->classprop_begin(),
890           e = P->classprop_end(); i != e; ++i)
891      P->addPropertyMethods(Context, *i, insMethods);
892    P->addMethods(&insMethods[0], insMethods.size(),
893                  &clsMethods[0], clsMethods.size(), AtEndLoc);
894  }
895  else if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(ClassDecl)) {
896    // FIXME: Need to compare properties to those in interface?
897
898    // FIXME: If we merge properties into class we should probably
899    // merge them into category as well?
900    for (ObjCCategoryDecl::classprop_iterator i = C->classprop_begin(),
901           e = C->classprop_end(); i != e; ++i)
902      C->addPropertyMethods(Context, *i, insMethods);
903    C->addMethods(&insMethods[0], insMethods.size(),
904                  &clsMethods[0], clsMethods.size(), AtEndLoc);
905  }
906  else if (ObjCImplementationDecl *IC =
907                dyn_cast<ObjCImplementationDecl>(ClassDecl)) {
908    IC->setLocEnd(AtEndLoc);
909    if (ObjCInterfaceDecl* IDecl = getObjCInterfaceDecl(IC->getIdentifier()))
910      ImplMethodsVsClassMethods(IC, IDecl);
911  } else {
912    ObjCCategoryImplDecl* CatImplClass = cast<ObjCCategoryImplDecl>(ClassDecl);
913    CatImplClass->setLocEnd(AtEndLoc);
914    ObjCInterfaceDecl* IDecl = CatImplClass->getClassInterface();
915    // Find category interface decl and then check that all methods declared
916    // in this interface are implemented in the category @implementation.
917    if (IDecl) {
918      for (ObjCCategoryDecl *Categories = IDecl->getCategoryList();
919           Categories; Categories = Categories->getNextClassCategory()) {
920        if (Categories->getIdentifier() == CatImplClass->getIdentifier()) {
921          ImplCategoryMethodsVsIntfMethods(CatImplClass, Categories);
922          break;
923        }
924      }
925    }
926  }
927}
928
929
930/// CvtQTToAstBitMask - utility routine to produce an AST bitmask for
931/// objective-c's type qualifier from the parser version of the same info.
932static Decl::ObjCDeclQualifier
933CvtQTToAstBitMask(ObjCDeclSpec::ObjCDeclQualifier PQTVal) {
934  Decl::ObjCDeclQualifier ret = Decl::OBJC_TQ_None;
935  if (PQTVal & ObjCDeclSpec::DQ_In)
936    ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_In);
937  if (PQTVal & ObjCDeclSpec::DQ_Inout)
938    ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Inout);
939  if (PQTVal & ObjCDeclSpec::DQ_Out)
940    ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Out);
941  if (PQTVal & ObjCDeclSpec::DQ_Bycopy)
942    ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Bycopy);
943  if (PQTVal & ObjCDeclSpec::DQ_Byref)
944    ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Byref);
945  if (PQTVal & ObjCDeclSpec::DQ_Oneway)
946    ret = (Decl::ObjCDeclQualifier)(ret | Decl::OBJC_TQ_Oneway);
947
948  return ret;
949}
950
951Sema::DeclTy *Sema::ActOnMethodDeclaration(
952    SourceLocation MethodLoc, SourceLocation EndLoc,
953    tok::TokenKind MethodType, DeclTy *classDecl,
954    ObjCDeclSpec &ReturnQT, TypeTy *ReturnType,
955    Selector Sel,
956    // optional arguments. The number of types/arguments is obtained
957    // from the Sel.getNumArgs().
958    ObjCDeclSpec *ArgQT, TypeTy **ArgTypes, IdentifierInfo **ArgNames,
959    AttributeList *AttrList, tok::ObjCKeywordKind MethodDeclKind,
960    bool isVariadic) {
961  Decl *ClassDecl = static_cast<Decl*>(classDecl);
962
963  // Make sure we can establish a context for the method.
964  if (!ClassDecl) {
965    Diag(MethodLoc, diag::error_missing_method_context);
966    return 0;
967  }
968  QualType resultDeclType;
969
970  if (ReturnType)
971    resultDeclType = QualType::getFromOpaquePtr(ReturnType);
972  else // get the type for "id".
973    resultDeclType = Context.getObjCIdType();
974
975  ObjCMethodDecl* ObjCMethod =
976    ObjCMethodDecl::Create(Context, MethodLoc, EndLoc, Sel, resultDeclType,
977                           ClassDecl,
978                           MethodType == tok::minus, isVariadic,
979                           false,
980                           MethodDeclKind == tok::objc_optional ?
981                           ObjCMethodDecl::Optional :
982                           ObjCMethodDecl::Required);
983
984  llvm::SmallVector<ParmVarDecl*, 16> Params;
985
986  for (unsigned i = 0; i < Sel.getNumArgs(); i++) {
987    // FIXME: arg->AttrList must be stored too!
988    QualType argType;
989
990    if (ArgTypes[i])
991      argType = QualType::getFromOpaquePtr(ArgTypes[i]);
992    else
993      argType = Context.getObjCIdType();
994    ParmVarDecl* Param = ParmVarDecl::Create(Context, ObjCMethod,
995                                             SourceLocation(/*FIXME*/),
996                                             ArgNames[i], argType,
997                                             VarDecl::None, 0, 0);
998    Param->setObjCDeclQualifier(
999      CvtQTToAstBitMask(ArgQT[i].getObjCDeclQualifier()));
1000    Params.push_back(Param);
1001  }
1002
1003  ObjCMethod->setMethodParams(&Params[0], Sel.getNumArgs());
1004  ObjCMethod->setObjCDeclQualifier(
1005    CvtQTToAstBitMask(ReturnQT.getObjCDeclQualifier()));
1006  const ObjCMethodDecl *PrevMethod = 0;
1007
1008  if (AttrList)
1009    ProcessDeclAttributeList(ObjCMethod, AttrList);
1010
1011  // For implementations (which can be very "coarse grain"), we add the
1012  // method now. This allows the AST to implement lookup methods that work
1013  // incrementally (without waiting until we parse the @end). It also allows
1014  // us to flag multiple declaration errors as they occur.
1015  if (ObjCImplementationDecl *ImpDecl =
1016        dyn_cast<ObjCImplementationDecl>(ClassDecl)) {
1017    if (MethodType == tok::minus) {
1018      PrevMethod = ImpDecl->getInstanceMethod(Sel);
1019      ImpDecl->addInstanceMethod(ObjCMethod);
1020    } else {
1021      PrevMethod = ImpDecl->getClassMethod(Sel);
1022      ImpDecl->addClassMethod(ObjCMethod);
1023    }
1024  }
1025  else if (ObjCCategoryImplDecl *CatImpDecl =
1026            dyn_cast<ObjCCategoryImplDecl>(ClassDecl)) {
1027    if (MethodType == tok::minus) {
1028      PrevMethod = CatImpDecl->getInstanceMethod(Sel);
1029      CatImpDecl->addInstanceMethod(ObjCMethod);
1030    } else {
1031      PrevMethod = CatImpDecl->getClassMethod(Sel);
1032      CatImpDecl->addClassMethod(ObjCMethod);
1033    }
1034  }
1035  if (PrevMethod) {
1036    // You can never have two method definitions with the same name.
1037    Diag(ObjCMethod->getLocation(), diag::error_duplicate_method_decl,
1038        ObjCMethod->getSelector().getName());
1039    Diag(PrevMethod->getLocation(), diag::err_previous_declaration);
1040  }
1041  return ObjCMethod;
1042}
1043
1044void Sema::CheckObjCPropertyAttributes(QualType PropertyTy,
1045                                       SourceLocation Loc,
1046                                       unsigned &Attributes) {
1047  // FIXME: Improve the reported location.
1048
1049  // readonly and readwrite conflict.
1050  if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) &&
1051      (Attributes & ObjCDeclSpec::DQ_PR_readwrite)) {
1052    Diag(Loc, diag::err_objc_property_attr_mutually_exclusive,
1053         "readonly", "readwrite");
1054    Attributes ^= ObjCDeclSpec::DQ_PR_readonly;
1055  }
1056
1057  // Check for copy or retain on non-object types.
1058  if ((Attributes & (ObjCDeclSpec::DQ_PR_copy | ObjCDeclSpec::DQ_PR_retain)) &&
1059      !Context.isObjCObjectPointerType(PropertyTy)) {
1060    Diag(Loc, diag::err_objc_property_requires_object,
1061         Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain");
1062    Attributes &= ~(ObjCDeclSpec::DQ_PR_copy | ObjCDeclSpec::DQ_PR_retain);
1063  }
1064
1065  // Check for more than one of { assign, copy, retain }.
1066  if (Attributes & ObjCDeclSpec::DQ_PR_assign) {
1067    if (Attributes & ObjCDeclSpec::DQ_PR_copy) {
1068      Diag(Loc, diag::err_objc_property_attr_mutually_exclusive,
1069           "assign", "copy");
1070      Attributes ^= ObjCDeclSpec::DQ_PR_copy;
1071    }
1072    if (Attributes & ObjCDeclSpec::DQ_PR_retain) {
1073      Diag(Loc, diag::err_objc_property_attr_mutually_exclusive,
1074           "assign", "retain");
1075      Attributes ^= ObjCDeclSpec::DQ_PR_retain;
1076    }
1077  } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) {
1078    if (Attributes & ObjCDeclSpec::DQ_PR_retain) {
1079      Diag(Loc, diag::err_objc_property_attr_mutually_exclusive,
1080           "copy", "retain");
1081      Attributes ^= ObjCDeclSpec::DQ_PR_retain;
1082    }
1083  }
1084
1085  // Warn if user supplied no assignment attribute, property is
1086  // readwrite, and this is an object type.
1087  if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy |
1088                      ObjCDeclSpec::DQ_PR_retain)) &&
1089      !(Attributes & ObjCDeclSpec::DQ_PR_readonly) &&
1090      Context.isObjCObjectPointerType(PropertyTy)) {
1091    // Skip this warning in gc-only mode.
1092    if (getLangOptions().getGCMode() != LangOptions::GCOnly)
1093      Diag(Loc, diag::warn_objc_property_no_assignment_attribute);
1094
1095    // If non-gc code warn that this is likely inappropriate.
1096    if (getLangOptions().getGCMode() == LangOptions::NonGC)
1097      Diag(Loc, diag::warn_objc_property_default_assign_on_object);
1098
1099    // FIXME: Implement warning dependent on NSCopying being
1100    // implemented. See also:
1101    // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496>
1102    // (please trim this list while you are at it).
1103  }
1104}
1105
1106Sema::DeclTy *Sema::ActOnProperty(Scope *S, SourceLocation AtLoc,
1107                                  FieldDeclarator &FD,
1108                                  ObjCDeclSpec &ODS,
1109                                  Selector GetterSel,
1110                                  Selector SetterSel,
1111                                  tok::ObjCKeywordKind MethodImplKind) {
1112  QualType T = GetTypeForDeclarator(FD.D, S);
1113  unsigned Attributes = ODS.getPropertyAttributes();
1114
1115  // May modify Attributes.
1116  CheckObjCPropertyAttributes(T, AtLoc, Attributes);
1117
1118  ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, AtLoc,
1119                                                     FD.D.getIdentifier(), T);
1120  // Regardless of setter/getter attribute, we save the default getter/setter
1121  // selector names in anticipation of declaration of setter/getter methods.
1122  PDecl->setGetterName(GetterSel);
1123  PDecl->setSetterName(SetterSel);
1124
1125  if (Attributes & ObjCDeclSpec::DQ_PR_readonly)
1126    PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly);
1127
1128  if (Attributes & ObjCDeclSpec::DQ_PR_getter)
1129    PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter);
1130
1131  if (Attributes & ObjCDeclSpec::DQ_PR_setter)
1132    PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter);
1133
1134  if (Attributes & ObjCDeclSpec::DQ_PR_assign)
1135    PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign);
1136
1137  if (Attributes & ObjCDeclSpec::DQ_PR_readwrite)
1138    PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite);
1139
1140  if (Attributes & ObjCDeclSpec::DQ_PR_retain)
1141    PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain);
1142
1143  if (Attributes & ObjCDeclSpec::DQ_PR_copy)
1144    PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy);
1145
1146  if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic)
1147    PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic);
1148
1149  if (MethodImplKind == tok::objc_required)
1150    PDecl->setPropertyImplementation(ObjCPropertyDecl::Required);
1151  else if (MethodImplKind == tok::objc_optional)
1152    PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional);
1153
1154  return PDecl;
1155}
1156
1157/// ActOnPropertyImplDecl - This routine performs semantic checks and
1158/// builds the AST node for a property implementation declaration; declared
1159/// as @synthesize or @dynamic.
1160///
1161Sema::DeclTy *Sema::ActOnPropertyImplDecl(SourceLocation AtLoc,
1162                                          SourceLocation PropertyLoc,
1163                                          bool Synthesize,
1164                                          DeclTy *ClassCatImpDecl,
1165                                          IdentifierInfo *PropertyId,
1166                                          IdentifierInfo *PropertyIvar) {
1167  Decl *ClassImpDecl = static_cast<Decl*>(ClassCatImpDecl);
1168  // Make sure we have a context for the property implementation declaration.
1169  if (!ClassImpDecl) {
1170    Diag(AtLoc, diag::error_missing_property_context);
1171    return 0;
1172  }
1173  ObjCPropertyDecl *property = 0;
1174  ObjCInterfaceDecl* IDecl = 0;
1175  // Find the class or category class where this property must have
1176  // a declaration.
1177  ObjCImplementationDecl *IC = 0;
1178  ObjCCategoryImplDecl* CatImplClass = 0;
1179  if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) {
1180    IDecl = getObjCInterfaceDecl(IC->getIdentifier());
1181    // We always synthesize an interface for an implementation
1182    // without an interface decl. So, IDecl is always non-zero.
1183    assert(IDecl &&
1184           "ActOnPropertyImplDecl - @implementation without @interface");
1185
1186    // Look for this property declaration in the @implementation's @interface
1187    property = IDecl->FindPropertyDeclaration(PropertyId);
1188    if (!property) {
1189      Diag(PropertyLoc, diag::error_bad_property_decl, IDecl->getName());
1190      return 0;
1191    }
1192  }
1193  else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) {
1194    if (Synthesize) {
1195      Diag(AtLoc, diag::error_synthesize_category_decl);
1196      return 0;
1197    }
1198    IDecl = CatImplClass->getClassInterface();
1199    if (!IDecl) {
1200      Diag(AtLoc, diag::error_missing_property_interface);
1201      return 0;
1202    }
1203    ObjCCategoryDecl *Category =
1204      IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier());
1205
1206    // If category for this implementation not found, it is an error which
1207    // has already been reported eralier.
1208    if (!Category)
1209      return 0;
1210    // Look for this property declaration in @implementation's category
1211    property = Category->FindPropertyDeclaration(PropertyId);
1212    if (!property) {
1213      Diag(PropertyLoc, diag::error_bad_category_property_decl,
1214           Category->getName());
1215      return 0;
1216    }
1217  }
1218  else {
1219    Diag(AtLoc, diag::error_bad_property_context);
1220    return 0;
1221  }
1222  ObjCIvarDecl *Ivar = 0;
1223  // Check that we have a valid, previously declared ivar for @synthesize
1224  if (Synthesize) {
1225    // @synthesize
1226    if (!PropertyIvar)
1227      PropertyIvar = PropertyId;
1228    // Check that this is a previously declared 'ivar' in 'IDecl' interface
1229    Ivar = IDecl->FindIvarDeclaration(PropertyIvar);
1230    if (!Ivar) {
1231      Diag(PropertyLoc, diag::error_missing_property_ivar_decl,
1232           PropertyId->getName());
1233      return 0;
1234    }
1235    // Check that type of property and its ivar match.
1236    if (Context.getCanonicalType(Ivar->getType()) !=
1237        Context.getCanonicalType(property->getType())) {
1238      Diag(PropertyLoc, diag::error_property_ivar_type, property->getName(),
1239           Ivar->getName());
1240      return 0;
1241    }
1242
1243  } else if (PropertyIvar) {
1244    // @dynamic
1245    Diag(PropertyLoc, diag::error_dynamic_property_ivar_decl);
1246    return 0;
1247  }
1248  assert (property && "ActOnPropertyImplDecl - property declaration missing");
1249  ObjCPropertyImplDecl *PIDecl =
1250    ObjCPropertyImplDecl::Create(Context, AtLoc, PropertyLoc, property,
1251                                 (Synthesize ?
1252                                  ObjCPropertyImplDecl::Synthesize
1253                                  : ObjCPropertyImplDecl::Dynamic),
1254                                 Ivar);
1255  if (IC)
1256    IC->addPropertyImplementation(PIDecl);
1257  else
1258    CatImplClass->addPropertyImplementation(PIDecl);
1259
1260  return PIDecl;
1261}
1262