SemaDeclObjC.cpp revision 75cf3e86d33ce810c12084126385371b335c30ba
1//===--- SemaDeclObjC.cpp - Semantic Analysis for ObjC Declarations -------===// 2// 3// The LLVM Compiler Infrastructure 4// 5// This file is distributed under the University of Illinois Open Source 6// License. See LICENSE.TXT for details. 7// 8//===----------------------------------------------------------------------===// 9// 10// This file implements semantic analysis for Objective C declarations. 11// 12//===----------------------------------------------------------------------===// 13 14#include "clang/Sema/SemaInternal.h" 15#include "clang/Sema/Lookup.h" 16#include "clang/Sema/ExternalSemaSource.h" 17#include "clang/Sema/Scope.h" 18#include "clang/Sema/ScopeInfo.h" 19#include "clang/AST/ASTConsumer.h" 20#include "clang/AST/Expr.h" 21#include "clang/AST/ExprObjC.h" 22#include "clang/AST/ASTContext.h" 23#include "clang/AST/DeclObjC.h" 24#include "clang/Basic/SourceManager.h" 25#include "clang/Sema/DeclSpec.h" 26#include "llvm/ADT/DenseSet.h" 27 28using namespace clang; 29 30/// Check whether the given method, which must be in the 'init' 31/// family, is a valid member of that family. 32/// 33/// \param receiverTypeIfCall - if null, check this as if declaring it; 34/// if non-null, check this as if making a call to it with the given 35/// receiver type 36/// 37/// \return true to indicate that there was an error and appropriate 38/// actions were taken 39bool Sema::checkInitMethod(ObjCMethodDecl *method, 40 QualType receiverTypeIfCall) { 41 if (method->isInvalidDecl()) return true; 42 43 // This castAs is safe: methods that don't return an object 44 // pointer won't be inferred as inits and will reject an explicit 45 // objc_method_family(init). 46 47 // We ignore protocols here. Should we? What about Class? 48 49 const ObjCObjectType *result = method->getResultType() 50 ->castAs<ObjCObjectPointerType>()->getObjectType(); 51 52 if (result->isObjCId()) { 53 return false; 54 } else if (result->isObjCClass()) { 55 // fall through: always an error 56 } else { 57 ObjCInterfaceDecl *resultClass = result->getInterface(); 58 assert(resultClass && "unexpected object type!"); 59 60 // It's okay for the result type to still be a forward declaration 61 // if we're checking an interface declaration. 62 if (resultClass->isForwardDecl()) { 63 if (receiverTypeIfCall.isNull() && 64 !isa<ObjCImplementationDecl>(method->getDeclContext())) 65 return false; 66 67 // Otherwise, we try to compare class types. 68 } else { 69 // If this method was declared in a protocol, we can't check 70 // anything unless we have a receiver type that's an interface. 71 const ObjCInterfaceDecl *receiverClass = 0; 72 if (isa<ObjCProtocolDecl>(method->getDeclContext())) { 73 if (receiverTypeIfCall.isNull()) 74 return false; 75 76 receiverClass = receiverTypeIfCall->castAs<ObjCObjectPointerType>() 77 ->getInterfaceDecl(); 78 79 // This can be null for calls to e.g. id<Foo>. 80 if (!receiverClass) return false; 81 } else { 82 receiverClass = method->getClassInterface(); 83 assert(receiverClass && "method not associated with a class!"); 84 } 85 86 // If either class is a subclass of the other, it's fine. 87 if (receiverClass->isSuperClassOf(resultClass) || 88 resultClass->isSuperClassOf(receiverClass)) 89 return false; 90 } 91 } 92 93 SourceLocation loc = method->getLocation(); 94 95 // If we're in a system header, and this is not a call, just make 96 // the method unusable. 97 if (receiverTypeIfCall.isNull() && getSourceManager().isInSystemHeader(loc)) { 98 method->addAttr(new (Context) UnavailableAttr(loc, Context, 99 "init method returns a type unrelated to its receiver type")); 100 return true; 101 } 102 103 // Otherwise, it's an error. 104 Diag(loc, diag::err_arc_init_method_unrelated_result_type); 105 method->setInvalidDecl(); 106 return true; 107} 108 109bool Sema::CheckObjCMethodOverride(ObjCMethodDecl *NewMethod, 110 const ObjCMethodDecl *Overridden, 111 bool IsImplementation) { 112 if (Overridden->hasRelatedResultType() && 113 !NewMethod->hasRelatedResultType()) { 114 // This can only happen when the method follows a naming convention that 115 // implies a related result type, and the original (overridden) method has 116 // a suitable return type, but the new (overriding) method does not have 117 // a suitable return type. 118 QualType ResultType = NewMethod->getResultType(); 119 SourceRange ResultTypeRange; 120 if (const TypeSourceInfo *ResultTypeInfo 121 = NewMethod->getResultTypeSourceInfo()) 122 ResultTypeRange = ResultTypeInfo->getTypeLoc().getSourceRange(); 123 124 // Figure out which class this method is part of, if any. 125 ObjCInterfaceDecl *CurrentClass 126 = dyn_cast<ObjCInterfaceDecl>(NewMethod->getDeclContext()); 127 if (!CurrentClass) { 128 DeclContext *DC = NewMethod->getDeclContext(); 129 if (ObjCCategoryDecl *Cat = dyn_cast<ObjCCategoryDecl>(DC)) 130 CurrentClass = Cat->getClassInterface(); 131 else if (ObjCImplDecl *Impl = dyn_cast<ObjCImplDecl>(DC)) 132 CurrentClass = Impl->getClassInterface(); 133 else if (ObjCCategoryImplDecl *CatImpl 134 = dyn_cast<ObjCCategoryImplDecl>(DC)) 135 CurrentClass = CatImpl->getClassInterface(); 136 } 137 138 if (CurrentClass) { 139 Diag(NewMethod->getLocation(), 140 diag::warn_related_result_type_compatibility_class) 141 << Context.getObjCInterfaceType(CurrentClass) 142 << ResultType 143 << ResultTypeRange; 144 } else { 145 Diag(NewMethod->getLocation(), 146 diag::warn_related_result_type_compatibility_protocol) 147 << ResultType 148 << ResultTypeRange; 149 } 150 151 Diag(Overridden->getLocation(), diag::note_related_result_type_overridden) 152 << Overridden->getMethodFamily(); 153 } 154 155 return false; 156} 157 158/// \brief Check a method declaration for compatibility with the Objective-C 159/// ARC conventions. 160static bool CheckARCMethodDecl(Sema &S, ObjCMethodDecl *method) { 161 ObjCMethodFamily family = method->getMethodFamily(); 162 switch (family) { 163 case OMF_None: 164 case OMF_dealloc: 165 case OMF_retain: 166 case OMF_release: 167 case OMF_autorelease: 168 case OMF_retainCount: 169 case OMF_self: 170 case OMF_performSelector: 171 return false; 172 173 case OMF_init: 174 // If the method doesn't obey the init rules, don't bother annotating it. 175 if (S.checkInitMethod(method, QualType())) 176 return true; 177 178 method->addAttr(new (S.Context) NSConsumesSelfAttr(SourceLocation(), 179 S.Context)); 180 181 // Don't add a second copy of this attribute, but otherwise don't 182 // let it be suppressed. 183 if (method->hasAttr<NSReturnsRetainedAttr>()) 184 return false; 185 break; 186 187 case OMF_alloc: 188 case OMF_copy: 189 case OMF_mutableCopy: 190 case OMF_new: 191 if (method->hasAttr<NSReturnsRetainedAttr>() || 192 method->hasAttr<NSReturnsNotRetainedAttr>() || 193 method->hasAttr<NSReturnsAutoreleasedAttr>()) 194 return false; 195 break; 196 } 197 198 method->addAttr(new (S.Context) NSReturnsRetainedAttr(SourceLocation(), 199 S.Context)); 200 return false; 201} 202 203static void DiagnoseObjCImplementedDeprecations(Sema &S, 204 NamedDecl *ND, 205 SourceLocation ImplLoc, 206 int select) { 207 if (ND && ND->isDeprecated()) { 208 S.Diag(ImplLoc, diag::warn_deprecated_def) << select; 209 if (select == 0) 210 S.Diag(ND->getLocation(), diag::note_method_declared_at); 211 else 212 S.Diag(ND->getLocation(), diag::note_previous_decl) << "class"; 213 } 214} 215 216/// ActOnStartOfObjCMethodDef - This routine sets up parameters; invisible 217/// and user declared, in the method definition's AST. 218void Sema::ActOnStartOfObjCMethodDef(Scope *FnBodyScope, Decl *D) { 219 assert(getCurMethodDecl() == 0 && "Method parsing confused"); 220 ObjCMethodDecl *MDecl = dyn_cast_or_null<ObjCMethodDecl>(D); 221 222 // If we don't have a valid method decl, simply return. 223 if (!MDecl) 224 return; 225 226 // Allow the rest of sema to find private method decl implementations. 227 if (MDecl->isInstanceMethod()) 228 AddInstanceMethodToGlobalPool(MDecl, true); 229 else 230 AddFactoryMethodToGlobalPool(MDecl, true); 231 232 // Allow all of Sema to see that we are entering a method definition. 233 PushDeclContext(FnBodyScope, MDecl); 234 PushFunctionScope(); 235 236 // Create Decl objects for each parameter, entrring them in the scope for 237 // binding to their use. 238 239 // Insert the invisible arguments, self and _cmd! 240 MDecl->createImplicitParams(Context, MDecl->getClassInterface()); 241 242 PushOnScopeChains(MDecl->getSelfDecl(), FnBodyScope); 243 PushOnScopeChains(MDecl->getCmdDecl(), FnBodyScope); 244 245 // Introduce all of the other parameters into this scope. 246 for (ObjCMethodDecl::param_iterator PI = MDecl->param_begin(), 247 E = MDecl->param_end(); PI != E; ++PI) { 248 ParmVarDecl *Param = (*PI); 249 if (!Param->isInvalidDecl() && 250 RequireCompleteType(Param->getLocation(), Param->getType(), 251 diag::err_typecheck_decl_incomplete_type)) 252 Param->setInvalidDecl(); 253 if ((*PI)->getIdentifier()) 254 PushOnScopeChains(*PI, FnBodyScope); 255 } 256 257 // In ARC, disallow definition of retain/release/autorelease/retainCount 258 if (getLangOptions().ObjCAutoRefCount) { 259 switch (MDecl->getMethodFamily()) { 260 case OMF_retain: 261 case OMF_retainCount: 262 case OMF_release: 263 case OMF_autorelease: 264 Diag(MDecl->getLocation(), diag::err_arc_illegal_method_def) 265 << MDecl->getSelector(); 266 break; 267 268 case OMF_None: 269 case OMF_dealloc: 270 case OMF_alloc: 271 case OMF_init: 272 case OMF_mutableCopy: 273 case OMF_copy: 274 case OMF_new: 275 case OMF_self: 276 case OMF_performSelector: 277 break; 278 } 279 } 280 281 // Warn on implementating deprecated methods under 282 // -Wdeprecated-implementations flag. 283 if (ObjCInterfaceDecl *IC = MDecl->getClassInterface()) 284 if (ObjCMethodDecl *IMD = 285 IC->lookupMethod(MDecl->getSelector(), MDecl->isInstanceMethod())) 286 DiagnoseObjCImplementedDeprecations(*this, 287 dyn_cast<NamedDecl>(IMD), 288 MDecl->getLocation(), 0); 289} 290 291Decl *Sema:: 292ActOnStartClassInterface(SourceLocation AtInterfaceLoc, 293 IdentifierInfo *ClassName, SourceLocation ClassLoc, 294 IdentifierInfo *SuperName, SourceLocation SuperLoc, 295 Decl * const *ProtoRefs, unsigned NumProtoRefs, 296 const SourceLocation *ProtoLocs, 297 SourceLocation EndProtoLoc, AttributeList *AttrList) { 298 assert(ClassName && "Missing class identifier"); 299 300 // Check for another declaration kind with the same name. 301 NamedDecl *PrevDecl = LookupSingleName(TUScope, ClassName, ClassLoc, 302 LookupOrdinaryName, ForRedeclaration); 303 304 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) { 305 Diag(ClassLoc, diag::err_redefinition_different_kind) << ClassName; 306 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 307 } 308 309 ObjCInterfaceDecl* IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl); 310 if (IDecl) { 311 // Class already seen. Is it a forward declaration? 312 if (!IDecl->isForwardDecl()) { 313 IDecl->setInvalidDecl(); 314 Diag(AtInterfaceLoc, diag::err_duplicate_class_def)<<IDecl->getDeclName(); 315 Diag(IDecl->getLocation(), diag::note_previous_definition); 316 317 // Return the previous class interface. 318 // FIXME: don't leak the objects passed in! 319 return IDecl; 320 } else { 321 IDecl->setLocation(AtInterfaceLoc); 322 IDecl->setForwardDecl(false); 323 IDecl->setClassLoc(ClassLoc); 324 // If the forward decl was in a PCH, we need to write it again in a 325 // dependent AST file. 326 IDecl->setChangedSinceDeserialization(true); 327 328 // Since this ObjCInterfaceDecl was created by a forward declaration, 329 // we now add it to the DeclContext since it wasn't added before 330 // (see ActOnForwardClassDeclaration). 331 IDecl->setLexicalDeclContext(CurContext); 332 CurContext->addDecl(IDecl); 333 334 if (AttrList) 335 ProcessDeclAttributeList(TUScope, IDecl, AttrList); 336 } 337 } else { 338 IDecl = ObjCInterfaceDecl::Create(Context, CurContext, AtInterfaceLoc, 339 ClassName, ClassLoc); 340 if (AttrList) 341 ProcessDeclAttributeList(TUScope, IDecl, AttrList); 342 343 PushOnScopeChains(IDecl, TUScope); 344 } 345 346 if (SuperName) { 347 // Check if a different kind of symbol declared in this scope. 348 PrevDecl = LookupSingleName(TUScope, SuperName, SuperLoc, 349 LookupOrdinaryName); 350 351 if (!PrevDecl) { 352 // Try to correct for a typo in the superclass name. 353 TypoCorrection Corrected = CorrectTypo( 354 DeclarationNameInfo(SuperName, SuperLoc), LookupOrdinaryName, TUScope, 355 NULL, NULL, false, CTC_NoKeywords); 356 if ((PrevDecl = Corrected.getCorrectionDeclAs<ObjCInterfaceDecl>())) { 357 Diag(SuperLoc, diag::err_undef_superclass_suggest) 358 << SuperName << ClassName << PrevDecl->getDeclName(); 359 Diag(PrevDecl->getLocation(), diag::note_previous_decl) 360 << PrevDecl->getDeclName(); 361 } 362 } 363 364 if (PrevDecl == IDecl) { 365 Diag(SuperLoc, diag::err_recursive_superclass) 366 << SuperName << ClassName << SourceRange(AtInterfaceLoc, ClassLoc); 367 IDecl->setLocEnd(ClassLoc); 368 } else { 369 ObjCInterfaceDecl *SuperClassDecl = 370 dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl); 371 372 // Diagnose classes that inherit from deprecated classes. 373 if (SuperClassDecl) 374 (void)DiagnoseUseOfDecl(SuperClassDecl, SuperLoc); 375 376 if (PrevDecl && SuperClassDecl == 0) { 377 // The previous declaration was not a class decl. Check if we have a 378 // typedef. If we do, get the underlying class type. 379 if (const TypedefNameDecl *TDecl = 380 dyn_cast_or_null<TypedefNameDecl>(PrevDecl)) { 381 QualType T = TDecl->getUnderlyingType(); 382 if (T->isObjCObjectType()) { 383 if (NamedDecl *IDecl = T->getAs<ObjCObjectType>()->getInterface()) 384 SuperClassDecl = dyn_cast<ObjCInterfaceDecl>(IDecl); 385 } 386 } 387 388 // This handles the following case: 389 // 390 // typedef int SuperClass; 391 // @interface MyClass : SuperClass {} @end 392 // 393 if (!SuperClassDecl) { 394 Diag(SuperLoc, diag::err_redefinition_different_kind) << SuperName; 395 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 396 } 397 } 398 399 if (!dyn_cast_or_null<TypedefNameDecl>(PrevDecl)) { 400 if (!SuperClassDecl) 401 Diag(SuperLoc, diag::err_undef_superclass) 402 << SuperName << ClassName << SourceRange(AtInterfaceLoc, ClassLoc); 403 else if (SuperClassDecl->isForwardDecl()) { 404 Diag(SuperLoc, diag::err_forward_superclass) 405 << SuperClassDecl->getDeclName() << ClassName 406 << SourceRange(AtInterfaceLoc, ClassLoc); 407 Diag(SuperClassDecl->getLocation(), diag::note_forward_class); 408 SuperClassDecl = 0; 409 } 410 } 411 IDecl->setSuperClass(SuperClassDecl); 412 IDecl->setSuperClassLoc(SuperLoc); 413 IDecl->setLocEnd(SuperLoc); 414 } 415 } else { // we have a root class. 416 IDecl->setLocEnd(ClassLoc); 417 } 418 419 // Check then save referenced protocols. 420 if (NumProtoRefs) { 421 IDecl->setProtocolList((ObjCProtocolDecl**)ProtoRefs, NumProtoRefs, 422 ProtoLocs, Context); 423 IDecl->setLocEnd(EndProtoLoc); 424 } 425 426 CheckObjCDeclScope(IDecl); 427 return IDecl; 428} 429 430/// ActOnCompatiblityAlias - this action is called after complete parsing of 431/// @compatibility_alias declaration. It sets up the alias relationships. 432Decl *Sema::ActOnCompatiblityAlias(SourceLocation AtLoc, 433 IdentifierInfo *AliasName, 434 SourceLocation AliasLocation, 435 IdentifierInfo *ClassName, 436 SourceLocation ClassLocation) { 437 // Look for previous declaration of alias name 438 NamedDecl *ADecl = LookupSingleName(TUScope, AliasName, AliasLocation, 439 LookupOrdinaryName, ForRedeclaration); 440 if (ADecl) { 441 if (isa<ObjCCompatibleAliasDecl>(ADecl)) 442 Diag(AliasLocation, diag::warn_previous_alias_decl); 443 else 444 Diag(AliasLocation, diag::err_conflicting_aliasing_type) << AliasName; 445 Diag(ADecl->getLocation(), diag::note_previous_declaration); 446 return 0; 447 } 448 // Check for class declaration 449 NamedDecl *CDeclU = LookupSingleName(TUScope, ClassName, ClassLocation, 450 LookupOrdinaryName, ForRedeclaration); 451 if (const TypedefNameDecl *TDecl = 452 dyn_cast_or_null<TypedefNameDecl>(CDeclU)) { 453 QualType T = TDecl->getUnderlyingType(); 454 if (T->isObjCObjectType()) { 455 if (NamedDecl *IDecl = T->getAs<ObjCObjectType>()->getInterface()) { 456 ClassName = IDecl->getIdentifier(); 457 CDeclU = LookupSingleName(TUScope, ClassName, ClassLocation, 458 LookupOrdinaryName, ForRedeclaration); 459 } 460 } 461 } 462 ObjCInterfaceDecl *CDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDeclU); 463 if (CDecl == 0) { 464 Diag(ClassLocation, diag::warn_undef_interface) << ClassName; 465 if (CDeclU) 466 Diag(CDeclU->getLocation(), diag::note_previous_declaration); 467 return 0; 468 } 469 470 // Everything checked out, instantiate a new alias declaration AST. 471 ObjCCompatibleAliasDecl *AliasDecl = 472 ObjCCompatibleAliasDecl::Create(Context, CurContext, AtLoc, AliasName, CDecl); 473 474 if (!CheckObjCDeclScope(AliasDecl)) 475 PushOnScopeChains(AliasDecl, TUScope); 476 477 return AliasDecl; 478} 479 480bool Sema::CheckForwardProtocolDeclarationForCircularDependency( 481 IdentifierInfo *PName, 482 SourceLocation &Ploc, SourceLocation PrevLoc, 483 const ObjCList<ObjCProtocolDecl> &PList) { 484 485 bool res = false; 486 for (ObjCList<ObjCProtocolDecl>::iterator I = PList.begin(), 487 E = PList.end(); I != E; ++I) { 488 if (ObjCProtocolDecl *PDecl = LookupProtocol((*I)->getIdentifier(), 489 Ploc)) { 490 if (PDecl->getIdentifier() == PName) { 491 Diag(Ploc, diag::err_protocol_has_circular_dependency); 492 Diag(PrevLoc, diag::note_previous_definition); 493 res = true; 494 } 495 if (CheckForwardProtocolDeclarationForCircularDependency(PName, Ploc, 496 PDecl->getLocation(), PDecl->getReferencedProtocols())) 497 res = true; 498 } 499 } 500 return res; 501} 502 503Decl * 504Sema::ActOnStartProtocolInterface(SourceLocation AtProtoInterfaceLoc, 505 IdentifierInfo *ProtocolName, 506 SourceLocation ProtocolLoc, 507 Decl * const *ProtoRefs, 508 unsigned NumProtoRefs, 509 const SourceLocation *ProtoLocs, 510 SourceLocation EndProtoLoc, 511 AttributeList *AttrList) { 512 bool err = false; 513 // FIXME: Deal with AttrList. 514 assert(ProtocolName && "Missing protocol identifier"); 515 ObjCProtocolDecl *PDecl = LookupProtocol(ProtocolName, ProtocolLoc); 516 if (PDecl) { 517 // Protocol already seen. Better be a forward protocol declaration 518 if (!PDecl->isForwardDecl()) { 519 Diag(ProtocolLoc, diag::warn_duplicate_protocol_def) << ProtocolName; 520 Diag(PDecl->getLocation(), diag::note_previous_definition); 521 // Just return the protocol we already had. 522 // FIXME: don't leak the objects passed in! 523 return PDecl; 524 } 525 ObjCList<ObjCProtocolDecl> PList; 526 PList.set((ObjCProtocolDecl *const*)ProtoRefs, NumProtoRefs, Context); 527 err = CheckForwardProtocolDeclarationForCircularDependency( 528 ProtocolName, ProtocolLoc, PDecl->getLocation(), PList); 529 530 // Make sure the cached decl gets a valid start location. 531 PDecl->setLocation(AtProtoInterfaceLoc); 532 PDecl->setForwardDecl(false); 533 CurContext->addDecl(PDecl); 534 // Repeat in dependent AST files. 535 PDecl->setChangedSinceDeserialization(true); 536 } else { 537 PDecl = ObjCProtocolDecl::Create(Context, CurContext, 538 AtProtoInterfaceLoc,ProtocolName); 539 PushOnScopeChains(PDecl, TUScope); 540 PDecl->setForwardDecl(false); 541 } 542 if (AttrList) 543 ProcessDeclAttributeList(TUScope, PDecl, AttrList); 544 if (!err && NumProtoRefs ) { 545 /// Check then save referenced protocols. 546 PDecl->setProtocolList((ObjCProtocolDecl**)ProtoRefs, NumProtoRefs, 547 ProtoLocs, Context); 548 PDecl->setLocEnd(EndProtoLoc); 549 } 550 551 CheckObjCDeclScope(PDecl); 552 return PDecl; 553} 554 555/// FindProtocolDeclaration - This routine looks up protocols and 556/// issues an error if they are not declared. It returns list of 557/// protocol declarations in its 'Protocols' argument. 558void 559Sema::FindProtocolDeclaration(bool WarnOnDeclarations, 560 const IdentifierLocPair *ProtocolId, 561 unsigned NumProtocols, 562 SmallVectorImpl<Decl *> &Protocols) { 563 for (unsigned i = 0; i != NumProtocols; ++i) { 564 ObjCProtocolDecl *PDecl = LookupProtocol(ProtocolId[i].first, 565 ProtocolId[i].second); 566 if (!PDecl) { 567 TypoCorrection Corrected = CorrectTypo( 568 DeclarationNameInfo(ProtocolId[i].first, ProtocolId[i].second), 569 LookupObjCProtocolName, TUScope, NULL, NULL, false, CTC_NoKeywords); 570 if ((PDecl = Corrected.getCorrectionDeclAs<ObjCProtocolDecl>())) { 571 Diag(ProtocolId[i].second, diag::err_undeclared_protocol_suggest) 572 << ProtocolId[i].first << Corrected.getCorrection(); 573 Diag(PDecl->getLocation(), diag::note_previous_decl) 574 << PDecl->getDeclName(); 575 } 576 } 577 578 if (!PDecl) { 579 Diag(ProtocolId[i].second, diag::err_undeclared_protocol) 580 << ProtocolId[i].first; 581 continue; 582 } 583 584 (void)DiagnoseUseOfDecl(PDecl, ProtocolId[i].second); 585 586 // If this is a forward declaration and we are supposed to warn in this 587 // case, do it. 588 if (WarnOnDeclarations && PDecl->isForwardDecl()) 589 Diag(ProtocolId[i].second, diag::warn_undef_protocolref) 590 << ProtocolId[i].first; 591 Protocols.push_back(PDecl); 592 } 593} 594 595/// DiagnoseClassExtensionDupMethods - Check for duplicate declaration of 596/// a class method in its extension. 597/// 598void Sema::DiagnoseClassExtensionDupMethods(ObjCCategoryDecl *CAT, 599 ObjCInterfaceDecl *ID) { 600 if (!ID) 601 return; // Possibly due to previous error 602 603 llvm::DenseMap<Selector, const ObjCMethodDecl*> MethodMap; 604 for (ObjCInterfaceDecl::method_iterator i = ID->meth_begin(), 605 e = ID->meth_end(); i != e; ++i) { 606 ObjCMethodDecl *MD = *i; 607 MethodMap[MD->getSelector()] = MD; 608 } 609 610 if (MethodMap.empty()) 611 return; 612 for (ObjCCategoryDecl::method_iterator i = CAT->meth_begin(), 613 e = CAT->meth_end(); i != e; ++i) { 614 ObjCMethodDecl *Method = *i; 615 const ObjCMethodDecl *&PrevMethod = MethodMap[Method->getSelector()]; 616 if (PrevMethod && !MatchTwoMethodDeclarations(Method, PrevMethod)) { 617 Diag(Method->getLocation(), diag::err_duplicate_method_decl) 618 << Method->getDeclName(); 619 Diag(PrevMethod->getLocation(), diag::note_previous_declaration); 620 } 621 } 622} 623 624/// ActOnForwardProtocolDeclaration - Handle @protocol foo; 625Decl * 626Sema::ActOnForwardProtocolDeclaration(SourceLocation AtProtocolLoc, 627 const IdentifierLocPair *IdentList, 628 unsigned NumElts, 629 AttributeList *attrList) { 630 SmallVector<ObjCProtocolDecl*, 32> Protocols; 631 SmallVector<SourceLocation, 8> ProtoLocs; 632 633 for (unsigned i = 0; i != NumElts; ++i) { 634 IdentifierInfo *Ident = IdentList[i].first; 635 ObjCProtocolDecl *PDecl = LookupProtocol(Ident, IdentList[i].second); 636 bool isNew = false; 637 if (PDecl == 0) { // Not already seen? 638 PDecl = ObjCProtocolDecl::Create(Context, CurContext, 639 IdentList[i].second, Ident); 640 PushOnScopeChains(PDecl, TUScope, false); 641 isNew = true; 642 } 643 if (attrList) { 644 ProcessDeclAttributeList(TUScope, PDecl, attrList); 645 if (!isNew) 646 PDecl->setChangedSinceDeserialization(true); 647 } 648 Protocols.push_back(PDecl); 649 ProtoLocs.push_back(IdentList[i].second); 650 } 651 652 ObjCForwardProtocolDecl *PDecl = 653 ObjCForwardProtocolDecl::Create(Context, CurContext, AtProtocolLoc, 654 Protocols.data(), Protocols.size(), 655 ProtoLocs.data()); 656 CurContext->addDecl(PDecl); 657 CheckObjCDeclScope(PDecl); 658 return PDecl; 659} 660 661Decl *Sema:: 662ActOnStartCategoryInterface(SourceLocation AtInterfaceLoc, 663 IdentifierInfo *ClassName, SourceLocation ClassLoc, 664 IdentifierInfo *CategoryName, 665 SourceLocation CategoryLoc, 666 Decl * const *ProtoRefs, 667 unsigned NumProtoRefs, 668 const SourceLocation *ProtoLocs, 669 SourceLocation EndProtoLoc) { 670 ObjCCategoryDecl *CDecl; 671 ObjCInterfaceDecl *IDecl = getObjCInterfaceDecl(ClassName, ClassLoc, true); 672 673 /// Check that class of this category is already completely declared. 674 if (!IDecl || IDecl->isForwardDecl()) { 675 // Create an invalid ObjCCategoryDecl to serve as context for 676 // the enclosing method declarations. We mark the decl invalid 677 // to make it clear that this isn't a valid AST. 678 CDecl = ObjCCategoryDecl::Create(Context, CurContext, AtInterfaceLoc, 679 ClassLoc, CategoryLoc, CategoryName); 680 CDecl->setInvalidDecl(); 681 Diag(ClassLoc, diag::err_undef_interface) << ClassName; 682 return CDecl; 683 } 684 685 if (!CategoryName && IDecl->getImplementation()) { 686 Diag(ClassLoc, diag::err_class_extension_after_impl) << ClassName; 687 Diag(IDecl->getImplementation()->getLocation(), 688 diag::note_implementation_declared); 689 } 690 691 CDecl = ObjCCategoryDecl::Create(Context, CurContext, AtInterfaceLoc, 692 ClassLoc, CategoryLoc, CategoryName); 693 // FIXME: PushOnScopeChains? 694 CurContext->addDecl(CDecl); 695 696 CDecl->setClassInterface(IDecl); 697 // Insert class extension to the list of class's categories. 698 if (!CategoryName) 699 CDecl->insertNextClassCategory(); 700 701 // If the interface is deprecated, warn about it. 702 (void)DiagnoseUseOfDecl(IDecl, ClassLoc); 703 704 if (CategoryName) { 705 /// Check for duplicate interface declaration for this category 706 ObjCCategoryDecl *CDeclChain; 707 for (CDeclChain = IDecl->getCategoryList(); CDeclChain; 708 CDeclChain = CDeclChain->getNextClassCategory()) { 709 if (CDeclChain->getIdentifier() == CategoryName) { 710 // Class extensions can be declared multiple times. 711 Diag(CategoryLoc, diag::warn_dup_category_def) 712 << ClassName << CategoryName; 713 Diag(CDeclChain->getLocation(), diag::note_previous_definition); 714 break; 715 } 716 } 717 if (!CDeclChain) 718 CDecl->insertNextClassCategory(); 719 } 720 721 if (NumProtoRefs) { 722 CDecl->setProtocolList((ObjCProtocolDecl**)ProtoRefs, NumProtoRefs, 723 ProtoLocs, Context); 724 // Protocols in the class extension belong to the class. 725 if (CDecl->IsClassExtension()) 726 IDecl->mergeClassExtensionProtocolList((ObjCProtocolDecl**)ProtoRefs, 727 NumProtoRefs, Context); 728 } 729 730 CheckObjCDeclScope(CDecl); 731 return CDecl; 732} 733 734/// ActOnStartCategoryImplementation - Perform semantic checks on the 735/// category implementation declaration and build an ObjCCategoryImplDecl 736/// object. 737Decl *Sema::ActOnStartCategoryImplementation( 738 SourceLocation AtCatImplLoc, 739 IdentifierInfo *ClassName, SourceLocation ClassLoc, 740 IdentifierInfo *CatName, SourceLocation CatLoc) { 741 ObjCInterfaceDecl *IDecl = getObjCInterfaceDecl(ClassName, ClassLoc, true); 742 ObjCCategoryDecl *CatIDecl = 0; 743 if (IDecl) { 744 CatIDecl = IDecl->FindCategoryDeclaration(CatName); 745 if (!CatIDecl) { 746 // Category @implementation with no corresponding @interface. 747 // Create and install one. 748 CatIDecl = ObjCCategoryDecl::Create(Context, CurContext, SourceLocation(), 749 SourceLocation(), SourceLocation(), 750 CatName); 751 CatIDecl->setClassInterface(IDecl); 752 CatIDecl->insertNextClassCategory(); 753 } 754 } 755 756 ObjCCategoryImplDecl *CDecl = 757 ObjCCategoryImplDecl::Create(Context, CurContext, AtCatImplLoc, CatName, 758 IDecl); 759 /// Check that class of this category is already completely declared. 760 if (!IDecl || IDecl->isForwardDecl()) { 761 Diag(ClassLoc, diag::err_undef_interface) << ClassName; 762 CDecl->setInvalidDecl(); 763 } 764 765 // FIXME: PushOnScopeChains? 766 CurContext->addDecl(CDecl); 767 768 /// Check that CatName, category name, is not used in another implementation. 769 if (CatIDecl) { 770 if (CatIDecl->getImplementation()) { 771 Diag(ClassLoc, diag::err_dup_implementation_category) << ClassName 772 << CatName; 773 Diag(CatIDecl->getImplementation()->getLocation(), 774 diag::note_previous_definition); 775 } else { 776 CatIDecl->setImplementation(CDecl); 777 // Warn on implementating category of deprecated class under 778 // -Wdeprecated-implementations flag. 779 DiagnoseObjCImplementedDeprecations(*this, 780 dyn_cast<NamedDecl>(IDecl), 781 CDecl->getLocation(), 2); 782 } 783 } 784 785 CheckObjCDeclScope(CDecl); 786 return CDecl; 787} 788 789Decl *Sema::ActOnStartClassImplementation( 790 SourceLocation AtClassImplLoc, 791 IdentifierInfo *ClassName, SourceLocation ClassLoc, 792 IdentifierInfo *SuperClassname, 793 SourceLocation SuperClassLoc) { 794 ObjCInterfaceDecl* IDecl = 0; 795 // Check for another declaration kind with the same name. 796 NamedDecl *PrevDecl 797 = LookupSingleName(TUScope, ClassName, ClassLoc, LookupOrdinaryName, 798 ForRedeclaration); 799 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) { 800 Diag(ClassLoc, diag::err_redefinition_different_kind) << ClassName; 801 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 802 } else if ((IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl))) { 803 // If this is a forward declaration of an interface, warn. 804 if (IDecl->isForwardDecl()) { 805 Diag(ClassLoc, diag::warn_undef_interface) << ClassName; 806 IDecl = 0; 807 } 808 } else { 809 // We did not find anything with the name ClassName; try to correct for 810 // typos in the class name. 811 TypoCorrection Corrected = CorrectTypo( 812 DeclarationNameInfo(ClassName, ClassLoc), LookupOrdinaryName, TUScope, 813 NULL, NULL, false, CTC_NoKeywords); 814 if ((IDecl = Corrected.getCorrectionDeclAs<ObjCInterfaceDecl>())) { 815 // Suggest the (potentially) correct interface name. However, put the 816 // fix-it hint itself in a separate note, since changing the name in 817 // the warning would make the fix-it change semantics.However, don't 818 // provide a code-modification hint or use the typo name for recovery, 819 // because this is just a warning. The program may actually be correct. 820 DeclarationName CorrectedName = Corrected.getCorrection(); 821 Diag(ClassLoc, diag::warn_undef_interface_suggest) 822 << ClassName << CorrectedName; 823 Diag(IDecl->getLocation(), diag::note_previous_decl) << CorrectedName 824 << FixItHint::CreateReplacement(ClassLoc, CorrectedName.getAsString()); 825 IDecl = 0; 826 } else { 827 Diag(ClassLoc, diag::warn_undef_interface) << ClassName; 828 } 829 } 830 831 // Check that super class name is valid class name 832 ObjCInterfaceDecl* SDecl = 0; 833 if (SuperClassname) { 834 // Check if a different kind of symbol declared in this scope. 835 PrevDecl = LookupSingleName(TUScope, SuperClassname, SuperClassLoc, 836 LookupOrdinaryName); 837 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) { 838 Diag(SuperClassLoc, diag::err_redefinition_different_kind) 839 << SuperClassname; 840 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 841 } else { 842 SDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl); 843 if (!SDecl) 844 Diag(SuperClassLoc, diag::err_undef_superclass) 845 << SuperClassname << ClassName; 846 else if (IDecl && IDecl->getSuperClass() != SDecl) { 847 // This implementation and its interface do not have the same 848 // super class. 849 Diag(SuperClassLoc, diag::err_conflicting_super_class) 850 << SDecl->getDeclName(); 851 Diag(SDecl->getLocation(), diag::note_previous_definition); 852 } 853 } 854 } 855 856 if (!IDecl) { 857 // Legacy case of @implementation with no corresponding @interface. 858 // Build, chain & install the interface decl into the identifier. 859 860 // FIXME: Do we support attributes on the @implementation? If so we should 861 // copy them over. 862 IDecl = ObjCInterfaceDecl::Create(Context, CurContext, AtClassImplLoc, 863 ClassName, ClassLoc, false, true); 864 IDecl->setSuperClass(SDecl); 865 IDecl->setLocEnd(ClassLoc); 866 867 PushOnScopeChains(IDecl, TUScope); 868 } else { 869 // Mark the interface as being completed, even if it was just as 870 // @class ....; 871 // declaration; the user cannot reopen it. 872 IDecl->setForwardDecl(false); 873 } 874 875 ObjCImplementationDecl* IMPDecl = 876 ObjCImplementationDecl::Create(Context, CurContext, AtClassImplLoc, 877 IDecl, SDecl); 878 879 if (CheckObjCDeclScope(IMPDecl)) 880 return IMPDecl; 881 882 // Check that there is no duplicate implementation of this class. 883 if (IDecl->getImplementation()) { 884 // FIXME: Don't leak everything! 885 Diag(ClassLoc, diag::err_dup_implementation_class) << ClassName; 886 Diag(IDecl->getImplementation()->getLocation(), 887 diag::note_previous_definition); 888 } else { // add it to the list. 889 IDecl->setImplementation(IMPDecl); 890 PushOnScopeChains(IMPDecl, TUScope); 891 // Warn on implementating deprecated class under 892 // -Wdeprecated-implementations flag. 893 DiagnoseObjCImplementedDeprecations(*this, 894 dyn_cast<NamedDecl>(IDecl), 895 IMPDecl->getLocation(), 1); 896 } 897 return IMPDecl; 898} 899 900void Sema::CheckImplementationIvars(ObjCImplementationDecl *ImpDecl, 901 ObjCIvarDecl **ivars, unsigned numIvars, 902 SourceLocation RBrace) { 903 assert(ImpDecl && "missing implementation decl"); 904 ObjCInterfaceDecl* IDecl = ImpDecl->getClassInterface(); 905 if (!IDecl) 906 return; 907 /// Check case of non-existing @interface decl. 908 /// (legacy objective-c @implementation decl without an @interface decl). 909 /// Add implementations's ivar to the synthesize class's ivar list. 910 if (IDecl->isImplicitInterfaceDecl()) { 911 IDecl->setLocEnd(RBrace); 912 // Add ivar's to class's DeclContext. 913 for (unsigned i = 0, e = numIvars; i != e; ++i) { 914 ivars[i]->setLexicalDeclContext(ImpDecl); 915 IDecl->makeDeclVisibleInContext(ivars[i], false); 916 ImpDecl->addDecl(ivars[i]); 917 } 918 919 return; 920 } 921 // If implementation has empty ivar list, just return. 922 if (numIvars == 0) 923 return; 924 925 assert(ivars && "missing @implementation ivars"); 926 if (LangOpts.ObjCNonFragileABI2) { 927 if (ImpDecl->getSuperClass()) 928 Diag(ImpDecl->getLocation(), diag::warn_on_superclass_use); 929 for (unsigned i = 0; i < numIvars; i++) { 930 ObjCIvarDecl* ImplIvar = ivars[i]; 931 if (const ObjCIvarDecl *ClsIvar = 932 IDecl->getIvarDecl(ImplIvar->getIdentifier())) { 933 Diag(ImplIvar->getLocation(), diag::err_duplicate_ivar_declaration); 934 Diag(ClsIvar->getLocation(), diag::note_previous_definition); 935 continue; 936 } 937 // Instance ivar to Implementation's DeclContext. 938 ImplIvar->setLexicalDeclContext(ImpDecl); 939 IDecl->makeDeclVisibleInContext(ImplIvar, false); 940 ImpDecl->addDecl(ImplIvar); 941 } 942 return; 943 } 944 // Check interface's Ivar list against those in the implementation. 945 // names and types must match. 946 // 947 unsigned j = 0; 948 ObjCInterfaceDecl::ivar_iterator 949 IVI = IDecl->ivar_begin(), IVE = IDecl->ivar_end(); 950 for (; numIvars > 0 && IVI != IVE; ++IVI) { 951 ObjCIvarDecl* ImplIvar = ivars[j++]; 952 ObjCIvarDecl* ClsIvar = *IVI; 953 assert (ImplIvar && "missing implementation ivar"); 954 assert (ClsIvar && "missing class ivar"); 955 956 // First, make sure the types match. 957 if (Context.getCanonicalType(ImplIvar->getType()) != 958 Context.getCanonicalType(ClsIvar->getType())) { 959 Diag(ImplIvar->getLocation(), diag::err_conflicting_ivar_type) 960 << ImplIvar->getIdentifier() 961 << ImplIvar->getType() << ClsIvar->getType(); 962 Diag(ClsIvar->getLocation(), diag::note_previous_definition); 963 } else if (ImplIvar->isBitField() && ClsIvar->isBitField()) { 964 Expr *ImplBitWidth = ImplIvar->getBitWidth(); 965 Expr *ClsBitWidth = ClsIvar->getBitWidth(); 966 if (ImplBitWidth->EvaluateAsInt(Context).getZExtValue() != 967 ClsBitWidth->EvaluateAsInt(Context).getZExtValue()) { 968 Diag(ImplBitWidth->getLocStart(), diag::err_conflicting_ivar_bitwidth) 969 << ImplIvar->getIdentifier(); 970 Diag(ClsBitWidth->getLocStart(), diag::note_previous_definition); 971 } 972 } 973 // Make sure the names are identical. 974 if (ImplIvar->getIdentifier() != ClsIvar->getIdentifier()) { 975 Diag(ImplIvar->getLocation(), diag::err_conflicting_ivar_name) 976 << ImplIvar->getIdentifier() << ClsIvar->getIdentifier(); 977 Diag(ClsIvar->getLocation(), diag::note_previous_definition); 978 } 979 --numIvars; 980 } 981 982 if (numIvars > 0) 983 Diag(ivars[j]->getLocation(), diag::err_inconsistant_ivar_count); 984 else if (IVI != IVE) 985 Diag((*IVI)->getLocation(), diag::err_inconsistant_ivar_count); 986} 987 988void Sema::WarnUndefinedMethod(SourceLocation ImpLoc, ObjCMethodDecl *method, 989 bool &IncompleteImpl, unsigned DiagID) { 990 // No point warning no definition of method which is 'unavailable'. 991 if (method->hasAttr<UnavailableAttr>()) 992 return; 993 if (!IncompleteImpl) { 994 Diag(ImpLoc, diag::warn_incomplete_impl); 995 IncompleteImpl = true; 996 } 997 if (DiagID == diag::warn_unimplemented_protocol_method) 998 Diag(ImpLoc, DiagID) << method->getDeclName(); 999 else 1000 Diag(method->getLocation(), DiagID) << method->getDeclName(); 1001} 1002 1003/// Determines if type B can be substituted for type A. Returns true if we can 1004/// guarantee that anything that the user will do to an object of type A can 1005/// also be done to an object of type B. This is trivially true if the two 1006/// types are the same, or if B is a subclass of A. It becomes more complex 1007/// in cases where protocols are involved. 1008/// 1009/// Object types in Objective-C describe the minimum requirements for an 1010/// object, rather than providing a complete description of a type. For 1011/// example, if A is a subclass of B, then B* may refer to an instance of A. 1012/// The principle of substitutability means that we may use an instance of A 1013/// anywhere that we may use an instance of B - it will implement all of the 1014/// ivars of B and all of the methods of B. 1015/// 1016/// This substitutability is important when type checking methods, because 1017/// the implementation may have stricter type definitions than the interface. 1018/// The interface specifies minimum requirements, but the implementation may 1019/// have more accurate ones. For example, a method may privately accept 1020/// instances of B, but only publish that it accepts instances of A. Any 1021/// object passed to it will be type checked against B, and so will implicitly 1022/// by a valid A*. Similarly, a method may return a subclass of the class that 1023/// it is declared as returning. 1024/// 1025/// This is most important when considering subclassing. A method in a 1026/// subclass must accept any object as an argument that its superclass's 1027/// implementation accepts. It may, however, accept a more general type 1028/// without breaking substitutability (i.e. you can still use the subclass 1029/// anywhere that you can use the superclass, but not vice versa). The 1030/// converse requirement applies to return types: the return type for a 1031/// subclass method must be a valid object of the kind that the superclass 1032/// advertises, but it may be specified more accurately. This avoids the need 1033/// for explicit down-casting by callers. 1034/// 1035/// Note: This is a stricter requirement than for assignment. 1036static bool isObjCTypeSubstitutable(ASTContext &Context, 1037 const ObjCObjectPointerType *A, 1038 const ObjCObjectPointerType *B, 1039 bool rejectId) { 1040 // Reject a protocol-unqualified id. 1041 if (rejectId && B->isObjCIdType()) return false; 1042 1043 // If B is a qualified id, then A must also be a qualified id and it must 1044 // implement all of the protocols in B. It may not be a qualified class. 1045 // For example, MyClass<A> can be assigned to id<A>, but MyClass<A> is a 1046 // stricter definition so it is not substitutable for id<A>. 1047 if (B->isObjCQualifiedIdType()) { 1048 return A->isObjCQualifiedIdType() && 1049 Context.ObjCQualifiedIdTypesAreCompatible(QualType(A, 0), 1050 QualType(B,0), 1051 false); 1052 } 1053 1054 /* 1055 // id is a special type that bypasses type checking completely. We want a 1056 // warning when it is used in one place but not another. 1057 if (C.isObjCIdType(A) || C.isObjCIdType(B)) return false; 1058 1059 1060 // If B is a qualified id, then A must also be a qualified id (which it isn't 1061 // if we've got this far) 1062 if (B->isObjCQualifiedIdType()) return false; 1063 */ 1064 1065 // Now we know that A and B are (potentially-qualified) class types. The 1066 // normal rules for assignment apply. 1067 return Context.canAssignObjCInterfaces(A, B); 1068} 1069 1070static SourceRange getTypeRange(TypeSourceInfo *TSI) { 1071 return (TSI ? TSI->getTypeLoc().getSourceRange() : SourceRange()); 1072} 1073 1074static bool CheckMethodOverrideReturn(Sema &S, 1075 ObjCMethodDecl *MethodImpl, 1076 ObjCMethodDecl *MethodDecl, 1077 bool IsProtocolMethodDecl, 1078 bool IsOverridingMode, 1079 bool Warn) { 1080 if (IsProtocolMethodDecl && 1081 (MethodDecl->getObjCDeclQualifier() != 1082 MethodImpl->getObjCDeclQualifier())) { 1083 if (Warn) { 1084 S.Diag(MethodImpl->getLocation(), 1085 (IsOverridingMode ? 1086 diag::warn_conflicting_overriding_ret_type_modifiers 1087 : diag::warn_conflicting_ret_type_modifiers)) 1088 << MethodImpl->getDeclName() 1089 << getTypeRange(MethodImpl->getResultTypeSourceInfo()); 1090 S.Diag(MethodDecl->getLocation(), diag::note_previous_declaration) 1091 << getTypeRange(MethodDecl->getResultTypeSourceInfo()); 1092 } 1093 else 1094 return false; 1095 } 1096 1097 if (S.Context.hasSameUnqualifiedType(MethodImpl->getResultType(), 1098 MethodDecl->getResultType())) 1099 return true; 1100 if (!Warn) 1101 return false; 1102 1103 unsigned DiagID = 1104 IsOverridingMode ? diag::warn_conflicting_overriding_ret_types 1105 : diag::warn_conflicting_ret_types; 1106 1107 // Mismatches between ObjC pointers go into a different warning 1108 // category, and sometimes they're even completely whitelisted. 1109 if (const ObjCObjectPointerType *ImplPtrTy = 1110 MethodImpl->getResultType()->getAs<ObjCObjectPointerType>()) { 1111 if (const ObjCObjectPointerType *IfacePtrTy = 1112 MethodDecl->getResultType()->getAs<ObjCObjectPointerType>()) { 1113 // Allow non-matching return types as long as they don't violate 1114 // the principle of substitutability. Specifically, we permit 1115 // return types that are subclasses of the declared return type, 1116 // or that are more-qualified versions of the declared type. 1117 if (isObjCTypeSubstitutable(S.Context, IfacePtrTy, ImplPtrTy, false)) 1118 return false; 1119 1120 DiagID = 1121 IsOverridingMode ? diag::warn_non_covariant_overriding_ret_types 1122 : diag::warn_non_covariant_ret_types; 1123 } 1124 } 1125 1126 S.Diag(MethodImpl->getLocation(), DiagID) 1127 << MethodImpl->getDeclName() 1128 << MethodDecl->getResultType() 1129 << MethodImpl->getResultType() 1130 << getTypeRange(MethodImpl->getResultTypeSourceInfo()); 1131 S.Diag(MethodDecl->getLocation(), 1132 IsOverridingMode ? diag::note_previous_declaration 1133 : diag::note_previous_definition) 1134 << getTypeRange(MethodDecl->getResultTypeSourceInfo()); 1135 return false; 1136} 1137 1138static bool CheckMethodOverrideParam(Sema &S, 1139 ObjCMethodDecl *MethodImpl, 1140 ObjCMethodDecl *MethodDecl, 1141 ParmVarDecl *ImplVar, 1142 ParmVarDecl *IfaceVar, 1143 bool IsProtocolMethodDecl, 1144 bool IsOverridingMode, 1145 bool Warn) { 1146 if (IsProtocolMethodDecl && 1147 (ImplVar->getObjCDeclQualifier() != 1148 IfaceVar->getObjCDeclQualifier())) { 1149 if (Warn) { 1150 if (IsOverridingMode) 1151 S.Diag(ImplVar->getLocation(), 1152 diag::warn_conflicting_overriding_param_modifiers) 1153 << getTypeRange(ImplVar->getTypeSourceInfo()) 1154 << MethodImpl->getDeclName(); 1155 else S.Diag(ImplVar->getLocation(), 1156 diag::warn_conflicting_param_modifiers) 1157 << getTypeRange(ImplVar->getTypeSourceInfo()) 1158 << MethodImpl->getDeclName(); 1159 S.Diag(IfaceVar->getLocation(), diag::note_previous_declaration) 1160 << getTypeRange(IfaceVar->getTypeSourceInfo()); 1161 } 1162 else 1163 return false; 1164 } 1165 1166 QualType ImplTy = ImplVar->getType(); 1167 QualType IfaceTy = IfaceVar->getType(); 1168 1169 if (S.Context.hasSameUnqualifiedType(ImplTy, IfaceTy)) 1170 return true; 1171 1172 if (!Warn) 1173 return false; 1174 unsigned DiagID = 1175 IsOverridingMode ? diag::warn_conflicting_overriding_param_types 1176 : diag::warn_conflicting_param_types; 1177 1178 // Mismatches between ObjC pointers go into a different warning 1179 // category, and sometimes they're even completely whitelisted. 1180 if (const ObjCObjectPointerType *ImplPtrTy = 1181 ImplTy->getAs<ObjCObjectPointerType>()) { 1182 if (const ObjCObjectPointerType *IfacePtrTy = 1183 IfaceTy->getAs<ObjCObjectPointerType>()) { 1184 // Allow non-matching argument types as long as they don't 1185 // violate the principle of substitutability. Specifically, the 1186 // implementation must accept any objects that the superclass 1187 // accepts, however it may also accept others. 1188 if (isObjCTypeSubstitutable(S.Context, ImplPtrTy, IfacePtrTy, true)) 1189 return false; 1190 1191 DiagID = 1192 IsOverridingMode ? diag::warn_non_contravariant_overriding_param_types 1193 : diag::warn_non_contravariant_param_types; 1194 } 1195 } 1196 1197 S.Diag(ImplVar->getLocation(), DiagID) 1198 << getTypeRange(ImplVar->getTypeSourceInfo()) 1199 << MethodImpl->getDeclName() << IfaceTy << ImplTy; 1200 S.Diag(IfaceVar->getLocation(), 1201 (IsOverridingMode ? diag::note_previous_declaration 1202 : diag::note_previous_definition)) 1203 << getTypeRange(IfaceVar->getTypeSourceInfo()); 1204 return false; 1205} 1206 1207/// In ARC, check whether the conventional meanings of the two methods 1208/// match. If they don't, it's a hard error. 1209static bool checkMethodFamilyMismatch(Sema &S, ObjCMethodDecl *impl, 1210 ObjCMethodDecl *decl) { 1211 ObjCMethodFamily implFamily = impl->getMethodFamily(); 1212 ObjCMethodFamily declFamily = decl->getMethodFamily(); 1213 if (implFamily == declFamily) return false; 1214 1215 // Since conventions are sorted by selector, the only possibility is 1216 // that the types differ enough to cause one selector or the other 1217 // to fall out of the family. 1218 assert(implFamily == OMF_None || declFamily == OMF_None); 1219 1220 // No further diagnostics required on invalid declarations. 1221 if (impl->isInvalidDecl() || decl->isInvalidDecl()) return true; 1222 1223 const ObjCMethodDecl *unmatched = impl; 1224 ObjCMethodFamily family = declFamily; 1225 unsigned errorID = diag::err_arc_lost_method_convention; 1226 unsigned noteID = diag::note_arc_lost_method_convention; 1227 if (declFamily == OMF_None) { 1228 unmatched = decl; 1229 family = implFamily; 1230 errorID = diag::err_arc_gained_method_convention; 1231 noteID = diag::note_arc_gained_method_convention; 1232 } 1233 1234 // Indexes into a %select clause in the diagnostic. 1235 enum FamilySelector { 1236 F_alloc, F_copy, F_mutableCopy = F_copy, F_init, F_new 1237 }; 1238 FamilySelector familySelector = FamilySelector(); 1239 1240 switch (family) { 1241 case OMF_None: llvm_unreachable("logic error, no method convention"); 1242 case OMF_retain: 1243 case OMF_release: 1244 case OMF_autorelease: 1245 case OMF_dealloc: 1246 case OMF_retainCount: 1247 case OMF_self: 1248 case OMF_performSelector: 1249 // Mismatches for these methods don't change ownership 1250 // conventions, so we don't care. 1251 return false; 1252 1253 case OMF_init: familySelector = F_init; break; 1254 case OMF_alloc: familySelector = F_alloc; break; 1255 case OMF_copy: familySelector = F_copy; break; 1256 case OMF_mutableCopy: familySelector = F_mutableCopy; break; 1257 case OMF_new: familySelector = F_new; break; 1258 } 1259 1260 enum ReasonSelector { R_NonObjectReturn, R_UnrelatedReturn }; 1261 ReasonSelector reasonSelector; 1262 1263 // The only reason these methods don't fall within their families is 1264 // due to unusual result types. 1265 if (unmatched->getResultType()->isObjCObjectPointerType()) { 1266 reasonSelector = R_UnrelatedReturn; 1267 } else { 1268 reasonSelector = R_NonObjectReturn; 1269 } 1270 1271 S.Diag(impl->getLocation(), errorID) << familySelector << reasonSelector; 1272 S.Diag(decl->getLocation(), noteID) << familySelector << reasonSelector; 1273 1274 return true; 1275} 1276 1277void Sema::WarnConflictingTypedMethods(ObjCMethodDecl *ImpMethodDecl, 1278 ObjCMethodDecl *MethodDecl, 1279 bool IsProtocolMethodDecl, 1280 bool IsOverridingMode) { 1281 if (getLangOptions().ObjCAutoRefCount && 1282 !IsOverridingMode && 1283 checkMethodFamilyMismatch(*this, ImpMethodDecl, MethodDecl)) 1284 return; 1285 1286 CheckMethodOverrideReturn(*this, ImpMethodDecl, MethodDecl, 1287 IsProtocolMethodDecl, IsOverridingMode, 1288 true); 1289 1290 for (ObjCMethodDecl::param_iterator IM = ImpMethodDecl->param_begin(), 1291 IF = MethodDecl->param_begin(), EM = ImpMethodDecl->param_end(); 1292 IM != EM; ++IM, ++IF) { 1293 CheckMethodOverrideParam(*this, ImpMethodDecl, MethodDecl, *IM, *IF, 1294 IsProtocolMethodDecl, IsOverridingMode, true); 1295 } 1296 1297 if (ImpMethodDecl->isVariadic() != MethodDecl->isVariadic()) { 1298 if (IsOverridingMode) 1299 Diag(ImpMethodDecl->getLocation(), 1300 diag::warn_conflicting_overriding_variadic); 1301 else 1302 Diag(ImpMethodDecl->getLocation(), diag::warn_conflicting_variadic); 1303 Diag(MethodDecl->getLocation(), diag::note_previous_declaration); 1304 } 1305} 1306 1307/// WarnExactTypedMethods - This routine issues a warning if method 1308/// implementation declaration matches exactly that of its declaration. 1309void Sema::WarnExactTypedMethods(ObjCMethodDecl *ImpMethodDecl, 1310 ObjCMethodDecl *MethodDecl, 1311 bool IsProtocolMethodDecl) { 1312 // don't issue warning when protocol method is optional because primary 1313 // class is not required to implement it and it is safe for protocol 1314 // to implement it. 1315 if (MethodDecl->getImplementationControl() == ObjCMethodDecl::Optional) 1316 return; 1317 // don't issue warning when primary class's method is 1318 // depecated/unavailable. 1319 if (MethodDecl->hasAttr<UnavailableAttr>() || 1320 MethodDecl->hasAttr<DeprecatedAttr>()) 1321 return; 1322 1323 bool match = CheckMethodOverrideReturn(*this, ImpMethodDecl, MethodDecl, 1324 IsProtocolMethodDecl, false, false); 1325 if (match) 1326 for (ObjCMethodDecl::param_iterator IM = ImpMethodDecl->param_begin(), 1327 IF = MethodDecl->param_begin(), EM = ImpMethodDecl->param_end(); 1328 IM != EM; ++IM, ++IF) { 1329 match = CheckMethodOverrideParam(*this, ImpMethodDecl, MethodDecl, 1330 *IM, *IF, 1331 IsProtocolMethodDecl, false, false); 1332 if (!match) 1333 break; 1334 } 1335 if (match) 1336 match = (ImpMethodDecl->isVariadic() == MethodDecl->isVariadic()); 1337 if (match) 1338 match = !(MethodDecl->isClassMethod() && 1339 MethodDecl->getSelector() == GetNullarySelector("load", Context)); 1340 1341 if (match) { 1342 Diag(ImpMethodDecl->getLocation(), 1343 diag::warn_category_method_impl_match); 1344 Diag(MethodDecl->getLocation(), diag::note_method_declared_at); 1345 } 1346} 1347 1348/// FIXME: Type hierarchies in Objective-C can be deep. We could most likely 1349/// improve the efficiency of selector lookups and type checking by associating 1350/// with each protocol / interface / category the flattened instance tables. If 1351/// we used an immutable set to keep the table then it wouldn't add significant 1352/// memory cost and it would be handy for lookups. 1353 1354/// CheckProtocolMethodDefs - This routine checks unimplemented methods 1355/// Declared in protocol, and those referenced by it. 1356void Sema::CheckProtocolMethodDefs(SourceLocation ImpLoc, 1357 ObjCProtocolDecl *PDecl, 1358 bool& IncompleteImpl, 1359 const llvm::DenseSet<Selector> &InsMap, 1360 const llvm::DenseSet<Selector> &ClsMap, 1361 ObjCContainerDecl *CDecl) { 1362 ObjCInterfaceDecl *IDecl; 1363 if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(CDecl)) 1364 IDecl = C->getClassInterface(); 1365 else 1366 IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl); 1367 assert (IDecl && "CheckProtocolMethodDefs - IDecl is null"); 1368 1369 ObjCInterfaceDecl *Super = IDecl->getSuperClass(); 1370 ObjCInterfaceDecl *NSIDecl = 0; 1371 if (getLangOptions().NeXTRuntime) { 1372 // check to see if class implements forwardInvocation method and objects 1373 // of this class are derived from 'NSProxy' so that to forward requests 1374 // from one object to another. 1375 // Under such conditions, which means that every method possible is 1376 // implemented in the class, we should not issue "Method definition not 1377 // found" warnings. 1378 // FIXME: Use a general GetUnarySelector method for this. 1379 IdentifierInfo* II = &Context.Idents.get("forwardInvocation"); 1380 Selector fISelector = Context.Selectors.getSelector(1, &II); 1381 if (InsMap.count(fISelector)) 1382 // Is IDecl derived from 'NSProxy'? If so, no instance methods 1383 // need be implemented in the implementation. 1384 NSIDecl = IDecl->lookupInheritedClass(&Context.Idents.get("NSProxy")); 1385 } 1386 1387 // If a method lookup fails locally we still need to look and see if 1388 // the method was implemented by a base class or an inherited 1389 // protocol. This lookup is slow, but occurs rarely in correct code 1390 // and otherwise would terminate in a warning. 1391 1392 // check unimplemented instance methods. 1393 if (!NSIDecl) 1394 for (ObjCProtocolDecl::instmeth_iterator I = PDecl->instmeth_begin(), 1395 E = PDecl->instmeth_end(); I != E; ++I) { 1396 ObjCMethodDecl *method = *I; 1397 if (method->getImplementationControl() != ObjCMethodDecl::Optional && 1398 !method->isSynthesized() && !InsMap.count(method->getSelector()) && 1399 (!Super || 1400 !Super->lookupInstanceMethod(method->getSelector()))) { 1401 // Ugly, but necessary. Method declared in protcol might have 1402 // have been synthesized due to a property declared in the class which 1403 // uses the protocol. 1404 ObjCMethodDecl *MethodInClass = 1405 IDecl->lookupInstanceMethod(method->getSelector()); 1406 if (!MethodInClass || !MethodInClass->isSynthesized()) { 1407 unsigned DIAG = diag::warn_unimplemented_protocol_method; 1408 if (Diags.getDiagnosticLevel(DIAG, ImpLoc) 1409 != Diagnostic::Ignored) { 1410 WarnUndefinedMethod(ImpLoc, method, IncompleteImpl, DIAG); 1411 Diag(method->getLocation(), diag::note_method_declared_at); 1412 Diag(CDecl->getLocation(), diag::note_required_for_protocol_at) 1413 << PDecl->getDeclName(); 1414 } 1415 } 1416 } 1417 } 1418 // check unimplemented class methods 1419 for (ObjCProtocolDecl::classmeth_iterator 1420 I = PDecl->classmeth_begin(), E = PDecl->classmeth_end(); 1421 I != E; ++I) { 1422 ObjCMethodDecl *method = *I; 1423 if (method->getImplementationControl() != ObjCMethodDecl::Optional && 1424 !ClsMap.count(method->getSelector()) && 1425 (!Super || !Super->lookupClassMethod(method->getSelector()))) { 1426 unsigned DIAG = diag::warn_unimplemented_protocol_method; 1427 if (Diags.getDiagnosticLevel(DIAG, ImpLoc) != Diagnostic::Ignored) { 1428 WarnUndefinedMethod(ImpLoc, method, IncompleteImpl, DIAG); 1429 Diag(method->getLocation(), diag::note_method_declared_at); 1430 Diag(IDecl->getLocation(), diag::note_required_for_protocol_at) << 1431 PDecl->getDeclName(); 1432 } 1433 } 1434 } 1435 // Check on this protocols's referenced protocols, recursively. 1436 for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 1437 E = PDecl->protocol_end(); PI != E; ++PI) 1438 CheckProtocolMethodDefs(ImpLoc, *PI, IncompleteImpl, InsMap, ClsMap, IDecl); 1439} 1440 1441/// MatchAllMethodDeclarations - Check methods declared in interface 1442/// or protocol against those declared in their implementations. 1443/// 1444void Sema::MatchAllMethodDeclarations(const llvm::DenseSet<Selector> &InsMap, 1445 const llvm::DenseSet<Selector> &ClsMap, 1446 llvm::DenseSet<Selector> &InsMapSeen, 1447 llvm::DenseSet<Selector> &ClsMapSeen, 1448 ObjCImplDecl* IMPDecl, 1449 ObjCContainerDecl* CDecl, 1450 bool &IncompleteImpl, 1451 bool ImmediateClass, 1452 bool WarnExactMatch) { 1453 // Check and see if instance methods in class interface have been 1454 // implemented in the implementation class. If so, their types match. 1455 for (ObjCInterfaceDecl::instmeth_iterator I = CDecl->instmeth_begin(), 1456 E = CDecl->instmeth_end(); I != E; ++I) { 1457 if (InsMapSeen.count((*I)->getSelector())) 1458 continue; 1459 InsMapSeen.insert((*I)->getSelector()); 1460 if (!(*I)->isSynthesized() && 1461 !InsMap.count((*I)->getSelector())) { 1462 if (ImmediateClass) 1463 WarnUndefinedMethod(IMPDecl->getLocation(), *I, IncompleteImpl, 1464 diag::note_undef_method_impl); 1465 continue; 1466 } else { 1467 ObjCMethodDecl *ImpMethodDecl = 1468 IMPDecl->getInstanceMethod((*I)->getSelector()); 1469 ObjCMethodDecl *MethodDecl = 1470 CDecl->getInstanceMethod((*I)->getSelector()); 1471 assert(MethodDecl && 1472 "MethodDecl is null in ImplMethodsVsClassMethods"); 1473 // ImpMethodDecl may be null as in a @dynamic property. 1474 if (ImpMethodDecl) { 1475 if (!WarnExactMatch) 1476 WarnConflictingTypedMethods(ImpMethodDecl, MethodDecl, 1477 isa<ObjCProtocolDecl>(CDecl)); 1478 else 1479 WarnExactTypedMethods(ImpMethodDecl, MethodDecl, 1480 isa<ObjCProtocolDecl>(CDecl)); 1481 } 1482 } 1483 } 1484 1485 // Check and see if class methods in class interface have been 1486 // implemented in the implementation class. If so, their types match. 1487 for (ObjCInterfaceDecl::classmeth_iterator 1488 I = CDecl->classmeth_begin(), E = CDecl->classmeth_end(); I != E; ++I) { 1489 if (ClsMapSeen.count((*I)->getSelector())) 1490 continue; 1491 ClsMapSeen.insert((*I)->getSelector()); 1492 if (!ClsMap.count((*I)->getSelector())) { 1493 if (ImmediateClass) 1494 WarnUndefinedMethod(IMPDecl->getLocation(), *I, IncompleteImpl, 1495 diag::note_undef_method_impl); 1496 } else { 1497 ObjCMethodDecl *ImpMethodDecl = 1498 IMPDecl->getClassMethod((*I)->getSelector()); 1499 ObjCMethodDecl *MethodDecl = 1500 CDecl->getClassMethod((*I)->getSelector()); 1501 if (!WarnExactMatch) 1502 WarnConflictingTypedMethods(ImpMethodDecl, MethodDecl, 1503 isa<ObjCProtocolDecl>(CDecl)); 1504 else 1505 WarnExactTypedMethods(ImpMethodDecl, MethodDecl, 1506 isa<ObjCProtocolDecl>(CDecl)); 1507 } 1508 } 1509 1510 if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl> (CDecl)) { 1511 // Also methods in class extensions need be looked at next. 1512 for (const ObjCCategoryDecl *ClsExtDecl = I->getFirstClassExtension(); 1513 ClsExtDecl; ClsExtDecl = ClsExtDecl->getNextClassExtension()) 1514 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen, 1515 IMPDecl, 1516 const_cast<ObjCCategoryDecl *>(ClsExtDecl), 1517 IncompleteImpl, false, WarnExactMatch); 1518 1519 // Check for any implementation of a methods declared in protocol. 1520 for (ObjCInterfaceDecl::all_protocol_iterator 1521 PI = I->all_referenced_protocol_begin(), 1522 E = I->all_referenced_protocol_end(); PI != E; ++PI) 1523 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen, 1524 IMPDecl, 1525 (*PI), IncompleteImpl, false, WarnExactMatch); 1526 1527 // FIXME. For now, we are not checking for extact match of methods 1528 // in category implementation and its primary class's super class. 1529 if (!WarnExactMatch && I->getSuperClass()) 1530 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen, 1531 IMPDecl, 1532 I->getSuperClass(), IncompleteImpl, false); 1533 } 1534} 1535 1536/// CheckCategoryVsClassMethodMatches - Checks that methods implemented in 1537/// category matches with those implemented in its primary class and 1538/// warns each time an exact match is found. 1539void Sema::CheckCategoryVsClassMethodMatches( 1540 ObjCCategoryImplDecl *CatIMPDecl) { 1541 llvm::DenseSet<Selector> InsMap, ClsMap; 1542 1543 for (ObjCImplementationDecl::instmeth_iterator 1544 I = CatIMPDecl->instmeth_begin(), 1545 E = CatIMPDecl->instmeth_end(); I!=E; ++I) 1546 InsMap.insert((*I)->getSelector()); 1547 1548 for (ObjCImplementationDecl::classmeth_iterator 1549 I = CatIMPDecl->classmeth_begin(), 1550 E = CatIMPDecl->classmeth_end(); I != E; ++I) 1551 ClsMap.insert((*I)->getSelector()); 1552 if (InsMap.empty() && ClsMap.empty()) 1553 return; 1554 1555 // Get category's primary class. 1556 ObjCCategoryDecl *CatDecl = CatIMPDecl->getCategoryDecl(); 1557 if (!CatDecl) 1558 return; 1559 ObjCInterfaceDecl *IDecl = CatDecl->getClassInterface(); 1560 if (!IDecl) 1561 return; 1562 llvm::DenseSet<Selector> InsMapSeen, ClsMapSeen; 1563 bool IncompleteImpl = false; 1564 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen, 1565 CatIMPDecl, IDecl, 1566 IncompleteImpl, false, true /*WarnExactMatch*/); 1567} 1568 1569void Sema::ImplMethodsVsClassMethods(Scope *S, ObjCImplDecl* IMPDecl, 1570 ObjCContainerDecl* CDecl, 1571 bool IncompleteImpl) { 1572 llvm::DenseSet<Selector> InsMap; 1573 // Check and see if instance methods in class interface have been 1574 // implemented in the implementation class. 1575 for (ObjCImplementationDecl::instmeth_iterator 1576 I = IMPDecl->instmeth_begin(), E = IMPDecl->instmeth_end(); I!=E; ++I) 1577 InsMap.insert((*I)->getSelector()); 1578 1579 // Check and see if properties declared in the interface have either 1) 1580 // an implementation or 2) there is a @synthesize/@dynamic implementation 1581 // of the property in the @implementation. 1582 if (isa<ObjCInterfaceDecl>(CDecl) && 1583 !(LangOpts.ObjCDefaultSynthProperties && LangOpts.ObjCNonFragileABI2)) 1584 DiagnoseUnimplementedProperties(S, IMPDecl, CDecl, InsMap); 1585 1586 llvm::DenseSet<Selector> ClsMap; 1587 for (ObjCImplementationDecl::classmeth_iterator 1588 I = IMPDecl->classmeth_begin(), 1589 E = IMPDecl->classmeth_end(); I != E; ++I) 1590 ClsMap.insert((*I)->getSelector()); 1591 1592 // Check for type conflict of methods declared in a class/protocol and 1593 // its implementation; if any. 1594 llvm::DenseSet<Selector> InsMapSeen, ClsMapSeen; 1595 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen, 1596 IMPDecl, CDecl, 1597 IncompleteImpl, true); 1598 1599 // check all methods implemented in category against those declared 1600 // in its primary class. 1601 if (ObjCCategoryImplDecl *CatDecl = 1602 dyn_cast<ObjCCategoryImplDecl>(IMPDecl)) 1603 CheckCategoryVsClassMethodMatches(CatDecl); 1604 1605 // Check the protocol list for unimplemented methods in the @implementation 1606 // class. 1607 // Check and see if class methods in class interface have been 1608 // implemented in the implementation class. 1609 1610 if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl> (CDecl)) { 1611 for (ObjCInterfaceDecl::all_protocol_iterator 1612 PI = I->all_referenced_protocol_begin(), 1613 E = I->all_referenced_protocol_end(); PI != E; ++PI) 1614 CheckProtocolMethodDefs(IMPDecl->getLocation(), *PI, IncompleteImpl, 1615 InsMap, ClsMap, I); 1616 // Check class extensions (unnamed categories) 1617 for (const ObjCCategoryDecl *Categories = I->getFirstClassExtension(); 1618 Categories; Categories = Categories->getNextClassExtension()) 1619 ImplMethodsVsClassMethods(S, IMPDecl, 1620 const_cast<ObjCCategoryDecl*>(Categories), 1621 IncompleteImpl); 1622 } else if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(CDecl)) { 1623 // For extended class, unimplemented methods in its protocols will 1624 // be reported in the primary class. 1625 if (!C->IsClassExtension()) { 1626 for (ObjCCategoryDecl::protocol_iterator PI = C->protocol_begin(), 1627 E = C->protocol_end(); PI != E; ++PI) 1628 CheckProtocolMethodDefs(IMPDecl->getLocation(), *PI, IncompleteImpl, 1629 InsMap, ClsMap, CDecl); 1630 // Report unimplemented properties in the category as well. 1631 // When reporting on missing setter/getters, do not report when 1632 // setter/getter is implemented in category's primary class 1633 // implementation. 1634 if (ObjCInterfaceDecl *ID = C->getClassInterface()) 1635 if (ObjCImplDecl *IMP = ID->getImplementation()) { 1636 for (ObjCImplementationDecl::instmeth_iterator 1637 I = IMP->instmeth_begin(), E = IMP->instmeth_end(); I!=E; ++I) 1638 InsMap.insert((*I)->getSelector()); 1639 } 1640 DiagnoseUnimplementedProperties(S, IMPDecl, CDecl, InsMap); 1641 } 1642 } else 1643 assert(false && "invalid ObjCContainerDecl type."); 1644} 1645 1646/// ActOnForwardClassDeclaration - 1647Decl * 1648Sema::ActOnForwardClassDeclaration(SourceLocation AtClassLoc, 1649 IdentifierInfo **IdentList, 1650 SourceLocation *IdentLocs, 1651 unsigned NumElts) { 1652 SmallVector<ObjCInterfaceDecl*, 32> Interfaces; 1653 1654 for (unsigned i = 0; i != NumElts; ++i) { 1655 // Check for another declaration kind with the same name. 1656 NamedDecl *PrevDecl 1657 = LookupSingleName(TUScope, IdentList[i], IdentLocs[i], 1658 LookupOrdinaryName, ForRedeclaration); 1659 if (PrevDecl && PrevDecl->isTemplateParameter()) { 1660 // Maybe we will complain about the shadowed template parameter. 1661 DiagnoseTemplateParameterShadow(AtClassLoc, PrevDecl); 1662 // Just pretend that we didn't see the previous declaration. 1663 PrevDecl = 0; 1664 } 1665 1666 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) { 1667 // GCC apparently allows the following idiom: 1668 // 1669 // typedef NSObject < XCElementTogglerP > XCElementToggler; 1670 // @class XCElementToggler; 1671 // 1672 // FIXME: Make an extension? 1673 TypedefNameDecl *TDD = dyn_cast<TypedefNameDecl>(PrevDecl); 1674 if (!TDD || !TDD->getUnderlyingType()->isObjCObjectType()) { 1675 Diag(AtClassLoc, diag::err_redefinition_different_kind) << IdentList[i]; 1676 Diag(PrevDecl->getLocation(), diag::note_previous_definition); 1677 } else { 1678 // a forward class declaration matching a typedef name of a class refers 1679 // to the underlying class. 1680 if (const ObjCObjectType *OI = 1681 TDD->getUnderlyingType()->getAs<ObjCObjectType>()) 1682 PrevDecl = OI->getInterface(); 1683 } 1684 } 1685 ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl); 1686 if (!IDecl) { // Not already seen? Make a forward decl. 1687 IDecl = ObjCInterfaceDecl::Create(Context, CurContext, AtClassLoc, 1688 IdentList[i], IdentLocs[i], true); 1689 1690 // Push the ObjCInterfaceDecl on the scope chain but do *not* add it to 1691 // the current DeclContext. This prevents clients that walk DeclContext 1692 // from seeing the imaginary ObjCInterfaceDecl until it is actually 1693 // declared later (if at all). We also take care to explicitly make 1694 // sure this declaration is visible for name lookup. 1695 PushOnScopeChains(IDecl, TUScope, false); 1696 CurContext->makeDeclVisibleInContext(IDecl, true); 1697 } 1698 1699 Interfaces.push_back(IDecl); 1700 } 1701 1702 assert(Interfaces.size() == NumElts); 1703 ObjCClassDecl *CDecl = ObjCClassDecl::Create(Context, CurContext, AtClassLoc, 1704 Interfaces.data(), IdentLocs, 1705 Interfaces.size()); 1706 CurContext->addDecl(CDecl); 1707 CheckObjCDeclScope(CDecl); 1708 return CDecl; 1709} 1710 1711static bool tryMatchRecordTypes(ASTContext &Context, 1712 Sema::MethodMatchStrategy strategy, 1713 const Type *left, const Type *right); 1714 1715static bool matchTypes(ASTContext &Context, Sema::MethodMatchStrategy strategy, 1716 QualType leftQT, QualType rightQT) { 1717 const Type *left = 1718 Context.getCanonicalType(leftQT).getUnqualifiedType().getTypePtr(); 1719 const Type *right = 1720 Context.getCanonicalType(rightQT).getUnqualifiedType().getTypePtr(); 1721 1722 if (left == right) return true; 1723 1724 // If we're doing a strict match, the types have to match exactly. 1725 if (strategy == Sema::MMS_strict) return false; 1726 1727 if (left->isIncompleteType() || right->isIncompleteType()) return false; 1728 1729 // Otherwise, use this absurdly complicated algorithm to try to 1730 // validate the basic, low-level compatibility of the two types. 1731 1732 // As a minimum, require the sizes and alignments to match. 1733 if (Context.getTypeInfo(left) != Context.getTypeInfo(right)) 1734 return false; 1735 1736 // Consider all the kinds of non-dependent canonical types: 1737 // - functions and arrays aren't possible as return and parameter types 1738 1739 // - vector types of equal size can be arbitrarily mixed 1740 if (isa<VectorType>(left)) return isa<VectorType>(right); 1741 if (isa<VectorType>(right)) return false; 1742 1743 // - references should only match references of identical type 1744 // - structs, unions, and Objective-C objects must match more-or-less 1745 // exactly 1746 // - everything else should be a scalar 1747 if (!left->isScalarType() || !right->isScalarType()) 1748 return tryMatchRecordTypes(Context, strategy, left, right); 1749 1750 // Make scalars agree in kind, except count bools as chars. 1751 Type::ScalarTypeKind leftSK = left->getScalarTypeKind(); 1752 Type::ScalarTypeKind rightSK = right->getScalarTypeKind(); 1753 if (leftSK == Type::STK_Bool) leftSK = Type::STK_Integral; 1754 if (rightSK == Type::STK_Bool) rightSK = Type::STK_Integral; 1755 1756 // Note that data member pointers and function member pointers don't 1757 // intermix because of the size differences. 1758 1759 return (leftSK == rightSK); 1760} 1761 1762static bool tryMatchRecordTypes(ASTContext &Context, 1763 Sema::MethodMatchStrategy strategy, 1764 const Type *lt, const Type *rt) { 1765 assert(lt && rt && lt != rt); 1766 1767 if (!isa<RecordType>(lt) || !isa<RecordType>(rt)) return false; 1768 RecordDecl *left = cast<RecordType>(lt)->getDecl(); 1769 RecordDecl *right = cast<RecordType>(rt)->getDecl(); 1770 1771 // Require union-hood to match. 1772 if (left->isUnion() != right->isUnion()) return false; 1773 1774 // Require an exact match if either is non-POD. 1775 if ((isa<CXXRecordDecl>(left) && !cast<CXXRecordDecl>(left)->isPOD()) || 1776 (isa<CXXRecordDecl>(right) && !cast<CXXRecordDecl>(right)->isPOD())) 1777 return false; 1778 1779 // Require size and alignment to match. 1780 if (Context.getTypeInfo(lt) != Context.getTypeInfo(rt)) return false; 1781 1782 // Require fields to match. 1783 RecordDecl::field_iterator li = left->field_begin(), le = left->field_end(); 1784 RecordDecl::field_iterator ri = right->field_begin(), re = right->field_end(); 1785 for (; li != le && ri != re; ++li, ++ri) { 1786 if (!matchTypes(Context, strategy, li->getType(), ri->getType())) 1787 return false; 1788 } 1789 return (li == le && ri == re); 1790} 1791 1792/// MatchTwoMethodDeclarations - Checks that two methods have matching type and 1793/// returns true, or false, accordingly. 1794/// TODO: Handle protocol list; such as id<p1,p2> in type comparisons 1795bool Sema::MatchTwoMethodDeclarations(const ObjCMethodDecl *left, 1796 const ObjCMethodDecl *right, 1797 MethodMatchStrategy strategy) { 1798 if (!matchTypes(Context, strategy, 1799 left->getResultType(), right->getResultType())) 1800 return false; 1801 1802 if (getLangOptions().ObjCAutoRefCount && 1803 (left->hasAttr<NSReturnsRetainedAttr>() 1804 != right->hasAttr<NSReturnsRetainedAttr>() || 1805 left->hasAttr<NSConsumesSelfAttr>() 1806 != right->hasAttr<NSConsumesSelfAttr>())) 1807 return false; 1808 1809 ObjCMethodDecl::param_iterator 1810 li = left->param_begin(), le = left->param_end(), ri = right->param_begin(); 1811 1812 for (; li != le; ++li, ++ri) { 1813 assert(ri != right->param_end() && "Param mismatch"); 1814 ParmVarDecl *lparm = *li, *rparm = *ri; 1815 1816 if (!matchTypes(Context, strategy, lparm->getType(), rparm->getType())) 1817 return false; 1818 1819 if (getLangOptions().ObjCAutoRefCount && 1820 lparm->hasAttr<NSConsumedAttr>() != rparm->hasAttr<NSConsumedAttr>()) 1821 return false; 1822 } 1823 return true; 1824} 1825 1826/// \brief Read the contents of the method pool for a given selector from 1827/// external storage. 1828/// 1829/// This routine should only be called once, when the method pool has no entry 1830/// for this selector. 1831Sema::GlobalMethodPool::iterator Sema::ReadMethodPool(Selector Sel) { 1832 assert(ExternalSource && "We need an external AST source"); 1833 assert(MethodPool.find(Sel) == MethodPool.end() && 1834 "Selector data already loaded into the method pool"); 1835 1836 // Read the method list from the external source. 1837 GlobalMethods Methods = ExternalSource->ReadMethodPool(Sel); 1838 1839 return MethodPool.insert(std::make_pair(Sel, Methods)).first; 1840} 1841 1842void Sema::AddMethodToGlobalPool(ObjCMethodDecl *Method, bool impl, 1843 bool instance) { 1844 GlobalMethodPool::iterator Pos = MethodPool.find(Method->getSelector()); 1845 if (Pos == MethodPool.end()) { 1846 if (ExternalSource) 1847 Pos = ReadMethodPool(Method->getSelector()); 1848 else 1849 Pos = MethodPool.insert(std::make_pair(Method->getSelector(), 1850 GlobalMethods())).first; 1851 } 1852 Method->setDefined(impl); 1853 ObjCMethodList &Entry = instance ? Pos->second.first : Pos->second.second; 1854 if (Entry.Method == 0) { 1855 // Haven't seen a method with this selector name yet - add it. 1856 Entry.Method = Method; 1857 Entry.Next = 0; 1858 return; 1859 } 1860 1861 // We've seen a method with this name, see if we have already seen this type 1862 // signature. 1863 for (ObjCMethodList *List = &Entry; List; List = List->Next) { 1864 bool match = MatchTwoMethodDeclarations(Method, List->Method); 1865 1866 if (match) { 1867 ObjCMethodDecl *PrevObjCMethod = List->Method; 1868 PrevObjCMethod->setDefined(impl); 1869 // If a method is deprecated, push it in the global pool. 1870 // This is used for better diagnostics. 1871 if (Method->isDeprecated()) { 1872 if (!PrevObjCMethod->isDeprecated()) 1873 List->Method = Method; 1874 } 1875 // If new method is unavailable, push it into global pool 1876 // unless previous one is deprecated. 1877 if (Method->isUnavailable()) { 1878 if (PrevObjCMethod->getAvailability() < AR_Deprecated) 1879 List->Method = Method; 1880 } 1881 return; 1882 } 1883 } 1884 1885 // We have a new signature for an existing method - add it. 1886 // This is extremely rare. Only 1% of Cocoa selectors are "overloaded". 1887 ObjCMethodList *Mem = BumpAlloc.Allocate<ObjCMethodList>(); 1888 Entry.Next = new (Mem) ObjCMethodList(Method, Entry.Next); 1889} 1890 1891/// Determines if this is an "acceptable" loose mismatch in the global 1892/// method pool. This exists mostly as a hack to get around certain 1893/// global mismatches which we can't afford to make warnings / errors. 1894/// Really, what we want is a way to take a method out of the global 1895/// method pool. 1896static bool isAcceptableMethodMismatch(ObjCMethodDecl *chosen, 1897 ObjCMethodDecl *other) { 1898 if (!chosen->isInstanceMethod()) 1899 return false; 1900 1901 Selector sel = chosen->getSelector(); 1902 if (!sel.isUnarySelector() || sel.getNameForSlot(0) != "length") 1903 return false; 1904 1905 // Don't complain about mismatches for -length if the method we 1906 // chose has an integral result type. 1907 return (chosen->getResultType()->isIntegerType()); 1908} 1909 1910ObjCMethodDecl *Sema::LookupMethodInGlobalPool(Selector Sel, SourceRange R, 1911 bool receiverIdOrClass, 1912 bool warn, bool instance) { 1913 GlobalMethodPool::iterator Pos = MethodPool.find(Sel); 1914 if (Pos == MethodPool.end()) { 1915 if (ExternalSource) 1916 Pos = ReadMethodPool(Sel); 1917 else 1918 return 0; 1919 } 1920 1921 ObjCMethodList &MethList = instance ? Pos->second.first : Pos->second.second; 1922 1923 if (warn && MethList.Method && MethList.Next) { 1924 bool issueDiagnostic = false, issueError = false; 1925 1926 // We support a warning which complains about *any* difference in 1927 // method signature. 1928 bool strictSelectorMatch = 1929 (receiverIdOrClass && warn && 1930 (Diags.getDiagnosticLevel(diag::warn_strict_multiple_method_decl, 1931 R.getBegin()) != 1932 Diagnostic::Ignored)); 1933 if (strictSelectorMatch) 1934 for (ObjCMethodList *Next = MethList.Next; Next; Next = Next->Next) { 1935 if (!MatchTwoMethodDeclarations(MethList.Method, Next->Method, 1936 MMS_strict)) { 1937 issueDiagnostic = true; 1938 break; 1939 } 1940 } 1941 1942 // If we didn't see any strict differences, we won't see any loose 1943 // differences. In ARC, however, we also need to check for loose 1944 // mismatches, because most of them are errors. 1945 if (!strictSelectorMatch || 1946 (issueDiagnostic && getLangOptions().ObjCAutoRefCount)) 1947 for (ObjCMethodList *Next = MethList.Next; Next; Next = Next->Next) { 1948 // This checks if the methods differ in type mismatch. 1949 if (!MatchTwoMethodDeclarations(MethList.Method, Next->Method, 1950 MMS_loose) && 1951 !isAcceptableMethodMismatch(MethList.Method, Next->Method)) { 1952 issueDiagnostic = true; 1953 if (getLangOptions().ObjCAutoRefCount) 1954 issueError = true; 1955 break; 1956 } 1957 } 1958 1959 if (issueDiagnostic) { 1960 if (issueError) 1961 Diag(R.getBegin(), diag::err_arc_multiple_method_decl) << Sel << R; 1962 else if (strictSelectorMatch) 1963 Diag(R.getBegin(), diag::warn_strict_multiple_method_decl) << Sel << R; 1964 else 1965 Diag(R.getBegin(), diag::warn_multiple_method_decl) << Sel << R; 1966 1967 Diag(MethList.Method->getLocStart(), 1968 issueError ? diag::note_possibility : diag::note_using) 1969 << MethList.Method->getSourceRange(); 1970 for (ObjCMethodList *Next = MethList.Next; Next; Next = Next->Next) 1971 Diag(Next->Method->getLocStart(), diag::note_also_found) 1972 << Next->Method->getSourceRange(); 1973 } 1974 } 1975 return MethList.Method; 1976} 1977 1978ObjCMethodDecl *Sema::LookupImplementedMethodInGlobalPool(Selector Sel) { 1979 GlobalMethodPool::iterator Pos = MethodPool.find(Sel); 1980 if (Pos == MethodPool.end()) 1981 return 0; 1982 1983 GlobalMethods &Methods = Pos->second; 1984 1985 if (Methods.first.Method && Methods.first.Method->isDefined()) 1986 return Methods.first.Method; 1987 if (Methods.second.Method && Methods.second.Method->isDefined()) 1988 return Methods.second.Method; 1989 return 0; 1990} 1991 1992/// CompareMethodParamsInBaseAndSuper - This routine compares methods with 1993/// identical selector names in current and its super classes and issues 1994/// a warning if any of their argument types are incompatible. 1995void Sema::CompareMethodParamsInBaseAndSuper(Decl *ClassDecl, 1996 ObjCMethodDecl *Method, 1997 bool IsInstance) { 1998 ObjCInterfaceDecl *ID = dyn_cast<ObjCInterfaceDecl>(ClassDecl); 1999 if (ID == 0) return; 2000 2001 while (ObjCInterfaceDecl *SD = ID->getSuperClass()) { 2002 ObjCMethodDecl *SuperMethodDecl = 2003 SD->lookupMethod(Method->getSelector(), IsInstance); 2004 if (SuperMethodDecl == 0) { 2005 ID = SD; 2006 continue; 2007 } 2008 ObjCMethodDecl::param_iterator ParamI = Method->param_begin(), 2009 E = Method->param_end(); 2010 ObjCMethodDecl::param_iterator PrevI = SuperMethodDecl->param_begin(); 2011 for (; ParamI != E; ++ParamI, ++PrevI) { 2012 // Number of parameters are the same and is guaranteed by selector match. 2013 assert(PrevI != SuperMethodDecl->param_end() && "Param mismatch"); 2014 QualType T1 = Context.getCanonicalType((*ParamI)->getType()); 2015 QualType T2 = Context.getCanonicalType((*PrevI)->getType()); 2016 // If type of argument of method in this class does not match its 2017 // respective argument type in the super class method, issue warning; 2018 if (!Context.typesAreCompatible(T1, T2)) { 2019 Diag((*ParamI)->getLocation(), diag::ext_typecheck_base_super) 2020 << T1 << T2; 2021 Diag(SuperMethodDecl->getLocation(), diag::note_previous_declaration); 2022 return; 2023 } 2024 } 2025 ID = SD; 2026 } 2027} 2028 2029/// DiagnoseDuplicateIvars - 2030/// Check for duplicate ivars in the entire class at the start of 2031/// @implementation. This becomes necesssary because class extension can 2032/// add ivars to a class in random order which will not be known until 2033/// class's @implementation is seen. 2034void Sema::DiagnoseDuplicateIvars(ObjCInterfaceDecl *ID, 2035 ObjCInterfaceDecl *SID) { 2036 for (ObjCInterfaceDecl::ivar_iterator IVI = ID->ivar_begin(), 2037 IVE = ID->ivar_end(); IVI != IVE; ++IVI) { 2038 ObjCIvarDecl* Ivar = (*IVI); 2039 if (Ivar->isInvalidDecl()) 2040 continue; 2041 if (IdentifierInfo *II = Ivar->getIdentifier()) { 2042 ObjCIvarDecl* prevIvar = SID->lookupInstanceVariable(II); 2043 if (prevIvar) { 2044 Diag(Ivar->getLocation(), diag::err_duplicate_member) << II; 2045 Diag(prevIvar->getLocation(), diag::note_previous_declaration); 2046 Ivar->setInvalidDecl(); 2047 } 2048 } 2049 } 2050} 2051 2052// Note: For class/category implemenations, allMethods/allProperties is 2053// always null. 2054void Sema::ActOnAtEnd(Scope *S, SourceRange AtEnd, 2055 Decl *ClassDecl, 2056 Decl **allMethods, unsigned allNum, 2057 Decl **allProperties, unsigned pNum, 2058 DeclGroupPtrTy *allTUVars, unsigned tuvNum) { 2059 // FIXME: If we don't have a ClassDecl, we have an error. We should consider 2060 // always passing in a decl. If the decl has an error, isInvalidDecl() 2061 // should be true. 2062 if (!ClassDecl) 2063 return; 2064 2065 bool isInterfaceDeclKind = 2066 isa<ObjCInterfaceDecl>(ClassDecl) || isa<ObjCCategoryDecl>(ClassDecl) 2067 || isa<ObjCProtocolDecl>(ClassDecl); 2068 bool checkIdenticalMethods = isa<ObjCImplementationDecl>(ClassDecl); 2069 2070 if (!isInterfaceDeclKind && AtEnd.isInvalid()) { 2071 // FIXME: This is wrong. We shouldn't be pretending that there is 2072 // an '@end' in the declaration. 2073 SourceLocation L = ClassDecl->getLocation(); 2074 AtEnd.setBegin(L); 2075 AtEnd.setEnd(L); 2076 Diag(L, diag::err_missing_atend); 2077 } 2078 2079 // FIXME: Remove these and use the ObjCContainerDecl/DeclContext. 2080 llvm::DenseMap<Selector, const ObjCMethodDecl*> InsMap; 2081 llvm::DenseMap<Selector, const ObjCMethodDecl*> ClsMap; 2082 2083 for (unsigned i = 0; i < allNum; i++ ) { 2084 ObjCMethodDecl *Method = 2085 cast_or_null<ObjCMethodDecl>(allMethods[i]); 2086 2087 if (!Method) continue; // Already issued a diagnostic. 2088 if (Method->isInstanceMethod()) { 2089 /// Check for instance method of the same name with incompatible types 2090 const ObjCMethodDecl *&PrevMethod = InsMap[Method->getSelector()]; 2091 bool match = PrevMethod ? MatchTwoMethodDeclarations(Method, PrevMethod) 2092 : false; 2093 if ((isInterfaceDeclKind && PrevMethod && !match) 2094 || (checkIdenticalMethods && match)) { 2095 Diag(Method->getLocation(), diag::err_duplicate_method_decl) 2096 << Method->getDeclName(); 2097 Diag(PrevMethod->getLocation(), diag::note_previous_declaration); 2098 Method->setInvalidDecl(); 2099 } else { 2100 InsMap[Method->getSelector()] = Method; 2101 /// The following allows us to typecheck messages to "id". 2102 AddInstanceMethodToGlobalPool(Method); 2103 // verify that the instance method conforms to the same definition of 2104 // parent methods if it shadows one. 2105 CompareMethodParamsInBaseAndSuper(ClassDecl, Method, true); 2106 } 2107 } else { 2108 /// Check for class method of the same name with incompatible types 2109 const ObjCMethodDecl *&PrevMethod = ClsMap[Method->getSelector()]; 2110 bool match = PrevMethod ? MatchTwoMethodDeclarations(Method, PrevMethod) 2111 : false; 2112 if ((isInterfaceDeclKind && PrevMethod && !match) 2113 || (checkIdenticalMethods && match)) { 2114 Diag(Method->getLocation(), diag::err_duplicate_method_decl) 2115 << Method->getDeclName(); 2116 Diag(PrevMethod->getLocation(), diag::note_previous_declaration); 2117 Method->setInvalidDecl(); 2118 } else { 2119 ClsMap[Method->getSelector()] = Method; 2120 /// The following allows us to typecheck messages to "Class". 2121 AddFactoryMethodToGlobalPool(Method); 2122 // verify that the class method conforms to the same definition of 2123 // parent methods if it shadows one. 2124 CompareMethodParamsInBaseAndSuper(ClassDecl, Method, false); 2125 } 2126 } 2127 } 2128 if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 2129 // Compares properties declared in this class to those of its 2130 // super class. 2131 ComparePropertiesInBaseAndSuper(I); 2132 CompareProperties(I, I); 2133 } else if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 2134 // Categories are used to extend the class by declaring new methods. 2135 // By the same token, they are also used to add new properties. No 2136 // need to compare the added property to those in the class. 2137 2138 // Compare protocol properties with those in category 2139 CompareProperties(C, C); 2140 if (C->IsClassExtension()) { 2141 ObjCInterfaceDecl *CCPrimary = C->getClassInterface(); 2142 DiagnoseClassExtensionDupMethods(C, CCPrimary); 2143 } 2144 } 2145 if (ObjCContainerDecl *CDecl = dyn_cast<ObjCContainerDecl>(ClassDecl)) { 2146 if (CDecl->getIdentifier()) 2147 // ProcessPropertyDecl is responsible for diagnosing conflicts with any 2148 // user-defined setter/getter. It also synthesizes setter/getter methods 2149 // and adds them to the DeclContext and global method pools. 2150 for (ObjCContainerDecl::prop_iterator I = CDecl->prop_begin(), 2151 E = CDecl->prop_end(); 2152 I != E; ++I) 2153 ProcessPropertyDecl(*I, CDecl); 2154 CDecl->setAtEndRange(AtEnd); 2155 } 2156 if (ObjCImplementationDecl *IC=dyn_cast<ObjCImplementationDecl>(ClassDecl)) { 2157 IC->setAtEndRange(AtEnd); 2158 if (ObjCInterfaceDecl* IDecl = IC->getClassInterface()) { 2159 // Any property declared in a class extension might have user 2160 // declared setter or getter in current class extension or one 2161 // of the other class extensions. Mark them as synthesized as 2162 // property will be synthesized when property with same name is 2163 // seen in the @implementation. 2164 for (const ObjCCategoryDecl *ClsExtDecl = 2165 IDecl->getFirstClassExtension(); 2166 ClsExtDecl; ClsExtDecl = ClsExtDecl->getNextClassExtension()) { 2167 for (ObjCContainerDecl::prop_iterator I = ClsExtDecl->prop_begin(), 2168 E = ClsExtDecl->prop_end(); I != E; ++I) { 2169 ObjCPropertyDecl *Property = (*I); 2170 // Skip over properties declared @dynamic 2171 if (const ObjCPropertyImplDecl *PIDecl 2172 = IC->FindPropertyImplDecl(Property->getIdentifier())) 2173 if (PIDecl->getPropertyImplementation() 2174 == ObjCPropertyImplDecl::Dynamic) 2175 continue; 2176 2177 for (const ObjCCategoryDecl *CExtDecl = 2178 IDecl->getFirstClassExtension(); 2179 CExtDecl; CExtDecl = CExtDecl->getNextClassExtension()) { 2180 if (ObjCMethodDecl *GetterMethod = 2181 CExtDecl->getInstanceMethod(Property->getGetterName())) 2182 GetterMethod->setSynthesized(true); 2183 if (!Property->isReadOnly()) 2184 if (ObjCMethodDecl *SetterMethod = 2185 CExtDecl->getInstanceMethod(Property->getSetterName())) 2186 SetterMethod->setSynthesized(true); 2187 } 2188 } 2189 } 2190 2191 if (LangOpts.ObjCDefaultSynthProperties && 2192 LangOpts.ObjCNonFragileABI2) 2193 DefaultSynthesizeProperties(S, IC, IDecl); 2194 ImplMethodsVsClassMethods(S, IC, IDecl); 2195 AtomicPropertySetterGetterRules(IC, IDecl); 2196 DiagnoseOwningPropertyGetterSynthesis(IC); 2197 2198 if (LangOpts.ObjCNonFragileABI2) 2199 while (IDecl->getSuperClass()) { 2200 DiagnoseDuplicateIvars(IDecl, IDecl->getSuperClass()); 2201 IDecl = IDecl->getSuperClass(); 2202 } 2203 } 2204 SetIvarInitializers(IC); 2205 } else if (ObjCCategoryImplDecl* CatImplClass = 2206 dyn_cast<ObjCCategoryImplDecl>(ClassDecl)) { 2207 CatImplClass->setAtEndRange(AtEnd); 2208 2209 // Find category interface decl and then check that all methods declared 2210 // in this interface are implemented in the category @implementation. 2211 if (ObjCInterfaceDecl* IDecl = CatImplClass->getClassInterface()) { 2212 for (ObjCCategoryDecl *Categories = IDecl->getCategoryList(); 2213 Categories; Categories = Categories->getNextClassCategory()) { 2214 if (Categories->getIdentifier() == CatImplClass->getIdentifier()) { 2215 ImplMethodsVsClassMethods(S, CatImplClass, Categories); 2216 break; 2217 } 2218 } 2219 } 2220 } 2221 if (isInterfaceDeclKind) { 2222 // Reject invalid vardecls. 2223 for (unsigned i = 0; i != tuvNum; i++) { 2224 DeclGroupRef DG = allTUVars[i].getAsVal<DeclGroupRef>(); 2225 for (DeclGroupRef::iterator I = DG.begin(), E = DG.end(); I != E; ++I) 2226 if (VarDecl *VDecl = dyn_cast<VarDecl>(*I)) { 2227 if (!VDecl->hasExternalStorage()) 2228 Diag(VDecl->getLocation(), diag::err_objc_var_decl_inclass); 2229 } 2230 } 2231 } 2232} 2233 2234 2235/// CvtQTToAstBitMask - utility routine to produce an AST bitmask for 2236/// objective-c's type qualifier from the parser version of the same info. 2237static Decl::ObjCDeclQualifier 2238CvtQTToAstBitMask(ObjCDeclSpec::ObjCDeclQualifier PQTVal) { 2239 return (Decl::ObjCDeclQualifier) (unsigned) PQTVal; 2240} 2241 2242static inline 2243bool containsInvalidMethodImplAttribute(const AttrVec &A) { 2244 // The 'ibaction' attribute is allowed on method definitions because of 2245 // how the IBAction macro is used on both method declarations and definitions. 2246 // If the method definitions contains any other attributes, return true. 2247 for (AttrVec::const_iterator i = A.begin(), e = A.end(); i != e; ++i) 2248 if ((*i)->getKind() != attr::IBAction) 2249 return true; 2250 return false; 2251} 2252 2253/// \brief Check whether the declared result type of the given Objective-C 2254/// method declaration is compatible with the method's class. 2255/// 2256static bool 2257CheckRelatedResultTypeCompatibility(Sema &S, ObjCMethodDecl *Method, 2258 ObjCInterfaceDecl *CurrentClass) { 2259 QualType ResultType = Method->getResultType(); 2260 SourceRange ResultTypeRange; 2261 if (const TypeSourceInfo *ResultTypeInfo = Method->getResultTypeSourceInfo()) 2262 ResultTypeRange = ResultTypeInfo->getTypeLoc().getSourceRange(); 2263 2264 // If an Objective-C method inherits its related result type, then its 2265 // declared result type must be compatible with its own class type. The 2266 // declared result type is compatible if: 2267 if (const ObjCObjectPointerType *ResultObjectType 2268 = ResultType->getAs<ObjCObjectPointerType>()) { 2269 // - it is id or qualified id, or 2270 if (ResultObjectType->isObjCIdType() || 2271 ResultObjectType->isObjCQualifiedIdType()) 2272 return false; 2273 2274 if (CurrentClass) { 2275 if (ObjCInterfaceDecl *ResultClass 2276 = ResultObjectType->getInterfaceDecl()) { 2277 // - it is the same as the method's class type, or 2278 if (CurrentClass == ResultClass) 2279 return false; 2280 2281 // - it is a superclass of the method's class type 2282 if (ResultClass->isSuperClassOf(CurrentClass)) 2283 return false; 2284 } 2285 } 2286 } 2287 2288 return true; 2289} 2290 2291namespace { 2292/// A helper class for searching for methods which a particular method 2293/// overrides. 2294class OverrideSearch { 2295 Sema &S; 2296 ObjCMethodDecl *Method; 2297 llvm::SmallPtrSet<ObjCContainerDecl*, 8> Searched; 2298 llvm::SmallPtrSet<ObjCMethodDecl*, 8> Overridden; 2299 bool Recursive; 2300 2301public: 2302 OverrideSearch(Sema &S, ObjCMethodDecl *method) : S(S), Method(method) { 2303 Selector selector = method->getSelector(); 2304 2305 // Bypass this search if we've never seen an instance/class method 2306 // with this selector before. 2307 Sema::GlobalMethodPool::iterator it = S.MethodPool.find(selector); 2308 if (it == S.MethodPool.end()) { 2309 if (!S.ExternalSource) return; 2310 it = S.ReadMethodPool(selector); 2311 } 2312 ObjCMethodList &list = 2313 method->isInstanceMethod() ? it->second.first : it->second.second; 2314 if (!list.Method) return; 2315 2316 ObjCContainerDecl *container 2317 = cast<ObjCContainerDecl>(method->getDeclContext()); 2318 2319 // Prevent the search from reaching this container again. This is 2320 // important with categories, which override methods from the 2321 // interface and each other. 2322 Searched.insert(container); 2323 searchFromContainer(container); 2324 } 2325 2326 typedef llvm::SmallPtrSet<ObjCMethodDecl*,8>::iterator iterator; 2327 iterator begin() const { return Overridden.begin(); } 2328 iterator end() const { return Overridden.end(); } 2329 2330private: 2331 void searchFromContainer(ObjCContainerDecl *container) { 2332 if (container->isInvalidDecl()) return; 2333 2334 switch (container->getDeclKind()) { 2335#define OBJCCONTAINER(type, base) \ 2336 case Decl::type: \ 2337 searchFrom(cast<type##Decl>(container)); \ 2338 break; 2339#define ABSTRACT_DECL(expansion) 2340#define DECL(type, base) \ 2341 case Decl::type: 2342#include "clang/AST/DeclNodes.inc" 2343 llvm_unreachable("not an ObjC container!"); 2344 } 2345 } 2346 2347 void searchFrom(ObjCProtocolDecl *protocol) { 2348 // A method in a protocol declaration overrides declarations from 2349 // referenced ("parent") protocols. 2350 search(protocol->getReferencedProtocols()); 2351 } 2352 2353 void searchFrom(ObjCCategoryDecl *category) { 2354 // A method in a category declaration overrides declarations from 2355 // the main class and from protocols the category references. 2356 search(category->getClassInterface()); 2357 search(category->getReferencedProtocols()); 2358 } 2359 2360 void searchFrom(ObjCCategoryImplDecl *impl) { 2361 // A method in a category definition that has a category 2362 // declaration overrides declarations from the category 2363 // declaration. 2364 if (ObjCCategoryDecl *category = impl->getCategoryDecl()) { 2365 search(category); 2366 2367 // Otherwise it overrides declarations from the class. 2368 } else { 2369 search(impl->getClassInterface()); 2370 } 2371 } 2372 2373 void searchFrom(ObjCInterfaceDecl *iface) { 2374 // A method in a class declaration overrides declarations from 2375 2376 // - categories, 2377 for (ObjCCategoryDecl *category = iface->getCategoryList(); 2378 category; category = category->getNextClassCategory()) 2379 search(category); 2380 2381 // - the super class, and 2382 if (ObjCInterfaceDecl *super = iface->getSuperClass()) 2383 search(super); 2384 2385 // - any referenced protocols. 2386 search(iface->getReferencedProtocols()); 2387 } 2388 2389 void searchFrom(ObjCImplementationDecl *impl) { 2390 // A method in a class implementation overrides declarations from 2391 // the class interface. 2392 search(impl->getClassInterface()); 2393 } 2394 2395 2396 void search(const ObjCProtocolList &protocols) { 2397 for (ObjCProtocolList::iterator i = protocols.begin(), e = protocols.end(); 2398 i != e; ++i) 2399 search(*i); 2400 } 2401 2402 void search(ObjCContainerDecl *container) { 2403 // Abort if we've already searched this container. 2404 if (!Searched.insert(container)) return; 2405 2406 // Check for a method in this container which matches this selector. 2407 ObjCMethodDecl *meth = container->getMethod(Method->getSelector(), 2408 Method->isInstanceMethod()); 2409 2410 // If we find one, record it and bail out. 2411 if (meth) { 2412 Overridden.insert(meth); 2413 return; 2414 } 2415 2416 // Otherwise, search for methods that a hypothetical method here 2417 // would have overridden. 2418 2419 // Note that we're now in a recursive case. 2420 Recursive = true; 2421 2422 searchFromContainer(container); 2423 } 2424}; 2425} 2426 2427Decl *Sema::ActOnMethodDeclaration( 2428 Scope *S, 2429 SourceLocation MethodLoc, SourceLocation EndLoc, 2430 tok::TokenKind MethodType, Decl *ClassDecl, 2431 ObjCDeclSpec &ReturnQT, ParsedType ReturnType, 2432 SourceLocation SelectorStartLoc, 2433 Selector Sel, 2434 // optional arguments. The number of types/arguments is obtained 2435 // from the Sel.getNumArgs(). 2436 ObjCArgInfo *ArgInfo, 2437 DeclaratorChunk::ParamInfo *CParamInfo, unsigned CNumArgs, // c-style args 2438 AttributeList *AttrList, tok::ObjCKeywordKind MethodDeclKind, 2439 bool isVariadic, bool MethodDefinition) { 2440 // Make sure we can establish a context for the method. 2441 if (!ClassDecl) { 2442 Diag(MethodLoc, diag::error_missing_method_context); 2443 return 0; 2444 } 2445 QualType resultDeclType; 2446 2447 TypeSourceInfo *ResultTInfo = 0; 2448 if (ReturnType) { 2449 resultDeclType = GetTypeFromParser(ReturnType, &ResultTInfo); 2450 2451 // Methods cannot return interface types. All ObjC objects are 2452 // passed by reference. 2453 if (resultDeclType->isObjCObjectType()) { 2454 Diag(MethodLoc, diag::err_object_cannot_be_passed_returned_by_value) 2455 << 0 << resultDeclType; 2456 return 0; 2457 } 2458 } else { // get the type for "id". 2459 resultDeclType = Context.getObjCIdType(); 2460 Diag(MethodLoc, diag::warn_missing_method_return_type) 2461 << FixItHint::CreateInsertion(SelectorStartLoc, "(id)"); 2462 } 2463 2464 ObjCMethodDecl* ObjCMethod = 2465 ObjCMethodDecl::Create(Context, MethodLoc, EndLoc, Sel, resultDeclType, 2466 ResultTInfo, 2467 cast<DeclContext>(ClassDecl), 2468 MethodType == tok::minus, isVariadic, 2469 /*isSynthesized=*/false, 2470 /*isImplicitlyDeclared=*/false, /*isDefined=*/false, 2471 MethodDeclKind == tok::objc_optional 2472 ? ObjCMethodDecl::Optional 2473 : ObjCMethodDecl::Required, 2474 false); 2475 2476 SmallVector<ParmVarDecl*, 16> Params; 2477 2478 for (unsigned i = 0, e = Sel.getNumArgs(); i != e; ++i) { 2479 QualType ArgType; 2480 TypeSourceInfo *DI; 2481 2482 if (ArgInfo[i].Type == 0) { 2483 ArgType = Context.getObjCIdType(); 2484 DI = 0; 2485 } else { 2486 ArgType = GetTypeFromParser(ArgInfo[i].Type, &DI); 2487 // Perform the default array/function conversions (C99 6.7.5.3p[7,8]). 2488 ArgType = Context.getAdjustedParameterType(ArgType); 2489 } 2490 2491 LookupResult R(*this, ArgInfo[i].Name, ArgInfo[i].NameLoc, 2492 LookupOrdinaryName, ForRedeclaration); 2493 LookupName(R, S); 2494 if (R.isSingleResult()) { 2495 NamedDecl *PrevDecl = R.getFoundDecl(); 2496 if (S->isDeclScope(PrevDecl)) { 2497 Diag(ArgInfo[i].NameLoc, 2498 (MethodDefinition ? diag::warn_method_param_redefinition 2499 : diag::warn_method_param_declaration)) 2500 << ArgInfo[i].Name; 2501 Diag(PrevDecl->getLocation(), 2502 diag::note_previous_declaration); 2503 } 2504 } 2505 2506 SourceLocation StartLoc = DI 2507 ? DI->getTypeLoc().getBeginLoc() 2508 : ArgInfo[i].NameLoc; 2509 2510 ParmVarDecl* Param = CheckParameter(ObjCMethod, StartLoc, 2511 ArgInfo[i].NameLoc, ArgInfo[i].Name, 2512 ArgType, DI, SC_None, SC_None); 2513 2514 Param->setObjCMethodScopeInfo(i); 2515 2516 Param->setObjCDeclQualifier( 2517 CvtQTToAstBitMask(ArgInfo[i].DeclSpec.getObjCDeclQualifier())); 2518 2519 // Apply the attributes to the parameter. 2520 ProcessDeclAttributeList(TUScope, Param, ArgInfo[i].ArgAttrs); 2521 2522 S->AddDecl(Param); 2523 IdResolver.AddDecl(Param); 2524 2525 Params.push_back(Param); 2526 } 2527 2528 for (unsigned i = 0, e = CNumArgs; i != e; ++i) { 2529 ParmVarDecl *Param = cast<ParmVarDecl>(CParamInfo[i].Param); 2530 QualType ArgType = Param->getType(); 2531 if (ArgType.isNull()) 2532 ArgType = Context.getObjCIdType(); 2533 else 2534 // Perform the default array/function conversions (C99 6.7.5.3p[7,8]). 2535 ArgType = Context.getAdjustedParameterType(ArgType); 2536 if (ArgType->isObjCObjectType()) { 2537 Diag(Param->getLocation(), 2538 diag::err_object_cannot_be_passed_returned_by_value) 2539 << 1 << ArgType; 2540 Param->setInvalidDecl(); 2541 } 2542 Param->setDeclContext(ObjCMethod); 2543 2544 Params.push_back(Param); 2545 } 2546 2547 ObjCMethod->setMethodParams(Context, Params.data(), Params.size(), 2548 Sel.getNumArgs()); 2549 ObjCMethod->setObjCDeclQualifier( 2550 CvtQTToAstBitMask(ReturnQT.getObjCDeclQualifier())); 2551 2552 if (AttrList) 2553 ProcessDeclAttributeList(TUScope, ObjCMethod, AttrList); 2554 2555 // Add the method now. 2556 const ObjCMethodDecl *PrevMethod = 0; 2557 if (ObjCImplDecl *ImpDecl = dyn_cast<ObjCImplDecl>(ClassDecl)) { 2558 if (MethodType == tok::minus) { 2559 PrevMethod = ImpDecl->getInstanceMethod(Sel); 2560 ImpDecl->addInstanceMethod(ObjCMethod); 2561 } else { 2562 PrevMethod = ImpDecl->getClassMethod(Sel); 2563 ImpDecl->addClassMethod(ObjCMethod); 2564 } 2565 2566 if (ObjCMethod->hasAttrs() && 2567 containsInvalidMethodImplAttribute(ObjCMethod->getAttrs())) 2568 Diag(EndLoc, diag::warn_attribute_method_def); 2569 } else { 2570 cast<DeclContext>(ClassDecl)->addDecl(ObjCMethod); 2571 } 2572 2573 if (PrevMethod) { 2574 // You can never have two method definitions with the same name. 2575 Diag(ObjCMethod->getLocation(), diag::err_duplicate_method_decl) 2576 << ObjCMethod->getDeclName(); 2577 Diag(PrevMethod->getLocation(), diag::note_previous_declaration); 2578 } 2579 2580 // If this Objective-C method does not have a related result type, but we 2581 // are allowed to infer related result types, try to do so based on the 2582 // method family. 2583 ObjCInterfaceDecl *CurrentClass = dyn_cast<ObjCInterfaceDecl>(ClassDecl); 2584 if (!CurrentClass) { 2585 if (ObjCCategoryDecl *Cat = dyn_cast<ObjCCategoryDecl>(ClassDecl)) 2586 CurrentClass = Cat->getClassInterface(); 2587 else if (ObjCImplDecl *Impl = dyn_cast<ObjCImplDecl>(ClassDecl)) 2588 CurrentClass = Impl->getClassInterface(); 2589 else if (ObjCCategoryImplDecl *CatImpl 2590 = dyn_cast<ObjCCategoryImplDecl>(ClassDecl)) 2591 CurrentClass = CatImpl->getClassInterface(); 2592 } 2593 2594 bool isRelatedResultTypeCompatible = 2595 (getLangOptions().ObjCInferRelatedResultType && 2596 !CheckRelatedResultTypeCompatibility(*this, ObjCMethod, CurrentClass)); 2597 2598 // Search for overridden methods and merge information down from them. 2599 OverrideSearch overrides(*this, ObjCMethod); 2600 for (OverrideSearch::iterator 2601 i = overrides.begin(), e = overrides.end(); i != e; ++i) { 2602 ObjCMethodDecl *overridden = *i; 2603 2604 // Propagate down the 'related result type' bit from overridden methods. 2605 if (isRelatedResultTypeCompatible && overridden->hasRelatedResultType()) 2606 ObjCMethod->SetRelatedResultType(); 2607 2608 // Then merge the declarations. 2609 mergeObjCMethodDecls(ObjCMethod, overridden); 2610 2611 // Check for overriding methods 2612 if (isa<ObjCInterfaceDecl>(ObjCMethod->getDeclContext()) || 2613 isa<ObjCImplementationDecl>(ObjCMethod->getDeclContext())) { 2614 WarnConflictingTypedMethods(ObjCMethod, overridden, 2615 isa<ObjCProtocolDecl>(overridden->getDeclContext()), true); 2616 } 2617 } 2618 2619 bool ARCError = false; 2620 if (getLangOptions().ObjCAutoRefCount) 2621 ARCError = CheckARCMethodDecl(*this, ObjCMethod); 2622 2623 if (!ARCError && isRelatedResultTypeCompatible && 2624 !ObjCMethod->hasRelatedResultType()) { 2625 bool InferRelatedResultType = false; 2626 switch (ObjCMethod->getMethodFamily()) { 2627 case OMF_None: 2628 case OMF_copy: 2629 case OMF_dealloc: 2630 case OMF_mutableCopy: 2631 case OMF_release: 2632 case OMF_retainCount: 2633 case OMF_performSelector: 2634 break; 2635 2636 case OMF_alloc: 2637 case OMF_new: 2638 InferRelatedResultType = ObjCMethod->isClassMethod(); 2639 break; 2640 2641 case OMF_init: 2642 case OMF_autorelease: 2643 case OMF_retain: 2644 case OMF_self: 2645 InferRelatedResultType = ObjCMethod->isInstanceMethod(); 2646 break; 2647 } 2648 2649 if (InferRelatedResultType) 2650 ObjCMethod->SetRelatedResultType(); 2651 } 2652 2653 return ObjCMethod; 2654} 2655 2656bool Sema::CheckObjCDeclScope(Decl *D) { 2657 if (isa<TranslationUnitDecl>(CurContext->getRedeclContext())) 2658 return false; 2659 2660 Diag(D->getLocation(), diag::err_objc_decls_may_only_appear_in_global_scope); 2661 D->setInvalidDecl(); 2662 2663 return true; 2664} 2665 2666/// Called whenever @defs(ClassName) is encountered in the source. Inserts the 2667/// instance variables of ClassName into Decls. 2668void Sema::ActOnDefs(Scope *S, Decl *TagD, SourceLocation DeclStart, 2669 IdentifierInfo *ClassName, 2670 SmallVectorImpl<Decl*> &Decls) { 2671 // Check that ClassName is a valid class 2672 ObjCInterfaceDecl *Class = getObjCInterfaceDecl(ClassName, DeclStart); 2673 if (!Class) { 2674 Diag(DeclStart, diag::err_undef_interface) << ClassName; 2675 return; 2676 } 2677 if (LangOpts.ObjCNonFragileABI) { 2678 Diag(DeclStart, diag::err_atdef_nonfragile_interface); 2679 return; 2680 } 2681 2682 // Collect the instance variables 2683 SmallVector<const ObjCIvarDecl*, 32> Ivars; 2684 Context.DeepCollectObjCIvars(Class, true, Ivars); 2685 // For each ivar, create a fresh ObjCAtDefsFieldDecl. 2686 for (unsigned i = 0; i < Ivars.size(); i++) { 2687 const FieldDecl* ID = cast<FieldDecl>(Ivars[i]); 2688 RecordDecl *Record = dyn_cast<RecordDecl>(TagD); 2689 Decl *FD = ObjCAtDefsFieldDecl::Create(Context, Record, 2690 /*FIXME: StartL=*/ID->getLocation(), 2691 ID->getLocation(), 2692 ID->getIdentifier(), ID->getType(), 2693 ID->getBitWidth()); 2694 Decls.push_back(FD); 2695 } 2696 2697 // Introduce all of these fields into the appropriate scope. 2698 for (SmallVectorImpl<Decl*>::iterator D = Decls.begin(); 2699 D != Decls.end(); ++D) { 2700 FieldDecl *FD = cast<FieldDecl>(*D); 2701 if (getLangOptions().CPlusPlus) 2702 PushOnScopeChains(cast<FieldDecl>(FD), S); 2703 else if (RecordDecl *Record = dyn_cast<RecordDecl>(TagD)) 2704 Record->addDecl(FD); 2705 } 2706} 2707 2708/// \brief Build a type-check a new Objective-C exception variable declaration. 2709VarDecl *Sema::BuildObjCExceptionDecl(TypeSourceInfo *TInfo, QualType T, 2710 SourceLocation StartLoc, 2711 SourceLocation IdLoc, 2712 IdentifierInfo *Id, 2713 bool Invalid) { 2714 // ISO/IEC TR 18037 S6.7.3: "The type of an object with automatic storage 2715 // duration shall not be qualified by an address-space qualifier." 2716 // Since all parameters have automatic store duration, they can not have 2717 // an address space. 2718 if (T.getAddressSpace() != 0) { 2719 Diag(IdLoc, diag::err_arg_with_address_space); 2720 Invalid = true; 2721 } 2722 2723 // An @catch parameter must be an unqualified object pointer type; 2724 // FIXME: Recover from "NSObject foo" by inserting the * in "NSObject *foo"? 2725 if (Invalid) { 2726 // Don't do any further checking. 2727 } else if (T->isDependentType()) { 2728 // Okay: we don't know what this type will instantiate to. 2729 } else if (!T->isObjCObjectPointerType()) { 2730 Invalid = true; 2731 Diag(IdLoc ,diag::err_catch_param_not_objc_type); 2732 } else if (T->isObjCQualifiedIdType()) { 2733 Invalid = true; 2734 Diag(IdLoc, diag::err_illegal_qualifiers_on_catch_parm); 2735 } 2736 2737 VarDecl *New = VarDecl::Create(Context, CurContext, StartLoc, IdLoc, Id, 2738 T, TInfo, SC_None, SC_None); 2739 New->setExceptionVariable(true); 2740 2741 if (Invalid) 2742 New->setInvalidDecl(); 2743 return New; 2744} 2745 2746Decl *Sema::ActOnObjCExceptionDecl(Scope *S, Declarator &D) { 2747 const DeclSpec &DS = D.getDeclSpec(); 2748 2749 // We allow the "register" storage class on exception variables because 2750 // GCC did, but we drop it completely. Any other storage class is an error. 2751 if (DS.getStorageClassSpec() == DeclSpec::SCS_register) { 2752 Diag(DS.getStorageClassSpecLoc(), diag::warn_register_objc_catch_parm) 2753 << FixItHint::CreateRemoval(SourceRange(DS.getStorageClassSpecLoc())); 2754 } else if (DS.getStorageClassSpec() != DeclSpec::SCS_unspecified) { 2755 Diag(DS.getStorageClassSpecLoc(), diag::err_storage_spec_on_catch_parm) 2756 << DS.getStorageClassSpec(); 2757 } 2758 if (D.getDeclSpec().isThreadSpecified()) 2759 Diag(D.getDeclSpec().getThreadSpecLoc(), diag::err_invalid_thread); 2760 D.getMutableDeclSpec().ClearStorageClassSpecs(); 2761 2762 DiagnoseFunctionSpecifiers(D); 2763 2764 // Check that there are no default arguments inside the type of this 2765 // exception object (C++ only). 2766 if (getLangOptions().CPlusPlus) 2767 CheckExtraCXXDefaultArguments(D); 2768 2769 TypeSourceInfo *TInfo = GetTypeForDeclarator(D, S); 2770 QualType ExceptionType = TInfo->getType(); 2771 2772 VarDecl *New = BuildObjCExceptionDecl(TInfo, ExceptionType, 2773 D.getSourceRange().getBegin(), 2774 D.getIdentifierLoc(), 2775 D.getIdentifier(), 2776 D.isInvalidType()); 2777 2778 // Parameter declarators cannot be qualified (C++ [dcl.meaning]p1). 2779 if (D.getCXXScopeSpec().isSet()) { 2780 Diag(D.getIdentifierLoc(), diag::err_qualified_objc_catch_parm) 2781 << D.getCXXScopeSpec().getRange(); 2782 New->setInvalidDecl(); 2783 } 2784 2785 // Add the parameter declaration into this scope. 2786 S->AddDecl(New); 2787 if (D.getIdentifier()) 2788 IdResolver.AddDecl(New); 2789 2790 ProcessDeclAttributes(S, New, D); 2791 2792 if (New->hasAttr<BlocksAttr>()) 2793 Diag(New->getLocation(), diag::err_block_on_nonlocal); 2794 return New; 2795} 2796 2797/// CollectIvarsToConstructOrDestruct - Collect those ivars which require 2798/// initialization. 2799void Sema::CollectIvarsToConstructOrDestruct(ObjCInterfaceDecl *OI, 2800 SmallVectorImpl<ObjCIvarDecl*> &Ivars) { 2801 for (ObjCIvarDecl *Iv = OI->all_declared_ivar_begin(); Iv; 2802 Iv= Iv->getNextIvar()) { 2803 QualType QT = Context.getBaseElementType(Iv->getType()); 2804 if (QT->isRecordType()) 2805 Ivars.push_back(Iv); 2806 } 2807} 2808 2809void Sema::DiagnoseUseOfUnimplementedSelectors() { 2810 // Load referenced selectors from the external source. 2811 if (ExternalSource) { 2812 SmallVector<std::pair<Selector, SourceLocation>, 4> Sels; 2813 ExternalSource->ReadReferencedSelectors(Sels); 2814 for (unsigned I = 0, N = Sels.size(); I != N; ++I) 2815 ReferencedSelectors[Sels[I].first] = Sels[I].second; 2816 } 2817 2818 // Warning will be issued only when selector table is 2819 // generated (which means there is at lease one implementation 2820 // in the TU). This is to match gcc's behavior. 2821 if (ReferencedSelectors.empty() || 2822 !Context.AnyObjCImplementation()) 2823 return; 2824 for (llvm::DenseMap<Selector, SourceLocation>::iterator S = 2825 ReferencedSelectors.begin(), 2826 E = ReferencedSelectors.end(); S != E; ++S) { 2827 Selector Sel = (*S).first; 2828 if (!LookupImplementedMethodInGlobalPool(Sel)) 2829 Diag((*S).second, diag::warn_unimplemented_selector) << Sel; 2830 } 2831 return; 2832} 2833