History log of /frameworks/base/core/java/android/widget/AutoCompleteTextView.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
cf12897cf553bfd07734dad3de071915fd21d4eb 17-Oct-2012 Fabrice Di Meglio <fdimeglio@google.com> Fix bug #7363252 Popup and Dialog UI widgets should be RTL aware

- set the Configuration's layout direction in ViewRootImpl instead of PhoneWindow$DecorView
- then remove unecessary API on ListPopupWindow for passing the layout direction

Change-Id: Ia2c6e4aa8cb82aed9b088bc3b8004ea0a1ded1f3
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
e56ffdc7b31b0937628609cc3bbaa15879023569 23-Sep-2012 Fabrice Di Meglio <fdimeglio@google.com> Fix bug #6427629 Clean up layout direction APIs

- rename getResolvedLayoutDirection() to getLayoutDirection()

Change-Id: I3afe56c0db0751952f5056c23893cb7455531d29
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
780c491fb9905adb3782f34886bb23327ed8f456 31-Aug-2012 Adam Powell <adamp@google.com> Add an OnDismissListener to AutoCompleteTextView

Bug 4551310

Change-Id: I702301ad3360828ec6637b6c09789e00d9661271
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
478923885da8fac0c1e0a8b7d85b98d1988504bc 03-Aug-2012 Adam Powell <adamp@google.com> Make AutoCompleteTextView#setText(CharSequence, boolean) public

Bug 6807326

Public bug http://code.google.com/p/android/issues/detail?id=34690

Make this available for use by applications that wish to make
programmatic changes to the AutoCompleteTextView without filtering.

Change-Id: I889452d3b19b378258ad9247f3d254afee1e8408
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
3a69bea30257f32a21bb6c32aafa52982d16a401 26-Jul-2012 Fabrice Di Meglio <fdimeglio@google.com> Make SearchView RTL aware

- see bug #5429822 UI should be mirrored for RTL locales (Arabic, Hebrew, farsi)

Change-Id: I7e7b51dccdd3b111e0594509334579b0502d24c8
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
4c359b76f9a030f92a302ba74a528faa170bad4e 25-Jul-2012 Scott Main <smain@google.com> docs: fix a bunch of links from javadocs to api guides
and add some attributes to Spinner and Switch

Change-Id: If015ad000c1a36e19904c132e98ebff1ceaf718b
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
5c49d11a57b0c868e15b9b3a79a9985288b5e15d 01-May-2012 Gilles Debunne <debunne@google.com> API fix, AutoCompleteTextView

Bug 6102885

Didn't fix dropDownSelector nor completionHintView at that point.

Change-Id: If080cbefd5189b79e4fa042e28dfa6a71524b93d
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
c27cc01f6abf8564dc9b7b6cd7f2a12a347f725d 16-Feb-2012 Romain Guy <romainguy@google.com> Prevent AutoCompleteTextView from opening a popup when it shouldn't
Bug #5553515

The People app is forcing ACTV to show the IME which had the side effect
of showing the drop down popup. ACTV was unfortunately not ready to show
the drop down if the filtering resulted in no results. Doing so was putting
ACTV in a weird state that in turn caused a window to be leaked and really
bad behavior to occur in the lower graphics levels.

Change-Id: I2ff146d5ae4e4a28edf6ea17039c9f8fdb710e4f
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
f0d3b7ff72511c9f6b9bf228e5b14ba6a2e35f34 19-Jan-2012 Gilles Debunne <debunne@google.com> AOOB in AutoComplete

Bug 5749557

Not clear how we can get an AOOB in that case.
tmp will always have the right length, and indeed the stack
trace attached to that bug shows a correct size of 10.

However, there is an index issue when we build the new
completion array. i is not the correct index to use.

Note however that the original buildDropDown method mentioned
is no longer present in the file. I tried to backtrack, but
the use of arraycopy always seemed correct.

Change-Id: Idf749c74b38923b5d18596c8e8f6ea887cc897d6
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
a0383f7212651c9508ad5fb56b1cd1216ceb8fe9 15-Sep-2011 Gilles Debunne <debunne@google.com> Merge "Bug 5319091: Completions delayed in AutoComplete in landscape"
d513e9746f09611db6478e368207ac7b112a253d 15-Sep-2011 Gilles Debunne <debunne@google.com> Bug 5319091: Completions delayed in AutoComplete in landscape

The filtering is an async process. We need to re-update completion
when it is finished.

Changed loogic to mimic the way it was done in GB.

Change-Id: If49048d786b3b9529da55c7247e7ef5f3d0fc8b5
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
688df79243762923f6cd34f767cb2f690b11a48c 15-Sep-2011 Gilles Debunne <debunne@google.com> Bug 5299484: Recipient address in to field is doubled when entering in landscape mode

A tap on a completion in the keyboard calls onCommitCompletion, which in turn calls
performCompletion because of the DropDownItemClickListener.

As a result, the text is replaced twice. Removing the first text replacement.

Change-Id: I4974d23c68ab25ca0ad0cda5abf25f30129b28ee
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
348e69cfabec21ccfbe708df06f0a7ea541a3053 17-Feb-2011 Adam Powell <adamp@google.com> Fix bug 3413800 - Revise AutoCompleteTextView dropdown behavior

Be more conservative with when we let an AutoCompleteTextView's
dropdown box of completion suggestions cover the IME.

Disable the expand-when-touched behavior of the dropdown list when
more than 3 items can be seen at a time without it.

Don't let a ListPopupWindow that is expanding in response to touch
scroll the anchor view within its parent and slide the dropdown out
from under the user's finger.

Change-Id: I009accfd4e841c9a5e1072735d8a0b067a0bc06a
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
711734a2f8d7529df0ed1bce36da651fc835c144 08-Feb-2011 Gilles Debunne <debunne@google.com> AutoComplete list does not hide the IME when it re-appears.

Bug 3415891

With the current behavior, as soon as the list is expanded by
'long' pressing on or scrolling its content, it will always further appear
in its long state, thus hiding the IME.

This fix changes this behavior so that the default state is always
compact, not hiding the IME, and an explicit expansion
is always required.

Also fixes a bug in ListPopupWindow that prevented the timer that
expands the list from being started.

Change-Id: I896e92d54961769c10b276c36f6510e91ff096a2
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
a4a5758b5f51834f7555ec909e8188c432fc5dc4 09-Feb-2011 Gilles Debunne <debunne@google.com> The tab key completes text in AutoCompleteTextView.

Bug 3330651.

The first item in the list is not selected by default. From discussions
in other related bugs, there does not seem to be an agreement on this.

Supporting the actual token separator has also been punted. This would
require a new method in the Tokenizer, which could be ill-defined for
exotic tokenizer, plus typing a comma (for instance) to achieve a
completion is not a common pattern.

Change-Id: I30baf62077c412256175f871d21f4841e104f212
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
4a74dbc3f2221af99f94b4f514b8291a16ae3661 24-Jan-2011 Gilles Debunne <debunne@google.com> New fix for popup behavior in AutoCompleteTextViews.

Bug 3374144

The fix in https://android-git.corp.google.com/g/#change,91880 is not
sufficient. An updated adapter needs to be able to force an update of
the poup result list.

Addded a flag that prevents the popup from being re-opened when it has
previously been closed by a user action.

Change-Id: I45fab056c8ebd6dc4317430213f2bc37b51b79e3
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
be2c4f92a990ca48ad6ede252343dd9574dfe505 18-Jan-2011 Gilles Debunne <debunne@google.com> Race condition patched in Email autocompletion.

Bug 3347962

Root cause of this problem: if the adapter's content gets updated by a backgroung
thread, the PopupDataSetObserver will call showDropDown which will popup the
list.

Added a flag to make this call show the popup iif it is already visible.
This relayout is needed to clear the mDataChanged flag set when the content was
modified and which otherwise prevents touch events on the result list.

ArrayAdapter didn't use its lock to protect access to mObject.

-------------------------------------------------

However, the study of the this race conditions revealed an other bug:

Updated adapter's content is not displayed in filtered AutoCompleteTextView
Bug 3369097

Change-Id: Icd90d452f98231866f4d8a1f6994c1492febecb9
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
b3ea92235c9ccc1ff295839a8f324dcd1c83dd6f 11-Jan-2011 Jeff Brown <jeffbrown@google.com> Fix NPEs in detached views.

Bug: 3297518
Change-Id: Ife1384f3a5bebbd28a29f97dc6d519f8a0b10ba9
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
4e6319b73c85082e18d1c532b86336ddd1f8cfaa 13-Dec-2010 Jeff Brown <jeffbrown@google.com> Add initial support for TAB navigation.

Bug: 3286652
Change-Id: I813a0318b3b8d9c9bc791ea6a2427be11c08de00
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
385a655b8e8bf85024e4f24f1d7f6c2d7d7e900d 21-Aug-2010 Scott Main <smain@google.com> am bb8d314b: am 70c9ffbc: am 11a72482: Merge "docs: add links from widget classes to tutorials" into froyo

Merge commit 'bb8d314b6c5ff9b51af29daa687d66dfd996914f'

* commit 'bb8d314b6c5ff9b51af29daa687d66dfd996914f':
docs: add links from widget classes to tutorials
41ec65355bd6ded652769725b276d47c54a0d913 20-Aug-2010 Scott Main <smain@google.com> docs: add links from widget classes to tutorials

Change-Id: I817e885524951853182b0458df4a32dea1614243
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
c3fa6304c997ccecf8ed15a4cbb7bd245128f3c3 18-May-2010 Adam Powell <adamp@google.com> Added ListPopupWindow. Refactored AutoCompleteTextView and Spinner
(optionally) to use it. Added associated styles.

ListPopupWindow allows apps to present a popup window of options to
the user that will correctly dodge the IME if needed.

Change-Id: I509c6c45036856daab686a6edeb7a9de1e72eb0a
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
c9c82b566943245cdaa62347b72f3613988ce5a0 09-Apr-2010 Romain Guy <romainguy@android.com> Don't supply a null child to the click listener.
External bug #http://code.google.com/p/android/issues/detail?id=7644

Change-Id: Iea2c0d7fa02d355fd68750d6dccf8e6c6773ab6b
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
387d8f8a62d6ea0932ebb498d2b1dda00a1256be 23-Mar-2010 Adam Powell <adamp@google.com> Fix bug 2495033.

AutoCompleteTextView now uses different logic to expand the dropdown
list of completion choices to cover the IME if present. Previously
this would happen whenever a touch down event occurred. Resizing the
dropdown could cause the parent view to animate a scroll and thereby
move the completion list up the screen. When this happened with a
finger down it would initiate a touch scroll on the completion
list. Prior to froyo this wasn't a problem since a list positioned at
the top could not scroll up, but with the addition of overscroll this
caused undesired behavior.

The completion list now will not expand to cover the IME on initial
touch down. Instead it will only expand if the user leaves a finger in
place for the duration of a timeout (currently 250ms) or if the user
explicitly begins a touch scroll on the completion list. This also has
a nice side effect where tapping a completion choice in the initial,
smaller list does not cause a split-second list expansion before the
list is dismissed.

Change-Id: If0994c68a91b3bfc3dcef660c67fde667a9727f9
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
7254afd4c275dec243d4825f8f68c815ced1342c 19-Mar-2010 Kenny Root <kroot@google.com> Ensure adapter is not null in AutoCompleteTextView

A runnable is posted for AutoCompleteTextView's PopupDataSetObserver, but
there's a possibility that mAdapter would be set to null between when
the runnable is run and the time it is posted.

This fixes a monkey crash seen in build 29176.

Change-Id: Ie7be51db580d6e9775533890e5f6902409bec84d
MonkeyCrashID: 2071507494::1632:123:521
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
11d5bfde8488505e15aa83275772d84579de04ca 17-Mar-2010 Romain Guy <romainguy@android.com> Fix NPE in AutoCompleteTextView to tame the monkeys.
Bug #2522599

Change-Id: I85654898399e5329585fb6aa5f3890ca4c22e2bf
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
4f43ae09d2cb0cce2b9e794f1b80f7198333c94b 17-Mar-2010 Romain Guy <romainguy@android.com> Stupid AutoCompleteTextView.
Bug #2522538

Fixes problems that occur in the Email application. If the adapter is initially empty,
the code in the data set observer to update the popup would not show the popup. This
change makes sure the popup will be shown if the adapter was initially empty and the
user has typed enough characters in the input field.

Change-Id: I44a0e4fab18a642763816a974b8c1886d8e52869
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
6a67810228d02e75446d55c4c353275c87e9e769 16-Mar-2010 Romain Guy <romainguy@android.com> Resize AutoCompleteTextView's dropdown when the list content changes.
Bug #2517711

Change-Id: Ibd4a9458d517063483712a60fb6d6b63311bbd0c
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
2beee4d11084f7b96dda6e335da0ebc08214dfb7 16-Mar-2010 Romain Guy <romainguy@android.com> Correctly handle disabled list items in AutoCompleteTextView.
Bug #2516659

Change-Id: If51dfbfff27777476e799030e2326e964ee74f42
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
d25eb35b6b80b6f8065ab39b1cf1abb1fd801234 11-Mar-2010 Amith Yamasani <yamasani@google.com> Fix for 2175289 : Can't get keyboard in search dialog after switching to landscape

The auto complete drop down was obscuring the keyboard. This fix checks if the
screen is in landscape mode and forces the keyboard in front when necessary.
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
3e141685003939a9addce21ba2492ea3a8aebee6 09-Mar-2010 Romain Guy <romainguy@android.com> Fix scrolling bug in AutoCompleteTextView.
Bug #2495033

This fixes various issues. ACTV would sometimes not update its popup to match
its size/location.

Change-Id: Ic662bddf40e49b09482b15ff91666be3709da1d5
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
43c9cdffb619f93d9d4525dffd05701dc9c8c4bf 27-Jan-2010 Romain Guy <romainguy@android.com> New View.dispatchDisplayHint() API.
Bug #2399147

This new API will be used by scrollable containers to tell children that they
are/are not displayed. This will allow lists to hide their filter popup window
for instance.
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
73beee234b4758318a4a795822e53ffb847fa10e 20-Jan-2010 Romain Guy <romainguy@android.com> Measure AutoCompleteTextView's dropdown to have enough room for all items.
Bug #2363514
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
980a938c1c9a6a5791a8240e5a1e6638ab28dc77 09-Jan-2010 Romain Guy <romainguy@android.com> Deprecate fill_parent and introduce match_parent.
Bug: #2361749.
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
21875052adddf2b52bc57fea62bf097b8aa04cbf 07-Jan-2010 Romain Guy <romainguy@android.com> Fix two ListView bugs related to onAttachedToWindow/onDetachedFromWindow.
Bug: #2359368.

onDetachedFromWindow() would never be called for views living in the scrap heap, but onAttachedToWindow() could be called several times for views recycled from the scrap heap.
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
280c753ae30502a7ffa3648a2152b2b784327277 11-Nov-2009 Evan Millar <emillar@google.com> Modify text validation behavior.

-Only perform validation when the view is *losing* focus.
-Don't perform validation when the window focus changes. This causes odd
behavior like validation being peformed when menu is pressed, or long
press dialogs pop-up.
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
4eb3efc8b270d2569fd813546f85add92e7f0ab0 06-Oct-2009 Bjorn Bringert <bringert@android.com> Fix back button handling in ACTV

AutoCompleteTextView.onKeyPreIme() used
getKeyDispatcherState().startTracking(event, this) to start tracking
the back button, but didn't update the state of the event
before checking event.isTracking().

Fixes http://b/issue?id=2167168
"AutoCompleteTextView back button handling is broken"

Change-Id: I2c5f1e761872b9e02d85ff6f958fabd558d041a0
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
aa1c6311d6d900261bcd9f3b0986b6c0394af07a 30-Sep-2009 Romain Guy <romainguy@android.com> Fix possible crash in AutoCompleteTextView.

This change makes sure that ACTV will not take action when an event is
received in a popup that just got dismissed.

This change also makes public two XML attributes of ACTV whose corresponding
Java APIs are public.

This change also fixes a couple of typos.

Change-Id: I78f113bc522d199ff3db44fc4cc3a1882afe822e
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
875fca2e18296ffd8bbe9ef4e1769d24a59f3584 17-Sep-2009 Bryan Mawhinney <bryanmawhinney@google.com> Make ACTV use all available space if height is FILL_PARENT.

This prevents the drop down from resizing when the keyboard is shown / hidden, and thus fixes the issue where the 4th item in the list could not be selected when in landscape mode.

Bug: 2096394
Change-Id: Id0e687c897a724379073dcfa82de7ce89ae12035
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
8d37426c754e9822feaa8c6cc0b7c13e8523e217 15-Sep-2009 Dianne Hackborn <hackbod@google.com> Various fixed for back key handling.

My last change was far from perfect. Hopefully this gets us
a little closer.

Change-Id: I413e55b6af42400b565de3040859d25d668bc9d2
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
83fe3f559249451706957b1a5f660b2b8272f114 13-Sep-2009 Dianne Hackborn <hackbod@google.com> Last big work on #1991910: Make swipes work with capacitive keys

This takes care of allowing us to cancel the back button. The
back button is a bear because it is strewn all over the place --
everywhere you can close something, there is some code looking
for the back button that now needs to deal with being canceled.

The main things changed are activity (of course), dialog,
input method, search dialog. There are some other misc places
in the framework (and some I missed here that I will get in a
second pass).

To facility all of this, the key dispatching APIs now provide
a lot more support for dealing with looking for cancelled keys,
and incidentally also provide an actual API for catching long
key presses. This also helped clean up the code in PhoneWindow
where it deals with all of the combinations of key pressed and
releases. (And also allows people to override
Activity.onKeyLongPress() to provide a different long press
action for a standard key like search.)

And while I was doing this, I reworked how we detect long
presses by having this be part of the key event delivered by
the window manager. This should greatly reduce (hopefully
outright eliminate) the problems with long presses being
mis-detected when an application is being slow.

Change-Id: Ia19066b8d588d573df3eee6d96e1c90fdc19f57d
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
332aaaf92fb0bae521006907db9559b8e14f1b96 07-Aug-2009 Karl Rosaen <krosaen@google.com> am a7a3b6ef: Dismiss both the soft keyboard and the search dialog on back if there is no text entered and no shortcuts are being obscured by the soft keyboard.

Merge commit 'a7a3b6ef0fdaf6b17993642b76baf90a03ae0077'

* commit 'a7a3b6ef0fdaf6b17993642b76baf90a03ae0077':
Dismiss both the soft keyboard and the search dialog on back if there is no text entered and no shortcuts are being obscured by the soft keyboard.
a7a3b6ef0fdaf6b17993642b76baf90a03ae0077 07-Aug-2009 Karl Rosaen <krosaen@google.com> Dismiss both the soft keyboard and the search dialog on back if there is no text entered and no shortcuts are being obscured by the soft keyboard.

Fixes bug 2039508. This makes backing out of the search dialog easier when dismissing the soft keyboard doesn't really
add any value.
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
383cc38a203b11d68c525505ef51c26d4ff6de66 29-Jul-2009 Android (Google) Code Review <android-gerrit@google.com> am 6b46dc86: Merge change 8840 into donut

Merge commit '6b46dc8616dff7a5049b9fbaa7bbf8b4c0840eb4'

* commit '6b46dc8616dff7a5049b9fbaa7bbf8b4c0840eb4':
Add padding to height of AutoCompleteTextView drop-down.
5420d01cef810c34d754cadfaa1e8cae13af06de 28-Jul-2009 Bjorn Bringert <bringert@android.com> Add padding to height of AutoCompleteTextView drop-down.

As described in http://b/issue?id=2017825
PopupWindow.getMaxAvailableHeight() does not include the padding in
the available height. To get the ACTV drop-down to actually fill
the screen, this change adds the padding to the value returned
by PopupWindow.getMaxAvailableHeight().

This is part of the fix for http://b/issue?id=2014450
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
48000fe23a339322429d6eb306bad0a30a49f62d 28-Jul-2009 Android (Google) Code Review <android-gerrit@google.com> am c6590d6f: Merge change 8759 into donut

Merge commit 'c6590d6f390fc69fe15a9a565327a8f8c97f107b'

* commit 'c6590d6f390fc69fe15a9a565327a8f8c97f107b':
Cancel search on BACK if IME is obscured.
003ad48380fe90556da408fedba7dfc1a37790b9 28-Jul-2009 Bjorn Bringert <bringert@android.com> Cancel search on BACK if IME is obscured.

This adds a hidden method AutoCompleteTextView.isImeHidden(),
and uses that in SearchDialog to cancel the search dialog
when BACK is pressed, if there is no previous search component
to return to.

mlebeau says:
If we fill the whole screen then it makes the issue of the back
button a little more important. Specifically, right now if you have
the list expanded and you press back, the keyboard hides but it's not
really showing any more anyway so it seems like pressing the button
does nothing. We rationalized this by saying "part of the keyboard
will be showing so it won't be completely non-obvious that it was
hidden". But since really the right UX is to fill the screen, as part
of this we should probably also add logic to the back button such
that if it is pressed when the list is obscuring the keyboard
(i.e. softInputMode on the PopupWindow is INPUT_METHOD_NOT_NEEDED)
then we should hide the dialog entirely rather than closing the
keyboard.

This is part of the fix for http://b/issue?id=2014450
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
e39900ca7aa73a7a484cc0cff79188940df64cdb 23-Jul-2009 Mike LeBeau <mlebeau@android.com> Merge commit '4182e684' into manualmerge

Conflicts:
core/java/android/widget/AutoCompleteTextView.java
d4760d77e7e8ab66af0307dcae39e0a8e9d90a14 23-Jul-2009 Mike LeBeau <mlebeau@android.com> Add new hidden API setForceIgnoreOutsideTouch to AutoCompleteTextView for
use by SearchDialog. SearchDialog wants to be able to say a dropdown should
not always be visible but still let it ignore outside touch when it does
show.

Fixes http://b/1997170
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
e75cfdc7336aca420fd9f537f179b2526442b9fa 22-Jul-2009 Android (Google) Code Review <android-gerrit@google.com> am b551fb87: Merge change 8210 into donut

Merge commit 'b551fb872be9b758c7793f56398d25a74d4a404c'

* commit 'b551fb872be9b758c7793f56398d25a74d4a404c':
Always call ensureImeVisible when the text field is clicked. We want this
470c565b6adf4847db7e10611b18f67bf9111768 22-Jul-2009 Mike LeBeau <mlebeau@android.com> Always call ensureImeVisible when the text field is clicked. We want this
regardless of whether dropDownAlwaysVisible is true or not, as long as
the popup is showing and is potentially obscuring the IME.
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
90ad64b2cb862f3ef6c61eee6a3833efb4337eaf 20-Jul-2009 Android (Google) Code Review <android-gerrit@google.com> am 51cefb2e: Merge change 7889 into donut

Merge commit '51cefb2ef58e18acad800c9aa63c2a7eee4d9731'

* commit '51cefb2ef58e18acad800c9aa63c2a7eee4d9731':
Ignore unneeded soft keyboard in ACTV height calc
00a5b99229e41c173afd3071f15aaa725f531814 20-Jul-2009 Bjorn Bringert <bringert@android.com> Ignore unneeded soft keyboard in ACTV height calc

Before, if dropDownAlwaysVisible was false,
the soft keyboard height was always taken into
account when calculating the available vertical space for
the AutoCompleteTextView drop-down height.
This meant that the drop-down would never pop over the soft
keyboard when navigating in the drop-down list.

This change makes the drop-down pop over the soft keyboard
when the keyboard is not needed, regardless of the value of
dropDownAlwaysVisible.

Fixes http://b/issue?id=1978935
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
9ae8b097567da74c790a23019526f3674a3ed8df 17-Jul-2009 Android (Google) Code Review <android-gerrit@google.com> am f32f746b: Merge change 7645 into donut

Merge commit 'f32f746b83826303350417ff9937a6f9e5488f24'

* commit 'f32f746b83826303350417ff9937a6f9e5488f24':
Make the SearchDialog's AutoCompleteTextView dropdown respect the
ffe3ecf2b1ee04288008758c0f60ae22238797c1 17-Jul-2009 Mike LeBeau <mlebeau@android.com> Make the SearchDialog's AutoCompleteTextView dropdown respect the
IME again when the user presses right or left from a query-jammed
suggestion to continue editing. Previously we required the user
to press on the text field again in order to get the IME to show.

We accomplish this by factoring out the code to 'ensureImeVisible'
into a separate method and calling that from SearchDialog.

Fixes http://b/1976338
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
24b03ace12dab2c786d5ba33b92be3f5b162982b 15-Jul-2009 Android (Google) Code Review <android-gerrit@google.com> am 00d3e361: Merge change 7153 into donut

Merge commit '00d3e361148133cea354d358757628b0acc01b75'

* commit '00d3e361148133cea354d358757628b0acc01b75':
Restore PopupWindow's original behavior and add an API to control the soft input
374aaaed32daa8482d98ec16988b2b51547f035d 15-Jul-2009 Romain Guy <romainguy@android.com> Restore PopupWindow's original behavior and add an API to control the soft input
mode.
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
0236141742e59ed2926700a4eaaa0a4cdcdf1e75 08-Jul-2009 Android (Google) Code Review <android-gerrit@google.com> am 7bf9f930: Merge change 6415 into donut

Merge commit '7bf9f930d986335cd24dc15e2ee588b851f194d4'

* commit '7bf9f930d986335cd24dc15e2ee588b851f194d4':
Fixes #1748951. Calling setListSelection() explicitely should cancel the selection hidden flag.
fb7ed107356a66a55f003a43a7acc2fdbed1e9c2 08-Jul-2009 Romain Guy <romainguy@android.com> Fixes #1748951. Calling setListSelection() explicitely should cancel the selection hidden flag.
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
9b7df7e628de5c44d2b04317da01b34f7d5e0edb 03-Jul-2009 Satish Sampath <satish@android.com> am 1b1a6e40: Fix build break by adding an @hide javadoc comment.

Merge commit '1b1a6e406c4233b309baee85e14f5a563ca63c48'

* commit '1b1a6e406c4233b309baee85e14f5a563ca63c48':
Fix build break by adding an @hide javadoc comment.
ed9f4c4c2fb764de14660432a9f04539b4373726 03-Jul-2009 Satish Sampath <satish@android.com> am fef8d3e4: Make search UI open up quicker to the user.

Merge commit 'fef8d3e4d8f6f46c098d04b3a57409c947ec1c75'

* commit 'fef8d3e4d8f6f46c098d04b3a57409c947ec1c75':
Make search UI open up quicker to the user.
1b1a6e406c4233b309baee85e14f5a563ca63c48 01-Jul-2009 Satish Sampath <satish@android.com> Fix build break by adding an @hide javadoc comment.
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
fef8d3e4d8f6f46c098d04b3a57409c947ec1c75 01-Jul-2009 Satish Sampath <satish@android.com> Make search UI open up quicker to the user.

On invoking the search UI, the drop down list box with past queries and shortcut items
appears after a few hundreds of milliseconds on screen. This was because we were
displaying the drop down within the onFilterCompleted callback after the list box filtered
the items based on the given query text. While that code path is necessary, for the first
invocation of the search dialog with an empty query we can show the list box before the
text stuff happens. This change does that, issuing an async request to show the drop
down after pending events have been processed.

Without this change, on an average it took 350ms for the code to show the drop down.
With this change, on an average it takes 150ms.
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
62ebe364cb6d9bd63d5603c0569ed842c4492c63 30-Jun-2009 Android (Google) Code Review <android-gerrit@google.com> am 3a15fbd7: Merge change 5581 into donut

Merge commit '3a15fbd7df56e44060c78d7832fbea895ceb9bbf'

* commit '3a15fbd7df56e44060c78d7832fbea895ceb9bbf':
Add a null check in an AutoCompleteTextView callback to prevent a crash.
d072154bddbfda8eb99a65b724922785f896f8eb 27-Jun-2009 Eric Fischer <enf@google.com> Add a null check in an AutoCompleteTextView callback to prevent a crash.

It looks like the drop down list had already been taken down before the
callback fired so it caused a null pointer exception. In this case just
do nothing instead.

Bug 1927858
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
2ac3412001f7dceb0d3a7641359e3718179b2613 24-Jun-2009 Romain Guy <romainguy@android.com> resolved conflicts for merge of 5a42b083 to master
e29f064383cbc745c8605c707000ab4e16ee0aac 24-Jun-2009 Romain Guy <romainguy@android.com> Fixes #1905761. Updates the height of ACTV's drop down whenever the IME changes.
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
9f79975fa03311dd682611d743e9257654d85c59 22-Jun-2009 Android (Google) Code Review <android-gerrit@google.com> am ecfb9f91: Merge change 4940 into donut

Merge commit 'ecfb9f91afa49df7b9b62526dcaca431b5ff1e01'

* commit 'ecfb9f91afa49df7b9b62526dcaca431b5ff1e01':
Fixes #1933585. Don't dismiss ACTV's drop down when it's set to alwaysVisible.
7299807d1895ea25cbe45d32b6edfd9a5723ee7a 22-Jun-2009 Romain Guy <romainguy@android.com> Fixes #1933585. Don't dismiss ACTV's drop down when it's set to alwaysVisible.

This change also resizes the drop down automatically whenever the soft input
method is shown/hidden.
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
845970ff256fb75a0d666b26f72dca33a3909c37 18-Jun-2009 Romain Guy <romainguy@android.com> am 465dee4b: Fixes #1819572. Do not resurrect the list\'s selection when the user moved it away.

Merge commit '465dee4b4b491fdbb082218e5eb1010a416992f9'

* commit '465dee4b4b491fdbb082218e5eb1010a416992f9':
Fixes #1819572. Do not resurrect the list's selection when the user moved it away.
465dee4b4b491fdbb082218e5eb1010a416992f9 18-Jun-2009 Romain Guy <romainguy@android.com> Fixes #1819572. Do not resurrect the list's selection when the user moved it away.

This is a workaround for a touch mode issue.

Touch mode is propagated lazily to windows. This causes problems in
the following scenario:
- Type something in the AutoCompleteTextView and get some results
- Move down with the d-pad to select an item in the list
- Move up with the d-pad until the selection disappears
- Type more text in the AutoCompleteTextView *using the soft keyboard*
and get new results; you are now in touch mode
- The selection comes back on the first item in the list, even though
the list is supposed to be in touch mode

Using the soft keyboard triggers the touch mode change but that change
is propagated to our window only after the first list layout, therefore
after the list attempts to resurrect the selection.

The trick to work around this issue is to pretend the list is in touch
mode when we know that the selection should not appear, that is when
we know the user moved the selection away from the list.

This boolean is set to true whenever we explicitely hide the list's
selection and reset to false whenver we know the user moved the
selection back to the list.

When this boolean is true, isInTouchMode() returns true, otherwise it
returns super.isInTouchMode().
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
21373aaef203ef442f435577ce4641c6b1a3030a 11-Jun-2009 Mike LeBeau <mlebeau@android.com> resolved conflicts for merge of 174231 to master
50145bc883909c4b1533894a2b947eed21312514 11-Jun-2009 Bjorn Bringert <bringert@android.com> ACTV: getWindowVisibility() instead of private attach count

When debugging a problem with the search dialog drop-down
sometimes not showing up, I saw that the mAttachCount variable
in AutoCompleteTextView could get a negative value because
onDetachedFromWindow() was called multiple times. This lead to
the drop-down not being displayed on filtering.

Instead of the private attach count in ACTV, this change
uses View.getWindowVisibility().
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
b9048924c77fec949f5e88990480f2fe58b8a991 10-Jun-2009 Android (Google) Code Review <android-gerrit@google.com> am a32b5f32: Merge change 2411 into donut

Merge commit 'a32b5f3252a58416f328399680395aa5fa936640'

* commit 'a32b5f3252a58416f328399680395aa5fa936640':
Manual merge from cupcake_dcm. Need to be reviewed by enf.
c1d2748d442f06a7266be04b9e9c7d20609ad5cc 25-May-2009 Daisuke Miyakawa <dmiyakawa@google.com> Manual merge from cupcake_dcm. Need to be reviewed by enf.
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
ddf9856c7de043674d9ede006aefc7769879a4b8 09-May-2009 Mike LeBeau <mlebeau@android.com> merged 98acd54, resolved conflicts
98acd54fa6657e8131b3a2a957de7882a2f511ab 08-May-2009 Mike LeBeau <mlebeau@android.com> Make the search dialog's autocomplete dropdown behave correctly
with respect to the soft keyboard. getMaxAvailableHeight in
PopupWindow relies on View's getWindowVisibleDisplayFrame, which
always takes into account the IME, whereas in this case, because
we want the window to extend down to the bottom of the display
when it is being interacted with by the user, I added a new
boolean option 'ignoreBottomDecorations' to getMaxAvailableHeight.
If true, the method returns the height which will extend the
PopupWindow down to the bottom of the screen, rather than just
down to the IME.

Then in AutoCompleteTextView, I set this to true when the
dropDownAlwaysVisible attribute is true and the PopupWindow's
input method mode is INPUT_METHOD_NOT_NEEDED (which happens when
the list is dragged or otherwise interacted with).

Then, because the dropdown height is only calculated when we call
showDropDown(), I had to replace a couple calls to mPopup.update().

There are still a few remaining bugs here I'm tracking Still to do:
* Fix a strange re-placement of the window which happens
intermittently.
* Strange behavior when using the directional pad.
* In a few cases, the list does not correctly size itself to the IME.
This seems to be because the available height is calculated before
the IME is yet on screen, and thus is calculated as the entire screen.
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
3ee2f8189f145e2cd0173a20d156dec47274bd13 02-May-2009 Android (Google) Code Review <android-gerrit@google.com> am 854c8c7: Merge change 896 into donut

Merge commit '854c8c78c1bce214f6479772d94147070ec6764f'

* commit '854c8c78c1bce214f6479772d94147070ec6764f':
make AutoCompleteTextView take the alternate anchor view into account when computing the max available space on screen.
743ae65992641263ae006605462af0290aac84ad 01-May-2009 Karl Rosaen <krosaen@google.com> make AutoCompleteTextView take the alternate anchor view into account when computing the max available space on screen.

before, it always computed the height based on the text view itself being the anchor. This fixes the clipping bug
in the search dialog.
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
bb15b1cb330bafc0cac993ff0e6bf5c3ba7d10aa 30-Apr-2009 android-build SharedAccount <android-build@google.com> fixed two stray merge issues
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
bff1389c9ab4442a6e278cf84ce37eadad21a9a1 29-Apr-2009 The Android Open Source Project <initial-contribution@android.com> fix conflict markers
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
2f7e0447ac746e940db753178d513df914c20334 29-Apr-2009 Karl Rosaen <krosaen@google.com> am 98e333f: Fix back key and ime behavior for search dialog.

Merge commit '98e333f551a4bf2ebb50bb97a2a56b14bfdcd74b'

* commit '98e333f551a4bf2ebb50bb97a2a56b14bfdcd74b':
Fix back key and ime behavior for search dialog.
8f080ec4292be02fad9896260bbd3cf5461f9399 29-Apr-2009 The Android Open Source Project <initial-contribution@android.com> am f3ccf8a: Merge branch \'readonly-p4-donut\' into donut
98e333f551a4bf2ebb50bb97a2a56b14bfdcd74b 28-Apr-2009 Karl Rosaen <krosaen@google.com> Fix back key and ime behavior for search dialog.

The back key now dismisses the soft keyboard, and then the dialog.

The soft keyboard behavior is improved by having ACTV do the following when 'mDropdownAlwaysShowing' is true:
- touching outside of the drop down doesn't dismiss it
- touching the text field ensures the imei is brought in front of the drop down
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
875d50a4b9294b2be33cff6493cae7acd1d07ea7 24-Apr-2009 Karl Rosaen <> AI 147564: Merge back from search branch to donut. Notes:
- all public apis and framework changes have been reviewed by relevant folks in our branch (e.g romainguy)
- all new public apis are @hidden; they will still get reviewed by api council once we're in git
- other than that, it's mostly GlobalSearch and search dialog stuff, a new apps provider, and some tweaks
to the contacts provider that was reviewed by jham

Automated import of CL 147564
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
95a1b260fcaa881cea8d6cfdcb3f80acc7580b9e 02-Apr-2009 Jeffrey Sharkey <> AI 144005: Fix auto-merge method duplication that broke build.

Automated import of CL 144005
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
f0bc7ecebf8c30732f6de109b9e04dab253c3d08 01-Apr-2009 Jeffrey Sharkey <> AI 143909: am: CL 143908 am: CL 143907 Make search widget drop-down wider.
Original author: jsharkey
Merged from: //branches/cupcake/...
Original author: android-build
Merged from: //branches/donutburger/...

Automated import of CL 143909
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
8126ac66b631dc635d8fab8a240840989cbd2a05 01-Apr-2009 Jeffrey Sharkey <> AI 143908: am: CL 143907 Make search widget drop-down wider.
Original author: jsharkey
Merged from: //branches/cupcake/...

Automated import of CL 143908
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
7b0b1ed979aa665175bf3952c8902ce13c763ab8 19-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import //branches/master/...@140412
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
ba87e3e6c985e7175152993b5efcc7dd2f0e1c93 13-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //branches/cupcake_rel/...@138607
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
c39a6e0c51e182338deb8b63d07933b585134929 11-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //branches/cupcake/...@137873
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
9066cfe9886ac131c34d59ed0e2d287b0e3c0087 04-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@135843
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
d83a98f4ce9cfa908f5c54bbd70f03eec07e7553 04-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@135843
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
076357b8567458d4b6dfdcf839ef751634cd2bfb 03-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@132589
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
3dec7d563a2f3e1eb967ce2054a00b6620e3558c 03-Mar-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //depot/cupcake/@137055
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
d24b8183b93e781080b2c16c487e60d51c12da31 11-Feb-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //branches/cupcake/...@130745
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
22f7dfd23490a3de2f21ff96949ba47003aac8f8 20-Jan-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //branches/cupcake/...@127101
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
9266c558bf1d21ff647525ff99f7dadbca417309 16-Jan-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //branches/cupcake/...@126645
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
b798689749c64baba81f02e10cf2157c747d6b46 10-Jan-2009 The Android Open Source Project <initial-contribution@android.com> auto import from //branches/cupcake/...@125939
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
f013e1afd1e68af5e3b868c26a653bbfb39538f8 18-Dec-2008 The Android Open Source Project <initial-contribution@android.com> Code drop from //branches/cupcake/...@124589
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java
54b6cfa9a9e5b861a9930af873580d6dc20f773c 21-Oct-2008 The Android Open Source Project <initial-contribution@android.com> Initial Contribution
/frameworks/base/core/java/android/widget/AutoCompleteTextView.java