History log of /frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
3e1e78ccd5936111f31a709592f11aa7c677c42d 05-Jun-2012 James Dong <jdong@google.com> Fix green or corrupted video frames in the exported movies

At least two use cases are affected: trimming and transition clip generation.

If the starting time of the transition or the trimming position is not the same as
that of any existing video frame, the video frame right before the transition
starting position or the trimming position must be encoded as the the first video
frame for the transtion or the trimmed video, and it is encoded as a key frame.
This frame was not saved without the patch.

In the transcoding phrase, since we could not find such a frame, the existing
code did not return an error, and incorrectly used some other frame to serve
as the reference key frame for the remaining video frames of the transition or
the trimmed video. As a result, we may see corrupted or green video frames in
the exported movies.

The fix is to always save the frame right before the trimming position or
the transition starting time, so that a key frame will always be encoded, and
the right reference frame is used for remaining video frames. In addition,
checks are added to prevent from future mistakes to use incorrect reference frames.

Patch was originally contributed by teng.hong@nxp.com

Change-Id: I182784d4c1786224445224634edab3338bf2278f
related-to-bug: 5713461
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
ff65330bfdd2841110d8ff2a1aba3543b2cb3156 10-Feb-2012 James Dong <jdong@google.com> Fix green frame issue

When the transition clip is generated: two clips in general are involved.
The second clip was assigned the incorrect effect number when a transition was coupled with a color effect

o patch contributed by Hong Teng <hongteng@nxp.com>
o related-to-bug: 5713461

Change-Id: I61b497620264692b331da8b8e7753240edc5d1aa
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
eac28ab858dc4ecdfd25b6d8851219e6787d1222 13-Oct-2011 Hong Teng <hongteng@google.com> Fix for 5154138 Titles are not aligned properly in a exported movie from Movie Studio
Apply frame effect(overlay) after rendering mode was done

Change-Id: I1ff9cc868117cc8dcdc735e6854ff429b74e8154
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
276adbc8cab51c5cd60906fdbff9c7d5345ad0a6 15-Sep-2011 Rajneesh Chowdury <rajneeshc@google.com> Fix for bug 5255159 Cannot play exported movie from Movie Studio

Ensure video encoder is not created and destroyed for every clip.

Change-Id: I7a1d525e7bcdc839acc39d43e5046207c2d3b44f
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
816cd5ae8896f4965b2f1a5ea72d59dcac7257cb 12-Sep-2011 Hong Teng <hongteng@google.com> Fix for
-5234840 corrupted frames in transition.
-Green frames in image transition.

modified: vss/mcs/src/M4MCS_API.c
modified: vss/src/M4VSS3GPP_EditVideo.c

Change-Id: I2632d47c44f00bbc81e2b3e19b225178ab456810
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
e9eec0e0975c57c0dac91eb5b4cbb052b7dd011a 30-Aug-2011 Rajneesh Chowdury <rajneeshc@google.com> Fix for 5156702 Rotate video output for thumbnails and export

This is part of a multi project submit.
This is the native engine part.

Change-Id: Icde922194a123a90544942caa12430fc3c4ef10e
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
d125366181feab7e45905a8051c94ab5a845e503 29-Aug-2011 Chih-Chung Chang <chihchung@google.com> Fix 5200858: we need to pass timestamp to render correct frames.

Change-Id: I262cefabea87f75883bcd074370deae054df3e88
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
0a25bd5bacf5408ca205b15e53cfb6dc2fc1d171 13-Aug-2011 Rajneesh Chowdury <rajneeshc@google.com> Fix for 4142219 Don't hard code platform-specific limitations.

Also fixes 5118207 add other video codec support for video editor export.

For importing video clips, Video Editor engine will query StageFright codecs
for supported codecs, profiles and levels.
For Export, the profile and level are configured in media_profiles.xml

Change-Id: I85c8bb8b87cfcf0f1351ecb8c4f369a8902e7a09
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
6e779fda8a4f6258f9b910290b2f296d18fb2585 04-Aug-2011 Rajneesh Chowdury <rajneeshc@google.com> Fix for 4132872 inefficient export logic.

Also fixes 3371103 Transitions between images takes a long time
to generate.

Redundant transcoding is removed. Decode encode will be done only
once per clip.
For images, conversion to 3gp clip is removed (except for generating
Kenburn image clip).

Change-Id: Id722cd0296641bd643eb5c63f4d8028716259c01
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
7dbd2c46824000ce473966637c11b8564682cb55 30-Jun-2011 Chih-Chung Chang <chihchung@google.com> Remove curtain effects (they are unused).

Change-Id: I8e1ccad3e9ddf4c272e85e7ca04582b4863c242d
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
b5c7784c96a606890eb8a8b560153ef4a5d1a0d9 23-Jun-2011 Thomas Le Guevel <thomaslg@google.com> Fix for: 4676350 Do not use dual copyright declaration for video editor code

Change-Id: I2856be051fa3b3ddfe67e096e45fb0b34beb92be
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
3b25fdc4a33b53cfcf67315c2d42ad699b8cefe2 22-Apr-2011 hongteng <hongteng@google.com> Fix for issue 3385135 "source code cleanup" engine part
- remove commented code
- remove code under #if 0
- remove macro FILE_LOWER_CASE as it is not used
- remove macro #if 1
- remove TIMESCALE_BUG macro, and all code under this macro as it is not used
- remove following unused functions:
* M4MCS_getExifInfo
* M4MCS_registerAudioEncoderExtended
* M4MCS_registerVideoDecoderExtended
* M4MCS_registerAudioDecoderExtended
* M4MCS_registerVideoEncoderExtended

Change-Id: I8e2916d956af6d381ae1962fedc61a8b48f60ce2
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
694816d7291f17364502ac5d3319684a0b180860 21-Apr-2011 Shyam Pallapothu <shyamp@google.com> Fix for issue 4133431 "Remove OSAL layer" in engine part

Change-Id: I98f98691048a5afc6f691b0cc3cec92e458e8f44
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
32ed3f4dad00f8a65f7e6b38402c70d5341c57eb 21-Apr-2011 Shyam Pallapothu <shyamp@google.com> Fix for issue 4133431 "Remove OSAL layer" in engine part

Change-Id: I9e2e142bcdf3153c529b790e368caea4fdb65ac8
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
d67e9da63323d965760337913f86de28024531a4 24-Feb-2011 Basavapatna Dattaguru <dattaguru@google.com> VideoEditor: Issue ID: 3371667: Fix Set1

Change-Id: I728bc27b86e0c8720a2d05e6cff8a76f820bf016
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
ac9dde5945fd00a6fb882bd171ee8a42a091fb86 17-Feb-2011 Danny Fernandes <dannyfernandes@google.com> Fixed issue 3421896 Slide transition causes images to jump in exported movie playback

Change-Id: I78cbe7e3509f65ce651de926267fad4f65c3c263
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
f58e4c332ecf8c0cd6037b010256d0b4c56e6a17 16-Feb-2011 Danny Fernandes <dannyfernandes@google.com> Fixed issue 3443078 overlay flicker on transition in exported video

Change-Id: I4c625a1f7c9897ee0d9aee3f521974456c97ad8c
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
aae29543bd55d383285a103e37e86afd18068fcd 02-Feb-2011 Dheeraj Sharma <dheerajs@google.com> Fix for issue: 3404624 The overlay in the exported video is blurry

Change-Id: Ia24eeec5d22b1f9bc911260292e8e481830f2493
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
bb337b471658b7c2264c6ff1bb613739db851baa 31-Jan-2011 Santosh Madhava <smadhava@google.com> Fix for issue 3404624 - The overlay in exported video is blurry

Change-Id: I52bd474c85589bd75e58c675045a7c7fe058a228
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
c6a88ac5d620a5cd47b2741a915d661aab8fe0b4 20-Jan-2011 Dharmaray Kundargi <dharmaray@google.com> Fix 3367037 Transition are of low Quality

Change-Id: I511546aef895edbfed16fc855bada93486dd886a
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c
7c9d8018755adf1857571125ba1b3598c96ea506 17-Jan-2011 Dharmaray Kundargi <dharmaray@google.com> Removed unwanted line in M4READER_Amr.h

vss core files upload on honeycomb

Change-Id: I61206ae2398ce8ac544c6fb01a76fe8917bce75b
/frameworks/av/libvideoeditor/vss/src/M4VSS3GPP_EditVideo.c