History log of /frameworks/av/media/libstagefright/codecs/aacenc/src/adj_thr.c
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
b5325c8a8fff4d735c24d9a8138e4213ee0833d5 23-May-2012 Martin Storsjo <martin@martin.st> stagefright aacenc: Move system headers before local headers

This avoids issues with the encoder's own definition of __inline,
which conflicts with headers brought in by string.h in glibc.

Change-Id: I9e3fbf8d892529940ea67a46e67a9abe71d9c5fa
/frameworks/av/media/libstagefright/codecs/aacenc/src/adj_thr.c
1f7e2d9906d25b4e709c247d78537ee826d31051 09-Mar-2012 Conley Owens <cco3@android.com> Merge changes I00c852e4,Ib31bf028

* changes:
stagefright aacenc: Avoid overflows when calculating normFactor
stagefright aacenc: Avoid a division by zero
80d4b8903ed09d2cf9ac35391f04eb8619f47a1e 24-Feb-2012 Jean-Baptiste Queru <jbq@google.com> Merge "stagefright aacenc: Zero-initialize a struct"
dcdfc1ad27cb64bcb51a864b020b846ba22ce2a7 19-Feb-2012 Martin Storsjo <martin@martin.st> stagefright aacenc: Avoid overflows when calculating normFactor

normFactor is calculated using the saturating L_add function,
but if the value added (*psfbPeFactors) is negative, the sum
can end up negative.

*psfbPeFactors can end up negative if redThrExp is less than
*psfbNActiveLines.

In cases where *psfbPeFactors ended up negative, normFactor
became INT_MIN, causing division by zero later.

Change-Id: I00c852e457b22f7eef4d6ed1887629828057206b
/frameworks/av/media/libstagefright/codecs/aacenc/src/adj_thr.c
01e29ede19cd7d85bfef38896de8e71e569cd211 19-Feb-2012 Martin Storsjo <martin@martin.st> stagefright aacenc: Avoid a division by zero

In rare cases, the result of normFactor * (*psfbNActiveLines)
could be zero, leading to a division by zero in pow2_xy.

In these cases, normFactor was INT_MIN, and if *psfbNActiveLines
was 2, the product was zero.

normFactor being INT_MIN is a bug in itself though.

Change-Id: Ib31bf02889615a7be3bd1bc028da8a7651a8dbee
/frameworks/av/media/libstagefright/codecs/aacenc/src/adj_thr.c
60866592ed6953f2b0e12cefcd58f1ced26546d0 12-Jan-2012 Martin Storsjo <martin@martin.st> stagefright aacenc: Properly terminate a comment

This avoids a warning about /* within a comment.

Change-Id: I9079909734d35db5ab0fd54b46173d7a1848d0c9
/frameworks/av/media/libstagefright/codecs/aacenc/src/adj_thr.c
132e42c04a58e623efa6cd6ca43641cd80db0f05 05-Apr-2011 Martin Storsjo <martin@martin.st> stagefright aacenc: Zero-initialize a struct

This avoids using uninitialized data in some cases, according
to valgrind.

Change-Id: I2eb5242b93c4d83a1cf6a15f022ec9579e0742a4
/frameworks/av/media/libstagefright/codecs/aacenc/src/adj_thr.c
b676a05348e4c516fa8b57e33b10548e6142c3f8 05-Apr-2011 Mans Rullgard <mans@mansr.com> stagefright aacenc/amrwbenc: Remove trailing whitespace

This was applied in AOSP master earlier, in commit
b21611e5b0f1797e39e781d91ade023bac87637f, but when merged
into the Google internal tree in
88c2d4d26d79384f32a25bd775cf873cb678b12a, none of these
changes have been brought in. (The diff of this merge commit
and its first parent, d94b71d, is empty.)

Therefore, reapply the rest of these changes on the files
that still are present in the current version.

Change-Id: I645a9b9134769958a11808a06163123d28d83e46
/frameworks/av/media/libstagefright/codecs/aacenc/src/adj_thr.c
e2e838afcf03e603a41a0455846eaf9614537c16 22-Apr-2011 Mans Rullgard <mans@mansr.com> Convert line breaks to Unix style

Change-Id: I6219725a9fbd72432bad71a176c14f26fabdbd5f
/frameworks/av/media/libstagefright/codecs/aacenc/src/adj_thr.c
956c553ab0ce72f8074ad0fda2ffd66a0305700c 15-May-2010 James Dong <jdong@google.com> Initial software encoder checkins

Change-Id: I27f387db23594e46384c4eb3a0093ce220bb6b60
/frameworks/av/media/libstagefright/codecs/aacenc/src/adj_thr.c