| 855f5407c74694ebd924b36738ecc79241c4becf |
|
15-May-2012 |
Gilles Debunne <debunne@google.com> |
Merge "Minor changes in SpellCheckSpan pool management in SpellChecker" into jb-dev
|
| bec154c50036bc70a37518dc93f6821209f58728 |
|
11-May-2012 |
satok <satok@google.com> |
Allow the spell checker to remove existing misspelled spans
Bug: 6451163
Change-Id: If018533e8855e9dc21ab2a09ae31aa80ef260b72
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 37e169cd1429c76a0223d8fdd77622ead718bbff |
|
11-May-2012 |
satok <satok@google.com> |
Add a safety net to set range span in the spell checker
Bug: 6476578
Change-Id: I60ad82f80770dcb67fd9663dac64dc81634d7014
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 12ff149265ba599627896f6c1a0e3ea9721b54c1 |
|
09-May-2012 |
Gilles Debunne <debunne@google.com> |
Merge "Spell checker underlines words even when there are no suggestions" into jb-dev
|
| 69865bd6860a97793a06523a48dfe6472e9b7562 |
|
09-May-2012 |
Gilles Debunne <debunne@google.com> |
Minor changes in SpellCheckSpan pool management in SpellChecker
Bug 6464190
The 'inProgress' flag is set to false when the SpellCheckSpan starts
to get used (instead of a less intuitive when it is removed).
Pool recycling in handled by onSpellCheckSpanRemoved, called from
the TextView's SpanWatcher, when a SpellCheckSpan is removed for any
reason (from the SC code or due to text editing).
The other change is that Sentence SC now correctly removes the span
from the text (and hence recycles it in the pool).
Change-Id: If8b433fd5e41d4dc0304a127ebcc088ea1eecaa7
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| a4c82c1c78cdd37e0dea1b5b2f44c25cc584034c |
|
09-May-2012 |
satok <satok@google.com> |
Not to add invalid spell check spans
Bug: 6464197
Change-Id: I6e9d359847b200e2afae61f85eb7cfe7f179b888
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 41347e9e8bff93f42ac11a88875ce67e64e5c88c |
|
09-May-2012 |
Gilles Debunne <debunne@google.com> |
Spell checker underlines words even when there are no suggestions
Bug 6222722
Also fixed a cast to Long warning.
Change-Id: Ief299cc3cb952b83f774ca1be13dc69352015a3e
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 8589474d269818713c86ee5e69a685584d1c62e7 |
|
20-Apr-2012 |
satok <satok@google.com> |
DO NOT MERGE. Backport If36b8a69e7fa22e837c99d Fix the issue that the spell check doesn't start when the user changes the cursor position by touch
Change-Id: I1535eae23efc42660b9d1e6dbfba6c800b0302b2
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 24d146b966c87fd9c3b48027cbfb4238cb892ca5 |
|
26-Apr-2012 |
satok <satok@google.com> |
Fix the boundary of the sentence level spell check
Bug: 6400290
Change-Id: Ifb3b2f4034a1717369c63206611e5b6c441fded5
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 0b7d747e900dd9e6e6f62f10772c2dded9b9d0c6 |
|
24-Apr-2012 |
Gilles Debunne <debunne@google.com> |
Merge "Editor uses a SpanWatcher to track EasyEditSpans"
|
| c62589cbecef6e748bcc6c6f4ea6a8ff7656923f |
|
12-Apr-2012 |
Gilles Debunne <debunne@google.com> |
Editor uses a SpanWatcher to track EasyEditSpans
Will also fix Bug 6344997
The previous TextWatcher mechanism was inneficient. It require an
expensive getSpans() call to retrieve all the spans and then search
for the one we're interested in in case it has been changed.
The SpanWatcher is faster, it will broadcast the add/changed/removed
events we're interested in.
Now that we can rely on SpanWatcher, use it to directly track
addition and removals of EasyEditSpans.
No unit test for this feature which require an integration with
the voice IME. Easy to test manually though.
Change-Id: Idabcacc48c479bf9868d5204c0b0ca709207ede2
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 979de903695275bae08f2e7a4e99d342f0facd23 |
|
23-Apr-2012 |
satok <satok@google.com> |
Fix the first boundary of the sentence level spell check
Change-Id: I7c7659c921103d31f9909c14850088aef0d2eb19
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| e1e874854ab8b73dc5f2346108cbfe90dabaea18 |
|
18-Apr-2012 |
satok <satok@google.com> |
Optimize the timing to query sentence level spell checking
Bug: 6354647
Change-Id: I52e6c21387c7f4d6fc05b4c50bbb0a5a6c75194b
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| c7ee1b9369ffd7c21a70738056a82dc4238e7fc1 |
|
11-Apr-2012 |
satok <satok@google.com> |
Get rid of "isSentenceLevelSpellCheckSupported"
Bug: 6320351
Change-Id: I0e931b7248f8c65268b60af599c07432d58d2f1f
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 0249b43f6ce59bfec104f0fe606d9059244f8797 |
|
10-Apr-2012 |
Gilles Debunne <debunne@google.com> |
Faster and simpler replace in SSB, take two
This is a new version of CL 179343 which had to be reverted.
This problem of the previous CL is that the ComposingSpan that
was part of the replacement text was correctly added during the
replace but was immediately removed because it had a zero-length
size.
Swapping the add and remove blocks solves the problem.
The new non-zero length enforcement also revealed a bug in the
spell checker where we were creating useless range spans.
Change-Id: I59cebd4708af3becc7ab625ae41bc36837f1a1cf
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| a4fb0cb1fe63262170c13a7853be4ccd45083670 |
|
08-Mar-2012 |
satok <satok@google.com> |
Merge "Optimization of the request of the sentence level spell check"
|
| fe5a51ee0440beb54f9ccba8b85f43b5f47f4cc2 |
|
08-Mar-2012 |
satok <satok@google.com> |
Optimization of the request of the sentence level spell check
Change-Id: Ic89b0dd027bf0af6e8f1877043ae40baed48b2a4
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 3154fc45e5294619c6f17c6e325036fbe8c70c5f |
|
08-Mar-2012 |
satok <satok@google.com> |
Merge "Fix spell checker framework"
|
| 2428ccbbde3ca1f6643a4952a6ca881dab80ce45 |
|
08-Mar-2012 |
satok <satok@google.com> |
Fix spell checker framework
Change-Id: I281d031259dd220936832668e7a4556473ccb2ce
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 792ee0cc4d9415e45a16803c6fe3e60c53760e25 |
|
08-Mar-2012 |
satok <satok@google.com> |
Fix possible NPE in SpellChecker
Change-Id: Ib3c9fe7189c8f31a460149add857e9855919f386
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 8898358bfdf4693af02ad454e1deb8034379ce02 |
|
30-Nov-2011 |
satok <satok@google.com> |
Handle sentence level spell checking hidden APIs
Change-Id: Ia91f1771c0b8ef458dd5b023f4c372cc36a15657
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| d404fe110558bd2e1960b428db6a2ee8bfd040cd |
|
21-Feb-2012 |
satok <satok@google.com> |
Refactor sentence level spell checking APIs
Support sentence level spell checking APIs: Step 1
Change-Id: I31c0b88e7885f33a0694ab60b8f2dbceeffe42f1
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 07ba2a2131abb4939d5b71ba27dcb68b2bba9255 |
|
14-Feb-2012 |
Gilles Debunne <debunne@google.com> |
Minor typo fixes
Change-Id: I8cd9500cc50b7a484bf387e6a6a0c9b4ffb175a4
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 6e0b22bea91398403ea500360b02ff2fc7a03d00 |
|
25-Jan-2012 |
Gilles Debunne <debunne@google.com> |
Modified algorithm to remove duplicated suggestions
Bug 5916225
Duplicates were removed when received from SpellChecker, in a way
that could move the top candidates lower in the list.
Moved that code to the part that creates the actual suggestion list,
to make it more generic. The order of the first SuggestionSpan is
guaranteed to be respected.
Also mentionned non null suggestions and fixed a problem in SuggestionSpan
constructor.
Change-Id: Iaa3b1b84ae512451e439e5c5e63448c2a19145b5
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| f43305fb057e0818db456065fba9698e2163a762 |
|
25-Jan-2012 |
satok <satok@google.com> |
Do not spell check when the keyboard language is not supported by the current spell checker
Bug: 5787064
Change-Id: I54a3955220bbe3dae999f6634ccd734e658e45c0
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 249d1e827a7ffe2a034130d05e18c7b521b0de9b |
|
13-Dec-2011 |
Gilles Debunne <debunne@google.com> |
Re-synced MR1 and master for SpellChecker
Some auto-merges got lost, re-syncing master with the latest
and greatest from MR1.
Change-Id: Ifc0b5d1fd2e11e68d219c3f491f37d4c047579a0
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| a4b1b8ab3c240efe82d1018a54277f16dc03a8fa |
|
13-Dec-2011 |
Gilles Debunne <debunne@google.com> |
am 7ffadba5: am 1fb90497: Merge "Text blinking cursor hard to see." into ics-mr1
* commit '7ffadba5dfbeeaa93a9559ca3eaf1a7719426a5f':
Text blinking cursor hard to see.
|
| c1761e7fe10390d90b805f373b51ecaabf214dac |
|
13-Dec-2011 |
Gilles Debunne <debunne@google.com> |
Fixed build after merge
Change-Id: Ifac89a70afa82047d97994860c6e58954f5d91d0
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 7cb77c1a0d86b0fbc8774cd90cc81debc3508be1 |
|
13-Dec-2011 |
Gilles Debunne <debunne@google.com> |
resolved conflicts for merge of 1742f20c to master
Change-Id: I02d84edfe8cc0b71881884ecec21f831404aa555
|
| 961ebb9ab0a6d45b06a74aa90894f7fda3d528c6 |
|
12-Dec-2011 |
Gilles Debunne <debunne@google.com> |
Text blinking cursor hard to see.
Bug 5738416
This problem was introduced in
https://android-git.corp.google.com/g/#/c/152599
The invalidated cursor region is no longer expanded to include the
cursor drawable (different from the handles' drawables).
Added that code back. Added a flag, since invalidateRegion is also
used to invalidate text span regions in spell check (assumes the decorated
span bounds are not bigger that text boundaries), which is fine in case
of underline.
When the cursor is moved on a single line, invalidate the whole line
(same as what was done before). This is sub-optimal, will file a bug
to fix this. The core problem is that we should invalidate the previous
and the new cursor's positions. We only have one of these.
Change-Id: I9ada9340fb52aad3d80c39efd021fd3f9ec0cc4d
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 2afcfa42392996525c6a995b354b241f22429959 |
|
10-Dec-2011 |
Gilles Debunne <debunne@google.com> |
resolved conflicts for merge of 5371a165 to master
Change-Id: I61830ec96c277ebba9db3e40842597b9c98d53c7
|
| be5f49fb6e17e0b9588d3b94022b7e3eb6d47317 |
|
26-Oct-2011 |
Gilles Debunne <debunne@google.com> |
Performance improvements for long text edition.
Limit each parse to batches of a few words, to keep the UI thread
responsive.
Possible optimizations for the future:
- SpellCheck in a thread, but that requires some locking mecanism
- Only spell check what is visible on screen. Will require additional
spans to tag the pieces of text.
This is a cherry pick of 145656 into ICS-MR1
Patch Set 2: Make the Runnable shared and stop it when detached.
Change-Id: Ibf8e98274bda84b7176aac181ff267fc1f1fa4cb
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 653d3a27878d5358b4a91518a756f6b9b3407b07 |
|
07-Dec-2011 |
Gilles Debunne <debunne@google.com> |
Limit created string size in Spell Checker
Change-Id: I2f4e7a8b0022d76bc30199ff80c2fe637dbe03ef
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| f9bb1cd1fcff7079445dae494ce5d56276092c11 |
|
07-Dec-2011 |
Gilles Debunne <debunne@google.com> |
resolved conflicts for merge of fb729202 to master
Change-Id: Ic571594b14f2822094d5c1aa4c4b1e9da4a2eae0
|
| 98a85c2de6b3f27ba1ccb2cfd44a775b4f490f72 |
|
06-Dec-2011 |
Gilles Debunne <debunne@google.com> |
Merge "Invalidated bounds tightened in TextView" into ics-mr1
|
| a49ba2f391cd0753eb12d2707bf9fe128e6566f0 |
|
02-Dec-2011 |
Gilles Debunne <debunne@google.com> |
(de)activating spell check taken into account immediately
Test for a change in the spell checker activate state on every
spell check. Add/remove suggestion spans accordingly.
Change-Id: I750f30b81464b85cebc695bdb0449ec038fc17df
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 8615ac9e049cdf4ab77b0897aca9bceec142c9fa |
|
30-Nov-2011 |
Gilles Debunne <debunne@google.com> |
Invalidated bounds tightened in TextView
New invalidateRegion method, with better horizontal invalidate
bounds in case the region is on one line.
Use by SpellChecker when a new SuggestionSpan is added.
Change-Id: Ide11f1d3d2b1350032b475db0641018a49c08d13
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 0dc1f648a09b46c45190ba1ce7daecf7fada4347 |
|
18-Nov-2011 |
satok <satok@google.com> |
add sentence level spell checker hidden apis
Change-Id: If65c89044bed064fd01a554e33176f64f7c21c0f
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| c95b7412c2d4b6dca0fdee631bd777b6148ddf81 |
|
10-Nov-2011 |
satok <satok@google.com> |
am 3628dafe: am 34bd5969: Merge "Respect user settings for spell checking language if explicitly set" into ics-mr1
* commit '3628dafe22aeeb2fca09b49d82c8d7289baf68ad':
Respect user settings for spell checking language if explicitly set
|
| 567354474f7893313d63b2bd13d07bf92aa729d3 |
|
10-Nov-2011 |
Marco Nelissen <marcone@google.com> |
Bug 5575396: close spell session on language change
Cherry pick change 8b67db17ec91956023e25674efe28a1f5ca970c8 from ics-mr1
Change-Id: I8166859e435f034535510a36772644cde3923cd9
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 05f24700613fb4dce95fb6d5f8fe460d7a30c128 |
|
02-Nov-2011 |
satok <satok@google.com> |
Respect user settings for spell checking language if explicitly set
Bug: 5554116
Change-Id: I8c16d732af1fe713d30d97dfe829ff16653c7f34
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 76bb11ca642556673249a6ef8b84ab2813deaa87 |
|
09-Nov-2011 |
Gilles Debunne <debunne@google.com> |
Merge "Bug 5575396: close spell session on language change" into ics-mr1
|
| 8b67db17ec91956023e25674efe28a1f5ca970c8 |
|
07-Nov-2011 |
Gilles Debunne <debunne@google.com> |
Bug 5575396: close spell session on language change
Change-Id: I661812c316ec9d98f66379357cbd1216bae65fa0
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 988af0861e5bb973b0593fbb19a8c357ae1c11e0 |
|
04-Nov-2011 |
Ken Wakasa <kwakasa@google.com> |
am 943f6d0b: Merge "Turn off the spell checker when the spell checker is disabled in the settings" into ics-mr1
* commit '943f6d0b33f599ed00b76c59b4a4b4c41d0e66f2':
Turn off the spell checker when the spell checker is disabled in the settings
|
| 9b3855b75246596fc704825dd92f9269f52cbe64 |
|
02-Nov-2011 |
satok <satok@google.com> |
Turn off the spell checker when the spell checker is disabled in the settings
Bug: 5554116
Change-Id: I9816101661e12cafdb9556c7e0bad39833f7dc67
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| e9b82808d412fa1b87954dd88579b92d0b4ab0e2 |
|
27-Oct-2011 |
Gilles Debunne <debunne@google.com> |
No threading issues in SpellChecker.
SpellChecker is exclusively called from the main UI thread and
there are no concurrency issues. As a result, the TextView's
wordIterator can safely be re-used in the parse() method.
Also reset the pool of SpellParsers on language change.
Change-Id: I1cc8a2750f21233754f006e40a81622730030ec8
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 35199f5ce7cfc433628a1beda84d80fcaa475e41 |
|
26-Oct-2011 |
Gilles Debunne <debunne@google.com> |
Performance improvements for long text edition.
Limit each parse to batches of a few words, to keep the UI thread
responsive.
Possible optimizations for the future:
- SpellCheck in a thread, but that requires some locking mecanism
- Only spell check what is visible on screen. Will require additional
spans to tag the pieces of text.
Change-Id: Ibf8e98274bda84b7176aac181ff267fc1f1fa4cb
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 9d8d3f1539ce5bdf512bd47ec1648609d6cde5b1 |
|
13-Oct-2011 |
Gilles Debunne <debunne@google.com> |
Spell checher's language synced with keyboard.
Bug 5379440. The spell check is now using the IME's language to
do the spell checking. Changing the input language triggers a
new spell check of the entire text.
Optimizations: ArrowKeyMovementMethod re-uses the TextView's
wordIterator, already set to the correct language.
One wordIterator shared by all SpellParsers in SpellChecker.
Cannot re-use TextView's because of concurrency issues.
With the current implementation, one has to type a new character
to see the new spell checking take place.
Change-Id: I0e460c0a6777548f89d03d6b68f3deea6606c17f
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| b10d396f2e1d0329013f5376bd486621bd177bc8 |
|
12-Oct-2011 |
Gilles Debunne <debunne@google.com> |
Merge "Bug 5385279: IOOB in createMisspelledSuggestionSpan"
|
| c08ec615d26508c14c44680ffe649d46be6de8c5 |
|
12-Oct-2011 |
Gilles Debunne <debunne@google.com> |
Bug 5385279: IOOB in createMisspelledSuggestionSpan
Race condition: when spell check result come back, the spell check span may no longer
be in the text, although it should have been removed by removeSpellCheckSpan.
This is possible because onGetSuggestions is called from an other thread
and it can see the text in an inconsistent state where the span may have been removed
from the text, but the listener that calls removeSpellCheckSpan has not yet been called.
As a result, onGetSuggestions still lists the span but getSpanStart returns -1.
Change-Id: Ia40f7ed2b46fc94888fce5a6b209fb0d0d529bbe
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 5915c885deaf40231c29bc720503dcf03acab188 |
|
11-Oct-2011 |
Gilles Debunne <debunne@google.com> |
Bug 5237623: word no longer underlined after replacement
When replacing a word, we need to remove *all* misspelled
suggestion spans, not just the one which triggered that popup.
Change-Id: I7be17ac626b26123b029f5e10c1e2eaa5f94d67c
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| f656030a865be029c7c29bab2ea6f5fff07624ae |
|
11-Oct-2011 |
Gilles Debunne <debunne@google.com> |
Bug 5437846: Crash in SpellChecker
The cached mText field from TextView is not constant overtime.
It is especially changed whne the first character of text is added.
Retrieve the actual current value everytime we use it.
Change-Id: Ie297a3292106879621e54a22e5d03444d442ec96
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 287d6c6e12a38864d019fa7b9184206bc8a31ea1 |
|
06-Oct-2011 |
Gilles Debunne <debunne@google.com> |
Bug 5250788: LatinIME slows down as amount of Text increases
Removed unnecessary CharSequenceIterator and made the WordIterator
work on String instead of CharSequence
Submit words to the spell checker by batches.
Refactored WordIterator to make it intrinsically local.
Change-Id: Ie9e30691985a130fa55cd052005ddb22a21761cb
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| e1fc4f6c3c7d573f013b707ee962d58f9fb636dd |
|
04-Oct-2011 |
Gilles Debunne <debunne@google.com> |
Optimisations and bugs in SpellChecker
A bug was introduced in a recent refactoring: correct words didn't have their
SpellCheckSpan removed, leaving a lot of useless spans.
SPAN_EXCLUSIVE_EXCLUSIVE should never have a 0-length. With Japanese characters
wordStart could be equal to wordEnd when parsing the text: skip these.
Using toString().substring(...) instead of subSequence(...).toString() which
is more efficient.
Change-Id: I670870a34565939b676400091f4852152a7f7124
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 176cd0d3b4a612b9fdd88c1d245e9fd93a327bf2 |
|
30-Sep-2011 |
Gilles Debunne <debunne@google.com> |
Bug 5384674: When only one suggestion is returned, it is displayed twice
Two separate issues here:
- The results of the spell checker may be identical to the one set by the IME. Since
we merge the spans, the entries are duplicated. Filter spell checker results to avoid
these duplicates.
- When the text is saved on rotation, the spans are saved and restored. Since we start
a new spell check when the window is attached, it also doubles the size.
Change-Id: I21e1a5ae1b264bc97f44d762e4589bf520c6c19c
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 9fb46925d33643f830dfc2cf5a15601eb416143b |
|
30-Sep-2011 |
Gilles Debunne <debunne@google.com> |
Merge "Bug 5384535: Underline for typo even if there are no suggestions"
|
| 70deff4c107963164f8b88365909fd30ab5e6526 |
|
30-Sep-2011 |
satok <satok@google.com> |
Use user's settings for the spell check language instead of the system locale
Bug: 5390462
Change-Id: Ia2a3981cb93f451646debe5ee6b037313825cf9f
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 1dd7e534e7870a4d2799e06dafdeffa932989f24 |
|
29-Sep-2011 |
Gilles Debunne <debunne@google.com> |
Bug 5384535: Underline for typo even if there are no suggestions
Change-Id: I63f78227a3a80c5fdb97b1d5d8d6c595a70e1990
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| b062e81e3a16af43db3619d721aa522c137d1aa9 |
|
27-Sep-2011 |
Gilles Debunne <debunne@google.com> |
Too many SpellCheckSpans are created.
Removed the Runnable in SpellChecker, spell check is triggered at the end
of updateSpellCheckSpans instead of when a new SpellCheckSpan is created.
Cache the spans in updateSpellCheckSpans to limit the calls to getSpans.
When typing, every new letter in a word will create a SpellCheckSpan
(this is needed in case the user taps somewhere else on the screen)
The SpellCheckSpans are pooled in SpellChecker to limit unnecessary new
SpellCheckSpan creation.
Minor optimization on test order in getSpans to avoid some calculation.
Spell check is not started everytime the selection is changed (would be
triggered when the insertion handle is moved). Explicitely do that only
on tap.
Change-Id: Ibacf80dd4ba098494e0b5ba0e58a362782fc8f71
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 186aaf973530f426b9b0e602e9744c591aa4aea9 |
|
16-Sep-2011 |
Gilles Debunne <debunne@google.com> |
Bug 5248215: Even though I turned off the Spelling correction, it still shows up
Bug 5313754: SpellCheckSession is released when the window loses focus.
When an EditText is initialized with text, a new spell check is initiated
and previous spell check spans are removed.
Requires a new flag to prevent this from happening when the window focus
change comes from the suggestion popup window being shown.
Also fixes bug 5329588: handle spell check language change.
This change has been reverted. This amended change defers the creation
of the SpellChecker, so that it is only created for editable TextView.
Patch 3: Bug 5332065, the spell check session is closed in onDetachedFromWindow, which is
called when the window is destroyed (like on rotation), which was not the case with
onWindowFocusChanged.
Patch 5: Fixed life cycle. A view can be created and never attached to the hierarchy. As
a result, the spellCheck session would not be closed. Moved spell check to onAttach and
perform a spell check when text is changed by setText only if the view has previously
been attached (and the spellChecker has been created).
Change-Id: Ic2cfbfc0d3f23c589dd9e37f02e4afc1d625615d
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| a80599f5be394edd9f3918ba03c490850a1d9e7f |
|
21-Sep-2011 |
Gilles Debunne <debunne@google.com> |
Revert "Bug 5248215: Even though I turned off the Spelling correction, it still shows up"
This reverts commit 6e405f84b8d0c7c0f939bc8e9bec17e65e704a2d.
Change-Id: I9593273d414aee1f9817f84b462cf45360ff19e3
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 6e405f84b8d0c7c0f939bc8e9bec17e65e704a2d |
|
16-Sep-2011 |
Gilles Debunne <debunne@google.com> |
Bug 5248215: Even though I turned off the Spelling correction, it still shows up
Bug 5313754: SpellCheckSession is released when the window loses focus.
When an EditText is initialized with text, a new spell check is initiated
and previous spell check spans are removed.
Requires a new flag to prevent this from happening when the window focus
change comes from the suggestion popup window being shown.
Also fixes bug 5329588: handle spell check language change.
Change-Id: I113229dbe06863d34c1369d05d067292894f73f1
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 0eea6681519277310e1733d791bfc0342b8e5cea |
|
29-Aug-2011 |
Gilles Debunne <debunne@google.com> |
Using ListView for Suggestion popup window
New background assets from Bug 5204807.
New text selection color and associated handles, bug 5217848.
Change-Id: I4eaea6be732843d8ff344400d029b4a1b80b084f
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 9906847cef4307896a64c68fa27da6603a7d8da2 |
|
29-Aug-2011 |
Gilles Debunne <debunne@google.com> |
Bug 5218421: new NPE is SpellChecker when using Japanese language
The spell checker session is null because the Japanase language is not supported.
Change-Id: I41d2157e8f66799fdb6dff718e8903ce6f1bb9fe
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| d6e3494421dff2a091f1011e5266b280b2109843 |
|
26-Aug-2011 |
Gilles Debunne <debunne@google.com> |
Bug 5218421. Spell check crash with Japanese characters
The word iterator returns no word in that case, and this is not
supported by TextInfo.
Change-Id: Iaf31c58638c02d3cdc7b88bc0d1201e793e84f17
/frameworks/base/core/java/android/widget/SpellChecker.java
|
| 6435a56a8c02de98befcc8cd743b2b638cffb327 |
|
05-Aug-2011 |
Gilles Debunne <debunne@google.com> |
Spell checking in TextViews
New UX interactions (the Paste action is no longer displayed after a delay)
suggestionEnabled flag replaced by existing input type flag.
removeSpans fixed in SpannableStringBuilder to always send notifications
SuggestionSpan handled by TextView instead of SpannableStringBuilder
New span update algorithm to correctly handle edition around word boundaries.
Change-Id: I52c01172f19e595fa512e285a565a3fd97c3c50e
/frameworks/base/core/java/android/widget/SpellChecker.java
|