764d9297c9631f239c8ebafc64edc77db80ce3c2 |
01-Jun-2012 |
Tor Norbye <tnorbye@google.com> |
Fix warnings First, update our various project-specific Eclipse compiler settings configuration files to include the new Eclipse 4 flags. Second, turn off the "Unchecked conversion from non-annotated type to @NonNull" warnings; there are hundreds or thousands of these, and there isn't much we can do about them when they're coming from platform and library APIs. Third, make the lint projects warning-clean again by addressing various warnings Eclipse found (such as some unclosed resources and some null handling issues; yesterday's null annotation fixes only addressed errors, not warnings.) Change-Id: If75f7401a1cbeef1bf58b47ccaa9ad17bede7f91
rg.eclipse.jdt.core.prefs
|
820265da80f6aef2f95d94bbc329e30999ec794f |
23-Dec-2011 |
Tor Norbye <tnorbye@google.com> |
Add @NonNull annotation and configure Eclipse settings This changeset adds a new @NonNull annotation, to match our existing @Nullable annotation, and it adds configuration settings for Eclipse 3.8 / Eclipse 4.2 which configures the new null analysis there to use our own annotations. Note that the annotations only have source retention so there is no extra size or class-loading overhead. (To use findbugs you'll need to temporarily change retention to class-level.) In upcoming CL's I'll use these annotations to clarify the Lint API and other APIs. Change-Id: I99096d8b8a7e25ef002624d592da7700195a5872
rg.eclipse.jdt.core.prefs
|
ab36f4e7488358dea4ab6b54ee2b7bef3da0232b |
21-Dec-2011 |
Tor Norbye <tnorbye@google.com> |
Update SDK codebase to JDK 6 This changeset makes the SDK codebase compile with source=1.6 (which means it also requires JDK 6). This means that methods implementing an interface requires @Override's. It also means we can start using APIs like the ArrayDeque class and methods like String#isEmpty(). This changeset looks big but the change is trivial: it's basically adding @Override in all the places that need it, along with some other automatic Eclipse cleanup in certain files (such as reordering imports where they were incorrectly ordered (because older versions of Eclipse didn't always handle inner classes right)), as well as cleaning up trailing whitespace and removing some $NON-NLS-1$ markers on lines where there aren't any string literals anymore. This changeset also sets the source and target JDK level to 6 in the Eclipse compiler .settings file, and synchronizes this file to all the other Eclipse SDK projects. Change-Id: I6a9585aa44c3dee9a5c00739ab22fbdbcb9f8275
rg.eclipse.jdt.core.prefs
|
42b2f34604a3f8e8ac191831d8f01a0498760d38 |
09-Jun-2011 |
Tor Norbye <tnorbye@google.com> |
Fix various warnings I ran the latest version of findbugs on our codebase and fixed some (not all!) of the warnings. I also ran with Eclipse 3.7 RC3 and updated our compiler warning settings for the new warnings that are available. I also fixed some DOS line endings in some files (formatted with CRLF instead of LF). Change-Id: I9a9d34a9b60f2cb609245793815d96a4587007b0
rg.eclipse.jdt.core.prefs
|
c3478c2a13d1afd5d2d5dae699af55822d391cf8 |
16-Mar-2011 |
Raphael Moll <ralf@android.com> |
Disable the "unecessary else" warning. This can be a matter of personal taste, but I find it a lot more readable to write an if {} else {} sometimes, and it's perfectly valid, so really it shouldn't be marked as a warning. Change-Id: Iac1b9bd5f9602b5018f7432422e0a083f4836490
rg.eclipse.jdt.core.prefs
|
a0b25adffe1b53b360bbeae185c40e1ce55b3842 |
09-Mar-2011 |
Xavier Ducrohet <xav@android.com> |
Add specifc warnings config for most sdk eclipse projects. Change-Id: I9837714c5673d43fa7108b16ab264f1017c4bd3d
rg.eclipse.jdt.core.prefs
|