159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===//
259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//                     The LLVM Compiler Infrastructure
459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source
60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details.
759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===//
959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump//  This file implements extra semantic analysis beyond what is enforced
1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//  by the C type system.
1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===//
1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner
155f8d604246976a93a73549b07bbc8ee0b2061b50John McCall#include "clang/Sema/Initialization.h"
16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Sema.h"
172d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h"
18276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman#include "clang/Sema/Initialization.h"
19831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith#include "clang/Sema/Lookup.h"
20781472fe99a120098c631b0cbe33c89f8cef5e70John McCall#include "clang/Sema/ScopeInfo.h"
21826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek#include "clang/Analysis/Analyses/FormatString.h"
2259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h"
23199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h"
24384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h"
25c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h"
26be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie#include "clang/AST/Expr.h"
272324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h"
287ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h"
29f85e193739c953358c865005855253af4f68a497John McCall#include "clang/AST/EvaluatedExprVisitor.h"
30f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/DeclObjC.h"
31f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h"
32f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h"
3359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h"
34f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h"
358fe83e1df954d72c0f4ffc15d20a5222ec151c21Benjamin Kramer#include "llvm/ADT/SmallString.h"
36f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h"
373bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h"
38691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher#include "clang/Basic/TargetBuiltins.h"
3926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman#include "clang/Basic/TargetInfo.h"
407da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian#include "clang/Basic/ConvertUTF.h"
41a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits>
4259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang;
43781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema;
4459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner
4560800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL,
4660800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner                                                    unsigned ByteNo) const {
4708f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner  return SL->getLocationOfByte(ByteNo, PP.getSourceManager(),
484e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie                               PP.getLangOpts(), PP.getTargetInfo());
4960800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner}
5060800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner
518e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number.
528e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking.  Returns true on error.
538e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) {
548e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  unsigned argCount = call->getNumArgs();
558e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  if (argCount == desiredArgCount) return false;
568e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
578e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  if (argCount < desiredArgCount)
588e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args)
598e10f3b9cc1db43645bbc2999eb163af8997d468John McCall        << 0 /*function call*/ << desiredArgCount << argCount
608e10f3b9cc1db43645bbc2999eb163af8997d468John McCall        << call->getSourceRange();
618e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
628e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  // Highlight all the excess arguments.
638e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  SourceRange range(call->getArg(desiredArgCount)->getLocStart(),
648e10f3b9cc1db43645bbc2999eb163af8997d468John McCall                    call->getArg(argCount - 1)->getLocEnd());
658e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
668e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args)
678e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    << 0 /*function call*/ << desiredArgCount << argCount
688e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    << call->getArg(1)->getSourceRange();
698e10f3b9cc1db43645bbc2999eb163af8997d468John McCall}
708e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
71e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// Check that the first argument to __builtin_annotation is an integer
72e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// and the second argument is a non-wide string literal.
73e59392176c2369df2bdd11b7786cb38abac00198Julien Lerougestatic bool SemaBuiltinAnnotation(Sema &S, CallExpr *TheCall) {
74e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  if (checkArgCount(S, TheCall, 2))
75e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    return true;
76e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge
77e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  // First argument should be an integer.
78e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  Expr *ValArg = TheCall->getArg(0);
79e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  QualType Ty = ValArg->getType();
80e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  if (!Ty->isIntegerType()) {
81e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    S.Diag(ValArg->getLocStart(), diag::err_builtin_annotation_first_arg)
82e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge      << ValArg->getSourceRange();
83e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    return true;
84e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  }
85e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge
86e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  // Second argument should be a constant string.
87e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  Expr *StrArg = TheCall->getArg(1)->IgnoreParenCasts();
88e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  StringLiteral *Literal = dyn_cast<StringLiteral>(StrArg);
8977f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge  if (!Literal || !Literal->isAscii()) {
90e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    S.Diag(StrArg->getLocStart(), diag::err_builtin_annotation_second_arg)
91e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge      << StrArg->getSourceRange();
9277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge    return true;
9377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge  }
94e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge
95e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  TheCall->setType(Ty);
9677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge  return false;
9777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge}
9877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge
9960d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult
100d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
10160d7b3a319d84d688752be3870615ac0f111fb16John McCall  ExprResult TheCallResult(Owned(TheCall));
1022def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor
103946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  // Find out if any arguments are required to be integer constant expressions.
104946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  unsigned ICEArguments = 0;
105946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  ASTContext::GetBuiltinTypeError Error;
106946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  Context.GetBuiltinType(BuiltinID, Error, &ICEArguments);
107946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  if (Error != ASTContext::GE_None)
108946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    ICEArguments = 0;  // Don't diagnose previously diagnosed errors.
109946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner
110946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  // If any arguments are required to be ICE's, check and diagnose.
111946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) {
112946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    // Skip arguments not required to be ICE's.
113946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    if ((ICEArguments & (1 << ArgNo)) == 0) continue;
114946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner
115946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    llvm::APSInt Result;
116946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    if (SemaBuiltinConstantArg(TheCall, ArgNo, Result))
117946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner      return true;
118946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    ICEArguments &= ~(1 << ArgNo);
119946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  }
120946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner
121d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson  switch (BuiltinID) {
12230ce344307f8a8b00054021307015571f83c7364Chris Lattner  case Builtin::BI__builtin___CFStringMakeConstantString:
123925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner    assert(TheCall->getNumArgs() == 1 &&
1241b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner           "Wrong # arguments to builtin CFStringMakeConstantString");
125690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner    if (CheckObjCString(TheCall->getArg(0)))
1260eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
127d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
12849ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek  case Builtin::BI__builtin_stdarg_start:
12930ce344307f8a8b00054021307015571f83c7364Chris Lattner  case Builtin::BI__builtin_va_start:
1300eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    if (SemaBuiltinVAStart(TheCall))
1310eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
132d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
1331b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_isgreater:
1341b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_isgreaterequal:
1351b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_isless:
1361b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_islessequal:
1371b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_islessgreater:
1381b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_isunordered:
1390eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    if (SemaBuiltinUnorderedCompare(TheCall))
1400eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
141d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
142e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer  case Builtin::BI__builtin_fpclassify:
143e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer    if (SemaBuiltinFPClassification(TheCall, 6))
144e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer      return ExprError();
145e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer    break;
1469ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isfinite:
1479ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isinf:
1489ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isinf_sign:
1499ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isnan:
1509ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isnormal:
1513b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer    if (SemaBuiltinFPClassification(TheCall, 1))
1529ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman      return ExprError();
1539ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman    break;
154d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  case Builtin::BI__builtin_shufflevector:
1550eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    return SemaBuiltinShuffleVector(TheCall);
1560eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    // TheCall will be freed by the smart pointer here, but that's fine, since
1570eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    // SemaBuiltinShuffleVector guts it, but then doesn't release it.
1584493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar  case Builtin::BI__builtin_prefetch:
1590eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    if (SemaBuiltinPrefetch(TheCall))
1600eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
161d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
162d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar  case Builtin::BI__builtin_object_size:
1630eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    if (SemaBuiltinObjectSize(TheCall))
1640eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
165d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
166d875fed28578835de89cd407e9db4be788596d7cEli Friedman  case Builtin::BI__builtin_longjmp:
167d875fed28578835de89cd407e9db4be788596d7cEli Friedman    if (SemaBuiltinLongjmp(TheCall))
168d875fed28578835de89cd407e9db4be788596d7cEli Friedman      return ExprError();
169d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
1708e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
1718e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  case Builtin::BI__builtin_classify_type:
1728e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    if (checkArgCount(*this, TheCall, 1)) return true;
1738e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    TheCall->setType(Context.IntTy);
1748e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    break;
17575c29a012793292ff4578015a9113bf086156d7fChris Lattner  case Builtin::BI__builtin_constant_p:
1768e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    if (checkArgCount(*this, TheCall, 1)) return true;
1778e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    TheCall->setType(Context.IntTy);
17875c29a012793292ff4578015a9113bf086156d7fChris Lattner    break;
1795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_add:
180a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_1:
181a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_2:
182a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_4:
183a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_8:
184a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_16:
1855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_sub:
186a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_1:
187a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_2:
188a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_4:
189a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_8:
190a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_16:
1915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_or:
192a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_1:
193a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_2:
194a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_4:
195a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_8:
196a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_16:
1975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_and:
198a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_1:
199a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_2:
200a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_4:
201a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_8:
202a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_16:
2035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_xor:
204a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_1:
205a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_2:
206a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_4:
207a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_8:
208a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_16:
2095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_add_and_fetch:
210a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_1:
211a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_2:
212a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_4:
213a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_8:
214a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_16:
2155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_sub_and_fetch:
216a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_1:
217a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_2:
218a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_4:
219a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_8:
220a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_16:
2215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_and_and_fetch:
222a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_1:
223a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_2:
224a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_4:
225a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_8:
226a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_16:
2275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_or_and_fetch:
228a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_1:
229a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_2:
230a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_4:
231a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_8:
232a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_16:
2335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_xor_and_fetch:
234a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_1:
235a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_2:
236a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_4:
237a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_8:
238a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_16:
2395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_val_compare_and_swap:
240a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_1:
241a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_2:
242a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_4:
243a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_8:
244a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_16:
2455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_bool_compare_and_swap:
246a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_1:
247a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_2:
248a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_4:
249a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_8:
250a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_16:
2515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_lock_test_and_set:
252a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_1:
253a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_2:
254a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_4:
255a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_8:
256a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_16:
2575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_lock_release:
258a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_1:
259a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_2:
260a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_4:
261a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_8:
262a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_16:
26323aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner  case Builtin::BI__sync_swap:
264a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_1:
265a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_2:
266a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_4:
267a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_8:
268a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_16:
2693fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer    return SemaBuiltinAtomicOverloaded(TheCallResult);
270ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define BUILTIN(ID, TYPE, ATTRS)
271ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define ATOMIC_BUILTIN(ID, TYPE, ATTRS) \
272ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Builtin::BI##ID: \
2733fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer    return SemaAtomicOpsOverloaded(TheCallResult, AtomicExpr::AO##ID);
274ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#include "clang/Basic/Builtins.def"
27577f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge  case Builtin::BI__builtin_annotation:
276e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    if (SemaBuiltinAnnotation(*this, TheCall))
27777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge      return ExprError();
27877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge    break;
27926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  }
28026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman
28126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  // Since the target specific builtins for each arch overlap, only check those
28226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  // of the arch we are compiling for.
28326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  if (BuiltinID >= Builtin::FirstTSBuiltin) {
284bcfd1f55bfbb3e5944cd5e03d07b343e280838c4Douglas Gregor    switch (Context.getTargetInfo().getTriple().getArch()) {
28526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman      case llvm::Triple::arm:
28626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman      case llvm::Triple::thumb:
28726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman        if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall))
28826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman          return ExprError();
28926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman        break;
290fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      case llvm::Triple::mips:
291fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      case llvm::Triple::mipsel:
292fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      case llvm::Triple::mips64:
293fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      case llvm::Triple::mips64el:
294fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan        if (CheckMipsBuiltinFunctionCall(BuiltinID, TheCall))
295fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan          return ExprError();
296fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan        break;
29726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman      default:
29826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman        break;
29926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman    }
30026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  }
30126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman
3023fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer  return TheCallResult;
30326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman}
30426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman
30561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code.
30661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) {
307da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  NeonTypeFlags Type(t);
308da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  int IsQuad = Type.isQuad();
309da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  switch (Type.getEltType()) {
310da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Int8:
311da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Poly8:
312da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return shift ? 7 : (8 << IsQuad) - 1;
313da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Int16:
314da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Poly16:
315da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return shift ? 15 : (4 << IsQuad) - 1;
316da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Int32:
317da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return shift ? 31 : (2 << IsQuad) - 1;
318da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Int64:
319da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return shift ? 63 : (1 << IsQuad) - 1;
320da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Float16:
321da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    assert(!shift && "cannot shift float types!");
322da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return (4 << IsQuad) - 1;
323da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Float32:
324da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    assert(!shift && "cannot shift float types!");
325da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return (2 << IsQuad) - 1;
32661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  }
3277530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie  llvm_unreachable("Invalid NeonTypeFlag!");
32861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman}
32961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman
3306f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// getNeonEltType - Return the QualType corresponding to the elements of
3316f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the vector type specified by the NeonTypeFlags.  This is used to check
3326f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the pointer arguments for Neon load/store intrinsics.
3336f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilsonstatic QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context) {
3346f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  switch (Flags.getEltType()) {
3356f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Int8:
3366f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy;
3376f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Int16:
3386f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy;
3396f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Int32:
3406f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy;
3416f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Int64:
3426f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Flags.isUnsigned() ? Context.UnsignedLongLongTy : Context.LongLongTy;
3436f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Poly8:
3446f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Context.SignedCharTy;
3456f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Poly16:
3466f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Context.ShortTy;
3476f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Float16:
3486f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Context.UnsignedShortTy;
3496f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Float32:
3506f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Context.FloatTy;
3516f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  }
3527530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie  llvm_unreachable("Invalid NeonTypeFlag!");
3536f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson}
3546f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson
35526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
3561c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman  llvm::APSInt Result;
3571c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman
358f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith  uint64_t mask = 0;
35961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  unsigned TV = 0;
3604648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson  int PtrArgNum = -1;
3616f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  bool HasConstPtr = false;
3621c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman  switch (BuiltinID) {
363a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK
364a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc"
365a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK
3661c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman  }
3671c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman
3680d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  // For NEON intrinsics which are overloaded on vector element type, validate
3690d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  // the immediate which specifies which variant to emit.
3706f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  unsigned ImmArg = TheCall->getNumArgs()-1;
3710d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  if (mask) {
3726f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    if (SemaBuiltinConstantArg(TheCall, ImmArg, Result))
3730d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman      return true;
3740d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman
375da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    TV = Result.getLimitedValue(64);
376f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith    if ((TV > 63) || (mask & (1ULL << TV)) == 0)
3770d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman      return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code)
3786f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson        << TheCall->getArg(ImmArg)->getSourceRange();
3796f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  }
3806f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson
3814648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson  if (PtrArgNum >= 0) {
3826f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    // Check that pointer arguments have the specified type.
3834648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    Expr *Arg = TheCall->getArg(PtrArgNum);
3844648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg))
3854648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson      Arg = ICE->getSubExpr();
3864648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg);
3874648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    QualType RHSTy = RHS.get()->getType();
3884648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context);
3894648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    if (HasConstPtr)
3904648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson      EltTy = EltTy.withConst();
3914648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    QualType LHSTy = Context.getPointerType(EltTy);
3924648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    AssignConvertType ConvTy;
3934648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS);
3944648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    if (RHS.isInvalid())
3954648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson      return true;
3964648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy,
3974648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson                                 RHS.get(), AA_Assigning))
3984648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson      return true;
3990d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  }
4001c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman
4010d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  // For NEON intrinsics which take an immediate value as part of the
4020d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  // instruction, range check them here.
40361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  unsigned i = 0, l = 0, u = 0;
4040d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  switch (BuiltinID) {
4050d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  default: return false;
406bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman  case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break;
407bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman  case ARM::BI__builtin_arm_usat: i = 1; u = 31; break;
40899c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman  case ARM::BI__builtin_arm_vcvtr_f:
40999c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman  case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break;
410a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK
411a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc"
412a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK
4130d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  };
4140d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman
415592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor  // We can't check the value of a dependent argument.
416592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor  if (TheCall->getArg(i)->isTypeDependent() ||
417592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor      TheCall->getArg(i)->isValueDependent())
418592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor    return false;
419592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
42061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  // Check that the immediate argument is actually a constant.
4210d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  if (SemaBuiltinConstantArg(TheCall, i, Result))
4220d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman    return true;
4230d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman
42461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  // Range check against the upper/lower values for this isntruction.
4250d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  unsigned Val = Result.getZExtValue();
42661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  if (Val < l || Val > (u + l))
4270d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman    return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
428476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer      << l << u+l << TheCall->getArg(i)->getSourceRange();
4290d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman
43099c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman  // FIXME: VFP Intrinsics should error if VFP not present.
43126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  return false;
432d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson}
433d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson
434fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyanbool Sema::CheckMipsBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
435fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  unsigned i = 0, l = 0, u = 0;
436fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  switch (BuiltinID) {
437fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  default: return false;
438fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  case Mips::BI__builtin_mips_wrdsp: i = 1; l = 0; u = 63; break;
439fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  case Mips::BI__builtin_mips_rddsp: i = 0; l = 0; u = 63; break;
440be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan  case Mips::BI__builtin_mips_append: i = 2; l = 0; u = 31; break;
441be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan  case Mips::BI__builtin_mips_balign: i = 2; l = 0; u = 3; break;
442be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan  case Mips::BI__builtin_mips_precr_sra_ph_w: i = 2; l = 0; u = 31; break;
443be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan  case Mips::BI__builtin_mips_precr_sra_r_ph_w: i = 2; l = 0; u = 31; break;
444be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan  case Mips::BI__builtin_mips_prepend: i = 2; l = 0; u = 31; break;
445fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  };
446fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
447fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  // We can't check the value of a dependent argument.
448fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  if (TheCall->getArg(i)->isTypeDependent() ||
449fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      TheCall->getArg(i)->isValueDependent())
450fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan    return false;
451fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
452fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  // Check that the immediate argument is actually a constant.
453fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  llvm::APSInt Result;
454fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  if (SemaBuiltinConstantArg(TheCall, i, Result))
455fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan    return true;
456fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
457fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  // Range check against the upper/lower values for this instruction.
458fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  unsigned Val = Result.getZExtValue();
459fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  if (Val < l || Val > u)
460fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan    return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
461fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      << l << u << TheCall->getArg(i)->getSourceRange();
462fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
463fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  return false;
464fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan}
465fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
466831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Given a FunctionDecl's FormatAttr, attempts to populate the FomatStringInfo
467831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// parameter with the FormatAttr's correct format_idx and firstDataArg.
468831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true when the format fits the function and the FormatStringInfo has
469831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// been populated.
470831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::getFormatStringInfo(const FormatAttr *Format, bool IsCXXMember,
471831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                               FormatStringInfo *FSI) {
472831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  FSI->HasVAListArg = Format->getFirstArg() == 0;
473831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  FSI->FormatIdx = Format->getFormatIdx() - 1;
474831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  FSI->FirstDataArg = FSI->HasVAListArg ? 0 : Format->getFirstArg() - 1;
475de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar
476831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // The way the format attribute works in GCC, the implicit this argument
477831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // of member functions is counted. However, it doesn't appear in our own
478831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // lists, so decrement format_idx in that case.
479831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (IsCXXMember) {
480831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    if(FSI->FormatIdx == 0)
481831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      return false;
482831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    --FSI->FormatIdx;
483831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    if (FSI->FirstDataArg != 0)
484831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      --FSI->FirstDataArg;
485831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  }
486831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return true;
487831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
4881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
489831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Handles the checks for format strings, non-POD arguments to vararg
490831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// functions, and NULL arguments passed to non-NULL parameters.
491831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithvoid Sema::checkCall(NamedDecl *FDecl, Expr **Args,
492831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     unsigned NumArgs,
493831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     unsigned NumProtoArgs,
494831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     bool IsMemberFunction,
495831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     SourceLocation Loc,
496831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     SourceRange Range,
497831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     VariadicCallType CallType) {
498de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar  // FIXME: This mechanism should be abstracted to be less fragile and
499de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar  // more efficient. For example, just map function ids to custom
500de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar  // handlers.
501de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar
502c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek  // Printf and scanf checking.
503831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  bool HandledFormatString = false;
504c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek  for (specific_attr_iterator<FormatAttr>
505831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith         I = FDecl->specific_attr_begin<FormatAttr>(),
506831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith         E = FDecl->specific_attr_end<FormatAttr>(); I != E ; ++I)
507ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose    if (CheckFormatArguments(*I, Args, NumArgs, IsMemberFunction, CallType,
508ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                             Loc, Range))
509831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        HandledFormatString = true;
510831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
511831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // Refuse POD arguments that weren't caught by the format string
512831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // checks above.
513831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (!HandledFormatString && CallType != VariadicDoesNotApply)
514831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    for (unsigned ArgIdx = NumProtoArgs; ArgIdx < NumArgs; ++ArgIdx)
515831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      variadicArgumentPODCheck(Args[ArgIdx], CallType);
5161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
517c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek  for (specific_attr_iterator<NonNullAttr>
518831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith         I = FDecl->specific_attr_begin<NonNullAttr>(),
519831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith         E = FDecl->specific_attr_end<NonNullAttr>(); I != E; ++I)
520831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    CheckNonNullArguments(*I, Args, Loc);
5210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
5220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // Type safety checking.
5230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  for (specific_attr_iterator<ArgumentWithTypeTagAttr>
5240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         i = FDecl->specific_attr_begin<ArgumentWithTypeTagAttr>(),
5250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         e = FDecl->specific_attr_end<ArgumentWithTypeTagAttr>(); i != e; ++i) {
5260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    CheckArgumentWithTypeTag(*i, Args);
5270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
528831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
529831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
530831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckConstructorCall - Check a constructor call for correctness and safety
531831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// properties not enforced by the C type system.
532831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithvoid Sema::CheckConstructorCall(FunctionDecl *FDecl, Expr **Args,
533831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                unsigned NumArgs,
534831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                const FunctionProtoType *Proto,
535831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                SourceLocation Loc) {
536831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  VariadicCallType CallType =
537831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    Proto->isVariadic() ? VariadicConstructor : VariadicDoesNotApply;
538831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  checkCall(FDecl, Args, NumArgs, Proto->getNumArgs(),
539831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            /*IsMemberFunction=*/true, Loc, SourceRange(), CallType);
540831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
541831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
542831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckFunctionCall - Check a direct function call for various correctness
543831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// and safety properties not strictly enforced by the C type system.
544831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall,
545831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                             const FunctionProtoType *Proto) {
546831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  bool IsMemberFunction = isa<CXXMemberCallExpr>(TheCall);
547831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  VariadicCallType CallType = getVariadicCallType(FDecl, Proto,
548831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                                  TheCall->getCallee());
549831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0;
550831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  checkCall(FDecl, TheCall->getArgs(), TheCall->getNumArgs(), NumProtoArgs,
551831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            IsMemberFunction, TheCall->getRParenLoc(),
552831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            TheCall->getCallee()->getSourceRange(), CallType);
553831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
554831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  IdentifierInfo *FnInfo = FDecl->getIdentifier();
555831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // None of the checks below are needed for functions that don't have
556831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // simple names (e.g., C++ conversion functions).
557831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (!FnInfo)
558831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return false;
5590eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl
5600a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  unsigned CMId = FDecl->getMemoryFunctionKind();
5610a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  if (CMId == 0)
562d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks    return false;
563bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
564d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks  // Handle memory setting and copying functions.
5650a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat)
566bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    CheckStrlcpycatArguments(TheCall, FnInfo);
567c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  else if (CMId == Builtin::BIstrncat)
568c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    CheckStrncatArguments(TheCall, FnInfo);
569d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks  else
5700a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks    CheckMemaccessArguments(TheCall, CMId, FnInfo);
5717ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth
572d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson  return false;
57371993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson}
57471993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson
57529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupasbool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac,
57629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                               Expr **Args, unsigned NumArgs) {
577831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  VariadicCallType CallType =
578831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      Method->isVariadic() ? VariadicMethod : VariadicDoesNotApply;
57929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas
580831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  checkCall(Method, Args, NumArgs, Method->param_size(),
581831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            /*IsMemberFunction=*/false,
582831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            lbrac, Method->getSourceRange(), CallType);
58329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas
58429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  return false;
58529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas}
58629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas
587831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall,
588831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                          const FunctionProtoType *Proto) {
589725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian  const VarDecl *V = dyn_cast<VarDecl>(NDecl);
590725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian  if (!V)
591d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    return false;
5921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
593725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian  QualType Ty = V->getType();
594725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian  if (!Ty->isBlockPointerType())
595d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    return false;
5961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
597831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  VariadicCallType CallType =
598831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      Proto && Proto->isVariadic() ? VariadicBlock : VariadicDoesNotApply ;
599831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0;
600d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson
601831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  checkCall(NDecl, TheCall->getArgs(), TheCall->getNumArgs(),
602831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            NumProtoArgs, /*IsMemberFunction=*/false,
603831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            TheCall->getRParenLoc(),
604831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            TheCall->getCallee()->getSourceRange(), CallType);
605831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
606d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson  return false;
607725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian}
608725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian
609ff34d401ff385ef7173ca612432b4ea717fff690Richard SmithExprResult Sema::SemaAtomicOpsOverloaded(ExprResult TheCallResult,
610ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith                                         AtomicExpr::AtomicOp Op) {
611276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  CallExpr *TheCall = cast<CallExpr>(TheCallResult.get());
612276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
613276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
614ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // All these operations take one of the following forms:
615ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  enum {
616ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // C    __c11_atomic_init(A *, C)
617ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Init,
618ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // C    __c11_atomic_load(A *, int)
619ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Load,
620ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // void __atomic_load(A *, CP, int)
621ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Copy,
622ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // C    __c11_atomic_add(A *, M, int)
623ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Arithmetic,
624ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // C    __atomic_exchange_n(A *, CP, int)
625ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Xchg,
626ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // void __atomic_exchange(A *, C *, CP, int)
627ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    GNUXchg,
628ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // bool __c11_atomic_compare_exchange_strong(A *, C *, CP, int, int)
629ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    C11CmpXchg,
630ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // bool __atomic_compare_exchange(A *, C *, CP, bool, int, int)
631ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    GNUCmpXchg
632ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  } Form = Init;
633ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  const unsigned NumArgs[] = { 2, 2, 3, 3, 3, 4, 5, 6 };
634ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  const unsigned NumVals[] = { 1, 0, 1, 1, 1, 2, 2, 3 };
635ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // where:
636ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   C is an appropriate type,
637ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   A is volatile _Atomic(C) for __c11 builtins and is C for GNU builtins,
638ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   CP is C for __c11 builtins and GNU _n builtins and is C * otherwise,
639ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   M is C if C is an integer, and ptrdiff_t if C is a pointer, and
640ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   the int parameters are for orderings.
641ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
642ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  assert(AtomicExpr::AO__c11_atomic_init == 0 &&
643ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith         AtomicExpr::AO__c11_atomic_fetch_xor + 1 == AtomicExpr::AO__atomic_load
644ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith         && "need to update code for modified C11 atomics");
645ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  bool IsC11 = Op >= AtomicExpr::AO__c11_atomic_init &&
646ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith               Op <= AtomicExpr::AO__c11_atomic_fetch_xor;
647ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  bool IsN = Op == AtomicExpr::AO__atomic_load_n ||
648ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith             Op == AtomicExpr::AO__atomic_store_n ||
649ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith             Op == AtomicExpr::AO__atomic_exchange_n ||
650ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith             Op == AtomicExpr::AO__atomic_compare_exchange_n;
651ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  bool IsAddSub = false;
652ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
653ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  switch (Op) {
654ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_init:
655ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Init;
656ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
657ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
658ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_load:
659ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_load_n:
660ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Load;
661ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
662ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
663ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_store:
664ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_load:
665ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_store:
666ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_store_n:
667ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Copy;
668ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
669ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
670ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_add:
671ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_sub:
672ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_add:
673ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_sub:
674ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_add_fetch:
675ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_sub_fetch:
676ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    IsAddSub = true;
677ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // Fall through.
678ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_and:
679ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_or:
680ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_xor:
681ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_and:
682ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_or:
683ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_xor:
68451b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith  case AtomicExpr::AO__atomic_fetch_nand:
685ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_and_fetch:
686ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_or_fetch:
687ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_xor_fetch:
68851b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith  case AtomicExpr::AO__atomic_nand_fetch:
689ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Arithmetic;
690ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
691ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
692ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_exchange:
693ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_exchange_n:
694ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Xchg;
695ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
696ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
697ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_exchange:
698ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = GNUXchg;
699ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
700ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
701ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_compare_exchange_strong:
702ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_compare_exchange_weak:
703ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = C11CmpXchg;
704ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
705ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
706ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_compare_exchange:
707ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_compare_exchange_n:
708ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = GNUCmpXchg;
709ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
710276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
711276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
712ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // Check we have the right number of arguments.
713ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (TheCall->getNumArgs() < NumArgs[Form]) {
714276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
715ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      << 0 << NumArgs[Form] << TheCall->getNumArgs()
716276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << TheCall->getCallee()->getSourceRange();
717276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
718ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  } else if (TheCall->getNumArgs() > NumArgs[Form]) {
719ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Diag(TheCall->getArg(NumArgs[Form])->getLocStart(),
720276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman         diag::err_typecheck_call_too_many_args)
721ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      << 0 << NumArgs[Form] << TheCall->getNumArgs()
722276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << TheCall->getCallee()->getSourceRange();
723276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
724276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
725276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
726ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // Inspect the first argument of the atomic operation.
727dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman  Expr *Ptr = TheCall->getArg(0);
728276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get();
729276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  const PointerType *pointerType = Ptr->getType()->getAs<PointerType>();
730276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  if (!pointerType) {
731ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
732276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << Ptr->getType() << Ptr->getSourceRange();
733276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
734276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
735276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
736ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // For a __c11 builtin, this should be a pointer to an _Atomic type.
737ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  QualType AtomTy = pointerType->getPointeeType(); // 'A'
738ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  QualType ValType = AtomTy; // 'C'
739ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (IsC11) {
740ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    if (!AtomTy->isAtomicType()) {
741ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic)
742ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        << Ptr->getType() << Ptr->getSourceRange();
743ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      return ExprError();
744ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    }
745ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    ValType = AtomTy->getAs<AtomicType>()->getValueType();
746276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
747276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
748ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // For an arithmetic operation, the implied arithmetic must be well-formed.
749ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (Form == Arithmetic) {
750ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // gcc does not enforce these rules for GNU atomics, but we do so for sanity.
751ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    if (IsAddSub && !ValType->isIntegerType() && !ValType->isPointerType()) {
752ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr)
753ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        << IsC11 << Ptr->getType() << Ptr->getSourceRange();
754ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      return ExprError();
755ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    }
756ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    if (!IsAddSub && !ValType->isIntegerType()) {
757ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      Diag(DRE->getLocStart(), diag::err_atomic_op_bitwise_needs_atomic_int)
758ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        << IsC11 << Ptr->getType() << Ptr->getSourceRange();
759ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      return ExprError();
760ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    }
761ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  } else if (IsN && !ValType->isIntegerType() && !ValType->isPointerType()) {
762ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // For __atomic_*_n operations, the value type must be a scalar integral or
763ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // pointer type which is 1, 2, 4, 8 or 16 bytes in length.
764276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr)
765ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      << IsC11 << Ptr->getType() << Ptr->getSourceRange();
766276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
767276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
768276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
769ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (!IsC11 && !AtomTy.isTriviallyCopyableType(Context)) {
770ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // For GNU atomics, require a trivially-copyable type. This is not part of
771ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // the GNU atomics specification, but we enforce it for sanity.
772ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Diag(DRE->getLocStart(), diag::err_atomic_op_needs_trivial_copy)
773276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << Ptr->getType() << Ptr->getSourceRange();
774276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
775276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
776276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
777ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // FIXME: For any builtin other than a load, the ValType must not be
778ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // const-qualified.
779ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
780276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  switch (ValType.getObjCLifetime()) {
781276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_None:
782276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_ExplicitNone:
783276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    // okay
784276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    break;
785276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
786276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_Weak:
787276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_Strong:
788276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_Autoreleasing:
789ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // FIXME: Can this happen? By this point, ValType should be known
790ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // to be trivially copyable.
791276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
792276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << ValType << Ptr->getSourceRange();
793276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
794276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
795276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
796276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  QualType ResultType = ValType;
797ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (Form == Copy || Form == GNUXchg || Form == Init)
798276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    ResultType = Context.VoidTy;
799ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  else if (Form == C11CmpXchg || Form == GNUCmpXchg)
800276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    ResultType = Context.BoolTy;
801276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
802ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // The type of a parameter passed 'by value'. In the GNU atomics, such
803ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // arguments are actually passed as pointers.
804ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  QualType ByValType = ValType; // 'CP'
805ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (!IsC11 && !IsN)
806ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    ByValType = Ptr->getType();
807ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
808276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  // The first argument --- the pointer --- has a fixed type; we
809276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  // deduce the types of the rest of the arguments accordingly.  Walk
810276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  // the remaining arguments, converting them to the deduced value type.
811ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  for (unsigned i = 1; i != NumArgs[Form]; ++i) {
812276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    QualType Ty;
813ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    if (i < NumVals[Form] + 1) {
814ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      switch (i) {
815ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      case 1:
816ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // The second argument is the non-atomic operand. For arithmetic, this
817ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // is always passed by value, and for a compare_exchange it is always
818ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // passed by address. For the rest, GNU uses by-address and C11 uses
819ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // by-value.
820ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        assert(Form != Load);
821ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        if (Form == Init || (Form == Arithmetic && ValType->isIntegerType()))
822ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith          Ty = ValType;
823ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        else if (Form == Copy || Form == Xchg)
824ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith          Ty = ByValType;
825ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        else if (Form == Arithmetic)
826ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith          Ty = Context.getPointerDiffType();
827ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        else
828ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith          Ty = Context.getPointerType(ValType.getUnqualifiedType());
829ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        break;
830ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      case 2:
831ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // The third argument to compare_exchange / GNU exchange is a
832ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // (pointer to a) desired value.
833ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        Ty = ByValType;
834ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        break;
835ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      case 3:
836ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // The fourth argument to GNU compare_exchange is a 'weak' flag.
837ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        Ty = Context.BoolTy;
838ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        break;
839ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      }
840276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    } else {
841276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      // The order(s) are always converted to int.
842276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      Ty = Context.IntTy;
843276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    }
844ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
845276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    InitializedEntity Entity =
846276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman        InitializedEntity::InitializeParameter(Context, Ty, false);
847ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    ExprResult Arg = TheCall->getArg(i);
848276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
849276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    if (Arg.isInvalid())
850276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      return true;
851276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    TheCall->setArg(i, Arg.get());
852276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
853276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
854ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // Permute the arguments into a 'consistent' order.
855dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman  SmallVector<Expr*, 5> SubExprs;
856dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman  SubExprs.push_back(Ptr);
857ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  switch (Form) {
858ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Init:
859ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // Note, AtomicExpr::getVal1() has a special case for this atomic.
8607a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall    SubExprs.push_back(TheCall->getArg(1)); // Val1
861ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
862ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Load:
863ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(1)); // Order
864ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
865ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Copy:
866ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Arithmetic:
867ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Xchg:
868dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(2)); // Order
869dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(1)); // Val1
870ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
871ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case GNUXchg:
872ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // Note, AtomicExpr::getVal2() has a special case for this atomic.
873ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(3)); // Order
874ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(1)); // Val1
875ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(2)); // Val2
876ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
877ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case C11CmpXchg:
878dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(3)); // Order
879dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(1)); // Val1
880dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(4)); // OrderFail
8812ebb98a78471f2039af4321bae657e7daacc2a62David Chisnall    SubExprs.push_back(TheCall->getArg(2)); // Val2
882ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
883ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case GNUCmpXchg:
884ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(4)); // Order
885ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(1)); // Val1
886ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(5)); // OrderFail
887ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(2)); // Val2
888ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(3)); // Weak
889ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
890276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
891dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman
892dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman  return Owned(new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(),
8933b6bef9a213249c6ab6d67c07b1ac6380961be3eBenjamin Kramer                                        SubExprs, ResultType, Op,
894dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman                                        TheCall->getRParenLoc()));
895276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman}
896276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
897276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
8985f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// checkBuiltinArgument - Given a call to a builtin function, perform
8995f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// normal type-checking on the given argument, updating the call in
9005f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// place.  This is useful when a builtin function requires custom
9015f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// type-checking for some of its arguments but not necessarily all of
9025f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// them.
9035f8d604246976a93a73549b07bbc8ee0b2061b50John McCall///
9045f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// Returns true on error.
9055f8d604246976a93a73549b07bbc8ee0b2061b50John McCallstatic bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) {
9065f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  FunctionDecl *Fn = E->getDirectCallee();
9075f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  assert(Fn && "builtin call without direct callee!");
9085f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
9095f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  ParmVarDecl *Param = Fn->getParamDecl(ArgIndex);
9105f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  InitializedEntity Entity =
9115f8d604246976a93a73549b07bbc8ee0b2061b50John McCall    InitializedEntity::InitializeParameter(S.Context, Param);
9125f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
9135f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  ExprResult Arg = E->getArg(0);
9145f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
9155f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  if (Arg.isInvalid())
9165f8d604246976a93a73549b07bbc8ee0b2061b50John McCall    return true;
9175f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
9185f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  E->setArg(ArgIndex, Arg.take());
9195f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  return false;
9205f8d604246976a93a73549b07bbc8ee0b2061b50John McCall}
9215f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
9225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like
9235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer
9245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument.  The main ActOnCallExpr routines have already
9255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as
9265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...).
9275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner///
9285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these
9295caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins,
93060d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult
93160d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) {
932d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  CallExpr *TheCall = (CallExpr *)TheCallResult.get();
9335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
9345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
9355caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner
9365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Ensure that we have at least one argument to do type inference from.
937d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  if (TheCall->getNumArgs() < 1) {
938d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
939d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << 0 << 1 << TheCall->getNumArgs()
940d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << TheCall->getCallee()->getSourceRange();
941d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
942d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  }
9431eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
9445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Inspect the first argument of the atomic builtin.  This should always be
9455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // a pointer type, whose element is an integral scalar or pointer type.
9465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Because it is a pointer type, we don't have to worry about any implicit
9475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // casts here.
948d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  // FIXME: We don't allow floating point scalars as input.
9495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  Expr *FirstArg = TheCall->getArg(0);
9508c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman  ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg);
9518c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman  if (FirstArgResult.isInvalid())
9528c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman    return ExprError();
9538c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman  FirstArg = FirstArgResult.take();
9548c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman  TheCall->setArg(0, FirstArg);
9558c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman
956f85e193739c953358c865005855253af4f68a497John McCall  const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>();
957f85e193739c953358c865005855253af4f68a497John McCall  if (!pointerType) {
958d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
959d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << FirstArg->getType() << FirstArg->getSourceRange();
960d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
961d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  }
9621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
963f85e193739c953358c865005855253af4f68a497John McCall  QualType ValType = pointerType->getPointeeType();
964dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner  if (!ValType->isIntegerType() && !ValType->isAnyPointerType() &&
965d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      !ValType->isBlockPointerType()) {
966d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr)
967d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << FirstArg->getType() << FirstArg->getSourceRange();
968d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
969d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  }
9705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner
971f85e193739c953358c865005855253af4f68a497John McCall  switch (ValType.getObjCLifetime()) {
972f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_None:
973f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_ExplicitNone:
974f85e193739c953358c865005855253af4f68a497John McCall    // okay
975f85e193739c953358c865005855253af4f68a497John McCall    break;
976f85e193739c953358c865005855253af4f68a497John McCall
977f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_Weak:
978f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_Strong:
979f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_Autoreleasing:
980b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis    Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
981f85e193739c953358c865005855253af4f68a497John McCall      << ValType << FirstArg->getSourceRange();
982f85e193739c953358c865005855253af4f68a497John McCall    return ExprError();
983f85e193739c953358c865005855253af4f68a497John McCall  }
984f85e193739c953358c865005855253af4f68a497John McCall
985b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall  // Strip any qualifiers off ValType.
986b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall  ValType = ValType.getUnqualifiedType();
987b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall
9888d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth  // The majority of builtins return a value, but a few have special return
9898d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth  // types, so allow them to override appropriately below.
9908d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth  QualType ResultType = ValType;
9918d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth
9925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // We need to figure out which concrete builtin this maps onto.  For example,
9935caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // __sync_fetch_and_add with a 2 byte object turns into
9945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // __sync_fetch_and_add_2.
9955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \
9965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \
9975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    Builtin::BI##x##_8, Builtin::BI##x##_16 }
9981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
9995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  static const unsigned BuiltinIndices[][5] = {
10005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_add),
10015caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_sub),
10025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_or),
10035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_and),
10045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_xor),
10051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
10065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_add_and_fetch),
10075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_sub_and_fetch),
10085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_and_and_fetch),
10095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_or_and_fetch),
10105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_xor_and_fetch),
10111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
10125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_val_compare_and_swap),
10135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_bool_compare_and_swap),
10145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_lock_test_and_set),
101523aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner    BUILTIN_ROW(__sync_lock_release),
101623aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner    BUILTIN_ROW(__sync_swap)
10175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  };
10181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW
10191eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
10205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Determine the index of the size.
10215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  unsigned SizeIndex;
1022199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck  switch (Context.getTypeSizeInChars(ValType).getQuantity()) {
10235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 1: SizeIndex = 0; break;
10245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 2: SizeIndex = 1; break;
10255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 4: SizeIndex = 2; break;
10265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 8: SizeIndex = 3; break;
10275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 16: SizeIndex = 4; break;
10285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  default:
1029d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size)
1030d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << FirstArg->getType() << FirstArg->getSourceRange();
1031d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
10325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  }
10331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
10345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Each of these builtins has one pointer argument, followed by some number of
10355caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // values (0, 1 or 2) followed by a potentially empty varags list of stuff
10365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // that we ignore.  Find out which row of BuiltinIndices to read from as well
10375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // as the number of fixed args.
10387814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor  unsigned BuiltinID = FDecl->getBuiltinID();
10395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  unsigned BuiltinIndex, NumFixed = 1;
10405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  switch (BuiltinID) {
1041b219cfc4d75f0a03630b7c4509ef791b7e97b2c8David Blaikie  default: llvm_unreachable("Unknown overloaded atomic builtin!");
1042a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add:
1043a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_1:
1044a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_2:
1045a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_4:
1046a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_8:
1047a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_16:
1048a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 0;
1049a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1050a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1051a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub:
1052a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_1:
1053a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_2:
1054a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_4:
1055a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_8:
1056a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_16:
1057a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 1;
1058a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1059a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1060a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or:
1061a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_1:
1062a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_2:
1063a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_4:
1064a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_8:
1065a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_16:
1066a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 2;
1067a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1068a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1069a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and:
1070a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_1:
1071a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_2:
1072a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_4:
1073a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_8:
1074a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_16:
1075a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 3;
1076a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1077a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1078a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor:
1079a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_1:
1080a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_2:
1081a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_4:
1082a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_8:
1083a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_16:
1084a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 4;
1085a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1086a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1087a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch:
1088a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_1:
1089a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_2:
1090a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_4:
1091a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_8:
1092a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_16:
1093a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 5;
1094a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1095a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1096a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch:
1097a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_1:
1098a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_2:
1099a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_4:
1100a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_8:
1101a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_16:
1102a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 6;
1103a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1104a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1105a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch:
1106a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_1:
1107a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_2:
1108a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_4:
1109a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_8:
1110a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_16:
1111a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 7;
1112a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1113a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1114a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch:
1115a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_1:
1116a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_2:
1117a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_4:
1118a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_8:
1119a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_16:
1120a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 8;
1121a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1122a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1123a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch:
1124a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_1:
1125a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_2:
1126a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_4:
1127a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_8:
1128a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_16:
1129a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 9;
1130a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
11311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
11325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_val_compare_and_swap:
1133a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_1:
1134a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_2:
1135a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_4:
1136a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_8:
1137a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_16:
11387eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar    BuiltinIndex = 10;
11395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    NumFixed = 2;
11405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    break;
1141a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
11425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_bool_compare_and_swap:
1143a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_1:
1144a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_2:
1145a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_4:
1146a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_8:
1147a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_16:
11487eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar    BuiltinIndex = 11;
11495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    NumFixed = 2;
11508d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth    ResultType = Context.BoolTy;
11515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    break;
1152a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1153a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set:
1154a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_1:
1155a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_2:
1156a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_4:
1157a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_8:
1158a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_16:
1159a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 12;
1160a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1161a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
11625caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_lock_release:
1163a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_1:
1164a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_2:
1165a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_4:
1166a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_8:
1167a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_16:
11687eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar    BuiltinIndex = 13;
11695caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    NumFixed = 0;
11708d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth    ResultType = Context.VoidTy;
11715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    break;
1172a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1173a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap:
1174a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_1:
1175a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_2:
1176a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_4:
1177a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_8:
1178a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_16:
1179a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 14;
1180a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
11815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  }
11821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
11835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Now that we know how many fixed arguments we expect, first check that we
11845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // have at least that many.
1185d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  if (TheCall->getNumArgs() < 1+NumFixed) {
1186d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
1187d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << 0 << 1+NumFixed << TheCall->getNumArgs()
1188d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << TheCall->getCallee()->getSourceRange();
1189d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
1190d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  }
11911eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1192e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner  // Get the decl for the concrete builtin from this, we can tell what the
1193e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner  // concrete integer type we should convert to is.
1194e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner  unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex];
1195e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner  const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID);
1196e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner  IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName);
11971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  FunctionDecl *NewBuiltinDecl =
1198e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner    cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID,
1199e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner                                           TUScope, false, DRE->getLocStart()));
1200d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth
1201f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall  // The first argument --- the pointer --- has a fixed type; we
1202f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall  // deduce the types of the rest of the arguments accordingly.  Walk
1203f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall  // the remaining arguments, converting them to the deduced value type.
12045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  for (unsigned i = 0; i != NumFixed; ++i) {
1205429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley    ExprResult Arg = TheCall->getArg(i+1);
12061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
12075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // GCC does an implicit conversion to the pointer or integer ValType.  This
12085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // can fail in some cases (1i -> int**), check for this error case now.
1209b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall    // Initialize the argument.
1210b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall    InitializedEntity Entity = InitializedEntity::InitializeParameter(Context,
1211b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall                                                   ValType, /*consume*/ false);
1212b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall    Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
1213429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley    if (Arg.isInvalid())
1214d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      return ExprError();
12151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
12165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // Okay, we have something that *can* be converted to the right type.  Check
12175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // to see if there is a potentially weird extension going on here.  This can
12185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // happen when you do an atomic operation on something like an char* and
12195caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // pass in 42.  The 42 gets converted to char.  This is even more strange
12205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // for things like 45.123 -> char, etc.
12211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump    // FIXME: Do this check.
1222b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall    TheCall->setArg(i+1, Arg.take());
12235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  }
12241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1225bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor  ASTContext& Context = this->getASTContext();
1226bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor
1227bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor  // Create a new DeclRefExpr to refer to the new decl.
1228bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor  DeclRefExpr* NewDRE = DeclRefExpr::Create(
1229bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      Context,
1230bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      DRE->getQualifierLoc(),
1231e4b92761b43ced611c417ae478568610f1ad7b1eAbramo Bagnara      SourceLocation(),
1232bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      NewBuiltinDecl,
1233f4b88a45902af1802a1cb42ba48b1c474474f228John McCall      /*enclosing*/ false,
1234bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      DRE->getLocation(),
1235a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman      Context.BuiltinFnTy,
1236bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      DRE->getValueKind());
12371eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
12385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Set the callee in the CallExpr.
1239a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman  // FIXME: This loses syntactic information.
1240a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman  QualType CalleePtrTy = Context.getPointerType(NewBuiltinDecl->getType());
1241a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman  ExprResult PromotedCall = ImpCastExprToType(NewDRE, CalleePtrTy,
1242a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman                                              CK_BuiltinFnToFnPtr);
1243429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  TheCall->setCallee(PromotedCall.take());
12441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1245db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth  // Change the result type of the call to match the original value type. This
1246db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth  // is arbitrary, but the codegen for these builtins ins design to handle it
1247db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth  // gracefully.
12488d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth  TheCall->setType(ResultType);
1249d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth
12503fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer  return TheCallResult;
12515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner}
12525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner
1253690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin
125471993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct
1255fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would
1256fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend).
1257690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) {
125856f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner  Arg = Arg->IgnoreParenCasts();
125971993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson  StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
126071993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson
12615cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor  if (!Literal || !Literal->isAscii()) {
1262fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner    Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant)
1263fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner      << Arg->getSourceRange();
12649cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson    return true;
126571993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson  }
12661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
12677da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian  if (Literal->containsNonAsciiOrNull()) {
12685f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner    StringRef String = Literal->getString();
12697da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    unsigned NumBytes = String.size();
12705f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner    SmallVector<UTF16, 128> ToBuf(NumBytes);
127131ba6135375433b617a8587ea6cc836a014ebd86Roman Divacky    const UTF8 *FromPtr = (const UTF8 *)String.data();
12727da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    UTF16 *ToPtr = &ToBuf[0];
12737da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian
12747da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes,
12757da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian                                                 &ToPtr, ToPtr + NumBytes,
12767da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian                                                 strictConversion);
12777da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    // Check for conversion failure.
12787da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    if (Result != conversionOK)
12797da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian      Diag(Arg->getLocStart(),
12807da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian           diag::warn_cfstring_truncated) << Arg->getSourceRange();
12817da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian  }
12829cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson  return false;
128359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner}
128459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner
1285c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity.
1286c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success.
1287925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) {
1288925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  Expr *Fn = TheCall->getCallee();
1289925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  if (TheCall->getNumArgs() > 2) {
12902c21a073525cdfa68e4439b7af551385dc2796abChris Lattner    Diag(TheCall->getArg(2)->getLocStart(),
1291fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner         diag::err_typecheck_call_too_many_args)
1292ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher      << 0 /*function call*/ << 2 << TheCall->getNumArgs()
1293ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher      << Fn->getSourceRange()
12941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump      << SourceRange(TheCall->getArg(2)->getLocStart(),
1295fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                     (*(TheCall->arg_end()-1))->getLocEnd());
129630ce344307f8a8b00054021307015571f83c7364Chris Lattner    return true;
129730ce344307f8a8b00054021307015571f83c7364Chris Lattner  }
129856f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman
129956f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman  if (TheCall->getNumArgs() < 2) {
1300d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher    return Diag(TheCall->getLocEnd(),
1301d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      diag::err_typecheck_call_too_few_args_at_least)
1302d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      << 0 /*function call*/ << 2 << TheCall->getNumArgs();
130356f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman  }
130456f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman
13055f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  // Type-check the first argument normally.
13065f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  if (checkBuiltinArgument(*this, TheCall, 0))
13075f8d604246976a93a73549b07bbc8ee0b2061b50John McCall    return true;
13085f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
1309c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner  // Determine whether the current function is variadic or not.
13109ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor  BlockScopeInfo *CurBlock = getCurBlock();
1311c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner  bool isVariadic;
1312cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff  if (CurBlock)
1313c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall    isVariadic = CurBlock->TheDecl->isVariadic();
13149498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek  else if (FunctionDecl *FD = getCurFunctionDecl())
13159498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek    isVariadic = FD->isVariadic();
13169498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek  else
131753d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis    isVariadic = getCurMethodDecl()->isVariadic();
13181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1319c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner  if (!isVariadic) {
132030ce344307f8a8b00054021307015571f83c7364Chris Lattner    Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
132130ce344307f8a8b00054021307015571f83c7364Chris Lattner    return true;
132230ce344307f8a8b00054021307015571f83c7364Chris Lattner  }
13231eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
132430ce344307f8a8b00054021307015571f83c7364Chris Lattner  // Verify that the second argument to the builtin is the last argument of the
132530ce344307f8a8b00054021307015571f83c7364Chris Lattner  // current function or method.
132630ce344307f8a8b00054021307015571f83c7364Chris Lattner  bool SecondArgIsLastNamedArgument = false;
1327e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson  const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts();
13281eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
132988cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson  if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
133088cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson    if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
133130ce344307f8a8b00054021307015571f83c7364Chris Lattner      // FIXME: This isn't correct for methods (results in bogus warning).
133230ce344307f8a8b00054021307015571f83c7364Chris Lattner      // Get the last formal in the current function.
133388cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson      const ParmVarDecl *LastArg;
1334cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff      if (CurBlock)
1335cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff        LastArg = *(CurBlock->TheDecl->param_end()-1);
1336cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff      else if (FunctionDecl *FD = getCurFunctionDecl())
1337371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner        LastArg = *(FD->param_end()-1);
133830ce344307f8a8b00054021307015571f83c7364Chris Lattner      else
133953d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis        LastArg = *(getCurMethodDecl()->param_end()-1);
134030ce344307f8a8b00054021307015571f83c7364Chris Lattner      SecondArgIsLastNamedArgument = PV == LastArg;
134130ce344307f8a8b00054021307015571f83c7364Chris Lattner    }
134230ce344307f8a8b00054021307015571f83c7364Chris Lattner  }
13431eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
134430ce344307f8a8b00054021307015571f83c7364Chris Lattner  if (!SecondArgIsLastNamedArgument)
13451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump    Diag(TheCall->getArg(1)->getLocStart(),
134630ce344307f8a8b00054021307015571f83c7364Chris Lattner         diag::warn_second_parameter_of_va_start_not_last_named_argument);
134730ce344307f8a8b00054021307015571f83c7364Chris Lattner  return false;
13486cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman}
134930ce344307f8a8b00054021307015571f83c7364Chris Lattner
13501b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and
13511b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends.  This is declared to take (...), so we have to check everything.
1352925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) {
1353925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  if (TheCall->getNumArgs() < 2)
13542c21a073525cdfa68e4439b7af551385dc2796abChris Lattner    return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
1355d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      << 0 << 2 << TheCall->getNumArgs()/*function call*/;
1356925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  if (TheCall->getNumArgs() > 2)
13571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump    return Diag(TheCall->getArg(2)->getLocStart(),
1358fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                diag::err_typecheck_call_too_many_args)
1359ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher      << 0 /*function call*/ << 2 << TheCall->getNumArgs()
1360fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner      << SourceRange(TheCall->getArg(2)->getLocStart(),
1361fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                     (*(TheCall->arg_end()-1))->getLocEnd());
13621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1363429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  ExprResult OrigArg0 = TheCall->getArg(0);
1364429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  ExprResult OrigArg1 = TheCall->getArg(1);
1365cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor
13661b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  // Do standard promotions between the two arguments, returning their common
13671b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  // type.
1368925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false);
1369429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  if (OrigArg0.isInvalid() || OrigArg1.isInvalid())
1370429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley    return true;
1371403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar
1372403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar  // Make sure any conversions are pushed back into the call; this is
1373403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar  // type safe since unordered compare builtins are declared as "_Bool
1374403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar  // foo(...)".
1375429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  TheCall->setArg(0, OrigArg0.get());
1376429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  TheCall->setArg(1, OrigArg1.get());
13771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1378429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent())
1379cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor    return false;
1380cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor
13811b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  // If the common type isn't a real floating type, then the arguments were
13821b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  // invalid for this operation.
1383860a319e62b0e256817a458396d191aa91c0787aEli Friedman  if (Res.isNull() || !Res->isRealFloatingType())
1384429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley    return Diag(OrigArg0.get()->getLocStart(),
1385fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                diag::err_typecheck_call_invalid_ordered_compare)
1386429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley      << OrigArg0.get()->getType() << OrigArg1.get()->getType()
1387429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley      << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd());
13881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
13891b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  return false;
13901b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner}
13911b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner
1392e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like
1393e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends.  This is declared to take (...), so we have
13943b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point
13953b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value.
13963b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) {
13973b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer  if (TheCall->getNumArgs() < NumArgs)
13989ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman    return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
1399d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      << 0 << NumArgs << TheCall->getNumArgs()/*function call*/;
14003b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer  if (TheCall->getNumArgs() > NumArgs)
14013b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer    return Diag(TheCall->getArg(NumArgs)->getLocStart(),
14029ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman                diag::err_typecheck_call_too_many_args)
1403ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher      << 0 /*function call*/ << NumArgs << TheCall->getNumArgs()
14043b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer      << SourceRange(TheCall->getArg(NumArgs)->getLocStart(),
14059ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman                     (*(TheCall->arg_end()-1))->getLocEnd());
14069ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman
14073b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer  Expr *OrigArg = TheCall->getArg(NumArgs-1);
14081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
14099ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  if (OrigArg->isTypeDependent())
14109ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman    return false;
14119ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman
141281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner  // This operation requires a non-_Complex floating-point number.
14139ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  if (!OrigArg->getType()->isRealFloatingType())
14141eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump    return Diag(OrigArg->getLocStart(),
14159ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman                diag::err_typecheck_call_invalid_unary_fp)
14169ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman      << OrigArg->getType() << OrigArg->getSourceRange();
14171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
141881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner  // If this is an implicit conversion from float -> double, remove it.
141981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner  if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) {
142081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner    Expr *CastArg = Cast->getSubExpr();
142181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner    if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) {
142281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner      assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) &&
142381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner             "promotion from float to double is the only expected cast here");
142481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner      Cast->setSubExpr(0);
142581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner      TheCall->setArg(NumArgs-1, CastArg);
142681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner    }
142781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner  }
142881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner
14299ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  return false;
14309ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman}
14319ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman
1432d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector.
1433d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything.
143460d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) {
143537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  if (TheCall->getNumArgs() < 2)
14360eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    return ExprError(Diag(TheCall->getLocEnd(),
1437d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher                          diag::err_typecheck_call_too_few_args_at_least)
143837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman      << 0 /*function call*/ << 2 << TheCall->getNumArgs()
1439d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      << TheCall->getSourceRange());
1440d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
144137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  // Determine which of the following types of shufflevector we're checking:
144237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  // 1) unary, vector mask: (lhs, mask)
144337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  // 2) binary, vector mask: (lhs, rhs, mask)
144437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  // 3) binary, scalar mask: (lhs, rhs, index, ..., index)
144537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  QualType resType = TheCall->getArg(0)->getType();
144637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  unsigned numElements = 0;
144737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman
1448cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor  if (!TheCall->getArg(0)->isTypeDependent() &&
1449cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      !TheCall->getArg(1)->isTypeDependent()) {
145037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    QualType LHSType = TheCall->getArg(0)->getType();
145137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    QualType RHSType = TheCall->getArg(1)->getType();
145237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman
145337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    if (!LHSType->isVectorType() || !RHSType->isVectorType()) {
1454cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector)
14551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump        << SourceRange(TheCall->getArg(0)->getLocStart(),
1456cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor                       TheCall->getArg(1)->getLocEnd());
1457cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      return ExprError();
1458cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor    }
145937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman
146037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    numElements = LHSType->getAs<VectorType>()->getNumElements();
146137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    unsigned numResElements = TheCall->getNumArgs() - 2;
146237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman
146337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    // Check to see if we have a call with 2 vector arguments, the unary shuffle
146437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    // with mask.  If so, verify that RHS is an integer vector type with the
146537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    // same number of elts as lhs.
146637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    if (TheCall->getNumArgs() == 2) {
1467f60946222721d9ba3c059563935c17b84703187aDouglas Gregor      if (!RHSType->hasIntegerRepresentation() ||
146837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman          RHSType->getAs<VectorType>()->getNumElements() != numElements)
146937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman        Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
147037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman          << SourceRange(TheCall->getArg(1)->getLocStart(),
147137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman                         TheCall->getArg(1)->getLocEnd());
147237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman      numResElements = numElements;
147337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    }
147437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) {
1475cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
14761eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump        << SourceRange(TheCall->getArg(0)->getLocStart(),
1477cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor                       TheCall->getArg(1)->getLocEnd());
1478cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      return ExprError();
147937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    } else if (numElements != numResElements) {
148037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman      QualType eltType = LHSType->getAs<VectorType>()->getElementType();
1481788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner      resType = Context.getVectorType(eltType, numResElements,
1482e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson                                      VectorType::GenericVector);
1483cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor    }
1484d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  }
1485d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
1486d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  for (unsigned i = 2; i < TheCall->getNumArgs(); i++) {
1487cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor    if (TheCall->getArg(i)->isTypeDependent() ||
1488cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor        TheCall->getArg(i)->isValueDependent())
1489cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      continue;
1490cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor
149137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    llvm::APSInt Result(32);
149237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context))
149337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman      return ExprError(Diag(TheCall->getLocStart(),
149437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman                  diag::err_shufflevector_nonconstant_argument)
149537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman                << TheCall->getArg(i)->getSourceRange());
14960eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl
1497d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner    if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2)
14980eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError(Diag(TheCall->getLocStart(),
1499fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                  diag::err_shufflevector_argument_too_large)
15000eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl               << TheCall->getArg(i)->getSourceRange());
1501d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  }
1502d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
15035f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner  SmallVector<Expr*, 32> exprs;
1504d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
1505d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner  for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) {
1506d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman    exprs.push_back(TheCall->getArg(i));
1507d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman    TheCall->setArg(i, 0);
1508d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  }
1509d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
15103b6bef9a213249c6ab6d67c07b1ac6380961be3eBenjamin Kramer  return Owned(new (Context) ShuffleVectorExpr(Context, exprs, resType,
15118189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek                                            TheCall->getCallee()->getLocStart(),
15128189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek                                            TheCall->getRParenLoc()));
1513d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman}
151430ce344307f8a8b00054021307015571f83c7364Chris Lattner
15154493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch.
15164493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two
15174493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args.
15184493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) {
1519fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner  unsigned NumArgs = TheCall->getNumArgs();
15204493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar
1521fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner  if (NumArgs > 3)
1522ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher    return Diag(TheCall->getLocEnd(),
1523ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher             diag::err_typecheck_call_too_many_args_at_most)
1524ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher             << 0 /*function call*/ << 3 << NumArgs
1525ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher             << TheCall->getSourceRange();
15264493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar
15274493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar  // Argument 0 is checked for us and the remaining arguments must be
15284493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar  // constant integers.
1529fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner  for (unsigned i = 1; i != NumArgs; ++i) {
15304493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    Expr *Arg = TheCall->getArg(i);
1531592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
1532592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor    // We can't check the value of a dependent argument.
1533592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor    if (Arg->isTypeDependent() || Arg->isValueDependent())
1534592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor      continue;
1535592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
15369aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman    llvm::APSInt Result;
1537691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher    if (SemaBuiltinConstantArg(TheCall, i, Result))
1538691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher      return true;
15391eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
15404493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    // FIXME: gcc issues a warning and rewrites these to 0. These
15414493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    // seems especially odd for the third argument since the default
15424493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    // is 3.
1543fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner    if (i == 1) {
15449aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman      if (Result.getLimitedValue() > 1)
1545fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner        return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
154621fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner             << "0" << "1" << Arg->getSourceRange();
15474493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    } else {
15489aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman      if (Result.getLimitedValue() > 3)
1549fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner        return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
155021fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner            << "0" << "3" << Arg->getSourceRange();
15514493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    }
15524493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar  }
15534493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar
1554fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner  return false;
15554493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar}
15564493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar
1557691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr
1558691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression.
1559691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum,
1560691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher                                  llvm::APSInt &Result) {
1561691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  Expr *Arg = TheCall->getArg(ArgNum);
1562691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
1563691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
1564691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher
1565691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (Arg->isTypeDependent() || Arg->isValueDependent()) return false;
1566691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher
1567691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (!Arg->isIntegerConstantExpr(Result, Context))
1568691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher    return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type)
15695e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher                << FDecl->getDeclName() <<  Arg->getSourceRange();
1570691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher
157121fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner  return false;
157221fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner}
157321fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner
1574d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr,
1575d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined
1576d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3).
1577fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner// For compatibility check 0-3, llvm only handles 0 and 2.
1578d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) {
1579691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  llvm::APSInt Result;
1580592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
1581592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor  // We can't check the value of a dependent argument.
1582592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor  if (TheCall->getArg(1)->isTypeDependent() ||
1583592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor      TheCall->getArg(1)->isValueDependent())
1584592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor    return false;
1585592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
1586691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  // Check constant-ness first.
1587691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (SemaBuiltinConstantArg(TheCall, 1, Result))
1588691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher    return true;
1589d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar
1590691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  Expr *Arg = TheCall->getArg(1);
1591d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar  if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) {
1592fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner    return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
1593fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner             << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
1594d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar  }
1595d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar
1596d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar  return false;
1597d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar}
1598d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar
1599586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val).
1600d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1.
1601d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) {
1602d875fed28578835de89cd407e9db4be788596d7cEli Friedman  Expr *Arg = TheCall->getArg(1);
1603691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  llvm::APSInt Result;
1604cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor
1605691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  // TODO: This is less than ideal. Overload this to take a value.
1606691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (SemaBuiltinConstantArg(TheCall, 1, Result))
1607691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher    return true;
1608691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher
1609691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (Result != 1)
1610d875fed28578835de89cd407e9db4be788596d7cEli Friedman    return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val)
1611d875fed28578835de89cd407e9db4be788596d7cEli Friedman             << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
1612d875fed28578835de89cd407e9db4be788596d7cEli Friedman
1613d875fed28578835de89cd407e9db4be788596d7cEli Friedman  return false;
1614d875fed28578835de89cd407e9db4be788596d7cEli Friedman}
1615d875fed28578835de89cd407e9db4be788596d7cEli Friedman
1616831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determine if an expression is a string literal or constant string.
1617831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// If this function returns false on the arguments to a function expecting a
1618831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// format string, we will usually need to emit a warning.
1619831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// True string literals are then checked by CheckFormatString.
1620831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithSema::StringLiteralCheckType
1621831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithSema::checkFormatStringExpr(const Expr *E, Expr **Args,
1622831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                            unsigned NumArgs, bool HasVAListArg,
1623831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                            unsigned format_idx, unsigned firstDataArg,
1624ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                            FormatStringType Type, VariadicCallType CallType,
1625ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                            bool inFunctionCall) {
16264fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain:
1627cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor  if (E->isTypeDependent() || E->isValueDependent())
1628831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
1629d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
163034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  E = E->IgnoreParenCasts();
1631f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne
1632a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie  if (E->isNullPointerConstant(Context, Expr::NPC_ValueDependentIsNotNull))
1633a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie    // Technically -Wformat-nonliteral does not warn about this case.
1634a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie    // The behavior of printf and friends in this case is implementation
1635a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie    // dependent.  Ideally if the format string cannot be null then
1636a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie    // it should have a 'nonnull' attribute in the function prototype.
1637831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_CheckedLiteral;
1638a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie
1639d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  switch (E->getStmtClass()) {
164056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall  case Stmt::BinaryConditionalOperatorClass:
1641d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  case Stmt::ConditionalOperatorClass: {
1642831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    // The expression is a literal if both sub-expressions were, and it was
1643831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    // completely checked only if both sub-expressions were checked.
1644831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    const AbstractConditionalOperator *C =
1645831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        cast<AbstractConditionalOperator>(E);
1646831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    StringLiteralCheckType Left =
1647831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        checkFormatStringExpr(C->getTrueExpr(), Args, NumArgs,
1648831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                              HasVAListArg, format_idx, firstDataArg,
1649ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                              Type, CallType, inFunctionCall);
1650831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    if (Left == SLCT_NotALiteral)
1651831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      return SLCT_NotALiteral;
1652831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    StringLiteralCheckType Right =
1653831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        checkFormatStringExpr(C->getFalseExpr(), Args, NumArgs,
1654831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                              HasVAListArg, format_idx, firstDataArg,
1655ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                              Type, CallType, inFunctionCall);
1656831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return Left < Right ? Left : Right;
1657d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  }
1658d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
1659d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  case Stmt::ImplicitCastExprClass: {
16604fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek    E = cast<ImplicitCastExpr>(E)->getSubExpr();
16614fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek    goto tryAgain;
1662d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  }
1663d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
166456ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall  case Stmt::OpaqueValueExprClass:
166556ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall    if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) {
166656ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall      E = src;
166756ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall      goto tryAgain;
166856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall    }
1669831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
167056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall
1671b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek  case Stmt::PredefinedExprClass:
1672b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek    // While __func__, etc., are technically not string literals, they
1673b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek    // cannot contain format specifiers and thus are not a security
1674b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek    // liability.
1675831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_UncheckedLiteral;
1676b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek
1677082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  case Stmt::DeclRefExprClass: {
1678082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    const DeclRefExpr *DR = cast<DeclRefExpr>(E);
16791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1680082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    // As an exception, do not flag errors for variables binding to
1681082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    // const string literals.
1682082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
1683082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      bool isConstant = false;
1684082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      QualType T = DR->getType();
1685082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek
1686082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      if (const ArrayType *AT = Context.getAsArrayType(T)) {
1687082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek        isConstant = AT->getElementType().isConstant(Context);
1688ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump      } else if (const PointerType *PT = T->getAs<PointerType>()) {
16891eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump        isConstant = T.isConstant(Context) &&
1690082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek                     PT->getPointeeType().isConstant(Context);
1691e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas      } else if (T->isObjCObjectPointerType()) {
1692e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas        // In ObjC, there is usually no "const ObjectPointer" type,
1693e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas        // so don't check if the pointee type is constant.
1694e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas        isConstant = T.isConstant(Context);
1695082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      }
16961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1697082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      if (isConstant) {
1698e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay        if (const Expr *Init = VD->getAnyInitializer()) {
1699e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay          // Look through initializers like const char c[] = { "foo" }
1700e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay          if (const InitListExpr *InitList = dyn_cast<InitListExpr>(Init)) {
1701e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay            if (InitList->isStringLiteralInit())
1702e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay              Init = InitList->getInit(0)->IgnoreParenImpCasts();
1703e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay          }
1704831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          return checkFormatStringExpr(Init, Args, NumArgs,
1705831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                       HasVAListArg, format_idx,
1706ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                       firstDataArg, Type, CallType,
1707831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                       /*inFunctionCall*/false);
1708e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay        }
1709082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      }
17101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1711d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // For vprintf* functions (i.e., HasVAListArg==true), we add a
1712d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // special check to see if the format string is a function parameter
1713d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // of the function calling the printf function.  If the function
1714d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // has an attribute indicating it is a printf-like function, then we
1715d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // should suppress warnings concerning non-literals being used in a call
1716d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // to a vprintf function.  For example:
1717d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //
1718d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // void
1719d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){
1720d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //      va_list ap;
1721d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //      va_start(ap, fmt);
1722d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //      vprintf(fmt, ap);  // Do NOT emit a warning about "fmt".
1723d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //      ...
1724d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //
1725f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas      if (HasVAListArg) {
1726f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas        if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(VD)) {
1727f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas          if (const NamedDecl *ND = dyn_cast<NamedDecl>(PV->getDeclContext())) {
1728f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas            int PVIndex = PV->getFunctionScopeIndex() + 1;
1729f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas            for (specific_attr_iterator<FormatAttr>
1730f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                 i = ND->specific_attr_begin<FormatAttr>(),
1731f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                 e = ND->specific_attr_end<FormatAttr>(); i != e ; ++i) {
1732f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              FormatAttr *PVFormat = *i;
1733f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              // adjust for implicit parameter
1734f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND))
1735f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                if (MD->isInstance())
1736f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                  ++PVIndex;
1737f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              // We also check if the formats are compatible.
1738f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              // We can't pass a 'scanf' string to a 'printf' function.
1739f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              if (PVIndex == PVFormat->getFormatIdx() &&
1740f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                  Type == GetFormatStringType(PVFormat))
1741831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                return SLCT_UncheckedLiteral;
1742f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas            }
1743f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas          }
1744f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas        }
1745f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas      }
1746082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    }
17471eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1748831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
1749082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  }
1750d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
175152aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas  case Stmt::CallExprClass:
175252aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas  case Stmt::CXXMemberCallExprClass: {
17538f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson    const CallExpr *CE = cast<CallExpr>(E);
175452aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas    if (const NamedDecl *ND = dyn_cast_or_null<NamedDecl>(CE->getCalleeDecl())) {
175552aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas      if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) {
175652aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas        unsigned ArgIndex = FA->getFormatIdx();
175752aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas        if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND))
175852aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas          if (MD->isInstance())
175952aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas            --ArgIndex;
176052aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas        const Expr *Arg = CE->getArg(ArgIndex - 1);
176152aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas
1762831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        return checkFormatStringExpr(Arg, Args, NumArgs,
1763831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                     HasVAListArg, format_idx, firstDataArg,
1764ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                     Type, CallType, inFunctionCall);
176550687314f87b67073c202fe46d84d12fb55e25cfJordan Rose      } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(ND)) {
176650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose        unsigned BuiltinID = FD->getBuiltinID();
176750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose        if (BuiltinID == Builtin::BI__builtin___CFStringMakeConstantString ||
176850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose            BuiltinID == Builtin::BI__builtin___NSStringMakeConstantString) {
176950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose          const Expr *Arg = CE->getArg(0);
1770831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          return checkFormatStringExpr(Arg, Args, NumArgs,
1771831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                       HasVAListArg, format_idx,
1772ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                       firstDataArg, Type, CallType,
1773ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                       inFunctionCall);
177450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose        }
17758f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson      }
17768f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson    }
17771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1778831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
17798f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson  }
1780082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  case Stmt::ObjCStringLiteralClass:
1781082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  case Stmt::StringLiteralClass: {
1782082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    const StringLiteral *StrE = NULL;
17831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1784082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E))
1785d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek      StrE = ObjCFExpr->getString();
1786d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek    else
1787082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      StrE = cast<StringLiteral>(E);
17881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1789d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek    if (StrE) {
179029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas      CheckFormatString(StrE, E, Args, NumArgs, HasVAListArg, format_idx,
1791ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                        firstDataArg, Type, inFunctionCall, CallType);
1792831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      return SLCT_CheckedLiteral;
1793d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek    }
17941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1795831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
1796d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  }
17971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1798082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  default:
1799831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
1800d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  }
1801d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek}
1802d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
1803e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid
18041eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull,
1805909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky                            const Expr * const *ExprArgs,
1806909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky                            SourceLocation CallSiteLoc) {
1807cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt  for (NonNullAttr::args_iterator i = NonNull->args_begin(),
1808cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt                                  e = NonNull->args_end();
1809e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian       i != e; ++i) {
1810909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky    const Expr *ArgExpr = ExprArgs[*i];
18114e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek    if (ArgExpr->isNullPointerConstant(Context,
1812ce94049b69f75b44c18584fe79cd238978b6b0d5Douglas Gregor                                       Expr::NPC_ValueDependentIsNotNull))
1813909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky      Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange();
1814e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian  }
1815e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian}
1816d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
181734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel DupasSema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) {
181834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  return llvm::StringSwitch<FormatStringType>(Format->getType())
181934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Case("scanf", FST_Scanf)
182034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Cases("printf", "printf0", FST_Printf)
182134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Cases("NSString", "CFString", FST_NSString)
182234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Case("strftime", FST_Strftime)
182334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Case("strfmon", FST_Strfmon)
182434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf)
182534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Default(FST_Unknown);
182634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas}
182734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas
1828ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose/// CheckFormatArguments - Check calls to printf and scanf (and similar
1829826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings.
1830831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true if a format string has been fully checked.
1831831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFormatArguments(const FormatAttr *Format, Expr **Args,
183229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                                unsigned NumArgs, bool IsCXXMember,
1833ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                VariadicCallType CallType,
183429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                                SourceLocation Loc, SourceRange Range) {
1835831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  FormatStringInfo FSI;
1836831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (getFormatStringInfo(Format, IsCXXMember, &FSI))
1837831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return CheckFormatArguments(Args, NumArgs, FSI.HasVAListArg, FSI.FormatIdx,
1838831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                FSI.FirstDataArg, GetFormatStringType(Format),
1839ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                CallType, Loc, Range);
1840831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return false;
184129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas}
18424a2614e94672c47395abcde60518776fbebec589Sebastian Redl
1843831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFormatArguments(Expr **Args, unsigned NumArgs,
184434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas                                bool HasVAListArg, unsigned format_idx,
184534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas                                unsigned firstDataArg, FormatStringType Type,
1846ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                VariadicCallType CallType,
184734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas                                SourceLocation Loc, SourceRange Range) {
1848826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  // CHECK: printf/scanf-like function is called with no format string.
184929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  if (format_idx >= NumArgs) {
185029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas    Diag(Loc, diag::warn_missing_format_string) << Range;
1851831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return false;
185271895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  }
18531eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
185429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts();
18551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
185659907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner  // CHECK: format string is not a string literal.
18571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  //
185871895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // Dynamically generated format strings are difficult to
185971895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // automatically vet at compile time.  Requiring that format strings
186071895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // are string literals: (1) permits the checking of format strings by
186171895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // the compiler and thereby (2) can practically remove the source of
186271895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // many format string exploits.
18637ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek
18641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  // Format string can be either ObjC string (e.g. @"%d") or
18657ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek  // C string (e.g. "%d")
18661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  // ObjC string uses the same format specifiers as C string, so we can use
18677ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek  // the same format string checking logic for both ObjC and C strings.
1868831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  StringLiteralCheckType CT =
1869831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      checkFormatStringExpr(OrigFormatExpr, Args, NumArgs, HasVAListArg,
1870ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                            format_idx, firstDataArg, Type, CallType);
1871831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (CT != SLCT_NotALiteral)
1872831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    // Literal format string found, check done!
1873831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return CT == SLCT_CheckedLiteral;
18741cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner
18752837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas  // Strftime is particular as it always uses a single 'time' argument,
18762837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas  // so it is safe to pass a non-literal string.
18772837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas  if (Type == FST_Strftime)
1878831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return false;
18792837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas
1880ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas  // Do not emit diag when the string param is a macro expansion and the
1881ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas  // format is either NSString or CFString. This is a hack to prevent
1882ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas  // diag when using the NSLocalizedString and CFCopyLocalizedString macros
1883ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas  // which are usually used in place of NS and CF string literals.
1884dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas  if (Type == FST_NSString &&
1885dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas      SourceMgr.isInSystemMacro(Args[format_idx]->getLocStart()))
1886831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return false;
1887ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas
1888655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner  // If there are no arguments specified, warn with -Wformat-security, otherwise
1889655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner  // warn only with -Wformat-nonliteral.
189029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  if (NumArgs == format_idx+1)
189129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas    Diag(Args[format_idx]->getLocStart(),
1892826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek         diag::warn_format_nonliteral_noargs)
1893655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner      << OrigFormatExpr->getSourceRange();
1894655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner  else
189529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas    Diag(Args[format_idx]->getLocStart(),
1896826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek         diag::warn_format_nonliteral)
1897655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner           << OrigFormatExpr->getSourceRange();
1898831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return false;
1899d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek}
1900d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
1901e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace {
1902826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler {
1903826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected:
1904e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  Sema &S;
1905e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  const StringLiteral *FExpr;
1906e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  const Expr *OrigFormatExpr;
19076ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek  const unsigned FirstDataArg;
1908e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  const unsigned NumDataArgs;
1909e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  const char *Beg; // Start of format string.
19100d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  const bool HasVAListArg;
191129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  const Expr * const *Args;
191229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  const unsigned NumArgs;
19130d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  unsigned FormatIdx;
19147f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  llvm::BitVector CoveredArgs;
1915efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  bool usesPositionalArgs;
1916efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  bool atFirstArg;
191755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  bool inFunctionCall;
1918ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose  Sema::VariadicCallType CallType;
19194e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic:
1920826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  CheckFormatHandler(Sema &s, const StringLiteral *fexpr,
19216ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek                     const Expr *origFormatExpr, unsigned firstDataArg,
192250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                     unsigned numDataArgs, const char *beg, bool hasVAListArg,
192329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                     Expr **args, unsigned numArgs,
1924ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                     unsigned formatIdx, bool inFunctionCall,
1925ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                     Sema::VariadicCallType callType)
1926e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek    : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr),
192750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose      FirstDataArg(firstDataArg), NumDataArgs(numDataArgs),
192850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose      Beg(beg), HasVAListArg(hasVAListArg),
192929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas      Args(args), NumArgs(numArgs), FormatIdx(formatIdx),
193055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      usesPositionalArgs(false), atFirstArg(true),
1931ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose      inFunctionCall(inFunctionCall), CallType(callType) {
19327f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek        CoveredArgs.resize(numDataArgs);
19337f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek        CoveredArgs.reset();
19347f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      }
19354e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
193607d161f38e708a91486bf1c031d525faebbb249dTed Kremenek  void DoneProcessing();
19374e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
1938826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  void HandleIncompleteSpecifier(const char *startSpecifier,
1939826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                 unsigned specifierLen);
194076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
1941bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  void HandleInvalidLengthModifier(
1942bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose      const analyze_format_string::FormatSpecifier &FS,
1943bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose      const analyze_format_string::ConversionSpecifier &CS,
19448be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose      const char *startSpecifier, unsigned specifierLen, unsigned DiagID);
1945bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
194676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg  void HandleNonStandardLengthModifier(
19478be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose      const analyze_format_string::FormatSpecifier &FS,
194876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg      const char *startSpecifier, unsigned specifierLen);
194976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
195076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg  void HandleNonStandardConversionSpecifier(
195176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg      const analyze_format_string::ConversionSpecifier &CS,
195276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg      const char *startSpecifier, unsigned specifierLen);
195376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
1954f85626453123f9691bcef13cff963f556e209c27Hans Wennborg  virtual void HandlePosition(const char *startPos, unsigned posLen);
1955f85626453123f9691bcef13cff963f556e209c27Hans Wennborg
1956efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  virtual void HandleInvalidPosition(const char *startSpecifier,
1957efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek                                     unsigned specifierLen,
1958826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                     analyze_format_string::PositionContext p);
1959efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
1960efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  virtual void HandleZeroPosition(const char *startPos, unsigned posLen);
1961efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
1962e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  void HandleNullChar(const char *nullCharacter);
19634e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
196455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  template <typename Range>
196555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  static void EmitFormatDiagnostic(Sema &S, bool inFunctionCall,
196655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                   const Expr *ArgumentExpr,
196755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                   PartialDiagnostic PDiag,
196855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                   SourceLocation StringLoc,
196955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                   bool IsStringLocation, Range StringRange,
1970ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                            ArrayRef<FixItHint> Fixit = ArrayRef<FixItHint>());
197155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
1972826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected:
1973c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc,
1974c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        const char *startSpec,
1975c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        unsigned specifierLen,
1976c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        const char *csStart, unsigned csLen);
197755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
197855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  void HandlePositionalNonpositionalArgs(SourceLocation Loc,
197955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                         const char *startSpec,
198055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                         unsigned specifierLen);
1981c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
1982f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek  SourceRange getFormatStringRange();
1983826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  CharSourceRange getSpecifierRange(const char *startSpecifier,
1984826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                    unsigned specifierLen);
1985e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  SourceLocation getLocationOfByte(const char *x);
19864e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
19870d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  const Expr *getDataArg(unsigned i) const;
1988666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek
1989666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS,
1990666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek                    const analyze_format_string::ConversionSpecifier &CS,
1991666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek                    const char *startSpecifier, unsigned specifierLen,
1992666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek                    unsigned argIndex);
199355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
199455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  template <typename Range>
199555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc,
199655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                            bool IsStringLocation, Range StringRange,
1997ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                            ArrayRef<FixItHint> Fixit = ArrayRef<FixItHint>());
199855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
199955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  void CheckPositionalAndNonpositionalArgs(
200055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      const analyze_format_string::FormatSpecifier *FS);
2001e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek};
2002e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}
2003e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2004826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() {
2005e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  return OrigFormatExpr->getSourceRange();
2006e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}
2007e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2008826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler::
2009826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) {
201045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  SourceLocation Start = getLocationOfByte(startSpecifier);
201145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  SourceLocation End   = getLocationOfByte(startSpecifier + specifierLen - 1);
201245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care
201345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  // Advance the end SourceLocation by one due to half-open ranges.
2014a64ccefdf0ea4e03ec88805d71b0af74950c7472Argyrios Kyrtzidis  End = End.getLocWithOffset(1);
201545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care
201645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  return CharSourceRange::getCharRange(Start, End);
2017f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek}
2018f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek
2019826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) {
20204e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek  return S.getLocationOfStringLiteralByte(FExpr, x - Beg);
2021e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}
2022e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2023826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier,
2024826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                                   unsigned specifierLen){
202555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier),
202655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(startSpecifier),
202755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       /*IsStringLocation*/true,
202855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpecifier, specifierLen));
2029808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek}
2030808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek
2031bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rosevoid CheckFormatHandler::HandleInvalidLengthModifier(
2032bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose    const analyze_format_string::FormatSpecifier &FS,
2033bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose    const analyze_format_string::ConversionSpecifier &CS,
20348be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    const char *startSpecifier, unsigned specifierLen, unsigned DiagID) {
2035bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  using namespace analyze_format_string;
2036bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
2037bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  const LengthModifier &LM = FS.getLengthModifier();
2038bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength());
2039bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
2040bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  // See if we know how to fix this length modifier.
2041bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  llvm::Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier();
2042bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  if (FixedLM) {
20438be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(),
2044bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose                         getLocationOfByte(LM.getStart()),
2045bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose                         /*IsStringLocation*/true,
2046bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose                         getSpecifierRange(startSpecifier, specifierLen));
2047bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
2048bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose    S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier)
2049bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose      << FixedLM->toString()
2050bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose      << FixItHint::CreateReplacement(LMRange, FixedLM->toString());
2051bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
2052bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  } else {
20538be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    FixItHint Hint;
20548be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    if (DiagID == diag::warn_format_nonsensical_length)
20558be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose      Hint = FixItHint::CreateRemoval(LMRange);
20568be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose
20578be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(),
2058bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose                         getLocationOfByte(LM.getStart()),
2059bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose                         /*IsStringLocation*/true,
2060bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose                         getSpecifierRange(startSpecifier, specifierLen),
20618be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         Hint);
2062bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  }
2063bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose}
2064bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
206576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardLengthModifier(
20668be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    const analyze_format_string::FormatSpecifier &FS,
206776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    const char *startSpecifier, unsigned specifierLen) {
20688be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  using namespace analyze_format_string;
20698be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose
20708be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  const LengthModifier &LM = FS.getLengthModifier();
20718be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength());
20728be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose
20738be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  // See if we know how to fix this length modifier.
20748be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  llvm::Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier();
20758be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  if (FixedLM) {
20768be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
20778be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                           << LM.toString() << 0,
20788be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         getLocationOfByte(LM.getStart()),
20798be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         /*IsStringLocation*/true,
20808be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         getSpecifierRange(startSpecifier, specifierLen));
20818be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose
20828be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier)
20838be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose      << FixedLM->toString()
20848be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose      << FixItHint::CreateReplacement(LMRange, FixedLM->toString());
20858be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose
20868be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  } else {
20878be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
20888be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                           << LM.toString() << 0,
20898be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         getLocationOfByte(LM.getStart()),
20908be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         /*IsStringLocation*/true,
20918be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         getSpecifierRange(startSpecifier, specifierLen));
20928be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  }
209376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg}
209476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
209576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardConversionSpecifier(
209676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    const analyze_format_string::ConversionSpecifier &CS,
209776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    const char *startSpecifier, unsigned specifierLen) {
209876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg  EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) << CS.toString()
2099f85626453123f9691bcef13cff963f556e209c27Hans Wennborg                       << 1,
210076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg                       getLocationOfByte(CS.getStart()),
210176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg                       /*IsStringLocation*/true,
210276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg                       getSpecifierRange(startSpecifier, specifierLen));
210376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg}
210476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
2105f85626453123f9691bcef13cff963f556e209c27Hans Wennborgvoid CheckFormatHandler::HandlePosition(const char *startPos,
2106f85626453123f9691bcef13cff963f556e209c27Hans Wennborg                                        unsigned posLen) {
2107f85626453123f9691bcef13cff963f556e209c27Hans Wennborg  EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_positional_arg),
2108f85626453123f9691bcef13cff963f556e209c27Hans Wennborg                               getLocationOfByte(startPos),
2109f85626453123f9691bcef13cff963f556e209c27Hans Wennborg                               /*IsStringLocation*/true,
2110f85626453123f9691bcef13cff963f556e209c27Hans Wennborg                               getSpecifierRange(startPos, posLen));
2111f85626453123f9691bcef13cff963f556e209c27Hans Wennborg}
2112f85626453123f9691bcef13cff963f556e209c27Hans Wennborg
2113efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid
2114826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen,
2115826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                     analyze_format_string::PositionContext p) {
211655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier)
211755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << (unsigned) p,
211855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(startPos), /*IsStringLocation*/true,
211955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startPos, posLen));
2120efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek}
2121efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
2122826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos,
2123efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek                                            unsigned posLen) {
212455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier),
212555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               getLocationOfByte(startPos),
212655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               /*IsStringLocation*/true,
212755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               getSpecifierRange(startPos, posLen));
2128efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek}
2129efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
2130826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) {
213150687314f87b67073c202fe46d84d12fb55e25cfJordan Rose  if (!isa<ObjCStringLiteral>(OrigFormatExpr)) {
21320c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek    // The presence of a null character is likely an error.
213355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    EmitFormatDiagnostic(
213455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      S.PDiag(diag::warn_printf_format_string_contains_null_char),
213555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      getLocationOfByte(nullCharacter), /*IsStringLocation*/true,
213655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      getFormatStringRange());
21370c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek  }
2138826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
2139826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
214048716663e421472cbd590af160a372bc490205e8Jordan Rose// Note that this may return NULL if there was an error parsing or building
214148716663e421472cbd590af160a372bc490205e8Jordan Rose// one of the argument expressions.
2142826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const {
214329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  return Args[FirstDataArg + i];
2144826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
21454e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2146826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() {
2147826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    // Does the number of data arguments exceed the number of
2148826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    // format conversions in the format string?
2149826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (!HasVAListArg) {
2150826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      // Find any arguments that weren't covered.
2151826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    CoveredArgs.flip();
2152826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    signed notCoveredArg = CoveredArgs.find_first();
2153826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    if (notCoveredArg >= 0) {
2154826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      assert((unsigned)notCoveredArg < NumDataArgs);
215548716663e421472cbd590af160a372bc490205e8Jordan Rose      if (const Expr *E = getDataArg((unsigned) notCoveredArg)) {
215648716663e421472cbd590af160a372bc490205e8Jordan Rose        SourceLocation Loc = E->getLocStart();
215748716663e421472cbd590af160a372bc490205e8Jordan Rose        if (!S.getSourceManager().isInSystemMacro(Loc)) {
215848716663e421472cbd590af160a372bc490205e8Jordan Rose          EmitFormatDiagnostic(S.PDiag(diag::warn_printf_data_arg_not_used),
215948716663e421472cbd590af160a372bc490205e8Jordan Rose                               Loc, /*IsStringLocation*/false,
216048716663e421472cbd590af160a372bc490205e8Jordan Rose                               getFormatStringRange());
216148716663e421472cbd590af160a372bc490205e8Jordan Rose        }
2162c03f2df2a2b097bf2686bf32411d5022323988b2Bob Wilson      }
2163826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    }
2164826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  }
2165826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
2166826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2167c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool
2168c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex,
2169c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     SourceLocation Loc,
2170c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     const char *startSpec,
2171c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     unsigned specifierLen,
2172c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     const char *csStart,
2173c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     unsigned csLen) {
2174c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2175c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  bool keepGoing = true;
2176c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  if (argIndex < NumDataArgs) {
2177c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // Consider the argument coverered, even though the specifier doesn't
2178c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // make sense.
2179c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    CoveredArgs.set(argIndex);
2180c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  }
2181c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  else {
2182c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // If argIndex exceeds the number of data arguments we
2183c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // don't issue a warning because that is just a cascade of warnings (and
2184c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // they may have intended '%%' anyway). We don't want to continue processing
2185c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // the format string after this point, however, as we will like just get
2186c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // gibberish when trying to match arguments.
2187c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    keepGoing = false;
2188c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  }
2189c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
219055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_conversion)
219155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << StringRef(csStart, csLen),
219255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       Loc, /*IsStringLocation*/true,
219355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpec, specifierLen));
2194c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2195c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  return keepGoing;
2196c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek}
2197c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
219855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid
219955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard TrieuCheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc,
220055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                                      const char *startSpec,
220155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                                      unsigned specifierLen) {
220255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(
220355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    S.PDiag(diag::warn_format_mix_positional_nonpositional_args),
220455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen));
220555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu}
220655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
2207666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool
2208666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs(
2209666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  const analyze_format_string::FormatSpecifier &FS,
2210666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  const analyze_format_string::ConversionSpecifier &CS,
2211666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  const char *startSpecifier, unsigned specifierLen, unsigned argIndex) {
2212666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek
2213666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  if (argIndex >= NumDataArgs) {
221455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    PartialDiagnostic PDiag = FS.usesPositionalArg()
221555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args)
221655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu           << (argIndex+1) << NumDataArgs)
221755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      : S.PDiag(diag::warn_printf_insufficient_data_args);
221855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    EmitFormatDiagnostic(
221955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true,
222055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      getSpecifierRange(startSpecifier, specifierLen));
2221666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek    return false;
2222666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  }
2223666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  return true;
2224666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek}
2225666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek
222655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range>
222755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag,
222855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              SourceLocation Loc,
222955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              bool IsStringLocation,
223055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              Range StringRange,
2231ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                                              ArrayRef<FixItHint> FixIt) {
223229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag,
223355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       Loc, IsStringLocation, StringRange, FixIt);
223455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu}
223555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
223655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \brief If the format string is not within the funcion call, emit a note
223755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// so that the function call and string are in diagnostic messages.
223855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
223970517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param InFunctionCall if true, the format string is within the function
224055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// call and only one diagnostic message will be produced.  Otherwise, an
224155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// extra note will be emitted pointing to location of the format string.
224255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
224355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param ArgumentExpr the expression that is passed as the format string
224455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// argument in the function call.  Used for getting locations when two
224555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostics are emitted.
224655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
224755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param PDiag the callee should already have provided any strings for the
224855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostic message.  This function only adds locations and fixits
224955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// to diagnostics.
225055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
225155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param Loc primary location for diagnostic.  If two diagnostics are
225255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// required, one will be at Loc and a new SourceLocation will be created for
225355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// the other one.
225455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
225555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param IsStringLocation if true, Loc points to the format string should be
225655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// used for the note.  Otherwise, Loc points to the argument list and will
225755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// be used with PDiag.
225855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
225955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param StringRange some or all of the string to highlight.  This is
226055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// templated so it can accept either a CharSourceRange or a SourceRange.
226155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
226270517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param FixIt optional fix it hint for the format string.
226355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range>
226455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(Sema &S, bool InFunctionCall,
226555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              const Expr *ArgumentExpr,
226655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              PartialDiagnostic PDiag,
226755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              SourceLocation Loc,
226855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              bool IsStringLocation,
226955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              Range StringRange,
2270ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                                              ArrayRef<FixItHint> FixIt) {
2271ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  if (InFunctionCall) {
2272ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    const Sema::SemaDiagnosticBuilder &D = S.Diag(Loc, PDiag);
2273ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    D << StringRange;
2274ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end();
2275ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose         I != E; ++I) {
2276ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      D << *I;
2277ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    }
2278ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  } else {
227955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag)
228055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      << ArgumentExpr->getSourceRange();
2281ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2282ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    const Sema::SemaDiagnosticBuilder &Note =
2283ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      S.Diag(IsStringLocation ? Loc : StringRange.getBegin(),
2284ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose             diag::note_format_string_defined);
2285ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2286ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    Note << StringRange;
2287ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end();
2288ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose         I != E; ++I) {
2289ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      Note << *I;
2290ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    }
229155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  }
229255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu}
229355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
2294826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===//
2295826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2296826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace {
2297826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler {
229850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose  bool ObjCContext;
2299826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic:
2300826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  CheckPrintfHandler(Sema &s, const StringLiteral *fexpr,
2301826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                     const Expr *origFormatExpr, unsigned firstDataArg,
230250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                     unsigned numDataArgs, bool isObjC,
2303826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                     const char *beg, bool hasVAListArg,
230429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                     Expr **Args, unsigned NumArgs,
2305ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                     unsigned formatIdx, bool inFunctionCall,
2306ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                     Sema::VariadicCallType CallType)
2307826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
230850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                       numDataArgs, beg, hasVAListArg, Args, NumArgs,
2309ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                       formatIdx, inFunctionCall, CallType), ObjCContext(isObjC)
2310ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose  {}
2311ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose
2312826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2313826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  bool HandleInvalidPrintfConversionSpecifier(
2314826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const analyze_printf::PrintfSpecifier &FS,
2315826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const char *startSpecifier,
2316826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      unsigned specifierLen);
2317826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2318826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS,
2319826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                             const char *startSpecifier,
2320826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                             unsigned specifierLen);
2321831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  bool checkFormatExpr(const analyze_printf::PrintfSpecifier &FS,
2322831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                       const char *StartSpecifier,
2323831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                       unsigned SpecifierLen,
2324831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                       const Expr *E);
2325831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2326826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k,
2327826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                    const char *startSpecifier, unsigned specifierLen);
2328826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS,
2329826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                           const analyze_printf::OptionalAmount &Amt,
2330826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                           unsigned type,
2331826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                           const char *startSpecifier, unsigned specifierLen);
2332826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  void HandleFlag(const analyze_printf::PrintfSpecifier &FS,
2333826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                  const analyze_printf::OptionalFlag &flag,
2334826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                  const char *startSpecifier, unsigned specifierLen);
2335826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS,
2336826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                         const analyze_printf::OptionalFlag &ignoredFlag,
2337826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                         const analyze_printf::OptionalFlag &flag,
2338826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                         const char *startSpecifier, unsigned specifierLen);
2339f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg  bool checkForCStrMembers(const analyze_printf::ArgType &AT,
2340831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                           const Expr *E, const CharSourceRange &CSR);
2341831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2342826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek};
2343826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
2344826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2345826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier(
2346826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const analyze_printf::PrintfSpecifier &FS,
2347826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const char *startSpecifier,
2348826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      unsigned specifierLen) {
23496ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const analyze_printf::PrintfConversionSpecifier &CS =
2350c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    FS.getConversionSpecifier();
2351826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2352c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  return HandleInvalidConversionSpecifier(FS.getArgIndex(),
2353c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          getLocationOfByte(CS.getStart()),
2354c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          startSpecifier, specifierLen,
2355c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          CS.getStart(), CS.getLength());
235626ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek}
235726ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek
2358826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount(
2359826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                               const analyze_format_string::OptionalAmount &Amt,
2360826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                               unsigned k, const char *startSpecifier,
2361826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                               unsigned specifierLen) {
23620d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek
23630d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  if (Amt.hasDataArgument()) {
23640d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek    if (!HasVAListArg) {
23657f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      unsigned argIndex = Amt.getArgIndex();
23667f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      if (argIndex >= NumDataArgs) {
236755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu        EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg)
236855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               << k,
236955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             getLocationOfByte(Amt.getStart()),
237055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             /*IsStringLocation*/true,
237155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             getSpecifierRange(startSpecifier, specifierLen));
23720d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        // Don't do any more checking.  We will just emit
23730d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        // spurious errors.
23740d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        return false;
23750d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek      }
23764e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
23770d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek      // Type check the data argument.  It should be an 'int'.
237831f8e32788adb299acad455363eb7fd244642c82Ted Kremenek      // Although not in conformance with C99, we also allow the argument to be
237931f8e32788adb299acad455363eb7fd244642c82Ted Kremenek      // an 'unsigned int' as that is a reasonably safe case.  GCC also
238031f8e32788adb299acad455363eb7fd244642c82Ted Kremenek      // doesn't emit a warning for that case.
23817f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      CoveredArgs.set(argIndex);
23827f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      const Expr *Arg = getDataArg(argIndex);
238348716663e421472cbd590af160a372bc490205e8Jordan Rose      if (!Arg)
238448716663e421472cbd590af160a372bc490205e8Jordan Rose        return false;
238548716663e421472cbd590af160a372bc490205e8Jordan Rose
23860d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek      QualType T = Arg->getType();
23874e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2388f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg      const analyze_printf::ArgType &AT = Amt.getArgType(S.Context);
2389f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg      assert(AT.isValid());
23904e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2391f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg      if (!AT.matchesType(S.Context, T)) {
239255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu        EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type)
2393f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg                               << k << AT.getRepresentativeTypeName(S.Context)
239455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               << T << Arg->getSourceRange(),
239555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             getLocationOfByte(Amt.getStart()),
239655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             /*IsStringLocation*/true,
239755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             getSpecifierRange(startSpecifier, specifierLen));
23980d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        // Don't do any more checking.  We will just emit
23990d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        // spurious errors.
24000d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        return false;
24010d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek      }
24020d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek    }
24030d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  }
24040d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  return true;
24050d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek}
24060d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek
2407e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount(
2408826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const analyze_printf::PrintfSpecifier &FS,
2409e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                      const analyze_printf::OptionalAmount &Amt,
2410e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                      unsigned type,
2411e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                      const char *startSpecifier,
2412e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                      unsigned specifierLen) {
24136ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const analyze_printf::PrintfConversionSpecifier &CS =
24146ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek    FS.getConversionSpecifier();
2415e4ee9663168dfb2b4122c768091e30217328c9faTom Care
241655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  FixItHint fixit =
241755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant
241855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(),
241955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                 Amt.getConstantLength()))
242055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      : FixItHint();
242155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
242255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount)
242355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << type << CS.toString(),
242455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(Amt.getStart()),
242555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       /*IsStringLocation*/true,
242655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpecifier, specifierLen),
242755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       fixit);
2428e4ee9663168dfb2b4122c768091e30217328c9faTom Care}
2429e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2430826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS,
2431e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                    const analyze_printf::OptionalFlag &flag,
2432e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                    const char *startSpecifier,
2433e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                    unsigned specifierLen) {
2434e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Warn about pointless flag with a fixit removal.
24356ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const analyze_printf::PrintfConversionSpecifier &CS =
24366ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek    FS.getConversionSpecifier();
243755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag)
243855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << flag.toString() << CS.toString(),
243955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(flag.getPosition()),
244055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       /*IsStringLocation*/true,
244155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpecifier, specifierLen),
244255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       FixItHint::CreateRemoval(
244355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         getSpecifierRange(flag.getPosition(), 1)));
2444e4ee9663168dfb2b4122c768091e30217328c9faTom Care}
2445e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2446e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag(
2447826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                const analyze_printf::PrintfSpecifier &FS,
2448e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                const analyze_printf::OptionalFlag &ignoredFlag,
2449e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                const analyze_printf::OptionalFlag &flag,
2450e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                const char *startSpecifier,
2451e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                unsigned specifierLen) {
2452e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Warn about ignored flag with a fixit removal.
245355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag)
245455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << ignoredFlag.toString() << flag.toString(),
245555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(ignoredFlag.getPosition()),
245655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       /*IsStringLocation*/true,
245755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpecifier, specifierLen),
245855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       FixItHint::CreateRemoval(
245955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         getSpecifierRange(ignoredFlag.getPosition(), 1)));
2460e4ee9663168dfb2b4122c768091e30217328c9faTom Care}
2461e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2462831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determines if the specified is a C++ class or struct containing
2463831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// a member with the specified name and kind (e.g. a CXXMethodDecl named
2464831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// "c_str()").
2465831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithtemplate<typename MemberKind>
2466831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithstatic llvm::SmallPtrSet<MemberKind*, 1>
2467831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCXXRecordMembersNamed(StringRef Name, Sema &S, QualType Ty) {
2468831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  const RecordType *RT = Ty->getAs<RecordType>();
2469831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  llvm::SmallPtrSet<MemberKind*, 1> Results;
2470831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2471831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (!RT)
2472831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return Results;
2473831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl());
2474831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (!RD)
2475831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return Results;
2476831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2477831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  LookupResult R(S, &S.PP.getIdentifierTable().get(Name), SourceLocation(),
2478831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                 Sema::LookupMemberName);
2479831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2480831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // We just need to include all members of the right kind turned up by the
2481831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // filter, at this point.
2482831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (S.LookupQualifiedName(R, RT->getDecl()))
2483831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    for (LookupResult::iterator I = R.begin(), E = R.end(); I != E; ++I) {
2484831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      NamedDecl *decl = (*I)->getUnderlyingDecl();
2485831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      if (MemberKind *FK = dyn_cast<MemberKind>(decl))
2486831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        Results.insert(FK);
2487831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    }
2488831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return Results;
2489831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
2490831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2491831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Check if a (w)string was passed when a (w)char* was needed, and offer a
2492f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg// better diagnostic if so. AT is assumed to be valid.
2493831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Returns true when a c_str() conversion method is found.
2494831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool CheckPrintfHandler::checkForCStrMembers(
2495f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg    const analyze_printf::ArgType &AT, const Expr *E,
2496831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    const CharSourceRange &CSR) {
2497831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  typedef llvm::SmallPtrSet<CXXMethodDecl*, 1> MethodSet;
2498831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2499831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  MethodSet Results =
2500831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      CXXRecordMembersNamed<CXXMethodDecl>("c_str", S, E->getType());
2501831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2502831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  for (MethodSet::iterator MI = Results.begin(), ME = Results.end();
2503831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith       MI != ME; ++MI) {
2504831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    const CXXMethodDecl *Method = *MI;
2505831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    if (Method->getNumParams() == 0 &&
2506f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg          AT.matchesType(S.Context, Method->getResultType())) {
2507831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      // FIXME: Suggest parens if the expression needs them.
2508831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      SourceLocation EndLoc =
2509831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          S.getPreprocessor().getLocForEndOfToken(E->getLocEnd());
2510831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      S.Diag(E->getLocStart(), diag::note_printf_c_str)
2511831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          << "c_str()"
2512831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          << FixItHint::CreateInsertion(EndLoc, ".c_str()");
2513831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      return true;
2514831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    }
2515831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  }
2516831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2517831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return false;
2518831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
2519831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2520e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool
2521826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier
25225c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek                                            &FS,
2523e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek                                          const char *startSpecifier,
2524e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek                                          unsigned specifierLen) {
2525e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
25266ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  using namespace analyze_format_string;
2527efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  using namespace analyze_printf;
25286ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const PrintfConversionSpecifier &CS = FS.getConversionSpecifier();
2529e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2530baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek  if (FS.consumesDataArgument()) {
2531baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    if (atFirstArg) {
2532baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek        atFirstArg = false;
2533baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek        usesPositionalArgs = FS.usesPositionalArg();
2534baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    }
2535baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    else if (usesPositionalArgs != FS.usesPositionalArg()) {
253655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()),
253755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                        startSpecifier, specifierLen);
2538baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek      return false;
2539baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    }
2540efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  }
2541efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
25420d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  // First check if the field width, precision, and conversion specifier
25430d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  // have matching data arguments.
2544efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0,
2545efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek                    startSpecifier, specifierLen)) {
25460d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek    return false;
25470d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  }
25484e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2549efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  if (!HandleAmount(FS.getPrecision(), /* precision */ 1,
2550efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek                    startSpecifier, specifierLen)) {
25510d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek    return false;
25520d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  }
25530d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek
2554f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek  if (!CS.consumesDataArgument()) {
2555f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek    // FIXME: Technically specifying a precision or field width here
2556f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek    // makes no sense.  Worth issuing a warning at some point.
25570e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek    return true;
2558f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek  }
25594e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
25607f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  // Consume the argument.
25617f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  unsigned argIndex = FS.getArgIndex();
2562e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek  if (argIndex < NumDataArgs) {
2563e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek    // The check to see if the argIndex is valid will come later.
2564e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek    // We set the bit here because we may exit early from this
2565e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek    // function if we encounter some other error.
2566e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek    CoveredArgs.set(argIndex);
2567e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek  }
25687f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek
25697f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  // Check for using an Objective-C specific conversion specifier
25707f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  // in a non-ObjC literal.
257150687314f87b67073c202fe46d84d12fb55e25cfJordan Rose  if (!ObjCContext && CS.isObjCArg()) {
2572826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier,
2573826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                                  specifierLen);
25747f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  }
25754e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2576e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check for invalid use of field width
2577e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidFieldWidth()) {
257845f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care    HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0,
2579e4ee9663168dfb2b4122c768091e30217328c9faTom Care        startSpecifier, specifierLen);
2580e4ee9663168dfb2b4122c768091e30217328c9faTom Care  }
2581e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2582e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check for invalid use of precision
2583e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidPrecision()) {
2584e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1,
2585e4ee9663168dfb2b4122c768091e30217328c9faTom Care        startSpecifier, specifierLen);
2586e4ee9663168dfb2b4122c768091e30217328c9faTom Care  }
2587e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2588e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check each flag does not conflict with any other component.
258965197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek  if (!FS.hasValidThousandsGroupingPrefix())
259065197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek    HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen);
2591e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidLeadingZeros())
2592e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen);
2593e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidPlusPrefix())
2594e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen);
259545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  if (!FS.hasValidSpacePrefix())
259645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care    HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen);
2597e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidAlternativeForm())
2598e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen);
2599e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidLeftJustified())
2600e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen);
2601e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2602e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check that flags are not ignored by another flag
260345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+'
260445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care    HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(),
260545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care        startSpecifier, specifierLen);
2606e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-'
2607e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(),
2608e4ee9663168dfb2b4122c768091e30217328c9faTom Care            startSpecifier, specifierLen);
2609e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2610e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check the length modifier is valid with the given conversion specifier.
2611bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo()))
26128be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
26138be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                                diag::warn_format_nonsensical_length);
2614bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  else if (!FS.hasStandardLengthModifier())
26158be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen);
2616bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  else if (!FS.hasStandardLengthConversionCombination())
26178be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
26188be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                                diag::warn_format_non_standard_conversion_spec);
2619e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2620bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  if (!FS.hasStandardConversionSpecifier(S.getLangOpts()))
2621bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose    HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen);
2622bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
2623da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek  // The remaining checks depend on the data arguments.
2624da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek  if (HasVAListArg)
2625da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek    return true;
26264e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2627666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
2628da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek    return false;
26294e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
263048716663e421472cbd590af160a372bc490205e8Jordan Rose  const Expr *Arg = getDataArg(argIndex);
263148716663e421472cbd590af160a372bc490205e8Jordan Rose  if (!Arg)
263248716663e421472cbd590af160a372bc490205e8Jordan Rose    return true;
263348716663e421472cbd590af160a372bc490205e8Jordan Rose
263448716663e421472cbd590af160a372bc490205e8Jordan Rose  return checkFormatExpr(FS, startSpecifier, specifierLen, Arg);
2635831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
2636831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2637ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rosestatic bool requiresParensToAddCast(const Expr *E) {
2638ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  // FIXME: We should have a general way to reason about operator
2639ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  // precedence and whether parens are actually needed here.
2640ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  // Take care of a few common cases where they aren't.
2641ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  const Expr *Inside = E->IgnoreImpCasts();
2642ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  if (const PseudoObjectExpr *POE = dyn_cast<PseudoObjectExpr>(Inside))
2643ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    Inside = POE->getSyntacticForm()->IgnoreImpCasts();
2644ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2645ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  switch (Inside->getStmtClass()) {
2646ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::ArraySubscriptExprClass:
2647ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::CallExprClass:
2648ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::DeclRefExprClass:
2649ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::MemberExprClass:
2650ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::ObjCIvarRefExprClass:
2651ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::ObjCMessageExprClass:
2652ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::ObjCPropertyRefExprClass:
2653ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::ParenExprClass:
2654ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::UnaryOperatorClass:
2655ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    return false;
2656ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  default:
2657ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    return true;
2658ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  }
2659ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose}
2660ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2661831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool
2662831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCheckPrintfHandler::checkFormatExpr(const analyze_printf::PrintfSpecifier &FS,
2663831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                    const char *StartSpecifier,
2664831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                    unsigned SpecifierLen,
2665831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                    const Expr *E) {
2666831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  using namespace analyze_format_string;
2667831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  using namespace analyze_printf;
266896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer  // Now type check the data expression that matches the
266996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer  // format specifier.
2670f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg  const analyze_printf::ArgType &AT = FS.getArgType(S.Context,
2671f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg                                                    ObjCContext);
2672614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  if (!AT.isValid())
2673614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    return true;
2674ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2675ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  QualType IntendedTy = E->getType();
2676ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  if (AT.matchesType(S.Context, IntendedTy))
2677614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    return true;
2678614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose
2679614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  // Look through argument promotions for our error message's reported type.
2680614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  // This includes the integral and floating promotions, but excludes array
2681614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  // and function pointer decay; seeing that an argument intended to be a
2682614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  // string has type 'char [6]' is probably more confusing than 'char *'.
2683614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) {
2684614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    if (ICE->getCastKind() == CK_IntegralCast ||
2685614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        ICE->getCastKind() == CK_FloatingCast) {
2686614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      E = ICE->getSubExpr();
2687ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      IntendedTy = E->getType();
2688614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose
2689614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      // Check if we didn't match because of an implicit cast from a 'char'
2690614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      // or 'short' to an 'int'.  This is done because printf is a varargs
2691614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      // function.
2692614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      if (ICE->getType() == S.Context.IntTy ||
2693614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          ICE->getType() == S.Context.UnsignedIntTy) {
2694614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        // All further checking is done on the subexpression.
2695ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        if (AT.matchesType(S.Context, IntendedTy))
2696614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          return true;
26974d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek      }
2698ee0259d308e72141982a85b40863e760a8447edfJordan Rose    }
2699614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  }
2700614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose
2701ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  if (S.Context.getTargetInfo().getTriple().isOSDarwin()) {
2702ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    // Special-case some of Darwin's platform-independence types.
2703ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    if (const TypedefType *UserTy = IntendedTy->getAs<TypedefType>()) {
2704ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      StringRef Name = UserTy->getDecl()->getName();
2705ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      IntendedTy = llvm::StringSwitch<QualType>(Name)
2706ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        .Case("NSInteger", S.Context.LongTy)
2707ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        .Case("NSUInteger", S.Context.UnsignedLongTy)
2708ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        .Case("SInt32", S.Context.IntTy)
2709ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        .Case("UInt32", S.Context.UnsignedIntTy)
2710ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        .Default(IntendedTy);
2711ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    }
2712ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  }
2713ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2714614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  // We may be able to offer a FixItHint if it is a supported type.
2715614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  PrintfSpecifier fixedFS = FS;
2716ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  bool success = fixedFS.fixType(IntendedTy, S.getLangOpts(),
2717614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose                                 S.Context, ObjCContext);
271896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer
2719614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  if (success) {
2720614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    // Get the fix string from the fixed format specifier
2721614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    SmallString<16> buf;
2722614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    llvm::raw_svector_ostream os(buf);
2723614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    fixedFS.toString(os);
2724614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose
2725ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    CharSourceRange SpecRange = getSpecifierRange(StartSpecifier, SpecifierLen);
2726ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2727ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    if (IntendedTy != E->getType()) {
2728ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // The canonical type for formatting this value is different from the
2729ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // actual type of the expression. (This occurs, for example, with Darwin's
2730ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // NSInteger on 32-bit platforms, where it is typedef'd as 'int', but
2731ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // should be printed as 'long' for 64-bit compatibility.)
2732ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // Rather than emitting a normal format/argument mismatch, we want to
2733ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // add a cast to the recommended type (and correct the format string
2734ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // if necessary).
2735ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      SmallString<16> CastBuf;
2736ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      llvm::raw_svector_ostream CastFix(CastBuf);
2737ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      CastFix << "(";
2738ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      IntendedTy.print(CastFix, S.Context.getPrintingPolicy());
2739ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      CastFix << ")";
2740ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2741ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      SmallVector<FixItHint,4> Hints;
2742ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      if (!AT.matchesType(S.Context, IntendedTy))
2743ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        Hints.push_back(FixItHint::CreateReplacement(SpecRange, os.str()));
2744ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2745ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      if (const CStyleCastExpr *CCast = dyn_cast<CStyleCastExpr>(E)) {
2746ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        // If there's already a cast present, just replace it.
2747ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        SourceRange CastRange(CCast->getLParenLoc(), CCast->getRParenLoc());
2748ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        Hints.push_back(FixItHint::CreateReplacement(CastRange, CastFix.str()));
2749ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2750ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      } else if (!requiresParensToAddCast(E)) {
2751ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        // If the expression has high enough precedence,
2752ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        // just write the C-style cast.
2753ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(),
2754ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                                                   CastFix.str()));
2755ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      } else {
2756ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        // Otherwise, add parens around the expression as well as the cast.
2757ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        CastFix << "(";
2758ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(),
2759ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                                                   CastFix.str()));
2760ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2761ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        SourceLocation After = S.PP.getLocForEndOfToken(E->getLocEnd());
2762ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        Hints.push_back(FixItHint::CreateInsertion(After, ")"));
2763ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      }
2764ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2765ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // We extract the name from the typedef because we don't want to show
2766ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // the underlying type in the diagnostic.
2767ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      const TypedefType *UserTy = cast<TypedefType>(E->getType());
2768ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      StringRef Name = UserTy->getDecl()->getName();
2769ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2770ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // Finally, emit the diagnostic.
2771ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      EmitFormatDiagnostic(S.PDiag(diag::warn_format_argument_needs_cast)
2772ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                             << Name << IntendedTy
2773ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                             << E->getSourceRange(),
2774ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                           E->getLocStart(), /*IsStringLocation=*/false,
2775ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                           SpecRange, Hints);
2776ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    } else {
2777ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      EmitFormatDiagnostic(
2778ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
2779ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose          << AT.getRepresentativeTypeName(S.Context) << IntendedTy
2780ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose          << E->getSourceRange(),
2781ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        E->getLocStart(),
2782ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        /*IsStringLocation*/false,
2783ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        SpecRange,
2784ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        FixItHint::CreateReplacement(SpecRange, os.str()));
2785ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    }
2786614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  } else {
2787614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    const CharSourceRange &CSR = getSpecifierRange(StartSpecifier,
2788614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose                                                   SpecifierLen);
2789614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    // Since the warning for passing non-POD types to variadic functions
2790614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    // was deferred until now, we emit a warning for non-POD
2791614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    // arguments here.
2792614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    if (S.isValidVarArgType(E->getType()) == Sema::VAK_Invalid) {
2793614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      unsigned DiagKind;
2794614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      if (E->getType()->isObjCObjectType())
2795614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        DiagKind = diag::err_cannot_pass_objc_interface_to_vararg_format;
2796614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      else
2797614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        DiagKind = diag::warn_non_pod_vararg_with_format_string;
279896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer
2799614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      EmitFormatDiagnostic(
2800614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        S.PDiag(DiagKind)
2801614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          << S.getLangOpts().CPlusPlus0x
2802614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          << E->getType()
2803614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          << CallType
2804614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          << AT.getRepresentativeTypeName(S.Context)
2805614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          << CSR
2806614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          << E->getSourceRange(),
2807614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        E->getLocStart(), /*IsStringLocation*/false, CSR);
280896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer
2809614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      checkForCStrMembers(AT, E, CSR);
2810614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    } else
281155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      EmitFormatDiagnostic(
281255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu        S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
2813f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg          << AT.getRepresentativeTypeName(S.Context) << E->getType()
2814614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          << CSR
2815831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          << E->getSourceRange(),
2816614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        E->getLocStart(), /*IsStringLocation*/false, CSR);
281796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer  }
281896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer
2819e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  return true;
2820e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}
2821e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2822826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===//
2823826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2824826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace {
2825826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler {
2826826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic:
2827826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  CheckScanfHandler(Sema &s, const StringLiteral *fexpr,
2828826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                    const Expr *origFormatExpr, unsigned firstDataArg,
282950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                    unsigned numDataArgs, const char *beg, bool hasVAListArg,
283029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                    Expr **Args, unsigned NumArgs,
2831ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                    unsigned formatIdx, bool inFunctionCall,
2832ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                    Sema::VariadicCallType CallType)
2833826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
283450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                       numDataArgs, beg, hasVAListArg,
2835ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                       Args, NumArgs, formatIdx, inFunctionCall, CallType)
2836ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose  {}
2837826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2838826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS,
2839826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                            const char *startSpecifier,
2840826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                            unsigned specifierLen);
2841c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2842c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  bool HandleInvalidScanfConversionSpecifier(
2843c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek          const analyze_scanf::ScanfSpecifier &FS,
2844c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek          const char *startSpecifier,
2845c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek          unsigned specifierLen);
2846b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek
2847b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek  void HandleIncompleteScanList(const char *start, const char *end);
2848826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek};
2849826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
2850826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2851b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start,
2852b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek                                                 const char *end) {
285355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete),
285455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(end), /*IsStringLocation*/true,
285555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(start, end - start));
2856b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek}
2857b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek
2858c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier(
2859c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        const analyze_scanf::ScanfSpecifier &FS,
2860c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        const char *startSpecifier,
2861c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        unsigned specifierLen) {
2862c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
28636ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const analyze_scanf::ScanfConversionSpecifier &CS =
2864c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    FS.getConversionSpecifier();
2865c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2866c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  return HandleInvalidConversionSpecifier(FS.getArgIndex(),
2867c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          getLocationOfByte(CS.getStart()),
2868c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          startSpecifier, specifierLen,
2869c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          CS.getStart(), CS.getLength());
2870c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek}
2871c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2872826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier(
2873826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                       const analyze_scanf::ScanfSpecifier &FS,
2874826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                       const char *startSpecifier,
2875826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                       unsigned specifierLen) {
2876826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2877826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  using namespace analyze_scanf;
2878826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  using namespace analyze_format_string;
2879826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
28806ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const ScanfConversionSpecifier &CS = FS.getConversionSpecifier();
2881826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2882baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek  // Handle case where '%' and '*' don't consume an argument.  These shouldn't
2883baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek  // be used to decide if we are using positional arguments consistently.
2884baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek  if (FS.consumesDataArgument()) {
2885baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    if (atFirstArg) {
2886baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek      atFirstArg = false;
2887baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek      usesPositionalArgs = FS.usesPositionalArg();
2888baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    }
2889baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    else if (usesPositionalArgs != FS.usesPositionalArg()) {
289055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()),
289155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                        startSpecifier, specifierLen);
2892baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek      return false;
2893baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    }
2894826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  }
2895826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2896826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  // Check if the field with is non-zero.
2897826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  const OptionalAmount &Amt = FS.getFieldWidth();
2898826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (Amt.getHowSpecified() == OptionalAmount::Constant) {
2899826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    if (Amt.getConstantAmount() == 0) {
2900826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      const CharSourceRange &R = getSpecifierRange(Amt.getStart(),
2901826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                                   Amt.getConstantLength());
290255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width),
290355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                           getLocationOfByte(Amt.getStart()),
290455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                           /*IsStringLocation*/true, R,
290555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                           FixItHint::CreateRemoval(R));
29067f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek    }
29077f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  }
2908826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2909826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (!FS.consumesDataArgument()) {
2910826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    // FIXME: Technically specifying a precision or field width here
2911826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    // makes no sense.  Worth issuing a warning at some point.
2912826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    return true;
2913826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  }
2914826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2915826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  // Consume the argument.
2916826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  unsigned argIndex = FS.getArgIndex();
2917826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (argIndex < NumDataArgs) {
2918826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      // The check to see if the argIndex is valid will come later.
2919826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      // We set the bit here because we may exit early from this
2920826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      // function if we encounter some other error.
2921826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    CoveredArgs.set(argIndex);
2922826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  }
2923826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
29241e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek  // Check the length modifier is valid with the given conversion specifier.
2925bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo()))
29268be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
29278be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                                diag::warn_format_nonsensical_length);
2928bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  else if (!FS.hasStandardLengthModifier())
29298be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen);
2930bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  else if (!FS.hasStandardLengthConversionCombination())
29318be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
29328be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                                diag::warn_format_non_standard_conversion_spec);
293376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
2934bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  if (!FS.hasStandardConversionSpecifier(S.getLangOpts()))
2935bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose    HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen);
2936bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
2937826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  // The remaining checks depend on the data arguments.
2938826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (HasVAListArg)
2939826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    return true;
2940826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2941666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
2942826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    return false;
2943826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
29446fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg  // Check that the argument type matches the format specifier.
29456fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg  const Expr *Ex = getDataArg(argIndex);
294648716663e421472cbd590af160a372bc490205e8Jordan Rose  if (!Ex)
294748716663e421472cbd590af160a372bc490205e8Jordan Rose    return true;
294848716663e421472cbd590af160a372bc490205e8Jordan Rose
294958e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg  const analyze_format_string::ArgType &AT = FS.getArgType(S.Context);
295058e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg  if (AT.isValid() && !AT.matchesType(S.Context, Ex->getType())) {
29516fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg    ScanfSpecifier fixedFS = FS;
29524e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie    bool success = fixedFS.fixType(Ex->getType(), S.getLangOpts(),
2953be6126a2a784e1446460b8d15c2b26f880c871fcHans Wennborg                                   S.Context);
29546fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg
29556fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg    if (success) {
29566fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg      // Get the fix string from the fixed format specifier.
2957f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith      SmallString<128> buf;
29586fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg      llvm::raw_svector_ostream os(buf);
29596fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg      fixedFS.toString(os);
29606fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg
29616fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg      EmitFormatDiagnostic(
29626fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg        S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
296358e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg          << AT.getRepresentativeTypeName(S.Context) << Ex->getType()
29646fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg          << Ex->getSourceRange(),
2965abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay        Ex->getLocStart(),
2966abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay        /*IsStringLocation*/false,
29676fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg        getSpecifierRange(startSpecifier, specifierLen),
29686fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg        FixItHint::CreateReplacement(
29696fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg          getSpecifierRange(startSpecifier, specifierLen),
29706fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg          os.str()));
29716fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg    } else {
2972220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas      EmitFormatDiagnostic(
2973220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas        S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
297458e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg          << AT.getRepresentativeTypeName(S.Context) << Ex->getType()
2975220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas          << Ex->getSourceRange(),
2976abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay        Ex->getLocStart(),
2977abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay        /*IsStringLocation*/false,
2978220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas        getSpecifierRange(startSpecifier, specifierLen));
29796fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg    }
29806fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg  }
29816fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg
2982826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  return true;
298307d161f38e708a91486bf1c031d525faebbb249dTed Kremenek}
2984e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2985826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr,
29860e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek                             const Expr *OrigFormatExpr,
298729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                             Expr **Args, unsigned NumArgs,
298829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                             bool HasVAListArg, unsigned format_idx,
298934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas                             unsigned firstDataArg, FormatStringType Type,
2990ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                             bool inFunctionCall, VariadicCallType CallType) {
2991826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2992e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  // CHECK: is the format string a wide literal?
2993df9ef1bc8c3780307ab2ed81bf5e31c23310b936Richard Smith  if (!FExpr->isAscii() && !FExpr->isUTF8()) {
299455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    CheckFormatHandler::EmitFormatDiagnostic(
299529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas      *this, inFunctionCall, Args[format_idx],
299655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(),
299755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      /*IsStringLocation*/true, OrigFormatExpr->getSourceRange());
2998e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek    return;
2999e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  }
3000826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3001e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  // Str - The format string.  NOTE: this is NOT null-terminated!
30025f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner  StringRef StrRef = FExpr->getString();
30032f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer  const char *Str = StrRef.data();
30042f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer  unsigned StrLen = StrRef.size();
300529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  const unsigned numDataArgs = NumArgs - firstDataArg;
3006826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3007e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  // CHECK: empty format string?
30084cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek  if (StrLen == 0 && numDataArgs > 0) {
300955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    CheckFormatHandler::EmitFormatDiagnostic(
301029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas      *this, inFunctionCall, Args[format_idx],
301155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      PDiag(diag::warn_empty_format_string), FExpr->getLocStart(),
301255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      /*IsStringLocation*/true, OrigFormatExpr->getSourceRange());
3013e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek    return;
3014e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  }
3015826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
301634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  if (Type == FST_Printf || Type == FST_NSString) {
3017826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
301850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                         numDataArgs, (Type == FST_NSString),
301929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                         Str, HasVAListArg, Args, NumArgs, format_idx,
3020ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                         inFunctionCall, CallType);
3021826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3022d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg    if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen,
30234e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie                                                  getLangOpts()))
3024826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      H.DoneProcessing();
302534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  } else if (Type == FST_Scanf) {
302650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose    CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, numDataArgs,
302729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                        Str, HasVAListArg, Args, NumArgs, format_idx,
3028ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                        inFunctionCall, CallType);
3029826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3030d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg    if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen,
30314e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie                                                 getLangOpts()))
3032826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      H.DoneProcessing();
303334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  } // TODO: handle other formats
3034ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek}
3035ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek
30367ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth//===--- CHECK: Standard memory functions ---------------------------------===//
30377ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth
30382a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// \brief Determine whether the given type is a dynamic class type (e.g.,
30392a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// whether it has a vtable).
30402a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregorstatic bool isDynamicClassType(QualType T) {
30412a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor  if (CXXRecordDecl *Record = T->getAsCXXRecordDecl())
30422a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor    if (CXXRecordDecl *Definition = Record->getDefinition())
30432a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor      if (Definition->isDynamicClass())
30442a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor        return true;
30452a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor
30462a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor  return false;
30472a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor}
30482a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor
3049a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument expression,
3050000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth/// otherwise returns NULL.
3051000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic const Expr *getSizeOfExprArg(const Expr* E) {
3052e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber  if (const UnaryExprOrTypeTraitExpr *SizeOf =
3053000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      dyn_cast<UnaryExprOrTypeTraitExpr>(E))
3054000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth    if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType())
3055000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      return SizeOf->getArgumentExpr()->IgnoreParenImpCasts();
3056e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber
3057000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  return 0;
3058000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth}
3059000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
3060a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument type.
3061000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic QualType getSizeOfArgType(const Expr* E) {
3062000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  if (const UnaryExprOrTypeTraitExpr *SizeOf =
3063000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      dyn_cast<UnaryExprOrTypeTraitExpr>(E))
3064000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth    if (SizeOf->getKind() == clang::UETT_SizeOf)
3065000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      return SizeOf->getTypeOfArgument();
3066000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
3067000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  return QualType();
3068e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber}
3069e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber
30707ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \brief Check for dangerous or invalid arguments to memset().
30717ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth///
3072929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth/// This issues warnings on known problematic, dangerous or unspecified
3073cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp'
3074cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// function calls.
30757ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth///
30767ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \param Call The call expression to diagnose.
3077cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gayvoid Sema::CheckMemaccessArguments(const CallExpr *Call,
30780a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks                                   unsigned BId,
3079cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay                                   IdentifierInfo *FnName) {
30800a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  assert(BId != 0);
30810a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks
30821d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek  // It is possible to have a non-standard definition of memset.  Validate
3083707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor  // we have enough arguments, and if not, abort further checking.
30840a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  unsigned ExpectedNumArgs = (BId == Builtin::BIstrndup ? 2 : 3);
3085cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber  if (Call->getNumArgs() < ExpectedNumArgs)
30861d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek    return;
30871d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek
30880a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  unsigned LastArg = (BId == Builtin::BImemset ||
30890a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks                      BId == Builtin::BIstrndup ? 1 : 2);
30900a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  unsigned LenArg = (BId == Builtin::BIstrndup ? 1 : 2);
3091cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber  const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts();
3092000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
3093000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  // We have special checking when the length is a sizeof expression.
3094000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  QualType SizeOfArgTy = getSizeOfArgType(LenExpr);
3095000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  const Expr *SizeOfArg = getSizeOfExprArg(LenExpr);
3096000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  llvm::FoldingSetNodeID SizeOfArgID;
3097000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
309806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor  for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) {
309906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor    const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts();
3100e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber    SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange();
310106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor
310206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor    QualType DestTy = Dest->getType();
310306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor    if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) {
310406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor      QualType PointeeTy = DestPtrTy->getPointeeType();
3105f85e193739c953358c865005855253af4f68a497John McCall
3106000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // Never warn about void type pointers. This can be used to suppress
3107000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // false positives.
3108000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      if (PointeeTy->isVoidType())
310906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor        continue;
311006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor
3111000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by
3112000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // actually comparing the expressions for equality. Because computing the
3113000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // expression IDs can be expensive, we only do this if the diagnostic is
3114000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // enabled.
3115000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      if (SizeOfArg &&
3116000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess,
3117000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                                   SizeOfArg->getExprLoc())) {
3118000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        // We only compute IDs for expressions if the warning is enabled, and
3119000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        // cache the sizeof arg's ID.
3120000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        if (SizeOfArgID == llvm::FoldingSetNodeID())
3121000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          SizeOfArg->Profile(SizeOfArgID, Context, true);
3122000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        llvm::FoldingSetNodeID DestID;
3123000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        Dest->Profile(DestID, Context, true);
3124000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        if (DestID == SizeOfArgID) {
3125cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber          // TODO: For strncpy() and friends, this could suggest sizeof(dst)
3126cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber          //       over sizeof(src) as well.
3127000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          unsigned ActionIdx = 0; // Default is to suggest dereferencing.
31286fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          StringRef ReadableName = FnName->getName();
31296fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks
3130000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest))
313190c78328e70cb376754edf87708505a84c044271Anna Zaks            if (UnaryOp->getOpcode() == UO_AddrOf)
3132000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth              ActionIdx = 1; // If its an address-of operator, just remove it.
3133000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          if (Context.getTypeSize(PointeeTy) == Context.getCharWidth())
3134000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth            ActionIdx = 2; // If the pointee's size is sizeof(char),
3135000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                           // suggest an explicit length.
31366fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks
31376fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          // If the function is defined as a builtin macro, do not show macro
31386fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          // expansion.
31396fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          SourceLocation SL = SizeOfArg->getExprLoc();
31406fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          SourceRange DSR = Dest->getSourceRange();
31416fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          SourceRange SSR = SizeOfArg->getSourceRange();
31426fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          SourceManager &SM  = PP.getSourceManager();
31436fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks
31446fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          if (SM.isMacroArgExpansion(SL)) {
31456fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks            ReadableName = Lexer::getImmediateMacroName(SL, SM, LangOpts);
31466fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks            SL = SM.getSpellingLoc(SL);
31476fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks            DSR = SourceRange(SM.getSpellingLoc(DSR.getBegin()),
31486fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks                             SM.getSpellingLoc(DSR.getEnd()));
31496fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks            SSR = SourceRange(SM.getSpellingLoc(SSR.getBegin()),
31506fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks                             SM.getSpellingLoc(SSR.getEnd()));
31516fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          }
31526fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks
315390c78328e70cb376754edf87708505a84c044271Anna Zaks          DiagRuntimeBehavior(SL, SizeOfArg,
3154000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                              PDiag(diag::warn_sizeof_pointer_expr_memaccess)
31556fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks                                << ReadableName
315690c78328e70cb376754edf87708505a84c044271Anna Zaks                                << PointeeTy
315790c78328e70cb376754edf87708505a84c044271Anna Zaks                                << DestTy
31586fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks                                << DSR
315990c78328e70cb376754edf87708505a84c044271Anna Zaks                                << SSR);
316090c78328e70cb376754edf87708505a84c044271Anna Zaks          DiagRuntimeBehavior(SL, SizeOfArg,
316190c78328e70cb376754edf87708505a84c044271Anna Zaks                         PDiag(diag::warn_sizeof_pointer_expr_memaccess_note)
316290c78328e70cb376754edf87708505a84c044271Anna Zaks                                << ActionIdx
316390c78328e70cb376754edf87708505a84c044271Anna Zaks                                << SSR);
316490c78328e70cb376754edf87708505a84c044271Anna Zaks
3165000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          break;
3166000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        }
3167000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      }
3168000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
3169000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // Also check for cases where the sizeof argument is the exact same
3170000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // type as the memory argument, and where it points to a user-defined
3171000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // record type.
3172000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      if (SizeOfArgTy != QualType()) {
3173000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        if (PointeeTy->isRecordType() &&
3174000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth            Context.typesAreCompatible(SizeOfArgTy, DestTy)) {
3175000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest,
3176000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                              PDiag(diag::warn_sizeof_pointer_type_memaccess)
3177000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                                << FnName << SizeOfArgTy << ArgIdx
3178000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                                << PointeeTy << Dest->getSourceRange()
3179000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                                << LenExpr->getSourceRange());
3180000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          break;
3181000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        }
3182e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber      }
3183e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber
318406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor      // Always complain about dynamic classes.
31850a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks      if (isDynamicClassType(PointeeTy)) {
31860a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks
31870a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        unsigned OperationType = 0;
31880a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        // "overwritten" if we're warning about the destination for any call
31890a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        // but memcmp; otherwise a verb appropriate to the call.
31900a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        if (ArgIdx != 0 || BId == Builtin::BImemcmp) {
31910a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks          if (BId == Builtin::BImemcpy)
31920a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            OperationType = 1;
31930a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks          else if(BId == Builtin::BImemmove)
31940a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            OperationType = 2;
31950a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks          else if (BId == Builtin::BImemcmp)
31960a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            OperationType = 3;
31970a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        }
31980a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks
31995c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay        DiagRuntimeBehavior(
32005c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay          Dest->getExprLoc(), Dest,
32015c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay          PDiag(diag::warn_dyn_class_memaccess)
32020a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx)
3203d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks            << FnName << PointeeTy
32040a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            << OperationType
32055c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay            << Call->getCallee()->getSourceRange());
32060a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks      } else if (PointeeTy.hasNonTrivialObjCLifetime() &&
32070a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks               BId != Builtin::BImemset)
32085c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay        DiagRuntimeBehavior(
32095c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay          Dest->getExprLoc(), Dest,
32105c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay          PDiag(diag::warn_arc_object_memaccess)
32115c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay            << ArgIdx << FnName << PointeeTy
32125c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay            << Call->getCallee()->getSourceRange());
3213f85e193739c953358c865005855253af4f68a497John McCall      else
321406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor        continue;
3215f85e193739c953358c865005855253af4f68a497John McCall
3216f85e193739c953358c865005855253af4f68a497John McCall      DiagRuntimeBehavior(
3217f85e193739c953358c865005855253af4f68a497John McCall        Dest->getExprLoc(), Dest,
3218929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth        PDiag(diag::note_bad_memaccess_silence)
321906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor          << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)"));
322006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor      break;
322106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor    }
32227ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth  }
32237ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth}
32247ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth
3225bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// A little helper routine: ignore addition and subtraction of integer literals.
3226bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// This intentionally does not ignore all integer constant expressions because
3227bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// we don't want to remove sizeof().
3228bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekstatic const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) {
3229bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  Ex = Ex->IgnoreParenCasts();
3230bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3231bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  for (;;) {
3232bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex);
3233bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    if (!BO || !BO->isAdditiveOp())
3234bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      break;
3235bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3236bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    const Expr *RHS = BO->getRHS()->IgnoreParenCasts();
3237bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    const Expr *LHS = BO->getLHS()->IgnoreParenCasts();
3238bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3239bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    if (isa<IntegerLiteral>(RHS))
3240bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      Ex = LHS;
3241bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    else if (isa<IntegerLiteral>(LHS))
3242bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      Ex = RHS;
3243bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    else
3244bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      break;
3245bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  }
3246bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3247bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  return Ex;
3248bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek}
3249bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
32500f38acee92014cb15af980808f87144e5564031dAnna Zaksstatic bool isConstantSizeArrayWithMoreThanOneElement(QualType Ty,
32510f38acee92014cb15af980808f87144e5564031dAnna Zaks                                                      ASTContext &Context) {
32520f38acee92014cb15af980808f87144e5564031dAnna Zaks  // Only handle constant-sized or VLAs, but not flexible members.
32530f38acee92014cb15af980808f87144e5564031dAnna Zaks  if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(Ty)) {
32540f38acee92014cb15af980808f87144e5564031dAnna Zaks    // Only issue the FIXIT for arrays of size > 1.
32550f38acee92014cb15af980808f87144e5564031dAnna Zaks    if (CAT->getSize().getSExtValue() <= 1)
32560f38acee92014cb15af980808f87144e5564031dAnna Zaks      return false;
32570f38acee92014cb15af980808f87144e5564031dAnna Zaks  } else if (!Ty->isVariableArrayType()) {
32580f38acee92014cb15af980808f87144e5564031dAnna Zaks    return false;
32590f38acee92014cb15af980808f87144e5564031dAnna Zaks  }
32600f38acee92014cb15af980808f87144e5564031dAnna Zaks  return true;
32610f38acee92014cb15af980808f87144e5564031dAnna Zaks}
32620f38acee92014cb15af980808f87144e5564031dAnna Zaks
3263bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// Warn if the user has made the 'size' argument to strlcpy or strlcat
3264bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// be the size of the source, instead of the destination.
3265bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekvoid Sema::CheckStrlcpycatArguments(const CallExpr *Call,
3266bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek                                    IdentifierInfo *FnName) {
3267bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3268bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // Don't crash if the user has the wrong number of arguments
3269bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (Call->getNumArgs() != 3)
3270bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    return;
3271bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3272bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context);
3273bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context);
3274bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *CompareWithSrc = NULL;
3275bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3276bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // Look for 'strlcpy(dst, x, sizeof(x))'
3277bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (const Expr *Ex = getSizeOfExprArg(SizeArg))
3278bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    CompareWithSrc = Ex;
3279bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  else {
3280bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    // Look for 'strlcpy(dst, x, strlen(x))'
3281bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) {
3282180f47959a066795cc0f409433023af448bb0328Richard Smith      if (SizeCall->isBuiltinCall() == Builtin::BIstrlen
3283bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek          && SizeCall->getNumArgs() == 1)
3284bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek        CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context);
3285bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    }
3286bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  }
3287bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3288bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (!CompareWithSrc)
3289bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    return;
3290bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3291bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // Determine if the argument to sizeof/strlen is equal to the source
3292bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // argument.  In principle there's all kinds of things you could do
3293bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // here, for instance creating an == expression and evaluating it with
3294bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // EvaluateAsBooleanCondition, but this uses a more direct technique:
3295bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg);
3296bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (!SrcArgDRE)
3297bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    return;
3298bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3299bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc);
3300bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (!CompareWithSrcDRE ||
3301bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl())
3302bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    return;
3303bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3304bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *OriginalSizeArg = Call->getArg(2);
3305bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size)
3306bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    << OriginalSizeArg->getSourceRange() << FnName;
3307bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3308bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // Output a FIXIT hint if the destination is an array (rather than a
3309bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // pointer to an array).  This could be enhanced to handle some
3310bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // pointers if we know the actual size, like if DstArg is 'array+2'
3311bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // we could say 'sizeof(array)-2'.
3312bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts();
33130f38acee92014cb15af980808f87144e5564031dAnna Zaks  if (!isConstantSizeArrayWithMoreThanOneElement(DstArg->getType(), Context))
33148f7462237ff542a4556775f98709ed300aa1731aTed Kremenek    return;
33158f7462237ff542a4556775f98709ed300aa1731aTed Kremenek
3316f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith  SmallString<128> sizeString;
33178f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  llvm::raw_svector_ostream OS(sizeString);
33188f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  OS << "sizeof(";
3319d1420c6fa788669e49f21e184927c7833881e399Richard Smith  DstArg->printPretty(OS, 0, getPrintingPolicy());
33208f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  OS << ")";
33218f7462237ff542a4556775f98709ed300aa1731aTed Kremenek
33228f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size)
33238f7462237ff542a4556775f98709ed300aa1731aTed Kremenek    << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(),
33248f7462237ff542a4556775f98709ed300aa1731aTed Kremenek                                    OS.str());
3325bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek}
3326bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3327c36bedc90c687caa71748480c60707ea4608b092Anna Zaks/// Check if two expressions refer to the same declaration.
3328c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic bool referToTheSameDecl(const Expr *E1, const Expr *E2) {
3329c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (const DeclRefExpr *D1 = dyn_cast_or_null<DeclRefExpr>(E1))
3330c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    if (const DeclRefExpr *D2 = dyn_cast_or_null<DeclRefExpr>(E2))
3331c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      return D1->getDecl() == D2->getDecl();
3332c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  return false;
3333c36bedc90c687caa71748480c60707ea4608b092Anna Zaks}
3334c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3335c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic const Expr *getStrlenExprArg(const Expr *E) {
3336c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (const CallExpr *CE = dyn_cast<CallExpr>(E)) {
3337c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    const FunctionDecl *FD = CE->getDirectCallee();
3338c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    if (!FD || FD->getMemoryFunctionKind() != Builtin::BIstrlen)
3339c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      return 0;
3340c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    return CE->getArg(0)->IgnoreParenCasts();
3341c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  }
3342c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  return 0;
3343c36bedc90c687caa71748480c60707ea4608b092Anna Zaks}
3344c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3345c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// Warn on anti-patterns as the 'size' argument to strncat.
3346c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// The correct size argument should look like following:
3347c36bedc90c687caa71748480c60707ea4608b092Anna Zaks//   strncat(dst, src, sizeof(dst) - strlen(dest) - 1);
3348c36bedc90c687caa71748480c60707ea4608b092Anna Zaksvoid Sema::CheckStrncatArguments(const CallExpr *CE,
3349c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                                 IdentifierInfo *FnName) {
3350c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  // Don't crash if the user has the wrong number of arguments.
3351c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (CE->getNumArgs() < 3)
3352c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    return;
3353c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  const Expr *DstArg = CE->getArg(0)->IgnoreParenCasts();
3354c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  const Expr *SrcArg = CE->getArg(1)->IgnoreParenCasts();
3355c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  const Expr *LenArg = CE->getArg(2)->IgnoreParenCasts();
3356c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3357c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  // Identify common expressions, which are wrongly used as the size argument
3358c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  // to strncat and may lead to buffer overflows.
3359c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  unsigned PatternType = 0;
3360c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (const Expr *SizeOfArg = getSizeOfExprArg(LenArg)) {
3361c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    // - sizeof(dst)
3362c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    if (referToTheSameDecl(SizeOfArg, DstArg))
3363c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      PatternType = 1;
3364c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    // - sizeof(src)
3365c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    else if (referToTheSameDecl(SizeOfArg, SrcArg))
3366c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      PatternType = 2;
3367c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  } else if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(LenArg)) {
3368c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    if (BE->getOpcode() == BO_Sub) {
3369c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      const Expr *L = BE->getLHS()->IgnoreParenCasts();
3370c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      const Expr *R = BE->getRHS()->IgnoreParenCasts();
3371c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      // - sizeof(dst) - strlen(dst)
3372c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      if (referToTheSameDecl(DstArg, getSizeOfExprArg(L)) &&
3373c36bedc90c687caa71748480c60707ea4608b092Anna Zaks          referToTheSameDecl(DstArg, getStrlenExprArg(R)))
3374c36bedc90c687caa71748480c60707ea4608b092Anna Zaks        PatternType = 1;
3375c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      // - sizeof(src) - (anything)
3376c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      else if (referToTheSameDecl(SrcArg, getSizeOfExprArg(L)))
3377c36bedc90c687caa71748480c60707ea4608b092Anna Zaks        PatternType = 2;
3378c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    }
3379c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  }
3380c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3381c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (PatternType == 0)
3382c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    return;
3383c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3384afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  // Generate the diagnostic.
3385afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  SourceLocation SL = LenArg->getLocStart();
3386afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  SourceRange SR = LenArg->getSourceRange();
3387afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  SourceManager &SM  = PP.getSourceManager();
3388afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks
3389afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  // If the function is defined as a builtin macro, do not show macro expansion.
3390afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  if (SM.isMacroArgExpansion(SL)) {
3391afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    SL = SM.getSpellingLoc(SL);
3392afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    SR = SourceRange(SM.getSpellingLoc(SR.getBegin()),
3393afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks                     SM.getSpellingLoc(SR.getEnd()));
3394afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  }
3395afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks
33960f38acee92014cb15af980808f87144e5564031dAnna Zaks  // Check if the destination is an array (rather than a pointer to an array).
33970f38acee92014cb15af980808f87144e5564031dAnna Zaks  QualType DstTy = DstArg->getType();
33980f38acee92014cb15af980808f87144e5564031dAnna Zaks  bool isKnownSizeArray = isConstantSizeArrayWithMoreThanOneElement(DstTy,
33990f38acee92014cb15af980808f87144e5564031dAnna Zaks                                                                    Context);
34000f38acee92014cb15af980808f87144e5564031dAnna Zaks  if (!isKnownSizeArray) {
34010f38acee92014cb15af980808f87144e5564031dAnna Zaks    if (PatternType == 1)
34020f38acee92014cb15af980808f87144e5564031dAnna Zaks      Diag(SL, diag::warn_strncat_wrong_size) << SR;
34030f38acee92014cb15af980808f87144e5564031dAnna Zaks    else
34040f38acee92014cb15af980808f87144e5564031dAnna Zaks      Diag(SL, diag::warn_strncat_src_size) << SR;
34050f38acee92014cb15af980808f87144e5564031dAnna Zaks    return;
34060f38acee92014cb15af980808f87144e5564031dAnna Zaks  }
34070f38acee92014cb15af980808f87144e5564031dAnna Zaks
3408c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (PatternType == 1)
3409afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    Diag(SL, diag::warn_strncat_large_size) << SR;
3410c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  else
3411afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    Diag(SL, diag::warn_strncat_src_size) << SR;
3412c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3413f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith  SmallString<128> sizeString;
3414c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  llvm::raw_svector_ostream OS(sizeString);
3415c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  OS << "sizeof(";
3416d1420c6fa788669e49f21e184927c7833881e399Richard Smith  DstArg->printPretty(OS, 0, getPrintingPolicy());
3417c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  OS << ") - ";
3418c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  OS << "strlen(";
3419d1420c6fa788669e49f21e184927c7833881e399Richard Smith  DstArg->printPretty(OS, 0, getPrintingPolicy());
3420c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  OS << ") - 1";
3421c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3422afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  Diag(SL, diag::note_strncat_wrong_size)
3423afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    << FixItHint::CreateReplacement(SR, OS.str());
3424c36bedc90c687caa71748480c60707ea4608b092Anna Zaks}
3425c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
342606de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===//
342706de276fff91264437fa75111ed76de43097e089Ted Kremenek
3428e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
3429e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                     Decl *ParentDecl);
3430e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars,
3431e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                      Decl *ParentDecl);
343206de276fff91264437fa75111ed76de43097e089Ted Kremenek
343306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address
343406de276fff91264437fa75111ed76de43097e089Ted Kremenek///   of a stack variable.
343506de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid
343606de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType,
343706de276fff91264437fa75111ed76de43097e089Ted Kremenek                           SourceLocation ReturnLoc) {
34381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
343926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  Expr *stackE = 0;
34405f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner  SmallVector<DeclRefExpr *, 8> refVars;
34414e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
344226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  // Perform checking for returned stack addresses, local blocks,
344326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  // label addresses or references to temporaries.
3444f85e193739c953358c865005855253af4f68a497John McCall  if (lhsType->isPointerType() ||
34454e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie      (!getLangOpts().ObjCAutoRefCount && lhsType->isBlockPointerType())) {
3446e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/0);
3447ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump  } else if (lhsType->isReferenceType()) {
3448e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    stackE = EvalVal(RetValExp, refVars, /*ParentDecl=*/0);
344926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  }
345026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
345126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  if (stackE == 0)
345226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    return; // Nothing suspicious was found.
345326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
345426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  SourceLocation diagLoc;
345526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  SourceRange diagRange;
345626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  if (refVars.empty()) {
345726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    diagLoc = stackE->getLocStart();
345826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    diagRange = stackE->getSourceRange();
345926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  } else {
346026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // We followed through a reference variable. 'stackE' contains the
346126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // problematic expression but we will warn at the return statement pointing
346226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // at the reference variable. We will later display the "trail" of
346326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // reference variables using notes.
346426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    diagLoc = refVars[0]->getLocStart();
346526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    diagRange = refVars[0]->getSourceRange();
346626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  }
346726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
346826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var.
346926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref
347026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis                                             : diag::warn_ret_stack_addr)
347126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis     << DR->getDecl()->getDeclName() << diagRange;
347226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  } else if (isa<BlockExpr>(stackE)) { // local block.
347326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(diagLoc, diag::err_ret_local_block) << diagRange;
347426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  } else if (isa<AddrLabelExpr>(stackE)) { // address of label.
347526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(diagLoc, diag::warn_ret_addr_label) << diagRange;
347626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  } else { // local temporary.
347726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref
347826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis                                             : diag::warn_ret_local_temp_addr)
347926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis     << diagRange;
348026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  }
348126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
348226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  // Display the "trail" of reference variables that we followed until we
348326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  // found the problematic expression using notes.
348426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  for (unsigned i = 0, e = refVars.size(); i != e; ++i) {
348526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl());
348626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // If this var binds to another reference var, show the range of the next
348726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // var, otherwise the var binds to the problematic expression, in which case
348826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // show the range of the expression.
348926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange()
349026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis                                  : stackE->getSourceRange();
349126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(VD->getLocation(), diag::note_ref_var_local_bind)
349226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      << VD->getDeclName() << range;
349306de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
349406de276fff91264437fa75111ed76de43097e089Ted Kremenek}
349506de276fff91264437fa75111ed76de43097e089Ted Kremenek
349606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that
349706de276fff91264437fa75111ed76de43097e089Ted Kremenek///  check if the expression in a return statement evaluates to an address
349826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  to a location on the stack, a local block, an address of a label, or a
349926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  reference to local temporary. The recursion is used to traverse the
350006de276fff91264437fa75111ed76de43097e089Ted Kremenek///  AST of the return expression, with recursion backtracking when we
350126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  encounter a subexpression that (1) clearly does not lead to one of the
350226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  above problematic expressions (2) is something we cannot determine leads to
350326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  a problematic expression based on such local checking.
350426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///
350526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  Both EvalAddr and EvalVal follow through reference variables to evaluate
350626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  the expression that they point to. Such variables are added to the
350726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  'refVars' vector so that we know what the reference variable "trail" was.
350806de276fff91264437fa75111ed76de43097e089Ted Kremenek///
3509e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek///  EvalAddr processes expressions that are pointers that are used as
3510e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek///  references (and not L-values).  EvalVal handles all other values.
351126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  At the base case of the recursion is a check for the above problematic
351226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  expressions.
351306de276fff91264437fa75111ed76de43097e089Ted Kremenek///
351406de276fff91264437fa75111ed76de43097e089Ted Kremenek///  This implementation handles:
351506de276fff91264437fa75111ed76de43097e089Ted Kremenek///
351606de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * pointer-to-pointer casts
351706de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * implicit conversions from array references to pointers
351806de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * taking the address of fields
351906de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * arbitrary interplay between "&" and "*" operators
352006de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * pointer arithmetic from an address of a stack variable
352106de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * taking the address of an array element where the array is on the stack
3522e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
3523e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                      Decl *ParentDecl) {
352426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  if (E->isTypeDependent())
352526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      return NULL;
352626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
352706de276fff91264437fa75111ed76de43097e089Ted Kremenek  // We should only be called for evaluating pointer expressions.
35280f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall  assert((E->getType()->isAnyPointerType() ||
3529dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff          E->getType()->isBlockPointerType() ||
3530a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek          E->getType()->isObjCQualifiedIdType()) &&
3531fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner         "EvalAddr only works on pointers");
35321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3533f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne  E = E->IgnoreParens();
3534f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne
353506de276fff91264437fa75111ed76de43097e089Ted Kremenek  // Our "symbolic interpreter" is just a dispatch off the currently
353606de276fff91264437fa75111ed76de43097e089Ted Kremenek  // viewed AST node.  We then recursively traverse the AST by calling
353706de276fff91264437fa75111ed76de43097e089Ted Kremenek  // EvalAddr and EvalVal appropriately.
353806de276fff91264437fa75111ed76de43097e089Ted Kremenek  switch (E->getStmtClass()) {
353926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  case Stmt::DeclRefExprClass: {
354026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    DeclRefExpr *DR = cast<DeclRefExpr>(E);
354126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
354226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
354326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      // If this is a reference variable, follow through to the expression that
354426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      // it points to.
354526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      if (V->hasLocalStorage() &&
354626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis          V->getType()->isReferenceType() && V->hasInit()) {
354726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        // Add the reference variable to the "trail".
354826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        refVars.push_back(DR);
3549e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis        return EvalAddr(V->getInit(), refVars, ParentDecl);
355026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      }
355126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
355226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    return NULL;
355326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  }
355406de276fff91264437fa75111ed76de43097e089Ted Kremenek
3555fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  case Stmt::UnaryOperatorClass: {
3556fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // The only unary operator that make sense to handle here
3557fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // is AddrOf.  All others don't make sense as pointers.
3558fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    UnaryOperator *U = cast<UnaryOperator>(E);
35591eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
35602de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    if (U->getOpcode() == UO_AddrOf)
3561e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      return EvalVal(U->getSubExpr(), refVars, ParentDecl);
3562fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    else
3563fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner      return NULL;
3564fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  }
35651eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3566fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  case Stmt::BinaryOperatorClass: {
3567fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // Handle pointer arithmetic.  All other binary operators are not valid
3568fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // in this context.
3569fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    BinaryOperator *B = cast<BinaryOperator>(E);
35702de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    BinaryOperatorKind op = B->getOpcode();
35711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
35722de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    if (op != BO_Add && op != BO_Sub)
3573fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner      return NULL;
35741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3575fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    Expr *Base = B->getLHS();
35763907323dd6665c0c4e383435cb145233f4533406Anders Carlsson
3577fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // Determine which argument is the real pointer base.  It could be
3578fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // the RHS argument instead of the LHS.
3579fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    if (!Base->getType()->isPointerType()) Base = B->getRHS();
35801eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3581fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    assert (Base->getType()->isPointerType());
3582e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalAddr(Base, refVars, ParentDecl);
3583fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  }
358461f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff
3585fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  // For conditional operators we need to see if either the LHS or RHS are
3586fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  // valid DeclRefExpr*s.  If one of them is valid, we return it.
3587fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  case Stmt::ConditionalOperatorClass: {
3588fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    ConditionalOperator *C = cast<ConditionalOperator>(E);
35891eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3590fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // Handle the GNU extension for missing LHS.
35919ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    if (Expr *lhsExpr = C->getLHS()) {
35929ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    // In C++, we can have a throw-expression, which has 'void' type.
35939ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor      if (!lhsExpr->getType()->isVoidType())
3594e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis        if (Expr* LHS = EvalAddr(lhsExpr, refVars, ParentDecl))
35959ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor          return LHS;
35969ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    }
35979ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor
35989ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    // In C++, we can have a throw-expression, which has 'void' type.
35999ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    if (C->getRHS()->getType()->isVoidType())
36009ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor      return NULL;
360106de276fff91264437fa75111ed76de43097e089Ted Kremenek
3602e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalAddr(C->getRHS(), refVars, ParentDecl);
3603fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  }
360426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
360526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  case Stmt::BlockExprClass:
3606469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall    if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures())
360726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      return E; // local block.
360826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    return NULL;
360926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
361026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  case Stmt::AddrLabelExprClass:
361126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    return E; // address of label.
36121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
361380ee6e878a169e6255d4686a91bb696151ff229fJohn McCall  case Stmt::ExprWithCleanupsClass:
3614e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,
3615e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                    ParentDecl);
361680ee6e878a169e6255d4686a91bb696151ff229fJohn McCall
361754b5274f2c190331438375ad114dad12ae098b57Ted Kremenek  // For casts, we need to handle conversions from arrays to
361854b5274f2c190331438375ad114dad12ae098b57Ted Kremenek  // pointer values, and pointer-to-pointer conversions.
361949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor  case Stmt::ImplicitCastExprClass:
36206eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor  case Stmt::CStyleCastExprClass:
3621f85e193739c953358c865005855253af4f68a497John McCall  case Stmt::CXXFunctionalCastExprClass:
36228b9414e868853fc052251455674bf7512261e14aEli Friedman  case Stmt::ObjCBridgedCastExprClass:
36231eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  case Stmt::CXXStaticCastExprClass:
36241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  case Stmt::CXXDynamicCastExprClass:
362549badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor  case Stmt::CXXConstCastExprClass:
362649badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor  case Stmt::CXXReinterpretCastExprClass: {
36278b9414e868853fc052251455674bf7512261e14aEli Friedman    Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
36288b9414e868853fc052251455674bf7512261e14aEli Friedman    switch (cast<CastExpr>(E)->getCastKind()) {
36298b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_BitCast:
36308b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_LValueToRValue:
36318b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_NoOp:
36328b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_BaseToDerived:
36338b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_DerivedToBase:
36348b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_UncheckedDerivedToBase:
36358b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_Dynamic:
36368b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_CPointerToObjCPointerCast:
36378b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_BlockPointerToObjCPointerCast:
36388b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_AnyPointerToBlockPointerCast:
3639e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      return EvalAddr(SubExpr, refVars, ParentDecl);
36408b9414e868853fc052251455674bf7512261e14aEli Friedman
36418b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_ArrayToPointerDecay:
3642e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      return EvalVal(SubExpr, refVars, ParentDecl);
36438b9414e868853fc052251455674bf7512261e14aEli Friedman
36448b9414e868853fc052251455674bf7512261e14aEli Friedman    default:
36458b9414e868853fc052251455674bf7512261e14aEli Friedman      return 0;
36468b9414e868853fc052251455674bf7512261e14aEli Friedman    }
3647fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  }
36481eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
364903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor  case Stmt::MaterializeTemporaryExprClass:
365003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor    if (Expr *Result = EvalAddr(
365103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor                         cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(),
3652e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                                refVars, ParentDecl))
365303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor      return Result;
365403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor
365503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor    return E;
365603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor
3657fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  // Everything else: we simply don't reason about them.
3658fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  default:
3659fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    return NULL;
366006de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
366106de276fff91264437fa75111ed76de43097e089Ted Kremenek}
36621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
366306de276fff91264437fa75111ed76de43097e089Ted Kremenek
366406de276fff91264437fa75111ed76de43097e089Ted Kremenek///  EvalVal - This function is complements EvalAddr in the mutual recursion.
366506de276fff91264437fa75111ed76de43097e089Ted Kremenek///   See the comments for EvalAddr for more details.
3666e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
3667e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                     Decl *ParentDecl) {
366868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo {
3669e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek  // We should only be called for evaluating non-pointer expressions, or
3670e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek  // expressions with a pointer type that are not used as references but instead
3671e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek  // are l-values (e.g., DeclRefExpr with a pointer type).
36721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
367306de276fff91264437fa75111ed76de43097e089Ted Kremenek  // Our "symbolic interpreter" is just a dispatch off the currently
367406de276fff91264437fa75111ed76de43097e089Ted Kremenek  // viewed AST node.  We then recursively traverse the AST by calling
367506de276fff91264437fa75111ed76de43097e089Ted Kremenek  // EvalAddr and EvalVal appropriately.
3676f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne
3677f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne  E = E->IgnoreParens();
367806de276fff91264437fa75111ed76de43097e089Ted Kremenek  switch (E->getStmtClass()) {
367968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek  case Stmt::ImplicitCastExprClass: {
368068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek    ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E);
36815baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall    if (IE->getValueKind() == VK_LValue) {
368268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek      E = IE->getSubExpr();
368368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek      continue;
368468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek    }
368568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek    return NULL;
368668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek  }
368768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek
368880ee6e878a169e6255d4686a91bb696151ff229fJohn McCall  case Stmt::ExprWithCleanupsClass:
3689e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,ParentDecl);
369080ee6e878a169e6255d4686a91bb696151ff229fJohn McCall
3691a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor  case Stmt::DeclRefExprClass: {
369226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // When we hit a DeclRefExpr we are looking at code that refers to a
369326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // variable's name. If it's not a reference variable we check if it has
369426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // local storage within the function, and if so, return the expression.
369506de276fff91264437fa75111ed76de43097e089Ted Kremenek    DeclRefExpr *DR = cast<DeclRefExpr>(E);
36961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3697e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) {
3698e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      // Check if it refers to itself, e.g. "int& i = i;".
3699e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      if (V == ParentDecl)
3700e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis        return DR;
3701e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis
370226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      if (V->hasLocalStorage()) {
370326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        if (!V->getType()->isReferenceType())
370426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis          return DR;
370526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
370626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        // Reference variable, follow through to the expression that
370726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        // it points to.
370826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        if (V->hasInit()) {
370926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis          // Add the reference variable to the "trail".
371026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis          refVars.push_back(DR);
3711e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis          return EvalVal(V->getInit(), refVars, V);
371226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        }
371326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      }
3714e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    }
37151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
371606de276fff91264437fa75111ed76de43097e089Ted Kremenek    return NULL;
371706de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
37181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
371906de276fff91264437fa75111ed76de43097e089Ted Kremenek  case Stmt::UnaryOperatorClass: {
372006de276fff91264437fa75111ed76de43097e089Ted Kremenek    // The only unary operator that make sense to handle here
372106de276fff91264437fa75111ed76de43097e089Ted Kremenek    // is Deref.  All others don't resolve to a "name."  This includes
372206de276fff91264437fa75111ed76de43097e089Ted Kremenek    // handling all sorts of rvalues passed to a unary operator.
372306de276fff91264437fa75111ed76de43097e089Ted Kremenek    UnaryOperator *U = cast<UnaryOperator>(E);
37241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
37252de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    if (U->getOpcode() == UO_Deref)
3726e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      return EvalAddr(U->getSubExpr(), refVars, ParentDecl);
372706de276fff91264437fa75111ed76de43097e089Ted Kremenek
372806de276fff91264437fa75111ed76de43097e089Ted Kremenek    return NULL;
372906de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
37301eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
373106de276fff91264437fa75111ed76de43097e089Ted Kremenek  case Stmt::ArraySubscriptExprClass: {
373206de276fff91264437fa75111ed76de43097e089Ted Kremenek    // Array subscripts are potential references to data on the stack.  We
373306de276fff91264437fa75111ed76de43097e089Ted Kremenek    // retrieve the DeclRefExpr* for the array variable if it indeed
373406de276fff91264437fa75111ed76de43097e089Ted Kremenek    // has local storage.
3735e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars,ParentDecl);
373606de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
37371eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
373806de276fff91264437fa75111ed76de43097e089Ted Kremenek  case Stmt::ConditionalOperatorClass: {
373906de276fff91264437fa75111ed76de43097e089Ted Kremenek    // For conditional operators we need to see if either the LHS or RHS are
374026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // non-NULL Expr's.  If one is non-NULL, we return it.
374106de276fff91264437fa75111ed76de43097e089Ted Kremenek    ConditionalOperator *C = cast<ConditionalOperator>(E);
374206de276fff91264437fa75111ed76de43097e089Ted Kremenek
37433907323dd6665c0c4e383435cb145233f4533406Anders Carlsson    // Handle the GNU extension for missing LHS.
37443907323dd6665c0c4e383435cb145233f4533406Anders Carlsson    if (Expr *lhsExpr = C->getLHS())
3745e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      if (Expr *LHS = EvalVal(lhsExpr, refVars, ParentDecl))
37463907323dd6665c0c4e383435cb145233f4533406Anders Carlsson        return LHS;
37473907323dd6665c0c4e383435cb145233f4533406Anders Carlsson
3748e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalVal(C->getRHS(), refVars, ParentDecl);
374906de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
37501eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
375106de276fff91264437fa75111ed76de43097e089Ted Kremenek  // Accesses to members are potential references to data on the stack.
375283f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor  case Stmt::MemberExprClass: {
375306de276fff91264437fa75111ed76de43097e089Ted Kremenek    MemberExpr *M = cast<MemberExpr>(E);
37541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
375506de276fff91264437fa75111ed76de43097e089Ted Kremenek    // Check for indirect access.  We only want direct field accesses.
3756a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek    if (M->isArrow())
3757a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek      return NULL;
3758a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek
3759a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek    // Check whether the member type is itself a reference, in which case
3760a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek    // we're not going to refer to the member, but to what the member refers to.
3761a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek    if (M->getMemberDecl()->getType()->isReferenceType())
376206de276fff91264437fa75111ed76de43097e089Ted Kremenek      return NULL;
3763a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek
3764e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalVal(M->getBase(), refVars, ParentDecl);
376506de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
37661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
376703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor  case Stmt::MaterializeTemporaryExprClass:
376803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor    if (Expr *Result = EvalVal(
376903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor                          cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(),
3770e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                               refVars, ParentDecl))
377103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor      return Result;
377203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor
377303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor    return E;
377403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor
377506de276fff91264437fa75111ed76de43097e089Ted Kremenek  default:
377626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // Check that we don't return or take the address of a reference to a
377726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // temporary. This is only useful in C++.
377826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    if (!E->isTypeDependent() && E->isRValue())
377926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      return E;
378026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
378126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // Everything else: we simply don't reason about them.
378206de276fff91264437fa75111ed76de43097e089Ted Kremenek    return NULL;
378306de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
378468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true);
378506de276fff91264437fa75111ed76de43097e089Ted Kremenek}
3786588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek
3787588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===//
3788588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek
3789588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==.
3790588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely
3791588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended.
3792dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieuvoid Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) {
3793dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts();
3794dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  Expr* RightExprSansParen = RHS->IgnoreParenImpCasts();
3795588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek
3796588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  // Special case: check for x == x (which is OK).
3797588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  // Do not emit warnings for such cases.
3798588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen))
3799588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek    if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen))
3800588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek      if (DRL->getDecl() == DRR->getDecl())
3801980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie        return;
38021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
38031eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
38041b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  // Special case: check for comparisons against literals that can be exactly
38051b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  //  represented by APFloat.  In such cases, do not emit a warning.  This
38061b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  //  is a heuristic: often comparison against such literals are used to
38071b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  //  detect if a value in a variable has not changed.  This clearly can
38081b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  //  lead to false negatives.
3809980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) {
3810980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    if (FLL->isExact())
3811980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie      return;
3812980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  } else
3813980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen))
3814980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie      if (FLR->isExact())
3815980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie        return;
38161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3817588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  // Check for comparisons with builtin types.
3818980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen))
3819980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    if (CL->isBuiltinCall())
3820980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie      return;
38211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3822980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen))
3823980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    if (CR->isBuiltinCall())
3824980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie      return;
38251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3826588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  // Emit the diagnostic.
3827980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  Diag(Loc, diag::warn_floatingpoint_eq)
3828980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    << LHS->getSourceRange() << RHS->getSourceRange();
3829588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek}
3830ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
3831f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===//
3832f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===//
3833ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
3834f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace {
3835ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
3836f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued
3837f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression.
3838f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange {
3839f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  /// The number of bits active in the int.
3840f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  unsigned Width;
3841ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
3842f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  /// True if the int is known not to have negative values.
3843f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  bool NonNegative;
384451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3845f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  IntRange(unsigned Width, bool NonNegative)
3846f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    : Width(Width), NonNegative(NonNegative)
3847f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  {}
384851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
38491844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the range of the bool type.
3850f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  static IntRange forBoolType() {
3851f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(1, true);
3852f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  }
385351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
38541844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the range of an opaque value of the given integral type.
38551844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  static IntRange forValueOfType(ASTContext &C, QualType T) {
38561844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    return forValueOfCanonicalType(C,
38571844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall                          T->getCanonicalTypeInternal().getTypePtr());
385851313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
385951313c39c84407dd6a323be99a8c322bf8d052a9John McCall
38601844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the range of an opaque value of a canonical integral type.
38611844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) {
3862f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    assert(T->isCanonicalUnqualified());
386351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3864f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    if (const VectorType *VT = dyn_cast<VectorType>(T))
3865f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      T = VT->getElementType().getTypePtr();
3866f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    if (const ComplexType *CT = dyn_cast<ComplexType>(T))
3867f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      T = CT->getElementType().getTypePtr();
3868323ed74658bc8375278eabf074b4777458376540John McCall
3869091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    // For enum types, use the known bit width of the enumerators.
3870323ed74658bc8375278eabf074b4777458376540John McCall    if (const EnumType *ET = dyn_cast<EnumType>(T)) {
3871323ed74658bc8375278eabf074b4777458376540John McCall      EnumDecl *Enum = ET->getDecl();
38725e1cdac63c3d9c9b32fa41fa0b2d242a58a20d49John McCall      if (!Enum->isCompleteDefinition())
3873091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall        return IntRange(C.getIntWidth(QualType(T, 0)), false);
3874091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall
3875323ed74658bc8375278eabf074b4777458376540John McCall      unsigned NumPositive = Enum->getNumPositiveBits();
3876323ed74658bc8375278eabf074b4777458376540John McCall      unsigned NumNegative = Enum->getNumNegativeBits();
3877323ed74658bc8375278eabf074b4777458376540John McCall
3878323ed74658bc8375278eabf074b4777458376540John McCall      return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0);
3879323ed74658bc8375278eabf074b4777458376540John McCall    }
388051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3881f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    const BuiltinType *BT = cast<BuiltinType>(T);
3882f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    assert(BT->isInteger());
388351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3884f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
388551313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
388651313c39c84407dd6a323be99a8c322bf8d052a9John McCall
38871844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the "target" range of a canonical integral type, i.e.
38881844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// the range of values expressible in the type.
38891844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  ///
38901844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// This matches forValueOfCanonicalType except that enums have the
38911844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// full range of their type, not the range of their enumerators.
38921844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) {
38931844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    assert(T->isCanonicalUnqualified());
38941844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall
38951844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    if (const VectorType *VT = dyn_cast<VectorType>(T))
38961844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      T = VT->getElementType().getTypePtr();
38971844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    if (const ComplexType *CT = dyn_cast<ComplexType>(T))
38981844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      T = CT->getElementType().getTypePtr();
38991844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    if (const EnumType *ET = dyn_cast<EnumType>(T))
390069ff26bd1e7a2faffec0c3b9740cfb0c6bb354c5Douglas Gregor      T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr();
39011844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall
39021844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    const BuiltinType *BT = cast<BuiltinType>(T);
39031844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    assert(BT->isInteger());
39041844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall
39051844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
39061844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  }
39071844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall
39081844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the supremum of two ranges: i.e. their conservative merge.
3909c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall  static IntRange join(IntRange L, IntRange R) {
3910f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(std::max(L.Width, R.Width),
391160fad45739b764886f707bd204eae9ecce6db1f2John McCall                    L.NonNegative && R.NonNegative);
391260fad45739b764886f707bd204eae9ecce6db1f2John McCall  }
391360fad45739b764886f707bd204eae9ecce6db1f2John McCall
39141844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the infinum of two ranges: i.e. their aggressive merge.
3915c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall  static IntRange meet(IntRange L, IntRange R) {
391660fad45739b764886f707bd204eae9ecce6db1f2John McCall    return IntRange(std::min(L.Width, R.Width),
391760fad45739b764886f707bd204eae9ecce6db1f2John McCall                    L.NonNegative || R.NonNegative);
391851313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
3919f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall};
392051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
39210692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, llvm::APSInt &value,
39220692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                              unsigned MaxWidth) {
3923f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (value.isSigned() && value.isNegative())
3924f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(value.getMinSignedBits(), false);
392551313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3926f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (value.getBitWidth() > MaxWidth)
39279f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad    value = value.trunc(MaxWidth);
392851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3929f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // isNonNegative() just checks the sign bit without considering
3930f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // signedness.
3931f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  return IntRange(value.getActiveBits(), true);
393251313c39c84407dd6a323be99a8c322bf8d052a9John McCall}
393351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
39340692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty,
39350692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                              unsigned MaxWidth) {
3936f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (result.isInt())
3937f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return GetValueRange(C, result.getInt(), MaxWidth);
393851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3939f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (result.isVector()) {
39400acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall    IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth);
39410acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall    for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) {
39420acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall      IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth);
39430acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall      R = IntRange::join(R, El);
39440acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall    }
3945f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return R;
394651313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
394751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3948f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (result.isComplexInt()) {
3949f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth);
3950f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth);
3951f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange::join(R, I);
3952f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  }
3953f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
3954f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // This can happen with lossless casts to intptr_t of "based" lvalues.
3955f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // Assume it might use arbitrary bits.
39560acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall  // FIXME: The only reason we need to pass the type in here is to get
39570acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall  // the sign right on this one case.  It would be nice if APValue
39580acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall  // preserved this.
395965639284118d54ddf2e51a05d2ffccda567fe246Eli Friedman  assert(result.isLValue() || result.isAddrLabelDiff());
39605e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor  return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType());
396151313c39c84407dd6a323be99a8c322bf8d052a9John McCall}
396251313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3963f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the
3964f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take.
3965f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall///
3966f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated
39670692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) {
396851313c39c84407dd6a323be99a8c322bf8d052a9John McCall  E = E->IgnoreParens();
396951313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3970f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // Try a full evaluation first.
3971f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  Expr::EvalResult result;
397251f4708c00110940ca3f337961915f2ca1668375Richard Smith  if (E->EvaluateAsRValue(result, C))
39730acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall    return GetValueRange(C, result.Val, E->getType(), MaxWidth);
397451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3975f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // I think we only want to look through implicit casts here; if the
3976f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // user has an explicit widening cast, we should treat the value as
3977f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // being of the new, wider type.
3978f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) {
3979b17ee5bff0d7986c14cdddb279e0131bd7f9678dEli Friedman    if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue)
3980f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return GetExprRange(C, CE->getSubExpr(), MaxWidth);
398151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
39821844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType());
398351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
39842de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast);
398560fad45739b764886f707bd204eae9ecce6db1f2John McCall
3986f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Assume that non-integer casts can span the full range of the type.
398760fad45739b764886f707bd204eae9ecce6db1f2John McCall    if (!isIntegerCast)
3988f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return OutputTypeRange;
398951313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3990f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange SubRange
3991f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      = GetExprRange(C, CE->getSubExpr(),
3992f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall                     std::min(MaxWidth, OutputTypeRange.Width));
399351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3994f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Bail out if the subexpr's range is as wide as the cast type.
3995f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    if (SubRange.Width >= OutputTypeRange.Width)
3996f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return OutputTypeRange;
399751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3998f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Otherwise, we take the smaller width, and we're non-negative if
3999f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // either the output type or the subexpr is.
4000f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(SubRange.Width,
4001f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall                    SubRange.NonNegative || OutputTypeRange.NonNegative);
4002f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  }
4003f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4004f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
4005f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // If we can fold the condition, just take that operand.
4006f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    bool CondResult;
4007f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C))
4008f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return GetExprRange(C, CondResult ? CO->getTrueExpr()
4009f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall                                        : CO->getFalseExpr(),
4010f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall                          MaxWidth);
4011f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4012f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Otherwise, conservatively merge.
4013f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth);
4014f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth);
4015f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange::join(L, R);
401651313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
401751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
401851313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
401951313c39c84407dd6a323be99a8c322bf8d052a9John McCall    switch (BO->getOpcode()) {
402051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4021f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Boolean-valued operations are single-bit and positive.
40222de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_LAnd:
40232de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_LOr:
40242de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_LT:
40252de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_GT:
40262de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_LE:
40272de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_GE:
40282de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_EQ:
40292de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_NE:
4030f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return IntRange::forBoolType();
403151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4032862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    // The type of the assignments is the type of the LHS, so the RHS
4033862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    // is not necessarily the same type.
40342de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_MulAssign:
40352de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_DivAssign:
40362de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_RemAssign:
40372de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_AddAssign:
40382de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_SubAssign:
4039862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    case BO_XorAssign:
4040862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    case BO_OrAssign:
4041862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall      // TODO: bitfields?
40421844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      return IntRange::forValueOfType(C, E->getType());
4043c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall
4044862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    // Simple assignments just pass through the RHS, which will have
4045862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    // been coerced to the LHS type.
4046862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    case BO_Assign:
4047862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall      // TODO: bitfields?
4048862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall      return GetExprRange(C, BO->getRHS(), MaxWidth);
4049862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall
405051313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // Operations with opaque sources are black-listed.
40512de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_PtrMemD:
40522de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_PtrMemI:
40531844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      return IntRange::forValueOfType(C, E->getType());
405451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
405560fad45739b764886f707bd204eae9ecce6db1f2John McCall    // Bitwise-and uses the *infinum* of the two source ranges.
40562de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_And:
40572de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_AndAssign:
405860fad45739b764886f707bd204eae9ecce6db1f2John McCall      return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth),
405960fad45739b764886f707bd204eae9ecce6db1f2John McCall                            GetExprRange(C, BO->getRHS(), MaxWidth));
406060fad45739b764886f707bd204eae9ecce6db1f2John McCall
406151313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // Left shift gets black-listed based on a judgement call.
40622de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_Shl:
40633aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      // ...except that we want to treat '1 << (blah)' as logically
40643aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      // positive.  It's an important idiom.
40653aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      if (IntegerLiteral *I
40663aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall            = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) {
40673aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall        if (I->getValue() == 1) {
40681844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall          IntRange R = IntRange::forValueOfType(C, E->getType());
40693aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall          return IntRange(R.Width, /*NonNegative*/ true);
40703aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall        }
40713aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      }
40723aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      // fallthrough
40733aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall
40742de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_ShlAssign:
40751844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      return IntRange::forValueOfType(C, E->getType());
407651313c39c84407dd6a323be99a8c322bf8d052a9John McCall
407760fad45739b764886f707bd204eae9ecce6db1f2John McCall    // Right shift by a constant can narrow its left argument.
40782de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_Shr:
40792de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_ShrAssign: {
408060fad45739b764886f707bd204eae9ecce6db1f2John McCall      IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
408160fad45739b764886f707bd204eae9ecce6db1f2John McCall
408260fad45739b764886f707bd204eae9ecce6db1f2John McCall      // If the shift amount is a positive constant, drop the width by
408360fad45739b764886f707bd204eae9ecce6db1f2John McCall      // that much.
408460fad45739b764886f707bd204eae9ecce6db1f2John McCall      llvm::APSInt shift;
408560fad45739b764886f707bd204eae9ecce6db1f2John McCall      if (BO->getRHS()->isIntegerConstantExpr(shift, C) &&
408660fad45739b764886f707bd204eae9ecce6db1f2John McCall          shift.isNonNegative()) {
408760fad45739b764886f707bd204eae9ecce6db1f2John McCall        unsigned zext = shift.getZExtValue();
408860fad45739b764886f707bd204eae9ecce6db1f2John McCall        if (zext >= L.Width)
408960fad45739b764886f707bd204eae9ecce6db1f2John McCall          L.Width = (L.NonNegative ? 0 : 1);
409060fad45739b764886f707bd204eae9ecce6db1f2John McCall        else
409160fad45739b764886f707bd204eae9ecce6db1f2John McCall          L.Width -= zext;
409260fad45739b764886f707bd204eae9ecce6db1f2John McCall      }
409360fad45739b764886f707bd204eae9ecce6db1f2John McCall
409460fad45739b764886f707bd204eae9ecce6db1f2John McCall      return L;
409560fad45739b764886f707bd204eae9ecce6db1f2John McCall    }
409660fad45739b764886f707bd204eae9ecce6db1f2John McCall
409760fad45739b764886f707bd204eae9ecce6db1f2John McCall    // Comma acts as its right operand.
40982de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_Comma:
4099f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return GetExprRange(C, BO->getRHS(), MaxWidth);
4100f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
410160fad45739b764886f707bd204eae9ecce6db1f2John McCall    // Black-list pointer subtractions.
41022de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_Sub:
410351313c39c84407dd6a323be99a8c322bf8d052a9John McCall      if (BO->getLHS()->getType()->isPointerType())
41041844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall        return IntRange::forValueOfType(C, E->getType());
410500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      break;
410600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
410700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // The width of a division result is mostly determined by the size
410800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // of the LHS.
410900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Div: {
411000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      // Don't 'pre-truncate' the operands.
411100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      unsigned opWidth = C.getIntWidth(E->getType());
411200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange L = GetExprRange(C, BO->getLHS(), opWidth);
411300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
411400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      // If the divisor is constant, use that.
411500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      llvm::APSInt divisor;
411600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) {
411700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall        unsigned log2 = divisor.logBase2(); // floor(log_2(divisor))
411800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall        if (log2 >= L.Width)
411900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall          L.Width = (L.NonNegative ? 0 : 1);
412000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall        else
412100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall          L.Width = std::min(L.Width - log2, MaxWidth);
412200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall        return L;
412300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      }
412400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
412500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      // Otherwise, just use the LHS's width.
412600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange R = GetExprRange(C, BO->getRHS(), opWidth);
412700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      return IntRange(L.Width, L.NonNegative && R.NonNegative);
412800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    }
412900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
413000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // The result of a remainder can't be larger than the result of
413100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // either side.
413200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Rem: {
413300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      // Don't 'pre-truncate' the operands.
413400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      unsigned opWidth = C.getIntWidth(E->getType());
413500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange L = GetExprRange(C, BO->getLHS(), opWidth);
413600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange R = GetExprRange(C, BO->getRHS(), opWidth);
413700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
413800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange meet = IntRange::meet(L, R);
413900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      meet.Width = std::min(meet.Width, MaxWidth);
414000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      return meet;
414100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    }
41424e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
414300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // The default behavior is okay for these.
414400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Mul:
414500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Add:
414600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Xor:
414700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Or:
4148f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      break;
414951313c39c84407dd6a323be99a8c322bf8d052a9John McCall    }
4150f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
415100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // The default case is to treat the operation as if it were closed
415200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // on the narrowest type that encompasses both operands.
4153f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
4154f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth);
4155f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange::join(L, R);
415651313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
415751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
415851313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
415951313c39c84407dd6a323be99a8c322bf8d052a9John McCall    switch (UO->getOpcode()) {
416051313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // Boolean-valued operations are white-listed.
41612de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case UO_LNot:
4162f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return IntRange::forBoolType();
416351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
416451313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // Operations with opaque sources are black-listed.
41652de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case UO_Deref:
41662de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case UO_AddrOf: // should be impossible
41671844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      return IntRange::forValueOfType(C, E->getType());
416851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
416951313c39c84407dd6a323be99a8c322bf8d052a9John McCall    default:
4170f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return GetExprRange(C, UO->getSubExpr(), MaxWidth);
417151313c39c84407dd6a323be99a8c322bf8d052a9John McCall    }
417251313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
41738ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor
41748ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor  if (dyn_cast<OffsetOfExpr>(E)) {
41751844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    IntRange::forValueOfType(C, E->getType());
41768ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor  }
417751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4178a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith  if (FieldDecl *BitField = E->getBitField())
4179a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith    return IntRange(BitField->getBitWidthValue(C),
41805e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor                    BitField->getType()->isUnsignedIntegerOrEnumerationType());
4181f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
41821844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  return IntRange::forValueOfType(C, E->getType());
4183f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}
4184f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
41850692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E) {
4186323ed74658bc8375278eabf074b4777458376540John McCall  return GetExprRange(C, E, C.getIntWidth(E->getType()));
4187323ed74658bc8375278eabf074b4777458376540John McCall}
4188323ed74658bc8375278eabf074b4777458376540John McCall
4189f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given
4190f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the
4191f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics.
41920692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const llvm::APFloat &value,
41930692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                 const llvm::fltSemantics &Src,
41940692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                 const llvm::fltSemantics &Tgt) {
4195f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  llvm::APFloat truncated = value;
4196f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4197f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  bool ignored;
4198f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored);
4199f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored);
4200f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4201f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  return truncated.bitwiseIsEqual(value);
420251313c39c84407dd6a323be99a8c322bf8d052a9John McCall}
420351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4204f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given
4205f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the
4206f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics.
4207f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall///
4208f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number).
42090692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const APValue &value,
42100692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                 const llvm::fltSemantics &Src,
42110692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                 const llvm::fltSemantics &Tgt) {
4212f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (value.isFloat())
4213f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IsSameFloatAfterCast(value.getFloat(), Src, Tgt);
4214f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4215f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (value.isVector()) {
4216f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i)
4217f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt))
4218f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall        return false;
4219f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return true;
4220f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  }
4221f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4222f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  assert(value.isComplexFloat());
4223f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) &&
4224f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall          IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt));
4225f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}
4226f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
42270692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC);
4228323ed74658bc8375278eabf074b4777458376540John McCall
4229e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) {
4230e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek  // Suppress cases where we are comparing against an enum constant.
4231e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek  if (const DeclRefExpr *DR =
4232e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek      dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts()))
4233e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek    if (isa<EnumConstantDecl>(DR->getDecl()))
4234e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek      return false;
4235e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek
4236e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek  // Suppress cases where the '0' value is expanded from a macro.
4237e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek  if (E->getLocStart().isMacroID())
4238e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek    return false;
4239e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek
4240323ed74658bc8375278eabf074b4777458376540John McCall  llvm::APSInt Value;
4241323ed74658bc8375278eabf074b4777458376540John McCall  return E->isIntegerConstantExpr(Value, S.Context) && Value == 0;
4242323ed74658bc8375278eabf074b4777458376540John McCall}
4243323ed74658bc8375278eabf074b4777458376540John McCall
4244372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) {
4245372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall  // Strip off implicit integral promotions.
4246372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall  while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) {
424763b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis    if (ICE->getCastKind() != CK_IntegralCast &&
424863b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis        ICE->getCastKind() != CK_NoOp)
4249372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      break;
425063b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis    E = ICE->getSubExpr();
4251372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall  }
4252372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall
4253372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall  return E->getType()->isEnumeralType();
4254372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall}
4255372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall
42560692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) {
42572de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  BinaryOperatorKind op = E->getOpcode();
425814af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor  if (E->isValueDependent())
425914af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor    return;
426014af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor
42612de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  if (op == BO_LT && IsZero(S, E->getRHS())) {
4262323ed74658bc8375278eabf074b4777458376540John McCall    S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
4263372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      << "< 0" << "false" << HasEnumType(E->getLHS())
4264323ed74658bc8375278eabf074b4777458376540John McCall      << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
42652de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  } else if (op == BO_GE && IsZero(S, E->getRHS())) {
4266323ed74658bc8375278eabf074b4777458376540John McCall    S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
4267372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      << ">= 0" << "true" << HasEnumType(E->getLHS())
4268323ed74658bc8375278eabf074b4777458376540John McCall      << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
42692de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  } else if (op == BO_GT && IsZero(S, E->getLHS())) {
4270323ed74658bc8375278eabf074b4777458376540John McCall    S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
4271372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      << "0 >" << "false" << HasEnumType(E->getRHS())
4272323ed74658bc8375278eabf074b4777458376540John McCall      << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
42732de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  } else if (op == BO_LE && IsZero(S, E->getLHS())) {
4274323ed74658bc8375278eabf074b4777458376540John McCall    S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
4275372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      << "0 <=" << "true" << HasEnumType(E->getRHS())
4276323ed74658bc8375278eabf074b4777458376540John McCall      << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
4277323ed74658bc8375278eabf074b4777458376540John McCall  }
4278323ed74658bc8375278eabf074b4777458376540John McCall}
4279323ed74658bc8375278eabf074b4777458376540John McCall
4280323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison.  Implements the
4281323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison.
42820692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) {
4283b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc());
4284b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc());
4285323ed74658bc8375278eabf074b4777458376540John McCall}
4286f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4287ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare.
4288ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall///
4289dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu/// \param E the binary operator to check for warnings
42900692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeComparison(Sema &S, BinaryOperator *E) {
4291323ed74658bc8375278eabf074b4777458376540John McCall  // The type the comparison is being performed in.
4292323ed74658bc8375278eabf074b4777458376540John McCall  QualType T = E->getLHS()->getType();
4293323ed74658bc8375278eabf074b4777458376540John McCall  assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType())
4294323ed74658bc8375278eabf074b4777458376540John McCall         && "comparison with mismatched types");
4295323ed74658bc8375278eabf074b4777458376540John McCall
4296323ed74658bc8375278eabf074b4777458376540John McCall  // We don't do anything special if this isn't an unsigned integral
4297323ed74658bc8375278eabf074b4777458376540John McCall  // comparison:  we're only interested in integral comparisons, and
4298323ed74658bc8375278eabf074b4777458376540John McCall  // signed comparisons only happen in cases we don't care to warn about.
42993e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor  //
43003e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor  // We also don't care about value-dependent expressions or expressions
43013e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor  // whose result is a constant.
43023e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor  if (!T->hasUnsignedIntegerRepresentation()
43033e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor      || E->isValueDependent() || E->isIntegerConstantExpr(S.Context))
4304323ed74658bc8375278eabf074b4777458376540John McCall    return AnalyzeImpConvsInComparison(S, E);
4305323ed74658bc8375278eabf074b4777458376540John McCall
4306dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  Expr *LHS = E->getLHS()->IgnoreParenImpCasts();
4307dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  Expr *RHS = E->getRHS()->IgnoreParenImpCasts();
4308323ed74658bc8375278eabf074b4777458376540John McCall
4309323ed74658bc8375278eabf074b4777458376540John McCall  // Check to see if one of the (unmodified) operands is of different
4310323ed74658bc8375278eabf074b4777458376540John McCall  // signedness.
4311323ed74658bc8375278eabf074b4777458376540John McCall  Expr *signedOperand, *unsignedOperand;
4312dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  if (LHS->getType()->hasSignedIntegerRepresentation()) {
4313dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    assert(!RHS->getType()->hasSignedIntegerRepresentation() &&
4314323ed74658bc8375278eabf074b4777458376540John McCall           "unsigned comparison between two signed integer expressions?");
4315dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    signedOperand = LHS;
4316dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    unsignedOperand = RHS;
4317dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  } else if (RHS->getType()->hasSignedIntegerRepresentation()) {
4318dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    signedOperand = RHS;
4319dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    unsignedOperand = LHS;
4320ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  } else {
4321323ed74658bc8375278eabf074b4777458376540John McCall    CheckTrivialUnsignedComparison(S, E);
4322323ed74658bc8375278eabf074b4777458376540John McCall    return AnalyzeImpConvsInComparison(S, E);
4323ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  }
4324ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
4325323ed74658bc8375278eabf074b4777458376540John McCall  // Otherwise, calculate the effective range of the signed operand.
4326323ed74658bc8375278eabf074b4777458376540John McCall  IntRange signedRange = GetExprRange(S.Context, signedOperand);
4327f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4328323ed74658bc8375278eabf074b4777458376540John McCall  // Go ahead and analyze implicit conversions in the operands.  Note
4329323ed74658bc8375278eabf074b4777458376540John McCall  // that we skip the implicit conversions on both sides.
4330dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc());
4331dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc());
4332ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
4333323ed74658bc8375278eabf074b4777458376540John McCall  // If the signed range is non-negative, -Wsign-compare won't fire,
4334323ed74658bc8375278eabf074b4777458376540John McCall  // but we should still check for comparisons which are always true
4335323ed74658bc8375278eabf074b4777458376540John McCall  // or false.
4336323ed74658bc8375278eabf074b4777458376540John McCall  if (signedRange.NonNegative)
4337323ed74658bc8375278eabf074b4777458376540John McCall    return CheckTrivialUnsignedComparison(S, E);
4338ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
4339ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  // For (in)equality comparisons, if the unsigned operand is a
4340ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  // constant which cannot collide with a overflowed signed operand,
4341ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  // then reinterpreting the signed operand as unsigned will not
4342ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  // change the result of the comparison.
4343323ed74658bc8375278eabf074b4777458376540John McCall  if (E->isEqualityOp()) {
4344323ed74658bc8375278eabf074b4777458376540John McCall    unsigned comparisonWidth = S.Context.getIntWidth(T);
4345323ed74658bc8375278eabf074b4777458376540John McCall    IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand);
4346323ed74658bc8375278eabf074b4777458376540John McCall
4347323ed74658bc8375278eabf074b4777458376540John McCall    // We should never be unable to prove that the unsigned operand is
4348323ed74658bc8375278eabf074b4777458376540John McCall    // non-negative.
4349323ed74658bc8375278eabf074b4777458376540John McCall    assert(unsignedRange.NonNegative && "unsigned range includes negative?");
4350ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
4351323ed74658bc8375278eabf074b4777458376540John McCall    if (unsignedRange.Width < comparisonWidth)
4352323ed74658bc8375278eabf074b4777458376540John McCall      return;
4353323ed74658bc8375278eabf074b4777458376540John McCall  }
4354323ed74658bc8375278eabf074b4777458376540John McCall
43556d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor  S.DiagRuntimeBehavior(E->getOperatorLoc(), E,
43566d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor    S.PDiag(diag::warn_mixed_sign_comparison)
43576d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor      << LHS->getType() << RHS->getType()
43586d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor      << LHS->getSourceRange() << RHS->getSourceRange());
4359ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall}
4360ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
436115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield.
436215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall///
436315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt.
43640692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init,
43650692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                      SourceLocation InitLoc) {
436615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  assert(Bitfield->isBitField());
436715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  if (Bitfield->isInvalidDecl())
436815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    return false;
436915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
437091b6014876e9186f968f74a8975ab8fc08ef1b68John McCall  // White-list bool bitfields.
437191b6014876e9186f968f74a8975ab8fc08ef1b68John McCall  if (Bitfield->getType()->isBooleanType())
437291b6014876e9186f968f74a8975ab8fc08ef1b68John McCall    return false;
437391b6014876e9186f968f74a8975ab8fc08ef1b68John McCall
437446ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor  // Ignore value- or type-dependent expressions.
437546ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor  if (Bitfield->getBitWidth()->isValueDependent() ||
437646ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor      Bitfield->getBitWidth()->isTypeDependent() ||
437746ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor      Init->isValueDependent() ||
437846ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor      Init->isTypeDependent())
437946ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor    return false;
438046ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor
438115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  Expr *OriginalInit = Init->IgnoreParenImpCasts();
438215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
438380d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith  llvm::APSInt Value;
438480d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith  if (!OriginalInit->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects))
438515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    return false;
438615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
438715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  unsigned OriginalWidth = Value.getBitWidth();
4388a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith  unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context);
438915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
439015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  if (OriginalWidth <= FieldWidth)
439115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    return false;
439215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
43933a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  // Compute the value which the bitfield will contain.
43949f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad  llvm::APSInt TruncatedValue = Value.trunc(FieldWidth);
43953a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  TruncatedValue.setIsSigned(Bitfield->getType()->isSignedIntegerType());
439615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
43973a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  // Check whether the stored value is equal to the original value.
43983a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  TruncatedValue = TruncatedValue.extend(OriginalWidth);
4399e1ecdc168175719d74e112bcacd4aae5e12d4631Richard Trieu  if (llvm::APSInt::isSameValue(Value, TruncatedValue))
440015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    return false;
440115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
44023a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  // Special-case bitfields of width 1: booleans are naturally 0/1, and
440334ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman  // therefore don't strictly fit into a signed bitfield of width 1.
440434ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman  if (FieldWidth == 1 && Value == 1)
44053a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman    return false;
44063a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman
440715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  std::string PrettyValue = Value.toString(10);
440815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  std::string PrettyTrunc = TruncatedValue.toString(10);
440915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
441015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant)
441115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    << PrettyValue << PrettyTrunc << OriginalInit->getType()
441215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    << Init->getSourceRange();
441315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
441415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  return true;
441515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall}
441615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
4417beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy
4418beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations.
44190692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeAssignment(Sema &S, BinaryOperator *E) {
4420beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  // Just recurse on the LHS.
4421beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc());
4422beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall
4423beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  // We want to recurse on the RHS as normal unless we're assigning to
4424beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  // a bitfield.
4425beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  if (FieldDecl *Bitfield = E->getLHS()->getBitField()) {
442615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(),
442715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall                                  E->getOperatorLoc())) {
442815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall      // Recurse, ignoring any implicit conversions on the RHS.
442915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall      return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(),
443015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall                                        E->getOperatorLoc());
4431beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall    }
4432beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  }
4433beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall
4434beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc());
4435beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall}
4436beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall
443751313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast;  purely a helper for CheckImplicitConversion.
44380692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T,
4439c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            SourceLocation CContext, unsigned diag,
4440c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            bool pruneControlFlow = false) {
4441c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (pruneControlFlow) {
4442c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    S.DiagRuntimeBehavior(E->getExprLoc(), E,
4443c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                          S.PDiag(diag)
4444c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            << SourceType << T << E->getSourceRange()
4445c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            << SourceRange(CContext));
4446c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    return;
4447c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  }
44485a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  S.Diag(E->getExprLoc(), diag)
44495a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor    << SourceType << T << E->getSourceRange() << SourceRange(CContext);
44505a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor}
44515a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor
4452e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast;  purely a helper for CheckImplicitConversion.
44530692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType T,
4454c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            SourceLocation CContext, unsigned diag,
4455c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            bool pruneControlFlow = false) {
4456c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow);
4457e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth}
4458e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth
44599ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// Diagnose an implicit cast from a literal expression. Does not warn when the
44609ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// cast wouldn't lose information.
4461f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruthvoid DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T,
4462f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth                                    SourceLocation CContext) {
44639ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay  // Try to convert the literal exactly to an integer. If we can, don't warn.
4464f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth  bool isExact = false;
44659ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay  const llvm::APFloat &Value = FL->getValue();
44663e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin  llvm::APSInt IntegerValue(S.Context.getIntWidth(T),
44673e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin                            T->hasUnsignedIntegerRepresentation());
44683e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin  if (Value.convertToInteger(IntegerValue,
4469f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth                             llvm::APFloat::rmTowardZero, &isExact)
44709ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay      == llvm::APFloat::opOK && isExact)
4471f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth    return;
4472f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth
4473be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  SmallString<16> PrettySourceValue;
4474be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  Value.toString(PrettySourceValue);
4475de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie  SmallString<16> PrettyTargetValue;
4476be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  if (T->isSpecificBuiltinType(BuiltinType::Bool))
4477be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    PrettyTargetValue = IntegerValue == 0 ? "false" : "true";
4478be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  else
4479de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie    IntegerValue.toString(PrettyTargetValue);
4480be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie
44819ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay  S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer)
4482be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    << FL->getType() << T.getUnqualifiedType() << PrettySourceValue
4483be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    << PrettyTargetValue << FL->getSourceRange() << SourceRange(CContext);
4484f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth}
4485f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth
4486091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) {
4487091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall  if (!Range.Width) return "0";
4488091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall
4489091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall  llvm::APSInt ValueInRange = Value;
4490091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall  ValueInRange.setIsSigned(!Range.NonNegative);
44919f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad  ValueInRange = ValueInRange.trunc(Range.Width);
4492091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall  return ValueInRange.toString(10);
4493091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall}
4494091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall
449588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgstatic bool IsImplicitBoolFloatConversion(Sema &S, Expr *Ex, bool ToBool) {
449688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  if (!isa<ImplicitCastExpr>(Ex))
449788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    return false;
449888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
449988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  Expr *InnerE = Ex->IgnoreParenImpCasts();
450088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  const Type *Target = S.Context.getCanonicalType(Ex->getType()).getTypePtr();
450188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  const Type *Source =
450288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    S.Context.getCanonicalType(InnerE->getType()).getTypePtr();
450388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  if (Target->isDependentType())
450488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    return false;
450588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
450688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  const BuiltinType *FloatCandidateBT =
450788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    dyn_cast<BuiltinType>(ToBool ? Source : Target);
450888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  const Type *BoolCandidateType = ToBool ? Target : Source;
450988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
451088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  return (BoolCandidateType->isSpecificBuiltinType(BuiltinType::Bool) &&
451188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg          FloatCandidateBT && (FloatCandidateBT->isFloatingPoint()));
451288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg}
451388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
451488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgvoid CheckImplicitArgumentConversions(Sema &S, CallExpr *TheCall,
451588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg                                      SourceLocation CC) {
451688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  unsigned NumArgs = TheCall->getNumArgs();
451788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  for (unsigned i = 0; i < NumArgs; ++i) {
451888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    Expr *CurrA = TheCall->getArg(i);
451988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    if (!IsImplicitBoolFloatConversion(S, CurrA, true))
452088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      continue;
452188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
452288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    bool IsSwapped = ((i > 0) &&
452388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        IsImplicitBoolFloatConversion(S, TheCall->getArg(i - 1), false));
452488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    IsSwapped |= ((i < (NumArgs - 1)) &&
452588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        IsImplicitBoolFloatConversion(S, TheCall->getArg(i + 1), false));
452688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    if (IsSwapped) {
452788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      // Warn on this floating-point to bool conversion.
452888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      DiagnoseImpCast(S, CurrA->IgnoreParenImpCasts(),
452988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg                      CurrA->getType(), CC,
453088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg                      diag::warn_impcast_floating_point_to_bool);
453188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    }
453288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  }
453388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg}
453488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
4535323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T,
4536b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall                             SourceLocation CC, bool *ICContext = 0) {
4537323ed74658bc8375278eabf074b4777458376540John McCall  if (E->isTypeDependent() || E->isValueDependent()) return;
453851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4539323ed74658bc8375278eabf074b4777458376540John McCall  const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr();
4540323ed74658bc8375278eabf074b4777458376540John McCall  const Type *Target = S.Context.getCanonicalType(T).getTypePtr();
4541323ed74658bc8375278eabf074b4777458376540John McCall  if (Source == Target) return;
4542323ed74658bc8375278eabf074b4777458376540John McCall  if (Target->isDependentType()) return;
454351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4544108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // If the conversion context location is invalid don't complain. We also
4545108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // don't want to emit a warning if the issue occurs from the expansion of
4546108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // a system macro. The problem is that 'getSpellingLoc()' is slow, so we
4547108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // delay this check as long as possible. Once we detect we are in that
4548108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // scenario, we just return.
4549ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek  if (CC.isInvalid())
4550b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return;
4551b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall
4552f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  // Diagnose implicit casts to bool.
4553f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  if (Target->isSpecificBuiltinType(BuiltinType::Bool)) {
4554f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu    if (isa<StringLiteral>(E))
4555f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      // Warn on string literal to bool.  Checks for string literals in logical
4556f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      // expressions, for instances, assert(0 && "error here"), is prevented
4557f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      // by a check in AnalyzeImplicitConversions().
4558f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      return DiagnoseImpCast(S, E, T, CC,
4559f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu                             diag::warn_impcast_string_literal_to_bool);
4560e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames    if (Source->isFunctionType()) {
4561e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      // Warn on function to bool. Checks free functions and static member
4562e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      // functions. Weakly imported functions are excluded from the check,
4563e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      // since it's common to test their value to check whether the linker
4564e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      // found a definition for them.
4565e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      ValueDecl *D = 0;
4566e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      if (DeclRefExpr* R = dyn_cast<DeclRefExpr>(E)) {
4567e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames        D = R->getDecl();
4568e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) {
4569e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames        D = M->getMemberDecl();
4570e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      }
4571e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames
4572e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      if (D && !D->isWeak()) {
457326b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu        if (FunctionDecl* F = dyn_cast<FunctionDecl>(D)) {
457426b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu          S.Diag(E->getExprLoc(), diag::warn_impcast_function_to_bool)
457526b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu            << F << E->getSourceRange() << SourceRange(CC);
45762def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          S.Diag(E->getExprLoc(), diag::note_function_to_bool_silence)
45772def77399ab3088106a2d61372344f5b7104e1a2David Blaikie            << FixItHint::CreateInsertion(E->getExprLoc(), "&");
45782def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          QualType ReturnType;
45792def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          UnresolvedSet<4> NonTemplateOverloads;
45802def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          S.isExprCallable(*E, ReturnType, NonTemplateOverloads);
45812def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          if (!ReturnType.isNull()
45822def77399ab3088106a2d61372344f5b7104e1a2David Blaikie              && ReturnType->isSpecificBuiltinType(BuiltinType::Bool))
45832def77399ab3088106a2d61372344f5b7104e1a2David Blaikie            S.Diag(E->getExprLoc(), diag::note_function_to_bool_call)
45842def77399ab3088106a2d61372344f5b7104e1a2David Blaikie              << FixItHint::CreateInsertion(
45852def77399ab3088106a2d61372344f5b7104e1a2David Blaikie                 S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()), "()");
458626b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu          return;
458726b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu        }
4588e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      }
4589e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames    }
4590f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  }
459151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
459251313c39c84407dd6a323be99a8c322bf8d052a9John McCall  // Strip vector types.
459351313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (isa<VectorType>(Source)) {
4594ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    if (!isa<VectorType>(Target)) {
4595d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay      if (S.SourceMgr.isInSystemMacro(CC))
4596ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek        return;
4597b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall      return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar);
4598ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    }
4599b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner
4600b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner    // If the vector cast is cast between two vectors of the same size, it is
4601b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner    // a bitcast, not a conversion.
4602b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner    if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target))
4603b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner      return;
460451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
460551313c39c84407dd6a323be99a8c322bf8d052a9John McCall    Source = cast<VectorType>(Source)->getElementType().getTypePtr();
460651313c39c84407dd6a323be99a8c322bf8d052a9John McCall    Target = cast<VectorType>(Target)->getElementType().getTypePtr();
460751313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
460851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
460951313c39c84407dd6a323be99a8c322bf8d052a9John McCall  // Strip complex types.
461051313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (isa<ComplexType>(Source)) {
4611ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    if (!isa<ComplexType>(Target)) {
4612d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay      if (S.SourceMgr.isInSystemMacro(CC))
4613ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek        return;
4614ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4615b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall      return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar);
4616ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    }
461751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
461851313c39c84407dd6a323be99a8c322bf8d052a9John McCall    Source = cast<ComplexType>(Source)->getElementType().getTypePtr();
461951313c39c84407dd6a323be99a8c322bf8d052a9John McCall    Target = cast<ComplexType>(Target)->getElementType().getTypePtr();
462051313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
462151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
462251313c39c84407dd6a323be99a8c322bf8d052a9John McCall  const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source);
462351313c39c84407dd6a323be99a8c322bf8d052a9John McCall  const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target);
462451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
462551313c39c84407dd6a323be99a8c322bf8d052a9John McCall  // If the source is floating point...
462651313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (SourceBT && SourceBT->isFloatingPoint()) {
462751313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // ...and the target is floating point...
462851313c39c84407dd6a323be99a8c322bf8d052a9John McCall    if (TargetBT && TargetBT->isFloatingPoint()) {
462951313c39c84407dd6a323be99a8c322bf8d052a9John McCall      // ...then warn if we're dropping FP rank.
463051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
463151313c39c84407dd6a323be99a8c322bf8d052a9John McCall      // Builtin FP kinds are ordered by increasing FP rank.
463251313c39c84407dd6a323be99a8c322bf8d052a9John McCall      if (SourceBT->getKind() > TargetBT->getKind()) {
463351313c39c84407dd6a323be99a8c322bf8d052a9John McCall        // Don't warn about float constants that are precisely
463451313c39c84407dd6a323be99a8c322bf8d052a9John McCall        // representable in the target type.
463551313c39c84407dd6a323be99a8c322bf8d052a9John McCall        Expr::EvalResult result;
463651f4708c00110940ca3f337961915f2ca1668375Richard Smith        if (E->EvaluateAsRValue(result, S.Context)) {
463751313c39c84407dd6a323be99a8c322bf8d052a9John McCall          // Value might be a float, a float vector, or a float complex.
463851313c39c84407dd6a323be99a8c322bf8d052a9John McCall          if (IsSameFloatAfterCast(result.Val,
4639323ed74658bc8375278eabf074b4777458376540John McCall                   S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)),
4640323ed74658bc8375278eabf074b4777458376540John McCall                   S.Context.getFloatTypeSemantics(QualType(SourceBT, 0))))
464151313c39c84407dd6a323be99a8c322bf8d052a9John McCall            return;
464251313c39c84407dd6a323be99a8c322bf8d052a9John McCall        }
464351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4644d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay        if (S.SourceMgr.isInSystemMacro(CC))
4645ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek          return;
4646ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4647b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall        DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision);
464851313c39c84407dd6a323be99a8c322bf8d052a9John McCall      }
464951313c39c84407dd6a323be99a8c322bf8d052a9John McCall      return;
465051313c39c84407dd6a323be99a8c322bf8d052a9John McCall    }
465151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4652ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    // If the target is integral, always warn.
4653be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    if (TargetBT && TargetBT->isInteger()) {
4654d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay      if (S.SourceMgr.isInSystemMacro(CC))
4655ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek        return;
4656ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4657a5b9332418f25338f118358e27303cd510d54107Chandler Carruth      Expr *InnerE = E->IgnoreParenImpCasts();
4658634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay      // We also want to warn on, e.g., "int i = -1.234"
4659634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay      if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE))
4660634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay        if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus)
4661634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay          InnerE = UOp->getSubExpr()->IgnoreParenImpCasts();
4662634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay
4663f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth      if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) {
4664f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth        DiagnoseFloatingLiteralImpCast(S, FL, T, CC);
4665a5b9332418f25338f118358e27303cd510d54107Chandler Carruth      } else {
4666a5b9332418f25338f118358e27303cd510d54107Chandler Carruth        DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer);
4667a5b9332418f25338f118358e27303cd510d54107Chandler Carruth      }
4668a5b9332418f25338f118358e27303cd510d54107Chandler Carruth    }
466951313c39c84407dd6a323be99a8c322bf8d052a9John McCall
467088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    // If the target is bool, warn if expr is a function or method call.
467188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    if (Target->isSpecificBuiltinType(BuiltinType::Bool) &&
467288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        isa<CallExpr>(E)) {
467388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      // Check last argument of function call to see if it is an
467488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      // implicit cast from a type matching the type the result
467588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      // is being cast to.
467688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      CallExpr *CEx = cast<CallExpr>(E);
467788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      unsigned NumArgs = CEx->getNumArgs();
467888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      if (NumArgs > 0) {
467988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        Expr *LastA = CEx->getArg(NumArgs - 1);
468088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        Expr *InnerE = LastA->IgnoreParenImpCasts();
468188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        const Type *InnerType =
468288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg          S.Context.getCanonicalType(InnerE->getType()).getTypePtr();
468388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        if (isa<ImplicitCastExpr>(LastA) && (InnerType == Target)) {
468488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg          // Warn on this floating-point to bool conversion
468588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg          DiagnoseImpCast(S, E, T, CC,
468688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg                          diag::warn_impcast_floating_point_to_bool);
468788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        }
468888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      }
468988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    }
469051313c39c84407dd6a323be99a8c322bf8d052a9John McCall    return;
469151313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
469251313c39c84407dd6a323be99a8c322bf8d052a9John McCall
46931838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu  if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull)
4694b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie           == Expr::NPCK_GNUNull) && !Target->isAnyPointerType()
469528a5f0cdfcc927a94c1bda6a225200762df22411David Blaikie      && !Target->isBlockPointerType() && !Target->isMemberPointerType()) {
4696b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie    SourceLocation Loc = E->getSourceRange().getBegin();
4697b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie    if (Loc.isMacroID())
4698b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie      Loc = S.SourceMgr.getImmediateExpansionRange(Loc).first;
46999fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie    if (!Loc.isMacroID() || CC.isMacroID())
47009fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie      S.Diag(Loc, diag::warn_impcast_null_pointer_to_integer)
47019fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie          << T << clang::SourceRange(CC)
47029fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie          << FixItHint::CreateReplacement(Loc, S.getFixItZeroLiteralForType(T));
47031838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu  }
47041838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu
4705b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie  if (!Source->isIntegerType() || !Target->isIntegerType())
4706b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie    return;
4707b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie
4708be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  // TODO: remove this early return once the false positives for constant->bool
4709be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  // in templates, macros, etc, are reduced or removed.
4710be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  if (Target->isSpecificBuiltinType(BuiltinType::Bool))
4711be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    return;
4712be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie
4713323ed74658bc8375278eabf074b4777458376540John McCall  IntRange SourceRange = GetExprRange(S.Context, E);
47141844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target);
471551313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4716f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (SourceRange.Width > TargetRange.Width) {
4717091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    // If the source is a constant, use a default-on diagnostic.
4718091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    // TODO: this should happen for bitfield stores, too.
4719091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    llvm::APSInt Value(32);
4720091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    if (E->isIntegerConstantExpr(Value, S.Context)) {
4721d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay      if (S.SourceMgr.isInSystemMacro(CC))
4722ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek        return;
4723ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4724091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall      std::string PrettySourceValue = Value.toString(10);
4725091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall      std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange);
4726091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall
47275e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek      S.DiagRuntimeBehavior(E->getExprLoc(), E,
47285e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek        S.PDiag(diag::warn_impcast_integer_precision_constant)
47295e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek            << PrettySourceValue << PrettyTargetValue
47305e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek            << E->getType() << T << E->getSourceRange()
47315e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek            << clang::SourceRange(CC));
4732091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall      return;
4733091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    }
4734091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall
4735b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner    // People want to build with -Wshorten-64-to-32 and not -Wconversion.
4736d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay    if (S.SourceMgr.isInSystemMacro(CC))
4737ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek      return;
4738ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
473937050841d7b852497b85d5275d9ea92c07ddf059David Blaikie    if (TargetRange.Width == 32 && S.Context.getIntWidth(E->getType()) == 64)
4740c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32,
4741c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                             /* pruneControlFlow */ true);
4742b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision);
4743323ed74658bc8375278eabf074b4777458376540John McCall  }
4744323ed74658bc8375278eabf074b4777458376540John McCall
4745323ed74658bc8375278eabf074b4777458376540John McCall  if ((TargetRange.NonNegative && !SourceRange.NonNegative) ||
4746323ed74658bc8375278eabf074b4777458376540John McCall      (!TargetRange.NonNegative && SourceRange.NonNegative &&
4747323ed74658bc8375278eabf074b4777458376540John McCall       SourceRange.Width == TargetRange.Width)) {
4748ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4749d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay    if (S.SourceMgr.isInSystemMacro(CC))
4750ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek      return;
4751ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4752323ed74658bc8375278eabf074b4777458376540John McCall    unsigned DiagID = diag::warn_impcast_integer_sign;
4753323ed74658bc8375278eabf074b4777458376540John McCall
4754323ed74658bc8375278eabf074b4777458376540John McCall    // Traditionally, gcc has warned about this under -Wsign-compare.
4755323ed74658bc8375278eabf074b4777458376540John McCall    // We also want to warn about it in -Wconversion.
4756323ed74658bc8375278eabf074b4777458376540John McCall    // So if -Wconversion is off, use a completely identical diagnostic
4757323ed74658bc8375278eabf074b4777458376540John McCall    // in the sign-compare group.
4758323ed74658bc8375278eabf074b4777458376540John McCall    // The conditional-checking code will
4759323ed74658bc8375278eabf074b4777458376540John McCall    if (ICContext) {
4760323ed74658bc8375278eabf074b4777458376540John McCall      DiagID = diag::warn_impcast_integer_sign_conditional;
4761323ed74658bc8375278eabf074b4777458376540John McCall      *ICContext = true;
4762323ed74658bc8375278eabf074b4777458376540John McCall    }
4763323ed74658bc8375278eabf074b4777458376540John McCall
4764b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return DiagnoseImpCast(S, E, T, CC, DiagID);
476551313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
476651313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4767284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor  // Diagnose conversions between different enumeration types.
47685a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  // In C, we pretend that the type of an EnumConstantDecl is its enumeration
47695a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  // type, to give us better diagnostics.
47705a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  QualType SourceType = E->getType();
47714e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie  if (!S.getLangOpts().CPlusPlus) {
47725a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor    if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E))
47735a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor      if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) {
47745a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor        EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext());
47755a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor        SourceType = S.Context.getTypeDeclType(Enum);
47765a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor        Source = S.Context.getCanonicalType(SourceType).getTypePtr();
47775a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor      }
47785a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  }
47795a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor
4780284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor  if (const EnumType *SourceEnum = Source->getAs<EnumType>())
4781284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor    if (const EnumType *TargetEnum = Target->getAs<EnumType>())
4782284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor      if ((SourceEnum->getDecl()->getIdentifier() ||
4783162e1c1b487352434552147967c3dd296ebee2f7Richard Smith           SourceEnum->getDecl()->getTypedefNameForAnonDecl()) &&
4784284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor          (TargetEnum->getDecl()->getIdentifier() ||
4785162e1c1b487352434552147967c3dd296ebee2f7Richard Smith           TargetEnum->getDecl()->getTypedefNameForAnonDecl()) &&
4786ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek          SourceEnum != TargetEnum) {
4787d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay        if (S.SourceMgr.isInSystemMacro(CC))
4788ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek          return;
4789ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
47905a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor        return DiagnoseImpCast(S, E, SourceType, T, CC,
4791284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor                               diag::warn_impcast_different_enum_types);
4792ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek      }
4793284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor
479451313c39c84407dd6a323be99a8c322bf8d052a9John McCall  return;
479551313c39c84407dd6a323be99a8c322bf8d052a9John McCall}
479651313c39c84407dd6a323be99a8c322bf8d052a9John McCall
47979fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E,
47989fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie                              SourceLocation CC, QualType T);
4799323ed74658bc8375278eabf074b4777458376540John McCall
4800323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T,
4801b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall                             SourceLocation CC, bool &ICContext) {
4802323ed74658bc8375278eabf074b4777458376540John McCall  E = E->IgnoreParenImpCasts();
4803323ed74658bc8375278eabf074b4777458376540John McCall
4804323ed74658bc8375278eabf074b4777458376540John McCall  if (isa<ConditionalOperator>(E))
48059fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie    return CheckConditionalOperator(S, cast<ConditionalOperator>(E), CC, T);
4806323ed74658bc8375278eabf074b4777458376540John McCall
4807b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(S, E, CC);
4808323ed74658bc8375278eabf074b4777458376540John McCall  if (E->getType() != T)
4809b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return CheckImplicitConversion(S, E, T, CC, &ICContext);
4810323ed74658bc8375278eabf074b4777458376540John McCall  return;
4811323ed74658bc8375278eabf074b4777458376540John McCall}
4812323ed74658bc8375278eabf074b4777458376540John McCall
48139fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E,
48149fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie                              SourceLocation CC, QualType T) {
4815b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(S, E->getCond(), CC);
4816323ed74658bc8375278eabf074b4777458376540John McCall
4817323ed74658bc8375278eabf074b4777458376540John McCall  bool Suspicious = false;
4818b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious);
4819b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious);
4820323ed74658bc8375278eabf074b4777458376540John McCall
4821323ed74658bc8375278eabf074b4777458376540John McCall  // If -Wconversion would have warned about either of the candidates
4822323ed74658bc8375278eabf074b4777458376540John McCall  // for a signedness conversion to the context type...
4823323ed74658bc8375278eabf074b4777458376540John McCall  if (!Suspicious) return;
4824323ed74658bc8375278eabf074b4777458376540John McCall
4825323ed74658bc8375278eabf074b4777458376540John McCall  // ...but it's currently ignored...
48260827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis  if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional,
48270827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis                                 CC))
4828323ed74658bc8375278eabf074b4777458376540John McCall    return;
4829323ed74658bc8375278eabf074b4777458376540John McCall
4830323ed74658bc8375278eabf074b4777458376540John McCall  // ...then check whether it would have warned about either of the
4831323ed74658bc8375278eabf074b4777458376540John McCall  // candidates for a signedness conversion to the condition type.
48325254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu  if (E->getType() == T) return;
48335254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu
48345254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu  Suspicious = false;
48355254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu  CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(),
48365254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu                          E->getType(), CC, &Suspicious);
48375254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu  if (!Suspicious)
48385254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu    CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(),
4839b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall                            E->getType(), CC, &Suspicious);
4840323ed74658bc8375278eabf074b4777458376540John McCall}
4841323ed74658bc8375278eabf074b4777458376540John McCall
4842323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting
4843323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression.  There are a couple
4844323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare.
4845b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) {
4846323ed74658bc8375278eabf074b4777458376540John McCall  QualType T = OrigE->getType();
4847323ed74658bc8375278eabf074b4777458376540John McCall  Expr *E = OrigE->IgnoreParenImpCasts();
4848323ed74658bc8375278eabf074b4777458376540John McCall
4849f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor  if (E->isTypeDependent() || E->isValueDependent())
4850f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor    return;
4851f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor
4852323ed74658bc8375278eabf074b4777458376540John McCall  // For conditional operators, we analyze the arguments as if they
4853323ed74658bc8375278eabf074b4777458376540John McCall  // were being fed directly into the output.
4854323ed74658bc8375278eabf074b4777458376540John McCall  if (isa<ConditionalOperator>(E)) {
4855323ed74658bc8375278eabf074b4777458376540John McCall    ConditionalOperator *CO = cast<ConditionalOperator>(E);
48569fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie    CheckConditionalOperator(S, CO, CC, T);
4857323ed74658bc8375278eabf074b4777458376540John McCall    return;
4858323ed74658bc8375278eabf074b4777458376540John McCall  }
4859323ed74658bc8375278eabf074b4777458376540John McCall
486088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  // Check implicit argument conversions for function calls.
486188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  if (CallExpr *Call = dyn_cast<CallExpr>(E))
486288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    CheckImplicitArgumentConversions(S, Call, CC);
486388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
4864323ed74658bc8375278eabf074b4777458376540John McCall  // Go ahead and check any implicit conversions we might have skipped.
4865323ed74658bc8375278eabf074b4777458376540John McCall  // The non-canonical typecheck is just an optimization;
4866323ed74658bc8375278eabf074b4777458376540John McCall  // CheckImplicitConversion will filter out dead implicit conversions.
4867323ed74658bc8375278eabf074b4777458376540John McCall  if (E->getType() != T)
4868b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    CheckImplicitConversion(S, E, T, CC);
4869323ed74658bc8375278eabf074b4777458376540John McCall
4870323ed74658bc8375278eabf074b4777458376540John McCall  // Now continue drilling into this expression.
4871323ed74658bc8375278eabf074b4777458376540John McCall
4872323ed74658bc8375278eabf074b4777458376540John McCall  // Skip past explicit casts.
4873323ed74658bc8375278eabf074b4777458376540John McCall  if (isa<ExplicitCastExpr>(E)) {
4874323ed74658bc8375278eabf074b4777458376540John McCall    E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts();
4875b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return AnalyzeImplicitConversions(S, E, CC);
4876323ed74658bc8375278eabf074b4777458376540John McCall  }
4877323ed74658bc8375278eabf074b4777458376540John McCall
4878beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
4879beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall    // Do a somewhat different check with comparison operators.
4880beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall    if (BO->isComparisonOp())
4881beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall      return AnalyzeComparison(S, BO);
4882beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall
48830fa063816818ac53a0015a5d2b0328812005b40eEli Friedman    // And with simple assignments.
48840fa063816818ac53a0015a5d2b0328812005b40eEli Friedman    if (BO->getOpcode() == BO_Assign)
4885beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall      return AnalyzeAssignment(S, BO);
4886beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  }
4887323ed74658bc8375278eabf074b4777458376540John McCall
4888323ed74658bc8375278eabf074b4777458376540John McCall  // These break the otherwise-useful invariant below.  Fortunately,
4889323ed74658bc8375278eabf074b4777458376540John McCall  // we don't really need to recurse into them, because any internal
4890323ed74658bc8375278eabf074b4777458376540John McCall  // expressions should have been analyzed already when they were
4891323ed74658bc8375278eabf074b4777458376540John McCall  // built into statements.
4892323ed74658bc8375278eabf074b4777458376540John McCall  if (isa<StmtExpr>(E)) return;
4893323ed74658bc8375278eabf074b4777458376540John McCall
4894323ed74658bc8375278eabf074b4777458376540John McCall  // Don't descend into unevaluated contexts.
4895f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne  if (isa<UnaryExprOrTypeTraitExpr>(E)) return;
4896323ed74658bc8375278eabf074b4777458376540John McCall
4897323ed74658bc8375278eabf074b4777458376540John McCall  // Now just recurse over the expression's children.
4898b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  CC = E->getExprLoc();
4899f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  BinaryOperator *BO = dyn_cast<BinaryOperator>(E);
4900f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  bool IsLogicalOperator = BO && BO->isLogicalOp();
4901f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  for (Stmt::child_range I = E->children(); I; ++I) {
490254042f1bd78f1f1ea86be7d4af541462e127d2edDouglas Gregor    Expr *ChildExpr = dyn_cast_or_null<Expr>(*I);
4903503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor    if (!ChildExpr)
4904503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor      continue;
4905503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor
4906f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu    if (IsLogicalOperator &&
4907f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu        isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts()))
4908f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      // Ignore checking string literals that are in logical operators.
4909f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      continue;
4910f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu    AnalyzeImplicitConversions(S, ChildExpr, CC);
4911f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  }
4912323ed74658bc8375278eabf074b4777458376540John McCall}
4913323ed74658bc8375278eabf074b4777458376540John McCall
4914323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace
4915323ed74658bc8375278eabf074b4777458376540John McCall
4916323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given
4917323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression).  Implements -Wconversion
4918323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare.
4919b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall///
4920b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e.
4921b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall///   the most location of the syntactic entity requiring the implicit
4922b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall///   conversion
4923b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) {
4924323ed74658bc8375278eabf074b4777458376540John McCall  // Don't diagnose in unevaluated contexts.
492571f55f771794674a410171dbf3cb5dbedf95d033David Blaikie  if (isUnevaluatedContext())
4926323ed74658bc8375278eabf074b4777458376540John McCall    return;
4927323ed74658bc8375278eabf074b4777458376540John McCall
4928323ed74658bc8375278eabf074b4777458376540John McCall  // Don't diagnose for value- or type-dependent expressions.
4929323ed74658bc8375278eabf074b4777458376540John McCall  if (E->isTypeDependent() || E->isValueDependent())
4930323ed74658bc8375278eabf074b4777458376540John McCall    return;
4931323ed74658bc8375278eabf074b4777458376540John McCall
4932d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  // Check for array bounds violations in cases where the check isn't triggered
4933d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  // elsewhere for other Expr types (like BinaryOperators), e.g. when an
4934d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  // ArraySubscriptExpr is on the RHS of a variable initialization.
4935d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  CheckArrayAccess(E);
4936d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
4937b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  // This is not the right CC for (e.g.) a variable initialization.
4938b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(*this, E, CC);
4939323ed74658bc8375278eabf074b4777458376540John McCall}
4940323ed74658bc8375278eabf074b4777458376540John McCall
494115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc,
494215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall                                       FieldDecl *BitField,
494315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall                                       Expr *Init) {
494415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc);
494515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall}
494615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
4947f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given
4948f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This
4949f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the
4950f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function
4951f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete.
495282aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregorbool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd,
495382aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor                                    bool CheckParameterNames) {
4954f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump  bool HasInvalidParm = false;
495582aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor  for (; P != PEnd; ++P) {
495682aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor    ParmVarDecl *Param = *P;
495782aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor
4958f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // C99 6.7.5.3p4: the parameters in a parameter type list in a
4959f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // function declarator that is part of a function definition of
4960f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // that function shall not have incomplete type.
4961f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    //
4962f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // This is also C++ [dcl.fct]p6.
4963f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    if (!Param->isInvalidDecl() &&
4964f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump        RequireCompleteType(Param->getLocation(), Param->getType(),
4965d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor                            diag::err_typecheck_decl_incomplete_type)) {
4966f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump      Param->setInvalidDecl();
4967f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump      HasInvalidParm = true;
4968f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    }
4969f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump
4970f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // C99 6.9.1p5: If the declarator includes a parameter type list, the
4971f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // declaration of each parameter shall include an identifier.
497282aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor    if (CheckParameterNames &&
497382aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor        Param->getIdentifier() == 0 &&
4974f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump        !Param->isImplicit() &&
49754e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie        !getLangOpts().CPlusPlus)
4976f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump      Diag(Param->getLocation(), diag::err_parameter_name_omitted);
4977d17e340e2d516139931768697bf080f60920ba9dSam Weinig
4978d17e340e2d516139931768697bf080f60920ba9dSam Weinig    // C99 6.7.5.3p12:
4979d17e340e2d516139931768697bf080f60920ba9dSam Weinig    //   If the function declarator is not part of a definition of that
4980d17e340e2d516139931768697bf080f60920ba9dSam Weinig    //   function, parameters may have incomplete type and may use the [*]
4981d17e340e2d516139931768697bf080f60920ba9dSam Weinig    //   notation in their sequences of declarator specifiers to specify
4982d17e340e2d516139931768697bf080f60920ba9dSam Weinig    //   variable length array types.
4983d17e340e2d516139931768697bf080f60920ba9dSam Weinig    QualType PType = Param->getOriginalType();
4984d17e340e2d516139931768697bf080f60920ba9dSam Weinig    if (const ArrayType *AT = Context.getAsArrayType(PType)) {
4985d17e340e2d516139931768697bf080f60920ba9dSam Weinig      if (AT->getSizeModifier() == ArrayType::Star) {
4986bed28ac1d1463adca3ecf24fca5c30646fa9dbb2Sylvestre Ledru        // FIXME: This diagnosic should point the '[*]' if source-location
4987d17e340e2d516139931768697bf080f60920ba9dSam Weinig        // information is added for it.
4988d17e340e2d516139931768697bf080f60920ba9dSam Weinig        Diag(Param->getLocation(), diag::err_array_star_in_function_definition);
4989d17e340e2d516139931768697bf080f60920ba9dSam Weinig      }
4990d17e340e2d516139931768697bf080f60920ba9dSam Weinig    }
4991f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump  }
4992f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump
4993f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump  return HasInvalidParm;
4994f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump}
4995b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
4996b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a
4997b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements.
4998b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) {
4999b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // This is actually a lot of work to potentially be doing on every
5000b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // cast; don't do it if we're ignoring -Wcast_align (as is the default).
50010827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis  if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align,
50020827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis                                          TRange.getBegin())
5003d6471f7c1921c7802804ce3ff6fe9768310f72b9David Blaikie        == DiagnosticsEngine::Ignored)
5004b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    return;
5005b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5006b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Ignore dependent types.
5007b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (T->isDependentType() || Op->getType()->isDependentType())
5008b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    return;
5009b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5010b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Require that the destination be a pointer type.
5011b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  const PointerType *DestPtr = T->getAs<PointerType>();
5012b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (!DestPtr) return;
5013b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5014b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // If the destination has alignment 1, we're done.
5015b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  QualType DestPointee = DestPtr->getPointeeType();
5016b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (DestPointee->isIncompleteType()) return;
5017b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee);
5018b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (DestAlign.isOne()) return;
5019b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5020b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Require that the source be a pointer type.
5021b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  const PointerType *SrcPtr = Op->getType()->getAs<PointerType>();
5022b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (!SrcPtr) return;
5023b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  QualType SrcPointee = SrcPtr->getPointeeType();
5024b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5025b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Whitelist casts from cv void*.  We already implicitly
5026b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // whitelisted casts to cv void*, since they have alignment 1.
5027b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Also whitelist casts involving incomplete types, which implicitly
5028b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // includes 'void'.
5029b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (SrcPointee->isIncompleteType()) return;
5030b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5031b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee);
5032b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (SrcAlign >= DestAlign) return;
5033b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5034b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  Diag(TRange.getBegin(), diag::warn_cast_align)
5035b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    << Op->getType() << T
5036b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    << static_cast<unsigned>(SrcAlign.getQuantity())
5037b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    << static_cast<unsigned>(DestAlign.getQuantity())
5038b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    << TRange << Op->getSourceRange();
5039b7f4ffe073fa419613946461a2583ba2fcb72280John McCall}
5040b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5041d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainstatic const Type* getElementType(const Expr *BaseExpr) {
5042d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  const Type* EltType = BaseExpr->getType().getTypePtr();
5043d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  if (EltType->isAnyPointerType())
5044d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    return EltType->getPointeeType().getTypePtr();
5045d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  else if (EltType->isArrayType())
5046d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    return EltType->getBaseElementTypeUnsafe();
5047d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  return EltType;
5048d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain}
5049d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
5050c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// \brief Check whether this array fits the idiom of a size-one tail padded
5051c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// array member of a struct.
5052c268434b332bbe57950d977633369bf5822d9554Chandler Carruth///
5053c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// We avoid emitting out-of-bounds access warnings for such arrays as they are
5054c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// commonly used to emulate flexible arrays in C89 code.
5055c268434b332bbe57950d977633369bf5822d9554Chandler Carruthstatic bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size,
5056c268434b332bbe57950d977633369bf5822d9554Chandler Carruth                                    const NamedDecl *ND) {
5057c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  if (Size != 1 || !ND) return false;
5058c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
5059c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  const FieldDecl *FD = dyn_cast<FieldDecl>(ND);
5060c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  if (!FD) return false;
5061c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
5062c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  // Don't consider sizes resulting from macro expansions or template argument
5063c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  // substitution to form C89 tail-padded arrays.
5064d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan
5065d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan  TypeSourceInfo *TInfo = FD->getTypeSourceInfo();
506600e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek  while (TInfo) {
506700e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    TypeLoc TL = TInfo->getTypeLoc();
506800e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    // Look through typedefs.
506900e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    const TypedefTypeLoc *TTL = dyn_cast<TypedefTypeLoc>(&TL);
507000e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    if (TTL) {
507100e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek      const TypedefNameDecl *TDL = TTL->getTypedefNameDecl();
507200e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek      TInfo = TDL->getTypeSourceInfo();
507300e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek      continue;
507400e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    }
507500e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    ConstantArrayTypeLoc CTL = cast<ConstantArrayTypeLoc>(TL);
507600e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    const Expr *SizeExpr = dyn_cast<IntegerLiteral>(CTL.getSizeExpr());
5077d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan    if (!SizeExpr || SizeExpr->getExprLoc().isMacroID())
5078d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan      return false;
507900e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    break;
5080d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan  }
5081c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
5082c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext());
5083381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay  if (!RD) return false;
5084381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay  if (RD->isUnion()) return false;
5085381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay  if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) {
5086381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay    if (!CRD->isStandardLayout()) return false;
5087381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay  }
5088c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
508922d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer  // See if this is the last field decl in the record.
509022d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer  const Decl *D = FD;
509122d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer  while ((D = D->getNextDeclInContext()))
509222d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer    if (isa<FieldDecl>(D))
509322d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer      return false;
509422d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer  return true;
5095c268434b332bbe57950d977633369bf5822d9554Chandler Carruth}
5096c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
5097d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainvoid Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr,
509880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay                            const ArraySubscriptExpr *ASE,
509925b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith                            bool AllowOnePastEnd, bool IndexNegated) {
510092b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman  IndexExpr = IndexExpr->IgnoreParenImpCasts();
510180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay  if (IndexExpr->isValueDependent())
510280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    return;
5103d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
510480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay  const Type *EffectiveType = getElementType(BaseExpr);
510580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay  BaseExpr = BaseExpr->IgnoreParenCasts();
51063406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth  const ConstantArrayType *ArrayTy =
5107d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    Context.getAsConstantArrayType(BaseExpr->getType());
51083406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth  if (!ArrayTy)
5109a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek    return;
511035001ca261f895817916b468379b696d6d45959dChandler Carruth
51113406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth  llvm::APSInt index;
511280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay  if (!IndexExpr->EvaluateAsInt(index, Context))
5113a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek    return;
511425b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith  if (IndexNegated)
511525b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith    index = -index;
51168fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek
5117ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth  const NamedDecl *ND = NULL;
5118ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth  if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr))
5119ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    ND = dyn_cast<NamedDecl>(DRE->getDecl());
5120c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr))
5121ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    ND = dyn_cast<NamedDecl>(ME->getMemberDecl());
5122ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth
51239e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek  if (index.isUnsigned() || !index.isNegative()) {
512425b3b849e3ad340b04442707038c86980035765bTed Kremenek    llvm::APInt size = ArrayTy->getSize();
512535001ca261f895817916b468379b696d6d45959dChandler Carruth    if (!size.isStrictlyPositive())
512635001ca261f895817916b468379b696d6d45959dChandler Carruth      return;
5127d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
5128d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    const Type* BaseType = getElementType(BaseExpr);
5129de5998f1d7dcecb777257ec932142d65de636eb8Nico Weber    if (BaseType != EffectiveType) {
5130d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      // Make sure we're comparing apples to apples when comparing index to size
5131d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType);
5132d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      uint64_t array_typesize = Context.getTypeSize(BaseType);
5133d10f4bc5a05ce0cdc1646dbb0f706bb9d3dfc0c5Kaelyn Uhrain      // Handle ptrarith_typesize being zero, such as when casting to void*
513418f169770d9d3f826bad8f1359c8c5770c5ab16fKaelyn Uhrain      if (!ptrarith_typesize) ptrarith_typesize = 1;
5135d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      if (ptrarith_typesize != array_typesize) {
5136d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        // There's a cast to a different size type involved
5137d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        uint64_t ratio = array_typesize / ptrarith_typesize;
5138d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        // TODO: Be smarter about handling cases where array_typesize is not a
5139d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        // multiple of ptrarith_typesize
5140d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        if (ptrarith_typesize * ratio == array_typesize)
5141d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain          size *= llvm::APInt(size.getBitWidth(), ratio);
5142d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      }
5143d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    }
5144d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
51453406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth    if (size.getBitWidth() > index.getBitWidth())
514692b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman      index = index.zext(size.getBitWidth());
514725b3b849e3ad340b04442707038c86980035765bTed Kremenek    else if (size.getBitWidth() < index.getBitWidth())
514892b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman      size = size.zext(index.getBitWidth());
514925b3b849e3ad340b04442707038c86980035765bTed Kremenek
5150d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    // For array subscripting the index must be less than size, but for pointer
5151d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    // arithmetic also allow the index (offset) to be equal to size since
5152d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    // computing the next address after the end of the array is legal and
5153d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    // commonly done e.g. in C++ iterators and range-based for loops.
515492b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman    if (AllowOnePastEnd ? index.ule(size) : index.ult(size))
5155ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth      return;
5156ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth
5157ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    // Also don't warn for arrays of size 1 which are members of some
5158ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    // structure. These are often used to approximate flexible arrays in C89
5159ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    // code.
5160d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    if (IsTailPaddedMemberArray(*this, size, ND))
51618fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek      return;
51623406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth
516380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    // Suppress the warning if the subscript expression (as identified by the
516480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    // ']' location) and the index expression are both from macro expansions
516580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    // within a system header.
516680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    if (ASE) {
516780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay      SourceLocation RBracketLoc = SourceMgr.getSpellingLoc(
516880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay          ASE->getRBracketLoc());
516980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay      if (SourceMgr.isInSystemHeader(RBracketLoc)) {
517080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay        SourceLocation IndexLoc = SourceMgr.getSpellingLoc(
517180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay            IndexExpr->getLocStart());
517280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay        if (SourceMgr.isFromSameFile(RBracketLoc, IndexLoc))
517380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay          return;
517480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay      }
517580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    }
517680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay
5177d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds;
517880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    if (ASE)
5179d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      DiagID = diag::warn_array_index_exceeds_bounds;
5180d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
5181d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr,
5182d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                        PDiag(DiagID) << index.toString(10, true)
5183d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << size.toString(10, true)
5184d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << (unsigned)size.getLimitedValue(~0U)
5185d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << IndexExpr->getSourceRange());
51863406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth  } else {
5187d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    unsigned DiagID = diag::warn_array_index_precedes_bounds;
518880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    if (!ASE) {
5189d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      DiagID = diag::warn_ptr_arith_precedes_bounds;
5190d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      if (index.isNegative()) index = -index;
5191d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    }
5192d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
5193d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr,
5194d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                        PDiag(DiagID) << index.toString(10, true)
5195d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << IndexExpr->getSourceRange());
5196a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek  }
519735001ca261f895817916b468379b696d6d45959dChandler Carruth
5198cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay  if (!ND) {
5199cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay    // Try harder to find a NamedDecl to point at in the note.
5200cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay    while (const ArraySubscriptExpr *ASE =
5201cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay           dyn_cast<ArraySubscriptExpr>(BaseExpr))
5202cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay      BaseExpr = ASE->getBase()->IgnoreParenCasts();
5203cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay    if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr))
5204cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay      ND = dyn_cast<NamedDecl>(DRE->getDecl());
5205cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay    if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr))
5206cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay      ND = dyn_cast<NamedDecl>(ME->getMemberDecl());
5207cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay  }
5208cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay
520935001ca261f895817916b468379b696d6d45959dChandler Carruth  if (ND)
5210d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    DiagRuntimeBehavior(ND->getLocStart(), BaseExpr,
5211d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                        PDiag(diag::note_array_index_out_of_bounds)
5212d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << ND->getDeclName());
52133aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek}
52143aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek
52153aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) {
5216d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  int AllowOnePastEnd = 0;
5217d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  while (expr) {
5218d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    expr = expr->IgnoreParenImpCasts();
52193aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek    switch (expr->getStmtClass()) {
5220d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      case Stmt::ArraySubscriptExprClass: {
5221d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr);
522280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay        CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE,
5223d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                         AllowOnePastEnd > 0);
52243aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        return;
5225d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      }
5226d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      case Stmt::UnaryOperatorClass: {
5227d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        // Only unwrap the * and & unary operators
5228d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        const UnaryOperator *UO = cast<UnaryOperator>(expr);
5229d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        expr = UO->getSubExpr();
5230d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        switch (UO->getOpcode()) {
5231d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain          case UO_AddrOf:
5232d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            AllowOnePastEnd++;
5233d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            break;
5234d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain          case UO_Deref:
5235d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            AllowOnePastEnd--;
5236d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            break;
5237d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain          default:
5238d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            return;
5239d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        }
5240d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        break;
5241d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      }
52423aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek      case Stmt::ConditionalOperatorClass: {
52433aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        const ConditionalOperator *cond = cast<ConditionalOperator>(expr);
52443aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        if (const Expr *lhs = cond->getLHS())
52453aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek          CheckArrayAccess(lhs);
52463aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        if (const Expr *rhs = cond->getRHS())
52473aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek          CheckArrayAccess(rhs);
52483aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        return;
52493aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek      }
52503aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek      default:
52513aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        return;
52523aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek    }
5253f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne  }
5254a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek}
5255f85e193739c953358c865005855253af4f68a497John McCall
5256f85e193739c953358c865005855253af4f68a497John McCall//===--- CHECK: Objective-C retain cycles ----------------------------------//
5257f85e193739c953358c865005855253af4f68a497John McCall
5258f85e193739c953358c865005855253af4f68a497John McCallnamespace {
5259f85e193739c953358c865005855253af4f68a497John McCall  struct RetainCycleOwner {
5260f85e193739c953358c865005855253af4f68a497John McCall    RetainCycleOwner() : Variable(0), Indirect(false) {}
5261f85e193739c953358c865005855253af4f68a497John McCall    VarDecl *Variable;
5262f85e193739c953358c865005855253af4f68a497John McCall    SourceRange Range;
5263f85e193739c953358c865005855253af4f68a497John McCall    SourceLocation Loc;
5264f85e193739c953358c865005855253af4f68a497John McCall    bool Indirect;
5265f85e193739c953358c865005855253af4f68a497John McCall
5266f85e193739c953358c865005855253af4f68a497John McCall    void setLocsFrom(Expr *e) {
5267f85e193739c953358c865005855253af4f68a497John McCall      Loc = e->getExprLoc();
5268f85e193739c953358c865005855253af4f68a497John McCall      Range = e->getSourceRange();
5269f85e193739c953358c865005855253af4f68a497John McCall    }
5270f85e193739c953358c865005855253af4f68a497John McCall  };
5271f85e193739c953358c865005855253af4f68a497John McCall}
5272f85e193739c953358c865005855253af4f68a497John McCall
5273f85e193739c953358c865005855253af4f68a497John McCall/// Consider whether capturing the given variable can possibly lead to
5274f85e193739c953358c865005855253af4f68a497John McCall/// a retain cycle.
5275f85e193739c953358c865005855253af4f68a497John McCallstatic bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) {
5276f85e193739c953358c865005855253af4f68a497John McCall  // In ARC, it's captured strongly iff the variable has __strong
5277f85e193739c953358c865005855253af4f68a497John McCall  // lifetime.  In MRR, it's captured strongly if the variable is
5278f85e193739c953358c865005855253af4f68a497John McCall  // __block and has an appropriate type.
5279f85e193739c953358c865005855253af4f68a497John McCall  if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong)
5280f85e193739c953358c865005855253af4f68a497John McCall    return false;
5281f85e193739c953358c865005855253af4f68a497John McCall
5282f85e193739c953358c865005855253af4f68a497John McCall  owner.Variable = var;
5283f85e193739c953358c865005855253af4f68a497John McCall  owner.setLocsFrom(ref);
5284f85e193739c953358c865005855253af4f68a497John McCall  return true;
5285f85e193739c953358c865005855253af4f68a497John McCall}
5286f85e193739c953358c865005855253af4f68a497John McCall
52876e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanianstatic bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) {
5288f85e193739c953358c865005855253af4f68a497John McCall  while (true) {
5289f85e193739c953358c865005855253af4f68a497John McCall    e = e->IgnoreParens();
5290f85e193739c953358c865005855253af4f68a497John McCall    if (CastExpr *cast = dyn_cast<CastExpr>(e)) {
5291f85e193739c953358c865005855253af4f68a497John McCall      switch (cast->getCastKind()) {
5292f85e193739c953358c865005855253af4f68a497John McCall      case CK_BitCast:
5293f85e193739c953358c865005855253af4f68a497John McCall      case CK_LValueBitCast:
5294f85e193739c953358c865005855253af4f68a497John McCall      case CK_LValueToRValue:
529533e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall      case CK_ARCReclaimReturnedObject:
5296f85e193739c953358c865005855253af4f68a497John McCall        e = cast->getSubExpr();
5297f85e193739c953358c865005855253af4f68a497John McCall        continue;
5298f85e193739c953358c865005855253af4f68a497John McCall
5299f85e193739c953358c865005855253af4f68a497John McCall      default:
5300f85e193739c953358c865005855253af4f68a497John McCall        return false;
5301f85e193739c953358c865005855253af4f68a497John McCall      }
5302f85e193739c953358c865005855253af4f68a497John McCall    }
5303f85e193739c953358c865005855253af4f68a497John McCall
5304f85e193739c953358c865005855253af4f68a497John McCall    if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) {
5305f85e193739c953358c865005855253af4f68a497John McCall      ObjCIvarDecl *ivar = ref->getDecl();
5306f85e193739c953358c865005855253af4f68a497John McCall      if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong)
5307f85e193739c953358c865005855253af4f68a497John McCall        return false;
5308f85e193739c953358c865005855253af4f68a497John McCall
5309f85e193739c953358c865005855253af4f68a497John McCall      // Try to find a retain cycle in the base.
53106e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian      if (!findRetainCycleOwner(S, ref->getBase(), owner))
5311f85e193739c953358c865005855253af4f68a497John McCall        return false;
5312f85e193739c953358c865005855253af4f68a497John McCall
5313f85e193739c953358c865005855253af4f68a497John McCall      if (ref->isFreeIvar()) owner.setLocsFrom(ref);
5314f85e193739c953358c865005855253af4f68a497John McCall      owner.Indirect = true;
5315f85e193739c953358c865005855253af4f68a497John McCall      return true;
5316f85e193739c953358c865005855253af4f68a497John McCall    }
5317f85e193739c953358c865005855253af4f68a497John McCall
5318f85e193739c953358c865005855253af4f68a497John McCall    if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) {
5319f85e193739c953358c865005855253af4f68a497John McCall      VarDecl *var = dyn_cast<VarDecl>(ref->getDecl());
5320f85e193739c953358c865005855253af4f68a497John McCall      if (!var) return false;
5321f85e193739c953358c865005855253af4f68a497John McCall      return considerVariable(var, ref, owner);
5322f85e193739c953358c865005855253af4f68a497John McCall    }
5323f85e193739c953358c865005855253af4f68a497John McCall
5324f85e193739c953358c865005855253af4f68a497John McCall    if (MemberExpr *member = dyn_cast<MemberExpr>(e)) {
5325f85e193739c953358c865005855253af4f68a497John McCall      if (member->isArrow()) return false;
5326f85e193739c953358c865005855253af4f68a497John McCall
5327f85e193739c953358c865005855253af4f68a497John McCall      // Don't count this as an indirect ownership.
5328f85e193739c953358c865005855253af4f68a497John McCall      e = member->getBase();
5329f85e193739c953358c865005855253af4f68a497John McCall      continue;
5330f85e193739c953358c865005855253af4f68a497John McCall    }
5331f85e193739c953358c865005855253af4f68a497John McCall
53324b9c2d235fb9449e249d74f48ecfec601650de93John McCall    if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) {
53334b9c2d235fb9449e249d74f48ecfec601650de93John McCall      // Only pay attention to pseudo-objects on property references.
53344b9c2d235fb9449e249d74f48ecfec601650de93John McCall      ObjCPropertyRefExpr *pre
53354b9c2d235fb9449e249d74f48ecfec601650de93John McCall        = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm()
53364b9c2d235fb9449e249d74f48ecfec601650de93John McCall                                              ->IgnoreParens());
53374b9c2d235fb9449e249d74f48ecfec601650de93John McCall      if (!pre) return false;
53384b9c2d235fb9449e249d74f48ecfec601650de93John McCall      if (pre->isImplicitProperty()) return false;
53394b9c2d235fb9449e249d74f48ecfec601650de93John McCall      ObjCPropertyDecl *property = pre->getExplicitProperty();
53404b9c2d235fb9449e249d74f48ecfec601650de93John McCall      if (!property->isRetaining() &&
53414b9c2d235fb9449e249d74f48ecfec601650de93John McCall          !(property->getPropertyIvarDecl() &&
53424b9c2d235fb9449e249d74f48ecfec601650de93John McCall            property->getPropertyIvarDecl()->getType()
53434b9c2d235fb9449e249d74f48ecfec601650de93John McCall              .getObjCLifetime() == Qualifiers::OCL_Strong))
53444b9c2d235fb9449e249d74f48ecfec601650de93John McCall          return false;
53454b9c2d235fb9449e249d74f48ecfec601650de93John McCall
53464b9c2d235fb9449e249d74f48ecfec601650de93John McCall      owner.Indirect = true;
53476e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian      if (pre->isSuperReceiver()) {
53486e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        owner.Variable = S.getCurMethodDecl()->getSelfDecl();
53496e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        if (!owner.Variable)
53506e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian          return false;
53516e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        owner.Loc = pre->getLocation();
53526e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        owner.Range = pre->getSourceRange();
53536e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        return true;
53546e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian      }
53554b9c2d235fb9449e249d74f48ecfec601650de93John McCall      e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase())
53564b9c2d235fb9449e249d74f48ecfec601650de93John McCall                              ->getSourceExpr());
53574b9c2d235fb9449e249d74f48ecfec601650de93John McCall      continue;
53584b9c2d235fb9449e249d74f48ecfec601650de93John McCall    }
53594b9c2d235fb9449e249d74f48ecfec601650de93John McCall
5360f85e193739c953358c865005855253af4f68a497John McCall    // Array ivars?
5361f85e193739c953358c865005855253af4f68a497John McCall
5362f85e193739c953358c865005855253af4f68a497John McCall    return false;
5363f85e193739c953358c865005855253af4f68a497John McCall  }
5364f85e193739c953358c865005855253af4f68a497John McCall}
5365f85e193739c953358c865005855253af4f68a497John McCall
5366f85e193739c953358c865005855253af4f68a497John McCallnamespace {
5367f85e193739c953358c865005855253af4f68a497John McCall  struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> {
5368f85e193739c953358c865005855253af4f68a497John McCall    FindCaptureVisitor(ASTContext &Context, VarDecl *variable)
5369f85e193739c953358c865005855253af4f68a497John McCall      : EvaluatedExprVisitor<FindCaptureVisitor>(Context),
5370f85e193739c953358c865005855253af4f68a497John McCall        Variable(variable), Capturer(0) {}
5371f85e193739c953358c865005855253af4f68a497John McCall
5372f85e193739c953358c865005855253af4f68a497John McCall    VarDecl *Variable;
5373f85e193739c953358c865005855253af4f68a497John McCall    Expr *Capturer;
5374f85e193739c953358c865005855253af4f68a497John McCall
5375f85e193739c953358c865005855253af4f68a497John McCall    void VisitDeclRefExpr(DeclRefExpr *ref) {
5376f85e193739c953358c865005855253af4f68a497John McCall      if (ref->getDecl() == Variable && !Capturer)
5377f85e193739c953358c865005855253af4f68a497John McCall        Capturer = ref;
5378f85e193739c953358c865005855253af4f68a497John McCall    }
5379f85e193739c953358c865005855253af4f68a497John McCall
5380f85e193739c953358c865005855253af4f68a497John McCall    void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) {
5381f85e193739c953358c865005855253af4f68a497John McCall      if (Capturer) return;
5382f85e193739c953358c865005855253af4f68a497John McCall      Visit(ref->getBase());
5383f85e193739c953358c865005855253af4f68a497John McCall      if (Capturer && ref->isFreeIvar())
5384f85e193739c953358c865005855253af4f68a497John McCall        Capturer = ref;
5385f85e193739c953358c865005855253af4f68a497John McCall    }
5386f85e193739c953358c865005855253af4f68a497John McCall
5387f85e193739c953358c865005855253af4f68a497John McCall    void VisitBlockExpr(BlockExpr *block) {
5388f85e193739c953358c865005855253af4f68a497John McCall      // Look inside nested blocks
5389f85e193739c953358c865005855253af4f68a497John McCall      if (block->getBlockDecl()->capturesVariable(Variable))
5390f85e193739c953358c865005855253af4f68a497John McCall        Visit(block->getBlockDecl()->getBody());
5391f85e193739c953358c865005855253af4f68a497John McCall    }
53927e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian
53937e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian    void VisitOpaqueValueExpr(OpaqueValueExpr *OVE) {
53947e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian      if (Capturer) return;
53957e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian      if (OVE->getSourceExpr())
53967e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian        Visit(OVE->getSourceExpr());
53977e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian    }
5398f85e193739c953358c865005855253af4f68a497John McCall  };
5399f85e193739c953358c865005855253af4f68a497John McCall}
5400f85e193739c953358c865005855253af4f68a497John McCall
5401f85e193739c953358c865005855253af4f68a497John McCall/// Check whether the given argument is a block which captures a
5402f85e193739c953358c865005855253af4f68a497John McCall/// variable.
5403f85e193739c953358c865005855253af4f68a497John McCallstatic Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) {
5404f85e193739c953358c865005855253af4f68a497John McCall  assert(owner.Variable && owner.Loc.isValid());
5405f85e193739c953358c865005855253af4f68a497John McCall
5406f85e193739c953358c865005855253af4f68a497John McCall  e = e->IgnoreParenCasts();
5407f85e193739c953358c865005855253af4f68a497John McCall  BlockExpr *block = dyn_cast<BlockExpr>(e);
5408f85e193739c953358c865005855253af4f68a497John McCall  if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable))
5409f85e193739c953358c865005855253af4f68a497John McCall    return 0;
5410f85e193739c953358c865005855253af4f68a497John McCall
5411f85e193739c953358c865005855253af4f68a497John McCall  FindCaptureVisitor visitor(S.Context, owner.Variable);
5412f85e193739c953358c865005855253af4f68a497John McCall  visitor.Visit(block->getBlockDecl()->getBody());
5413f85e193739c953358c865005855253af4f68a497John McCall  return visitor.Capturer;
5414f85e193739c953358c865005855253af4f68a497John McCall}
5415f85e193739c953358c865005855253af4f68a497John McCall
5416f85e193739c953358c865005855253af4f68a497John McCallstatic void diagnoseRetainCycle(Sema &S, Expr *capturer,
5417f85e193739c953358c865005855253af4f68a497John McCall                                RetainCycleOwner &owner) {
5418f85e193739c953358c865005855253af4f68a497John McCall  assert(capturer);
5419f85e193739c953358c865005855253af4f68a497John McCall  assert(owner.Variable && owner.Loc.isValid());
5420f85e193739c953358c865005855253af4f68a497John McCall
5421f85e193739c953358c865005855253af4f68a497John McCall  S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle)
5422f85e193739c953358c865005855253af4f68a497John McCall    << owner.Variable << capturer->getSourceRange();
5423f85e193739c953358c865005855253af4f68a497John McCall  S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner)
5424f85e193739c953358c865005855253af4f68a497John McCall    << owner.Indirect << owner.Range;
5425f85e193739c953358c865005855253af4f68a497John McCall}
5426f85e193739c953358c865005855253af4f68a497John McCall
5427f85e193739c953358c865005855253af4f68a497John McCall/// Check for a keyword selector that starts with the word 'add' or
5428f85e193739c953358c865005855253af4f68a497John McCall/// 'set'.
5429f85e193739c953358c865005855253af4f68a497John McCallstatic bool isSetterLikeSelector(Selector sel) {
5430f85e193739c953358c865005855253af4f68a497John McCall  if (sel.isUnarySelector()) return false;
5431f85e193739c953358c865005855253af4f68a497John McCall
54325f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner  StringRef str = sel.getNameForSlot(0);
5433f85e193739c953358c865005855253af4f68a497John McCall  while (!str.empty() && str.front() == '_') str = str.substr(1);
5434968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek  if (str.startswith("set"))
5435f85e193739c953358c865005855253af4f68a497John McCall    str = str.substr(3);
5436968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek  else if (str.startswith("add")) {
5437968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek    // Specially whitelist 'addOperationWithBlock:'.
5438968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek    if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock"))
5439968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek      return false;
5440968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek    str = str.substr(3);
5441968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek  }
5442f85e193739c953358c865005855253af4f68a497John McCall  else
5443f85e193739c953358c865005855253af4f68a497John McCall    return false;
5444f85e193739c953358c865005855253af4f68a497John McCall
5445f85e193739c953358c865005855253af4f68a497John McCall  if (str.empty()) return true;
5446f85e193739c953358c865005855253af4f68a497John McCall  return !islower(str.front());
5447f85e193739c953358c865005855253af4f68a497John McCall}
5448f85e193739c953358c865005855253af4f68a497John McCall
5449f85e193739c953358c865005855253af4f68a497John McCall/// Check a message send to see if it's likely to cause a retain cycle.
5450f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(ObjCMessageExpr *msg) {
5451f85e193739c953358c865005855253af4f68a497John McCall  // Only check instance methods whose selector looks like a setter.
5452f85e193739c953358c865005855253af4f68a497John McCall  if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector()))
5453f85e193739c953358c865005855253af4f68a497John McCall    return;
5454f85e193739c953358c865005855253af4f68a497John McCall
5455f85e193739c953358c865005855253af4f68a497John McCall  // Try to find a variable that the receiver is strongly owned by.
5456f85e193739c953358c865005855253af4f68a497John McCall  RetainCycleOwner owner;
5457f85e193739c953358c865005855253af4f68a497John McCall  if (msg->getReceiverKind() == ObjCMessageExpr::Instance) {
54586e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian    if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner))
5459f85e193739c953358c865005855253af4f68a497John McCall      return;
5460f85e193739c953358c865005855253af4f68a497John McCall  } else {
5461f85e193739c953358c865005855253af4f68a497John McCall    assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance);
5462f85e193739c953358c865005855253af4f68a497John McCall    owner.Variable = getCurMethodDecl()->getSelfDecl();
5463f85e193739c953358c865005855253af4f68a497John McCall    owner.Loc = msg->getSuperLoc();
5464f85e193739c953358c865005855253af4f68a497John McCall    owner.Range = msg->getSuperLoc();
5465f85e193739c953358c865005855253af4f68a497John McCall  }
5466f85e193739c953358c865005855253af4f68a497John McCall
5467f85e193739c953358c865005855253af4f68a497John McCall  // Check whether the receiver is captured by any of the arguments.
5468f85e193739c953358c865005855253af4f68a497John McCall  for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i)
5469f85e193739c953358c865005855253af4f68a497John McCall    if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner))
5470f85e193739c953358c865005855253af4f68a497John McCall      return diagnoseRetainCycle(*this, capturer, owner);
5471f85e193739c953358c865005855253af4f68a497John McCall}
5472f85e193739c953358c865005855253af4f68a497John McCall
5473f85e193739c953358c865005855253af4f68a497John McCall/// Check a property assign to see if it's likely to cause a retain cycle.
5474f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(Expr *receiver, Expr *argument) {
5475f85e193739c953358c865005855253af4f68a497John McCall  RetainCycleOwner owner;
54766e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian  if (!findRetainCycleOwner(*this, receiver, owner))
5477f85e193739c953358c865005855253af4f68a497John McCall    return;
5478f85e193739c953358c865005855253af4f68a497John McCall
5479f85e193739c953358c865005855253af4f68a497John McCall  if (Expr *capturer = findCapturingExpr(*this, argument, owner))
5480f85e193739c953358c865005855253af4f68a497John McCall    diagnoseRetainCycle(*this, capturer, owner);
5481f85e193739c953358c865005855253af4f68a497John McCall}
5482f85e193739c953358c865005855253af4f68a497John McCall
5483921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianbool Sema::checkUnsafeAssigns(SourceLocation Loc,
5484f85e193739c953358c865005855253af4f68a497John McCall                              QualType LHS, Expr *RHS) {
5485f85e193739c953358c865005855253af4f68a497John McCall  Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime();
5486f85e193739c953358c865005855253af4f68a497John McCall  if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone)
5487921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    return false;
5488921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  // strip off any implicit cast added to get to the one arc-specific
5489921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
549033e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall    if (cast->getCastKind() == CK_ARCConsumeObject) {
5491f85e193739c953358c865005855253af4f68a497John McCall      Diag(Loc, diag::warn_arc_retained_assign)
5492bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian        << (LT == Qualifiers::OCL_ExplicitNone) << 1
5493f85e193739c953358c865005855253af4f68a497John McCall        << RHS->getSourceRange();
5494921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian      return true;
5495921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    }
5496921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    RHS = cast->getSubExpr();
5497921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  }
5498921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  return false;
5499f85e193739c953358c865005855253af4f68a497John McCall}
5500f85e193739c953358c865005855253af4f68a497John McCall
5501921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianvoid Sema::checkUnsafeExprAssigns(SourceLocation Loc,
5502921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian                              Expr *LHS, Expr *RHS) {
550387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  QualType LHSType;
550487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  // PropertyRef on LHS type need be directly obtained from
550587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  // its declaration as it has a PsuedoType.
550687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  ObjCPropertyRefExpr *PRE
550787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens());
550887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  if (PRE && !PRE->isImplicitProperty()) {
550987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    const ObjCPropertyDecl *PD = PRE->getExplicitProperty();
551087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    if (PD)
551187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      LHSType = PD->getType();
551287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  }
551387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian
551487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  if (LHSType.isNull())
551587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    LHSType = LHS->getType();
5516921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  if (checkUnsafeAssigns(Loc, LHSType, RHS))
5517921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    return;
5518921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime();
5519921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  // FIXME. Check for other life times.
5520921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  if (LT != Qualifiers::OCL_None)
5521921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    return;
5522921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian
552387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  if (PRE) {
5524921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    if (PRE->isImplicitProperty())
5525921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian      return;
5526921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    const ObjCPropertyDecl *PD = PRE->getExplicitProperty();
5527921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    if (!PD)
5528921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian      return;
5529921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian
5530921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    unsigned Attributes = PD->getPropertyAttributes();
553187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) {
553287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      // when 'assign' attribute was not explicitly specified
553387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      // by user, ignore it and rely on property type itself
553487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      // for lifetime info.
553587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten();
553687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) &&
553787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian          LHSType->isObjCRetainableType())
553887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian        return;
553987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian
5540921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian      while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
554133e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall        if (cast->getCastKind() == CK_ARCConsumeObject) {
5542921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian          Diag(Loc, diag::warn_arc_retained_property_assign)
5543921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian          << RHS->getSourceRange();
5544921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian          return;
5545921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian        }
5546921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian        RHS = cast->getSubExpr();
5547921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian      }
554887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    }
5549bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian    else if (Attributes & ObjCPropertyDecl::OBJC_PR_weak) {
5550bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian      while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
5551bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian        if (cast->getCastKind() == CK_ARCConsumeObject) {
5552bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian          Diag(Loc, diag::warn_arc_retained_assign)
5553bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian          << 0 << 0<< RHS->getSourceRange();
5554bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian          return;
5555bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian        }
5556bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian        RHS = cast->getSubExpr();
5557bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian      }
5558bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian    }
5559921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  }
5560921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian}
5561625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5562625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko//===--- CHECK: Empty statement body (-Wempty-body) ---------------------===//
5563625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5564625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkonamespace {
5565625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkobool ShouldDiagnoseEmptyStmtBody(const SourceManager &SourceMgr,
5566625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 SourceLocation StmtLoc,
5567625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 const NullStmt *Body) {
5568625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Do not warn if the body is a macro that expands to nothing, e.g:
5569625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //
5570625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // #define CALL(x)
5571625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // if (condition)
5572625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //   CALL(0);
5573625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //
5574625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (Body->hasLeadingEmptyMacro())
5575625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return false;
5576625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5577625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Get line numbers of statement and body.
5578625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  bool StmtLineInvalid;
5579625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  unsigned StmtLine = SourceMgr.getSpellingLineNumber(StmtLoc,
5580625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                                      &StmtLineInvalid);
5581625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (StmtLineInvalid)
5582625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return false;
5583625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5584625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  bool BodyLineInvalid;
5585625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  unsigned BodyLine = SourceMgr.getSpellingLineNumber(Body->getSemiLoc(),
5586625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                                      &BodyLineInvalid);
5587625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (BodyLineInvalid)
5588625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return false;
5589625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5590625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Warn if null statement and body are on the same line.
5591625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (StmtLine != BodyLine)
5592625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return false;
5593625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5594625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  return true;
5595625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko}
5596625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} // Unnamed namespace
5597625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5598625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyStmtBody(SourceLocation StmtLoc,
5599625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 const Stmt *Body,
5600625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 unsigned DiagID) {
5601625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Since this is a syntactic check, don't emit diagnostic for template
5602625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // instantiations, this just adds noise.
5603625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (CurrentInstantiationScope)
5604625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
5605625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5606625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // The body should be a null statement.
5607625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  const NullStmt *NBody = dyn_cast<NullStmt>(Body);
5608625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!NBody)
5609625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
5610625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5611625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Do the usual checks.
5612625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody))
5613625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
5614625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5615625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  Diag(NBody->getSemiLoc(), DiagID);
5616625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line);
5617625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko}
5618625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5619625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyLoopBody(const Stmt *S,
5620625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 const Stmt *PossibleBody) {
5621625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  assert(!CurrentInstantiationScope); // Ensured by caller
5622625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5623625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  SourceLocation StmtLoc;
5624625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  const Stmt *Body;
5625625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  unsigned DiagID;
5626625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (const ForStmt *FS = dyn_cast<ForStmt>(S)) {
5627625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    StmtLoc = FS->getRParenLoc();
5628625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    Body = FS->getBody();
5629625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    DiagID = diag::warn_empty_for_body;
5630625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  } else if (const WhileStmt *WS = dyn_cast<WhileStmt>(S)) {
5631625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    StmtLoc = WS->getCond()->getSourceRange().getEnd();
5632625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    Body = WS->getBody();
5633625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    DiagID = diag::warn_empty_while_body;
5634625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  } else
5635625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return; // Neither `for' nor `while'.
5636625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5637625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // The body should be a null statement.
5638625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  const NullStmt *NBody = dyn_cast<NullStmt>(Body);
5639625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!NBody)
5640625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
5641625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5642625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Skip expensive checks if diagnostic is disabled.
5643625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (Diags.getDiagnosticLevel(DiagID, NBody->getSemiLoc()) ==
5644625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko          DiagnosticsEngine::Ignored)
5645625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
5646625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5647625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Do the usual checks.
5648625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody))
5649625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
5650625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5651625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // `for(...);' and `while(...);' are popular idioms, so in order to keep
5652625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // noise level low, emit diagnostics only if for/while is followed by a
5653625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // CompoundStmt, e.g.:
5654625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //    for (int i = 0; i < n; i++);
5655625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //    {
5656625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //      a(i);
5657625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //    }
5658625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // or if for/while is followed by a statement with more indentation
5659625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // than for/while itself:
5660625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //    for (int i = 0; i < n; i++);
5661625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //      a(i);
5662625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  bool ProbableTypo = isa<CompoundStmt>(PossibleBody);
5663625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!ProbableTypo) {
5664625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    bool BodyColInvalid;
5665625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    unsigned BodyCol = SourceMgr.getPresumedColumnNumber(
5666625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                             PossibleBody->getLocStart(),
5667625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                             &BodyColInvalid);
5668625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    if (BodyColInvalid)
5669625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko      return;
5670625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5671625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    bool StmtColInvalid;
5672625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    unsigned StmtCol = SourceMgr.getPresumedColumnNumber(
5673625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                             S->getLocStart(),
5674625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                             &StmtColInvalid);
5675625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    if (StmtColInvalid)
5676625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko      return;
5677625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5678625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    if (BodyCol > StmtCol)
5679625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko      ProbableTypo = true;
5680625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  }
5681625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5682625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (ProbableTypo) {
5683625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    Diag(NBody->getSemiLoc(), DiagID);
5684625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line);
5685625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  }
5686625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko}
56870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
56880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- Layout compatibility ----------------------------------------------//
56890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
56900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace {
56910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
56920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2);
56930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
56940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two enumeration types are layout-compatible.
56950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, EnumDecl *ED1, EnumDecl *ED2) {
56960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // C++11 [dcl.enum] p8:
56970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // Two enumeration types are layout-compatible if they have the same
56980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // underlying type.
56990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return ED1->isComplete() && ED2->isComplete() &&
57000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         C.hasSameType(ED1->getIntegerType(), ED2->getIntegerType());
57010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
57020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
57030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two fields are layout-compatible.
57040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, FieldDecl *Field1, FieldDecl *Field2) {
57050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!isLayoutCompatible(C, Field1->getType(), Field2->getType()))
57060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
57070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
57080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (Field1->isBitField() != Field2->isBitField())
57090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
57100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
57110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (Field1->isBitField()) {
57120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // Make sure that the bit-fields are the same length.
57130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    unsigned Bits1 = Field1->getBitWidthValue(C);
57140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    unsigned Bits2 = Field2->getBitWidthValue(C);
57150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
57160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (Bits1 != Bits2)
57170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
57180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
57190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
57200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return true;
57210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
57220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
57230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout structs are layout-compatible.
57240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p17)
57250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleStruct(ASTContext &C,
57260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                              RecordDecl *RD1,
57270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                              RecordDecl *RD2) {
57280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // If both records are C++ classes, check that base classes match.
57290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (const CXXRecordDecl *D1CXX = dyn_cast<CXXRecordDecl>(RD1)) {
57300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // If one of records is a CXXRecordDecl we are in C++ mode,
57310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // thus the other one is a CXXRecordDecl, too.
57320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    const CXXRecordDecl *D2CXX = cast<CXXRecordDecl>(RD2);
57330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // Check number of base classes.
57340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (D1CXX->getNumBases() != D2CXX->getNumBases())
57350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
57360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
57370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // Check the base classes.
57380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    for (CXXRecordDecl::base_class_const_iterator
57390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko               Base1 = D1CXX->bases_begin(),
57400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko           BaseEnd1 = D1CXX->bases_end(),
57410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko              Base2 = D2CXX->bases_begin();
57420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         Base1 != BaseEnd1;
57430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         ++Base1, ++Base2) {
57440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (!isLayoutCompatible(C, Base1->getType(), Base2->getType()))
57450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        return false;
57460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
57470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  } else if (const CXXRecordDecl *D2CXX = dyn_cast<CXXRecordDecl>(RD2)) {
57480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // If only RD2 is a C++ class, it should have zero base classes.
57490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (D2CXX->getNumBases() > 0)
57500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
57510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
57520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
57530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // Check the fields.
57540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  RecordDecl::field_iterator Field2 = RD2->field_begin(),
57550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                             Field2End = RD2->field_end(),
57560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                             Field1 = RD1->field_begin(),
57570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                             Field1End = RD1->field_end();
57580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  for ( ; Field1 != Field1End && Field2 != Field2End; ++Field1, ++Field2) {
57590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (!isLayoutCompatible(C, *Field1, *Field2))
57600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
57610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
57620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (Field1 != Field1End || Field2 != Field2End)
57630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
57640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
57650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return true;
57660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
57670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
57680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout unions are layout-compatible.
57690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p18)
57700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleUnion(ASTContext &C,
57710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                             RecordDecl *RD1,
57720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                             RecordDecl *RD2) {
57730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  llvm::SmallPtrSet<FieldDecl *, 8> UnmatchedFields;
57740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  for (RecordDecl::field_iterator Field2 = RD2->field_begin(),
57750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                  Field2End = RD2->field_end();
57760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko       Field2 != Field2End; ++Field2) {
57770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    UnmatchedFields.insert(*Field2);
57780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
57790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
57800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  for (RecordDecl::field_iterator Field1 = RD1->field_begin(),
57810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                  Field1End = RD1->field_end();
57820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko       Field1 != Field1End; ++Field1) {
57830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    llvm::SmallPtrSet<FieldDecl *, 8>::iterator
57840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        I = UnmatchedFields.begin(),
57850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        E = UnmatchedFields.end();
57860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
57870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    for ( ; I != E; ++I) {
57880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (isLayoutCompatible(C, *Field1, *I)) {
57890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        bool Result = UnmatchedFields.erase(*I);
57900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        (void) Result;
57910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        assert(Result);
57920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        break;
57930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      }
57940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
57950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (I == E)
57960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
57970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
57980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
57990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return UnmatchedFields.empty();
58000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
58010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, RecordDecl *RD1, RecordDecl *RD2) {
58030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (RD1->isUnion() != RD2->isUnion())
58040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
58050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (RD1->isUnion())
58070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return isLayoutCompatibleUnion(C, RD1, RD2);
58080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  else
58090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return isLayoutCompatibleStruct(C, RD1, RD2);
58100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
58110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two types are layout-compatible in C++11 sense.
58130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2) {
58140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (T1.isNull() || T2.isNull())
58150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
58160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // C++11 [basic.types] p11:
58180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // If two types T1 and T2 are the same type, then T1 and T2 are
58190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // layout-compatible types.
58200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (C.hasSameType(T1, T2))
58210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return true;
58220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  T1 = T1.getCanonicalType().getUnqualifiedType();
58240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  T2 = T2.getCanonicalType().getUnqualifiedType();
58250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const Type::TypeClass TC1 = T1->getTypeClass();
58270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const Type::TypeClass TC2 = T2->getTypeClass();
58280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (TC1 != TC2)
58300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
58310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (TC1 == Type::Enum) {
58330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return isLayoutCompatible(C,
58340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                              cast<EnumType>(T1)->getDecl(),
58350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                              cast<EnumType>(T2)->getDecl());
58360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  } else if (TC1 == Type::Record) {
58370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (!T1->isStandardLayoutType() || !T2->isStandardLayoutType())
58380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
58390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return isLayoutCompatible(C,
58410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                              cast<RecordType>(T1)->getDecl(),
58420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                              cast<RecordType>(T2)->getDecl());
58430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
58440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return false;
58460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
58470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
58480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- CHECK: pointer_with_type_tag attribute: datatypes should match ----//
58500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace {
58520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Given a type tag expression find the type tag itself.
58530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
58540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Type tag expression, as it appears in user's code.
58550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
58560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param VD Declaration of an identifier that appears in a type tag.
58570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
58580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValue Type tag magic value.
58590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool FindTypeTagExpr(const Expr *TypeExpr, const ASTContext &Ctx,
58600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                     const ValueDecl **VD, uint64_t *MagicValue) {
58610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  while(true) {
58620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (!TypeExpr)
58630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
58640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    TypeExpr = TypeExpr->IgnoreParenImpCasts()->IgnoreParenCasts();
58660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    switch (TypeExpr->getStmtClass()) {
58680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    case Stmt::UnaryOperatorClass: {
58690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      const UnaryOperator *UO = cast<UnaryOperator>(TypeExpr);
58700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (UO->getOpcode() == UO_AddrOf || UO->getOpcode() == UO_Deref) {
58710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        TypeExpr = UO->getSubExpr();
58720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        continue;
58730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      }
58740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
58750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
58760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    case Stmt::DeclRefExprClass: {
58780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      const DeclRefExpr *DRE = cast<DeclRefExpr>(TypeExpr);
58790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      *VD = DRE->getDecl();
58800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return true;
58810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
58820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    case Stmt::IntegerLiteralClass: {
58840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      const IntegerLiteral *IL = cast<IntegerLiteral>(TypeExpr);
58850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      llvm::APInt MagicValueAPInt = IL->getValue();
58860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (MagicValueAPInt.getActiveBits() <= 64) {
58870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        *MagicValue = MagicValueAPInt.getZExtValue();
58880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        return true;
58890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      } else
58900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        return false;
58910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
58920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    case Stmt::BinaryConditionalOperatorClass:
58940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    case Stmt::ConditionalOperatorClass: {
58950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      const AbstractConditionalOperator *ACO =
58960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          cast<AbstractConditionalOperator>(TypeExpr);
58970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      bool Result;
58980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (ACO->getCond()->EvaluateAsBooleanCondition(Result, Ctx)) {
58990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        if (Result)
59000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          TypeExpr = ACO->getTrueExpr();
59010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        else
59020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          TypeExpr = ACO->getFalseExpr();
59030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        continue;
59040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      }
59050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
59060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
59070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    case Stmt::BinaryOperatorClass: {
59090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      const BinaryOperator *BO = cast<BinaryOperator>(TypeExpr);
59100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (BO->getOpcode() == BO_Comma) {
59110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        TypeExpr = BO->getRHS();
59120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        continue;
59130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      }
59140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
59150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
59160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    default:
59180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
59190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
59200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
59210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
59220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Retrieve the C type corresponding to type tag TypeExpr.
59240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
59250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Expression that specifies a type tag.
59260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
59270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValues Registered magic values.
59280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
59290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param FoundWrongKind Set to true if a type tag was found, but of a wrong
59300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///        kind.
59310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
59320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeInfo Information about the corresponding C type.
59330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
59340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \returns true if the corresponding C type was found.
59350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool GetMatchingCType(
59360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        const IdentifierInfo *ArgumentKind,
59370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        const Expr *TypeExpr, const ASTContext &Ctx,
59380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        const llvm::DenseMap<Sema::TypeTagMagicValue,
59390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                             Sema::TypeTagData> *MagicValues,
59400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        bool &FoundWrongKind,
59410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        Sema::TypeTagData &TypeInfo) {
59420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  FoundWrongKind = false;
59430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // Variable declaration that has type_tag_for_datatype attribute.
59450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const ValueDecl *VD = NULL;
59460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  uint64_t MagicValue;
59480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!FindTypeTagExpr(TypeExpr, Ctx, &VD, &MagicValue))
59500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
59510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (VD) {
59530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    for (specific_attr_iterator<TypeTagForDatatypeAttr>
59540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko             I = VD->specific_attr_begin<TypeTagForDatatypeAttr>(),
59550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko             E = VD->specific_attr_end<TypeTagForDatatypeAttr>();
59560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         I != E; ++I) {
59570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (I->getArgumentKind() != ArgumentKind) {
59580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        FoundWrongKind = true;
59590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        return false;
59600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      }
59610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      TypeInfo.Type = I->getMatchingCType();
59620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      TypeInfo.LayoutCompatible = I->getLayoutCompatible();
59630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      TypeInfo.MustBeNull = I->getMustBeNull();
59640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return true;
59650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
59660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
59670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
59680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!MagicValues)
59700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
59710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  llvm::DenseMap<Sema::TypeTagMagicValue,
59730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                 Sema::TypeTagData>::const_iterator I =
59740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      MagicValues->find(std::make_pair(ArgumentKind, MagicValue));
59750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (I == MagicValues->end())
59760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
59770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  TypeInfo = I->second;
59790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return true;
59800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
59810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace
59820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::RegisterTypeTagForDatatype(const IdentifierInfo *ArgumentKind,
59840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                      uint64_t MagicValue, QualType Type,
59850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                      bool LayoutCompatible,
59860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                      bool MustBeNull) {
59870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!TypeTagForDatatypeMagicValues)
59880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    TypeTagForDatatypeMagicValues.reset(
59890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        new llvm::DenseMap<TypeTagMagicValue, TypeTagData>);
59900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  TypeTagMagicValue Magic(ArgumentKind, MagicValue);
59920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  (*TypeTagForDatatypeMagicValues)[Magic] =
59930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      TypeTagData(Type, LayoutCompatible, MustBeNull);
59940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
59950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace {
59970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool IsSameCharType(QualType T1, QualType T2) {
59980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const BuiltinType *BT1 = T1->getAs<BuiltinType>();
59990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!BT1)
60000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
60010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const BuiltinType *BT2 = T2->getAs<BuiltinType>();
60030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!BT2)
60040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
60050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  BuiltinType::Kind T1Kind = BT1->getKind();
60070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  BuiltinType::Kind T2Kind = BT2->getKind();
60080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return (T1Kind == BuiltinType::SChar  && T2Kind == BuiltinType::Char_S) ||
60100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         (T1Kind == BuiltinType::UChar  && T2Kind == BuiltinType::Char_U) ||
60110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         (T1Kind == BuiltinType::Char_U && T2Kind == BuiltinType::UChar) ||
60120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         (T1Kind == BuiltinType::Char_S && T2Kind == BuiltinType::SChar);
60130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
60140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace
60150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::CheckArgumentWithTypeTag(const ArgumentWithTypeTagAttr *Attr,
60170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                    const Expr * const *ExprArgs) {
60180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const IdentifierInfo *ArgumentKind = Attr->getArgumentKind();
60190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  bool IsPointerAttr = Attr->getIsPointer();
60200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const Expr *TypeTagExpr = ExprArgs[Attr->getTypeTagIdx()];
60220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  bool FoundWrongKind;
60230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  TypeTagData TypeInfo;
60240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!GetMatchingCType(ArgumentKind, TypeTagExpr, Context,
60250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                        TypeTagForDatatypeMagicValues.get(),
60260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                        FoundWrongKind, TypeInfo)) {
60270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (FoundWrongKind)
60280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      Diag(TypeTagExpr->getExprLoc(),
60290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko           diag::warn_type_tag_for_datatype_wrong_kind)
60300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        << TypeTagExpr->getSourceRange();
60310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return;
60320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
60330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const Expr *ArgumentExpr = ExprArgs[Attr->getArgumentIdx()];
60350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (IsPointerAttr) {
60360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // Skip implicit cast of pointer to `void *' (as a function argument).
60370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(ArgumentExpr))
60380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (ICE->getType()->isVoidPointerType())
60390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        ArgumentExpr = ICE->getSubExpr();
60400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
60410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  QualType ArgumentType = ArgumentExpr->getType();
60420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // Passing a `void*' pointer shouldn't trigger a warning.
60440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (IsPointerAttr && ArgumentType->isVoidPointerType())
60450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return;
60460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (TypeInfo.MustBeNull) {
60480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // Type tag with matching void type requires a null pointer.
60490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (!ArgumentExpr->isNullPointerConstant(Context,
60500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                             Expr::NPC_ValueDependentIsNotNull)) {
60510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      Diag(ArgumentExpr->getExprLoc(),
60520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko           diag::warn_type_safety_null_pointer_required)
60530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          << ArgumentKind->getName()
60540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          << ArgumentExpr->getSourceRange()
60550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          << TypeTagExpr->getSourceRange();
60560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
60570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return;
60580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
60590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  QualType RequiredType = TypeInfo.Type;
60610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (IsPointerAttr)
60620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    RequiredType = Context.getPointerType(RequiredType);
60630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  bool mismatch = false;
60650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!TypeInfo.LayoutCompatible) {
60660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    mismatch = !Context.hasSameType(ArgumentType, RequiredType);
60670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // C++11 [basic.fundamental] p1:
60690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // Plain char, signed char, and unsigned char are three distinct types.
60700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    //
60710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // But we treat plain `char' as equivalent to `signed char' or `unsigned
60720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // char' depending on the current char signedness mode.
60730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (mismatch)
60740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if ((IsPointerAttr && IsSameCharType(ArgumentType->getPointeeType(),
60750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                           RequiredType->getPointeeType())) ||
60760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          (!IsPointerAttr && IsSameCharType(ArgumentType, RequiredType)))
60770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        mismatch = false;
60780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  } else
60790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (IsPointerAttr)
60800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      mismatch = !isLayoutCompatible(Context,
60810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                     ArgumentType->getPointeeType(),
60820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                     RequiredType->getPointeeType());
60830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    else
60840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      mismatch = !isLayoutCompatible(Context, ArgumentType, RequiredType);
60850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (mismatch)
60870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    Diag(ArgumentExpr->getExprLoc(), diag::warn_type_safety_type_mismatch)
60880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        << ArgumentType << ArgumentKind->getName()
60890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        << TypeInfo.LayoutCompatible << RequiredType
60900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        << ArgumentExpr->getSourceRange()
60910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        << TypeTagExpr->getSourceRange();
60920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
60930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
6094