19d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===--- SemaObjCProperty.cpp - Semantic Analysis for ObjC @property ------===// 29d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 39d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// The LLVM Compiler Infrastructure 49d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 59d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file is distributed under the University of Illinois Open Source 69d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// License. See LICENSE.TXT for details. 79d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 89d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 99d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file implements semantic analysis for Objective C @property and 119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// @synthesize declarations. 129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Initialization.h" 177cd088e519d7e6caa4c4c12db52e0e4ae35d25c2John McCall#include "clang/AST/DeclObjC.h" 1817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian#include "clang/AST/ExprObjC.h" 1957e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian#include "clang/AST/ExprCXX.h" 20c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis#include "clang/AST/ASTMutationListener.h" 21edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian#include "clang/Lex/Lexer.h" 22edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian#include "clang/Basic/SourceManager.h" 2350df6ae41f232612e5e88b19e0db9900d08d2f6cJohn McCall#include "llvm/ADT/DenseSet.h" 248fe83e1df954d72c0f4ffc15d20a5222ec151c21Benjamin Kramer#include "llvm/ADT/SmallString.h" 259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekusing namespace clang; 279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Grammar actions. 3028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 3128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 32265941bc308d65cc270d5c4de5806f37ce405606John McCall/// getImpliedARCOwnership - Given a set of property attributes and a 33265941bc308d65cc270d5c4de5806f37ce405606John McCall/// type, infer an expected lifetime. The type's ownership qualification 34265941bc308d65cc270d5c4de5806f37ce405606John McCall/// is not considered. 35265941bc308d65cc270d5c4de5806f37ce405606John McCall/// 36265941bc308d65cc270d5c4de5806f37ce405606John McCall/// Returns OCL_None if the attributes as stated do not imply an ownership. 37265941bc308d65cc270d5c4de5806f37ce405606John McCall/// Never returns OCL_Autoreleasing. 38265941bc308d65cc270d5c4de5806f37ce405606John McCallstatic Qualifiers::ObjCLifetime getImpliedARCOwnership( 39265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::PropertyAttributeKind attrs, 40265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType type) { 41265941bc308d65cc270d5c4de5806f37ce405606John McCall // retain, strong, copy, weak, and unsafe_unretained are only legal 42265941bc308d65cc270d5c4de5806f37ce405606John McCall // on properties of retainable pointer type. 43265941bc308d65cc270d5c4de5806f37ce405606John McCall if (attrs & (ObjCPropertyDecl::OBJC_PR_retain | 44265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::OBJC_PR_strong | 45265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::OBJC_PR_copy)) { 46d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall return Qualifiers::OCL_Strong; 47265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (attrs & ObjCPropertyDecl::OBJC_PR_weak) { 48265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_Weak; 49265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (attrs & ObjCPropertyDecl::OBJC_PR_unsafe_unretained) { 50265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_ExplicitNone; 51265941bc308d65cc270d5c4de5806f37ce405606John McCall } 52265941bc308d65cc270d5c4de5806f37ce405606John McCall 53265941bc308d65cc270d5c4de5806f37ce405606John McCall // assign can appear on other types, so we have to check the 54265941bc308d65cc270d5c4de5806f37ce405606John McCall // property type. 55265941bc308d65cc270d5c4de5806f37ce405606John McCall if (attrs & ObjCPropertyDecl::OBJC_PR_assign && 56265941bc308d65cc270d5c4de5806f37ce405606John McCall type->isObjCRetainableType()) { 57265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_ExplicitNone; 58265941bc308d65cc270d5c4de5806f37ce405606John McCall } 59265941bc308d65cc270d5c4de5806f37ce405606John McCall 60265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_None; 61265941bc308d65cc270d5c4de5806f37ce405606John McCall} 62265941bc308d65cc270d5c4de5806f37ce405606John McCall 63f85e193739c953358c865005855253af4f68a497John McCall/// Check the internal consistency of a property declaration. 64f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyDecl(Sema &S, ObjCPropertyDecl *property) { 65f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl()) return; 66f85e193739c953358c865005855253af4f68a497John McCall 67f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind propertyKind 68f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 69f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime propertyLifetime 70f85e193739c953358c865005855253af4f68a497John McCall = property->getType().getObjCLifetime(); 71f85e193739c953358c865005855253af4f68a497John McCall 72f85e193739c953358c865005855253af4f68a497John McCall // Nothing to do if we don't have a lifetime. 73f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == Qualifiers::OCL_None) return; 74f85e193739c953358c865005855253af4f68a497John McCall 75265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime expectedLifetime 76265941bc308d65cc270d5c4de5806f37ce405606John McCall = getImpliedARCOwnership(propertyKind, property->getType()); 77265941bc308d65cc270d5c4de5806f37ce405606John McCall if (!expectedLifetime) { 78f85e193739c953358c865005855253af4f68a497John McCall // We have a lifetime qualifier but no dominating property 79265941bc308d65cc270d5c4de5806f37ce405606John McCall // attribute. That's okay, but restore reasonable invariants by 80265941bc308d65cc270d5c4de5806f37ce405606John McCall // setting the property attribute according to the lifetime 81265941bc308d65cc270d5c4de5806f37ce405606John McCall // qualifier. 82265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::PropertyAttributeKind attr; 83265941bc308d65cc270d5c4de5806f37ce405606John McCall if (propertyLifetime == Qualifiers::OCL_Strong) { 84265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_strong; 85265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (propertyLifetime == Qualifiers::OCL_Weak) { 86265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_weak; 87265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 88265941bc308d65cc270d5c4de5806f37ce405606John McCall assert(propertyLifetime == Qualifiers::OCL_ExplicitNone); 89265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_unsafe_unretained; 90265941bc308d65cc270d5c4de5806f37ce405606John McCall } 91265941bc308d65cc270d5c4de5806f37ce405606John McCall property->setPropertyAttributes(attr); 92f85e193739c953358c865005855253af4f68a497John McCall return; 93f85e193739c953358c865005855253af4f68a497John McCall } 94f85e193739c953358c865005855253af4f68a497John McCall 95f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == expectedLifetime) return; 96f85e193739c953358c865005855253af4f68a497John McCall 97f85e193739c953358c865005855253af4f68a497John McCall property->setInvalidDecl(); 98f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), 99b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis diag::err_arc_inconsistent_property_ownership) 100f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 101265941bc308d65cc270d5c4de5806f37ce405606John McCall << expectedLifetime 102f85e193739c953358c865005855253af4f68a497John McCall << propertyLifetime; 103f85e193739c953358c865005855253af4f68a497John McCall} 104f85e193739c953358c865005855253af4f68a497John McCall 105dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanianstatic unsigned deduceWeakPropertyFromType(Sema &S, QualType T) { 106dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian if ((S.getLangOpts().getGC() != LangOptions::NonGC && 107dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian T.isObjCGCWeak()) || 108dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian (S.getLangOpts().ObjCAutoRefCount && 109dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian T.getObjCLifetime() == Qualifiers::OCL_Weak)) 110dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian return ObjCDeclSpec::DQ_PR_weak; 111dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian return 0; 112dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian} 113dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian 114d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnProperty(Scope *S, SourceLocation AtLoc, 11577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation LParenLoc, 116d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall FieldDeclarator &FD, 117d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall ObjCDeclSpec &ODS, 118d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector GetterSel, 119d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector SetterSel, 120d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool *isOverridingProperty, 1214a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek tok::ObjCKeywordKind MethodImplKind, 1224a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek DeclContext *lexicalDC) { 12328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek unsigned Attributes = ODS.getPropertyAttributes(); 124f85e193739c953358c865005855253af4f68a497John McCall TypeSourceInfo *TSI = GetTypeForDeclarator(FD.D, S); 125f85e193739c953358c865005855253af4f68a497John McCall QualType T = TSI->getType(); 126dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian Attributes |= deduceWeakPropertyFromType(*this, T); 127dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian 12828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isReadWrite = ((Attributes & ObjCDeclSpec::DQ_PR_readwrite) || 12928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // default is readwrite! 13028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly)); 13128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // property is defaulted to 'assign' if it is readwrite and is 13228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // not retain or copy 13328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isAssign = ((Attributes & ObjCDeclSpec::DQ_PR_assign) || 13428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (isReadWrite && 13528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_retain) && 136f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_strong) && 137f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_copy) && 138f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) && 139f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_weak))); 14014086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian 141e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Proceed with constructing the ObjCPropertDecls. 142a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian ObjCContainerDecl *ClassDecl = cast<ObjCContainerDecl>(CurContext); 14328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) 144ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian if (CDecl->IsClassExtension()) { 14577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Decl *Res = HandlePropertyInClassExtension(S, AtLoc, LParenLoc, 146ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian FD, GetterSel, SetterSel, 147ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isAssign, isReadWrite, 148ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian Attributes, 149dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis ODS.getPropertyAttributes(), 150ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isOverridingProperty, TSI, 151ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian MethodImplKind); 152f85e193739c953358c865005855253af4f68a497John McCall if (Res) { 153cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes, false); 1544e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 155f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, cast<ObjCPropertyDecl>(Res)); 156f85e193739c953358c865005855253af4f68a497John McCall } 157abd56c816e9164b17bb3e7154a511b0c9896ffdbDmitri Gribenko ActOnDocumentableDecl(Res); 158ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian return Res; 159ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian } 160ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian 16177bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian ObjCPropertyDecl *Res = CreatePropertyDecl(S, ClassDecl, AtLoc, LParenLoc, FD, 162f85e193739c953358c865005855253af4f68a497John McCall GetterSel, SetterSel, 163f85e193739c953358c865005855253af4f68a497John McCall isAssign, isReadWrite, 164dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis Attributes, 165dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis ODS.getPropertyAttributes(), 166dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis TSI, MethodImplKind); 1674a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek if (lexicalDC) 1684a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek Res->setLexicalDeclContext(lexicalDC); 1694a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek 170842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian // Validate the attributes on the @property. 171cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes, 172cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian (isa<ObjCInterfaceDecl>(ClassDecl) || 173cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian isa<ObjCProtocolDecl>(ClassDecl))); 174f85e193739c953358c865005855253af4f68a497John McCall 1754e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 176f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, Res); 177f85e193739c953358c865005855253af4f68a497John McCall 178abd56c816e9164b17bb3e7154a511b0c9896ffdbDmitri Gribenko ActOnDocumentableDecl(Res); 179842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian return Res; 180e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 181e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 182b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidisstatic ObjCPropertyDecl::PropertyAttributeKind 183b98ffded10453d80369951f33f3892f35d747c95Argyrios KyrtzidismakePropertyAttributesAsWritten(unsigned Attributes) { 184b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis unsigned attributesAsWritten = 0; 185b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 186b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readonly; 187b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 188b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readwrite; 189b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_getter) 190b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_getter; 191b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_setter) 192b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_setter; 193b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_assign) 194b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_assign; 195b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_retain) 196b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_retain; 197b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_strong) 198b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_strong; 199b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_weak) 200b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_weak; 201b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_copy) 202b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_copy; 203b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 204b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_unsafe_unretained; 205b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 206b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_nonatomic; 207b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_atomic) 208b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_atomic; 209b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis 210b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis return (ObjCPropertyDecl::PropertyAttributeKind)attributesAsWritten; 211b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis} 212b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis 2135bf0e3522fac400cf7bf49a775554f0fc942b336Fariborz Jahanianstatic bool LocPropertyAttribute( ASTContext &Context, const char *attrName, 214edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian SourceLocation LParenLoc, SourceLocation &Loc) { 215edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian if (LParenLoc.isMacroID()) 216edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return false; 217edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian 218edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian SourceManager &SM = Context.getSourceManager(); 219edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian std::pair<FileID, unsigned> locInfo = SM.getDecomposedLoc(LParenLoc); 220edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian // Try to load the file buffer. 221edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian bool invalidTemp = false; 222edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian StringRef file = SM.getBufferData(locInfo.first, &invalidTemp); 223edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian if (invalidTemp) 224edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return false; 225edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian const char *tokenBegin = file.data() + locInfo.second; 226edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian 227edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian // Lex from the start of the given location. 228edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Lexer lexer(SM.getLocForStartOfFile(locInfo.first), 229edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Context.getLangOpts(), 230edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian file.begin(), tokenBegin, file.end()); 231edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Token Tok; 232edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian do { 233edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian lexer.LexFromRawLexer(Tok); 234edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian if (Tok.is(tok::raw_identifier) && 235edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian StringRef(Tok.getRawIdentifierData(), Tok.getLength()) == attrName) { 236edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Loc = Tok.getLocation(); 237edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return true; 238edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian } 239edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian } while (Tok.isNot(tok::r_paren)); 240edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian return false; 241edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian 2422b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian} 2432b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian 244d9f95b35dc4fc168a167a9b9b61a5f9e1d0462baFariborz Jahanianstatic unsigned getOwnershipRule(unsigned attr) { 245dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian return attr & (ObjCPropertyDecl::OBJC_PR_assign | 246dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_retain | 247dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_copy | 248dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_weak | 249dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_strong | 250dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 251dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian} 252dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian 253d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl * 254a28948f34817476d02412fa204cae038e228c827Fariborz JahanianSema::HandlePropertyInClassExtension(Scope *S, 25577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation AtLoc, 25677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation LParenLoc, 25777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FieldDeclarator &FD, 258e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, Selector SetterSel, 259e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 260e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 261e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 262dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis const unsigned AttributesAsWritten, 263e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek bool *isOverridingProperty, 26483a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *T, 265e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek tok::ObjCKeywordKind MethodImplKind) { 26658a764940df0cd41767367eb2f4fced6f374176bFariborz Jahanian ObjCCategoryDecl *CDecl = cast<ObjCCategoryDecl>(CurContext); 267e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Diagnose if this property is already in continuation class. 268a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian DeclContext *DC = CurContext; 269e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 2702a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCInterfaceDecl *CCPrimary = CDecl->getClassInterface(); 2712a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 2722a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian if (CCPrimary) 2732a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // Check for duplicate declaration of this property in current and 2742a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // other class extensions. 2752a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian for (const ObjCCategoryDecl *ClsExtDecl = 2762a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian CCPrimary->getFirstClassExtension(); 2772a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ClsExtDecl; ClsExtDecl = ClsExtDecl->getNextClassExtension()) { 2782a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian if (ObjCPropertyDecl *prevDecl = 2792a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCPropertyDecl::findPropertyDecl(ClsExtDecl, PropertyId)) { 2802a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(AtLoc, diag::err_duplicate_property); 2812a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(prevDecl->getLocation(), diag::note_property_declare); 2822a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian return 0; 2832a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 2842a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 2852a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 286e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Create a new ObjCPropertyDecl with the DeclContext being 287e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // the class extension. 28888f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // FIXME. We should really be using CreatePropertyDecl for this. 289e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 290e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::Create(Context, DC, FD.D.getIdentifierLoc(), 29177bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian PropertyId, AtLoc, LParenLoc, T); 292b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis PDecl->setPropertyAttributesAsWritten( 293dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis makePropertyAttributesAsWritten(AttributesAsWritten)); 29422f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 29522f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 29622f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 29722f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 29888f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // Set setter/getter selector name. Needed later. 29988f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setGetterName(GetterSel); 30088f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setSetterName(SetterSel); 30191ae6b43b3a294243698cdb544dd7a18efa4c7a8Douglas Gregor ProcessDeclAttributes(S, PDecl, FD.D); 302e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DC->addDecl(PDecl); 303e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 304e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // We need to look in the @interface to see if the @property was 305e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // already declared. 306e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!CCPrimary) { 307e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(CDecl->getLocation(), diag::err_continuation_class); 308e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 309d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 310e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 311e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 312e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Find the property in continuation class's primary class only. 313e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PIDecl = 314e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CCPrimary->FindPropertyVisibleInPrimaryClass(PropertyId); 315e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 316e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!PIDecl) { 317e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // No matching property found in the primary class. Just fall thru 318e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and add property to continuation class's primary class. 319d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis ObjCPropertyDecl *PrimaryPDecl = 32077bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian CreatePropertyDecl(S, CCPrimary, AtLoc, LParenLoc, 321e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FD, GetterSel, SetterSel, isAssign, isReadWrite, 322dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis Attributes,AttributesAsWritten, T, MethodImplKind, DC); 323e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 324e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // A case of continuation class adding a new property in the class. This 325e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // is not what it was meant for. However, gcc supports it and so should we. 326e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter/getters are declared here. 327d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis ProcessPropertyDecl(PrimaryPDecl, CCPrimary, /* redeclaredProperty = */ 0, 328a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek /* lexicalDC = */ CDecl); 329d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setGetterMethodDecl(PrimaryPDecl->getGetterMethodDecl()); 330d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setSetterMethodDecl(PrimaryPDecl->getSetterMethodDecl()); 331c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis if (ASTMutationListener *L = Context.getASTMutationListener()) 332d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis L->AddedObjCPropertyInClassExtension(PrimaryPDecl, /*OrigProp=*/0, CDecl); 333d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis return PrimaryPDecl; 334e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 335e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian if (!Context.hasSameType(PIDecl->getType(), PDecl->getType())) { 336e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian bool IncompatibleObjC = false; 337e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian QualType ConvertedType; 338ff2a0ecae1d7692dbb63aa540dba41a8c21d7ee4Fariborz Jahanian // Relax the strict type matching for property type in continuation class. 339ff2a0ecae1d7692dbb63aa540dba41a8c21d7ee4Fariborz Jahanian // Allow property object type of continuation class to be different as long 340ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // as it narrows the object type in its primary class property. Note that 341ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // this conversion is safe only because the wider type is for a 'readonly' 342ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // property in primary class and 'narrowed' type for a 'readwrite' property 343ad7eff2faf517779689327dc268817c2c2c8ebc4Fariborz Jahanian // in continuation class. 344e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian if (!isa<ObjCObjectPointerType>(PIDecl->getType()) || 345e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian !isa<ObjCObjectPointerType>(PDecl->getType()) || 346e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian (!isObjCPointerConversion(PDecl->getType(), PIDecl->getType(), 347e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian ConvertedType, IncompatibleObjC)) 348e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian || IncompatibleObjC) { 349e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian Diag(AtLoc, 350e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian diag::err_type_mismatch_continuation_class) << PDecl->getType(); 351e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian Diag(PIDecl->getLocation(), diag::note_property_declare); 352e23518342e326e3d6e9139f05384f030e2a94d4aFariborz Jahanian } 353a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian } 354a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian 355e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // The property 'PIDecl's readonly attribute will be over-ridden 356e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // with continuation class's readwrite property attribute! 35780aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian unsigned PIkind = PIDecl->getPropertyAttributesAsWritten(); 358e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (isReadWrite && (PIkind & ObjCPropertyDecl::OBJC_PR_readonly)) { 359dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian PIkind |= deduceWeakPropertyFromType(*this, PIDecl->getType()); 360d9f95b35dc4fc168a167a9b9b61a5f9e1d0462baFariborz Jahanian unsigned ClassExtensionMemoryModel = getOwnershipRule(Attributes); 361d9f95b35dc4fc168a167a9b9b61a5f9e1d0462baFariborz Jahanian unsigned PrimaryClassMemoryModel = getOwnershipRule(PIkind); 362dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian if (PrimaryClassMemoryModel && ClassExtensionMemoryModel && 363dad633b0a0955ceb4579e9508224562ad41b6a8dFariborz Jahanian (PrimaryClassMemoryModel != ClassExtensionMemoryModel)) { 364e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::warn_property_attr_mismatch); 365e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 366e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 3679944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek DeclContext *DC = cast<DeclContext>(CCPrimary); 3689944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek if (!ObjCPropertyDecl::findPropertyDecl(DC, 3699944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek PIDecl->getDeclName().getAsIdentifierInfo())) { 370e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Protocol is not in the primary class. Must build one for it. 371e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCDeclSpec ProtocolPropertyODS; 372e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // FIXME. Assuming that ObjCDeclSpec::ObjCPropertyAttributeKind 373e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and ObjCPropertyDecl::PropertyAttributeKind have identical 374e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // values. Should consolidate both into one enum type. 375e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProtocolPropertyODS. 376e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek setPropertyAttributes((ObjCDeclSpec::ObjCPropertyAttributeKind) 377e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIkind); 378a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // Must re-establish the context from class extension to primary 379a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // class context. 3807939418cbdf1b610a69e6adf29cd7dc8d0e9eaf8Fariborz Jahanian ContextRAII SavedContext(*this, CCPrimary); 3817939418cbdf1b610a69e6adf29cd7dc8d0e9eaf8Fariborz Jahanian 382d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ProtocolPtrTy = 38377bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian ActOnProperty(S, AtLoc, LParenLoc, FD, ProtocolPropertyODS, 384e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getGetterName(), 385e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getSetterName(), 386a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian isOverridingProperty, 3874a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek MethodImplKind, 3884a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek /* lexicalDC = */ CDecl); 389d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall PIDecl = cast<ObjCPropertyDecl>(ProtocolPtrTy); 39028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 391e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->makeitReadWriteAttribute(); 392e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 393e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 394f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) 395f85e193739c953358c865005855253af4f68a497John McCall PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 396e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 397e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 398e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setSetterName(SetterSel); 399e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } else { 400788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // Tailor the diagnostics for the common case where a readwrite 401788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // property is declared both in the @interface and the continuation. 402788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // This is a common error where the user often intended the original 403788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // declaration to be readonly. 404788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek unsigned diag = 405788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_readwrite) && 406788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (PIkind & ObjCPropertyDecl::OBJC_PR_readwrite) 407788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek ? diag::err_use_continuation_class_redeclaration_readwrite 408788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek : diag::err_use_continuation_class; 409788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek Diag(AtLoc, diag) 410e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek << CCPrimary->getDeclName(); 411e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 412e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 413e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 414e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter decl is synthesized, and added to primary class's list. 4158254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ProcessPropertyDecl(PIDecl, CCPrimary, PDecl, CDecl); 416d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setGetterMethodDecl(PIDecl->getGetterMethodDecl()); 417d7c15a64ba8ebdca0dd48dd1d2f233107d34494eArgyrios Kyrtzidis PDecl->setSetterMethodDecl(PIDecl->getSetterMethodDecl()); 418c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis if (ASTMutationListener *L = Context.getASTMutationListener()) 419c80553efdc269dabd4ed0c3210555f45729ab5ddArgyrios Kyrtzidis L->AddedObjCPropertyInClassExtension(PDecl, PIDecl, CDecl); 420d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 421e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 422e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 423e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekObjCPropertyDecl *Sema::CreatePropertyDecl(Scope *S, 424e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *CDecl, 425e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, 42677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation LParenLoc, 427e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FieldDeclarator &FD, 428e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, 429e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector SetterSel, 430e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 431e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 432e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 433dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis const unsigned AttributesAsWritten, 43483a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *TInfo, 43523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek tok::ObjCKeywordKind MethodImplKind, 43623173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek DeclContext *lexicalDC){ 437e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 43883a230c83a54190366138c1a4f4310ef838b88fcJohn McCall QualType T = TInfo->getType(); 43928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 44028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Issue a warning if property is 'assign' as default and its object, which is 44128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // gc'able conforms to NSCopying protocol 4424e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() != LangOptions::NonGC && 44328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek isAssign && !(Attributes & ObjCDeclSpec::DQ_PR_assign)) 444c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (const ObjCObjectPointerType *ObjPtrTy = 445c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall T->getAs<ObjCObjectPointerType>()) { 446c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall ObjCInterfaceDecl *IDecl = ObjPtrTy->getObjectType()->getInterface(); 447c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl) 448c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (ObjCProtocolDecl* PNSCopying = 449c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall LookupProtocol(&Context.Idents.get("NSCopying"), AtLoc)) 450c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl->ClassImplementsProtocol(PNSCopying, true)) 451c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall Diag(AtLoc, diag::warn_implements_nscopying) << PropertyId; 45228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 453c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (T->isObjCObjectType()) 45428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(FD.D.getIdentifierLoc(), diag::err_statically_allocated_object); 45528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 456e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 45728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC, 45828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek FD.D.getIdentifierLoc(), 45977bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian PropertyId, AtLoc, LParenLoc, TInfo); 460e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 4619f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek if (ObjCPropertyDecl *prevDecl = 4629f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) { 46328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PDecl->getLocation(), diag::err_duplicate_property); 464894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek Diag(prevDecl->getLocation(), diag::note_property_declare); 46528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 46628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 46723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek else { 46828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek DC->addDecl(PDecl); 46923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek if (lexicalDC) 47023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek PDecl->setLexicalDeclContext(lexicalDC); 47123173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek } 47228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 47328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isArrayType() || T->isFunctionType()) { 47428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::err_property_type) << T; 47528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 47628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 47728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 47828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ProcessDeclAttributes(S, PDecl, FD.D); 47928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 48028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Regardless of setter/getter attribute, we save the default getter/setter 48128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // selector names in anticipation of declaration of setter/getter methods. 48228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setGetterName(GetterSel); 48328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setSetterName(SetterSel); 4840a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis PDecl->setPropertyAttributesAsWritten( 485dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis makePropertyAttributesAsWritten(AttributesAsWritten)); 4860a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 48728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 48828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 48928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 49028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_getter) 49128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter); 49228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 49328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_setter) 49428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter); 49528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 49628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isReadWrite) 49728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 49828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 49928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 50028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 50128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 502f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) 503f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 504f85e193739c953358c865005855253af4f68a497John McCall 505f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_weak) 506f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_weak); 507f85e193739c953358c865005855253af4f68a497John McCall 50828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 50928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 51028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 511f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 512f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 513f85e193739c953358c865005855253af4f68a497John McCall 51428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isAssign) 51528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 51628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 517265941bc308d65cc270d5c4de5806f37ce405606John McCall // In the semantic attributes, one of nonatomic or atomic is always set. 51828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 51928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 520265941bc308d65cc270d5c4de5806f37ce405606John McCall else 52145937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_atomic); 52228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 523f85e193739c953358c865005855253af4f68a497John McCall // 'unsafe_unretained' is alias for 'assign'. 524f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 525f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 526f85e193739c953358c865005855253af4f68a497John McCall if (isAssign) 527f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 528f85e193739c953358c865005855253af4f68a497John McCall 52928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (MethodImplKind == tok::objc_required) 53028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Required); 53128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek else if (MethodImplKind == tok::objc_optional) 53228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional); 53328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 534e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return PDecl; 53528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 53628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 537f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyImpl(Sema &S, SourceLocation propertyImplLoc, 538f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *property, 539f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar) { 540f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl() || ivar->isInvalidDecl()) return; 541f85e193739c953358c865005855253af4f68a497John McCall 542f85e193739c953358c865005855253af4f68a497John McCall QualType ivarType = ivar->getType(); 543f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime ivarLifetime = ivarType.getObjCLifetime(); 544f85e193739c953358c865005855253af4f68a497John McCall 545265941bc308d65cc270d5c4de5806f37ce405606John McCall // The lifetime implied by the property's attributes. 546265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime propertyLifetime = 547265941bc308d65cc270d5c4de5806f37ce405606John McCall getImpliedARCOwnership(property->getPropertyAttributes(), 548265941bc308d65cc270d5c4de5806f37ce405606John McCall property->getType()); 549f85e193739c953358c865005855253af4f68a497John McCall 550265941bc308d65cc270d5c4de5806f37ce405606John McCall // We're fine if they match. 551265941bc308d65cc270d5c4de5806f37ce405606John McCall if (propertyLifetime == ivarLifetime) return; 552f85e193739c953358c865005855253af4f68a497John McCall 553265941bc308d65cc270d5c4de5806f37ce405606John McCall // These aren't valid lifetimes for object ivars; don't diagnose twice. 554265941bc308d65cc270d5c4de5806f37ce405606John McCall if (ivarLifetime == Qualifiers::OCL_None || 555265941bc308d65cc270d5c4de5806f37ce405606John McCall ivarLifetime == Qualifiers::OCL_Autoreleasing) 556265941bc308d65cc270d5c4de5806f37ce405606John McCall return; 557265941bc308d65cc270d5c4de5806f37ce405606John McCall 558d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // If the ivar is private, and it's implicitly __unsafe_unretained 559d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // becaues of its type, then pretend it was actually implicitly 560d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // __strong. This is only sound because we're processing the 561d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall // property implementation before parsing any method bodies. 562d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall if (ivarLifetime == Qualifiers::OCL_ExplicitNone && 563d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall propertyLifetime == Qualifiers::OCL_Strong && 564d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall ivar->getAccessControl() == ObjCIvarDecl::Private) { 565d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall SplitQualType split = ivarType.split(); 566d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall if (split.Quals.hasObjCLifetime()) { 567d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall assert(ivarType->isObjCARCImplicitlyUnretainedType()); 568d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall split.Quals.setObjCLifetime(Qualifiers::OCL_Strong); 569d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall ivarType = S.Context.getQualifiedType(split); 570d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall ivar->setType(ivarType); 571d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall return; 572d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall } 573d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall } 574d64c2eb83d7ec86faa4f2554935a977a19573f59John McCall 575265941bc308d65cc270d5c4de5806f37ce405606John McCall switch (propertyLifetime) { 576265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Strong: 577265941bc308d65cc270d5c4de5806f37ce405606John McCall S.Diag(propertyImplLoc, diag::err_arc_strong_property_ownership) 578265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 579265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName() 580265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivarLifetime; 581265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 582265941bc308d65cc270d5c4de5806f37ce405606John McCall 583265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Weak: 584265941bc308d65cc270d5c4de5806f37ce405606John McCall S.Diag(propertyImplLoc, diag::error_weak_property) 585265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 586265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName(); 587265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 588265941bc308d65cc270d5c4de5806f37ce405606John McCall 589265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_ExplicitNone: 590265941bc308d65cc270d5c4de5806f37ce405606John McCall S.Diag(propertyImplLoc, diag::err_arc_assign_property_ownership) 591265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 592265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName() 593265941bc308d65cc270d5c4de5806f37ce405606John McCall << ((property->getPropertyAttributesAsWritten() 594265941bc308d65cc270d5c4de5806f37ce405606John McCall & ObjCPropertyDecl::OBJC_PR_assign) != 0); 595265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 596265941bc308d65cc270d5c4de5806f37ce405606John McCall 597265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Autoreleasing: 598265941bc308d65cc270d5c4de5806f37ce405606John McCall llvm_unreachable("properties cannot be autoreleasing"); 599265941bc308d65cc270d5c4de5806f37ce405606John McCall 600265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_None: 601265941bc308d65cc270d5c4de5806f37ce405606John McCall // Any other property should be ignored. 602f85e193739c953358c865005855253af4f68a497John McCall return; 603f85e193739c953358c865005855253af4f68a497John McCall } 604f85e193739c953358c865005855253af4f68a497John McCall 605f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), diag::note_property_declare); 606f85e193739c953358c865005855253af4f68a497John McCall} 607f85e193739c953358c865005855253af4f68a497John McCall 608015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// setImpliedPropertyAttributeForReadOnlyProperty - 609015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// This routine evaludates life-time attributes for a 'readonly' 610015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// property with no known lifetime of its own, using backing 611015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// 'ivar's attribute, if any. If no backing 'ivar', property's 612015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian/// life-time is assumed 'strong'. 613015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanianstatic void setImpliedPropertyAttributeForReadOnlyProperty( 614015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCPropertyDecl *property, ObjCIvarDecl *ivar) { 615015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian Qualifiers::ObjCLifetime propertyLifetime = 616015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian getImpliedARCOwnership(property->getPropertyAttributes(), 617015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->getType()); 618015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian if (propertyLifetime != Qualifiers::OCL_None) 619015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 620015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian 621015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian if (!ivar) { 622015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // if no backing ivar, make property 'strong'. 623015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 624015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 625015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian } 626015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // property assumes owenership of backing ivar. 627015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian QualType ivarType = ivar->getType(); 628015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian Qualifiers::ObjCLifetime ivarLifetime = ivarType.getObjCLifetime(); 629015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian if (ivarLifetime == Qualifiers::OCL_Strong) 630015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 631015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian else if (ivarLifetime == Qualifiers::OCL_Weak) 632015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian property->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_weak); 633015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 634015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian} 63528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 636cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian/// DiagnoseClassAndClassExtPropertyMismatch - diagnose inconsistant property 637cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian/// attribute declared in primary class and attributes overridden in any of its 638cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian/// class extensions. 639cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanianstatic void 640cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz JahanianDiagnoseClassAndClassExtPropertyMismatch(Sema &S, ObjCInterfaceDecl *ClassDecl, 641cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCPropertyDecl *property) { 642cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian unsigned Attributes = property->getPropertyAttributesAsWritten(); 643cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian bool warn = (Attributes & ObjCDeclSpec::DQ_PR_readonly); 644cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian for (const ObjCCategoryDecl *CDecl = ClassDecl->getFirstClassExtension(); 645cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian CDecl; CDecl = CDecl->getNextClassExtension()) { 646cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCPropertyDecl *ClassExtProperty = 0; 647cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian for (ObjCContainerDecl::prop_iterator P = CDecl->prop_begin(), 648cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian E = CDecl->prop_end(); P != E; ++P) { 649cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if ((*P)->getIdentifier() == property->getIdentifier()) { 650cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ClassExtProperty = *P; 651cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian break; 652cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 653cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 654cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (ClassExtProperty) { 655c78ff27813288b30ee566477705353ae660fd577Fariborz Jahanian warn = false; 656cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian unsigned classExtPropertyAttr = 657cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ClassExtProperty->getPropertyAttributesAsWritten(); 658cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // We are issuing the warning that we postponed because class extensions 659cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // can override readonly->readwrite and 'setter' attributes originally 660cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // placed on class's property declaration now make sense in the overridden 661cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // property. 662cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readonly) { 663cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (!classExtPropertyAttr || 664a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian (classExtPropertyAttr & 665a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian (ObjCDeclSpec::DQ_PR_readwrite| 666a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_assign | 667a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_unsafe_unretained | 668a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_copy | 669a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_retain | 670a6e28f27c668775e3927b9c0be0a17636fed16fcFariborz Jahanian ObjCDeclSpec::DQ_PR_strong))) 671cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian continue; 672cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian warn = true; 673cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian break; 674cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 675cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 676cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 677cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (warn) { 678cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian unsigned setterAttrs = (ObjCDeclSpec::DQ_PR_assign | 679cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_unsafe_unretained | 680cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_copy | 681cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_retain | 682cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian ObjCDeclSpec::DQ_PR_strong); 683cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (Attributes & setterAttrs) { 684cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian const char * which = 685cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 686cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "assign" : 687cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) ? 688cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "unsafe_unretained" : 689cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 690cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "copy" : 691cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_retain) ? 692cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian "retain" : "strong"; 693cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 694cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian S.Diag(property->getLocation(), 695cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian diag::warn_objc_property_attr_mutually_exclusive) 696cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian << "readonly" << which; 697cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 698cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 699cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 700cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 701cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian} 702cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 70328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// ActOnPropertyImplDecl - This routine performs semantic checks and 70428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// builds the AST node for a property implementation declaration; declared 705699c9044c7d53a2774d0dd261a6901dd2c4a545fJames Dennett/// as \@synthesize or \@dynamic. 70628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// 707d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnPropertyImplDecl(Scope *S, 708d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation AtLoc, 709d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation PropertyLoc, 710d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool Synthesize, 711d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall IdentifierInfo *PropertyId, 712a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor IdentifierInfo *PropertyIvar, 713a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor SourceLocation PropertyIvarLoc) { 714e9686572f17968048a5e097254f85c202ea44aecTed Kremenek ObjCContainerDecl *ClassImpDecl = 71584e0ccff7a6e51d7b81fd58686b493a4880dd44dFariborz Jahanian dyn_cast<ObjCContainerDecl>(CurContext); 71628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Make sure we have a context for the property implementation declaration. 71728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!ClassImpDecl) { 71828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_context); 719d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 72028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 721f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis if (PropertyIvarLoc.isInvalid()) 722f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis PropertyIvarLoc = PropertyLoc; 723e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman SourceLocation PropertyDiagLoc = PropertyLoc; 724e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (PropertyDiagLoc.isInvalid()) 725e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman PropertyDiagLoc = ClassImpDecl->getLocStart(); 72628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *property = 0; 72728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl* IDecl = 0; 72828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Find the class or category class where this property must have 72928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a declaration. 73028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCImplementationDecl *IC = 0; 73128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryImplDecl* CatImplClass = 0; 73228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) { 73328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = IC->getClassInterface(); 73428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // We always synthesize an interface for an implementation 73528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // without an interface decl. So, IDecl is always non-zero. 73628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert(IDecl && 73728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "ActOnPropertyImplDecl - @implementation without @interface"); 73828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 73928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in the @implementation's @interface 74028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = IDecl->FindPropertyDeclaration(PropertyId); 74128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 74228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_property_decl) << IDecl->getDeclName(); 743d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 74428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 745dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian unsigned PIkind = property->getPropertyAttributesAsWritten(); 74645937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian if ((PIkind & (ObjCPropertyDecl::OBJC_PR_atomic | 74745937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_nonatomic) ) == 0) { 748dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian if (AtLoc.isValid()) 749dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(AtLoc, diag::warn_implicit_atomic_property); 750dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian else 751dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(IC->getLocation(), diag::warn_auto_implicit_atomic_property); 752dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 753dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian } 754dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian 75528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (const ObjCCategoryDecl *CD = 75628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek dyn_cast<ObjCCategoryDecl>(property->getDeclContext())) { 75728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!CD->IsClassExtension()) { 75828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_category_property) << CD->getDeclName(); 75928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(property->getLocation(), diag::note_property_declare); 760d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 76128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 76228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 7632b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian 7642b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian if (Synthesize&& 7652b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian (PIkind & ObjCPropertyDecl::OBJC_PR_readonly) && 7662b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian property->hasAttr<IBOutletAttr>() && 7672b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian !AtLoc.isValid()) { 7682b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian Diag(IC->getLocation(), diag::warn_auto_readonly_iboutlet_property); 7692b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 770edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian SourceLocation readonlyLoc; 7715bf0e3522fac400cf7bf49a775554f0fc942b336Fariborz Jahanian if (LocPropertyAttribute(Context, "readonly", 772edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian property->getLParenLoc(), readonlyLoc)) { 773edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian SourceLocation endLoc = 774edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian readonlyLoc.getLocWithOffset(strlen("readonly")-1); 775edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian SourceRange ReadonlySourceRange(readonlyLoc, endLoc); 776edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian Diag(property->getLocation(), 777edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian diag::note_auto_readonly_iboutlet_fixup_suggest) << 778edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian FixItHint::CreateReplacement(ReadonlySourceRange, "readwrite"); 779edcc27f6171fd8cc736d057d87b128252fcb7344Fariborz Jahanian } 7802b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian } 781cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian 782cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian DiagnoseClassAndClassExtPropertyMismatch(*this, IDecl, property); 7832b309fb125906b1fb10efb1890860cd042fbfab3Fariborz Jahanian 78428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) { 78528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 78628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_synthesize_category_decl); 787d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 78828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 78928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = CatImplClass->getClassInterface(); 79028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!IDecl) { 79128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_interface); 792d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 79328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 79428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryDecl *Category = 79528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier()); 79628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 79728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // If category for this implementation not found, it is an error which 79828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // has already been reported eralier. 79928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Category) 800d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 80128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in @implementation's category 80228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = Category->FindPropertyDeclaration(PropertyId); 80328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 80428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_category_property_decl) 80528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << Category->getDeclName(); 806d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 80728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 80828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 80928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_bad_property_context); 810d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 81128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 81228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCIvarDecl *Ivar = 0; 813e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman bool CompleteTypeErr = false; 814744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian bool compat = true; 81528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that we have a valid, previously declared ivar for @synthesize 81628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 81728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @synthesize 81828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!PropertyIvar) 81928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyIvar = PropertyId; 820015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // Check that this is a previously declared 'ivar' in 'IDecl' interface 821015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared; 822015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyIvar, ClassDeclared); 823265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType PropType = property->getType(); 824265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType PropertyIvarType = PropType.getNonReferenceType(); 825e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 826e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (RequireCompleteType(PropertyDiagLoc, PropertyIvarType, 827d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor diag::err_incomplete_synthesized_property, 828d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor property->getDeclName())) { 829e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(property->getLocation(), diag::note_property_declare); 830e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman CompleteTypeErr = true; 831e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman } 832e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 8334e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 834015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian (property->getPropertyAttributesAsWritten() & 8353efd348d3586b22bb0153f17181128a1b3c41140Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_readonly) && 8363efd348d3586b22bb0153f17181128a1b3c41140Fariborz Jahanian PropertyIvarType->isObjCRetainableType()) { 837015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian setImpliedPropertyAttributeForReadOnlyProperty(property, Ivar); 838015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian } 839015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian 840015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCPropertyDecl::PropertyAttributeKind kind 841015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian = property->getPropertyAttributes(); 842265941bc308d65cc270d5c4de5806f37ce405606John McCall 843265941bc308d65cc270d5c4de5806f37ce405606John McCall // Add GC __weak to the ivar type if the property is weak. 844265941bc308d65cc270d5c4de5806f37ce405606John McCall if ((kind & ObjCPropertyDecl::OBJC_PR_weak) && 8454e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() != LangOptions::NonGC) { 8464e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie assert(!getLangOpts().ObjCAutoRefCount); 847265941bc308d65cc270d5c4de5806f37ce405606John McCall if (PropertyIvarType.isObjCGCStrong()) { 848e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::err_gc_weak_property_strong_type); 849265941bc308d65cc270d5c4de5806f37ce405606John McCall Diag(property->getLocation(), diag::note_property_declare); 850265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 851265941bc308d65cc270d5c4de5806f37ce405606John McCall PropertyIvarType = 852265941bc308d65cc270d5c4de5806f37ce405606John McCall Context.getObjCGCQualType(PropertyIvarType, Qualifiers::Weak); 853edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian } 854edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian } 855e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian if (AtLoc.isInvalid()) { 856e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // Check when default synthesizing a property that there is 857e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // an ivar matching property name and issue warning; since this 858e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // is the most common case of not using an ivar used for backing 859e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian // property in non-default synthesis case. 860e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared=0; 861e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian ObjCIvarDecl *originalIvar = 862e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian IDecl->lookupInstanceVariable(property->getIdentifier(), 863e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian ClassDeclared); 864e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian if (originalIvar) { 865e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian Diag(PropertyDiagLoc, 866e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian diag::warn_autosynthesis_property_ivar_match) 8672578532c7323efdd68ec42a31b7bdf72e5218867Fariborz Jahanian << PropertyId << (Ivar == 0) << PropertyIvar 86820e7d992140cc6bc94f2e65f3638346527150756Fariborz Jahanian << originalIvar->getIdentifier(); 869e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 870e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian Diag(originalIvar->getLocation(), diag::note_ivar_decl); 871dd3284b17829adfd542ecf4a7b4423dce1d7502bFariborz Jahanian } 872e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian } 873e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian 874e95f8ef6563bdf26de5294873733a3425c09db42Fariborz Jahanian if (!Ivar) { 875265941bc308d65cc270d5c4de5806f37ce405606John McCall // In ARC, give the ivar a lifetime qualifier based on the 876f85e193739c953358c865005855253af4f68a497John McCall // property attributes. 8774e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 878265941bc308d65cc270d5c4de5806f37ce405606John McCall !PropertyIvarType.getObjCLifetime() && 879265941bc308d65cc270d5c4de5806f37ce405606John McCall PropertyIvarType->isObjCRetainableType()) { 880f85e193739c953358c865005855253af4f68a497John McCall 881265941bc308d65cc270d5c4de5806f37ce405606John McCall // It's an error if we have to do this and the user didn't 882265941bc308d65cc270d5c4de5806f37ce405606John McCall // explicitly write an ownership attribute on the property. 883473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis if (!property->hasWrittenStorageAttribute() && 884265941bc308d65cc270d5c4de5806f37ce405606John McCall !(kind & ObjCPropertyDecl::OBJC_PR_strong)) { 885e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, 886473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis diag::err_arc_objc_property_default_assign_on_object); 887473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis Diag(property->getLocation(), diag::note_property_declare); 888265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 889265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime lifetime = 890265941bc308d65cc270d5c4de5806f37ce405606John McCall getImpliedARCOwnership(kind, PropertyIvarType); 891265941bc308d65cc270d5c4de5806f37ce405606John McCall assert(lifetime && "no lifetime for property?"); 8926dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian if (lifetime == Qualifiers::OCL_Weak) { 8936dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian bool err = false; 8946dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian if (const ObjCObjectPointerType *ObjT = 895a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith PropertyIvarType->getAs<ObjCObjectPointerType>()) { 896a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith const ObjCInterfaceDecl *ObjI = ObjT->getInterfaceDecl(); 897a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith if (ObjI && ObjI->isArcWeakrefUnavailable()) { 898e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::err_arc_weak_unavailable_property); 8996dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 9006dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian err = true; 9016dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian } 902a8eaf008e92759142982f7b40720b2b2674bd663Richard Smith } 9030a7dd788dbef975f35f273c7ab913f480f7edd60John McCall if (!err && !getLangOpts().ObjCARCWeak) { 904e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::err_arc_weak_no_runtime); 9056dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 9066dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian } 907f85e193739c953358c865005855253af4f68a497John McCall } 9086dce88d9f71cd4be18554af94145a9147b363199Fariborz Jahanian 909f85e193739c953358c865005855253af4f68a497John McCall Qualifiers qs; 910265941bc308d65cc270d5c4de5806f37ce405606John McCall qs.addObjCLifetime(lifetime); 911f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType = Context.getQualifiedType(PropertyIvarType, qs); 912f85e193739c953358c865005855253af4f68a497John McCall } 913f85e193739c953358c865005855253af4f68a497John McCall } 914f85e193739c953358c865005855253af4f68a497John McCall 915f85e193739c953358c865005855253af4f68a497John McCall if (kind & ObjCPropertyDecl::OBJC_PR_weak && 9164e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie !getLangOpts().ObjCAutoRefCount && 9174e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() == LangOptions::NonGC) { 918e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_synthesize_weak_non_arc_or_gc); 919f85e193739c953358c865005855253af4f68a497John McCall Diag(property->getLocation(), diag::note_property_declare); 920f85e193739c953358c865005855253af4f68a497John McCall } 921f85e193739c953358c865005855253af4f68a497John McCall 922ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Ivar = ObjCIvarDecl::Create(Context, ClassImpDecl, 923f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis PropertyIvarLoc,PropertyIvarLoc, PropertyIvar, 92414086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType, /*Dinfo=*/0, 9257504966cc0d07eac26baabec80a7406695efb307Fariborz Jahanian ObjCIvarDecl::Private, 926ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian (Expr *)0, true); 927e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (CompleteTypeErr) 928e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Ivar->setInvalidDecl(); 92929fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar ClassImpDecl->addDecl(Ivar); 9301b7f9cbed1b96b58a6e5f7808ebc9345a76a0936Richard Smith IDecl->makeDeclVisibleInContext(Ivar); 93128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property->setPropertyIvarDecl(Ivar); 93228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 933260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (getLangOpts().ObjCRuntime.isFragile()) 934e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_missing_property_ivar_decl) 935e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman << PropertyId; 93628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 93728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 938260611a32535c851237926bfcf78869b13c07d5bJohn McCall } else if (getLangOpts().ObjCRuntime.isNonFragile() && 93960ef308e51c71b760d7f598c1b763ceb7b768148Douglas Gregor !declaresSameEntity(ClassDeclared, IDecl)) { 940e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_ivar_in_superclass_use) 94128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName() 94228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << ClassDeclared->getDeclName(); 94328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Ivar->getLocation(), diag::note_previous_access_declaration) 9444087f27e5416c799bcb6be072f905be752acb61cDaniel Dunbar << Ivar << Ivar->getName(); 94528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so more errors are caught. 94628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 94728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType IvarType = Context.getCanonicalType(Ivar->getType()); 94828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 94928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that type of property and its ivar are type compatible. 950744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian if (!Context.hasSameType(PropertyIvarType, IvarType)) { 951744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian compat = false; 95214086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (isa<ObjCObjectPointerType>(PropertyIvarType) 953f85e193739c953358c865005855253af4f68a497John McCall && isa<ObjCObjectPointerType>(IvarType)) 95462ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian compat = 95562ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian Context.canAssignObjCInterfaces( 95614086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType->getAs<ObjCObjectPointerType>(), 95762ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian IvarType->getAs<ObjCObjectPointerType>()); 958b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor else { 959f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis compat = (CheckAssignmentConstraints(PropertyIvarLoc, PropertyIvarType, 960f911242f43ae1b0a85c323631fe817df95c9cbe9Argyrios Kyrtzidis IvarType) 961daa8e4e888758d55a7a759dd4a91b83921cef222John McCall == Compatible); 962b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor } 96362ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian if (!compat) { 964e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_property_ivar_type) 965f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 966f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 967f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 96828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 96928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 97028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 971744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian else { 972744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // FIXME! Rules for properties are somewhat different that those 973744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // for assignments. Use a new routine to consolidate all cases; 974744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // specifically for property redeclarations as well as for ivars. 975744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian QualType lhsType =Context.getCanonicalType(PropertyIvarType).getUnqualifiedType(); 976744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian QualType rhsType =Context.getCanonicalType(IvarType).getUnqualifiedType(); 977744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian if (lhsType != rhsType && 978744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian lhsType->isArithmeticType()) { 979744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian Diag(PropertyDiagLoc, diag::error_property_ivar_type) 980744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian << property->getDeclName() << PropType 981744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian << Ivar->getDeclName() << IvarType; 982744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian Diag(Ivar->getLocation(), diag::note_ivar_decl); 983744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian // Fall thru - see previous comment 984744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian } 98528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 98628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // __weak is explicit. So it works on Canonical type. 987f85e193739c953358c865005855253af4f68a497John McCall if ((PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() && 9884e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() != LangOptions::NonGC)) { 989e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_weak_property) 99028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 991edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian Diag(Ivar->getLocation(), diag::note_ivar_decl); 99228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 99328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 994f85e193739c953358c865005855253af4f68a497John McCall // Fall thru - see previous comment 99528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((property->getType()->isObjCObjectPointerType() || 99628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropType.isObjCGCStrong()) && IvarType.isObjCGCWeak() && 9974e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts().getGC() != LangOptions::NonGC) { 998e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_strong_property) 99928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 100028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 100128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 100228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 10034e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 1004f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyImpl(*this, PropertyLoc, property, Ivar); 100528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (PropertyIvar) 100628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @dynamic 1007e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_dynamic_property_ivar_decl); 1008f85e193739c953358c865005855253af4f68a497John McCall 100928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert (property && "ActOnPropertyImplDecl - property declaration missing"); 101028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl *PIDecl = 101128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Create(Context, CurContext, AtLoc, PropertyLoc, 101228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property, 101328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Synthesize ? 101428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Synthesize 101528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek : ObjCPropertyImplDecl::Dynamic), 1016a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor Ivar, PropertyIvarLoc); 1017e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 1018744147138cd2a77320c431578da130cc3d81a1d5Fariborz Jahanian if (CompleteTypeErr || !compat) 1019e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman PIDecl->setInvalidDecl(); 1020e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman 102117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *getterMethod = property->getGetterMethodDecl()) { 102217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian getterMethod->createImplicitParams(Context, IDecl); 1023e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (getLangOpts().CPlusPlus && Synthesize && !CompleteTypeErr && 10240313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian Ivar->getType()->isRecordType()) { 102517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // For Objective-C++, need to synthesize the AST for the IVAR object to be 102617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // returned by the getter as it must conform to C++'s copy-return rules. 102717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 102817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = getterMethod->getSelfDecl(); 102917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 1030f4b88a45902af1802a1cb42ba48b1c474474f228John McCall new (Context) DeclRefExpr(SelfDecl, false, SelfDecl->getType(), 1031f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_RValue, SourceLocation()); 103217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *IvarRefExpr = 103317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 103417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 103560d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult Res = 103617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PerformCopyInitialization(InitializedEntity::InitializeResult( 10373c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor SourceLocation(), 10383c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor getterMethod->getResultType(), 10393c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor /*NRVO=*/false), 104017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SourceLocation(), 104117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Owned(IvarRefExpr)); 104217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (!Res.isInvalid()) { 104317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *ResExpr = Res.takeAs<Expr>(); 104417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ResExpr) 10454765fa05b5652fcc4356371c2f481d0ea9a1b007John McCall ResExpr = MaybeCreateExprWithCleanups(ResExpr); 104617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setGetterCXXConstructor(ResExpr); 104717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 104817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 1049831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>() && 1050831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !getterMethod->hasAttr<NSReturnsNotRetainedAttr>()) { 1051831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(getterMethod->getLocation(), 1052831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian diag::warn_property_getter_owning_mismatch); 1053831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 1054831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian } 105517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 105617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *setterMethod = property->getSetterMethodDecl()) { 105717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian setterMethod->createImplicitParams(Context, IDecl); 1058e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman if (getLangOpts().CPlusPlus && Synthesize && !CompleteTypeErr && 1059e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Ivar->getType()->isRecordType()) { 106017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 106117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = setterMethod->getSelfDecl(); 106217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 1063f4b88a45902af1802a1cb42ba48b1c474474f228John McCall new (Context) DeclRefExpr(SelfDecl, false, SelfDecl->getType(), 1064f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_RValue, SourceLocation()); 106517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *lhs = 106617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 106717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 106817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ObjCMethodDecl::param_iterator P = setterMethod->param_begin(); 106917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ParmVarDecl *Param = (*P); 10703c3b7f90a863af43fa63043d396553ecf205351cJohn McCall QualType T = Param->getType().getNonReferenceType(); 1071f4b88a45902af1802a1cb42ba48b1c474474f228John McCall Expr *rhs = new (Context) DeclRefExpr(Param, false, T, 1072f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_LValue, SourceLocation()); 1073fa432391a708448518df1e6ced4e34f4c349d169Fariborz Jahanian ExprResult Res = BuildBinOp(S, lhs->getLocEnd(), 10742de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BO_Assign, lhs, rhs); 107557e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (property->getPropertyAttributes() & 107657e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_atomic) { 107757e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian Expr *callExpr = Res.takeAs<Expr>(); 107857e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (const CXXOperatorCallExpr *CXXCE = 107913bf6336ab395eb6af487ab96d32229460907769Fariborz Jahanian dyn_cast_or_null<CXXOperatorCallExpr>(callExpr)) 108013bf6336ab395eb6af487ab96d32229460907769Fariborz Jahanian if (const FunctionDecl *FuncDecl = CXXCE->getDirectCallee()) 108157e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (!FuncDecl->isTrivial()) 108220abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian if (property->getType()->isReferenceType()) { 108320abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian Diag(PropertyLoc, 108420abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian diag::err_atomic_property_nontrivial_assign_op) 108557e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian << property->getType(); 108620abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian Diag(FuncDecl->getLocStart(), 108720abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian diag::note_callee_decl) << FuncDecl; 108820abee6b95c4f5a61e471b4b616439280ca4a81bFariborz Jahanian } 108957e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian } 109017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setSetterCXXAssignment(Res.takeAs<Expr>()); 109117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 109217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 109317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian 109428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (IC) { 109528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 109628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 109728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->FindPropertyImplIvarDecl(PropertyIvar)) { 109828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 109928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 110028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 110128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 110228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 110328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 110428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl 110528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek = IC->FindPropertyImplDecl(PropertyId)) { 110628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 110728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 1108d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 110928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 111028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->addPropertyImplementation(PIDecl); 11114e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCDefaultSynthProperties && 1112260611a32535c851237926bfcf78869b13c07d5bJohn McCall getLangOpts().ObjCRuntime.isNonFragile() && 111371207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek !IDecl->isObjCRequiresPropertyDefs()) { 1114ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // Diagnose if an ivar was lazily synthesdized due to a previous 1115ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // use and if 1) property is @dynamic or 2) property is synthesized 1116cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // but it requires an ivar of different name. 1117411c25c4512f00e07442e8818d011c7e0902d739Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared=0; 1118ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian ObjCIvarDecl *Ivar = 0; 1119ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (!Synthesize) 1120ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 1121ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian else { 1122ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (PropertyIvar && PropertyIvar != PropertyId) 1123ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 1124ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 1125cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // Issue diagnostics only if Ivar belongs to current class. 1126cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian if (Ivar && Ivar->getSynthesize() && 112760ef308e51c71b760d7f598c1b763ceb7b768148Douglas Gregor declaresSameEntity(IC->getClassInterface(), ClassDeclared)) { 1128ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Diag(Ivar->getLocation(), diag::err_undeclared_var_use) 1129ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian << PropertyId; 1130ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar->setInvalidDecl(); 1131ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 1132ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 113328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 113428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 113528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 113628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplIvarDecl(PropertyIvar)) { 1137e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_duplicate_ivar_use) 113828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 113928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 114028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 114128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 114228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 114328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 114428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplDecl(PropertyId)) { 1145e4c043d3fdd0f98ab724aa4f1419cec9985ea2c4Eli Friedman Diag(PropertyDiagLoc, diag::error_property_implemented) << PropertyId; 114628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 1147d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 114828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 114928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->addPropertyImplementation(PIDecl); 115028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 115128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 1152d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PIDecl; 115328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 115428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 115528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 115628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Helper methods. 115728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 115828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 11599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// DiagnosePropertyMismatch - Compares two properties for their 11609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// attributes and types and warns on a variety of inconsistencies. 11619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 11629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 11639d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property, 11649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperProperty, 11659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const IdentifierInfo *inheritedName) { 11669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 11679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Property->getPropertyAttributes(); 11689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind SAttr = 11699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SuperProperty->getPropertyAttributes(); 11709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly) 11719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite)) 11729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_readonly_property) 11739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << inheritedName; 11749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy) 11759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_copy)) 11769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 11779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "copy" << inheritedName; 11781b46d8d78be713c546fb9680eaeea8f793bee5bfFariborz Jahanian else if (!(SAttr & ObjCPropertyDecl::OBJC_PR_readonly)){ 1179f85e193739c953358c865005855253af4f68a497John McCall unsigned CAttrRetain = 1180f85e193739c953358c865005855253af4f68a497John McCall (CAttr & 1181f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 1182f85e193739c953358c865005855253af4f68a497John McCall unsigned SAttrRetain = 1183f85e193739c953358c865005855253af4f68a497John McCall (SAttr & 1184f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 1185f85e193739c953358c865005855253af4f68a497John McCall bool CStrong = (CAttrRetain != 0); 1186f85e193739c953358c865005855253af4f68a497John McCall bool SStrong = (SAttrRetain != 0); 1187f85e193739c953358c865005855253af4f68a497John McCall if (CStrong != SStrong) 1188f85e193739c953358c865005855253af4f68a497John McCall Diag(Property->getLocation(), diag::warn_property_attribute) 1189f85e193739c953358c865005855253af4f68a497John McCall << Property->getDeclName() << "retain (or strong)" << inheritedName; 1190f85e193739c953358c865005855253af4f68a497John McCall } 11919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 11929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic) 11939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)) 11949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 11959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "atomic" << inheritedName; 11969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getSetterName() != SuperProperty->getSetterName()) 11979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 11989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "setter" << inheritedName; 11999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getGetterName() != SuperProperty->getGetterName()) 12009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 12019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "getter" << inheritedName; 12029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 12039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType LHSType = 12049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SuperProperty->getType()); 12059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType RHSType = 12069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(Property->getType()); 12079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1208c286f3835eb6001c61664cef5d610dfaf80a6e9bFariborz Jahanian if (!Context.propertyTypesAreCompatible(LHSType, RHSType)) { 12098beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // Do cases not handled in above. 12108beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // FIXME. For future support of covariant property types, revisit this. 12118beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian bool IncompatibleObjC = false; 12128beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian QualType ConvertedType; 12138beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian if (!isObjCPointerConversion(RHSType, LHSType, 12148beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian ConvertedType, IncompatibleObjC) || 121513546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian IncompatibleObjC) { 12168beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian Diag(Property->getLocation(), diag::warn_property_types_are_incompatible) 12178beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian << Property->getType() << SuperProperty->getType() << inheritedName; 121813546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian Diag(SuperProperty->getLocation(), diag::note_property_declare); 121913546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian } 12209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 12229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 12239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::DiagnosePropertyAccessorMismatch(ObjCPropertyDecl *property, 12249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, 12259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc) { 12269abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (!GetterMethod) 12279abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian return false; 12289abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType GetterType = GetterMethod->getResultType().getNonReferenceType(); 12299abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType PropertyIvarType = property->getType().getNonReferenceType(); 12309abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian bool compat = Context.hasSameType(PropertyIvarType, GetterType); 12319abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (!compat) { 12329abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (isa<ObjCObjectPointerType>(PropertyIvarType) && 12339abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian isa<ObjCObjectPointerType>(GetterType)) 12349abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian compat = 12359abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Context.canAssignObjCInterfaces( 1236490a52b4947381879a47b4251db5fb81cdf5d02bFariborz Jahanian GetterType->getAs<ObjCObjectPointerType>(), 1237490a52b4947381879a47b4251db5fb81cdf5d02bFariborz Jahanian PropertyIvarType->getAs<ObjCObjectPointerType>()); 1238490a52b4947381879a47b4251db5fb81cdf5d02bFariborz Jahanian else if (CheckAssignmentConstraints(Loc, GetterType, PropertyIvarType) 12399abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian != Compatible) { 12409abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(Loc, diag::error_property_accessor_type) 12419abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << property->getDeclName() << PropertyIvarType 12429abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << GetterMethod->getSelector() << GetterType; 12439abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(GetterMethod->getLocation(), diag::note_declared_at); 12449abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian return true; 12459abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian } else { 12469abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian compat = true; 12479abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType lhsType =Context.getCanonicalType(PropertyIvarType).getUnqualifiedType(); 12489abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian QualType rhsType =Context.getCanonicalType(GetterType).getUnqualifiedType(); 12499abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (lhsType != rhsType && lhsType->isArithmeticType()) 12509abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian compat = false; 12519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12539abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian 12549abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian if (!compat) { 12559abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(Loc, diag::warn_accessor_property_type_mismatch) 12569abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << property->getDeclName() 12579abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian << GetterMethod->getSelector(); 12589abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian Diag(GetterMethod->getLocation(), diag::note_declared_at); 12599abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian return true; 12609abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian } 12619abf88c9286d7465ce18285f87bb302f588b59fcFariborz Jahanian 12629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 12639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 12649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 12659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ComparePropertiesInBaseAndSuper - This routine compares property 12669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declarations in base and its super class, if any, and issues 1267fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner/// diagnostics in a variety of inconsistent situations. 12689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 12699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ComparePropertiesInBaseAndSuper(ObjCInterfaceDecl *IDecl) { 12709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *SDecl = IDecl->getSuperClass(); 12719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SDecl) 12729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 12739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: O(N^2) 12749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator S = SDecl->prop_begin(), 12759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = SDecl->prop_end(); S != E; ++S) { 1276581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *SuperPDecl = *S; 12779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Does property in super class has declaration in current class? 12789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator I = IDecl->prop_begin(), 12799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); I != E; ++I) { 1280581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *PDecl = *I; 12819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SuperPDecl->getIdentifier() == PDecl->getIdentifier()) 12829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch(PDecl, SuperPDecl, 12839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SDecl->getIdentifier()); 12849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 12879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 12889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// MatchOneProtocolPropertiesInClass - This routine goes thru the list 12899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// of properties declared in a protocol and compares their attribute against 12909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the same property declared in the class or category. 12919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 12929d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::MatchOneProtocolPropertiesInClass(Decl *CDecl, 12939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *PDecl) { 12949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 12959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 12969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 12979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 12989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "MatchOneProtocolPropertiesInClass"); 12999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CatDecl->IsClassExtension()) 13009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 13019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 1302581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Pr = *P; 13039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl::prop_iterator CP, CE; 13049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in category's list of properties? 13052d2f9368d35b3628c7e3b4563f74849a0f901a00Ted Kremenek for (CP = CatDecl->prop_begin(), CE = CatDecl->prop_end(); CP!=CE; ++CP) 1306262bc18e32500558af7cb0afa205b34bd37bafedDavid Blaikie if (CP->getIdentifier() == Pr->getIdentifier()) 13079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 13089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 13099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 1310581deb3da481053c4993c7600f97acf7768caac5David Blaikie DiagnosePropertyMismatch(*CP, Pr, PDecl->getIdentifier()); 13119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 13139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 13159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 1316581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Pr = *P; 13179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl::prop_iterator CP, CE; 13189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in class's list of properties? 13199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (CP = IDecl->prop_begin(), CE = IDecl->prop_end(); CP != CE; ++CP) 1320262bc18e32500558af7cb0afa205b34bd37bafedDavid Blaikie if (CP->getIdentifier() == Pr->getIdentifier()) 13219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 13229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 13239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 1324581deb3da481053c4993c7600f97acf7768caac5David Blaikie DiagnosePropertyMismatch(*CP, Pr, PDecl->getIdentifier()); 13259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 13279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CompareProperties - This routine compares properties 13299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declared in 'ClassOrProtocol' objects (which can be a class or an 13309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// inherited protocol with the list of properties for class/category 'CDecl' 13319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 1332d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CompareProperties(Decl *CDecl, Decl *ClassOrProtocol) { 1333d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ClassDecl = ClassOrProtocol; 13349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 13359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 13379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 13389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 13399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "CompareProperties"); 13409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *MDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 13419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = MDecl->protocol_begin(), 13429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MDecl->protocol_end(); P != E; ++P) 13439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of category with those of protocol (*P) 13449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 13459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this category and recursively match 13479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those in the category. 13489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = CatDecl->protocol_begin(), 13499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CatDecl->protocol_end(); P != E; ++P) 1350d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(CatDecl, *P); 13519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 13529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 13539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 13549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 13559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 13569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 13589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *MDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 136153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 136253b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = MDecl->all_referenced_protocol_begin(), 136353b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = MDecl->all_referenced_protocol_end(); P != E; ++P) 13649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of class IDecl with those of protocol (*P). 13659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 13669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this class and recursively match 13689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those declared in the class. 136953b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 137053b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = IDecl->all_referenced_protocol_begin(), 137153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); P != E; ++P) 1372d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(IDecl, *P); 13739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 13749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 13759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 13769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 13779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 13789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 13809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// isPropertyReadonly - Return true if property is readonly, by searching 13829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// for the property in the class and in its categories and implementations 13839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 13849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::isPropertyReadonly(ObjCPropertyDecl *PDecl, 13859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl) { 13869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // by far the most common case. 13879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!PDecl->isReadOnly()) 13889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 13899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if interface has a user defined setter, 13909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 13919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IDecl->getInstanceMethod(PDecl->getSetterName())) 13929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 13939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Main class has the property as 'readonly'. Must search 13959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // through the category list to see if the property's 13969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // attribute has been over-ridden to 'readwrite'. 13979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl *Category = IDecl->getCategoryList(); 13989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category; Category = Category->getNextClassCategory()) { 13999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if a category has a user defined setter, 14009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 14019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Category->getInstanceMethod(PDecl->getSetterName())) 14029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *P = 14049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category->FindPropertyDeclaration(PDecl->getIdentifier()); 14059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (P && !P->isReadOnly()) 14069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Also, check for definition of a setter method in the implementation if 14109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // all else failed. 14119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(CurContext)) { 14129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *IMD = 14139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCImplementationDecl>(OMD->getDeclContext())) { 14149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IMD->getInstanceMethod(PDecl->getSetterName())) 14159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else if (ObjCCategoryImplDecl *CIMD = 14179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCCategoryImplDecl>(OMD->getDeclContext())) { 14189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CIMD->getInstanceMethod(PDecl->getSetterName())) 14199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Lastly, look through the implementation (if one is in scope). 14239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *ImpDecl = IDecl->getImplementation()) 14249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ImpDecl->getInstanceMethod(PDecl->getSetterName())) 14259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 14269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // If all fails, look at the super class. 14279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *SIDecl = IDecl->getSuperClass()) 14289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return isPropertyReadonly(PDecl, SIDecl); 14299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 14309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 14319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CollectImmediateProperties - This routine collects all properties in 14339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the class and its conforming protocols; but not those it its super class. 14349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::CollectImmediateProperties(ObjCContainerDecl *CDecl, 1435cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap, 1436cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& SuperPropMap) { 14379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 14389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 14399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 1440581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 14419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 14429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 144453b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 144553b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 144653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 1447cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 14489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *CATDecl = dyn_cast<ObjCCategoryDecl>(CDecl)) { 14509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CATDecl->IsClassExtension()) 14519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = CATDecl->prop_begin(), 14529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->prop_end(); P != E; ++P) { 1453581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 14549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 14559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 145753b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCCategoryDecl::protocol_iterator PI = CATDecl->protocol_begin(), 14589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->protocol_end(); PI != E; ++PI) 1459cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 14609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 14629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 14639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 1464581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 1465cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *PropertyFromSuper = SuperPropMap[Prop->getIdentifier()]; 1466cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // Exclude property for protocols which conform to class's super-class, 1467cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // as super-class has to implement the property. 1468a929ec7b673b244bec024ba7eb95140404a7af5dFariborz Jahanian if (!PropertyFromSuper || 1469a929ec7b673b244bec024ba7eb95140404a7af5dFariborz Jahanian PropertyFromSuper->getIdentifier() != Prop->getIdentifier()) { 1470cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *&PropEntry = PropMap[Prop->getIdentifier()]; 1471cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropEntry) 1472cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian PropEntry = Prop; 1473cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian } 14749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 14769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 14779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) 1478cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 14799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 14819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1482509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectClassPropertyImplementations - This routine collects list of 1483509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in the class. This includes, class's 1484509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// and its conforming protocols' properties. 1485509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectClassPropertyImplementations(ObjCContainerDecl *CDecl, 1486509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 1487509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 1488509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 1489509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = IDecl->prop_end(); P != E; ++P) { 1490581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 1491509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 1492509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 149353b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 149453b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 149553b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 1496509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 1497509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1498509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 1499509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 1500509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->prop_end(); P != E; ++P) { 1501581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 1502d48bcb2f4dedf8e7b654cb017968b3d7b6663a57Benjamin Kramer // Insert into PropMap if not there already. 1503d48bcb2f4dedf8e7b654cb017968b3d7b6663a57Benjamin Kramer PropMap.insert(std::make_pair(Prop->getIdentifier(), Prop)); 1504509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1505509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // scan through protocol's protocols. 1506509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 1507509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->protocol_end(); PI != E; ++PI) 1508509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 1509509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1510509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 1511509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1512509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectSuperClassPropertyImplementations - This routine collects list of 1513509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in super class(s) and also coming from their 1514509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// conforming protocols. 1515509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectSuperClassPropertyImplementations(ObjCInterfaceDecl *CDecl, 1516509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 1517509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *SDecl = CDecl->getSuperClass()) { 1518509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian while (SDecl) { 1519509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(SDecl, PropMap); 1520509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian SDecl = SDecl->getSuperClass(); 1521509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1522509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1523509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 1524509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 15259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// LookupPropertyDecl - Looks up a property in the current class and all 15269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// its protocols. 15279d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekObjCPropertyDecl *Sema::LookupPropertyDecl(const ObjCContainerDecl *CDecl, 15289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek IdentifierInfo *II) { 15299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCInterfaceDecl *IDecl = 15309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCInterfaceDecl>(CDecl)) { 15319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 15329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 1533581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 15349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 15359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 15369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 153853b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 153953b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 154053b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) { 15419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 15429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 15439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 15449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (const ObjCProtocolDecl *PDecl = 15479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCProtocolDecl>(CDecl)) { 15489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 15499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 1550581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Prop = *P; 15519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 15529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 15539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 15559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 15569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) { 15579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 15589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 15599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 15609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return 0; 15639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 15649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1565d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenekstatic IdentifierInfo * getDefaultSynthIvarName(ObjCPropertyDecl *Prop, 1566d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek ASTContext &Ctx) { 1567f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> ivarName; 1568d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek { 1569d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek llvm::raw_svector_ostream os(ivarName); 1570d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek os << '_' << Prop->getIdentifier()->getName(); 1571d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek } 1572d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek return &Ctx.Idents.get(ivarName.str()); 1573d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek} 1574d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek 1575699c9044c7d53a2774d0dd261a6901dd2c4a545fJames Dennett/// \brief Default synthesizes all properties which must be synthesized 1576699c9044c7d53a2774d0dd261a6901dd2c4a545fJames Dennett/// in class's \@implementation. 1577d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenekvoid Sema::DefaultSynthesizeProperties(Scope *S, ObjCImplDecl* IMPDecl, 1578d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek ObjCInterfaceDecl *IDecl) { 1579509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1580509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 1581509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(IDecl, PropMap); 1582509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (PropMap.empty()) 1583509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian return; 1584509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 1585509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1586509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1587509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 1588509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 1589509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = P->second; 1590509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // If property to be implemented in the super class, ignore. 1591509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (SuperPropMap[Prop->getIdentifier()]) 1592509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 1593509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // Is there a matching propery synthesize/dynamic? 1594509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (Prop->isInvalidDecl() || 1595509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 1596509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian IMPDecl->FindPropertyImplIvarDecl(Prop->getIdentifier())) 1597509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 1598d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian // Property may have been synthesized by user. 1599d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian if (IMPDecl->FindPropertyImplDecl(Prop->getIdentifier())) 1600d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian continue; 160195f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getGetterName())) { 160295f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (Prop->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_readonly) 160395f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 160495f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getSetterName())) 160595f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 160695f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian } 1607f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian if (isa<ObjCProtocolDecl>(Prop->getDeclContext())) { 1608f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian // We won't auto-synthesize properties declared in protocols. 1609f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian Diag(IMPDecl->getLocation(), 1610f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian diag::warn_auto_synthesizing_protocol_property); 1611f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian Diag(Prop->getLocation(), diag::note_property_declare); 1612f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian continue; 1613f8aba8c618920db8f6ef2db0c554b0c270503cefFariborz Jahanian } 16142a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek 16152a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // We use invalid SourceLocations for the synthesized ivars since they 16162a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // aren't really synthesized at a particular location; they just exist. 16172a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // Saying that they are located at the @implementation isn't really going 16182a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // to help users. 1619975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian ObjCPropertyImplDecl *PIDecl = dyn_cast_or_null<ObjCPropertyImplDecl>( 1620975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian ActOnPropertyImplDecl(S, SourceLocation(), SourceLocation(), 1621975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian true, 1622975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian /* property = */ Prop->getIdentifier(), 1623975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian /* ivar = */ getDefaultSynthIvarName(Prop, Context), 1624390fff8e8b480fa146ffc14cbc63a1c2f9e2d206Argyrios Kyrtzidis Prop->getLocation())); 1625975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian if (PIDecl) { 1626975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian Diag(Prop->getLocation(), diag::warn_missing_explicit_synthesis); 16275ea66619a3108e2985e952b9a60a84316d464b25Fariborz Jahanian Diag(IMPDecl->getLocation(), diag::note_while_in_implementation); 1628975eef64182a78d1afc0f3da8cba4cb961cda5e4Fariborz Jahanian } 16292a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek } 1630509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 16319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 16328697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanianvoid Sema::DefaultSynthesizeProperties(Scope *S, Decl *D) { 1633260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (!LangOpts.ObjCDefaultSynthProperties || LangOpts.ObjCRuntime.isFragile()) 16348697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian return; 16358697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian ObjCImplementationDecl *IC=dyn_cast_or_null<ObjCImplementationDecl>(D); 16368697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (!IC) 16378697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian return; 16388697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (ObjCInterfaceDecl* IDecl = IC->getClassInterface()) 163971207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek if (!IDecl->isObjCRequiresPropertyDefs()) 1640eb4f2c56c298071d58b441ccf801b039be93788aFariborz Jahanian DefaultSynthesizeProperties(S, IC, IDecl); 16418697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian} 16428697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian 164317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanianvoid Sema::DiagnoseUnimplementedProperties(Scope *S, ObjCImplDecl* IMPDecl, 16449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl *CDecl, 1645811bfcd823d51db6a06b3fd5a5943ff910b79d68Benjamin Kramer const SelectorSet &InsMap) { 1646cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 1647cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) 1648cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1649cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian 16509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 1651cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties(CDecl, PropMap, SuperPropMap); 16529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PropMap.empty()) 16539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 16549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 16559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseSet<ObjCPropertyDecl *> PropImplMap; 16569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCImplDecl::propimpl_iterator 16579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I = IMPDecl->propimpl_begin(), 16589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek EI = IMPDecl->propimpl_end(); I != EI; ++I) 1659262bc18e32500558af7cb0afa205b34bd37bafedDavid Blaikie PropImplMap.insert(I->getPropertyDecl()); 16609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 16619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 16629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 16639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = P->second; 16649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is there a matching propery synthesize/dynamic? 16659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->isInvalidDecl() || 16669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 1667327126ee3d2faad9314b2633974eefc672f73b79Fariborz Jahanian PropImplMap.count(Prop) || Prop->hasAttr<UnavailableAttr>()) 16689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 16699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!InsMap.count(Prop->getGetterName())) { 1670b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(IMPDecl->getLocation(), 16719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 16729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 16739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 16749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getGetterName(); 1675b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(Prop->getLocation(), 1676b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian diag::note_property_declare); 1677260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (LangOpts.ObjCDefaultSynthProperties && LangOpts.ObjCRuntime.isNonFragile()) 1678da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian if (ObjCInterfaceDecl *ID = dyn_cast<ObjCInterfaceDecl>(CDecl)) 167971207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek if (const ObjCInterfaceDecl *RID = ID->isObjCRequiresPropertyDefs()) 1680da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian Diag(RID->getLocation(), diag::note_suppressed_class_declare); 1681da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian 16829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 16839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 16849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!Prop->isReadOnly() && !InsMap.count(Prop->getSetterName())) { 1685b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(IMPDecl->getLocation(), 16869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 16879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 16889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 16899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getSetterName(); 1690b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(Prop->getLocation(), 1691b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian diag::note_property_declare); 1692260611a32535c851237926bfcf78869b13c07d5bJohn McCall if (LangOpts.ObjCDefaultSynthProperties && LangOpts.ObjCRuntime.isNonFragile()) 1693da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian if (ObjCInterfaceDecl *ID = dyn_cast<ObjCInterfaceDecl>(CDecl)) 169471207fc0470e1eee40a2951cd5cc3ff47725b755Ted Kremenek if (const ObjCInterfaceDecl *RID = ID->isObjCRequiresPropertyDefs()) 1695da611a74c408af0f9526acc690b85214bf180852Fariborz Jahanian Diag(RID->getLocation(), diag::note_suppressed_class_declare); 16969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 16979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 16989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 16999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 17009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 17019d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::AtomicPropertySetterGetterRules (ObjCImplDecl* IMPDecl, 17029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl* IDecl) { 17039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Rules apply in non-GC mode only 17044e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() != LangOptions::NonGC) 17059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 17069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator I = IDecl->prop_begin(), 17079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); 17089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I != E; ++I) { 1709581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyDecl *Property = *I; 171094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *GetterMethod = 0; 171194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *SetterMethod = 0; 171294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis bool LookedUpGetterSetter = false; 171394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 17149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned Attributes = Property->getPropertyAttributes(); 1715265941bc308d65cc270d5c4de5806f37ce405606John McCall unsigned AttributesAsWritten = Property->getPropertyAttributesAsWritten(); 171694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 1717265941bc308d65cc270d5c4de5806f37ce405606John McCall if (!(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_atomic) && 1718265941bc308d65cc270d5c4de5806f37ce405606John McCall !(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_nonatomic)) { 171994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 172094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 172194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 172294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (GetterMethod) { 172394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(GetterMethod->getLocation(), 172494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1725293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 0; 172694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 172794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 172894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (SetterMethod) { 172994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(SetterMethod->getLocation(), 173094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1731293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 1; 173294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 173394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 173494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 173594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 17369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // We only care about readwrite atomic property. 17379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCPropertyDecl::OBJC_PR_nonatomic) || 17389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek !(Attributes & ObjCPropertyDecl::OBJC_PR_readwrite)) 17399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 17409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCPropertyImplDecl *PIDecl 17419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek = IMPDecl->FindPropertyImplDecl(Property->getIdentifier())) { 17429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic) 17439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 174494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (!LookedUpGetterSetter) { 174594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 174694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 174794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 174894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 17499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((GetterMethod && !SetterMethod) || (!GetterMethod && SetterMethod)) { 17509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation MethodLoc = 17519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (GetterMethod ? GetterMethod->getLocation() 17529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek : SetterMethod->getLocation()); 17539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(MethodLoc, diag::warn_atomic_property_rule) 17547d65f6965d215f4cb2eb0738ee1b9024e5ab5bbaFariborz Jahanian << Property->getIdentifier() << (GetterMethod != 0) 17557d65f6965d215f4cb2eb0738ee1b9024e5ab5bbaFariborz Jahanian << (SetterMethod != 0); 175677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian // fixit stuff. 175777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian if (!AttributesAsWritten) { 175877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian if (Property->getLParenLoc().isValid()) { 175977bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian // @property () ... case. 176077bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceRange PropSourceRange(Property->getAtLoc(), 176177bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Property->getLParenLoc()); 176277bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(Property->getLocation(), diag::note_atomic_property_fixup_suggest) << 176377bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FixItHint::CreateReplacement(PropSourceRange, "@property (nonatomic"); 176477bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 176577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian else { 176677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian //@property id etc. 176777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation endLoc = 176877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Property->getTypeSourceInfo()->getTypeLoc().getBeginLoc(); 176977bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian endLoc = endLoc.getLocWithOffset(-1); 177077bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceRange PropSourceRange(Property->getAtLoc(), endLoc); 177177bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(Property->getLocation(), diag::note_atomic_property_fixup_suggest) << 177277bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FixItHint::CreateReplacement(PropSourceRange, "@property (nonatomic) "); 177377bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 177477bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 177577bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian else if (!(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_atomic)) { 177677bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian // @property () ... case. 177777bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceLocation endLoc = Property->getLParenLoc(); 177877bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian SourceRange PropSourceRange(Property->getAtLoc(), endLoc); 177977bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(Property->getLocation(), diag::note_atomic_property_fixup_suggest) << 178077bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian FixItHint::CreateReplacement(PropSourceRange, "@property (nonatomic, "); 178177bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian } 178277bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian else 178377bfb8b43ec3f7dee3a71f6e854b03ad29dab84fFariborz Jahanian Diag(MethodLoc, diag::note_atomic_property_fixup_suggest); 17849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::note_property_declare); 17859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 17869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 17879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 17889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 17899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1790f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::DiagnoseOwningPropertyGetterSynthesis(const ObjCImplementationDecl *D) { 17914e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() == LangOptions::GCOnly) 1792f85e193739c953358c865005855253af4f68a497John McCall return; 1793f85e193739c953358c865005855253af4f68a497John McCall 1794f85e193739c953358c865005855253af4f68a497John McCall for (ObjCImplementationDecl::propimpl_iterator 1795f85e193739c953358c865005855253af4f68a497John McCall i = D->propimpl_begin(), e = D->propimpl_end(); i != e; ++i) { 1796581deb3da481053c4993c7600f97acf7768caac5David Blaikie ObjCPropertyImplDecl *PID = *i; 1797f85e193739c953358c865005855253af4f68a497John McCall if (PID->getPropertyImplementation() != ObjCPropertyImplDecl::Synthesize) 1798f85e193739c953358c865005855253af4f68a497John McCall continue; 1799f85e193739c953358c865005855253af4f68a497John McCall 1800f85e193739c953358c865005855253af4f68a497John McCall const ObjCPropertyDecl *PD = PID->getPropertyDecl(); 1801831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (PD && !PD->hasAttr<NSReturnsNotRetainedAttr>() && 1802831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !D->getInstanceMethod(PD->getGetterName())) { 1803f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodDecl *method = PD->getGetterMethodDecl(); 1804f85e193739c953358c865005855253af4f68a497John McCall if (!method) 1805f85e193739c953358c865005855253af4f68a497John McCall continue; 1806f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodFamily family = method->getMethodFamily(); 1807f85e193739c953358c865005855253af4f68a497John McCall if (family == OMF_alloc || family == OMF_copy || 1808f85e193739c953358c865005855253af4f68a497John McCall family == OMF_mutableCopy || family == OMF_new) { 18094e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 1810f85e193739c953358c865005855253af4f68a497John McCall Diag(PID->getLocation(), diag::err_ownin_getter_rule); 1811f85e193739c953358c865005855253af4f68a497John McCall else 1812920c9c1155c118ac40e5209d4b757b9f54186339Ted Kremenek Diag(PID->getLocation(), diag::warn_owning_getter_rule); 1813f85e193739c953358c865005855253af4f68a497John McCall Diag(PD->getLocation(), diag::note_property_declare); 1814f85e193739c953358c865005855253af4f68a497John McCall } 1815f85e193739c953358c865005855253af4f68a497John McCall } 1816f85e193739c953358c865005855253af4f68a497John McCall } 1817f85e193739c953358c865005855253af4f68a497John McCall} 1818f85e193739c953358c865005855253af4f68a497John McCall 18195de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// AddPropertyAttrs - Propagates attributes from a property to the 18205de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// implicitly-declared getter or setter for that property. 18215de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCallstatic void AddPropertyAttrs(Sema &S, ObjCMethodDecl *PropertyMethod, 18225de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall ObjCPropertyDecl *Property) { 18235de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall // Should we just clone all attributes over? 18240a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor for (Decl::attr_iterator A = Property->attr_begin(), 18250a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor AEnd = Property->attr_end(); 18260a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor A != AEnd; ++A) { 18270a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor if (isa<DeprecatedAttr>(*A) || 18280a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<UnavailableAttr>(*A) || 18290a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<AvailabilityAttr>(*A)) 18300a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor PropertyMethod->addAttr((*A)->clone(S.Context)); 18310a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor } 18325de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall} 18335de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 18349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ProcessPropertyDecl - Make sure that any user-defined setter/getter methods 18359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// have the property type and issue diagnostics if they don't. 18369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// Also synthesize a getter/setter method if none exist (and update the 18379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// appropriate lookup tables. FIXME: Should reconsider if adding synthesized 18389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// methods is the "right" thing to do. 18399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ProcessPropertyDecl(ObjCPropertyDecl *property, 18408254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *CD, 18418254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCPropertyDecl *redeclaredProperty, 18428254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *lexicalDC) { 18438254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 18449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, *SetterMethod; 18459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 18469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod = CD->getInstanceMethod(property->getGetterName()); 18479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod = CD->getInstanceMethod(property->getSetterName()); 18489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyAccessorMismatch(property, GetterMethod, 18499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation()); 18509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 18519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) { 18529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 18539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getPropertyAttributes(); 18549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((!(CAttr & ObjCPropertyDecl::OBJC_PR_readonly)) && 18559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SetterMethod->getResultType()) != 18569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.VoidTy) 18579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::err_setter_type_void); 18589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod->param_size() != 1 || 18592aac0c9f8bc4dca3f883f429af8c1f57132d62d0Fariborz Jahanian !Context.hasSameUnqualifiedType( 1860bb13c320fff4bc4b3536e62626c97d7b055c6113Fariborz Jahanian (*SetterMethod->param_begin())->getType().getNonReferenceType(), 1861bb13c320fff4bc4b3536e62626c97d7b055c6113Fariborz Jahanian property->getType().getNonReferenceType())) { 18629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(property->getLocation(), 18639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_accessor_property_type_mismatch) 18649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 18659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << SetterMethod->getSelector(); 18669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::note_declared_at); 18679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 18689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 18699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 18709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Synthesize getter/setter methods if none exist. 18719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default getter and if one not found, add one. 18729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: The synthesized property we set here is misleading. We almost always 18739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // synthesize these methods unless the user explicitly provided prototypes 18749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // (which is odd, but allowed). Sema should be typechecking that the 18759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // declarations jive in that situation (which it is not currently). 18769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!GetterMethod) { 18779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property getter name was found. 18789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a getter method and add it to the list of methods 18799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 1880a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek SourceLocation Loc = redeclaredProperty ? 1881a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek redeclaredProperty->getLocation() : 1882a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getLocation(); 1883a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek 1884a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek GetterMethod = ObjCMethodDecl::Create(Context, Loc, Loc, 1885a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getGetterName(), 188675cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis property->getType(), 0, CD, /*isInstance=*/true, 188775cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isVariadic=*/false, /*isSynthesized=*/true, 188875cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, /*isDefined=*/false, 18899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 18909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 18919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Optional : 18929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Required); 18939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(GetterMethod); 18945de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 18955de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, GetterMethod, property); 18965de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 189723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 189823173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 1899a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek if (lexicalDC) 190023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek GetterMethod->setLexicalDeclContext(lexicalDC); 1901831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>()) 1902831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian GetterMethod->addAttr( 1903831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian ::new (Context) NSReturnsNotRetainedAttr(Loc, Context)); 19049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 19059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared getter will be synthesize when @synthesize of 19069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 19079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->setSynthesized(true); 19089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setGetterMethodDecl(GetterMethod); 19099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 19109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Skip setter if property is read-only. 19119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!property->isReadOnly()) { 19129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default setter and if one not found, add one. 19139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SetterMethod) { 19149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property setter name was found. 19159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a setter method and add it to the list of methods 19169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 19178254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SourceLocation Loc = redeclaredProperty ? 19188254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek redeclaredProperty->getLocation() : 19198254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getLocation(); 19208254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 19218254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SetterMethod = 1922491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis ObjCMethodDecl::Create(Context, Loc, Loc, 19238254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getSetterName(), Context.VoidTy, 0, 192475cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis CD, /*isInstance=*/true, /*isVariadic=*/false, 192575cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isSynthesized=*/true, 192675cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, 192775cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isDefined=*/false, 19289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 19299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 19308254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Optional : 19318254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Required); 19328254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 19339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Invent the arguments for the setter. We don't bother making a 19349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // nice name for the argument. 1935ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara ParmVarDecl *Argument = ParmVarDecl::Create(Context, SetterMethod, 1936ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Loc, Loc, 19379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getIdentifier(), 1938f85e193739c953358c865005855253af4f68a497John McCall property->getType().getUnqualifiedType(), 19399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek /*TInfo=*/0, 1940d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 1941d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 19429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 0); 1943491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis SetterMethod->setMethodParams(Context, Argument, 1944491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis ArrayRef<SourceLocation>()); 19455de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 19465de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, SetterMethod, property); 19475de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 19489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(SetterMethod); 194923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 195023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 19518254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek if (lexicalDC) 195223173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek SetterMethod->setLexicalDeclContext(lexicalDC); 19539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 19549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared setter will be synthesize when @synthesize of 19559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 19569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod->setSynthesized(true); 19579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setSetterMethodDecl(SetterMethod); 19589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 19599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Add any synthesized methods to the global pool. This allows us to 19609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // handle the following, which is supported by GCC (and part of the design). 19619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 19629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @interface Foo 19639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @property double bar; 19649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @end 19659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 19669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // void thisIsUnfortunate() { 19679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // id foo; 19689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // double bar = [foo bar]; 19699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // } 19709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 19719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod) 19729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(GetterMethod); 19739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) 19749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(SetterMethod); 1975e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis 1976e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis ObjCInterfaceDecl *CurrentClass = dyn_cast<ObjCInterfaceDecl>(CD); 1977e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (!CurrentClass) { 1978e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (ObjCCategoryDecl *Cat = dyn_cast<ObjCCategoryDecl>(CD)) 1979e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CurrentClass = Cat->getClassInterface(); 1980e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis else if (ObjCImplDecl *Impl = dyn_cast<ObjCImplDecl>(CD)) 1981e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CurrentClass = Impl->getClassInterface(); 1982e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis } 1983e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (GetterMethod) 1984e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CheckObjCMethodOverrides(GetterMethod, CurrentClass, Sema::RTC_Unknown); 1985e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis if (SetterMethod) 1986e15db6f0d226a3bc88d244512d1004c7c1c07391Argyrios Kyrtzidis CheckObjCMethodOverrides(SetterMethod, CurrentClass, Sema::RTC_Unknown); 19879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 19889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1989d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CheckObjCPropertyAttributes(Decl *PDecl, 19909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc, 1991cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian unsigned &Attributes, 1992cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian bool propertyInPrimaryClass) { 19939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Improve the reported location. 1994f85e193739c953358c865005855253af4f68a497John McCall if (!PDecl || PDecl->isInvalidDecl()) 19955fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek return; 19965fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek 19975fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek ObjCPropertyDecl *PropertyDecl = cast<ObjCPropertyDecl>(PDecl); 1998842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian QualType PropertyTy = PropertyDecl->getType(); 19999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 20004e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 2001015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2002015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian PropertyTy->isObjCRetainableType()) { 2003015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // 'readonly' property with no obvious lifetime. 2004015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian // its life time will be determined by its backing ivar. 2005015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian unsigned rel = (ObjCDeclSpec::DQ_PR_unsafe_unretained | 2006015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_copy | 2007015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_retain | 2008015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_strong | 2009015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_weak | 2010015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian ObjCDeclSpec::DQ_PR_assign); 2011015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian if ((Attributes & rel) == 0) 2012015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian return; 2013015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian } 2014015f608042a1d247899866849e69a4e9a1aff6a8Fariborz Jahanian 2015cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if (propertyInPrimaryClass) { 2016cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // we postpone most property diagnosis until class's implementation 2017cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // because, its readonly attribute may be overridden in its class 2018cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian // extensions making other attributes, which make no sense, to make sense. 2019cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2020cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_readwrite)) 2021cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2022cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian << "readonly" << "readwrite"; 2023cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian } 20249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // readonly and readwrite/assign/retain/copy conflict. 2025cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian else if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2026cea06d26b8f3a2599bba79f7e072b7550de949a7Fariborz Jahanian (Attributes & (ObjCDeclSpec::DQ_PR_readwrite | 202728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_assign | 2028f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 202928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_copy | 2030f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | 2031f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_strong))) { 203228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek const char * which = (Attributes & ObjCDeclSpec::DQ_PR_readwrite) ? 203328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "readwrite" : 203428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 203528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "assign" : 2036f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) ? 2037f85e193739c953358c865005855253af4f68a497John McCall "unsafe_unretained" : 203828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 203928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "copy" : "retain"; 20409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 204128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, (Attributes & (ObjCDeclSpec::DQ_PR_readwrite)) ? 204228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::err_objc_property_attr_mutually_exclusive : 204328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::warn_objc_property_attr_mutually_exclusive) 204428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "readonly" << which; 204528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 20469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 204728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for copy or retain on non-object types. 2048f85e193739c953358c865005855253af4f68a497John McCall if ((Attributes & (ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 2049f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong)) && 2050f85e193739c953358c865005855253af4f68a497John McCall !PropertyTy->isObjCRetainableType() && 2051842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian !PropertyDecl->getAttr<ObjCNSObjectAttr>()) { 205228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_requires_object) 2053f85e193739c953358c865005855253af4f68a497John McCall << (Attributes & ObjCDeclSpec::DQ_PR_weak ? "weak" : 2054f85e193739c953358c865005855253af4f68a497John McCall Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain (or strong)"); 2055f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~(ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 2056f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong); 2057977ea7864a50eee39f6bef8a5a79154ac9ba4b3eJohn McCall PropertyDecl->setInvalidDecl(); 205828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 20599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 206028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for more than one of { assign, copy, retain }. 206128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_assign) { 206228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 206328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 206428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "copy"; 206528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 206628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 206728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 206828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 206928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "retain"; 207028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 207128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 2072f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 2073f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2074f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "strong"; 2075f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 2076f85e193739c953358c865005855253af4f68a497John McCall } 20774e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 2078f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2079f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2080f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "weak"; 2081f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 2082f85e193739c953358c865005855253af4f68a497John McCall } 2083f85e193739c953358c865005855253af4f68a497John McCall } else if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) { 2084f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 2085f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2086f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "copy"; 2087f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 2088f85e193739c953358c865005855253af4f68a497John McCall } 2089f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 2090f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2091f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "retain"; 2092f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 2093f85e193739c953358c865005855253af4f68a497John McCall } 2094f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 2095f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2096f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "strong"; 2097f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 2098f85e193739c953358c865005855253af4f68a497John McCall } 20994e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount && 2100f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2101f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2102f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "weak"; 2103f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 2104f85e193739c953358c865005855253af4f68a497John McCall } 210528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 210628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 210728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 210828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "copy" << "retain"; 210928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 211028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 2111f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 2112f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2113f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "strong"; 2114f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 2115f85e193739c953358c865005855253af4f68a497John McCall } 2116f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_weak) { 2117f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2118f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "weak"; 2119f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 2120f85e193739c953358c865005855253af4f68a497John McCall } 2121f85e193739c953358c865005855253af4f68a497John McCall } 2122f85e193739c953358c865005855253af4f68a497John McCall else if ((Attributes & ObjCDeclSpec::DQ_PR_retain) && 2123f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2124f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2125f85e193739c953358c865005855253af4f68a497John McCall << "retain" << "weak"; 2126528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 2127f85e193739c953358c865005855253af4f68a497John McCall } 2128f85e193739c953358c865005855253af4f68a497John McCall else if ((Attributes & ObjCDeclSpec::DQ_PR_strong) && 2129f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 2130f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 2131f85e193739c953358c865005855253af4f68a497John McCall << "strong" << "weak"; 2132f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 213328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 21349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 21359d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian if ((Attributes & ObjCDeclSpec::DQ_PR_atomic) && 21369d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_nonatomic)) { 21379d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 21389d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian << "atomic" << "nonatomic"; 21399d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian Attributes &= ~ObjCDeclSpec::DQ_PR_atomic; 21409d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian } 21419d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian 214228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Warn if user supplied no assignment attribute, property is 214328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // readwrite, and this is an object type. 214428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy | 2145f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 2146f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong | 2147f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_weak)) && 214828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyTy->isObjCObjectPointerType()) { 21494e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().ObjCAutoRefCount) 2150bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // With arc, @property definitions should default to (strong) when 2151f21a92d35953adb038ffbe37cd1a4083e0df0ec0Fariborz Jahanian // not specified; including when property is 'readonly'. 2152bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian PropertyDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 2153f21a92d35953adb038ffbe37cd1a4083e0df0ec0Fariborz Jahanian else if (!(Attributes & ObjCDeclSpec::DQ_PR_readonly)) { 21549f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian bool isAnyClassTy = 21559f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian (PropertyTy->isObjCClassType() || 21569f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian PropertyTy->isObjCQualifiedClassType()); 21579f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian // In non-gc, non-arc mode, 'Class' is treated as a 'void *' no need to 21589f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian // issue any warning. 21594e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (isAnyClassTy && getLangOpts().getGC() == LangOptions::NonGC) 21609f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian ; 21619f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian else { 2162bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // Skip this warning in gc-only mode. 21634e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() != LangOptions::GCOnly) 2164bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_no_assignment_attribute); 21650a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 2166bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // If non-gc code warn that this is likely inappropriate. 21674e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (getLangOpts().getGC() == LangOptions::NonGC) 2168bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_default_assign_on_object); 21699f37cd1810646ffc9002c7a6477fe158ee15ede4Fariborz Jahanian } 2170bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian } 21719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 217228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME: Implement warning dependent on NSCopying being 217328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // implemented. See also: 217428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496> 217528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // (please trim this list while you are at it). 217628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 21779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 217828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & ObjCDeclSpec::DQ_PR_copy) 21792b77cb803c76d01d2d10a58cec9334e2090cd7c3Fariborz Jahanian &&!(Attributes & ObjCDeclSpec::DQ_PR_readonly) 21804e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie && getLangOpts().getGC() == LangOptions::GCOnly 218128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && PropertyTy->isBlockPointerType()) 218228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_copy_missing_on_block); 21837c16d58f8546365d1f56468e9ae1ecfa182afca0Fariborz Jahanian else if ((Attributes & ObjCDeclSpec::DQ_PR_retain) && 2184528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian !(Attributes & ObjCDeclSpec::DQ_PR_readonly) && 2185528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian !(Attributes & ObjCDeclSpec::DQ_PR_strong) && 2186528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian PropertyTy->isBlockPointerType()) 2187528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian Diag(Loc, diag::warn_objc_property_retain_of_block); 218848a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian 218948a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 219048a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_setter)) 219148a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian Diag(Loc, diag::warn_objc_readonly_property_has_setter); 219248a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian 21939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 2194