SemaObjCProperty.cpp revision 788f489a37bf1150deb9378cec6a6eb902d0d1b2
19d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===--- SemaObjCProperty.cpp - Semantic Analysis for ObjC @property ------===//
29d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//
39d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//                     The LLVM Compiler Infrastructure
49d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//
59d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file is distributed under the University of Illinois Open Source
69d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// License. See LICENSE.TXT for details.
79d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//
89d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===//
99d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//
109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//  This file implements semantic analysis for Objective C @property and
119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//  @synthesize declarations.
129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//
139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===//
149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h"
16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Initialization.h"
177cd088e519d7e6caa4c4c12db52e0e4ae35d25c2John McCall#include "clang/AST/DeclObjC.h"
1817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian#include "clang/AST/ExprObjC.h"
1950df6ae41f232612e5e88b19e0db9900d08d2f6cJohn McCall#include "llvm/ADT/DenseSet.h"
209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekusing namespace clang;
229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
2328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===//
2428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Grammar actions.
2528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===//
2628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
27d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnProperty(Scope *S, SourceLocation AtLoc,
28d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall                          FieldDeclarator &FD,
29d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall                          ObjCDeclSpec &ODS,
30d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall                          Selector GetterSel,
31d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall                          Selector SetterSel,
32d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall                          Decl *ClassCategory,
33d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall                          bool *isOverridingProperty,
344a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek                          tok::ObjCKeywordKind MethodImplKind,
354a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek                          DeclContext *lexicalDC) {
3628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  unsigned Attributes = ODS.getPropertyAttributes();
3728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  bool isReadWrite = ((Attributes & ObjCDeclSpec::DQ_PR_readwrite) ||
3828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                      // default is readwrite!
3928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                      !(Attributes & ObjCDeclSpec::DQ_PR_readonly));
4028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  // property is defaulted to 'assign' if it is readwrite and is
4128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  // not retain or copy
4228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  bool isAssign = ((Attributes & ObjCDeclSpec::DQ_PR_assign) ||
4328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                   (isReadWrite &&
4428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                    !(Attributes & ObjCDeclSpec::DQ_PR_retain) &&
4528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                    !(Attributes & ObjCDeclSpec::DQ_PR_copy)));
46e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek
47bf1a028246d884a540aeafa38e89be59a269b072John McCall  TypeSourceInfo *TSI = GetTypeForDeclarator(FD.D, S);
48bf1a028246d884a540aeafa38e89be59a269b072John McCall  QualType T = TSI->getType();
4928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if (T->isReferenceType()) {
5028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    Diag(AtLoc, diag::error_reference_property);
51d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall    return 0;
5228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  }
53e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  // Proceed with constructing the ObjCPropertDecls.
54e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  ObjCContainerDecl *ClassDecl =
55d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall    cast<ObjCContainerDecl>(ClassCategory);
56e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek
5728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl))
58ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian    if (CDecl->IsClassExtension()) {
59d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall      Decl *Res = HandlePropertyInClassExtension(S, CDecl, AtLoc,
60ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian                                           FD, GetterSel, SetterSel,
61ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian                                           isAssign, isReadWrite,
62ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian                                           Attributes,
63ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian                                           isOverridingProperty, TSI,
64ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian                                           MethodImplKind);
65ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian      if (Res)
66ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian        CheckObjCPropertyAttributes(Res, AtLoc, Attributes);
67ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian      return Res;
68ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian    }
69ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian
70d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall  Decl *Res = CreatePropertyDecl(S, ClassDecl, AtLoc, FD,
71d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall                                 GetterSel, SetterSel,
72d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall                                 isAssign, isReadWrite,
73d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall                                 Attributes, TSI, MethodImplKind);
744a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek  if (lexicalDC)
754a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek    Res->setLexicalDeclContext(lexicalDC);
764a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek
77842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian  // Validate the attributes on the @property.
78842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian  CheckObjCPropertyAttributes(Res, AtLoc, Attributes);
79842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian  return Res;
80e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek}
81e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek
82d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *
83e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekSema::HandlePropertyInClassExtension(Scope *S, ObjCCategoryDecl *CDecl,
84e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                                     SourceLocation AtLoc, FieldDeclarator &FD,
85e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                                     Selector GetterSel, Selector SetterSel,
86e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                                     const bool isAssign,
87e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                                     const bool isReadWrite,
88e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                                     const unsigned Attributes,
89e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                                     bool *isOverridingProperty,
9083a230c83a54190366138c1a4f4310ef838b88fcJohn McCall                                     TypeSourceInfo *T,
91e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                                     tok::ObjCKeywordKind MethodImplKind) {
92e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek
93e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  // Diagnose if this property is already in continuation class.
94e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  DeclContext *DC = cast<DeclContext>(CDecl);
95e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  IdentifierInfo *PropertyId = FD.D.getIdentifier();
96894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek
979f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek  if (ObjCPropertyDecl *prevDecl =
989f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek        ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) {
99e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    Diag(AtLoc, diag::err_duplicate_property);
100894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek    Diag(prevDecl->getLocation(), diag::note_property_declare);
101d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall    return 0;
102e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  }
103e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek
104e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  // Create a new ObjCPropertyDecl with the DeclContext being
105e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  // the class extension.
106e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  ObjCPropertyDecl *PDecl =
107e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    ObjCPropertyDecl::Create(Context, DC, FD.D.getIdentifierLoc(),
108e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                             PropertyId, AtLoc, T);
10922f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian  if (Attributes & ObjCDeclSpec::DQ_PR_readonly)
11022f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian    PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly);
11122f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian  if (Attributes & ObjCDeclSpec::DQ_PR_readwrite)
11222f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian    PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite);
11322f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian
114e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  DC->addDecl(PDecl);
115e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek
116e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  // We need to look in the @interface to see if the @property was
117e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  // already declared.
118e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  ObjCInterfaceDecl *CCPrimary = CDecl->getClassInterface();
119e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  if (!CCPrimary) {
120e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    Diag(CDecl->getLocation(), diag::err_continuation_class);
121e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    *isOverridingProperty = true;
122d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall    return 0;
123e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  }
124e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek
125e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  // Find the property in continuation class's primary class only.
126e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  ObjCPropertyDecl *PIDecl =
127e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    CCPrimary->FindPropertyVisibleInPrimaryClass(PropertyId);
128e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek
129e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  if (!PIDecl) {
130e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    // No matching property found in the primary class. Just fall thru
131e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    // and add property to continuation class's primary class.
132e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    ObjCPropertyDecl *PDecl =
133e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek      CreatePropertyDecl(S, CCPrimary, AtLoc,
134e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                         FD, GetterSel, SetterSel, isAssign, isReadWrite,
13523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek                         Attributes, T, MethodImplKind, DC);
13680aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian    // Mark written attribute as having no attribute because
13780aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian    // this is not a user-written property declaration in primary
13880aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian    // class.
13980aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian    PDecl->setPropertyAttributesAsWritten(ObjCPropertyDecl::OBJC_PR_noattr);
140e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek
141e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    // A case of continuation class adding a new property in the class. This
142e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    // is not what it was meant for. However, gcc supports it and so should we.
143e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    // Make sure setter/getters are declared here.
144a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek    ProcessPropertyDecl(PDecl, CCPrimary, /* redeclaredProperty = */ 0,
145a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek                        /* lexicalDC = */ CDecl);
146d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall    return PDecl;
147e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  }
148e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek
149e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  // The property 'PIDecl's readonly attribute will be over-ridden
150e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  // with continuation class's readwrite property attribute!
15180aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian  unsigned PIkind = PIDecl->getPropertyAttributesAsWritten();
152e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  if (isReadWrite && (PIkind & ObjCPropertyDecl::OBJC_PR_readonly)) {
153e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    unsigned retainCopyNonatomic =
154e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    (ObjCPropertyDecl::OBJC_PR_retain |
155e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek     ObjCPropertyDecl::OBJC_PR_copy |
156e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek     ObjCPropertyDecl::OBJC_PR_nonatomic);
157e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    if ((Attributes & retainCopyNonatomic) !=
158e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek        (PIkind & retainCopyNonatomic)) {
159e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek      Diag(AtLoc, diag::warn_property_attr_mismatch);
160e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek      Diag(PIDecl->getLocation(), diag::note_property_declare);
161e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    }
1629944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek    DeclContext *DC = cast<DeclContext>(CCPrimary);
1639944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek    if (!ObjCPropertyDecl::findPropertyDecl(DC,
1649944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek                                 PIDecl->getDeclName().getAsIdentifierInfo())) {
165e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek      // Protocol is not in the primary class. Must build one for it.
166e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek      ObjCDeclSpec ProtocolPropertyODS;
167e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek      // FIXME. Assuming that ObjCDeclSpec::ObjCPropertyAttributeKind
168e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek      // and ObjCPropertyDecl::PropertyAttributeKind have identical
169e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek      // values.  Should consolidate both into one enum type.
170e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek      ProtocolPropertyODS.
171e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek      setPropertyAttributes((ObjCDeclSpec::ObjCPropertyAttributeKind)
172e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                            PIkind);
173e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek
174d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall      Decl *ProtocolPtrTy =
175e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek        ActOnProperty(S, AtLoc, FD, ProtocolPropertyODS,
176e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                      PIDecl->getGetterName(),
177e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                      PIDecl->getSetterName(),
178d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall                      CCPrimary, isOverridingProperty,
1794a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek                      MethodImplKind,
1804a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek                      /* lexicalDC = */ CDecl);
181d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall      PIDecl = cast<ObjCPropertyDecl>(ProtocolPtrTy);
18228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    }
183e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    PIDecl->makeitReadWriteAttribute();
184e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    if (Attributes & ObjCDeclSpec::DQ_PR_retain)
185e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek      PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain);
186e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    if (Attributes & ObjCDeclSpec::DQ_PR_copy)
187e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek      PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy);
188e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    PIDecl->setSetterName(SetterSel);
189e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  } else {
190788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek    // Tailor the diagnostics for the common case where a readwrite
191788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek    // property is declared both in the @interface and the continuation.
192788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek    // This is a common error where the user often intended the original
193788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek    // declaration to be readonly.
194788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek    unsigned diag =
195788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek      (Attributes & ObjCDeclSpec::DQ_PR_readwrite) &&
196788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek      (PIkind & ObjCPropertyDecl::OBJC_PR_readwrite)
197788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek      ? diag::err_use_continuation_class_redeclaration_readwrite
198788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek      : diag::err_use_continuation_class;
199788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek    Diag(AtLoc, diag)
200e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek      << CCPrimary->getDeclName();
201e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek    Diag(PIDecl->getLocation(), diag::note_property_declare);
202e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  }
203e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  *isOverridingProperty = true;
204e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  // Make sure setter decl is synthesized, and added to primary class's list.
2058254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek  ProcessPropertyDecl(PIDecl, CCPrimary, PDecl, CDecl);
206d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall  return 0;
207e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek}
208e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek
209e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekObjCPropertyDecl *Sema::CreatePropertyDecl(Scope *S,
210e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                                           ObjCContainerDecl *CDecl,
211e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                                           SourceLocation AtLoc,
212e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                                           FieldDeclarator &FD,
213e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                                           Selector GetterSel,
214e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                                           Selector SetterSel,
215e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                                           const bool isAssign,
216e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                                           const bool isReadWrite,
217e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek                                           const unsigned Attributes,
21883a230c83a54190366138c1a4f4310ef838b88fcJohn McCall                                           TypeSourceInfo *TInfo,
21923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek                                           tok::ObjCKeywordKind MethodImplKind,
22023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek                                           DeclContext *lexicalDC){
221e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  IdentifierInfo *PropertyId = FD.D.getIdentifier();
22283a230c83a54190366138c1a4f4310ef838b88fcJohn McCall  QualType T = TInfo->getType();
22328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
22428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  // Issue a warning if property is 'assign' as default and its object, which is
22528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  // gc'able conforms to NSCopying protocol
22628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if (getLangOptions().getGCMode() != LangOptions::NonGC &&
22728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      isAssign && !(Attributes & ObjCDeclSpec::DQ_PR_assign))
228c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall    if (const ObjCObjectPointerType *ObjPtrTy =
229c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall          T->getAs<ObjCObjectPointerType>()) {
230c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall      ObjCInterfaceDecl *IDecl = ObjPtrTy->getObjectType()->getInterface();
231c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall      if (IDecl)
232c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall        if (ObjCProtocolDecl* PNSCopying =
233c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall            LookupProtocol(&Context.Idents.get("NSCopying"), AtLoc))
234c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall          if (IDecl->ClassImplementsProtocol(PNSCopying, true))
235c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall            Diag(AtLoc, diag::warn_implements_nscopying) << PropertyId;
23628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    }
237c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall  if (T->isObjCObjectType())
23828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    Diag(FD.D.getIdentifierLoc(), diag::err_statically_allocated_object);
23928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
240e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  DeclContext *DC = cast<DeclContext>(CDecl);
24128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC,
24228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                                                     FD.D.getIdentifierLoc(),
24383a230c83a54190366138c1a4f4310ef838b88fcJohn McCall                                                     PropertyId, AtLoc, TInfo);
244e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek
2459f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek  if (ObjCPropertyDecl *prevDecl =
2469f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek        ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) {
24728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    Diag(PDecl->getLocation(), diag::err_duplicate_property);
248894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek    Diag(prevDecl->getLocation(), diag::note_property_declare);
24928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    PDecl->setInvalidDecl();
25028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  }
25123173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek  else {
25228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    DC->addDecl(PDecl);
25323173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek    if (lexicalDC)
25423173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek      PDecl->setLexicalDeclContext(lexicalDC);
25523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek  }
25628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
25728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if (T->isArrayType() || T->isFunctionType()) {
25828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    Diag(AtLoc, diag::err_property_type) << T;
25928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    PDecl->setInvalidDecl();
26028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  }
26128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
26228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  ProcessDeclAttributes(S, PDecl, FD.D);
26328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
26428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  // Regardless of setter/getter attribute, we save the default getter/setter
26528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  // selector names in anticipation of declaration of setter/getter methods.
26628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  PDecl->setGetterName(GetterSel);
26728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  PDecl->setSetterName(SetterSel);
26828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
26928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if (Attributes & ObjCDeclSpec::DQ_PR_readonly)
27028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly);
27128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
27228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if (Attributes & ObjCDeclSpec::DQ_PR_getter)
27328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter);
27428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
27528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if (Attributes & ObjCDeclSpec::DQ_PR_setter)
27628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter);
27728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
27828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if (isReadWrite)
27928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite);
28028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
28128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if (Attributes & ObjCDeclSpec::DQ_PR_retain)
28228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain);
28328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
28428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if (Attributes & ObjCDeclSpec::DQ_PR_copy)
28528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy);
28628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
28728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if (isAssign)
28828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign);
28928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
29028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic)
29128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic);
29228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
29380aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian  PDecl->setPropertyAttributesAsWritten(PDecl->getPropertyAttributes());
29480aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian
29528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if (MethodImplKind == tok::objc_required)
29628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    PDecl->setPropertyImplementation(ObjCPropertyDecl::Required);
29728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  else if (MethodImplKind == tok::objc_optional)
29828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional);
29928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
300e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek  return PDecl;
30128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek}
30228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
30328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
30428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// ActOnPropertyImplDecl - This routine performs semantic checks and
30528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// builds the AST node for a property implementation declaration; declared
30628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// as @synthesize or @dynamic.
30728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek///
308d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnPropertyImplDecl(Scope *S,
309d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall                                  SourceLocation AtLoc,
310d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall                                  SourceLocation PropertyLoc,
311d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall                                  bool Synthesize,
312d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall                                  Decl *ClassCatImpDecl,
313d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall                                  IdentifierInfo *PropertyId,
314d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall                                  IdentifierInfo *PropertyIvar) {
315e9686572f17968048a5e097254f85c202ea44aecTed Kremenek  ObjCContainerDecl *ClassImpDecl =
316d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall    cast_or_null<ObjCContainerDecl>(ClassCatImpDecl);
31728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  // Make sure we have a context for the property implementation declaration.
31828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if (!ClassImpDecl) {
31928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    Diag(AtLoc, diag::error_missing_property_context);
320d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall    return 0;
32128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  }
32228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  ObjCPropertyDecl *property = 0;
32328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  ObjCInterfaceDecl* IDecl = 0;
32428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  // Find the class or category class where this property must have
32528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  // a declaration.
32628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  ObjCImplementationDecl *IC = 0;
32728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  ObjCCategoryImplDecl* CatImplClass = 0;
32828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) {
32928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    IDecl = IC->getClassInterface();
33028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    // We always synthesize an interface for an implementation
33128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    // without an interface decl. So, IDecl is always non-zero.
33228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    assert(IDecl &&
33328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek           "ActOnPropertyImplDecl - @implementation without @interface");
33428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
33528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    // Look for this property declaration in the @implementation's @interface
33628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    property = IDecl->FindPropertyDeclaration(PropertyId);
33728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    if (!property) {
33828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      Diag(PropertyLoc, diag::error_bad_property_decl) << IDecl->getDeclName();
339d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall      return 0;
34028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    }
34128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    if (const ObjCCategoryDecl *CD =
34228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        dyn_cast<ObjCCategoryDecl>(property->getDeclContext())) {
34328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      if (!CD->IsClassExtension()) {
34428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        Diag(PropertyLoc, diag::error_category_property) << CD->getDeclName();
34528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        Diag(property->getLocation(), diag::note_property_declare);
346d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall        return 0;
34728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      }
34828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    }
34928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  } else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) {
35028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    if (Synthesize) {
35128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      Diag(AtLoc, diag::error_synthesize_category_decl);
352d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall      return 0;
35328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    }
35428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    IDecl = CatImplClass->getClassInterface();
35528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    if (!IDecl) {
35628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      Diag(AtLoc, diag::error_missing_property_interface);
357d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall      return 0;
35828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    }
35928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    ObjCCategoryDecl *Category =
36028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier());
36128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
36228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    // If category for this implementation not found, it is an error which
36328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    // has already been reported eralier.
36428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    if (!Category)
365d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall      return 0;
36628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    // Look for this property declaration in @implementation's category
36728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    property = Category->FindPropertyDeclaration(PropertyId);
36828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    if (!property) {
36928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      Diag(PropertyLoc, diag::error_bad_category_property_decl)
37028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      << Category->getDeclName();
371d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall      return 0;
37228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    }
37328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  } else {
37428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    Diag(AtLoc, diag::error_bad_property_context);
375d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall    return 0;
37628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  }
37728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  ObjCIvarDecl *Ivar = 0;
37828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  // Check that we have a valid, previously declared ivar for @synthesize
37928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if (Synthesize) {
38028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    // @synthesize
38128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    if (!PropertyIvar)
38228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      PropertyIvar = PropertyId;
38328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    QualType PropType = Context.getCanonicalType(property->getType());
38428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    // Check that this is a previously declared 'ivar' in 'IDecl' interface
38528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    ObjCInterfaceDecl *ClassDeclared;
38628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    Ivar = IDecl->lookupInstanceVariable(PropertyIvar, ClassDeclared);
38728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    if (!Ivar) {
38829fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar      Ivar = ObjCIvarDecl::Create(Context, ClassImpDecl, PropertyLoc,
38928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                                  PropertyIvar, PropType, /*Dinfo=*/0,
3902846b2b47029c877357438d16c73911c1510be6cFariborz Jahanian                                  ObjCIvarDecl::Protected,
391ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian                                  (Expr *)0, true);
39229fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar      ClassImpDecl->addDecl(Ivar);
39328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      IDecl->makeDeclVisibleInContext(Ivar, false);
39428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      property->setPropertyIvarDecl(Ivar);
39528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
39628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      if (!getLangOptions().ObjCNonFragileABI)
39728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        Diag(PropertyLoc, diag::error_missing_property_ivar_decl) << PropertyId;
39828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      // Note! I deliberately want it to fall thru so, we have a
39928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      // a property implementation and to avoid future warnings.
40028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    } else if (getLangOptions().ObjCNonFragileABI &&
40128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek               ClassDeclared != IDecl) {
40228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      Diag(PropertyLoc, diag::error_ivar_in_superclass_use)
40328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      << property->getDeclName() << Ivar->getDeclName()
40428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      << ClassDeclared->getDeclName();
40528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      Diag(Ivar->getLocation(), diag::note_previous_access_declaration)
4064087f27e5416c799bcb6be072f905be752acb61cDaniel Dunbar      << Ivar << Ivar->getName();
40728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      // Note! I deliberately want it to fall thru so more errors are caught.
40828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    }
40928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    QualType IvarType = Context.getCanonicalType(Ivar->getType());
41028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
41128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    // Check that type of property and its ivar are type compatible.
41228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    if (PropType != IvarType) {
41362ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian      bool compat = false;
41462ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian      if (isa<ObjCObjectPointerType>(PropType)
41562ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian            && isa<ObjCObjectPointerType>(IvarType))
41662ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian        compat =
41762ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian          Context.canAssignObjCInterfaces(
41862ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian                                  PropType->getAs<ObjCObjectPointerType>(),
41962ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian                                  IvarType->getAs<ObjCObjectPointerType>());
42062ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian      else
42162ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian        compat = (CheckAssignmentConstraints(PropType, IvarType) == Compatible);
42262ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian      if (!compat) {
42328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        Diag(PropertyLoc, diag::error_property_ivar_type)
424f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek          << property->getDeclName() << PropType
425f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek          << Ivar->getDeclName() << IvarType;
426f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek        Diag(Ivar->getLocation(), diag::note_ivar_decl);
42728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        // Note! I deliberately want it to fall thru so, we have a
42828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        // a property implementation and to avoid future warnings.
42928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      }
43028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
43128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      // FIXME! Rules for properties are somewhat different that those
43228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      // for assignments. Use a new routine to consolidate all cases;
43328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      // specifically for property redeclarations as well as for ivars.
43428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      QualType lhsType =Context.getCanonicalType(PropType).getUnqualifiedType();
43528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      QualType rhsType =Context.getCanonicalType(IvarType).getUnqualifiedType();
43628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      if (lhsType != rhsType &&
43728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek          lhsType->isArithmeticType()) {
43828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        Diag(PropertyLoc, diag::error_property_ivar_type)
439f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek          << property->getDeclName() << PropType
440f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek          << Ivar->getDeclName() << IvarType;
441f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek        Diag(Ivar->getLocation(), diag::note_ivar_decl);
44228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        // Fall thru - see previous comment
44328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      }
44428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      // __weak is explicit. So it works on Canonical type.
44528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      if (PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() &&
44628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek          getLangOptions().getGCMode() != LangOptions::NonGC) {
44728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        Diag(PropertyLoc, diag::error_weak_property)
44828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        << property->getDeclName() << Ivar->getDeclName();
44928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        // Fall thru - see previous comment
45028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      }
45128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      if ((property->getType()->isObjCObjectPointerType() ||
45228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek           PropType.isObjCGCStrong()) && IvarType.isObjCGCWeak() &&
45328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek          getLangOptions().getGCMode() != LangOptions::NonGC) {
45428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        Diag(PropertyLoc, diag::error_strong_property)
45528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        << property->getDeclName() << Ivar->getDeclName();
45628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        // Fall thru - see previous comment
45728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      }
45828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    }
45928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  } else if (PropertyIvar)
46028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    // @dynamic
46128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    Diag(PropertyLoc, diag::error_dynamic_property_ivar_decl);
46228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  assert (property && "ActOnPropertyImplDecl - property declaration missing");
46328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  ObjCPropertyImplDecl *PIDecl =
46428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  ObjCPropertyImplDecl::Create(Context, CurContext, AtLoc, PropertyLoc,
46528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                               property,
46628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                               (Synthesize ?
46728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                                ObjCPropertyImplDecl::Synthesize
46828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                                : ObjCPropertyImplDecl::Dynamic),
46928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                               Ivar);
47017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian  if (ObjCMethodDecl *getterMethod = property->getGetterMethodDecl()) {
47117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian    getterMethod->createImplicitParams(Context, IDecl);
4720313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian    if (getLangOptions().CPlusPlus && Synthesize &&
4730313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian        Ivar->getType()->isRecordType()) {
47417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian      // For Objective-C++, need to synthesize the AST for the IVAR object to be
47517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian      // returned by the getter as it must conform to C++'s copy-return rules.
47617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian      // FIXME. Eventually we want to do this for Objective-C as well.
47717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian      ImplicitParamDecl *SelfDecl = getterMethod->getSelfDecl();
47817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian      DeclRefExpr *SelfExpr =
47917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian        new (Context) DeclRefExpr(SelfDecl,SelfDecl->getType(),
48017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian                                  SourceLocation());
48117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian      Expr *IvarRefExpr =
48217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian        new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc,
48317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian                                      SelfExpr, true, true);
48460d7b3a319d84d688752be3870615ac0f111fb16John McCall      ExprResult Res =
48517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian        PerformCopyInitialization(InitializedEntity::InitializeResult(
4863c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor                                    SourceLocation(),
4873c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor                                    getterMethod->getResultType(),
4883c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor                                    /*NRVO=*/false),
48917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian                                  SourceLocation(),
49017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian                                  Owned(IvarRefExpr));
49117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian      if (!Res.isInvalid()) {
49217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian        Expr *ResExpr = Res.takeAs<Expr>();
49317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian        if (ResExpr)
49417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian          ResExpr = MaybeCreateCXXExprWithTemporaries(ResExpr);
49517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian        PIDecl->setGetterCXXConstructor(ResExpr);
49617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian      }
49717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian    }
49817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian  }
49917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian  if (ObjCMethodDecl *setterMethod = property->getSetterMethodDecl()) {
50017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian    setterMethod->createImplicitParams(Context, IDecl);
5010313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian    if (getLangOptions().CPlusPlus && Synthesize
5020313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian        && Ivar->getType()->isRecordType()) {
50317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian      // FIXME. Eventually we want to do this for Objective-C as well.
50417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian      ImplicitParamDecl *SelfDecl = setterMethod->getSelfDecl();
50517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian      DeclRefExpr *SelfExpr =
50617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian        new (Context) DeclRefExpr(SelfDecl,SelfDecl->getType(),
50717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian                                  SourceLocation());
50817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian      Expr *lhs =
50917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian        new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc,
51017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian                                      SelfExpr, true, true);
51117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian      ObjCMethodDecl::param_iterator P = setterMethod->param_begin();
51217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian      ParmVarDecl *Param = (*P);
51317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian      Expr *rhs = new (Context) DeclRefExpr(Param,Param->getType(),
51417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian                                            SourceLocation());
515fa432391a708448518df1e6ced4e34f4c349d169Fariborz Jahanian      ExprResult Res = BuildBinOp(S, lhs->getLocEnd(),
5162de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall                                  BO_Assign, lhs, rhs);
51717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian      PIDecl->setSetterCXXAssignment(Res.takeAs<Expr>());
51817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian    }
51917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian  }
52017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian
52128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if (IC) {
52228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    if (Synthesize)
52328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      if (ObjCPropertyImplDecl *PPIDecl =
52428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek          IC->FindPropertyImplIvarDecl(PropertyIvar)) {
52528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        Diag(PropertyLoc, diag::error_duplicate_ivar_use)
52628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier()
52728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        << PropertyIvar;
52828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        Diag(PPIDecl->getLocation(), diag::note_previous_use);
52928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      }
53028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
53128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    if (ObjCPropertyImplDecl *PPIDecl
53228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        = IC->FindPropertyImplDecl(PropertyId)) {
53328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      Diag(PropertyLoc, diag::error_property_implemented) << PropertyId;
53428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      Diag(PPIDecl->getLocation(), diag::note_previous_declaration);
535d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall      return 0;
53628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    }
53728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    IC->addPropertyImplementation(PIDecl);
538ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian    if (getLangOptions().ObjCNonFragileABI2) {
539ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian      // Diagnose if an ivar was lazily synthesdized due to a previous
540ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian      // use and if 1) property is @dynamic or 2) property is synthesized
541cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian      // but it requires an ivar of different name.
542ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian      ObjCInterfaceDecl *ClassDeclared;
543ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian      ObjCIvarDecl *Ivar = 0;
544ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian      if (!Synthesize)
545ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian        Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared);
546ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian      else {
547ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian        if (PropertyIvar && PropertyIvar != PropertyId)
548ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian          Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared);
549ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian      }
550cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian      // Issue diagnostics only if Ivar belongs to current class.
551cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian      if (Ivar && Ivar->getSynthesize() &&
552cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian          IC->getClassInterface() == ClassDeclared) {
553ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian        Diag(Ivar->getLocation(), diag::err_undeclared_var_use)
554ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian        << PropertyId;
555ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian        Ivar->setInvalidDecl();
556ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian      }
557ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian    }
55828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  } else {
55928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    if (Synthesize)
56028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      if (ObjCPropertyImplDecl *PPIDecl =
56128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek          CatImplClass->FindPropertyImplIvarDecl(PropertyIvar)) {
56228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        Diag(PropertyLoc, diag::error_duplicate_ivar_use)
56328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier()
56428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        << PropertyIvar;
56528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        Diag(PPIDecl->getLocation(), diag::note_previous_use);
56628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      }
56728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
56828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    if (ObjCPropertyImplDecl *PPIDecl =
56928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        CatImplClass->FindPropertyImplDecl(PropertyId)) {
57028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      Diag(PropertyLoc, diag::error_property_implemented) << PropertyId;
57128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      Diag(PPIDecl->getLocation(), diag::note_previous_declaration);
572d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall      return 0;
57328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    }
57428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    CatImplClass->addPropertyImplementation(PIDecl);
57528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  }
57628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
577d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall  return PIDecl;
57828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek}
57928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
58028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===//
58128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Helper methods.
58228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===//
58328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek
5849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// DiagnosePropertyMismatch - Compares two properties for their
5859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// attributes and types and warns on a variety of inconsistencies.
5869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek///
5879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid
5889d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property,
5899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                               ObjCPropertyDecl *SuperProperty,
5909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                               const IdentifierInfo *inheritedName) {
5919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  ObjCPropertyDecl::PropertyAttributeKind CAttr =
5929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  Property->getPropertyAttributes();
5939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  ObjCPropertyDecl::PropertyAttributeKind SAttr =
5949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  SuperProperty->getPropertyAttributes();
5959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly)
5969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite))
5979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    Diag(Property->getLocation(), diag::warn_readonly_property)
5989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      << Property->getDeclName() << inheritedName;
5999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy)
6009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      != (SAttr & ObjCPropertyDecl::OBJC_PR_copy))
6019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    Diag(Property->getLocation(), diag::warn_property_attribute)
6029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      << Property->getDeclName() << "copy" << inheritedName;
6039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  else if ((CAttr & ObjCPropertyDecl::OBJC_PR_retain)
6049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek           != (SAttr & ObjCPropertyDecl::OBJC_PR_retain))
6059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    Diag(Property->getLocation(), diag::warn_property_attribute)
6069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      << Property->getDeclName() << "retain" << inheritedName;
6079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
6089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)
6099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic))
6109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    Diag(Property->getLocation(), diag::warn_property_attribute)
6119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      << Property->getDeclName() << "atomic" << inheritedName;
6129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (Property->getSetterName() != SuperProperty->getSetterName())
6139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    Diag(Property->getLocation(), diag::warn_property_attribute)
6149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      << Property->getDeclName() << "setter" << inheritedName;
6159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (Property->getGetterName() != SuperProperty->getGetterName())
6169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    Diag(Property->getLocation(), diag::warn_property_attribute)
6179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      << Property->getDeclName() << "getter" << inheritedName;
6189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
6199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  QualType LHSType =
6209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    Context.getCanonicalType(SuperProperty->getType());
6219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  QualType RHSType =
6229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    Context.getCanonicalType(Property->getType());
6239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
6249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (!Context.typesAreCompatible(LHSType, RHSType)) {
6259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // FIXME: Incorporate this test with typesAreCompatible.
6269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    if (LHSType->isObjCQualifiedIdType() && RHSType->isObjCQualifiedIdType())
6279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      if (Context.ObjCQualifiedIdTypesAreCompatible(LHSType, RHSType, false))
6289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        return;
6299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    Diag(Property->getLocation(), diag::warn_property_types_are_incompatible)
6309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      << Property->getType() << SuperProperty->getType() << inheritedName;
6319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  }
6329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek}
6339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
6349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::DiagnosePropertyAccessorMismatch(ObjCPropertyDecl *property,
6359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                                            ObjCMethodDecl *GetterMethod,
6369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                                            SourceLocation Loc) {
6379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (GetterMethod &&
6389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      GetterMethod->getResultType() != property->getType()) {
6399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    AssignConvertType result = Incompatible;
6409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    if (property->getType()->isObjCObjectPointerType())
6419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      result = CheckAssignmentConstraints(GetterMethod->getResultType(),
6429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                                          property->getType());
6439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    if (result != Compatible) {
6449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      Diag(Loc, diag::warn_accessor_property_type_mismatch)
6459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      << property->getDeclName()
6469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      << GetterMethod->getSelector();
6479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      Diag(GetterMethod->getLocation(), diag::note_declared_at);
6489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      return true;
6499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    }
6509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  }
6519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  return false;
6529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek}
6539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
6549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ComparePropertiesInBaseAndSuper - This routine compares property
6559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declarations in base and its super class, if any, and issues
6569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// diagnostics in a variety of inconsistant situations.
6579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek///
6589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ComparePropertiesInBaseAndSuper(ObjCInterfaceDecl *IDecl) {
6599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  ObjCInterfaceDecl *SDecl = IDecl->getSuperClass();
6609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (!SDecl)
6619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    return;
6629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // FIXME: O(N^2)
6639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  for (ObjCInterfaceDecl::prop_iterator S = SDecl->prop_begin(),
6649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek       E = SDecl->prop_end(); S != E; ++S) {
6659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    ObjCPropertyDecl *SuperPDecl = (*S);
6669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // Does property in super class has declaration in current class?
6679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    for (ObjCInterfaceDecl::prop_iterator I = IDecl->prop_begin(),
6689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek         E = IDecl->prop_end(); I != E; ++I) {
6699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      ObjCPropertyDecl *PDecl = (*I);
6709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      if (SuperPDecl->getIdentifier() == PDecl->getIdentifier())
6719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek          DiagnosePropertyMismatch(PDecl, SuperPDecl,
6729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                                   SDecl->getIdentifier());
6739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    }
6749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  }
6759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek}
6769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
6779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// MatchOneProtocolPropertiesInClass - This routine goes thru the list
6789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// of properties declared in a protocol and compares their attribute against
6799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the same property declared in the class or category.
6809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid
6819d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::MatchOneProtocolPropertiesInClass(Decl *CDecl,
6829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                                          ObjCProtocolDecl *PDecl) {
6839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl);
6849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (!IDecl) {
6859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // Category
6869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl);
6879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    assert (CatDecl && "MatchOneProtocolPropertiesInClass");
6889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    if (!CatDecl->IsClassExtension())
6899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(),
6909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek           E = PDecl->prop_end(); P != E; ++P) {
6919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        ObjCPropertyDecl *Pr = (*P);
6929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        ObjCCategoryDecl::prop_iterator CP, CE;
6939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        // Is this property already in  category's list of properties?
6942d2f9368d35b3628c7e3b4563f74849a0f901a00Ted Kremenek        for (CP = CatDecl->prop_begin(), CE = CatDecl->prop_end(); CP!=CE; ++CP)
6959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek          if ((*CP)->getIdentifier() == Pr->getIdentifier())
6969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek            break;
6979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        if (CP != CE)
6989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek          // Property protocol already exist in class. Diagnose any mismatch.
6999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek          DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier());
7009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      }
7019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    return;
7029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  }
7039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(),
7049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek       E = PDecl->prop_end(); P != E; ++P) {
7059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    ObjCPropertyDecl *Pr = (*P);
7069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    ObjCInterfaceDecl::prop_iterator CP, CE;
7079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // Is this property already in  class's list of properties?
7089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    for (CP = IDecl->prop_begin(), CE = IDecl->prop_end(); CP != CE; ++CP)
7099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      if ((*CP)->getIdentifier() == Pr->getIdentifier())
7109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        break;
7119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    if (CP != CE)
7129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      // Property protocol already exist in class. Diagnose any mismatch.
7139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier());
7149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    }
7159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek}
7169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
7179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CompareProperties - This routine compares properties
7189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declared in 'ClassOrProtocol' objects (which can be a class or an
7199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// inherited protocol with the list of properties for class/category 'CDecl'
7209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek///
721d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CompareProperties(Decl *CDecl, Decl *ClassOrProtocol) {
722d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall  Decl *ClassDecl = ClassOrProtocol;
7239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl);
7249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
7259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (!IDecl) {
7269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // Category
7279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl);
7289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    assert (CatDecl && "CompareProperties");
7299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    if (ObjCCategoryDecl *MDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) {
7309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      for (ObjCCategoryDecl::protocol_iterator P = MDecl->protocol_begin(),
7319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek           E = MDecl->protocol_end(); P != E; ++P)
7329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      // Match properties of category with those of protocol (*P)
7339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      MatchOneProtocolPropertiesInClass(CatDecl, *P);
7349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
7359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      // Go thru the list of protocols for this category and recursively match
7369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      // their properties with those in the category.
7379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      for (ObjCCategoryDecl::protocol_iterator P = CatDecl->protocol_begin(),
7389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek           E = CatDecl->protocol_end(); P != E; ++P)
739d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall        CompareProperties(CatDecl, *P);
7409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    } else {
7419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl);
7429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(),
7439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek           E = MD->protocol_end(); P != E; ++P)
7449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        MatchOneProtocolPropertiesInClass(CatDecl, *P);
7459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    }
7469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    return;
7479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  }
7489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
7499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (ObjCInterfaceDecl *MDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) {
75053b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek    for (ObjCInterfaceDecl::all_protocol_iterator
75153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek          P = MDecl->all_referenced_protocol_begin(),
75253b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek          E = MDecl->all_referenced_protocol_end(); P != E; ++P)
7539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      // Match properties of class IDecl with those of protocol (*P).
7549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      MatchOneProtocolPropertiesInClass(IDecl, *P);
7559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
7569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // Go thru the list of protocols for this class and recursively match
7579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // their properties with those declared in the class.
75853b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek    for (ObjCInterfaceDecl::all_protocol_iterator
75953b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek          P = IDecl->all_referenced_protocol_begin(),
76053b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek          E = IDecl->all_referenced_protocol_end(); P != E; ++P)
761d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall      CompareProperties(IDecl, *P);
7629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  } else {
7639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl);
7649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(),
7659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek         E = MD->protocol_end(); P != E; ++P)
7669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      MatchOneProtocolPropertiesInClass(IDecl, *P);
7679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  }
7689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek}
7699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
7709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// isPropertyReadonly - Return true if property is readonly, by searching
7719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// for the property in the class and in its categories and implementations
7729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek///
7739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::isPropertyReadonly(ObjCPropertyDecl *PDecl,
7749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                              ObjCInterfaceDecl *IDecl) {
7759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // by far the most common case.
7769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (!PDecl->isReadOnly())
7779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    return false;
7789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // Even if property is ready only, if interface has a user defined setter,
7799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // it is not considered read only.
7809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (IDecl->getInstanceMethod(PDecl->getSetterName()))
7819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    return false;
7829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
7839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // Main class has the property as 'readonly'. Must search
7849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // through the category list to see if the property's
7859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // attribute has been over-ridden to 'readwrite'.
7869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  for (ObjCCategoryDecl *Category = IDecl->getCategoryList();
7879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek       Category; Category = Category->getNextClassCategory()) {
7889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // Even if property is ready only, if a category has a user defined setter,
7899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // it is not considered read only.
7909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    if (Category->getInstanceMethod(PDecl->getSetterName()))
7919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      return false;
7929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    ObjCPropertyDecl *P =
7939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      Category->FindPropertyDeclaration(PDecl->getIdentifier());
7949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    if (P && !P->isReadOnly())
7959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      return false;
7969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  }
7979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
7989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // Also, check for definition of a setter method in the implementation if
7999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // all else failed.
8009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(CurContext)) {
8019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    if (ObjCImplementationDecl *IMD =
8029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        dyn_cast<ObjCImplementationDecl>(OMD->getDeclContext())) {
8039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      if (IMD->getInstanceMethod(PDecl->getSetterName()))
8049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        return false;
8059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    } else if (ObjCCategoryImplDecl *CIMD =
8069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek               dyn_cast<ObjCCategoryImplDecl>(OMD->getDeclContext())) {
8079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      if (CIMD->getInstanceMethod(PDecl->getSetterName()))
8089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        return false;
8099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    }
8109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  }
8119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // Lastly, look through the implementation (if one is in scope).
8129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (ObjCImplementationDecl *ImpDecl = IDecl->getImplementation())
8139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    if (ImpDecl->getInstanceMethod(PDecl->getSetterName()))
8149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      return false;
8159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // If all fails, look at the super class.
8169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (ObjCInterfaceDecl *SIDecl = IDecl->getSuperClass())
8179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    return isPropertyReadonly(PDecl, SIDecl);
8189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  return true;
8199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek}
8209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
8219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CollectImmediateProperties - This routine collects all properties in
8229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the class and its conforming protocols; but not those it its super class.
8239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::CollectImmediateProperties(ObjCContainerDecl *CDecl,
824cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian            llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap,
825cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian            llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& SuperPropMap) {
8269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) {
8279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(),
8289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek         E = IDecl->prop_end(); P != E; ++P) {
8299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      ObjCPropertyDecl *Prop = (*P);
8309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      PropMap[Prop->getIdentifier()] = Prop;
8319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    }
8329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // scan through class's protocols.
83353b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek    for (ObjCInterfaceDecl::all_protocol_iterator
83453b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek         PI = IDecl->all_referenced_protocol_begin(),
83553b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek         E = IDecl->all_referenced_protocol_end(); PI != E; ++PI)
836cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian        CollectImmediateProperties((*PI), PropMap, SuperPropMap);
8379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  }
8389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (ObjCCategoryDecl *CATDecl = dyn_cast<ObjCCategoryDecl>(CDecl)) {
8399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    if (!CATDecl->IsClassExtension())
8409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      for (ObjCContainerDecl::prop_iterator P = CATDecl->prop_begin(),
8419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek           E = CATDecl->prop_end(); P != E; ++P) {
8429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        ObjCPropertyDecl *Prop = (*P);
8439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        PropMap[Prop->getIdentifier()] = Prop;
8449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      }
8459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // scan through class's protocols.
84653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek    for (ObjCCategoryDecl::protocol_iterator PI = CATDecl->protocol_begin(),
8479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek         E = CATDecl->protocol_end(); PI != E; ++PI)
848cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian      CollectImmediateProperties((*PI), PropMap, SuperPropMap);
8499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  }
8509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) {
8519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(),
8529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek         E = PDecl->prop_end(); P != E; ++P) {
8539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      ObjCPropertyDecl *Prop = (*P);
854cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian      ObjCPropertyDecl *PropertyFromSuper = SuperPropMap[Prop->getIdentifier()];
855cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian      // Exclude property for protocols which conform to class's super-class,
856cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian      // as super-class has to implement the property.
857cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian      if (!PropertyFromSuper || PropertyFromSuper != Prop) {
858cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian        ObjCPropertyDecl *&PropEntry = PropMap[Prop->getIdentifier()];
859cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian        if (!PropEntry)
860cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian          PropEntry = Prop;
861cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian      }
8629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    }
8639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // scan through protocol's protocols.
8649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(),
8659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek         E = PDecl->protocol_end(); PI != E; ++PI)
866cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian      CollectImmediateProperties((*PI), PropMap, SuperPropMap);
8679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  }
8689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek}
8699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
870509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectClassPropertyImplementations - This routine collects list of
871509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in the class. This includes, class's
872509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// and its conforming protocols' properties.
873509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectClassPropertyImplementations(ObjCContainerDecl *CDecl,
874509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian                llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) {
875509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian  if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) {
876509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian    for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(),
877509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian         E = IDecl->prop_end(); P != E; ++P) {
878509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian      ObjCPropertyDecl *Prop = (*P);
879509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian      PropMap[Prop->getIdentifier()] = Prop;
880509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian    }
88153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek    for (ObjCInterfaceDecl::all_protocol_iterator
88253b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek         PI = IDecl->all_referenced_protocol_begin(),
88353b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek         E = IDecl->all_referenced_protocol_end(); PI != E; ++PI)
884509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian      CollectClassPropertyImplementations((*PI), PropMap);
885509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian  }
886509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian  else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) {
887509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian    for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(),
888509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian         E = PDecl->prop_end(); P != E; ++P) {
889509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian      ObjCPropertyDecl *Prop = (*P);
890509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian      PropMap[Prop->getIdentifier()] = Prop;
891509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian    }
892509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian    // scan through protocol's protocols.
893509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian    for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(),
894509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian         E = PDecl->protocol_end(); PI != E; ++PI)
895509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian      CollectClassPropertyImplementations((*PI), PropMap);
896509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian  }
897509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian}
898509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian
899509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectSuperClassPropertyImplementations - This routine collects list of
900509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in super class(s) and also coming from their
901509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// conforming protocols.
902509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectSuperClassPropertyImplementations(ObjCInterfaceDecl *CDecl,
903509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian                llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) {
904509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian  if (ObjCInterfaceDecl *SDecl = CDecl->getSuperClass()) {
905509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian    while (SDecl) {
906509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian      CollectClassPropertyImplementations(SDecl, PropMap);
907509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian      SDecl = SDecl->getSuperClass();
908509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian    }
909509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian  }
910509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian}
911509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian
9129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// LookupPropertyDecl - Looks up a property in the current class and all
9139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// its protocols.
9149d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekObjCPropertyDecl *Sema::LookupPropertyDecl(const ObjCContainerDecl *CDecl,
9159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                                     IdentifierInfo *II) {
9169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (const ObjCInterfaceDecl *IDecl =
9179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        dyn_cast<ObjCInterfaceDecl>(CDecl)) {
9189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(),
9199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek         E = IDecl->prop_end(); P != E; ++P) {
9209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      ObjCPropertyDecl *Prop = (*P);
9219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      if (Prop->getIdentifier() == II)
9229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        return Prop;
9239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    }
9249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // scan through class's protocols.
92553b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek    for (ObjCInterfaceDecl::all_protocol_iterator
92653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek         PI = IDecl->all_referenced_protocol_begin(),
92753b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek         E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) {
9289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II);
9299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      if (Prop)
9309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        return Prop;
9319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    }
9329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  }
9339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  else if (const ObjCProtocolDecl *PDecl =
9349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek            dyn_cast<ObjCProtocolDecl>(CDecl)) {
9359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(),
9369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek         E = PDecl->prop_end(); P != E; ++P) {
9379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      ObjCPropertyDecl *Prop = (*P);
9389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      if (Prop->getIdentifier() == II)
9399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        return Prop;
9409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    }
9419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // scan through protocol's protocols.
9429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(),
9439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek         E = PDecl->protocol_end(); PI != E; ++PI) {
9449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II);
9459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      if (Prop)
9469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        return Prop;
9479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    }
9489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  }
9499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  return 0;
9509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek}
9519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
952509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// DefaultSynthesizeProperties - This routine default synthesizes all
953509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties which must be synthesized in class's @implementation.
954509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianvoid Sema::DefaultSynthesizeProperties (Scope *S, ObjCImplDecl* IMPDecl,
955509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian                                        ObjCInterfaceDecl *IDecl) {
956509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian
957509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian  llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap;
958509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian  CollectClassPropertyImplementations(IDecl, PropMap);
959509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian  if (PropMap.empty())
960509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian    return;
961509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian  llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap;
962509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian  CollectSuperClassPropertyImplementations(IDecl, SuperPropMap);
963509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian
964509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian  for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator
965509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian       P = PropMap.begin(), E = PropMap.end(); P != E; ++P) {
966509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian    ObjCPropertyDecl *Prop = P->second;
967509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian    // If property to be implemented in the super class, ignore.
968509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian    if (SuperPropMap[Prop->getIdentifier()])
969509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian      continue;
970509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian    // Is there a matching propery synthesize/dynamic?
971509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian    if (Prop->isInvalidDecl() ||
972509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian        Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional ||
973509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian        IMPDecl->FindPropertyImplIvarDecl(Prop->getIdentifier()))
974509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian      continue;
975d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian    // Property may have been synthesized by user.
976d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian    if (IMPDecl->FindPropertyImplDecl(Prop->getIdentifier()))
977d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian      continue;
97895f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian    if (IMPDecl->getInstanceMethod(Prop->getGetterName())) {
97995f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian      if (Prop->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_readonly)
98095f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian        continue;
98195f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian      if (IMPDecl->getInstanceMethod(Prop->getSetterName()))
98295f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian        continue;
98395f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian    }
984d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian
9852a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek
9862a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek    // We use invalid SourceLocations for the synthesized ivars since they
9872a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek    // aren't really synthesized at a particular location; they just exist.
9882a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek    // Saying that they are located at the @implementation isn't really going
9892a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek    // to help users.
9902a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek    ActOnPropertyImplDecl(S, SourceLocation(), SourceLocation(),
9912a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek                          true,IMPDecl,
992509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian                          Prop->getIdentifier(), Prop->getIdentifier());
9932a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek  }
994509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian}
9959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
99617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanianvoid Sema::DiagnoseUnimplementedProperties(Scope *S, ObjCImplDecl* IMPDecl,
9979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                                      ObjCContainerDecl *CDecl,
9989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                                      const llvm::DenseSet<Selector>& InsMap) {
999cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian  llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap;
1000cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian  if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl))
1001cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian    CollectSuperClassPropertyImplementations(IDecl, SuperPropMap);
1002cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian
10039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap;
1004cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian  CollectImmediateProperties(CDecl, PropMap, SuperPropMap);
10059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (PropMap.empty())
10069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    return;
10079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
10089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  llvm::DenseSet<ObjCPropertyDecl *> PropImplMap;
10099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  for (ObjCImplDecl::propimpl_iterator
10109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek       I = IMPDecl->propimpl_begin(),
10119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek       EI = IMPDecl->propimpl_end(); I != EI; ++I)
10129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    PropImplMap.insert((*I)->getPropertyDecl());
10139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
10149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator
10159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek       P = PropMap.begin(), E = PropMap.end(); P != E; ++P) {
10169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    ObjCPropertyDecl *Prop = P->second;
10179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // Is there a matching propery synthesize/dynamic?
10189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    if (Prop->isInvalidDecl() ||
10199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional ||
10209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        PropImplMap.count(Prop))
10219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      continue;
10229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    if (!InsMap.count(Prop->getGetterName())) {
10239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      Diag(Prop->getLocation(),
10249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek           isa<ObjCCategoryDecl>(CDecl) ?
10259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek            diag::warn_setter_getter_impl_required_in_category :
10269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek            diag::warn_setter_getter_impl_required)
10279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      << Prop->getDeclName() << Prop->getGetterName();
10289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      Diag(IMPDecl->getLocation(),
10299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek           diag::note_property_impl_required);
10309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    }
10319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
10329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    if (!Prop->isReadOnly() && !InsMap.count(Prop->getSetterName())) {
10339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      Diag(Prop->getLocation(),
10349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek           isa<ObjCCategoryDecl>(CDecl) ?
10359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek           diag::warn_setter_getter_impl_required_in_category :
10369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek           diag::warn_setter_getter_impl_required)
10379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      << Prop->getDeclName() << Prop->getSetterName();
10389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      Diag(IMPDecl->getLocation(),
10399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek           diag::note_property_impl_required);
10409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    }
10419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  }
10429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek}
10439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
10449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid
10459d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::AtomicPropertySetterGetterRules (ObjCImplDecl* IMPDecl,
10469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                                       ObjCContainerDecl* IDecl) {
10479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // Rules apply in non-GC mode only
10489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (getLangOptions().getGCMode() != LangOptions::NonGC)
10499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    return;
10509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  for (ObjCContainerDecl::prop_iterator I = IDecl->prop_begin(),
10519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek       E = IDecl->prop_end();
10529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek       I != E; ++I) {
10539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    ObjCPropertyDecl *Property = (*I);
10549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    unsigned Attributes = Property->getPropertyAttributes();
10559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // We only care about readwrite atomic property.
10569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    if ((Attributes & ObjCPropertyDecl::OBJC_PR_nonatomic) ||
10579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        !(Attributes & ObjCPropertyDecl::OBJC_PR_readwrite))
10589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      continue;
10599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    if (const ObjCPropertyImplDecl *PIDecl
10609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek         = IMPDecl->FindPropertyImplDecl(Property->getIdentifier())) {
10619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic)
10629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        continue;
10639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      ObjCMethodDecl *GetterMethod =
10649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        IMPDecl->getInstanceMethod(Property->getGetterName());
10659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      ObjCMethodDecl *SetterMethod =
10669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        IMPDecl->getInstanceMethod(Property->getSetterName());
10679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      if ((GetterMethod && !SetterMethod) || (!GetterMethod && SetterMethod)) {
10689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        SourceLocation MethodLoc =
10699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek          (GetterMethod ? GetterMethod->getLocation()
10709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                        : SetterMethod->getLocation());
10719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        Diag(MethodLoc, diag::warn_atomic_property_rule)
10729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek          << Property->getIdentifier();
10739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        Diag(Property->getLocation(), diag::note_property_declare);
10749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      }
10759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    }
10769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  }
10779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek}
10789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
10799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ProcessPropertyDecl - Make sure that any user-defined setter/getter methods
10809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// have the property type and issue diagnostics if they don't.
10819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// Also synthesize a getter/setter method if none exist (and update the
10829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// appropriate lookup tables. FIXME: Should reconsider if adding synthesized
10839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// methods is the "right" thing to do.
10849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ProcessPropertyDecl(ObjCPropertyDecl *property,
10858254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek                               ObjCContainerDecl *CD,
10868254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek                               ObjCPropertyDecl *redeclaredProperty,
10878254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek                               ObjCContainerDecl *lexicalDC) {
10888254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek
10899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  ObjCMethodDecl *GetterMethod, *SetterMethod;
10909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
10919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  GetterMethod = CD->getInstanceMethod(property->getGetterName());
10929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  SetterMethod = CD->getInstanceMethod(property->getSetterName());
10939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  DiagnosePropertyAccessorMismatch(property, GetterMethod,
10949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                                   property->getLocation());
10959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
10969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (SetterMethod) {
10979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    ObjCPropertyDecl::PropertyAttributeKind CAttr =
10989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      property->getPropertyAttributes();
10999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    if ((!(CAttr & ObjCPropertyDecl::OBJC_PR_readonly)) &&
11009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        Context.getCanonicalType(SetterMethod->getResultType()) !=
11019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek          Context.VoidTy)
11029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      Diag(SetterMethod->getLocation(), diag::err_setter_type_void);
11039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    if (SetterMethod->param_size() != 1 ||
11049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        ((*SetterMethod->param_begin())->getType() != property->getType())) {
11059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      Diag(property->getLocation(),
11069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek           diag::warn_accessor_property_type_mismatch)
11079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        << property->getDeclName()
11089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek        << SetterMethod->getSelector();
11099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      Diag(SetterMethod->getLocation(), diag::note_declared_at);
11109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    }
11119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  }
11129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
11139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // Synthesize getter/setter methods if none exist.
11149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // Find the default getter and if one not found, add one.
11159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // FIXME: The synthesized property we set here is misleading. We almost always
11169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // synthesize these methods unless the user explicitly provided prototypes
11179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // (which is odd, but allowed). Sema should be typechecking that the
11189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // declarations jive in that situation (which it is not currently).
11199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (!GetterMethod) {
11209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // No instance method of same name as property getter name was found.
11219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // Declare a getter method and add it to the list of methods
11229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // for this class.
1123a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek    SourceLocation Loc = redeclaredProperty ?
1124a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek      redeclaredProperty->getLocation() :
1125a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek      property->getLocation();
1126a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek
1127a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek    GetterMethod = ObjCMethodDecl::Create(Context, Loc, Loc,
1128a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek                             property->getGetterName(),
11293fe104154dd2e8ffb351142d74f308938b5c99bfFariborz Jahanian                             property->getType(), 0, CD, true, false, true,
11303fe104154dd2e8ffb351142d74f308938b5c99bfFariborz Jahanian                             false,
11319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                             (property->getPropertyImplementation() ==
11329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                              ObjCPropertyDecl::Optional) ?
11339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                             ObjCMethodDecl::Optional :
11349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                             ObjCMethodDecl::Required);
11359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    CD->addDecl(GetterMethod);
113623173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek    // FIXME: Eventually this shouldn't be needed, as the lexical context
113723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek    // and the real context should be the same.
1138a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek    if (lexicalDC)
113923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek      GetterMethod->setLexicalDeclContext(lexicalDC);
11409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  } else
11419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // A user declared getter will be synthesize when @synthesize of
11429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // the property with the same name is seen in the @implementation
11439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    GetterMethod->setSynthesized(true);
11449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  property->setGetterMethodDecl(GetterMethod);
11459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
11469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // Skip setter if property is read-only.
11479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (!property->isReadOnly()) {
11489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    // Find the default setter and if one not found, add one.
11499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    if (!SetterMethod) {
11509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      // No instance method of same name as property setter name was found.
11519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      // Declare a setter method and add it to the list of methods
11529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      // for this class.
11538254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek      SourceLocation Loc = redeclaredProperty ?
11548254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek        redeclaredProperty->getLocation() :
11558254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek        property->getLocation();
11568254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek
11578254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek      SetterMethod =
11588254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek        ObjCMethodDecl::Create(Context, Loc, Loc,
11598254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek                               property->getSetterName(), Context.VoidTy, 0,
11608254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek                               CD, true, false, true, false,
11619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                               (property->getPropertyImplementation() ==
11629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                                ObjCPropertyDecl::Optional) ?
11638254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek                                ObjCMethodDecl::Optional :
11648254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek                                ObjCMethodDecl::Required);
11658254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek
11669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      // Invent the arguments for the setter. We don't bother making a
11679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      // nice name for the argument.
11688254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek      ParmVarDecl *Argument = ParmVarDecl::Create(Context, SetterMethod, Loc,
11699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                                                  property->getIdentifier(),
11709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                                                  property->getType(),
11719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                                                  /*TInfo=*/0,
1172d931b086984257de68868a64a235c2b4b34003fbJohn McCall                                                  SC_None,
1173d931b086984257de68868a64a235c2b4b34003fbJohn McCall                                                  SC_None,
11749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                                                  0);
11754ecb25fa94897b2c03510292acace710e5262ba5Fariborz Jahanian      SetterMethod->setMethodParams(Context, &Argument, 1, 1);
11769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      CD->addDecl(SetterMethod);
117723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek      // FIXME: Eventually this shouldn't be needed, as the lexical context
117823173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek      // and the real context should be the same.
11798254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek      if (lexicalDC)
118023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek        SetterMethod->setLexicalDeclContext(lexicalDC);
11819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    } else
11829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      // A user declared setter will be synthesize when @synthesize of
11839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      // the property with the same name is seen in the @implementation
11849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek      SetterMethod->setSynthesized(true);
11859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    property->setSetterMethodDecl(SetterMethod);
11869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  }
11879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // Add any synthesized methods to the global pool. This allows us to
11889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // handle the following, which is supported by GCC (and part of the design).
11899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  //
11909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // @interface Foo
11919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // @property double bar;
11929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // @end
11939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  //
11949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // void thisIsUnfortunate() {
11959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  //   id foo;
11969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  //   double bar = [foo bar];
11979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // }
11989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  //
11999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (GetterMethod)
12009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    AddInstanceMethodToGlobalPool(GetterMethod);
12019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if (SetterMethod)
12029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek    AddInstanceMethodToGlobalPool(SetterMethod);
12039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek}
12049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
1205d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CheckObjCPropertyAttributes(Decl *PDecl,
12069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                                       SourceLocation Loc,
12079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek                                       unsigned &Attributes) {
12089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // FIXME: Improve the reported location.
12095fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek  if (!PDecl)
12105fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek    return;
12115fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek
12125fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek  ObjCPropertyDecl *PropertyDecl = cast<ObjCPropertyDecl>(PDecl);
1213842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian  QualType PropertyTy = PropertyDecl->getType();
12149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
12159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  // readonly and readwrite/assign/retain/copy conflict.
12169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek  if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) &&
121728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      (Attributes & (ObjCDeclSpec::DQ_PR_readwrite |
121828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                     ObjCDeclSpec::DQ_PR_assign |
121928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                     ObjCDeclSpec::DQ_PR_copy |
122028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                     ObjCDeclSpec::DQ_PR_retain))) {
122128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    const char * which = (Attributes & ObjCDeclSpec::DQ_PR_readwrite) ?
122228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                          "readwrite" :
122328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                         (Attributes & ObjCDeclSpec::DQ_PR_assign) ?
122428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                          "assign" :
122528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                         (Attributes & ObjCDeclSpec::DQ_PR_copy) ?
122628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                          "copy" : "retain";
12279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
122828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    Diag(Loc, (Attributes & (ObjCDeclSpec::DQ_PR_readwrite)) ?
122928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                 diag::err_objc_property_attr_mutually_exclusive :
123028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                 diag::warn_objc_property_attr_mutually_exclusive)
123128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      << "readonly" << which;
123228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  }
12339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
123428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  // Check for copy or retain on non-object types.
123528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if ((Attributes & (ObjCDeclSpec::DQ_PR_copy | ObjCDeclSpec::DQ_PR_retain)) &&
123628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      !PropertyTy->isObjCObjectPointerType() &&
123728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      !PropertyTy->isBlockPointerType() &&
1238842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian      !Context.isObjCNSObjectType(PropertyTy) &&
1239842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian      !PropertyDecl->getAttr<ObjCNSObjectAttr>()) {
124028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    Diag(Loc, diag::err_objc_property_requires_object)
124128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      << (Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain");
124228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    Attributes &= ~(ObjCDeclSpec::DQ_PR_copy | ObjCDeclSpec::DQ_PR_retain);
124328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  }
12449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
124528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  // Check for more than one of { assign, copy, retain }.
124628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if (Attributes & ObjCDeclSpec::DQ_PR_assign) {
124728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    if (Attributes & ObjCDeclSpec::DQ_PR_copy) {
124828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      Diag(Loc, diag::err_objc_property_attr_mutually_exclusive)
124928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        << "assign" << "copy";
125028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      Attributes &= ~ObjCDeclSpec::DQ_PR_copy;
125128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    }
125228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    if (Attributes & ObjCDeclSpec::DQ_PR_retain) {
125328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      Diag(Loc, diag::err_objc_property_attr_mutually_exclusive)
125428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        << "assign" << "retain";
125528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      Attributes &= ~ObjCDeclSpec::DQ_PR_retain;
125628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    }
125728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) {
125828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    if (Attributes & ObjCDeclSpec::DQ_PR_retain) {
125928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      Diag(Loc, diag::err_objc_property_attr_mutually_exclusive)
126028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek        << "copy" << "retain";
126128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      Attributes &= ~ObjCDeclSpec::DQ_PR_retain;
126228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    }
126328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  }
12649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
126528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  // Warn if user supplied no assignment attribute, property is
126628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  // readwrite, and this is an object type.
126728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy |
126828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek                      ObjCDeclSpec::DQ_PR_retain)) &&
126928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      !(Attributes & ObjCDeclSpec::DQ_PR_readonly) &&
127028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      PropertyTy->isObjCObjectPointerType()) {
127128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    // Skip this warning in gc-only mode.
127228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    if (getLangOptions().getGCMode() != LangOptions::GCOnly)
127328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      Diag(Loc, diag::warn_objc_property_no_assignment_attribute);
12749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
127528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    // If non-gc code warn that this is likely inappropriate.
127628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    if (getLangOptions().getGCMode() == LangOptions::NonGC)
127728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      Diag(Loc, diag::warn_objc_property_default_assign_on_object);
12789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
127928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    // FIXME: Implement warning dependent on NSCopying being
128028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    // implemented. See also:
128128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496>
128228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    // (please trim this list while you are at it).
128328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  }
12849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek
128528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek  if (!(Attributes & ObjCDeclSpec::DQ_PR_copy)
128628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      && getLangOptions().getGCMode() == LangOptions::GCOnly
128728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek      && PropertyTy->isBlockPointerType())
128828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek    Diag(Loc, diag::warn_objc_property_copy_missing_on_block);
12899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek}
1290