SemaObjCProperty.cpp revision 8697d308c1bdd50e5c45757ac11be701c26e9e97
19d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===--- SemaObjCProperty.cpp - Semantic Analysis for ObjC @property ------===// 29d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 39d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// The LLVM Compiler Infrastructure 49d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 59d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file is distributed under the University of Illinois Open Source 69d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// License. See LICENSE.TXT for details. 79d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 89d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 99d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file implements semantic analysis for Objective C @property and 119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// @synthesize declarations. 129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Initialization.h" 177cd088e519d7e6caa4c4c12db52e0e4ae35d25c2John McCall#include "clang/AST/DeclObjC.h" 1817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian#include "clang/AST/ExprObjC.h" 1950df6ae41f232612e5e88b19e0db9900d08d2f6cJohn McCall#include "llvm/ADT/DenseSet.h" 209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekusing namespace clang; 229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Grammar actions. 2528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 27f85e193739c953358c865005855253af4f68a497John McCall/// Check the internal consistency of a property declaration. 28f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyDecl(Sema &S, ObjCPropertyDecl *property) { 29f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl()) return; 30f85e193739c953358c865005855253af4f68a497John McCall 31f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind propertyKind 32f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 33f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime propertyLifetime 34f85e193739c953358c865005855253af4f68a497John McCall = property->getType().getObjCLifetime(); 35f85e193739c953358c865005855253af4f68a497John McCall 36f85e193739c953358c865005855253af4f68a497John McCall // Nothing to do if we don't have a lifetime. 37f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == Qualifiers::OCL_None) return; 38f85e193739c953358c865005855253af4f68a497John McCall 39f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime expectedLifetime; 40f85e193739c953358c865005855253af4f68a497John McCall unsigned selector; 41f85e193739c953358c865005855253af4f68a497John McCall 42f85e193739c953358c865005855253af4f68a497John McCall // Strong properties should have either strong or no lifetime. 43f85e193739c953358c865005855253af4f68a497John McCall if (propertyKind & (ObjCPropertyDecl::OBJC_PR_retain | 44f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_strong | 45f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_copy)) { 46f85e193739c953358c865005855253af4f68a497John McCall expectedLifetime = Qualifiers::OCL_Strong; 47f85e193739c953358c865005855253af4f68a497John McCall selector = 0; 48f85e193739c953358c865005855253af4f68a497John McCall } else if (propertyKind & ObjCPropertyDecl::OBJC_PR_weak) { 49f85e193739c953358c865005855253af4f68a497John McCall expectedLifetime = Qualifiers::OCL_Weak; 50f85e193739c953358c865005855253af4f68a497John McCall selector = 1; 51f85e193739c953358c865005855253af4f68a497John McCall } else if (propertyKind & (ObjCPropertyDecl::OBJC_PR_assign | 52f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_unsafe_unretained) && 53f85e193739c953358c865005855253af4f68a497John McCall property->getType()->isObjCRetainableType()) { 54f85e193739c953358c865005855253af4f68a497John McCall expectedLifetime = Qualifiers::OCL_ExplicitNone; 55f85e193739c953358c865005855253af4f68a497John McCall selector = 2; 56f85e193739c953358c865005855253af4f68a497John McCall } else { 57f85e193739c953358c865005855253af4f68a497John McCall // We have a lifetime qualifier but no dominating property 58f85e193739c953358c865005855253af4f68a497John McCall // attribute. That's okay. 59f85e193739c953358c865005855253af4f68a497John McCall return; 60f85e193739c953358c865005855253af4f68a497John McCall } 61f85e193739c953358c865005855253af4f68a497John McCall 62f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == expectedLifetime) return; 63f85e193739c953358c865005855253af4f68a497John McCall 64f85e193739c953358c865005855253af4f68a497John McCall property->setInvalidDecl(); 65f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), 66b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis diag::err_arc_inconsistent_property_ownership) 67f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 68f85e193739c953358c865005855253af4f68a497John McCall << selector 69f85e193739c953358c865005855253af4f68a497John McCall << propertyLifetime; 70f85e193739c953358c865005855253af4f68a497John McCall} 71f85e193739c953358c865005855253af4f68a497John McCall 72d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnProperty(Scope *S, SourceLocation AtLoc, 73d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall FieldDeclarator &FD, 74d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall ObjCDeclSpec &ODS, 75d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector GetterSel, 76d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector SetterSel, 77d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool *isOverridingProperty, 784a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek tok::ObjCKeywordKind MethodImplKind, 794a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek DeclContext *lexicalDC) { 8028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek unsigned Attributes = ODS.getPropertyAttributes(); 81f85e193739c953358c865005855253af4f68a497John McCall TypeSourceInfo *TSI = GetTypeForDeclarator(FD.D, S); 82f85e193739c953358c865005855253af4f68a497John McCall QualType T = TSI->getType(); 83f85e193739c953358c865005855253af4f68a497John McCall if ((getLangOptions().getGCMode() != LangOptions::NonGC && 84f85e193739c953358c865005855253af4f68a497John McCall T.isObjCGCWeak()) || 85f85e193739c953358c865005855253af4f68a497John McCall (getLangOptions().ObjCAutoRefCount && 86f85e193739c953358c865005855253af4f68a497John McCall T.getObjCLifetime() == Qualifiers::OCL_Weak)) 87f85e193739c953358c865005855253af4f68a497John McCall Attributes |= ObjCDeclSpec::DQ_PR_weak; 88f85e193739c953358c865005855253af4f68a497John McCall 8928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isReadWrite = ((Attributes & ObjCDeclSpec::DQ_PR_readwrite) || 9028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // default is readwrite! 9128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly)); 9228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // property is defaulted to 'assign' if it is readwrite and is 9328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // not retain or copy 9428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isAssign = ((Attributes & ObjCDeclSpec::DQ_PR_assign) || 9528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (isReadWrite && 9628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_retain) && 97f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_strong) && 98f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_copy) && 99f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) && 100f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_weak))); 10114086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian 102e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Proceed with constructing the ObjCPropertDecls. 103a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian ObjCContainerDecl *ClassDecl = cast<ObjCContainerDecl>(CurContext); 104e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 10528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) 106ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian if (CDecl->IsClassExtension()) { 107a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian Decl *Res = HandlePropertyInClassExtension(S, AtLoc, 108ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian FD, GetterSel, SetterSel, 109ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isAssign, isReadWrite, 110ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian Attributes, 111ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isOverridingProperty, TSI, 112ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian MethodImplKind); 113f85e193739c953358c865005855253af4f68a497John McCall if (Res) { 114ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes); 115f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 116f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, cast<ObjCPropertyDecl>(Res)); 117f85e193739c953358c865005855253af4f68a497John McCall } 118ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian return Res; 119ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian } 120ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian 121f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *Res = CreatePropertyDecl(S, ClassDecl, AtLoc, FD, 122f85e193739c953358c865005855253af4f68a497John McCall GetterSel, SetterSel, 123f85e193739c953358c865005855253af4f68a497John McCall isAssign, isReadWrite, 124f85e193739c953358c865005855253af4f68a497John McCall Attributes, TSI, MethodImplKind); 1254a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek if (lexicalDC) 1264a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek Res->setLexicalDeclContext(lexicalDC); 1274a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek 128842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian // Validate the attributes on the @property. 129842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes); 130f85e193739c953358c865005855253af4f68a497John McCall 131f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 132f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, Res); 133f85e193739c953358c865005855253af4f68a497John McCall 134842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian return Res; 135e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 136e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 137d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl * 138a28948f34817476d02412fa204cae038e228c827Fariborz JahanianSema::HandlePropertyInClassExtension(Scope *S, 139e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, FieldDeclarator &FD, 140e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, Selector SetterSel, 141e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 142e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 143e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 144e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek bool *isOverridingProperty, 14583a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *T, 146e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek tok::ObjCKeywordKind MethodImplKind) { 14758a764940df0cd41767367eb2f4fced6f374176bFariborz Jahanian ObjCCategoryDecl *CDecl = cast<ObjCCategoryDecl>(CurContext); 148e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Diagnose if this property is already in continuation class. 149a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian DeclContext *DC = CurContext; 150e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 1512a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCInterfaceDecl *CCPrimary = CDecl->getClassInterface(); 1522a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 1532a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian if (CCPrimary) 1542a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // Check for duplicate declaration of this property in current and 1552a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // other class extensions. 1562a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian for (const ObjCCategoryDecl *ClsExtDecl = 1572a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian CCPrimary->getFirstClassExtension(); 1582a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ClsExtDecl; ClsExtDecl = ClsExtDecl->getNextClassExtension()) { 1592a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian if (ObjCPropertyDecl *prevDecl = 1602a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCPropertyDecl::findPropertyDecl(ClsExtDecl, PropertyId)) { 1612a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(AtLoc, diag::err_duplicate_property); 1622a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(prevDecl->getLocation(), diag::note_property_declare); 1632a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian return 0; 1642a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 1652a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 1662a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 167e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Create a new ObjCPropertyDecl with the DeclContext being 168e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // the class extension. 16988f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // FIXME. We should really be using CreatePropertyDecl for this. 170e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 171e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::Create(Context, DC, FD.D.getIdentifierLoc(), 172e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PropertyId, AtLoc, T); 17322f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 17422f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 17522f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 17622f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 17788f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // Set setter/getter selector name. Needed later. 17888f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setGetterName(GetterSel); 17988f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setSetterName(SetterSel); 18091ae6b43b3a294243698cdb544dd7a18efa4c7a8Douglas Gregor ProcessDeclAttributes(S, PDecl, FD.D); 181e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DC->addDecl(PDecl); 182e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 183e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // We need to look in the @interface to see if the @property was 184e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // already declared. 185e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!CCPrimary) { 186e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(CDecl->getLocation(), diag::err_continuation_class); 187e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 188d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 189e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 190e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 191e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Find the property in continuation class's primary class only. 192e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PIDecl = 193e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CCPrimary->FindPropertyVisibleInPrimaryClass(PropertyId); 194e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 195e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!PIDecl) { 196e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // No matching property found in the primary class. Just fall thru 197e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and add property to continuation class's primary class. 198e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 199e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CreatePropertyDecl(S, CCPrimary, AtLoc, 200e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FD, GetterSel, SetterSel, isAssign, isReadWrite, 20123173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek Attributes, T, MethodImplKind, DC); 202e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 203e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // A case of continuation class adding a new property in the class. This 204e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // is not what it was meant for. However, gcc supports it and so should we. 205e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter/getters are declared here. 206a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek ProcessPropertyDecl(PDecl, CCPrimary, /* redeclaredProperty = */ 0, 207a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek /* lexicalDC = */ CDecl); 208d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PDecl; 209e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 210e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 211e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // The property 'PIDecl's readonly attribute will be over-ridden 212e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // with continuation class's readwrite property attribute! 21380aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian unsigned PIkind = PIDecl->getPropertyAttributesAsWritten(); 214e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (isReadWrite && (PIkind & ObjCPropertyDecl::OBJC_PR_readonly)) { 215e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek unsigned retainCopyNonatomic = 216e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (ObjCPropertyDecl::OBJC_PR_retain | 217f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_strong | 218e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_copy | 219e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_nonatomic); 220e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if ((Attributes & retainCopyNonatomic) != 221e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (PIkind & retainCopyNonatomic)) { 222e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::warn_property_attr_mismatch); 223e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 224e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 2259944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek DeclContext *DC = cast<DeclContext>(CCPrimary); 2269944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek if (!ObjCPropertyDecl::findPropertyDecl(DC, 2279944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek PIDecl->getDeclName().getAsIdentifierInfo())) { 228e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Protocol is not in the primary class. Must build one for it. 229e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCDeclSpec ProtocolPropertyODS; 230e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // FIXME. Assuming that ObjCDeclSpec::ObjCPropertyAttributeKind 231e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and ObjCPropertyDecl::PropertyAttributeKind have identical 232e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // values. Should consolidate both into one enum type. 233e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProtocolPropertyODS. 234e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek setPropertyAttributes((ObjCDeclSpec::ObjCPropertyAttributeKind) 235e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIkind); 236a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // Must re-establish the context from class extension to primary 237a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // class context. 2387939418cbdf1b610a69e6adf29cd7dc8d0e9eaf8Fariborz Jahanian ContextRAII SavedContext(*this, CCPrimary); 2397939418cbdf1b610a69e6adf29cd7dc8d0e9eaf8Fariborz Jahanian 240d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ProtocolPtrTy = 241e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ActOnProperty(S, AtLoc, FD, ProtocolPropertyODS, 242e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getGetterName(), 243e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getSetterName(), 244a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian isOverridingProperty, 2454a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek MethodImplKind, 2464a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek /* lexicalDC = */ CDecl); 247d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall PIDecl = cast<ObjCPropertyDecl>(ProtocolPtrTy); 24828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 249e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->makeitReadWriteAttribute(); 250e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 251e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 252f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) 253f85e193739c953358c865005855253af4f68a497John McCall PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 254e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 255e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 256e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setSetterName(SetterSel); 257e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } else { 258788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // Tailor the diagnostics for the common case where a readwrite 259788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // property is declared both in the @interface and the continuation. 260788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // This is a common error where the user often intended the original 261788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // declaration to be readonly. 262788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek unsigned diag = 263788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_readwrite) && 264788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (PIkind & ObjCPropertyDecl::OBJC_PR_readwrite) 265788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek ? diag::err_use_continuation_class_redeclaration_readwrite 266788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek : diag::err_use_continuation_class; 267788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek Diag(AtLoc, diag) 268e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek << CCPrimary->getDeclName(); 269e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 270e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 271e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 272e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter decl is synthesized, and added to primary class's list. 2738254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ProcessPropertyDecl(PIDecl, CCPrimary, PDecl, CDecl); 274d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 275e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 276e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 277e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekObjCPropertyDecl *Sema::CreatePropertyDecl(Scope *S, 278e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *CDecl, 279e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, 280e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FieldDeclarator &FD, 281e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, 282e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector SetterSel, 283e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 284e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 285e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 28683a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *TInfo, 28723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek tok::ObjCKeywordKind MethodImplKind, 28823173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek DeclContext *lexicalDC){ 289e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 29083a230c83a54190366138c1a4f4310ef838b88fcJohn McCall QualType T = TInfo->getType(); 29128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 29228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Issue a warning if property is 'assign' as default and its object, which is 29328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // gc'able conforms to NSCopying protocol 29428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (getLangOptions().getGCMode() != LangOptions::NonGC && 29528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek isAssign && !(Attributes & ObjCDeclSpec::DQ_PR_assign)) 296c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (const ObjCObjectPointerType *ObjPtrTy = 297c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall T->getAs<ObjCObjectPointerType>()) { 298c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall ObjCInterfaceDecl *IDecl = ObjPtrTy->getObjectType()->getInterface(); 299c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl) 300c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (ObjCProtocolDecl* PNSCopying = 301c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall LookupProtocol(&Context.Idents.get("NSCopying"), AtLoc)) 302c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl->ClassImplementsProtocol(PNSCopying, true)) 303c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall Diag(AtLoc, diag::warn_implements_nscopying) << PropertyId; 30428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 305c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (T->isObjCObjectType()) 30628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(FD.D.getIdentifierLoc(), diag::err_statically_allocated_object); 30728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 308e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 30928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC, 31028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek FD.D.getIdentifierLoc(), 31183a230c83a54190366138c1a4f4310ef838b88fcJohn McCall PropertyId, AtLoc, TInfo); 312e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 3139f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek if (ObjCPropertyDecl *prevDecl = 3149f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) { 31528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PDecl->getLocation(), diag::err_duplicate_property); 316894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek Diag(prevDecl->getLocation(), diag::note_property_declare); 31728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 31828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 31923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek else { 32028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek DC->addDecl(PDecl); 32123173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek if (lexicalDC) 32223173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek PDecl->setLexicalDeclContext(lexicalDC); 32323173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek } 32428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 32528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isArrayType() || T->isFunctionType()) { 32628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::err_property_type) << T; 32728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 32828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 32928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 33028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ProcessDeclAttributes(S, PDecl, FD.D); 33128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 33228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Regardless of setter/getter attribute, we save the default getter/setter 33328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // selector names in anticipation of declaration of setter/getter methods. 33428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setGetterName(GetterSel); 33528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setSetterName(SetterSel); 33628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 3370a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis unsigned attributesAsWritten = 0; 3380a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 3390a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readonly; 3400a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 3410a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readwrite; 3420a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_getter) 3430a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_getter; 3440a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_setter) 3450a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_setter; 3460a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_assign) 3470a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_assign; 3480a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_retain) 3490a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_retain; 3500a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_strong) 3510a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_strong; 3520a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_weak) 3530a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_weak; 3540a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_copy) 3550a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_copy; 3560a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 3570a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_unsafe_unretained; 3580a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 3590a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_nonatomic; 3600a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_atomic) 3610a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_atomic; 3620a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 3630a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis PDecl->setPropertyAttributesAsWritten( 3640a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis (ObjCPropertyDecl::PropertyAttributeKind)attributesAsWritten); 3650a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 36628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 36728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 36828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 36928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_getter) 37028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter); 37128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 37228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_setter) 37328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter); 37428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 37528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isReadWrite) 37628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 37728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 37828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 37928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 38028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 381f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) 382f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 383f85e193739c953358c865005855253af4f68a497John McCall 384f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_weak) 385f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_weak); 386f85e193739c953358c865005855253af4f68a497John McCall 38728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 38828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 38928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 390f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 391f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 392f85e193739c953358c865005855253af4f68a497John McCall 39328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isAssign) 39428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 39528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 39628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 39728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 39845937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian else if (Attributes & ObjCDeclSpec::DQ_PR_atomic) 39945937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_atomic); 40028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 401f85e193739c953358c865005855253af4f68a497John McCall // 'unsafe_unretained' is alias for 'assign'. 402f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 403f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 404f85e193739c953358c865005855253af4f68a497John McCall if (isAssign) 405f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 406f85e193739c953358c865005855253af4f68a497John McCall 40728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (MethodImplKind == tok::objc_required) 40828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Required); 40928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek else if (MethodImplKind == tok::objc_optional) 41028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional); 41128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 412e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return PDecl; 41328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 41428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 415f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyImpl(Sema &S, SourceLocation propertyImplLoc, 416f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *property, 417f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar) { 418f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl() || ivar->isInvalidDecl()) return; 419f85e193739c953358c865005855253af4f68a497John McCall 420f85e193739c953358c865005855253af4f68a497John McCall QualType propertyType = property->getType(); 421f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime propertyLifetime = propertyType.getObjCLifetime(); 422f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind propertyKind 423f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 424f85e193739c953358c865005855253af4f68a497John McCall 425f85e193739c953358c865005855253af4f68a497John McCall QualType ivarType = ivar->getType(); 426f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime ivarLifetime = ivarType.getObjCLifetime(); 427f85e193739c953358c865005855253af4f68a497John McCall 428f85e193739c953358c865005855253af4f68a497John McCall // Case 1: strong properties. 429f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == Qualifiers::OCL_Strong || 430f85e193739c953358c865005855253af4f68a497John McCall (propertyKind & (ObjCPropertyDecl::OBJC_PR_retain | 431f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_strong | 432f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_copy))) { 433f85e193739c953358c865005855253af4f68a497John McCall switch (ivarLifetime) { 434f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 435f85e193739c953358c865005855253af4f68a497John McCall // Okay. 436f85e193739c953358c865005855253af4f68a497John McCall return; 437f85e193739c953358c865005855253af4f68a497John McCall 438f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 439f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 440f85e193739c953358c865005855253af4f68a497John McCall // These aren't valid lifetimes for object ivars; don't diagnose twice. 441f85e193739c953358c865005855253af4f68a497John McCall return; 442f85e193739c953358c865005855253af4f68a497John McCall 443f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 444f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 445b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis S.Diag(propertyImplLoc, diag::err_arc_strong_property_ownership) 446f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 447f85e193739c953358c865005855253af4f68a497John McCall << ivar->getDeclName() 448f85e193739c953358c865005855253af4f68a497John McCall << ivarLifetime; 449f85e193739c953358c865005855253af4f68a497John McCall break; 450f85e193739c953358c865005855253af4f68a497John McCall } 451f85e193739c953358c865005855253af4f68a497John McCall 452f85e193739c953358c865005855253af4f68a497John McCall // Case 2: weak properties. 453f85e193739c953358c865005855253af4f68a497John McCall } else if (propertyLifetime == Qualifiers::OCL_Weak || 454f85e193739c953358c865005855253af4f68a497John McCall (propertyKind & ObjCPropertyDecl::OBJC_PR_weak)) { 455f85e193739c953358c865005855253af4f68a497John McCall switch (ivarLifetime) { 456f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 457f85e193739c953358c865005855253af4f68a497John McCall // Okay. 458f85e193739c953358c865005855253af4f68a497John McCall return; 459f85e193739c953358c865005855253af4f68a497John McCall 460f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 461f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 462f85e193739c953358c865005855253af4f68a497John McCall // These aren't valid lifetimes for object ivars; don't diagnose twice. 463f85e193739c953358c865005855253af4f68a497John McCall return; 464f85e193739c953358c865005855253af4f68a497John McCall 465f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 466f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 467f85e193739c953358c865005855253af4f68a497John McCall S.Diag(propertyImplLoc, diag::error_weak_property) 468f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 469f85e193739c953358c865005855253af4f68a497John McCall << ivar->getDeclName(); 470f85e193739c953358c865005855253af4f68a497John McCall break; 471f85e193739c953358c865005855253af4f68a497John McCall } 472f85e193739c953358c865005855253af4f68a497John McCall 473f85e193739c953358c865005855253af4f68a497John McCall // Case 3: assign properties. 474f85e193739c953358c865005855253af4f68a497John McCall } else if ((propertyKind & ObjCPropertyDecl::OBJC_PR_assign) && 475f85e193739c953358c865005855253af4f68a497John McCall propertyType->isObjCRetainableType()) { 476f85e193739c953358c865005855253af4f68a497John McCall switch (ivarLifetime) { 477f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 478f85e193739c953358c865005855253af4f68a497John McCall // Okay. 479f85e193739c953358c865005855253af4f68a497John McCall return; 480f85e193739c953358c865005855253af4f68a497John McCall 481f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 482f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 483f85e193739c953358c865005855253af4f68a497John McCall // These aren't valid lifetimes for object ivars; don't diagnose twice. 484f85e193739c953358c865005855253af4f68a497John McCall return; 485f85e193739c953358c865005855253af4f68a497John McCall 486f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 487f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 488b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis S.Diag(propertyImplLoc, diag::err_arc_assign_property_ownership) 489f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 4909414449e299036efbd411d92266983dfc24e24e9Fariborz Jahanian << ivar->getDeclName() 4919414449e299036efbd411d92266983dfc24e24e9Fariborz Jahanian << ((property->getPropertyAttributesAsWritten() 4929414449e299036efbd411d92266983dfc24e24e9Fariborz Jahanian & ObjCPropertyDecl::OBJC_PR_assign) != 0); 493f85e193739c953358c865005855253af4f68a497John McCall break; 494f85e193739c953358c865005855253af4f68a497John McCall } 495f85e193739c953358c865005855253af4f68a497John McCall 496f85e193739c953358c865005855253af4f68a497John McCall // Any other property should be ignored. 497f85e193739c953358c865005855253af4f68a497John McCall } else { 498f85e193739c953358c865005855253af4f68a497John McCall return; 499f85e193739c953358c865005855253af4f68a497John McCall } 500f85e193739c953358c865005855253af4f68a497John McCall 501f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), diag::note_property_declare); 502f85e193739c953358c865005855253af4f68a497John McCall} 503f85e193739c953358c865005855253af4f68a497John McCall 50428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 50528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// ActOnPropertyImplDecl - This routine performs semantic checks and 50628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// builds the AST node for a property implementation declaration; declared 50728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// as @synthesize or @dynamic. 50828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// 509d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnPropertyImplDecl(Scope *S, 510d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation AtLoc, 511d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation PropertyLoc, 512d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool Synthesize, 513d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall IdentifierInfo *PropertyId, 514a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor IdentifierInfo *PropertyIvar, 515a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor SourceLocation PropertyIvarLoc) { 516e9686572f17968048a5e097254f85c202ea44aecTed Kremenek ObjCContainerDecl *ClassImpDecl = 517a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian cast_or_null<ObjCContainerDecl>(CurContext); 51828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Make sure we have a context for the property implementation declaration. 51928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!ClassImpDecl) { 52028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_context); 521d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 52228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 52328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *property = 0; 52428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl* IDecl = 0; 52528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Find the class or category class where this property must have 52628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a declaration. 52728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCImplementationDecl *IC = 0; 52828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryImplDecl* CatImplClass = 0; 52928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) { 53028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = IC->getClassInterface(); 53128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // We always synthesize an interface for an implementation 53228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // without an interface decl. So, IDecl is always non-zero. 53328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert(IDecl && 53428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "ActOnPropertyImplDecl - @implementation without @interface"); 53528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 53628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in the @implementation's @interface 53728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = IDecl->FindPropertyDeclaration(PropertyId); 53828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 53928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_property_decl) << IDecl->getDeclName(); 540d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 54128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 542dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian unsigned PIkind = property->getPropertyAttributesAsWritten(); 54345937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian if ((PIkind & (ObjCPropertyDecl::OBJC_PR_atomic | 54445937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_nonatomic) ) == 0) { 545dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian if (AtLoc.isValid()) 546dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(AtLoc, diag::warn_implicit_atomic_property); 547dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian else 548dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(IC->getLocation(), diag::warn_auto_implicit_atomic_property); 549dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 550dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian } 551dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian 55228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (const ObjCCategoryDecl *CD = 55328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek dyn_cast<ObjCCategoryDecl>(property->getDeclContext())) { 55428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!CD->IsClassExtension()) { 55528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_category_property) << CD->getDeclName(); 55628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(property->getLocation(), diag::note_property_declare); 557d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 55828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 55928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 56028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) { 56128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 56228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_synthesize_category_decl); 563d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 56428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 56528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = CatImplClass->getClassInterface(); 56628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!IDecl) { 56728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_interface); 568d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 56928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 57028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryDecl *Category = 57128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier()); 57228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 57328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // If category for this implementation not found, it is an error which 57428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // has already been reported eralier. 57528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Category) 576d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 57728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in @implementation's category 57828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = Category->FindPropertyDeclaration(PropertyId); 57928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 58028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_category_property_decl) 58128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << Category->getDeclName(); 582d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 58328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 58428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 58528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_bad_property_context); 586d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 58728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 58828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCIvarDecl *Ivar = 0; 58928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that we have a valid, previously declared ivar for @synthesize 59028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 59128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @synthesize 59228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!PropertyIvar) 59328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyIvar = PropertyId; 594f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind kind 595f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 59628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType PropType = Context.getCanonicalType(property->getType()); 59714086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian QualType PropertyIvarType = PropType; 59814086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (PropType->isReferenceType()) 59914086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType = cast<ReferenceType>(PropType)->getPointeeType(); 60028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that this is a previously declared 'ivar' in 'IDecl' interface 60128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl *ClassDeclared; 60228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Ivar = IDecl->lookupInstanceVariable(PropertyIvar, ClassDeclared); 60328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Ivar) { 604f85e193739c953358c865005855253af4f68a497John McCall // In ARC, give the ivar a lifetime qualifier based on its 605f85e193739c953358c865005855253af4f68a497John McCall // property attributes. 606f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount && 607f85e193739c953358c865005855253af4f68a497John McCall !PropertyIvarType.getObjCLifetime()) { 608f85e193739c953358c865005855253af4f68a497John McCall 609473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis if (!property->hasWrittenStorageAttribute() && 610bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian property->getType()->isObjCRetainableType() && 611bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian !(kind & ObjCPropertyDecl::OBJC_PR_strong) ) { 612473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis Diag(PropertyLoc, 613473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis diag::err_arc_objc_property_default_assign_on_object); 614473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis Diag(property->getLocation(), diag::note_property_declare); 615473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis } 616473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis 617f85e193739c953358c865005855253af4f68a497John McCall // retain/copy have retaining lifetime. 618f85e193739c953358c865005855253af4f68a497John McCall if (kind & (ObjCPropertyDecl::OBJC_PR_retain | 619f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_strong | 620f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_copy)) { 621f85e193739c953358c865005855253af4f68a497John McCall Qualifiers qs; 622f85e193739c953358c865005855253af4f68a497John McCall qs.addObjCLifetime(Qualifiers::OCL_Strong); 623f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType = Context.getQualifiedType(PropertyIvarType, qs); 624f85e193739c953358c865005855253af4f68a497John McCall } 625f85e193739c953358c865005855253af4f68a497John McCall else if (kind & ObjCPropertyDecl::OBJC_PR_weak) { 6269f084a3166b684573ba49df28fc5792bc37d92e1John McCall if (!getLangOptions().ObjCRuntimeHasWeak) { 627f85e193739c953358c865005855253af4f68a497John McCall Diag(PropertyLoc, diag::err_arc_weak_no_runtime); 628f85e193739c953358c865005855253af4f68a497John McCall Diag(property->getLocation(), diag::note_property_declare); 629f85e193739c953358c865005855253af4f68a497John McCall } 630f85e193739c953358c865005855253af4f68a497John McCall Qualifiers qs; 631f85e193739c953358c865005855253af4f68a497John McCall qs.addObjCLifetime(Qualifiers::OCL_Weak); 632f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType = Context.getQualifiedType(PropertyIvarType, qs); 633f85e193739c953358c865005855253af4f68a497John McCall } 634f85e193739c953358c865005855253af4f68a497John McCall else if (kind & ObjCPropertyDecl::OBJC_PR_assign && 635f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType->isObjCRetainableType()) { 636f85e193739c953358c865005855253af4f68a497John McCall // assume that an 'assign' property synthesizes __unsafe_unretained 637f85e193739c953358c865005855253af4f68a497John McCall // ivar 638f85e193739c953358c865005855253af4f68a497John McCall Qualifiers qs; 639f85e193739c953358c865005855253af4f68a497John McCall qs.addObjCLifetime(Qualifiers::OCL_ExplicitNone); 640f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType = Context.getQualifiedType(PropertyIvarType, qs); 641f85e193739c953358c865005855253af4f68a497John McCall } 642f85e193739c953358c865005855253af4f68a497John McCall } 643f85e193739c953358c865005855253af4f68a497John McCall 644f85e193739c953358c865005855253af4f68a497John McCall if (kind & ObjCPropertyDecl::OBJC_PR_weak && 645f85e193739c953358c865005855253af4f68a497John McCall !getLangOptions().ObjCAutoRefCount && 646f85e193739c953358c865005855253af4f68a497John McCall getLangOptions().getGCMode() == LangOptions::NonGC) { 647f85e193739c953358c865005855253af4f68a497John McCall Diag(PropertyLoc, diag::error_synthesize_weak_non_arc_or_gc); 648f85e193739c953358c865005855253af4f68a497John McCall Diag(property->getLocation(), diag::note_property_declare); 649f85e193739c953358c865005855253af4f68a497John McCall } 650f85e193739c953358c865005855253af4f68a497John McCall 651ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Ivar = ObjCIvarDecl::Create(Context, ClassImpDecl, 652ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara PropertyLoc, PropertyLoc, PropertyIvar, 65314086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType, /*Dinfo=*/0, 6547504966cc0d07eac26baabec80a7406695efb307Fariborz Jahanian ObjCIvarDecl::Private, 655ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian (Expr *)0, true); 65629fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar ClassImpDecl->addDecl(Ivar); 65728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->makeDeclVisibleInContext(Ivar, false); 65828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property->setPropertyIvarDecl(Ivar); 65928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 66028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!getLangOptions().ObjCNonFragileABI) 66128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_missing_property_ivar_decl) << PropertyId; 66228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 66328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 66428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (getLangOptions().ObjCNonFragileABI && 66528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ClassDeclared != IDecl) { 66628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_ivar_in_superclass_use) 66728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName() 66828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << ClassDeclared->getDeclName(); 66928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Ivar->getLocation(), diag::note_previous_access_declaration) 6704087f27e5416c799bcb6be072f905be752acb61cDaniel Dunbar << Ivar << Ivar->getName(); 67128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so more errors are caught. 67228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 67328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType IvarType = Context.getCanonicalType(Ivar->getType()); 67428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 67528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that type of property and its ivar are type compatible. 67614086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (PropertyIvarType != IvarType) { 67762ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian bool compat = false; 67814086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (isa<ObjCObjectPointerType>(PropertyIvarType) 679f85e193739c953358c865005855253af4f68a497John McCall && isa<ObjCObjectPointerType>(IvarType)) 68062ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian compat = 68162ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian Context.canAssignObjCInterfaces( 68214086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType->getAs<ObjCObjectPointerType>(), 68362ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian IvarType->getAs<ObjCObjectPointerType>()); 684b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor else { 685b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor SourceLocation Loc = PropertyIvarLoc; 686b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor if (Loc.isInvalid()) 687b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor Loc = PropertyLoc; 68814086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian compat = (CheckAssignmentConstraints(Loc, PropertyIvarType, IvarType) 689daa8e4e888758d55a7a759dd4a91b83921cef222John McCall == Compatible); 690b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor } 69162ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian if (!compat) { 69228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 693f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 694f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 695f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 69628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 69728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 69828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 69928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 70028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME! Rules for properties are somewhat different that those 70128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // for assignments. Use a new routine to consolidate all cases; 70228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // specifically for property redeclarations as well as for ivars. 70314086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian QualType lhsType =Context.getCanonicalType(PropertyIvarType).getUnqualifiedType(); 70428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType rhsType =Context.getCanonicalType(IvarType).getUnqualifiedType(); 70528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (lhsType != rhsType && 70628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek lhsType->isArithmeticType()) { 70728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 708f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 709f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 710f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 71128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 71228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 71328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // __weak is explicit. So it works on Canonical type. 714f85e193739c953358c865005855253af4f68a497John McCall if ((PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() && 715f85e193739c953358c865005855253af4f68a497John McCall getLangOptions().getGCMode() != LangOptions::NonGC)) { 71628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_weak_property) 71728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 71828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 71928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 720f85e193739c953358c865005855253af4f68a497John McCall // Fall thru - see previous comment 72128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((property->getType()->isObjCObjectPointerType() || 72228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropType.isObjCGCStrong()) && IvarType.isObjCGCWeak() && 72328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek getLangOptions().getGCMode() != LangOptions::NonGC) { 72428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_strong_property) 72528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 72628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 72728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 72828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 729f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 730f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyImpl(*this, PropertyLoc, property, Ivar); 73128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (PropertyIvar) 73228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @dynamic 73328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_dynamic_property_ivar_decl); 734f85e193739c953358c865005855253af4f68a497John McCall 73528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert (property && "ActOnPropertyImplDecl - property declaration missing"); 73628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl *PIDecl = 73728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Create(Context, CurContext, AtLoc, PropertyLoc, 73828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property, 73928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Synthesize ? 74028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Synthesize 74128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek : ObjCPropertyImplDecl::Dynamic), 742a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor Ivar, PropertyIvarLoc); 74317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *getterMethod = property->getGetterMethodDecl()) { 74417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian getterMethod->createImplicitParams(Context, IDecl); 7450313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian if (getLangOptions().CPlusPlus && Synthesize && 7460313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian Ivar->getType()->isRecordType()) { 74717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // For Objective-C++, need to synthesize the AST for the IVAR object to be 74817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // returned by the getter as it must conform to C++'s copy-return rules. 74917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 75017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = getterMethod->getSelfDecl(); 75117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 752f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall new (Context) DeclRefExpr(SelfDecl, SelfDecl->getType(), 753f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_RValue, SourceLocation()); 75417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *IvarRefExpr = 75517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 75617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 75760d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult Res = 75817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PerformCopyInitialization(InitializedEntity::InitializeResult( 7593c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor SourceLocation(), 7603c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor getterMethod->getResultType(), 7613c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor /*NRVO=*/false), 76217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SourceLocation(), 76317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Owned(IvarRefExpr)); 76417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (!Res.isInvalid()) { 76517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *ResExpr = Res.takeAs<Expr>(); 76617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ResExpr) 7674765fa05b5652fcc4356371c2f481d0ea9a1b007John McCall ResExpr = MaybeCreateExprWithCleanups(ResExpr); 76817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setGetterCXXConstructor(ResExpr); 76917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 77017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 771831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>() && 772831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !getterMethod->hasAttr<NSReturnsNotRetainedAttr>()) { 773831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(getterMethod->getLocation(), 774831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian diag::warn_property_getter_owning_mismatch); 775831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 776831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian } 77717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 77817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *setterMethod = property->getSetterMethodDecl()) { 77917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian setterMethod->createImplicitParams(Context, IDecl); 7800313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian if (getLangOptions().CPlusPlus && Synthesize 7810313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian && Ivar->getType()->isRecordType()) { 78217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 78317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = setterMethod->getSelfDecl(); 78417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 785f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall new (Context) DeclRefExpr(SelfDecl, SelfDecl->getType(), 786f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_RValue, SourceLocation()); 78717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *lhs = 78817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 78917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 79017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ObjCMethodDecl::param_iterator P = setterMethod->param_begin(); 79117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ParmVarDecl *Param = (*P); 79214086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian QualType T = Param->getType(); 79314086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (T->isReferenceType()) 79461750f2bed7f5c0e440318841e3be385920b22f3Fariborz Jahanian T = T->getAs<ReferenceType>()->getPointeeType(); 79514086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian Expr *rhs = new (Context) DeclRefExpr(Param, T, 796f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_LValue, SourceLocation()); 797fa432391a708448518df1e6ced4e34f4c349d169Fariborz Jahanian ExprResult Res = BuildBinOp(S, lhs->getLocEnd(), 7982de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BO_Assign, lhs, rhs); 79917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setSetterCXXAssignment(Res.takeAs<Expr>()); 80017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 80117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 80217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian 80328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (IC) { 80428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 80528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 80628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->FindPropertyImplIvarDecl(PropertyIvar)) { 80728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 80828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 80928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 81028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 81128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 81228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 81328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl 81428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek = IC->FindPropertyImplDecl(PropertyId)) { 81528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 81628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 817d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 81828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 81928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->addPropertyImplementation(PIDecl); 820e776f88430eb77ce8d58f2e6ec10da1383b71de8Fariborz Jahanian if (getLangOptions().ObjCDefaultSynthProperties && 821e776f88430eb77ce8d58f2e6ec10da1383b71de8Fariborz Jahanian getLangOptions().ObjCNonFragileABI2) { 822ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // Diagnose if an ivar was lazily synthesdized due to a previous 823ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // use and if 1) property is @dynamic or 2) property is synthesized 824cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // but it requires an ivar of different name. 825411c25c4512f00e07442e8818d011c7e0902d739Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared=0; 826ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian ObjCIvarDecl *Ivar = 0; 827ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (!Synthesize) 828ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 829ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian else { 830ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (PropertyIvar && PropertyIvar != PropertyId) 831ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 832ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 833cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // Issue diagnostics only if Ivar belongs to current class. 834cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian if (Ivar && Ivar->getSynthesize() && 835cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian IC->getClassInterface() == ClassDeclared) { 836ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Diag(Ivar->getLocation(), diag::err_undeclared_var_use) 837ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian << PropertyId; 838ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar->setInvalidDecl(); 839ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 840ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 84128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 84228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 84328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 84428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplIvarDecl(PropertyIvar)) { 84528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 84628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 84728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 84828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 84928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 85028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 85128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 85228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplDecl(PropertyId)) { 85328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 85428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 855d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 85628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 85728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->addPropertyImplementation(PIDecl); 85828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 85928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 860d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PIDecl; 86128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 86228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 86328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 86428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Helper methods. 86528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 86628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 8679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// DiagnosePropertyMismatch - Compares two properties for their 8689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// attributes and types and warns on a variety of inconsistencies. 8699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 8709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 8719d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property, 8729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperProperty, 8739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const IdentifierInfo *inheritedName) { 8749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 8759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Property->getPropertyAttributes(); 8769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind SAttr = 8779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SuperProperty->getPropertyAttributes(); 8789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly) 8799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite)) 8809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_readonly_property) 8819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << inheritedName; 8829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy) 8839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_copy)) 8849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 8859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "copy" << inheritedName; 886f85e193739c953358c865005855253af4f68a497John McCall else { 887f85e193739c953358c865005855253af4f68a497John McCall unsigned CAttrRetain = 888f85e193739c953358c865005855253af4f68a497John McCall (CAttr & 889f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 890f85e193739c953358c865005855253af4f68a497John McCall unsigned SAttrRetain = 891f85e193739c953358c865005855253af4f68a497John McCall (SAttr & 892f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 893f85e193739c953358c865005855253af4f68a497John McCall bool CStrong = (CAttrRetain != 0); 894f85e193739c953358c865005855253af4f68a497John McCall bool SStrong = (SAttrRetain != 0); 895f85e193739c953358c865005855253af4f68a497John McCall if (CStrong != SStrong) 896f85e193739c953358c865005855253af4f68a497John McCall Diag(Property->getLocation(), diag::warn_property_attribute) 897f85e193739c953358c865005855253af4f68a497John McCall << Property->getDeclName() << "retain (or strong)" << inheritedName; 898f85e193739c953358c865005855253af4f68a497John McCall } 8999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic) 9019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)) 9029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 9039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "atomic" << inheritedName; 9049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getSetterName() != SuperProperty->getSetterName()) 9059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 9069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "setter" << inheritedName; 9079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getGetterName() != SuperProperty->getGetterName()) 9089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 9099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "getter" << inheritedName; 9109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType LHSType = 9129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SuperProperty->getType()); 9139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType RHSType = 9149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(Property->getType()); 9159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 916c286f3835eb6001c61664cef5d610dfaf80a6e9bFariborz Jahanian if (!Context.propertyTypesAreCompatible(LHSType, RHSType)) { 9178beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // Do cases not handled in above. 9188beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // FIXME. For future support of covariant property types, revisit this. 9198beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian bool IncompatibleObjC = false; 9208beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian QualType ConvertedType; 9218beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian if (!isObjCPointerConversion(RHSType, LHSType, 9228beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian ConvertedType, IncompatibleObjC) || 9238beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian IncompatibleObjC) 9248beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian Diag(Property->getLocation(), diag::warn_property_types_are_incompatible) 9258beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian << Property->getType() << SuperProperty->getType() << inheritedName; 9269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::DiagnosePropertyAccessorMismatch(ObjCPropertyDecl *property, 9309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, 9319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc) { 9329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod && 9339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->getResultType() != property->getType()) { 9349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AssignConvertType result = Incompatible; 9351c23e91ef66688d20868b6bab3b5589a119eb603John McCall if (property->getType()->isObjCObjectPointerType()) 936b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor result = CheckAssignmentConstraints(Loc, GetterMethod->getResultType(), 9371c23e91ef66688d20868b6bab3b5589a119eb603John McCall property->getType()); 9389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (result != Compatible) { 9399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Loc, diag::warn_accessor_property_type_mismatch) 9409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 9419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << GetterMethod->getSelector(); 9429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(GetterMethod->getLocation(), diag::note_declared_at); 9439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 9449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 9479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ComparePropertiesInBaseAndSuper - This routine compares property 9509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declarations in base and its super class, if any, and issues 951fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner/// diagnostics in a variety of inconsistent situations. 9529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 9539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ComparePropertiesInBaseAndSuper(ObjCInterfaceDecl *IDecl) { 9549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *SDecl = IDecl->getSuperClass(); 9559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SDecl) 9569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 9579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: O(N^2) 9589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator S = SDecl->prop_begin(), 9599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = SDecl->prop_end(); S != E; ++S) { 9609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperPDecl = (*S); 9619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Does property in super class has declaration in current class? 9629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator I = IDecl->prop_begin(), 9639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); I != E; ++I) { 9649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *PDecl = (*I); 9659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SuperPDecl->getIdentifier() == PDecl->getIdentifier()) 9669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch(PDecl, SuperPDecl, 9679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SDecl->getIdentifier()); 9689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// MatchOneProtocolPropertiesInClass - This routine goes thru the list 9739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// of properties declared in a protocol and compares their attribute against 9749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the same property declared in the class or category. 9759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 9769d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::MatchOneProtocolPropertiesInClass(Decl *CDecl, 9779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *PDecl) { 9789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 9799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 9809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 9819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 9829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "MatchOneProtocolPropertiesInClass"); 9839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CatDecl->IsClassExtension()) 9849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 9859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 9869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 9879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl::prop_iterator CP, CE; 9889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in category's list of properties? 9892d2f9368d35b3628c7e3b4563f74849a0f901a00Ted Kremenek for (CP = CatDecl->prop_begin(), CE = CatDecl->prop_end(); CP!=CE; ++CP) 9909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 9919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 9929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 9939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 9949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 9959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 9979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 9999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 10009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 10019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl::prop_iterator CP, CE; 10029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in class's list of properties? 10039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (CP = IDecl->prop_begin(), CE = IDecl->prop_end(); CP != CE; ++CP) 10049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 10059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 10069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 10079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 10089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 10099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 10119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CompareProperties - This routine compares properties 10139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declared in 'ClassOrProtocol' objects (which can be a class or an 10149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// inherited protocol with the list of properties for class/category 'CDecl' 10159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 1016d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CompareProperties(Decl *CDecl, Decl *ClassOrProtocol) { 1017d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ClassDecl = ClassOrProtocol; 10189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 10199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 10219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 10229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 10239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "CompareProperties"); 10249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *MDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 10259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = MDecl->protocol_begin(), 10269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MDecl->protocol_end(); P != E; ++P) 10279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of category with those of protocol (*P) 10289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 10299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this category and recursively match 10319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those in the category. 10329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = CatDecl->protocol_begin(), 10339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CatDecl->protocol_end(); P != E; ++P) 1034d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(CatDecl, *P); 10359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 10369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 10379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 10389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 10399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 10409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 10429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *MDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 104553b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 104653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = MDecl->all_referenced_protocol_begin(), 104753b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = MDecl->all_referenced_protocol_end(); P != E; ++P) 10489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of class IDecl with those of protocol (*P). 10499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 10509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this class and recursively match 10529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those declared in the class. 105353b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 105453b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = IDecl->all_referenced_protocol_begin(), 105553b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); P != E; ++P) 1056d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(IDecl, *P); 10579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 10589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 10599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 10609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 10619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 10629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 10649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// isPropertyReadonly - Return true if property is readonly, by searching 10669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// for the property in the class and in its categories and implementations 10679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 10689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::isPropertyReadonly(ObjCPropertyDecl *PDecl, 10699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl) { 10709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // by far the most common case. 10719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!PDecl->isReadOnly()) 10729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 10739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if interface has a user defined setter, 10749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 10759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IDecl->getInstanceMethod(PDecl->getSetterName())) 10769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 10779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Main class has the property as 'readonly'. Must search 10799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // through the category list to see if the property's 10809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // attribute has been over-ridden to 'readwrite'. 10819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl *Category = IDecl->getCategoryList(); 10829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category; Category = Category->getNextClassCategory()) { 10839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if a category has a user defined setter, 10849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 10859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Category->getInstanceMethod(PDecl->getSetterName())) 10869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 10879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *P = 10889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category->FindPropertyDeclaration(PDecl->getIdentifier()); 10899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (P && !P->isReadOnly()) 10909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 10919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Also, check for definition of a setter method in the implementation if 10949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // all else failed. 10959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(CurContext)) { 10969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *IMD = 10979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCImplementationDecl>(OMD->getDeclContext())) { 10989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IMD->getInstanceMethod(PDecl->getSetterName())) 10999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else if (ObjCCategoryImplDecl *CIMD = 11019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCCategoryImplDecl>(OMD->getDeclContext())) { 11029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CIMD->getInstanceMethod(PDecl->getSetterName())) 11039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Lastly, look through the implementation (if one is in scope). 11079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *ImpDecl = IDecl->getImplementation()) 11089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ImpDecl->getInstanceMethod(PDecl->getSetterName())) 11099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // If all fails, look at the super class. 11119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *SIDecl = IDecl->getSuperClass()) 11129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return isPropertyReadonly(PDecl, SIDecl); 11139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 11149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 11159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 11169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CollectImmediateProperties - This routine collects all properties in 11179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the class and its conforming protocols; but not those it its super class. 11189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::CollectImmediateProperties(ObjCContainerDecl *CDecl, 1119cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap, 1120cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& SuperPropMap) { 11219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 11229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 11239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 11249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 11259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 11269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 112853b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 112953b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 113053b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 1131cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 11329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *CATDecl = dyn_cast<ObjCCategoryDecl>(CDecl)) { 11349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CATDecl->IsClassExtension()) 11359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = CATDecl->prop_begin(), 11369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->prop_end(); P != E; ++P) { 11379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 11389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 11399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 114153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCCategoryDecl::protocol_iterator PI = CATDecl->protocol_begin(), 11429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->protocol_end(); PI != E; ++PI) 1143cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 11449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 11469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 11479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 11489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 1149cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *PropertyFromSuper = SuperPropMap[Prop->getIdentifier()]; 1150cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // Exclude property for protocols which conform to class's super-class, 1151cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // as super-class has to implement the property. 1152cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropertyFromSuper || PropertyFromSuper != Prop) { 1153cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *&PropEntry = PropMap[Prop->getIdentifier()]; 1154cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropEntry) 1155cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian PropEntry = Prop; 1156cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian } 11579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 11599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 11609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) 1161cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 11629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 11649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1165509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectClassPropertyImplementations - This routine collects list of 1166509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in the class. This includes, class's 1167509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// and its conforming protocols' properties. 1168509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectClassPropertyImplementations(ObjCContainerDecl *CDecl, 1169509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 1170509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 1171509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 1172509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = IDecl->prop_end(); P != E; ++P) { 1173509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = (*P); 1174509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 1175509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 117653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 117753b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 117853b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 1179509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 1180509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1181509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 1182509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 1183509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->prop_end(); P != E; ++P) { 1184509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = (*P); 1185509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 1186509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1187509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // scan through protocol's protocols. 1188509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 1189509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->protocol_end(); PI != E; ++PI) 1190509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 1191509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1192509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 1193509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1194509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectSuperClassPropertyImplementations - This routine collects list of 1195509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in super class(s) and also coming from their 1196509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// conforming protocols. 1197509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectSuperClassPropertyImplementations(ObjCInterfaceDecl *CDecl, 1198509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 1199509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *SDecl = CDecl->getSuperClass()) { 1200509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian while (SDecl) { 1201509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(SDecl, PropMap); 1202509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian SDecl = SDecl->getSuperClass(); 1203509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1204509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1205509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 1206509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 12079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// LookupPropertyDecl - Looks up a property in the current class and all 12089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// its protocols. 12099d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekObjCPropertyDecl *Sema::LookupPropertyDecl(const ObjCContainerDecl *CDecl, 12109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek IdentifierInfo *II) { 12119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCInterfaceDecl *IDecl = 12129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCInterfaceDecl>(CDecl)) { 12139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 12149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 12159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 12169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 12179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 122053b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 122153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 122253b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) { 12239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 12249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 12259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (const ObjCProtocolDecl *PDecl = 12299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCProtocolDecl>(CDecl)) { 12309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 12319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 12329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 12339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 12349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 12379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 12389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) { 12399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 12409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 12419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return 0; 12459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 12469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1247509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// DefaultSynthesizeProperties - This routine default synthesizes all 1248509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties which must be synthesized in class's @implementation. 1249509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianvoid Sema::DefaultSynthesizeProperties (Scope *S, ObjCImplDecl* IMPDecl, 1250509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCInterfaceDecl *IDecl) { 1251509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1252509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 1253509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(IDecl, PropMap); 1254509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (PropMap.empty()) 1255509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian return; 1256509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 1257509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1258509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1259509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 1260509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 1261509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = P->second; 1262509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // If property to be implemented in the super class, ignore. 1263509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (SuperPropMap[Prop->getIdentifier()]) 1264509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 1265509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // Is there a matching propery synthesize/dynamic? 1266509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (Prop->isInvalidDecl() || 1267509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 1268509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian IMPDecl->FindPropertyImplIvarDecl(Prop->getIdentifier())) 1269509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 1270d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian // Property may have been synthesized by user. 1271d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian if (IMPDecl->FindPropertyImplDecl(Prop->getIdentifier())) 1272d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian continue; 127395f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getGetterName())) { 127495f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (Prop->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_readonly) 127595f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 127695f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getSetterName())) 127795f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 127895f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian } 1279d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian 12802a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek 12812a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // We use invalid SourceLocations for the synthesized ivars since they 12822a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // aren't really synthesized at a particular location; they just exist. 12832a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // Saying that they are located at the @implementation isn't really going 12842a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // to help users. 12852a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek ActOnPropertyImplDecl(S, SourceLocation(), SourceLocation(), 1286a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian true, 1287a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor Prop->getIdentifier(), Prop->getIdentifier(), 1288a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor SourceLocation()); 12892a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek } 1290509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 12919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 12928697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanianvoid Sema::DefaultSynthesizeProperties(Scope *S, Decl *D) { 12938697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (!LangOpts.ObjCDefaultSynthProperties || !LangOpts.ObjCNonFragileABI2) 12948697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian return; 12958697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian ObjCImplementationDecl *IC=dyn_cast_or_null<ObjCImplementationDecl>(D); 12968697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (!IC) 12978697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian return; 12988697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (ObjCInterfaceDecl* IDecl = IC->getClassInterface()) 12998697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian DefaultSynthesizeProperties(S, IC, IDecl); 13008697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian} 13018697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian 130217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanianvoid Sema::DiagnoseUnimplementedProperties(Scope *S, ObjCImplDecl* IMPDecl, 13039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl *CDecl, 13049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const llvm::DenseSet<Selector>& InsMap) { 1305cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 1306cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) 1307cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1308cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian 13099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 1310cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties(CDecl, PropMap, SuperPropMap); 13119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PropMap.empty()) 13129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 13139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseSet<ObjCPropertyDecl *> PropImplMap; 13159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCImplDecl::propimpl_iterator 13169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I = IMPDecl->propimpl_begin(), 13179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek EI = IMPDecl->propimpl_end(); I != EI; ++I) 13189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropImplMap.insert((*I)->getPropertyDecl()); 13199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 13219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 13229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = P->second; 13239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is there a matching propery synthesize/dynamic? 13249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->isInvalidDecl() || 13259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 1326327126ee3d2faad9314b2633974eefc672f73b79Fariborz Jahanian PropImplMap.count(Prop) || Prop->hasAttr<UnavailableAttr>()) 13279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 13289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!InsMap.count(Prop->getGetterName())) { 1329b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(IMPDecl->getLocation(), 13309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 13319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 13329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 13339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getGetterName(); 1334b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(Prop->getLocation(), 1335b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian diag::note_property_declare); 13369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!Prop->isReadOnly() && !InsMap.count(Prop->getSetterName())) { 1339b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(IMPDecl->getLocation(), 13409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 13419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 13429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 13439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getSetterName(); 1344b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(Prop->getLocation(), 1345b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian diag::note_property_declare); 13469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 13499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 13519d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::AtomicPropertySetterGetterRules (ObjCImplDecl* IMPDecl, 13529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl* IDecl) { 13539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Rules apply in non-GC mode only 13549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (getLangOptions().getGCMode() != LangOptions::NonGC) 13559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 13569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator I = IDecl->prop_begin(), 13579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); 13589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I != E; ++I) { 13599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Property = (*I); 136094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *GetterMethod = 0; 136194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *SetterMethod = 0; 136294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis bool LookedUpGetterSetter = false; 136394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 13649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned Attributes = Property->getPropertyAttributes(); 136594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis unsigned AttributesAsWrittern = Property->getPropertyAttributesAsWritten(); 136694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 136745937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian if (!(AttributesAsWrittern & ObjCPropertyDecl::OBJC_PR_atomic) && 136845937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian !(AttributesAsWrittern & ObjCPropertyDecl::OBJC_PR_nonatomic)) { 136994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 137094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 137194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 137294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (GetterMethod) { 137394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(GetterMethod->getLocation(), 137494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1375293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 0; 137694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 137794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 137894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (SetterMethod) { 137994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(SetterMethod->getLocation(), 138094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1381293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 1; 138294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 138394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 138494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 138594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 13869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // We only care about readwrite atomic property. 13879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCPropertyDecl::OBJC_PR_nonatomic) || 13889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek !(Attributes & ObjCPropertyDecl::OBJC_PR_readwrite)) 13899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 13909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCPropertyImplDecl *PIDecl 13919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek = IMPDecl->FindPropertyImplDecl(Property->getIdentifier())) { 13929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic) 13939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 139494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (!LookedUpGetterSetter) { 139594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 139694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 139794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 139894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 13999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((GetterMethod && !SetterMethod) || (!GetterMethod && SetterMethod)) { 14009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation MethodLoc = 14019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (GetterMethod ? GetterMethod->getLocation() 14029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek : SetterMethod->getLocation()); 14039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(MethodLoc, diag::warn_atomic_property_rule) 14049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getIdentifier(); 14059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::note_property_declare); 14069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 14109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1411f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::DiagnoseOwningPropertyGetterSynthesis(const ObjCImplementationDecl *D) { 1412f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().getGCMode() == LangOptions::GCOnly) 1413f85e193739c953358c865005855253af4f68a497John McCall return; 1414f85e193739c953358c865005855253af4f68a497John McCall 1415f85e193739c953358c865005855253af4f68a497John McCall for (ObjCImplementationDecl::propimpl_iterator 1416f85e193739c953358c865005855253af4f68a497John McCall i = D->propimpl_begin(), e = D->propimpl_end(); i != e; ++i) { 1417f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyImplDecl *PID = *i; 1418f85e193739c953358c865005855253af4f68a497John McCall if (PID->getPropertyImplementation() != ObjCPropertyImplDecl::Synthesize) 1419f85e193739c953358c865005855253af4f68a497John McCall continue; 1420f85e193739c953358c865005855253af4f68a497John McCall 1421f85e193739c953358c865005855253af4f68a497John McCall const ObjCPropertyDecl *PD = PID->getPropertyDecl(); 1422831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (PD && !PD->hasAttr<NSReturnsNotRetainedAttr>() && 1423831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !D->getInstanceMethod(PD->getGetterName())) { 1424f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodDecl *method = PD->getGetterMethodDecl(); 1425f85e193739c953358c865005855253af4f68a497John McCall if (!method) 1426f85e193739c953358c865005855253af4f68a497John McCall continue; 1427f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodFamily family = method->getMethodFamily(); 1428f85e193739c953358c865005855253af4f68a497John McCall if (family == OMF_alloc || family == OMF_copy || 1429f85e193739c953358c865005855253af4f68a497John McCall family == OMF_mutableCopy || family == OMF_new) { 1430f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 1431f85e193739c953358c865005855253af4f68a497John McCall Diag(PID->getLocation(), diag::err_ownin_getter_rule); 1432f85e193739c953358c865005855253af4f68a497John McCall else 1433f85e193739c953358c865005855253af4f68a497John McCall Diag(PID->getLocation(), diag::warn_ownin_getter_rule); 1434f85e193739c953358c865005855253af4f68a497John McCall Diag(PD->getLocation(), diag::note_property_declare); 1435f85e193739c953358c865005855253af4f68a497John McCall } 1436f85e193739c953358c865005855253af4f68a497John McCall } 1437f85e193739c953358c865005855253af4f68a497John McCall } 1438f85e193739c953358c865005855253af4f68a497John McCall} 1439f85e193739c953358c865005855253af4f68a497John McCall 14405de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// AddPropertyAttrs - Propagates attributes from a property to the 14415de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// implicitly-declared getter or setter for that property. 14425de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCallstatic void AddPropertyAttrs(Sema &S, ObjCMethodDecl *PropertyMethod, 14435de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall ObjCPropertyDecl *Property) { 14445de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall // Should we just clone all attributes over? 14450a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor for (Decl::attr_iterator A = Property->attr_begin(), 14460a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor AEnd = Property->attr_end(); 14470a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor A != AEnd; ++A) { 14480a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor if (isa<DeprecatedAttr>(*A) || 14490a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<UnavailableAttr>(*A) || 14500a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<AvailabilityAttr>(*A)) 14510a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor PropertyMethod->addAttr((*A)->clone(S.Context)); 14520a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor } 14535de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall} 14545de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 14559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ProcessPropertyDecl - Make sure that any user-defined setter/getter methods 14569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// have the property type and issue diagnostics if they don't. 14579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// Also synthesize a getter/setter method if none exist (and update the 14589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// appropriate lookup tables. FIXME: Should reconsider if adding synthesized 14599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// methods is the "right" thing to do. 14609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ProcessPropertyDecl(ObjCPropertyDecl *property, 14618254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *CD, 14628254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCPropertyDecl *redeclaredProperty, 14638254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *lexicalDC) { 14648254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 14659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, *SetterMethod; 14669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod = CD->getInstanceMethod(property->getGetterName()); 14689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod = CD->getInstanceMethod(property->getSetterName()); 14699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyAccessorMismatch(property, GetterMethod, 14709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation()); 14719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) { 14739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 14749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getPropertyAttributes(); 14759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((!(CAttr & ObjCPropertyDecl::OBJC_PR_readonly)) && 14769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SetterMethod->getResultType()) != 14779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.VoidTy) 14789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::err_setter_type_void); 14799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod->param_size() != 1 || 14809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ((*SetterMethod->param_begin())->getType() != property->getType())) { 14819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(property->getLocation(), 14829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_accessor_property_type_mismatch) 14839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 14849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << SetterMethod->getSelector(); 14859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::note_declared_at); 14869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Synthesize getter/setter methods if none exist. 14909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default getter and if one not found, add one. 14919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: The synthesized property we set here is misleading. We almost always 14929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // synthesize these methods unless the user explicitly provided prototypes 14939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // (which is odd, but allowed). Sema should be typechecking that the 14949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // declarations jive in that situation (which it is not currently). 14959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!GetterMethod) { 14969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property getter name was found. 14979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a getter method and add it to the list of methods 14989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 1499a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek SourceLocation Loc = redeclaredProperty ? 1500a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek redeclaredProperty->getLocation() : 1501a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getLocation(); 1502a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek 1503a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek GetterMethod = ObjCMethodDecl::Create(Context, Loc, Loc, 1504a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getGetterName(), 150575cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis property->getType(), 0, CD, /*isInstance=*/true, 150675cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isVariadic=*/false, /*isSynthesized=*/true, 150775cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, /*isDefined=*/false, 15089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 15099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 15109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Optional : 15119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Required); 15129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(GetterMethod); 15135de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 15145de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, GetterMethod, property); 15155de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 151623173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 151723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 1518a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek if (lexicalDC) 151923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek GetterMethod->setLexicalDeclContext(lexicalDC); 1520831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>()) 1521831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian GetterMethod->addAttr( 1522831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian ::new (Context) NSReturnsNotRetainedAttr(Loc, Context)); 15239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 15249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared getter will be synthesize when @synthesize of 15259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 15269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->setSynthesized(true); 15279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setGetterMethodDecl(GetterMethod); 15289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 15299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Skip setter if property is read-only. 15309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!property->isReadOnly()) { 15319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default setter and if one not found, add one. 15329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SetterMethod) { 15339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property setter name was found. 15349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a setter method and add it to the list of methods 15359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 15368254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SourceLocation Loc = redeclaredProperty ? 15378254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek redeclaredProperty->getLocation() : 15388254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getLocation(); 15398254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 15408254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SetterMethod = 15418254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Create(Context, Loc, Loc, 15428254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getSetterName(), Context.VoidTy, 0, 154375cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis CD, /*isInstance=*/true, /*isVariadic=*/false, 154475cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isSynthesized=*/true, 154575cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, 154675cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isDefined=*/false, 15479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 15489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 15498254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Optional : 15508254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Required); 15518254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 15529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Invent the arguments for the setter. We don't bother making a 15539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // nice name for the argument. 1554ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara ParmVarDecl *Argument = ParmVarDecl::Create(Context, SetterMethod, 1555ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Loc, Loc, 15569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getIdentifier(), 1557f85e193739c953358c865005855253af4f68a497John McCall property->getType().getUnqualifiedType(), 15589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek /*TInfo=*/0, 1559d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 1560d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 15619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 0); 15624ecb25fa94897b2c03510292acace710e5262ba5Fariborz Jahanian SetterMethod->setMethodParams(Context, &Argument, 1, 1); 15635de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 15645de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, SetterMethod, property); 15655de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 15669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(SetterMethod); 156723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 156823173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 15698254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek if (lexicalDC) 157023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek SetterMethod->setLexicalDeclContext(lexicalDC); 15719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 15729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared setter will be synthesize when @synthesize of 15739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 15749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod->setSynthesized(true); 15759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setSetterMethodDecl(SetterMethod); 15769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Add any synthesized methods to the global pool. This allows us to 15789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // handle the following, which is supported by GCC (and part of the design). 15799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 15809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @interface Foo 15819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @property double bar; 15829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @end 15839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 15849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // void thisIsUnfortunate() { 15859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // id foo; 15869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // double bar = [foo bar]; 15879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // } 15889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 15899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod) 15909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(GetterMethod); 15919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) 15929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(SetterMethod); 15939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 15949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1595d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CheckObjCPropertyAttributes(Decl *PDecl, 15969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc, 15979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned &Attributes) { 15989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Improve the reported location. 1599f85e193739c953358c865005855253af4f68a497John McCall if (!PDecl || PDecl->isInvalidDecl()) 16005fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek return; 16015fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek 16025fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek ObjCPropertyDecl *PropertyDecl = cast<ObjCPropertyDecl>(PDecl); 1603842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian QualType PropertyTy = PropertyDecl->getType(); 16049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 16059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // readonly and readwrite/assign/retain/copy conflict. 16069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 160728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & (ObjCDeclSpec::DQ_PR_readwrite | 160828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_assign | 1609f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 161028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_copy | 1611f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | 1612f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_strong))) { 161328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek const char * which = (Attributes & ObjCDeclSpec::DQ_PR_readwrite) ? 161428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "readwrite" : 161528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 161628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "assign" : 1617f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) ? 1618f85e193739c953358c865005855253af4f68a497John McCall "unsafe_unretained" : 161928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 162028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "copy" : "retain"; 16219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 162228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, (Attributes & (ObjCDeclSpec::DQ_PR_readwrite)) ? 162328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::err_objc_property_attr_mutually_exclusive : 162428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::warn_objc_property_attr_mutually_exclusive) 162528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "readonly" << which; 162628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 16279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 162828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for copy or retain on non-object types. 1629f85e193739c953358c865005855253af4f68a497John McCall if ((Attributes & (ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 1630f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong)) && 1631f85e193739c953358c865005855253af4f68a497John McCall !PropertyTy->isObjCRetainableType() && 1632842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian !PropertyDecl->getAttr<ObjCNSObjectAttr>()) { 163328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_requires_object) 1634f85e193739c953358c865005855253af4f68a497John McCall << (Attributes & ObjCDeclSpec::DQ_PR_weak ? "weak" : 1635f85e193739c953358c865005855253af4f68a497John McCall Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain (or strong)"); 1636f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~(ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 1637f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong); 163828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 16399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 164028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for more than one of { assign, copy, retain }. 164128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_assign) { 164228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 164328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 164428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "copy"; 164528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 164628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 164728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 164828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 164928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "retain"; 165028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 165128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 1652f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 1653f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1654f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "strong"; 1655f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 1656f85e193739c953358c865005855253af4f68a497John McCall } 1657f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount && 1658f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1659f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1660f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "weak"; 1661f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1662f85e193739c953358c865005855253af4f68a497John McCall } 1663f85e193739c953358c865005855253af4f68a497John McCall } else if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) { 1664f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 1665f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1666f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "copy"; 1667f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 1668f85e193739c953358c865005855253af4f68a497John McCall } 1669f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 1670f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1671f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "retain"; 1672f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 1673f85e193739c953358c865005855253af4f68a497John McCall } 1674f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 1675f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1676f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "strong"; 1677f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 1678f85e193739c953358c865005855253af4f68a497John McCall } 1679f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount && 1680f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1681f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1682f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "weak"; 1683f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1684f85e193739c953358c865005855253af4f68a497John McCall } 168528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 168628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 168728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 168828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "copy" << "retain"; 168928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 169028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 1691f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 1692f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1693f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "strong"; 1694f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 1695f85e193739c953358c865005855253af4f68a497John McCall } 1696f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_weak) { 1697f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1698f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "weak"; 1699f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1700f85e193739c953358c865005855253af4f68a497John McCall } 1701f85e193739c953358c865005855253af4f68a497John McCall } 1702f85e193739c953358c865005855253af4f68a497John McCall else if ((Attributes & ObjCDeclSpec::DQ_PR_retain) && 1703f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1704f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1705f85e193739c953358c865005855253af4f68a497John McCall << "retain" << "weak"; 1706f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1707f85e193739c953358c865005855253af4f68a497John McCall } 1708f85e193739c953358c865005855253af4f68a497John McCall else if ((Attributes & ObjCDeclSpec::DQ_PR_strong) && 1709f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1710f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1711f85e193739c953358c865005855253af4f68a497John McCall << "strong" << "weak"; 1712f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 171328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 17149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 171528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Warn if user supplied no assignment attribute, property is 171628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // readwrite, and this is an object type. 171728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy | 1718f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 1719f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong | 1720f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_weak)) && 172128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly) && 172228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyTy->isObjCObjectPointerType()) { 1723bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian if (getLangOptions().ObjCAutoRefCount) 1724bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // With arc, @property definitions should default to (strong) when 1725bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // not specified 1726bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian PropertyDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 1727bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian else { 1728bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // Skip this warning in gc-only mode. 1729bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian if (getLangOptions().getGCMode() != LangOptions::GCOnly) 1730bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_no_assignment_attribute); 17310a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 1732bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // If non-gc code warn that this is likely inappropriate. 1733bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian if (getLangOptions().getGCMode() == LangOptions::NonGC) 1734bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_default_assign_on_object); 1735bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian } 17369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 173728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME: Implement warning dependent on NSCopying being 173828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // implemented. See also: 173928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496> 174028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // (please trim this list while you are at it). 174128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 17429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 174328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & ObjCDeclSpec::DQ_PR_copy) 17442b77cb803c76d01d2d10a58cec9334e2090cd7c3Fariborz Jahanian &&!(Attributes & ObjCDeclSpec::DQ_PR_readonly) 174528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && getLangOptions().getGCMode() == LangOptions::GCOnly 174628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && PropertyTy->isBlockPointerType()) 174728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_copy_missing_on_block); 17489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 1749