SemaObjCProperty.cpp revision f21a92d35953adb038ffbe37cd1a4083e0df0ec0
19d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===--- SemaObjCProperty.cpp - Semantic Analysis for ObjC @property ------===// 29d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 39d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// The LLVM Compiler Infrastructure 49d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 59d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file is distributed under the University of Illinois Open Source 69d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// License. See LICENSE.TXT for details. 79d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 89d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 99d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file implements semantic analysis for Objective C @property and 119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// @synthesize declarations. 129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Initialization.h" 177cd088e519d7e6caa4c4c12db52e0e4ae35d25c2John McCall#include "clang/AST/DeclObjC.h" 1817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian#include "clang/AST/ExprObjC.h" 1957e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian#include "clang/AST/ExprCXX.h" 2050df6ae41f232612e5e88b19e0db9900d08d2f6cJohn McCall#include "llvm/ADT/DenseSet.h" 219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekusing namespace clang; 239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Grammar actions. 2628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 28265941bc308d65cc270d5c4de5806f37ce405606John McCall/// getImpliedARCOwnership - Given a set of property attributes and a 29265941bc308d65cc270d5c4de5806f37ce405606John McCall/// type, infer an expected lifetime. The type's ownership qualification 30265941bc308d65cc270d5c4de5806f37ce405606John McCall/// is not considered. 31265941bc308d65cc270d5c4de5806f37ce405606John McCall/// 32265941bc308d65cc270d5c4de5806f37ce405606John McCall/// Returns OCL_None if the attributes as stated do not imply an ownership. 33265941bc308d65cc270d5c4de5806f37ce405606John McCall/// Never returns OCL_Autoreleasing. 34265941bc308d65cc270d5c4de5806f37ce405606John McCallstatic Qualifiers::ObjCLifetime getImpliedARCOwnership( 35265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::PropertyAttributeKind attrs, 36265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType type) { 37265941bc308d65cc270d5c4de5806f37ce405606John McCall // retain, strong, copy, weak, and unsafe_unretained are only legal 38265941bc308d65cc270d5c4de5806f37ce405606John McCall // on properties of retainable pointer type. 39265941bc308d65cc270d5c4de5806f37ce405606John McCall if (attrs & (ObjCPropertyDecl::OBJC_PR_retain | 40265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::OBJC_PR_strong | 41265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::OBJC_PR_copy)) { 425fa065b55bd622f20656e0de3b1f122951146784Fariborz Jahanian return type->getObjCARCImplicitLifetime(); 43265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (attrs & ObjCPropertyDecl::OBJC_PR_weak) { 44265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_Weak; 45265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (attrs & ObjCPropertyDecl::OBJC_PR_unsafe_unretained) { 46265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_ExplicitNone; 47265941bc308d65cc270d5c4de5806f37ce405606John McCall } 48265941bc308d65cc270d5c4de5806f37ce405606John McCall 49265941bc308d65cc270d5c4de5806f37ce405606John McCall // assign can appear on other types, so we have to check the 50265941bc308d65cc270d5c4de5806f37ce405606John McCall // property type. 51265941bc308d65cc270d5c4de5806f37ce405606John McCall if (attrs & ObjCPropertyDecl::OBJC_PR_assign && 52265941bc308d65cc270d5c4de5806f37ce405606John McCall type->isObjCRetainableType()) { 53265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_ExplicitNone; 54265941bc308d65cc270d5c4de5806f37ce405606John McCall } 55265941bc308d65cc270d5c4de5806f37ce405606John McCall 56265941bc308d65cc270d5c4de5806f37ce405606John McCall return Qualifiers::OCL_None; 57265941bc308d65cc270d5c4de5806f37ce405606John McCall} 58265941bc308d65cc270d5c4de5806f37ce405606John McCall 59f85e193739c953358c865005855253af4f68a497John McCall/// Check the internal consistency of a property declaration. 60f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyDecl(Sema &S, ObjCPropertyDecl *property) { 61f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl()) return; 62f85e193739c953358c865005855253af4f68a497John McCall 63f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind propertyKind 64f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 65f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime propertyLifetime 66f85e193739c953358c865005855253af4f68a497John McCall = property->getType().getObjCLifetime(); 67f85e193739c953358c865005855253af4f68a497John McCall 68f85e193739c953358c865005855253af4f68a497John McCall // Nothing to do if we don't have a lifetime. 69f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == Qualifiers::OCL_None) return; 70f85e193739c953358c865005855253af4f68a497John McCall 71265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime expectedLifetime 72265941bc308d65cc270d5c4de5806f37ce405606John McCall = getImpliedARCOwnership(propertyKind, property->getType()); 73265941bc308d65cc270d5c4de5806f37ce405606John McCall if (!expectedLifetime) { 74f85e193739c953358c865005855253af4f68a497John McCall // We have a lifetime qualifier but no dominating property 75265941bc308d65cc270d5c4de5806f37ce405606John McCall // attribute. That's okay, but restore reasonable invariants by 76265941bc308d65cc270d5c4de5806f37ce405606John McCall // setting the property attribute according to the lifetime 77265941bc308d65cc270d5c4de5806f37ce405606John McCall // qualifier. 78265941bc308d65cc270d5c4de5806f37ce405606John McCall ObjCPropertyDecl::PropertyAttributeKind attr; 79265941bc308d65cc270d5c4de5806f37ce405606John McCall if (propertyLifetime == Qualifiers::OCL_Strong) { 80265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_strong; 81265941bc308d65cc270d5c4de5806f37ce405606John McCall } else if (propertyLifetime == Qualifiers::OCL_Weak) { 82265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_weak; 83265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 84265941bc308d65cc270d5c4de5806f37ce405606John McCall assert(propertyLifetime == Qualifiers::OCL_ExplicitNone); 85265941bc308d65cc270d5c4de5806f37ce405606John McCall attr = ObjCPropertyDecl::OBJC_PR_unsafe_unretained; 86265941bc308d65cc270d5c4de5806f37ce405606John McCall } 87265941bc308d65cc270d5c4de5806f37ce405606John McCall property->setPropertyAttributes(attr); 88f85e193739c953358c865005855253af4f68a497John McCall return; 89f85e193739c953358c865005855253af4f68a497John McCall } 90f85e193739c953358c865005855253af4f68a497John McCall 91f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == expectedLifetime) return; 92f85e193739c953358c865005855253af4f68a497John McCall 93f85e193739c953358c865005855253af4f68a497John McCall property->setInvalidDecl(); 94f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), 95b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis diag::err_arc_inconsistent_property_ownership) 96f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 97265941bc308d65cc270d5c4de5806f37ce405606John McCall << expectedLifetime 98f85e193739c953358c865005855253af4f68a497John McCall << propertyLifetime; 99f85e193739c953358c865005855253af4f68a497John McCall} 100f85e193739c953358c865005855253af4f68a497John McCall 101d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnProperty(Scope *S, SourceLocation AtLoc, 102d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall FieldDeclarator &FD, 103d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall ObjCDeclSpec &ODS, 104d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector GetterSel, 105d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector SetterSel, 106d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool *isOverridingProperty, 1074a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek tok::ObjCKeywordKind MethodImplKind, 1084a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek DeclContext *lexicalDC) { 10928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek unsigned Attributes = ODS.getPropertyAttributes(); 110f85e193739c953358c865005855253af4f68a497John McCall TypeSourceInfo *TSI = GetTypeForDeclarator(FD.D, S); 111f85e193739c953358c865005855253af4f68a497John McCall QualType T = TSI->getType(); 112e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor if ((getLangOptions().getGC() != LangOptions::NonGC && 113f85e193739c953358c865005855253af4f68a497John McCall T.isObjCGCWeak()) || 114f85e193739c953358c865005855253af4f68a497John McCall (getLangOptions().ObjCAutoRefCount && 115f85e193739c953358c865005855253af4f68a497John McCall T.getObjCLifetime() == Qualifiers::OCL_Weak)) 116f85e193739c953358c865005855253af4f68a497John McCall Attributes |= ObjCDeclSpec::DQ_PR_weak; 117f85e193739c953358c865005855253af4f68a497John McCall 11828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isReadWrite = ((Attributes & ObjCDeclSpec::DQ_PR_readwrite) || 11928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // default is readwrite! 12028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly)); 12128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // property is defaulted to 'assign' if it is readwrite and is 12228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // not retain or copy 12328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isAssign = ((Attributes & ObjCDeclSpec::DQ_PR_assign) || 12428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (isReadWrite && 12528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_retain) && 126f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_strong) && 127f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_copy) && 128f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) && 129f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_weak))); 13014086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian 131e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Proceed with constructing the ObjCPropertDecls. 132a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian ObjCContainerDecl *ClassDecl = cast<ObjCContainerDecl>(CurContext); 133e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 13428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) 135ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian if (CDecl->IsClassExtension()) { 136a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian Decl *Res = HandlePropertyInClassExtension(S, AtLoc, 137ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian FD, GetterSel, SetterSel, 138ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isAssign, isReadWrite, 139ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian Attributes, 140dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis ODS.getPropertyAttributes(), 141ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isOverridingProperty, TSI, 142ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian MethodImplKind); 143f85e193739c953358c865005855253af4f68a497John McCall if (Res) { 144ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes); 145f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 146f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, cast<ObjCPropertyDecl>(Res)); 147f85e193739c953358c865005855253af4f68a497John McCall } 148ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian return Res; 149ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian } 150ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian 151f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *Res = CreatePropertyDecl(S, ClassDecl, AtLoc, FD, 152f85e193739c953358c865005855253af4f68a497John McCall GetterSel, SetterSel, 153f85e193739c953358c865005855253af4f68a497John McCall isAssign, isReadWrite, 154dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis Attributes, 155dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis ODS.getPropertyAttributes(), 156dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis TSI, MethodImplKind); 1574a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek if (lexicalDC) 1584a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek Res->setLexicalDeclContext(lexicalDC); 1594a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek 160842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian // Validate the attributes on the @property. 161842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes); 162f85e193739c953358c865005855253af4f68a497John McCall 163f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 164f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, Res); 165f85e193739c953358c865005855253af4f68a497John McCall 166842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian return Res; 167e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 168e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 169b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidisstatic ObjCPropertyDecl::PropertyAttributeKind 170b98ffded10453d80369951f33f3892f35d747c95Argyrios KyrtzidismakePropertyAttributesAsWritten(unsigned Attributes) { 171b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis unsigned attributesAsWritten = 0; 172b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 173b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readonly; 174b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 175b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_readwrite; 176b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_getter) 177b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_getter; 178b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_setter) 179b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_setter; 180b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_assign) 181b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_assign; 182b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_retain) 183b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_retain; 184b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_strong) 185b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_strong; 186b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_weak) 187b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_weak; 188b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_copy) 189b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_copy; 190b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 191b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_unsafe_unretained; 192b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 193b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_nonatomic; 194b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis if (Attributes & ObjCDeclSpec::DQ_PR_atomic) 195b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis attributesAsWritten |= ObjCPropertyDecl::OBJC_PR_atomic; 196b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis 197b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis return (ObjCPropertyDecl::PropertyAttributeKind)attributesAsWritten; 198b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis} 199b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis 200d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl * 201a28948f34817476d02412fa204cae038e228c827Fariborz JahanianSema::HandlePropertyInClassExtension(Scope *S, 202e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, FieldDeclarator &FD, 203e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, Selector SetterSel, 204e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 205e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 206e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 207dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis const unsigned AttributesAsWritten, 208e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek bool *isOverridingProperty, 20983a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *T, 210e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek tok::ObjCKeywordKind MethodImplKind) { 21158a764940df0cd41767367eb2f4fced6f374176bFariborz Jahanian ObjCCategoryDecl *CDecl = cast<ObjCCategoryDecl>(CurContext); 212e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Diagnose if this property is already in continuation class. 213a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian DeclContext *DC = CurContext; 214e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 2152a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCInterfaceDecl *CCPrimary = CDecl->getClassInterface(); 2162a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 2172a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian if (CCPrimary) 2182a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // Check for duplicate declaration of this property in current and 2192a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // other class extensions. 2202a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian for (const ObjCCategoryDecl *ClsExtDecl = 2212a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian CCPrimary->getFirstClassExtension(); 2222a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ClsExtDecl; ClsExtDecl = ClsExtDecl->getNextClassExtension()) { 2232a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian if (ObjCPropertyDecl *prevDecl = 2242a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCPropertyDecl::findPropertyDecl(ClsExtDecl, PropertyId)) { 2252a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(AtLoc, diag::err_duplicate_property); 2262a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(prevDecl->getLocation(), diag::note_property_declare); 2272a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian return 0; 2282a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 2292a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 2302a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 231e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Create a new ObjCPropertyDecl with the DeclContext being 232e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // the class extension. 23388f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // FIXME. We should really be using CreatePropertyDecl for this. 234e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 235e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::Create(Context, DC, FD.D.getIdentifierLoc(), 236e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PropertyId, AtLoc, T); 237b98ffded10453d80369951f33f3892f35d747c95Argyrios Kyrtzidis PDecl->setPropertyAttributesAsWritten( 238dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis makePropertyAttributesAsWritten(AttributesAsWritten)); 23922f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 24022f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 24122f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 24222f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 24388f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // Set setter/getter selector name. Needed later. 24488f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setGetterName(GetterSel); 24588f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setSetterName(SetterSel); 24691ae6b43b3a294243698cdb544dd7a18efa4c7a8Douglas Gregor ProcessDeclAttributes(S, PDecl, FD.D); 247e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DC->addDecl(PDecl); 248e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 249e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // We need to look in the @interface to see if the @property was 250e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // already declared. 251e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!CCPrimary) { 252e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(CDecl->getLocation(), diag::err_continuation_class); 253e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 254d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 255e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 256e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 257e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Find the property in continuation class's primary class only. 258e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PIDecl = 259e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CCPrimary->FindPropertyVisibleInPrimaryClass(PropertyId); 260e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 261e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!PIDecl) { 262e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // No matching property found in the primary class. Just fall thru 263e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and add property to continuation class's primary class. 264e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 265e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CreatePropertyDecl(S, CCPrimary, AtLoc, 266e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FD, GetterSel, SetterSel, isAssign, isReadWrite, 267dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis Attributes,AttributesAsWritten, T, MethodImplKind, DC); 268e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 269e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // A case of continuation class adding a new property in the class. This 270e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // is not what it was meant for. However, gcc supports it and so should we. 271e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter/getters are declared here. 272a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek ProcessPropertyDecl(PDecl, CCPrimary, /* redeclaredProperty = */ 0, 273a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek /* lexicalDC = */ CDecl); 274d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PDecl; 275e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 276a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian if (PIDecl->getType().getCanonicalType() 277a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian != PDecl->getType().getCanonicalType()) { 278a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian Diag(AtLoc, 27968af536046461b514b59aedac016b52784ece3f7Fariborz Jahanian diag::warn_type_mismatch_continuation_class) << PDecl->getType(); 280a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian Diag(PIDecl->getLocation(), diag::note_property_declare); 281a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian } 282a4b984d8396724a8e1137c22186c558c0cb0bf3fFariborz Jahanian 283e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // The property 'PIDecl's readonly attribute will be over-ridden 284e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // with continuation class's readwrite property attribute! 28580aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian unsigned PIkind = PIDecl->getPropertyAttributesAsWritten(); 286e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (isReadWrite && (PIkind & ObjCPropertyDecl::OBJC_PR_readonly)) { 287e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek unsigned retainCopyNonatomic = 288e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (ObjCPropertyDecl::OBJC_PR_retain | 289f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_strong | 290e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_copy | 291e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_nonatomic); 292e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if ((Attributes & retainCopyNonatomic) != 293e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (PIkind & retainCopyNonatomic)) { 294e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::warn_property_attr_mismatch); 295e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 296e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 2979944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek DeclContext *DC = cast<DeclContext>(CCPrimary); 2989944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek if (!ObjCPropertyDecl::findPropertyDecl(DC, 2999944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek PIDecl->getDeclName().getAsIdentifierInfo())) { 300e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Protocol is not in the primary class. Must build one for it. 301e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCDeclSpec ProtocolPropertyODS; 302e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // FIXME. Assuming that ObjCDeclSpec::ObjCPropertyAttributeKind 303e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and ObjCPropertyDecl::PropertyAttributeKind have identical 304e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // values. Should consolidate both into one enum type. 305e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProtocolPropertyODS. 306e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek setPropertyAttributes((ObjCDeclSpec::ObjCPropertyAttributeKind) 307e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIkind); 308a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // Must re-establish the context from class extension to primary 309a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian // class context. 3107939418cbdf1b610a69e6adf29cd7dc8d0e9eaf8Fariborz Jahanian ContextRAII SavedContext(*this, CCPrimary); 3117939418cbdf1b610a69e6adf29cd7dc8d0e9eaf8Fariborz Jahanian 312d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ProtocolPtrTy = 313e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ActOnProperty(S, AtLoc, FD, ProtocolPropertyODS, 314e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getGetterName(), 315e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getSetterName(), 316a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian isOverridingProperty, 3174a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek MethodImplKind, 3184a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek /* lexicalDC = */ CDecl); 319d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall PIDecl = cast<ObjCPropertyDecl>(ProtocolPtrTy); 32028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 321e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->makeitReadWriteAttribute(); 322e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 323e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 324f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) 325f85e193739c953358c865005855253af4f68a497John McCall PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 326e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 327e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 328e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setSetterName(SetterSel); 329e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } else { 330788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // Tailor the diagnostics for the common case where a readwrite 331788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // property is declared both in the @interface and the continuation. 332788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // This is a common error where the user often intended the original 333788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // declaration to be readonly. 334788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek unsigned diag = 335788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_readwrite) && 336788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (PIkind & ObjCPropertyDecl::OBJC_PR_readwrite) 337788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek ? diag::err_use_continuation_class_redeclaration_readwrite 338788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek : diag::err_use_continuation_class; 339788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek Diag(AtLoc, diag) 340e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek << CCPrimary->getDeclName(); 341e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 342e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 343e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 344e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter decl is synthesized, and added to primary class's list. 3458254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ProcessPropertyDecl(PIDecl, CCPrimary, PDecl, CDecl); 346d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 347e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 348e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 349e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekObjCPropertyDecl *Sema::CreatePropertyDecl(Scope *S, 350e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *CDecl, 351e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, 352e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FieldDeclarator &FD, 353e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, 354e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector SetterSel, 355e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 356e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 357e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 358dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis const unsigned AttributesAsWritten, 35983a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *TInfo, 36023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek tok::ObjCKeywordKind MethodImplKind, 36123173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek DeclContext *lexicalDC){ 362e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 36383a230c83a54190366138c1a4f4310ef838b88fcJohn McCall QualType T = TInfo->getType(); 36428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 36528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Issue a warning if property is 'assign' as default and its object, which is 36628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // gc'able conforms to NSCopying protocol 367e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor if (getLangOptions().getGC() != LangOptions::NonGC && 36828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek isAssign && !(Attributes & ObjCDeclSpec::DQ_PR_assign)) 369c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (const ObjCObjectPointerType *ObjPtrTy = 370c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall T->getAs<ObjCObjectPointerType>()) { 371c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall ObjCInterfaceDecl *IDecl = ObjPtrTy->getObjectType()->getInterface(); 372c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl) 373c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (ObjCProtocolDecl* PNSCopying = 374c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall LookupProtocol(&Context.Idents.get("NSCopying"), AtLoc)) 375c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl->ClassImplementsProtocol(PNSCopying, true)) 376c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall Diag(AtLoc, diag::warn_implements_nscopying) << PropertyId; 37728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 378c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (T->isObjCObjectType()) 37928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(FD.D.getIdentifierLoc(), diag::err_statically_allocated_object); 38028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 381e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 38228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC, 38328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek FD.D.getIdentifierLoc(), 38483a230c83a54190366138c1a4f4310ef838b88fcJohn McCall PropertyId, AtLoc, TInfo); 385e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 3869f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek if (ObjCPropertyDecl *prevDecl = 3879f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) { 38828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PDecl->getLocation(), diag::err_duplicate_property); 389894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek Diag(prevDecl->getLocation(), diag::note_property_declare); 39028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 39128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 39223173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek else { 39328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek DC->addDecl(PDecl); 39423173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek if (lexicalDC) 39523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek PDecl->setLexicalDeclContext(lexicalDC); 39623173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek } 39728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 39828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isArrayType() || T->isFunctionType()) { 39928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::err_property_type) << T; 40028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 40128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 40228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 40328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ProcessDeclAttributes(S, PDecl, FD.D); 40428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 40528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Regardless of setter/getter attribute, we save the default getter/setter 40628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // selector names in anticipation of declaration of setter/getter methods. 40728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setGetterName(GetterSel); 40828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setSetterName(SetterSel); 4090a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis PDecl->setPropertyAttributesAsWritten( 410dbbdec994f5a96b5c25aaa679cd86ecabf545f7bArgyrios Kyrtzidis makePropertyAttributesAsWritten(AttributesAsWritten)); 4110a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 41228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 41328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 41428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 41528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_getter) 41628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter); 41728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 41828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_setter) 41928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter); 42028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 42128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isReadWrite) 42228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 42328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 42428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 42528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 42628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 427f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) 428f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 429f85e193739c953358c865005855253af4f68a497John McCall 430f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_weak) 431f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_weak); 432f85e193739c953358c865005855253af4f68a497John McCall 43328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 43428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 43528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 436f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 437f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 438f85e193739c953358c865005855253af4f68a497John McCall 43928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isAssign) 44028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 44128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 442265941bc308d65cc270d5c4de5806f37ce405606John McCall // In the semantic attributes, one of nonatomic or atomic is always set. 44328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 44428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 445265941bc308d65cc270d5c4de5806f37ce405606John McCall else 44645937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_atomic); 44728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 448f85e193739c953358c865005855253af4f68a497John McCall // 'unsafe_unretained' is alias for 'assign'. 449f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 450f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 451f85e193739c953358c865005855253af4f68a497John McCall if (isAssign) 452f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 453f85e193739c953358c865005855253af4f68a497John McCall 45428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (MethodImplKind == tok::objc_required) 45528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Required); 45628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek else if (MethodImplKind == tok::objc_optional) 45728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional); 45828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 459e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return PDecl; 46028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 46128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 462f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyImpl(Sema &S, SourceLocation propertyImplLoc, 463f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *property, 464f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar) { 465f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl() || ivar->isInvalidDecl()) return; 466f85e193739c953358c865005855253af4f68a497John McCall 467f85e193739c953358c865005855253af4f68a497John McCall QualType ivarType = ivar->getType(); 468f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime ivarLifetime = ivarType.getObjCLifetime(); 469f85e193739c953358c865005855253af4f68a497John McCall 470265941bc308d65cc270d5c4de5806f37ce405606John McCall // The lifetime implied by the property's attributes. 471265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime propertyLifetime = 472265941bc308d65cc270d5c4de5806f37ce405606John McCall getImpliedARCOwnership(property->getPropertyAttributes(), 473265941bc308d65cc270d5c4de5806f37ce405606John McCall property->getType()); 474f85e193739c953358c865005855253af4f68a497John McCall 475265941bc308d65cc270d5c4de5806f37ce405606John McCall // We're fine if they match. 476265941bc308d65cc270d5c4de5806f37ce405606John McCall if (propertyLifetime == ivarLifetime) return; 477f85e193739c953358c865005855253af4f68a497John McCall 478265941bc308d65cc270d5c4de5806f37ce405606John McCall // These aren't valid lifetimes for object ivars; don't diagnose twice. 479265941bc308d65cc270d5c4de5806f37ce405606John McCall if (ivarLifetime == Qualifiers::OCL_None || 480265941bc308d65cc270d5c4de5806f37ce405606John McCall ivarLifetime == Qualifiers::OCL_Autoreleasing) 481265941bc308d65cc270d5c4de5806f37ce405606John McCall return; 482265941bc308d65cc270d5c4de5806f37ce405606John McCall 483265941bc308d65cc270d5c4de5806f37ce405606John McCall switch (propertyLifetime) { 484265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Strong: 485265941bc308d65cc270d5c4de5806f37ce405606John McCall S.Diag(propertyImplLoc, diag::err_arc_strong_property_ownership) 486265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 487265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName() 488265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivarLifetime; 489265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 490265941bc308d65cc270d5c4de5806f37ce405606John McCall 491265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Weak: 492265941bc308d65cc270d5c4de5806f37ce405606John McCall S.Diag(propertyImplLoc, diag::error_weak_property) 493265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 494265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName(); 495265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 496265941bc308d65cc270d5c4de5806f37ce405606John McCall 497265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_ExplicitNone: 498265941bc308d65cc270d5c4de5806f37ce405606John McCall S.Diag(propertyImplLoc, diag::err_arc_assign_property_ownership) 499265941bc308d65cc270d5c4de5806f37ce405606John McCall << property->getDeclName() 500265941bc308d65cc270d5c4de5806f37ce405606John McCall << ivar->getDeclName() 501265941bc308d65cc270d5c4de5806f37ce405606John McCall << ((property->getPropertyAttributesAsWritten() 502265941bc308d65cc270d5c4de5806f37ce405606John McCall & ObjCPropertyDecl::OBJC_PR_assign) != 0); 503265941bc308d65cc270d5c4de5806f37ce405606John McCall break; 504265941bc308d65cc270d5c4de5806f37ce405606John McCall 505265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_Autoreleasing: 506265941bc308d65cc270d5c4de5806f37ce405606John McCall llvm_unreachable("properties cannot be autoreleasing"); 507265941bc308d65cc270d5c4de5806f37ce405606John McCall 508265941bc308d65cc270d5c4de5806f37ce405606John McCall case Qualifiers::OCL_None: 509265941bc308d65cc270d5c4de5806f37ce405606John McCall // Any other property should be ignored. 510f85e193739c953358c865005855253af4f68a497John McCall return; 511f85e193739c953358c865005855253af4f68a497John McCall } 512f85e193739c953358c865005855253af4f68a497John McCall 513f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), diag::note_property_declare); 514f85e193739c953358c865005855253af4f68a497John McCall} 515f85e193739c953358c865005855253af4f68a497John McCall 51628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 51728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// ActOnPropertyImplDecl - This routine performs semantic checks and 51828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// builds the AST node for a property implementation declaration; declared 51928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// as @synthesize or @dynamic. 52028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// 521d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnPropertyImplDecl(Scope *S, 522d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation AtLoc, 523d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation PropertyLoc, 524d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool Synthesize, 525d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall IdentifierInfo *PropertyId, 526a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor IdentifierInfo *PropertyIvar, 527a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor SourceLocation PropertyIvarLoc) { 528e9686572f17968048a5e097254f85c202ea44aecTed Kremenek ObjCContainerDecl *ClassImpDecl = 52984e0ccff7a6e51d7b81fd58686b493a4880dd44dFariborz Jahanian dyn_cast<ObjCContainerDecl>(CurContext); 53028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Make sure we have a context for the property implementation declaration. 53128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!ClassImpDecl) { 53228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_context); 533d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 53428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 53528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *property = 0; 53628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl* IDecl = 0; 53728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Find the class or category class where this property must have 53828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a declaration. 53928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCImplementationDecl *IC = 0; 54028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryImplDecl* CatImplClass = 0; 54128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) { 54228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = IC->getClassInterface(); 54328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // We always synthesize an interface for an implementation 54428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // without an interface decl. So, IDecl is always non-zero. 54528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert(IDecl && 54628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "ActOnPropertyImplDecl - @implementation without @interface"); 54728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 54828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in the @implementation's @interface 54928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = IDecl->FindPropertyDeclaration(PropertyId); 55028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 55128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_property_decl) << IDecl->getDeclName(); 552d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 55328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 554dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian unsigned PIkind = property->getPropertyAttributesAsWritten(); 55545937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian if ((PIkind & (ObjCPropertyDecl::OBJC_PR_atomic | 55645937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_nonatomic) ) == 0) { 557dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian if (AtLoc.isValid()) 558dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(AtLoc, diag::warn_implicit_atomic_property); 559dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian else 560dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(IC->getLocation(), diag::warn_auto_implicit_atomic_property); 561dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 562dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian } 563dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian 56428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (const ObjCCategoryDecl *CD = 56528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek dyn_cast<ObjCCategoryDecl>(property->getDeclContext())) { 56628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!CD->IsClassExtension()) { 56728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_category_property) << CD->getDeclName(); 56828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(property->getLocation(), diag::note_property_declare); 569d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 57028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 57128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 57228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) { 57328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 57428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_synthesize_category_decl); 575d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 57628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 57728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = CatImplClass->getClassInterface(); 57828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!IDecl) { 57928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_interface); 580d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 58128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 58228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryDecl *Category = 58328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier()); 58428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 58528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // If category for this implementation not found, it is an error which 58628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // has already been reported eralier. 58728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Category) 588d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 58928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in @implementation's category 59028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = Category->FindPropertyDeclaration(PropertyId); 59128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 59228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_category_property_decl) 59328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << Category->getDeclName(); 594d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 59528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 59628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 59728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_bad_property_context); 598d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 59928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 60028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCIvarDecl *Ivar = 0; 60128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that we have a valid, previously declared ivar for @synthesize 60228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 60328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @synthesize 60428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!PropertyIvar) 60528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyIvar = PropertyId; 606f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind kind 607f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 608265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType PropType = property->getType(); 609265941bc308d65cc270d5c4de5806f37ce405606John McCall 610265941bc308d65cc270d5c4de5806f37ce405606John McCall QualType PropertyIvarType = PropType.getNonReferenceType(); 611265941bc308d65cc270d5c4de5806f37ce405606John McCall 612265941bc308d65cc270d5c4de5806f37ce405606John McCall // Add GC __weak to the ivar type if the property is weak. 613265941bc308d65cc270d5c4de5806f37ce405606John McCall if ((kind & ObjCPropertyDecl::OBJC_PR_weak) && 614e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor getLangOptions().getGC() != LangOptions::NonGC) { 615265941bc308d65cc270d5c4de5806f37ce405606John McCall assert(!getLangOptions().ObjCAutoRefCount); 616265941bc308d65cc270d5c4de5806f37ce405606John McCall if (PropertyIvarType.isObjCGCStrong()) { 617265941bc308d65cc270d5c4de5806f37ce405606John McCall Diag(PropertyLoc, diag::err_gc_weak_property_strong_type); 618265941bc308d65cc270d5c4de5806f37ce405606John McCall Diag(property->getLocation(), diag::note_property_declare); 619265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 620265941bc308d65cc270d5c4de5806f37ce405606John McCall PropertyIvarType = 621265941bc308d65cc270d5c4de5806f37ce405606John McCall Context.getObjCGCQualType(PropertyIvarType, Qualifiers::Weak); 622edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian } 623edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian } 624265941bc308d65cc270d5c4de5806f37ce405606John McCall 62528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that this is a previously declared 'ivar' in 'IDecl' interface 62628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl *ClassDeclared; 62728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Ivar = IDecl->lookupInstanceVariable(PropertyIvar, ClassDeclared); 62828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Ivar) { 629265941bc308d65cc270d5c4de5806f37ce405606John McCall // In ARC, give the ivar a lifetime qualifier based on the 630f85e193739c953358c865005855253af4f68a497John McCall // property attributes. 631f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount && 632265941bc308d65cc270d5c4de5806f37ce405606John McCall !PropertyIvarType.getObjCLifetime() && 633265941bc308d65cc270d5c4de5806f37ce405606John McCall PropertyIvarType->isObjCRetainableType()) { 634f85e193739c953358c865005855253af4f68a497John McCall 635265941bc308d65cc270d5c4de5806f37ce405606John McCall // It's an error if we have to do this and the user didn't 636265941bc308d65cc270d5c4de5806f37ce405606John McCall // explicitly write an ownership attribute on the property. 637473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis if (!property->hasWrittenStorageAttribute() && 638265941bc308d65cc270d5c4de5806f37ce405606John McCall !(kind & ObjCPropertyDecl::OBJC_PR_strong)) { 639473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis Diag(PropertyLoc, 640473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis diag::err_arc_objc_property_default_assign_on_object); 641473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis Diag(property->getLocation(), diag::note_property_declare); 642265941bc308d65cc270d5c4de5806f37ce405606John McCall } else { 643265941bc308d65cc270d5c4de5806f37ce405606John McCall Qualifiers::ObjCLifetime lifetime = 644265941bc308d65cc270d5c4de5806f37ce405606John McCall getImpliedARCOwnership(kind, PropertyIvarType); 645265941bc308d65cc270d5c4de5806f37ce405606John McCall assert(lifetime && "no lifetime for property?"); 646473506bd9dfd84944c2c5ca2c2a38814f46febc6Argyrios Kyrtzidis 647265941bc308d65cc270d5c4de5806f37ce405606John McCall if (lifetime == Qualifiers::OCL_Weak && 648265941bc308d65cc270d5c4de5806f37ce405606John McCall !getLangOptions().ObjCRuntimeHasWeak) { 649f85e193739c953358c865005855253af4f68a497John McCall Diag(PropertyLoc, diag::err_arc_weak_no_runtime); 650f85e193739c953358c865005855253af4f68a497John McCall Diag(property->getLocation(), diag::note_property_declare); 651f85e193739c953358c865005855253af4f68a497John McCall } 652265941bc308d65cc270d5c4de5806f37ce405606John McCall 653f85e193739c953358c865005855253af4f68a497John McCall Qualifiers qs; 654265941bc308d65cc270d5c4de5806f37ce405606John McCall qs.addObjCLifetime(lifetime); 655f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType = Context.getQualifiedType(PropertyIvarType, qs); 656f85e193739c953358c865005855253af4f68a497John McCall } 657f85e193739c953358c865005855253af4f68a497John McCall } 658f85e193739c953358c865005855253af4f68a497John McCall 659f85e193739c953358c865005855253af4f68a497John McCall if (kind & ObjCPropertyDecl::OBJC_PR_weak && 660f85e193739c953358c865005855253af4f68a497John McCall !getLangOptions().ObjCAutoRefCount && 661e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor getLangOptions().getGC() == LangOptions::NonGC) { 662f85e193739c953358c865005855253af4f68a497John McCall Diag(PropertyLoc, diag::error_synthesize_weak_non_arc_or_gc); 663f85e193739c953358c865005855253af4f68a497John McCall Diag(property->getLocation(), diag::note_property_declare); 664f85e193739c953358c865005855253af4f68a497John McCall } 665f85e193739c953358c865005855253af4f68a497John McCall 666ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Ivar = ObjCIvarDecl::Create(Context, ClassImpDecl, 667ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara PropertyLoc, PropertyLoc, PropertyIvar, 66814086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType, /*Dinfo=*/0, 6697504966cc0d07eac26baabec80a7406695efb307Fariborz Jahanian ObjCIvarDecl::Private, 670ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian (Expr *)0, true); 67129fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar ClassImpDecl->addDecl(Ivar); 67228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->makeDeclVisibleInContext(Ivar, false); 67328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property->setPropertyIvarDecl(Ivar); 67428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 67528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!getLangOptions().ObjCNonFragileABI) 67628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_missing_property_ivar_decl) << PropertyId; 67728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 67828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 67928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (getLangOptions().ObjCNonFragileABI && 68028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ClassDeclared != IDecl) { 68128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_ivar_in_superclass_use) 68228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName() 68328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << ClassDeclared->getDeclName(); 68428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Ivar->getLocation(), diag::note_previous_access_declaration) 6854087f27e5416c799bcb6be072f905be752acb61cDaniel Dunbar << Ivar << Ivar->getName(); 68628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so more errors are caught. 68728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 68828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType IvarType = Context.getCanonicalType(Ivar->getType()); 68928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 69028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that type of property and its ivar are type compatible. 691265941bc308d65cc270d5c4de5806f37ce405606John McCall if (Context.getCanonicalType(PropertyIvarType) != IvarType) { 69262ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian bool compat = false; 69314086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (isa<ObjCObjectPointerType>(PropertyIvarType) 694f85e193739c953358c865005855253af4f68a497John McCall && isa<ObjCObjectPointerType>(IvarType)) 69562ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian compat = 69662ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian Context.canAssignObjCInterfaces( 69714086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType->getAs<ObjCObjectPointerType>(), 69862ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian IvarType->getAs<ObjCObjectPointerType>()); 699b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor else { 700b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor SourceLocation Loc = PropertyIvarLoc; 701b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor if (Loc.isInvalid()) 702b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor Loc = PropertyLoc; 70314086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian compat = (CheckAssignmentConstraints(Loc, PropertyIvarType, IvarType) 704daa8e4e888758d55a7a759dd4a91b83921cef222John McCall == Compatible); 705b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor } 70662ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian if (!compat) { 70728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 708f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 709f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 710f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 71128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 71228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 71328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 71428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 71528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME! Rules for properties are somewhat different that those 71628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // for assignments. Use a new routine to consolidate all cases; 71728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // specifically for property redeclarations as well as for ivars. 71814086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian QualType lhsType =Context.getCanonicalType(PropertyIvarType).getUnqualifiedType(); 71928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType rhsType =Context.getCanonicalType(IvarType).getUnqualifiedType(); 72028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (lhsType != rhsType && 72128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek lhsType->isArithmeticType()) { 72228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 723f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 724f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 725f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 72628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 72728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 72828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // __weak is explicit. So it works on Canonical type. 729f85e193739c953358c865005855253af4f68a497John McCall if ((PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() && 730e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor getLangOptions().getGC() != LangOptions::NonGC)) { 73128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_weak_property) 73228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 733edc08821d3f73514291b339db29aca1a17485e39Fariborz Jahanian Diag(Ivar->getLocation(), diag::note_ivar_decl); 73428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 73528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 736f85e193739c953358c865005855253af4f68a497John McCall // Fall thru - see previous comment 73728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((property->getType()->isObjCObjectPointerType() || 73828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropType.isObjCGCStrong()) && IvarType.isObjCGCWeak() && 739e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor getLangOptions().getGC() != LangOptions::NonGC) { 74028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_strong_property) 74128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 74228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 74328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 74428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 745f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 746f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyImpl(*this, PropertyLoc, property, Ivar); 74728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (PropertyIvar) 74828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @dynamic 74928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_dynamic_property_ivar_decl); 750f85e193739c953358c865005855253af4f68a497John McCall 75128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert (property && "ActOnPropertyImplDecl - property declaration missing"); 75228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl *PIDecl = 75328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Create(Context, CurContext, AtLoc, PropertyLoc, 75428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property, 75528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Synthesize ? 75628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Synthesize 75728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek : ObjCPropertyImplDecl::Dynamic), 758a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor Ivar, PropertyIvarLoc); 75917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *getterMethod = property->getGetterMethodDecl()) { 76017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian getterMethod->createImplicitParams(Context, IDecl); 7610313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian if (getLangOptions().CPlusPlus && Synthesize && 7620313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian Ivar->getType()->isRecordType()) { 76317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // For Objective-C++, need to synthesize the AST for the IVAR object to be 76417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // returned by the getter as it must conform to C++'s copy-return rules. 76517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 76617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = getterMethod->getSelfDecl(); 76717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 768f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall new (Context) DeclRefExpr(SelfDecl, SelfDecl->getType(), 769f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_RValue, SourceLocation()); 77017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *IvarRefExpr = 77117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 77217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 77360d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult Res = 77417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PerformCopyInitialization(InitializedEntity::InitializeResult( 7753c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor SourceLocation(), 7763c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor getterMethod->getResultType(), 7773c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor /*NRVO=*/false), 77817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SourceLocation(), 77917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Owned(IvarRefExpr)); 78017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (!Res.isInvalid()) { 78117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *ResExpr = Res.takeAs<Expr>(); 78217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ResExpr) 7834765fa05b5652fcc4356371c2f481d0ea9a1b007John McCall ResExpr = MaybeCreateExprWithCleanups(ResExpr); 78417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setGetterCXXConstructor(ResExpr); 78517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 78617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 787831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>() && 788831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !getterMethod->hasAttr<NSReturnsNotRetainedAttr>()) { 789831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(getterMethod->getLocation(), 790831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian diag::warn_property_getter_owning_mismatch); 791831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 792831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian } 79317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 79417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *setterMethod = property->getSetterMethodDecl()) { 79517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian setterMethod->createImplicitParams(Context, IDecl); 7960313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian if (getLangOptions().CPlusPlus && Synthesize 7970313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian && Ivar->getType()->isRecordType()) { 79817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 79917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = setterMethod->getSelfDecl(); 80017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 801f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall new (Context) DeclRefExpr(SelfDecl, SelfDecl->getType(), 802f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_RValue, SourceLocation()); 80317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *lhs = 80417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 80517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 80617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ObjCMethodDecl::param_iterator P = setterMethod->param_begin(); 80717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ParmVarDecl *Param = (*P); 8083c3b7f90a863af43fa63043d396553ecf205351cJohn McCall QualType T = Param->getType().getNonReferenceType(); 80914086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian Expr *rhs = new (Context) DeclRefExpr(Param, T, 810f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_LValue, SourceLocation()); 811fa432391a708448518df1e6ced4e34f4c349d169Fariborz Jahanian ExprResult Res = BuildBinOp(S, lhs->getLocEnd(), 8122de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BO_Assign, lhs, rhs); 81357e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (property->getPropertyAttributes() & 81457e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_atomic) { 81557e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian Expr *callExpr = Res.takeAs<Expr>(); 81657e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (const CXXOperatorCallExpr *CXXCE = 81713bf6336ab395eb6af487ab96d32229460907769Fariborz Jahanian dyn_cast_or_null<CXXOperatorCallExpr>(callExpr)) 81813bf6336ab395eb6af487ab96d32229460907769Fariborz Jahanian if (const FunctionDecl *FuncDecl = CXXCE->getDirectCallee()) 81957e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian if (!FuncDecl->isTrivial()) 82057e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian Diag(PropertyLoc, 82157e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian diag::warn_atomic_property_nontrivial_assign_op) 82257e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian << property->getType(); 82357e264e9f4ff0a72f3585a960cdf63437b76fa93Fariborz Jahanian } 82417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setSetterCXXAssignment(Res.takeAs<Expr>()); 82517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 82617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 82717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian 82828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (IC) { 82928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 83028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 83128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->FindPropertyImplIvarDecl(PropertyIvar)) { 83228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 83328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 83428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 83528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 83628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 83728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 83828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl 83928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek = IC->FindPropertyImplDecl(PropertyId)) { 84028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 84128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 842d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 84328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 84428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->addPropertyImplementation(PIDecl); 845e776f88430eb77ce8d58f2e6ec10da1383b71de8Fariborz Jahanian if (getLangOptions().ObjCDefaultSynthProperties && 846e776f88430eb77ce8d58f2e6ec10da1383b71de8Fariborz Jahanian getLangOptions().ObjCNonFragileABI2) { 847ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // Diagnose if an ivar was lazily synthesdized due to a previous 848ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // use and if 1) property is @dynamic or 2) property is synthesized 849cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // but it requires an ivar of different name. 850411c25c4512f00e07442e8818d011c7e0902d739Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared=0; 851ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian ObjCIvarDecl *Ivar = 0; 852ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (!Synthesize) 853ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 854ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian else { 855ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (PropertyIvar && PropertyIvar != PropertyId) 856ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 857ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 858cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // Issue diagnostics only if Ivar belongs to current class. 859cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian if (Ivar && Ivar->getSynthesize() && 860cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian IC->getClassInterface() == ClassDeclared) { 861ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Diag(Ivar->getLocation(), diag::err_undeclared_var_use) 862ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian << PropertyId; 863ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar->setInvalidDecl(); 864ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 865ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 86628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 86728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 86828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 86928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplIvarDecl(PropertyIvar)) { 87028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 87128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 87228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 87328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 87428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 87528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 87628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 87728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplDecl(PropertyId)) { 87828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 87928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 880d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 88128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 88228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->addPropertyImplementation(PIDecl); 88328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 88428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 885d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PIDecl; 88628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 88728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 88828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 88928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Helper methods. 89028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 89128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 8929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// DiagnosePropertyMismatch - Compares two properties for their 8939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// attributes and types and warns on a variety of inconsistencies. 8949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 8959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 8969d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property, 8979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperProperty, 8989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const IdentifierInfo *inheritedName) { 8999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 9009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Property->getPropertyAttributes(); 9019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind SAttr = 9029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SuperProperty->getPropertyAttributes(); 9039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly) 9049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite)) 9059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_readonly_property) 9069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << inheritedName; 9079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy) 9089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_copy)) 9099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 9109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "copy" << inheritedName; 9111b46d8d78be713c546fb9680eaeea8f793bee5bfFariborz Jahanian else if (!(SAttr & ObjCPropertyDecl::OBJC_PR_readonly)){ 912f85e193739c953358c865005855253af4f68a497John McCall unsigned CAttrRetain = 913f85e193739c953358c865005855253af4f68a497John McCall (CAttr & 914f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 915f85e193739c953358c865005855253af4f68a497John McCall unsigned SAttrRetain = 916f85e193739c953358c865005855253af4f68a497John McCall (SAttr & 917f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 918f85e193739c953358c865005855253af4f68a497John McCall bool CStrong = (CAttrRetain != 0); 919f85e193739c953358c865005855253af4f68a497John McCall bool SStrong = (SAttrRetain != 0); 920f85e193739c953358c865005855253af4f68a497John McCall if (CStrong != SStrong) 921f85e193739c953358c865005855253af4f68a497John McCall Diag(Property->getLocation(), diag::warn_property_attribute) 922f85e193739c953358c865005855253af4f68a497John McCall << Property->getDeclName() << "retain (or strong)" << inheritedName; 923f85e193739c953358c865005855253af4f68a497John McCall } 9249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic) 9269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)) 9279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 9289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "atomic" << inheritedName; 9299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getSetterName() != SuperProperty->getSetterName()) 9309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 9319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "setter" << inheritedName; 9329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getGetterName() != SuperProperty->getGetterName()) 9339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 9349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "getter" << inheritedName; 9359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType LHSType = 9379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SuperProperty->getType()); 9389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType RHSType = 9399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(Property->getType()); 9409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 941c286f3835eb6001c61664cef5d610dfaf80a6e9bFariborz Jahanian if (!Context.propertyTypesAreCompatible(LHSType, RHSType)) { 9428beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // Do cases not handled in above. 9438beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian // FIXME. For future support of covariant property types, revisit this. 9448beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian bool IncompatibleObjC = false; 9458beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian QualType ConvertedType; 9468beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian if (!isObjCPointerConversion(RHSType, LHSType, 9478beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian ConvertedType, IncompatibleObjC) || 94813546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian IncompatibleObjC) { 9498beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian Diag(Property->getLocation(), diag::warn_property_types_are_incompatible) 9508beb6a2426b5a6b79ecf019316d9fbd30755e087Fariborz Jahanian << Property->getType() << SuperProperty->getType() << inheritedName; 95113546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian Diag(SuperProperty->getLocation(), diag::note_property_declare); 95213546a871db44c707001f507a9edfd0d5bcc81b4Fariborz Jahanian } 9539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::DiagnosePropertyAccessorMismatch(ObjCPropertyDecl *property, 9579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, 9589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc) { 9599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod && 9603c3b7f90a863af43fa63043d396553ecf205351cJohn McCall !Context.hasSameType(GetterMethod->getResultType().getNonReferenceType(), 9613c3b7f90a863af43fa63043d396553ecf205351cJohn McCall property->getType().getNonReferenceType())) { 9629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AssignConvertType result = Incompatible; 9631c23e91ef66688d20868b6bab3b5589a119eb603John McCall if (property->getType()->isObjCObjectPointerType()) 964b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor result = CheckAssignmentConstraints(Loc, GetterMethod->getResultType(), 9651c23e91ef66688d20868b6bab3b5589a119eb603John McCall property->getType()); 9669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (result != Compatible) { 9679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Loc, diag::warn_accessor_property_type_mismatch) 9689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 9699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << GetterMethod->getSelector(); 9709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(GetterMethod->getLocation(), diag::note_declared_at); 9719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 9729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 9759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ComparePropertiesInBaseAndSuper - This routine compares property 9789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declarations in base and its super class, if any, and issues 979fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner/// diagnostics in a variety of inconsistent situations. 9809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 9819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ComparePropertiesInBaseAndSuper(ObjCInterfaceDecl *IDecl) { 9829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *SDecl = IDecl->getSuperClass(); 9839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SDecl) 9849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 9859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: O(N^2) 9869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator S = SDecl->prop_begin(), 9879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = SDecl->prop_end(); S != E; ++S) { 9889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperPDecl = (*S); 9899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Does property in super class has declaration in current class? 9909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator I = IDecl->prop_begin(), 9919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); I != E; ++I) { 9929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *PDecl = (*I); 9939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SuperPDecl->getIdentifier() == PDecl->getIdentifier()) 9949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch(PDecl, SuperPDecl, 9959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SDecl->getIdentifier()); 9969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// MatchOneProtocolPropertiesInClass - This routine goes thru the list 10019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// of properties declared in a protocol and compares their attribute against 10029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the same property declared in the class or category. 10039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 10049d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::MatchOneProtocolPropertiesInClass(Decl *CDecl, 10059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *PDecl) { 10069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 10079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 10089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 10099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 10109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "MatchOneProtocolPropertiesInClass"); 10119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CatDecl->IsClassExtension()) 10129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 10139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 10149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 10159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl::prop_iterator CP, CE; 10169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in category's list of properties? 10172d2f9368d35b3628c7e3b4563f74849a0f901a00Ted Kremenek for (CP = CatDecl->prop_begin(), CE = CatDecl->prop_end(); CP!=CE; ++CP) 10189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 10199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 10209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 10219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 10229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 10239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 10259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 10279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 10289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 10299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl::prop_iterator CP, CE; 10309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in class's list of properties? 10319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (CP = IDecl->prop_begin(), CE = IDecl->prop_end(); CP != CE; ++CP) 10329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 10339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 10349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 10359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 10369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 10379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 10399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CompareProperties - This routine compares properties 10419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declared in 'ClassOrProtocol' objects (which can be a class or an 10429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// inherited protocol with the list of properties for class/category 'CDecl' 10439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 1044d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CompareProperties(Decl *CDecl, Decl *ClassOrProtocol) { 1045d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ClassDecl = ClassOrProtocol; 10469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 10479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 10499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 10509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 10519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "CompareProperties"); 10529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *MDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 10539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = MDecl->protocol_begin(), 10549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MDecl->protocol_end(); P != E; ++P) 10559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of category with those of protocol (*P) 10569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 10579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this category and recursively match 10599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those in the category. 10609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = CatDecl->protocol_begin(), 10619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CatDecl->protocol_end(); P != E; ++P) 1062d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(CatDecl, *P); 10639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 10649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 10659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 10669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 10679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 10689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 10709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *MDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 107353b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 107453b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = MDecl->all_referenced_protocol_begin(), 107553b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = MDecl->all_referenced_protocol_end(); P != E; ++P) 10769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of class IDecl with those of protocol (*P). 10779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 10789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this class and recursively match 10809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those declared in the class. 108153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 108253b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = IDecl->all_referenced_protocol_begin(), 108353b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); P != E; ++P) 1084d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(IDecl, *P); 10859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 10869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 10879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 10889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 10899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 10909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 10929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// isPropertyReadonly - Return true if property is readonly, by searching 10949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// for the property in the class and in its categories and implementations 10959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 10969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::isPropertyReadonly(ObjCPropertyDecl *PDecl, 10979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl) { 10989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // by far the most common case. 10999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!PDecl->isReadOnly()) 11009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if interface has a user defined setter, 11029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 11039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IDecl->getInstanceMethod(PDecl->getSetterName())) 11049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 11069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Main class has the property as 'readonly'. Must search 11079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // through the category list to see if the property's 11089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // attribute has been over-ridden to 'readwrite'. 11099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl *Category = IDecl->getCategoryList(); 11109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category; Category = Category->getNextClassCategory()) { 11119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if a category has a user defined setter, 11129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 11139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Category->getInstanceMethod(PDecl->getSetterName())) 11149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *P = 11169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category->FindPropertyDeclaration(PDecl->getIdentifier()); 11179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (P && !P->isReadOnly()) 11189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 11219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Also, check for definition of a setter method in the implementation if 11229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // all else failed. 11239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(CurContext)) { 11249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *IMD = 11259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCImplementationDecl>(OMD->getDeclContext())) { 11269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IMD->getInstanceMethod(PDecl->getSetterName())) 11279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else if (ObjCCategoryImplDecl *CIMD = 11299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCCategoryImplDecl>(OMD->getDeclContext())) { 11309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CIMD->getInstanceMethod(PDecl->getSetterName())) 11319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Lastly, look through the implementation (if one is in scope). 11359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *ImpDecl = IDecl->getImplementation()) 11369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ImpDecl->getInstanceMethod(PDecl->getSetterName())) 11379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 11389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // If all fails, look at the super class. 11399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *SIDecl = IDecl->getSuperClass()) 11409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return isPropertyReadonly(PDecl, SIDecl); 11419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 11429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 11439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 11449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CollectImmediateProperties - This routine collects all properties in 11459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the class and its conforming protocols; but not those it its super class. 11469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::CollectImmediateProperties(ObjCContainerDecl *CDecl, 1147cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap, 1148cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& SuperPropMap) { 11499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 11509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 11519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 11529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 11539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 11549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 115653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 115753b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 115853b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 1159cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 11609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *CATDecl = dyn_cast<ObjCCategoryDecl>(CDecl)) { 11629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CATDecl->IsClassExtension()) 11639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = CATDecl->prop_begin(), 11649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->prop_end(); P != E; ++P) { 11659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 11669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 11679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 116953b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCCategoryDecl::protocol_iterator PI = CATDecl->protocol_begin(), 11709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->protocol_end(); PI != E; ++PI) 1171cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 11729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 11749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 11759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 11769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 1177cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *PropertyFromSuper = SuperPropMap[Prop->getIdentifier()]; 1178cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // Exclude property for protocols which conform to class's super-class, 1179cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // as super-class has to implement the property. 1180a929ec7b673b244bec024ba7eb95140404a7af5dFariborz Jahanian if (!PropertyFromSuper || 1181a929ec7b673b244bec024ba7eb95140404a7af5dFariborz Jahanian PropertyFromSuper->getIdentifier() != Prop->getIdentifier()) { 1182cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *&PropEntry = PropMap[Prop->getIdentifier()]; 1183cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropEntry) 1184cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian PropEntry = Prop; 1185cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian } 11869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 11889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 11899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) 1190cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 11919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 11939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1194509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectClassPropertyImplementations - This routine collects list of 1195509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in the class. This includes, class's 1196509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// and its conforming protocols' properties. 1197509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectClassPropertyImplementations(ObjCContainerDecl *CDecl, 1198509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 1199509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 1200509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 1201509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = IDecl->prop_end(); P != E; ++P) { 1202509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = (*P); 1203509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 1204509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 120553b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 120653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 120753b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 1208509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 1209509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1210509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 1211509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 1212509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->prop_end(); P != E; ++P) { 1213509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = (*P); 1214509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 1215509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1216509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // scan through protocol's protocols. 1217509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 1218509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->protocol_end(); PI != E; ++PI) 1219509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 1220509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1221509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 1222509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1223509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectSuperClassPropertyImplementations - This routine collects list of 1224509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in super class(s) and also coming from their 1225509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// conforming protocols. 1226509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectSuperClassPropertyImplementations(ObjCInterfaceDecl *CDecl, 1227509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 1228509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *SDecl = CDecl->getSuperClass()) { 1229509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian while (SDecl) { 1230509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(SDecl, PropMap); 1231509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian SDecl = SDecl->getSuperClass(); 1232509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1233509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1234509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 1235509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 12369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// LookupPropertyDecl - Looks up a property in the current class and all 12379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// its protocols. 12389d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekObjCPropertyDecl *Sema::LookupPropertyDecl(const ObjCContainerDecl *CDecl, 12399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek IdentifierInfo *II) { 12409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCInterfaceDecl *IDecl = 12419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCInterfaceDecl>(CDecl)) { 12429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 12439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 12449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 12459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 12469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 124953b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 125053b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 125153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) { 12529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 12539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 12549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (const ObjCProtocolDecl *PDecl = 12589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCProtocolDecl>(CDecl)) { 12599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 12609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 12619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 12629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 12639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 12669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 12679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) { 12689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 12699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 12709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return 0; 12749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 12759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1276d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenekstatic IdentifierInfo * getDefaultSynthIvarName(ObjCPropertyDecl *Prop, 1277d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek ASTContext &Ctx) { 1278d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek llvm::SmallString<128> ivarName; 1279d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek { 1280d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek llvm::raw_svector_ostream os(ivarName); 1281d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek os << '_' << Prop->getIdentifier()->getName(); 1282d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek } 1283d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek return &Ctx.Idents.get(ivarName.str()); 1284d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek} 1285d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek 1286509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// DefaultSynthesizeProperties - This routine default synthesizes all 1287509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties which must be synthesized in class's @implementation. 1288d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenekvoid Sema::DefaultSynthesizeProperties(Scope *S, ObjCImplDecl* IMPDecl, 1289d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek ObjCInterfaceDecl *IDecl) { 1290509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1291509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 1292509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(IDecl, PropMap); 1293509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (PropMap.empty()) 1294509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian return; 1295509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 1296509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1297509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1298509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 1299509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 1300509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = P->second; 1301509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // If property to be implemented in the super class, ignore. 1302509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (SuperPropMap[Prop->getIdentifier()]) 1303509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 1304509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // Is there a matching propery synthesize/dynamic? 1305509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (Prop->isInvalidDecl() || 1306509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 1307509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian IMPDecl->FindPropertyImplIvarDecl(Prop->getIdentifier())) 1308509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 1309d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian // Property may have been synthesized by user. 1310d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian if (IMPDecl->FindPropertyImplDecl(Prop->getIdentifier())) 1311d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian continue; 131295f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getGetterName())) { 131395f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (Prop->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_readonly) 131495f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 131595f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getSetterName())) 131695f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 131795f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian } 1318d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian 13192a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek 13202a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // We use invalid SourceLocations for the synthesized ivars since they 13212a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // aren't really synthesized at a particular location; they just exist. 13222a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // Saying that they are located at the @implementation isn't really going 13232a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // to help users. 13242a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek ActOnPropertyImplDecl(S, SourceLocation(), SourceLocation(), 1325a28948f34817476d02412fa204cae038e228c827Fariborz Jahanian true, 1326d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek /* property = */ Prop->getIdentifier(), 1327d2ee809f9e7c2c7a83b8918efa11e98863463f78Ted Kremenek /* ivar = */ getDefaultSynthIvarName(Prop, Context), 1328a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor SourceLocation()); 13292a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek } 1330509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 13319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13328697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanianvoid Sema::DefaultSynthesizeProperties(Scope *S, Decl *D) { 13338697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (!LangOpts.ObjCDefaultSynthProperties || !LangOpts.ObjCNonFragileABI2) 13348697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian return; 13358697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian ObjCImplementationDecl *IC=dyn_cast_or_null<ObjCImplementationDecl>(D); 13368697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (!IC) 13378697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian return; 13388697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian if (ObjCInterfaceDecl* IDecl = IC->getClassInterface()) 13398697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian DefaultSynthesizeProperties(S, IC, IDecl); 13408697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian} 13418697d308c1bdd50e5c45757ac11be701c26e9e97Fariborz Jahanian 134217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanianvoid Sema::DiagnoseUnimplementedProperties(Scope *S, ObjCImplDecl* IMPDecl, 13439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl *CDecl, 13449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const llvm::DenseSet<Selector>& InsMap) { 1345cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 1346cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) 1347cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1348cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian 13499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 1350cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties(CDecl, PropMap, SuperPropMap); 13519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PropMap.empty()) 13529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 13539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseSet<ObjCPropertyDecl *> PropImplMap; 13559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCImplDecl::propimpl_iterator 13569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I = IMPDecl->propimpl_begin(), 13579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek EI = IMPDecl->propimpl_end(); I != EI; ++I) 13589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropImplMap.insert((*I)->getPropertyDecl()); 13599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 13619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 13629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = P->second; 13639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is there a matching propery synthesize/dynamic? 13649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->isInvalidDecl() || 13659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 1366327126ee3d2faad9314b2633974eefc672f73b79Fariborz Jahanian PropImplMap.count(Prop) || Prop->hasAttr<UnavailableAttr>()) 13679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 13689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!InsMap.count(Prop->getGetterName())) { 1369b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(IMPDecl->getLocation(), 13709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 13719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 13729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 13739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getGetterName(); 1374b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(Prop->getLocation(), 1375b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian diag::note_property_declare); 13769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!Prop->isReadOnly() && !InsMap.count(Prop->getSetterName())) { 1379b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(IMPDecl->getLocation(), 13809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 13819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 13829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 13839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getSetterName(); 1384b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian Diag(Prop->getLocation(), 1385b8607398a5e1e552f82a86d1d8c3a4031ac4c946Fariborz Jahanian diag::note_property_declare); 13869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 13899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 13919d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::AtomicPropertySetterGetterRules (ObjCImplDecl* IMPDecl, 13929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl* IDecl) { 13939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Rules apply in non-GC mode only 1394e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor if (getLangOptions().getGC() != LangOptions::NonGC) 13959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 13969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator I = IDecl->prop_begin(), 13979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); 13989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I != E; ++I) { 13999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Property = (*I); 140094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *GetterMethod = 0; 140194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *SetterMethod = 0; 140294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis bool LookedUpGetterSetter = false; 140394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 14049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned Attributes = Property->getPropertyAttributes(); 1405265941bc308d65cc270d5c4de5806f37ce405606John McCall unsigned AttributesAsWritten = Property->getPropertyAttributesAsWritten(); 140694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 1407265941bc308d65cc270d5c4de5806f37ce405606John McCall if (!(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_atomic) && 1408265941bc308d65cc270d5c4de5806f37ce405606John McCall !(AttributesAsWritten & ObjCPropertyDecl::OBJC_PR_nonatomic)) { 140994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 141094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 141194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 141294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (GetterMethod) { 141394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(GetterMethod->getLocation(), 141494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1415293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 0; 141694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 141794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 141894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (SetterMethod) { 141994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(SetterMethod->getLocation(), 142094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1421293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 1; 142294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 142394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 142494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 142594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 14269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // We only care about readwrite atomic property. 14279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCPropertyDecl::OBJC_PR_nonatomic) || 14289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek !(Attributes & ObjCPropertyDecl::OBJC_PR_readwrite)) 14299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 14309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCPropertyImplDecl *PIDecl 14319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek = IMPDecl->FindPropertyImplDecl(Property->getIdentifier())) { 14329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic) 14339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 143494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (!LookedUpGetterSetter) { 143594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 143694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 143794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 143894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 14399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((GetterMethod && !SetterMethod) || (!GetterMethod && SetterMethod)) { 14409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation MethodLoc = 14419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (GetterMethod ? GetterMethod->getLocation() 14429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek : SetterMethod->getLocation()); 14439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(MethodLoc, diag::warn_atomic_property_rule) 14447d65f6965d215f4cb2eb0738ee1b9024e5ab5bbaFariborz Jahanian << Property->getIdentifier() << (GetterMethod != 0) 14457d65f6965d215f4cb2eb0738ee1b9024e5ab5bbaFariborz Jahanian << (SetterMethod != 0); 14467d65f6965d215f4cb2eb0738ee1b9024e5ab5bbaFariborz Jahanian Diag(MethodLoc, diag::note_atomic_property_fixup_suggest); 14479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::note_property_declare); 14489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 14529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1453f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::DiagnoseOwningPropertyGetterSynthesis(const ObjCImplementationDecl *D) { 1454e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor if (getLangOptions().getGC() == LangOptions::GCOnly) 1455f85e193739c953358c865005855253af4f68a497John McCall return; 1456f85e193739c953358c865005855253af4f68a497John McCall 1457f85e193739c953358c865005855253af4f68a497John McCall for (ObjCImplementationDecl::propimpl_iterator 1458f85e193739c953358c865005855253af4f68a497John McCall i = D->propimpl_begin(), e = D->propimpl_end(); i != e; ++i) { 1459f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyImplDecl *PID = *i; 1460f85e193739c953358c865005855253af4f68a497John McCall if (PID->getPropertyImplementation() != ObjCPropertyImplDecl::Synthesize) 1461f85e193739c953358c865005855253af4f68a497John McCall continue; 1462f85e193739c953358c865005855253af4f68a497John McCall 1463f85e193739c953358c865005855253af4f68a497John McCall const ObjCPropertyDecl *PD = PID->getPropertyDecl(); 1464831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (PD && !PD->hasAttr<NSReturnsNotRetainedAttr>() && 1465831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian !D->getInstanceMethod(PD->getGetterName())) { 1466f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodDecl *method = PD->getGetterMethodDecl(); 1467f85e193739c953358c865005855253af4f68a497John McCall if (!method) 1468f85e193739c953358c865005855253af4f68a497John McCall continue; 1469f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodFamily family = method->getMethodFamily(); 1470f85e193739c953358c865005855253af4f68a497John McCall if (family == OMF_alloc || family == OMF_copy || 1471f85e193739c953358c865005855253af4f68a497John McCall family == OMF_mutableCopy || family == OMF_new) { 1472f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 1473f85e193739c953358c865005855253af4f68a497John McCall Diag(PID->getLocation(), diag::err_ownin_getter_rule); 1474f85e193739c953358c865005855253af4f68a497John McCall else 1475920c9c1155c118ac40e5209d4b757b9f54186339Ted Kremenek Diag(PID->getLocation(), diag::warn_owning_getter_rule); 1476f85e193739c953358c865005855253af4f68a497John McCall Diag(PD->getLocation(), diag::note_property_declare); 1477f85e193739c953358c865005855253af4f68a497John McCall } 1478f85e193739c953358c865005855253af4f68a497John McCall } 1479f85e193739c953358c865005855253af4f68a497John McCall } 1480f85e193739c953358c865005855253af4f68a497John McCall} 1481f85e193739c953358c865005855253af4f68a497John McCall 14825de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// AddPropertyAttrs - Propagates attributes from a property to the 14835de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// implicitly-declared getter or setter for that property. 14845de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCallstatic void AddPropertyAttrs(Sema &S, ObjCMethodDecl *PropertyMethod, 14855de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall ObjCPropertyDecl *Property) { 14865de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall // Should we just clone all attributes over? 14870a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor for (Decl::attr_iterator A = Property->attr_begin(), 14880a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor AEnd = Property->attr_end(); 14890a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor A != AEnd; ++A) { 14900a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor if (isa<DeprecatedAttr>(*A) || 14910a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<UnavailableAttr>(*A) || 14920a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<AvailabilityAttr>(*A)) 14930a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor PropertyMethod->addAttr((*A)->clone(S.Context)); 14940a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor } 14955de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall} 14965de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 14979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ProcessPropertyDecl - Make sure that any user-defined setter/getter methods 14989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// have the property type and issue diagnostics if they don't. 14999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// Also synthesize a getter/setter method if none exist (and update the 15009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// appropriate lookup tables. FIXME: Should reconsider if adding synthesized 15019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// methods is the "right" thing to do. 15029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ProcessPropertyDecl(ObjCPropertyDecl *property, 15038254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *CD, 15048254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCPropertyDecl *redeclaredProperty, 15058254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *lexicalDC) { 15068254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 15079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, *SetterMethod; 15089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 15099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod = CD->getInstanceMethod(property->getGetterName()); 15109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod = CD->getInstanceMethod(property->getSetterName()); 15119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyAccessorMismatch(property, GetterMethod, 15129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation()); 15139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 15149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) { 15159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 15169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getPropertyAttributes(); 15179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((!(CAttr & ObjCPropertyDecl::OBJC_PR_readonly)) && 15189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SetterMethod->getResultType()) != 15199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.VoidTy) 15209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::err_setter_type_void); 15219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod->param_size() != 1 || 15222aac0c9f8bc4dca3f883f429af8c1f57132d62d0Fariborz Jahanian !Context.hasSameUnqualifiedType( 1523bb13c320fff4bc4b3536e62626c97d7b055c6113Fariborz Jahanian (*SetterMethod->param_begin())->getType().getNonReferenceType(), 1524bb13c320fff4bc4b3536e62626c97d7b055c6113Fariborz Jahanian property->getType().getNonReferenceType())) { 15259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(property->getLocation(), 15269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_accessor_property_type_mismatch) 15279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 15289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << SetterMethod->getSelector(); 15299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::note_declared_at); 15309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 15339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Synthesize getter/setter methods if none exist. 15349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default getter and if one not found, add one. 15359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: The synthesized property we set here is misleading. We almost always 15369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // synthesize these methods unless the user explicitly provided prototypes 15379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // (which is odd, but allowed). Sema should be typechecking that the 15389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // declarations jive in that situation (which it is not currently). 15399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!GetterMethod) { 15409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property getter name was found. 15419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a getter method and add it to the list of methods 15429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 1543a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek SourceLocation Loc = redeclaredProperty ? 1544a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek redeclaredProperty->getLocation() : 1545a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getLocation(); 1546a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek 1547a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek GetterMethod = ObjCMethodDecl::Create(Context, Loc, Loc, 1548a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getGetterName(), 154975cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis property->getType(), 0, CD, /*isInstance=*/true, 155075cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isVariadic=*/false, /*isSynthesized=*/true, 155175cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, /*isDefined=*/false, 15529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 15539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 15549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Optional : 15559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Required); 15569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(GetterMethod); 15575de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 15585de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, GetterMethod, property); 15595de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 156023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 156123173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 1562a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek if (lexicalDC) 156323173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek GetterMethod->setLexicalDeclContext(lexicalDC); 1564831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian if (property->hasAttr<NSReturnsNotRetainedAttr>()) 1565831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian GetterMethod->addAttr( 1566831fb9622581fc3b777848e6b097a0cb23d124deFariborz Jahanian ::new (Context) NSReturnsNotRetainedAttr(Loc, Context)); 15679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 15689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared getter will be synthesize when @synthesize of 15699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 15709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->setSynthesized(true); 15719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setGetterMethodDecl(GetterMethod); 15729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 15739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Skip setter if property is read-only. 15749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!property->isReadOnly()) { 15759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default setter and if one not found, add one. 15769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SetterMethod) { 15779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property setter name was found. 15789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a setter method and add it to the list of methods 15799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 15808254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SourceLocation Loc = redeclaredProperty ? 15818254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek redeclaredProperty->getLocation() : 15828254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getLocation(); 15838254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 15848254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SetterMethod = 1585491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis ObjCMethodDecl::Create(Context, Loc, Loc, 15868254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getSetterName(), Context.VoidTy, 0, 158775cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis CD, /*isInstance=*/true, /*isVariadic=*/false, 158875cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isSynthesized=*/true, 158975cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isImplicitlyDeclared=*/true, 159075cf3e86d33ce810c12084126385371b335c30baArgyrios Kyrtzidis /*isDefined=*/false, 15919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 15929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 15938254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Optional : 15948254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Required); 15958254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 15969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Invent the arguments for the setter. We don't bother making a 15979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // nice name for the argument. 1598ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara ParmVarDecl *Argument = ParmVarDecl::Create(Context, SetterMethod, 1599ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Loc, Loc, 16009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getIdentifier(), 1601f85e193739c953358c865005855253af4f68a497John McCall property->getType().getUnqualifiedType(), 16029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek /*TInfo=*/0, 1603d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 1604d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 16059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 0); 1606491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis SetterMethod->setMethodParams(Context, Argument, 1607491306a83c4f0f49f95a3bcbca8580cb98a91c7aArgyrios Kyrtzidis ArrayRef<SourceLocation>()); 16085de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 16095de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, SetterMethod, property); 16105de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 16119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(SetterMethod); 161223173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 161323173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 16148254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek if (lexicalDC) 161523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek SetterMethod->setLexicalDeclContext(lexicalDC); 16169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 16179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared setter will be synthesize when @synthesize of 16189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 16199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod->setSynthesized(true); 16209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setSetterMethodDecl(SetterMethod); 16219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 16229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Add any synthesized methods to the global pool. This allows us to 16239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // handle the following, which is supported by GCC (and part of the design). 16249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 16259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @interface Foo 16269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @property double bar; 16279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @end 16289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 16299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // void thisIsUnfortunate() { 16309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // id foo; 16319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // double bar = [foo bar]; 16329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // } 16339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 16349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod) 16359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(GetterMethod); 16369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) 16379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(SetterMethod); 16389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 16399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1640d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CheckObjCPropertyAttributes(Decl *PDecl, 16419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc, 16429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned &Attributes) { 16439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Improve the reported location. 1644f85e193739c953358c865005855253af4f68a497John McCall if (!PDecl || PDecl->isInvalidDecl()) 16455fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek return; 16465fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek 16475fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek ObjCPropertyDecl *PropertyDecl = cast<ObjCPropertyDecl>(PDecl); 1648842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian QualType PropertyTy = PropertyDecl->getType(); 16499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 16509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // readonly and readwrite/assign/retain/copy conflict. 16519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 165228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & (ObjCDeclSpec::DQ_PR_readwrite | 165328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_assign | 1654f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 165528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_copy | 1656f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | 1657f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_strong))) { 165828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek const char * which = (Attributes & ObjCDeclSpec::DQ_PR_readwrite) ? 165928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "readwrite" : 166028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 166128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "assign" : 1662f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) ? 1663f85e193739c953358c865005855253af4f68a497John McCall "unsafe_unretained" : 166428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 166528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "copy" : "retain"; 16669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 166728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, (Attributes & (ObjCDeclSpec::DQ_PR_readwrite)) ? 166828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::err_objc_property_attr_mutually_exclusive : 166928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::warn_objc_property_attr_mutually_exclusive) 167028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "readonly" << which; 167128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 16729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 167328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for copy or retain on non-object types. 1674f85e193739c953358c865005855253af4f68a497John McCall if ((Attributes & (ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 1675f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong)) && 1676f85e193739c953358c865005855253af4f68a497John McCall !PropertyTy->isObjCRetainableType() && 1677842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian !PropertyDecl->getAttr<ObjCNSObjectAttr>()) { 167828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_requires_object) 1679f85e193739c953358c865005855253af4f68a497John McCall << (Attributes & ObjCDeclSpec::DQ_PR_weak ? "weak" : 1680f85e193739c953358c865005855253af4f68a497John McCall Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain (or strong)"); 1681f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~(ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 1682f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong); 168328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 16849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 168528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for more than one of { assign, copy, retain }. 168628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_assign) { 168728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 168828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 168928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "copy"; 169028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 169128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 169228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 169328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 169428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "retain"; 169528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 169628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 1697f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 1698f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1699f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "strong"; 1700f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 1701f85e193739c953358c865005855253af4f68a497John McCall } 1702f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount && 1703f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1704f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1705f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "weak"; 1706f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1707f85e193739c953358c865005855253af4f68a497John McCall } 1708f85e193739c953358c865005855253af4f68a497John McCall } else if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) { 1709f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 1710f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1711f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "copy"; 1712f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 1713f85e193739c953358c865005855253af4f68a497John McCall } 1714f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 1715f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1716f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "retain"; 1717f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 1718f85e193739c953358c865005855253af4f68a497John McCall } 1719f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 1720f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1721f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "strong"; 1722f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 1723f85e193739c953358c865005855253af4f68a497John McCall } 1724f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount && 1725f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1726f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1727f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "weak"; 1728f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1729f85e193739c953358c865005855253af4f68a497John McCall } 173028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 173128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 173228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 173328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "copy" << "retain"; 173428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 173528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 1736f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 1737f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1738f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "strong"; 1739f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 1740f85e193739c953358c865005855253af4f68a497John McCall } 1741f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_weak) { 1742f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1743f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "weak"; 1744f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1745f85e193739c953358c865005855253af4f68a497John McCall } 1746f85e193739c953358c865005855253af4f68a497John McCall } 1747f85e193739c953358c865005855253af4f68a497John McCall else if ((Attributes & ObjCDeclSpec::DQ_PR_retain) && 1748f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1749f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1750f85e193739c953358c865005855253af4f68a497John McCall << "retain" << "weak"; 1751528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 1752f85e193739c953358c865005855253af4f68a497John McCall } 1753f85e193739c953358c865005855253af4f68a497John McCall else if ((Attributes & ObjCDeclSpec::DQ_PR_strong) && 1754f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1755f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1756f85e193739c953358c865005855253af4f68a497John McCall << "strong" << "weak"; 1757f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 175828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 17599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 17609d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian if ((Attributes & ObjCDeclSpec::DQ_PR_atomic) && 17619d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_nonatomic)) { 17629d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 17639d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian << "atomic" << "nonatomic"; 17649d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian Attributes &= ~ObjCDeclSpec::DQ_PR_atomic; 17659d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian } 17669d1bbeab2475fe45a3d4cb8de6810bc3275f1dd7Fariborz Jahanian 176728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Warn if user supplied no assignment attribute, property is 176828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // readwrite, and this is an object type. 176928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy | 1770f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 1771f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong | 1772f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_weak)) && 177328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyTy->isObjCObjectPointerType()) { 1774bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian if (getLangOptions().ObjCAutoRefCount) 1775bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // With arc, @property definitions should default to (strong) when 1776f21a92d35953adb038ffbe37cd1a4083e0df0ec0Fariborz Jahanian // not specified; including when property is 'readonly'. 1777bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian PropertyDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 1778f21a92d35953adb038ffbe37cd1a4083e0df0ec0Fariborz Jahanian else if (!(Attributes & ObjCDeclSpec::DQ_PR_readonly)) { 1779bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // Skip this warning in gc-only mode. 1780e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor if (getLangOptions().getGC() != LangOptions::GCOnly) 1781bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_no_assignment_attribute); 17820a68dc7f04be1542ce249ff4adb169453698ad91Argyrios Kyrtzidis 1783bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian // If non-gc code warn that this is likely inappropriate. 1784e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor if (getLangOptions().getGC() == LangOptions::NonGC) 1785bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian Diag(Loc, diag::warn_objc_property_default_assign_on_object); 1786bc03aea4bec84d7abecabd26b8583adb687c4089Fariborz Jahanian } 17879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 178828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME: Implement warning dependent on NSCopying being 178928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // implemented. See also: 179028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496> 179128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // (please trim this list while you are at it). 179228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 17939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 179428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & ObjCDeclSpec::DQ_PR_copy) 17952b77cb803c76d01d2d10a58cec9334e2090cd7c3Fariborz Jahanian &&!(Attributes & ObjCDeclSpec::DQ_PR_readonly) 1796e289d81369914678db386f6aa86faf8f178e245dDouglas Gregor && getLangOptions().getGC() == LangOptions::GCOnly 179728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && PropertyTy->isBlockPointerType()) 179828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_copy_missing_on_block); 1799528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian else if (getLangOptions().ObjCAutoRefCount && 1800528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_retain) && 1801528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian !(Attributes & ObjCDeclSpec::DQ_PR_readonly) && 1802528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian !(Attributes & ObjCDeclSpec::DQ_PR_strong) && 1803528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian PropertyTy->isBlockPointerType()) 1804528a499eb84d61667f65b16a13780c135b822f6bFariborz Jahanian Diag(Loc, diag::warn_objc_property_retain_of_block); 180548a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian 180648a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 180748a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian (Attributes & ObjCDeclSpec::DQ_PR_setter)) 180848a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian Diag(Loc, diag::warn_objc_readonly_property_has_setter); 180948a98c7a8467a9570d2fc7f2aab7f5273a3e218eFariborz Jahanian 18109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 1811