SemaObjCProperty.cpp revision f85e193739c953358c865005855253af4f68a497
19d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===--- SemaObjCProperty.cpp - Semantic Analysis for ObjC @property ------===// 29d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 39d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// The LLVM Compiler Infrastructure 49d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 59d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file is distributed under the University of Illinois Open Source 69d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// License. See LICENSE.TXT for details. 79d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 89d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 99d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// This file implements semantic analysis for Objective C @property and 119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// @synthesize declarations. 129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek// 139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek//===----------------------------------------------------------------------===// 149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Initialization.h" 177cd088e519d7e6caa4c4c12db52e0e4ae35d25c2John McCall#include "clang/AST/DeclObjC.h" 1817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian#include "clang/AST/ExprObjC.h" 1950df6ae41f232612e5e88b19e0db9900d08d2f6cJohn McCall#include "llvm/ADT/DenseSet.h" 209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekusing namespace clang; 229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 2328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Grammar actions. 2528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 2628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 27f85e193739c953358c865005855253af4f68a497John McCall/// Check the internal consistency of a property declaration. 28f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyDecl(Sema &S, ObjCPropertyDecl *property) { 29f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl()) return; 30f85e193739c953358c865005855253af4f68a497John McCall 31f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind propertyKind 32f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 33f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime propertyLifetime 34f85e193739c953358c865005855253af4f68a497John McCall = property->getType().getObjCLifetime(); 35f85e193739c953358c865005855253af4f68a497John McCall 36f85e193739c953358c865005855253af4f68a497John McCall // Nothing to do if we don't have a lifetime. 37f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == Qualifiers::OCL_None) return; 38f85e193739c953358c865005855253af4f68a497John McCall 39f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime expectedLifetime; 40f85e193739c953358c865005855253af4f68a497John McCall unsigned selector; 41f85e193739c953358c865005855253af4f68a497John McCall 42f85e193739c953358c865005855253af4f68a497John McCall // Strong properties should have either strong or no lifetime. 43f85e193739c953358c865005855253af4f68a497John McCall if (propertyKind & (ObjCPropertyDecl::OBJC_PR_retain | 44f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_strong | 45f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_copy)) { 46f85e193739c953358c865005855253af4f68a497John McCall expectedLifetime = Qualifiers::OCL_Strong; 47f85e193739c953358c865005855253af4f68a497John McCall selector = 0; 48f85e193739c953358c865005855253af4f68a497John McCall } else if (propertyKind & ObjCPropertyDecl::OBJC_PR_weak) { 49f85e193739c953358c865005855253af4f68a497John McCall expectedLifetime = Qualifiers::OCL_Weak; 50f85e193739c953358c865005855253af4f68a497John McCall selector = 1; 51f85e193739c953358c865005855253af4f68a497John McCall } else if (propertyKind & (ObjCPropertyDecl::OBJC_PR_assign | 52f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_unsafe_unretained) && 53f85e193739c953358c865005855253af4f68a497John McCall property->getType()->isObjCRetainableType()) { 54f85e193739c953358c865005855253af4f68a497John McCall expectedLifetime = Qualifiers::OCL_ExplicitNone; 55f85e193739c953358c865005855253af4f68a497John McCall selector = 2; 56f85e193739c953358c865005855253af4f68a497John McCall } else { 57f85e193739c953358c865005855253af4f68a497John McCall // We have a lifetime qualifier but no dominating property 58f85e193739c953358c865005855253af4f68a497John McCall // attribute. That's okay. 59f85e193739c953358c865005855253af4f68a497John McCall return; 60f85e193739c953358c865005855253af4f68a497John McCall } 61f85e193739c953358c865005855253af4f68a497John McCall 62f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == expectedLifetime) return; 63f85e193739c953358c865005855253af4f68a497John McCall 64f85e193739c953358c865005855253af4f68a497John McCall property->setInvalidDecl(); 65f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), 66f85e193739c953358c865005855253af4f68a497John McCall diag::err_arc_inconsistent_property_lifetime) 67f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 68f85e193739c953358c865005855253af4f68a497John McCall << selector 69f85e193739c953358c865005855253af4f68a497John McCall << propertyLifetime; 70f85e193739c953358c865005855253af4f68a497John McCall} 71f85e193739c953358c865005855253af4f68a497John McCall 72d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnProperty(Scope *S, SourceLocation AtLoc, 73d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall FieldDeclarator &FD, 74d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall ObjCDeclSpec &ODS, 75d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector GetterSel, 76d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Selector SetterSel, 77d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ClassCategory, 78d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool *isOverridingProperty, 794a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek tok::ObjCKeywordKind MethodImplKind, 804a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek DeclContext *lexicalDC) { 8128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek unsigned Attributes = ODS.getPropertyAttributes(); 82f85e193739c953358c865005855253af4f68a497John McCall TypeSourceInfo *TSI = GetTypeForDeclarator(FD.D, S); 83f85e193739c953358c865005855253af4f68a497John McCall QualType T = TSI->getType(); 84f85e193739c953358c865005855253af4f68a497John McCall if ((getLangOptions().getGCMode() != LangOptions::NonGC && 85f85e193739c953358c865005855253af4f68a497John McCall T.isObjCGCWeak()) || 86f85e193739c953358c865005855253af4f68a497John McCall (getLangOptions().ObjCAutoRefCount && 87f85e193739c953358c865005855253af4f68a497John McCall T.getObjCLifetime() == Qualifiers::OCL_Weak)) 88f85e193739c953358c865005855253af4f68a497John McCall Attributes |= ObjCDeclSpec::DQ_PR_weak; 89f85e193739c953358c865005855253af4f68a497John McCall 9028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isReadWrite = ((Attributes & ObjCDeclSpec::DQ_PR_readwrite) || 9128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // default is readwrite! 9228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly)); 9328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // property is defaulted to 'assign' if it is readwrite and is 9428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // not retain or copy 9528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek bool isAssign = ((Attributes & ObjCDeclSpec::DQ_PR_assign) || 9628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (isReadWrite && 9728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_retain) && 98f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_strong) && 99f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_copy) && 100f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) && 101f85e193739c953358c865005855253af4f68a497John McCall !(Attributes & ObjCDeclSpec::DQ_PR_weak))); 10214086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian 103e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Proceed with constructing the ObjCPropertDecls. 104e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *ClassDecl = 105d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall cast<ObjCContainerDecl>(ClassCategory); 106e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 10728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCCategoryDecl *CDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) 108ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian if (CDecl->IsClassExtension()) { 109d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *Res = HandlePropertyInClassExtension(S, CDecl, AtLoc, 110ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian FD, GetterSel, SetterSel, 111ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isAssign, isReadWrite, 112ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian Attributes, 113ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian isOverridingProperty, TSI, 114ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian MethodImplKind); 115f85e193739c953358c865005855253af4f68a497John McCall if (Res) { 116ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes); 117f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 118f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, cast<ObjCPropertyDecl>(Res)); 119f85e193739c953358c865005855253af4f68a497John McCall } 120ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian return Res; 121ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian } 122ae415dc21ee6402cee1675ec8bb965a24f9e5b6bFariborz Jahanian 123f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *Res = CreatePropertyDecl(S, ClassDecl, AtLoc, FD, 124f85e193739c953358c865005855253af4f68a497John McCall GetterSel, SetterSel, 125f85e193739c953358c865005855253af4f68a497John McCall isAssign, isReadWrite, 126f85e193739c953358c865005855253af4f68a497John McCall Attributes, TSI, MethodImplKind); 1274a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek if (lexicalDC) 1284a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek Res->setLexicalDeclContext(lexicalDC); 1294a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek 130842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian // Validate the attributes on the @property. 131842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian CheckObjCPropertyAttributes(Res, AtLoc, Attributes); 132f85e193739c953358c865005855253af4f68a497John McCall 133f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 134f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyDecl(*this, Res); 135f85e193739c953358c865005855253af4f68a497John McCall 136842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian return Res; 137e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 138e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 139d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl * 140e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekSema::HandlePropertyInClassExtension(Scope *S, ObjCCategoryDecl *CDecl, 141e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, FieldDeclarator &FD, 142e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, Selector SetterSel, 143e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 144e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 145e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 146e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek bool *isOverridingProperty, 14783a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *T, 148e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek tok::ObjCKeywordKind MethodImplKind) { 149e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 150e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Diagnose if this property is already in continuation class. 151e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 152e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 1532a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCInterfaceDecl *CCPrimary = CDecl->getClassInterface(); 1542a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 1552a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian if (CCPrimary) 1562a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // Check for duplicate declaration of this property in current and 1572a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian // other class extensions. 1582a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian for (const ObjCCategoryDecl *ClsExtDecl = 1592a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian CCPrimary->getFirstClassExtension(); 1602a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ClsExtDecl; ClsExtDecl = ClsExtDecl->getNextClassExtension()) { 1612a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian if (ObjCPropertyDecl *prevDecl = 1622a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian ObjCPropertyDecl::findPropertyDecl(ClsExtDecl, PropertyId)) { 1632a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(AtLoc, diag::err_duplicate_property); 1642a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian Diag(prevDecl->getLocation(), diag::note_property_declare); 1652a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian return 0; 1662a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 1672a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian } 1682a2891410b02d146b779cdb29eeb9b6d1a9fa030Fariborz Jahanian 169e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Create a new ObjCPropertyDecl with the DeclContext being 170e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // the class extension. 17188f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // FIXME. We should really be using CreatePropertyDecl for this. 172e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 173e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::Create(Context, DC, FD.D.getIdentifierLoc(), 174e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PropertyId, AtLoc, T); 17522f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 17622f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 17722f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian if (Attributes & ObjCDeclSpec::DQ_PR_readwrite) 17822f757b38da3fc9f17ea9e99524064fdfbca3456Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 17988f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian // Set setter/getter selector name. Needed later. 18088f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setGetterName(GetterSel); 18188f5e9be350f4b107f8665183a6d441874e0fcc7Fariborz Jahanian PDecl->setSetterName(SetterSel); 182e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DC->addDecl(PDecl); 183e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 184e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // We need to look in the @interface to see if the @property was 185e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // already declared. 186e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!CCPrimary) { 187e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(CDecl->getLocation(), diag::err_continuation_class); 188e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 189d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 190e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 191e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 192e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Find the property in continuation class's primary class only. 193e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PIDecl = 194e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CCPrimary->FindPropertyVisibleInPrimaryClass(PropertyId); 195e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 196e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (!PIDecl) { 197e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // No matching property found in the primary class. Just fall thru 198e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and add property to continuation class's primary class. 199e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl *PDecl = 200e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek CreatePropertyDecl(S, CCPrimary, AtLoc, 201e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FD, GetterSel, SetterSel, isAssign, isReadWrite, 20223173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek Attributes, T, MethodImplKind, DC); 20380aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian // Mark written attribute as having no attribute because 20480aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian // this is not a user-written property declaration in primary 20580aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian // class. 20680aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian PDecl->setPropertyAttributesAsWritten(ObjCPropertyDecl::OBJC_PR_noattr); 207e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 208e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // A case of continuation class adding a new property in the class. This 209e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // is not what it was meant for. However, gcc supports it and so should we. 210e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter/getters are declared here. 211a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek ProcessPropertyDecl(PDecl, CCPrimary, /* redeclaredProperty = */ 0, 212a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek /* lexicalDC = */ CDecl); 213d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PDecl; 214e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 215e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 216e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // The property 'PIDecl's readonly attribute will be over-ridden 217e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // with continuation class's readwrite property attribute! 21880aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian unsigned PIkind = PIDecl->getPropertyAttributesAsWritten(); 219e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (isReadWrite && (PIkind & ObjCPropertyDecl::OBJC_PR_readonly)) { 220e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek unsigned retainCopyNonatomic = 221e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (ObjCPropertyDecl::OBJC_PR_retain | 222f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_strong | 223e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_copy | 224e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCPropertyDecl::OBJC_PR_nonatomic); 225e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if ((Attributes & retainCopyNonatomic) != 226e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek (PIkind & retainCopyNonatomic)) { 227e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(AtLoc, diag::warn_property_attr_mismatch); 228e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 229e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 2309944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek DeclContext *DC = cast<DeclContext>(CCPrimary); 2319944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek if (!ObjCPropertyDecl::findPropertyDecl(DC, 2329944c769b69b1904a7b16d3ce10fbdc9c67c764fTed Kremenek PIDecl->getDeclName().getAsIdentifierInfo())) { 233e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Protocol is not in the primary class. Must build one for it. 234e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCDeclSpec ProtocolPropertyODS; 235e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // FIXME. Assuming that ObjCDeclSpec::ObjCPropertyAttributeKind 236e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // and ObjCPropertyDecl::PropertyAttributeKind have identical 237e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // values. Should consolidate both into one enum type. 238e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ProtocolPropertyODS. 239e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek setPropertyAttributes((ObjCDeclSpec::ObjCPropertyAttributeKind) 240e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIkind); 241e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 242d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ProtocolPtrTy = 243e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ActOnProperty(S, AtLoc, FD, ProtocolPropertyODS, 244e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getGetterName(), 245e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->getSetterName(), 246d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CCPrimary, isOverridingProperty, 2474a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek MethodImplKind, 2484a2e9ea0c191176ebe996516a9cf4f93b7e932ccTed Kremenek /* lexicalDC = */ CDecl); 249d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall PIDecl = cast<ObjCPropertyDecl>(ProtocolPtrTy); 25028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 251e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->makeitReadWriteAttribute(); 252e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 253e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 254f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) 255f85e193739c953358c865005855253af4f68a497John McCall PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 256e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 257e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 258e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek PIDecl->setSetterName(SetterSel); 259e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } else { 260788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // Tailor the diagnostics for the common case where a readwrite 261788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // property is declared both in the @interface and the continuation. 262788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // This is a common error where the user often intended the original 263788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek // declaration to be readonly. 264788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek unsigned diag = 265788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_readwrite) && 266788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek (PIkind & ObjCPropertyDecl::OBJC_PR_readwrite) 267788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek ? diag::err_use_continuation_class_redeclaration_readwrite 268788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek : diag::err_use_continuation_class; 269788f489a37bf1150deb9378cec6a6eb902d0d1b2Ted Kremenek Diag(AtLoc, diag) 270e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek << CCPrimary->getDeclName(); 271e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Diag(PIDecl->getLocation(), diag::note_property_declare); 272e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek } 273e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek *isOverridingProperty = true; 274e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek // Make sure setter decl is synthesized, and added to primary class's list. 2758254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ProcessPropertyDecl(PIDecl, CCPrimary, PDecl, CDecl); 276d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 277e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek} 278e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 279e3d67bcc7b89b335dbcd097a299658057ea31097Ted KremenekObjCPropertyDecl *Sema::CreatePropertyDecl(Scope *S, 280e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek ObjCContainerDecl *CDecl, 281e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek SourceLocation AtLoc, 282e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek FieldDeclarator &FD, 283e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector GetterSel, 284e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek Selector SetterSel, 285e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isAssign, 286e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const bool isReadWrite, 287e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek const unsigned Attributes, 28883a230c83a54190366138c1a4f4310ef838b88fcJohn McCall TypeSourceInfo *TInfo, 28923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek tok::ObjCKeywordKind MethodImplKind, 29023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek DeclContext *lexicalDC){ 291e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek IdentifierInfo *PropertyId = FD.D.getIdentifier(); 29283a230c83a54190366138c1a4f4310ef838b88fcJohn McCall QualType T = TInfo->getType(); 29328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 29428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Issue a warning if property is 'assign' as default and its object, which is 29528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // gc'able conforms to NSCopying protocol 29628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (getLangOptions().getGCMode() != LangOptions::NonGC && 29728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek isAssign && !(Attributes & ObjCDeclSpec::DQ_PR_assign)) 298c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (const ObjCObjectPointerType *ObjPtrTy = 299c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall T->getAs<ObjCObjectPointerType>()) { 300c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall ObjCInterfaceDecl *IDecl = ObjPtrTy->getObjectType()->getInterface(); 301c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl) 302c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (ObjCProtocolDecl* PNSCopying = 303c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall LookupProtocol(&Context.Idents.get("NSCopying"), AtLoc)) 304c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (IDecl->ClassImplementsProtocol(PNSCopying, true)) 305c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall Diag(AtLoc, diag::warn_implements_nscopying) << PropertyId; 30628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 307c12c5bba6ceb6acd4e51e7a0fc03257da9cfd44eJohn McCall if (T->isObjCObjectType()) 30828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(FD.D.getIdentifierLoc(), diag::err_statically_allocated_object); 30928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 310e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek DeclContext *DC = cast<DeclContext>(CDecl); 31128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *PDecl = ObjCPropertyDecl::Create(Context, DC, 31228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek FD.D.getIdentifierLoc(), 31383a230c83a54190366138c1a4f4310ef838b88fcJohn McCall PropertyId, AtLoc, TInfo); 314e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek 3159f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek if (ObjCPropertyDecl *prevDecl = 3169f550ff05d496e6b9480e5619a21d9da0c9e27c1Ted Kremenek ObjCPropertyDecl::findPropertyDecl(DC, PropertyId)) { 31728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PDecl->getLocation(), diag::err_duplicate_property); 318894ae6ad081465a3b168db7e60ab3f94e3730b57Ted Kremenek Diag(prevDecl->getLocation(), diag::note_property_declare); 31928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 32028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 32123173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek else { 32228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek DC->addDecl(PDecl); 32323173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek if (lexicalDC) 32423173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek PDecl->setLexicalDeclContext(lexicalDC); 32523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek } 32628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 32728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (T->isArrayType() || T->isFunctionType()) { 32828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::err_property_type) << T; 32928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setInvalidDecl(); 33028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 33128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 33228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ProcessDeclAttributes(S, PDecl, FD.D); 33328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 33428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Regardless of setter/getter attribute, we save the default getter/setter 33528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // selector names in anticipation of declaration of setter/getter methods. 33628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setGetterName(GetterSel); 33728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setSetterName(SetterSel); 33828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 33928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_readonly) 34028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readonly); 34128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 34228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_getter) 34328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_getter); 34428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 34528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_setter) 34628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_setter); 34728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 34828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isReadWrite) 34928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_readwrite); 35028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 35128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) 35228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_retain); 35328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 354f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) 355f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_strong); 356f85e193739c953358c865005855253af4f68a497John McCall 357f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_weak) 358f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_weak); 359f85e193739c953358c865005855253af4f68a497John McCall 36028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) 36128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_copy); 36228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 363f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 364f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 365f85e193739c953358c865005855253af4f68a497John McCall 36628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (isAssign) 36728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 36828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 36928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_nonatomic) 37028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_nonatomic); 37145937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian else if (Attributes & ObjCDeclSpec::DQ_PR_atomic) 37245937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_atomic); 37328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 374f85e193739c953358c865005855253af4f68a497John McCall // FIXME: Why do PropertyAttributesAsWritten get set from PropertyAttributes, 375f85e193739c953358c865005855253af4f68a497John McCall // shouldn't PropertyAttributesAsWritten get set *only* through the attributes 376f85e193739c953358c865005855253af4f68a497John McCall // of the ObjCDeclSpec ? 37780aa1cd7973561889e51c1c152c8990a8de9c953Fariborz Jahanian PDecl->setPropertyAttributesAsWritten(PDecl->getPropertyAttributes()); 378f85e193739c953358c865005855253af4f68a497John McCall 379f85e193739c953358c865005855253af4f68a497John McCall // 'unsafe_unretained' is alias for 'assign'. 380f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) 381f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_assign); 382f85e193739c953358c865005855253af4f68a497John McCall if (isAssign) 383f85e193739c953358c865005855253af4f68a497John McCall PDecl->setPropertyAttributes(ObjCPropertyDecl::OBJC_PR_unsafe_unretained); 384f85e193739c953358c865005855253af4f68a497John McCall 38528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (MethodImplKind == tok::objc_required) 38628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Required); 38728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek else if (MethodImplKind == tok::objc_optional) 38828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PDecl->setPropertyImplementation(ObjCPropertyDecl::Optional); 38928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 390e3d67bcc7b89b335dbcd097a299658057ea31097Ted Kremenek return PDecl; 39128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 39228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 393f85e193739c953358c865005855253af4f68a497John McCallstatic void checkARCPropertyImpl(Sema &S, SourceLocation propertyImplLoc, 394f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *property, 395f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar) { 396f85e193739c953358c865005855253af4f68a497John McCall if (property->isInvalidDecl() || ivar->isInvalidDecl()) return; 397f85e193739c953358c865005855253af4f68a497John McCall 398f85e193739c953358c865005855253af4f68a497John McCall QualType propertyType = property->getType(); 399f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime propertyLifetime = propertyType.getObjCLifetime(); 400f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind propertyKind 401f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 402f85e193739c953358c865005855253af4f68a497John McCall 403f85e193739c953358c865005855253af4f68a497John McCall QualType ivarType = ivar->getType(); 404f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime ivarLifetime = ivarType.getObjCLifetime(); 405f85e193739c953358c865005855253af4f68a497John McCall 406f85e193739c953358c865005855253af4f68a497John McCall // Case 1: strong properties. 407f85e193739c953358c865005855253af4f68a497John McCall if (propertyLifetime == Qualifiers::OCL_Strong || 408f85e193739c953358c865005855253af4f68a497John McCall (propertyKind & (ObjCPropertyDecl::OBJC_PR_retain | 409f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_strong | 410f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_copy))) { 411f85e193739c953358c865005855253af4f68a497John McCall switch (ivarLifetime) { 412f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 413f85e193739c953358c865005855253af4f68a497John McCall // Okay. 414f85e193739c953358c865005855253af4f68a497John McCall return; 415f85e193739c953358c865005855253af4f68a497John McCall 416f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 417f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 418f85e193739c953358c865005855253af4f68a497John McCall // These aren't valid lifetimes for object ivars; don't diagnose twice. 419f85e193739c953358c865005855253af4f68a497John McCall return; 420f85e193739c953358c865005855253af4f68a497John McCall 421f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 422f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 423f85e193739c953358c865005855253af4f68a497John McCall S.Diag(propertyImplLoc, diag::err_arc_strong_property_lifetime) 424f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 425f85e193739c953358c865005855253af4f68a497John McCall << ivar->getDeclName() 426f85e193739c953358c865005855253af4f68a497John McCall << ivarLifetime; 427f85e193739c953358c865005855253af4f68a497John McCall break; 428f85e193739c953358c865005855253af4f68a497John McCall } 429f85e193739c953358c865005855253af4f68a497John McCall 430f85e193739c953358c865005855253af4f68a497John McCall // Case 2: weak properties. 431f85e193739c953358c865005855253af4f68a497John McCall } else if (propertyLifetime == Qualifiers::OCL_Weak || 432f85e193739c953358c865005855253af4f68a497John McCall (propertyKind & ObjCPropertyDecl::OBJC_PR_weak)) { 433f85e193739c953358c865005855253af4f68a497John McCall switch (ivarLifetime) { 434f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 435f85e193739c953358c865005855253af4f68a497John McCall // Okay. 436f85e193739c953358c865005855253af4f68a497John McCall return; 437f85e193739c953358c865005855253af4f68a497John McCall 438f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 439f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 440f85e193739c953358c865005855253af4f68a497John McCall // These aren't valid lifetimes for object ivars; don't diagnose twice. 441f85e193739c953358c865005855253af4f68a497John McCall return; 442f85e193739c953358c865005855253af4f68a497John McCall 443f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 444f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 445f85e193739c953358c865005855253af4f68a497John McCall S.Diag(propertyImplLoc, diag::error_weak_property) 446f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 447f85e193739c953358c865005855253af4f68a497John McCall << ivar->getDeclName(); 448f85e193739c953358c865005855253af4f68a497John McCall break; 449f85e193739c953358c865005855253af4f68a497John McCall } 450f85e193739c953358c865005855253af4f68a497John McCall 451f85e193739c953358c865005855253af4f68a497John McCall // Case 3: assign properties. 452f85e193739c953358c865005855253af4f68a497John McCall } else if ((propertyKind & ObjCPropertyDecl::OBJC_PR_assign) && 453f85e193739c953358c865005855253af4f68a497John McCall propertyType->isObjCRetainableType()) { 454f85e193739c953358c865005855253af4f68a497John McCall switch (ivarLifetime) { 455f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 456f85e193739c953358c865005855253af4f68a497John McCall // Okay. 457f85e193739c953358c865005855253af4f68a497John McCall return; 458f85e193739c953358c865005855253af4f68a497John McCall 459f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 460f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 461f85e193739c953358c865005855253af4f68a497John McCall // These aren't valid lifetimes for object ivars; don't diagnose twice. 462f85e193739c953358c865005855253af4f68a497John McCall return; 463f85e193739c953358c865005855253af4f68a497John McCall 464f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 465f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 466f85e193739c953358c865005855253af4f68a497John McCall S.Diag(propertyImplLoc, diag::err_arc_assign_property_lifetime) 467f85e193739c953358c865005855253af4f68a497John McCall << property->getDeclName() 468f85e193739c953358c865005855253af4f68a497John McCall << ivar->getDeclName(); 469f85e193739c953358c865005855253af4f68a497John McCall break; 470f85e193739c953358c865005855253af4f68a497John McCall } 471f85e193739c953358c865005855253af4f68a497John McCall 472f85e193739c953358c865005855253af4f68a497John McCall // Any other property should be ignored. 473f85e193739c953358c865005855253af4f68a497John McCall } else { 474f85e193739c953358c865005855253af4f68a497John McCall return; 475f85e193739c953358c865005855253af4f68a497John McCall } 476f85e193739c953358c865005855253af4f68a497John McCall 477f85e193739c953358c865005855253af4f68a497John McCall S.Diag(property->getLocation(), diag::note_property_declare); 478f85e193739c953358c865005855253af4f68a497John McCall} 479f85e193739c953358c865005855253af4f68a497John McCall 48028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 48128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// ActOnPropertyImplDecl - This routine performs semantic checks and 48228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// builds the AST node for a property implementation declaration; declared 48328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// as @synthesize or @dynamic. 48428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek/// 485d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallDecl *Sema::ActOnPropertyImplDecl(Scope *S, 486d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation AtLoc, 487d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall SourceLocation PropertyLoc, 488d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall bool Synthesize, 489d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ClassCatImpDecl, 490d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall IdentifierInfo *PropertyId, 491a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor IdentifierInfo *PropertyIvar, 492a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor SourceLocation PropertyIvarLoc) { 493e9686572f17968048a5e097254f85c202ea44aecTed Kremenek ObjCContainerDecl *ClassImpDecl = 494d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall cast_or_null<ObjCContainerDecl>(ClassCatImpDecl); 49528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Make sure we have a context for the property implementation declaration. 49628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!ClassImpDecl) { 49728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_context); 498d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 49928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 50028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyDecl *property = 0; 50128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl* IDecl = 0; 50228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Find the class or category class where this property must have 50328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a declaration. 50428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCImplementationDecl *IC = 0; 50528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryImplDecl* CatImplClass = 0; 50628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((IC = dyn_cast<ObjCImplementationDecl>(ClassImpDecl))) { 50728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = IC->getClassInterface(); 50828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // We always synthesize an interface for an implementation 50928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // without an interface decl. So, IDecl is always non-zero. 51028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert(IDecl && 51128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "ActOnPropertyImplDecl - @implementation without @interface"); 51228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 51328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in the @implementation's @interface 51428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = IDecl->FindPropertyDeclaration(PropertyId); 51528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 51628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_property_decl) << IDecl->getDeclName(); 517d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 51828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 519dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian unsigned PIkind = property->getPropertyAttributesAsWritten(); 52045937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian if ((PIkind & (ObjCPropertyDecl::OBJC_PR_atomic | 52145937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian ObjCPropertyDecl::OBJC_PR_nonatomic) ) == 0) { 522dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian if (AtLoc.isValid()) 523dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(AtLoc, diag::warn_implicit_atomic_property); 524dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian else 525dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(IC->getLocation(), diag::warn_auto_implicit_atomic_property); 526dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian Diag(property->getLocation(), diag::note_property_declare); 527dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian } 528dd4430e596fac34e9ce44228a249f71e73effd4aFariborz Jahanian 52928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (const ObjCCategoryDecl *CD = 53028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek dyn_cast<ObjCCategoryDecl>(property->getDeclContext())) { 53128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!CD->IsClassExtension()) { 53228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_category_property) << CD->getDeclName(); 53328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(property->getLocation(), diag::note_property_declare); 534d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 53528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 53628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 53728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if ((CatImplClass = dyn_cast<ObjCCategoryImplDecl>(ClassImpDecl))) { 53828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 53928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_synthesize_category_decl); 540d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 54128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 54228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl = CatImplClass->getClassInterface(); 54328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!IDecl) { 54428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_missing_property_interface); 545d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 54628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 54728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCCategoryDecl *Category = 54828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier()); 54928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 55028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // If category for this implementation not found, it is an error which 55128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // has already been reported eralier. 55228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Category) 553d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 55428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Look for this property declaration in @implementation's category 55528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property = Category->FindPropertyDeclaration(PropertyId); 55628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!property) { 55728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_bad_category_property_decl) 55828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << Category->getDeclName(); 559d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 56028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 56128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 56228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(AtLoc, diag::error_bad_property_context); 563d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 56428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 56528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCIvarDecl *Ivar = 0; 56628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that we have a valid, previously declared ivar for @synthesize 56728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) { 56828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @synthesize 56928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!PropertyIvar) 57028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyIvar = PropertyId; 571f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::PropertyAttributeKind kind 572f85e193739c953358c865005855253af4f68a497John McCall = property->getPropertyAttributes(); 57328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType PropType = Context.getCanonicalType(property->getType()); 57414086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian QualType PropertyIvarType = PropType; 57514086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (PropType->isReferenceType()) 57614086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType = cast<ReferenceType>(PropType)->getPointeeType(); 57728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that this is a previously declared 'ivar' in 'IDecl' interface 57828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCInterfaceDecl *ClassDeclared; 57928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Ivar = IDecl->lookupInstanceVariable(PropertyIvar, ClassDeclared); 58028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!Ivar) { 581f85e193739c953358c865005855253af4f68a497John McCall // In ARC, give the ivar a lifetime qualifier based on its 582f85e193739c953358c865005855253af4f68a497John McCall // property attributes. 583f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount && 584f85e193739c953358c865005855253af4f68a497John McCall !PropertyIvarType.getObjCLifetime()) { 585f85e193739c953358c865005855253af4f68a497John McCall 586f85e193739c953358c865005855253af4f68a497John McCall // retain/copy have retaining lifetime. 587f85e193739c953358c865005855253af4f68a497John McCall if (kind & (ObjCPropertyDecl::OBJC_PR_retain | 588f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_strong | 589f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_copy)) { 590f85e193739c953358c865005855253af4f68a497John McCall Qualifiers qs; 591f85e193739c953358c865005855253af4f68a497John McCall qs.addObjCLifetime(Qualifiers::OCL_Strong); 592f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType = Context.getQualifiedType(PropertyIvarType, qs); 593f85e193739c953358c865005855253af4f68a497John McCall } 594f85e193739c953358c865005855253af4f68a497John McCall else if (kind & ObjCPropertyDecl::OBJC_PR_weak) { 595f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCNoAutoRefCountRuntime) { 596f85e193739c953358c865005855253af4f68a497John McCall Diag(PropertyLoc, diag::err_arc_weak_no_runtime); 597f85e193739c953358c865005855253af4f68a497John McCall Diag(property->getLocation(), diag::note_property_declare); 598f85e193739c953358c865005855253af4f68a497John McCall } 599f85e193739c953358c865005855253af4f68a497John McCall Qualifiers qs; 600f85e193739c953358c865005855253af4f68a497John McCall qs.addObjCLifetime(Qualifiers::OCL_Weak); 601f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType = Context.getQualifiedType(PropertyIvarType, qs); 602f85e193739c953358c865005855253af4f68a497John McCall } 603f85e193739c953358c865005855253af4f68a497John McCall else if (kind & ObjCPropertyDecl::OBJC_PR_assign && 604f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType->isObjCRetainableType()) { 605f85e193739c953358c865005855253af4f68a497John McCall // assume that an 'assign' property synthesizes __unsafe_unretained 606f85e193739c953358c865005855253af4f68a497John McCall // ivar 607f85e193739c953358c865005855253af4f68a497John McCall Qualifiers qs; 608f85e193739c953358c865005855253af4f68a497John McCall qs.addObjCLifetime(Qualifiers::OCL_ExplicitNone); 609f85e193739c953358c865005855253af4f68a497John McCall PropertyIvarType = Context.getQualifiedType(PropertyIvarType, qs); 610f85e193739c953358c865005855253af4f68a497John McCall } 611f85e193739c953358c865005855253af4f68a497John McCall } 612f85e193739c953358c865005855253af4f68a497John McCall 613f85e193739c953358c865005855253af4f68a497John McCall if (kind & ObjCPropertyDecl::OBJC_PR_weak && 614f85e193739c953358c865005855253af4f68a497John McCall !getLangOptions().ObjCAutoRefCount && 615f85e193739c953358c865005855253af4f68a497John McCall getLangOptions().getGCMode() == LangOptions::NonGC) { 616f85e193739c953358c865005855253af4f68a497John McCall Diag(PropertyLoc, diag::error_synthesize_weak_non_arc_or_gc); 617f85e193739c953358c865005855253af4f68a497John McCall Diag(property->getLocation(), diag::note_property_declare); 618f85e193739c953358c865005855253af4f68a497John McCall } 619f85e193739c953358c865005855253af4f68a497John McCall 620ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Ivar = ObjCIvarDecl::Create(Context, ClassImpDecl, 621ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara PropertyLoc, PropertyLoc, PropertyIvar, 62214086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType, /*Dinfo=*/0, 6237504966cc0d07eac26baabec80a7406695efb307Fariborz Jahanian ObjCIvarDecl::Private, 624ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian (Expr *)0, true); 62529fa69addf8b19871e7866c32c92b5d142c4bfbcDaniel Dunbar ClassImpDecl->addDecl(Ivar); 62628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IDecl->makeDeclVisibleInContext(Ivar, false); 62728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property->setPropertyIvarDecl(Ivar); 62828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 62928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!getLangOptions().ObjCNonFragileABI) 63028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_missing_property_ivar_decl) << PropertyId; 63128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 63228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 63328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (getLangOptions().ObjCNonFragileABI && 63428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ClassDeclared != IDecl) { 63528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_ivar_in_superclass_use) 63628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName() 63728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << ClassDeclared->getDeclName(); 63828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Ivar->getLocation(), diag::note_previous_access_declaration) 6394087f27e5416c799bcb6be072f905be752acb61cDaniel Dunbar << Ivar << Ivar->getName(); 64028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so more errors are caught. 64128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 64228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType IvarType = Context.getCanonicalType(Ivar->getType()); 64328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 64428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check that type of property and its ivar are type compatible. 64514086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (PropertyIvarType != IvarType) { 64662ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian bool compat = false; 64714086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (isa<ObjCObjectPointerType>(PropertyIvarType) 648f85e193739c953358c865005855253af4f68a497John McCall && isa<ObjCObjectPointerType>(IvarType)) 64962ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian compat = 65062ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian Context.canAssignObjCInterfaces( 65114086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian PropertyIvarType->getAs<ObjCObjectPointerType>(), 65262ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian IvarType->getAs<ObjCObjectPointerType>()); 653b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor else { 654b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor SourceLocation Loc = PropertyIvarLoc; 655b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor if (Loc.isInvalid()) 656b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor Loc = PropertyLoc; 65714086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian compat = (CheckAssignmentConstraints(Loc, PropertyIvarType, IvarType) 658daa8e4e888758d55a7a759dd4a91b83921cef222John McCall == Compatible); 659b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor } 66062ac5d01aade35790a6d8e814edb21062da5d3f7Fariborz Jahanian if (!compat) { 66128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 662f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 663f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 664f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 66528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Note! I deliberately want it to fall thru so, we have a 66628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // a property implementation and to avoid future warnings. 66728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 66828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 66928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME! Rules for properties are somewhat different that those 67028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // for assignments. Use a new routine to consolidate all cases; 67128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // specifically for property redeclarations as well as for ivars. 67214086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian QualType lhsType =Context.getCanonicalType(PropertyIvarType).getUnqualifiedType(); 67328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek QualType rhsType =Context.getCanonicalType(IvarType).getUnqualifiedType(); 67428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (lhsType != rhsType && 67528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek lhsType->isArithmeticType()) { 67628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_ivar_type) 677f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << property->getDeclName() << PropType 678f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek << Ivar->getDeclName() << IvarType; 679f921a4868cf1876636f6684e7f68697b18c0cb47Ted Kremenek Diag(Ivar->getLocation(), diag::note_ivar_decl); 68028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 68128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 68228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // __weak is explicit. So it works on Canonical type. 683f85e193739c953358c865005855253af4f68a497John McCall if ((PropType.isObjCGCWeak() && !IvarType.isObjCGCWeak() && 684f85e193739c953358c865005855253af4f68a497John McCall getLangOptions().getGCMode() != LangOptions::NonGC)) { 68528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_weak_property) 68628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 68728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 68828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 689f85e193739c953358c865005855253af4f68a497John McCall // Fall thru - see previous comment 69028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if ((property->getType()->isObjCObjectPointerType() || 69128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropType.isObjCGCStrong()) && IvarType.isObjCGCWeak() && 69228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek getLangOptions().getGCMode() != LangOptions::NonGC) { 69328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_strong_property) 69428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << property->getDeclName() << Ivar->getDeclName(); 69528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Fall thru - see previous comment 69628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 69728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 698f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 699f85e193739c953358c865005855253af4f68a497John McCall checkARCPropertyImpl(*this, PropertyLoc, property, Ivar); 70028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (PropertyIvar) 70128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // @dynamic 70228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_dynamic_property_ivar_decl); 703f85e193739c953358c865005855253af4f68a497John McCall 70428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek assert (property && "ActOnPropertyImplDecl - property declaration missing"); 70528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl *PIDecl = 70628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Create(Context, CurContext, AtLoc, PropertyLoc, 70728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek property, 70828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Synthesize ? 70928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCPropertyImplDecl::Synthesize 71028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek : ObjCPropertyImplDecl::Dynamic), 711a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor Ivar, PropertyIvarLoc); 71217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *getterMethod = property->getGetterMethodDecl()) { 71317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian getterMethod->createImplicitParams(Context, IDecl); 7140313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian if (getLangOptions().CPlusPlus && Synthesize && 7150313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian Ivar->getType()->isRecordType()) { 71617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // For Objective-C++, need to synthesize the AST for the IVAR object to be 71717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // returned by the getter as it must conform to C++'s copy-return rules. 71817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 71917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = getterMethod->getSelfDecl(); 72017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 721f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall new (Context) DeclRefExpr(SelfDecl, SelfDecl->getType(), 722f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_RValue, SourceLocation()); 72317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *IvarRefExpr = 72417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 72517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 72660d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult Res = 72717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PerformCopyInitialization(InitializedEntity::InitializeResult( 7283c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor SourceLocation(), 7293c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor getterMethod->getResultType(), 7303c9034cb7ff1d6c1e4ecd1b44c98f553df013c7cDouglas Gregor /*NRVO=*/false), 73117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SourceLocation(), 73217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Owned(IvarRefExpr)); 73317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (!Res.isInvalid()) { 73417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *ResExpr = Res.takeAs<Expr>(); 73517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ResExpr) 7364765fa05b5652fcc4356371c2f481d0ea9a1b007John McCall ResExpr = MaybeCreateExprWithCleanups(ResExpr); 73717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setGetterCXXConstructor(ResExpr); 73817cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 73917cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 74017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 74117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian if (ObjCMethodDecl *setterMethod = property->getSetterMethodDecl()) { 74217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian setterMethod->createImplicitParams(Context, IDecl); 7430313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian if (getLangOptions().CPlusPlus && Synthesize 7440313f441b72ef6b69a93e5003c684b01cb72fd46Fariborz Jahanian && Ivar->getType()->isRecordType()) { 74517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian // FIXME. Eventually we want to do this for Objective-C as well. 74617cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ImplicitParamDecl *SelfDecl = setterMethod->getSelfDecl(); 74717cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian DeclRefExpr *SelfExpr = 748f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall new (Context) DeclRefExpr(SelfDecl, SelfDecl->getType(), 749f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_RValue, SourceLocation()); 75017cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian Expr *lhs = 75117cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian new (Context) ObjCIvarRefExpr(Ivar, Ivar->getType(), AtLoc, 75217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian SelfExpr, true, true); 75317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ObjCMethodDecl::param_iterator P = setterMethod->param_begin(); 75417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian ParmVarDecl *Param = (*P); 75514086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian QualType T = Param->getType(); 75614086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian if (T->isReferenceType()) 75761750f2bed7f5c0e440318841e3be385920b22f3Fariborz Jahanian T = T->getAs<ReferenceType>()->getPointeeType(); 75814086764e340267e17803d0f8243070ffae2c76eFariborz Jahanian Expr *rhs = new (Context) DeclRefExpr(Param, T, 759f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall VK_LValue, SourceLocation()); 760fa432391a708448518df1e6ced4e34f4c349d169Fariborz Jahanian ExprResult Res = BuildBinOp(S, lhs->getLocEnd(), 7612de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BO_Assign, lhs, rhs); 76217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian PIDecl->setSetterCXXAssignment(Res.takeAs<Expr>()); 76317cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 76417cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian } 76517cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanian 76628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (IC) { 76728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 76828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 76928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->FindPropertyImplIvarDecl(PropertyIvar)) { 77028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 77128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 77228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 77328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 77428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 77528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 77628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl 77728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek = IC->FindPropertyImplDecl(PropertyId)) { 77828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 77928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 780d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 78128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 78228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek IC->addPropertyImplementation(PIDecl); 783e776f88430eb77ce8d58f2e6ec10da1383b71de8Fariborz Jahanian if (getLangOptions().ObjCDefaultSynthProperties && 784e776f88430eb77ce8d58f2e6ec10da1383b71de8Fariborz Jahanian getLangOptions().ObjCNonFragileABI2) { 785ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // Diagnose if an ivar was lazily synthesdized due to a previous 786ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian // use and if 1) property is @dynamic or 2) property is synthesized 787cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // but it requires an ivar of different name. 788411c25c4512f00e07442e8818d011c7e0902d739Fariborz Jahanian ObjCInterfaceDecl *ClassDeclared=0; 789ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian ObjCIvarDecl *Ivar = 0; 790ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (!Synthesize) 791ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 792ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian else { 793ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian if (PropertyIvar && PropertyIvar != PropertyId) 794ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar = IDecl->lookupInstanceVariable(PropertyId, ClassDeclared); 795ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 796cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian // Issue diagnostics only if Ivar belongs to current class. 797cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian if (Ivar && Ivar->getSynthesize() && 798cdaa6a8fed16d8bd3987fb4f3304dfb4e52876c3Fariborz Jahanian IC->getClassInterface() == ClassDeclared) { 799ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Diag(Ivar->getLocation(), diag::err_undeclared_var_use) 800ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian << PropertyId; 801ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian Ivar->setInvalidDecl(); 802ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 803ad51e74030a59a8aa4ef0ebca1d7a701602ef53bFariborz Jahanian } 80428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else { 80528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Synthesize) 80628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 80728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplIvarDecl(PropertyIvar)) { 80828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_duplicate_ivar_use) 80928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyId << PPIDecl->getPropertyDecl()->getIdentifier() 81028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << PropertyIvar; 81128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_use); 81228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 81328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 81428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (ObjCPropertyImplDecl *PPIDecl = 81528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->FindPropertyImplDecl(PropertyId)) { 81628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PropertyLoc, diag::error_property_implemented) << PropertyId; 81728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(PPIDecl->getLocation(), diag::note_previous_declaration); 818d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return 0; 81928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 82028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek CatImplClass->addPropertyImplementation(PIDecl); 82128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 82228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 823d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall return PIDecl; 82428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek} 82528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 82628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 82728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek// Helper methods. 82828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek//===----------------------------------------------------------------------===// 82928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek 8309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// DiagnosePropertyMismatch - Compares two properties for their 8319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// attributes and types and warns on a variety of inconsistencies. 8329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 8339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 8349d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::DiagnosePropertyMismatch(ObjCPropertyDecl *Property, 8359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperProperty, 8369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const IdentifierInfo *inheritedName) { 8379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 8389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Property->getPropertyAttributes(); 8399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind SAttr = 8409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SuperProperty->getPropertyAttributes(); 8419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_readonly) 8429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek && (SAttr & ObjCPropertyDecl::OBJC_PR_readwrite)) 8439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_readonly_property) 8449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << inheritedName; 8459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_copy) 8469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_copy)) 8479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 8489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "copy" << inheritedName; 849f85e193739c953358c865005855253af4f68a497John McCall else { 850f85e193739c953358c865005855253af4f68a497John McCall unsigned CAttrRetain = 851f85e193739c953358c865005855253af4f68a497John McCall (CAttr & 852f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 853f85e193739c953358c865005855253af4f68a497John McCall unsigned SAttrRetain = 854f85e193739c953358c865005855253af4f68a497John McCall (SAttr & 855f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_strong)); 856f85e193739c953358c865005855253af4f68a497John McCall bool CStrong = (CAttrRetain != 0); 857f85e193739c953358c865005855253af4f68a497John McCall bool SStrong = (SAttrRetain != 0); 858f85e193739c953358c865005855253af4f68a497John McCall if (CStrong != SStrong) 859f85e193739c953358c865005855253af4f68a497John McCall Diag(Property->getLocation(), diag::warn_property_attribute) 860f85e193739c953358c865005855253af4f68a497John McCall << Property->getDeclName() << "retain (or strong)" << inheritedName; 861f85e193739c953358c865005855253af4f68a497John McCall } 8629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 8639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((CAttr & ObjCPropertyDecl::OBJC_PR_nonatomic) 8649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek != (SAttr & ObjCPropertyDecl::OBJC_PR_nonatomic)) 8659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 8669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "atomic" << inheritedName; 8679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getSetterName() != SuperProperty->getSetterName()) 8689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 8699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "setter" << inheritedName; 8709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Property->getGetterName() != SuperProperty->getGetterName()) 8719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_attribute) 8729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getDeclName() << "getter" << inheritedName; 8739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 8749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType LHSType = 8759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SuperProperty->getType()); 8769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek QualType RHSType = 8779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(Property->getType()); 8789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 8799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!Context.typesAreCompatible(LHSType, RHSType)) { 8809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Incorporate this test with typesAreCompatible. 8819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (LHSType->isObjCQualifiedIdType() && RHSType->isObjCQualifiedIdType()) 8829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Context.ObjCQualifiedIdTypesAreCompatible(LHSType, RHSType, false)) 8839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 8849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::warn_property_types_are_incompatible) 8859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getType() << SuperProperty->getType() << inheritedName; 8869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 8879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 8889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 8899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::DiagnosePropertyAccessorMismatch(ObjCPropertyDecl *property, 8909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, 8919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc) { 8929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod && 8939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->getResultType() != property->getType()) { 8949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AssignConvertType result = Incompatible; 8951c23e91ef66688d20868b6bab3b5589a119eb603John McCall if (property->getType()->isObjCObjectPointerType()) 896b608b987718c6d841115464f79ab2d1820a63e17Douglas Gregor result = CheckAssignmentConstraints(Loc, GetterMethod->getResultType(), 8971c23e91ef66688d20868b6bab3b5589a119eb603John McCall property->getType()); 8989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (result != Compatible) { 8999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Loc, diag::warn_accessor_property_type_mismatch) 9009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 9019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << GetterMethod->getSelector(); 9029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(GetterMethod->getLocation(), diag::note_declared_at); 9039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 9049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 9079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ComparePropertiesInBaseAndSuper - This routine compares property 9109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declarations in base and its super class, if any, and issues 911fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner/// diagnostics in a variety of inconsistent situations. 9129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 9139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ComparePropertiesInBaseAndSuper(ObjCInterfaceDecl *IDecl) { 9149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *SDecl = IDecl->getSuperClass(); 9159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SDecl) 9169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 9179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: O(N^2) 9189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator S = SDecl->prop_begin(), 9199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = SDecl->prop_end(); S != E; ++S) { 9209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *SuperPDecl = (*S); 9219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Does property in super class has declaration in current class? 9229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCInterfaceDecl::prop_iterator I = IDecl->prop_begin(), 9239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); I != E; ++I) { 9249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *PDecl = (*I); 9259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SuperPDecl->getIdentifier() == PDecl->getIdentifier()) 9269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch(PDecl, SuperPDecl, 9279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SDecl->getIdentifier()); 9289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// MatchOneProtocolPropertiesInClass - This routine goes thru the list 9339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// of properties declared in a protocol and compares their attribute against 9349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the same property declared in the class or category. 9359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 9369d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::MatchOneProtocolPropertiesInClass(Decl *CDecl, 9379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *PDecl) { 9389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 9399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 9409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 9419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 9429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "MatchOneProtocolPropertiesInClass"); 9439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CatDecl->IsClassExtension()) 9449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 9459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 9469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 9479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl::prop_iterator CP, CE; 9489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in category's list of properties? 9492d2f9368d35b3628c7e3b4563f74849a0f901a00Ted Kremenek for (CP = CatDecl->prop_begin(), CE = CatDecl->prop_end(); CP!=CE; ++CP) 9509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 9519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 9529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 9539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 9549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 9559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 9579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 9599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 9609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Pr = (*P); 9619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl::prop_iterator CP, CE; 9629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is this property already in class's list of properties? 9639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (CP = IDecl->prop_begin(), CE = IDecl->prop_end(); CP != CE; ++CP) 9649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((*CP)->getIdentifier() == Pr->getIdentifier()) 9659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek break; 9669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CP != CE) 9679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Property protocol already exist in class. Diagnose any mismatch. 9689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyMismatch((*CP), Pr, PDecl->getIdentifier()); 9699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 9709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 9719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CompareProperties - This routine compares properties 9739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// declared in 'ClassOrProtocol' objects (which can be a class or an 9749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// inherited protocol with the list of properties for class/category 'CDecl' 9759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 976d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CompareProperties(Decl *CDecl, Decl *ClassOrProtocol) { 977d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall Decl *ClassDecl = ClassOrProtocol; 9789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDecl); 9799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!IDecl) { 9819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Category 9829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCCategoryDecl *CatDecl = static_cast<ObjCCategoryDecl*>(CDecl); 9839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek assert (CatDecl && "CompareProperties"); 9849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *MDecl = dyn_cast<ObjCCategoryDecl>(ClassDecl)) { 9859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = MDecl->protocol_begin(), 9869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MDecl->protocol_end(); P != E; ++P) 9879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of category with those of protocol (*P) 9889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 9899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 9909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this category and recursively match 9919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those in the category. 9929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl::protocol_iterator P = CatDecl->protocol_begin(), 9939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CatDecl->protocol_end(); P != E; ++P) 994d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(CatDecl, *P); 9959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 9969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 9979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 9989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 9999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(CatDecl, *P); 10009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 10029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *MDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) { 100553b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 100653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = MDecl->all_referenced_protocol_begin(), 100753b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = MDecl->all_referenced_protocol_end(); P != E; ++P) 10089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Match properties of class IDecl with those of protocol (*P). 10099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 10109d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10119d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Go thru the list of protocols for this class and recursively match 10129d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // their properties with those declared in the class. 101353b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 101453b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek P = IDecl->all_referenced_protocol_begin(), 101553b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); P != E; ++P) 1016d226f65006733ed7f709c3174f22ce33391cb58fJohn McCall CompareProperties(IDecl, *P); 10179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else { 10189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCProtocolDecl *MD = cast<ObjCProtocolDecl>(ClassDecl); 10199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator P = MD->protocol_begin(), 10209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = MD->protocol_end(); P != E; ++P) 10219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek MatchOneProtocolPropertiesInClass(IDecl, *P); 10229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 10249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// isPropertyReadonly - Return true if property is readonly, by searching 10269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// for the property in the class and in its categories and implementations 10279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// 10289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekbool Sema::isPropertyReadonly(ObjCPropertyDecl *PDecl, 10299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCInterfaceDecl *IDecl) { 10309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // by far the most common case. 10319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!PDecl->isReadOnly()) 10329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 10339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if interface has a user defined setter, 10349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 10359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IDecl->getInstanceMethod(PDecl->getSetterName())) 10369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 10379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Main class has the property as 'readonly'. Must search 10399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // through the category list to see if the property's 10409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // attribute has been over-ridden to 'readwrite'. 10419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCCategoryDecl *Category = IDecl->getCategoryList(); 10429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category; Category = Category->getNextClassCategory()) { 10439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Even if property is ready only, if a category has a user defined setter, 10449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // it is not considered read only. 10459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Category->getInstanceMethod(PDecl->getSetterName())) 10469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 10479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *P = 10489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Category->FindPropertyDeclaration(PDecl->getIdentifier()); 10499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (P && !P->isReadOnly()) 10509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 10519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Also, check for definition of a setter method in the implementation if 10549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // all else failed. 10559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(CurContext)) { 10569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *IMD = 10579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCImplementationDecl>(OMD->getDeclContext())) { 10589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (IMD->getInstanceMethod(PDecl->getSetterName())) 10599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 10609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else if (ObjCCategoryImplDecl *CIMD = 10619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCCategoryImplDecl>(OMD->getDeclContext())) { 10629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (CIMD->getInstanceMethod(PDecl->getSetterName())) 10639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 10649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Lastly, look through the implementation (if one is in scope). 10679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCImplementationDecl *ImpDecl = IDecl->getImplementation()) 10689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ImpDecl->getInstanceMethod(PDecl->getSetterName())) 10699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return false; 10709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // If all fails, look at the super class. 10719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *SIDecl = IDecl->getSuperClass()) 10729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return isPropertyReadonly(PDecl, SIDecl); 10739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return true; 10749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 10759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 10769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// CollectImmediateProperties - This routine collects all properties in 10779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// the class and its conforming protocols; but not those it its super class. 10789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::CollectImmediateProperties(ObjCContainerDecl *CDecl, 1079cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap, 1080cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& SuperPropMap) { 10819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 10829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 10839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 10849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 10859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 10869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 108853b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 108953b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 109053b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 1091cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 10929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 10939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (ObjCCategoryDecl *CATDecl = dyn_cast<ObjCCategoryDecl>(CDecl)) { 10949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!CATDecl->IsClassExtension()) 10959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = CATDecl->prop_begin(), 10969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->prop_end(); P != E; ++P) { 10979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 10989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropMap[Prop->getIdentifier()] = Prop; 10999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 110153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCCategoryDecl::protocol_iterator PI = CATDecl->protocol_begin(), 11029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = CATDecl->protocol_end(); PI != E; ++PI) 1103cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 11049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 11069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 11079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 11089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 1109cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *PropertyFromSuper = SuperPropMap[Prop->getIdentifier()]; 1110cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // Exclude property for protocols which conform to class's super-class, 1111cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian // as super-class has to implement the property. 1112cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropertyFromSuper || PropertyFromSuper != Prop) { 1113cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian ObjCPropertyDecl *&PropEntry = PropMap[Prop->getIdentifier()]; 1114cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (!PropEntry) 1115cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian PropEntry = Prop; 1116cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian } 11179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 11199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 11209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) 1121cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties((*PI), PropMap, SuperPropMap); 11229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 11249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1125509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectClassPropertyImplementations - This routine collects list of 1126509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in the class. This includes, class's 1127509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// and its conforming protocols' properties. 1128509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectClassPropertyImplementations(ObjCContainerDecl *CDecl, 1129509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 1130509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) { 1131509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 1132509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = IDecl->prop_end(); P != E; ++P) { 1133509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = (*P); 1134509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 1135509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 113653b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 113753b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 113853b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) 1139509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 1140509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1141509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian else if (ObjCProtocolDecl *PDecl = dyn_cast<ObjCProtocolDecl>(CDecl)) { 1142509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 1143509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->prop_end(); P != E; ++P) { 1144509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = (*P); 1145509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian PropMap[Prop->getIdentifier()] = Prop; 1146509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1147509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // scan through protocol's protocols. 1148509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 1149509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian E = PDecl->protocol_end(); PI != E; ++PI) 1150509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations((*PI), PropMap); 1151509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1152509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 1153509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1154509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// CollectSuperClassPropertyImplementations - This routine collects list of 1155509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties to be implemented in super class(s) and also coming from their 1156509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// conforming protocols. 1157509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianstatic void CollectSuperClassPropertyImplementations(ObjCInterfaceDecl *CDecl, 1158509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>& PropMap) { 1159509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (ObjCInterfaceDecl *SDecl = CDecl->getSuperClass()) { 1160509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian while (SDecl) { 1161509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(SDecl, PropMap); 1162509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian SDecl = SDecl->getSuperClass(); 1163509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1164509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian } 1165509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 1166509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 11679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// LookupPropertyDecl - Looks up a property in the current class and all 11689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// its protocols. 11699d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekObjCPropertyDecl *Sema::LookupPropertyDecl(const ObjCContainerDecl *CDecl, 11709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek IdentifierInfo *II) { 11719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCInterfaceDecl *IDecl = 11729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCInterfaceDecl>(CDecl)) { 11739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator P = IDecl->prop_begin(), 11749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); P != E; ++P) { 11759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 11769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 11779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 11789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through class's protocols. 118053b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek for (ObjCInterfaceDecl::all_protocol_iterator 118153b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek PI = IDecl->all_referenced_protocol_begin(), 118253b9441b5a81a24fa1f66f3f6416f1e36baa9c2fTed Kremenek E = IDecl->all_referenced_protocol_end(); PI != E; ++PI) { 11839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 11849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 11859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 11869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek else if (const ObjCProtocolDecl *PDecl = 11899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek dyn_cast<ObjCProtocolDecl>(CDecl)) { 11909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::prop_iterator P = PDecl->prop_begin(), 11919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->prop_end(); P != E; ++P) { 11929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = (*P); 11939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->getIdentifier() == II) 11949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 11959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 11969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // scan through protocol's protocols. 11979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCProtocolDecl::protocol_iterator PI = PDecl->protocol_begin(), 11989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = PDecl->protocol_end(); PI != E; ++PI) { 11999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = LookupPropertyDecl((*PI), II); 12009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop) 12019d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return Prop; 12029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return 0; 12059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 12069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1207509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// DefaultSynthesizeProperties - This routine default synthesizes all 1208509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian/// properties which must be synthesized in class's @implementation. 1209509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanianvoid Sema::DefaultSynthesizeProperties (Scope *S, ObjCImplDecl* IMPDecl, 1210509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCInterfaceDecl *IDecl) { 1211509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1212509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 1213509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectClassPropertyImplementations(IDecl, PropMap); 1214509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (PropMap.empty()) 1215509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian return; 1216509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 1217509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1218509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian 1219509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 1220509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 1221509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian ObjCPropertyDecl *Prop = P->second; 1222509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // If property to be implemented in the super class, ignore. 1223509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (SuperPropMap[Prop->getIdentifier()]) 1224509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 1225509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian // Is there a matching propery synthesize/dynamic? 1226509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian if (Prop->isInvalidDecl() || 1227509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 1228509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian IMPDecl->FindPropertyImplIvarDecl(Prop->getIdentifier())) 1229509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian continue; 1230d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian // Property may have been synthesized by user. 1231d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian if (IMPDecl->FindPropertyImplDecl(Prop->getIdentifier())) 1232d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian continue; 123395f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getGetterName())) { 123495f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (Prop->getPropertyAttributes() & ObjCPropertyDecl::OBJC_PR_readonly) 123595f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 123695f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian if (IMPDecl->getInstanceMethod(Prop->getSetterName())) 123795f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian continue; 123895f1b86b73a9a203311adc7646f2fa9ee5cdd2b7Fariborz Jahanian } 1239d3635b9681daaef74974932f77080910b032b9fdFariborz Jahanian 12402a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek 12412a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // We use invalid SourceLocations for the synthesized ivars since they 12422a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // aren't really synthesized at a particular location; they just exist. 12432a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // Saying that they are located at the @implementation isn't really going 12442a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek // to help users. 12452a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek ActOnPropertyImplDecl(S, SourceLocation(), SourceLocation(), 12462a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek true,IMPDecl, 1247a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor Prop->getIdentifier(), Prop->getIdentifier(), 1248a4ffd85a6684e42f900aad5459e58ad91bb88755Douglas Gregor SourceLocation()); 12492a6af6b7874e41f3e6213e8d18623c4bac150354Ted Kremenek } 1250509d477ae5a24282719320fe92038ccf57358840Fariborz Jahanian} 12519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 125217cb326cb62a59f53d92236394af40eaae4eddbdFariborz Jahanianvoid Sema::DiagnoseUnimplementedProperties(Scope *S, ObjCImplDecl* IMPDecl, 12539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl *CDecl, 12549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek const llvm::DenseSet<Selector>& InsMap) { 1255cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> SuperPropMap; 1256cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) 1257cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectSuperClassPropertyImplementations(IDecl, SuperPropMap); 1258cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian 12599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*> PropMap; 1260cfa6a27f3cc5add888c6ac84dbcc45854cfd8666Fariborz Jahanian CollectImmediateProperties(CDecl, PropMap, SuperPropMap); 12619d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PropMap.empty()) 12629d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 12639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 12649d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek llvm::DenseSet<ObjCPropertyDecl *> PropImplMap; 12659d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCImplDecl::propimpl_iterator 12669d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I = IMPDecl->propimpl_begin(), 12679d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek EI = IMPDecl->propimpl_end(); I != EI; ++I) 12689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropImplMap.insert((*I)->getPropertyDecl()); 12699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 12709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (llvm::DenseMap<IdentifierInfo *, ObjCPropertyDecl*>::iterator 12719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek P = PropMap.begin(), E = PropMap.end(); P != E; ++P) { 12729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Prop = P->second; 12739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Is there a matching propery synthesize/dynamic? 12749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (Prop->isInvalidDecl() || 12759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Prop->getPropertyImplementation() == ObjCPropertyDecl::Optional || 12769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek PropImplMap.count(Prop)) 12779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 12789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!InsMap.count(Prop->getGetterName())) { 12799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Prop->getLocation(), 12809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 12819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 12829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 12839d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getGetterName(); 12849d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(IMPDecl->getLocation(), 12859d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::note_property_impl_required); 12869d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12879d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 12889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!Prop->isReadOnly() && !InsMap.count(Prop->getSetterName())) { 12899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Prop->getLocation(), 12909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek isa<ObjCCategoryDecl>(CDecl) ? 12919d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required_in_category : 12929d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_setter_getter_impl_required) 12939d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Prop->getDeclName() << Prop->getSetterName(); 12949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(IMPDecl->getLocation(), 12959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::note_property_impl_required); 12969d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12979d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 12989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 12999d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 13009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid 13019d64c15223497f31899cc47fbe1531873dc06f2eTed KremenekSema::AtomicPropertySetterGetterRules (ObjCImplDecl* IMPDecl, 13029d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCContainerDecl* IDecl) { 13039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Rules apply in non-GC mode only 13049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (getLangOptions().getGCMode() != LangOptions::NonGC) 13059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek return; 13069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek for (ObjCContainerDecl::prop_iterator I = IDecl->prop_begin(), 13079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek E = IDecl->prop_end(); 13089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek I != E; ++I) { 13099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl *Property = (*I); 131094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *GetterMethod = 0; 131194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis ObjCMethodDecl *SetterMethod = 0; 131294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis bool LookedUpGetterSetter = false; 131394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 13149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned Attributes = Property->getPropertyAttributes(); 131594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis unsigned AttributesAsWrittern = Property->getPropertyAttributesAsWritten(); 131694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 131745937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian if (!(AttributesAsWrittern & ObjCPropertyDecl::OBJC_PR_atomic) && 131845937ae10a0f70f74508165aab4f2b63e18ea747Fariborz Jahanian !(AttributesAsWrittern & ObjCPropertyDecl::OBJC_PR_nonatomic)) { 131994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 132094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 132194659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 132294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (GetterMethod) { 132394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(GetterMethod->getLocation(), 132494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1325293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 0; 132694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 132794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 132894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (SetterMethod) { 132994659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(SetterMethod->getLocation(), 133094659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis diag::warn_default_atomic_custom_getter_setter) 1331293a45e724a15fb58b8805a5791f9f3aee769cf6Argyrios Kyrtzidis << Property->getIdentifier() << 1; 133294659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis Diag(Property->getLocation(), diag::note_property_declare); 133394659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 133494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 133594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis 13369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // We only care about readwrite atomic property. 13379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCPropertyDecl::OBJC_PR_nonatomic) || 13389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek !(Attributes & ObjCPropertyDecl::OBJC_PR_readwrite)) 13399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 13409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (const ObjCPropertyImplDecl *PIDecl 13419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek = IMPDecl->FindPropertyImplDecl(Property->getIdentifier())) { 13429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (PIDecl->getPropertyImplementation() == ObjCPropertyImplDecl::Dynamic) 13439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek continue; 134494659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis if (!LookedUpGetterSetter) { 134594659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis GetterMethod = IMPDecl->getInstanceMethod(Property->getGetterName()); 134694659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis SetterMethod = IMPDecl->getInstanceMethod(Property->getSetterName()); 134794659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis LookedUpGetterSetter = true; 134894659e4bdb87534f591ae185812548c42d6efacbArgyrios Kyrtzidis } 13499d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((GetterMethod && !SetterMethod) || (!GetterMethod && SetterMethod)) { 13509d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation MethodLoc = 13519d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (GetterMethod ? GetterMethod->getLocation() 13529d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek : SetterMethod->getLocation()); 13539d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(MethodLoc, diag::warn_atomic_property_rule) 13549d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << Property->getIdentifier(); 13559d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(Property->getLocation(), diag::note_property_declare); 13569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 13599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 13609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1361f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::DiagnoseOwningPropertyGetterSynthesis(const ObjCImplementationDecl *D) { 1362f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().getGCMode() == LangOptions::GCOnly) 1363f85e193739c953358c865005855253af4f68a497John McCall return; 1364f85e193739c953358c865005855253af4f68a497John McCall 1365f85e193739c953358c865005855253af4f68a497John McCall for (ObjCImplementationDecl::propimpl_iterator 1366f85e193739c953358c865005855253af4f68a497John McCall i = D->propimpl_begin(), e = D->propimpl_end(); i != e; ++i) { 1367f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyImplDecl *PID = *i; 1368f85e193739c953358c865005855253af4f68a497John McCall if (PID->getPropertyImplementation() != ObjCPropertyImplDecl::Synthesize) 1369f85e193739c953358c865005855253af4f68a497John McCall continue; 1370f85e193739c953358c865005855253af4f68a497John McCall 1371f85e193739c953358c865005855253af4f68a497John McCall const ObjCPropertyDecl *PD = PID->getPropertyDecl(); 1372f85e193739c953358c865005855253af4f68a497John McCall if (PD && !D->getInstanceMethod(PD->getGetterName())) { 1373f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodDecl *method = PD->getGetterMethodDecl(); 1374f85e193739c953358c865005855253af4f68a497John McCall if (!method) 1375f85e193739c953358c865005855253af4f68a497John McCall continue; 1376f85e193739c953358c865005855253af4f68a497John McCall ObjCMethodFamily family = method->getMethodFamily(); 1377f85e193739c953358c865005855253af4f68a497John McCall if (family == OMF_alloc || family == OMF_copy || 1378f85e193739c953358c865005855253af4f68a497John McCall family == OMF_mutableCopy || family == OMF_new) { 1379f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 1380f85e193739c953358c865005855253af4f68a497John McCall Diag(PID->getLocation(), diag::err_ownin_getter_rule); 1381f85e193739c953358c865005855253af4f68a497John McCall else 1382f85e193739c953358c865005855253af4f68a497John McCall Diag(PID->getLocation(), diag::warn_ownin_getter_rule); 1383f85e193739c953358c865005855253af4f68a497John McCall Diag(PD->getLocation(), diag::note_property_declare); 1384f85e193739c953358c865005855253af4f68a497John McCall } 1385f85e193739c953358c865005855253af4f68a497John McCall } 1386f85e193739c953358c865005855253af4f68a497John McCall } 1387f85e193739c953358c865005855253af4f68a497John McCall} 1388f85e193739c953358c865005855253af4f68a497John McCall 13895de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// AddPropertyAttrs - Propagates attributes from a property to the 13905de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall/// implicitly-declared getter or setter for that property. 13915de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCallstatic void AddPropertyAttrs(Sema &S, ObjCMethodDecl *PropertyMethod, 13925de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall ObjCPropertyDecl *Property) { 13935de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall // Should we just clone all attributes over? 13940a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor for (Decl::attr_iterator A = Property->attr_begin(), 13950a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor AEnd = Property->attr_end(); 13960a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor A != AEnd; ++A) { 13970a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor if (isa<DeprecatedAttr>(*A) || 13980a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<UnavailableAttr>(*A) || 13990a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor isa<AvailabilityAttr>(*A)) 14000a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor PropertyMethod->addAttr((*A)->clone(S.Context)); 14010a0d2b179085a52c10402feebeb6db8b4d96a140Douglas Gregor } 14025de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall} 14035de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 14049d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// ProcessPropertyDecl - Make sure that any user-defined setter/getter methods 14059d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// have the property type and issue diagnostics if they don't. 14069d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// Also synthesize a getter/setter method if none exist (and update the 14079d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// appropriate lookup tables. FIXME: Should reconsider if adding synthesized 14089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek/// methods is the "right" thing to do. 14099d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenekvoid Sema::ProcessPropertyDecl(ObjCPropertyDecl *property, 14108254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *CD, 14118254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCPropertyDecl *redeclaredProperty, 14128254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCContainerDecl *lexicalDC) { 14138254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 14149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl *GetterMethod, *SetterMethod; 14159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod = CD->getInstanceMethod(property->getGetterName()); 14179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod = CD->getInstanceMethod(property->getSetterName()); 14189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek DiagnosePropertyAccessorMismatch(property, GetterMethod, 14199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getLocation()); 14209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) { 14229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::PropertyAttributeKind CAttr = 14239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getPropertyAttributes(); 14249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((!(CAttr & ObjCPropertyDecl::OBJC_PR_readonly)) && 14259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.getCanonicalType(SetterMethod->getResultType()) != 14269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Context.VoidTy) 14279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::err_setter_type_void); 14289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod->param_size() != 1 || 14299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ((*SetterMethod->param_begin())->getType() != property->getType())) { 14309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(property->getLocation(), 14319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek diag::warn_accessor_property_type_mismatch) 14329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << property->getDeclName() 14339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek << SetterMethod->getSelector(); 14349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek Diag(SetterMethod->getLocation(), diag::note_declared_at); 14359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 14379d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Synthesize getter/setter methods if none exist. 14399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default getter and if one not found, add one. 14409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: The synthesized property we set here is misleading. We almost always 14419d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // synthesize these methods unless the user explicitly provided prototypes 14429d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // (which is odd, but allowed). Sema should be typechecking that the 14439d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // declarations jive in that situation (which it is not currently). 14449d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!GetterMethod) { 14459d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property getter name was found. 14469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a getter method and add it to the list of methods 14479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 1448a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek SourceLocation Loc = redeclaredProperty ? 1449a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek redeclaredProperty->getLocation() : 1450a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getLocation(); 1451a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek 1452a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek GetterMethod = ObjCMethodDecl::Create(Context, Loc, Loc, 1453a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek property->getGetterName(), 14543fe104154dd2e8ffb351142d74f308938b5c99bfFariborz Jahanian property->getType(), 0, CD, true, false, true, 14553fe104154dd2e8ffb351142d74f308938b5c99bfFariborz Jahanian false, 14569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 14579d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 14589d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Optional : 14599d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCMethodDecl::Required); 14609d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(GetterMethod); 14615de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 14625de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, GetterMethod, property); 14635de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 146423173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 146523173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 1466a054fb46b1fb596d1719b89d2d9a5be3c32a4b0dTed Kremenek if (lexicalDC) 146723173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek GetterMethod->setLexicalDeclContext(lexicalDC); 14689d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 14699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared getter will be synthesize when @synthesize of 14709d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 14719d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek GetterMethod->setSynthesized(true); 14729d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setGetterMethodDecl(GetterMethod); 14739d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 14749d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Skip setter if property is read-only. 14759d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!property->isReadOnly()) { 14769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Find the default setter and if one not found, add one. 14779d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (!SetterMethod) { 14789d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // No instance method of same name as property setter name was found. 14799d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Declare a setter method and add it to the list of methods 14809d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // for this class. 14818254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SourceLocation Loc = redeclaredProperty ? 14828254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek redeclaredProperty->getLocation() : 14838254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getLocation(); 14848254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 14858254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek SetterMethod = 14868254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Create(Context, Loc, Loc, 14878254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek property->getSetterName(), Context.VoidTy, 0, 14888254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek CD, true, false, true, false, 14899d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek (property->getPropertyImplementation() == 14909d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek ObjCPropertyDecl::Optional) ? 14918254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Optional : 14928254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek ObjCMethodDecl::Required); 14938254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek 14949d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Invent the arguments for the setter. We don't bother making a 14959d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // nice name for the argument. 1496ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara ParmVarDecl *Argument = ParmVarDecl::Create(Context, SetterMethod, 1497ff676cb48fe8bf7be2feaa251dc7c5fb15af4730Abramo Bagnara Loc, Loc, 14989d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->getIdentifier(), 1499f85e193739c953358c865005855253af4f68a497John McCall property->getType().getUnqualifiedType(), 15009d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek /*TInfo=*/0, 1501d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 1502d931b086984257de68868a64a235c2b4b34003fbJohn McCall SC_None, 15039d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 0); 15044ecb25fa94897b2c03510292acace710e5262ba5Fariborz Jahanian SetterMethod->setMethodParams(Context, &Argument, 1, 1); 15055de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 15065de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall AddPropertyAttrs(*this, SetterMethod, property); 15075de74d19ddcf84cfe9d7d973192ba93fd0c64d4fJohn McCall 15089d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek CD->addDecl(SetterMethod); 150923173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // FIXME: Eventually this shouldn't be needed, as the lexical context 151023173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek // and the real context should be the same. 15118254aa62d9189395be1eed61194cd4b5ee6cb4a2Ted Kremenek if (lexicalDC) 151223173d7f029f430611caceea72ae61ba6b80af1cTed Kremenek SetterMethod->setLexicalDeclContext(lexicalDC); 15139d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } else 15149d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // A user declared setter will be synthesize when @synthesize of 15159d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // the property with the same name is seen in the @implementation 15169d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SetterMethod->setSynthesized(true); 15179d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek property->setSetterMethodDecl(SetterMethod); 15189d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek } 15199d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // Add any synthesized methods to the global pool. This allows us to 15209d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // handle the following, which is supported by GCC (and part of the design). 15219d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 15229d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @interface Foo 15239d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @property double bar; 15249d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // @end 15259d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 15269d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // void thisIsUnfortunate() { 15279d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // id foo; 15289d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // double bar = [foo bar]; 15299d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // } 15309d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // 15319d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (GetterMethod) 15329d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(GetterMethod); 15339d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if (SetterMethod) 15349d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek AddInstanceMethodToGlobalPool(SetterMethod); 15359d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 15369d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 1537d226f65006733ed7f709c3174f22ce33391cb58fJohn McCallvoid Sema::CheckObjCPropertyAttributes(Decl *PDecl, 15389d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek SourceLocation Loc, 15399d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek unsigned &Attributes) { 15409d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // FIXME: Improve the reported location. 1541f85e193739c953358c865005855253af4f68a497John McCall if (!PDecl || PDecl->isInvalidDecl()) 15425fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek return; 15435fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek 15445fcd52a6c94c7f93bd80062248353c45330da23aTed Kremenek ObjCPropertyDecl *PropertyDecl = cast<ObjCPropertyDecl>(PDecl); 1545842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian QualType PropertyTy = PropertyDecl->getType(); 15469d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 15479d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek // readonly and readwrite/assign/retain/copy conflict. 15489d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek if ((Attributes & ObjCDeclSpec::DQ_PR_readonly) && 154928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & (ObjCDeclSpec::DQ_PR_readwrite | 155028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_assign | 1551f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 155228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek ObjCDeclSpec::DQ_PR_copy | 1553f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | 1554f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_strong))) { 155528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek const char * which = (Attributes & ObjCDeclSpec::DQ_PR_readwrite) ? 155628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "readwrite" : 155728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_assign) ? 155828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "assign" : 1559f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) ? 1560f85e193739c953358c865005855253af4f68a497John McCall "unsafe_unretained" : 156128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek (Attributes & ObjCDeclSpec::DQ_PR_copy) ? 156228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek "copy" : "retain"; 15639d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 156428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, (Attributes & (ObjCDeclSpec::DQ_PR_readwrite)) ? 156528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::err_objc_property_attr_mutually_exclusive : 156628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek diag::warn_objc_property_attr_mutually_exclusive) 156728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "readonly" << which; 156828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 15699d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 157028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for copy or retain on non-object types. 1571f85e193739c953358c865005855253af4f68a497John McCall if ((Attributes & (ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 1572f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong)) && 1573f85e193739c953358c865005855253af4f68a497John McCall !PropertyTy->isObjCRetainableType() && 1574842f07b065ac481fce9d82d55cb62e36bac6c921Fariborz Jahanian !PropertyDecl->getAttr<ObjCNSObjectAttr>()) { 157528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_requires_object) 1576f85e193739c953358c865005855253af4f68a497John McCall << (Attributes & ObjCDeclSpec::DQ_PR_weak ? "weak" : 1577f85e193739c953358c865005855253af4f68a497John McCall Attributes & ObjCDeclSpec::DQ_PR_copy ? "copy" : "retain (or strong)"); 1578f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~(ObjCDeclSpec::DQ_PR_weak | ObjCDeclSpec::DQ_PR_copy | 1579f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong); 158028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 15819d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 158228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Check for more than one of { assign, copy, retain }. 158328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_assign) { 158428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 158528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 158628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "copy"; 158728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 158828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 158928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 159028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 159128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "assign" << "retain"; 159228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 159328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 1594f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 1595f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1596f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "strong"; 1597f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 1598f85e193739c953358c865005855253af4f68a497John McCall } 1599f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount && 1600f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1601f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1602f85e193739c953358c865005855253af4f68a497John McCall << "assign" << "weak"; 1603f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1604f85e193739c953358c865005855253af4f68a497John McCall } 1605f85e193739c953358c865005855253af4f68a497John McCall } else if (Attributes & ObjCDeclSpec::DQ_PR_unsafe_unretained) { 1606f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 1607f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1608f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "copy"; 1609f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_copy; 1610f85e193739c953358c865005855253af4f68a497John McCall } 1611f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 1612f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1613f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "retain"; 1614f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 1615f85e193739c953358c865005855253af4f68a497John McCall } 1616f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 1617f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1618f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "strong"; 1619f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 1620f85e193739c953358c865005855253af4f68a497John McCall } 1621f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount && 1622f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1623f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1624f85e193739c953358c865005855253af4f68a497John McCall << "unsafe_unretained" << "weak"; 1625f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1626f85e193739c953358c865005855253af4f68a497John McCall } 162728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } else if (Attributes & ObjCDeclSpec::DQ_PR_copy) { 162828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (Attributes & ObjCDeclSpec::DQ_PR_retain) { 162928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 163028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek << "copy" << "retain"; 163128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Attributes &= ~ObjCDeclSpec::DQ_PR_retain; 163228685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 1633f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_strong) { 1634f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1635f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "strong"; 1636f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_strong; 1637f85e193739c953358c865005855253af4f68a497John McCall } 1638f85e193739c953358c865005855253af4f68a497John McCall if (Attributes & ObjCDeclSpec::DQ_PR_weak) { 1639f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1640f85e193739c953358c865005855253af4f68a497John McCall << "copy" << "weak"; 1641f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1642f85e193739c953358c865005855253af4f68a497John McCall } 1643f85e193739c953358c865005855253af4f68a497John McCall } 1644f85e193739c953358c865005855253af4f68a497John McCall else if ((Attributes & ObjCDeclSpec::DQ_PR_retain) && 1645f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1646f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1647f85e193739c953358c865005855253af4f68a497John McCall << "retain" << "weak"; 1648f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 1649f85e193739c953358c865005855253af4f68a497John McCall } 1650f85e193739c953358c865005855253af4f68a497John McCall else if ((Attributes & ObjCDeclSpec::DQ_PR_strong) && 1651f85e193739c953358c865005855253af4f68a497John McCall (Attributes & ObjCDeclSpec::DQ_PR_weak)) { 1652f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_objc_property_attr_mutually_exclusive) 1653f85e193739c953358c865005855253af4f68a497John McCall << "strong" << "weak"; 1654f85e193739c953358c865005855253af4f68a497John McCall Attributes &= ~ObjCDeclSpec::DQ_PR_weak; 165528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 16569d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 165728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // Warn if user supplied no assignment attribute, property is 165828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // readwrite, and this is an object type. 165928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & (ObjCDeclSpec::DQ_PR_assign | ObjCDeclSpec::DQ_PR_copy | 1660f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_unsafe_unretained | 1661f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_retain | ObjCDeclSpec::DQ_PR_strong | 1662f85e193739c953358c865005855253af4f68a497John McCall ObjCDeclSpec::DQ_PR_weak)) && 166328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek !(Attributes & ObjCDeclSpec::DQ_PR_readonly) && 166428685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek PropertyTy->isObjCObjectPointerType()) { 1665f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().ObjCAutoRefCount) 1666f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::err_arc_objc_property_default_assign_on_object); 1667f85e193739c953358c865005855253af4f68a497John McCall else { 1668f85e193739c953358c865005855253af4f68a497John McCall // Skip this warning in gc-only mode. 1669f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().getGCMode() != LangOptions::GCOnly) 1670f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::warn_objc_property_no_assignment_attribute); 1671f85e193739c953358c865005855253af4f68a497John McCall 1672f85e193739c953358c865005855253af4f68a497John McCall // If non-gc code warn that this is likely inappropriate. 1673f85e193739c953358c865005855253af4f68a497John McCall if (getLangOptions().getGCMode() == LangOptions::NonGC) 1674f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::warn_objc_property_default_assign_on_object); 1675f85e193739c953358c865005855253af4f68a497John McCall } 16769d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 167728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // FIXME: Implement warning dependent on NSCopying being 167828685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // implemented. See also: 167928685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // <rdar://5168496&4855821&5607453&5096644&4947311&5698469&4947014&5168496> 168028685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek // (please trim this list while you are at it). 168128685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek } 16829d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek 168328685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek if (!(Attributes & ObjCDeclSpec::DQ_PR_copy) 16842b77cb803c76d01d2d10a58cec9334e2090cd7c3Fariborz Jahanian &&!(Attributes & ObjCDeclSpec::DQ_PR_readonly) 168528685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && getLangOptions().getGCMode() == LangOptions::GCOnly 168628685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek && PropertyTy->isBlockPointerType()) 168728685ab2ddeea146841bf2e277e25c7b32dfc9f6Ted Kremenek Diag(Loc, diag::warn_objc_property_copy_missing_on_block); 16889d64c15223497f31899cc47fbe1531873dc06f2eTed Kremenek} 1689