15821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Copyright (c) 2012 The Chromium Authors. All rights reserved. 25821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Use of this source code is governed by a BSD-style license that can be 35821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// found in the LICENSE file. 45821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 55821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include <string.h> 65821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include <time.h> 7b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles)#include <algorithm> 8b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles)#include <numeric> 95821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include <vector> 105821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 115821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "base/basictypes.h" 125821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "base/logging.h" 13eb525c5499e34cc9c4b825d6d9e75bb07cc06aceBen Murdoch#include "base/time/time.h" 145821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "skia/ext/convolver.h" 155821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "testing/gtest/include/gtest/gtest.h" 165821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "third_party/skia/include/core/SkBitmap.h" 175821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "third_party/skia/include/core/SkColorPriv.h" 185821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "third_party/skia/include/core/SkRect.h" 195821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "third_party/skia/include/core/SkTypes.h" 205821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 215821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)namespace skia { 225821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 235821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)namespace { 245821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 255821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Fills the given filter with impulse functions for the range 0->num_entries. 265821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)void FillImpulseFilter(int num_entries, ConvolutionFilter1D* filter) { 275821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) float one = 1.0f; 285821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) for (int i = 0; i < num_entries; i++) 295821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) filter->AddFilter(i, &one, 1); 305821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 315821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 325821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Filters the given input with the impulse function, and verifies that it 335821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// does not change. 345821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)void TestImpulseConvolution(const unsigned char* data, int width, int height) { 355821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int byte_count = width * height * 4; 365821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 375821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ConvolutionFilter1D filter_x; 385821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) FillImpulseFilter(width, &filter_x); 395821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 405821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ConvolutionFilter1D filter_y; 415821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) FillImpulseFilter(height, &filter_y); 425821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 435821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) std::vector<unsigned char> output; 445821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) output.resize(byte_count); 455821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) BGRAConvolve2D(data, width * 4, true, filter_x, filter_y, 465821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) filter_x.num_values() * 4, &output[0], false); 475821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 485821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Output should exactly match input. 495821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_EQ(0, memcmp(data, &output[0], byte_count)); 505821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 515821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 525821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Fills the destination filter with a box filter averaging every two pixels 535821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// to produce the output. 545821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)void FillBoxFilter(int size, ConvolutionFilter1D* filter) { 555821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const float box[2] = { 0.5, 0.5 }; 565821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) for (int i = 0; i < size; i++) 575821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) filter->AddFilter(i * 2, box, 2); 585821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 595821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 605821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} // namespace 615821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 625821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Tests that each pixel, when set and run through the impulse filter, does 635821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// not change. 645821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)TEST(Convolver, Impulse) { 655821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // We pick an "odd" size that is not likely to fit on any boundaries so that 665821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // we can see if all the widths and paddings are handled properly. 675821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int width = 15; 685821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int height = 31; 695821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int byte_count = width * height * 4; 705821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) std::vector<unsigned char> input; 715821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) input.resize(byte_count); 725821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 735821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) unsigned char* input_ptr = &input[0]; 745821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) for (int y = 0; y < height; y++) { 755821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) for (int x = 0; x < width; x++) { 765821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) for (int channel = 0; channel < 3; channel++) { 775821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) memset(input_ptr, 0, byte_count); 785821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) input_ptr[(y * width + x) * 4 + channel] = 0xff; 795821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Always set the alpha channel or it will attempt to "fix" it for us. 805821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) input_ptr[(y * width + x) * 4 + 3] = 0xff; 815821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) TestImpulseConvolution(input_ptr, width, height); 825821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 835821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 845821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 855821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 865821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 875821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Tests that using a box filter to halve an image results in every square of 4 885821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// pixels in the original get averaged to a pixel in the output. 895821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)TEST(Convolver, Halve) { 905821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) static const int kSize = 16; 915821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 925821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int src_width = kSize; 935821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int src_height = kSize; 945821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int src_row_stride = src_width * 4; 955821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int src_byte_count = src_row_stride * src_height; 965821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) std::vector<unsigned char> input; 975821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) input.resize(src_byte_count); 985821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 995821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int dest_width = src_width / 2; 1005821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int dest_height = src_height / 2; 1015821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int dest_byte_count = dest_width * dest_height * 4; 1025821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) std::vector<unsigned char> output; 1035821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) output.resize(dest_byte_count); 1045821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1055821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // First fill the array with a bunch of random data. 1065821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) srand(static_cast<unsigned>(time(NULL))); 1075821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) for (int i = 0; i < src_byte_count; i++) 1085821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) input[i] = rand() * 255 / RAND_MAX; 1095821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1105821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Compute the filters. 1115821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ConvolutionFilter1D filter_x, filter_y; 1125821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) FillBoxFilter(dest_width, &filter_x); 1135821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) FillBoxFilter(dest_height, &filter_y); 1145821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1155821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Do the convolution. 1165821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) BGRAConvolve2D(&input[0], src_width, true, filter_x, filter_y, 1175821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) filter_x.num_values() * 4, &output[0], false); 1185821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1195821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Compute the expected results and check, allowing for a small difference 1205821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // to account for rounding errors. 1215821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) for (int y = 0; y < dest_height; y++) { 1225821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) for (int x = 0; x < dest_width; x++) { 1235821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) for (int channel = 0; channel < 4; channel++) { 1245821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int src_offset = (y * 2 * src_row_stride + x * 2 * 4) + channel; 1255821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int value = input[src_offset] + // Top left source pixel. 1265821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) input[src_offset + 4] + // Top right source pixel. 1275821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) input[src_offset + src_row_stride] + // Lower left. 1285821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) input[src_offset + src_row_stride + 4]; // Lower right. 1295821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) value /= 4; // Average. 1305821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int difference = value - output[(y * dest_width + x) * 4 + channel]; 1315821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_TRUE(difference >= -1 || difference <= 1); 1325821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 1335821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 1345821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 1355821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 1365821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1375821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Tests the optimization in Convolver1D::AddFilter that avoids storing 1385821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// leading/trailing zeroes. 1395821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)TEST(Convolver, AddFilter) { 1405821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) skia::ConvolutionFilter1D filter; 1415821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1425821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const skia::ConvolutionFilter1D::Fixed* values = NULL; 1435821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int filter_offset = 0; 1445821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int filter_length = 0; 1455821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1465821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // An all-zero filter is handled correctly, all factors ignored 1475821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) static const float factors1[] = { 0.0f, 0.0f, 0.0f }; 1485821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) filter.AddFilter(11, factors1, arraysize(factors1)); 1495821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(0, filter.max_filter()); 1505821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(1, filter.num_values()); 1515821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1525821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) values = filter.FilterForValue(0, &filter_offset, &filter_length); 1535821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_TRUE(values == NULL); // No values => NULL. 1545821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(11, filter_offset); // Same as input offset. 1555821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(0, filter_length); // But no factors since all are zeroes. 1565821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1575821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Zeroes on the left are ignored 1585821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) static const float factors2[] = { 0.0f, 1.0f, 1.0f, 1.0f, 1.0f }; 1595821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) filter.AddFilter(22, factors2, arraysize(factors2)); 1605821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(4, filter.max_filter()); 1615821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(2, filter.num_values()); 1625821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1635821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) values = filter.FilterForValue(1, &filter_offset, &filter_length); 1645821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_TRUE(values != NULL); 1655821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(23, filter_offset); // 22 plus 1 leading zero 1665821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(4, filter_length); // 5 - 1 leading zero 1675821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1685821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Zeroes on the right are ignored 1695821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) static const float factors3[] = { 1.0f, 1.0f, 1.0f, 1.0f, 1.0f, 0.0f, 0.0f }; 1705821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) filter.AddFilter(33, factors3, arraysize(factors3)); 1715821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(5, filter.max_filter()); 1725821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(3, filter.num_values()); 1735821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1745821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) values = filter.FilterForValue(2, &filter_offset, &filter_length); 1755821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_TRUE(values != NULL); 1765821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(33, filter_offset); // 33, same as input due to no leading zero 1775821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(5, filter_length); // 7 - 2 trailing zeroes 1785821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1795821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Zeroes in leading & trailing positions 1805821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) static const float factors4[] = { 0.0f, 0.0f, 1.0f, 1.0f, 1.0f, 0.0f, 0.0f }; 1815821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) filter.AddFilter(44, factors4, arraysize(factors4)); 1825821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(5, filter.max_filter()); // No change from existing value. 1835821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(4, filter.num_values()); 1845821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1855821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) values = filter.FilterForValue(3, &filter_offset, &filter_length); 1865821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_TRUE(values != NULL); 1875821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(46, filter_offset); // 44 plus 2 leading zeroes 1885821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(3, filter_length); // 7 - (2 leading + 2 trailing) zeroes 1895821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1905821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Zeroes surrounded by non-zero values are ignored 1915821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) static const float factors5[] = { 0.0f, 0.0f, 1925821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1.0f, 0.0f, 0.0f, 0.0f, 0.0f, 1.0f, 1935821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 0.0f }; 1945821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) filter.AddFilter(55, factors5, arraysize(factors5)); 1955821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(6, filter.max_filter()); 1965821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(5, filter.num_values()); 1975821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1985821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) values = filter.FilterForValue(4, &filter_offset, &filter_length); 1995821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_TRUE(values != NULL); 2005821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(57, filter_offset); // 55 plus 2 leading zeroes 2015821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(6, filter_length); // 9 - (2 leading + 1 trailing) zeroes 2025821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 2035821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // All-zero filters after the first one also work 2045821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) static const float factors6[] = { 0.0f }; 2055821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) filter.AddFilter(66, factors6, arraysize(factors6)); 2065821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(6, filter.max_filter()); 2075821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(6, filter.num_values()); 2085821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 2095821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) values = filter.FilterForValue(5, &filter_offset, &filter_length); 2105821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_TRUE(values == NULL); // filter_length == 0 => values is NULL 2115821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(66, filter_offset); // value passed in 2125821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(0, filter_length); 2135821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 2145821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 215bb1529ce867d8845a77ec7cdf3e3003ef1771a40Ben Murdoch#if defined(THREAD_SANITIZER) 216bb1529ce867d8845a77ec7cdf3e3003ef1771a40Ben Murdoch// Times out under ThreadSanitizer, http://crbug.com/134400. 217bb1529ce867d8845a77ec7cdf3e3003ef1771a40Ben Murdoch#define MAYBE_SIMDVerification DISABLED_SIMDVerification 218bb1529ce867d8845a77ec7cdf3e3003ef1771a40Ben Murdoch#else 219bb1529ce867d8845a77ec7cdf3e3003ef1771a40Ben Murdoch#define MAYBE_SIMDVerification SIMDVerification 220bb1529ce867d8845a77ec7cdf3e3003ef1771a40Ben Murdoch#endif 221bb1529ce867d8845a77ec7cdf3e3003ef1771a40Ben MurdochTEST(Convolver, MAYBE_SIMDVerification) { 2222a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) int source_sizes[][2] = { 2232a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) {1,1}, {1,2}, {1,3}, {1,4}, {1,5}, 2242a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) {2,1}, {2,2}, {2,3}, {2,4}, {2,5}, 2252a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) {3,1}, {3,2}, {3,3}, {3,4}, {3,5}, 2262a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) {4,1}, {4,2}, {4,3}, {4,4}, {4,5}, 2272a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) {1920, 1080}, 2282a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) {720, 480}, 2292a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) {1377, 523}, 2302a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) {325, 241} }; 2315821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int dest_sizes[][2] = { {1280, 1024}, {480, 270}, {177, 123} }; 2325821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) float filter[] = { 0.05f, -0.15f, 0.6f, 0.6f, -0.15f, 0.05f }; 2335821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 2345821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) srand(static_cast<unsigned int>(time(0))); 2355821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 2365821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Loop over some specific source and destination dimensions. 2375821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) for (unsigned int i = 0; i < arraysize(source_sizes); ++i) { 2385821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) unsigned int source_width = source_sizes[i][0]; 2395821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) unsigned int source_height = source_sizes[i][1]; 2405821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) for (unsigned int j = 0; j < arraysize(dest_sizes); ++j) { 2412a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) unsigned int dest_width = dest_sizes[j][0]; 2422a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) unsigned int dest_height = dest_sizes[j][1]; 2435821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 2445821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Preparing convolve coefficients. 2455821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ConvolutionFilter1D x_filter, y_filter; 2465821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) for (unsigned int p = 0; p < dest_width; ++p) { 2475821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) unsigned int offset = source_width * p / dest_width; 2482a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) EXPECT_LT(offset, source_width); 2492a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) x_filter.AddFilter(offset, filter, 2502a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) std::min<int>(arraysize(filter), 2512a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) source_width - offset)); 2525821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 253c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) x_filter.PaddingForSIMD(); 2545821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) for (unsigned int p = 0; p < dest_height; ++p) { 2555821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) unsigned int offset = source_height * p / dest_height; 2562a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) y_filter.AddFilter(offset, filter, 2572a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) std::min<int>(arraysize(filter), 2582a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) source_height - offset)); 2595821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 260c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) y_filter.PaddingForSIMD(); 2615821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 2625821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Allocate input and output skia bitmap. 2635821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) SkBitmap source, result_c, result_sse; 2645821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) source.setConfig(SkBitmap::kARGB_8888_Config, 2655821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) source_width, source_height); 2665821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) source.allocPixels(); 2675821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) result_c.setConfig(SkBitmap::kARGB_8888_Config, 2685821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) dest_width, dest_height); 2695821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) result_c.allocPixels(); 2705821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) result_sse.setConfig(SkBitmap::kARGB_8888_Config, 2715821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) dest_width, dest_height); 2725821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) result_sse.allocPixels(); 2735821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 2745821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Randomize source bitmap for testing. 2755821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) unsigned char* src_ptr = static_cast<unsigned char*>(source.getPixels()); 2765821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) for (int y = 0; y < source.height(); y++) { 2772a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) for (unsigned int x = 0; x < source.rowBytes(); x++) 2785821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) src_ptr[x] = rand() % 255; 2795821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) src_ptr += source.rowBytes(); 2805821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 2815821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 2825821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Test both cases with different has_alpha. 2835821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) for (int alpha = 0; alpha < 2; alpha++) { 2845821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Convolve using C code. 2855821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) base::TimeTicks resize_start; 2865821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) base::TimeDelta delta_c, delta_sse; 2875821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) unsigned char* r1 = static_cast<unsigned char*>(result_c.getPixels()); 2885821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) unsigned char* r2 = static_cast<unsigned char*>(result_sse.getPixels()); 2895821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 2905821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) resize_start = base::TimeTicks::Now(); 2915821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) BGRAConvolve2D(static_cast<const uint8*>(source.getPixels()), 2925821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) static_cast<int>(source.rowBytes()), 2935821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) (alpha != 0), x_filter, y_filter, 2945821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) static_cast<int>(result_c.rowBytes()), r1, false); 2955821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) delta_c = base::TimeTicks::Now() - resize_start; 2965821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 2975821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) resize_start = base::TimeTicks::Now(); 2985821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Convolve using SSE2 code 2995821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) BGRAConvolve2D(static_cast<const uint8*>(source.getPixels()), 3005821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) static_cast<int>(source.rowBytes()), 3015821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) (alpha != 0), x_filter, y_filter, 3025821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) static_cast<int>(result_sse.rowBytes()), r2, true); 3035821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) delta_sse = base::TimeTicks::Now() - resize_start; 3045821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 3055821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Unfortunately I could not enable the performance check now. 3065821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Most bots use debug version, and there are great difference between 3075821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // the code generation for intrinsic, etc. In release version speed 3085821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // difference was 150%-200% depend on alpha channel presence; 3095821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // while in debug version speed difference was 96%-120%. 3105821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // TODO(jiesun): optimize further until we could enable this for 3115821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // debug version too. 3125821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // EXPECT_LE(delta_sse, delta_c); 3135821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 3145821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int64 c_us = delta_c.InMicroseconds(); 3155821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) int64 sse_us = delta_sse.InMicroseconds(); 3165821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) VLOG(1) << "from:" << source_width << "x" << source_height 3175821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) << " to:" << dest_width << "x" << dest_height 3185821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) << (alpha ? " with alpha" : " w/o alpha"); 3195821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) VLOG(1) << "c:" << c_us << " sse:" << sse_us; 3205821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) VLOG(1) << "ratio:" << static_cast<float>(c_us) / sse_us; 3215821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 3225821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Comparing result. 3235821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) for (unsigned int i = 0; i < dest_height; i++) { 3245821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) for (unsigned int x = 0; x < dest_width * 4; x++) { // RGBA always. 3255821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_EQ(r1[x], r2[x]); 3265821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 3275821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) r1 += result_c.rowBytes(); 3285821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) r2 += result_sse.rowBytes(); 3295821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 3305821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 3315821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 3325821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 333c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)} 334c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 335c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)TEST(Convolver, SeparableSingleConvolution) { 336c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) static const int kImgWidth = 1024; 337c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) static const int kImgHeight = 1024; 338c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) static const int kChannelCount = 3; 339c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) static const int kStrideSlack = 22; 340c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) ConvolutionFilter1D filter; 341c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) const float box[5] = { 0.2f, 0.2f, 0.2f, 0.2f, 0.2f }; 342c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) filter.AddFilter(0, box, 5); 343c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 344c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // Allocate a source image and set to 0. 345c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) const int src_row_stride = kImgWidth * kChannelCount + kStrideSlack; 346c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) int src_byte_count = src_row_stride * kImgHeight; 347c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) std::vector<unsigned char> input; 348c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) const int signal_x = kImgWidth / 2; 349c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) const int signal_y = kImgHeight / 2; 350c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) input.resize(src_byte_count, 0); 351c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // The image has a single impulse pixel in channel 1, smack in the middle. 352c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) const int non_zero_pixel_index = 353c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) signal_y * src_row_stride + signal_x * kChannelCount + 1; 354c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) input[non_zero_pixel_index] = 255; 355c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 356c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // Destination will be a single channel image with stide matching width. 357c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) const int dest_row_stride = kImgWidth; 358c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) const int dest_byte_count = dest_row_stride * kImgHeight; 359c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) std::vector<unsigned char> output; 360c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) output.resize(dest_byte_count); 361c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 362c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // Apply convolution in X. 363c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) SingleChannelConvolveX1D(&input[0], src_row_stride, 1, kChannelCount, 364c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) filter, SkISize::Make(kImgWidth, kImgHeight), 365c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) &output[0], dest_row_stride, 0, 1, false); 366c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) for (int x = signal_x - 2; x <= signal_x + 2; ++x) 367c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_GT(output[signal_y * dest_row_stride + x], 0); 368c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 369c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_EQ(output[signal_y * dest_row_stride + signal_x - 3], 0); 370c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_EQ(output[signal_y * dest_row_stride + signal_x + 3], 0); 371c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 372c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // Apply convolution in Y. 373c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) SingleChannelConvolveY1D(&input[0], src_row_stride, 1, kChannelCount, 374c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) filter, SkISize::Make(kImgWidth, kImgHeight), 375c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) &output[0], dest_row_stride, 0, 1, false); 376c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) for (int y = signal_y - 2; y <= signal_y + 2; ++y) 377c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_GT(output[y * dest_row_stride + signal_x], 0); 378c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 379c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_EQ(output[(signal_y - 3) * dest_row_stride + signal_x], 0); 380c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_EQ(output[(signal_y + 3) * dest_row_stride + signal_x], 0); 381c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 382c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_EQ(output[signal_y * dest_row_stride + signal_x - 1], 0); 383c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_EQ(output[signal_y * dest_row_stride + signal_x + 1], 0); 384c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 385c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // The main point of calling this is to invoke the routine on input without 386c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // padding. 387c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) std::vector<unsigned char> output2; 388c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) output2.resize(dest_byte_count); 389c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) SingleChannelConvolveX1D(&output[0], dest_row_stride, 0, 1, 390c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) filter, SkISize::Make(kImgWidth, kImgHeight), 391c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) &output2[0], dest_row_stride, 0, 1, false); 392c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // This should be a result of 2D convolution. 393c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) for (int x = signal_x - 2; x <= signal_x + 2; ++x) { 394c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) for (int y = signal_y - 2; y <= signal_y + 2; ++y) 395c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_GT(output2[y * dest_row_stride + x], 0); 396c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) } 397c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_EQ(output2[0], 0); 398c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_EQ(output2[dest_row_stride - 1], 0); 399c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_EQ(output2[dest_byte_count - 1], 0); 400c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)} 401c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 402c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles)TEST(Convolver, SeparableSingleConvolutionEdges) { 403c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // The purpose of this test is to check if the implementation treats correctly 404c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // edges of the image. 405c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) static const int kImgWidth = 600; 406c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) static const int kImgHeight = 800; 407c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) static const int kChannelCount = 3; 408c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) static const int kStrideSlack = 22; 409c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) static const int kChannel = 1; 410c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) ConvolutionFilter1D filter; 411c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) const float box[5] = { 0.2f, 0.2f, 0.2f, 0.2f, 0.2f }; 412c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) filter.AddFilter(0, box, 5); 413c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 414c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // Allocate a source image and set to 0. 415c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) int src_row_stride = kImgWidth * kChannelCount + kStrideSlack; 416c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) int src_byte_count = src_row_stride * kImgHeight; 417c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) std::vector<unsigned char> input(src_byte_count); 418c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 419c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // Draw a frame around the image. 420c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) for (int i = 0; i < src_byte_count; ++i) { 421c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) int row = i / src_row_stride; 422c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) int col = i % src_row_stride / kChannelCount; 423c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) int channel = i % src_row_stride % kChannelCount; 424c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) if (channel != kChannel || col > kImgWidth) { 425c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) input[i] = 255; 426c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) } else if (row == 0 || col == 0 || 427c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) col == kImgWidth - 1 || row == kImgHeight - 1) { 428c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) input[i] = 100; 429c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) } else if (row == 1 || col == 1 || 430c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) col == kImgWidth - 2 || row == kImgHeight - 2) { 431c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) input[i] = 200; 432c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) } else { 433c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) input[i] = 0; 434c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) } 435c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) } 436c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 437c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // Destination will be a single channel image with stide matching width. 438c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) int dest_row_stride = kImgWidth; 439c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) int dest_byte_count = dest_row_stride * kImgHeight; 440c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) std::vector<unsigned char> output; 441c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) output.resize(dest_byte_count); 442c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 443c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // Apply convolution in X. 444c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) SingleChannelConvolveX1D(&input[0], src_row_stride, 1, kChannelCount, 445c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) filter, SkISize::Make(kImgWidth, kImgHeight), 446c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) &output[0], dest_row_stride, 0, 1, false); 447c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 448c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) // Sadly, comparison is not as simple as retaining all values. 449c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) int invalid_values = 0; 450c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) const unsigned char first_value = output[0]; 451c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_NEAR(first_value, 100, 1); 452c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) for (int i = 0; i < dest_row_stride; ++i) { 453c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) if (output[i] != first_value) 454c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) ++invalid_values; 455c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) } 456c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_EQ(0, invalid_values); 457c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 458c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) int test_row = 22; 459c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_NEAR(output[test_row * dest_row_stride], 100, 1); 460c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_NEAR(output[test_row * dest_row_stride + 1], 80, 1); 461c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_NEAR(output[test_row * dest_row_stride + 2], 60, 1); 462c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_NEAR(output[test_row * dest_row_stride + 3], 40, 1); 463c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_NEAR(output[(test_row + 1) * dest_row_stride - 1], 100, 1); 464c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_NEAR(output[(test_row + 1) * dest_row_stride - 2], 80, 1); 465c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_NEAR(output[(test_row + 1) * dest_row_stride - 3], 60, 1); 466c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_NEAR(output[(test_row + 1) * dest_row_stride - 4], 40, 1); 467c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 468c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) SingleChannelConvolveY1D(&input[0], src_row_stride, 1, kChannelCount, 469c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) filter, SkISize::Make(kImgWidth, kImgHeight), 470c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) &output[0], dest_row_stride, 0, 1, false); 471c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 472c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) int test_column = 42; 473c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_NEAR(output[test_column], 100, 1); 474c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_NEAR(output[test_column + dest_row_stride], 80, 1); 475c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_NEAR(output[test_column + dest_row_stride * 2], 60, 1); 476c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_NEAR(output[test_column + dest_row_stride * 3], 40, 1); 477c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) 478c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_NEAR(output[test_column + dest_row_stride * (kImgHeight - 1)], 100, 1); 479c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_NEAR(output[test_column + dest_row_stride * (kImgHeight - 2)], 80, 1); 480c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_NEAR(output[test_column + dest_row_stride * (kImgHeight - 3)], 60, 1); 481c2e0dbddbe15c98d52c4786dac06cb8952a8ae6dTorne (Richard Coles) EXPECT_NEAR(output[test_column + dest_row_stride * (kImgHeight - 4)], 40, 1); 4825821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 4835821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 484b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles)TEST(Convolver, SetUpGaussianConvolutionFilter) { 485b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) ConvolutionFilter1D smoothing_filter; 486b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) ConvolutionFilter1D gradient_filter; 487b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) SetUpGaussianConvolutionKernel(&smoothing_filter, 4.5f, false); 488b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) SetUpGaussianConvolutionKernel(&gradient_filter, 3.0f, true); 489b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) 490b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) int specified_filter_length; 491b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) int filter_offset; 492b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) int filter_length; 493b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) 494b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) const ConvolutionFilter1D::Fixed* smoothing_kernel = 495b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) smoothing_filter.GetSingleFilter( 496b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) &specified_filter_length, &filter_offset, &filter_length); 497b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) EXPECT_TRUE(smoothing_kernel); 498b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) std::vector<float> fp_smoothing_kernel(filter_length); 499b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) std::transform(smoothing_kernel, 500b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) smoothing_kernel + filter_length, 501b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) fp_smoothing_kernel.begin(), 502b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) ConvolutionFilter1D::FixedToFloat); 503b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) // Should sum-up to 1 (nearly), and all values whould be in ]0, 1[. 504b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) EXPECT_NEAR(std::accumulate( 505b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) fp_smoothing_kernel.begin(), fp_smoothing_kernel.end(), 0.0f), 506b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) 1.0f, 0.01f); 507b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) EXPECT_GT(*std::min_element(fp_smoothing_kernel.begin(), 508b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) fp_smoothing_kernel.end()), 0.0f); 509b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) EXPECT_LT(*std::max_element(fp_smoothing_kernel.begin(), 510b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) fp_smoothing_kernel.end()), 1.0f); 511b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) 512b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) const ConvolutionFilter1D::Fixed* gradient_kernel = 513b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) gradient_filter.GetSingleFilter( 514b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) &specified_filter_length, &filter_offset, &filter_length); 515b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) EXPECT_TRUE(gradient_kernel); 516b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) std::vector<float> fp_gradient_kernel(filter_length); 517b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) std::transform(gradient_kernel, 518b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) gradient_kernel + filter_length, 519b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) fp_gradient_kernel.begin(), 520b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) ConvolutionFilter1D::FixedToFloat); 521b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) // Should sum-up to 0, and all values whould be in ]-1.5, 1.5[. 522b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) EXPECT_NEAR(std::accumulate( 523b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) fp_gradient_kernel.begin(), fp_gradient_kernel.end(), 0.0f), 524b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) 0.0f, 0.01f); 525b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) EXPECT_GT(*std::min_element(fp_gradient_kernel.begin(), 526b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) fp_gradient_kernel.end()), -1.5f); 527b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) EXPECT_LT(*std::min_element(fp_gradient_kernel.begin(), 528b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) fp_gradient_kernel.end()), 0.0f); 529b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) EXPECT_LT(*std::max_element(fp_gradient_kernel.begin(), 530b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) fp_gradient_kernel.end()), 1.5f); 531b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) EXPECT_GT(*std::max_element(fp_gradient_kernel.begin(), 532b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) fp_gradient_kernel.end()), 0.0f); 533b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles)} 534b2df76ea8fec9e32f6f3718986dba0d95315b29cTorne (Richard Coles) 5355821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} // namespace skia 536