apps_model_builder_unittest.cc revision 2a99a7e74a7f215066514fe81d2bfa6639d9eddd
15821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Copyright (c) 2012 The Chromium Authors. All rights reserved. 25821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Use of this source code is governed by a BSD-style license that can be 35821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// found in the LICENSE file. 45821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 55821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chrome/browser/ui/app_list/apps_model_builder.h" 65821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 75821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include <string> 85821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 92a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)#include "base/files/file_path.h" 105821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "base/memory/scoped_ptr.h" 112a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)#include "base/prefs/pref_service.h" 122a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)#include "base/values.h" 132a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)#include "chrome/browser/extensions/extension_function_test_utils.h" 145821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chrome/browser/extensions/extension_service_unittest.h" 155821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chrome/browser/extensions/extension_sorting.h" 162a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)#include "chrome/common/extensions/extension_constants.h" 172a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)#include "chrome/common/extensions/manifest.h" 182a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)#include "chrome/common/pref_names.h" 195821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "chrome/test/base/testing_profile.h" 205821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "testing/gtest/include/gtest/gtest.h" 215821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)#include "ui/app_list/app_list_item_model.h" 225821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 235821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)namespace { 245821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 255821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)const char kHostedAppId[] = "dceacbkfkmllgmjmbhgkpjegnodmildf"; 265821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)const char kPackagedApp1Id[] = "emfkafnhnpcmabnnkckkchdilgeoekbo"; 275821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)const char kPackagedApp2Id[] = "jlklkagmeajbjiobondfhiekepofmljl"; 285821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 295821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)// Get a string of all apps in |model| joined with ','. 305821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)std::string GetModelContent(app_list::AppListModel::Apps* model) { 315821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) std::string content; 325821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) for (size_t i = 0; i < model->item_count(); ++i) { 335821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) if (i > 0) 345821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) content += ','; 355821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) content += model->GetItemAt(i)->title(); 365821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 375821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) return content; 385821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 395821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 402a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)scoped_refptr<extensions::Extension> MakeApp(const std::string& name, 412a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) const std::string& version, 422a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) const std::string& url, 432a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) const std::string& id) { 442a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) std::string err; 452a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) DictionaryValue value; 462a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) value.SetString("name", name); 472a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) value.SetString("version", version); 482a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) value.SetString("app.launch.web_url", url); 492a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) scoped_refptr<extensions::Extension> app = 502a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) extensions::Extension::Create( 512a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) base::FilePath(), 522a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) extensions::Manifest::INTERNAL, 532a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) value, 542a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) extensions::Extension::WAS_INSTALLED_BY_DEFAULT, 552a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) id, 562a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) &err); 572a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) EXPECT_EQ(err, ""); 582a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) return app; 592a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)} 602a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 615821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} // namespace 625821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 635821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)class AppsModelBuilderTest : public ExtensionServiceTestBase { 645821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) public: 655821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) AppsModelBuilderTest() {} 665821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) virtual ~AppsModelBuilderTest() {} 675821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 685821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) virtual void SetUp() OVERRIDE { 695821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // Load "app_list" extensions test profile. 705821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // The test profile has 4 extensions: 715821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // 1 dummy extension, 2 packaged extension apps and 1 hosted extension app. 722a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) base::FilePath source_install_dir = data_dir_ 735821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) .AppendASCII("app_list") 745821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) .AppendASCII("Extensions"); 752a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) base::FilePath pref_path = source_install_dir 765821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) .DirName() 775821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) .AppendASCII("Preferences"); 785821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) InitializeInstalledExtensionService(pref_path, source_install_dir); 795821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) service_->Init(); 805821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 815821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // There should be 4 extensions in the test profile. 825821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) const ExtensionSet* extensions = service_->extensions(); 835821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ASSERT_EQ(static_cast<size_t>(4), extensions->size()); 845821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) } 855821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)}; 865821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 875821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)TEST_F(AppsModelBuilderTest, Build) { 885821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) scoped_ptr<app_list::AppListModel::Apps> model( 895821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) new app_list::AppListModel::Apps); 905821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) AppsModelBuilder builder(profile_.get(), model.get(), NULL); 915821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) builder.Build(); 925821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 935821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) // The apps list would have 3 extension apps in the profile. 945821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_EQ(std::string("Packaged App 1,Packaged App 2,Hosted App"), 955821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) GetModelContent(model.get())); 965821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 975821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 982a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)TEST_F(AppsModelBuilderTest, HideWebStore) { 992a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) // Install a "web store" app. 1002a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) scoped_refptr<extensions::Extension> store = 1012a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) MakeApp("webstore", 1022a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) "0.0", 1032a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) "http://google.com", 1042a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) std::string(extension_misc::kWebStoreAppId)); 1052a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) service_->AddExtension(store); 1062a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 1072a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) // Install an "enterprise web store" app. 1082a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) scoped_refptr<extensions::Extension> enterprise_store = 1092a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) MakeApp("enterprise_webstore", 1102a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) "0.0", 1112a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) "http://google.com", 1122a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) std::string(extension_misc::kEnterpriseWebStoreAppId)); 1132a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) service_->AddExtension(enterprise_store); 1142a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 1152a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) // Web stores should be present in the AppListModel. 1162a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) app_list::AppListModel::Apps model1; 1172a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) AppsModelBuilder builder1(profile_.get(), &model1, NULL); 1182a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) builder1.Build(); 1192a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) std::string content = GetModelContent(&model1); 1202a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) EXPECT_NE(std::string::npos, content.find("webstore")); 1212a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) EXPECT_NE(std::string::npos, content.find("enterprise_webstore")); 1222a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 1232a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) // Activate the HideWebStoreIcon policy. 1242a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) profile_->GetPrefs()->SetBoolean(prefs::kHideWebStoreIcon, true); 1252a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 1262a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) // Web stores should NOT be in the AppListModel. 1272a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) app_list::AppListModel::Apps model2; 1282a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) AppsModelBuilder builder2(profile_.get(), &model2, NULL); 1292a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) builder2.Build(); 1302a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) content = GetModelContent(&model2); 1312a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) EXPECT_EQ(std::string::npos, content.find("webstore")); 1322a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) EXPECT_EQ(std::string::npos, content.find("enterprise_webstore")); 1332a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)} 1342a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 1355821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)TEST_F(AppsModelBuilderTest, DisableAndEnable) { 1365821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) scoped_ptr<app_list::AppListModel::Apps> model( 1375821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) new app_list::AppListModel::Apps); 1385821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) AppsModelBuilder builder(profile_.get(), model.get(), NULL); 1395821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) builder.Build(); 1405821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1415821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) service_->DisableExtension(kHostedAppId, 1425821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) extensions::Extension::DISABLE_NONE); 1432a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) EXPECT_EQ(std::string("Packaged App 1,Packaged App 2,Hosted App"), 1445821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) GetModelContent(model.get())); 1455821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1465821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) service_->EnableExtension(kHostedAppId); 1475821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_EQ(std::string("Packaged App 1,Packaged App 2,Hosted App"), 1485821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) GetModelContent(model.get())); 1495821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 1505821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1512a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)TEST_F(AppsModelBuilderTest, Uninstall) { 1522a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) scoped_ptr<app_list::AppListModel::Apps> model( 1532a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) new app_list::AppListModel::Apps); 1542a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) AppsModelBuilder builder(profile_.get(), model.get(), NULL); 1552a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) builder.Build(); 1562a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 1572a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) service_->UninstallExtension(kPackagedApp2Id, false, NULL); 1582a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) EXPECT_EQ(std::string("Packaged App 1,Hosted App"), 1592a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) GetModelContent(model.get())); 1602a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 1612a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) loop_.RunUntilIdle(); 1622a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)} 1632a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 1645821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)TEST_F(AppsModelBuilderTest, OrdinalPrefsChange) { 1655821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) scoped_ptr<app_list::AppListModel::Apps> model( 1665821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) new app_list::AppListModel::Apps); 1675821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) AppsModelBuilder builder(profile_.get(), model.get(), NULL); 1685821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) builder.Build(); 1695821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1705821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ExtensionSorting* sorting = service_->extension_prefs()->extension_sorting(); 1715821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1725821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) syncer::StringOrdinal package_app_page = 1735821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) sorting->GetPageOrdinal(kPackagedApp1Id); 1745821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) sorting->SetPageOrdinal(kHostedAppId, package_app_page.CreateBefore()); 1755821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_EQ(std::string("Hosted App,Packaged App 1,Packaged App 2"), 1765821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) GetModelContent(model.get())); 1775821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1785821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) syncer::StringOrdinal app1_ordinal = 1795821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) sorting->GetAppLaunchOrdinal(kPackagedApp1Id); 1805821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) syncer::StringOrdinal app2_ordinal = 1815821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) sorting->GetAppLaunchOrdinal(kPackagedApp2Id); 1825821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) sorting->SetPageOrdinal(kHostedAppId, package_app_page); 1835821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) sorting->SetAppLaunchOrdinal(kHostedAppId, 1845821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) app1_ordinal.CreateBetween(app2_ordinal)); 1855821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_EQ(std::string("Packaged App 1,Hosted App,Packaged App 2"), 1865821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) GetModelContent(model.get())); 1875821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 1885821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1895821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)TEST_F(AppsModelBuilderTest, OnExtensionMoved) { 1905821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) scoped_ptr<app_list::AppListModel::Apps> model( 1915821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) new app_list::AppListModel::Apps); 1925821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) AppsModelBuilder builder(profile_.get(), model.get(), NULL); 1935821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) builder.Build(); 1945821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1955821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) ExtensionSorting* sorting = service_->extension_prefs()->extension_sorting(); 1965821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) sorting->SetPageOrdinal(kHostedAppId, 1975821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) sorting->GetPageOrdinal(kPackagedApp1Id)); 1985821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 1995821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) service_->OnExtensionMoved(kHostedAppId, kPackagedApp1Id, kPackagedApp2Id); 2005821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_EQ(std::string("Packaged App 1,Hosted App,Packaged App 2"), 2015821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) GetModelContent(model.get())); 2025821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 2035821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) service_->OnExtensionMoved(kHostedAppId, kPackagedApp2Id, std::string()); 2045821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_EQ(std::string("Packaged App 1,Packaged App 2,Hosted App"), 2055821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) GetModelContent(model.get())); 2065821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) 2075821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) service_->OnExtensionMoved(kHostedAppId, std::string(), kPackagedApp1Id); 2085821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) EXPECT_EQ(std::string("Hosted App,Packaged App 1,Packaged App 2"), 2095821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles) GetModelContent(model.get())); 2105821806d5e7f356e8fa4b058a389a808ea183019Torne (Richard Coles)} 2112a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 2122a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)TEST_F(AppsModelBuilderTest, InvalidOrdinal) { 2132a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) // Creates a no-ordinal case. 2142a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) ExtensionSorting* sorting = service_->extension_prefs()->extension_sorting(); 2152a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) sorting->ClearOrdinals(kPackagedApp1Id); 2162a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 2172a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) // Creates an corrupted ordinal case. 2182a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) ExtensionScopedPrefs* scoped_prefs = service_->extension_prefs(); 2192a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) scoped_prefs->UpdateExtensionPref( 2202a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) kHostedAppId, 2212a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) "page_ordinal", 2222a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) base::Value::CreateStringValue("a corrupted ordinal")); 2232a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 2242a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) scoped_ptr<app_list::AppListModel::Apps> model( 2252a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) new app_list::AppListModel::Apps); 2262a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) AppsModelBuilder builder(profile_.get(), model.get(), NULL); 2272a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 2282a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) // This should not assert or crash. 2292a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) builder.Build(); 2302a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)} 2312a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 2322a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)TEST_F(AppsModelBuilderTest, OrdinalConfilicts) { 2332a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) // Creates conflict ordinals for app1 and app2. 2342a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) syncer::StringOrdinal conflict_ordinal = 2352a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) syncer::StringOrdinal::CreateInitialOrdinal(); 2362a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 2372a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) ExtensionSorting* sorting = service_->extension_prefs()->extension_sorting(); 2382a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) sorting->SetPageOrdinal(kHostedAppId, conflict_ordinal); 2392a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) sorting->SetAppLaunchOrdinal(kHostedAppId, conflict_ordinal); 2402a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 2412a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) sorting->SetPageOrdinal(kPackagedApp1Id, conflict_ordinal); 2422a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) sorting->SetAppLaunchOrdinal(kPackagedApp1Id, conflict_ordinal); 2432a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 2442a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) sorting->SetPageOrdinal(kPackagedApp2Id, conflict_ordinal); 2452a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) sorting->SetAppLaunchOrdinal(kPackagedApp2Id, conflict_ordinal); 2462a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 2472a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) scoped_ptr<app_list::AppListModel::Apps> model( 2482a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) new app_list::AppListModel::Apps); 2492a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) AppsModelBuilder builder(profile_.get(), model.get(), NULL); 2502a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) builder.Build(); 2512a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 2522a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) // By default, conflicted items are sorted by their app ids. 2532a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) EXPECT_EQ(std::string("Hosted App,Packaged App 1,Packaged App 2"), 2542a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) GetModelContent(model.get())); 2552a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) 2562a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) // Move hosted app between app1 and app2 and it should not crash. 2572a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) service_->OnExtensionMoved(kHostedAppId, kPackagedApp1Id, kPackagedApp2Id); 2582a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) EXPECT_EQ(std::string("Packaged App 1,Hosted App,Packaged App 2"), 2592a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles) GetModelContent(model.get())); 2602a99a7e74a7f215066514fe81d2bfa6639d9edddTorne (Richard Coles)} 261