SemaChecking.cpp revision 02be968a08184acd42aaefa6f9a7dc883a4d1937
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===//
259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//                     The LLVM Compiler Infrastructure
459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source
60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details.
759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===//
959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump//  This file implements extra semantic analysis beyond what is enforced
1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//  by the C type system.
1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===//
1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner
152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h"
1659907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h"
17199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h"
18384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h"
19c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h"
2055fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/AST/EvaluatedExprVisitor.h"
21be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie#include "clang/AST/Expr.h"
222324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h"
237ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h"
24f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h"
25f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h"
2655fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Analysis/Analyses/FormatString.h"
273f6f51e28231f65de9c2dd150a2d757b2162cfa3Jordan Rose#include "clang/Basic/CharInfo.h"
2855fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Basic/TargetBuiltins.h"
2955fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Basic/TargetInfo.h"
3059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h"
3155fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Initialization.h"
3255fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Lookup.h"
3355fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/ScopeInfo.h"
3455fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Sema.h"
35f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h"
36f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h"
3755fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "llvm/ADT/SmallString.h"
38cb5620c9b213f4bd323912159fdddda35e258a14Dmitri Gribenko#include "llvm/Support/ConvertUTF.h"
393bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h"
40a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits>
4159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang;
42781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema;
4359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner
4460800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL,
4560800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner                                                    unsigned ByteNo) const {
4608f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner  return SL->getLocationOfByte(ByteNo, PP.getSourceManager(),
474e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie                               PP.getLangOpts(), PP.getTargetInfo());
4860800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner}
4960800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner
508e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number.
518e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking.  Returns true on error.
528e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) {
538e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  unsigned argCount = call->getNumArgs();
548e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  if (argCount == desiredArgCount) return false;
558e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
568e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  if (argCount < desiredArgCount)
578e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args)
588e10f3b9cc1db43645bbc2999eb163af8997d468John McCall        << 0 /*function call*/ << desiredArgCount << argCount
598e10f3b9cc1db43645bbc2999eb163af8997d468John McCall        << call->getSourceRange();
608e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
618e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  // Highlight all the excess arguments.
628e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  SourceRange range(call->getArg(desiredArgCount)->getLocStart(),
638e10f3b9cc1db43645bbc2999eb163af8997d468John McCall                    call->getArg(argCount - 1)->getLocEnd());
648e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
658e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args)
668e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    << 0 /*function call*/ << desiredArgCount << argCount
678e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    << call->getArg(1)->getSourceRange();
688e10f3b9cc1db43645bbc2999eb163af8997d468John McCall}
698e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
70e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// Check that the first argument to __builtin_annotation is an integer
71e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// and the second argument is a non-wide string literal.
72e59392176c2369df2bdd11b7786cb38abac00198Julien Lerougestatic bool SemaBuiltinAnnotation(Sema &S, CallExpr *TheCall) {
73e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  if (checkArgCount(S, TheCall, 2))
74e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    return true;
75e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge
76e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  // First argument should be an integer.
77e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  Expr *ValArg = TheCall->getArg(0);
78e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  QualType Ty = ValArg->getType();
79e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  if (!Ty->isIntegerType()) {
80e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    S.Diag(ValArg->getLocStart(), diag::err_builtin_annotation_first_arg)
81e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge      << ValArg->getSourceRange();
82e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    return true;
83e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  }
84e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge
85e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  // Second argument should be a constant string.
86e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  Expr *StrArg = TheCall->getArg(1)->IgnoreParenCasts();
87e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  StringLiteral *Literal = dyn_cast<StringLiteral>(StrArg);
8877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge  if (!Literal || !Literal->isAscii()) {
89e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    S.Diag(StrArg->getLocStart(), diag::err_builtin_annotation_second_arg)
90e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge      << StrArg->getSourceRange();
9177f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge    return true;
9277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge  }
93e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge
94e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  TheCall->setType(Ty);
9577f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge  return false;
9677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge}
9777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge
9860d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult
99d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
10060d7b3a319d84d688752be3870615ac0f111fb16John McCall  ExprResult TheCallResult(Owned(TheCall));
1012def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor
102946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  // Find out if any arguments are required to be integer constant expressions.
103946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  unsigned ICEArguments = 0;
104946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  ASTContext::GetBuiltinTypeError Error;
105946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  Context.GetBuiltinType(BuiltinID, Error, &ICEArguments);
106946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  if (Error != ASTContext::GE_None)
107946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    ICEArguments = 0;  // Don't diagnose previously diagnosed errors.
108946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner
109946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  // If any arguments are required to be ICE's, check and diagnose.
110946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) {
111946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    // Skip arguments not required to be ICE's.
112946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    if ((ICEArguments & (1 << ArgNo)) == 0) continue;
113946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner
114946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    llvm::APSInt Result;
115946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    if (SemaBuiltinConstantArg(TheCall, ArgNo, Result))
116946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner      return true;
117946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    ICEArguments &= ~(1 << ArgNo);
118946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  }
119946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner
120d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson  switch (BuiltinID) {
12130ce344307f8a8b00054021307015571f83c7364Chris Lattner  case Builtin::BI__builtin___CFStringMakeConstantString:
122925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner    assert(TheCall->getNumArgs() == 1 &&
1231b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner           "Wrong # arguments to builtin CFStringMakeConstantString");
124690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner    if (CheckObjCString(TheCall->getArg(0)))
1250eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
126d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
12749ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek  case Builtin::BI__builtin_stdarg_start:
12830ce344307f8a8b00054021307015571f83c7364Chris Lattner  case Builtin::BI__builtin_va_start:
1290eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    if (SemaBuiltinVAStart(TheCall))
1300eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
131d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
1321b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_isgreater:
1331b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_isgreaterequal:
1341b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_isless:
1351b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_islessequal:
1361b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_islessgreater:
1371b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_isunordered:
1380eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    if (SemaBuiltinUnorderedCompare(TheCall))
1390eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
140d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
141e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer  case Builtin::BI__builtin_fpclassify:
142e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer    if (SemaBuiltinFPClassification(TheCall, 6))
143e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer      return ExprError();
144e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer    break;
1459ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isfinite:
1469ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isinf:
1479ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isinf_sign:
1489ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isnan:
1499ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isnormal:
1503b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer    if (SemaBuiltinFPClassification(TheCall, 1))
1519ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman      return ExprError();
1529ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman    break;
153d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  case Builtin::BI__builtin_shufflevector:
1540eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    return SemaBuiltinShuffleVector(TheCall);
1550eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    // TheCall will be freed by the smart pointer here, but that's fine, since
1560eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    // SemaBuiltinShuffleVector guts it, but then doesn't release it.
1574493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar  case Builtin::BI__builtin_prefetch:
1580eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    if (SemaBuiltinPrefetch(TheCall))
1590eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
160d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
161d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar  case Builtin::BI__builtin_object_size:
1620eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    if (SemaBuiltinObjectSize(TheCall))
1630eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
164d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
165d875fed28578835de89cd407e9db4be788596d7cEli Friedman  case Builtin::BI__builtin_longjmp:
166d875fed28578835de89cd407e9db4be788596d7cEli Friedman    if (SemaBuiltinLongjmp(TheCall))
167d875fed28578835de89cd407e9db4be788596d7cEli Friedman      return ExprError();
168d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
1698e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
1708e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  case Builtin::BI__builtin_classify_type:
1718e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    if (checkArgCount(*this, TheCall, 1)) return true;
1728e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    TheCall->setType(Context.IntTy);
1738e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    break;
17475c29a012793292ff4578015a9113bf086156d7fChris Lattner  case Builtin::BI__builtin_constant_p:
1758e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    if (checkArgCount(*this, TheCall, 1)) return true;
1768e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    TheCall->setType(Context.IntTy);
17775c29a012793292ff4578015a9113bf086156d7fChris Lattner    break;
1785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_add:
179a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_1:
180a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_2:
181a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_4:
182a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_8:
183a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_16:
1845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_sub:
185a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_1:
186a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_2:
187a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_4:
188a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_8:
189a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_16:
1905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_or:
191a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_1:
192a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_2:
193a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_4:
194a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_8:
195a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_16:
1965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_and:
197a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_1:
198a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_2:
199a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_4:
200a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_8:
201a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_16:
2025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_xor:
203a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_1:
204a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_2:
205a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_4:
206a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_8:
207a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_16:
2085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_add_and_fetch:
209a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_1:
210a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_2:
211a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_4:
212a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_8:
213a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_16:
2145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_sub_and_fetch:
215a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_1:
216a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_2:
217a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_4:
218a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_8:
219a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_16:
2205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_and_and_fetch:
221a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_1:
222a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_2:
223a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_4:
224a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_8:
225a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_16:
2265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_or_and_fetch:
227a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_1:
228a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_2:
229a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_4:
230a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_8:
231a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_16:
2325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_xor_and_fetch:
233a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_1:
234a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_2:
235a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_4:
236a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_8:
237a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_16:
2385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_val_compare_and_swap:
239a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_1:
240a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_2:
241a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_4:
242a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_8:
243a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_16:
2445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_bool_compare_and_swap:
245a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_1:
246a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_2:
247a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_4:
248a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_8:
249a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_16:
2505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_lock_test_and_set:
251a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_1:
252a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_2:
253a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_4:
254a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_8:
255a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_16:
2565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_lock_release:
257a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_1:
258a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_2:
259a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_4:
260a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_8:
261a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_16:
26223aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner  case Builtin::BI__sync_swap:
263a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_1:
264a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_2:
265a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_4:
266a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_8:
267a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_16:
2683fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer    return SemaBuiltinAtomicOverloaded(TheCallResult);
269ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define BUILTIN(ID, TYPE, ATTRS)
270ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define ATOMIC_BUILTIN(ID, TYPE, ATTRS) \
271ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Builtin::BI##ID: \
2723fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer    return SemaAtomicOpsOverloaded(TheCallResult, AtomicExpr::AO##ID);
273ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#include "clang/Basic/Builtins.def"
27477f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge  case Builtin::BI__builtin_annotation:
275e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    if (SemaBuiltinAnnotation(*this, TheCall))
27677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge      return ExprError();
27777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge    break;
27826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  }
27926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman
28026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  // Since the target specific builtins for each arch overlap, only check those
28126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  // of the arch we are compiling for.
28226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  if (BuiltinID >= Builtin::FirstTSBuiltin) {
283bcfd1f55bfbb3e5944cd5e03d07b343e280838c4Douglas Gregor    switch (Context.getTargetInfo().getTriple().getArch()) {
28426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman      case llvm::Triple::arm:
28526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman      case llvm::Triple::thumb:
28626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman        if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall))
28726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman          return ExprError();
28826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman        break;
289fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      case llvm::Triple::mips:
290fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      case llvm::Triple::mipsel:
291fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      case llvm::Triple::mips64:
292fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      case llvm::Triple::mips64el:
293fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan        if (CheckMipsBuiltinFunctionCall(BuiltinID, TheCall))
294fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan          return ExprError();
295fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan        break;
29626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman      default:
29726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman        break;
29826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman    }
29926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  }
30026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman
3013fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer  return TheCallResult;
30226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman}
30326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman
30461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code.
30561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) {
306da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  NeonTypeFlags Type(t);
307da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  int IsQuad = Type.isQuad();
308da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  switch (Type.getEltType()) {
309da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Int8:
310da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Poly8:
311da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return shift ? 7 : (8 << IsQuad) - 1;
312da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Int16:
313da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Poly16:
314da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return shift ? 15 : (4 << IsQuad) - 1;
315da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Int32:
316da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return shift ? 31 : (2 << IsQuad) - 1;
317da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Int64:
318da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return shift ? 63 : (1 << IsQuad) - 1;
319da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Float16:
320da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    assert(!shift && "cannot shift float types!");
321da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return (4 << IsQuad) - 1;
322da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Float32:
323da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    assert(!shift && "cannot shift float types!");
324da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return (2 << IsQuad) - 1;
32561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  }
3267530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie  llvm_unreachable("Invalid NeonTypeFlag!");
32761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman}
32861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman
3296f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// getNeonEltType - Return the QualType corresponding to the elements of
3306f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the vector type specified by the NeonTypeFlags.  This is used to check
3316f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the pointer arguments for Neon load/store intrinsics.
3326f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilsonstatic QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context) {
3336f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  switch (Flags.getEltType()) {
3346f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Int8:
3356f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy;
3366f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Int16:
3376f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy;
3386f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Int32:
3396f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy;
3406f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Int64:
3416f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Flags.isUnsigned() ? Context.UnsignedLongLongTy : Context.LongLongTy;
3426f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Poly8:
3436f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Context.SignedCharTy;
3446f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Poly16:
3456f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Context.ShortTy;
3466f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Float16:
3476f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Context.UnsignedShortTy;
3486f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Float32:
3496f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Context.FloatTy;
3506f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  }
3517530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie  llvm_unreachable("Invalid NeonTypeFlag!");
3526f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson}
3536f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson
35426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
3551c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman  llvm::APSInt Result;
3561c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman
357f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith  uint64_t mask = 0;
35861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  unsigned TV = 0;
3594648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson  int PtrArgNum = -1;
3606f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  bool HasConstPtr = false;
3611c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman  switch (BuiltinID) {
362a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK
363a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc"
364a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK
3651c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman  }
3661c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman
3670d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  // For NEON intrinsics which are overloaded on vector element type, validate
3680d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  // the immediate which specifies which variant to emit.
3696f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  unsigned ImmArg = TheCall->getNumArgs()-1;
3700d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  if (mask) {
3716f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    if (SemaBuiltinConstantArg(TheCall, ImmArg, Result))
3720d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman      return true;
3730d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman
374da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    TV = Result.getLimitedValue(64);
375f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith    if ((TV > 63) || (mask & (1ULL << TV)) == 0)
3760d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman      return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code)
3776f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson        << TheCall->getArg(ImmArg)->getSourceRange();
3786f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  }
3796f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson
3804648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson  if (PtrArgNum >= 0) {
3816f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    // Check that pointer arguments have the specified type.
3824648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    Expr *Arg = TheCall->getArg(PtrArgNum);
3834648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg))
3844648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson      Arg = ICE->getSubExpr();
3854648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg);
3864648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    QualType RHSTy = RHS.get()->getType();
3874648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context);
3884648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    if (HasConstPtr)
3894648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson      EltTy = EltTy.withConst();
3904648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    QualType LHSTy = Context.getPointerType(EltTy);
3914648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    AssignConvertType ConvTy;
3924648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS);
3934648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    if (RHS.isInvalid())
3944648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson      return true;
3954648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy,
3964648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson                                 RHS.get(), AA_Assigning))
3974648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson      return true;
3980d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  }
3991c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman
4000d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  // For NEON intrinsics which take an immediate value as part of the
4010d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  // instruction, range check them here.
40261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  unsigned i = 0, l = 0, u = 0;
4030d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  switch (BuiltinID) {
4040d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  default: return false;
405bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman  case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break;
406bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman  case ARM::BI__builtin_arm_usat: i = 1; u = 31; break;
40799c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman  case ARM::BI__builtin_arm_vcvtr_f:
40899c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman  case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break;
409a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK
410a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc"
411a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK
4120d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  };
4130d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman
414592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor  // We can't check the value of a dependent argument.
415592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor  if (TheCall->getArg(i)->isTypeDependent() ||
416592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor      TheCall->getArg(i)->isValueDependent())
417592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor    return false;
418592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
41961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  // Check that the immediate argument is actually a constant.
4200d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  if (SemaBuiltinConstantArg(TheCall, i, Result))
4210d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman    return true;
4220d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman
42361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  // Range check against the upper/lower values for this isntruction.
4240d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  unsigned Val = Result.getZExtValue();
42561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  if (Val < l || Val > (u + l))
4260d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman    return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
427476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer      << l << u+l << TheCall->getArg(i)->getSourceRange();
4280d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman
42999c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman  // FIXME: VFP Intrinsics should error if VFP not present.
43026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  return false;
431d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson}
432d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson
433fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyanbool Sema::CheckMipsBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
434fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  unsigned i = 0, l = 0, u = 0;
435fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  switch (BuiltinID) {
436fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  default: return false;
437fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  case Mips::BI__builtin_mips_wrdsp: i = 1; l = 0; u = 63; break;
438fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  case Mips::BI__builtin_mips_rddsp: i = 0; l = 0; u = 63; break;
439be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan  case Mips::BI__builtin_mips_append: i = 2; l = 0; u = 31; break;
440be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan  case Mips::BI__builtin_mips_balign: i = 2; l = 0; u = 3; break;
441be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan  case Mips::BI__builtin_mips_precr_sra_ph_w: i = 2; l = 0; u = 31; break;
442be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan  case Mips::BI__builtin_mips_precr_sra_r_ph_w: i = 2; l = 0; u = 31; break;
443be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan  case Mips::BI__builtin_mips_prepend: i = 2; l = 0; u = 31; break;
444fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  };
445fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
446fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  // We can't check the value of a dependent argument.
447fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  if (TheCall->getArg(i)->isTypeDependent() ||
448fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      TheCall->getArg(i)->isValueDependent())
449fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan    return false;
450fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
451fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  // Check that the immediate argument is actually a constant.
452fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  llvm::APSInt Result;
453fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  if (SemaBuiltinConstantArg(TheCall, i, Result))
454fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan    return true;
455fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
456fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  // Range check against the upper/lower values for this instruction.
457fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  unsigned Val = Result.getZExtValue();
458fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  if (Val < l || Val > u)
459fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan    return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
460fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      << l << u << TheCall->getArg(i)->getSourceRange();
461fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
462fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  return false;
463fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan}
464fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
465831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Given a FunctionDecl's FormatAttr, attempts to populate the FomatStringInfo
466831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// parameter with the FormatAttr's correct format_idx and firstDataArg.
467831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true when the format fits the function and the FormatStringInfo has
468831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// been populated.
469831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::getFormatStringInfo(const FormatAttr *Format, bool IsCXXMember,
470831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                               FormatStringInfo *FSI) {
471831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  FSI->HasVAListArg = Format->getFirstArg() == 0;
472831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  FSI->FormatIdx = Format->getFormatIdx() - 1;
473831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  FSI->FirstDataArg = FSI->HasVAListArg ? 0 : Format->getFirstArg() - 1;
474de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar
475831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // The way the format attribute works in GCC, the implicit this argument
476831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // of member functions is counted. However, it doesn't appear in our own
477831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // lists, so decrement format_idx in that case.
478831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (IsCXXMember) {
479831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    if(FSI->FormatIdx == 0)
480831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      return false;
481831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    --FSI->FormatIdx;
482831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    if (FSI->FirstDataArg != 0)
483831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      --FSI->FirstDataArg;
484831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  }
485831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return true;
486831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
4871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
488831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Handles the checks for format strings, non-POD arguments to vararg
489831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// functions, and NULL arguments passed to non-NULL parameters.
4901c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkovoid Sema::checkCall(NamedDecl *FDecl,
4911c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko                     ArrayRef<const Expr *> Args,
492831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     unsigned NumProtoArgs,
493831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     bool IsMemberFunction,
494831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     SourceLocation Loc,
495831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     SourceRange Range,
496831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     VariadicCallType CallType) {
49766360e224689dc23a0acd8a6705ba50bec13bc97Jordan Rose  if (CurContext->isDependentContext())
49866360e224689dc23a0acd8a6705ba50bec13bc97Jordan Rose    return;
499de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar
500c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek  // Printf and scanf checking.
501831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  bool HandledFormatString = false;
502c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek  for (specific_attr_iterator<FormatAttr>
503831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith         I = FDecl->specific_attr_begin<FormatAttr>(),
504831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith         E = FDecl->specific_attr_end<FormatAttr>(); I != E ; ++I)
5051c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko    if (CheckFormatArguments(*I, Args, IsMemberFunction, CallType, Loc, Range))
506831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        HandledFormatString = true;
507831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
508831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // Refuse POD arguments that weren't caught by the format string
509831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // checks above.
510831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (!HandledFormatString && CallType != VariadicDoesNotApply)
5111c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko    for (unsigned ArgIdx = NumProtoArgs; ArgIdx < Args.size(); ++ArgIdx) {
5120234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek      // Args[ArgIdx] can be null in malformed code.
5131c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko      if (const Expr *Arg = Args[ArgIdx])
5140234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek        variadicArgumentPODCheck(Arg, CallType);
5150234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek    }
5161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
517c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek  for (specific_attr_iterator<NonNullAttr>
518831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith         I = FDecl->specific_attr_begin<NonNullAttr>(),
519831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith         E = FDecl->specific_attr_end<NonNullAttr>(); I != E; ++I)
5201c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko    CheckNonNullArguments(*I, Args.data(), Loc);
5210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
5220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // Type safety checking.
5230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  for (specific_attr_iterator<ArgumentWithTypeTagAttr>
5240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         i = FDecl->specific_attr_begin<ArgumentWithTypeTagAttr>(),
5250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         e = FDecl->specific_attr_end<ArgumentWithTypeTagAttr>(); i != e; ++i) {
5261c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko    CheckArgumentWithTypeTag(*i, Args.data());
5270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
528831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
529831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
530831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckConstructorCall - Check a constructor call for correctness and safety
531831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// properties not enforced by the C type system.
5321c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkovoid Sema::CheckConstructorCall(FunctionDecl *FDecl,
5331c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko                                ArrayRef<const Expr *> Args,
534831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                const FunctionProtoType *Proto,
535831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                SourceLocation Loc) {
536831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  VariadicCallType CallType =
537831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    Proto->isVariadic() ? VariadicConstructor : VariadicDoesNotApply;
5381c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko  checkCall(FDecl, Args, Proto->getNumArgs(),
539831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            /*IsMemberFunction=*/true, Loc, SourceRange(), CallType);
540831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
541831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
542831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckFunctionCall - Check a direct function call for various correctness
543831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// and safety properties not strictly enforced by the C type system.
544831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall,
545831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                             const FunctionProtoType *Proto) {
5462edcde8747a000113b434a5c88b4648beed4197bEli Friedman  bool IsMemberOperatorCall = isa<CXXOperatorCallExpr>(TheCall) &&
5472edcde8747a000113b434a5c88b4648beed4197bEli Friedman                              isa<CXXMethodDecl>(FDecl);
5482edcde8747a000113b434a5c88b4648beed4197bEli Friedman  bool IsMemberFunction = isa<CXXMemberCallExpr>(TheCall) ||
5492edcde8747a000113b434a5c88b4648beed4197bEli Friedman                          IsMemberOperatorCall;
550831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  VariadicCallType CallType = getVariadicCallType(FDecl, Proto,
551831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                                  TheCall->getCallee());
552831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0;
5532edcde8747a000113b434a5c88b4648beed4197bEli Friedman  Expr** Args = TheCall->getArgs();
5542edcde8747a000113b434a5c88b4648beed4197bEli Friedman  unsigned NumArgs = TheCall->getNumArgs();
555df75b0c74b277c6b46af2f9e90e13160fbc14d6fEli Friedman  if (IsMemberOperatorCall) {
5562edcde8747a000113b434a5c88b4648beed4197bEli Friedman    // If this is a call to a member operator, hide the first argument
5572edcde8747a000113b434a5c88b4648beed4197bEli Friedman    // from checkCall.
5582edcde8747a000113b434a5c88b4648beed4197bEli Friedman    // FIXME: Our choice of AST representation here is less than ideal.
5592edcde8747a000113b434a5c88b4648beed4197bEli Friedman    ++Args;
5602edcde8747a000113b434a5c88b4648beed4197bEli Friedman    --NumArgs;
5612edcde8747a000113b434a5c88b4648beed4197bEli Friedman  }
5621c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko  checkCall(FDecl, llvm::makeArrayRef<const Expr *>(Args, NumArgs),
5631c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko            NumProtoArgs,
564831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            IsMemberFunction, TheCall->getRParenLoc(),
565831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            TheCall->getCallee()->getSourceRange(), CallType);
566831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
567831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  IdentifierInfo *FnInfo = FDecl->getIdentifier();
568831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // None of the checks below are needed for functions that don't have
569831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // simple names (e.g., C++ conversion functions).
570831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (!FnInfo)
571831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return false;
5720eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl
5730a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  unsigned CMId = FDecl->getMemoryFunctionKind();
5740a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  if (CMId == 0)
575d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks    return false;
576bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
577d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks  // Handle memory setting and copying functions.
5780a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat)
579bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    CheckStrlcpycatArguments(TheCall, FnInfo);
580c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  else if (CMId == Builtin::BIstrncat)
581c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    CheckStrncatArguments(TheCall, FnInfo);
582d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks  else
5830a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks    CheckMemaccessArguments(TheCall, CMId, FnInfo);
5847ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth
585d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson  return false;
58671993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson}
58771993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson
58829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupasbool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac,
58929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                               Expr **Args, unsigned NumArgs) {
590831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  VariadicCallType CallType =
591831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      Method->isVariadic() ? VariadicMethod : VariadicDoesNotApply;
59229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas
5931c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko  checkCall(Method, llvm::makeArrayRef<const Expr *>(Args, NumArgs),
5941c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko            Method->param_size(),
595831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            /*IsMemberFunction=*/false,
596831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            lbrac, Method->getSourceRange(), CallType);
59729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas
59829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  return false;
59929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas}
60029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas
601831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall,
602831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                          const FunctionProtoType *Proto) {
603725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian  const VarDecl *V = dyn_cast<VarDecl>(NDecl);
604725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian  if (!V)
605d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    return false;
6061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
607725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian  QualType Ty = V->getType();
608725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian  if (!Ty->isBlockPointerType())
609d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    return false;
6101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
611831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  VariadicCallType CallType =
612831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      Proto && Proto->isVariadic() ? VariadicBlock : VariadicDoesNotApply ;
613831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0;
614d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson
6151c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko  checkCall(NDecl,
6161c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko            llvm::makeArrayRef<const Expr *>(TheCall->getArgs(),
6171c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko                                             TheCall->getNumArgs()),
618831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            NumProtoArgs, /*IsMemberFunction=*/false,
619831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            TheCall->getRParenLoc(),
620831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            TheCall->getCallee()->getSourceRange(), CallType);
621831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
622d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson  return false;
623725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian}
624725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian
625ff34d401ff385ef7173ca612432b4ea717fff690Richard SmithExprResult Sema::SemaAtomicOpsOverloaded(ExprResult TheCallResult,
626ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith                                         AtomicExpr::AtomicOp Op) {
627276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  CallExpr *TheCall = cast<CallExpr>(TheCallResult.get());
628276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
629276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
630ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // All these operations take one of the following forms:
631ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  enum {
632ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // C    __c11_atomic_init(A *, C)
633ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Init,
634ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // C    __c11_atomic_load(A *, int)
635ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Load,
636ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // void __atomic_load(A *, CP, int)
637ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Copy,
638ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // C    __c11_atomic_add(A *, M, int)
639ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Arithmetic,
640ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // C    __atomic_exchange_n(A *, CP, int)
641ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Xchg,
642ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // void __atomic_exchange(A *, C *, CP, int)
643ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    GNUXchg,
644ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // bool __c11_atomic_compare_exchange_strong(A *, C *, CP, int, int)
645ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    C11CmpXchg,
646ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // bool __atomic_compare_exchange(A *, C *, CP, bool, int, int)
647ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    GNUCmpXchg
648ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  } Form = Init;
649ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  const unsigned NumArgs[] = { 2, 2, 3, 3, 3, 4, 5, 6 };
650ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  const unsigned NumVals[] = { 1, 0, 1, 1, 1, 2, 2, 3 };
651ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // where:
652ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   C is an appropriate type,
653ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   A is volatile _Atomic(C) for __c11 builtins and is C for GNU builtins,
654ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   CP is C for __c11 builtins and GNU _n builtins and is C * otherwise,
655ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   M is C if C is an integer, and ptrdiff_t if C is a pointer, and
656ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   the int parameters are for orderings.
657ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
658ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  assert(AtomicExpr::AO__c11_atomic_init == 0 &&
659ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith         AtomicExpr::AO__c11_atomic_fetch_xor + 1 == AtomicExpr::AO__atomic_load
660ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith         && "need to update code for modified C11 atomics");
661ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  bool IsC11 = Op >= AtomicExpr::AO__c11_atomic_init &&
662ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith               Op <= AtomicExpr::AO__c11_atomic_fetch_xor;
663ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  bool IsN = Op == AtomicExpr::AO__atomic_load_n ||
664ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith             Op == AtomicExpr::AO__atomic_store_n ||
665ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith             Op == AtomicExpr::AO__atomic_exchange_n ||
666ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith             Op == AtomicExpr::AO__atomic_compare_exchange_n;
667ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  bool IsAddSub = false;
668ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
669ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  switch (Op) {
670ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_init:
671ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Init;
672ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
673ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
674ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_load:
675ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_load_n:
676ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Load;
677ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
678ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
679ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_store:
680ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_load:
681ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_store:
682ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_store_n:
683ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Copy;
684ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
685ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
686ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_add:
687ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_sub:
688ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_add:
689ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_sub:
690ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_add_fetch:
691ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_sub_fetch:
692ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    IsAddSub = true;
693ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // Fall through.
694ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_and:
695ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_or:
696ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_xor:
697ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_and:
698ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_or:
699ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_xor:
70051b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith  case AtomicExpr::AO__atomic_fetch_nand:
701ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_and_fetch:
702ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_or_fetch:
703ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_xor_fetch:
70451b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith  case AtomicExpr::AO__atomic_nand_fetch:
705ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Arithmetic;
706ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
707ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
708ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_exchange:
709ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_exchange_n:
710ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Xchg;
711ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
712ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
713ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_exchange:
714ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = GNUXchg;
715ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
716ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
717ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_compare_exchange_strong:
718ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_compare_exchange_weak:
719ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = C11CmpXchg;
720ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
721ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
722ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_compare_exchange:
723ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_compare_exchange_n:
724ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = GNUCmpXchg;
725ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
726276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
727276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
728ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // Check we have the right number of arguments.
729ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (TheCall->getNumArgs() < NumArgs[Form]) {
730276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
731ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      << 0 << NumArgs[Form] << TheCall->getNumArgs()
732276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << TheCall->getCallee()->getSourceRange();
733276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
734ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  } else if (TheCall->getNumArgs() > NumArgs[Form]) {
735ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Diag(TheCall->getArg(NumArgs[Form])->getLocStart(),
736276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman         diag::err_typecheck_call_too_many_args)
737ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      << 0 << NumArgs[Form] << TheCall->getNumArgs()
738276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << TheCall->getCallee()->getSourceRange();
739276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
740276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
741276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
742ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // Inspect the first argument of the atomic operation.
743dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman  Expr *Ptr = TheCall->getArg(0);
744276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get();
745276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  const PointerType *pointerType = Ptr->getType()->getAs<PointerType>();
746276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  if (!pointerType) {
747ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
748276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << Ptr->getType() << Ptr->getSourceRange();
749276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
750276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
751276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
752ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // For a __c11 builtin, this should be a pointer to an _Atomic type.
753ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  QualType AtomTy = pointerType->getPointeeType(); // 'A'
754ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  QualType ValType = AtomTy; // 'C'
755ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (IsC11) {
756ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    if (!AtomTy->isAtomicType()) {
757ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic)
758ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        << Ptr->getType() << Ptr->getSourceRange();
759ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      return ExprError();
760ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    }
761bc57b108b2253e26b83768dba196c28564952f18Richard Smith    if (AtomTy.isConstQualified()) {
762bc57b108b2253e26b83768dba196c28564952f18Richard Smith      Diag(DRE->getLocStart(), diag::err_atomic_op_needs_non_const_atomic)
763bc57b108b2253e26b83768dba196c28564952f18Richard Smith        << Ptr->getType() << Ptr->getSourceRange();
764bc57b108b2253e26b83768dba196c28564952f18Richard Smith      return ExprError();
765bc57b108b2253e26b83768dba196c28564952f18Richard Smith    }
766ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    ValType = AtomTy->getAs<AtomicType>()->getValueType();
767276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
768276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
769ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // For an arithmetic operation, the implied arithmetic must be well-formed.
770ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (Form == Arithmetic) {
771ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // gcc does not enforce these rules for GNU atomics, but we do so for sanity.
772ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    if (IsAddSub && !ValType->isIntegerType() && !ValType->isPointerType()) {
773ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr)
774ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        << IsC11 << Ptr->getType() << Ptr->getSourceRange();
775ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      return ExprError();
776ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    }
777ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    if (!IsAddSub && !ValType->isIntegerType()) {
778ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      Diag(DRE->getLocStart(), diag::err_atomic_op_bitwise_needs_atomic_int)
779ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        << IsC11 << Ptr->getType() << Ptr->getSourceRange();
780ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      return ExprError();
781ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    }
782ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  } else if (IsN && !ValType->isIntegerType() && !ValType->isPointerType()) {
783ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // For __atomic_*_n operations, the value type must be a scalar integral or
784ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // pointer type which is 1, 2, 4, 8 or 16 bytes in length.
785276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr)
786ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      << IsC11 << Ptr->getType() << Ptr->getSourceRange();
787276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
788276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
789276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
790ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (!IsC11 && !AtomTy.isTriviallyCopyableType(Context)) {
791ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // For GNU atomics, require a trivially-copyable type. This is not part of
792ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // the GNU atomics specification, but we enforce it for sanity.
793ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Diag(DRE->getLocStart(), diag::err_atomic_op_needs_trivial_copy)
794276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << Ptr->getType() << Ptr->getSourceRange();
795276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
796276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
797276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
798ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // FIXME: For any builtin other than a load, the ValType must not be
799ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // const-qualified.
800ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
801276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  switch (ValType.getObjCLifetime()) {
802276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_None:
803276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_ExplicitNone:
804276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    // okay
805276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    break;
806276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
807276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_Weak:
808276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_Strong:
809276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_Autoreleasing:
810ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // FIXME: Can this happen? By this point, ValType should be known
811ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // to be trivially copyable.
812276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
813276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << ValType << Ptr->getSourceRange();
814276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
815276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
816276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
817276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  QualType ResultType = ValType;
818ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (Form == Copy || Form == GNUXchg || Form == Init)
819276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    ResultType = Context.VoidTy;
820ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  else if (Form == C11CmpXchg || Form == GNUCmpXchg)
821276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    ResultType = Context.BoolTy;
822276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
823ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // The type of a parameter passed 'by value'. In the GNU atomics, such
824ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // arguments are actually passed as pointers.
825ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  QualType ByValType = ValType; // 'CP'
826ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (!IsC11 && !IsN)
827ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    ByValType = Ptr->getType();
828ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
829276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  // The first argument --- the pointer --- has a fixed type; we
830276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  // deduce the types of the rest of the arguments accordingly.  Walk
831276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  // the remaining arguments, converting them to the deduced value type.
832ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  for (unsigned i = 1; i != NumArgs[Form]; ++i) {
833276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    QualType Ty;
834ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    if (i < NumVals[Form] + 1) {
835ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      switch (i) {
836ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      case 1:
837ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // The second argument is the non-atomic operand. For arithmetic, this
838ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // is always passed by value, and for a compare_exchange it is always
839ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // passed by address. For the rest, GNU uses by-address and C11 uses
840ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // by-value.
841ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        assert(Form != Load);
842ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        if (Form == Init || (Form == Arithmetic && ValType->isIntegerType()))
843ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith          Ty = ValType;
844ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        else if (Form == Copy || Form == Xchg)
845ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith          Ty = ByValType;
846ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        else if (Form == Arithmetic)
847ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith          Ty = Context.getPointerDiffType();
848ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        else
849ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith          Ty = Context.getPointerType(ValType.getUnqualifiedType());
850ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        break;
851ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      case 2:
852ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // The third argument to compare_exchange / GNU exchange is a
853ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // (pointer to a) desired value.
854ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        Ty = ByValType;
855ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        break;
856ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      case 3:
857ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // The fourth argument to GNU compare_exchange is a 'weak' flag.
858ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        Ty = Context.BoolTy;
859ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        break;
860ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      }
861276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    } else {
862276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      // The order(s) are always converted to int.
863276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      Ty = Context.IntTy;
864276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    }
865ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
866276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    InitializedEntity Entity =
867276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman        InitializedEntity::InitializeParameter(Context, Ty, false);
868ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    ExprResult Arg = TheCall->getArg(i);
869276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
870276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    if (Arg.isInvalid())
871276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      return true;
872276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    TheCall->setArg(i, Arg.get());
873276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
874276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
875ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // Permute the arguments into a 'consistent' order.
876dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman  SmallVector<Expr*, 5> SubExprs;
877dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman  SubExprs.push_back(Ptr);
878ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  switch (Form) {
879ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Init:
880ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // Note, AtomicExpr::getVal1() has a special case for this atomic.
8817a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall    SubExprs.push_back(TheCall->getArg(1)); // Val1
882ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
883ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Load:
884ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(1)); // Order
885ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
886ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Copy:
887ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Arithmetic:
888ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Xchg:
889dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(2)); // Order
890dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(1)); // Val1
891ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
892ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case GNUXchg:
893ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // Note, AtomicExpr::getVal2() has a special case for this atomic.
894ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(3)); // Order
895ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(1)); // Val1
896ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(2)); // Val2
897ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
898ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case C11CmpXchg:
899dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(3)); // Order
900dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(1)); // Val1
901dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(4)); // OrderFail
9022ebb98a78471f2039af4321bae657e7daacc2a62David Chisnall    SubExprs.push_back(TheCall->getArg(2)); // Val2
903ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
904ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case GNUCmpXchg:
905ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(4)); // Order
906ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(1)); // Val1
907ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(5)); // OrderFail
908ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(2)); // Val2
909ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(3)); // Weak
910ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
911276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
912dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman
913dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman  return Owned(new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(),
9143b6bef9a213249c6ab6d67c07b1ac6380961be3eBenjamin Kramer                                        SubExprs, ResultType, Op,
915dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman                                        TheCall->getRParenLoc()));
916276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman}
917276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
918276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
9195f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// checkBuiltinArgument - Given a call to a builtin function, perform
9205f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// normal type-checking on the given argument, updating the call in
9215f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// place.  This is useful when a builtin function requires custom
9225f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// type-checking for some of its arguments but not necessarily all of
9235f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// them.
9245f8d604246976a93a73549b07bbc8ee0b2061b50John McCall///
9255f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// Returns true on error.
9265f8d604246976a93a73549b07bbc8ee0b2061b50John McCallstatic bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) {
9275f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  FunctionDecl *Fn = E->getDirectCallee();
9285f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  assert(Fn && "builtin call without direct callee!");
9295f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
9305f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  ParmVarDecl *Param = Fn->getParamDecl(ArgIndex);
9315f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  InitializedEntity Entity =
9325f8d604246976a93a73549b07bbc8ee0b2061b50John McCall    InitializedEntity::InitializeParameter(S.Context, Param);
9335f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
9345f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  ExprResult Arg = E->getArg(0);
9355f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
9365f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  if (Arg.isInvalid())
9375f8d604246976a93a73549b07bbc8ee0b2061b50John McCall    return true;
9385f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
9395f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  E->setArg(ArgIndex, Arg.take());
9405f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  return false;
9415f8d604246976a93a73549b07bbc8ee0b2061b50John McCall}
9425f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
9435caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like
9445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer
9455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument.  The main ActOnCallExpr routines have already
9465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as
9475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...).
9485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner///
9495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these
9505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins,
95160d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult
95260d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) {
953d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  CallExpr *TheCall = (CallExpr *)TheCallResult.get();
9545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
9555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
9565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner
9575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Ensure that we have at least one argument to do type inference from.
958d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  if (TheCall->getNumArgs() < 1) {
959d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
960d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << 0 << 1 << TheCall->getNumArgs()
961d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << TheCall->getCallee()->getSourceRange();
962d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
963d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  }
9641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
9655caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Inspect the first argument of the atomic builtin.  This should always be
9665caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // a pointer type, whose element is an integral scalar or pointer type.
9675caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Because it is a pointer type, we don't have to worry about any implicit
9685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // casts here.
969d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  // FIXME: We don't allow floating point scalars as input.
9705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  Expr *FirstArg = TheCall->getArg(0);
9718c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman  ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg);
9728c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman  if (FirstArgResult.isInvalid())
9738c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman    return ExprError();
9748c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman  FirstArg = FirstArgResult.take();
9758c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman  TheCall->setArg(0, FirstArg);
9768c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman
977f85e193739c953358c865005855253af4f68a497John McCall  const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>();
978f85e193739c953358c865005855253af4f68a497John McCall  if (!pointerType) {
979d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
980d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << FirstArg->getType() << FirstArg->getSourceRange();
981d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
982d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  }
9831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
984f85e193739c953358c865005855253af4f68a497John McCall  QualType ValType = pointerType->getPointeeType();
985dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner  if (!ValType->isIntegerType() && !ValType->isAnyPointerType() &&
986d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      !ValType->isBlockPointerType()) {
987d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr)
988d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << FirstArg->getType() << FirstArg->getSourceRange();
989d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
990d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  }
9915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner
992f85e193739c953358c865005855253af4f68a497John McCall  switch (ValType.getObjCLifetime()) {
993f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_None:
994f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_ExplicitNone:
995f85e193739c953358c865005855253af4f68a497John McCall    // okay
996f85e193739c953358c865005855253af4f68a497John McCall    break;
997f85e193739c953358c865005855253af4f68a497John McCall
998f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_Weak:
999f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_Strong:
1000f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_Autoreleasing:
1001b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis    Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
1002f85e193739c953358c865005855253af4f68a497John McCall      << ValType << FirstArg->getSourceRange();
1003f85e193739c953358c865005855253af4f68a497John McCall    return ExprError();
1004f85e193739c953358c865005855253af4f68a497John McCall  }
1005f85e193739c953358c865005855253af4f68a497John McCall
1006b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall  // Strip any qualifiers off ValType.
1007b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall  ValType = ValType.getUnqualifiedType();
1008b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall
10098d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth  // The majority of builtins return a value, but a few have special return
10108d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth  // types, so allow them to override appropriately below.
10118d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth  QualType ResultType = ValType;
10128d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth
10135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // We need to figure out which concrete builtin this maps onto.  For example,
10145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // __sync_fetch_and_add with a 2 byte object turns into
10155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // __sync_fetch_and_add_2.
10165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \
10175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \
10185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    Builtin::BI##x##_8, Builtin::BI##x##_16 }
10191eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
10205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  static const unsigned BuiltinIndices[][5] = {
10215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_add),
10225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_sub),
10235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_or),
10245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_and),
10255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_xor),
10261eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
10275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_add_and_fetch),
10285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_sub_and_fetch),
10295caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_and_and_fetch),
10305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_or_and_fetch),
10315caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_xor_and_fetch),
10321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
10335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_val_compare_and_swap),
10345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_bool_compare_and_swap),
10355caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_lock_test_and_set),
103623aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner    BUILTIN_ROW(__sync_lock_release),
103723aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner    BUILTIN_ROW(__sync_swap)
10385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  };
10391eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW
10401eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
10415caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Determine the index of the size.
10425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  unsigned SizeIndex;
1043199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck  switch (Context.getTypeSizeInChars(ValType).getQuantity()) {
10445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 1: SizeIndex = 0; break;
10455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 2: SizeIndex = 1; break;
10465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 4: SizeIndex = 2; break;
10475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 8: SizeIndex = 3; break;
10485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 16: SizeIndex = 4; break;
10495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  default:
1050d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size)
1051d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << FirstArg->getType() << FirstArg->getSourceRange();
1052d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
10535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  }
10541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
10555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Each of these builtins has one pointer argument, followed by some number of
10565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // values (0, 1 or 2) followed by a potentially empty varags list of stuff
10575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // that we ignore.  Find out which row of BuiltinIndices to read from as well
10585caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // as the number of fixed args.
10597814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor  unsigned BuiltinID = FDecl->getBuiltinID();
10605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  unsigned BuiltinIndex, NumFixed = 1;
10615caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  switch (BuiltinID) {
1062b219cfc4d75f0a03630b7c4509ef791b7e97b2c8David Blaikie  default: llvm_unreachable("Unknown overloaded atomic builtin!");
1063a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add:
1064a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_1:
1065a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_2:
1066a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_4:
1067a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_8:
1068a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_16:
1069a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 0;
1070a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1071a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1072a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub:
1073a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_1:
1074a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_2:
1075a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_4:
1076a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_8:
1077a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_16:
1078a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 1;
1079a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1080a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1081a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or:
1082a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_1:
1083a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_2:
1084a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_4:
1085a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_8:
1086a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_16:
1087a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 2;
1088a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1089a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1090a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and:
1091a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_1:
1092a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_2:
1093a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_4:
1094a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_8:
1095a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_16:
1096a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 3;
1097a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1098a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1099a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor:
1100a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_1:
1101a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_2:
1102a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_4:
1103a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_8:
1104a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_16:
1105a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 4;
1106a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1107a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1108a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch:
1109a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_1:
1110a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_2:
1111a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_4:
1112a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_8:
1113a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_16:
1114a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 5;
1115a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1116a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1117a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch:
1118a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_1:
1119a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_2:
1120a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_4:
1121a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_8:
1122a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_16:
1123a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 6;
1124a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1125a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1126a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch:
1127a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_1:
1128a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_2:
1129a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_4:
1130a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_8:
1131a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_16:
1132a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 7;
1133a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1134a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1135a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch:
1136a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_1:
1137a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_2:
1138a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_4:
1139a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_8:
1140a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_16:
1141a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 8;
1142a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1143a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1144a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch:
1145a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_1:
1146a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_2:
1147a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_4:
1148a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_8:
1149a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_16:
1150a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 9;
1151a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
11521eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
11535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_val_compare_and_swap:
1154a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_1:
1155a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_2:
1156a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_4:
1157a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_8:
1158a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_16:
11597eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar    BuiltinIndex = 10;
11605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    NumFixed = 2;
11615caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    break;
1162a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
11635caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_bool_compare_and_swap:
1164a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_1:
1165a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_2:
1166a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_4:
1167a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_8:
1168a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_16:
11697eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar    BuiltinIndex = 11;
11705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    NumFixed = 2;
11718d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth    ResultType = Context.BoolTy;
11725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    break;
1173a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1174a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set:
1175a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_1:
1176a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_2:
1177a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_4:
1178a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_8:
1179a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_16:
1180a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 12;
1181a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1182a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
11835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_lock_release:
1184a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_1:
1185a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_2:
1186a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_4:
1187a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_8:
1188a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_16:
11897eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar    BuiltinIndex = 13;
11905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    NumFixed = 0;
11918d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth    ResultType = Context.VoidTy;
11925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    break;
1193a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1194a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap:
1195a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_1:
1196a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_2:
1197a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_4:
1198a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_8:
1199a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_16:
1200a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 14;
1201a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
12025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  }
12031eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
12045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Now that we know how many fixed arguments we expect, first check that we
12055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // have at least that many.
1206d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  if (TheCall->getNumArgs() < 1+NumFixed) {
1207d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
1208d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << 0 << 1+NumFixed << TheCall->getNumArgs()
1209d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << TheCall->getCallee()->getSourceRange();
1210d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
1211d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  }
12121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1213e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner  // Get the decl for the concrete builtin from this, we can tell what the
1214e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner  // concrete integer type we should convert to is.
1215e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner  unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex];
1216e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner  const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID);
12172ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara  FunctionDecl *NewBuiltinDecl;
12182ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara  if (NewBuiltinID == BuiltinID)
12192ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara    NewBuiltinDecl = FDecl;
12202ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara  else {
12212ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara    // Perform builtin lookup to avoid redeclaring it.
12222ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara    DeclarationName DN(&Context.Idents.get(NewBuiltinName));
12232ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara    LookupResult Res(*this, DN, DRE->getLocStart(), LookupOrdinaryName);
12242ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara    LookupName(Res, TUScope, /*AllowBuiltinCreation=*/true);
12252ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara    assert(Res.getFoundDecl());
12262ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara    NewBuiltinDecl = dyn_cast<FunctionDecl>(Res.getFoundDecl());
12272ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara    if (NewBuiltinDecl == 0)
12282ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara      return ExprError();
12292ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara  }
1230d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth
1231f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall  // The first argument --- the pointer --- has a fixed type; we
1232f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall  // deduce the types of the rest of the arguments accordingly.  Walk
1233f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall  // the remaining arguments, converting them to the deduced value type.
12345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  for (unsigned i = 0; i != NumFixed; ++i) {
1235429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley    ExprResult Arg = TheCall->getArg(i+1);
12361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
12375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // GCC does an implicit conversion to the pointer or integer ValType.  This
12385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // can fail in some cases (1i -> int**), check for this error case now.
1239b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall    // Initialize the argument.
1240b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall    InitializedEntity Entity = InitializedEntity::InitializeParameter(Context,
1241b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall                                                   ValType, /*consume*/ false);
1242b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall    Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
1243429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley    if (Arg.isInvalid())
1244d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      return ExprError();
12451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
12465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // Okay, we have something that *can* be converted to the right type.  Check
12475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // to see if there is a potentially weird extension going on here.  This can
12485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // happen when you do an atomic operation on something like an char* and
12495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // pass in 42.  The 42 gets converted to char.  This is even more strange
12505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // for things like 45.123 -> char, etc.
12511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump    // FIXME: Do this check.
1252b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall    TheCall->setArg(i+1, Arg.take());
12535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  }
12541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1255bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor  ASTContext& Context = this->getASTContext();
1256bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor
1257bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor  // Create a new DeclRefExpr to refer to the new decl.
1258bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor  DeclRefExpr* NewDRE = DeclRefExpr::Create(
1259bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      Context,
1260bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      DRE->getQualifierLoc(),
1261e4b92761b43ced611c417ae478568610f1ad7b1eAbramo Bagnara      SourceLocation(),
1262bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      NewBuiltinDecl,
1263f4b88a45902af1802a1cb42ba48b1c474474f228John McCall      /*enclosing*/ false,
1264bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      DRE->getLocation(),
1265a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman      Context.BuiltinFnTy,
1266bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      DRE->getValueKind());
12671eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
12685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Set the callee in the CallExpr.
1269a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman  // FIXME: This loses syntactic information.
1270a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman  QualType CalleePtrTy = Context.getPointerType(NewBuiltinDecl->getType());
1271a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman  ExprResult PromotedCall = ImpCastExprToType(NewDRE, CalleePtrTy,
1272a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman                                              CK_BuiltinFnToFnPtr);
1273429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  TheCall->setCallee(PromotedCall.take());
12741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1275db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth  // Change the result type of the call to match the original value type. This
1276db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth  // is arbitrary, but the codegen for these builtins ins design to handle it
1277db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth  // gracefully.
12788d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth  TheCall->setType(ResultType);
1279d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth
12803fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer  return TheCallResult;
12815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner}
12825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner
1283690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin
128471993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct
1285fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would
1286fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend).
1287690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) {
128856f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner  Arg = Arg->IgnoreParenCasts();
128971993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson  StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
129071993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson
12915cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor  if (!Literal || !Literal->isAscii()) {
1292fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner    Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant)
1293fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner      << Arg->getSourceRange();
12949cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson    return true;
129571993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson  }
12961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
12977da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian  if (Literal->containsNonAsciiOrNull()) {
12985f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner    StringRef String = Literal->getString();
12997da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    unsigned NumBytes = String.size();
13005f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner    SmallVector<UTF16, 128> ToBuf(NumBytes);
130131ba6135375433b617a8587ea6cc836a014ebd86Roman Divacky    const UTF8 *FromPtr = (const UTF8 *)String.data();
13027da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    UTF16 *ToPtr = &ToBuf[0];
13037da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian
13047da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes,
13057da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian                                                 &ToPtr, ToPtr + NumBytes,
13067da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian                                                 strictConversion);
13077da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    // Check for conversion failure.
13087da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    if (Result != conversionOK)
13097da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian      Diag(Arg->getLocStart(),
13107da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian           diag::warn_cfstring_truncated) << Arg->getSourceRange();
13117da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian  }
13129cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson  return false;
131359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner}
131459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner
1315c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity.
1316c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success.
1317925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) {
1318925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  Expr *Fn = TheCall->getCallee();
1319925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  if (TheCall->getNumArgs() > 2) {
13202c21a073525cdfa68e4439b7af551385dc2796abChris Lattner    Diag(TheCall->getArg(2)->getLocStart(),
1321fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner         diag::err_typecheck_call_too_many_args)
1322ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher      << 0 /*function call*/ << 2 << TheCall->getNumArgs()
1323ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher      << Fn->getSourceRange()
13241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump      << SourceRange(TheCall->getArg(2)->getLocStart(),
1325fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                     (*(TheCall->arg_end()-1))->getLocEnd());
132630ce344307f8a8b00054021307015571f83c7364Chris Lattner    return true;
132730ce344307f8a8b00054021307015571f83c7364Chris Lattner  }
132856f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman
132956f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman  if (TheCall->getNumArgs() < 2) {
1330d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher    return Diag(TheCall->getLocEnd(),
1331d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      diag::err_typecheck_call_too_few_args_at_least)
1332d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      << 0 /*function call*/ << 2 << TheCall->getNumArgs();
133356f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman  }
133456f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman
13355f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  // Type-check the first argument normally.
13365f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  if (checkBuiltinArgument(*this, TheCall, 0))
13375f8d604246976a93a73549b07bbc8ee0b2061b50John McCall    return true;
13385f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
1339c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner  // Determine whether the current function is variadic or not.
13409ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor  BlockScopeInfo *CurBlock = getCurBlock();
1341c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner  bool isVariadic;
1342cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff  if (CurBlock)
1343c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall    isVariadic = CurBlock->TheDecl->isVariadic();
13449498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek  else if (FunctionDecl *FD = getCurFunctionDecl())
13459498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek    isVariadic = FD->isVariadic();
13469498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek  else
134753d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis    isVariadic = getCurMethodDecl()->isVariadic();
13481eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1349c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner  if (!isVariadic) {
135030ce344307f8a8b00054021307015571f83c7364Chris Lattner    Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
135130ce344307f8a8b00054021307015571f83c7364Chris Lattner    return true;
135230ce344307f8a8b00054021307015571f83c7364Chris Lattner  }
13531eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
135430ce344307f8a8b00054021307015571f83c7364Chris Lattner  // Verify that the second argument to the builtin is the last argument of the
135530ce344307f8a8b00054021307015571f83c7364Chris Lattner  // current function or method.
135630ce344307f8a8b00054021307015571f83c7364Chris Lattner  bool SecondArgIsLastNamedArgument = false;
1357e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson  const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts();
13581eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
135988cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson  if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
136088cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson    if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
136130ce344307f8a8b00054021307015571f83c7364Chris Lattner      // FIXME: This isn't correct for methods (results in bogus warning).
136230ce344307f8a8b00054021307015571f83c7364Chris Lattner      // Get the last formal in the current function.
136388cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson      const ParmVarDecl *LastArg;
1364cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff      if (CurBlock)
1365cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff        LastArg = *(CurBlock->TheDecl->param_end()-1);
1366cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff      else if (FunctionDecl *FD = getCurFunctionDecl())
1367371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner        LastArg = *(FD->param_end()-1);
136830ce344307f8a8b00054021307015571f83c7364Chris Lattner      else
136953d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis        LastArg = *(getCurMethodDecl()->param_end()-1);
137030ce344307f8a8b00054021307015571f83c7364Chris Lattner      SecondArgIsLastNamedArgument = PV == LastArg;
137130ce344307f8a8b00054021307015571f83c7364Chris Lattner    }
137230ce344307f8a8b00054021307015571f83c7364Chris Lattner  }
13731eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
137430ce344307f8a8b00054021307015571f83c7364Chris Lattner  if (!SecondArgIsLastNamedArgument)
13751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump    Diag(TheCall->getArg(1)->getLocStart(),
137630ce344307f8a8b00054021307015571f83c7364Chris Lattner         diag::warn_second_parameter_of_va_start_not_last_named_argument);
137730ce344307f8a8b00054021307015571f83c7364Chris Lattner  return false;
13786cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman}
137930ce344307f8a8b00054021307015571f83c7364Chris Lattner
13801b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and
13811b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends.  This is declared to take (...), so we have to check everything.
1382925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) {
1383925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  if (TheCall->getNumArgs() < 2)
13842c21a073525cdfa68e4439b7af551385dc2796abChris Lattner    return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
1385d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      << 0 << 2 << TheCall->getNumArgs()/*function call*/;
1386925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  if (TheCall->getNumArgs() > 2)
13871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump    return Diag(TheCall->getArg(2)->getLocStart(),
1388fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                diag::err_typecheck_call_too_many_args)
1389ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher      << 0 /*function call*/ << 2 << TheCall->getNumArgs()
1390fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner      << SourceRange(TheCall->getArg(2)->getLocStart(),
1391fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                     (*(TheCall->arg_end()-1))->getLocEnd());
13921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1393429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  ExprResult OrigArg0 = TheCall->getArg(0);
1394429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  ExprResult OrigArg1 = TheCall->getArg(1);
1395cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor
13961b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  // Do standard promotions between the two arguments, returning their common
13971b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  // type.
1398925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false);
1399429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  if (OrigArg0.isInvalid() || OrigArg1.isInvalid())
1400429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley    return true;
1401403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar
1402403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar  // Make sure any conversions are pushed back into the call; this is
1403403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar  // type safe since unordered compare builtins are declared as "_Bool
1404403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar  // foo(...)".
1405429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  TheCall->setArg(0, OrigArg0.get());
1406429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  TheCall->setArg(1, OrigArg1.get());
14071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1408429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent())
1409cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor    return false;
1410cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor
14111b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  // If the common type isn't a real floating type, then the arguments were
14121b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  // invalid for this operation.
1413860a319e62b0e256817a458396d191aa91c0787aEli Friedman  if (Res.isNull() || !Res->isRealFloatingType())
1414429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley    return Diag(OrigArg0.get()->getLocStart(),
1415fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                diag::err_typecheck_call_invalid_ordered_compare)
1416429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley      << OrigArg0.get()->getType() << OrigArg1.get()->getType()
1417429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley      << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd());
14181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
14191b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  return false;
14201b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner}
14211b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner
1422e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like
1423e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends.  This is declared to take (...), so we have
14243b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point
14253b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value.
14263b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) {
14273b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer  if (TheCall->getNumArgs() < NumArgs)
14289ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman    return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
1429d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      << 0 << NumArgs << TheCall->getNumArgs()/*function call*/;
14303b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer  if (TheCall->getNumArgs() > NumArgs)
14313b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer    return Diag(TheCall->getArg(NumArgs)->getLocStart(),
14329ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman                diag::err_typecheck_call_too_many_args)
1433ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher      << 0 /*function call*/ << NumArgs << TheCall->getNumArgs()
14343b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer      << SourceRange(TheCall->getArg(NumArgs)->getLocStart(),
14359ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman                     (*(TheCall->arg_end()-1))->getLocEnd());
14369ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman
14373b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer  Expr *OrigArg = TheCall->getArg(NumArgs-1);
14381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
14399ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  if (OrigArg->isTypeDependent())
14409ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman    return false;
14419ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman
144281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner  // This operation requires a non-_Complex floating-point number.
14439ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  if (!OrigArg->getType()->isRealFloatingType())
14441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump    return Diag(OrigArg->getLocStart(),
14459ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman                diag::err_typecheck_call_invalid_unary_fp)
14469ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman      << OrigArg->getType() << OrigArg->getSourceRange();
14471eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
144881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner  // If this is an implicit conversion from float -> double, remove it.
144981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner  if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) {
145081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner    Expr *CastArg = Cast->getSubExpr();
145181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner    if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) {
145281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner      assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) &&
145381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner             "promotion from float to double is the only expected cast here");
145481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner      Cast->setSubExpr(0);
145581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner      TheCall->setArg(NumArgs-1, CastArg);
145681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner    }
145781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner  }
145881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner
14599ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  return false;
14609ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman}
14619ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman
1462d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector.
1463d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything.
146460d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) {
146537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  if (TheCall->getNumArgs() < 2)
14660eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    return ExprError(Diag(TheCall->getLocEnd(),
1467d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher                          diag::err_typecheck_call_too_few_args_at_least)
146837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman      << 0 /*function call*/ << 2 << TheCall->getNumArgs()
1469d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      << TheCall->getSourceRange());
1470d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
147137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  // Determine which of the following types of shufflevector we're checking:
147237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  // 1) unary, vector mask: (lhs, mask)
147337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  // 2) binary, vector mask: (lhs, rhs, mask)
147437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  // 3) binary, scalar mask: (lhs, rhs, index, ..., index)
147537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  QualType resType = TheCall->getArg(0)->getType();
147637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  unsigned numElements = 0;
147737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman
1478cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor  if (!TheCall->getArg(0)->isTypeDependent() &&
1479cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      !TheCall->getArg(1)->isTypeDependent()) {
148037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    QualType LHSType = TheCall->getArg(0)->getType();
148137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    QualType RHSType = TheCall->getArg(1)->getType();
148237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman
148337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    if (!LHSType->isVectorType() || !RHSType->isVectorType()) {
1484cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector)
14851eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump        << SourceRange(TheCall->getArg(0)->getLocStart(),
1486cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor                       TheCall->getArg(1)->getLocEnd());
1487cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      return ExprError();
1488cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor    }
148937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman
149037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    numElements = LHSType->getAs<VectorType>()->getNumElements();
149137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    unsigned numResElements = TheCall->getNumArgs() - 2;
149237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman
149337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    // Check to see if we have a call with 2 vector arguments, the unary shuffle
149437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    // with mask.  If so, verify that RHS is an integer vector type with the
149537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    // same number of elts as lhs.
149637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    if (TheCall->getNumArgs() == 2) {
1497f60946222721d9ba3c059563935c17b84703187aDouglas Gregor      if (!RHSType->hasIntegerRepresentation() ||
149837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman          RHSType->getAs<VectorType>()->getNumElements() != numElements)
149937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman        Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
150037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman          << SourceRange(TheCall->getArg(1)->getLocStart(),
150137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman                         TheCall->getArg(1)->getLocEnd());
150237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman      numResElements = numElements;
150337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    }
150437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) {
1505cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
15061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump        << SourceRange(TheCall->getArg(0)->getLocStart(),
1507cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor                       TheCall->getArg(1)->getLocEnd());
1508cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      return ExprError();
150937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    } else if (numElements != numResElements) {
151037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman      QualType eltType = LHSType->getAs<VectorType>()->getElementType();
1511788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner      resType = Context.getVectorType(eltType, numResElements,
1512e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson                                      VectorType::GenericVector);
1513cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor    }
1514d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  }
1515d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
1516d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  for (unsigned i = 2; i < TheCall->getNumArgs(); i++) {
1517cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor    if (TheCall->getArg(i)->isTypeDependent() ||
1518cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor        TheCall->getArg(i)->isValueDependent())
1519cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      continue;
1520cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor
152137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    llvm::APSInt Result(32);
152237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context))
152337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman      return ExprError(Diag(TheCall->getLocStart(),
152437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman                  diag::err_shufflevector_nonconstant_argument)
152537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman                << TheCall->getArg(i)->getSourceRange());
15260eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl
1527d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner    if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2)
15280eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError(Diag(TheCall->getLocStart(),
1529fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                  diag::err_shufflevector_argument_too_large)
15300eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl               << TheCall->getArg(i)->getSourceRange());
1531d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  }
1532d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
15335f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner  SmallVector<Expr*, 32> exprs;
1534d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
1535d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner  for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) {
1536d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman    exprs.push_back(TheCall->getArg(i));
1537d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman    TheCall->setArg(i, 0);
1538d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  }
1539d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
15403b6bef9a213249c6ab6d67c07b1ac6380961be3eBenjamin Kramer  return Owned(new (Context) ShuffleVectorExpr(Context, exprs, resType,
15418189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek                                            TheCall->getCallee()->getLocStart(),
15428189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek                                            TheCall->getRParenLoc()));
1543d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman}
154430ce344307f8a8b00054021307015571f83c7364Chris Lattner
15454493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch.
15464493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two
15474493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args.
15484493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) {
1549fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner  unsigned NumArgs = TheCall->getNumArgs();
15504493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar
1551fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner  if (NumArgs > 3)
1552ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher    return Diag(TheCall->getLocEnd(),
1553ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher             diag::err_typecheck_call_too_many_args_at_most)
1554ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher             << 0 /*function call*/ << 3 << NumArgs
1555ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher             << TheCall->getSourceRange();
15564493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar
15574493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar  // Argument 0 is checked for us and the remaining arguments must be
15584493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar  // constant integers.
1559fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner  for (unsigned i = 1; i != NumArgs; ++i) {
15604493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    Expr *Arg = TheCall->getArg(i);
1561592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
1562592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor    // We can't check the value of a dependent argument.
1563592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor    if (Arg->isTypeDependent() || Arg->isValueDependent())
1564592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor      continue;
1565592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
15669aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman    llvm::APSInt Result;
1567691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher    if (SemaBuiltinConstantArg(TheCall, i, Result))
1568691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher      return true;
15691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
15704493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    // FIXME: gcc issues a warning and rewrites these to 0. These
15714493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    // seems especially odd for the third argument since the default
15724493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    // is 3.
1573fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner    if (i == 1) {
15749aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman      if (Result.getLimitedValue() > 1)
1575fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner        return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
157621fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner             << "0" << "1" << Arg->getSourceRange();
15774493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    } else {
15789aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman      if (Result.getLimitedValue() > 3)
1579fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner        return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
158021fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner            << "0" << "3" << Arg->getSourceRange();
15814493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    }
15824493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar  }
15834493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar
1584fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner  return false;
15854493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar}
15864493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar
1587691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr
1588691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression.
1589691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum,
1590691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher                                  llvm::APSInt &Result) {
1591691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  Expr *Arg = TheCall->getArg(ArgNum);
1592691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
1593691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
1594691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher
1595691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (Arg->isTypeDependent() || Arg->isValueDependent()) return false;
1596691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher
1597691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (!Arg->isIntegerConstantExpr(Result, Context))
1598691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher    return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type)
15995e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher                << FDecl->getDeclName() <<  Arg->getSourceRange();
1600691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher
160121fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner  return false;
160221fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner}
160321fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner
1604d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr,
1605d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined
1606d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3).
1607fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner// For compatibility check 0-3, llvm only handles 0 and 2.
1608d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) {
1609691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  llvm::APSInt Result;
1610592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
1611592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor  // We can't check the value of a dependent argument.
1612592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor  if (TheCall->getArg(1)->isTypeDependent() ||
1613592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor      TheCall->getArg(1)->isValueDependent())
1614592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor    return false;
1615592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
1616691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  // Check constant-ness first.
1617691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (SemaBuiltinConstantArg(TheCall, 1, Result))
1618691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher    return true;
1619d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar
1620691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  Expr *Arg = TheCall->getArg(1);
1621d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar  if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) {
1622fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner    return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
1623fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner             << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
1624d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar  }
1625d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar
1626d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar  return false;
1627d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar}
1628d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar
1629586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val).
1630d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1.
1631d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) {
1632d875fed28578835de89cd407e9db4be788596d7cEli Friedman  Expr *Arg = TheCall->getArg(1);
1633691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  llvm::APSInt Result;
1634cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor
1635691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  // TODO: This is less than ideal. Overload this to take a value.
1636691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (SemaBuiltinConstantArg(TheCall, 1, Result))
1637691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher    return true;
1638691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher
1639691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (Result != 1)
1640d875fed28578835de89cd407e9db4be788596d7cEli Friedman    return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val)
1641d875fed28578835de89cd407e9db4be788596d7cEli Friedman             << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
1642d875fed28578835de89cd407e9db4be788596d7cEli Friedman
1643d875fed28578835de89cd407e9db4be788596d7cEli Friedman  return false;
1644d875fed28578835de89cd407e9db4be788596d7cEli Friedman}
1645d875fed28578835de89cd407e9db4be788596d7cEli Friedman
1646831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determine if an expression is a string literal or constant string.
1647831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// If this function returns false on the arguments to a function expecting a
1648831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// format string, we will usually need to emit a warning.
1649831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// True string literals are then checked by CheckFormatString.
1650831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithSema::StringLiteralCheckType
16511c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri GribenkoSema::checkFormatStringExpr(const Expr *E, ArrayRef<const Expr *> Args,
16521c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko                            bool HasVAListArg,
1653831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                            unsigned format_idx, unsigned firstDataArg,
1654ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                            FormatStringType Type, VariadicCallType CallType,
1655ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                            bool inFunctionCall) {
16564fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain:
1657cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor  if (E->isTypeDependent() || E->isValueDependent())
1658831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
1659d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
166034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  E = E->IgnoreParenCasts();
1661f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne
1662a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie  if (E->isNullPointerConstant(Context, Expr::NPC_ValueDependentIsNotNull))
1663a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie    // Technically -Wformat-nonliteral does not warn about this case.
1664a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie    // The behavior of printf and friends in this case is implementation
1665a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie    // dependent.  Ideally if the format string cannot be null then
1666a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie    // it should have a 'nonnull' attribute in the function prototype.
1667831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_CheckedLiteral;
1668a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie
1669d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  switch (E->getStmtClass()) {
167056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall  case Stmt::BinaryConditionalOperatorClass:
1671d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  case Stmt::ConditionalOperatorClass: {
1672831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    // The expression is a literal if both sub-expressions were, and it was
1673831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    // completely checked only if both sub-expressions were checked.
1674831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    const AbstractConditionalOperator *C =
1675831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        cast<AbstractConditionalOperator>(E);
1676831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    StringLiteralCheckType Left =
16771c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko        checkFormatStringExpr(C->getTrueExpr(), Args,
1678831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                              HasVAListArg, format_idx, firstDataArg,
1679ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                              Type, CallType, inFunctionCall);
1680831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    if (Left == SLCT_NotALiteral)
1681831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      return SLCT_NotALiteral;
1682831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    StringLiteralCheckType Right =
16831c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko        checkFormatStringExpr(C->getFalseExpr(), Args,
1684831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                              HasVAListArg, format_idx, firstDataArg,
1685ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                              Type, CallType, inFunctionCall);
1686831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return Left < Right ? Left : Right;
1687d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  }
1688d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
1689d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  case Stmt::ImplicitCastExprClass: {
16904fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek    E = cast<ImplicitCastExpr>(E)->getSubExpr();
16914fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek    goto tryAgain;
1692d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  }
1693d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
169456ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall  case Stmt::OpaqueValueExprClass:
169556ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall    if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) {
169656ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall      E = src;
169756ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall      goto tryAgain;
169856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall    }
1699831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
170056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall
1701b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek  case Stmt::PredefinedExprClass:
1702b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek    // While __func__, etc., are technically not string literals, they
1703b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek    // cannot contain format specifiers and thus are not a security
1704b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek    // liability.
1705831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_UncheckedLiteral;
1706b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek
1707082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  case Stmt::DeclRefExprClass: {
1708082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    const DeclRefExpr *DR = cast<DeclRefExpr>(E);
17091eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1710082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    // As an exception, do not flag errors for variables binding to
1711082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    // const string literals.
1712082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
1713082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      bool isConstant = false;
1714082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      QualType T = DR->getType();
1715082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek
1716082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      if (const ArrayType *AT = Context.getAsArrayType(T)) {
1717082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek        isConstant = AT->getElementType().isConstant(Context);
1718ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump      } else if (const PointerType *PT = T->getAs<PointerType>()) {
17191eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump        isConstant = T.isConstant(Context) &&
1720082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek                     PT->getPointeeType().isConstant(Context);
1721e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas      } else if (T->isObjCObjectPointerType()) {
1722e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas        // In ObjC, there is usually no "const ObjectPointer" type,
1723e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas        // so don't check if the pointee type is constant.
1724e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas        isConstant = T.isConstant(Context);
1725082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      }
17261eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1727082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      if (isConstant) {
1728e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay        if (const Expr *Init = VD->getAnyInitializer()) {
1729e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay          // Look through initializers like const char c[] = { "foo" }
1730e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay          if (const InitListExpr *InitList = dyn_cast<InitListExpr>(Init)) {
1731e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay            if (InitList->isStringLiteralInit())
1732e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay              Init = InitList->getInit(0)->IgnoreParenImpCasts();
1733e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay          }
17341c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko          return checkFormatStringExpr(Init, Args,
1735831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                       HasVAListArg, format_idx,
1736ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                       firstDataArg, Type, CallType,
1737831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                       /*inFunctionCall*/false);
1738e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay        }
1739082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      }
17401eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1741d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // For vprintf* functions (i.e., HasVAListArg==true), we add a
1742d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // special check to see if the format string is a function parameter
1743d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // of the function calling the printf function.  If the function
1744d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // has an attribute indicating it is a printf-like function, then we
1745d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // should suppress warnings concerning non-literals being used in a call
1746d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // to a vprintf function.  For example:
1747d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //
1748d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // void
1749d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){
1750d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //      va_list ap;
1751d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //      va_start(ap, fmt);
1752d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //      vprintf(fmt, ap);  // Do NOT emit a warning about "fmt".
1753d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //      ...
1754d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //
1755f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas      if (HasVAListArg) {
1756f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas        if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(VD)) {
1757f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas          if (const NamedDecl *ND = dyn_cast<NamedDecl>(PV->getDeclContext())) {
1758f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas            int PVIndex = PV->getFunctionScopeIndex() + 1;
1759f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas            for (specific_attr_iterator<FormatAttr>
1760f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                 i = ND->specific_attr_begin<FormatAttr>(),
1761f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                 e = ND->specific_attr_end<FormatAttr>(); i != e ; ++i) {
1762f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              FormatAttr *PVFormat = *i;
1763f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              // adjust for implicit parameter
1764f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND))
1765f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                if (MD->isInstance())
1766f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                  ++PVIndex;
1767f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              // We also check if the formats are compatible.
1768f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              // We can't pass a 'scanf' string to a 'printf' function.
1769f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              if (PVIndex == PVFormat->getFormatIdx() &&
1770f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                  Type == GetFormatStringType(PVFormat))
1771831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                return SLCT_UncheckedLiteral;
1772f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas            }
1773f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas          }
1774f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas        }
1775f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas      }
1776082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    }
17771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1778831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
1779082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  }
1780d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
178152aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas  case Stmt::CallExprClass:
178252aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas  case Stmt::CXXMemberCallExprClass: {
17838f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson    const CallExpr *CE = cast<CallExpr>(E);
178452aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas    if (const NamedDecl *ND = dyn_cast_or_null<NamedDecl>(CE->getCalleeDecl())) {
178552aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas      if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) {
178652aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas        unsigned ArgIndex = FA->getFormatIdx();
178752aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas        if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND))
178852aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas          if (MD->isInstance())
178952aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas            --ArgIndex;
179052aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas        const Expr *Arg = CE->getArg(ArgIndex - 1);
179152aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas
17921c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko        return checkFormatStringExpr(Arg, Args,
1793831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                     HasVAListArg, format_idx, firstDataArg,
1794ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                     Type, CallType, inFunctionCall);
179550687314f87b67073c202fe46d84d12fb55e25cfJordan Rose      } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(ND)) {
179650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose        unsigned BuiltinID = FD->getBuiltinID();
179750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose        if (BuiltinID == Builtin::BI__builtin___CFStringMakeConstantString ||
179850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose            BuiltinID == Builtin::BI__builtin___NSStringMakeConstantString) {
179950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose          const Expr *Arg = CE->getArg(0);
18001c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko          return checkFormatStringExpr(Arg, Args,
1801831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                       HasVAListArg, format_idx,
1802ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                       firstDataArg, Type, CallType,
1803ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                       inFunctionCall);
180450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose        }
18058f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson      }
18068f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson    }
18071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1808831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
18098f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson  }
1810082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  case Stmt::ObjCStringLiteralClass:
1811082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  case Stmt::StringLiteralClass: {
1812082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    const StringLiteral *StrE = NULL;
18131eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1814082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E))
1815d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek      StrE = ObjCFExpr->getString();
1816d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek    else
1817082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      StrE = cast<StringLiteral>(E);
18181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1819d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek    if (StrE) {
18201c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko      CheckFormatString(StrE, E, Args, HasVAListArg, format_idx,
1821ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                        firstDataArg, Type, inFunctionCall, CallType);
1822831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      return SLCT_CheckedLiteral;
1823d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek    }
18241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1825831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
1826d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  }
18271eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1828082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  default:
1829831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
1830d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  }
1831d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek}
1832d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
1833e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid
18341eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull,
1835909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky                            const Expr * const *ExprArgs,
1836909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky                            SourceLocation CallSiteLoc) {
1837cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt  for (NonNullAttr::args_iterator i = NonNull->args_begin(),
1838cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt                                  e = NonNull->args_end();
1839e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian       i != e; ++i) {
1840909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky    const Expr *ArgExpr = ExprArgs[*i];
18413edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky
18423edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky    // As a special case, transparent unions initialized with zero are
18433edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky    // considered null for the purposes of the nonnull attribute.
18443edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky    if (const RecordType *UT = ArgExpr->getType()->getAsUnionType()) {
18453edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky      if (UT->getDecl()->hasAttr<TransparentUnionAttr>())
18463edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky        if (const CompoundLiteralExpr *CLE =
18473edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky            dyn_cast<CompoundLiteralExpr>(ArgExpr))
18483edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky          if (const InitListExpr *ILE =
18493edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky              dyn_cast<InitListExpr>(CLE->getInitializer()))
18503edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky            ArgExpr = ILE->getInit(0);
18513edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky    }
18523edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky
18533edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky    bool Result;
18543edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky    if (ArgExpr->EvaluateAsBooleanCondition(Result, Context) && !Result)
1855909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky      Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange();
1856e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian  }
1857e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian}
1858d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
185934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel DupasSema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) {
186034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  return llvm::StringSwitch<FormatStringType>(Format->getType())
186134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Case("scanf", FST_Scanf)
186234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Cases("printf", "printf0", FST_Printf)
186334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Cases("NSString", "CFString", FST_NSString)
186434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Case("strftime", FST_Strftime)
186534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Case("strfmon", FST_Strfmon)
186634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf)
186734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Default(FST_Unknown);
186834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas}
186934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas
1870ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose/// CheckFormatArguments - Check calls to printf and scanf (and similar
1871826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings.
1872831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true if a format string has been fully checked.
18731c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkobool Sema::CheckFormatArguments(const FormatAttr *Format,
18741c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko                                ArrayRef<const Expr *> Args,
18751c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko                                bool IsCXXMember,
1876ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                VariadicCallType CallType,
187729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                                SourceLocation Loc, SourceRange Range) {
1878831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  FormatStringInfo FSI;
1879831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (getFormatStringInfo(Format, IsCXXMember, &FSI))
18801c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko    return CheckFormatArguments(Args, FSI.HasVAListArg, FSI.FormatIdx,
1881831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                FSI.FirstDataArg, GetFormatStringType(Format),
1882ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                CallType, Loc, Range);
1883831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return false;
188429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas}
18854a2614e94672c47395abcde60518776fbebec589Sebastian Redl
18861c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkobool Sema::CheckFormatArguments(ArrayRef<const Expr *> Args,
188734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas                                bool HasVAListArg, unsigned format_idx,
188834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas                                unsigned firstDataArg, FormatStringType Type,
1889ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                VariadicCallType CallType,
189034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas                                SourceLocation Loc, SourceRange Range) {
1891826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  // CHECK: printf/scanf-like function is called with no format string.
18921c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko  if (format_idx >= Args.size()) {
189329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas    Diag(Loc, diag::warn_missing_format_string) << Range;
1894831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return false;
189571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  }
18961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
189729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts();
18981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
189959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner  // CHECK: format string is not a string literal.
19001eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  //
190171895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // Dynamically generated format strings are difficult to
190271895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // automatically vet at compile time.  Requiring that format strings
190371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // are string literals: (1) permits the checking of format strings by
190471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // the compiler and thereby (2) can practically remove the source of
190571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // many format string exploits.
19067ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek
19071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  // Format string can be either ObjC string (e.g. @"%d") or
19087ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek  // C string (e.g. "%d")
19091eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  // ObjC string uses the same format specifiers as C string, so we can use
19107ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek  // the same format string checking logic for both ObjC and C strings.
1911831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  StringLiteralCheckType CT =
19121c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko      checkFormatStringExpr(OrigFormatExpr, Args, HasVAListArg,
1913ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                            format_idx, firstDataArg, Type, CallType);
1914831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (CT != SLCT_NotALiteral)
1915831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    // Literal format string found, check done!
1916831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return CT == SLCT_CheckedLiteral;
19171cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner
19182837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas  // Strftime is particular as it always uses a single 'time' argument,
19192837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas  // so it is safe to pass a non-literal string.
19202837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas  if (Type == FST_Strftime)
1921831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return false;
19222837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas
1923ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas  // Do not emit diag when the string param is a macro expansion and the
1924ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas  // format is either NSString or CFString. This is a hack to prevent
1925ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas  // diag when using the NSLocalizedString and CFCopyLocalizedString macros
1926ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas  // which are usually used in place of NS and CF string literals.
1927dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas  if (Type == FST_NSString &&
1928dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas      SourceMgr.isInSystemMacro(Args[format_idx]->getLocStart()))
1929831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return false;
1930ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas
1931655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner  // If there are no arguments specified, warn with -Wformat-security, otherwise
1932655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner  // warn only with -Wformat-nonliteral.
19331c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko  if (Args.size() == format_idx+1)
193429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas    Diag(Args[format_idx]->getLocStart(),
1935826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek         diag::warn_format_nonliteral_noargs)
1936655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner      << OrigFormatExpr->getSourceRange();
1937655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner  else
193829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas    Diag(Args[format_idx]->getLocStart(),
1939826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek         diag::warn_format_nonliteral)
1940655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner           << OrigFormatExpr->getSourceRange();
1941831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return false;
1942d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek}
1943d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
1944e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace {
1945826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler {
1946826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected:
1947e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  Sema &S;
1948e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  const StringLiteral *FExpr;
1949e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  const Expr *OrigFormatExpr;
19506ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek  const unsigned FirstDataArg;
1951e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  const unsigned NumDataArgs;
1952e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  const char *Beg; // Start of format string.
19530d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  const bool HasVAListArg;
19541c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko  ArrayRef<const Expr *> Args;
19550d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  unsigned FormatIdx;
19567f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  llvm::BitVector CoveredArgs;
1957efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  bool usesPositionalArgs;
1958efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  bool atFirstArg;
195955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  bool inFunctionCall;
1960ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose  Sema::VariadicCallType CallType;
19614e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic:
1962826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  CheckFormatHandler(Sema &s, const StringLiteral *fexpr,
19636ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek                     const Expr *origFormatExpr, unsigned firstDataArg,
196450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                     unsigned numDataArgs, const char *beg, bool hasVAListArg,
19651c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko                     ArrayRef<const Expr *> Args,
1966ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                     unsigned formatIdx, bool inFunctionCall,
1967ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                     Sema::VariadicCallType callType)
1968e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek    : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr),
196950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose      FirstDataArg(firstDataArg), NumDataArgs(numDataArgs),
197050687314f87b67073c202fe46d84d12fb55e25cfJordan Rose      Beg(beg), HasVAListArg(hasVAListArg),
19711c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko      Args(Args), FormatIdx(formatIdx),
197255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      usesPositionalArgs(false), atFirstArg(true),
1973ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose      inFunctionCall(inFunctionCall), CallType(callType) {
19747f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek        CoveredArgs.resize(numDataArgs);
19757f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek        CoveredArgs.reset();
19767f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      }
19774e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
197807d161f38e708a91486bf1c031d525faebbb249dTed Kremenek  void DoneProcessing();
19794e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
1980826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  void HandleIncompleteSpecifier(const char *startSpecifier,
1981826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                 unsigned specifierLen);
198276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
1983bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  void HandleInvalidLengthModifier(
1984bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose      const analyze_format_string::FormatSpecifier &FS,
1985bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose      const analyze_format_string::ConversionSpecifier &CS,
19868be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose      const char *startSpecifier, unsigned specifierLen, unsigned DiagID);
1987bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
198876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg  void HandleNonStandardLengthModifier(
19898be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose      const analyze_format_string::FormatSpecifier &FS,
199076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg      const char *startSpecifier, unsigned specifierLen);
199176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
199276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg  void HandleNonStandardConversionSpecifier(
199376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg      const analyze_format_string::ConversionSpecifier &CS,
199476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg      const char *startSpecifier, unsigned specifierLen);
199576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
1996f85626453123f9691bcef13cff963f556e209c27Hans Wennborg  virtual void HandlePosition(const char *startPos, unsigned posLen);
1997f85626453123f9691bcef13cff963f556e209c27Hans Wennborg
1998efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  virtual void HandleInvalidPosition(const char *startSpecifier,
1999efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek                                     unsigned specifierLen,
2000826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                     analyze_format_string::PositionContext p);
2001efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
2002efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  virtual void HandleZeroPosition(const char *startPos, unsigned posLen);
2003efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
2004e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  void HandleNullChar(const char *nullCharacter);
20054e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
200655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  template <typename Range>
200755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  static void EmitFormatDiagnostic(Sema &S, bool inFunctionCall,
200855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                   const Expr *ArgumentExpr,
200955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                   PartialDiagnostic PDiag,
201055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                   SourceLocation StringLoc,
201155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                   bool IsStringLocation, Range StringRange,
2012ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                            ArrayRef<FixItHint> Fixit = ArrayRef<FixItHint>());
201355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
2014826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected:
2015c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc,
2016c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        const char *startSpec,
2017c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        unsigned specifierLen,
2018c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        const char *csStart, unsigned csLen);
201955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
202055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  void HandlePositionalNonpositionalArgs(SourceLocation Loc,
202155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                         const char *startSpec,
202255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                         unsigned specifierLen);
2023c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2024f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek  SourceRange getFormatStringRange();
2025826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  CharSourceRange getSpecifierRange(const char *startSpecifier,
2026826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                    unsigned specifierLen);
2027e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  SourceLocation getLocationOfByte(const char *x);
20284e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
20290d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  const Expr *getDataArg(unsigned i) const;
2030666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek
2031666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS,
2032666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek                    const analyze_format_string::ConversionSpecifier &CS,
2033666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek                    const char *startSpecifier, unsigned specifierLen,
2034666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek                    unsigned argIndex);
203555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
203655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  template <typename Range>
203755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc,
203855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                            bool IsStringLocation, Range StringRange,
2039ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                            ArrayRef<FixItHint> Fixit = ArrayRef<FixItHint>());
204055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
204155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  void CheckPositionalAndNonpositionalArgs(
204255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      const analyze_format_string::FormatSpecifier *FS);
2043e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek};
2044e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}
2045e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2046826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() {
2047e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  return OrigFormatExpr->getSourceRange();
2048e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}
2049e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2050826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler::
2051826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) {
205245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  SourceLocation Start = getLocationOfByte(startSpecifier);
205345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  SourceLocation End   = getLocationOfByte(startSpecifier + specifierLen - 1);
205445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care
205545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  // Advance the end SourceLocation by one due to half-open ranges.
2056a64ccefdf0ea4e03ec88805d71b0af74950c7472Argyrios Kyrtzidis  End = End.getLocWithOffset(1);
205745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care
205845f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  return CharSourceRange::getCharRange(Start, End);
2059f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek}
2060f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek
2061826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) {
20624e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek  return S.getLocationOfStringLiteralByte(FExpr, x - Beg);
2063e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}
2064e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2065826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier,
2066826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                                   unsigned specifierLen){
206755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier),
206855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(startSpecifier),
206955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       /*IsStringLocation*/true,
207055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpecifier, specifierLen));
2071808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek}
2072808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek
2073bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rosevoid CheckFormatHandler::HandleInvalidLengthModifier(
2074bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose    const analyze_format_string::FormatSpecifier &FS,
2075bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose    const analyze_format_string::ConversionSpecifier &CS,
20768be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    const char *startSpecifier, unsigned specifierLen, unsigned DiagID) {
2077bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  using namespace analyze_format_string;
2078bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
2079bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  const LengthModifier &LM = FS.getLengthModifier();
2080bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength());
2081bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
2082bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  // See if we know how to fix this length modifier.
2083dc84cd5efdd3430efb22546b4ac656aa0540b210David Blaikie  Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier();
2084bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  if (FixedLM) {
20858be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(),
2086bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose                         getLocationOfByte(LM.getStart()),
2087bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose                         /*IsStringLocation*/true,
2088bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose                         getSpecifierRange(startSpecifier, specifierLen));
2089bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
2090bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose    S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier)
2091bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose      << FixedLM->toString()
2092bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose      << FixItHint::CreateReplacement(LMRange, FixedLM->toString());
2093bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
2094bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  } else {
20958be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    FixItHint Hint;
20968be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    if (DiagID == diag::warn_format_nonsensical_length)
20978be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose      Hint = FixItHint::CreateRemoval(LMRange);
20988be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose
20998be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(),
2100bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose                         getLocationOfByte(LM.getStart()),
2101bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose                         /*IsStringLocation*/true,
2102bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose                         getSpecifierRange(startSpecifier, specifierLen),
21038be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         Hint);
2104bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  }
2105bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose}
2106bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
210776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardLengthModifier(
21088be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    const analyze_format_string::FormatSpecifier &FS,
210976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    const char *startSpecifier, unsigned specifierLen) {
21108be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  using namespace analyze_format_string;
21118be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose
21128be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  const LengthModifier &LM = FS.getLengthModifier();
21138be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength());
21148be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose
21158be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  // See if we know how to fix this length modifier.
2116dc84cd5efdd3430efb22546b4ac656aa0540b210David Blaikie  Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier();
21178be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  if (FixedLM) {
21188be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
21198be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                           << LM.toString() << 0,
21208be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         getLocationOfByte(LM.getStart()),
21218be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         /*IsStringLocation*/true,
21228be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         getSpecifierRange(startSpecifier, specifierLen));
21238be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose
21248be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier)
21258be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose      << FixedLM->toString()
21268be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose      << FixItHint::CreateReplacement(LMRange, FixedLM->toString());
21278be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose
21288be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  } else {
21298be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
21308be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                           << LM.toString() << 0,
21318be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         getLocationOfByte(LM.getStart()),
21328be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         /*IsStringLocation*/true,
21338be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         getSpecifierRange(startSpecifier, specifierLen));
21348be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  }
213576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg}
213676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
213776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardConversionSpecifier(
213876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    const analyze_format_string::ConversionSpecifier &CS,
213976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    const char *startSpecifier, unsigned specifierLen) {
2140670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose  using namespace analyze_format_string;
2141670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose
2142670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose  // See if we know how to fix this conversion specifier.
2143dc84cd5efdd3430efb22546b4ac656aa0540b210David Blaikie  Optional<ConversionSpecifier> FixedCS = CS.getStandardSpecifier();
2144670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose  if (FixedCS) {
2145670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose    EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
2146670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose                          << CS.toString() << /*conversion specifier*/1,
2147670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose                         getLocationOfByte(CS.getStart()),
2148670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose                         /*IsStringLocation*/true,
2149670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose                         getSpecifierRange(startSpecifier, specifierLen));
2150670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose
2151670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose    CharSourceRange CSRange = getSpecifierRange(CS.getStart(), CS.getLength());
2152670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose    S.Diag(getLocationOfByte(CS.getStart()), diag::note_format_fix_specifier)
2153670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose      << FixedCS->toString()
2154670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose      << FixItHint::CreateReplacement(CSRange, FixedCS->toString());
2155670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose  } else {
2156670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose    EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
2157670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose                          << CS.toString() << /*conversion specifier*/1,
2158670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose                         getLocationOfByte(CS.getStart()),
2159670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose                         /*IsStringLocation*/true,
2160670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose                         getSpecifierRange(startSpecifier, specifierLen));
2161670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose  }
216276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg}
216376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
2164f85626453123f9691bcef13cff963f556e209c27Hans Wennborgvoid CheckFormatHandler::HandlePosition(const char *startPos,
2165f85626453123f9691bcef13cff963f556e209c27Hans Wennborg                                        unsigned posLen) {
2166f85626453123f9691bcef13cff963f556e209c27Hans Wennborg  EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_positional_arg),
2167f85626453123f9691bcef13cff963f556e209c27Hans Wennborg                               getLocationOfByte(startPos),
2168f85626453123f9691bcef13cff963f556e209c27Hans Wennborg                               /*IsStringLocation*/true,
2169f85626453123f9691bcef13cff963f556e209c27Hans Wennborg                               getSpecifierRange(startPos, posLen));
2170f85626453123f9691bcef13cff963f556e209c27Hans Wennborg}
2171f85626453123f9691bcef13cff963f556e209c27Hans Wennborg
2172efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid
2173826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen,
2174826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                     analyze_format_string::PositionContext p) {
217555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier)
217655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << (unsigned) p,
217755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(startPos), /*IsStringLocation*/true,
217855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startPos, posLen));
2179efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek}
2180efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
2181826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos,
2182efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek                                            unsigned posLen) {
218355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier),
218455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               getLocationOfByte(startPos),
218555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               /*IsStringLocation*/true,
218655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               getSpecifierRange(startPos, posLen));
2187efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek}
2188efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
2189826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) {
219050687314f87b67073c202fe46d84d12fb55e25cfJordan Rose  if (!isa<ObjCStringLiteral>(OrigFormatExpr)) {
21910c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek    // The presence of a null character is likely an error.
219255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    EmitFormatDiagnostic(
219355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      S.PDiag(diag::warn_printf_format_string_contains_null_char),
219455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      getLocationOfByte(nullCharacter), /*IsStringLocation*/true,
219555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      getFormatStringRange());
21960c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek  }
2197826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
2198826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
219948716663e421472cbd590af160a372bc490205e8Jordan Rose// Note that this may return NULL if there was an error parsing or building
220048716663e421472cbd590af160a372bc490205e8Jordan Rose// one of the argument expressions.
2201826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const {
220229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  return Args[FirstDataArg + i];
2203826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
22044e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2205826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() {
2206826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    // Does the number of data arguments exceed the number of
2207826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    // format conversions in the format string?
2208826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (!HasVAListArg) {
2209826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      // Find any arguments that weren't covered.
2210826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    CoveredArgs.flip();
2211826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    signed notCoveredArg = CoveredArgs.find_first();
2212826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    if (notCoveredArg >= 0) {
2213826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      assert((unsigned)notCoveredArg < NumDataArgs);
221448716663e421472cbd590af160a372bc490205e8Jordan Rose      if (const Expr *E = getDataArg((unsigned) notCoveredArg)) {
221548716663e421472cbd590af160a372bc490205e8Jordan Rose        SourceLocation Loc = E->getLocStart();
221648716663e421472cbd590af160a372bc490205e8Jordan Rose        if (!S.getSourceManager().isInSystemMacro(Loc)) {
221748716663e421472cbd590af160a372bc490205e8Jordan Rose          EmitFormatDiagnostic(S.PDiag(diag::warn_printf_data_arg_not_used),
221848716663e421472cbd590af160a372bc490205e8Jordan Rose                               Loc, /*IsStringLocation*/false,
221948716663e421472cbd590af160a372bc490205e8Jordan Rose                               getFormatStringRange());
222048716663e421472cbd590af160a372bc490205e8Jordan Rose        }
2221c03f2df2a2b097bf2686bf32411d5022323988b2Bob Wilson      }
2222826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    }
2223826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  }
2224826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
2225826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2226c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool
2227c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex,
2228c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     SourceLocation Loc,
2229c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     const char *startSpec,
2230c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     unsigned specifierLen,
2231c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     const char *csStart,
2232c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     unsigned csLen) {
2233c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2234c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  bool keepGoing = true;
2235c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  if (argIndex < NumDataArgs) {
2236c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // Consider the argument coverered, even though the specifier doesn't
2237c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // make sense.
2238c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    CoveredArgs.set(argIndex);
2239c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  }
2240c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  else {
2241c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // If argIndex exceeds the number of data arguments we
2242c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // don't issue a warning because that is just a cascade of warnings (and
2243c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // they may have intended '%%' anyway). We don't want to continue processing
2244c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // the format string after this point, however, as we will like just get
2245c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // gibberish when trying to match arguments.
2246c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    keepGoing = false;
2247c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  }
2248c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
224955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_conversion)
225055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << StringRef(csStart, csLen),
225155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       Loc, /*IsStringLocation*/true,
225255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpec, specifierLen));
2253c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2254c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  return keepGoing;
2255c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek}
2256c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
225755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid
225855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard TrieuCheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc,
225955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                                      const char *startSpec,
226055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                                      unsigned specifierLen) {
226155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(
226255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    S.PDiag(diag::warn_format_mix_positional_nonpositional_args),
226355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen));
226455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu}
226555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
2266666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool
2267666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs(
2268666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  const analyze_format_string::FormatSpecifier &FS,
2269666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  const analyze_format_string::ConversionSpecifier &CS,
2270666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  const char *startSpecifier, unsigned specifierLen, unsigned argIndex) {
2271666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek
2272666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  if (argIndex >= NumDataArgs) {
227355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    PartialDiagnostic PDiag = FS.usesPositionalArg()
227455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args)
227555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu           << (argIndex+1) << NumDataArgs)
227655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      : S.PDiag(diag::warn_printf_insufficient_data_args);
227755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    EmitFormatDiagnostic(
227855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true,
227955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      getSpecifierRange(startSpecifier, specifierLen));
2280666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek    return false;
2281666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  }
2282666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  return true;
2283666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek}
2284666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek
228555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range>
228655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag,
228755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              SourceLocation Loc,
228855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              bool IsStringLocation,
228955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              Range StringRange,
2290ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                                              ArrayRef<FixItHint> FixIt) {
229129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag,
229255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       Loc, IsStringLocation, StringRange, FixIt);
229355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu}
229455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
229555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \brief If the format string is not within the funcion call, emit a note
229655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// so that the function call and string are in diagnostic messages.
229755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
229870517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param InFunctionCall if true, the format string is within the function
229955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// call and only one diagnostic message will be produced.  Otherwise, an
230055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// extra note will be emitted pointing to location of the format string.
230155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
230255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param ArgumentExpr the expression that is passed as the format string
230355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// argument in the function call.  Used for getting locations when two
230455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostics are emitted.
230555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
230655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param PDiag the callee should already have provided any strings for the
230755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostic message.  This function only adds locations and fixits
230855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// to diagnostics.
230955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
231055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param Loc primary location for diagnostic.  If two diagnostics are
231155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// required, one will be at Loc and a new SourceLocation will be created for
231255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// the other one.
231355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
231455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param IsStringLocation if true, Loc points to the format string should be
231555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// used for the note.  Otherwise, Loc points to the argument list and will
231655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// be used with PDiag.
231755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
231855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param StringRange some or all of the string to highlight.  This is
231955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// templated so it can accept either a CharSourceRange or a SourceRange.
232055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
232170517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param FixIt optional fix it hint for the format string.
232255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range>
232355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(Sema &S, bool InFunctionCall,
232455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              const Expr *ArgumentExpr,
232555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              PartialDiagnostic PDiag,
232655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              SourceLocation Loc,
232755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              bool IsStringLocation,
232855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              Range StringRange,
2329ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                                              ArrayRef<FixItHint> FixIt) {
2330ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  if (InFunctionCall) {
2331ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    const Sema::SemaDiagnosticBuilder &D = S.Diag(Loc, PDiag);
2332ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    D << StringRange;
2333ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end();
2334ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose         I != E; ++I) {
2335ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      D << *I;
2336ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    }
2337ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  } else {
233855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag)
233955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      << ArgumentExpr->getSourceRange();
2340ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2341ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    const Sema::SemaDiagnosticBuilder &Note =
2342ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      S.Diag(IsStringLocation ? Loc : StringRange.getBegin(),
2343ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose             diag::note_format_string_defined);
2344ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2345ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    Note << StringRange;
2346ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end();
2347ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose         I != E; ++I) {
2348ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      Note << *I;
2349ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    }
235055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  }
235155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu}
235255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
2353826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===//
2354826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2355826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace {
2356826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler {
235750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose  bool ObjCContext;
2358826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic:
2359826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  CheckPrintfHandler(Sema &s, const StringLiteral *fexpr,
2360826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                     const Expr *origFormatExpr, unsigned firstDataArg,
236150687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                     unsigned numDataArgs, bool isObjC,
2362826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                     const char *beg, bool hasVAListArg,
23631c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko                     ArrayRef<const Expr *> Args,
2364ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                     unsigned formatIdx, bool inFunctionCall,
2365ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                     Sema::VariadicCallType CallType)
2366826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
23671c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko                       numDataArgs, beg, hasVAListArg, Args,
2368ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                       formatIdx, inFunctionCall, CallType), ObjCContext(isObjC)
2369ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose  {}
2370ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose
2371826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2372826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  bool HandleInvalidPrintfConversionSpecifier(
2373826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const analyze_printf::PrintfSpecifier &FS,
2374826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const char *startSpecifier,
2375826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      unsigned specifierLen);
2376826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2377826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS,
2378826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                             const char *startSpecifier,
2379826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                             unsigned specifierLen);
2380831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  bool checkFormatExpr(const analyze_printf::PrintfSpecifier &FS,
2381831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                       const char *StartSpecifier,
2382831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                       unsigned SpecifierLen,
2383831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                       const Expr *E);
2384831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2385826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k,
2386826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                    const char *startSpecifier, unsigned specifierLen);
2387826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS,
2388826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                           const analyze_printf::OptionalAmount &Amt,
2389826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                           unsigned type,
2390826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                           const char *startSpecifier, unsigned specifierLen);
2391826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  void HandleFlag(const analyze_printf::PrintfSpecifier &FS,
2392826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                  const analyze_printf::OptionalFlag &flag,
2393826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                  const char *startSpecifier, unsigned specifierLen);
2394826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS,
2395826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                         const analyze_printf::OptionalFlag &ignoredFlag,
2396826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                         const analyze_printf::OptionalFlag &flag,
2397826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                         const char *startSpecifier, unsigned specifierLen);
2398f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg  bool checkForCStrMembers(const analyze_printf::ArgType &AT,
2399831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                           const Expr *E, const CharSourceRange &CSR);
2400831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2401826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek};
2402826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
2403826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2404826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier(
2405826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const analyze_printf::PrintfSpecifier &FS,
2406826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const char *startSpecifier,
2407826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      unsigned specifierLen) {
24086ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const analyze_printf::PrintfConversionSpecifier &CS =
2409c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    FS.getConversionSpecifier();
2410826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2411c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  return HandleInvalidConversionSpecifier(FS.getArgIndex(),
2412c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          getLocationOfByte(CS.getStart()),
2413c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          startSpecifier, specifierLen,
2414c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          CS.getStart(), CS.getLength());
241526ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek}
241626ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek
2417826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount(
2418826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                               const analyze_format_string::OptionalAmount &Amt,
2419826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                               unsigned k, const char *startSpecifier,
2420826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                               unsigned specifierLen) {
24210d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek
24220d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  if (Amt.hasDataArgument()) {
24230d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek    if (!HasVAListArg) {
24247f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      unsigned argIndex = Amt.getArgIndex();
24257f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      if (argIndex >= NumDataArgs) {
242655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu        EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg)
242755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               << k,
242855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             getLocationOfByte(Amt.getStart()),
242955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             /*IsStringLocation*/true,
243055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             getSpecifierRange(startSpecifier, specifierLen));
24310d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        // Don't do any more checking.  We will just emit
24320d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        // spurious errors.
24330d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        return false;
24340d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek      }
24354e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
24360d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek      // Type check the data argument.  It should be an 'int'.
243731f8e32788adb299acad455363eb7fd244642c82Ted Kremenek      // Although not in conformance with C99, we also allow the argument to be
243831f8e32788adb299acad455363eb7fd244642c82Ted Kremenek      // an 'unsigned int' as that is a reasonably safe case.  GCC also
243931f8e32788adb299acad455363eb7fd244642c82Ted Kremenek      // doesn't emit a warning for that case.
24407f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      CoveredArgs.set(argIndex);
24417f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      const Expr *Arg = getDataArg(argIndex);
244248716663e421472cbd590af160a372bc490205e8Jordan Rose      if (!Arg)
244348716663e421472cbd590af160a372bc490205e8Jordan Rose        return false;
244448716663e421472cbd590af160a372bc490205e8Jordan Rose
24450d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek      QualType T = Arg->getType();
24464e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2447f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg      const analyze_printf::ArgType &AT = Amt.getArgType(S.Context);
2448f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg      assert(AT.isValid());
24494e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2450f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg      if (!AT.matchesType(S.Context, T)) {
245155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu        EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type)
2452f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg                               << k << AT.getRepresentativeTypeName(S.Context)
245355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               << T << Arg->getSourceRange(),
245455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             getLocationOfByte(Amt.getStart()),
245555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             /*IsStringLocation*/true,
245655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             getSpecifierRange(startSpecifier, specifierLen));
24570d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        // Don't do any more checking.  We will just emit
24580d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        // spurious errors.
24590d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        return false;
24600d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek      }
24610d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek    }
24620d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  }
24630d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  return true;
24640d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek}
24650d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek
2466e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount(
2467826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const analyze_printf::PrintfSpecifier &FS,
2468e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                      const analyze_printf::OptionalAmount &Amt,
2469e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                      unsigned type,
2470e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                      const char *startSpecifier,
2471e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                      unsigned specifierLen) {
24726ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const analyze_printf::PrintfConversionSpecifier &CS =
24736ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek    FS.getConversionSpecifier();
2474e4ee9663168dfb2b4122c768091e30217328c9faTom Care
247555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  FixItHint fixit =
247655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant
247755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(),
247855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                 Amt.getConstantLength()))
247955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      : FixItHint();
248055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
248155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount)
248255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << type << CS.toString(),
248355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(Amt.getStart()),
248455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       /*IsStringLocation*/true,
248555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpecifier, specifierLen),
248655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       fixit);
2487e4ee9663168dfb2b4122c768091e30217328c9faTom Care}
2488e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2489826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS,
2490e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                    const analyze_printf::OptionalFlag &flag,
2491e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                    const char *startSpecifier,
2492e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                    unsigned specifierLen) {
2493e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Warn about pointless flag with a fixit removal.
24946ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const analyze_printf::PrintfConversionSpecifier &CS =
24956ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek    FS.getConversionSpecifier();
249655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag)
249755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << flag.toString() << CS.toString(),
249855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(flag.getPosition()),
249955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       /*IsStringLocation*/true,
250055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpecifier, specifierLen),
250155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       FixItHint::CreateRemoval(
250255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         getSpecifierRange(flag.getPosition(), 1)));
2503e4ee9663168dfb2b4122c768091e30217328c9faTom Care}
2504e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2505e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag(
2506826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                const analyze_printf::PrintfSpecifier &FS,
2507e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                const analyze_printf::OptionalFlag &ignoredFlag,
2508e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                const analyze_printf::OptionalFlag &flag,
2509e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                const char *startSpecifier,
2510e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                unsigned specifierLen) {
2511e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Warn about ignored flag with a fixit removal.
251255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag)
251355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << ignoredFlag.toString() << flag.toString(),
251455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(ignoredFlag.getPosition()),
251555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       /*IsStringLocation*/true,
251655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpecifier, specifierLen),
251755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       FixItHint::CreateRemoval(
251855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         getSpecifierRange(ignoredFlag.getPosition(), 1)));
2519e4ee9663168dfb2b4122c768091e30217328c9faTom Care}
2520e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2521831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determines if the specified is a C++ class or struct containing
2522831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// a member with the specified name and kind (e.g. a CXXMethodDecl named
2523831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// "c_str()").
2524831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithtemplate<typename MemberKind>
2525831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithstatic llvm::SmallPtrSet<MemberKind*, 1>
2526831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCXXRecordMembersNamed(StringRef Name, Sema &S, QualType Ty) {
2527831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  const RecordType *RT = Ty->getAs<RecordType>();
2528831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  llvm::SmallPtrSet<MemberKind*, 1> Results;
2529831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2530831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (!RT)
2531831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return Results;
2532831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl());
2533831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (!RD)
2534831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return Results;
2535831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2536831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  LookupResult R(S, &S.PP.getIdentifierTable().get(Name), SourceLocation(),
2537831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                 Sema::LookupMemberName);
2538831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2539831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // We just need to include all members of the right kind turned up by the
2540831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // filter, at this point.
2541831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (S.LookupQualifiedName(R, RT->getDecl()))
2542831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    for (LookupResult::iterator I = R.begin(), E = R.end(); I != E; ++I) {
2543831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      NamedDecl *decl = (*I)->getUnderlyingDecl();
2544831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      if (MemberKind *FK = dyn_cast<MemberKind>(decl))
2545831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        Results.insert(FK);
2546831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    }
2547831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return Results;
2548831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
2549831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2550831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Check if a (w)string was passed when a (w)char* was needed, and offer a
2551f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg// better diagnostic if so. AT is assumed to be valid.
2552831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Returns true when a c_str() conversion method is found.
2553831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool CheckPrintfHandler::checkForCStrMembers(
2554f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg    const analyze_printf::ArgType &AT, const Expr *E,
2555831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    const CharSourceRange &CSR) {
2556831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  typedef llvm::SmallPtrSet<CXXMethodDecl*, 1> MethodSet;
2557831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2558831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  MethodSet Results =
2559831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      CXXRecordMembersNamed<CXXMethodDecl>("c_str", S, E->getType());
2560831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2561831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  for (MethodSet::iterator MI = Results.begin(), ME = Results.end();
2562831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith       MI != ME; ++MI) {
2563831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    const CXXMethodDecl *Method = *MI;
2564831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    if (Method->getNumParams() == 0 &&
2565f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg          AT.matchesType(S.Context, Method->getResultType())) {
2566831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      // FIXME: Suggest parens if the expression needs them.
2567831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      SourceLocation EndLoc =
2568831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          S.getPreprocessor().getLocForEndOfToken(E->getLocEnd());
2569831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      S.Diag(E->getLocStart(), diag::note_printf_c_str)
2570831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          << "c_str()"
2571831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          << FixItHint::CreateInsertion(EndLoc, ".c_str()");
2572831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      return true;
2573831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    }
2574831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  }
2575831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2576831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return false;
2577831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
2578831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2579e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool
2580826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier
25815c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek                                            &FS,
2582e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek                                          const char *startSpecifier,
2583e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek                                          unsigned specifierLen) {
2584e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
25856ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  using namespace analyze_format_string;
2586efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  using namespace analyze_printf;
25876ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const PrintfConversionSpecifier &CS = FS.getConversionSpecifier();
2588e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2589baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek  if (FS.consumesDataArgument()) {
2590baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    if (atFirstArg) {
2591baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek        atFirstArg = false;
2592baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek        usesPositionalArgs = FS.usesPositionalArg();
2593baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    }
2594baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    else if (usesPositionalArgs != FS.usesPositionalArg()) {
259555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()),
259655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                        startSpecifier, specifierLen);
2597baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek      return false;
2598baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    }
2599efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  }
2600efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
26010d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  // First check if the field width, precision, and conversion specifier
26020d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  // have matching data arguments.
2603efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0,
2604efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek                    startSpecifier, specifierLen)) {
26050d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek    return false;
26060d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  }
26074e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2608efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  if (!HandleAmount(FS.getPrecision(), /* precision */ 1,
2609efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek                    startSpecifier, specifierLen)) {
26100d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek    return false;
26110d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  }
26120d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek
2613f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek  if (!CS.consumesDataArgument()) {
2614f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek    // FIXME: Technically specifying a precision or field width here
2615f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek    // makes no sense.  Worth issuing a warning at some point.
26160e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek    return true;
2617f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek  }
26184e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
26197f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  // Consume the argument.
26207f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  unsigned argIndex = FS.getArgIndex();
2621e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek  if (argIndex < NumDataArgs) {
2622e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek    // The check to see if the argIndex is valid will come later.
2623e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek    // We set the bit here because we may exit early from this
2624e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek    // function if we encounter some other error.
2625e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek    CoveredArgs.set(argIndex);
2626e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek  }
26277f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek
26287f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  // Check for using an Objective-C specific conversion specifier
26297f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  // in a non-ObjC literal.
263050687314f87b67073c202fe46d84d12fb55e25cfJordan Rose  if (!ObjCContext && CS.isObjCArg()) {
2631826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier,
2632826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                                  specifierLen);
26337f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  }
26344e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2635e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check for invalid use of field width
2636e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidFieldWidth()) {
263745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care    HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0,
2638e4ee9663168dfb2b4122c768091e30217328c9faTom Care        startSpecifier, specifierLen);
2639e4ee9663168dfb2b4122c768091e30217328c9faTom Care  }
2640e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2641e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check for invalid use of precision
2642e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidPrecision()) {
2643e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1,
2644e4ee9663168dfb2b4122c768091e30217328c9faTom Care        startSpecifier, specifierLen);
2645e4ee9663168dfb2b4122c768091e30217328c9faTom Care  }
2646e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2647e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check each flag does not conflict with any other component.
264865197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek  if (!FS.hasValidThousandsGroupingPrefix())
264965197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek    HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen);
2650e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidLeadingZeros())
2651e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen);
2652e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidPlusPrefix())
2653e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen);
265445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  if (!FS.hasValidSpacePrefix())
265545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care    HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen);
2656e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidAlternativeForm())
2657e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen);
2658e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidLeftJustified())
2659e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen);
2660e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2661e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check that flags are not ignored by another flag
266245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+'
266345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care    HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(),
266445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care        startSpecifier, specifierLen);
2665e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-'
2666e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(),
2667e4ee9663168dfb2b4122c768091e30217328c9faTom Care            startSpecifier, specifierLen);
2668e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2669e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check the length modifier is valid with the given conversion specifier.
2670bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo()))
26718be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
26728be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                                diag::warn_format_nonsensical_length);
2673bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  else if (!FS.hasStandardLengthModifier())
26748be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen);
2675bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  else if (!FS.hasStandardLengthConversionCombination())
26768be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
26778be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                                diag::warn_format_non_standard_conversion_spec);
2678e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2679bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  if (!FS.hasStandardConversionSpecifier(S.getLangOpts()))
2680bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose    HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen);
2681bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
2682da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek  // The remaining checks depend on the data arguments.
2683da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek  if (HasVAListArg)
2684da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek    return true;
26854e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2686666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
2687da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek    return false;
26884e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
268948716663e421472cbd590af160a372bc490205e8Jordan Rose  const Expr *Arg = getDataArg(argIndex);
269048716663e421472cbd590af160a372bc490205e8Jordan Rose  if (!Arg)
269148716663e421472cbd590af160a372bc490205e8Jordan Rose    return true;
269248716663e421472cbd590af160a372bc490205e8Jordan Rose
269348716663e421472cbd590af160a372bc490205e8Jordan Rose  return checkFormatExpr(FS, startSpecifier, specifierLen, Arg);
2694831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
2695831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2696ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rosestatic bool requiresParensToAddCast(const Expr *E) {
2697ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  // FIXME: We should have a general way to reason about operator
2698ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  // precedence and whether parens are actually needed here.
2699ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  // Take care of a few common cases where they aren't.
2700ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  const Expr *Inside = E->IgnoreImpCasts();
2701ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  if (const PseudoObjectExpr *POE = dyn_cast<PseudoObjectExpr>(Inside))
2702ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    Inside = POE->getSyntacticForm()->IgnoreImpCasts();
2703ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2704ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  switch (Inside->getStmtClass()) {
2705ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::ArraySubscriptExprClass:
2706ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::CallExprClass:
270717ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose  case Stmt::CharacterLiteralClass:
270817ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose  case Stmt::CXXBoolLiteralExprClass:
2709ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::DeclRefExprClass:
271017ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose  case Stmt::FloatingLiteralClass:
271117ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose  case Stmt::IntegerLiteralClass:
2712ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::MemberExprClass:
271317ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose  case Stmt::ObjCArrayLiteralClass:
271417ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose  case Stmt::ObjCBoolLiteralExprClass:
271517ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose  case Stmt::ObjCBoxedExprClass:
271617ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose  case Stmt::ObjCDictionaryLiteralClass:
271717ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose  case Stmt::ObjCEncodeExprClass:
2718ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::ObjCIvarRefExprClass:
2719ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::ObjCMessageExprClass:
2720ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::ObjCPropertyRefExprClass:
272117ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose  case Stmt::ObjCStringLiteralClass:
272217ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose  case Stmt::ObjCSubscriptRefExprClass:
2723ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::ParenExprClass:
272417ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose  case Stmt::StringLiteralClass:
2725ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::UnaryOperatorClass:
2726ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    return false;
2727ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  default:
2728ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    return true;
2729ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  }
2730ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose}
2731ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2732831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool
2733831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCheckPrintfHandler::checkFormatExpr(const analyze_printf::PrintfSpecifier &FS,
2734831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                    const char *StartSpecifier,
2735831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                    unsigned SpecifierLen,
2736831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                    const Expr *E) {
2737831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  using namespace analyze_format_string;
2738831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  using namespace analyze_printf;
273996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer  // Now type check the data expression that matches the
274096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer  // format specifier.
2741f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg  const analyze_printf::ArgType &AT = FS.getArgType(S.Context,
2742f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg                                                    ObjCContext);
2743614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  if (!AT.isValid())
2744614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    return true;
2745ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2746448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose  QualType ExprTy = E->getType();
274702be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek  while (const TypeOfExprType *TET = dyn_cast<TypeOfExprType>(ExprTy)) {
274802be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek    ExprTy = TET->getUnderlyingExpr()->getType();
274902be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek  }
275002be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek
2751448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose  if (AT.matchesType(S.Context, ExprTy))
2752614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    return true;
2753614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose
2754614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  // Look through argument promotions for our error message's reported type.
2755614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  // This includes the integral and floating promotions, but excludes array
2756614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  // and function pointer decay; seeing that an argument intended to be a
2757614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  // string has type 'char [6]' is probably more confusing than 'char *'.
2758614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) {
2759614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    if (ICE->getCastKind() == CK_IntegralCast ||
2760614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        ICE->getCastKind() == CK_FloatingCast) {
2761614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      E = ICE->getSubExpr();
2762448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose      ExprTy = E->getType();
2763614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose
2764614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      // Check if we didn't match because of an implicit cast from a 'char'
2765614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      // or 'short' to an 'int'.  This is done because printf is a varargs
2766614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      // function.
2767614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      if (ICE->getType() == S.Context.IntTy ||
2768614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          ICE->getType() == S.Context.UnsignedIntTy) {
2769614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        // All further checking is done on the subexpression.
2770448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose        if (AT.matchesType(S.Context, ExprTy))
2771614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          return true;
27724d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek      }
2773ee0259d308e72141982a85b40863e760a8447edfJordan Rose    }
2774448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose  } else if (const CharacterLiteral *CL = dyn_cast<CharacterLiteral>(E)) {
2775448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose    // Special case for 'a', which has type 'int' in C.
2776448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose    // Note, however, that we do /not/ want to treat multibyte constants like
2777448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose    // 'MooV' as characters! This form is deprecated but still exists.
2778448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose    if (ExprTy == S.Context.IntTy)
2779448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose      if (llvm::isUIntN(S.Context.getCharWidth(), CL->getValue()))
2780448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose        ExprTy = S.Context.CharTy;
2781614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  }
2782614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose
27832cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose  // %C in an Objective-C context prints a unichar, not a wchar_t.
27842cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose  // If the argument is an integer of some kind, believe the %C and suggest
27852cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose  // a cast instead of changing the conversion specifier.
2786448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose  QualType IntendedTy = ExprTy;
27872cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose  if (ObjCContext &&
27882cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose      FS.getConversionSpecifier().getKind() == ConversionSpecifier::CArg) {
27892cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose    if (ExprTy->isIntegralOrUnscopedEnumerationType() &&
27902cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        !ExprTy->isCharType()) {
27912cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose      // 'unichar' is defined as a typedef of unsigned short, but we should
27922cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose      // prefer using the typedef if it is visible.
27932cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose      IntendedTy = S.Context.UnsignedShortTy;
27942cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose
27952cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose      LookupResult Result(S, &S.Context.Idents.get("unichar"), E->getLocStart(),
27962cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose                          Sema::LookupOrdinaryName);
27972cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose      if (S.LookupName(Result, S.getCurScope())) {
27982cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        NamedDecl *ND = Result.getFoundDecl();
27992cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        if (TypedefNameDecl *TD = dyn_cast<TypedefNameDecl>(ND))
28002cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose          if (TD->getUnderlyingType() == IntendedTy)
28012cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose            IntendedTy = S.Context.getTypedefType(TD);
28022cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose      }
28032cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose    }
28042cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose  }
28052cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose
28062cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose  // Special-case some of Darwin's platform-independence types by suggesting
28072cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose  // casts to primitive types that are known to be large enough.
28082cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose  bool ShouldNotPrintDirectly = false;
2809ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  if (S.Context.getTargetInfo().getTriple().isOSDarwin()) {
28106edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek    // Use a 'while' to peel off layers of typedefs.
28116edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek    QualType TyTy = IntendedTy;
28126edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek    while (const TypedefType *UserTy = TyTy->getAs<TypedefType>()) {
2813ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      StringRef Name = UserTy->getDecl()->getName();
28142cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose      QualType CastTy = llvm::StringSwitch<QualType>(Name)
2815ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        .Case("NSInteger", S.Context.LongTy)
2816ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        .Case("NSUInteger", S.Context.UnsignedLongTy)
2817ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        .Case("SInt32", S.Context.IntTy)
2818ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        .Case("UInt32", S.Context.UnsignedIntTy)
28192cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        .Default(QualType());
28202cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose
28212cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose      if (!CastTy.isNull()) {
28222cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        ShouldNotPrintDirectly = true;
28232cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        IntendedTy = CastTy;
28246edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek        break;
28252cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose      }
28266edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek      TyTy = UserTy->desugar();
2827ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    }
2828ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  }
2829ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2830614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  // We may be able to offer a FixItHint if it is a supported type.
2831614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  PrintfSpecifier fixedFS = FS;
2832ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  bool success = fixedFS.fixType(IntendedTy, S.getLangOpts(),
2833614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose                                 S.Context, ObjCContext);
283496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer
2835614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  if (success) {
2836614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    // Get the fix string from the fixed format specifier
2837614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    SmallString<16> buf;
2838614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    llvm::raw_svector_ostream os(buf);
2839614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    fixedFS.toString(os);
2840614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose
2841ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    CharSourceRange SpecRange = getSpecifierRange(StartSpecifier, SpecifierLen);
2842ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
28432cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose    if (IntendedTy == ExprTy) {
28442cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose      // In this case, the specifier is wrong and should be changed to match
28452cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose      // the argument.
28462cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose      EmitFormatDiagnostic(
28472cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
28482cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose          << AT.getRepresentativeTypeName(S.Context) << IntendedTy
28492cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose          << E->getSourceRange(),
28502cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        E->getLocStart(),
28512cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        /*IsStringLocation*/false,
28522cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        SpecRange,
28532cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        FixItHint::CreateReplacement(SpecRange, os.str()));
28542cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose
28552cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose    } else {
2856ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // The canonical type for formatting this value is different from the
2857ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // actual type of the expression. (This occurs, for example, with Darwin's
2858ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // NSInteger on 32-bit platforms, where it is typedef'd as 'int', but
2859ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // should be printed as 'long' for 64-bit compatibility.)
2860ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // Rather than emitting a normal format/argument mismatch, we want to
2861ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // add a cast to the recommended type (and correct the format string
2862ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // if necessary).
2863ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      SmallString<16> CastBuf;
2864ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      llvm::raw_svector_ostream CastFix(CastBuf);
2865ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      CastFix << "(";
2866ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      IntendedTy.print(CastFix, S.Context.getPrintingPolicy());
2867ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      CastFix << ")";
2868ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2869ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      SmallVector<FixItHint,4> Hints;
2870ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      if (!AT.matchesType(S.Context, IntendedTy))
2871ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        Hints.push_back(FixItHint::CreateReplacement(SpecRange, os.str()));
2872ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2873ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      if (const CStyleCastExpr *CCast = dyn_cast<CStyleCastExpr>(E)) {
2874ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        // If there's already a cast present, just replace it.
2875ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        SourceRange CastRange(CCast->getLParenLoc(), CCast->getRParenLoc());
2876ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        Hints.push_back(FixItHint::CreateReplacement(CastRange, CastFix.str()));
2877ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2878ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      } else if (!requiresParensToAddCast(E)) {
2879ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        // If the expression has high enough precedence,
2880ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        // just write the C-style cast.
2881ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(),
2882ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                                                   CastFix.str()));
2883ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      } else {
2884ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        // Otherwise, add parens around the expression as well as the cast.
2885ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        CastFix << "(";
2886ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(),
2887ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                                                   CastFix.str()));
2888ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2889ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        SourceLocation After = S.PP.getLocForEndOfToken(E->getLocEnd());
2890ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        Hints.push_back(FixItHint::CreateInsertion(After, ")"));
2891ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      }
2892ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
28932cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose      if (ShouldNotPrintDirectly) {
28942cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        // The expression has a type that should not be printed directly.
28952cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        // We extract the name from the typedef because we don't want to show
28962cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        // the underlying type in the diagnostic.
28972cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        StringRef Name = cast<TypedefType>(ExprTy)->getDecl()->getName();
28982cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose
28992cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        EmitFormatDiagnostic(S.PDiag(diag::warn_format_argument_needs_cast)
29002cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose                               << Name << IntendedTy
29012cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose                               << E->getSourceRange(),
29022cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose                             E->getLocStart(), /*IsStringLocation=*/false,
29032cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose                             SpecRange, Hints);
29042cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose      } else {
29052cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        // In this case, the expression could be printed using a different
29062cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        // specifier, but we've decided that the specifier is probably correct
29072cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        // and we should cast instead. Just use the normal warning message.
29082cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose        EmitFormatDiagnostic(
29092cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose          S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
29102cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose            << AT.getRepresentativeTypeName(S.Context) << ExprTy
29112cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose            << E->getSourceRange(),
29122cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose          E->getLocStart(), /*IsStringLocation*/false,
29132cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose          SpecRange, Hints);
29142cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose      }
2915ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    }
2916614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  } else {
2917614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    const CharSourceRange &CSR = getSpecifierRange(StartSpecifier,
2918614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose                                                   SpecifierLen);
2919614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    // Since the warning for passing non-POD types to variadic functions
2920614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    // was deferred until now, we emit a warning for non-POD
2921614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    // arguments here.
2922448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose    if (S.isValidVarArgType(ExprTy) == Sema::VAK_Invalid) {
2923614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      unsigned DiagKind;
2924448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose      if (ExprTy->isObjCObjectType())
2925614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        DiagKind = diag::err_cannot_pass_objc_interface_to_vararg_format;
2926614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      else
2927614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        DiagKind = diag::warn_non_pod_vararg_with_format_string;
292896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer
2929614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      EmitFormatDiagnostic(
2930614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        S.PDiag(DiagKind)
293180ad52f327b532bded5c5b0ee38779d841c6cd35Richard Smith          << S.getLangOpts().CPlusPlus11
2932448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose          << ExprTy
2933614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          << CallType
2934614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          << AT.getRepresentativeTypeName(S.Context)
2935614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          << CSR
2936614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          << E->getSourceRange(),
2937614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        E->getLocStart(), /*IsStringLocation*/false, CSR);
293896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer
2939614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      checkForCStrMembers(AT, E, CSR);
2940614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    } else
294155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      EmitFormatDiagnostic(
294255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu        S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
2943448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose          << AT.getRepresentativeTypeName(S.Context) << ExprTy
2944614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          << CSR
2945831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          << E->getSourceRange(),
2946614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        E->getLocStart(), /*IsStringLocation*/false, CSR);
294796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer  }
294896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer
2949e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  return true;
2950e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}
2951e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2952826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===//
2953826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2954826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace {
2955826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler {
2956826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic:
2957826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  CheckScanfHandler(Sema &s, const StringLiteral *fexpr,
2958826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                    const Expr *origFormatExpr, unsigned firstDataArg,
295950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                    unsigned numDataArgs, const char *beg, bool hasVAListArg,
29601c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko                    ArrayRef<const Expr *> Args,
2961ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                    unsigned formatIdx, bool inFunctionCall,
2962ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                    Sema::VariadicCallType CallType)
2963826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
296450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                       numDataArgs, beg, hasVAListArg,
29651c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko                       Args, formatIdx, inFunctionCall, CallType)
2966ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose  {}
2967826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2968826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS,
2969826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                            const char *startSpecifier,
2970826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                            unsigned specifierLen);
2971c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2972c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  bool HandleInvalidScanfConversionSpecifier(
2973c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek          const analyze_scanf::ScanfSpecifier &FS,
2974c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek          const char *startSpecifier,
2975c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek          unsigned specifierLen);
2976b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek
2977b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek  void HandleIncompleteScanList(const char *start, const char *end);
2978826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek};
2979826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
2980826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2981b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start,
2982b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek                                                 const char *end) {
298355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete),
298455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(end), /*IsStringLocation*/true,
298555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(start, end - start));
2986b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek}
2987b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek
2988c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier(
2989c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        const analyze_scanf::ScanfSpecifier &FS,
2990c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        const char *startSpecifier,
2991c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        unsigned specifierLen) {
2992c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
29936ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const analyze_scanf::ScanfConversionSpecifier &CS =
2994c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    FS.getConversionSpecifier();
2995c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2996c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  return HandleInvalidConversionSpecifier(FS.getArgIndex(),
2997c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          getLocationOfByte(CS.getStart()),
2998c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          startSpecifier, specifierLen,
2999c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          CS.getStart(), CS.getLength());
3000c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek}
3001c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
3002826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier(
3003826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                       const analyze_scanf::ScanfSpecifier &FS,
3004826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                       const char *startSpecifier,
3005826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                       unsigned specifierLen) {
3006826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3007826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  using namespace analyze_scanf;
3008826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  using namespace analyze_format_string;
3009826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
30106ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const ScanfConversionSpecifier &CS = FS.getConversionSpecifier();
3011826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3012baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek  // Handle case where '%' and '*' don't consume an argument.  These shouldn't
3013baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek  // be used to decide if we are using positional arguments consistently.
3014baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek  if (FS.consumesDataArgument()) {
3015baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    if (atFirstArg) {
3016baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek      atFirstArg = false;
3017baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek      usesPositionalArgs = FS.usesPositionalArg();
3018baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    }
3019baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    else if (usesPositionalArgs != FS.usesPositionalArg()) {
302055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()),
302155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                        startSpecifier, specifierLen);
3022baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek      return false;
3023baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    }
3024826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  }
3025826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3026826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  // Check if the field with is non-zero.
3027826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  const OptionalAmount &Amt = FS.getFieldWidth();
3028826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (Amt.getHowSpecified() == OptionalAmount::Constant) {
3029826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    if (Amt.getConstantAmount() == 0) {
3030826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      const CharSourceRange &R = getSpecifierRange(Amt.getStart(),
3031826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                                   Amt.getConstantLength());
303255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width),
303355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                           getLocationOfByte(Amt.getStart()),
303455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                           /*IsStringLocation*/true, R,
303555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                           FixItHint::CreateRemoval(R));
30367f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek    }
30377f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  }
3038826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3039826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (!FS.consumesDataArgument()) {
3040826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    // FIXME: Technically specifying a precision or field width here
3041826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    // makes no sense.  Worth issuing a warning at some point.
3042826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    return true;
3043826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  }
3044826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3045826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  // Consume the argument.
3046826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  unsigned argIndex = FS.getArgIndex();
3047826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (argIndex < NumDataArgs) {
3048826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      // The check to see if the argIndex is valid will come later.
3049826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      // We set the bit here because we may exit early from this
3050826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      // function if we encounter some other error.
3051826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    CoveredArgs.set(argIndex);
3052826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  }
3053826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
30541e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek  // Check the length modifier is valid with the given conversion specifier.
3055bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo()))
30568be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
30578be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                                diag::warn_format_nonsensical_length);
3058bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  else if (!FS.hasStandardLengthModifier())
30598be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen);
3060bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  else if (!FS.hasStandardLengthConversionCombination())
30618be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
30628be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                                diag::warn_format_non_standard_conversion_spec);
306376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
3064bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  if (!FS.hasStandardConversionSpecifier(S.getLangOpts()))
3065bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose    HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen);
3066bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
3067826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  // The remaining checks depend on the data arguments.
3068826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (HasVAListArg)
3069826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    return true;
3070826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3071666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
3072826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    return false;
3073826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
30746fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg  // Check that the argument type matches the format specifier.
30756fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg  const Expr *Ex = getDataArg(argIndex);
307648716663e421472cbd590af160a372bc490205e8Jordan Rose  if (!Ex)
307748716663e421472cbd590af160a372bc490205e8Jordan Rose    return true;
307848716663e421472cbd590af160a372bc490205e8Jordan Rose
307958e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg  const analyze_format_string::ArgType &AT = FS.getArgType(S.Context);
308058e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg  if (AT.isValid() && !AT.matchesType(S.Context, Ex->getType())) {
30816fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg    ScanfSpecifier fixedFS = FS;
30824e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie    bool success = fixedFS.fixType(Ex->getType(), S.getLangOpts(),
3083be6126a2a784e1446460b8d15c2b26f880c871fcHans Wennborg                                   S.Context);
30846fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg
30856fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg    if (success) {
30866fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg      // Get the fix string from the fixed format specifier.
3087f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith      SmallString<128> buf;
30886fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg      llvm::raw_svector_ostream os(buf);
30896fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg      fixedFS.toString(os);
30906fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg
30916fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg      EmitFormatDiagnostic(
30926fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg        S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
309358e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg          << AT.getRepresentativeTypeName(S.Context) << Ex->getType()
30946fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg          << Ex->getSourceRange(),
3095abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay        Ex->getLocStart(),
3096abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay        /*IsStringLocation*/false,
30976fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg        getSpecifierRange(startSpecifier, specifierLen),
30986fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg        FixItHint::CreateReplacement(
30996fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg          getSpecifierRange(startSpecifier, specifierLen),
31006fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg          os.str()));
31016fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg    } else {
3102220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas      EmitFormatDiagnostic(
3103220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas        S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
310458e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg          << AT.getRepresentativeTypeName(S.Context) << Ex->getType()
3105220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas          << Ex->getSourceRange(),
3106abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay        Ex->getLocStart(),
3107abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay        /*IsStringLocation*/false,
3108220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas        getSpecifierRange(startSpecifier, specifierLen));
31096fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg    }
31106fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg  }
31116fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg
3112826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  return true;
311307d161f38e708a91486bf1c031d525faebbb249dTed Kremenek}
3114e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
3115826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr,
31160e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek                             const Expr *OrigFormatExpr,
31171c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko                             ArrayRef<const Expr *> Args,
311829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                             bool HasVAListArg, unsigned format_idx,
311934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas                             unsigned firstDataArg, FormatStringType Type,
3120ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                             bool inFunctionCall, VariadicCallType CallType) {
3121826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3122e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  // CHECK: is the format string a wide literal?
3123df9ef1bc8c3780307ab2ed81bf5e31c23310b936Richard Smith  if (!FExpr->isAscii() && !FExpr->isUTF8()) {
312455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    CheckFormatHandler::EmitFormatDiagnostic(
312529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas      *this, inFunctionCall, Args[format_idx],
312655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(),
312755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      /*IsStringLocation*/true, OrigFormatExpr->getSourceRange());
3128e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek    return;
3129e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  }
3130826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3131e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  // Str - The format string.  NOTE: this is NOT null-terminated!
31325f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner  StringRef StrRef = FExpr->getString();
31332f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer  const char *Str = StrRef.data();
31342f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer  unsigned StrLen = StrRef.size();
31351c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko  const unsigned numDataArgs = Args.size() - firstDataArg;
3136826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3137e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  // CHECK: empty format string?
31384cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek  if (StrLen == 0 && numDataArgs > 0) {
313955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    CheckFormatHandler::EmitFormatDiagnostic(
314029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas      *this, inFunctionCall, Args[format_idx],
314155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      PDiag(diag::warn_empty_format_string), FExpr->getLocStart(),
314255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      /*IsStringLocation*/true, OrigFormatExpr->getSourceRange());
3143e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek    return;
3144e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  }
3145826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
314634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  if (Type == FST_Printf || Type == FST_NSString) {
3147826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
314850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                         numDataArgs, (Type == FST_NSString),
31491c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko                         Str, HasVAListArg, Args, format_idx,
3150ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                         inFunctionCall, CallType);
3151826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3152d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg    if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen,
3153275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose                                                  getLangOpts(),
3154275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose                                                  Context.getTargetInfo()))
3155826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      H.DoneProcessing();
315634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  } else if (Type == FST_Scanf) {
315750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose    CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, numDataArgs,
31581c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko                        Str, HasVAListArg, Args, format_idx,
3159ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                        inFunctionCall, CallType);
3160826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3161d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg    if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen,
3162275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose                                                 getLangOpts(),
3163275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose                                                 Context.getTargetInfo()))
3164826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      H.DoneProcessing();
316534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  } // TODO: handle other formats
3166ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek}
3167ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek
31687ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth//===--- CHECK: Standard memory functions ---------------------------------===//
31697ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth
31702a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// \brief Determine whether the given type is a dynamic class type (e.g.,
31712a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// whether it has a vtable).
31722a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregorstatic bool isDynamicClassType(QualType T) {
31732a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor  if (CXXRecordDecl *Record = T->getAsCXXRecordDecl())
31742a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor    if (CXXRecordDecl *Definition = Record->getDefinition())
31752a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor      if (Definition->isDynamicClass())
31762a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor        return true;
31772a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor
31782a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor  return false;
31792a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor}
31802a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor
3181a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument expression,
3182000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth/// otherwise returns NULL.
3183000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic const Expr *getSizeOfExprArg(const Expr* E) {
3184e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber  if (const UnaryExprOrTypeTraitExpr *SizeOf =
3185000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      dyn_cast<UnaryExprOrTypeTraitExpr>(E))
3186000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth    if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType())
3187000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      return SizeOf->getArgumentExpr()->IgnoreParenImpCasts();
3188e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber
3189000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  return 0;
3190000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth}
3191000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
3192a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument type.
3193000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic QualType getSizeOfArgType(const Expr* E) {
3194000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  if (const UnaryExprOrTypeTraitExpr *SizeOf =
3195000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      dyn_cast<UnaryExprOrTypeTraitExpr>(E))
3196000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth    if (SizeOf->getKind() == clang::UETT_SizeOf)
3197000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      return SizeOf->getTypeOfArgument();
3198000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
3199000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  return QualType();
3200e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber}
3201e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber
32027ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \brief Check for dangerous or invalid arguments to memset().
32037ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth///
3204929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth/// This issues warnings on known problematic, dangerous or unspecified
3205cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp'
3206cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// function calls.
32077ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth///
32087ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \param Call The call expression to diagnose.
3209cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gayvoid Sema::CheckMemaccessArguments(const CallExpr *Call,
32100a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks                                   unsigned BId,
3211cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay                                   IdentifierInfo *FnName) {
32120a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  assert(BId != 0);
32130a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks
32141d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek  // It is possible to have a non-standard definition of memset.  Validate
3215707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor  // we have enough arguments, and if not, abort further checking.
32160a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  unsigned ExpectedNumArgs = (BId == Builtin::BIstrndup ? 2 : 3);
3217cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber  if (Call->getNumArgs() < ExpectedNumArgs)
32181d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek    return;
32191d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek
32200a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  unsigned LastArg = (BId == Builtin::BImemset ||
32210a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks                      BId == Builtin::BIstrndup ? 1 : 2);
32220a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  unsigned LenArg = (BId == Builtin::BIstrndup ? 1 : 2);
3223cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber  const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts();
3224000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
3225000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  // We have special checking when the length is a sizeof expression.
3226000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  QualType SizeOfArgTy = getSizeOfArgType(LenExpr);
3227000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  const Expr *SizeOfArg = getSizeOfExprArg(LenExpr);
3228000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  llvm::FoldingSetNodeID SizeOfArgID;
3229000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
323006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor  for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) {
323106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor    const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts();
3232e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber    SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange();
323306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor
323406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor    QualType DestTy = Dest->getType();
323506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor    if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) {
323606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor      QualType PointeeTy = DestPtrTy->getPointeeType();
3237f85e193739c953358c865005855253af4f68a497John McCall
3238000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // Never warn about void type pointers. This can be used to suppress
3239000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // false positives.
3240000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      if (PointeeTy->isVoidType())
324106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor        continue;
324206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor
3243000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by
3244000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // actually comparing the expressions for equality. Because computing the
3245000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // expression IDs can be expensive, we only do this if the diagnostic is
3246000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // enabled.
3247000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      if (SizeOfArg &&
3248000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess,
3249000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                                   SizeOfArg->getExprLoc())) {
3250000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        // We only compute IDs for expressions if the warning is enabled, and
3251000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        // cache the sizeof arg's ID.
3252000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        if (SizeOfArgID == llvm::FoldingSetNodeID())
3253000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          SizeOfArg->Profile(SizeOfArgID, Context, true);
3254000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        llvm::FoldingSetNodeID DestID;
3255000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        Dest->Profile(DestID, Context, true);
3256000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        if (DestID == SizeOfArgID) {
3257cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber          // TODO: For strncpy() and friends, this could suggest sizeof(dst)
3258cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber          //       over sizeof(src) as well.
3259000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          unsigned ActionIdx = 0; // Default is to suggest dereferencing.
32606fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          StringRef ReadableName = FnName->getName();
32616fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks
3262000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest))
326390c78328e70cb376754edf87708505a84c044271Anna Zaks            if (UnaryOp->getOpcode() == UO_AddrOf)
3264000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth              ActionIdx = 1; // If its an address-of operator, just remove it.
32657adf4179f827b14b025135829dadeaa2442e1d42Fariborz Jahanian          if (!PointeeTy->isIncompleteType() &&
32667adf4179f827b14b025135829dadeaa2442e1d42Fariborz Jahanian              (Context.getTypeSize(PointeeTy) == Context.getCharWidth()))
3267000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth            ActionIdx = 2; // If the pointee's size is sizeof(char),
3268000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                           // suggest an explicit length.
32696fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks
32706fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          // If the function is defined as a builtin macro, do not show macro
32716fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          // expansion.
32726fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          SourceLocation SL = SizeOfArg->getExprLoc();
32736fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          SourceRange DSR = Dest->getSourceRange();
32746fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          SourceRange SSR = SizeOfArg->getSourceRange();
32756fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          SourceManager &SM  = PP.getSourceManager();
32766fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks
32776fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          if (SM.isMacroArgExpansion(SL)) {
32786fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks            ReadableName = Lexer::getImmediateMacroName(SL, SM, LangOpts);
32796fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks            SL = SM.getSpellingLoc(SL);
32806fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks            DSR = SourceRange(SM.getSpellingLoc(DSR.getBegin()),
32816fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks                             SM.getSpellingLoc(DSR.getEnd()));
32826fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks            SSR = SourceRange(SM.getSpellingLoc(SSR.getBegin()),
32836fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks                             SM.getSpellingLoc(SSR.getEnd()));
32846fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          }
32856fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks
328690c78328e70cb376754edf87708505a84c044271Anna Zaks          DiagRuntimeBehavior(SL, SizeOfArg,
3287000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                              PDiag(diag::warn_sizeof_pointer_expr_memaccess)
32886fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks                                << ReadableName
328990c78328e70cb376754edf87708505a84c044271Anna Zaks                                << PointeeTy
329090c78328e70cb376754edf87708505a84c044271Anna Zaks                                << DestTy
32916fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks                                << DSR
329290c78328e70cb376754edf87708505a84c044271Anna Zaks                                << SSR);
329390c78328e70cb376754edf87708505a84c044271Anna Zaks          DiagRuntimeBehavior(SL, SizeOfArg,
329490c78328e70cb376754edf87708505a84c044271Anna Zaks                         PDiag(diag::warn_sizeof_pointer_expr_memaccess_note)
329590c78328e70cb376754edf87708505a84c044271Anna Zaks                                << ActionIdx
329690c78328e70cb376754edf87708505a84c044271Anna Zaks                                << SSR);
329790c78328e70cb376754edf87708505a84c044271Anna Zaks
3298000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          break;
3299000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        }
3300000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      }
3301000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
3302000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // Also check for cases where the sizeof argument is the exact same
3303000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // type as the memory argument, and where it points to a user-defined
3304000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // record type.
3305000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      if (SizeOfArgTy != QualType()) {
3306000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        if (PointeeTy->isRecordType() &&
3307000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth            Context.typesAreCompatible(SizeOfArgTy, DestTy)) {
3308000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest,
3309000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                              PDiag(diag::warn_sizeof_pointer_type_memaccess)
3310000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                                << FnName << SizeOfArgTy << ArgIdx
3311000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                                << PointeeTy << Dest->getSourceRange()
3312000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                                << LenExpr->getSourceRange());
3313000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          break;
3314000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        }
3315e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber      }
3316e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber
331706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor      // Always complain about dynamic classes.
33180a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks      if (isDynamicClassType(PointeeTy)) {
33190a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks
33200a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        unsigned OperationType = 0;
33210a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        // "overwritten" if we're warning about the destination for any call
33220a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        // but memcmp; otherwise a verb appropriate to the call.
33230a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        if (ArgIdx != 0 || BId == Builtin::BImemcmp) {
33240a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks          if (BId == Builtin::BImemcpy)
33250a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            OperationType = 1;
33260a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks          else if(BId == Builtin::BImemmove)
33270a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            OperationType = 2;
33280a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks          else if (BId == Builtin::BImemcmp)
33290a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            OperationType = 3;
33300a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        }
33310a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks
33325c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay        DiagRuntimeBehavior(
33335c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay          Dest->getExprLoc(), Dest,
33345c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay          PDiag(diag::warn_dyn_class_memaccess)
33350a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx)
3336d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks            << FnName << PointeeTy
33370a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            << OperationType
33385c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay            << Call->getCallee()->getSourceRange());
33390a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks      } else if (PointeeTy.hasNonTrivialObjCLifetime() &&
33400a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks               BId != Builtin::BImemset)
33415c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay        DiagRuntimeBehavior(
33425c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay          Dest->getExprLoc(), Dest,
33435c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay          PDiag(diag::warn_arc_object_memaccess)
33445c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay            << ArgIdx << FnName << PointeeTy
33455c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay            << Call->getCallee()->getSourceRange());
3346f85e193739c953358c865005855253af4f68a497John McCall      else
334706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor        continue;
3348f85e193739c953358c865005855253af4f68a497John McCall
3349f85e193739c953358c865005855253af4f68a497John McCall      DiagRuntimeBehavior(
3350f85e193739c953358c865005855253af4f68a497John McCall        Dest->getExprLoc(), Dest,
3351929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth        PDiag(diag::note_bad_memaccess_silence)
335206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor          << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)"));
335306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor      break;
335406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor    }
33557ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth  }
33567ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth}
33577ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth
3358bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// A little helper routine: ignore addition and subtraction of integer literals.
3359bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// This intentionally does not ignore all integer constant expressions because
3360bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// we don't want to remove sizeof().
3361bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekstatic const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) {
3362bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  Ex = Ex->IgnoreParenCasts();
3363bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3364bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  for (;;) {
3365bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex);
3366bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    if (!BO || !BO->isAdditiveOp())
3367bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      break;
3368bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3369bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    const Expr *RHS = BO->getRHS()->IgnoreParenCasts();
3370bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    const Expr *LHS = BO->getLHS()->IgnoreParenCasts();
3371bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3372bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    if (isa<IntegerLiteral>(RHS))
3373bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      Ex = LHS;
3374bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    else if (isa<IntegerLiteral>(LHS))
3375bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      Ex = RHS;
3376bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    else
3377bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      break;
3378bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  }
3379bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3380bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  return Ex;
3381bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek}
3382bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
33830f38acee92014cb15af980808f87144e5564031dAnna Zaksstatic bool isConstantSizeArrayWithMoreThanOneElement(QualType Ty,
33840f38acee92014cb15af980808f87144e5564031dAnna Zaks                                                      ASTContext &Context) {
33850f38acee92014cb15af980808f87144e5564031dAnna Zaks  // Only handle constant-sized or VLAs, but not flexible members.
33860f38acee92014cb15af980808f87144e5564031dAnna Zaks  if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(Ty)) {
33870f38acee92014cb15af980808f87144e5564031dAnna Zaks    // Only issue the FIXIT for arrays of size > 1.
33880f38acee92014cb15af980808f87144e5564031dAnna Zaks    if (CAT->getSize().getSExtValue() <= 1)
33890f38acee92014cb15af980808f87144e5564031dAnna Zaks      return false;
33900f38acee92014cb15af980808f87144e5564031dAnna Zaks  } else if (!Ty->isVariableArrayType()) {
33910f38acee92014cb15af980808f87144e5564031dAnna Zaks    return false;
33920f38acee92014cb15af980808f87144e5564031dAnna Zaks  }
33930f38acee92014cb15af980808f87144e5564031dAnna Zaks  return true;
33940f38acee92014cb15af980808f87144e5564031dAnna Zaks}
33950f38acee92014cb15af980808f87144e5564031dAnna Zaks
3396bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// Warn if the user has made the 'size' argument to strlcpy or strlcat
3397bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// be the size of the source, instead of the destination.
3398bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekvoid Sema::CheckStrlcpycatArguments(const CallExpr *Call,
3399bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek                                    IdentifierInfo *FnName) {
3400bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3401bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // Don't crash if the user has the wrong number of arguments
3402bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (Call->getNumArgs() != 3)
3403bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    return;
3404bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3405bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context);
3406bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context);
3407bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *CompareWithSrc = NULL;
3408bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3409bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // Look for 'strlcpy(dst, x, sizeof(x))'
3410bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (const Expr *Ex = getSizeOfExprArg(SizeArg))
3411bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    CompareWithSrc = Ex;
3412bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  else {
3413bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    // Look for 'strlcpy(dst, x, strlen(x))'
3414bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) {
3415180f47959a066795cc0f409433023af448bb0328Richard Smith      if (SizeCall->isBuiltinCall() == Builtin::BIstrlen
3416bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek          && SizeCall->getNumArgs() == 1)
3417bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek        CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context);
3418bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    }
3419bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  }
3420bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3421bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (!CompareWithSrc)
3422bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    return;
3423bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3424bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // Determine if the argument to sizeof/strlen is equal to the source
3425bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // argument.  In principle there's all kinds of things you could do
3426bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // here, for instance creating an == expression and evaluating it with
3427bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // EvaluateAsBooleanCondition, but this uses a more direct technique:
3428bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg);
3429bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (!SrcArgDRE)
3430bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    return;
3431bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3432bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc);
3433bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (!CompareWithSrcDRE ||
3434bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl())
3435bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    return;
3436bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3437bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *OriginalSizeArg = Call->getArg(2);
3438bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size)
3439bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    << OriginalSizeArg->getSourceRange() << FnName;
3440bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3441bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // Output a FIXIT hint if the destination is an array (rather than a
3442bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // pointer to an array).  This could be enhanced to handle some
3443bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // pointers if we know the actual size, like if DstArg is 'array+2'
3444bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // we could say 'sizeof(array)-2'.
3445bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts();
34460f38acee92014cb15af980808f87144e5564031dAnna Zaks  if (!isConstantSizeArrayWithMoreThanOneElement(DstArg->getType(), Context))
34478f7462237ff542a4556775f98709ed300aa1731aTed Kremenek    return;
34488f7462237ff542a4556775f98709ed300aa1731aTed Kremenek
3449f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith  SmallString<128> sizeString;
34508f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  llvm::raw_svector_ostream OS(sizeString);
34518f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  OS << "sizeof(";
3452d1420c6fa788669e49f21e184927c7833881e399Richard Smith  DstArg->printPretty(OS, 0, getPrintingPolicy());
34538f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  OS << ")";
34548f7462237ff542a4556775f98709ed300aa1731aTed Kremenek
34558f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size)
34568f7462237ff542a4556775f98709ed300aa1731aTed Kremenek    << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(),
34578f7462237ff542a4556775f98709ed300aa1731aTed Kremenek                                    OS.str());
3458bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek}
3459bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3460c36bedc90c687caa71748480c60707ea4608b092Anna Zaks/// Check if two expressions refer to the same declaration.
3461c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic bool referToTheSameDecl(const Expr *E1, const Expr *E2) {
3462c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (const DeclRefExpr *D1 = dyn_cast_or_null<DeclRefExpr>(E1))
3463c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    if (const DeclRefExpr *D2 = dyn_cast_or_null<DeclRefExpr>(E2))
3464c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      return D1->getDecl() == D2->getDecl();
3465c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  return false;
3466c36bedc90c687caa71748480c60707ea4608b092Anna Zaks}
3467c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3468c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic const Expr *getStrlenExprArg(const Expr *E) {
3469c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (const CallExpr *CE = dyn_cast<CallExpr>(E)) {
3470c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    const FunctionDecl *FD = CE->getDirectCallee();
3471c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    if (!FD || FD->getMemoryFunctionKind() != Builtin::BIstrlen)
3472c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      return 0;
3473c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    return CE->getArg(0)->IgnoreParenCasts();
3474c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  }
3475c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  return 0;
3476c36bedc90c687caa71748480c60707ea4608b092Anna Zaks}
3477c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3478c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// Warn on anti-patterns as the 'size' argument to strncat.
3479c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// The correct size argument should look like following:
3480c36bedc90c687caa71748480c60707ea4608b092Anna Zaks//   strncat(dst, src, sizeof(dst) - strlen(dest) - 1);
3481c36bedc90c687caa71748480c60707ea4608b092Anna Zaksvoid Sema::CheckStrncatArguments(const CallExpr *CE,
3482c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                                 IdentifierInfo *FnName) {
3483c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  // Don't crash if the user has the wrong number of arguments.
3484c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (CE->getNumArgs() < 3)
3485c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    return;
3486c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  const Expr *DstArg = CE->getArg(0)->IgnoreParenCasts();
3487c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  const Expr *SrcArg = CE->getArg(1)->IgnoreParenCasts();
3488c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  const Expr *LenArg = CE->getArg(2)->IgnoreParenCasts();
3489c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3490c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  // Identify common expressions, which are wrongly used as the size argument
3491c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  // to strncat and may lead to buffer overflows.
3492c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  unsigned PatternType = 0;
3493c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (const Expr *SizeOfArg = getSizeOfExprArg(LenArg)) {
3494c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    // - sizeof(dst)
3495c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    if (referToTheSameDecl(SizeOfArg, DstArg))
3496c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      PatternType = 1;
3497c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    // - sizeof(src)
3498c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    else if (referToTheSameDecl(SizeOfArg, SrcArg))
3499c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      PatternType = 2;
3500c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  } else if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(LenArg)) {
3501c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    if (BE->getOpcode() == BO_Sub) {
3502c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      const Expr *L = BE->getLHS()->IgnoreParenCasts();
3503c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      const Expr *R = BE->getRHS()->IgnoreParenCasts();
3504c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      // - sizeof(dst) - strlen(dst)
3505c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      if (referToTheSameDecl(DstArg, getSizeOfExprArg(L)) &&
3506c36bedc90c687caa71748480c60707ea4608b092Anna Zaks          referToTheSameDecl(DstArg, getStrlenExprArg(R)))
3507c36bedc90c687caa71748480c60707ea4608b092Anna Zaks        PatternType = 1;
3508c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      // - sizeof(src) - (anything)
3509c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      else if (referToTheSameDecl(SrcArg, getSizeOfExprArg(L)))
3510c36bedc90c687caa71748480c60707ea4608b092Anna Zaks        PatternType = 2;
3511c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    }
3512c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  }
3513c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3514c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (PatternType == 0)
3515c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    return;
3516c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3517afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  // Generate the diagnostic.
3518afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  SourceLocation SL = LenArg->getLocStart();
3519afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  SourceRange SR = LenArg->getSourceRange();
3520afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  SourceManager &SM  = PP.getSourceManager();
3521afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks
3522afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  // If the function is defined as a builtin macro, do not show macro expansion.
3523afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  if (SM.isMacroArgExpansion(SL)) {
3524afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    SL = SM.getSpellingLoc(SL);
3525afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    SR = SourceRange(SM.getSpellingLoc(SR.getBegin()),
3526afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks                     SM.getSpellingLoc(SR.getEnd()));
3527afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  }
3528afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks
35290f38acee92014cb15af980808f87144e5564031dAnna Zaks  // Check if the destination is an array (rather than a pointer to an array).
35300f38acee92014cb15af980808f87144e5564031dAnna Zaks  QualType DstTy = DstArg->getType();
35310f38acee92014cb15af980808f87144e5564031dAnna Zaks  bool isKnownSizeArray = isConstantSizeArrayWithMoreThanOneElement(DstTy,
35320f38acee92014cb15af980808f87144e5564031dAnna Zaks                                                                    Context);
35330f38acee92014cb15af980808f87144e5564031dAnna Zaks  if (!isKnownSizeArray) {
35340f38acee92014cb15af980808f87144e5564031dAnna Zaks    if (PatternType == 1)
35350f38acee92014cb15af980808f87144e5564031dAnna Zaks      Diag(SL, diag::warn_strncat_wrong_size) << SR;
35360f38acee92014cb15af980808f87144e5564031dAnna Zaks    else
35370f38acee92014cb15af980808f87144e5564031dAnna Zaks      Diag(SL, diag::warn_strncat_src_size) << SR;
35380f38acee92014cb15af980808f87144e5564031dAnna Zaks    return;
35390f38acee92014cb15af980808f87144e5564031dAnna Zaks  }
35400f38acee92014cb15af980808f87144e5564031dAnna Zaks
3541c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (PatternType == 1)
3542afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    Diag(SL, diag::warn_strncat_large_size) << SR;
3543c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  else
3544afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    Diag(SL, diag::warn_strncat_src_size) << SR;
3545c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3546f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith  SmallString<128> sizeString;
3547c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  llvm::raw_svector_ostream OS(sizeString);
3548c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  OS << "sizeof(";
3549d1420c6fa788669e49f21e184927c7833881e399Richard Smith  DstArg->printPretty(OS, 0, getPrintingPolicy());
3550c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  OS << ") - ";
3551c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  OS << "strlen(";
3552d1420c6fa788669e49f21e184927c7833881e399Richard Smith  DstArg->printPretty(OS, 0, getPrintingPolicy());
3553c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  OS << ") - 1";
3554c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3555afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  Diag(SL, diag::note_strncat_wrong_size)
3556afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    << FixItHint::CreateReplacement(SR, OS.str());
3557c36bedc90c687caa71748480c60707ea4608b092Anna Zaks}
3558c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
355906de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===//
356006de276fff91264437fa75111ed76de43097e089Ted Kremenek
3561e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
3562e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                     Decl *ParentDecl);
3563e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars,
3564e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                      Decl *ParentDecl);
356506de276fff91264437fa75111ed76de43097e089Ted Kremenek
356606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address
356706de276fff91264437fa75111ed76de43097e089Ted Kremenek///   of a stack variable.
356806de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid
356906de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType,
357006de276fff91264437fa75111ed76de43097e089Ted Kremenek                           SourceLocation ReturnLoc) {
35711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
357226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  Expr *stackE = 0;
35735f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner  SmallVector<DeclRefExpr *, 8> refVars;
35744e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
357526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  // Perform checking for returned stack addresses, local blocks,
357626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  // label addresses or references to temporaries.
3577f85e193739c953358c865005855253af4f68a497John McCall  if (lhsType->isPointerType() ||
35784e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie      (!getLangOpts().ObjCAutoRefCount && lhsType->isBlockPointerType())) {
3579e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/0);
3580ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump  } else if (lhsType->isReferenceType()) {
3581e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    stackE = EvalVal(RetValExp, refVars, /*ParentDecl=*/0);
358226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  }
358326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
358426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  if (stackE == 0)
358526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    return; // Nothing suspicious was found.
358626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
358726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  SourceLocation diagLoc;
358826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  SourceRange diagRange;
358926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  if (refVars.empty()) {
359026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    diagLoc = stackE->getLocStart();
359126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    diagRange = stackE->getSourceRange();
359226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  } else {
359326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // We followed through a reference variable. 'stackE' contains the
359426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // problematic expression but we will warn at the return statement pointing
359526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // at the reference variable. We will later display the "trail" of
359626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // reference variables using notes.
359726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    diagLoc = refVars[0]->getLocStart();
359826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    diagRange = refVars[0]->getSourceRange();
359926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  }
360026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
360126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var.
360226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref
360326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis                                             : diag::warn_ret_stack_addr)
360426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis     << DR->getDecl()->getDeclName() << diagRange;
360526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  } else if (isa<BlockExpr>(stackE)) { // local block.
360626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(diagLoc, diag::err_ret_local_block) << diagRange;
360726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  } else if (isa<AddrLabelExpr>(stackE)) { // address of label.
360826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(diagLoc, diag::warn_ret_addr_label) << diagRange;
360926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  } else { // local temporary.
361026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref
361126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis                                             : diag::warn_ret_local_temp_addr)
361226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis     << diagRange;
361326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  }
361426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
361526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  // Display the "trail" of reference variables that we followed until we
361626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  // found the problematic expression using notes.
361726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  for (unsigned i = 0, e = refVars.size(); i != e; ++i) {
361826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl());
361926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // If this var binds to another reference var, show the range of the next
362026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // var, otherwise the var binds to the problematic expression, in which case
362126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // show the range of the expression.
362226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange()
362326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis                                  : stackE->getSourceRange();
362426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(VD->getLocation(), diag::note_ref_var_local_bind)
362526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      << VD->getDeclName() << range;
362606de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
362706de276fff91264437fa75111ed76de43097e089Ted Kremenek}
362806de276fff91264437fa75111ed76de43097e089Ted Kremenek
362906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that
363006de276fff91264437fa75111ed76de43097e089Ted Kremenek///  check if the expression in a return statement evaluates to an address
363126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  to a location on the stack, a local block, an address of a label, or a
363226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  reference to local temporary. The recursion is used to traverse the
363306de276fff91264437fa75111ed76de43097e089Ted Kremenek///  AST of the return expression, with recursion backtracking when we
363426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  encounter a subexpression that (1) clearly does not lead to one of the
363526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  above problematic expressions (2) is something we cannot determine leads to
363626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  a problematic expression based on such local checking.
363726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///
363826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  Both EvalAddr and EvalVal follow through reference variables to evaluate
363926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  the expression that they point to. Such variables are added to the
364026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  'refVars' vector so that we know what the reference variable "trail" was.
364106de276fff91264437fa75111ed76de43097e089Ted Kremenek///
3642e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek///  EvalAddr processes expressions that are pointers that are used as
3643e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek///  references (and not L-values).  EvalVal handles all other values.
364426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  At the base case of the recursion is a check for the above problematic
364526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  expressions.
364606de276fff91264437fa75111ed76de43097e089Ted Kremenek///
364706de276fff91264437fa75111ed76de43097e089Ted Kremenek///  This implementation handles:
364806de276fff91264437fa75111ed76de43097e089Ted Kremenek///
364906de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * pointer-to-pointer casts
365006de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * implicit conversions from array references to pointers
365106de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * taking the address of fields
365206de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * arbitrary interplay between "&" and "*" operators
365306de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * pointer arithmetic from an address of a stack variable
365406de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * taking the address of an array element where the array is on the stack
3655e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
3656e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                      Decl *ParentDecl) {
365726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  if (E->isTypeDependent())
365826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      return NULL;
365926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
366006de276fff91264437fa75111ed76de43097e089Ted Kremenek  // We should only be called for evaluating pointer expressions.
36610f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall  assert((E->getType()->isAnyPointerType() ||
3662dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff          E->getType()->isBlockPointerType() ||
3663a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek          E->getType()->isObjCQualifiedIdType()) &&
3664fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner         "EvalAddr only works on pointers");
36651eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3666f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne  E = E->IgnoreParens();
3667f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne
366806de276fff91264437fa75111ed76de43097e089Ted Kremenek  // Our "symbolic interpreter" is just a dispatch off the currently
366906de276fff91264437fa75111ed76de43097e089Ted Kremenek  // viewed AST node.  We then recursively traverse the AST by calling
367006de276fff91264437fa75111ed76de43097e089Ted Kremenek  // EvalAddr and EvalVal appropriately.
367106de276fff91264437fa75111ed76de43097e089Ted Kremenek  switch (E->getStmtClass()) {
367226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  case Stmt::DeclRefExprClass: {
367326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    DeclRefExpr *DR = cast<DeclRefExpr>(E);
367426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
367526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
367626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      // If this is a reference variable, follow through to the expression that
367726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      // it points to.
367826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      if (V->hasLocalStorage() &&
367926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis          V->getType()->isReferenceType() && V->hasInit()) {
368026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        // Add the reference variable to the "trail".
368126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        refVars.push_back(DR);
3682e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis        return EvalAddr(V->getInit(), refVars, ParentDecl);
368326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      }
368426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
368526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    return NULL;
368626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  }
368706de276fff91264437fa75111ed76de43097e089Ted Kremenek
3688fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  case Stmt::UnaryOperatorClass: {
3689fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // The only unary operator that make sense to handle here
3690fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // is AddrOf.  All others don't make sense as pointers.
3691fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    UnaryOperator *U = cast<UnaryOperator>(E);
36921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
36932de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    if (U->getOpcode() == UO_AddrOf)
3694e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      return EvalVal(U->getSubExpr(), refVars, ParentDecl);
3695fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    else
3696fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner      return NULL;
3697fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  }
36981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3699fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  case Stmt::BinaryOperatorClass: {
3700fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // Handle pointer arithmetic.  All other binary operators are not valid
3701fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // in this context.
3702fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    BinaryOperator *B = cast<BinaryOperator>(E);
37032de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    BinaryOperatorKind op = B->getOpcode();
37041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
37052de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    if (op != BO_Add && op != BO_Sub)
3706fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner      return NULL;
37071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3708fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    Expr *Base = B->getLHS();
37093907323dd6665c0c4e383435cb145233f4533406Anders Carlsson
3710fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // Determine which argument is the real pointer base.  It could be
3711fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // the RHS argument instead of the LHS.
3712fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    if (!Base->getType()->isPointerType()) Base = B->getRHS();
37131eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3714fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    assert (Base->getType()->isPointerType());
3715e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalAddr(Base, refVars, ParentDecl);
3716fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  }
371761f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff
3718fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  // For conditional operators we need to see if either the LHS or RHS are
3719fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  // valid DeclRefExpr*s.  If one of them is valid, we return it.
3720fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  case Stmt::ConditionalOperatorClass: {
3721fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    ConditionalOperator *C = cast<ConditionalOperator>(E);
37221eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3723fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // Handle the GNU extension for missing LHS.
37249ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    if (Expr *lhsExpr = C->getLHS()) {
37259ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    // In C++, we can have a throw-expression, which has 'void' type.
37269ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor      if (!lhsExpr->getType()->isVoidType())
3727e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis        if (Expr* LHS = EvalAddr(lhsExpr, refVars, ParentDecl))
37289ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor          return LHS;
37299ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    }
37309ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor
37319ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    // In C++, we can have a throw-expression, which has 'void' type.
37329ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    if (C->getRHS()->getType()->isVoidType())
37339ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor      return NULL;
373406de276fff91264437fa75111ed76de43097e089Ted Kremenek
3735e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalAddr(C->getRHS(), refVars, ParentDecl);
3736fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  }
373726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
373826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  case Stmt::BlockExprClass:
3739469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall    if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures())
374026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      return E; // local block.
374126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    return NULL;
374226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
374326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  case Stmt::AddrLabelExprClass:
374426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    return E; // address of label.
37451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
374680ee6e878a169e6255d4686a91bb696151ff229fJohn McCall  case Stmt::ExprWithCleanupsClass:
3747e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,
3748e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                    ParentDecl);
374980ee6e878a169e6255d4686a91bb696151ff229fJohn McCall
375054b5274f2c190331438375ad114dad12ae098b57Ted Kremenek  // For casts, we need to handle conversions from arrays to
375154b5274f2c190331438375ad114dad12ae098b57Ted Kremenek  // pointer values, and pointer-to-pointer conversions.
375249badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor  case Stmt::ImplicitCastExprClass:
37536eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor  case Stmt::CStyleCastExprClass:
3754f85e193739c953358c865005855253af4f68a497John McCall  case Stmt::CXXFunctionalCastExprClass:
37558b9414e868853fc052251455674bf7512261e14aEli Friedman  case Stmt::ObjCBridgedCastExprClass:
37561eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  case Stmt::CXXStaticCastExprClass:
37571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  case Stmt::CXXDynamicCastExprClass:
375849badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor  case Stmt::CXXConstCastExprClass:
375949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor  case Stmt::CXXReinterpretCastExprClass: {
37608b9414e868853fc052251455674bf7512261e14aEli Friedman    Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
37618b9414e868853fc052251455674bf7512261e14aEli Friedman    switch (cast<CastExpr>(E)->getCastKind()) {
37628b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_BitCast:
37638b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_LValueToRValue:
37648b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_NoOp:
37658b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_BaseToDerived:
37668b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_DerivedToBase:
37678b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_UncheckedDerivedToBase:
37688b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_Dynamic:
37698b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_CPointerToObjCPointerCast:
37708b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_BlockPointerToObjCPointerCast:
37718b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_AnyPointerToBlockPointerCast:
3772e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      return EvalAddr(SubExpr, refVars, ParentDecl);
37738b9414e868853fc052251455674bf7512261e14aEli Friedman
37748b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_ArrayToPointerDecay:
3775e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      return EvalVal(SubExpr, refVars, ParentDecl);
37768b9414e868853fc052251455674bf7512261e14aEli Friedman
37778b9414e868853fc052251455674bf7512261e14aEli Friedman    default:
37788b9414e868853fc052251455674bf7512261e14aEli Friedman      return 0;
37798b9414e868853fc052251455674bf7512261e14aEli Friedman    }
3780fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  }
37811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
378203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor  case Stmt::MaterializeTemporaryExprClass:
378303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor    if (Expr *Result = EvalAddr(
378403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor                         cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(),
3785e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                                refVars, ParentDecl))
378603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor      return Result;
378703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor
378803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor    return E;
378903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor
3790fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  // Everything else: we simply don't reason about them.
3791fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  default:
3792fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    return NULL;
379306de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
379406de276fff91264437fa75111ed76de43097e089Ted Kremenek}
37951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
379606de276fff91264437fa75111ed76de43097e089Ted Kremenek
379706de276fff91264437fa75111ed76de43097e089Ted Kremenek///  EvalVal - This function is complements EvalAddr in the mutual recursion.
379806de276fff91264437fa75111ed76de43097e089Ted Kremenek///   See the comments for EvalAddr for more details.
3799e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
3800e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                     Decl *ParentDecl) {
380168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo {
3802e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek  // We should only be called for evaluating non-pointer expressions, or
3803e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek  // expressions with a pointer type that are not used as references but instead
3804e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek  // are l-values (e.g., DeclRefExpr with a pointer type).
38051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
380606de276fff91264437fa75111ed76de43097e089Ted Kremenek  // Our "symbolic interpreter" is just a dispatch off the currently
380706de276fff91264437fa75111ed76de43097e089Ted Kremenek  // viewed AST node.  We then recursively traverse the AST by calling
380806de276fff91264437fa75111ed76de43097e089Ted Kremenek  // EvalAddr and EvalVal appropriately.
3809f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne
3810f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne  E = E->IgnoreParens();
381106de276fff91264437fa75111ed76de43097e089Ted Kremenek  switch (E->getStmtClass()) {
381268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek  case Stmt::ImplicitCastExprClass: {
381368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek    ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E);
38145baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall    if (IE->getValueKind() == VK_LValue) {
381568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek      E = IE->getSubExpr();
381668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek      continue;
381768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek    }
381868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek    return NULL;
381968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek  }
382068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek
382180ee6e878a169e6255d4686a91bb696151ff229fJohn McCall  case Stmt::ExprWithCleanupsClass:
3822e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,ParentDecl);
382380ee6e878a169e6255d4686a91bb696151ff229fJohn McCall
3824a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor  case Stmt::DeclRefExprClass: {
382526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // When we hit a DeclRefExpr we are looking at code that refers to a
382626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // variable's name. If it's not a reference variable we check if it has
382726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // local storage within the function, and if so, return the expression.
382806de276fff91264437fa75111ed76de43097e089Ted Kremenek    DeclRefExpr *DR = cast<DeclRefExpr>(E);
38291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3830e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) {
3831e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      // Check if it refers to itself, e.g. "int& i = i;".
3832e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      if (V == ParentDecl)
3833e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis        return DR;
3834e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis
383526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      if (V->hasLocalStorage()) {
383626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        if (!V->getType()->isReferenceType())
383726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis          return DR;
383826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
383926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        // Reference variable, follow through to the expression that
384026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        // it points to.
384126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        if (V->hasInit()) {
384226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis          // Add the reference variable to the "trail".
384326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis          refVars.push_back(DR);
3844e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis          return EvalVal(V->getInit(), refVars, V);
384526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        }
384626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      }
3847e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    }
38481eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
384906de276fff91264437fa75111ed76de43097e089Ted Kremenek    return NULL;
385006de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
38511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
385206de276fff91264437fa75111ed76de43097e089Ted Kremenek  case Stmt::UnaryOperatorClass: {
385306de276fff91264437fa75111ed76de43097e089Ted Kremenek    // The only unary operator that make sense to handle here
385406de276fff91264437fa75111ed76de43097e089Ted Kremenek    // is Deref.  All others don't resolve to a "name."  This includes
385506de276fff91264437fa75111ed76de43097e089Ted Kremenek    // handling all sorts of rvalues passed to a unary operator.
385606de276fff91264437fa75111ed76de43097e089Ted Kremenek    UnaryOperator *U = cast<UnaryOperator>(E);
38571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
38582de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    if (U->getOpcode() == UO_Deref)
3859e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      return EvalAddr(U->getSubExpr(), refVars, ParentDecl);
386006de276fff91264437fa75111ed76de43097e089Ted Kremenek
386106de276fff91264437fa75111ed76de43097e089Ted Kremenek    return NULL;
386206de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
38631eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
386406de276fff91264437fa75111ed76de43097e089Ted Kremenek  case Stmt::ArraySubscriptExprClass: {
386506de276fff91264437fa75111ed76de43097e089Ted Kremenek    // Array subscripts are potential references to data on the stack.  We
386606de276fff91264437fa75111ed76de43097e089Ted Kremenek    // retrieve the DeclRefExpr* for the array variable if it indeed
386706de276fff91264437fa75111ed76de43097e089Ted Kremenek    // has local storage.
3868e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars,ParentDecl);
386906de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
38701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
387106de276fff91264437fa75111ed76de43097e089Ted Kremenek  case Stmt::ConditionalOperatorClass: {
387206de276fff91264437fa75111ed76de43097e089Ted Kremenek    // For conditional operators we need to see if either the LHS or RHS are
387326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // non-NULL Expr's.  If one is non-NULL, we return it.
387406de276fff91264437fa75111ed76de43097e089Ted Kremenek    ConditionalOperator *C = cast<ConditionalOperator>(E);
387506de276fff91264437fa75111ed76de43097e089Ted Kremenek
38763907323dd6665c0c4e383435cb145233f4533406Anders Carlsson    // Handle the GNU extension for missing LHS.
38773907323dd6665c0c4e383435cb145233f4533406Anders Carlsson    if (Expr *lhsExpr = C->getLHS())
3878e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      if (Expr *LHS = EvalVal(lhsExpr, refVars, ParentDecl))
38793907323dd6665c0c4e383435cb145233f4533406Anders Carlsson        return LHS;
38803907323dd6665c0c4e383435cb145233f4533406Anders Carlsson
3881e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalVal(C->getRHS(), refVars, ParentDecl);
388206de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
38831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
388406de276fff91264437fa75111ed76de43097e089Ted Kremenek  // Accesses to members are potential references to data on the stack.
388583f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor  case Stmt::MemberExprClass: {
388606de276fff91264437fa75111ed76de43097e089Ted Kremenek    MemberExpr *M = cast<MemberExpr>(E);
38871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
388806de276fff91264437fa75111ed76de43097e089Ted Kremenek    // Check for indirect access.  We only want direct field accesses.
3889a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek    if (M->isArrow())
3890a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek      return NULL;
3891a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek
3892a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek    // Check whether the member type is itself a reference, in which case
3893a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek    // we're not going to refer to the member, but to what the member refers to.
3894a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek    if (M->getMemberDecl()->getType()->isReferenceType())
389506de276fff91264437fa75111ed76de43097e089Ted Kremenek      return NULL;
3896a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek
3897e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalVal(M->getBase(), refVars, ParentDecl);
389806de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
38991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
390003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor  case Stmt::MaterializeTemporaryExprClass:
390103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor    if (Expr *Result = EvalVal(
390203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor                          cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(),
3903e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                               refVars, ParentDecl))
390403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor      return Result;
390503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor
390603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor    return E;
390703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor
390806de276fff91264437fa75111ed76de43097e089Ted Kremenek  default:
390926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // Check that we don't return or take the address of a reference to a
391026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // temporary. This is only useful in C++.
391126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    if (!E->isTypeDependent() && E->isRValue())
391226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      return E;
391326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
391426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // Everything else: we simply don't reason about them.
391506de276fff91264437fa75111ed76de43097e089Ted Kremenek    return NULL;
391606de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
391768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true);
391806de276fff91264437fa75111ed76de43097e089Ted Kremenek}
3919588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek
3920588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===//
3921588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek
3922588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==.
3923588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely
3924588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended.
3925dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieuvoid Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) {
3926dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts();
3927dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  Expr* RightExprSansParen = RHS->IgnoreParenImpCasts();
3928588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek
3929588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  // Special case: check for x == x (which is OK).
3930588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  // Do not emit warnings for such cases.
3931588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen))
3932588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek    if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen))
3933588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek      if (DRL->getDecl() == DRR->getDecl())
3934980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie        return;
39351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
39361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
39371b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  // Special case: check for comparisons against literals that can be exactly
39381b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  //  represented by APFloat.  In such cases, do not emit a warning.  This
39391b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  //  is a heuristic: often comparison against such literals are used to
39401b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  //  detect if a value in a variable has not changed.  This clearly can
39411b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  //  lead to false negatives.
3942980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) {
3943980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    if (FLL->isExact())
3944980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie      return;
3945980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  } else
3946980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen))
3947980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie      if (FLR->isExact())
3948980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie        return;
39491eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3950588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  // Check for comparisons with builtin types.
3951980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen))
3952980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    if (CL->isBuiltinCall())
3953980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie      return;
39541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3955980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen))
3956980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    if (CR->isBuiltinCall())
3957980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie      return;
39581eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3959588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  // Emit the diagnostic.
3960980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  Diag(Loc, diag::warn_floatingpoint_eq)
3961980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    << LHS->getSourceRange() << RHS->getSourceRange();
3962588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek}
3963ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
3964f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===//
3965f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===//
3966ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
3967f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace {
3968ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
3969f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued
3970f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression.
3971f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange {
3972f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  /// The number of bits active in the int.
3973f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  unsigned Width;
3974ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
3975f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  /// True if the int is known not to have negative values.
3976f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  bool NonNegative;
397751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3978f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  IntRange(unsigned Width, bool NonNegative)
3979f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    : Width(Width), NonNegative(NonNegative)
3980f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  {}
398151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
39821844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the range of the bool type.
3983f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  static IntRange forBoolType() {
3984f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(1, true);
3985f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  }
398651313c39c84407dd6a323be99a8c322bf8d052a9John McCall
39871844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the range of an opaque value of the given integral type.
39881844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  static IntRange forValueOfType(ASTContext &C, QualType T) {
39891844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    return forValueOfCanonicalType(C,
39901844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall                          T->getCanonicalTypeInternal().getTypePtr());
399151313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
399251313c39c84407dd6a323be99a8c322bf8d052a9John McCall
39931844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the range of an opaque value of a canonical integral type.
39941844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) {
3995f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    assert(T->isCanonicalUnqualified());
399651313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3997f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    if (const VectorType *VT = dyn_cast<VectorType>(T))
3998f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      T = VT->getElementType().getTypePtr();
3999f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    if (const ComplexType *CT = dyn_cast<ComplexType>(T))
4000f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      T = CT->getElementType().getTypePtr();
4001323ed74658bc8375278eabf074b4777458376540John McCall
4002091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    // For enum types, use the known bit width of the enumerators.
4003323ed74658bc8375278eabf074b4777458376540John McCall    if (const EnumType *ET = dyn_cast<EnumType>(T)) {
4004323ed74658bc8375278eabf074b4777458376540John McCall      EnumDecl *Enum = ET->getDecl();
40055e1cdac63c3d9c9b32fa41fa0b2d242a58a20d49John McCall      if (!Enum->isCompleteDefinition())
4006091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall        return IntRange(C.getIntWidth(QualType(T, 0)), false);
4007091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall
4008323ed74658bc8375278eabf074b4777458376540John McCall      unsigned NumPositive = Enum->getNumPositiveBits();
4009323ed74658bc8375278eabf074b4777458376540John McCall      unsigned NumNegative = Enum->getNumNegativeBits();
4010323ed74658bc8375278eabf074b4777458376540John McCall
40118f50b24c8b17368f68c2e71240d487dde53f6da8Richard Trieu      if (NumNegative == 0)
40128f50b24c8b17368f68c2e71240d487dde53f6da8Richard Trieu        return IntRange(NumPositive, true/*NonNegative*/);
40138f50b24c8b17368f68c2e71240d487dde53f6da8Richard Trieu      else
40148f50b24c8b17368f68c2e71240d487dde53f6da8Richard Trieu        return IntRange(std::max(NumPositive + 1, NumNegative),
40158f50b24c8b17368f68c2e71240d487dde53f6da8Richard Trieu                        false/*NonNegative*/);
4016323ed74658bc8375278eabf074b4777458376540John McCall    }
401751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4018f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    const BuiltinType *BT = cast<BuiltinType>(T);
4019f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    assert(BT->isInteger());
402051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4021f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
402251313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
402351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
40241844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the "target" range of a canonical integral type, i.e.
40251844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// the range of values expressible in the type.
40261844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  ///
40271844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// This matches forValueOfCanonicalType except that enums have the
40281844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// full range of their type, not the range of their enumerators.
40291844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) {
40301844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    assert(T->isCanonicalUnqualified());
40311844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall
40321844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    if (const VectorType *VT = dyn_cast<VectorType>(T))
40331844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      T = VT->getElementType().getTypePtr();
40341844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    if (const ComplexType *CT = dyn_cast<ComplexType>(T))
40351844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      T = CT->getElementType().getTypePtr();
40361844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    if (const EnumType *ET = dyn_cast<EnumType>(T))
403769ff26bd1e7a2faffec0c3b9740cfb0c6bb354c5Douglas Gregor      T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr();
40381844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall
40391844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    const BuiltinType *BT = cast<BuiltinType>(T);
40401844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    assert(BT->isInteger());
40411844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall
40421844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
40431844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  }
40441844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall
40451844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the supremum of two ranges: i.e. their conservative merge.
4046c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall  static IntRange join(IntRange L, IntRange R) {
4047f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(std::max(L.Width, R.Width),
404860fad45739b764886f707bd204eae9ecce6db1f2John McCall                    L.NonNegative && R.NonNegative);
404960fad45739b764886f707bd204eae9ecce6db1f2John McCall  }
405060fad45739b764886f707bd204eae9ecce6db1f2John McCall
40511844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the infinum of two ranges: i.e. their aggressive merge.
4052c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall  static IntRange meet(IntRange L, IntRange R) {
405360fad45739b764886f707bd204eae9ecce6db1f2John McCall    return IntRange(std::min(L.Width, R.Width),
405460fad45739b764886f707bd204eae9ecce6db1f2John McCall                    L.NonNegative || R.NonNegative);
405551313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
4056f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall};
405751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
40580692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, llvm::APSInt &value,
40590692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                              unsigned MaxWidth) {
4060f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (value.isSigned() && value.isNegative())
4061f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(value.getMinSignedBits(), false);
406251313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4063f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (value.getBitWidth() > MaxWidth)
40649f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad    value = value.trunc(MaxWidth);
406551313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4066f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // isNonNegative() just checks the sign bit without considering
4067f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // signedness.
4068f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  return IntRange(value.getActiveBits(), true);
406951313c39c84407dd6a323be99a8c322bf8d052a9John McCall}
407051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
40710692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty,
40720692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                              unsigned MaxWidth) {
4073f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (result.isInt())
4074f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return GetValueRange(C, result.getInt(), MaxWidth);
407551313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4076f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (result.isVector()) {
40770acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall    IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth);
40780acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall    for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) {
40790acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall      IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth);
40800acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall      R = IntRange::join(R, El);
40810acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall    }
4082f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return R;
408351313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
408451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4085f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (result.isComplexInt()) {
4086f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth);
4087f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth);
4088f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange::join(R, I);
4089f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  }
4090f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4091f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // This can happen with lossless casts to intptr_t of "based" lvalues.
4092f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // Assume it might use arbitrary bits.
40930acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall  // FIXME: The only reason we need to pass the type in here is to get
40940acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall  // the sign right on this one case.  It would be nice if APValue
40950acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall  // preserved this.
409665639284118d54ddf2e51a05d2ffccda567fe246Eli Friedman  assert(result.isLValue() || result.isAddrLabelDiff());
40975e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor  return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType());
409851313c39c84407dd6a323be99a8c322bf8d052a9John McCall}
409951313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4100f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the
4101f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take.
4102f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall///
4103f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated
41040692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) {
410551313c39c84407dd6a323be99a8c322bf8d052a9John McCall  E = E->IgnoreParens();
410651313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4107f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // Try a full evaluation first.
4108f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  Expr::EvalResult result;
410951f4708c00110940ca3f337961915f2ca1668375Richard Smith  if (E->EvaluateAsRValue(result, C))
41100acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall    return GetValueRange(C, result.Val, E->getType(), MaxWidth);
411151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4112f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // I think we only want to look through implicit casts here; if the
4113f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // user has an explicit widening cast, we should treat the value as
4114f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // being of the new, wider type.
4115f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) {
4116b17ee5bff0d7986c14cdddb279e0131bd7f9678dEli Friedman    if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue)
4117f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return GetExprRange(C, CE->getSubExpr(), MaxWidth);
411851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
41191844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType());
412051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
41212de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast);
412260fad45739b764886f707bd204eae9ecce6db1f2John McCall
4123f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Assume that non-integer casts can span the full range of the type.
412460fad45739b764886f707bd204eae9ecce6db1f2John McCall    if (!isIntegerCast)
4125f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return OutputTypeRange;
412651313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4127f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange SubRange
4128f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      = GetExprRange(C, CE->getSubExpr(),
4129f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall                     std::min(MaxWidth, OutputTypeRange.Width));
413051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4131f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Bail out if the subexpr's range is as wide as the cast type.
4132f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    if (SubRange.Width >= OutputTypeRange.Width)
4133f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return OutputTypeRange;
413451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4135f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Otherwise, we take the smaller width, and we're non-negative if
4136f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // either the output type or the subexpr is.
4137f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(SubRange.Width,
4138f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall                    SubRange.NonNegative || OutputTypeRange.NonNegative);
4139f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  }
4140f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4141f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
4142f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // If we can fold the condition, just take that operand.
4143f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    bool CondResult;
4144f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C))
4145f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return GetExprRange(C, CondResult ? CO->getTrueExpr()
4146f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall                                        : CO->getFalseExpr(),
4147f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall                          MaxWidth);
4148f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4149f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Otherwise, conservatively merge.
4150f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth);
4151f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth);
4152f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange::join(L, R);
415351313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
415451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
415551313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
415651313c39c84407dd6a323be99a8c322bf8d052a9John McCall    switch (BO->getOpcode()) {
415751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4158f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Boolean-valued operations are single-bit and positive.
41592de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_LAnd:
41602de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_LOr:
41612de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_LT:
41622de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_GT:
41632de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_LE:
41642de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_GE:
41652de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_EQ:
41662de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_NE:
4167f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return IntRange::forBoolType();
416851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4169862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    // The type of the assignments is the type of the LHS, so the RHS
4170862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    // is not necessarily the same type.
41712de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_MulAssign:
41722de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_DivAssign:
41732de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_RemAssign:
41742de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_AddAssign:
41752de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_SubAssign:
4176862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    case BO_XorAssign:
4177862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    case BO_OrAssign:
4178862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall      // TODO: bitfields?
41791844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      return IntRange::forValueOfType(C, E->getType());
4180c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall
4181862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    // Simple assignments just pass through the RHS, which will have
4182862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    // been coerced to the LHS type.
4183862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    case BO_Assign:
4184862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall      // TODO: bitfields?
4185862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall      return GetExprRange(C, BO->getRHS(), MaxWidth);
4186862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall
418751313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // Operations with opaque sources are black-listed.
41882de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_PtrMemD:
41892de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_PtrMemI:
41901844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      return IntRange::forValueOfType(C, E->getType());
419151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
419260fad45739b764886f707bd204eae9ecce6db1f2John McCall    // Bitwise-and uses the *infinum* of the two source ranges.
41932de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_And:
41942de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_AndAssign:
419560fad45739b764886f707bd204eae9ecce6db1f2John McCall      return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth),
419660fad45739b764886f707bd204eae9ecce6db1f2John McCall                            GetExprRange(C, BO->getRHS(), MaxWidth));
419760fad45739b764886f707bd204eae9ecce6db1f2John McCall
419851313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // Left shift gets black-listed based on a judgement call.
41992de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_Shl:
42003aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      // ...except that we want to treat '1 << (blah)' as logically
42013aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      // positive.  It's an important idiom.
42023aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      if (IntegerLiteral *I
42033aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall            = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) {
42043aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall        if (I->getValue() == 1) {
42051844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall          IntRange R = IntRange::forValueOfType(C, E->getType());
42063aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall          return IntRange(R.Width, /*NonNegative*/ true);
42073aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall        }
42083aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      }
42093aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      // fallthrough
42103aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall
42112de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_ShlAssign:
42121844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      return IntRange::forValueOfType(C, E->getType());
421351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
421460fad45739b764886f707bd204eae9ecce6db1f2John McCall    // Right shift by a constant can narrow its left argument.
42152de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_Shr:
42162de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_ShrAssign: {
421760fad45739b764886f707bd204eae9ecce6db1f2John McCall      IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
421860fad45739b764886f707bd204eae9ecce6db1f2John McCall
421960fad45739b764886f707bd204eae9ecce6db1f2John McCall      // If the shift amount is a positive constant, drop the width by
422060fad45739b764886f707bd204eae9ecce6db1f2John McCall      // that much.
422160fad45739b764886f707bd204eae9ecce6db1f2John McCall      llvm::APSInt shift;
422260fad45739b764886f707bd204eae9ecce6db1f2John McCall      if (BO->getRHS()->isIntegerConstantExpr(shift, C) &&
422360fad45739b764886f707bd204eae9ecce6db1f2John McCall          shift.isNonNegative()) {
422460fad45739b764886f707bd204eae9ecce6db1f2John McCall        unsigned zext = shift.getZExtValue();
422560fad45739b764886f707bd204eae9ecce6db1f2John McCall        if (zext >= L.Width)
422660fad45739b764886f707bd204eae9ecce6db1f2John McCall          L.Width = (L.NonNegative ? 0 : 1);
422760fad45739b764886f707bd204eae9ecce6db1f2John McCall        else
422860fad45739b764886f707bd204eae9ecce6db1f2John McCall          L.Width -= zext;
422960fad45739b764886f707bd204eae9ecce6db1f2John McCall      }
423060fad45739b764886f707bd204eae9ecce6db1f2John McCall
423160fad45739b764886f707bd204eae9ecce6db1f2John McCall      return L;
423260fad45739b764886f707bd204eae9ecce6db1f2John McCall    }
423360fad45739b764886f707bd204eae9ecce6db1f2John McCall
423460fad45739b764886f707bd204eae9ecce6db1f2John McCall    // Comma acts as its right operand.
42352de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_Comma:
4236f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return GetExprRange(C, BO->getRHS(), MaxWidth);
4237f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
423860fad45739b764886f707bd204eae9ecce6db1f2John McCall    // Black-list pointer subtractions.
42392de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_Sub:
424051313c39c84407dd6a323be99a8c322bf8d052a9John McCall      if (BO->getLHS()->getType()->isPointerType())
42411844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall        return IntRange::forValueOfType(C, E->getType());
424200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      break;
424300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
424400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // The width of a division result is mostly determined by the size
424500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // of the LHS.
424600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Div: {
424700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      // Don't 'pre-truncate' the operands.
424800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      unsigned opWidth = C.getIntWidth(E->getType());
424900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange L = GetExprRange(C, BO->getLHS(), opWidth);
425000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
425100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      // If the divisor is constant, use that.
425200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      llvm::APSInt divisor;
425300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) {
425400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall        unsigned log2 = divisor.logBase2(); // floor(log_2(divisor))
425500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall        if (log2 >= L.Width)
425600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall          L.Width = (L.NonNegative ? 0 : 1);
425700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall        else
425800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall          L.Width = std::min(L.Width - log2, MaxWidth);
425900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall        return L;
426000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      }
426100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
426200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      // Otherwise, just use the LHS's width.
426300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange R = GetExprRange(C, BO->getRHS(), opWidth);
426400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      return IntRange(L.Width, L.NonNegative && R.NonNegative);
426500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    }
426600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
426700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // The result of a remainder can't be larger than the result of
426800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // either side.
426900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Rem: {
427000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      // Don't 'pre-truncate' the operands.
427100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      unsigned opWidth = C.getIntWidth(E->getType());
427200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange L = GetExprRange(C, BO->getLHS(), opWidth);
427300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange R = GetExprRange(C, BO->getRHS(), opWidth);
427400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
427500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange meet = IntRange::meet(L, R);
427600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      meet.Width = std::min(meet.Width, MaxWidth);
427700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      return meet;
427800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    }
42794e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
428000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // The default behavior is okay for these.
428100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Mul:
428200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Add:
428300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Xor:
428400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Or:
4285f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      break;
428651313c39c84407dd6a323be99a8c322bf8d052a9John McCall    }
4287f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
428800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // The default case is to treat the operation as if it were closed
428900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // on the narrowest type that encompasses both operands.
4290f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
4291f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth);
4292f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange::join(L, R);
429351313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
429451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
429551313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
429651313c39c84407dd6a323be99a8c322bf8d052a9John McCall    switch (UO->getOpcode()) {
429751313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // Boolean-valued operations are white-listed.
42982de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case UO_LNot:
4299f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return IntRange::forBoolType();
430051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
430151313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // Operations with opaque sources are black-listed.
43022de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case UO_Deref:
43032de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case UO_AddrOf: // should be impossible
43041844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      return IntRange::forValueOfType(C, E->getType());
430551313c39c84407dd6a323be99a8c322bf8d052a9John McCall
430651313c39c84407dd6a323be99a8c322bf8d052a9John McCall    default:
4307f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return GetExprRange(C, UO->getSubExpr(), MaxWidth);
430851313c39c84407dd6a323be99a8c322bf8d052a9John McCall    }
430951313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
43108ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor
43118ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor  if (dyn_cast<OffsetOfExpr>(E)) {
43121844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    IntRange::forValueOfType(C, E->getType());
43138ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor  }
431451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4315a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith  if (FieldDecl *BitField = E->getBitField())
4316a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith    return IntRange(BitField->getBitWidthValue(C),
43175e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor                    BitField->getType()->isUnsignedIntegerOrEnumerationType());
4318f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
43191844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  return IntRange::forValueOfType(C, E->getType());
4320f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}
4321f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
43220692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E) {
4323323ed74658bc8375278eabf074b4777458376540John McCall  return GetExprRange(C, E, C.getIntWidth(E->getType()));
4324323ed74658bc8375278eabf074b4777458376540John McCall}
4325323ed74658bc8375278eabf074b4777458376540John McCall
4326f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given
4327f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the
4328f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics.
43290692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const llvm::APFloat &value,
43300692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                 const llvm::fltSemantics &Src,
43310692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                 const llvm::fltSemantics &Tgt) {
4332f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  llvm::APFloat truncated = value;
4333f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4334f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  bool ignored;
4335f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored);
4336f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored);
4337f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4338f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  return truncated.bitwiseIsEqual(value);
433951313c39c84407dd6a323be99a8c322bf8d052a9John McCall}
434051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4341f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given
4342f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the
4343f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics.
4344f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall///
4345f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number).
43460692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const APValue &value,
43470692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                 const llvm::fltSemantics &Src,
43480692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                 const llvm::fltSemantics &Tgt) {
4349f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (value.isFloat())
4350f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IsSameFloatAfterCast(value.getFloat(), Src, Tgt);
4351f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4352f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (value.isVector()) {
4353f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i)
4354f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt))
4355f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall        return false;
4356f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return true;
4357f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  }
4358f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4359f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  assert(value.isComplexFloat());
4360f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) &&
4361f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall          IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt));
4362f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}
4363f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
43640692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC);
4365323ed74658bc8375278eabf074b4777458376540John McCall
4366e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) {
4367e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek  // Suppress cases where we are comparing against an enum constant.
4368e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek  if (const DeclRefExpr *DR =
4369e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek      dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts()))
4370e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek    if (isa<EnumConstantDecl>(DR->getDecl()))
4371e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek      return false;
4372e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek
4373e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek  // Suppress cases where the '0' value is expanded from a macro.
4374e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek  if (E->getLocStart().isMacroID())
4375e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek    return false;
4376e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek
4377323ed74658bc8375278eabf074b4777458376540John McCall  llvm::APSInt Value;
4378323ed74658bc8375278eabf074b4777458376540John McCall  return E->isIntegerConstantExpr(Value, S.Context) && Value == 0;
4379323ed74658bc8375278eabf074b4777458376540John McCall}
4380323ed74658bc8375278eabf074b4777458376540John McCall
4381372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) {
4382372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall  // Strip off implicit integral promotions.
4383372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall  while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) {
438463b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis    if (ICE->getCastKind() != CK_IntegralCast &&
438563b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis        ICE->getCastKind() != CK_NoOp)
4386372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      break;
438763b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis    E = ICE->getSubExpr();
4388372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall  }
4389372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall
4390372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall  return E->getType()->isEnumeralType();
4391372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall}
4392372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall
43930692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) {
43942de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  BinaryOperatorKind op = E->getOpcode();
439514af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor  if (E->isValueDependent())
439614af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor    return;
439714af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor
43982de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  if (op == BO_LT && IsZero(S, E->getRHS())) {
4399323ed74658bc8375278eabf074b4777458376540John McCall    S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
4400372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      << "< 0" << "false" << HasEnumType(E->getLHS())
4401323ed74658bc8375278eabf074b4777458376540John McCall      << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
44022de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  } else if (op == BO_GE && IsZero(S, E->getRHS())) {
4403323ed74658bc8375278eabf074b4777458376540John McCall    S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
4404372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      << ">= 0" << "true" << HasEnumType(E->getLHS())
4405323ed74658bc8375278eabf074b4777458376540John McCall      << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
44062de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  } else if (op == BO_GT && IsZero(S, E->getLHS())) {
4407323ed74658bc8375278eabf074b4777458376540John McCall    S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
4408372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      << "0 >" << "false" << HasEnumType(E->getRHS())
4409323ed74658bc8375278eabf074b4777458376540John McCall      << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
44102de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  } else if (op == BO_LE && IsZero(S, E->getLHS())) {
4411323ed74658bc8375278eabf074b4777458376540John McCall    S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
4412372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      << "0 <=" << "true" << HasEnumType(E->getRHS())
4413323ed74658bc8375278eabf074b4777458376540John McCall      << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
4414323ed74658bc8375278eabf074b4777458376540John McCall  }
4415323ed74658bc8375278eabf074b4777458376540John McCall}
4416323ed74658bc8375278eabf074b4777458376540John McCall
441715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanianstatic void DiagnoseOutOfRangeComparison(Sema &S, BinaryOperator *E,
4418a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian                                         Expr *Constant, Expr *Other,
441915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian                                         llvm::APSInt Value,
4420a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian                                         bool RhsConstant) {
4421526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu  // 0 values are handled later by CheckTrivialUnsignedComparison().
4422526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu  if (Value == 0)
4423526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu    return;
4424526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu
442515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  BinaryOperatorKind op = E->getOpcode();
4426a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  QualType OtherT = Other->getType();
4427a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  QualType ConstantT = Constant->getType();
4428526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu  QualType CommonT = E->getLHS()->getType();
4429a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  if (S.Context.hasSameUnqualifiedType(OtherT, ConstantT))
443015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    return;
4431a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  assert((OtherT->isIntegerType() && ConstantT->isIntegerType())
443215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian         && "comparison with non-integer type");
4433526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu
4434526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu  bool ConstantSigned = ConstantT->isSignedIntegerType();
4435526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu  bool CommonSigned = CommonT->isSignedIntegerType();
4436526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu
4437526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu  bool EqualityOnly = false;
4438526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu
4439526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu  // TODO: Investigate using GetExprRange() to get tighter bounds on
4440526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu  // on the bit ranges.
444115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  IntRange OtherRange = IntRange::forValueOfType(S.Context, OtherT);
4442526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu  unsigned OtherWidth = OtherRange.Width;
4443526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu
4444526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu  if (CommonSigned) {
4445526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu    // The common type is signed, therefore no signed to unsigned conversion.
4446d87de7bdbc25dd84ae3dbefffda4539c443000d2Eli Friedman    if (!OtherRange.NonNegative) {
4447526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      // Check that the constant is representable in type OtherT.
4448526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      if (ConstantSigned) {
4449526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu        if (OtherWidth >= Value.getMinSignedBits())
4450526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu          return;
4451526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      } else { // !ConstantSigned
4452526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu        if (OtherWidth >= Value.getActiveBits() + 1)
4453526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu          return;
4454526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      }
4455526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu    } else { // !OtherSigned
4456526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      // Check that the constant is representable in type OtherT.
4457526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      // Negative values are out of range.
4458526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      if (ConstantSigned) {
4459526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu        if (Value.isNonNegative() && OtherWidth >= Value.getActiveBits())
4460526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu          return;
4461526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      } else { // !ConstantSigned
4462526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu        if (OtherWidth >= Value.getActiveBits())
4463526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu          return;
4464526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      }
4465526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu    }
4466526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu  } else {  // !CommonSigned
4467d87de7bdbc25dd84ae3dbefffda4539c443000d2Eli Friedman    if (OtherRange.NonNegative) {
4468526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      if (OtherWidth >= Value.getActiveBits())
4469526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu        return;
4470d87de7bdbc25dd84ae3dbefffda4539c443000d2Eli Friedman    } else if (!OtherRange.NonNegative && !ConstantSigned) {
4471526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      // Check to see if the constant is representable in OtherT.
4472526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      if (OtherWidth > Value.getActiveBits())
4473526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu        return;
4474526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      // Check to see if the constant is equivalent to a negative value
4475526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      // cast to CommonT.
4476526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      if (S.Context.getIntWidth(ConstantT) == S.Context.getIntWidth(CommonT) &&
44775d1cf4f292cb060b1973eb197607fc6d5716bd12Richard Trieu          Value.isNegative() && Value.getMinSignedBits() <= OtherWidth)
4478526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu        return;
4479526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      // The constant value rests between values that OtherT can represent after
4480526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      // conversion.  Relational comparison still works, but equality
4481526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      // comparisons will be tautological.
4482526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      EqualityOnly = true;
4483526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu    } else { // OtherSigned && ConstantSigned
4484526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      assert(0 && "Two signed types converted to unsigned types.");
4485526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu    }
4486526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu  }
4487526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu
4488526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu  bool PositiveConstant = !ConstantSigned || Value.isNonNegative();
4489526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu
449015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  bool IsTrue = true;
4491526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu  if (op == BO_EQ || op == BO_NE) {
4492526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu    IsTrue = op == BO_NE;
4493526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu  } else if (EqualityOnly) {
4494526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu    return;
4495526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu  } else if (RhsConstant) {
449615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    if (op == BO_GT || op == BO_GE)
4497526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      IsTrue = !PositiveConstant;
449815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    else // op == BO_LT || op == BO_LE
4499526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      IsTrue = PositiveConstant;
4500a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  } else {
450115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    if (op == BO_LT || op == BO_LE)
4502526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      IsTrue = !PositiveConstant;
450315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    else // op == BO_GT || op == BO_GE
4504526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      IsTrue = PositiveConstant;
450515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  }
45067adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek
45077adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek  // If this is a comparison to an enum constant, include that
45087adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek  // constant in the diagnostic.
45097adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek  const EnumConstantDecl *ED = 0;
45107adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek  if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Constant))
45117adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek    ED = dyn_cast<EnumConstantDecl>(DR->getDecl());
45127adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek
45137adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek  SmallString<64> PrettySourceValue;
45147adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek  llvm::raw_svector_ostream OS(PrettySourceValue);
45157adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek  if (ED)
45169de50947ba381561a5236b3c878c83e4bb8c1088Ted Kremenek    OS << '\'' << *ED << "' (" << Value << ")";
45177adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek  else
45187adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek    OS << Value;
45197adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek
4520a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  S.Diag(E->getOperatorLoc(), diag::warn_out_of_range_compare)
45217adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek      << OS.str() << OtherT << IsTrue
4522526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu      << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
452315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian}
452415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian
4525323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison.  Implements the
4526323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison.
45270692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) {
4528b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc());
4529b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc());
4530323ed74658bc8375278eabf074b4777458376540John McCall}
4531f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4532ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare.
4533ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall///
4534dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu/// \param E the binary operator to check for warnings
45350692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeComparison(Sema &S, BinaryOperator *E) {
4536323ed74658bc8375278eabf074b4777458376540John McCall  // The type the comparison is being performed in.
4537323ed74658bc8375278eabf074b4777458376540John McCall  QualType T = E->getLHS()->getType();
4538323ed74658bc8375278eabf074b4777458376540John McCall  assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType())
4539323ed74658bc8375278eabf074b4777458376540John McCall         && "comparison with mismatched types");
4540ab4702febef82409773f7c80ec02d53ddbb4d80eFariborz Jahanian  if (E->isValueDependent())
4541ab4702febef82409773f7c80ec02d53ddbb4d80eFariborz Jahanian    return AnalyzeImpConvsInComparison(S, E);
4542323ed74658bc8375278eabf074b4777458376540John McCall
454315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  Expr *LHS = E->getLHS()->IgnoreParenImpCasts();
454415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  Expr *RHS = E->getRHS()->IgnoreParenImpCasts();
454515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian
454615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  bool IsComparisonConstant = false;
454715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian
4548a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  // Check whether an integer constant comparison results in a value
454915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  // of 'true' or 'false'.
455015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  if (T->isIntegralType(S.Context)) {
455115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    llvm::APSInt RHSValue;
455215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    bool IsRHSIntegralLiteral =
455315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian      RHS->isIntegerConstantExpr(RHSValue, S.Context);
455415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    llvm::APSInt LHSValue;
455515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    bool IsLHSIntegralLiteral =
455615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian      LHS->isIntegerConstantExpr(LHSValue, S.Context);
455715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    if (IsRHSIntegralLiteral && !IsLHSIntegralLiteral)
455815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian        DiagnoseOutOfRangeComparison(S, E, RHS, LHS, RHSValue, true);
455915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    else if (!IsRHSIntegralLiteral && IsLHSIntegralLiteral)
456015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian      DiagnoseOutOfRangeComparison(S, E, LHS, RHS, LHSValue, false);
456115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    else
456215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian      IsComparisonConstant =
456315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian        (IsRHSIntegralLiteral && IsLHSIntegralLiteral);
4564a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  } else if (!T->hasUnsignedIntegerRepresentation())
4565a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian      IsComparisonConstant = E->isIntegerConstantExpr(S.Context);
456615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian
4567323ed74658bc8375278eabf074b4777458376540John McCall  // We don't do anything special if this isn't an unsigned integral
4568323ed74658bc8375278eabf074b4777458376540John McCall  // comparison:  we're only interested in integral comparisons, and
4569323ed74658bc8375278eabf074b4777458376540John McCall  // signed comparisons only happen in cases we don't care to warn about.
45703e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor  //
45713e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor  // We also don't care about value-dependent expressions or expressions
45723e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor  // whose result is a constant.
457315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  if (!T->hasUnsignedIntegerRepresentation() || IsComparisonConstant)
4574323ed74658bc8375278eabf074b4777458376540John McCall    return AnalyzeImpConvsInComparison(S, E);
457515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian
4576323ed74658bc8375278eabf074b4777458376540John McCall  // Check to see if one of the (unmodified) operands is of different
4577323ed74658bc8375278eabf074b4777458376540John McCall  // signedness.
4578323ed74658bc8375278eabf074b4777458376540John McCall  Expr *signedOperand, *unsignedOperand;
4579dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  if (LHS->getType()->hasSignedIntegerRepresentation()) {
4580dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    assert(!RHS->getType()->hasSignedIntegerRepresentation() &&
4581323ed74658bc8375278eabf074b4777458376540John McCall           "unsigned comparison between two signed integer expressions?");
4582dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    signedOperand = LHS;
4583dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    unsignedOperand = RHS;
4584dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  } else if (RHS->getType()->hasSignedIntegerRepresentation()) {
4585dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    signedOperand = RHS;
4586dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    unsignedOperand = LHS;
4587ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  } else {
4588323ed74658bc8375278eabf074b4777458376540John McCall    CheckTrivialUnsignedComparison(S, E);
4589323ed74658bc8375278eabf074b4777458376540John McCall    return AnalyzeImpConvsInComparison(S, E);
4590ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  }
4591ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
4592323ed74658bc8375278eabf074b4777458376540John McCall  // Otherwise, calculate the effective range of the signed operand.
4593323ed74658bc8375278eabf074b4777458376540John McCall  IntRange signedRange = GetExprRange(S.Context, signedOperand);
4594f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4595323ed74658bc8375278eabf074b4777458376540John McCall  // Go ahead and analyze implicit conversions in the operands.  Note
4596323ed74658bc8375278eabf074b4777458376540John McCall  // that we skip the implicit conversions on both sides.
4597dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc());
4598dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc());
4599ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
4600323ed74658bc8375278eabf074b4777458376540John McCall  // If the signed range is non-negative, -Wsign-compare won't fire,
4601323ed74658bc8375278eabf074b4777458376540John McCall  // but we should still check for comparisons which are always true
4602323ed74658bc8375278eabf074b4777458376540John McCall  // or false.
4603323ed74658bc8375278eabf074b4777458376540John McCall  if (signedRange.NonNegative)
4604323ed74658bc8375278eabf074b4777458376540John McCall    return CheckTrivialUnsignedComparison(S, E);
4605ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
4606ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  // For (in)equality comparisons, if the unsigned operand is a
4607ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  // constant which cannot collide with a overflowed signed operand,
4608ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  // then reinterpreting the signed operand as unsigned will not
4609ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  // change the result of the comparison.
4610323ed74658bc8375278eabf074b4777458376540John McCall  if (E->isEqualityOp()) {
4611323ed74658bc8375278eabf074b4777458376540John McCall    unsigned comparisonWidth = S.Context.getIntWidth(T);
4612323ed74658bc8375278eabf074b4777458376540John McCall    IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand);
4613323ed74658bc8375278eabf074b4777458376540John McCall
4614323ed74658bc8375278eabf074b4777458376540John McCall    // We should never be unable to prove that the unsigned operand is
4615323ed74658bc8375278eabf074b4777458376540John McCall    // non-negative.
4616323ed74658bc8375278eabf074b4777458376540John McCall    assert(unsignedRange.NonNegative && "unsigned range includes negative?");
4617ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
4618323ed74658bc8375278eabf074b4777458376540John McCall    if (unsignedRange.Width < comparisonWidth)
4619323ed74658bc8375278eabf074b4777458376540John McCall      return;
4620323ed74658bc8375278eabf074b4777458376540John McCall  }
4621323ed74658bc8375278eabf074b4777458376540John McCall
46226d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor  S.DiagRuntimeBehavior(E->getOperatorLoc(), E,
46236d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor    S.PDiag(diag::warn_mixed_sign_comparison)
46246d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor      << LHS->getType() << RHS->getType()
46256d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor      << LHS->getSourceRange() << RHS->getSourceRange());
4626ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall}
4627ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
462815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield.
462915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall///
463015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt.
46310692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init,
46320692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                      SourceLocation InitLoc) {
463315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  assert(Bitfield->isBitField());
463415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  if (Bitfield->isInvalidDecl())
463515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    return false;
463615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
463791b6014876e9186f968f74a8975ab8fc08ef1b68John McCall  // White-list bool bitfields.
463891b6014876e9186f968f74a8975ab8fc08ef1b68John McCall  if (Bitfield->getType()->isBooleanType())
463991b6014876e9186f968f74a8975ab8fc08ef1b68John McCall    return false;
464091b6014876e9186f968f74a8975ab8fc08ef1b68John McCall
464146ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor  // Ignore value- or type-dependent expressions.
464246ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor  if (Bitfield->getBitWidth()->isValueDependent() ||
464346ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor      Bitfield->getBitWidth()->isTypeDependent() ||
464446ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor      Init->isValueDependent() ||
464546ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor      Init->isTypeDependent())
464646ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor    return false;
464746ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor
464815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  Expr *OriginalInit = Init->IgnoreParenImpCasts();
464915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
465080d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith  llvm::APSInt Value;
465180d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith  if (!OriginalInit->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects))
465215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    return false;
465315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
465415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  unsigned OriginalWidth = Value.getBitWidth();
4655a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith  unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context);
465615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
465715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  if (OriginalWidth <= FieldWidth)
465815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    return false;
465915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
46603a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  // Compute the value which the bitfield will contain.
46619f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad  llvm::APSInt TruncatedValue = Value.trunc(FieldWidth);
46623a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  TruncatedValue.setIsSigned(Bitfield->getType()->isSignedIntegerType());
466315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
46643a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  // Check whether the stored value is equal to the original value.
46653a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  TruncatedValue = TruncatedValue.extend(OriginalWidth);
4666e1ecdc168175719d74e112bcacd4aae5e12d4631Richard Trieu  if (llvm::APSInt::isSameValue(Value, TruncatedValue))
466715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    return false;
466815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
46693a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  // Special-case bitfields of width 1: booleans are naturally 0/1, and
467034ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman  // therefore don't strictly fit into a signed bitfield of width 1.
467134ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman  if (FieldWidth == 1 && Value == 1)
46723a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman    return false;
46733a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman
467415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  std::string PrettyValue = Value.toString(10);
467515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  std::string PrettyTrunc = TruncatedValue.toString(10);
467615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
467715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant)
467815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    << PrettyValue << PrettyTrunc << OriginalInit->getType()
467915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    << Init->getSourceRange();
468015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
468115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  return true;
468215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall}
468315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
4684beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy
4685beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations.
46860692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeAssignment(Sema &S, BinaryOperator *E) {
4687beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  // Just recurse on the LHS.
4688beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc());
4689beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall
4690beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  // We want to recurse on the RHS as normal unless we're assigning to
4691beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  // a bitfield.
4692beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  if (FieldDecl *Bitfield = E->getLHS()->getBitField()) {
4693dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov    if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(),
469415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall                                  E->getOperatorLoc())) {
469515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall      // Recurse, ignoring any implicit conversions on the RHS.
469615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall      return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(),
469715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall                                        E->getOperatorLoc());
4698beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall    }
4699beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  }
4700beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall
4701beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc());
4702beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall}
4703beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall
470451313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast;  purely a helper for CheckImplicitConversion.
47050692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T,
4706c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            SourceLocation CContext, unsigned diag,
4707c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            bool pruneControlFlow = false) {
4708c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (pruneControlFlow) {
4709c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    S.DiagRuntimeBehavior(E->getExprLoc(), E,
4710c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                          S.PDiag(diag)
4711c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            << SourceType << T << E->getSourceRange()
4712c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            << SourceRange(CContext));
4713c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    return;
4714c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  }
47155a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  S.Diag(E->getExprLoc(), diag)
47165a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor    << SourceType << T << E->getSourceRange() << SourceRange(CContext);
47175a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor}
47185a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor
4719e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast;  purely a helper for CheckImplicitConversion.
47200692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType T,
4721c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            SourceLocation CContext, unsigned diag,
4722c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            bool pruneControlFlow = false) {
4723c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow);
4724e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth}
4725e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth
47269ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// Diagnose an implicit cast from a literal expression. Does not warn when the
47279ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// cast wouldn't lose information.
4728f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruthvoid DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T,
4729f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth                                    SourceLocation CContext) {
47309ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay  // Try to convert the literal exactly to an integer. If we can, don't warn.
4731f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth  bool isExact = false;
47329ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay  const llvm::APFloat &Value = FL->getValue();
47333e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin  llvm::APSInt IntegerValue(S.Context.getIntWidth(T),
47343e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin                            T->hasUnsignedIntegerRepresentation());
47353e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin  if (Value.convertToInteger(IntegerValue,
4736f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth                             llvm::APFloat::rmTowardZero, &isExact)
47379ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay      == llvm::APFloat::opOK && isExact)
4738f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth    return;
4739f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth
4740be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  SmallString<16> PrettySourceValue;
4741be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  Value.toString(PrettySourceValue);
4742de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie  SmallString<16> PrettyTargetValue;
4743be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  if (T->isSpecificBuiltinType(BuiltinType::Bool))
4744be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    PrettyTargetValue = IntegerValue == 0 ? "false" : "true";
4745be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  else
4746de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie    IntegerValue.toString(PrettyTargetValue);
4747be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie
47489ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay  S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer)
4749be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    << FL->getType() << T.getUnqualifiedType() << PrettySourceValue
4750be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    << PrettyTargetValue << FL->getSourceRange() << SourceRange(CContext);
4751f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth}
4752f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth
4753091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) {
4754091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall  if (!Range.Width) return "0";
4755091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall
4756091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall  llvm::APSInt ValueInRange = Value;
4757091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall  ValueInRange.setIsSigned(!Range.NonNegative);
47589f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad  ValueInRange = ValueInRange.trunc(Range.Width);
4759091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall  return ValueInRange.toString(10);
4760091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall}
4761091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall
476288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgstatic bool IsImplicitBoolFloatConversion(Sema &S, Expr *Ex, bool ToBool) {
476388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  if (!isa<ImplicitCastExpr>(Ex))
476488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    return false;
476588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
476688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  Expr *InnerE = Ex->IgnoreParenImpCasts();
476788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  const Type *Target = S.Context.getCanonicalType(Ex->getType()).getTypePtr();
476888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  const Type *Source =
476988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    S.Context.getCanonicalType(InnerE->getType()).getTypePtr();
477088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  if (Target->isDependentType())
477188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    return false;
477288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
477388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  const BuiltinType *FloatCandidateBT =
477488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    dyn_cast<BuiltinType>(ToBool ? Source : Target);
477588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  const Type *BoolCandidateType = ToBool ? Target : Source;
477688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
477788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  return (BoolCandidateType->isSpecificBuiltinType(BuiltinType::Bool) &&
477888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg          FloatCandidateBT && (FloatCandidateBT->isFloatingPoint()));
477988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg}
478088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
478188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgvoid CheckImplicitArgumentConversions(Sema &S, CallExpr *TheCall,
478288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg                                      SourceLocation CC) {
478388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  unsigned NumArgs = TheCall->getNumArgs();
478488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  for (unsigned i = 0; i < NumArgs; ++i) {
478588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    Expr *CurrA = TheCall->getArg(i);
478688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    if (!IsImplicitBoolFloatConversion(S, CurrA, true))
478788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      continue;
478888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
478988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    bool IsSwapped = ((i > 0) &&
479088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        IsImplicitBoolFloatConversion(S, TheCall->getArg(i - 1), false));
479188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    IsSwapped |= ((i < (NumArgs - 1)) &&
479288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        IsImplicitBoolFloatConversion(S, TheCall->getArg(i + 1), false));
479388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    if (IsSwapped) {
479488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      // Warn on this floating-point to bool conversion.
479588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      DiagnoseImpCast(S, CurrA->IgnoreParenImpCasts(),
479688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg                      CurrA->getType(), CC,
479788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg                      diag::warn_impcast_floating_point_to_bool);
479888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    }
479988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  }
480088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg}
480188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
4802323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T,
4803dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov                             SourceLocation CC, bool *ICContext = 0) {
4804323ed74658bc8375278eabf074b4777458376540John McCall  if (E->isTypeDependent() || E->isValueDependent()) return;
480551313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4806323ed74658bc8375278eabf074b4777458376540John McCall  const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr();
4807323ed74658bc8375278eabf074b4777458376540John McCall  const Type *Target = S.Context.getCanonicalType(T).getTypePtr();
4808323ed74658bc8375278eabf074b4777458376540John McCall  if (Source == Target) return;
4809323ed74658bc8375278eabf074b4777458376540John McCall  if (Target->isDependentType()) return;
481051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4811108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // If the conversion context location is invalid don't complain. We also
4812108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // don't want to emit a warning if the issue occurs from the expansion of
4813108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // a system macro. The problem is that 'getSpellingLoc()' is slow, so we
4814108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // delay this check as long as possible. Once we detect we are in that
4815108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // scenario, we just return.
4816ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek  if (CC.isInvalid())
4817b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return;
4818b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall
4819f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  // Diagnose implicit casts to bool.
4820f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  if (Target->isSpecificBuiltinType(BuiltinType::Bool)) {
4821f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu    if (isa<StringLiteral>(E))
4822f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      // Warn on string literal to bool.  Checks for string literals in logical
4823f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      // expressions, for instances, assert(0 && "error here"), is prevented
4824f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      // by a check in AnalyzeImplicitConversions().
4825f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      return DiagnoseImpCast(S, E, T, CC,
4826f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu                             diag::warn_impcast_string_literal_to_bool);
4827e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames    if (Source->isFunctionType()) {
4828e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      // Warn on function to bool. Checks free functions and static member
4829e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      // functions. Weakly imported functions are excluded from the check,
4830e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      // since it's common to test their value to check whether the linker
4831e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      // found a definition for them.
4832e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      ValueDecl *D = 0;
4833e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      if (DeclRefExpr* R = dyn_cast<DeclRefExpr>(E)) {
4834e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames        D = R->getDecl();
4835e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) {
4836e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames        D = M->getMemberDecl();
4837e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      }
4838e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames
4839e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      if (D && !D->isWeak()) {
484026b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu        if (FunctionDecl* F = dyn_cast<FunctionDecl>(D)) {
484126b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu          S.Diag(E->getExprLoc(), diag::warn_impcast_function_to_bool)
484226b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu            << F << E->getSourceRange() << SourceRange(CC);
48432def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          S.Diag(E->getExprLoc(), diag::note_function_to_bool_silence)
48442def77399ab3088106a2d61372344f5b7104e1a2David Blaikie            << FixItHint::CreateInsertion(E->getExprLoc(), "&");
48452def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          QualType ReturnType;
48462def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          UnresolvedSet<4> NonTemplateOverloads;
48472def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          S.isExprCallable(*E, ReturnType, NonTemplateOverloads);
48482def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          if (!ReturnType.isNull()
48492def77399ab3088106a2d61372344f5b7104e1a2David Blaikie              && ReturnType->isSpecificBuiltinType(BuiltinType::Bool))
48502def77399ab3088106a2d61372344f5b7104e1a2David Blaikie            S.Diag(E->getExprLoc(), diag::note_function_to_bool_call)
48512def77399ab3088106a2d61372344f5b7104e1a2David Blaikie              << FixItHint::CreateInsertion(
48522def77399ab3088106a2d61372344f5b7104e1a2David Blaikie                 S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()), "()");
485326b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu          return;
485426b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu        }
4855e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      }
4856e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames    }
4857f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  }
485851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
485951313c39c84407dd6a323be99a8c322bf8d052a9John McCall  // Strip vector types.
486051313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (isa<VectorType>(Source)) {
4861ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    if (!isa<VectorType>(Target)) {
4862d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay      if (S.SourceMgr.isInSystemMacro(CC))
4863ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek        return;
4864b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall      return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar);
4865ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    }
4866b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner
4867b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner    // If the vector cast is cast between two vectors of the same size, it is
4868b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner    // a bitcast, not a conversion.
4869b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner    if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target))
4870b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner      return;
487151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
487251313c39c84407dd6a323be99a8c322bf8d052a9John McCall    Source = cast<VectorType>(Source)->getElementType().getTypePtr();
487351313c39c84407dd6a323be99a8c322bf8d052a9John McCall    Target = cast<VectorType>(Target)->getElementType().getTypePtr();
487451313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
487551313c39c84407dd6a323be99a8c322bf8d052a9John McCall
487651313c39c84407dd6a323be99a8c322bf8d052a9John McCall  // Strip complex types.
487751313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (isa<ComplexType>(Source)) {
4878ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    if (!isa<ComplexType>(Target)) {
4879d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay      if (S.SourceMgr.isInSystemMacro(CC))
4880ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek        return;
4881ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4882b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall      return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar);
4883ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    }
488451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
488551313c39c84407dd6a323be99a8c322bf8d052a9John McCall    Source = cast<ComplexType>(Source)->getElementType().getTypePtr();
488651313c39c84407dd6a323be99a8c322bf8d052a9John McCall    Target = cast<ComplexType>(Target)->getElementType().getTypePtr();
488751313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
488851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
488951313c39c84407dd6a323be99a8c322bf8d052a9John McCall  const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source);
489051313c39c84407dd6a323be99a8c322bf8d052a9John McCall  const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target);
489151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
489251313c39c84407dd6a323be99a8c322bf8d052a9John McCall  // If the source is floating point...
489351313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (SourceBT && SourceBT->isFloatingPoint()) {
489451313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // ...and the target is floating point...
489551313c39c84407dd6a323be99a8c322bf8d052a9John McCall    if (TargetBT && TargetBT->isFloatingPoint()) {
489651313c39c84407dd6a323be99a8c322bf8d052a9John McCall      // ...then warn if we're dropping FP rank.
489751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
489851313c39c84407dd6a323be99a8c322bf8d052a9John McCall      // Builtin FP kinds are ordered by increasing FP rank.
489951313c39c84407dd6a323be99a8c322bf8d052a9John McCall      if (SourceBT->getKind() > TargetBT->getKind()) {
490051313c39c84407dd6a323be99a8c322bf8d052a9John McCall        // Don't warn about float constants that are precisely
490151313c39c84407dd6a323be99a8c322bf8d052a9John McCall        // representable in the target type.
490251313c39c84407dd6a323be99a8c322bf8d052a9John McCall        Expr::EvalResult result;
490351f4708c00110940ca3f337961915f2ca1668375Richard Smith        if (E->EvaluateAsRValue(result, S.Context)) {
490451313c39c84407dd6a323be99a8c322bf8d052a9John McCall          // Value might be a float, a float vector, or a float complex.
490551313c39c84407dd6a323be99a8c322bf8d052a9John McCall          if (IsSameFloatAfterCast(result.Val,
4906323ed74658bc8375278eabf074b4777458376540John McCall                   S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)),
4907323ed74658bc8375278eabf074b4777458376540John McCall                   S.Context.getFloatTypeSemantics(QualType(SourceBT, 0))))
490851313c39c84407dd6a323be99a8c322bf8d052a9John McCall            return;
490951313c39c84407dd6a323be99a8c322bf8d052a9John McCall        }
491051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4911d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay        if (S.SourceMgr.isInSystemMacro(CC))
4912ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek          return;
4913ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4914b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall        DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision);
491551313c39c84407dd6a323be99a8c322bf8d052a9John McCall      }
491651313c39c84407dd6a323be99a8c322bf8d052a9John McCall      return;
491751313c39c84407dd6a323be99a8c322bf8d052a9John McCall    }
491851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4919ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    // If the target is integral, always warn.
4920be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    if (TargetBT && TargetBT->isInteger()) {
4921d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay      if (S.SourceMgr.isInSystemMacro(CC))
4922ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek        return;
4923ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4924a5b9332418f25338f118358e27303cd510d54107Chandler Carruth      Expr *InnerE = E->IgnoreParenImpCasts();
4925634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay      // We also want to warn on, e.g., "int i = -1.234"
4926634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay      if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE))
4927634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay        if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus)
4928634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay          InnerE = UOp->getSubExpr()->IgnoreParenImpCasts();
4929634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay
4930f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth      if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) {
4931f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth        DiagnoseFloatingLiteralImpCast(S, FL, T, CC);
4932a5b9332418f25338f118358e27303cd510d54107Chandler Carruth      } else {
4933a5b9332418f25338f118358e27303cd510d54107Chandler Carruth        DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer);
4934a5b9332418f25338f118358e27303cd510d54107Chandler Carruth      }
4935a5b9332418f25338f118358e27303cd510d54107Chandler Carruth    }
493651313c39c84407dd6a323be99a8c322bf8d052a9John McCall
493788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    // If the target is bool, warn if expr is a function or method call.
493888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    if (Target->isSpecificBuiltinType(BuiltinType::Bool) &&
493988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        isa<CallExpr>(E)) {
494088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      // Check last argument of function call to see if it is an
494188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      // implicit cast from a type matching the type the result
494288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      // is being cast to.
494388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      CallExpr *CEx = cast<CallExpr>(E);
494488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      unsigned NumArgs = CEx->getNumArgs();
494588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      if (NumArgs > 0) {
494688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        Expr *LastA = CEx->getArg(NumArgs - 1);
494788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        Expr *InnerE = LastA->IgnoreParenImpCasts();
494888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        const Type *InnerType =
494988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg          S.Context.getCanonicalType(InnerE->getType()).getTypePtr();
495088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        if (isa<ImplicitCastExpr>(LastA) && (InnerType == Target)) {
495188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg          // Warn on this floating-point to bool conversion
495288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg          DiagnoseImpCast(S, E, T, CC,
495388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg                          diag::warn_impcast_floating_point_to_bool);
495488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        }
495588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      }
495688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    }
495751313c39c84407dd6a323be99a8c322bf8d052a9John McCall    return;
495851313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
495951313c39c84407dd6a323be99a8c322bf8d052a9John McCall
49601838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu  if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull)
4961b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie           == Expr::NPCK_GNUNull) && !Target->isAnyPointerType()
4962e81b43bc306d361fcf4d411aeb14b43f8464bf4aDavid Blaikie      && !Target->isBlockPointerType() && !Target->isMemberPointerType()
4963896c7dd62801c0aacf14b05183c3c471c1fe9f7aDavid Blaikie      && Target->isScalarType() && !Target->isNullPtrType()) {
4964b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie    SourceLocation Loc = E->getSourceRange().getBegin();
4965b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie    if (Loc.isMacroID())
4966b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie      Loc = S.SourceMgr.getImmediateExpansionRange(Loc).first;
49679fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie    if (!Loc.isMacroID() || CC.isMacroID())
49689fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie      S.Diag(Loc, diag::warn_impcast_null_pointer_to_integer)
49699fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie          << T << clang::SourceRange(CC)
49709fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie          << FixItHint::CreateReplacement(Loc, S.getFixItZeroLiteralForType(T));
49711838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu  }
49721838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu
4973b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie  if (!Source->isIntegerType() || !Target->isIntegerType())
4974b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie    return;
4975b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie
4976be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  // TODO: remove this early return once the false positives for constant->bool
4977be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  // in templates, macros, etc, are reduced or removed.
4978be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  if (Target->isSpecificBuiltinType(BuiltinType::Bool))
4979be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    return;
4980be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie
4981323ed74658bc8375278eabf074b4777458376540John McCall  IntRange SourceRange = GetExprRange(S.Context, E);
49821844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target);
498351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4984dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov  if (SourceRange.Width > TargetRange.Width) {
498525ffbef84450f0c666957a2d00cdf928c61b44d7Sam Panzer    // If the source is a constant, use a default-on diagnostic.
4986dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov    // TODO: this should happen for bitfield stores, too.
4987dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov    llvm::APSInt Value(32);
4988dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov    if (E->isIntegerConstantExpr(Value, S.Context)) {
4989dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov      if (S.SourceMgr.isInSystemMacro(CC))
4990dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov        return;
4991dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov
4992091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall      std::string PrettySourceValue = Value.toString(10);
4993091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall      std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange);
4994dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov
49955e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek      S.DiagRuntimeBehavior(E->getExprLoc(), E,
49965e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek        S.PDiag(diag::warn_impcast_integer_precision_constant)
49975e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek            << PrettySourceValue << PrettyTargetValue
49985e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek            << E->getType() << T << E->getSourceRange()
49995e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek            << clang::SourceRange(CC));
5000091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall      return;
5001091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    }
5002091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall
5003dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov    // People want to build with -Wshorten-64-to-32 and not -Wconversion.
5004dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov    if (S.SourceMgr.isInSystemMacro(CC))
5005dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov      return;
5006dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov
500737050841d7b852497b85d5275d9ea92c07ddf059David Blaikie    if (TargetRange.Width == 32 && S.Context.getIntWidth(E->getType()) == 64)
5008c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32,
5009c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                             /* pruneControlFlow */ true);
5010b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision);
5011323ed74658bc8375278eabf074b4777458376540John McCall  }
5012323ed74658bc8375278eabf074b4777458376540John McCall
5013323ed74658bc8375278eabf074b4777458376540John McCall  if ((TargetRange.NonNegative && !SourceRange.NonNegative) ||
5014323ed74658bc8375278eabf074b4777458376540John McCall      (!TargetRange.NonNegative && SourceRange.NonNegative &&
5015323ed74658bc8375278eabf074b4777458376540John McCall       SourceRange.Width == TargetRange.Width)) {
5016ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
5017d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay    if (S.SourceMgr.isInSystemMacro(CC))
5018ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek      return;
5019ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
5020323ed74658bc8375278eabf074b4777458376540John McCall    unsigned DiagID = diag::warn_impcast_integer_sign;
5021323ed74658bc8375278eabf074b4777458376540John McCall
5022323ed74658bc8375278eabf074b4777458376540John McCall    // Traditionally, gcc has warned about this under -Wsign-compare.
5023323ed74658bc8375278eabf074b4777458376540John McCall    // We also want to warn about it in -Wconversion.
5024323ed74658bc8375278eabf074b4777458376540John McCall    // So if -Wconversion is off, use a completely identical diagnostic
5025323ed74658bc8375278eabf074b4777458376540John McCall    // in the sign-compare group.
5026323ed74658bc8375278eabf074b4777458376540John McCall    // The conditional-checking code will
5027323ed74658bc8375278eabf074b4777458376540John McCall    if (ICContext) {
5028323ed74658bc8375278eabf074b4777458376540John McCall      DiagID = diag::warn_impcast_integer_sign_conditional;
5029323ed74658bc8375278eabf074b4777458376540John McCall      *ICContext = true;
5030323ed74658bc8375278eabf074b4777458376540John McCall    }
5031323ed74658bc8375278eabf074b4777458376540John McCall
5032b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return DiagnoseImpCast(S, E, T, CC, DiagID);
503351313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
503451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
5035284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor  // Diagnose conversions between different enumeration types.
50365a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  // In C, we pretend that the type of an EnumConstantDecl is its enumeration
50375a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  // type, to give us better diagnostics.
50385a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  QualType SourceType = E->getType();
50394e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie  if (!S.getLangOpts().CPlusPlus) {
50405a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor    if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E))
50415a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor      if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) {
50425a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor        EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext());
50435a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor        SourceType = S.Context.getTypeDeclType(Enum);
50445a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor        Source = S.Context.getCanonicalType(SourceType).getTypePtr();
50455a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor      }
50465a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  }
50475a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor
5048284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor  if (const EnumType *SourceEnum = Source->getAs<EnumType>())
5049284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor    if (const EnumType *TargetEnum = Target->getAs<EnumType>())
505083972f128e9218c051692bf96361327a701aeb79John McCall      if (SourceEnum->getDecl()->hasNameForLinkage() &&
505183972f128e9218c051692bf96361327a701aeb79John McCall          TargetEnum->getDecl()->hasNameForLinkage() &&
5052ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek          SourceEnum != TargetEnum) {
5053d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay        if (S.SourceMgr.isInSystemMacro(CC))
5054ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek          return;
5055ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
50565a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor        return DiagnoseImpCast(S, E, SourceType, T, CC,
5057284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor                               diag::warn_impcast_different_enum_types);
5058ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek      }
5059284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor
506051313c39c84407dd6a323be99a8c322bf8d052a9John McCall  return;
506151313c39c84407dd6a323be99a8c322bf8d052a9John McCall}
506251313c39c84407dd6a323be99a8c322bf8d052a9John McCall
50639fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E,
50649fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie                              SourceLocation CC, QualType T);
5065323ed74658bc8375278eabf074b4777458376540John McCall
5066323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T,
5067b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall                             SourceLocation CC, bool &ICContext) {
5068323ed74658bc8375278eabf074b4777458376540John McCall  E = E->IgnoreParenImpCasts();
5069323ed74658bc8375278eabf074b4777458376540John McCall
5070323ed74658bc8375278eabf074b4777458376540John McCall  if (isa<ConditionalOperator>(E))
50719fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie    return CheckConditionalOperator(S, cast<ConditionalOperator>(E), CC, T);
5072323ed74658bc8375278eabf074b4777458376540John McCall
5073b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(S, E, CC);
5074323ed74658bc8375278eabf074b4777458376540John McCall  if (E->getType() != T)
5075b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return CheckImplicitConversion(S, E, T, CC, &ICContext);
5076323ed74658bc8375278eabf074b4777458376540John McCall  return;
5077323ed74658bc8375278eabf074b4777458376540John McCall}
5078323ed74658bc8375278eabf074b4777458376540John McCall
50799fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E,
50809fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie                              SourceLocation CC, QualType T) {
5081b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(S, E->getCond(), CC);
5082323ed74658bc8375278eabf074b4777458376540John McCall
5083323ed74658bc8375278eabf074b4777458376540John McCall  bool Suspicious = false;
5084b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious);
5085b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious);
5086323ed74658bc8375278eabf074b4777458376540John McCall
5087323ed74658bc8375278eabf074b4777458376540John McCall  // If -Wconversion would have warned about either of the candidates
5088323ed74658bc8375278eabf074b4777458376540John McCall  // for a signedness conversion to the context type...
5089323ed74658bc8375278eabf074b4777458376540John McCall  if (!Suspicious) return;
5090323ed74658bc8375278eabf074b4777458376540John McCall
5091323ed74658bc8375278eabf074b4777458376540John McCall  // ...but it's currently ignored...
50920827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis  if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional,
50930827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis                                 CC))
5094323ed74658bc8375278eabf074b4777458376540John McCall    return;
5095323ed74658bc8375278eabf074b4777458376540John McCall
5096323ed74658bc8375278eabf074b4777458376540John McCall  // ...then check whether it would have warned about either of the
5097323ed74658bc8375278eabf074b4777458376540John McCall  // candidates for a signedness conversion to the condition type.
50985254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu  if (E->getType() == T) return;
50995254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu
51005254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu  Suspicious = false;
51015254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu  CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(),
51025254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu                          E->getType(), CC, &Suspicious);
51035254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu  if (!Suspicious)
51045254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu    CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(),
5105b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall                            E->getType(), CC, &Suspicious);
5106323ed74658bc8375278eabf074b4777458376540John McCall}
5107323ed74658bc8375278eabf074b4777458376540John McCall
5108323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting
5109323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression.  There are a couple
5110323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare.
5111b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) {
5112323ed74658bc8375278eabf074b4777458376540John McCall  QualType T = OrigE->getType();
5113323ed74658bc8375278eabf074b4777458376540John McCall  Expr *E = OrigE->IgnoreParenImpCasts();
5114323ed74658bc8375278eabf074b4777458376540John McCall
5115f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor  if (E->isTypeDependent() || E->isValueDependent())
5116f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor    return;
5117f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor
5118323ed74658bc8375278eabf074b4777458376540John McCall  // For conditional operators, we analyze the arguments as if they
5119323ed74658bc8375278eabf074b4777458376540John McCall  // were being fed directly into the output.
5120323ed74658bc8375278eabf074b4777458376540John McCall  if (isa<ConditionalOperator>(E)) {
5121323ed74658bc8375278eabf074b4777458376540John McCall    ConditionalOperator *CO = cast<ConditionalOperator>(E);
51229fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie    CheckConditionalOperator(S, CO, CC, T);
5123323ed74658bc8375278eabf074b4777458376540John McCall    return;
5124323ed74658bc8375278eabf074b4777458376540John McCall  }
5125323ed74658bc8375278eabf074b4777458376540John McCall
512688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  // Check implicit argument conversions for function calls.
512788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  if (CallExpr *Call = dyn_cast<CallExpr>(E))
512888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    CheckImplicitArgumentConversions(S, Call, CC);
512988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
5130323ed74658bc8375278eabf074b4777458376540John McCall  // Go ahead and check any implicit conversions we might have skipped.
5131323ed74658bc8375278eabf074b4777458376540John McCall  // The non-canonical typecheck is just an optimization;
5132323ed74658bc8375278eabf074b4777458376540John McCall  // CheckImplicitConversion will filter out dead implicit conversions.
5133323ed74658bc8375278eabf074b4777458376540John McCall  if (E->getType() != T)
5134b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    CheckImplicitConversion(S, E, T, CC);
5135323ed74658bc8375278eabf074b4777458376540John McCall
5136323ed74658bc8375278eabf074b4777458376540John McCall  // Now continue drilling into this expression.
5137323ed74658bc8375278eabf074b4777458376540John McCall
5138323ed74658bc8375278eabf074b4777458376540John McCall  // Skip past explicit casts.
5139323ed74658bc8375278eabf074b4777458376540John McCall  if (isa<ExplicitCastExpr>(E)) {
5140323ed74658bc8375278eabf074b4777458376540John McCall    E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts();
5141b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return AnalyzeImplicitConversions(S, E, CC);
5142323ed74658bc8375278eabf074b4777458376540John McCall  }
5143323ed74658bc8375278eabf074b4777458376540John McCall
5144beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
5145beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall    // Do a somewhat different check with comparison operators.
5146beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall    if (BO->isComparisonOp())
5147beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall      return AnalyzeComparison(S, BO);
5148beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall
5149dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov    // And with simple assignments.
5150dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov    if (BO->getOpcode() == BO_Assign)
5151beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall      return AnalyzeAssignment(S, BO);
5152beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  }
5153323ed74658bc8375278eabf074b4777458376540John McCall
5154323ed74658bc8375278eabf074b4777458376540John McCall  // These break the otherwise-useful invariant below.  Fortunately,
5155323ed74658bc8375278eabf074b4777458376540John McCall  // we don't really need to recurse into them, because any internal
5156323ed74658bc8375278eabf074b4777458376540John McCall  // expressions should have been analyzed already when they were
5157323ed74658bc8375278eabf074b4777458376540John McCall  // built into statements.
5158323ed74658bc8375278eabf074b4777458376540John McCall  if (isa<StmtExpr>(E)) return;
5159323ed74658bc8375278eabf074b4777458376540John McCall
5160323ed74658bc8375278eabf074b4777458376540John McCall  // Don't descend into unevaluated contexts.
5161f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne  if (isa<UnaryExprOrTypeTraitExpr>(E)) return;
5162323ed74658bc8375278eabf074b4777458376540John McCall
5163323ed74658bc8375278eabf074b4777458376540John McCall  // Now just recurse over the expression's children.
5164b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  CC = E->getExprLoc();
5165f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  BinaryOperator *BO = dyn_cast<BinaryOperator>(E);
5166f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  bool IsLogicalOperator = BO && BO->isLogicalOp();
5167f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  for (Stmt::child_range I = E->children(); I; ++I) {
516854042f1bd78f1f1ea86be7d4af541462e127d2edDouglas Gregor    Expr *ChildExpr = dyn_cast_or_null<Expr>(*I);
5169503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor    if (!ChildExpr)
5170503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor      continue;
5171503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor
5172f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu    if (IsLogicalOperator &&
5173f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu        isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts()))
5174f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      // Ignore checking string literals that are in logical operators.
5175f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      continue;
5176f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu    AnalyzeImplicitConversions(S, ChildExpr, CC);
5177f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  }
5178323ed74658bc8375278eabf074b4777458376540John McCall}
5179323ed74658bc8375278eabf074b4777458376540John McCall
5180323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace
5181323ed74658bc8375278eabf074b4777458376540John McCall
5182323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given
5183323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression).  Implements -Wconversion
5184323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare.
5185b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall///
5186b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e.
5187b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall///   the most location of the syntactic entity requiring the implicit
5188b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall///   conversion
5189b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) {
5190323ed74658bc8375278eabf074b4777458376540John McCall  // Don't diagnose in unevaluated contexts.
519171f55f771794674a410171dbf3cb5dbedf95d033David Blaikie  if (isUnevaluatedContext())
5192323ed74658bc8375278eabf074b4777458376540John McCall    return;
5193323ed74658bc8375278eabf074b4777458376540John McCall
5194323ed74658bc8375278eabf074b4777458376540John McCall  // Don't diagnose for value- or type-dependent expressions.
5195323ed74658bc8375278eabf074b4777458376540John McCall  if (E->isTypeDependent() || E->isValueDependent())
5196323ed74658bc8375278eabf074b4777458376540John McCall    return;
5197323ed74658bc8375278eabf074b4777458376540John McCall
5198d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  // Check for array bounds violations in cases where the check isn't triggered
5199d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  // elsewhere for other Expr types (like BinaryOperators), e.g. when an
5200d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  // ArraySubscriptExpr is on the RHS of a variable initialization.
5201d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  CheckArrayAccess(E);
5202d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
5203b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  // This is not the right CC for (e.g.) a variable initialization.
5204b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(*this, E, CC);
5205323ed74658bc8375278eabf074b4777458376540John McCall}
5206323ed74658bc8375278eabf074b4777458376540John McCall
5207ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian/// Diagnose when expression is an integer constant expression and its evaluation
5208ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian/// results in integer overflow
5209ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanianvoid Sema::CheckForIntOverflow (Expr *E) {
52101fd8d46d222fab7f17b91846e2c50bef640a60a0Fariborz Jahanian  if (isa<BinaryOperator>(E->IgnoreParens())) {
5211ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian    llvm::SmallVector<PartialDiagnosticAt, 4> Diags;
5212ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian    E->EvaluateForOverflow(Context, &Diags);
5213ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian  }
5214ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian}
5215ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian
52166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithnamespace {
52176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith/// \brief Visitor for expressions which looks for unsequenced operations on the
52186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith/// same object.
52196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithclass SequenceChecker : public EvaluatedExprVisitor<SequenceChecker> {
52206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// \brief A tree of sequenced regions within an expression. Two regions are
52216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// unsequenced if one is an ancestor or a descendent of the other. When we
52226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// finish processing an expression with sequencing, such as a comma
52236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// expression, we fold its tree nodes into its parent, since they are
52246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// unsequenced with respect to nodes we will visit later.
52256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  class SequenceTree {
52266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    struct Value {
52276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      explicit Value(unsigned Parent) : Parent(Parent), Merged(false) {}
52286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      unsigned Parent : 31;
52296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      bool Merged : 1;
52306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    };
52316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    llvm::SmallVector<Value, 8> Values;
52326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
52336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  public:
52346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    /// \brief A region within an expression which may be sequenced with respect
52356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    /// to some other region.
52366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    class Seq {
52376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      explicit Seq(unsigned N) : Index(N) {}
52386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      unsigned Index;
52396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      friend class SequenceTree;
52406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    public:
52416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      Seq() : Index(0) {}
52426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    };
52436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
52446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    SequenceTree() { Values.push_back(Value(0)); }
52456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Seq root() const { return Seq(0); }
52466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
52476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    /// \brief Create a new sequence of operations, which is an unsequenced
52486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    /// subset of \p Parent. This sequence of operations is sequenced with
52496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    /// respect to other children of \p Parent.
52506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Seq allocate(Seq Parent) {
52516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      Values.push_back(Value(Parent.Index));
52526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      return Seq(Values.size() - 1);
52536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    }
52546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
52556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    /// \brief Merge a sequence of operations into its parent.
52566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    void merge(Seq S) {
52576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      Values[S.Index].Merged = true;
52586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    }
52596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
52606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    /// \brief Determine whether two operations are unsequenced. This operation
52616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    /// is asymmetric: \p Cur should be the more recent sequence, and \p Old
52626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    /// should have been merged into its parent as appropriate.
52636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    bool isUnsequenced(Seq Cur, Seq Old) {
52646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      unsigned C = representative(Cur.Index);
52656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      unsigned Target = representative(Old.Index);
52666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      while (C >= Target) {
52676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith        if (C == Target)
52686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith          return true;
52696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith        C = Values[C].Parent;
52706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      }
52716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      return false;
52726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    }
52736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
52746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  private:
52756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    /// \brief Pick a representative for a sequence.
52766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    unsigned representative(unsigned K) {
52776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      if (Values[K].Merged)
52786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith        // Perform path compression as we go.
52796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith        return Values[K].Parent = representative(Values[K].Parent);
52806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      return K;
52816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    }
52826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  };
52836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
52846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// An object for which we can track unsequenced uses.
52856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  typedef NamedDecl *Object;
52866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
52876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// Different flavors of object usage which we track. We only track the
52886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// least-sequenced usage of each kind.
52896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  enum UsageKind {
52906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    /// A read of an object. Multiple unsequenced reads are OK.
52916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    UK_Use,
52926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    /// A modification of an object which is sequenced before the value
52936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    /// computation of the expression, such as ++n.
52946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    UK_ModAsValue,
52956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    /// A modification of an object which is not sequenced before the value
52966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    /// computation of the expression, such as n++.
52976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    UK_ModAsSideEffect,
52986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
52996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    UK_Count = UK_ModAsSideEffect + 1
53006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  };
53016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
53026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  struct Usage {
53036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Usage() : Use(0), Seq() {}
53046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Expr *Use;
53056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    SequenceTree::Seq Seq;
53066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  };
53076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
53086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  struct UsageInfo {
53096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    UsageInfo() : Diagnosed(false) {}
53106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Usage Uses[UK_Count];
53116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    /// Have we issued a diagnostic for this variable already?
53126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    bool Diagnosed;
53136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  };
53146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  typedef llvm::SmallDenseMap<Object, UsageInfo, 16> UsageInfoMap;
53156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
53166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  Sema &SemaRef;
53176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// Sequenced regions within the expression.
53186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  SequenceTree Tree;
53196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// Declaration modifications and references which we have seen.
53206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  UsageInfoMap UsageMap;
53216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// The region we are currently within.
53226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  SequenceTree::Seq Region;
53236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// Filled in with declarations which were modified as a side-effect
53246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// (that is, post-increment operations).
53256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  llvm::SmallVectorImpl<std::pair<Object, Usage> > *ModAsSideEffect;
53261a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith  /// Expressions to check later. We defer checking these to reduce
53271a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith  /// stack usage.
53281a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith  llvm::SmallVectorImpl<Expr*> &WorkList;
53296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
53306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// RAII object wrapping the visitation of a sequenced subexpression of an
53316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// expression. At the end of this process, the side-effects of the evaluation
53326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// become sequenced with respect to the value computation of the result, so
53336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// we downgrade any UK_ModAsSideEffect within the evaluation to
53346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// UK_ModAsValue.
53356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  struct SequencedSubexpression {
53366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    SequencedSubexpression(SequenceChecker &Self)
53376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      : Self(Self), OldModAsSideEffect(Self.ModAsSideEffect) {
53386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      Self.ModAsSideEffect = &ModAsSideEffect;
53396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    }
53406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    ~SequencedSubexpression() {
53416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      for (unsigned I = 0, E = ModAsSideEffect.size(); I != E; ++I) {
53426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith        UsageInfo &U = Self.UsageMap[ModAsSideEffect[I].first];
53436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith        U.Uses[UK_ModAsSideEffect] = ModAsSideEffect[I].second;
53446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith        Self.addUsage(U, ModAsSideEffect[I].first,
53456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith                      ModAsSideEffect[I].second.Use, UK_ModAsValue);
53466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      }
53476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      Self.ModAsSideEffect = OldModAsSideEffect;
53486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    }
53496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
53506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    SequenceChecker &Self;
53516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    llvm::SmallVector<std::pair<Object, Usage>, 4> ModAsSideEffect;
53526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    llvm::SmallVectorImpl<std::pair<Object, Usage> > *OldModAsSideEffect;
53536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  };
53546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
53556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// \brief Find the object which is produced by the specified expression,
53566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// if any.
53576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  Object getObject(Expr *E, bool Mod) const {
53586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    E = E->IgnoreParenCasts();
53596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
53606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      if (Mod && (UO->getOpcode() == UO_PreInc || UO->getOpcode() == UO_PreDec))
53616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith        return getObject(UO->getSubExpr(), Mod);
53626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
53636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      if (BO->getOpcode() == BO_Comma)
53646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith        return getObject(BO->getRHS(), Mod);
53656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      if (Mod && BO->isAssignmentOp())
53666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith        return getObject(BO->getLHS(), Mod);
53676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    } else if (MemberExpr *ME = dyn_cast<MemberExpr>(E)) {
53686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      // FIXME: Check for more interesting cases, like "x.n = ++x.n".
53696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      if (isa<CXXThisExpr>(ME->getBase()->IgnoreParenCasts()))
53706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith        return ME->getMemberDecl();
53716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    } else if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E))
53726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      // FIXME: If this is a reference, map through to its value.
53736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      return DRE->getDecl();
53746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    return 0;
53756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
53766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
53776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// \brief Note that an object was modified or used by an expression.
53786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void addUsage(UsageInfo &UI, Object O, Expr *Ref, UsageKind UK) {
53796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Usage &U = UI.Uses[UK];
53806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    if (!U.Use || !Tree.isUnsequenced(Region, U.Seq)) {
53816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      if (UK == UK_ModAsSideEffect && ModAsSideEffect)
53826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith        ModAsSideEffect->push_back(std::make_pair(O, U));
53836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      U.Use = Ref;
53846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      U.Seq = Region;
53856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    }
53866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
53876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// \brief Check whether a modification or use conflicts with a prior usage.
53886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void checkUsage(Object O, UsageInfo &UI, Expr *Ref, UsageKind OtherKind,
53896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith                  bool IsModMod) {
53906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    if (UI.Diagnosed)
53916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      return;
53926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
53936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    const Usage &U = UI.Uses[OtherKind];
53946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    if (!U.Use || !Tree.isUnsequenced(Region, U.Seq))
53956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      return;
53966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
53976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Expr *Mod = U.Use;
53986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Expr *ModOrUse = Ref;
53996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    if (OtherKind == UK_Use)
54006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      std::swap(Mod, ModOrUse);
54016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
54026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    SemaRef.Diag(Mod->getExprLoc(),
54036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith                 IsModMod ? diag::warn_unsequenced_mod_mod
54046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith                          : diag::warn_unsequenced_mod_use)
54056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      << O << SourceRange(ModOrUse->getExprLoc());
54066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    UI.Diagnosed = true;
54076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
54086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
54096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void notePreUse(Object O, Expr *Use) {
54106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    UsageInfo &U = UsageMap[O];
54116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // Uses conflict with other modifications.
54126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    checkUsage(O, U, Use, UK_ModAsValue, false);
54136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
54146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void notePostUse(Object O, Expr *Use) {
54156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    UsageInfo &U = UsageMap[O];
54166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    checkUsage(O, U, Use, UK_ModAsSideEffect, false);
54176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    addUsage(U, O, Use, UK_Use);
54186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
54196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
54206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void notePreMod(Object O, Expr *Mod) {
54216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    UsageInfo &U = UsageMap[O];
54226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // Modifications conflict with other modifications and with uses.
54236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    checkUsage(O, U, Mod, UK_ModAsValue, true);
54246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    checkUsage(O, U, Mod, UK_Use, false);
54256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
54266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void notePostMod(Object O, Expr *Use, UsageKind UK) {
54276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    UsageInfo &U = UsageMap[O];
54286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    checkUsage(O, U, Use, UK_ModAsSideEffect, true);
54296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    addUsage(U, O, Use, UK);
54306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
54316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
54326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithpublic:
54331a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith  SequenceChecker(Sema &S, Expr *E,
54341a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith                  llvm::SmallVectorImpl<Expr*> &WorkList)
5435e5096c8f2f2e64d5ac98531ff9aa952bbe60d5fcRichard Smith    : EvaluatedExprVisitor<SequenceChecker>(S.Context), SemaRef(S),
54361a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith      Region(Tree.root()), ModAsSideEffect(0), WorkList(WorkList) {
54376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Visit(E);
54386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
54396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
54406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void VisitStmt(Stmt *S) {
54416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // Skip all statements which aren't expressions for now.
54426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
54436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
54446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void VisitExpr(Expr *E) {
54456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // By default, just recurse to evaluated subexpressions.
5446e5096c8f2f2e64d5ac98531ff9aa952bbe60d5fcRichard Smith    EvaluatedExprVisitor<SequenceChecker>::VisitStmt(E);
54476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
54486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
54496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void VisitCastExpr(CastExpr *E) {
54506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Object O = Object();
54516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    if (E->getCastKind() == CK_LValueToRValue)
54526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      O = getObject(E->getSubExpr(), false);
54536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
54546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    if (O)
54556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      notePreUse(O, E);
54566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    VisitExpr(E);
54576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    if (O)
54586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      notePostUse(O, E);
54596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
54606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
54616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void VisitBinComma(BinaryOperator *BO) {
54626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // C++11 [expr.comma]p1:
54636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    //   Every value computation and side effect associated with the left
54646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    //   expression is sequenced before every value computation and side
54656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    //   effect associated with the right expression.
54666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    SequenceTree::Seq LHS = Tree.allocate(Region);
54676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    SequenceTree::Seq RHS = Tree.allocate(Region);
54686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    SequenceTree::Seq OldRegion = Region;
54696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
54706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    {
54716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      SequencedSubexpression SeqLHS(*this);
54726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      Region = LHS;
54736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      Visit(BO->getLHS());
54746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    }
54756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
54766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Region = RHS;
54776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Visit(BO->getRHS());
54786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
54796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Region = OldRegion;
54806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
54816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // Forget that LHS and RHS are sequenced. They are both unsequenced
54826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // with respect to other stuff.
54836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Tree.merge(LHS);
54846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Tree.merge(RHS);
54856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
54866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
54876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void VisitBinAssign(BinaryOperator *BO) {
54886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // The modification is sequenced after the value computation of the LHS
54896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // and RHS, so check it before inspecting the operands and update the
54906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // map afterwards.
54916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Object O = getObject(BO->getLHS(), true);
54926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    if (!O)
54936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      return VisitExpr(BO);
54946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
54956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    notePreMod(O, BO);
54966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
54976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // C++11 [expr.ass]p7:
54986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    //   E1 op= E2 is equivalent to E1 = E1 op E2, except that E1 is evaluated
54996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    //   only once.
55006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    //
55016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // Therefore, for a compound assignment operator, O is considered used
55026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // everywhere except within the evaluation of E1 itself.
55036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    if (isa<CompoundAssignOperator>(BO))
55046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      notePreUse(O, BO);
55056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
55066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Visit(BO->getLHS());
55076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
55086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    if (isa<CompoundAssignOperator>(BO))
55096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      notePostUse(O, BO);
55106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
55116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Visit(BO->getRHS());
55126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
55136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    notePostMod(O, BO, UK_ModAsValue);
55146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
55156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void VisitCompoundAssignOperator(CompoundAssignOperator *CAO) {
55166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    VisitBinAssign(CAO);
55176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
55186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
55196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void VisitUnaryPreInc(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); }
55206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void VisitUnaryPreDec(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); }
55216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void VisitUnaryPreIncDec(UnaryOperator *UO) {
55226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Object O = getObject(UO->getSubExpr(), true);
55236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    if (!O)
55246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      return VisitExpr(UO);
55256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
55266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    notePreMod(O, UO);
55276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Visit(UO->getSubExpr());
55286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    notePostMod(O, UO, UK_ModAsValue);
55296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
55306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
55316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void VisitUnaryPostInc(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); }
55326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void VisitUnaryPostDec(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); }
55336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void VisitUnaryPostIncDec(UnaryOperator *UO) {
55346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Object O = getObject(UO->getSubExpr(), true);
55356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    if (!O)
55366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      return VisitExpr(UO);
55376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
55386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    notePreMod(O, UO);
55396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Visit(UO->getSubExpr());
55406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    notePostMod(O, UO, UK_ModAsSideEffect);
55416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
55426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
55436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  /// Don't visit the RHS of '&&' or '||' if it might not be evaluated.
55446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void VisitBinLOr(BinaryOperator *BO) {
55456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // The side-effects of the LHS of an '&&' are sequenced before the
55466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // value computation of the RHS, and hence before the value computation
55476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // of the '&&' itself, unless the LHS evaluates to zero. We treat them
55486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // as if they were unconditionally sequenced.
55496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    {
55506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      SequencedSubexpression Sequenced(*this);
55516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      Visit(BO->getLHS());
55526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    }
55536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
55546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    bool Result;
55556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    if (!BO->getLHS()->isValueDependent() &&
5556995e4a7530d705147c875b63608532c483c011a8Richard Smith        BO->getLHS()->EvaluateAsBooleanCondition(Result, SemaRef.Context)) {
5557995e4a7530d705147c875b63608532c483c011a8Richard Smith      if (!Result)
5558995e4a7530d705147c875b63608532c483c011a8Richard Smith        Visit(BO->getRHS());
5559995e4a7530d705147c875b63608532c483c011a8Richard Smith    } else {
5560995e4a7530d705147c875b63608532c483c011a8Richard Smith      // Check for unsequenced operations in the RHS, treating it as an
5561995e4a7530d705147c875b63608532c483c011a8Richard Smith      // entirely separate evaluation.
5562995e4a7530d705147c875b63608532c483c011a8Richard Smith      //
5563995e4a7530d705147c875b63608532c483c011a8Richard Smith      // FIXME: If there are operations in the RHS which are unsequenced
5564995e4a7530d705147c875b63608532c483c011a8Richard Smith      // with respect to operations outside the RHS, and those operations
5565995e4a7530d705147c875b63608532c483c011a8Richard Smith      // are unconditionally evaluated, diagnose them.
55661a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith      WorkList.push_back(BO->getRHS());
5567995e4a7530d705147c875b63608532c483c011a8Richard Smith    }
55686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
55696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void VisitBinLAnd(BinaryOperator *BO) {
55706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    {
55716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      SequencedSubexpression Sequenced(*this);
55726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      Visit(BO->getLHS());
55736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    }
55746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
55756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    bool Result;
55766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    if (!BO->getLHS()->isValueDependent() &&
5577995e4a7530d705147c875b63608532c483c011a8Richard Smith        BO->getLHS()->EvaluateAsBooleanCondition(Result, SemaRef.Context)) {
5578995e4a7530d705147c875b63608532c483c011a8Richard Smith      if (Result)
5579995e4a7530d705147c875b63608532c483c011a8Richard Smith        Visit(BO->getRHS());
5580995e4a7530d705147c875b63608532c483c011a8Richard Smith    } else {
55811a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith      WorkList.push_back(BO->getRHS());
5582995e4a7530d705147c875b63608532c483c011a8Richard Smith    }
55836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
55846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
55856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  // Only visit the condition, unless we can be sure which subexpression will
55866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  // be chosen.
55876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void VisitAbstractConditionalOperator(AbstractConditionalOperator *CO) {
55886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    SequencedSubexpression Sequenced(*this);
55896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Visit(CO->getCond());
55906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
55916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    bool Result;
55926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    if (!CO->getCond()->isValueDependent() &&
55936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith        CO->getCond()->EvaluateAsBooleanCondition(Result, SemaRef.Context))
55946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      Visit(Result ? CO->getTrueExpr() : CO->getFalseExpr());
5595995e4a7530d705147c875b63608532c483c011a8Richard Smith    else {
55961a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith      WorkList.push_back(CO->getTrueExpr());
55971a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith      WorkList.push_back(CO->getFalseExpr());
5598995e4a7530d705147c875b63608532c483c011a8Richard Smith    }
55996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
56006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
56016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void VisitCXXConstructExpr(CXXConstructExpr *CCE) {
56026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    if (!CCE->isListInitialization())
56036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      return VisitExpr(CCE);
56046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
56056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // In C++11, list initializations are sequenced.
56066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    llvm::SmallVector<SequenceTree::Seq, 32> Elts;
56076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    SequenceTree::Seq Parent = Region;
56086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    for (CXXConstructExpr::arg_iterator I = CCE->arg_begin(),
56096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith                                        E = CCE->arg_end();
56106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith         I != E; ++I) {
56116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      Region = Tree.allocate(Parent);
56126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      Elts.push_back(Region);
56136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      Visit(*I);
56146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    }
56156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
56166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // Forget that the initializers are sequenced.
56176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Region = Parent;
56186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    for (unsigned I = 0; I < Elts.size(); ++I)
56196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      Tree.merge(Elts[I]);
56206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
56216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
56226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  void VisitInitListExpr(InitListExpr *ILE) {
56236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    if (!SemaRef.getLangOpts().CPlusPlus11)
56246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      return VisitExpr(ILE);
56256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
56266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // In C++11, list initializations are sequenced.
56276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    llvm::SmallVector<SequenceTree::Seq, 32> Elts;
56286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    SequenceTree::Seq Parent = Region;
56296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    for (unsigned I = 0; I < ILE->getNumInits(); ++I) {
56306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      Expr *E = ILE->getInit(I);
56316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      if (!E) continue;
56326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      Region = Tree.allocate(Parent);
56336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      Elts.push_back(Region);
56346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      Visit(E);
56356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    }
56366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
56376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    // Forget that the initializers are sequenced.
56386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    Region = Parent;
56396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith    for (unsigned I = 0; I < Elts.size(); ++I)
56406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith      Tree.merge(Elts[I]);
56416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  }
56426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith};
56436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith}
56446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
56456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithvoid Sema::CheckUnsequencedOperations(Expr *E) {
56461a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith  llvm::SmallVector<Expr*, 8> WorkList;
56471a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith  WorkList.push_back(E);
56481a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith  while (!WorkList.empty()) {
56491a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith    Expr *Item = WorkList.back();
56501a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith    WorkList.pop_back();
56511a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith    SequenceChecker(*this, Item, WorkList);
56521a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith  }
56536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith}
56546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
5655ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanianvoid Sema::CheckCompletedExpr(Expr *E, SourceLocation CheckLoc,
5656ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian                              bool IsConstexpr) {
56576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  CheckImplicitConversions(E, CheckLoc);
56586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith  CheckUnsequencedOperations(E);
5659ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian  if (!IsConstexpr && !E->isValueDependent())
5660ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian    CheckForIntOverflow(E);
56616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith}
56626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith
566315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc,
566415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall                                       FieldDecl *BitField,
566515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall                                       Expr *Init) {
566615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc);
566715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall}
566815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
5669f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given
5670f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This
5671f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the
5672f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function
5673f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete.
567482aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregorbool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd,
567582aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor                                    bool CheckParameterNames) {
5676f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump  bool HasInvalidParm = false;
567782aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor  for (; P != PEnd; ++P) {
567882aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor    ParmVarDecl *Param = *P;
567982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor
5680f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // C99 6.7.5.3p4: the parameters in a parameter type list in a
5681f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // function declarator that is part of a function definition of
5682f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // that function shall not have incomplete type.
5683f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    //
5684f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // This is also C++ [dcl.fct]p6.
5685f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    if (!Param->isInvalidDecl() &&
5686f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump        RequireCompleteType(Param->getLocation(), Param->getType(),
5687d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor                            diag::err_typecheck_decl_incomplete_type)) {
5688f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump      Param->setInvalidDecl();
5689f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump      HasInvalidParm = true;
5690f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    }
5691f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump
5692f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // C99 6.9.1p5: If the declarator includes a parameter type list, the
5693f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // declaration of each parameter shall include an identifier.
569482aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor    if (CheckParameterNames &&
569582aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor        Param->getIdentifier() == 0 &&
5696f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump        !Param->isImplicit() &&
56974e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie        !getLangOpts().CPlusPlus)
5698f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump      Diag(Param->getLocation(), diag::err_parameter_name_omitted);
5699d17e340e2d516139931768697bf080f60920ba9dSam Weinig
5700d17e340e2d516139931768697bf080f60920ba9dSam Weinig    // C99 6.7.5.3p12:
5701d17e340e2d516139931768697bf080f60920ba9dSam Weinig    //   If the function declarator is not part of a definition of that
5702d17e340e2d516139931768697bf080f60920ba9dSam Weinig    //   function, parameters may have incomplete type and may use the [*]
5703d17e340e2d516139931768697bf080f60920ba9dSam Weinig    //   notation in their sequences of declarator specifiers to specify
5704d17e340e2d516139931768697bf080f60920ba9dSam Weinig    //   variable length array types.
5705d17e340e2d516139931768697bf080f60920ba9dSam Weinig    QualType PType = Param->getOriginalType();
5706d17e340e2d516139931768697bf080f60920ba9dSam Weinig    if (const ArrayType *AT = Context.getAsArrayType(PType)) {
5707d17e340e2d516139931768697bf080f60920ba9dSam Weinig      if (AT->getSizeModifier() == ArrayType::Star) {
5708fc09336a5965040736f9bc63a70416003972364eStefanus Du Toit        // FIXME: This diagnostic should point the '[*]' if source-location
5709d17e340e2d516139931768697bf080f60920ba9dSam Weinig        // information is added for it.
5710d17e340e2d516139931768697bf080f60920ba9dSam Weinig        Diag(Param->getLocation(), diag::err_array_star_in_function_definition);
5711d17e340e2d516139931768697bf080f60920ba9dSam Weinig      }
5712d17e340e2d516139931768697bf080f60920ba9dSam Weinig    }
5713f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump  }
5714f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump
5715f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump  return HasInvalidParm;
5716f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump}
5717b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5718b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a
5719b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements.
5720b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) {
5721b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // This is actually a lot of work to potentially be doing on every
5722b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // cast; don't do it if we're ignoring -Wcast_align (as is the default).
57230827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis  if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align,
57240827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis                                          TRange.getBegin())
5725d6471f7c1921c7802804ce3ff6fe9768310f72b9David Blaikie        == DiagnosticsEngine::Ignored)
5726b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    return;
5727b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5728b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Ignore dependent types.
5729b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (T->isDependentType() || Op->getType()->isDependentType())
5730b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    return;
5731b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5732b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Require that the destination be a pointer type.
5733b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  const PointerType *DestPtr = T->getAs<PointerType>();
5734b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (!DestPtr) return;
5735b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5736b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // If the destination has alignment 1, we're done.
5737b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  QualType DestPointee = DestPtr->getPointeeType();
5738b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (DestPointee->isIncompleteType()) return;
5739b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee);
5740b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (DestAlign.isOne()) return;
5741b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5742b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Require that the source be a pointer type.
5743b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  const PointerType *SrcPtr = Op->getType()->getAs<PointerType>();
5744b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (!SrcPtr) return;
5745b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  QualType SrcPointee = SrcPtr->getPointeeType();
5746b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5747b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Whitelist casts from cv void*.  We already implicitly
5748b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // whitelisted casts to cv void*, since they have alignment 1.
5749b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Also whitelist casts involving incomplete types, which implicitly
5750b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // includes 'void'.
5751b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (SrcPointee->isIncompleteType()) return;
5752b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5753b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee);
5754b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (SrcAlign >= DestAlign) return;
5755b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5756b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  Diag(TRange.getBegin(), diag::warn_cast_align)
5757b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    << Op->getType() << T
5758b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    << static_cast<unsigned>(SrcAlign.getQuantity())
5759b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    << static_cast<unsigned>(DestAlign.getQuantity())
5760b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    << TRange << Op->getSourceRange();
5761b7f4ffe073fa419613946461a2583ba2fcb72280John McCall}
5762b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5763d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainstatic const Type* getElementType(const Expr *BaseExpr) {
5764d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  const Type* EltType = BaseExpr->getType().getTypePtr();
5765d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  if (EltType->isAnyPointerType())
5766d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    return EltType->getPointeeType().getTypePtr();
5767d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  else if (EltType->isArrayType())
5768d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    return EltType->getBaseElementTypeUnsafe();
5769d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  return EltType;
5770d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain}
5771d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
5772c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// \brief Check whether this array fits the idiom of a size-one tail padded
5773c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// array member of a struct.
5774c268434b332bbe57950d977633369bf5822d9554Chandler Carruth///
5775c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// We avoid emitting out-of-bounds access warnings for such arrays as they are
5776c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// commonly used to emulate flexible arrays in C89 code.
5777c268434b332bbe57950d977633369bf5822d9554Chandler Carruthstatic bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size,
5778c268434b332bbe57950d977633369bf5822d9554Chandler Carruth                                    const NamedDecl *ND) {
5779c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  if (Size != 1 || !ND) return false;
5780c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
5781c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  const FieldDecl *FD = dyn_cast<FieldDecl>(ND);
5782c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  if (!FD) return false;
5783c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
5784c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  // Don't consider sizes resulting from macro expansions or template argument
5785c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  // substitution to form C89 tail-padded arrays.
5786d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan
5787d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan  TypeSourceInfo *TInfo = FD->getTypeSourceInfo();
578800e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek  while (TInfo) {
578900e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    TypeLoc TL = TInfo->getTypeLoc();
579000e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    // Look through typedefs.
579139e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie    if (TypedefTypeLoc TTL = TL.getAs<TypedefTypeLoc>()) {
579239e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie      const TypedefNameDecl *TDL = TTL.getTypedefNameDecl();
579300e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek      TInfo = TDL->getTypeSourceInfo();
579400e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek      continue;
579500e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    }
579639e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie    if (ConstantArrayTypeLoc CTL = TL.getAs<ConstantArrayTypeLoc>()) {
579739e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie      const Expr *SizeExpr = dyn_cast<IntegerLiteral>(CTL.getSizeExpr());
57985e25301c24c92a9b7018cee20e524c4eb7192bf0Chad Rosier      if (!SizeExpr || SizeExpr->getExprLoc().isMacroID())
57995e25301c24c92a9b7018cee20e524c4eb7192bf0Chad Rosier        return false;
58005e25301c24c92a9b7018cee20e524c4eb7192bf0Chad Rosier    }
580100e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    break;
5802d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan  }
5803c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
5804c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext());
5805381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay  if (!RD) return false;
5806381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay  if (RD->isUnion()) return false;
5807381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay  if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) {
5808381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay    if (!CRD->isStandardLayout()) return false;
5809381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay  }
5810c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
581122d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer  // See if this is the last field decl in the record.
581222d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer  const Decl *D = FD;
581322d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer  while ((D = D->getNextDeclInContext()))
581422d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer    if (isa<FieldDecl>(D))
581522d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer      return false;
581622d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer  return true;
5817c268434b332bbe57950d977633369bf5822d9554Chandler Carruth}
5818c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
5819d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainvoid Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr,
582080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay                            const ArraySubscriptExpr *ASE,
582125b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith                            bool AllowOnePastEnd, bool IndexNegated) {
582292b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman  IndexExpr = IndexExpr->IgnoreParenImpCasts();
582380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay  if (IndexExpr->isValueDependent())
582480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    return;
5825d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
582680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay  const Type *EffectiveType = getElementType(BaseExpr);
582780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay  BaseExpr = BaseExpr->IgnoreParenCasts();
58283406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth  const ConstantArrayType *ArrayTy =
5829d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    Context.getAsConstantArrayType(BaseExpr->getType());
58303406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth  if (!ArrayTy)
5831a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek    return;
583235001ca261f895817916b468379b696d6d45959dChandler Carruth
58333406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth  llvm::APSInt index;
583480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay  if (!IndexExpr->EvaluateAsInt(index, Context))
5835a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek    return;
583625b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith  if (IndexNegated)
583725b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith    index = -index;
58388fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek
5839ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth  const NamedDecl *ND = NULL;
5840ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth  if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr))
5841ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    ND = dyn_cast<NamedDecl>(DRE->getDecl());
5842c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr))
5843ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    ND = dyn_cast<NamedDecl>(ME->getMemberDecl());
5844ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth
58459e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek  if (index.isUnsigned() || !index.isNegative()) {
584625b3b849e3ad340b04442707038c86980035765bTed Kremenek    llvm::APInt size = ArrayTy->getSize();
584735001ca261f895817916b468379b696d6d45959dChandler Carruth    if (!size.isStrictlyPositive())
584835001ca261f895817916b468379b696d6d45959dChandler Carruth      return;
5849d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
5850d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    const Type* BaseType = getElementType(BaseExpr);
5851de5998f1d7dcecb777257ec932142d65de636eb8Nico Weber    if (BaseType != EffectiveType) {
5852d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      // Make sure we're comparing apples to apples when comparing index to size
5853d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType);
5854d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      uint64_t array_typesize = Context.getTypeSize(BaseType);
5855d10f4bc5a05ce0cdc1646dbb0f706bb9d3dfc0c5Kaelyn Uhrain      // Handle ptrarith_typesize being zero, such as when casting to void*
585618f169770d9d3f826bad8f1359c8c5770c5ab16fKaelyn Uhrain      if (!ptrarith_typesize) ptrarith_typesize = 1;
5857d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      if (ptrarith_typesize != array_typesize) {
5858d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        // There's a cast to a different size type involved
5859d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        uint64_t ratio = array_typesize / ptrarith_typesize;
5860d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        // TODO: Be smarter about handling cases where array_typesize is not a
5861d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        // multiple of ptrarith_typesize
5862d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        if (ptrarith_typesize * ratio == array_typesize)
5863d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain          size *= llvm::APInt(size.getBitWidth(), ratio);
5864d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      }
5865d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    }
5866d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
58673406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth    if (size.getBitWidth() > index.getBitWidth())
586892b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman      index = index.zext(size.getBitWidth());
586925b3b849e3ad340b04442707038c86980035765bTed Kremenek    else if (size.getBitWidth() < index.getBitWidth())
587092b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman      size = size.zext(index.getBitWidth());
587125b3b849e3ad340b04442707038c86980035765bTed Kremenek
5872d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    // For array subscripting the index must be less than size, but for pointer
5873d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    // arithmetic also allow the index (offset) to be equal to size since
5874d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    // computing the next address after the end of the array is legal and
5875d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    // commonly done e.g. in C++ iterators and range-based for loops.
587692b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman    if (AllowOnePastEnd ? index.ule(size) : index.ult(size))
5877ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth      return;
5878ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth
5879ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    // Also don't warn for arrays of size 1 which are members of some
5880ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    // structure. These are often used to approximate flexible arrays in C89
5881ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    // code.
5882d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    if (IsTailPaddedMemberArray(*this, size, ND))
58838fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek      return;
58843406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth
588580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    // Suppress the warning if the subscript expression (as identified by the
588680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    // ']' location) and the index expression are both from macro expansions
588780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    // within a system header.
588880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    if (ASE) {
588980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay      SourceLocation RBracketLoc = SourceMgr.getSpellingLoc(
589080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay          ASE->getRBracketLoc());
589180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay      if (SourceMgr.isInSystemHeader(RBracketLoc)) {
589280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay        SourceLocation IndexLoc = SourceMgr.getSpellingLoc(
589380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay            IndexExpr->getLocStart());
589480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay        if (SourceMgr.isFromSameFile(RBracketLoc, IndexLoc))
589580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay          return;
589680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay      }
589780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    }
589880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay
5899d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds;
590080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    if (ASE)
5901d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      DiagID = diag::warn_array_index_exceeds_bounds;
5902d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
5903d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr,
5904d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                        PDiag(DiagID) << index.toString(10, true)
5905d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << size.toString(10, true)
5906d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << (unsigned)size.getLimitedValue(~0U)
5907d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << IndexExpr->getSourceRange());
59083406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth  } else {
5909d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    unsigned DiagID = diag::warn_array_index_precedes_bounds;
591080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    if (!ASE) {
5911d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      DiagID = diag::warn_ptr_arith_precedes_bounds;
5912d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      if (index.isNegative()) index = -index;
5913d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    }
5914d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
5915d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr,
5916d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                        PDiag(DiagID) << index.toString(10, true)
5917d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << IndexExpr->getSourceRange());
5918a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek  }
591935001ca261f895817916b468379b696d6d45959dChandler Carruth
5920cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay  if (!ND) {
5921cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay    // Try harder to find a NamedDecl to point at in the note.
5922cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay    while (const ArraySubscriptExpr *ASE =
5923cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay           dyn_cast<ArraySubscriptExpr>(BaseExpr))
5924cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay      BaseExpr = ASE->getBase()->IgnoreParenCasts();
5925cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay    if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr))
5926cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay      ND = dyn_cast<NamedDecl>(DRE->getDecl());
5927cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay    if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr))
5928cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay      ND = dyn_cast<NamedDecl>(ME->getMemberDecl());
5929cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay  }
5930cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay
593135001ca261f895817916b468379b696d6d45959dChandler Carruth  if (ND)
5932d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    DiagRuntimeBehavior(ND->getLocStart(), BaseExpr,
5933d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                        PDiag(diag::note_array_index_out_of_bounds)
5934d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << ND->getDeclName());
59353aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek}
59363aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek
59373aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) {
5938d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  int AllowOnePastEnd = 0;
5939d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  while (expr) {
5940d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    expr = expr->IgnoreParenImpCasts();
59413aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek    switch (expr->getStmtClass()) {
5942d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      case Stmt::ArraySubscriptExprClass: {
5943d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr);
594480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay        CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE,
5945d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                         AllowOnePastEnd > 0);
59463aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        return;
5947d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      }
5948d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      case Stmt::UnaryOperatorClass: {
5949d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        // Only unwrap the * and & unary operators
5950d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        const UnaryOperator *UO = cast<UnaryOperator>(expr);
5951d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        expr = UO->getSubExpr();
5952d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        switch (UO->getOpcode()) {
5953d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain          case UO_AddrOf:
5954d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            AllowOnePastEnd++;
5955d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            break;
5956d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain          case UO_Deref:
5957d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            AllowOnePastEnd--;
5958d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            break;
5959d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain          default:
5960d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            return;
5961d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        }
5962d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        break;
5963d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      }
59643aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek      case Stmt::ConditionalOperatorClass: {
59653aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        const ConditionalOperator *cond = cast<ConditionalOperator>(expr);
59663aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        if (const Expr *lhs = cond->getLHS())
59673aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek          CheckArrayAccess(lhs);
59683aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        if (const Expr *rhs = cond->getRHS())
59693aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek          CheckArrayAccess(rhs);
59703aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        return;
59713aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek      }
59723aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek      default:
59733aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        return;
59743aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek    }
5975f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne  }
5976a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek}
5977f85e193739c953358c865005855253af4f68a497John McCall
5978f85e193739c953358c865005855253af4f68a497John McCall//===--- CHECK: Objective-C retain cycles ----------------------------------//
5979f85e193739c953358c865005855253af4f68a497John McCall
5980f85e193739c953358c865005855253af4f68a497John McCallnamespace {
5981f85e193739c953358c865005855253af4f68a497John McCall  struct RetainCycleOwner {
5982f85e193739c953358c865005855253af4f68a497John McCall    RetainCycleOwner() : Variable(0), Indirect(false) {}
5983f85e193739c953358c865005855253af4f68a497John McCall    VarDecl *Variable;
5984f85e193739c953358c865005855253af4f68a497John McCall    SourceRange Range;
5985f85e193739c953358c865005855253af4f68a497John McCall    SourceLocation Loc;
5986f85e193739c953358c865005855253af4f68a497John McCall    bool Indirect;
5987f85e193739c953358c865005855253af4f68a497John McCall
5988f85e193739c953358c865005855253af4f68a497John McCall    void setLocsFrom(Expr *e) {
5989f85e193739c953358c865005855253af4f68a497John McCall      Loc = e->getExprLoc();
5990f85e193739c953358c865005855253af4f68a497John McCall      Range = e->getSourceRange();
5991f85e193739c953358c865005855253af4f68a497John McCall    }
5992f85e193739c953358c865005855253af4f68a497John McCall  };
5993f85e193739c953358c865005855253af4f68a497John McCall}
5994f85e193739c953358c865005855253af4f68a497John McCall
5995f85e193739c953358c865005855253af4f68a497John McCall/// Consider whether capturing the given variable can possibly lead to
5996f85e193739c953358c865005855253af4f68a497John McCall/// a retain cycle.
5997f85e193739c953358c865005855253af4f68a497John McCallstatic bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) {
5998f3477c13eeaf11b32a41f181398fb5deffd0dd73Sylvestre Ledru  // In ARC, it's captured strongly iff the variable has __strong
5999f85e193739c953358c865005855253af4f68a497John McCall  // lifetime.  In MRR, it's captured strongly if the variable is
6000f85e193739c953358c865005855253af4f68a497John McCall  // __block and has an appropriate type.
6001f85e193739c953358c865005855253af4f68a497John McCall  if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong)
6002f85e193739c953358c865005855253af4f68a497John McCall    return false;
6003f85e193739c953358c865005855253af4f68a497John McCall
6004f85e193739c953358c865005855253af4f68a497John McCall  owner.Variable = var;
6005e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose  if (ref)
6006e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose    owner.setLocsFrom(ref);
6007f85e193739c953358c865005855253af4f68a497John McCall  return true;
6008f85e193739c953358c865005855253af4f68a497John McCall}
6009f85e193739c953358c865005855253af4f68a497John McCall
60106e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanianstatic bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) {
6011f85e193739c953358c865005855253af4f68a497John McCall  while (true) {
6012f85e193739c953358c865005855253af4f68a497John McCall    e = e->IgnoreParens();
6013f85e193739c953358c865005855253af4f68a497John McCall    if (CastExpr *cast = dyn_cast<CastExpr>(e)) {
6014f85e193739c953358c865005855253af4f68a497John McCall      switch (cast->getCastKind()) {
6015f85e193739c953358c865005855253af4f68a497John McCall      case CK_BitCast:
6016f85e193739c953358c865005855253af4f68a497John McCall      case CK_LValueBitCast:
6017f85e193739c953358c865005855253af4f68a497John McCall      case CK_LValueToRValue:
601833e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall      case CK_ARCReclaimReturnedObject:
6019f85e193739c953358c865005855253af4f68a497John McCall        e = cast->getSubExpr();
6020f85e193739c953358c865005855253af4f68a497John McCall        continue;
6021f85e193739c953358c865005855253af4f68a497John McCall
6022f85e193739c953358c865005855253af4f68a497John McCall      default:
6023f85e193739c953358c865005855253af4f68a497John McCall        return false;
6024f85e193739c953358c865005855253af4f68a497John McCall      }
6025f85e193739c953358c865005855253af4f68a497John McCall    }
6026f85e193739c953358c865005855253af4f68a497John McCall
6027f85e193739c953358c865005855253af4f68a497John McCall    if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) {
6028f85e193739c953358c865005855253af4f68a497John McCall      ObjCIvarDecl *ivar = ref->getDecl();
6029f85e193739c953358c865005855253af4f68a497John McCall      if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong)
6030f85e193739c953358c865005855253af4f68a497John McCall        return false;
6031f85e193739c953358c865005855253af4f68a497John McCall
6032f85e193739c953358c865005855253af4f68a497John McCall      // Try to find a retain cycle in the base.
60336e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian      if (!findRetainCycleOwner(S, ref->getBase(), owner))
6034f85e193739c953358c865005855253af4f68a497John McCall        return false;
6035f85e193739c953358c865005855253af4f68a497John McCall
6036f85e193739c953358c865005855253af4f68a497John McCall      if (ref->isFreeIvar()) owner.setLocsFrom(ref);
6037f85e193739c953358c865005855253af4f68a497John McCall      owner.Indirect = true;
6038f85e193739c953358c865005855253af4f68a497John McCall      return true;
6039f85e193739c953358c865005855253af4f68a497John McCall    }
6040f85e193739c953358c865005855253af4f68a497John McCall
6041f85e193739c953358c865005855253af4f68a497John McCall    if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) {
6042f85e193739c953358c865005855253af4f68a497John McCall      VarDecl *var = dyn_cast<VarDecl>(ref->getDecl());
6043f85e193739c953358c865005855253af4f68a497John McCall      if (!var) return false;
6044f85e193739c953358c865005855253af4f68a497John McCall      return considerVariable(var, ref, owner);
6045f85e193739c953358c865005855253af4f68a497John McCall    }
6046f85e193739c953358c865005855253af4f68a497John McCall
6047f85e193739c953358c865005855253af4f68a497John McCall    if (MemberExpr *member = dyn_cast<MemberExpr>(e)) {
6048f85e193739c953358c865005855253af4f68a497John McCall      if (member->isArrow()) return false;
6049f85e193739c953358c865005855253af4f68a497John McCall
6050f85e193739c953358c865005855253af4f68a497John McCall      // Don't count this as an indirect ownership.
6051f85e193739c953358c865005855253af4f68a497John McCall      e = member->getBase();
6052f85e193739c953358c865005855253af4f68a497John McCall      continue;
6053f85e193739c953358c865005855253af4f68a497John McCall    }
6054f85e193739c953358c865005855253af4f68a497John McCall
60554b9c2d235fb9449e249d74f48ecfec601650de93John McCall    if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) {
60564b9c2d235fb9449e249d74f48ecfec601650de93John McCall      // Only pay attention to pseudo-objects on property references.
60574b9c2d235fb9449e249d74f48ecfec601650de93John McCall      ObjCPropertyRefExpr *pre
60584b9c2d235fb9449e249d74f48ecfec601650de93John McCall        = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm()
60594b9c2d235fb9449e249d74f48ecfec601650de93John McCall                                              ->IgnoreParens());
60604b9c2d235fb9449e249d74f48ecfec601650de93John McCall      if (!pre) return false;
60614b9c2d235fb9449e249d74f48ecfec601650de93John McCall      if (pre->isImplicitProperty()) return false;
60624b9c2d235fb9449e249d74f48ecfec601650de93John McCall      ObjCPropertyDecl *property = pre->getExplicitProperty();
60634b9c2d235fb9449e249d74f48ecfec601650de93John McCall      if (!property->isRetaining() &&
60644b9c2d235fb9449e249d74f48ecfec601650de93John McCall          !(property->getPropertyIvarDecl() &&
60654b9c2d235fb9449e249d74f48ecfec601650de93John McCall            property->getPropertyIvarDecl()->getType()
60664b9c2d235fb9449e249d74f48ecfec601650de93John McCall              .getObjCLifetime() == Qualifiers::OCL_Strong))
60674b9c2d235fb9449e249d74f48ecfec601650de93John McCall          return false;
60684b9c2d235fb9449e249d74f48ecfec601650de93John McCall
60694b9c2d235fb9449e249d74f48ecfec601650de93John McCall      owner.Indirect = true;
60706e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian      if (pre->isSuperReceiver()) {
60716e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        owner.Variable = S.getCurMethodDecl()->getSelfDecl();
60726e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        if (!owner.Variable)
60736e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian          return false;
60746e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        owner.Loc = pre->getLocation();
60756e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        owner.Range = pre->getSourceRange();
60766e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        return true;
60776e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian      }
60784b9c2d235fb9449e249d74f48ecfec601650de93John McCall      e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase())
60794b9c2d235fb9449e249d74f48ecfec601650de93John McCall                              ->getSourceExpr());
60804b9c2d235fb9449e249d74f48ecfec601650de93John McCall      continue;
60814b9c2d235fb9449e249d74f48ecfec601650de93John McCall    }
60824b9c2d235fb9449e249d74f48ecfec601650de93John McCall
6083f85e193739c953358c865005855253af4f68a497John McCall    // Array ivars?
6084f85e193739c953358c865005855253af4f68a497John McCall
6085f85e193739c953358c865005855253af4f68a497John McCall    return false;
6086f85e193739c953358c865005855253af4f68a497John McCall  }
6087f85e193739c953358c865005855253af4f68a497John McCall}
6088f85e193739c953358c865005855253af4f68a497John McCall
6089f85e193739c953358c865005855253af4f68a497John McCallnamespace {
6090f85e193739c953358c865005855253af4f68a497John McCall  struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> {
6091f85e193739c953358c865005855253af4f68a497John McCall    FindCaptureVisitor(ASTContext &Context, VarDecl *variable)
6092f85e193739c953358c865005855253af4f68a497John McCall      : EvaluatedExprVisitor<FindCaptureVisitor>(Context),
6093f85e193739c953358c865005855253af4f68a497John McCall        Variable(variable), Capturer(0) {}
6094f85e193739c953358c865005855253af4f68a497John McCall
6095f85e193739c953358c865005855253af4f68a497John McCall    VarDecl *Variable;
6096f85e193739c953358c865005855253af4f68a497John McCall    Expr *Capturer;
6097f85e193739c953358c865005855253af4f68a497John McCall
6098f85e193739c953358c865005855253af4f68a497John McCall    void VisitDeclRefExpr(DeclRefExpr *ref) {
6099f85e193739c953358c865005855253af4f68a497John McCall      if (ref->getDecl() == Variable && !Capturer)
6100f85e193739c953358c865005855253af4f68a497John McCall        Capturer = ref;
6101f85e193739c953358c865005855253af4f68a497John McCall    }
6102f85e193739c953358c865005855253af4f68a497John McCall
6103f85e193739c953358c865005855253af4f68a497John McCall    void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) {
6104f85e193739c953358c865005855253af4f68a497John McCall      if (Capturer) return;
6105f85e193739c953358c865005855253af4f68a497John McCall      Visit(ref->getBase());
6106f85e193739c953358c865005855253af4f68a497John McCall      if (Capturer && ref->isFreeIvar())
6107f85e193739c953358c865005855253af4f68a497John McCall        Capturer = ref;
6108f85e193739c953358c865005855253af4f68a497John McCall    }
6109f85e193739c953358c865005855253af4f68a497John McCall
6110f85e193739c953358c865005855253af4f68a497John McCall    void VisitBlockExpr(BlockExpr *block) {
6111f85e193739c953358c865005855253af4f68a497John McCall      // Look inside nested blocks
6112f85e193739c953358c865005855253af4f68a497John McCall      if (block->getBlockDecl()->capturesVariable(Variable))
6113f85e193739c953358c865005855253af4f68a497John McCall        Visit(block->getBlockDecl()->getBody());
6114f85e193739c953358c865005855253af4f68a497John McCall    }
61157e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian
61167e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian    void VisitOpaqueValueExpr(OpaqueValueExpr *OVE) {
61177e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian      if (Capturer) return;
61187e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian      if (OVE->getSourceExpr())
61197e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian        Visit(OVE->getSourceExpr());
61207e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian    }
6121f85e193739c953358c865005855253af4f68a497John McCall  };
6122f85e193739c953358c865005855253af4f68a497John McCall}
6123f85e193739c953358c865005855253af4f68a497John McCall
6124f85e193739c953358c865005855253af4f68a497John McCall/// Check whether the given argument is a block which captures a
6125f85e193739c953358c865005855253af4f68a497John McCall/// variable.
6126f85e193739c953358c865005855253af4f68a497John McCallstatic Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) {
6127f85e193739c953358c865005855253af4f68a497John McCall  assert(owner.Variable && owner.Loc.isValid());
6128f85e193739c953358c865005855253af4f68a497John McCall
6129f85e193739c953358c865005855253af4f68a497John McCall  e = e->IgnoreParenCasts();
61301fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose
61311fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose  // Look through [^{...} copy] and Block_copy(^{...}).
61321fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose  if (ObjCMessageExpr *ME = dyn_cast<ObjCMessageExpr>(e)) {
61331fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose    Selector Cmd = ME->getSelector();
61341fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose    if (Cmd.isUnarySelector() && Cmd.getNameForSlot(0) == "copy") {
61351fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose      e = ME->getInstanceReceiver();
61361fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose      if (!e)
61371fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose        return 0;
61381fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose      e = e->IgnoreParenCasts();
61391fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose    }
61401fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose  } else if (CallExpr *CE = dyn_cast<CallExpr>(e)) {
61411fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose    if (CE->getNumArgs() == 1) {
61421fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose      FunctionDecl *Fn = dyn_cast_or_null<FunctionDecl>(CE->getCalleeDecl());
6143d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek      if (Fn) {
6144d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek        const IdentifierInfo *FnI = Fn->getIdentifier();
6145d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek        if (FnI && FnI->isStr("_Block_copy")) {
6146d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek          e = CE->getArg(0)->IgnoreParenCasts();
6147d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek        }
6148d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek      }
61491fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose    }
61501fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose  }
61511fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose
6152f85e193739c953358c865005855253af4f68a497John McCall  BlockExpr *block = dyn_cast<BlockExpr>(e);
6153f85e193739c953358c865005855253af4f68a497John McCall  if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable))
6154f85e193739c953358c865005855253af4f68a497John McCall    return 0;
6155f85e193739c953358c865005855253af4f68a497John McCall
6156f85e193739c953358c865005855253af4f68a497John McCall  FindCaptureVisitor visitor(S.Context, owner.Variable);
6157f85e193739c953358c865005855253af4f68a497John McCall  visitor.Visit(block->getBlockDecl()->getBody());
6158f85e193739c953358c865005855253af4f68a497John McCall  return visitor.Capturer;
6159f85e193739c953358c865005855253af4f68a497John McCall}
6160f85e193739c953358c865005855253af4f68a497John McCall
6161f85e193739c953358c865005855253af4f68a497John McCallstatic void diagnoseRetainCycle(Sema &S, Expr *capturer,
6162f85e193739c953358c865005855253af4f68a497John McCall                                RetainCycleOwner &owner) {
6163f85e193739c953358c865005855253af4f68a497John McCall  assert(capturer);
6164f85e193739c953358c865005855253af4f68a497John McCall  assert(owner.Variable && owner.Loc.isValid());
6165f85e193739c953358c865005855253af4f68a497John McCall
6166f85e193739c953358c865005855253af4f68a497John McCall  S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle)
6167f85e193739c953358c865005855253af4f68a497John McCall    << owner.Variable << capturer->getSourceRange();
6168f85e193739c953358c865005855253af4f68a497John McCall  S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner)
6169f85e193739c953358c865005855253af4f68a497John McCall    << owner.Indirect << owner.Range;
6170f85e193739c953358c865005855253af4f68a497John McCall}
6171f85e193739c953358c865005855253af4f68a497John McCall
6172f85e193739c953358c865005855253af4f68a497John McCall/// Check for a keyword selector that starts with the word 'add' or
6173f85e193739c953358c865005855253af4f68a497John McCall/// 'set'.
6174f85e193739c953358c865005855253af4f68a497John McCallstatic bool isSetterLikeSelector(Selector sel) {
6175f85e193739c953358c865005855253af4f68a497John McCall  if (sel.isUnarySelector()) return false;
6176f85e193739c953358c865005855253af4f68a497John McCall
61775f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner  StringRef str = sel.getNameForSlot(0);
6178f85e193739c953358c865005855253af4f68a497John McCall  while (!str.empty() && str.front() == '_') str = str.substr(1);
6179968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek  if (str.startswith("set"))
6180f85e193739c953358c865005855253af4f68a497John McCall    str = str.substr(3);
6181968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek  else if (str.startswith("add")) {
6182968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek    // Specially whitelist 'addOperationWithBlock:'.
6183968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek    if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock"))
6184968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek      return false;
6185968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek    str = str.substr(3);
6186968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek  }
6187f85e193739c953358c865005855253af4f68a497John McCall  else
6188f85e193739c953358c865005855253af4f68a497John McCall    return false;
6189f85e193739c953358c865005855253af4f68a497John McCall
6190f85e193739c953358c865005855253af4f68a497John McCall  if (str.empty()) return true;
61913f6f51e28231f65de9c2dd150a2d757b2162cfa3Jordan Rose  return !isLowercase(str.front());
6192f85e193739c953358c865005855253af4f68a497John McCall}
6193f85e193739c953358c865005855253af4f68a497John McCall
6194f85e193739c953358c865005855253af4f68a497John McCall/// Check a message send to see if it's likely to cause a retain cycle.
6195f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(ObjCMessageExpr *msg) {
6196f85e193739c953358c865005855253af4f68a497John McCall  // Only check instance methods whose selector looks like a setter.
6197f85e193739c953358c865005855253af4f68a497John McCall  if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector()))
6198f85e193739c953358c865005855253af4f68a497John McCall    return;
6199f85e193739c953358c865005855253af4f68a497John McCall
6200f85e193739c953358c865005855253af4f68a497John McCall  // Try to find a variable that the receiver is strongly owned by.
6201f85e193739c953358c865005855253af4f68a497John McCall  RetainCycleOwner owner;
6202f85e193739c953358c865005855253af4f68a497John McCall  if (msg->getReceiverKind() == ObjCMessageExpr::Instance) {
62036e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian    if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner))
6204f85e193739c953358c865005855253af4f68a497John McCall      return;
6205f85e193739c953358c865005855253af4f68a497John McCall  } else {
6206f85e193739c953358c865005855253af4f68a497John McCall    assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance);
6207f85e193739c953358c865005855253af4f68a497John McCall    owner.Variable = getCurMethodDecl()->getSelfDecl();
6208f85e193739c953358c865005855253af4f68a497John McCall    owner.Loc = msg->getSuperLoc();
6209f85e193739c953358c865005855253af4f68a497John McCall    owner.Range = msg->getSuperLoc();
6210f85e193739c953358c865005855253af4f68a497John McCall  }
6211f85e193739c953358c865005855253af4f68a497John McCall
6212f85e193739c953358c865005855253af4f68a497John McCall  // Check whether the receiver is captured by any of the arguments.
6213f85e193739c953358c865005855253af4f68a497John McCall  for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i)
6214f85e193739c953358c865005855253af4f68a497John McCall    if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner))
6215f85e193739c953358c865005855253af4f68a497John McCall      return diagnoseRetainCycle(*this, capturer, owner);
6216f85e193739c953358c865005855253af4f68a497John McCall}
6217f85e193739c953358c865005855253af4f68a497John McCall
6218f85e193739c953358c865005855253af4f68a497John McCall/// Check a property assign to see if it's likely to cause a retain cycle.
6219f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(Expr *receiver, Expr *argument) {
6220f85e193739c953358c865005855253af4f68a497John McCall  RetainCycleOwner owner;
62216e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian  if (!findRetainCycleOwner(*this, receiver, owner))
6222f85e193739c953358c865005855253af4f68a497John McCall    return;
6223f85e193739c953358c865005855253af4f68a497John McCall
6224f85e193739c953358c865005855253af4f68a497John McCall  if (Expr *capturer = findCapturingExpr(*this, argument, owner))
6225f85e193739c953358c865005855253af4f68a497John McCall    diagnoseRetainCycle(*this, capturer, owner);
6226f85e193739c953358c865005855253af4f68a497John McCall}
6227f85e193739c953358c865005855253af4f68a497John McCall
6228e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rosevoid Sema::checkRetainCycles(VarDecl *Var, Expr *Init) {
6229e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose  RetainCycleOwner Owner;
6230e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose  if (!considerVariable(Var, /*DeclRefExpr=*/0, Owner))
6231e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose    return;
6232e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose
6233e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose  // Because we don't have an expression for the variable, we have to set the
6234e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose  // location explicitly here.
6235e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose  Owner.Loc = Var->getLocation();
6236e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose  Owner.Range = Var->getSourceRange();
6237e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose
6238e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose  if (Expr *Capturer = findCapturingExpr(*this, Init, Owner))
6239e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose    diagnoseRetainCycle(*this, Capturer, Owner);
6240e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose}
6241e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose
62429d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenekstatic bool checkUnsafeAssignLiteral(Sema &S, SourceLocation Loc,
62439d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek                                     Expr *RHS, bool isProperty) {
62449d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek  // Check if RHS is an Objective-C object literal, which also can get
62459d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek  // immediately zapped in a weak reference.  Note that we explicitly
62469d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek  // allow ObjCStringLiterals, since those are designed to never really die.
62479d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek  RHS = RHS->IgnoreParenImpCasts();
6248f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek
6249d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek  // This enum needs to match with the 'select' in
6250d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek  // warn_objc_arc_literal_assign (off-by-1).
6251d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek  Sema::ObjCLiteralKind Kind = S.CheckLiteralKind(RHS);
6252d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek  if (Kind == Sema::LK_String || Kind == Sema::LK_None)
6253d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek    return false;
6254f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek
6255f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek  S.Diag(Loc, diag::warn_arc_literal_assign)
6256d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek    << (unsigned) Kind
62579d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek    << (isProperty ? 0 : 1)
62589d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek    << RHS->getSourceRange();
6259f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek
6260f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek  return true;
62619d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek}
62629d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek
6263b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenekstatic bool checkUnsafeAssignObject(Sema &S, SourceLocation Loc,
6264b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek                                    Qualifiers::ObjCLifetime LT,
6265b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek                                    Expr *RHS, bool isProperty) {
6266b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek  // Strip off any implicit cast added to get to the one ARC-specific.
6267b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek  while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
6268b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek    if (cast->getCastKind() == CK_ARCConsumeObject) {
6269b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek      S.Diag(Loc, diag::warn_arc_retained_assign)
6270b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek        << (LT == Qualifiers::OCL_ExplicitNone)
6271b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek        << (isProperty ? 0 : 1)
6272b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek        << RHS->getSourceRange();
6273b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek      return true;
6274b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek    }
6275b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek    RHS = cast->getSubExpr();
6276b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek  }
6277b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek
6278b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek  if (LT == Qualifiers::OCL_Weak &&
6279b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek      checkUnsafeAssignLiteral(S, Loc, RHS, isProperty))
6280b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek    return true;
6281b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek
6282b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek  return false;
6283b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek}
6284b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek
6285b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenekbool Sema::checkUnsafeAssigns(SourceLocation Loc,
6286b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek                              QualType LHS, Expr *RHS) {
6287b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek  Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime();
6288b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek
6289b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek  if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone)
6290b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek    return false;
6291b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek
6292b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek  if (checkUnsafeAssignObject(*this, Loc, LT, RHS, false))
6293b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek    return true;
6294b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek
6295b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek  return false;
6296b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek}
6297b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek
6298921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianvoid Sema::checkUnsafeExprAssigns(SourceLocation Loc,
6299921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian                              Expr *LHS, Expr *RHS) {
630087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  QualType LHSType;
630187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  // PropertyRef on LHS type need be directly obtained from
630287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  // its declaration as it has a PsuedoType.
630387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  ObjCPropertyRefExpr *PRE
630487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens());
630587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  if (PRE && !PRE->isImplicitProperty()) {
630687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    const ObjCPropertyDecl *PD = PRE->getExplicitProperty();
630787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    if (PD)
630887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      LHSType = PD->getType();
630987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  }
631087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian
631187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  if (LHSType.isNull())
631287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    LHSType = LHS->getType();
63137a2704800943fbb69207e125d28186278712af36Jordan Rose
63147a2704800943fbb69207e125d28186278712af36Jordan Rose  Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime();
63157a2704800943fbb69207e125d28186278712af36Jordan Rose
63167a2704800943fbb69207e125d28186278712af36Jordan Rose  if (LT == Qualifiers::OCL_Weak) {
63177a2704800943fbb69207e125d28186278712af36Jordan Rose    DiagnosticsEngine::Level Level =
63187a2704800943fbb69207e125d28186278712af36Jordan Rose      Diags.getDiagnosticLevel(diag::warn_arc_repeated_use_of_weak, Loc);
63197a2704800943fbb69207e125d28186278712af36Jordan Rose    if (Level != DiagnosticsEngine::Ignored)
63207a2704800943fbb69207e125d28186278712af36Jordan Rose      getCurFunction()->markSafeWeakUse(LHS);
63217a2704800943fbb69207e125d28186278712af36Jordan Rose  }
63227a2704800943fbb69207e125d28186278712af36Jordan Rose
6323921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  if (checkUnsafeAssigns(Loc, LHSType, RHS))
6324921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    return;
63257a2704800943fbb69207e125d28186278712af36Jordan Rose
6326921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  // FIXME. Check for other life times.
6327921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  if (LT != Qualifiers::OCL_None)
6328921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    return;
6329921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian
633087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  if (PRE) {
6331921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    if (PRE->isImplicitProperty())
6332921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian      return;
6333921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    const ObjCPropertyDecl *PD = PRE->getExplicitProperty();
6334921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    if (!PD)
6335921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian      return;
6336921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian
6337ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling    unsigned Attributes = PD->getPropertyAttributes();
6338ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling    if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) {
633987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      // when 'assign' attribute was not explicitly specified
634087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      // by user, ignore it and rely on property type itself
634187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      // for lifetime info.
634287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten();
634387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) &&
634487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian          LHSType->isObjCRetainableType())
634587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian        return;
634687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian
6347921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian      while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
634833e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall        if (cast->getCastKind() == CK_ARCConsumeObject) {
6349921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian          Diag(Loc, diag::warn_arc_retained_property_assign)
6350921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian          << RHS->getSourceRange();
6351921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian          return;
6352921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian        }
6353921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian        RHS = cast->getSubExpr();
6354921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian      }
635587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    }
6356ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling    else if (Attributes & ObjCPropertyDecl::OBJC_PR_weak) {
6357b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek      if (checkUnsafeAssignObject(*this, Loc, Qualifiers::OCL_Weak, RHS, true))
6358b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek        return;
6359bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian    }
6360921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  }
6361921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian}
6362625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
6363625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko//===--- CHECK: Empty statement body (-Wempty-body) ---------------------===//
6364625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
6365625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkonamespace {
6366625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkobool ShouldDiagnoseEmptyStmtBody(const SourceManager &SourceMgr,
6367625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 SourceLocation StmtLoc,
6368625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 const NullStmt *Body) {
6369625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Do not warn if the body is a macro that expands to nothing, e.g:
6370625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //
6371625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // #define CALL(x)
6372625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // if (condition)
6373625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //   CALL(0);
6374625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //
6375625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (Body->hasLeadingEmptyMacro())
6376625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return false;
6377625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
6378625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Get line numbers of statement and body.
6379625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  bool StmtLineInvalid;
6380625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  unsigned StmtLine = SourceMgr.getSpellingLineNumber(StmtLoc,
6381625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                                      &StmtLineInvalid);
6382625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (StmtLineInvalid)
6383625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return false;
6384625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
6385625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  bool BodyLineInvalid;
6386625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  unsigned BodyLine = SourceMgr.getSpellingLineNumber(Body->getSemiLoc(),
6387625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                                      &BodyLineInvalid);
6388625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (BodyLineInvalid)
6389625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return false;
6390625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
6391625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Warn if null statement and body are on the same line.
6392625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (StmtLine != BodyLine)
6393625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return false;
6394625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
6395625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  return true;
6396625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko}
6397625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} // Unnamed namespace
6398625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
6399625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyStmtBody(SourceLocation StmtLoc,
6400625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 const Stmt *Body,
6401625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 unsigned DiagID) {
6402625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Since this is a syntactic check, don't emit diagnostic for template
6403625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // instantiations, this just adds noise.
6404625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (CurrentInstantiationScope)
6405625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
6406625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
6407625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // The body should be a null statement.
6408625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  const NullStmt *NBody = dyn_cast<NullStmt>(Body);
6409625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!NBody)
6410625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
6411625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
6412625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Do the usual checks.
6413625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody))
6414625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
6415625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
6416625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  Diag(NBody->getSemiLoc(), DiagID);
6417625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line);
6418625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko}
6419625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
6420625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyLoopBody(const Stmt *S,
6421625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 const Stmt *PossibleBody) {
6422625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  assert(!CurrentInstantiationScope); // Ensured by caller
6423625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
6424625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  SourceLocation StmtLoc;
6425625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  const Stmt *Body;
6426625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  unsigned DiagID;
6427625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (const ForStmt *FS = dyn_cast<ForStmt>(S)) {
6428625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    StmtLoc = FS->getRParenLoc();
6429625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    Body = FS->getBody();
6430625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    DiagID = diag::warn_empty_for_body;
6431625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  } else if (const WhileStmt *WS = dyn_cast<WhileStmt>(S)) {
6432625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    StmtLoc = WS->getCond()->getSourceRange().getEnd();
6433625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    Body = WS->getBody();
6434625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    DiagID = diag::warn_empty_while_body;
6435625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  } else
6436625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return; // Neither `for' nor `while'.
6437625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
6438625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // The body should be a null statement.
6439625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  const NullStmt *NBody = dyn_cast<NullStmt>(Body);
6440625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!NBody)
6441625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
6442625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
6443625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Skip expensive checks if diagnostic is disabled.
6444625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (Diags.getDiagnosticLevel(DiagID, NBody->getSemiLoc()) ==
6445625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko          DiagnosticsEngine::Ignored)
6446625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
6447625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
6448625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Do the usual checks.
6449625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody))
6450625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
6451625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
6452625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // `for(...);' and `while(...);' are popular idioms, so in order to keep
6453625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // noise level low, emit diagnostics only if for/while is followed by a
6454625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // CompoundStmt, e.g.:
6455625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //    for (int i = 0; i < n; i++);
6456625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //    {
6457625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //      a(i);
6458625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //    }
6459625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // or if for/while is followed by a statement with more indentation
6460625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // than for/while itself:
6461625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //    for (int i = 0; i < n; i++);
6462625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //      a(i);
6463625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  bool ProbableTypo = isa<CompoundStmt>(PossibleBody);
6464625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!ProbableTypo) {
6465625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    bool BodyColInvalid;
6466625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    unsigned BodyCol = SourceMgr.getPresumedColumnNumber(
6467625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                             PossibleBody->getLocStart(),
6468625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                             &BodyColInvalid);
6469625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    if (BodyColInvalid)
6470625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko      return;
6471625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
6472625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    bool StmtColInvalid;
6473625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    unsigned StmtCol = SourceMgr.getPresumedColumnNumber(
6474625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                             S->getLocStart(),
6475625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                             &StmtColInvalid);
6476625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    if (StmtColInvalid)
6477625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko      return;
6478625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
6479625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    if (BodyCol > StmtCol)
6480625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko      ProbableTypo = true;
6481625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  }
6482625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
6483625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (ProbableTypo) {
6484625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    Diag(NBody->getSemiLoc(), DiagID);
6485625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line);
6486625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  }
6487625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko}
64880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
64890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- Layout compatibility ----------------------------------------------//
64900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
64910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace {
64920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
64930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2);
64940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
64950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two enumeration types are layout-compatible.
64960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, EnumDecl *ED1, EnumDecl *ED2) {
64970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // C++11 [dcl.enum] p8:
64980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // Two enumeration types are layout-compatible if they have the same
64990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // underlying type.
65000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return ED1->isComplete() && ED2->isComplete() &&
65010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         C.hasSameType(ED1->getIntegerType(), ED2->getIntegerType());
65020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
65030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
65040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two fields are layout-compatible.
65050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, FieldDecl *Field1, FieldDecl *Field2) {
65060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!isLayoutCompatible(C, Field1->getType(), Field2->getType()))
65070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
65080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
65090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (Field1->isBitField() != Field2->isBitField())
65100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
65110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
65120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (Field1->isBitField()) {
65130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // Make sure that the bit-fields are the same length.
65140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    unsigned Bits1 = Field1->getBitWidthValue(C);
65150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    unsigned Bits2 = Field2->getBitWidthValue(C);
65160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
65170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (Bits1 != Bits2)
65180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
65190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
65200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
65210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return true;
65220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
65230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
65240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout structs are layout-compatible.
65250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p17)
65260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleStruct(ASTContext &C,
65270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                              RecordDecl *RD1,
65280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                              RecordDecl *RD2) {
65290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // If both records are C++ classes, check that base classes match.
65300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (const CXXRecordDecl *D1CXX = dyn_cast<CXXRecordDecl>(RD1)) {
65310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // If one of records is a CXXRecordDecl we are in C++ mode,
65320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // thus the other one is a CXXRecordDecl, too.
65330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    const CXXRecordDecl *D2CXX = cast<CXXRecordDecl>(RD2);
65340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // Check number of base classes.
65350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (D1CXX->getNumBases() != D2CXX->getNumBases())
65360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
65370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
65380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // Check the base classes.
65390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    for (CXXRecordDecl::base_class_const_iterator
65400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko               Base1 = D1CXX->bases_begin(),
65410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko           BaseEnd1 = D1CXX->bases_end(),
65420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko              Base2 = D2CXX->bases_begin();
65430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         Base1 != BaseEnd1;
65440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         ++Base1, ++Base2) {
65450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (!isLayoutCompatible(C, Base1->getType(), Base2->getType()))
65460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        return false;
65470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
65480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  } else if (const CXXRecordDecl *D2CXX = dyn_cast<CXXRecordDecl>(RD2)) {
65490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // If only RD2 is a C++ class, it should have zero base classes.
65500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (D2CXX->getNumBases() > 0)
65510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
65520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
65530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
65540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // Check the fields.
65550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  RecordDecl::field_iterator Field2 = RD2->field_begin(),
65560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                             Field2End = RD2->field_end(),
65570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                             Field1 = RD1->field_begin(),
65580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                             Field1End = RD1->field_end();
65590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  for ( ; Field1 != Field1End && Field2 != Field2End; ++Field1, ++Field2) {
65600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (!isLayoutCompatible(C, *Field1, *Field2))
65610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
65620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
65630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (Field1 != Field1End || Field2 != Field2End)
65640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
65650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
65660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return true;
65670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
65680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
65690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout unions are layout-compatible.
65700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p18)
65710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleUnion(ASTContext &C,
65720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                             RecordDecl *RD1,
65730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                             RecordDecl *RD2) {
65740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  llvm::SmallPtrSet<FieldDecl *, 8> UnmatchedFields;
65750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  for (RecordDecl::field_iterator Field2 = RD2->field_begin(),
65760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                  Field2End = RD2->field_end();
65770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko       Field2 != Field2End; ++Field2) {
65780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    UnmatchedFields.insert(*Field2);
65790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
65800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
65810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  for (RecordDecl::field_iterator Field1 = RD1->field_begin(),
65820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                  Field1End = RD1->field_end();
65830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko       Field1 != Field1End; ++Field1) {
65840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    llvm::SmallPtrSet<FieldDecl *, 8>::iterator
65850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        I = UnmatchedFields.begin(),
65860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        E = UnmatchedFields.end();
65870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
65880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    for ( ; I != E; ++I) {
65890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (isLayoutCompatible(C, *Field1, *I)) {
65900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        bool Result = UnmatchedFields.erase(*I);
65910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        (void) Result;
65920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        assert(Result);
65930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        break;
65940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      }
65950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
65960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (I == E)
65970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
65980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
65990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
66000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return UnmatchedFields.empty();
66010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
66020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
66030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, RecordDecl *RD1, RecordDecl *RD2) {
66040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (RD1->isUnion() != RD2->isUnion())
66050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
66060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
66070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (RD1->isUnion())
66080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return isLayoutCompatibleUnion(C, RD1, RD2);
66090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  else
66100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return isLayoutCompatibleStruct(C, RD1, RD2);
66110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
66120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
66130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two types are layout-compatible in C++11 sense.
66140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2) {
66150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (T1.isNull() || T2.isNull())
66160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
66170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
66180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // C++11 [basic.types] p11:
66190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // If two types T1 and T2 are the same type, then T1 and T2 are
66200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // layout-compatible types.
66210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (C.hasSameType(T1, T2))
66220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return true;
66230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
66240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  T1 = T1.getCanonicalType().getUnqualifiedType();
66250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  T2 = T2.getCanonicalType().getUnqualifiedType();
66260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
66270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const Type::TypeClass TC1 = T1->getTypeClass();
66280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const Type::TypeClass TC2 = T2->getTypeClass();
66290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
66300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (TC1 != TC2)
66310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
66320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
66330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (TC1 == Type::Enum) {
66340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return isLayoutCompatible(C,
66350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                              cast<EnumType>(T1)->getDecl(),
66360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                              cast<EnumType>(T2)->getDecl());
66370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  } else if (TC1 == Type::Record) {
66380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (!T1->isStandardLayoutType() || !T2->isStandardLayoutType())
66390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
66400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
66410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return isLayoutCompatible(C,
66420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                              cast<RecordType>(T1)->getDecl(),
66430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                              cast<RecordType>(T2)->getDecl());
66440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
66450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
66460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return false;
66470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
66480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
66490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
66500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- CHECK: pointer_with_type_tag attribute: datatypes should match ----//
66510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
66520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace {
66530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Given a type tag expression find the type tag itself.
66540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
66550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Type tag expression, as it appears in user's code.
66560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
66570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param VD Declaration of an identifier that appears in a type tag.
66580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
66590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValue Type tag magic value.
66600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool FindTypeTagExpr(const Expr *TypeExpr, const ASTContext &Ctx,
66610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                     const ValueDecl **VD, uint64_t *MagicValue) {
66620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  while(true) {
66630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (!TypeExpr)
66640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
66650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
66660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    TypeExpr = TypeExpr->IgnoreParenImpCasts()->IgnoreParenCasts();
66670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
66680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    switch (TypeExpr->getStmtClass()) {
66690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    case Stmt::UnaryOperatorClass: {
66700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      const UnaryOperator *UO = cast<UnaryOperator>(TypeExpr);
66710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (UO->getOpcode() == UO_AddrOf || UO->getOpcode() == UO_Deref) {
66720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        TypeExpr = UO->getSubExpr();
66730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        continue;
66740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      }
66750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
66760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
66770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
66780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    case Stmt::DeclRefExprClass: {
66790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      const DeclRefExpr *DRE = cast<DeclRefExpr>(TypeExpr);
66800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      *VD = DRE->getDecl();
66810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return true;
66820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
66830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
66840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    case Stmt::IntegerLiteralClass: {
66850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      const IntegerLiteral *IL = cast<IntegerLiteral>(TypeExpr);
66860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      llvm::APInt MagicValueAPInt = IL->getValue();
66870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (MagicValueAPInt.getActiveBits() <= 64) {
66880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        *MagicValue = MagicValueAPInt.getZExtValue();
66890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        return true;
66900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      } else
66910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        return false;
66920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
66930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
66940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    case Stmt::BinaryConditionalOperatorClass:
66950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    case Stmt::ConditionalOperatorClass: {
66960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      const AbstractConditionalOperator *ACO =
66970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          cast<AbstractConditionalOperator>(TypeExpr);
66980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      bool Result;
66990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (ACO->getCond()->EvaluateAsBooleanCondition(Result, Ctx)) {
67000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        if (Result)
67010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          TypeExpr = ACO->getTrueExpr();
67020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        else
67030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          TypeExpr = ACO->getFalseExpr();
67040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        continue;
67050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      }
67060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
67070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
67080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
67090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    case Stmt::BinaryOperatorClass: {
67100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      const BinaryOperator *BO = cast<BinaryOperator>(TypeExpr);
67110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (BO->getOpcode() == BO_Comma) {
67120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        TypeExpr = BO->getRHS();
67130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        continue;
67140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      }
67150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
67160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
67170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
67180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    default:
67190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
67200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
67210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
67220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
67230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
67240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Retrieve the C type corresponding to type tag TypeExpr.
67250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
67260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Expression that specifies a type tag.
67270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
67280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValues Registered magic values.
67290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
67300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param FoundWrongKind Set to true if a type tag was found, but of a wrong
67310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///        kind.
67320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
67330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeInfo Information about the corresponding C type.
67340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
67350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \returns true if the corresponding C type was found.
67360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool GetMatchingCType(
67370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        const IdentifierInfo *ArgumentKind,
67380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        const Expr *TypeExpr, const ASTContext &Ctx,
67390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        const llvm::DenseMap<Sema::TypeTagMagicValue,
67400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                             Sema::TypeTagData> *MagicValues,
67410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        bool &FoundWrongKind,
67420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        Sema::TypeTagData &TypeInfo) {
67430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  FoundWrongKind = false;
67440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
67450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // Variable declaration that has type_tag_for_datatype attribute.
67460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const ValueDecl *VD = NULL;
67470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
67480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  uint64_t MagicValue;
67490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
67500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!FindTypeTagExpr(TypeExpr, Ctx, &VD, &MagicValue))
67510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
67520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
67530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (VD) {
67540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    for (specific_attr_iterator<TypeTagForDatatypeAttr>
67550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko             I = VD->specific_attr_begin<TypeTagForDatatypeAttr>(),
67560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko             E = VD->specific_attr_end<TypeTagForDatatypeAttr>();
67570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         I != E; ++I) {
67580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (I->getArgumentKind() != ArgumentKind) {
67590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        FoundWrongKind = true;
67600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        return false;
67610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      }
67620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      TypeInfo.Type = I->getMatchingCType();
67630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      TypeInfo.LayoutCompatible = I->getLayoutCompatible();
67640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      TypeInfo.MustBeNull = I->getMustBeNull();
67650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return true;
67660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
67670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
67680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
67690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
67700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!MagicValues)
67710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
67720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
67730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  llvm::DenseMap<Sema::TypeTagMagicValue,
67740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                 Sema::TypeTagData>::const_iterator I =
67750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      MagicValues->find(std::make_pair(ArgumentKind, MagicValue));
67760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (I == MagicValues->end())
67770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
67780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
67790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  TypeInfo = I->second;
67800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return true;
67810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
67820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace
67830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
67840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::RegisterTypeTagForDatatype(const IdentifierInfo *ArgumentKind,
67850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                      uint64_t MagicValue, QualType Type,
67860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                      bool LayoutCompatible,
67870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                      bool MustBeNull) {
67880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!TypeTagForDatatypeMagicValues)
67890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    TypeTagForDatatypeMagicValues.reset(
67900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        new llvm::DenseMap<TypeTagMagicValue, TypeTagData>);
67910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
67920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  TypeTagMagicValue Magic(ArgumentKind, MagicValue);
67930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  (*TypeTagForDatatypeMagicValues)[Magic] =
67940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      TypeTagData(Type, LayoutCompatible, MustBeNull);
67950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
67960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
67970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace {
67980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool IsSameCharType(QualType T1, QualType T2) {
67990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const BuiltinType *BT1 = T1->getAs<BuiltinType>();
68000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!BT1)
68010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
68020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
68030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const BuiltinType *BT2 = T2->getAs<BuiltinType>();
68040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!BT2)
68050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
68060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
68070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  BuiltinType::Kind T1Kind = BT1->getKind();
68080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  BuiltinType::Kind T2Kind = BT2->getKind();
68090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
68100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return (T1Kind == BuiltinType::SChar  && T2Kind == BuiltinType::Char_S) ||
68110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         (T1Kind == BuiltinType::UChar  && T2Kind == BuiltinType::Char_U) ||
68120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         (T1Kind == BuiltinType::Char_U && T2Kind == BuiltinType::UChar) ||
68130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         (T1Kind == BuiltinType::Char_S && T2Kind == BuiltinType::SChar);
68140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
68150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace
68160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
68170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::CheckArgumentWithTypeTag(const ArgumentWithTypeTagAttr *Attr,
68180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                    const Expr * const *ExprArgs) {
68190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const IdentifierInfo *ArgumentKind = Attr->getArgumentKind();
68200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  bool IsPointerAttr = Attr->getIsPointer();
68210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
68220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const Expr *TypeTagExpr = ExprArgs[Attr->getTypeTagIdx()];
68230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  bool FoundWrongKind;
68240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  TypeTagData TypeInfo;
68250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!GetMatchingCType(ArgumentKind, TypeTagExpr, Context,
68260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                        TypeTagForDatatypeMagicValues.get(),
68270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                        FoundWrongKind, TypeInfo)) {
68280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (FoundWrongKind)
68290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      Diag(TypeTagExpr->getExprLoc(),
68300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko           diag::warn_type_tag_for_datatype_wrong_kind)
68310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        << TypeTagExpr->getSourceRange();
68320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return;
68330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
68340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
68350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const Expr *ArgumentExpr = ExprArgs[Attr->getArgumentIdx()];
68360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (IsPointerAttr) {
68370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // Skip implicit cast of pointer to `void *' (as a function argument).
68380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(ArgumentExpr))
68395a24980d059cd9fbe8375a4c549313101ad20698Dmitri Gribenko      if (ICE->getType()->isVoidPointerType() &&
6840b57ce4e8918656f5f4070f59d74354fcefbbb6f8Dmitri Gribenko          ICE->getCastKind() == CK_BitCast)
68410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        ArgumentExpr = ICE->getSubExpr();
68420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
68430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  QualType ArgumentType = ArgumentExpr->getType();
68440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
68450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // Passing a `void*' pointer shouldn't trigger a warning.
68460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (IsPointerAttr && ArgumentType->isVoidPointerType())
68470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return;
68480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
68490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (TypeInfo.MustBeNull) {
68500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // Type tag with matching void type requires a null pointer.
68510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (!ArgumentExpr->isNullPointerConstant(Context,
68520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                             Expr::NPC_ValueDependentIsNotNull)) {
68530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      Diag(ArgumentExpr->getExprLoc(),
68540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko           diag::warn_type_safety_null_pointer_required)
68550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          << ArgumentKind->getName()
68560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          << ArgumentExpr->getSourceRange()
68570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          << TypeTagExpr->getSourceRange();
68580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
68590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return;
68600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
68610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
68620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  QualType RequiredType = TypeInfo.Type;
68630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (IsPointerAttr)
68640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    RequiredType = Context.getPointerType(RequiredType);
68650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
68660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  bool mismatch = false;
68670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!TypeInfo.LayoutCompatible) {
68680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    mismatch = !Context.hasSameType(ArgumentType, RequiredType);
68690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
68700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // C++11 [basic.fundamental] p1:
68710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // Plain char, signed char, and unsigned char are three distinct types.
68720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    //
68730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // But we treat plain `char' as equivalent to `signed char' or `unsigned
68740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // char' depending on the current char signedness mode.
68750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (mismatch)
68760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if ((IsPointerAttr && IsSameCharType(ArgumentType->getPointeeType(),
68770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                           RequiredType->getPointeeType())) ||
68780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          (!IsPointerAttr && IsSameCharType(ArgumentType, RequiredType)))
68790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        mismatch = false;
68800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  } else
68810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (IsPointerAttr)
68820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      mismatch = !isLayoutCompatible(Context,
68830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                     ArgumentType->getPointeeType(),
68840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                     RequiredType->getPointeeType());
68850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    else
68860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      mismatch = !isLayoutCompatible(Context, ArgumentType, RequiredType);
68870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
68880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (mismatch)
68890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    Diag(ArgumentExpr->getExprLoc(), diag::warn_type_safety_type_mismatch)
68900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        << ArgumentType << ArgumentKind->getName()
68910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        << TypeInfo.LayoutCompatible << RequiredType
68920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        << ArgumentExpr->getSourceRange()
68930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        << TypeTagExpr->getSourceRange();
68940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
6895