SemaChecking.cpp revision 09bddcf8c0ce4cc2f2a18e050e971539e8a396f8
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// The LLVM Compiler Infrastructure 459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source 60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details. 759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump// This file implements extra semantic analysis beyond what is enforced 1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// by the C type system. 1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 1659907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h" 17199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h" 18384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 19c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h" 2055fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/AST/EvaluatedExprVisitor.h" 21be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie#include "clang/AST/Expr.h" 222324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h" 237ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h" 24f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h" 25f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h" 2655fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Analysis/Analyses/FormatString.h" 273f6f51e28231f65de9c2dd150a2d757b2162cfa3Jordan Rose#include "clang/Basic/CharInfo.h" 2855fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Basic/TargetBuiltins.h" 2955fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Basic/TargetInfo.h" 3059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h" 3155fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Initialization.h" 3255fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Lookup.h" 3355fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/ScopeInfo.h" 3455fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Sema.h" 35f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h" 36f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h" 3755fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "llvm/ADT/SmallString.h" 38cb5620c9b213f4bd323912159fdddda35e258a14Dmitri Gribenko#include "llvm/Support/ConvertUTF.h" 393bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h" 40a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits> 4159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang; 42781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema; 4359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 4460800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 4560800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned ByteNo) const { 4608f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner return SL->getLocationOfByte(ByteNo, PP.getSourceManager(), 474e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie PP.getLangOpts(), PP.getTargetInfo()); 4860800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner} 4960800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 508e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number. 518e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking. Returns true on error. 528e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) { 538e10f3b9cc1db43645bbc2999eb163af8997d468John McCall unsigned argCount = call->getNumArgs(); 548e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount == desiredArgCount) return false; 558e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 568e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount < desiredArgCount) 578e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args) 588e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 598e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getSourceRange(); 608e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 618e10f3b9cc1db43645bbc2999eb163af8997d468John McCall // Highlight all the excess arguments. 628e10f3b9cc1db43645bbc2999eb163af8997d468John McCall SourceRange range(call->getArg(desiredArgCount)->getLocStart(), 638e10f3b9cc1db43645bbc2999eb163af8997d468John McCall call->getArg(argCount - 1)->getLocEnd()); 648e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 658e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args) 668e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 678e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getArg(1)->getSourceRange(); 688e10f3b9cc1db43645bbc2999eb163af8997d468John McCall} 698e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 70e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// Check that the first argument to __builtin_annotation is an integer 71e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// and the second argument is a non-wide string literal. 72e59392176c2369df2bdd11b7786cb38abac00198Julien Lerougestatic bool SemaBuiltinAnnotation(Sema &S, CallExpr *TheCall) { 73e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (checkArgCount(S, TheCall, 2)) 74e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge return true; 75e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 76e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge // First argument should be an integer. 77e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge Expr *ValArg = TheCall->getArg(0); 78e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge QualType Ty = ValArg->getType(); 79e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (!Ty->isIntegerType()) { 80e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge S.Diag(ValArg->getLocStart(), diag::err_builtin_annotation_first_arg) 81e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge << ValArg->getSourceRange(); 82e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge return true; 83e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge } 84e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 85e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge // Second argument should be a constant string. 86e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge Expr *StrArg = TheCall->getArg(1)->IgnoreParenCasts(); 87e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge StringLiteral *Literal = dyn_cast<StringLiteral>(StrArg); 8877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge if (!Literal || !Literal->isAscii()) { 89e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge S.Diag(StrArg->getLocStart(), diag::err_builtin_annotation_second_arg) 90e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge << StrArg->getSourceRange(); 9177f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return true; 9277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge } 93e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 94e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge TheCall->setType(Ty); 9577f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return false; 9677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge} 9777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge 9860d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 99d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 10060d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult TheCallResult(Owned(TheCall)); 1012def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor 102946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Find out if any arguments are required to be integer constant expressions. 103946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner unsigned ICEArguments = 0; 104946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ASTContext::GetBuiltinTypeError Error; 105946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 106946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (Error != ASTContext::GE_None) 107946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments = 0; // Don't diagnose previously diagnosed errors. 108946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 109946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // If any arguments are required to be ICE's, check and diagnose. 110946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 111946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Skip arguments not required to be ICE's. 112946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if ((ICEArguments & (1 << ArgNo)) == 0) continue; 113946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 114946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner llvm::APSInt Result; 115946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 116946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner return true; 117946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments &= ~(1 << ArgNo); 118946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner } 119946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 120d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson switch (BuiltinID) { 12130ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin___CFStringMakeConstantString: 122925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner assert(TheCall->getNumArgs() == 1 && 1231b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner "Wrong # arguments to builtin CFStringMakeConstantString"); 124690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner if (CheckObjCString(TheCall->getArg(0))) 1250eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 126d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 12749ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek case Builtin::BI__builtin_stdarg_start: 12830ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin_va_start: 1290eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinVAStart(TheCall)) 1300eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 131d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1321b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreater: 1331b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreaterequal: 1341b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isless: 1351b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessequal: 1361b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessgreater: 1371b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isunordered: 1380eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinUnorderedCompare(TheCall)) 1390eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 140d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 141e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer case Builtin::BI__builtin_fpclassify: 142e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer if (SemaBuiltinFPClassification(TheCall, 6)) 143e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer return ExprError(); 144e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer break; 1459ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isfinite: 1469ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf: 1479ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf_sign: 1489ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnan: 1499ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnormal: 1503b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (SemaBuiltinFPClassification(TheCall, 1)) 1519ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return ExprError(); 1529ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman break; 153d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman case Builtin::BI__builtin_shufflevector: 1540eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return SemaBuiltinShuffleVector(TheCall); 1550eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // TheCall will be freed by the smart pointer here, but that's fine, since 1560eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // SemaBuiltinShuffleVector guts it, but then doesn't release it. 1574493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar case Builtin::BI__builtin_prefetch: 1580eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinPrefetch(TheCall)) 1590eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 160d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 161d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar case Builtin::BI__builtin_object_size: 1620eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinObjectSize(TheCall)) 1630eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 164d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 165d875fed28578835de89cd407e9db4be788596d7cEli Friedman case Builtin::BI__builtin_longjmp: 166d875fed28578835de89cd407e9db4be788596d7cEli Friedman if (SemaBuiltinLongjmp(TheCall)) 167d875fed28578835de89cd407e9db4be788596d7cEli Friedman return ExprError(); 168d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1698e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 1708e10f3b9cc1db43645bbc2999eb163af8997d468John McCall case Builtin::BI__builtin_classify_type: 1718e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1728e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 1738e10f3b9cc1db43645bbc2999eb163af8997d468John McCall break; 17475c29a012793292ff4578015a9113bf086156d7fChris Lattner case Builtin::BI__builtin_constant_p: 1758e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1768e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 17775c29a012793292ff4578015a9113bf086156d7fChris Lattner break; 1785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: 179a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 180a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 181a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 182a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 183a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 1845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: 185a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 186a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 187a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 188a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 189a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 1905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: 191a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 192a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 193a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 194a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 195a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 1965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: 197a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 198a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 199a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 200a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 201a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 2025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: 203a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 204a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 205a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 206a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 207a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 2085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_add_and_fetch: 209a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 210a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 211a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 212a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 213a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 2145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_sub_and_fetch: 215a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 216a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 217a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 218a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 219a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 2205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_and_and_fetch: 221a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 222a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 223a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 224a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 225a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 2265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_or_and_fetch: 227a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 228a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 229a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 230a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 231a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 2325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_xor_and_fetch: 233a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 234a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 235a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 236a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 237a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 2385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 239a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 240a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 241a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 242a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 243a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 2445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 245a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 246a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 247a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 248a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 249a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 2505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_test_and_set: 251a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 252a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 253a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 254a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 255a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 2565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 257a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 258a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 259a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 260a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 261a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 26223aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: 263a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 264a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 265a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 266a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 267a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 2683fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return SemaBuiltinAtomicOverloaded(TheCallResult); 269ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define BUILTIN(ID, TYPE, ATTRS) 270ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define ATOMIC_BUILTIN(ID, TYPE, ATTRS) \ 271ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Builtin::BI##ID: \ 2723fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return SemaAtomicOpsOverloaded(TheCallResult, AtomicExpr::AO##ID); 273ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#include "clang/Basic/Builtins.def" 27477f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge case Builtin::BI__builtin_annotation: 275e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (SemaBuiltinAnnotation(*this, TheCall)) 27677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return ExprError(); 27777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge break; 27826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 27926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 28026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // Since the target specific builtins for each arch overlap, only check those 28126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // of the arch we are compiling for. 28226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (BuiltinID >= Builtin::FirstTSBuiltin) { 283bcfd1f55bfbb3e5944cd5e03d07b343e280838c4Douglas Gregor switch (Context.getTargetInfo().getTriple().getArch()) { 28426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::arm: 28526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::thumb: 28626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 28726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return ExprError(); 28826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 289fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips: 290fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mipsel: 291fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips64: 292fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips64el: 293fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (CheckMipsBuiltinFunctionCall(BuiltinID, TheCall)) 294fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return ExprError(); 295fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan break; 29626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman default: 29726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 29826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 29926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 30026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 3013fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return TheCallResult; 30226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman} 30326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 30461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code. 30561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) { 306da95f73b59f9af964e33725c515139d34c90c863Bob Wilson NeonTypeFlags Type(t); 307da95f73b59f9af964e33725c515139d34c90c863Bob Wilson int IsQuad = Type.isQuad(); 308da95f73b59f9af964e33725c515139d34c90c863Bob Wilson switch (Type.getEltType()) { 309da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int8: 310da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly8: 311da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 7 : (8 << IsQuad) - 1; 312da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int16: 313da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly16: 314da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 15 : (4 << IsQuad) - 1; 315da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int32: 316da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 31 : (2 << IsQuad) - 1; 317da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int64: 318da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 63 : (1 << IsQuad) - 1; 319da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float16: 320da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 321da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (4 << IsQuad) - 1; 322da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float32: 323da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 324da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (2 << IsQuad) - 1; 32561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman } 3267530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie llvm_unreachable("Invalid NeonTypeFlag!"); 32761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman} 32861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 3296f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// getNeonEltType - Return the QualType corresponding to the elements of 3306f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the vector type specified by the NeonTypeFlags. This is used to check 3316f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the pointer arguments for Neon load/store intrinsics. 3326f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilsonstatic QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context) { 3336f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson switch (Flags.getEltType()) { 3346f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int8: 3356f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy; 3366f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int16: 3376f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy; 3386f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int32: 3396f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy; 3406f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int64: 3416f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedLongLongTy : Context.LongLongTy; 3426f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly8: 3436f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.SignedCharTy; 3446f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly16: 3456f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.ShortTy; 3466f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float16: 3476f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.UnsignedShortTy; 3486f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float32: 3496f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.FloatTy; 3506f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 3517530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie llvm_unreachable("Invalid NeonTypeFlag!"); 3526f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson} 3536f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 35426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 3551c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman llvm::APSInt Result; 3561c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 357f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith uint64_t mask = 0; 35861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned TV = 0; 3594648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson int PtrArgNum = -1; 3606f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson bool HasConstPtr = false; 3611c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman switch (BuiltinID) { 362a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK 363a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 364a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK 3651c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman } 3661c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 3670d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which are overloaded on vector element type, validate 3680d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // the immediate which specifies which variant to emit. 3696f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson unsigned ImmArg = TheCall->getNumArgs()-1; 3700d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (mask) { 3716f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson if (SemaBuiltinConstantArg(TheCall, ImmArg, Result)) 3720d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 3730d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 374da95f73b59f9af964e33725c515139d34c90c863Bob Wilson TV = Result.getLimitedValue(64); 375f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith if ((TV > 63) || (mask & (1ULL << TV)) == 0) 3760d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 3776f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson << TheCall->getArg(ImmArg)->getSourceRange(); 3786f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 3796f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 3804648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (PtrArgNum >= 0) { 3816f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson // Check that pointer arguments have the specified type. 3824648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Expr *Arg = TheCall->getArg(PtrArgNum); 3834648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) 3844648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Arg = ICE->getSubExpr(); 3854648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg); 3864648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType RHSTy = RHS.get()->getType(); 3874648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context); 3884648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (HasConstPtr) 3894648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson EltTy = EltTy.withConst(); 3904648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType LHSTy = Context.getPointerType(EltTy); 3914648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson AssignConvertType ConvTy; 3924648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS); 3934648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (RHS.isInvalid()) 3944648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 3954648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy, 3964648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson RHS.get(), AA_Assigning)) 3974648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 3980d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman } 3991c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 4000d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which take an immediate value as part of the 4010d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // instruction, range check them here. 40261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned i = 0, l = 0, u = 0; 4030d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman switch (BuiltinID) { 4040d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman default: return false; 405bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 406bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 40799c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_f: 40899c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 409a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK 410a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 411a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK 4120d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman }; 4130d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 414592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 415592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 416592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor TheCall->getArg(i)->isValueDependent()) 417592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor return false; 418592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 41961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Check that the immediate argument is actually a constant. 4200d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, i, Result)) 4210d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 4220d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 42361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Range check against the upper/lower values for this isntruction. 4240d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned Val = Result.getZExtValue(); 42561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if (Val < l || Val > (u + l)) 4260d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 427476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer << l << u+l << TheCall->getArg(i)->getSourceRange(); 4280d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 42999c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman // FIXME: VFP Intrinsics should error if VFP not present. 43026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return false; 431d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson} 432d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 433fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyanbool Sema::CheckMipsBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 434fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan unsigned i = 0, l = 0, u = 0; 435fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan switch (BuiltinID) { 436fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan default: return false; 437fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case Mips::BI__builtin_mips_wrdsp: i = 1; l = 0; u = 63; break; 438fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case Mips::BI__builtin_mips_rddsp: i = 0; l = 0; u = 63; break; 439be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_append: i = 2; l = 0; u = 31; break; 440be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_balign: i = 2; l = 0; u = 3; break; 441be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_precr_sra_ph_w: i = 2; l = 0; u = 31; break; 442be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_precr_sra_r_ph_w: i = 2; l = 0; u = 31; break; 443be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_prepend: i = 2; l = 0; u = 31; break; 444fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan }; 445fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 446fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // We can't check the value of a dependent argument. 447fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (TheCall->getArg(i)->isTypeDependent() || 448fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan TheCall->getArg(i)->isValueDependent()) 449fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return false; 450fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 451fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // Check that the immediate argument is actually a constant. 452fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan llvm::APSInt Result; 453fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (SemaBuiltinConstantArg(TheCall, i, Result)) 454fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return true; 455fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 456fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // Range check against the upper/lower values for this instruction. 457fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan unsigned Val = Result.getZExtValue(); 458fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (Val < l || Val > u) 459fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 460fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan << l << u << TheCall->getArg(i)->getSourceRange(); 461fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 462fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return false; 463fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan} 464fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 465831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Given a FunctionDecl's FormatAttr, attempts to populate the FomatStringInfo 466831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// parameter with the FormatAttr's correct format_idx and firstDataArg. 467831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true when the format fits the function and the FormatStringInfo has 468831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// been populated. 469831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::getFormatStringInfo(const FormatAttr *Format, bool IsCXXMember, 470831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FormatStringInfo *FSI) { 471831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->HasVAListArg = Format->getFirstArg() == 0; 472831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->FormatIdx = Format->getFormatIdx() - 1; 473831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->FirstDataArg = FSI->HasVAListArg ? 0 : Format->getFirstArg() - 1; 474de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 475831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // The way the format attribute works in GCC, the implicit this argument 476831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // of member functions is counted. However, it doesn't appear in our own 477831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // lists, so decrement format_idx in that case. 478831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (IsCXXMember) { 479831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if(FSI->FormatIdx == 0) 480831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 481831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith --FSI->FormatIdx; 482831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (FSI->FirstDataArg != 0) 483831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith --FSI->FirstDataArg; 484831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 485831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return true; 486831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 4871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 488831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Handles the checks for format strings, non-POD arguments to vararg 489831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// functions, and NULL arguments passed to non-NULL parameters. 4901c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkovoid Sema::checkCall(NamedDecl *FDecl, 4911c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 492831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs, 493831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool IsMemberFunction, 494831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation Loc, 495831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceRange Range, 496831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType) { 49766360e224689dc23a0acd8a6705ba50bec13bc97Jordan Rose if (CurContext->isDependentContext()) 49866360e224689dc23a0acd8a6705ba50bec13bc97Jordan Rose return; 499de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 500c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek // Printf and scanf checking. 501831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool HandledFormatString = false; 5020538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu if (FDecl) 5030538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu for (specific_attr_iterator<FormatAttr> 5040538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu I = FDecl->specific_attr_begin<FormatAttr>(), 5050538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu E = FDecl->specific_attr_end<FormatAttr>(); I != E ; ++I) 5060538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu if (CheckFormatArguments(*I, Args, IsMemberFunction, CallType, Loc, 5070538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu Range)) 5080538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu HandledFormatString = true; 509831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 510831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // Refuse POD arguments that weren't caught by the format string 511831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // checks above. 512831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!HandledFormatString && CallType != VariadicDoesNotApply) 5131c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko for (unsigned ArgIdx = NumProtoArgs; ArgIdx < Args.size(); ++ArgIdx) { 5140234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek // Args[ArgIdx] can be null in malformed code. 5151c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko if (const Expr *Arg = Args[ArgIdx]) 5160234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek variadicArgumentPODCheck(Arg, CallType); 5170234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek } 5181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5190538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu if (FDecl) { 5200538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu for (specific_attr_iterator<NonNullAttr> 5210538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu I = FDecl->specific_attr_begin<NonNullAttr>(), 5220538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu E = FDecl->specific_attr_end<NonNullAttr>(); I != E; ++I) 5230538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu CheckNonNullArguments(*I, Args.data(), Loc); 5240538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu 5250538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu // Type safety checking. 5260538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu for (specific_attr_iterator<ArgumentWithTypeTagAttr> 5270538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu i = FDecl->specific_attr_begin<ArgumentWithTypeTagAttr>(), 5280538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu e = FDecl->specific_attr_end<ArgumentWithTypeTagAttr>(); 5290538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu i != e; ++i) { 5300538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu CheckArgumentWithTypeTag(*i, Args.data()); 5310538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu } 5320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 533831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 534831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 535831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckConstructorCall - Check a constructor call for correctness and safety 536831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// properties not enforced by the C type system. 5371c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkovoid Sema::CheckConstructorCall(FunctionDecl *FDecl, 5381c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 539831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const FunctionProtoType *Proto, 540831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation Loc) { 541831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = 542831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Proto->isVariadic() ? VariadicConstructor : VariadicDoesNotApply; 5431c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkCall(FDecl, Args, Proto->getNumArgs(), 544831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*IsMemberFunction=*/true, Loc, SourceRange(), CallType); 545831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 546831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 547831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckFunctionCall - Check a direct function call for various correctness 548831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// and safety properties not strictly enforced by the C type system. 549831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall, 550831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const FunctionProtoType *Proto) { 5512edcde8747a000113b434a5c88b4648beed4197bEli Friedman bool IsMemberOperatorCall = isa<CXXOperatorCallExpr>(TheCall) && 5522edcde8747a000113b434a5c88b4648beed4197bEli Friedman isa<CXXMethodDecl>(FDecl); 5532edcde8747a000113b434a5c88b4648beed4197bEli Friedman bool IsMemberFunction = isa<CXXMemberCallExpr>(TheCall) || 5542edcde8747a000113b434a5c88b4648beed4197bEli Friedman IsMemberOperatorCall; 555831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = getVariadicCallType(FDecl, Proto, 556831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()); 557831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0; 5582edcde8747a000113b434a5c88b4648beed4197bEli Friedman Expr** Args = TheCall->getArgs(); 5592edcde8747a000113b434a5c88b4648beed4197bEli Friedman unsigned NumArgs = TheCall->getNumArgs(); 560df75b0c74b277c6b46af2f9e90e13160fbc14d6fEli Friedman if (IsMemberOperatorCall) { 5612edcde8747a000113b434a5c88b4648beed4197bEli Friedman // If this is a call to a member operator, hide the first argument 5622edcde8747a000113b434a5c88b4648beed4197bEli Friedman // from checkCall. 5632edcde8747a000113b434a5c88b4648beed4197bEli Friedman // FIXME: Our choice of AST representation here is less than ideal. 5642edcde8747a000113b434a5c88b4648beed4197bEli Friedman ++Args; 5652edcde8747a000113b434a5c88b4648beed4197bEli Friedman --NumArgs; 5662edcde8747a000113b434a5c88b4648beed4197bEli Friedman } 5671c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkCall(FDecl, llvm::makeArrayRef<const Expr *>(Args, NumArgs), 5681c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko NumProtoArgs, 569831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith IsMemberFunction, TheCall->getRParenLoc(), 570831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()->getSourceRange(), CallType); 571831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 572831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith IdentifierInfo *FnInfo = FDecl->getIdentifier(); 573831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // None of the checks below are needed for functions that don't have 574831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // simple names (e.g., C++ conversion functions). 575831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!FnInfo) 576831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 5770eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 5780a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned CMId = FDecl->getMemoryFunctionKind(); 5790a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == 0) 580d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks return false; 581bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 582d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks // Handle memory setting and copying functions. 5830a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat) 584bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CheckStrlcpycatArguments(TheCall, FnInfo); 585c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (CMId == Builtin::BIstrncat) 586c36bedc90c687caa71748480c60707ea4608b092Anna Zaks CheckStrncatArguments(TheCall, FnInfo); 587d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks else 5880a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks CheckMemaccessArguments(TheCall, CMId, FnInfo); 5897ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 590d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 59171993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson} 59271993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 59329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupasbool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac, 594287f24d3991994b9a263af9e2a873f4feadfb8faDmitri Gribenko ArrayRef<const Expr *> Args) { 595831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = 596831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Method->isVariadic() ? VariadicMethod : VariadicDoesNotApply; 59729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 598287f24d3991994b9a263af9e2a873f4feadfb8faDmitri Gribenko checkCall(Method, Args, Method->param_size(), 599831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*IsMemberFunction=*/false, 600831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith lbrac, Method->getSourceRange(), CallType); 60129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 60229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return false; 60329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 60429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 605f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieubool Sema::CheckPointerCall(NamedDecl *NDecl, CallExpr *TheCall, 606f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu const FunctionProtoType *Proto) { 607725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian const VarDecl *V = dyn_cast<VarDecl>(NDecl); 608725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!V) 609d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 6101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 611725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian QualType Ty = V->getType(); 612f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu if (!Ty->isBlockPointerType() && !Ty->isFunctionPointerType()) 613d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 6141eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 615f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu VariadicCallType CallType; 616a4993778f65212f01168c857cf3043e99ba85c9fRichard Trieu if (!Proto || !Proto->isVariadic()) { 617f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu CallType = VariadicDoesNotApply; 618f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu } else if (Ty->isBlockPointerType()) { 619f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu CallType = VariadicBlock; 620f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu } else { // Ty->isFunctionPointerType() 621f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu CallType = VariadicFunction; 622f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu } 623831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0; 624d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 6251c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkCall(NDecl, 6261c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko llvm::makeArrayRef<const Expr *>(TheCall->getArgs(), 6271c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko TheCall->getNumArgs()), 628831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith NumProtoArgs, /*IsMemberFunction=*/false, 629831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getRParenLoc(), 630831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()->getSourceRange(), CallType); 631831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 632d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 633725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian} 634725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian 6350538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu/// Checks function calls when a FunctionDecl or a NamedDecl is not available, 6360538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu/// such as function pointers returned from functions. 6370538f0e9200df56974b5a71bc276dbce456e9781Richard Trieubool Sema::CheckOtherCall(CallExpr *TheCall, const FunctionProtoType *Proto) { 6380538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu VariadicCallType CallType = getVariadicCallType(/*FDecl=*/0, Proto, 6390538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu TheCall->getCallee()); 6400538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0; 6410538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu 6420538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu checkCall(/*FDecl=*/0, 6430538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu llvm::makeArrayRef<const Expr *>(TheCall->getArgs(), 6440538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu TheCall->getNumArgs()), 6450538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu NumProtoArgs, /*IsMemberFunction=*/false, 6460538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu TheCall->getRParenLoc(), 6470538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu TheCall->getCallee()->getSourceRange(), CallType); 6480538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu 6490538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu return false; 6500538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu} 6510538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu 652ff34d401ff385ef7173ca612432b4ea717fff690Richard SmithExprResult Sema::SemaAtomicOpsOverloaded(ExprResult TheCallResult, 653ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith AtomicExpr::AtomicOp Op) { 654276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman CallExpr *TheCall = cast<CallExpr>(TheCallResult.get()); 655276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 656276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 657ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // All these operations take one of the following forms: 658ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith enum { 659ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_init(A *, C) 660ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Init, 661ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_load(A *, int) 662ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Load, 663ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // void __atomic_load(A *, CP, int) 664ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Copy, 665ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_add(A *, M, int) 666ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Arithmetic, 667ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __atomic_exchange_n(A *, CP, int) 668ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Xchg, 669ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // void __atomic_exchange(A *, C *, CP, int) 670ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith GNUXchg, 671ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // bool __c11_atomic_compare_exchange_strong(A *, C *, CP, int, int) 672ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith C11CmpXchg, 673ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // bool __atomic_compare_exchange(A *, C *, CP, bool, int, int) 674ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith GNUCmpXchg 675ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } Form = Init; 676ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith const unsigned NumArgs[] = { 2, 2, 3, 3, 3, 4, 5, 6 }; 677ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith const unsigned NumVals[] = { 1, 0, 1, 1, 1, 2, 2, 3 }; 678ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // where: 679ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C is an appropriate type, 680ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // A is volatile _Atomic(C) for __c11 builtins and is C for GNU builtins, 681ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // CP is C for __c11 builtins and GNU _n builtins and is C * otherwise, 682ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // M is C if C is an integer, and ptrdiff_t if C is a pointer, and 683ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // the int parameters are for orderings. 684ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 685ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith assert(AtomicExpr::AO__c11_atomic_init == 0 && 686ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith AtomicExpr::AO__c11_atomic_fetch_xor + 1 == AtomicExpr::AO__atomic_load 687ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith && "need to update code for modified C11 atomics"); 688ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsC11 = Op >= AtomicExpr::AO__c11_atomic_init && 689ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op <= AtomicExpr::AO__c11_atomic_fetch_xor; 690ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsN = Op == AtomicExpr::AO__atomic_load_n || 691ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_store_n || 692ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_exchange_n || 693ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_compare_exchange_n; 694ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsAddSub = false; 695ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 696ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (Op) { 697ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_init: 698ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Init; 699ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 700ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 701ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_load: 702ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_load_n: 703ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Load; 704ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 705ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 706ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_store: 707ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_load: 708ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_store: 709ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_store_n: 710ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Copy; 711ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 712ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 713ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_add: 714ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_sub: 715ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_add: 716ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_sub: 717ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_add_fetch: 718ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_sub_fetch: 719ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith IsAddSub = true; 720ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Fall through. 721ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_and: 722ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_or: 723ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_xor: 724ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_and: 725ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_or: 726ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_xor: 72751b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith case AtomicExpr::AO__atomic_fetch_nand: 728ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_and_fetch: 729ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_or_fetch: 730ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_xor_fetch: 73151b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith case AtomicExpr::AO__atomic_nand_fetch: 732ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Arithmetic; 733ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 734ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 735ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_exchange: 736ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_exchange_n: 737ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Xchg; 738ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 739ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 740ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_exchange: 741ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = GNUXchg; 742ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 743ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 744ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_compare_exchange_strong: 745ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_compare_exchange_weak: 746ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = C11CmpXchg; 747ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 748ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 749ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_compare_exchange: 750ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_compare_exchange_n: 751ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = GNUCmpXchg; 752ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 753276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 754276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 755ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Check we have the right number of arguments. 756ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (TheCall->getNumArgs() < NumArgs[Form]) { 757276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 758ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << 0 << NumArgs[Form] << TheCall->getNumArgs() 759276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 760276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 761ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } else if (TheCall->getNumArgs() > NumArgs[Form]) { 762ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(TheCall->getArg(NumArgs[Form])->getLocStart(), 763276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman diag::err_typecheck_call_too_many_args) 764ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << 0 << NumArgs[Form] << TheCall->getNumArgs() 765276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 766276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 767276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 768276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 769ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Inspect the first argument of the atomic operation. 770dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman Expr *Ptr = TheCall->getArg(0); 771276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get(); 772276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman const PointerType *pointerType = Ptr->getType()->getAs<PointerType>(); 773276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!pointerType) { 774ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 775276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 776276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 777276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 778276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 779ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For a __c11 builtin, this should be a pointer to an _Atomic type. 780ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType AtomTy = pointerType->getPointeeType(); // 'A' 781ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType ValType = AtomTy; // 'C' 782ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (IsC11) { 783ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!AtomTy->isAtomicType()) { 784ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic) 785ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << Ptr->getType() << Ptr->getSourceRange(); 786ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 787ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 788bc57b108b2253e26b83768dba196c28564952f18Richard Smith if (AtomTy.isConstQualified()) { 789bc57b108b2253e26b83768dba196c28564952f18Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_non_const_atomic) 790bc57b108b2253e26b83768dba196c28564952f18Richard Smith << Ptr->getType() << Ptr->getSourceRange(); 791bc57b108b2253e26b83768dba196c28564952f18Richard Smith return ExprError(); 792bc57b108b2253e26b83768dba196c28564952f18Richard Smith } 793ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ValType = AtomTy->getAs<AtomicType>()->getValueType(); 794276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 795276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 796ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For an arithmetic operation, the implied arithmetic must be well-formed. 797ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Arithmetic) { 798ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // gcc does not enforce these rules for GNU atomics, but we do so for sanity. 799ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (IsAddSub && !ValType->isIntegerType() && !ValType->isPointerType()) { 800ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 801ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 802ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 803ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 804ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsAddSub && !ValType->isIntegerType()) { 805ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_bitwise_needs_atomic_int) 806ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 807ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 808ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 809ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } else if (IsN && !ValType->isIntegerType() && !ValType->isPointerType()) { 810ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For __atomic_*_n operations, the value type must be a scalar integral or 811ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // pointer type which is 1, 2, 4, 8 or 16 bytes in length. 812276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 813ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 814276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 815276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 816276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 817ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsC11 && !AtomTy.isTriviallyCopyableType(Context)) { 818ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For GNU atomics, require a trivially-copyable type. This is not part of 819ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // the GNU atomics specification, but we enforce it for sanity. 820ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_trivial_copy) 821276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 822276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 823276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 824276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 825ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // FIXME: For any builtin other than a load, the ValType must not be 826ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // const-qualified. 827ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 828276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman switch (ValType.getObjCLifetime()) { 829276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_None: 830276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_ExplicitNone: 831276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // okay 832276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman break; 833276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 834276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Weak: 835276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Strong: 836276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Autoreleasing: 837ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // FIXME: Can this happen? By this point, ValType should be known 838ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // to be trivially copyable. 839276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 840276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << ValType << Ptr->getSourceRange(); 841276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 842276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 843276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 844276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType ResultType = ValType; 845ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Copy || Form == GNUXchg || Form == Init) 846276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.VoidTy; 847ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == C11CmpXchg || Form == GNUCmpXchg) 848276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.BoolTy; 849276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 850ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The type of a parameter passed 'by value'. In the GNU atomics, such 851ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // arguments are actually passed as pointers. 852ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType ByValType = ValType; // 'CP' 853ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsC11 && !IsN) 854ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ByValType = Ptr->getType(); 855ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 856276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The first argument --- the pointer --- has a fixed type; we 857276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // deduce the types of the rest of the arguments accordingly. Walk 858276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // the remaining arguments, converting them to the deduced value type. 859ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith for (unsigned i = 1; i != NumArgs[Form]; ++i) { 860276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType Ty; 861ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (i < NumVals[Form] + 1) { 862ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (i) { 863ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 1: 864ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The second argument is the non-atomic operand. For arithmetic, this 865ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // is always passed by value, and for a compare_exchange it is always 866ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // passed by address. For the rest, GNU uses by-address and C11 uses 867ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // by-value. 868ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith assert(Form != Load); 869ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Init || (Form == Arithmetic && ValType->isIntegerType())) 870ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ValType; 871ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == Copy || Form == Xchg) 872ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ByValType; 873ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == Arithmetic) 874ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.getPointerDiffType(); 875ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else 876ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.getPointerType(ValType.getUnqualifiedType()); 877ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 878ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 2: 879ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The third argument to compare_exchange / GNU exchange is a 880ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // (pointer to a) desired value. 881ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ByValType; 882ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 883ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 3: 884ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The fourth argument to GNU compare_exchange is a 'weak' flag. 885ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.BoolTy; 886ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 887ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 888276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else { 889276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The order(s) are always converted to int. 890276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.IntTy; 891276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 892ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 893276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity Entity = 894276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity::InitializeParameter(Context, Ty, false); 895ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ExprResult Arg = TheCall->getArg(i); 896276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 897276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Arg.isInvalid()) 898276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return true; 899276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman TheCall->setArg(i, Arg.get()); 900276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 901276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 902ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Permute the arguments into a 'consistent' order. 903dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SmallVector<Expr*, 5> SubExprs; 904dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(Ptr); 905ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (Form) { 906ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Init: 907ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Note, AtomicExpr::getVal1() has a special case for this atomic. 9087a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall SubExprs.push_back(TheCall->getArg(1)); // Val1 909ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 910ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Load: 911ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Order 912ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 913ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Copy: 914ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Arithmetic: 915ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Xchg: 916dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(2)); // Order 917dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 918ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 919ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case GNUXchg: 920ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Note, AtomicExpr::getVal2() has a special case for this atomic. 921ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(3)); // Order 922ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Val1 923ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(2)); // Val2 924ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 925ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case C11CmpXchg: 926dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(3)); // Order 927dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 928dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(4)); // OrderFail 9292ebb98a78471f2039af4321bae657e7daacc2a62David Chisnall SubExprs.push_back(TheCall->getArg(2)); // Val2 930ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 931ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case GNUCmpXchg: 932ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(4)); // Order 933ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Val1 934ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(5)); // OrderFail 935ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(2)); // Val2 936ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(3)); // Weak 937ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 938276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 939538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian 940538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian AtomicExpr *AE = new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(), 941538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian SubExprs, ResultType, Op, 942538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian TheCall->getRParenLoc()); 943538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian 944538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian if ((Op == AtomicExpr::AO__c11_atomic_load || 945538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian (Op == AtomicExpr::AO__c11_atomic_store)) && 946538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian Context.AtomicUsesUnsupportedLibcall(AE)) 947538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian Diag(AE->getLocStart(), diag::err_atomic_load_store_uses_lib) << 948538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian ((Op == AtomicExpr::AO__c11_atomic_load) ? 0 : 1); 949dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman 950538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian return Owned(AE); 951276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman} 952276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 953276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 9545f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// checkBuiltinArgument - Given a call to a builtin function, perform 9555f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// normal type-checking on the given argument, updating the call in 9565f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// place. This is useful when a builtin function requires custom 9575f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// type-checking for some of its arguments but not necessarily all of 9585f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// them. 9595f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// 9605f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// Returns true on error. 9615f8d604246976a93a73549b07bbc8ee0b2061b50John McCallstatic bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) { 9625f8d604246976a93a73549b07bbc8ee0b2061b50John McCall FunctionDecl *Fn = E->getDirectCallee(); 9635f8d604246976a93a73549b07bbc8ee0b2061b50John McCall assert(Fn && "builtin call without direct callee!"); 9645f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9655f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ParmVarDecl *Param = Fn->getParamDecl(ArgIndex); 9665f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity Entity = 9675f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity::InitializeParameter(S.Context, Param); 9685f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9695f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ExprResult Arg = E->getArg(0); 9705f8d604246976a93a73549b07bbc8ee0b2061b50John McCall Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg); 9715f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (Arg.isInvalid()) 9725f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 9735f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9745f8d604246976a93a73549b07bbc8ee0b2061b50John McCall E->setArg(ArgIndex, Arg.take()); 9755f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return false; 9765f8d604246976a93a73549b07bbc8ee0b2061b50John McCall} 9775f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like 9795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer 9805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument. The main ActOnCallExpr routines have already 9815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as 9825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...). 9835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// 9845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these 9855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins, 98660d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 98760d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 988d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 9895caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 9905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 9915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 9925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Ensure that we have at least one argument to do type inference from. 993d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1) { 994d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 995d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1 << TheCall->getNumArgs() 996d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 997d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 998d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 9991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Inspect the first argument of the atomic builtin. This should always be 10015caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // a pointer type, whose element is an integral scalar or pointer type. 10025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Because it is a pointer type, we don't have to worry about any implicit 10035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // casts here. 1004d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth // FIXME: We don't allow floating point scalars as input. 10055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *FirstArg = TheCall->getArg(0); 10068c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg); 10078c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman if (FirstArgResult.isInvalid()) 10088c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman return ExprError(); 10098c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman FirstArg = FirstArgResult.take(); 10108c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman TheCall->setArg(0, FirstArg); 10118c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman 1012f85e193739c953358c865005855253af4f68a497John McCall const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>(); 1013f85e193739c953358c865005855253af4f68a497John McCall if (!pointerType) { 1014d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 1015d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 1016d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 1017d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 10181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1019f85e193739c953358c865005855253af4f68a497John McCall QualType ValType = pointerType->getPointeeType(); 1020dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 1021d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth !ValType->isBlockPointerType()) { 1022d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 1023d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 1024d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 1025d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 10265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 1027f85e193739c953358c865005855253af4f68a497John McCall switch (ValType.getObjCLifetime()) { 1028f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 1029f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 1030f85e193739c953358c865005855253af4f68a497John McCall // okay 1031f85e193739c953358c865005855253af4f68a497John McCall break; 1032f85e193739c953358c865005855253af4f68a497John McCall 1033f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 1034f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 1035f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 1036b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 1037f85e193739c953358c865005855253af4f68a497John McCall << ValType << FirstArg->getSourceRange(); 1038f85e193739c953358c865005855253af4f68a497John McCall return ExprError(); 1039f85e193739c953358c865005855253af4f68a497John McCall } 1040f85e193739c953358c865005855253af4f68a497John McCall 1041b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Strip any qualifiers off ValType. 1042b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType = ValType.getUnqualifiedType(); 1043b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall 10448d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // The majority of builtins return a value, but a few have special return 10458d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // types, so allow them to override appropriately below. 10468d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth QualType ResultType = ValType; 10478d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth 10485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // We need to figure out which concrete builtin this maps onto. For example, 10495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add with a 2 byte object turns into 10505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add_2. 10515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \ 10525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 10535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Builtin::BI##x##_8, Builtin::BI##x##_16 } 10541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner static const unsigned BuiltinIndices[][5] = { 10565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_add), 10575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_sub), 10585caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_or), 10595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_and), 10605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_xor), 10611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10625caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_add_and_fetch), 10635caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_sub_and_fetch), 10645caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_and_and_fetch), 10655caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_or_and_fetch), 10665caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_xor_and_fetch), 10671eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_val_compare_and_swap), 10695caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_bool_compare_and_swap), 10705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_test_and_set), 107123aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_lock_release), 107223aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_swap) 10735caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner }; 10741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW 10751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10765caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Determine the index of the size. 10775caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned SizeIndex; 1078199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 10795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 1: SizeIndex = 0; break; 10805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 2: SizeIndex = 1; break; 10815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 4: SizeIndex = 2; break; 10825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 8: SizeIndex = 3; break; 10835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 16: SizeIndex = 4; break; 10845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: 1085d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 1086d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 1087d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 10885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 10891eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Each of these builtins has one pointer argument, followed by some number of 10915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // values (0, 1 or 2) followed by a potentially empty varags list of stuff 10925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // that we ignore. Find out which row of BuiltinIndices to read from as well 10935caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // as the number of fixed args. 10947814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor unsigned BuiltinID = FDecl->getBuiltinID(); 10955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned BuiltinIndex, NumFixed = 1; 10965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner switch (BuiltinID) { 1097b219cfc4d75f0a03630b7c4509ef791b7e97b2c8David Blaikie default: llvm_unreachable("Unknown overloaded atomic builtin!"); 1098a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add: 1099a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 1100a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 1101a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 1102a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 1103a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 1104a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 0; 1105a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1106a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1107a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub: 1108a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 1109a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 1110a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 1111a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 1112a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 1113a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 1; 1114a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1115a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1116a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or: 1117a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 1118a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 1119a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 1120a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 1121a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 1122a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 2; 1123a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1124a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1125a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and: 1126a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 1127a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 1128a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 1129a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 1130a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 1131a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 3; 1132a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1133a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1134a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor: 1135a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 1136a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 1137a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 1138a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 1139a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 1140a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 4; 1141a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1142a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1143a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch: 1144a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 1145a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 1146a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 1147a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 1148a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 1149a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 5; 1150a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1151a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1152a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch: 1153a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 1154a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 1155a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 1156a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 1157a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 1158a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 6; 1159a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1160a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1161a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch: 1162a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 1163a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 1164a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 1165a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 1166a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 1167a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 7; 1168a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1169a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1170a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch: 1171a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 1172a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 1173a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 1174a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 1175a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 1176a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 8; 1177a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1178a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1179a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch: 1180a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 1181a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 1182a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 1183a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 1184a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 1185a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 9; 1186a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 11871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 1189a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 1190a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 1191a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 1192a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 1193a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 11947eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 10; 11955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 11965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1197a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 11985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 1199a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 1200a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 1201a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 1202a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 1203a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 12047eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 11; 12055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 12068d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.BoolTy; 12075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1208a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1209a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set: 1210a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 1211a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 1212a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 1213a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 1214a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 1215a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 12; 1216a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1217a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 12185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 1219a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 1220a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 1221a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 1222a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 1223a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 12247eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 13; 12255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 0; 12268d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.VoidTy; 12275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1228a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1229a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap: 1230a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 1231a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 1232a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 1233a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 1234a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 1235a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 14; 1236a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 12375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 12381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Now that we know how many fixed arguments we expect, first check that we 12405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // have at least that many. 1241d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1+NumFixed) { 1242d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 1243d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1+NumFixed << TheCall->getNumArgs() 1244d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 1245d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 1246d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 12471eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1248e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // Get the decl for the concrete builtin from this, we can tell what the 1249e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // concrete integer type we should convert to is. 1250e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 1251e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 12522ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara FunctionDecl *NewBuiltinDecl; 12532ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara if (NewBuiltinID == BuiltinID) 12542ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara NewBuiltinDecl = FDecl; 12552ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara else { 12562ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara // Perform builtin lookup to avoid redeclaring it. 12572ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara DeclarationName DN(&Context.Idents.get(NewBuiltinName)); 12582ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara LookupResult Res(*this, DN, DRE->getLocStart(), LookupOrdinaryName); 12592ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara LookupName(Res, TUScope, /*AllowBuiltinCreation=*/true); 12602ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara assert(Res.getFoundDecl()); 12612ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara NewBuiltinDecl = dyn_cast<FunctionDecl>(Res.getFoundDecl()); 12622ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara if (NewBuiltinDecl == 0) 12632ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara return ExprError(); 12642ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara } 1265d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 1266f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // The first argument --- the pointer --- has a fixed type; we 1267f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // deduce the types of the rest of the arguments accordingly. Walk 1268f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // the remaining arguments, converting them to the deduced value type. 12695caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner for (unsigned i = 0; i != NumFixed; ++i) { 1270429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult Arg = TheCall->getArg(i+1); 12711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // GCC does an implicit conversion to the pointer or integer ValType. This 12735caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // can fail in some cases (1i -> int**), check for this error case now. 1274b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Initialize the argument. 1275b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall InitializedEntity Entity = InitializedEntity::InitializeParameter(Context, 1276b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType, /*consume*/ false); 1277b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 1278429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (Arg.isInvalid()) 1279d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 12801eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Okay, we have something that *can* be converted to the right type. Check 12825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // to see if there is a potentially weird extension going on here. This can 12835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // happen when you do an atomic operation on something like an char* and 12845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // pass in 42. The 42 gets converted to char. This is even more strange 12855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // for things like 45.123 -> char, etc. 12861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // FIXME: Do this check. 1287b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall TheCall->setArg(i+1, Arg.take()); 12885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 12891eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1290bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor ASTContext& Context = this->getASTContext(); 1291bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor 1292bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor // Create a new DeclRefExpr to refer to the new decl. 1293bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DeclRefExpr* NewDRE = DeclRefExpr::Create( 1294bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor Context, 1295bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getQualifierLoc(), 1296e4b92761b43ced611c417ae478568610f1ad7b1eAbramo Bagnara SourceLocation(), 1297bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor NewBuiltinDecl, 1298f4b88a45902af1802a1cb42ba48b1c474474f228John McCall /*enclosing*/ false, 1299bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getLocation(), 1300a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman Context.BuiltinFnTy, 1301bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getValueKind()); 13021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 13035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Set the callee in the CallExpr. 1304a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman // FIXME: This loses syntactic information. 1305a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman QualType CalleePtrTy = Context.getPointerType(NewBuiltinDecl->getType()); 1306a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman ExprResult PromotedCall = ImpCastExprToType(NewDRE, CalleePtrTy, 1307a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman CK_BuiltinFnToFnPtr); 1308429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setCallee(PromotedCall.take()); 13091eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1310db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // Change the result type of the call to match the original value type. This 1311db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // is arbitrary, but the codegen for these builtins ins design to handle it 1312db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // gracefully. 13138d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth TheCall->setType(ResultType); 1314d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 13153fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return TheCallResult; 13165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner} 13175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 1318690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin 131971993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct 1320fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would 1321fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend). 1322690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) { 132356f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner Arg = Arg->IgnoreParenCasts(); 132471993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 132571993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 13265cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!Literal || !Literal->isAscii()) { 1327fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 1328fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << Arg->getSourceRange(); 13299cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return true; 133071993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson } 13311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 13327da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Literal->containsNonAsciiOrNull()) { 13335f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef String = Literal->getString(); 13347da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian unsigned NumBytes = String.size(); 13355f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<UTF16, 128> ToBuf(NumBytes); 133631ba6135375433b617a8587ea6cc836a014ebd86Roman Divacky const UTF8 *FromPtr = (const UTF8 *)String.data(); 13377da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian UTF16 *ToPtr = &ToBuf[0]; 13387da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 13397da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 13407da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian &ToPtr, ToPtr + NumBytes, 13417da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian strictConversion); 13427da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian // Check for conversion failure. 13437da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Result != conversionOK) 13447da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian Diag(Arg->getLocStart(), 13457da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian diag::warn_cfstring_truncated) << Arg->getSourceRange(); 13467da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian } 13479cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return false; 134859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner} 134959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 1350c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 1351c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success. 1352925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 1353925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *Fn = TheCall->getCallee(); 1354925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) { 13552c21a073525cdfa68e4439b7af551385dc2796abChris Lattner Diag(TheCall->getArg(2)->getLocStart(), 1356fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1357ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1358ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << Fn->getSourceRange() 13591eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(2)->getLocStart(), 1360fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 136130ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 136230ce344307f8a8b00054021307015571f83c7364Chris Lattner } 136356f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 136456f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman if (TheCall->getNumArgs() < 2) { 1365d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher return Diag(TheCall->getLocEnd(), 1366d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 1367d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 136856f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman } 136956f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 13705f8d604246976a93a73549b07bbc8ee0b2061b50John McCall // Type-check the first argument normally. 13715f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (checkBuiltinArgument(*this, TheCall, 0)) 13725f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 13735f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 1374c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner // Determine whether the current function is variadic or not. 13759ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor BlockScopeInfo *CurBlock = getCurBlock(); 1376c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner bool isVariadic; 1377cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1378c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall isVariadic = CurBlock->TheDecl->isVariadic(); 13799498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else if (FunctionDecl *FD = getCurFunctionDecl()) 13809498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek isVariadic = FD->isVariadic(); 13819498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else 138253d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis isVariadic = getCurMethodDecl()->isVariadic(); 13831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1384c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner if (!isVariadic) { 138530ce344307f8a8b00054021307015571f83c7364Chris Lattner Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 138630ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 138730ce344307f8a8b00054021307015571f83c7364Chris Lattner } 13881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 138930ce344307f8a8b00054021307015571f83c7364Chris Lattner // Verify that the second argument to the builtin is the last argument of the 139030ce344307f8a8b00054021307015571f83c7364Chris Lattner // current function or method. 139130ce344307f8a8b00054021307015571f83c7364Chris Lattner bool SecondArgIsLastNamedArgument = false; 1392e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 13931eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1394b07d448a625d7399d871079d55491c6b10316e6fNico Weber // These are valid if SecondArgIsLastNamedArgument is false after the next 1395b07d448a625d7399d871079d55491c6b10316e6fNico Weber // block. 1396b07d448a625d7399d871079d55491c6b10316e6fNico Weber QualType Type; 1397b07d448a625d7399d871079d55491c6b10316e6fNico Weber SourceLocation ParamLoc; 1398b07d448a625d7399d871079d55491c6b10316e6fNico Weber 139988cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 140088cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 140130ce344307f8a8b00054021307015571f83c7364Chris Lattner // FIXME: This isn't correct for methods (results in bogus warning). 140230ce344307f8a8b00054021307015571f83c7364Chris Lattner // Get the last formal in the current function. 140388cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson const ParmVarDecl *LastArg; 1404cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1405cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff LastArg = *(CurBlock->TheDecl->param_end()-1); 1406cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff else if (FunctionDecl *FD = getCurFunctionDecl()) 1407371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner LastArg = *(FD->param_end()-1); 140830ce344307f8a8b00054021307015571f83c7364Chris Lattner else 140953d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis LastArg = *(getCurMethodDecl()->param_end()-1); 141030ce344307f8a8b00054021307015571f83c7364Chris Lattner SecondArgIsLastNamedArgument = PV == LastArg; 1411b07d448a625d7399d871079d55491c6b10316e6fNico Weber 1412b07d448a625d7399d871079d55491c6b10316e6fNico Weber Type = PV->getType(); 1413b07d448a625d7399d871079d55491c6b10316e6fNico Weber ParamLoc = PV->getLocation(); 141430ce344307f8a8b00054021307015571f83c7364Chris Lattner } 141530ce344307f8a8b00054021307015571f83c7364Chris Lattner } 14161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 141730ce344307f8a8b00054021307015571f83c7364Chris Lattner if (!SecondArgIsLastNamedArgument) 14181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(1)->getLocStart(), 141930ce344307f8a8b00054021307015571f83c7364Chris Lattner diag::warn_second_parameter_of_va_start_not_last_named_argument); 1420b07d448a625d7399d871079d55491c6b10316e6fNico Weber else if (Type->isReferenceType()) { 1421b07d448a625d7399d871079d55491c6b10316e6fNico Weber Diag(Arg->getLocStart(), 1422b07d448a625d7399d871079d55491c6b10316e6fNico Weber diag::warn_va_start_of_reference_type_is_undefined); 1423b07d448a625d7399d871079d55491c6b10316e6fNico Weber Diag(ParamLoc, diag::note_parameter_type) << Type; 1424b07d448a625d7399d871079d55491c6b10316e6fNico Weber } 1425b07d448a625d7399d871079d55491c6b10316e6fNico Weber 142630ce344307f8a8b00054021307015571f83c7364Chris Lattner return false; 14276cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman} 142830ce344307f8a8b00054021307015571f83c7364Chris Lattner 14291b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 14301b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends. This is declared to take (...), so we have to check everything. 1431925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 1432925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() < 2) 14332c21a073525cdfa68e4439b7af551385dc2796abChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1434d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << 2 << TheCall->getNumArgs()/*function call*/; 1435925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) 14361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(TheCall->getArg(2)->getLocStart(), 1437fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1438ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1439fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(TheCall->getArg(2)->getLocStart(), 1440fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 14411eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1442429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg0 = TheCall->getArg(0); 1443429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg1 = TheCall->getArg(1); 1444cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 14451b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // Do standard promotions between the two arguments, returning their common 14461b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // type. 1447925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 1448429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.isInvalid() || OrigArg1.isInvalid()) 1449429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return true; 1450403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar 1451403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // Make sure any conversions are pushed back into the call; this is 1452403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // type safe since unordered compare builtins are declared as "_Bool 1453403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // foo(...)". 1454429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(0, OrigArg0.get()); 1455429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(1, OrigArg1.get()); 14561eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1457429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent()) 1458cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 1459cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 14601b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // If the common type isn't a real floating type, then the arguments were 14611b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // invalid for this operation. 1462860a319e62b0e256817a458396d191aa91c0787aEli Friedman if (Res.isNull() || !Res->isRealFloatingType()) 1463429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return Diag(OrigArg0.get()->getLocStart(), 1464fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_invalid_ordered_compare) 1465429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << OrigArg0.get()->getType() << OrigArg1.get()->getType() 1466429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd()); 14671eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 14681b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner return false; 14691b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner} 14701b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner 1471e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 1472e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends. This is declared to take (...), so we have 14733b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point 14743b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value. 14753b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 14763b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() < NumArgs) 14779ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1478d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 14793b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() > NumArgs) 14803b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer return Diag(TheCall->getArg(NumArgs)->getLocStart(), 14819ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_too_many_args) 1482ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 14833b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 14849ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman (*(TheCall->arg_end()-1))->getLocEnd()); 14859ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 14863b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer Expr *OrigArg = TheCall->getArg(NumArgs-1); 14871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 14889ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (OrigArg->isTypeDependent()) 14899ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 14909ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 149181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // This operation requires a non-_Complex floating-point number. 14929ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (!OrigArg->getType()->isRealFloatingType()) 14931eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg->getLocStart(), 14949ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_invalid_unary_fp) 14959ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman << OrigArg->getType() << OrigArg->getSourceRange(); 14961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 149781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // If this is an implicit conversion from float -> double, remove it. 149881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 149981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Expr *CastArg = Cast->getSubExpr(); 150081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 150181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 150281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner "promotion from float to double is the only expected cast here"); 150381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Cast->setSubExpr(0); 150481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner TheCall->setArg(NumArgs-1, CastArg); 150581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 150681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 150781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner 15089ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 15099ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman} 15109ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 1511d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 1512d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything. 151360d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 151437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() < 2) 15150eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocEnd(), 1516d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 151737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1518d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << TheCall->getSourceRange()); 1519d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 152037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Determine which of the following types of shufflevector we're checking: 152137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 1) unary, vector mask: (lhs, mask) 152237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 2) binary, vector mask: (lhs, rhs, mask) 152337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 152437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType resType = TheCall->getArg(0)->getType(); 152537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numElements = 0; 152637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 1527cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (!TheCall->getArg(0)->isTypeDependent() && 1528cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor !TheCall->getArg(1)->isTypeDependent()) { 152937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType LHSType = TheCall->getArg(0)->getType(); 153037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType RHSType = TheCall->getArg(1)->getType(); 153137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 153237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!LHSType->isVectorType() || !RHSType->isVectorType()) { 1533cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) 15341eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1535cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1536cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 1537cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 153837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 153937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numElements = LHSType->getAs<VectorType>()->getNumElements(); 154037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numResElements = TheCall->getNumArgs() - 2; 154137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 154237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Check to see if we have a call with 2 vector arguments, the unary shuffle 154337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // with mask. If so, verify that RHS is an integer vector type with the 154437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // same number of elts as lhs. 154537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() == 2) { 15464cb3d909cb4af5efc073fd4122d4998c466a220eSylvestre Ledru if (!RHSType->hasIntegerRepresentation() || 154737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman RHSType->getAs<VectorType>()->getNumElements() != numElements) 154837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 154937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << SourceRange(TheCall->getArg(1)->getLocStart(), 155037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman TheCall->getArg(1)->getLocEnd()); 155137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } 155237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 1553cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 15541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1555cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1556cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 155737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } else if (numElements != numResElements) { 155837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 1559788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner resType = Context.getVectorType(eltType, numResElements, 1560e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson VectorType::GenericVector); 1561cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 1562d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1563d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1564d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 1565cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 1566cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(i)->isValueDependent()) 1567cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor continue; 1568cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 156937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman llvm::APSInt Result(32); 157037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 157137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman return ExprError(Diag(TheCall->getLocStart(), 157237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman diag::err_shufflevector_nonconstant_argument) 157337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << TheCall->getArg(i)->getSourceRange()); 15740eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 1575d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 15760eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocStart(), 1577fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_shufflevector_argument_too_large) 15780eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl << TheCall->getArg(i)->getSourceRange()); 1579d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1580d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 15815f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<Expr*, 32> exprs; 1582d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1583d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 1584d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman exprs.push_back(TheCall->getArg(i)); 1585d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman TheCall->setArg(i, 0); 1586d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1587d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 15883b6bef9a213249c6ab6d67c07b1ac6380961be3eBenjamin Kramer return Owned(new (Context) ShuffleVectorExpr(Context, exprs, resType, 15898189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getCallee()->getLocStart(), 15908189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getRParenLoc())); 1591d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman} 159230ce344307f8a8b00054021307015571f83c7364Chris Lattner 15934493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 15944493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two 15954493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args. 15964493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 1597fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner unsigned NumArgs = TheCall->getNumArgs(); 15984493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1599fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (NumArgs > 3) 1600ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher return Diag(TheCall->getLocEnd(), 1601ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher diag::err_typecheck_call_too_many_args_at_most) 1602ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 3 << NumArgs 1603ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << TheCall->getSourceRange(); 16044493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 16054493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // Argument 0 is checked for us and the remaining arguments must be 16064493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // constant integers. 1607fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner for (unsigned i = 1; i != NumArgs; ++i) { 16084493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar Expr *Arg = TheCall->getArg(i); 1609592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1610592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 1611592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (Arg->isTypeDependent() || Arg->isValueDependent()) 1612592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor continue; 1613592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 16149aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman llvm::APSInt Result; 1615691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, i, Result)) 1616691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 16171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 16184493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // FIXME: gcc issues a warning and rewrites these to 0. These 16194493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // seems especially odd for the third argument since the default 16204493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // is 3. 1621fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (i == 1) { 16229aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 1) 1623fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 162421fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "1" << Arg->getSourceRange(); 16254493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } else { 16269aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 3) 1627fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 162821fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "3" << Arg->getSourceRange(); 16294493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 16304493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 16314493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1632fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return false; 16334493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar} 16344493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1635691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 1636691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression. 1637691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 1638691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt &Result) { 1639691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(ArgNum); 1640691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 1641691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 1642691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1643691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 1644691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1645691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (!Arg->isIntegerConstantExpr(Result, Context)) 1646691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 16475e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher << FDecl->getDeclName() << Arg->getSourceRange(); 1648691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 164921fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner return false; 165021fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner} 165121fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner 1652d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 1653d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined 1654d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3). 1655fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner// For compatibility check 0-3, llvm only handles 0 and 2. 1656d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 1657691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1658592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1659592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 1660592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (TheCall->getArg(1)->isTypeDependent() || 1661592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor TheCall->getArg(1)->isValueDependent()) 1662592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor return false; 1663592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1664691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // Check constant-ness first. 1665691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1666691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1667d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1668691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(1); 1669d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 1670fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 1671fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1672d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar } 1673d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1674d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar return false; 1675d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar} 1676d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1677586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 1678d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1. 1679d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 1680d875fed28578835de89cd407e9db4be788596d7cEli Friedman Expr *Arg = TheCall->getArg(1); 1681691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1682cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 1683691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // TODO: This is less than ideal. Overload this to take a value. 1684691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1685691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1686691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1687691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Result != 1) 1688d875fed28578835de89cd407e9db4be788596d7cEli Friedman return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 1689d875fed28578835de89cd407e9db4be788596d7cEli Friedman << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1690d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1691d875fed28578835de89cd407e9db4be788596d7cEli Friedman return false; 1692d875fed28578835de89cd407e9db4be788596d7cEli Friedman} 1693d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1694831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determine if an expression is a string literal or constant string. 1695831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// If this function returns false on the arguments to a function expecting a 1696831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// format string, we will usually need to emit a warning. 1697831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// True string literals are then checked by CheckFormatString. 1698831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithSema::StringLiteralCheckType 16991c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri GribenkoSema::checkFormatStringExpr(const Expr *E, ArrayRef<const Expr *> Args, 17001c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko bool HasVAListArg, 1701831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned format_idx, unsigned firstDataArg, 1702ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose FormatStringType Type, VariadicCallType CallType, 1703ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose bool inFunctionCall) { 17044fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain: 1705cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 1706831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1707d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 170834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas E = E->IgnoreParenCasts(); 1709f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 1710a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie if (E->isNullPointerConstant(Context, Expr::NPC_ValueDependentIsNotNull)) 1711a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // Technically -Wformat-nonliteral does not warn about this case. 1712a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // The behavior of printf and friends in this case is implementation 1713a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // dependent. Ideally if the format string cannot be null then 1714a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // it should have a 'nonnull' attribute in the function prototype. 1715831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_CheckedLiteral; 1716a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie 1717d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek switch (E->getStmtClass()) { 171856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::BinaryConditionalOperatorClass: 1719d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ConditionalOperatorClass: { 1720831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // The expression is a literal if both sub-expressions were, and it was 1721831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // completely checked only if both sub-expressions were checked. 1722831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const AbstractConditionalOperator *C = 1723831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith cast<AbstractConditionalOperator>(E); 1724831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType Left = 17251c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkFormatStringExpr(C->getTrueExpr(), Args, 1726831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1727ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 1728831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (Left == SLCT_NotALiteral) 1729831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1730831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType Right = 17311c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkFormatStringExpr(C->getFalseExpr(), Args, 1732831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1733ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 1734831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Left < Right ? Left : Right; 1735d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1736d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1737d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ImplicitCastExprClass: { 17384fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ImplicitCastExpr>(E)->getSubExpr(); 17394fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 1740d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1741d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 174256ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::OpaqueValueExprClass: 174356ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) { 174456ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall E = src; 174556ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall goto tryAgain; 174656ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall } 1747831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 174856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall 1749b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek case Stmt::PredefinedExprClass: 1750b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // While __func__, etc., are technically not string literals, they 1751b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // cannot contain format specifiers and thus are not a security 1752b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // liability. 1753831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_UncheckedLiteral; 1754b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek 1755082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::DeclRefExprClass: { 1756082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const DeclRefExpr *DR = cast<DeclRefExpr>(E); 17571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1758082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // As an exception, do not flag errors for variables binding to 1759082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // const string literals. 1760082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 1761082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool isConstant = false; 1762082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek QualType T = DR->getType(); 1763082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek 1764082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ArrayType *AT = Context.getAsArrayType(T)) { 1765082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek isConstant = AT->getElementType().isConstant(Context); 1766ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (const PointerType *PT = T->getAs<PointerType>()) { 17671eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump isConstant = T.isConstant(Context) && 1768082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek PT->getPointeeType().isConstant(Context); 1769e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas } else if (T->isObjCObjectPointerType()) { 1770e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas // In ObjC, there is usually no "const ObjectPointer" type, 1771e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas // so don't check if the pointee type is constant. 1772e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas isConstant = T.isConstant(Context); 1773082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 17741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1775082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (isConstant) { 1776e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (const Expr *Init = VD->getAnyInitializer()) { 1777e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay // Look through initializers like const char c[] = { "foo" } 1778e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (const InitListExpr *InitList = dyn_cast<InitListExpr>(Init)) { 1779e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (InitList->isStringLiteralInit()) 1780e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay Init = InitList->getInit(0)->IgnoreParenImpCasts(); 1781e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay } 17821c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return checkFormatStringExpr(Init, Args, 1783831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, 1784ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, CallType, 1785831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*inFunctionCall*/false); 1786e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay } 1787082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 17881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1789d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // For vprintf* functions (i.e., HasVAListArg==true), we add a 1790d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // special check to see if the format string is a function parameter 1791d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // of the function calling the printf function. If the function 1792d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // has an attribute indicating it is a printf-like function, then we 1793d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // should suppress warnings concerning non-literals being used in a call 1794d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // to a vprintf function. For example: 1795d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1796d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // void 1797d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 1798d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_list ap; 1799d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_start(ap, fmt); 1800d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 1801d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // ... 1802d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1803f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (HasVAListArg) { 1804f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(VD)) { 1805f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const NamedDecl *ND = dyn_cast<NamedDecl>(PV->getDeclContext())) { 1806f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas int PVIndex = PV->getFunctionScopeIndex() + 1; 1807f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas for (specific_attr_iterator<FormatAttr> 1808f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas i = ND->specific_attr_begin<FormatAttr>(), 1809f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas e = ND->specific_attr_end<FormatAttr>(); i != e ; ++i) { 1810f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas FormatAttr *PVFormat = *i; 1811f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // adjust for implicit parameter 1812f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 1813f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (MD->isInstance()) 1814f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas ++PVIndex; 1815f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // We also check if the formats are compatible. 1816f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // We can't pass a 'scanf' string to a 'printf' function. 1817f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (PVIndex == PVFormat->getFormatIdx() && 1818f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas Type == GetFormatStringType(PVFormat)) 1819831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_UncheckedLiteral; 1820f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1821f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1822f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1823f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1824082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 18251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1826831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1827082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 1828d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 182952aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas case Stmt::CallExprClass: 183052aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas case Stmt::CXXMemberCallExprClass: { 18318f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const CallExpr *CE = cast<CallExpr>(E); 183252aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const NamedDecl *ND = dyn_cast_or_null<NamedDecl>(CE->getCalleeDecl())) { 183352aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) { 183452aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas unsigned ArgIndex = FA->getFormatIdx(); 183552aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 183652aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (MD->isInstance()) 183752aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas --ArgIndex; 183852aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas const Expr *Arg = CE->getArg(ArgIndex - 1); 183952aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas 18401c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return checkFormatStringExpr(Arg, Args, 1841831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1842ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 184350687314f87b67073c202fe46d84d12fb55e25cfJordan Rose } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(ND)) { 184450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned BuiltinID = FD->getBuiltinID(); 184550687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (BuiltinID == Builtin::BI__builtin___CFStringMakeConstantString || 184650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose BuiltinID == Builtin::BI__builtin___NSStringMakeConstantString) { 184750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose const Expr *Arg = CE->getArg(0); 18481c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return checkFormatStringExpr(Arg, Args, 1849831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, 1850ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, CallType, 1851ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall); 185250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose } 18538f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 18548f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 18551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1856831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 18578f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 1858082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::ObjCStringLiteralClass: 1859082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::StringLiteralClass: { 1860082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const StringLiteral *StrE = NULL; 18611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1862082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 1863d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek StrE = ObjCFExpr->getString(); 1864d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek else 1865082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek StrE = cast<StringLiteral>(E); 18661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1867d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek if (StrE) { 18681c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko CheckFormatString(StrE, E, Args, HasVAListArg, format_idx, 1869ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, inFunctionCall, CallType); 1870831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_CheckedLiteral; 1871d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 18721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1873831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1874d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 18751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1876082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek default: 1877831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1878d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1879d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1880d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1881e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid 18821eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull, 1883909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr * const *ExprArgs, 1884909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky SourceLocation CallSiteLoc) { 1885cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt for (NonNullAttr::args_iterator i = NonNull->args_begin(), 1886cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt e = NonNull->args_end(); 1887e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian i != e; ++i) { 1888909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr *ArgExpr = ExprArgs[*i]; 18893edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky 18903edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky // As a special case, transparent unions initialized with zero are 18913edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky // considered null for the purposes of the nonnull attribute. 18923edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (const RecordType *UT = ArgExpr->getType()->getAsUnionType()) { 18933edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (UT->getDecl()->hasAttr<TransparentUnionAttr>()) 18943edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (const CompoundLiteralExpr *CLE = 18953edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky dyn_cast<CompoundLiteralExpr>(ArgExpr)) 18963edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (const InitListExpr *ILE = 18973edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky dyn_cast<InitListExpr>(CLE->getInitializer())) 18983edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky ArgExpr = ILE->getInit(0); 18993edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky } 19003edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky 19013edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky bool Result; 19023edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (ArgExpr->EvaluateAsBooleanCondition(Result, Context) && !Result) 1903909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange(); 1904e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian } 1905e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian} 1906d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 190734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel DupasSema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) { 190834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas return llvm::StringSwitch<FormatStringType>(Format->getType()) 190934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("scanf", FST_Scanf) 191034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("printf", "printf0", FST_Printf) 191134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("NSString", "CFString", FST_NSString) 191234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("strftime", FST_Strftime) 191334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("strfmon", FST_Strfmon) 191434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf) 191534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Default(FST_Unknown); 191634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas} 191734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas 1918ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose/// CheckFormatArguments - Check calls to printf and scanf (and similar 1919826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings. 1920831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true if a format string has been fully checked. 19211c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkobool Sema::CheckFormatArguments(const FormatAttr *Format, 19221c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 19231c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko bool IsCXXMember, 1924ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose VariadicCallType CallType, 192529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas SourceLocation Loc, SourceRange Range) { 1926831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FormatStringInfo FSI; 1927831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (getFormatStringInfo(Format, IsCXXMember, &FSI)) 19281c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return CheckFormatArguments(Args, FSI.HasVAListArg, FSI.FormatIdx, 1929831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI.FirstDataArg, GetFormatStringType(Format), 1930ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose CallType, Loc, Range); 1931831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 193229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 19334a2614e94672c47395abcde60518776fbebec589Sebastian Redl 19341c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkobool Sema::CheckFormatArguments(ArrayRef<const Expr *> Args, 193534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas bool HasVAListArg, unsigned format_idx, 193634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg, FormatStringType Type, 1937ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose VariadicCallType CallType, 193834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas SourceLocation Loc, SourceRange Range) { 1939826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // CHECK: printf/scanf-like function is called with no format string. 19401c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko if (format_idx >= Args.size()) { 194129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Loc, diag::warn_missing_format_string) << Range; 1942831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 194371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek } 19441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 194529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts(); 19461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 194759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner // CHECK: format string is not a string literal. 19481eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // 194971895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // Dynamically generated format strings are difficult to 195071895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // automatically vet at compile time. Requiring that format strings 195171895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // are string literals: (1) permits the checking of format strings by 195271895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // the compiler and thereby (2) can practically remove the source of 195371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // many format string exploits. 19547ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek 19551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // Format string can be either ObjC string (e.g. @"%d") or 19567ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // C string (e.g. "%d") 19571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // ObjC string uses the same format specifiers as C string, so we can use 19587ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // the same format string checking logic for both ObjC and C strings. 1959831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType CT = 19601c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkFormatStringExpr(OrigFormatExpr, Args, HasVAListArg, 1961ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose format_idx, firstDataArg, Type, CallType); 1962831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (CT != SLCT_NotALiteral) 1963831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // Literal format string found, check done! 1964831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return CT == SLCT_CheckedLiteral; 19651cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner 19662837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas // Strftime is particular as it always uses a single 'time' argument, 19672837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas // so it is safe to pass a non-literal string. 19682837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas if (Type == FST_Strftime) 1969831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 19702837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas 1971ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // Do not emit diag when the string param is a macro expansion and the 1972ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // format is either NSString or CFString. This is a hack to prevent 1973ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // diag when using the NSLocalizedString and CFCopyLocalizedString macros 1974ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // which are usually used in place of NS and CF string literals. 1975dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas if (Type == FST_NSString && 1976dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas SourceMgr.isInSystemMacro(Args[format_idx]->getLocStart())) 1977831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 1978ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas 1979655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // If there are no arguments specified, warn with -Wformat-security, otherwise 1980655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // warn only with -Wformat-nonliteral. 19812243e78a6580ead4d17b76c924cd4b630b50d6aeEli Friedman if (Args.size() == firstDataArg) 198229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Args[format_idx]->getLocStart(), 1983826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral_noargs) 1984655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1985655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner else 198629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Args[format_idx]->getLocStart(), 1987826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral) 1988655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1989831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 1990d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1991d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1992e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace { 1993826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler { 1994826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1995e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Sema &S; 1996e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const StringLiteral *FExpr; 1997e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const Expr *OrigFormatExpr; 19986ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const unsigned FirstDataArg; 1999e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const unsigned NumDataArgs; 2000e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *Beg; // Start of format string. 20010d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const bool HasVAListArg; 20021c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args; 20030d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek unsigned FormatIdx; 20047f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek llvm::BitVector CoveredArgs; 2005efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool usesPositionalArgs; 2006efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool atFirstArg; 200755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool inFunctionCall; 2008ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType; 20094e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic: 2010826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 20116ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 201250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, const char *beg, bool hasVAListArg, 20131c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 2014ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 2015ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType callType) 2016e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 201750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose FirstDataArg(firstDataArg), NumDataArgs(numDataArgs), 201850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose Beg(beg), HasVAListArg(hasVAListArg), 20191c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Args(Args), FormatIdx(formatIdx), 202055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu usesPositionalArgs(false), atFirstArg(true), 2021ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall(inFunctionCall), CallType(callType) { 20227f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.resize(numDataArgs); 20237f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.reset(); 20247f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 20254e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 202607d161f38e708a91486bf1c031d525faebbb249dTed Kremenek void DoneProcessing(); 20274e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2028826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIncompleteSpecifier(const char *startSpecifier, 2029826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 203076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 2031bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose void HandleInvalidLengthModifier( 2032bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::FormatSpecifier &FS, 2033bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::ConversionSpecifier &CS, 20348be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const char *startSpecifier, unsigned specifierLen, unsigned DiagID); 2035bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 203676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg void HandleNonStandardLengthModifier( 20378be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const analyze_format_string::FormatSpecifier &FS, 203876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen); 203976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 204076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg void HandleNonStandardConversionSpecifier( 204176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 204276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen); 204376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 2044f85626453123f9691bcef13cff963f556e209c27Hans Wennborg virtual void HandlePosition(const char *startPos, unsigned posLen); 2045f85626453123f9691bcef13cff963f556e209c27Hans Wennborg 2046efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleInvalidPosition(const char *startSpecifier, 2047efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned specifierLen, 2048826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p); 2049efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2050efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 2051efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2052e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek void HandleNullChar(const char *nullCharacter); 20534e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 205455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 205555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu static void EmitFormatDiagnostic(Sema &S, bool inFunctionCall, 205655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 205755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 205855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation StringLoc, 205955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 20605543169296beeb183b9c9392debc774fcf493eebDmitri Gribenko ArrayRef<FixItHint> Fixit = None); 206155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2062826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 2063c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 2064c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 2065c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 2066c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, unsigned csLen); 206755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 206855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void HandlePositionalNonpositionalArgs(SourceLocation Loc, 206955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 207055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen); 2071c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2072f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek SourceRange getFormatStringRange(); 2073826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CharSourceRange getSpecifierRange(const char *startSpecifier, 2074826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2075e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek SourceLocation getLocationOfByte(const char *x); 20764e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 20770d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const Expr *getDataArg(unsigned i) const; 2078666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 2079666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 2080666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 2081666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, 2082666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek unsigned argIndex); 208355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 208455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 208555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc, 208655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 20875543169296beeb183b9c9392debc774fcf493eebDmitri Gribenko ArrayRef<FixItHint> Fixit = None); 208855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 208955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void CheckPositionalAndNonpositionalArgs( 209055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const analyze_format_string::FormatSpecifier *FS); 2091e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}; 2092e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2093e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2094826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() { 2095e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return OrigFormatExpr->getSourceRange(); 2096e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2097e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2098826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler:: 2099826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 210045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation Start = getLocationOfByte(startSpecifier); 210145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 210245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 210345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care // Advance the end SourceLocation by one due to half-open ranges. 2104a64ccefdf0ea4e03ec88805d71b0af74950c7472Argyrios Kyrtzidis End = End.getLocWithOffset(1); 210545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 210645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care return CharSourceRange::getCharRange(Start, End); 2107f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek} 2108f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek 2109826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 21104e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 2111e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2112e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2113826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 2114826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen){ 211555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier), 211655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startSpecifier), 211755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 211855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 2119808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek} 2120808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek 2121bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rosevoid CheckFormatHandler::HandleInvalidLengthModifier( 2122bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::FormatSpecifier &FS, 2123bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::ConversionSpecifier &CS, 21248be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const char *startSpecifier, unsigned specifierLen, unsigned DiagID) { 2125bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose using namespace analyze_format_string; 2126bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2127bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const LengthModifier &LM = FS.getLengthModifier(); 2128bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength()); 2129bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2130bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose // See if we know how to fix this length modifier. 2131dc84cd5efdd3430efb22546b4ac656aa0540b210David Blaikie Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier(); 2132bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (FixedLM) { 21338be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(), 2134bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getLocationOfByte(LM.getStart()), 2135bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose /*IsStringLocation*/true, 2136bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 2137bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2138bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier) 2139bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose << FixedLM->toString() 2140bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose << FixItHint::CreateReplacement(LMRange, FixedLM->toString()); 2141bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2142bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose } else { 21438be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose FixItHint Hint; 21448be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose if (DiagID == diag::warn_format_nonsensical_length) 21458be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose Hint = FixItHint::CreateRemoval(LMRange); 21468be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 21478be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(), 2148bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getLocationOfByte(LM.getStart()), 2149bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose /*IsStringLocation*/true, 2150bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getSpecifierRange(startSpecifier, specifierLen), 21518be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose Hint); 2152bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose } 2153bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose} 2154bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 215576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardLengthModifier( 21568be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const analyze_format_string::FormatSpecifier &FS, 215776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen) { 21588be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose using namespace analyze_format_string; 21598be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 21608be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const LengthModifier &LM = FS.getLengthModifier(); 21618be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength()); 21628be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 21638be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose // See if we know how to fix this length modifier. 2164dc84cd5efdd3430efb22546b4ac656aa0540b210David Blaikie Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier(); 21658be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose if (FixedLM) { 21668be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 21678be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << LM.toString() << 0, 21688be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getLocationOfByte(LM.getStart()), 21698be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose /*IsStringLocation*/true, 21708be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 21718be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 21728be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier) 21738be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << FixedLM->toString() 21748be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << FixItHint::CreateReplacement(LMRange, FixedLM->toString()); 21758be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 21768be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose } else { 21778be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 21788be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << LM.toString() << 0, 21798be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getLocationOfByte(LM.getStart()), 21808be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose /*IsStringLocation*/true, 21818be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 21828be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose } 218376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg} 218476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 218576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardConversionSpecifier( 218676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 218776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen) { 2188670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose using namespace analyze_format_string; 2189670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose 2190670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose // See if we know how to fix this conversion specifier. 2191dc84cd5efdd3430efb22546b4ac656aa0540b210David Blaikie Optional<ConversionSpecifier> FixedCS = CS.getStandardSpecifier(); 2192670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose if (FixedCS) { 2193670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 2194670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << CS.toString() << /*conversion specifier*/1, 2195670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getLocationOfByte(CS.getStart()), 2196670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose /*IsStringLocation*/true, 2197670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 2198670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose 2199670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose CharSourceRange CSRange = getSpecifierRange(CS.getStart(), CS.getLength()); 2200670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose S.Diag(getLocationOfByte(CS.getStart()), diag::note_format_fix_specifier) 2201670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << FixedCS->toString() 2202670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << FixItHint::CreateReplacement(CSRange, FixedCS->toString()); 2203670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose } else { 2204670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 2205670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << CS.toString() << /*conversion specifier*/1, 2206670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getLocationOfByte(CS.getStart()), 2207670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose /*IsStringLocation*/true, 2208670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 2209670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose } 221076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg} 221176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 2212f85626453123f9691bcef13cff963f556e209c27Hans Wennborgvoid CheckFormatHandler::HandlePosition(const char *startPos, 2213f85626453123f9691bcef13cff963f556e209c27Hans Wennborg unsigned posLen) { 2214f85626453123f9691bcef13cff963f556e209c27Hans Wennborg EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_positional_arg), 2215f85626453123f9691bcef13cff963f556e209c27Hans Wennborg getLocationOfByte(startPos), 2216f85626453123f9691bcef13cff963f556e209c27Hans Wennborg /*IsStringLocation*/true, 2217f85626453123f9691bcef13cff963f556e209c27Hans Wennborg getSpecifierRange(startPos, posLen)); 2218f85626453123f9691bcef13cff963f556e209c27Hans Wennborg} 2219f85626453123f9691bcef13cff963f556e209c27Hans Wennborg 2220efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid 2221826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 2222826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p) { 222355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier) 222455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (unsigned) p, 222555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), /*IsStringLocation*/true, 222655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 2227efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 2228efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2229826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos, 2230efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned posLen) { 223155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier), 223255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), 223355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 223455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 2235efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 2236efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2237826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 223850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (!isa<ObjCStringLiteral>(OrigFormatExpr)) { 22390c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek // The presence of a null character is likely an error. 224055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 224155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_format_string_contains_null_char), 224255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(nullCharacter), /*IsStringLocation*/true, 224355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getFormatStringRange()); 22440c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek } 2245826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2246826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 224748716663e421472cbd590af160a372bc490205e8Jordan Rose// Note that this may return NULL if there was an error parsing or building 224848716663e421472cbd590af160a372bc490205e8Jordan Rose// one of the argument expressions. 2249826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const { 225029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return Args[FirstDataArg + i]; 2251826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 22524e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2253826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() { 2254826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Does the number of data arguments exceed the number of 2255826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // format conversions in the format string? 2256826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!HasVAListArg) { 2257826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Find any arguments that weren't covered. 2258826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.flip(); 2259826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek signed notCoveredArg = CoveredArgs.find_first(); 2260826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (notCoveredArg >= 0) { 2261826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek assert((unsigned)notCoveredArg < NumDataArgs); 226248716663e421472cbd590af160a372bc490205e8Jordan Rose if (const Expr *E = getDataArg((unsigned) notCoveredArg)) { 226348716663e421472cbd590af160a372bc490205e8Jordan Rose SourceLocation Loc = E->getLocStart(); 226448716663e421472cbd590af160a372bc490205e8Jordan Rose if (!S.getSourceManager().isInSystemMacro(Loc)) { 226548716663e421472cbd590af160a372bc490205e8Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_printf_data_arg_not_used), 226648716663e421472cbd590af160a372bc490205e8Jordan Rose Loc, /*IsStringLocation*/false, 226748716663e421472cbd590af160a372bc490205e8Jordan Rose getFormatStringRange()); 226848716663e421472cbd590af160a372bc490205e8Jordan Rose } 2269c03f2df2a2b097bf2686bf32411d5022323988b2Bob Wilson } 2270826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2271826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2272826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2273826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2274c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool 2275c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 2276c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek SourceLocation Loc, 2277c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 2278c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 2279c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, 2280c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned csLen) { 2281c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2282c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool keepGoing = true; 2283c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek if (argIndex < NumDataArgs) { 2284c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // Consider the argument coverered, even though the specifier doesn't 2285c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // make sense. 2286c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CoveredArgs.set(argIndex); 2287c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 2288c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek else { 2289c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // If argIndex exceeds the number of data arguments we 2290c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // don't issue a warning because that is just a cascade of warnings (and 2291c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // they may have intended '%%' anyway). We don't want to continue processing 2292c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // the format string after this point, however, as we will like just get 2293c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // gibberish when trying to match arguments. 2294c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek keepGoing = false; 2295c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 2296c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 229755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_conversion) 229855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << StringRef(csStart, csLen), 229955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*IsStringLocation*/true, 230055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpec, specifierLen)); 2301c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2302c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return keepGoing; 2303c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 2304c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 230555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid 230655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard TrieuCheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc, 230755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 230855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen) { 230955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 231055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_format_mix_positional_nonpositional_args), 231155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen)); 231255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 231355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2314666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool 2315666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs( 2316666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::FormatSpecifier &FS, 2317666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 2318666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 2319666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 2320666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (argIndex >= NumDataArgs) { 232155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag = FS.usesPositionalArg() 232255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args) 232355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (argIndex+1) << NumDataArgs) 232455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : S.PDiag(diag::warn_printf_insufficient_data_args); 232555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 232655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true, 232755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 2328666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return false; 2329666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 2330666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return true; 2331666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek} 2332666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 233355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 233455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag, 233555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 233655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 233755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 2338ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose ArrayRef<FixItHint> FixIt) { 233929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag, 234055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, IsStringLocation, StringRange, FixIt); 234155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 234255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 234355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \brief If the format string is not within the funcion call, emit a note 234455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// so that the function call and string are in diagnostic messages. 234555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 234670517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param InFunctionCall if true, the format string is within the function 234755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// call and only one diagnostic message will be produced. Otherwise, an 234855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// extra note will be emitted pointing to location of the format string. 234955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 235055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param ArgumentExpr the expression that is passed as the format string 235155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// argument in the function call. Used for getting locations when two 235255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostics are emitted. 235355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 235455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param PDiag the callee should already have provided any strings for the 235555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostic message. This function only adds locations and fixits 235655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// to diagnostics. 235755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 235855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param Loc primary location for diagnostic. If two diagnostics are 235955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// required, one will be at Loc and a new SourceLocation will be created for 236055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// the other one. 236155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 236255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param IsStringLocation if true, Loc points to the format string should be 236355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// used for the note. Otherwise, Loc points to the argument list and will 236455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// be used with PDiag. 236555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 236655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param StringRange some or all of the string to highlight. This is 236755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// templated so it can accept either a CharSourceRange or a SourceRange. 236855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 236970517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param FixIt optional fix it hint for the format string. 237055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 237155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(Sema &S, bool InFunctionCall, 237255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 237355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 237455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 237555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 237655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 2377ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose ArrayRef<FixItHint> FixIt) { 2378ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (InFunctionCall) { 2379ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Sema::SemaDiagnosticBuilder &D = S.Diag(Loc, PDiag); 2380ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose D << StringRange; 2381ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end(); 2382ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose I != E; ++I) { 2383ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose D << *I; 2384ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2385ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else { 238655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag) 238755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ArgumentExpr->getSourceRange(); 2388ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2389ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Sema::SemaDiagnosticBuilder &Note = 2390ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose S.Diag(IsStringLocation ? Loc : StringRange.getBegin(), 2391ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose diag::note_format_string_defined); 2392ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2393ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Note << StringRange; 2394ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end(); 2395ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose I != E; ++I) { 2396ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Note << *I; 2397ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 239855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu } 239955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 240055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2401826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===// 2402826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2403826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 2404826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler { 240550687314f87b67073c202fe46d84d12fb55e25cfJordan Rose bool ObjCContext; 2406826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 2407826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 2408826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 240950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, bool isObjC, 2410826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 24111c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 2412ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 2413ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType) 2414826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 24151c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko numDataArgs, beg, hasVAListArg, Args, 2416ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose formatIdx, inFunctionCall, CallType), ObjCContext(isObjC) 2417ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose {} 2418ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose 2419826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2420826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleInvalidPrintfConversionSpecifier( 2421826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2422826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2423826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2424826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2425826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 2426826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2427826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2428831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool checkFormatExpr(const analyze_printf::PrintfSpecifier &FS, 2429831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const char *StartSpecifier, 2430831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned SpecifierLen, 2431831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E); 2432831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2433826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 2434826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2435826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 2436826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalAmount &Amt, 2437826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned type, 2438826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2439826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 2440826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 2441826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2442826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 2443826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &ignoredFlag, 2444826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 2445826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2446f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg bool checkForCStrMembers(const analyze_printf::ArgType &AT, 2447831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E, const CharSourceRange &CSR); 2448831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2449826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 2450826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2451826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2452826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 2453826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2454826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2455826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 24566ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 2457c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 2458826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2459c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 2460c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 2461c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 2462c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 246326ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek} 246426ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek 2465826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount( 2466826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_format_string::OptionalAmount &Amt, 2467826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned k, const char *startSpecifier, 2468826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 24690d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 24700d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (Amt.hasDataArgument()) { 24710d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (!HasVAListArg) { 24727f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = Amt.getArgIndex(); 24737f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (argIndex >= NumDataArgs) { 247455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg) 247555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << k, 247655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 247755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 247855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 24790d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 24800d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 24810d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 24820d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 24834e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 24840d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Type check the data argument. It should be an 'int'. 248531f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // Although not in conformance with C99, we also allow the argument to be 248631f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // an 'unsigned int' as that is a reasonably safe case. GCC also 248731f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // doesn't emit a warning for that case. 24887f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.set(argIndex); 24897f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek const Expr *Arg = getDataArg(argIndex); 249048716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Arg) 249148716663e421472cbd590af160a372bc490205e8Jordan Rose return false; 249248716663e421472cbd590af160a372bc490205e8Jordan Rose 24930d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek QualType T = Arg->getType(); 24944e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2495f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT = Amt.getArgType(S.Context); 2496f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg assert(AT.isValid()); 24974e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2498f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg if (!AT.matchesType(S.Context, T)) { 249955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type) 2500f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg << k << AT.getRepresentativeTypeName(S.Context) 250155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << T << Arg->getSourceRange(), 250255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 250355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 250455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 25050d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 25060d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 25070d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 25080d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 25090d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 25100d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 25110d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return true; 25120d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek} 25130d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 2514e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount( 2515826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2516e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalAmount &Amt, 2517e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned type, 2518e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2519e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 25206ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 25216ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 2522e4ee9663168dfb2b4122c768091e30217328c9faTom Care 252355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint fixit = 252455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant 252555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 252655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getConstantLength())) 252755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : FixItHint(); 252855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 252955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount) 253055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << type << CS.toString(), 253155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 253255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 253355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 253455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu fixit); 2535e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2536e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2537826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 2538e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 2539e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2540e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 2541e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about pointless flag with a fixit removal. 25426ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 25436ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 254455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag) 254555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << flag.toString() << CS.toString(), 254655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(flag.getPosition()), 254755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 254855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 254955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 255055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(flag.getPosition(), 1))); 2551e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2552e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2553e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag( 2554826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2555e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &ignoredFlag, 2556e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 2557e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2558e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 2559e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about ignored flag with a fixit removal. 256055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag) 256155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ignoredFlag.toString() << flag.toString(), 256255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(ignoredFlag.getPosition()), 256355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 256455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 256555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 256655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(ignoredFlag.getPosition(), 1))); 2567e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2568e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2569831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determines if the specified is a C++ class or struct containing 2570831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// a member with the specified name and kind (e.g. a CXXMethodDecl named 2571831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// "c_str()"). 2572831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithtemplate<typename MemberKind> 2573831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithstatic llvm::SmallPtrSet<MemberKind*, 1> 2574831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCXXRecordMembersNamed(StringRef Name, Sema &S, QualType Ty) { 2575831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const RecordType *RT = Ty->getAs<RecordType>(); 2576831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith llvm::SmallPtrSet<MemberKind*, 1> Results; 2577831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2578831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!RT) 2579831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2580831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl()); 2581831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!RD) 2582831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2583831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2584831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith LookupResult R(S, &S.PP.getIdentifierTable().get(Name), SourceLocation(), 2585831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Sema::LookupMemberName); 2586831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2587831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // We just need to include all members of the right kind turned up by the 2588831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // filter, at this point. 2589831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (S.LookupQualifiedName(R, RT->getDecl())) 2590831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith for (LookupResult::iterator I = R.begin(), E = R.end(); I != E; ++I) { 2591831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith NamedDecl *decl = (*I)->getUnderlyingDecl(); 2592831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (MemberKind *FK = dyn_cast<MemberKind>(decl)) 2593831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Results.insert(FK); 2594831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2595831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2596831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2597831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2598831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Check if a (w)string was passed when a (w)char* was needed, and offer a 2599f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg// better diagnostic if so. AT is assumed to be valid. 2600831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Returns true when a c_str() conversion method is found. 2601831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool CheckPrintfHandler::checkForCStrMembers( 2602f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT, const Expr *E, 2603831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CharSourceRange &CSR) { 2604831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith typedef llvm::SmallPtrSet<CXXMethodDecl*, 1> MethodSet; 2605831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2606831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith MethodSet Results = 2607831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith CXXRecordMembersNamed<CXXMethodDecl>("c_str", S, E->getType()); 2608831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2609831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith for (MethodSet::iterator MI = Results.begin(), ME = Results.end(); 2610831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith MI != ME; ++MI) { 2611831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CXXMethodDecl *Method = *MI; 2612831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (Method->getNumParams() == 0 && 2613f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg AT.matchesType(S.Context, Method->getResultType())) { 2614831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // FIXME: Suggest parens if the expression needs them. 2615831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation EndLoc = 2616831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()); 2617831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith S.Diag(E->getLocStart(), diag::note_printf_c_str) 2618831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << "c_str()" 2619831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << FixItHint::CreateInsertion(EndLoc, ".c_str()"); 2620831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return true; 2621831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2622831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2623831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2624831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 2625831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2626831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2627e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool 2628826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 26295c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek &FS, 2630e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *startSpecifier, 2631e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned specifierLen) { 2632e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 26336ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek using namespace analyze_format_string; 2634efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek using namespace analyze_printf; 26356ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 2636e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2637baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 2638baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 2639baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 2640baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 2641baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2642baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 264355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 264455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 2645baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 2646baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2647efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek } 2648efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 26490d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // First check if the field width, precision, and conversion specifier 26500d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // have matching data arguments. 2651efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 2652efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 26530d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 26540d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 26554e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2656efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 2657efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 26580d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 26590d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 26600d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 2661f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek if (!CS.consumesDataArgument()) { 2662f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // FIXME: Technically specifying a precision or field width here 2663f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // makes no sense. Worth issuing a warning at some point. 26640e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek return true; 2665f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek } 26664e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 26677f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Consume the argument. 26687f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = FS.getArgIndex(); 2669e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek if (argIndex < NumDataArgs) { 2670e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // The check to see if the argIndex is valid will come later. 2671e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // We set the bit here because we may exit early from this 2672e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // function if we encounter some other error. 2673e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek CoveredArgs.set(argIndex); 2674e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek } 26757f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek 26767f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Check for using an Objective-C specific conversion specifier 26777f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // in a non-ObjC literal. 267850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (!ObjCContext && CS.isObjCArg()) { 2679826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 2680826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek specifierLen); 26817f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 26824e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2683e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of field width 2684e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidFieldWidth()) { 268545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 2686e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2687e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2688e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2689e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of precision 2690e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPrecision()) { 2691e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 2692e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2693e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2694e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2695e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check each flag does not conflict with any other component. 269665197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek if (!FS.hasValidThousandsGroupingPrefix()) 269765197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen); 2698e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeadingZeros()) 2699e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 2700e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPlusPrefix()) 2701e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 270245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (!FS.hasValidSpacePrefix()) 270345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 2704e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidAlternativeForm()) 2705e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 2706e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeftJustified()) 2707e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 2708e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2709e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check that flags are not ignored by another flag 271045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 271145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 271245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care startSpecifier, specifierLen); 2713e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 2714e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 2715e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2716e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2717e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check the length modifier is valid with the given conversion specifier. 2718bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo())) 27198be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 27208be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_nonsensical_length); 2721bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthModifier()) 27228be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen); 2723bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthConversionCombination()) 27248be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 27258be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_non_standard_conversion_spec); 2726e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2727bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 2728bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 2729bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2730da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek // The remaining checks depend on the data arguments. 2731da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek if (HasVAListArg) 2732da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return true; 27334e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2734666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 2735da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return false; 27364e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 273748716663e421472cbd590af160a372bc490205e8Jordan Rose const Expr *Arg = getDataArg(argIndex); 273848716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Arg) 273948716663e421472cbd590af160a372bc490205e8Jordan Rose return true; 274048716663e421472cbd590af160a372bc490205e8Jordan Rose 274148716663e421472cbd590af160a372bc490205e8Jordan Rose return checkFormatExpr(FS, startSpecifier, specifierLen, Arg); 2742831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2743831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2744ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rosestatic bool requiresParensToAddCast(const Expr *E) { 2745ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // FIXME: We should have a general way to reason about operator 2746ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // precedence and whether parens are actually needed here. 2747ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Take care of a few common cases where they aren't. 2748ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Expr *Inside = E->IgnoreImpCasts(); 2749ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (const PseudoObjectExpr *POE = dyn_cast<PseudoObjectExpr>(Inside)) 2750ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Inside = POE->getSyntacticForm()->IgnoreImpCasts(); 2751ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2752ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose switch (Inside->getStmtClass()) { 2753ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ArraySubscriptExprClass: 2754ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::CallExprClass: 275517ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::CharacterLiteralClass: 275617ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::CXXBoolLiteralExprClass: 2757ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::DeclRefExprClass: 275817ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::FloatingLiteralClass: 275917ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::IntegerLiteralClass: 2760ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::MemberExprClass: 276117ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCArrayLiteralClass: 276217ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCBoolLiteralExprClass: 276317ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCBoxedExprClass: 276417ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCDictionaryLiteralClass: 276517ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCEncodeExprClass: 2766ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCIvarRefExprClass: 2767ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCMessageExprClass: 2768ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCPropertyRefExprClass: 276917ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCStringLiteralClass: 277017ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCSubscriptRefExprClass: 2771ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ParenExprClass: 277217ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::StringLiteralClass: 2773ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::UnaryOperatorClass: 2774ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose return false; 2775ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose default: 2776ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose return true; 2777ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2778ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose} 2779ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2780831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool 2781831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCheckPrintfHandler::checkFormatExpr(const analyze_printf::PrintfSpecifier &FS, 2782831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const char *StartSpecifier, 2783831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned SpecifierLen, 2784831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E) { 2785831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith using namespace analyze_format_string; 2786831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith using namespace analyze_printf; 278796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Now type check the data expression that matches the 278896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // format specifier. 2789f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT = FS.getArgType(S.Context, 2790f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg ObjCContext); 2791614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (!AT.isValid()) 2792614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 2793ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2794448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose QualType ExprTy = E->getType(); 279502be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek while (const TypeOfExprType *TET = dyn_cast<TypeOfExprType>(ExprTy)) { 279602be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek ExprTy = TET->getUnderlyingExpr()->getType(); 279702be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek } 279802be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek 2799448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (AT.matchesType(S.Context, ExprTy)) 2800614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 2801614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 2802614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Look through argument promotions for our error message's reported type. 2803614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // This includes the integral and floating promotions, but excludes array 2804614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // and function pointer decay; seeing that an argument intended to be a 2805614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // string has type 'char [6]' is probably more confusing than 'char *'. 2806614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 2807614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (ICE->getCastKind() == CK_IntegralCast || 2808614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose ICE->getCastKind() == CK_FloatingCast) { 2809614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E = ICE->getSubExpr(); 2810448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose ExprTy = E->getType(); 2811614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 2812614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Check if we didn't match because of an implicit cast from a 'char' 2813614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // or 'short' to an 'int'. This is done because printf is a varargs 2814614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // function. 2815614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (ICE->getType() == S.Context.IntTy || 2816614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose ICE->getType() == S.Context.UnsignedIntTy) { 2817614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // All further checking is done on the subexpression. 2818448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (AT.matchesType(S.Context, ExprTy)) 2819614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 28204d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek } 2821ee0259d308e72141982a85b40863e760a8447edfJordan Rose } 2822448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose } else if (const CharacterLiteral *CL = dyn_cast<CharacterLiteral>(E)) { 2823448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose // Special case for 'a', which has type 'int' in C. 2824448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose // Note, however, that we do /not/ want to treat multibyte constants like 2825448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose // 'MooV' as characters! This form is deprecated but still exists. 2826448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (ExprTy == S.Context.IntTy) 2827448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (llvm::isUIntN(S.Context.getCharWidth(), CL->getValue())) 2828448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose ExprTy = S.Context.CharTy; 2829614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } 2830614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 28312cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // %C in an Objective-C context prints a unichar, not a wchar_t. 28322cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // If the argument is an integer of some kind, believe the %C and suggest 28332cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // a cast instead of changing the conversion specifier. 2834448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose QualType IntendedTy = ExprTy; 28352cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (ObjCContext && 28362cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose FS.getConversionSpecifier().getKind() == ConversionSpecifier::CArg) { 28372cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (ExprTy->isIntegralOrUnscopedEnumerationType() && 28382cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose !ExprTy->isCharType()) { 28392cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // 'unichar' is defined as a typedef of unsigned short, but we should 28402cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // prefer using the typedef if it is visible. 28412cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose IntendedTy = S.Context.UnsignedShortTy; 28422cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 28432cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose LookupResult Result(S, &S.Context.Idents.get("unichar"), E->getLocStart(), 28442cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose Sema::LookupOrdinaryName); 28452cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (S.LookupName(Result, S.getCurScope())) { 28462cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose NamedDecl *ND = Result.getFoundDecl(); 28472cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (TypedefNameDecl *TD = dyn_cast<TypedefNameDecl>(ND)) 28482cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (TD->getUnderlyingType() == IntendedTy) 28492cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose IntendedTy = S.Context.getTypedefType(TD); 28502cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 28512cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 28522cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 28532cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 28542cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // Special-case some of Darwin's platform-independence types by suggesting 28552cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // casts to primitive types that are known to be large enough. 28562cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose bool ShouldNotPrintDirectly = false; 2857ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (S.Context.getTargetInfo().getTriple().isOSDarwin()) { 28586edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek // Use a 'while' to peel off layers of typedefs. 28596edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek QualType TyTy = IntendedTy; 28606edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek while (const TypedefType *UserTy = TyTy->getAs<TypedefType>()) { 2861ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose StringRef Name = UserTy->getDecl()->getName(); 28622cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose QualType CastTy = llvm::StringSwitch<QualType>(Name) 2863ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("NSInteger", S.Context.LongTy) 2864ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("NSUInteger", S.Context.UnsignedLongTy) 2865ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("SInt32", S.Context.IntTy) 2866ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("UInt32", S.Context.UnsignedIntTy) 28672cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose .Default(QualType()); 28682cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 28692cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (!CastTy.isNull()) { 28702cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose ShouldNotPrintDirectly = true; 28712cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose IntendedTy = CastTy; 28726edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek break; 28732cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 28746edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek TyTy = UserTy->desugar(); 2875ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2876ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2877ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2878614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // We may be able to offer a FixItHint if it is a supported type. 2879614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose PrintfSpecifier fixedFS = FS; 2880ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose bool success = fixedFS.fixType(IntendedTy, S.getLangOpts(), 2881614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose S.Context, ObjCContext); 288296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2883614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (success) { 2884614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Get the fix string from the fixed format specifier 2885614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose SmallString<16> buf; 2886614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose llvm::raw_svector_ostream os(buf); 2887614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose fixedFS.toString(os); 2888614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 2889ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CharSourceRange SpecRange = getSpecifierRange(StartSpecifier, SpecifierLen); 2890ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 28912cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (IntendedTy == ExprTy) { 28922cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // In this case, the specifier is wrong and should be changed to match 28932cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // the argument. 28942cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose EmitFormatDiagnostic( 28952cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 28962cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << AT.getRepresentativeTypeName(S.Context) << IntendedTy 28972cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << E->getSourceRange(), 28982cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose E->getLocStart(), 28992cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose /*IsStringLocation*/false, 29002cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose SpecRange, 29012cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose FixItHint::CreateReplacement(SpecRange, os.str())); 29022cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 29032cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } else { 2904ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // The canonical type for formatting this value is different from the 2905ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // actual type of the expression. (This occurs, for example, with Darwin's 2906ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // NSInteger on 32-bit platforms, where it is typedef'd as 'int', but 2907ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // should be printed as 'long' for 64-bit compatibility.) 2908ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Rather than emitting a normal format/argument mismatch, we want to 2909ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // add a cast to the recommended type (and correct the format string 2910ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // if necessary). 2911ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SmallString<16> CastBuf; 2912ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose llvm::raw_svector_ostream CastFix(CastBuf); 2913ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << "("; 2914ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose IntendedTy.print(CastFix, S.Context.getPrintingPolicy()); 2915ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << ")"; 2916ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2917ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SmallVector<FixItHint,4> Hints; 2918ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (!AT.matchesType(S.Context, IntendedTy)) 2919ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateReplacement(SpecRange, os.str())); 2920ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2921ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (const CStyleCastExpr *CCast = dyn_cast<CStyleCastExpr>(E)) { 2922ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // If there's already a cast present, just replace it. 2923ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SourceRange CastRange(CCast->getLParenLoc(), CCast->getRParenLoc()); 2924ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateReplacement(CastRange, CastFix.str())); 2925ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2926ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else if (!requiresParensToAddCast(E)) { 2927ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // If the expression has high enough precedence, 2928ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // just write the C-style cast. 2929ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(), 2930ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix.str())); 2931ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else { 2932ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Otherwise, add parens around the expression as well as the cast. 2933ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << "("; 2934ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(), 2935ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix.str())); 2936ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2937ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SourceLocation After = S.PP.getLocForEndOfToken(E->getLocEnd()); 2938ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(After, ")")); 2939ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2940ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 29412cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (ShouldNotPrintDirectly) { 29422cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // The expression has a type that should not be printed directly. 29432cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // We extract the name from the typedef because we don't want to show 29442cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // the underlying type in the diagnostic. 29452cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose StringRef Name = cast<TypedefType>(ExprTy)->getDecl()->getName(); 29462cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 29472cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_argument_needs_cast) 29482cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << Name << IntendedTy 29492cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << E->getSourceRange(), 29502cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose E->getLocStart(), /*IsStringLocation=*/false, 29512cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose SpecRange, Hints); 29522cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } else { 29532cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // In this case, the expression could be printed using a different 29542cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // specifier, but we've decided that the specifier is probably correct 29552cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // and we should cast instead. Just use the normal warning message. 29562cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose EmitFormatDiagnostic( 29572cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 29582cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << AT.getRepresentativeTypeName(S.Context) << ExprTy 29592cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << E->getSourceRange(), 29602cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose E->getLocStart(), /*IsStringLocation*/false, 29612cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose SpecRange, Hints); 29622cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 2963ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2964614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } else { 2965614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose const CharSourceRange &CSR = getSpecifierRange(StartSpecifier, 2966614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose SpecifierLen); 2967614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Since the warning for passing non-POD types to variadic functions 2968614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // was deferred until now, we emit a warning for non-POD 2969614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // arguments here. 2970448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (S.isValidVarArgType(ExprTy) == Sema::VAK_Invalid) { 2971614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose unsigned DiagKind; 2972448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (ExprTy->isObjCObjectType()) 2973614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose DiagKind = diag::err_cannot_pass_objc_interface_to_vararg_format; 2974614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose else 2975614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose DiagKind = diag::warn_non_pod_vararg_with_format_string; 297696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2977614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose EmitFormatDiagnostic( 2978614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose S.PDiag(DiagKind) 297980ad52f327b532bded5c5b0ee38779d841c6cd35Richard Smith << S.getLangOpts().CPlusPlus11 2980448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose << ExprTy 2981614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CallType 2982614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << AT.getRepresentativeTypeName(S.Context) 2983614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CSR 2984614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << E->getSourceRange(), 2985614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E->getLocStart(), /*IsStringLocation*/false, CSR); 298696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2987614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose checkForCStrMembers(AT, E, CSR); 2988614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } else 298955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 299055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 2991448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose << AT.getRepresentativeTypeName(S.Context) << ExprTy 2992614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CSR 2993831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << E->getSourceRange(), 2994614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E->getLocStart(), /*IsStringLocation*/false, CSR); 299596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 299696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2997e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return true; 2998e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2999e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 3000826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===// 3001826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3002826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 3003826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler { 3004826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 3005826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 3006826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 300750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, const char *beg, bool hasVAListArg, 30081c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 3009ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 3010ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType) 3011826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 301250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose numDataArgs, beg, hasVAListArg, 30131c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Args, formatIdx, inFunctionCall, CallType) 3014ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose {} 3015826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3016826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 3017826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 3018826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 3019c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 3020c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidScanfConversionSpecifier( 3021c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 3022c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 3023c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen); 3024b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 3025b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek void HandleIncompleteScanList(const char *start, const char *end); 3026826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 3027826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 3028826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3029b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start, 3030b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek const char *end) { 303155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete), 303255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(end), /*IsStringLocation*/true, 303355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(start, end - start)); 3034b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek} 3035b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 3036c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 3037c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 3038c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 3039c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen) { 3040c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 30416ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_scanf::ScanfConversionSpecifier &CS = 3042c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 3043c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 3044c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 3045c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 3046c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 3047c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 3048c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 3049c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 3050826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier( 3051826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 3052826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 3053826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 3054826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3055826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_scanf; 3056826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_format_string; 3057826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 30586ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 3059826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3060baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Handle case where '%' and '*' don't consume an argument. These shouldn't 3061baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // be used to decide if we are using positional arguments consistently. 3062baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 3063baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 3064baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 3065baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 3066baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 3067baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 306855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 306955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 3070baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 3071baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 3072826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 3073826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3074826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Check if the field with is non-zero. 3075826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const OptionalAmount &Amt = FS.getFieldWidth(); 3076826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getHowSpecified() == OptionalAmount::Constant) { 3077826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getConstantAmount() == 0) { 3078826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 3079826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Amt.getConstantLength()); 308055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width), 308155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 308255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, R, 308355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval(R)); 30847f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 30857f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 3086826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3087826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!FS.consumesDataArgument()) { 3088826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Technically specifying a precision or field width here 3089826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // makes no sense. Worth issuing a warning at some point. 3090826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 3091826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 3092826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3093826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Consume the argument. 3094826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned argIndex = FS.getArgIndex(); 3095826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (argIndex < NumDataArgs) { 3096826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The check to see if the argIndex is valid will come later. 3097826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // We set the bit here because we may exit early from this 3098826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // function if we encounter some other error. 3099826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.set(argIndex); 3100826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 3101826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 31021e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek // Check the length modifier is valid with the given conversion specifier. 3103bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo())) 31048be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 31058be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_nonsensical_length); 3106bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthModifier()) 31078be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen); 3108bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthConversionCombination()) 31098be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 31108be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_non_standard_conversion_spec); 311176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 3112bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 3113bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 3114bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 3115826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The remaining checks depend on the data arguments. 3116826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (HasVAListArg) 3117826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 3118826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3119666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 3120826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return false; 3121826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 31226fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Check that the argument type matches the format specifier. 31236fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg const Expr *Ex = getDataArg(argIndex); 312448716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Ex) 312548716663e421472cbd590af160a372bc490205e8Jordan Rose return true; 312648716663e421472cbd590af160a372bc490205e8Jordan Rose 312758e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg const analyze_format_string::ArgType &AT = FS.getArgType(S.Context); 312858e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg if (AT.isValid() && !AT.matchesType(S.Context, Ex->getType())) { 31296fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg ScanfSpecifier fixedFS = FS; 31304e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie bool success = fixedFS.fixType(Ex->getType(), S.getLangOpts(), 3131be6126a2a784e1446460b8d15c2b26f880c871fcHans Wennborg S.Context); 31326fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 31336fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg if (success) { 31346fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Get the fix string from the fixed format specifier. 3135f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> buf; 31366fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg llvm::raw_svector_ostream os(buf); 31376fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg fixedFS.toString(os); 31386fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 31396fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg EmitFormatDiagnostic( 31406fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 314158e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg << AT.getRepresentativeTypeName(S.Context) << Ex->getType() 31426fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg << Ex->getSourceRange(), 3143abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay Ex->getLocStart(), 3144abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay /*IsStringLocation*/false, 31456fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 31466fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg FixItHint::CreateReplacement( 31476fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 31486fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg os.str())); 31496fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } else { 3150220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas EmitFormatDiagnostic( 3151220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 315258e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg << AT.getRepresentativeTypeName(S.Context) << Ex->getType() 3153220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << Ex->getSourceRange(), 3154abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay Ex->getLocStart(), 3155abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay /*IsStringLocation*/false, 3156220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas getSpecifierRange(startSpecifier, specifierLen)); 31576fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 31586fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 31596fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 3160826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 316107d161f38e708a91486bf1c031d525faebbb249dTed Kremenek} 3162e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 3163826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr, 31640e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const Expr *OrigFormatExpr, 31651c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 316629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas bool HasVAListArg, unsigned format_idx, 316734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg, FormatStringType Type, 3168ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose bool inFunctionCall, VariadicCallType CallType) { 3169826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3170e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: is the format string a wide literal? 3171df9ef1bc8c3780307ab2ed81bf5e31c23310b936Richard Smith if (!FExpr->isAscii() && !FExpr->isUTF8()) { 317255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 317329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas *this, inFunctionCall, Args[format_idx], 317455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(), 317555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 3176e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 3177e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 3178826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3179e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // Str - The format string. NOTE: this is NOT null-terminated! 31805f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef StrRef = FExpr->getString(); 31812f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer const char *Str = StrRef.data(); 31822f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer unsigned StrLen = StrRef.size(); 31831c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko const unsigned numDataArgs = Args.size() - firstDataArg; 3184826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3185e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: empty format string? 31864cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek if (StrLen == 0 && numDataArgs > 0) { 318755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 318829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas *this, inFunctionCall, Args[format_idx], 318955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_empty_format_string), FExpr->getLocStart(), 319055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 3191e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 3192e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 3193826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 319434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas if (Type == FST_Printf || Type == FST_NSString) { 3195826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 319650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose numDataArgs, (Type == FST_NSString), 31971c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Str, HasVAListArg, Args, format_idx, 3198ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall, CallType); 3199826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3200d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen, 3201275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose getLangOpts(), 3202275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose Context.getTargetInfo())) 3203826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 320434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } else if (Type == FST_Scanf) { 320550687314f87b67073c202fe46d84d12fb55e25cfJordan Rose CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, numDataArgs, 32061c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Str, HasVAListArg, Args, format_idx, 3207ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall, CallType); 3208826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3209d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen, 3210275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose getLangOpts(), 3211275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose Context.getTargetInfo())) 3212826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 321334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } // TODO: handle other formats 3214ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek} 3215ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek 32167ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth//===--- CHECK: Standard memory functions ---------------------------------===// 32177ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 32182a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// \brief Determine whether the given type is a dynamic class type (e.g., 32192a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// whether it has a vtable). 32202a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregorstatic bool isDynamicClassType(QualType T) { 32212a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Record = T->getAsCXXRecordDecl()) 32222a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Definition = Record->getDefinition()) 32232a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (Definition->isDynamicClass()) 32242a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return true; 32252a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 32262a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return false; 32272a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor} 32282a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 3229a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument expression, 3230000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth/// otherwise returns NULL. 3231000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic const Expr *getSizeOfExprArg(const Expr* E) { 3232e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber if (const UnaryExprOrTypeTraitExpr *SizeOf = 3233000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 3234000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType()) 3235000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getArgumentExpr()->IgnoreParenImpCasts(); 3236e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 3237000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return 0; 3238000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth} 3239000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3240a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument type. 3241000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic QualType getSizeOfArgType(const Expr* E) { 3242000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryExprOrTypeTraitExpr *SizeOf = 3243000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 3244000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf) 3245000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getTypeOfArgument(); 3246000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3247000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return QualType(); 3248e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber} 3249e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 32507ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \brief Check for dangerous or invalid arguments to memset(). 32517ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 3252929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth/// This issues warnings on known problematic, dangerous or unspecified 3253cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp' 3254cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// function calls. 32557ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 32567ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \param Call The call expression to diagnose. 3257cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gayvoid Sema::CheckMemaccessArguments(const CallExpr *Call, 32580a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned BId, 3259cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay IdentifierInfo *FnName) { 32600a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks assert(BId != 0); 32610a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 32621d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek // It is possible to have a non-standard definition of memset. Validate 3263707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor // we have enough arguments, and if not, abort further checking. 32640a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned ExpectedNumArgs = (BId == Builtin::BIstrndup ? 2 : 3); 3265cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber if (Call->getNumArgs() < ExpectedNumArgs) 32661d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek return; 32671d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek 32680a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LastArg = (BId == Builtin::BImemset || 32690a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId == Builtin::BIstrndup ? 1 : 2); 32700a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LenArg = (BId == Builtin::BIstrndup ? 1 : 2); 3271cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts(); 3272000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3273000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We have special checking when the length is a sizeof expression. 3274000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth QualType SizeOfArgTy = getSizeOfArgType(LenExpr); 3275000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth const Expr *SizeOfArg = getSizeOfExprArg(LenExpr); 3276000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID SizeOfArgID; 3277000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 327806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) { 327906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts(); 3280e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange(); 328106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 328206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType DestTy = Dest->getType(); 328306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) { 328406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType PointeeTy = DestPtrTy->getPointeeType(); 3285f85e193739c953358c865005855253af4f68a497John McCall 3286000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Never warn about void type pointers. This can be used to suppress 3287000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // false positives. 3288000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isVoidType()) 328906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 329006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 3291000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by 3292000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // actually comparing the expressions for equality. Because computing the 3293000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // expression IDs can be expensive, we only do this if the diagnostic is 3294000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // enabled. 3295000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArg && 3296000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess, 3297000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->getExprLoc())) { 3298000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We only compute IDs for expressions if the warning is enabled, and 3299000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // cache the sizeof arg's ID. 3300000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgID == llvm::FoldingSetNodeID()) 3301000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->Profile(SizeOfArgID, Context, true); 3302000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID DestID; 3303000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Dest->Profile(DestID, Context, true); 3304000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (DestID == SizeOfArgID) { 3305cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // TODO: For strncpy() and friends, this could suggest sizeof(dst) 3306cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // over sizeof(src) as well. 3307000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth unsigned ActionIdx = 0; // Default is to suggest dereferencing. 33086fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks StringRef ReadableName = FnName->getName(); 33096fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 3310000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest)) 331190c78328e70cb376754edf87708505a84c044271Anna Zaks if (UnaryOp->getOpcode() == UO_AddrOf) 3312000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 1; // If its an address-of operator, just remove it. 33137adf4179f827b14b025135829dadeaa2442e1d42Fariborz Jahanian if (!PointeeTy->isIncompleteType() && 33147adf4179f827b14b025135829dadeaa2442e1d42Fariborz Jahanian (Context.getTypeSize(PointeeTy) == Context.getCharWidth())) 3315000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 2; // If the pointee's size is sizeof(char), 3316000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // suggest an explicit length. 33176fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 33186fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks // If the function is defined as a builtin macro, do not show macro 33196fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks // expansion. 33206fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceLocation SL = SizeOfArg->getExprLoc(); 33216fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceRange DSR = Dest->getSourceRange(); 33226fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceRange SSR = SizeOfArg->getSourceRange(); 33236fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceManager &SM = PP.getSourceManager(); 33246fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 33256fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks if (SM.isMacroArgExpansion(SL)) { 33266fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks ReadableName = Lexer::getImmediateMacroName(SL, SM, LangOpts); 33276fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SL = SM.getSpellingLoc(SL); 33286fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks DSR = SourceRange(SM.getSpellingLoc(DSR.getBegin()), 33296fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SM.getSpellingLoc(DSR.getEnd())); 33306fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SSR = SourceRange(SM.getSpellingLoc(SSR.getBegin()), 33316fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SM.getSpellingLoc(SSR.getEnd())); 33326fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks } 33336fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 333490c78328e70cb376754edf87708505a84c044271Anna Zaks DiagRuntimeBehavior(SL, SizeOfArg, 3335000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_expr_memaccess) 33366fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks << ReadableName 333790c78328e70cb376754edf87708505a84c044271Anna Zaks << PointeeTy 333890c78328e70cb376754edf87708505a84c044271Anna Zaks << DestTy 33396fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks << DSR 334090c78328e70cb376754edf87708505a84c044271Anna Zaks << SSR); 334190c78328e70cb376754edf87708505a84c044271Anna Zaks DiagRuntimeBehavior(SL, SizeOfArg, 334290c78328e70cb376754edf87708505a84c044271Anna Zaks PDiag(diag::warn_sizeof_pointer_expr_memaccess_note) 334390c78328e70cb376754edf87708505a84c044271Anna Zaks << ActionIdx 334490c78328e70cb376754edf87708505a84c044271Anna Zaks << SSR); 334590c78328e70cb376754edf87708505a84c044271Anna Zaks 3346000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 3347000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3348000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3349000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3350000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Also check for cases where the sizeof argument is the exact same 3351000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // type as the memory argument, and where it points to a user-defined 3352000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // record type. 3353000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgTy != QualType()) { 3354000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isRecordType() && 3355000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Context.typesAreCompatible(SizeOfArgTy, DestTy)) { 3356000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest, 3357000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_type_memaccess) 3358000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << FnName << SizeOfArgTy << ArgIdx 3359000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << PointeeTy << Dest->getSourceRange() 3360000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << LenExpr->getSourceRange()); 3361000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 3362000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3363e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber } 3364e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 336506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor // Always complain about dynamic classes. 33660a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (isDynamicClassType(PointeeTy)) { 33670a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 33680a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned OperationType = 0; 33690a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // "overwritten" if we're warning about the destination for any call 33700a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // but memcmp; otherwise a verb appropriate to the call. 33710a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (ArgIdx != 0 || BId == Builtin::BImemcmp) { 33720a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (BId == Builtin::BImemcpy) 33730a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 1; 33740a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if(BId == Builtin::BImemmove) 33750a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 2; 33760a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if (BId == Builtin::BImemcmp) 33770a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 3; 33780a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } 33790a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 33805c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 33815c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 33825c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_dyn_class_memaccess) 33830a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx) 3384d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks << FnName << PointeeTy 33850a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << OperationType 33865c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 33870a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } else if (PointeeTy.hasNonTrivialObjCLifetime() && 33880a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId != Builtin::BImemset) 33895c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 33905c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 33915c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_arc_object_memaccess) 33925c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << ArgIdx << FnName << PointeeTy 33935c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 3394f85e193739c953358c865005855253af4f68a497John McCall else 339506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 3396f85e193739c953358c865005855253af4f68a497John McCall 3397f85e193739c953358c865005855253af4f68a497John McCall DiagRuntimeBehavior( 3398f85e193739c953358c865005855253af4f68a497John McCall Dest->getExprLoc(), Dest, 3399929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth PDiag(diag::note_bad_memaccess_silence) 340006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)")); 340106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor break; 340206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 34037ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth } 34047ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth} 34057ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 3406bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// A little helper routine: ignore addition and subtraction of integer literals. 3407bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// This intentionally does not ignore all integer constant expressions because 3408bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// we don't want to remove sizeof(). 3409bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekstatic const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) { 3410bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = Ex->IgnoreParenCasts(); 3411bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3412bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek for (;;) { 3413bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex); 3414bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!BO || !BO->isAdditiveOp()) 3415bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 3416bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3417bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *RHS = BO->getRHS()->IgnoreParenCasts(); 3418bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *LHS = BO->getLHS()->IgnoreParenCasts(); 3419bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3420bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (isa<IntegerLiteral>(RHS)) 3421bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = LHS; 3422bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else if (isa<IntegerLiteral>(LHS)) 3423bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = RHS; 3424bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else 3425bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 3426bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3427bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3428bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return Ex; 3429bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 3430bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 34310f38acee92014cb15af980808f87144e5564031dAnna Zaksstatic bool isConstantSizeArrayWithMoreThanOneElement(QualType Ty, 34320f38acee92014cb15af980808f87144e5564031dAnna Zaks ASTContext &Context) { 34330f38acee92014cb15af980808f87144e5564031dAnna Zaks // Only handle constant-sized or VLAs, but not flexible members. 34340f38acee92014cb15af980808f87144e5564031dAnna Zaks if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(Ty)) { 34350f38acee92014cb15af980808f87144e5564031dAnna Zaks // Only issue the FIXIT for arrays of size > 1. 34360f38acee92014cb15af980808f87144e5564031dAnna Zaks if (CAT->getSize().getSExtValue() <= 1) 34370f38acee92014cb15af980808f87144e5564031dAnna Zaks return false; 34380f38acee92014cb15af980808f87144e5564031dAnna Zaks } else if (!Ty->isVariableArrayType()) { 34390f38acee92014cb15af980808f87144e5564031dAnna Zaks return false; 34400f38acee92014cb15af980808f87144e5564031dAnna Zaks } 34410f38acee92014cb15af980808f87144e5564031dAnna Zaks return true; 34420f38acee92014cb15af980808f87144e5564031dAnna Zaks} 34430f38acee92014cb15af980808f87144e5564031dAnna Zaks 3444bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// Warn if the user has made the 'size' argument to strlcpy or strlcat 3445bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// be the size of the source, instead of the destination. 3446bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekvoid Sema::CheckStrlcpycatArguments(const CallExpr *Call, 3447bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek IdentifierInfo *FnName) { 3448bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3449bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Don't crash if the user has the wrong number of arguments 3450bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (Call->getNumArgs() != 3) 3451bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3452bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3453bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context); 3454bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context); 3455bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *CompareWithSrc = NULL; 3456bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3457bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, sizeof(x))' 3458bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const Expr *Ex = getSizeOfExprArg(SizeArg)) 3459bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = Ex; 3460bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else { 3461bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, strlen(x))' 3462bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) { 3463180f47959a066795cc0f409433023af448bb0328Richard Smith if (SizeCall->isBuiltinCall() == Builtin::BIstrlen 3464bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek && SizeCall->getNumArgs() == 1) 3465bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context); 3466bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3467bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3468bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3469bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrc) 3470bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3471bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3472bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Determine if the argument to sizeof/strlen is equal to the source 3473bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // argument. In principle there's all kinds of things you could do 3474bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // here, for instance creating an == expression and evaluating it with 3475bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // EvaluateAsBooleanCondition, but this uses a more direct technique: 3476bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg); 3477bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!SrcArgDRE) 3478bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3479bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3480bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc); 3481bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrcDRE || 3482bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl()) 3483bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3484bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3485bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *OriginalSizeArg = Call->getArg(2); 3486bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size) 3487bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek << OriginalSizeArg->getSourceRange() << FnName; 3488bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3489bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Output a FIXIT hint if the destination is an array (rather than a 3490bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointer to an array). This could be enhanced to handle some 3491bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointers if we know the actual size, like if DstArg is 'array+2' 3492bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // we could say 'sizeof(array)-2'. 3493bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts(); 34940f38acee92014cb15af980808f87144e5564031dAnna Zaks if (!isConstantSizeArrayWithMoreThanOneElement(DstArg->getType(), Context)) 34958f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 34968f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 3497f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> sizeString; 34988f7462237ff542a4556775f98709ed300aa1731aTed Kremenek llvm::raw_svector_ostream OS(sizeString); 34998f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << "sizeof("; 3500d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 35018f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << ")"; 35028f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 35038f7462237ff542a4556775f98709ed300aa1731aTed Kremenek Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size) 35048f7462237ff542a4556775f98709ed300aa1731aTed Kremenek << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(), 35058f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS.str()); 3506bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 3507bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3508c36bedc90c687caa71748480c60707ea4608b092Anna Zaks/// Check if two expressions refer to the same declaration. 3509c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic bool referToTheSameDecl(const Expr *E1, const Expr *E2) { 3510c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const DeclRefExpr *D1 = dyn_cast_or_null<DeclRefExpr>(E1)) 3511c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const DeclRefExpr *D2 = dyn_cast_or_null<DeclRefExpr>(E2)) 3512c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return D1->getDecl() == D2->getDecl(); 3513c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return false; 3514c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3515c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3516c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic const Expr *getStrlenExprArg(const Expr *E) { 3517c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const CallExpr *CE = dyn_cast<CallExpr>(E)) { 3518c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const FunctionDecl *FD = CE->getDirectCallee(); 3519c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (!FD || FD->getMemoryFunctionKind() != Builtin::BIstrlen) 3520c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return 0; 3521c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return CE->getArg(0)->IgnoreParenCasts(); 3522c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3523c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return 0; 3524c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3525c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3526c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// Warn on anti-patterns as the 'size' argument to strncat. 3527c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// The correct size argument should look like following: 3528c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// strncat(dst, src, sizeof(dst) - strlen(dest) - 1); 3529c36bedc90c687caa71748480c60707ea4608b092Anna Zaksvoid Sema::CheckStrncatArguments(const CallExpr *CE, 3530c36bedc90c687caa71748480c60707ea4608b092Anna Zaks IdentifierInfo *FnName) { 3531c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Don't crash if the user has the wrong number of arguments. 3532c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (CE->getNumArgs() < 3) 3533c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 3534c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *DstArg = CE->getArg(0)->IgnoreParenCasts(); 3535c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *SrcArg = CE->getArg(1)->IgnoreParenCasts(); 3536c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *LenArg = CE->getArg(2)->IgnoreParenCasts(); 3537c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3538c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Identify common expressions, which are wrongly used as the size argument 3539c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // to strncat and may lead to buffer overflows. 3540c36bedc90c687caa71748480c60707ea4608b092Anna Zaks unsigned PatternType = 0; 3541c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const Expr *SizeOfArg = getSizeOfExprArg(LenArg)) { 3542c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(dst) 3543c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (referToTheSameDecl(SizeOfArg, DstArg)) 3544c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 1; 3545c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(src) 3546c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (referToTheSameDecl(SizeOfArg, SrcArg)) 3547c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 2; 3548c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } else if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(LenArg)) { 3549c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (BE->getOpcode() == BO_Sub) { 3550c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *L = BE->getLHS()->IgnoreParenCasts(); 3551c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *R = BE->getRHS()->IgnoreParenCasts(); 3552c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(dst) - strlen(dst) 3553c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (referToTheSameDecl(DstArg, getSizeOfExprArg(L)) && 3554c36bedc90c687caa71748480c60707ea4608b092Anna Zaks referToTheSameDecl(DstArg, getStrlenExprArg(R))) 3555c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 1; 3556c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(src) - (anything) 3557c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (referToTheSameDecl(SrcArg, getSizeOfExprArg(L))) 3558c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 2; 3559c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3560c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3561c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3562c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (PatternType == 0) 3563c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 3564c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3565afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks // Generate the diagnostic. 3566afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceLocation SL = LenArg->getLocStart(); 3567afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceRange SR = LenArg->getSourceRange(); 3568afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceManager &SM = PP.getSourceManager(); 3569afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks 3570afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks // If the function is defined as a builtin macro, do not show macro expansion. 3571afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks if (SM.isMacroArgExpansion(SL)) { 3572afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SL = SM.getSpellingLoc(SL); 3573afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SR = SourceRange(SM.getSpellingLoc(SR.getBegin()), 3574afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SM.getSpellingLoc(SR.getEnd())); 3575afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks } 3576afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks 35770f38acee92014cb15af980808f87144e5564031dAnna Zaks // Check if the destination is an array (rather than a pointer to an array). 35780f38acee92014cb15af980808f87144e5564031dAnna Zaks QualType DstTy = DstArg->getType(); 35790f38acee92014cb15af980808f87144e5564031dAnna Zaks bool isKnownSizeArray = isConstantSizeArrayWithMoreThanOneElement(DstTy, 35800f38acee92014cb15af980808f87144e5564031dAnna Zaks Context); 35810f38acee92014cb15af980808f87144e5564031dAnna Zaks if (!isKnownSizeArray) { 35820f38acee92014cb15af980808f87144e5564031dAnna Zaks if (PatternType == 1) 35830f38acee92014cb15af980808f87144e5564031dAnna Zaks Diag(SL, diag::warn_strncat_wrong_size) << SR; 35840f38acee92014cb15af980808f87144e5564031dAnna Zaks else 35850f38acee92014cb15af980808f87144e5564031dAnna Zaks Diag(SL, diag::warn_strncat_src_size) << SR; 35860f38acee92014cb15af980808f87144e5564031dAnna Zaks return; 35870f38acee92014cb15af980808f87144e5564031dAnna Zaks } 35880f38acee92014cb15af980808f87144e5564031dAnna Zaks 3589c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (PatternType == 1) 3590afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::warn_strncat_large_size) << SR; 3591c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else 3592afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::warn_strncat_src_size) << SR; 3593c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3594f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> sizeString; 3595c36bedc90c687caa71748480c60707ea4608b092Anna Zaks llvm::raw_svector_ostream OS(sizeString); 3596c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << "sizeof("; 3597d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 3598c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << ") - "; 3599c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << "strlen("; 3600d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 3601c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << ") - 1"; 3602c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3603afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::note_strncat_wrong_size) 3604afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks << FixItHint::CreateReplacement(SR, OS.str()); 3605c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3606c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 360706de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===// 360806de276fff91264437fa75111ed76de43097e089Ted Kremenek 3609e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3610e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl); 3611e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars, 3612e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl); 361306de276fff91264437fa75111ed76de43097e089Ted Kremenek 361406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address 361506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable. 361606de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid 361706de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 361806de276fff91264437fa75111ed76de43097e089Ted Kremenek SourceLocation ReturnLoc) { 36191eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 362026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Expr *stackE = 0; 36215f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<DeclRefExpr *, 8> refVars; 36224e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 362326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Perform checking for returned stack addresses, local blocks, 362426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // label addresses or references to temporaries. 3625f85e193739c953358c865005855253af4f68a497John McCall if (lhsType->isPointerType() || 36264e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie (!getLangOpts().ObjCAutoRefCount && lhsType->isBlockPointerType())) { 3627e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/0); 3628ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (lhsType->isReferenceType()) { 3629e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis stackE = EvalVal(RetValExp, refVars, /*ParentDecl=*/0); 363026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 363126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 363226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (stackE == 0) 363326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return; // Nothing suspicious was found. 363426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 363526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceLocation diagLoc; 363626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange diagRange; 363726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (refVars.empty()) { 363826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = stackE->getLocStart(); 363926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = stackE->getSourceRange(); 364026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { 364126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // We followed through a reference variable. 'stackE' contains the 364226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // problematic expression but we will warn at the return statement pointing 364326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // at the reference variable. We will later display the "trail" of 364426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // reference variables using notes. 364526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = refVars[0]->getLocStart(); 364626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = refVars[0]->getSourceRange(); 364726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 364826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 364926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var. 365026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref 365126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_stack_addr) 365226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << DR->getDecl()->getDeclName() << diagRange; 365326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<BlockExpr>(stackE)) { // local block. 365426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::err_ret_local_block) << diagRange; 365526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 365626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 365726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { // local temporary. 365826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref 365926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_local_temp_addr) 366026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << diagRange; 366126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 366226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 366326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Display the "trail" of reference variables that we followed until we 366426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // found the problematic expression using notes. 366526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 366626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 366726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this var binds to another reference var, show the range of the next 366826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // var, otherwise the var binds to the problematic expression, in which case 366926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // show the range of the expression. 367026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange() 367126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : stackE->getSourceRange(); 367226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(VD->getLocation(), diag::note_ref_var_local_bind) 367326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << VD->getDeclName() << range; 367406de276fff91264437fa75111ed76de43097e089Ted Kremenek } 367506de276fff91264437fa75111ed76de43097e089Ted Kremenek} 367606de276fff91264437fa75111ed76de43097e089Ted Kremenek 367706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 367806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// check if the expression in a return statement evaluates to an address 367926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// to a location on the stack, a local block, an address of a label, or a 368026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// reference to local temporary. The recursion is used to traverse the 368106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// AST of the return expression, with recursion backtracking when we 368226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// encounter a subexpression that (1) clearly does not lead to one of the 368326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// above problematic expressions (2) is something we cannot determine leads to 368426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// a problematic expression based on such local checking. 368526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 368626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// Both EvalAddr and EvalVal follow through reference variables to evaluate 368726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// the expression that they point to. Such variables are added to the 368826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 'refVars' vector so that we know what the reference variable "trail" was. 368906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 3690e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// EvalAddr processes expressions that are pointers that are used as 3691e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// references (and not L-values). EvalVal handles all other values. 369226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// At the base case of the recursion is a check for the above problematic 369326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// expressions. 369406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 369506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// This implementation handles: 369606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 369706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer-to-pointer casts 369806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * implicit conversions from array references to pointers 369906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of fields 370006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * arbitrary interplay between "&" and "*" operators 370106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer arithmetic from an address of a stack variable 370206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of an array element where the array is on the stack 3703e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3704e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl) { 370526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (E->isTypeDependent()) 370626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 370726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 370806de276fff91264437fa75111ed76de43097e089Ted Kremenek // We should only be called for evaluating pointer expressions. 37090f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall assert((E->getType()->isAnyPointerType() || 3710dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff E->getType()->isBlockPointerType() || 3711a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek E->getType()->isObjCQualifiedIdType()) && 3712fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner "EvalAddr only works on pointers"); 37131eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3714f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 3715f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 371606de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 371706de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 371806de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 371906de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 372026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::DeclRefExprClass: { 372126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis DeclRefExpr *DR = cast<DeclRefExpr>(E); 372226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 372326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 372426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this is a reference variable, follow through to the expression that 372526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 372626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage() && 372726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis V->getType()->isReferenceType() && V->hasInit()) { 372826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 372926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 3730e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(V->getInit(), refVars, ParentDecl); 373126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 373226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 373326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 373426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 373506de276fff91264437fa75111ed76de43097e089Ted Kremenek 3736fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::UnaryOperatorClass: { 3737fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // The only unary operator that make sense to handle here 3738fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // is AddrOf. All others don't make sense as pointers. 3739fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner UnaryOperator *U = cast<UnaryOperator>(E); 37401eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 37412de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_AddrOf) 3742e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(U->getSubExpr(), refVars, ParentDecl); 3743fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 3744fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 3745fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 37461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3747fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::BinaryOperatorClass: { 3748fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle pointer arithmetic. All other binary operators are not valid 3749fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // in this context. 3750fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner BinaryOperator *B = cast<BinaryOperator>(E); 37512de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = B->getOpcode(); 37521eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 37532de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op != BO_Add && op != BO_Sub) 3754fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 37551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3756fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner Expr *Base = B->getLHS(); 37573907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 3758fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Determine which argument is the real pointer base. It could be 3759fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // the RHS argument instead of the LHS. 3760fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner if (!Base->getType()->isPointerType()) Base = B->getRHS(); 37611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3762fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner assert (Base->getType()->isPointerType()); 3763e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(Base, refVars, ParentDecl); 3764fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 376561f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff 3766fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // For conditional operators we need to see if either the LHS or RHS are 3767fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // valid DeclRefExpr*s. If one of them is valid, we return it. 3768fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ConditionalOperatorClass: { 3769fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner ConditionalOperator *C = cast<ConditionalOperator>(E); 37701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3771fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle the GNU extension for missing LHS. 37729ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (Expr *lhsExpr = C->getLHS()) { 37739ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 37749ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (!lhsExpr->getType()->isVoidType()) 3775e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (Expr* LHS = EvalAddr(lhsExpr, refVars, ParentDecl)) 37769ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return LHS; 37779ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor } 37789ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor 37799ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 37809ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (C->getRHS()->getType()->isVoidType()) 37819ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return NULL; 378206de276fff91264437fa75111ed76de43097e089Ted Kremenek 3783e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(C->getRHS(), refVars, ParentDecl); 3784fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 378526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 378626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::BlockExprClass: 3787469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures()) 378826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // local block. 378926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 379026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 379126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::AddrLabelExprClass: 379226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // address of label. 37931eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 379480ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 3795e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars, 3796e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis ParentDecl); 379780ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 379854b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // For casts, we need to handle conversions from arrays to 379954b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // pointer values, and pointer-to-pointer conversions. 380049badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::ImplicitCastExprClass: 38016eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor case Stmt::CStyleCastExprClass: 3802f85e193739c953358c865005855253af4f68a497John McCall case Stmt::CXXFunctionalCastExprClass: 38038b9414e868853fc052251455674bf7512261e14aEli Friedman case Stmt::ObjCBridgedCastExprClass: 38041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXStaticCastExprClass: 38051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXDynamicCastExprClass: 380649badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXConstCastExprClass: 380749badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXReinterpretCastExprClass: { 38088b9414e868853fc052251455674bf7512261e14aEli Friedman Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 38098b9414e868853fc052251455674bf7512261e14aEli Friedman switch (cast<CastExpr>(E)->getCastKind()) { 38108b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BitCast: 38118b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_LValueToRValue: 38128b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_NoOp: 38138b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BaseToDerived: 38148b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_DerivedToBase: 38158b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_UncheckedDerivedToBase: 38168b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_Dynamic: 38178b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_CPointerToObjCPointerCast: 38188b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BlockPointerToObjCPointerCast: 38198b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_AnyPointerToBlockPointerCast: 3820e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(SubExpr, refVars, ParentDecl); 38218b9414e868853fc052251455674bf7512261e14aEli Friedman 38228b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_ArrayToPointerDecay: 3823e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(SubExpr, refVars, ParentDecl); 38248b9414e868853fc052251455674bf7512261e14aEli Friedman 38258b9414e868853fc052251455674bf7512261e14aEli Friedman default: 38268b9414e868853fc052251455674bf7512261e14aEli Friedman return 0; 38278b9414e868853fc052251455674bf7512261e14aEli Friedman } 3828fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 38291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 383003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 383103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalAddr( 383203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 3833e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis refVars, ParentDecl)) 383403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 383503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 383603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 383703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 3838fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Everything else: we simply don't reason about them. 3839fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner default: 3840fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 384106de276fff91264437fa75111ed76de43097e089Ted Kremenek } 384206de276fff91264437fa75111ed76de43097e089Ted Kremenek} 38431eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 384406de276fff91264437fa75111ed76de43097e089Ted Kremenek 384506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalVal - This function is complements EvalAddr in the mutual recursion. 384606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// See the comments for EvalAddr for more details. 3847e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3848e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl) { 384968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo { 3850e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // We should only be called for evaluating non-pointer expressions, or 3851e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // expressions with a pointer type that are not used as references but instead 3852e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // are l-values (e.g., DeclRefExpr with a pointer type). 38531eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 385406de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 385506de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 385606de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 3857f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 3858f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 385906de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 386068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ImplicitCastExprClass: { 386168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 38625baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall if (IE->getValueKind() == VK_LValue) { 386368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = IE->getSubExpr(); 386468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 386568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 386668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek return NULL; 386768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 386868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek 386980ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 3870e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,ParentDecl); 387180ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 3872a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor case Stmt::DeclRefExprClass: { 387326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // When we hit a DeclRefExpr we are looking at code that refers to a 387426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // variable's name. If it's not a reference variable we check if it has 387526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // local storage within the function, and if so, return the expression. 387606de276fff91264437fa75111ed76de43097e089Ted Kremenek DeclRefExpr *DR = cast<DeclRefExpr>(E); 38771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3878e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) { 3879e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis // Check if it refers to itself, e.g. "int& i = i;". 3880e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (V == ParentDecl) 3881e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return DR; 3882e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis 388326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage()) { 388426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!V->getType()->isReferenceType()) 388526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return DR; 388626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 388726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Reference variable, follow through to the expression that 388826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 388926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasInit()) { 389026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 389126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 3892e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(V->getInit(), refVars, V); 389326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 389426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 3895e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis } 38961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 389706de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 389806de276fff91264437fa75111ed76de43097e089Ted Kremenek } 38991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 390006de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::UnaryOperatorClass: { 390106de276fff91264437fa75111ed76de43097e089Ted Kremenek // The only unary operator that make sense to handle here 390206de276fff91264437fa75111ed76de43097e089Ted Kremenek // is Deref. All others don't resolve to a "name." This includes 390306de276fff91264437fa75111ed76de43097e089Ted Kremenek // handling all sorts of rvalues passed to a unary operator. 390406de276fff91264437fa75111ed76de43097e089Ted Kremenek UnaryOperator *U = cast<UnaryOperator>(E); 39051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 39062de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_Deref) 3907e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(U->getSubExpr(), refVars, ParentDecl); 390806de276fff91264437fa75111ed76de43097e089Ted Kremenek 390906de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 391006de276fff91264437fa75111ed76de43097e089Ted Kremenek } 39111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 391206de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ArraySubscriptExprClass: { 391306de276fff91264437fa75111ed76de43097e089Ted Kremenek // Array subscripts are potential references to data on the stack. We 391406de276fff91264437fa75111ed76de43097e089Ted Kremenek // retrieve the DeclRefExpr* for the array variable if it indeed 391506de276fff91264437fa75111ed76de43097e089Ted Kremenek // has local storage. 3916e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars,ParentDecl); 391706de276fff91264437fa75111ed76de43097e089Ted Kremenek } 39181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 391906de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ConditionalOperatorClass: { 392006de276fff91264437fa75111ed76de43097e089Ted Kremenek // For conditional operators we need to see if either the LHS or RHS are 392126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // non-NULL Expr's. If one is non-NULL, we return it. 392206de276fff91264437fa75111ed76de43097e089Ted Kremenek ConditionalOperator *C = cast<ConditionalOperator>(E); 392306de276fff91264437fa75111ed76de43097e089Ted Kremenek 39243907323dd6665c0c4e383435cb145233f4533406Anders Carlsson // Handle the GNU extension for missing LHS. 39253907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (Expr *lhsExpr = C->getLHS()) 3926e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (Expr *LHS = EvalVal(lhsExpr, refVars, ParentDecl)) 39273907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return LHS; 39283907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 3929e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(C->getRHS(), refVars, ParentDecl); 393006de276fff91264437fa75111ed76de43097e089Ted Kremenek } 39311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 393206de276fff91264437fa75111ed76de43097e089Ted Kremenek // Accesses to members are potential references to data on the stack. 393383f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor case Stmt::MemberExprClass: { 393406de276fff91264437fa75111ed76de43097e089Ted Kremenek MemberExpr *M = cast<MemberExpr>(E); 39351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 393606de276fff91264437fa75111ed76de43097e089Ted Kremenek // Check for indirect access. We only want direct field accesses. 3937a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->isArrow()) 3938a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return NULL; 3939a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 3940a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // Check whether the member type is itself a reference, in which case 3941a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // we're not going to refer to the member, but to what the member refers to. 3942a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->getMemberDecl()->getType()->isReferenceType()) 394306de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 3944a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 3945e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(M->getBase(), refVars, ParentDecl); 394606de276fff91264437fa75111ed76de43097e089Ted Kremenek } 39471eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 394803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 394903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalVal( 395003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 3951e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis refVars, ParentDecl)) 395203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 395303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 395403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 395503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 395606de276fff91264437fa75111ed76de43097e089Ted Kremenek default: 395726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Check that we don't return or take the address of a reference to a 395826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // temporary. This is only useful in C++. 395926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!E->isTypeDependent() && E->isRValue()) 396026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; 396126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 396226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Everything else: we simply don't reason about them. 396306de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 396406de276fff91264437fa75111ed76de43097e089Ted Kremenek } 396568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true); 396606de276fff91264437fa75111ed76de43097e089Ted Kremenek} 3967588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3968588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 3969588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3970588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==. 3971588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely 3972588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended. 3973dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieuvoid Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) { 3974dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts(); 3975dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* RightExprSansParen = RHS->IgnoreParenImpCasts(); 3976588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3977588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Special case: check for x == x (which is OK). 3978588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Do not emit warnings for such cases. 3979588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 3980588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 3981588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DRL->getDecl() == DRR->getDecl()) 3982980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 39831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 39841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 39851b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // Special case: check for comparisons against literals that can be exactly 39861b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // represented by APFloat. In such cases, do not emit a warning. This 39871b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // is a heuristic: often comparison against such literals are used to 39881b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // detect if a value in a variable has not changed. This clearly can 39891b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // lead to false negatives. 3990980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 3991980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FLL->isExact()) 3992980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 3993980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie } else 3994980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)) 3995980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FLR->isExact()) 3996980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 39971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3998588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Check for comparisons with builtin types. 3999980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 4000980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CL->isBuiltinCall()) 4001980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 40021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4003980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 4004980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CR->isBuiltinCall()) 4005980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 40061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4007588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Emit the diagnostic. 4008980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie Diag(Loc, diag::warn_floatingpoint_eq) 4009980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie << LHS->getSourceRange() << RHS->getSourceRange(); 4010588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek} 4011ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4012f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 4013f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 4014ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4015f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace { 4016ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4017f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued 4018f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression. 4019f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange { 4020f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// The number of bits active in the int. 4021f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned Width; 4022ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4023f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// True if the int is known not to have negative values. 4024f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool NonNegative; 402551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4026f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange(unsigned Width, bool NonNegative) 4027f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : Width(Width), NonNegative(NonNegative) 4028f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall {} 402951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 40301844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of the bool type. 4031f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall static IntRange forBoolType() { 4032f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(1, true); 4033f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 403451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 40351844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of the given integral type. 40361844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfType(ASTContext &C, QualType T) { 40371844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return forValueOfCanonicalType(C, 40381844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T->getCanonicalTypeInternal().getTypePtr()); 403951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 404051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 40411844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of a canonical integral type. 40421844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 4043f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(T->isCanonicalUnqualified()); 404451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4045f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 4046f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = VT->getElementType().getTypePtr(); 4047f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 4048f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = CT->getElementType().getTypePtr(); 4049323ed74658bc8375278eabf074b4777458376540John McCall 4050f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer // For enum types, use the known bit width of the enumerators. 4051323ed74658bc8375278eabf074b4777458376540John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) { 4052f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer EnumDecl *Enum = ET->getDecl(); 4053f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer if (!Enum->isCompleteDefinition()) 4054f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer return IntRange(C.getIntWidth(QualType(T, 0)), false); 4055091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 4056f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer unsigned NumPositive = Enum->getNumPositiveBits(); 4057f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer unsigned NumNegative = Enum->getNumNegativeBits(); 4058323ed74658bc8375278eabf074b4777458376540John McCall 4059f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer if (NumNegative == 0) 4060f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer return IntRange(NumPositive, true/*NonNegative*/); 4061f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer else 4062f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer return IntRange(std::max(NumPositive + 1, NumNegative), 4063f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer false/*NonNegative*/); 4064323ed74658bc8375278eabf074b4777458376540John McCall } 406551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4066f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const BuiltinType *BT = cast<BuiltinType>(T); 4067f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(BT->isInteger()); 406851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4069f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 407051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 407151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 40721844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the "target" range of a canonical integral type, i.e. 40731844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// the range of values expressible in the type. 40741844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// 40751844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// This matches forValueOfCanonicalType except that enums have the 40761844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// full range of their type, not the range of their enumerators. 40771844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 40781844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(T->isCanonicalUnqualified()); 40791844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 40801844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 40811844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = VT->getElementType().getTypePtr(); 40821844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 40831844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = CT->getElementType().getTypePtr(); 40841844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) 408569ff26bd1e7a2faffec0c3b9740cfb0c6bb354c5Douglas Gregor T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr(); 40861844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 40871844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall const BuiltinType *BT = cast<BuiltinType>(T); 40881844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(BT->isInteger()); 40891844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 40901844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 40911844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall } 40921844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 40931844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the supremum of two ranges: i.e. their conservative merge. 4094c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange join(IntRange L, IntRange R) { 4095f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(std::max(L.Width, R.Width), 409660fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative && R.NonNegative); 409760fad45739b764886f707bd204eae9ecce6db1f2John McCall } 409860fad45739b764886f707bd204eae9ecce6db1f2John McCall 40991844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the infinum of two ranges: i.e. their aggressive merge. 4100c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange meet(IntRange L, IntRange R) { 410160fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange(std::min(L.Width, R.Width), 410260fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative || R.NonNegative); 410351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 4104f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}; 410551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 41060692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, 41070692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek unsigned MaxWidth) { 4108f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isSigned() && value.isNegative()) 4109f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getMinSignedBits(), false); 411051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4111f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.getBitWidth() > MaxWidth) 41129f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad value = value.trunc(MaxWidth); 411351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4114f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // isNonNegative() just checks the sign bit without considering 4115f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // signedness. 4116f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getActiveBits(), true); 411751313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 411851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 41190692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 41200692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek unsigned MaxWidth) { 4121f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isInt()) 4122f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetValueRange(C, result.getInt(), MaxWidth); 412351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4124f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isVector()) { 41250acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 41260acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 41270acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 41280acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall R = IntRange::join(R, El); 41290acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall } 4130f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return R; 413151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 413251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4133f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isComplexInt()) { 4134f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 4135f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 4136f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(R, I); 4137f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 4138f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4139f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // This can happen with lossless casts to intptr_t of "based" lvalues. 4140f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume it might use arbitrary bits. 41410acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // FIXME: The only reason we need to pass the type in here is to get 41420acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // the sign right on this one case. It would be nice if APValue 41430acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // preserved this. 414465639284118d54ddf2e51a05d2ffccda567fe246Eli Friedman assert(result.isLValue() || result.isAddrLabelDiff()); 41455e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType()); 414651313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 414751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 414809bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedmanstatic QualType GetExprType(Expr *E) { 414909bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman QualType Ty = E->getType(); 415009bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman if (const AtomicType *AtomicRHS = Ty->getAs<AtomicType>()) 415109bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman Ty = AtomicRHS->getValueType(); 415209bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return Ty; 415309bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman} 415409bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman 4155f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the 4156f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take. 4157f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 4158f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated 41590692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 416051313c39c84407dd6a323be99a8c322bf8d052a9John McCall E = E->IgnoreParens(); 416151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4162f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Try a full evaluation first. 4163f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall Expr::EvalResult result; 416451f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, C)) 416509bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return GetValueRange(C, result.Val, GetExprType(E), MaxWidth); 416651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4167f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // I think we only want to look through implicit casts here; if the 4168f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // user has an explicit widening cast, we should treat the value as 4169f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // being of the new, wider type. 4170f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 4171b17ee5bff0d7986c14cdddb279e0131bd7f9678dEli Friedman if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue) 4172f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CE->getSubExpr(), MaxWidth); 417351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 417409bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman IntRange OutputTypeRange = IntRange::forValueOfType(C, GetExprType(CE)); 417551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 41762de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 417760fad45739b764886f707bd204eae9ecce6db1f2John McCall 4178f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume that non-integer casts can span the full range of the type. 417960fad45739b764886f707bd204eae9ecce6db1f2John McCall if (!isIntegerCast) 4180f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 418151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4182f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange SubRange 4183f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall = GetExprRange(C, CE->getSubExpr(), 4184f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall std::min(MaxWidth, OutputTypeRange.Width)); 418551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4186f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Bail out if the subexpr's range is as wide as the cast type. 4187f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SubRange.Width >= OutputTypeRange.Width) 4188f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 418951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4190f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, we take the smaller width, and we're non-negative if 4191f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // either the output type or the subexpr is. 4192f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(SubRange.Width, 4193f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall SubRange.NonNegative || OutputTypeRange.NonNegative); 4194f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 4195f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4196f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 4197f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // If we can fold the condition, just take that operand. 4198f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool CondResult; 4199f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 4200f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CondResult ? CO->getTrueExpr() 4201f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : CO->getFalseExpr(), 4202f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall MaxWidth); 4203f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4204f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, conservatively merge. 4205f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 4206f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 4207f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 420851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 420951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 421051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 421151313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (BO->getOpcode()) { 421251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4213f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Boolean-valued operations are single-bit and positive. 42142de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LAnd: 42152de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LOr: 42162de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LT: 42172de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GT: 42182de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LE: 42192de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GE: 42202de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_EQ: 42212de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_NE: 4222f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 422351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4224862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // The type of the assignments is the type of the LHS, so the RHS 4225862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // is not necessarily the same type. 42262de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_MulAssign: 42272de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_DivAssign: 42282de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_RemAssign: 42292de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AddAssign: 42302de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_SubAssign: 4231862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_XorAssign: 4232862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_OrAssign: 4233862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 423409bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 4235c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall 4236862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // Simple assignments just pass through the RHS, which will have 4237862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // been coerced to the LHS type. 4238862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_Assign: 4239862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 4240862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 4241862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall 424251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 42432de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemD: 42442de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemI: 424509bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 424651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 424760fad45739b764886f707bd204eae9ecce6db1f2John McCall // Bitwise-and uses the *infinum* of the two source ranges. 42482de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_And: 42492de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AndAssign: 425060fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 425160fad45739b764886f707bd204eae9ecce6db1f2John McCall GetExprRange(C, BO->getRHS(), MaxWidth)); 425260fad45739b764886f707bd204eae9ecce6db1f2John McCall 425351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Left shift gets black-listed based on a judgement call. 42542de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shl: 42553aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // ...except that we want to treat '1 << (blah)' as logically 42563aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // positive. It's an important idiom. 42573aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (IntegerLiteral *I 42583aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 42593aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (I->getValue() == 1) { 426009bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman IntRange R = IntRange::forValueOfType(C, GetExprType(E)); 42613aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall return IntRange(R.Width, /*NonNegative*/ true); 42623aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 42633aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 42643aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // fallthrough 42653aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall 42662de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShlAssign: 426709bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 426851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 426960fad45739b764886f707bd204eae9ecce6db1f2John McCall // Right shift by a constant can narrow its left argument. 42702de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shr: 42712de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShrAssign: { 427260fad45739b764886f707bd204eae9ecce6db1f2John McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 427360fad45739b764886f707bd204eae9ecce6db1f2John McCall 427460fad45739b764886f707bd204eae9ecce6db1f2John McCall // If the shift amount is a positive constant, drop the width by 427560fad45739b764886f707bd204eae9ecce6db1f2John McCall // that much. 427660fad45739b764886f707bd204eae9ecce6db1f2John McCall llvm::APSInt shift; 427760fad45739b764886f707bd204eae9ecce6db1f2John McCall if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 427860fad45739b764886f707bd204eae9ecce6db1f2John McCall shift.isNonNegative()) { 427960fad45739b764886f707bd204eae9ecce6db1f2John McCall unsigned zext = shift.getZExtValue(); 428060fad45739b764886f707bd204eae9ecce6db1f2John McCall if (zext >= L.Width) 428160fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width = (L.NonNegative ? 0 : 1); 428260fad45739b764886f707bd204eae9ecce6db1f2John McCall else 428360fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width -= zext; 428460fad45739b764886f707bd204eae9ecce6db1f2John McCall } 428560fad45739b764886f707bd204eae9ecce6db1f2John McCall 428660fad45739b764886f707bd204eae9ecce6db1f2John McCall return L; 428760fad45739b764886f707bd204eae9ecce6db1f2John McCall } 428860fad45739b764886f707bd204eae9ecce6db1f2John McCall 428960fad45739b764886f707bd204eae9ecce6db1f2John McCall // Comma acts as its right operand. 42902de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Comma: 4291f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 4292f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 429360fad45739b764886f707bd204eae9ecce6db1f2John McCall // Black-list pointer subtractions. 42942de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Sub: 429551313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BO->getLHS()->getType()->isPointerType()) 429609bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 429700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall break; 429800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 429900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The width of a division result is mostly determined by the size 430000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // of the LHS. 430100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Div: { 430200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 430309bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman unsigned opWidth = C.getIntWidth(GetExprType(E)); 430400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 430500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 430600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // If the divisor is constant, use that. 430700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall llvm::APSInt divisor; 430800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) { 430900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned log2 = divisor.logBase2(); // floor(log_2(divisor)) 431000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (log2 >= L.Width) 431100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = (L.NonNegative ? 0 : 1); 431200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall else 431300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = std::min(L.Width - log2, MaxWidth); 431400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return L; 431500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 431600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 431700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Otherwise, just use the LHS's width. 431800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 431900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return IntRange(L.Width, L.NonNegative && R.NonNegative); 432000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 432100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 432200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The result of a remainder can't be larger than the result of 432300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // either side. 432400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Rem: { 432500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 432609bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman unsigned opWidth = C.getIntWidth(GetExprType(E)); 432700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 432800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 432900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 433000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange meet = IntRange::meet(L, R); 433100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall meet.Width = std::min(meet.Width, MaxWidth); 433200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return meet; 433300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 43344e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 433500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default behavior is okay for these. 433600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Mul: 433700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Add: 433800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Xor: 433900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Or: 4340f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall break; 434151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 4342f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 434300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default case is to treat the operation as if it were closed 434400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // on the narrowest type that encompasses both operands. 4345f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 4346f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 4347f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 434851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 434951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 435051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 435151313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (UO->getOpcode()) { 435251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Boolean-valued operations are white-listed. 43532de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_LNot: 4354f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 435551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 435651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 43572de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_Deref: 43582de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_AddrOf: // should be impossible 435909bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 436051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 436151313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 4362f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, UO->getSubExpr(), MaxWidth); 436351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 436451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 436551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4366993f43f24d7a45a5cd4678a3316b0852261fc5d4John McCall if (FieldDecl *BitField = E->getSourceBitField()) 4367a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith return IntRange(BitField->getBitWidthValue(C), 43685e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor BitField->getType()->isUnsignedIntegerOrEnumerationType()); 4369f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 437009bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 4371f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 4372f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 43730692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E) { 437409bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return GetExprRange(C, E, C.getIntWidth(GetExprType(E))); 4375323ed74658bc8375278eabf074b4777458376540John McCall} 4376323ed74658bc8375278eabf074b4777458376540John McCall 4377f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 4378f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 4379f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 43800692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const llvm::APFloat &value, 43810692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Src, 43820692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Tgt) { 4383f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APFloat truncated = value; 4384f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4385f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool ignored; 4386f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 4387f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 4388f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4389f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return truncated.bitwiseIsEqual(value); 439051313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 439151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4392f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 4393f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 4394f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 4395f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 4396f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number). 43970692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const APValue &value, 43980692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Src, 43990692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Tgt) { 4400f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isFloat()) 4401f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 4402f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4403f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isVector()) { 4404f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 4405f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 4406f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return false; 4407f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return true; 4408f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 4409f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4410f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(value.isComplexFloat()); 4411f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 4412f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 4413f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 4414f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 44150692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 4416323ed74658bc8375278eabf074b4777458376540John McCall 4417e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) { 4418e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where we are comparing against an enum constant. 4419e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (const DeclRefExpr *DR = 4420e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 4421e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (isa<EnumConstantDecl>(DR->getDecl())) 4422e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 4423e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 4424e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where the '0' value is expanded from a macro. 4425e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (E->getLocStart().isMacroID()) 4426e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 4427e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 4428323ed74658bc8375278eabf074b4777458376540John McCall llvm::APSInt Value; 4429323ed74658bc8375278eabf074b4777458376540John McCall return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 4430323ed74658bc8375278eabf074b4777458376540John McCall} 4431323ed74658bc8375278eabf074b4777458376540John McCall 4432372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) { 4433372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall // Strip off implicit integral promotions. 4434372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 443563b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis if (ICE->getCastKind() != CK_IntegralCast && 443663b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis ICE->getCastKind() != CK_NoOp) 4437372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall break; 443863b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis E = ICE->getSubExpr(); 4439372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall } 4440372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 4441372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall return E->getType()->isEnumeralType(); 4442372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall} 4443372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 44440692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 44452de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = E->getOpcode(); 444614af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor if (E->isValueDependent()) 444714af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor return; 444814af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor 44492de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op == BO_LT && IsZero(S, E->getRHS())) { 4450323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 4451372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "< 0" << "false" << HasEnumType(E->getLHS()) 4452323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 44532de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GE && IsZero(S, E->getRHS())) { 4454323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 4455372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << ">= 0" << "true" << HasEnumType(E->getLHS()) 4456323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 44572de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GT && IsZero(S, E->getLHS())) { 4458323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 4459372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 >" << "false" << HasEnumType(E->getRHS()) 4460323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 44612de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_LE && IsZero(S, E->getLHS())) { 4462323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 4463372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 <=" << "true" << HasEnumType(E->getRHS()) 4464323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 4465323ed74658bc8375278eabf074b4777458376540John McCall } 4466323ed74658bc8375278eabf074b4777458376540John McCall} 4467323ed74658bc8375278eabf074b4777458376540John McCall 446815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanianstatic void DiagnoseOutOfRangeComparison(Sema &S, BinaryOperator *E, 4469a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian Expr *Constant, Expr *Other, 447015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian llvm::APSInt Value, 4471a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian bool RhsConstant) { 4472526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // 0 values are handled later by CheckTrivialUnsignedComparison(). 4473526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (Value == 0) 4474526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4475526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 447615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian BinaryOperatorKind op = E->getOpcode(); 4477a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian QualType OtherT = Other->getType(); 4478a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian QualType ConstantT = Constant->getType(); 4479526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu QualType CommonT = E->getLHS()->getType(); 4480a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian if (S.Context.hasSameUnqualifiedType(OtherT, ConstantT)) 448115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian return; 4482a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian assert((OtherT->isIntegerType() && ConstantT->isIntegerType()) 448315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian && "comparison with non-integer type"); 4484526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4485526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool ConstantSigned = ConstantT->isSignedIntegerType(); 4486526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool CommonSigned = CommonT->isSignedIntegerType(); 4487526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4488526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool EqualityOnly = false; 4489526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4490526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // TODO: Investigate using GetExprRange() to get tighter bounds on 4491526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // on the bit ranges. 449215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian IntRange OtherRange = IntRange::forValueOfType(S.Context, OtherT); 4493526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu unsigned OtherWidth = OtherRange.Width; 4494526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4495526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (CommonSigned) { 4496526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // The common type is signed, therefore no signed to unsigned conversion. 4497d87de7bdbc25dd84ae3dbefffda4539c443000d2Eli Friedman if (!OtherRange.NonNegative) { 4498526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check that the constant is representable in type OtherT. 4499526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (ConstantSigned) { 4500526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getMinSignedBits()) 4501526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4502526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !ConstantSigned 4503526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getActiveBits() + 1) 4504526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4505526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4506526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !OtherSigned 4507526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check that the constant is representable in type OtherT. 4508526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Negative values are out of range. 4509526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (ConstantSigned) { 4510526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (Value.isNonNegative() && OtherWidth >= Value.getActiveBits()) 4511526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4512526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !ConstantSigned 4513526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getActiveBits()) 4514526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4515526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4516526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4517526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !CommonSigned 4518d87de7bdbc25dd84ae3dbefffda4539c443000d2Eli Friedman if (OtherRange.NonNegative) { 4519526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getActiveBits()) 4520526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4521d87de7bdbc25dd84ae3dbefffda4539c443000d2Eli Friedman } else if (!OtherRange.NonNegative && !ConstantSigned) { 4522526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check to see if the constant is representable in OtherT. 4523526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth > Value.getActiveBits()) 4524526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4525526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check to see if the constant is equivalent to a negative value 4526526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // cast to CommonT. 4527526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (S.Context.getIntWidth(ConstantT) == S.Context.getIntWidth(CommonT) && 45285d1cf4f292cb060b1973eb197607fc6d5716bd12Richard Trieu Value.isNegative() && Value.getMinSignedBits() <= OtherWidth) 4529526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4530526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // The constant value rests between values that OtherT can represent after 4531526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // conversion. Relational comparison still works, but equality 4532526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // comparisons will be tautological. 4533526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu EqualityOnly = true; 4534526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // OtherSigned && ConstantSigned 4535526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu assert(0 && "Two signed types converted to unsigned types."); 4536526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4537526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4538526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4539526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool PositiveConstant = !ConstantSigned || Value.isNonNegative(); 4540526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 454115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsTrue = true; 4542526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (op == BO_EQ || op == BO_NE) { 4543526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = op == BO_NE; 4544526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else if (EqualityOnly) { 4545526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4546526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else if (RhsConstant) { 454715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (op == BO_GT || op == BO_GE) 4548526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = !PositiveConstant; 454915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else // op == BO_LT || op == BO_LE 4550526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = PositiveConstant; 4551a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian } else { 455215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (op == BO_LT || op == BO_LE) 4553526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = !PositiveConstant; 455415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else // op == BO_GT || op == BO_GE 4555526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = PositiveConstant; 455615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian } 45577adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek 45587adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek // If this is a comparison to an enum constant, include that 45597adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek // constant in the diagnostic. 45607adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek const EnumConstantDecl *ED = 0; 45617adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Constant)) 45627adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek ED = dyn_cast<EnumConstantDecl>(DR->getDecl()); 45637adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek 45647adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek SmallString<64> PrettySourceValue; 45657adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek llvm::raw_svector_ostream OS(PrettySourceValue); 45667adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek if (ED) 45679de50947ba381561a5236b3c878c83e4bb8c1088Ted Kremenek OS << '\'' << *ED << "' (" << Value << ")"; 45687adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek else 45697adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek OS << Value; 45707adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek 4571a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian S.Diag(E->getOperatorLoc(), diag::warn_out_of_range_compare) 45727adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek << OS.str() << OtherT << IsTrue 4573526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 457415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian} 457515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4576323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison. Implements the 4577323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison. 45780692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 4579b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 4580b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 4581323ed74658bc8375278eabf074b4777458376540John McCall} 4582f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4583ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare. 4584ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// 4585dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu/// \param E the binary operator to check for warnings 45860692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeComparison(Sema &S, BinaryOperator *E) { 4587323ed74658bc8375278eabf074b4777458376540John McCall // The type the comparison is being performed in. 4588323ed74658bc8375278eabf074b4777458376540John McCall QualType T = E->getLHS()->getType(); 4589323ed74658bc8375278eabf074b4777458376540John McCall assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 4590323ed74658bc8375278eabf074b4777458376540John McCall && "comparison with mismatched types"); 4591ab4702febef82409773f7c80ec02d53ddbb4d80eFariborz Jahanian if (E->isValueDependent()) 4592ab4702febef82409773f7c80ec02d53ddbb4d80eFariborz Jahanian return AnalyzeImpConvsInComparison(S, E); 4593323ed74658bc8375278eabf074b4777458376540John McCall 459415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian Expr *LHS = E->getLHS()->IgnoreParenImpCasts(); 459515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian Expr *RHS = E->getRHS()->IgnoreParenImpCasts(); 459615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 459715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsComparisonConstant = false; 459815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4599a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian // Check whether an integer constant comparison results in a value 460015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian // of 'true' or 'false'. 460115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (T->isIntegralType(S.Context)) { 460215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian llvm::APSInt RHSValue; 460315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsRHSIntegralLiteral = 460415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian RHS->isIntegerConstantExpr(RHSValue, S.Context); 460515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian llvm::APSInt LHSValue; 460615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsLHSIntegralLiteral = 460715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian LHS->isIntegerConstantExpr(LHSValue, S.Context); 460815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (IsRHSIntegralLiteral && !IsLHSIntegralLiteral) 460915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian DiagnoseOutOfRangeComparison(S, E, RHS, LHS, RHSValue, true); 461015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else if (!IsRHSIntegralLiteral && IsLHSIntegralLiteral) 461115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian DiagnoseOutOfRangeComparison(S, E, LHS, RHS, LHSValue, false); 461215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else 461315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian IsComparisonConstant = 461415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian (IsRHSIntegralLiteral && IsLHSIntegralLiteral); 4615a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian } else if (!T->hasUnsignedIntegerRepresentation()) 4616a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian IsComparisonConstant = E->isIntegerConstantExpr(S.Context); 461715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4618323ed74658bc8375278eabf074b4777458376540John McCall // We don't do anything special if this isn't an unsigned integral 4619323ed74658bc8375278eabf074b4777458376540John McCall // comparison: we're only interested in integral comparisons, and 4620323ed74658bc8375278eabf074b4777458376540John McCall // signed comparisons only happen in cases we don't care to warn about. 46213e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // 46223e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // We also don't care about value-dependent expressions or expressions 46233e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // whose result is a constant. 462415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (!T->hasUnsignedIntegerRepresentation() || IsComparisonConstant) 4625323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 462615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4627323ed74658bc8375278eabf074b4777458376540John McCall // Check to see if one of the (unmodified) operands is of different 4628323ed74658bc8375278eabf074b4777458376540John McCall // signedness. 4629323ed74658bc8375278eabf074b4777458376540John McCall Expr *signedOperand, *unsignedOperand; 4630dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu if (LHS->getType()->hasSignedIntegerRepresentation()) { 4631dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu assert(!RHS->getType()->hasSignedIntegerRepresentation() && 4632323ed74658bc8375278eabf074b4777458376540John McCall "unsigned comparison between two signed integer expressions?"); 4633dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = LHS; 4634dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = RHS; 4635dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu } else if (RHS->getType()->hasSignedIntegerRepresentation()) { 4636dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = RHS; 4637dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = LHS; 4638ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } else { 4639323ed74658bc8375278eabf074b4777458376540John McCall CheckTrivialUnsignedComparison(S, E); 4640323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 4641ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } 4642ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4643323ed74658bc8375278eabf074b4777458376540John McCall // Otherwise, calculate the effective range of the signed operand. 4644323ed74658bc8375278eabf074b4777458376540John McCall IntRange signedRange = GetExprRange(S.Context, signedOperand); 4645f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4646323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and analyze implicit conversions in the operands. Note 4647323ed74658bc8375278eabf074b4777458376540John McCall // that we skip the implicit conversions on both sides. 4648dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc()); 4649dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc()); 4650ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4651323ed74658bc8375278eabf074b4777458376540John McCall // If the signed range is non-negative, -Wsign-compare won't fire, 4652323ed74658bc8375278eabf074b4777458376540John McCall // but we should still check for comparisons which are always true 4653323ed74658bc8375278eabf074b4777458376540John McCall // or false. 4654323ed74658bc8375278eabf074b4777458376540John McCall if (signedRange.NonNegative) 4655323ed74658bc8375278eabf074b4777458376540John McCall return CheckTrivialUnsignedComparison(S, E); 4656ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4657ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // For (in)equality comparisons, if the unsigned operand is a 4658ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // constant which cannot collide with a overflowed signed operand, 4659ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // then reinterpreting the signed operand as unsigned will not 4660ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // change the result of the comparison. 4661323ed74658bc8375278eabf074b4777458376540John McCall if (E->isEqualityOp()) { 4662323ed74658bc8375278eabf074b4777458376540John McCall unsigned comparisonWidth = S.Context.getIntWidth(T); 4663323ed74658bc8375278eabf074b4777458376540John McCall IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 4664323ed74658bc8375278eabf074b4777458376540John McCall 4665323ed74658bc8375278eabf074b4777458376540John McCall // We should never be unable to prove that the unsigned operand is 4666323ed74658bc8375278eabf074b4777458376540John McCall // non-negative. 4667323ed74658bc8375278eabf074b4777458376540John McCall assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 4668ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4669323ed74658bc8375278eabf074b4777458376540John McCall if (unsignedRange.Width < comparisonWidth) 4670323ed74658bc8375278eabf074b4777458376540John McCall return; 4671323ed74658bc8375278eabf074b4777458376540John McCall } 4672323ed74658bc8375278eabf074b4777458376540John McCall 46736d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor S.DiagRuntimeBehavior(E->getOperatorLoc(), E, 46746d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor S.PDiag(diag::warn_mixed_sign_comparison) 46756d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor << LHS->getType() << RHS->getType() 46766d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor << LHS->getSourceRange() << RHS->getSourceRange()); 4677ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall} 4678ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 467915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield. 468015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// 468115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt. 46820692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 46830692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek SourceLocation InitLoc) { 468415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall assert(Bitfield->isBitField()); 468515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Bitfield->isInvalidDecl()) 468615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 468715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 468891b6014876e9186f968f74a8975ab8fc08ef1b68John McCall // White-list bool bitfields. 468991b6014876e9186f968f74a8975ab8fc08ef1b68John McCall if (Bitfield->getType()->isBooleanType()) 469091b6014876e9186f968f74a8975ab8fc08ef1b68John McCall return false; 469191b6014876e9186f968f74a8975ab8fc08ef1b68John McCall 469246ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor // Ignore value- or type-dependent expressions. 469346ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor if (Bitfield->getBitWidth()->isValueDependent() || 469446ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Bitfield->getBitWidth()->isTypeDependent() || 469546ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isValueDependent() || 469646ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isTypeDependent()) 469746ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor return false; 469846ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor 469915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *OriginalInit = Init->IgnoreParenImpCasts(); 470015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 470180d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith llvm::APSInt Value; 470280d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith if (!OriginalInit->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects)) 470315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 470415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 470515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned OriginalWidth = Value.getBitWidth(); 4706a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context); 470715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 470815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (OriginalWidth <= FieldWidth) 470915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 471015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 47113a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Compute the value which the bitfield will contain. 47129f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad llvm::APSInt TruncatedValue = Value.trunc(FieldWidth); 47133a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman TruncatedValue.setIsSigned(Bitfield->getType()->isSignedIntegerType()); 471415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 47153a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Check whether the stored value is equal to the original value. 47163a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman TruncatedValue = TruncatedValue.extend(OriginalWidth); 4717e1ecdc168175719d74e112bcacd4aae5e12d4631Richard Trieu if (llvm::APSInt::isSameValue(Value, TruncatedValue)) 471815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 471915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 47203a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Special-case bitfields of width 1: booleans are naturally 0/1, and 472134ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman // therefore don't strictly fit into a signed bitfield of width 1. 472234ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman if (FieldWidth == 1 && Value == 1) 47233a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman return false; 47243a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman 472515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyValue = Value.toString(10); 472615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyTrunc = TruncatedValue.toString(10); 472715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 472815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 472915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << PrettyValue << PrettyTrunc << OriginalInit->getType() 473015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << Init->getSourceRange(); 473115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 473215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return true; 473315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 473415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 4735beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy 4736beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations. 47370692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeAssignment(Sema &S, BinaryOperator *E) { 4738beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Just recurse on the LHS. 4739beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 4740beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 4741beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // We want to recurse on the RHS as normal unless we're assigning to 4742beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // a bitfield. 4743993f43f24d7a45a5cd4678a3316b0852261fc5d4John McCall if (FieldDecl *Bitfield = E->getLHS()->getSourceBitField()) { 4744dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 474515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc())) { 474615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // Recurse, ignoring any implicit conversions on the RHS. 474715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 474815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc()); 4749beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4750beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4751beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 4752beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 4753beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall} 4754beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 475551313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 47560692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T, 4757c36bedc90c687caa71748480c60707ea4608b092Anna Zaks SourceLocation CContext, unsigned diag, 4758c36bedc90c687caa71748480c60707ea4608b092Anna Zaks bool pruneControlFlow = false) { 4759c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (pruneControlFlow) { 4760c36bedc90c687caa71748480c60707ea4608b092Anna Zaks S.DiagRuntimeBehavior(E->getExprLoc(), E, 4761c36bedc90c687caa71748480c60707ea4608b092Anna Zaks S.PDiag(diag) 4762c36bedc90c687caa71748480c60707ea4608b092Anna Zaks << SourceType << T << E->getSourceRange() 4763c36bedc90c687caa71748480c60707ea4608b092Anna Zaks << SourceRange(CContext)); 4764c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 4765c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 47665a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor S.Diag(E->getExprLoc(), diag) 47675a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor << SourceType << T << E->getSourceRange() << SourceRange(CContext); 47685a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor} 47695a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 4770e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 47710692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType T, 4772c36bedc90c687caa71748480c60707ea4608b092Anna Zaks SourceLocation CContext, unsigned diag, 4773c36bedc90c687caa71748480c60707ea4608b092Anna Zaks bool pruneControlFlow = false) { 4774c36bedc90c687caa71748480c60707ea4608b092Anna Zaks DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow); 4775e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth} 4776e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth 47779ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// Diagnose an implicit cast from a literal expression. Does not warn when the 47789ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// cast wouldn't lose information. 4779f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruthvoid DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T, 4780f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth SourceLocation CContext) { 47819ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay // Try to convert the literal exactly to an integer. If we can, don't warn. 4782f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth bool isExact = false; 47839ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay const llvm::APFloat &Value = FL->getValue(); 47843e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin llvm::APSInt IntegerValue(S.Context.getIntWidth(T), 47853e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin T->hasUnsignedIntegerRepresentation()); 47863e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin if (Value.convertToInteger(IntegerValue, 4787f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth llvm::APFloat::rmTowardZero, &isExact) 47889ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay == llvm::APFloat::opOK && isExact) 4789f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth return; 4790f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 4791be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie SmallString<16> PrettySourceValue; 4792be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie Value.toString(PrettySourceValue); 4793de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie SmallString<16> PrettyTargetValue; 4794be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (T->isSpecificBuiltinType(BuiltinType::Bool)) 4795be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie PrettyTargetValue = IntegerValue == 0 ? "false" : "true"; 4796be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie else 4797de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie IntegerValue.toString(PrettyTargetValue); 4798be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie 47999ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer) 4800be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie << FL->getType() << T.getUnqualifiedType() << PrettySourceValue 4801be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie << PrettyTargetValue << FL->getSourceRange() << SourceRange(CContext); 4802f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth} 4803f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 4804091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 4805091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Range.Width) return "0"; 4806091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 4807091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt ValueInRange = Value; 4808091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.setIsSigned(!Range.NonNegative); 48099f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad ValueInRange = ValueInRange.trunc(Range.Width); 4810091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return ValueInRange.toString(10); 4811091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall} 4812091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 481388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgstatic bool IsImplicitBoolFloatConversion(Sema &S, Expr *Ex, bool ToBool) { 481488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (!isa<ImplicitCastExpr>(Ex)) 481588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return false; 481688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 481788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *InnerE = Ex->IgnoreParenImpCasts(); 481888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *Target = S.Context.getCanonicalType(Ex->getType()).getTypePtr(); 481988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *Source = 482088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg S.Context.getCanonicalType(InnerE->getType()).getTypePtr(); 482188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (Target->isDependentType()) 482288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return false; 482388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 482488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const BuiltinType *FloatCandidateBT = 482588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg dyn_cast<BuiltinType>(ToBool ? Source : Target); 482688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *BoolCandidateType = ToBool ? Target : Source; 482788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 482888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return (BoolCandidateType->isSpecificBuiltinType(BuiltinType::Bool) && 482988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg FloatCandidateBT && (FloatCandidateBT->isFloatingPoint())); 483088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg} 483188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 483288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgvoid CheckImplicitArgumentConversions(Sema &S, CallExpr *TheCall, 483388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg SourceLocation CC) { 483488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg unsigned NumArgs = TheCall->getNumArgs(); 483588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg for (unsigned i = 0; i < NumArgs; ++i) { 483688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *CurrA = TheCall->getArg(i); 483788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (!IsImplicitBoolFloatConversion(S, CurrA, true)) 483888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg continue; 483988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 484088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg bool IsSwapped = ((i > 0) && 484188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsImplicitBoolFloatConversion(S, TheCall->getArg(i - 1), false)); 484288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsSwapped |= ((i < (NumArgs - 1)) && 484388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsImplicitBoolFloatConversion(S, TheCall->getArg(i + 1), false)); 484488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (IsSwapped) { 484588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Warn on this floating-point to bool conversion. 484688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg DiagnoseImpCast(S, CurrA->IgnoreParenImpCasts(), 484788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CurrA->getType(), CC, 484888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg diag::warn_impcast_floating_point_to_bool); 484988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 485088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 485188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg} 485288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 4853323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T, 4854dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov SourceLocation CC, bool *ICContext = 0) { 4855323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) return; 485651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4857323ed74658bc8375278eabf074b4777458376540John McCall const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 4858323ed74658bc8375278eabf074b4777458376540John McCall const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 4859323ed74658bc8375278eabf074b4777458376540John McCall if (Source == Target) return; 4860323ed74658bc8375278eabf074b4777458376540John McCall if (Target->isDependentType()) return; 486151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4862108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // If the conversion context location is invalid don't complain. We also 4863108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // don't want to emit a warning if the issue occurs from the expansion of 4864108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // a system macro. The problem is that 'getSpellingLoc()' is slow, so we 4865108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // delay this check as long as possible. Once we detect we are in that 4866108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // scenario, we just return. 4867ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (CC.isInvalid()) 4868b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return; 4869b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 4870f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Diagnose implicit casts to bool. 4871f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (Target->isSpecificBuiltinType(BuiltinType::Bool)) { 4872f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (isa<StringLiteral>(E)) 4873f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Warn on string literal to bool. Checks for string literals in logical 4874f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // expressions, for instances, assert(0 && "error here"), is prevented 4875f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // by a check in AnalyzeImplicitConversions(). 4876f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu return DiagnoseImpCast(S, E, T, CC, 4877f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu diag::warn_impcast_string_literal_to_bool); 4878e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (Source->isFunctionType()) { 4879e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // Warn on function to bool. Checks free functions and static member 4880e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // functions. Weakly imported functions are excluded from the check, 4881e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // since it's common to test their value to check whether the linker 4882e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // found a definition for them. 4883e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames ValueDecl *D = 0; 4884e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (DeclRefExpr* R = dyn_cast<DeclRefExpr>(E)) { 4885e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = R->getDecl(); 4886e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) { 4887e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = M->getMemberDecl(); 4888e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 4889e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames 4890e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (D && !D->isWeak()) { 489126b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu if (FunctionDecl* F = dyn_cast<FunctionDecl>(D)) { 489226b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu S.Diag(E->getExprLoc(), diag::warn_impcast_function_to_bool) 489326b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu << F << E->getSourceRange() << SourceRange(CC); 48942def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_silence) 48952def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion(E->getExprLoc(), "&"); 48962def77399ab3088106a2d61372344f5b7104e1a2David Blaikie QualType ReturnType; 48972def77399ab3088106a2d61372344f5b7104e1a2David Blaikie UnresolvedSet<4> NonTemplateOverloads; 4898c8fa525b5b81eeb7a62294dd3218ca2a6ccf0a6aDavid Blaikie S.tryExprAsCall(*E, ReturnType, NonTemplateOverloads); 48992def77399ab3088106a2d61372344f5b7104e1a2David Blaikie if (!ReturnType.isNull() 49002def77399ab3088106a2d61372344f5b7104e1a2David Blaikie && ReturnType->isSpecificBuiltinType(BuiltinType::Bool)) 49012def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_call) 49022def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion( 49032def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()), "()"); 490426b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu return; 490526b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu } 4906e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 4907e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 4908f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 490951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 491051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip vector types. 491151313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<VectorType>(Source)) { 4912ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<VectorType>(Target)) { 4913d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4914ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4915b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 4916ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 4917b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner 4918b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // If the vector cast is cast between two vectors of the same size, it is 4919b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // a bitcast, not a conversion. 4920b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target)) 4921b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner return; 492251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 492351313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 492451313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 492551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 492651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 492751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip complex types. 492851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<ComplexType>(Source)) { 4929ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<ComplexType>(Target)) { 4930d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4931ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4932ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4933b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 4934ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 493551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 493651313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 493751313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 493851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 493951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 494051313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 494151313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 494251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 494351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the source is floating point... 494451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT && SourceBT->isFloatingPoint()) { 494551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...and the target is floating point... 494651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (TargetBT && TargetBT->isFloatingPoint()) { 494751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...then warn if we're dropping FP rank. 494851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 494951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Builtin FP kinds are ordered by increasing FP rank. 495051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT->getKind() > TargetBT->getKind()) { 495151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Don't warn about float constants that are precisely 495251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // representable in the target type. 495351313c39c84407dd6a323be99a8c322bf8d052a9John McCall Expr::EvalResult result; 495451f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, S.Context)) { 495551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Value might be a float, a float vector, or a float complex. 495651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (IsSameFloatAfterCast(result.Val, 4957323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 4958323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 495951313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 496051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 496151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4962d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4963ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4964ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4965b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 496651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 496751313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 496851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 496951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4970ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // If the target is integral, always warn. 4971be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (TargetBT && TargetBT->isInteger()) { 4972d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4973ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4974ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4975a5b9332418f25338f118358e27303cd510d54107Chandler Carruth Expr *InnerE = E->IgnoreParenImpCasts(); 4976634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay // We also want to warn on, e.g., "int i = -1.234" 4977634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE)) 4978634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus) 4979634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay InnerE = UOp->getSubExpr()->IgnoreParenImpCasts(); 4980634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay 4981f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) { 4982f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth DiagnoseFloatingLiteralImpCast(S, FL, T, CC); 4983a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } else { 4984a5b9332418f25338f118358e27303cd510d54107Chandler Carruth DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 4985a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 4986a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 498751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 498888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // If the target is bool, warn if expr is a function or method call. 498988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (Target->isSpecificBuiltinType(BuiltinType::Bool) && 499088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg isa<CallExpr>(E)) { 499188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Check last argument of function call to see if it is an 499288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // implicit cast from a type matching the type the result 499388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // is being cast to. 499488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CallExpr *CEx = cast<CallExpr>(E); 499588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg unsigned NumArgs = CEx->getNumArgs(); 499688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (NumArgs > 0) { 499788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *LastA = CEx->getArg(NumArgs - 1); 499888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *InnerE = LastA->IgnoreParenImpCasts(); 499988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *InnerType = 500088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg S.Context.getCanonicalType(InnerE->getType()).getTypePtr(); 500188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (isa<ImplicitCastExpr>(LastA) && (InnerType == Target)) { 500288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Warn on this floating-point to bool conversion 500388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg DiagnoseImpCast(S, E, T, CC, 500488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg diag::warn_impcast_floating_point_to_bool); 500588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 500688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 500788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 500851313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 500951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 501051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 50111838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull) 5012b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie == Expr::NPCK_GNUNull) && !Target->isAnyPointerType() 5013e81b43bc306d361fcf4d411aeb14b43f8464bf4aDavid Blaikie && !Target->isBlockPointerType() && !Target->isMemberPointerType() 5014896c7dd62801c0aacf14b05183c3c471c1fe9f7aDavid Blaikie && Target->isScalarType() && !Target->isNullPtrType()) { 5015b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie SourceLocation Loc = E->getSourceRange().getBegin(); 5016b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie if (Loc.isMacroID()) 5017b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie Loc = S.SourceMgr.getImmediateExpansionRange(Loc).first; 50189fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie if (!Loc.isMacroID() || CC.isMacroID()) 50199fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie S.Diag(Loc, diag::warn_impcast_null_pointer_to_integer) 50209fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie << T << clang::SourceRange(CC) 50219fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie << FixItHint::CreateReplacement(Loc, S.getFixItZeroLiteralForType(T)); 50221838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu } 50231838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu 5024b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie if (!Source->isIntegerType() || !Target->isIntegerType()) 5025b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie return; 5026b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie 5027be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie // TODO: remove this early return once the false positives for constant->bool 5028be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie // in templates, macros, etc, are reduced or removed. 5029be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (Target->isSpecificBuiltinType(BuiltinType::Bool)) 5030be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie return; 5031be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie 5032323ed74658bc8375278eabf074b4777458376540John McCall IntRange SourceRange = GetExprRange(S.Context, E); 50331844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 503451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 5035dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (SourceRange.Width > TargetRange.Width) { 503625ffbef84450f0c666957a2d00cdf928c61b44d7Sam Panzer // If the source is a constant, use a default-on diagnostic. 5037dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov // TODO: this should happen for bitfield stores, too. 5038dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov llvm::APSInt Value(32); 5039dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (E->isIntegerConstantExpr(Value, S.Context)) { 5040dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (S.SourceMgr.isInSystemMacro(CC)) 5041dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov return; 5042dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov 5043091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettySourceValue = Value.toString(10); 5044091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 5045dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov 50465e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.DiagRuntimeBehavior(E->getExprLoc(), E, 50475e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.PDiag(diag::warn_impcast_integer_precision_constant) 50485e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << PrettySourceValue << PrettyTargetValue 50495e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << E->getType() << T << E->getSourceRange() 50505e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << clang::SourceRange(CC)); 5051091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return; 5052091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall } 5053091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 5054dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov // People want to build with -Wshorten-64-to-32 and not -Wconversion. 5055dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (S.SourceMgr.isInSystemMacro(CC)) 5056dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov return; 5057dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov 505837050841d7b852497b85d5275d9ea92c07ddf059David Blaikie if (TargetRange.Width == 32 && S.Context.getIntWidth(E->getType()) == 64) 5059c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32, 5060c36bedc90c687caa71748480c60707ea4608b092Anna Zaks /* pruneControlFlow */ true); 5061b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 5062323ed74658bc8375278eabf074b4777458376540John McCall } 5063323ed74658bc8375278eabf074b4777458376540John McCall 5064323ed74658bc8375278eabf074b4777458376540John McCall if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 5065323ed74658bc8375278eabf074b4777458376540John McCall (!TargetRange.NonNegative && SourceRange.NonNegative && 5066323ed74658bc8375278eabf074b4777458376540John McCall SourceRange.Width == TargetRange.Width)) { 5067ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 5068d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 5069ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 5070ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 5071323ed74658bc8375278eabf074b4777458376540John McCall unsigned DiagID = diag::warn_impcast_integer_sign; 5072323ed74658bc8375278eabf074b4777458376540John McCall 5073323ed74658bc8375278eabf074b4777458376540John McCall // Traditionally, gcc has warned about this under -Wsign-compare. 5074323ed74658bc8375278eabf074b4777458376540John McCall // We also want to warn about it in -Wconversion. 5075323ed74658bc8375278eabf074b4777458376540John McCall // So if -Wconversion is off, use a completely identical diagnostic 5076323ed74658bc8375278eabf074b4777458376540John McCall // in the sign-compare group. 5077323ed74658bc8375278eabf074b4777458376540John McCall // The conditional-checking code will 5078323ed74658bc8375278eabf074b4777458376540John McCall if (ICContext) { 5079323ed74658bc8375278eabf074b4777458376540John McCall DiagID = diag::warn_impcast_integer_sign_conditional; 5080323ed74658bc8375278eabf074b4777458376540John McCall *ICContext = true; 5081323ed74658bc8375278eabf074b4777458376540John McCall } 5082323ed74658bc8375278eabf074b4777458376540John McCall 5083b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, DiagID); 508451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 508551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 5086284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor // Diagnose conversions between different enumeration types. 50875a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // In C, we pretend that the type of an EnumConstantDecl is its enumeration 50885a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // type, to give us better diagnostics. 50895a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor QualType SourceType = E->getType(); 50904e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (!S.getLangOpts().CPlusPlus) { 50915a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 50925a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) { 50935a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext()); 50945a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceType = S.Context.getTypeDeclType(Enum); 50955a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor Source = S.Context.getCanonicalType(SourceType).getTypePtr(); 50965a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 50975a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 50985a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 5099284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *SourceEnum = Source->getAs<EnumType>()) 5100284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *TargetEnum = Target->getAs<EnumType>()) 510183972f128e9218c051692bf96361327a701aeb79John McCall if (SourceEnum->getDecl()->hasNameForLinkage() && 510283972f128e9218c051692bf96361327a701aeb79John McCall TargetEnum->getDecl()->hasNameForLinkage() && 5103ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceEnum != TargetEnum) { 5104d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 5105ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 5106ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 51075a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor return DiagnoseImpCast(S, E, SourceType, T, CC, 5108284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor diag::warn_impcast_different_enum_types); 5109ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 5110284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor 511151313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 511251313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 511351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 51149fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, 51159fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie SourceLocation CC, QualType T); 5116323ed74658bc8375278eabf074b4777458376540John McCall 5117323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T, 5118b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool &ICContext) { 5119323ed74658bc8375278eabf074b4777458376540John McCall E = E->IgnoreParenImpCasts(); 5120323ed74658bc8375278eabf074b4777458376540John McCall 5121323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) 51229fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie return CheckConditionalOperator(S, cast<ConditionalOperator>(E), CC, T); 5123323ed74658bc8375278eabf074b4777458376540John McCall 5124b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E, CC); 5125323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 5126b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return CheckImplicitConversion(S, E, T, CC, &ICContext); 5127323ed74658bc8375278eabf074b4777458376540John McCall return; 5128323ed74658bc8375278eabf074b4777458376540John McCall} 5129323ed74658bc8375278eabf074b4777458376540John McCall 51309fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, 51319fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie SourceLocation CC, QualType T) { 5132b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getCond(), CC); 5133323ed74658bc8375278eabf074b4777458376540John McCall 5134323ed74658bc8375278eabf074b4777458376540John McCall bool Suspicious = false; 5135b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 5136b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 5137323ed74658bc8375278eabf074b4777458376540John McCall 5138323ed74658bc8375278eabf074b4777458376540John McCall // If -Wconversion would have warned about either of the candidates 5139323ed74658bc8375278eabf074b4777458376540John McCall // for a signedness conversion to the context type... 5140323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) return; 5141323ed74658bc8375278eabf074b4777458376540John McCall 5142323ed74658bc8375278eabf074b4777458376540John McCall // ...but it's currently ignored... 51430827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional, 51440827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis CC)) 5145323ed74658bc8375278eabf074b4777458376540John McCall return; 5146323ed74658bc8375278eabf074b4777458376540John McCall 5147323ed74658bc8375278eabf074b4777458376540John McCall // ...then check whether it would have warned about either of the 5148323ed74658bc8375278eabf074b4777458376540John McCall // candidates for a signedness conversion to the condition type. 51495254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (E->getType() == T) return; 51505254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu 51515254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu Suspicious = false; 51525254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 51535254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu E->getType(), CC, &Suspicious); 51545254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (!Suspicious) 51555254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 5156b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 5157323ed74658bc8375278eabf074b4777458376540John McCall} 5158323ed74658bc8375278eabf074b4777458376540John McCall 5159323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting 5160323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression. There are a couple 5161323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare. 5162b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 5163323ed74658bc8375278eabf074b4777458376540John McCall QualType T = OrigE->getType(); 5164323ed74658bc8375278eabf074b4777458376540John McCall Expr *E = OrigE->IgnoreParenImpCasts(); 5165323ed74658bc8375278eabf074b4777458376540John McCall 5166f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 5167f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor return; 5168f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor 5169323ed74658bc8375278eabf074b4777458376540John McCall // For conditional operators, we analyze the arguments as if they 5170323ed74658bc8375278eabf074b4777458376540John McCall // were being fed directly into the output. 5171323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) { 5172323ed74658bc8375278eabf074b4777458376540John McCall ConditionalOperator *CO = cast<ConditionalOperator>(E); 51739fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie CheckConditionalOperator(S, CO, CC, T); 5174323ed74658bc8375278eabf074b4777458376540John McCall return; 5175323ed74658bc8375278eabf074b4777458376540John McCall } 5176323ed74658bc8375278eabf074b4777458376540John McCall 517788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Check implicit argument conversions for function calls. 517888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (CallExpr *Call = dyn_cast<CallExpr>(E)) 517988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CheckImplicitArgumentConversions(S, Call, CC); 518088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 5181323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and check any implicit conversions we might have skipped. 5182323ed74658bc8375278eabf074b4777458376540John McCall // The non-canonical typecheck is just an optimization; 5183323ed74658bc8375278eabf074b4777458376540John McCall // CheckImplicitConversion will filter out dead implicit conversions. 5184323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 5185b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckImplicitConversion(S, E, T, CC); 5186323ed74658bc8375278eabf074b4777458376540John McCall 5187323ed74658bc8375278eabf074b4777458376540John McCall // Now continue drilling into this expression. 51886f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian 51896f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian if (PseudoObjectExpr * POE = dyn_cast<PseudoObjectExpr>(E)) { 5190a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian if (POE->getResultExpr()) 5191a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian E = POE->getResultExpr(); 51926f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian } 51936f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian 5194a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian if (const OpaqueValueExpr *OVE = dyn_cast<OpaqueValueExpr>(E)) 5195a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian return AnalyzeImplicitConversions(S, OVE->getSourceExpr(), CC); 5196a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian 5197323ed74658bc8375278eabf074b4777458376540John McCall // Skip past explicit casts. 5198323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ExplicitCastExpr>(E)) { 5199323ed74658bc8375278eabf074b4777458376540John McCall E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 5200b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return AnalyzeImplicitConversions(S, E, CC); 5201323ed74658bc8375278eabf074b4777458376540John McCall } 5202323ed74658bc8375278eabf074b4777458376540John McCall 5203beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 5204beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Do a somewhat different check with comparison operators. 5205beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isComparisonOp()) 5206beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeComparison(S, BO); 5207beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 5208dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov // And with simple assignments. 5209dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (BO->getOpcode() == BO_Assign) 5210beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeAssignment(S, BO); 5211beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 5212323ed74658bc8375278eabf074b4777458376540John McCall 5213323ed74658bc8375278eabf074b4777458376540John McCall // These break the otherwise-useful invariant below. Fortunately, 5214323ed74658bc8375278eabf074b4777458376540John McCall // we don't really need to recurse into them, because any internal 5215323ed74658bc8375278eabf074b4777458376540John McCall // expressions should have been analyzed already when they were 5216323ed74658bc8375278eabf074b4777458376540John McCall // built into statements. 5217323ed74658bc8375278eabf074b4777458376540John McCall if (isa<StmtExpr>(E)) return; 5218323ed74658bc8375278eabf074b4777458376540John McCall 5219323ed74658bc8375278eabf074b4777458376540John McCall // Don't descend into unevaluated contexts. 5220f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne if (isa<UnaryExprOrTypeTraitExpr>(E)) return; 5221323ed74658bc8375278eabf074b4777458376540John McCall 5222323ed74658bc8375278eabf074b4777458376540John McCall // Now just recurse over the expression's children. 5223b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CC = E->getExprLoc(); 5224f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu BinaryOperator *BO = dyn_cast<BinaryOperator>(E); 5225f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu bool IsLogicalOperator = BO && BO->isLogicalOp(); 5226f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu for (Stmt::child_range I = E->children(); I; ++I) { 522754042f1bd78f1f1ea86be7d4af541462e127d2edDouglas Gregor Expr *ChildExpr = dyn_cast_or_null<Expr>(*I); 5228503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor if (!ChildExpr) 5229503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor continue; 5230503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor 5231f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (IsLogicalOperator && 5232f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts())) 5233f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Ignore checking string literals that are in logical operators. 5234f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu continue; 5235f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu AnalyzeImplicitConversions(S, ChildExpr, CC); 5236f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 5237323ed74658bc8375278eabf074b4777458376540John McCall} 5238323ed74658bc8375278eabf074b4777458376540John McCall 5239323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace 5240323ed74658bc8375278eabf074b4777458376540John McCall 5241323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given 5242323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression). Implements -Wconversion 5243323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare. 5244b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// 5245b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e. 5246b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// the most location of the syntactic entity requiring the implicit 5247b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// conversion 5248b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 5249323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose in unevaluated contexts. 525071f55f771794674a410171dbf3cb5dbedf95d033David Blaikie if (isUnevaluatedContext()) 5251323ed74658bc8375278eabf074b4777458376540John McCall return; 5252323ed74658bc8375278eabf074b4777458376540John McCall 5253323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose for value- or type-dependent expressions. 5254323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) 5255323ed74658bc8375278eabf074b4777458376540John McCall return; 5256323ed74658bc8375278eabf074b4777458376540John McCall 5257d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Check for array bounds violations in cases where the check isn't triggered 5258d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // elsewhere for other Expr types (like BinaryOperators), e.g. when an 5259d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // ArraySubscriptExpr is on the RHS of a variable initialization. 5260d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain CheckArrayAccess(E); 5261d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5262b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // This is not the right CC for (e.g.) a variable initialization. 5263b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(*this, E, CC); 5264323ed74658bc8375278eabf074b4777458376540John McCall} 5265323ed74658bc8375278eabf074b4777458376540John McCall 5266ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian/// Diagnose when expression is an integer constant expression and its evaluation 5267ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian/// results in integer overflow 5268ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanianvoid Sema::CheckForIntOverflow (Expr *E) { 52691fd8d46d222fab7f17b91846e2c50bef640a60a0Fariborz Jahanian if (isa<BinaryOperator>(E->IgnoreParens())) { 5270ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian llvm::SmallVector<PartialDiagnosticAt, 4> Diags; 5271ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian E->EvaluateForOverflow(Context, &Diags); 5272ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian } 5273ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian} 5274ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian 52756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithnamespace { 52766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith/// \brief Visitor for expressions which looks for unsequenced operations on the 52776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith/// same object. 52786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithclass SequenceChecker : public EvaluatedExprVisitor<SequenceChecker> { 52790c0b3909d11de7440d77556089516918b9c04cefRichard Smith typedef EvaluatedExprVisitor<SequenceChecker> Base; 52800c0b3909d11de7440d77556089516918b9c04cefRichard Smith 52816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief A tree of sequenced regions within an expression. Two regions are 52826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// unsequenced if one is an ancestor or a descendent of the other. When we 52836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// finish processing an expression with sequencing, such as a comma 52846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// expression, we fold its tree nodes into its parent, since they are 52856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// unsequenced with respect to nodes we will visit later. 52866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith class SequenceTree { 52876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct Value { 52886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith explicit Value(unsigned Parent) : Parent(Parent), Merged(false) {} 52896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned Parent : 31; 52906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Merged : 1; 52916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 52926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<Value, 8> Values; 52936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 52946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith public: 52956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief A region within an expression which may be sequenced with respect 52966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// to some other region. 52976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith class Seq { 52986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith explicit Seq(unsigned N) : Index(N) {} 52996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned Index; 53006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith friend class SequenceTree; 53016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith public: 53026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Seq() : Index(0) {} 53036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 53046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree() { Values.push_back(Value(0)); } 53066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Seq root() const { return Seq(0); } 53076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Create a new sequence of operations, which is an unsequenced 53096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// subset of \p Parent. This sequence of operations is sequenced with 53106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// respect to other children of \p Parent. 53116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Seq allocate(Seq Parent) { 53126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Values.push_back(Value(Parent.Index)); 53136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return Seq(Values.size() - 1); 53146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 53156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Merge a sequence of operations into its parent. 53176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void merge(Seq S) { 53186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Values[S.Index].Merged = true; 53196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 53206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Determine whether two operations are unsequenced. This operation 53226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// is asymmetric: \p Cur should be the more recent sequence, and \p Old 53236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// should have been merged into its parent as appropriate. 53246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool isUnsequenced(Seq Cur, Seq Old) { 53256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned C = representative(Cur.Index); 53266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned Target = representative(Old.Index); 53276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith while (C >= Target) { 53286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (C == Target) 53296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return true; 53306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith C = Values[C].Parent; 53316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 53326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return false; 53336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 53346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith private: 53366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Pick a representative for a sequence. 53376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned representative(unsigned K) { 53386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (Values[K].Merged) 53396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Perform path compression as we go. 53406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return Values[K].Parent = representative(Values[K].Parent); 53416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return K; 53426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 53436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 53446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// An object for which we can track unsequenced uses. 53466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith typedef NamedDecl *Object; 53476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Different flavors of object usage which we track. We only track the 53496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// least-sequenced usage of each kind. 53506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith enum UsageKind { 53516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// A read of an object. Multiple unsequenced reads are OK. 53526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_Use, 53536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// A modification of an object which is sequenced before the value 5354418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith /// computation of the expression, such as ++n in C++. 53556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_ModAsValue, 53566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// A modification of an object which is not sequenced before the value 53576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// computation of the expression, such as n++. 53586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_ModAsSideEffect, 53596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_Count = UK_ModAsSideEffect + 1 53616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 53626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct Usage { 53646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Usage() : Use(0), Seq() {} 53656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *Use; 53666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Seq; 53676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 53686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct UsageInfo { 53706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo() : Diagnosed(false) {} 53716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Usage Uses[UK_Count]; 53726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Have we issued a diagnostic for this variable already? 53736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Diagnosed; 53746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 53756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith typedef llvm::SmallDenseMap<Object, UsageInfo, 16> UsageInfoMap; 53766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Sema &SemaRef; 53786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Sequenced regions within the expression. 53796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree Tree; 53806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Declaration modifications and references which we have seen. 53816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfoMap UsageMap; 53826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// The region we are currently within. 53836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Region; 53846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Filled in with declarations which were modified as a side-effect 53856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// (that is, post-increment operations). 53866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVectorImpl<std::pair<Object, Usage> > *ModAsSideEffect; 53871a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith /// Expressions to check later. We defer checking these to reduce 53881a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith /// stack usage. 53891a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith llvm::SmallVectorImpl<Expr*> &WorkList; 53906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// RAII object wrapping the visitation of a sequenced subexpression of an 53926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// expression. At the end of this process, the side-effects of the evaluation 53936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// become sequenced with respect to the value computation of the result, so 53946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// we downgrade any UK_ModAsSideEffect within the evaluation to 53956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// UK_ModAsValue. 53966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct SequencedSubexpression { 53976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression(SequenceChecker &Self) 53986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith : Self(Self), OldModAsSideEffect(Self.ModAsSideEffect) { 53996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Self.ModAsSideEffect = &ModAsSideEffect; 54006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith ~SequencedSubexpression() { 54026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0, E = ModAsSideEffect.size(); I != E; ++I) { 54036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = Self.UsageMap[ModAsSideEffect[I].first]; 54046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith U.Uses[UK_ModAsSideEffect] = ModAsSideEffect[I].second; 54056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Self.addUsage(U, ModAsSideEffect[I].first, 54066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith ModAsSideEffect[I].second.Use, UK_ModAsValue); 54076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Self.ModAsSideEffect = OldModAsSideEffect; 54096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceChecker &Self; 54126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<std::pair<Object, Usage>, 4> ModAsSideEffect; 54136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVectorImpl<std::pair<Object, Usage> > *OldModAsSideEffect; 54146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 54156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 5416674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith /// RAII object wrapping the visitation of a subexpression which we might 5417674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith /// choose to evaluate as a constant. If any subexpression is evaluated and 5418674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith /// found to be non-constant, this allows us to suppress the evaluation of 5419674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith /// the outer expression. 5420674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith class EvaluationTracker { 5421674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith public: 5422674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker(SequenceChecker &Self) 5423674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith : Self(Self), Prev(Self.EvalTracker), EvalOK(true) { 5424674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith Self.EvalTracker = this; 5425674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith } 5426674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith ~EvaluationTracker() { 5427674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith Self.EvalTracker = Prev; 5428674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (Prev) 5429674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith Prev->EvalOK &= EvalOK; 5430674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith } 5431674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith 5432674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith bool evaluate(const Expr *E, bool &Result) { 5433674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (!EvalOK || E->isValueDependent()) 5434674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith return false; 5435674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvalOK = E->EvaluateAsBooleanCondition(Result, Self.SemaRef.Context); 5436674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith return EvalOK; 5437674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith } 5438674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith 5439674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith private: 5440674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith SequenceChecker &Self; 5441674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker *Prev; 5442674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith bool EvalOK; 5443674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith } *EvalTracker; 5444674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith 54456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Find the object which is produced by the specified expression, 54466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// if any. 54476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object getObject(Expr *E, bool Mod) const { 54486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith E = E->IgnoreParenCasts(); 54496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 54506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (Mod && (UO->getOpcode() == UO_PreInc || UO->getOpcode() == UO_PreDec)) 54516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return getObject(UO->getSubExpr(), Mod); 54526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 54536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (BO->getOpcode() == BO_Comma) 54546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return getObject(BO->getRHS(), Mod); 54556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (Mod && BO->isAssignmentOp()) 54566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return getObject(BO->getLHS(), Mod); 54576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } else if (MemberExpr *ME = dyn_cast<MemberExpr>(E)) { 54586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // FIXME: Check for more interesting cases, like "x.n = ++x.n". 54596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (isa<CXXThisExpr>(ME->getBase()->IgnoreParenCasts())) 54606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return ME->getMemberDecl(); 54616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } else if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 54626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // FIXME: If this is a reference, map through to its value. 54636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return DRE->getDecl(); 54646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return 0; 54656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Note that an object was modified or used by an expression. 54686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void addUsage(UsageInfo &UI, Object O, Expr *Ref, UsageKind UK) { 54696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Usage &U = UI.Uses[UK]; 54706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!U.Use || !Tree.isUnsequenced(Region, U.Seq)) { 54716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (UK == UK_ModAsSideEffect && ModAsSideEffect) 54726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith ModAsSideEffect->push_back(std::make_pair(O, U)); 54736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith U.Use = Ref; 54746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith U.Seq = Region; 54756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Check whether a modification or use conflicts with a prior usage. 54786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void checkUsage(Object O, UsageInfo &UI, Expr *Ref, UsageKind OtherKind, 54796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool IsModMod) { 54806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (UI.Diagnosed) 54816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return; 54826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith const Usage &U = UI.Uses[OtherKind]; 54846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!U.Use || !Tree.isUnsequenced(Region, U.Seq)) 54856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return; 54866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *Mod = U.Use; 54886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *ModOrUse = Ref; 54896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (OtherKind == UK_Use) 54906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith std::swap(Mod, ModOrUse); 54916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SemaRef.Diag(Mod->getExprLoc(), 54936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith IsModMod ? diag::warn_unsequenced_mod_mod 54946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith : diag::warn_unsequenced_mod_use) 54956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith << O << SourceRange(ModOrUse->getExprLoc()); 54966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UI.Diagnosed = true; 54976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePreUse(Object O, Expr *Use) { 55006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 55016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Uses conflict with other modifications. 55026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Use, UK_ModAsValue, false); 55036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePostUse(Object O, Expr *Use) { 55056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 55066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Use, UK_ModAsSideEffect, false); 55076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith addUsage(U, O, Use, UK_Use); 55086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePreMod(Object O, Expr *Mod) { 55116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 55126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Modifications conflict with other modifications and with uses. 55136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Mod, UK_ModAsValue, true); 55146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Mod, UK_Use, false); 55156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePostMod(Object O, Expr *Use, UsageKind UK) { 55176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 55186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Use, UK_ModAsSideEffect, true); 55196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith addUsage(U, O, Use, UK); 55206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithpublic: 55231a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith SequenceChecker(Sema &S, Expr *E, 55241a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith llvm::SmallVectorImpl<Expr*> &WorkList) 55250c0b3909d11de7440d77556089516918b9c04cefRichard Smith : Base(S.Context), SemaRef(S), Region(Tree.root()), 55260c0b3909d11de7440d77556089516918b9c04cefRichard Smith ModAsSideEffect(0), WorkList(WorkList), EvalTracker(0) { 55276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(E); 55286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitStmt(Stmt *S) { 55316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Skip all statements which aren't expressions for now. 55326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitExpr(Expr *E) { 55356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // By default, just recurse to evaluated subexpressions. 55360c0b3909d11de7440d77556089516918b9c04cefRichard Smith Base::VisitStmt(E); 55376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitCastExpr(CastExpr *E) { 55406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = Object(); 55416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (E->getCastKind() == CK_LValueToRValue) 55426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith O = getObject(E->getSubExpr(), false); 55436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (O) 55456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreUse(O, E); 55466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith VisitExpr(E); 55476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (O) 55486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePostUse(O, E); 55496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinComma(BinaryOperator *BO) { 55526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // C++11 [expr.comma]p1: 55536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Every value computation and side effect associated with the left 55546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // expression is sequenced before every value computation and side 55556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // effect associated with the right expression. 55566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq LHS = Tree.allocate(Region); 55576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq RHS = Tree.allocate(Region); 55586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq OldRegion = Region; 55596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith { 55616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression SeqLHS(*this); 55626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = LHS; 55636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 55646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = RHS; 55676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getRHS()); 55686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = OldRegion; 55706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Forget that LHS and RHS are sequenced. They are both unsequenced 55726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // with respect to other stuff. 55736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(LHS); 55746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(RHS); 55756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinAssign(BinaryOperator *BO) { 55786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // The modification is sequenced after the value computation of the LHS 55796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // and RHS, so check it before inspecting the operands and update the 55806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // map afterwards. 55816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = getObject(BO->getLHS(), true); 55826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!O) 55836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(BO); 55846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreMod(O, BO); 55866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // C++11 [expr.ass]p7: 55886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // E1 op= E2 is equivalent to E1 = E1 op E2, except that E1 is evaluated 55896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // only once. 55906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // 55916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Therefore, for a compound assignment operator, O is considered used 55926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // everywhere except within the evaluation of E1 itself. 55936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (isa<CompoundAssignOperator>(BO)) 55946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreUse(O, BO); 55956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 55976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (isa<CompoundAssignOperator>(BO)) 55996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePostUse(O, BO); 56006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getRHS()); 56026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 5603418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // C++11 [expr.ass]p1: 5604418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // the assignment is sequenced [...] before the value computation of the 5605418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // assignment expression. 5606418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // C11 6.5.16/3 has no such rule. 5607418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith notePostMod(O, BO, SemaRef.getLangOpts().CPlusPlus ? UK_ModAsValue 5608418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith : UK_ModAsSideEffect); 56096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitCompoundAssignOperator(CompoundAssignOperator *CAO) { 56116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith VisitBinAssign(CAO); 56126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPreInc(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); } 56156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPreDec(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); } 56166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPreIncDec(UnaryOperator *UO) { 56176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = getObject(UO->getSubExpr(), true); 56186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!O) 56196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(UO); 56206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreMod(O, UO); 56226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(UO->getSubExpr()); 5623418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // C++11 [expr.pre.incr]p1: 5624418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // the expression ++x is equivalent to x+=1 5625418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith notePostMod(O, UO, SemaRef.getLangOpts().CPlusPlus ? UK_ModAsValue 5626418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith : UK_ModAsSideEffect); 56276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPostInc(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); } 56306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPostDec(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); } 56316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPostIncDec(UnaryOperator *UO) { 56326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = getObject(UO->getSubExpr(), true); 56336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!O) 56346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(UO); 56356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreMod(O, UO); 56376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(UO->getSubExpr()); 56386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePostMod(O, UO, UK_ModAsSideEffect); 56396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Don't visit the RHS of '&&' or '||' if it might not be evaluated. 56426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinLOr(BinaryOperator *BO) { 56436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // The side-effects of the LHS of an '&&' are sequenced before the 56446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // value computation of the RHS, and hence before the value computation 56456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // of the '&&' itself, unless the LHS evaluates to zero. We treat them 56466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // as if they were unconditionally sequenced. 5647674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker Eval(*this); 56486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith { 56496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression Sequenced(*this); 56506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 56516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Result; 5654674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (Eval.evaluate(BO->getLHS(), Result)) { 5655995e4a7530d705147c875b63608532c483c011a8Richard Smith if (!Result) 5656995e4a7530d705147c875b63608532c483c011a8Richard Smith Visit(BO->getRHS()); 5657995e4a7530d705147c875b63608532c483c011a8Richard Smith } else { 5658995e4a7530d705147c875b63608532c483c011a8Richard Smith // Check for unsequenced operations in the RHS, treating it as an 5659995e4a7530d705147c875b63608532c483c011a8Richard Smith // entirely separate evaluation. 5660995e4a7530d705147c875b63608532c483c011a8Richard Smith // 5661995e4a7530d705147c875b63608532c483c011a8Richard Smith // FIXME: If there are operations in the RHS which are unsequenced 5662995e4a7530d705147c875b63608532c483c011a8Richard Smith // with respect to operations outside the RHS, and those operations 5663995e4a7530d705147c875b63608532c483c011a8Richard Smith // are unconditionally evaluated, diagnose them. 56641a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(BO->getRHS()); 5665995e4a7530d705147c875b63608532c483c011a8Richard Smith } 56666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinLAnd(BinaryOperator *BO) { 5668674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker Eval(*this); 56696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith { 56706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression Sequenced(*this); 56716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 56726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Result; 5675674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (Eval.evaluate(BO->getLHS(), Result)) { 5676995e4a7530d705147c875b63608532c483c011a8Richard Smith if (Result) 5677995e4a7530d705147c875b63608532c483c011a8Richard Smith Visit(BO->getRHS()); 5678995e4a7530d705147c875b63608532c483c011a8Richard Smith } else { 56791a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(BO->getRHS()); 5680995e4a7530d705147c875b63608532c483c011a8Richard Smith } 56816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Only visit the condition, unless we can be sure which subexpression will 56846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // be chosen. 56856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitAbstractConditionalOperator(AbstractConditionalOperator *CO) { 5686674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker Eval(*this); 5687418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith { 5688418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith SequencedSubexpression Sequenced(*this); 5689418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith Visit(CO->getCond()); 5690418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith } 56916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Result; 5693674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (Eval.evaluate(CO->getCond(), Result)) 56946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(Result ? CO->getTrueExpr() : CO->getFalseExpr()); 5695995e4a7530d705147c875b63608532c483c011a8Richard Smith else { 56961a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(CO->getTrueExpr()); 56971a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(CO->getFalseExpr()); 5698995e4a7530d705147c875b63608532c483c011a8Richard Smith } 56996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57010c0b3909d11de7440d77556089516918b9c04cefRichard Smith void VisitCallExpr(CallExpr *CE) { 57020c0b3909d11de7440d77556089516918b9c04cefRichard Smith // C++11 [intro.execution]p15: 57030c0b3909d11de7440d77556089516918b9c04cefRichard Smith // When calling a function [...], every value computation and side effect 57040c0b3909d11de7440d77556089516918b9c04cefRichard Smith // associated with any argument expression, or with the postfix expression 57050c0b3909d11de7440d77556089516918b9c04cefRichard Smith // designating the called function, is sequenced before execution of every 57060c0b3909d11de7440d77556089516918b9c04cefRichard Smith // expression or statement in the body of the function [and thus before 57070c0b3909d11de7440d77556089516918b9c04cefRichard Smith // the value computation of its result]. 57080c0b3909d11de7440d77556089516918b9c04cefRichard Smith SequencedSubexpression Sequenced(*this); 57090c0b3909d11de7440d77556089516918b9c04cefRichard Smith Base::VisitCallExpr(CE); 57100c0b3909d11de7440d77556089516918b9c04cefRichard Smith 57110c0b3909d11de7440d77556089516918b9c04cefRichard Smith // FIXME: CXXNewExpr and CXXDeleteExpr implicitly call functions. 57120c0b3909d11de7440d77556089516918b9c04cefRichard Smith } 57130c0b3909d11de7440d77556089516918b9c04cefRichard Smith 57146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitCXXConstructExpr(CXXConstructExpr *CCE) { 57150c0b3909d11de7440d77556089516918b9c04cefRichard Smith // This is a call, so all subexpressions are sequenced before the result. 57160c0b3909d11de7440d77556089516918b9c04cefRichard Smith SequencedSubexpression Sequenced(*this); 57170c0b3909d11de7440d77556089516918b9c04cefRichard Smith 57186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!CCE->isListInitialization()) 57196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(CCE); 57206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // In C++11, list initializations are sequenced. 57226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<SequenceTree::Seq, 32> Elts; 57236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Parent = Region; 57246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (CXXConstructExpr::arg_iterator I = CCE->arg_begin(), 57256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith E = CCE->arg_end(); 57266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith I != E; ++I) { 57276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Tree.allocate(Parent); 57286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Elts.push_back(Region); 57296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(*I); 57306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Forget that the initializers are sequenced. 57336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Parent; 57346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0; I < Elts.size(); ++I) 57356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(Elts[I]); 57366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitInitListExpr(InitListExpr *ILE) { 57396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!SemaRef.getLangOpts().CPlusPlus11) 57406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(ILE); 57416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // In C++11, list initializations are sequenced. 57436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<SequenceTree::Seq, 32> Elts; 57446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Parent = Region; 57456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0; I < ILE->getNumInits(); ++I) { 57466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *E = ILE->getInit(I); 57476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!E) continue; 57486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Tree.allocate(Parent); 57496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Elts.push_back(Region); 57506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(E); 57516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Forget that the initializers are sequenced. 57546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Parent; 57556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0; I < Elts.size(); ++I) 57566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(Elts[I]); 57576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith}; 57596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith} 57606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithvoid Sema::CheckUnsequencedOperations(Expr *E) { 57621a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith llvm::SmallVector<Expr*, 8> WorkList; 57631a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(E); 57641a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith while (!WorkList.empty()) { 57651a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith Expr *Item = WorkList.back(); 57661a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.pop_back(); 57671a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith SequenceChecker(*this, Item, WorkList); 57681a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith } 57696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith} 57706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 5771ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanianvoid Sema::CheckCompletedExpr(Expr *E, SourceLocation CheckLoc, 5772ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian bool IsConstexpr) { 57736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith CheckImplicitConversions(E, CheckLoc); 57746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith CheckUnsequencedOperations(E); 5775ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian if (!IsConstexpr && !E->isValueDependent()) 5776ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian CheckForIntOverflow(E); 57776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith} 57786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 577915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 578015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall FieldDecl *BitField, 578115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *Init) { 578215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 578315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 578415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 5785f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given 5786f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This 5787f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the 5788f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function 5789f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete. 57908c0501c7370d894a735692b92fab62bbb05d86bdReid Klecknerbool Sema::CheckParmsForFunctionDef(ParmVarDecl *const *P, 57918c0501c7370d894a735692b92fab62bbb05d86bdReid Kleckner ParmVarDecl *const *PEnd, 579282aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor bool CheckParameterNames) { 5793f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump bool HasInvalidParm = false; 579482aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor for (; P != PEnd; ++P) { 579582aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor ParmVarDecl *Param = *P; 579682aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor 5797f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.7.5.3p4: the parameters in a parameter type list in a 5798f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // function declarator that is part of a function definition of 5799f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // that function shall not have incomplete type. 5800f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // 5801f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // This is also C++ [dcl.fct]p6. 5802f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump if (!Param->isInvalidDecl() && 5803f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump RequireCompleteType(Param->getLocation(), Param->getType(), 5804d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor diag::err_typecheck_decl_incomplete_type)) { 5805f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Param->setInvalidDecl(); 5806f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump HasInvalidParm = true; 5807f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 5808f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 5809f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.9.1p5: If the declarator includes a parameter type list, the 5810f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // declaration of each parameter shall include an identifier. 581182aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor if (CheckParameterNames && 581282aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor Param->getIdentifier() == 0 && 5813f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !Param->isImplicit() && 58144e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie !getLangOpts().CPlusPlus) 5815f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Diag(Param->getLocation(), diag::err_parameter_name_omitted); 5816d17e340e2d516139931768697bf080f60920ba9dSam Weinig 5817d17e340e2d516139931768697bf080f60920ba9dSam Weinig // C99 6.7.5.3p12: 5818d17e340e2d516139931768697bf080f60920ba9dSam Weinig // If the function declarator is not part of a definition of that 5819d17e340e2d516139931768697bf080f60920ba9dSam Weinig // function, parameters may have incomplete type and may use the [*] 5820d17e340e2d516139931768697bf080f60920ba9dSam Weinig // notation in their sequences of declarator specifiers to specify 5821d17e340e2d516139931768697bf080f60920ba9dSam Weinig // variable length array types. 5822d17e340e2d516139931768697bf080f60920ba9dSam Weinig QualType PType = Param->getOriginalType(); 5823d237d2e6b85a74f31c986dc585fa6c39733b74a2Fariborz Jahanian while (const ArrayType *AT = Context.getAsArrayType(PType)) { 5824d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (AT->getSizeModifier() == ArrayType::Star) { 5825fc09336a5965040736f9bc63a70416003972364eStefanus Du Toit // FIXME: This diagnostic should point the '[*]' if source-location 5826d17e340e2d516139931768697bf080f60920ba9dSam Weinig // information is added for it. 5827d17e340e2d516139931768697bf080f60920ba9dSam Weinig Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 5828d237d2e6b85a74f31c986dc585fa6c39733b74a2Fariborz Jahanian break; 5829d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 5830d237d2e6b85a74f31c986dc585fa6c39733b74a2Fariborz Jahanian PType= AT->getElementType(); 5831d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 58329b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner 58339b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner // MSVC destroys objects passed by value in the callee. Therefore a 58349b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner // function definition which takes such a parameter must be able to call the 58359b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner // object's destructor. 58369b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner if (getLangOpts().CPlusPlus && 58379b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner Context.getTargetInfo().getCXXABI().isArgumentDestroyedByCallee()) { 58389b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner if (const RecordType *RT = Param->getType()->getAs<RecordType>()) 58399b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner FinalizeVarWithDestructor(Param, RT); 58409b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner } 5841f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 5842f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 5843f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump return HasInvalidParm; 5844f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump} 5845b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5846b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a 5847b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements. 5848b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 5849b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // This is actually a lot of work to potentially be doing on every 5850b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // cast; don't do it if we're ignoring -Wcast_align (as is the default). 58510827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align, 58520827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis TRange.getBegin()) 5853d6471f7c1921c7802804ce3ff6fe9768310f72b9David Blaikie == DiagnosticsEngine::Ignored) 5854b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 5855b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5856b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Ignore dependent types. 5857b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (T->isDependentType() || Op->getType()->isDependentType()) 5858b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 5859b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5860b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the destination be a pointer type. 5861b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *DestPtr = T->getAs<PointerType>(); 5862b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!DestPtr) return; 5863b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5864b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // If the destination has alignment 1, we're done. 5865b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType DestPointee = DestPtr->getPointeeType(); 5866b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestPointee->isIncompleteType()) return; 5867b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 5868b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestAlign.isOne()) return; 5869b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5870b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the source be a pointer type. 5871b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 5872b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!SrcPtr) return; 5873b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType SrcPointee = SrcPtr->getPointeeType(); 5874b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5875b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Whitelist casts from cv void*. We already implicitly 5876b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // whitelisted casts to cv void*, since they have alignment 1. 5877b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Also whitelist casts involving incomplete types, which implicitly 5878b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // includes 'void'. 5879b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcPointee->isIncompleteType()) return; 5880b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5881b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 5882b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcAlign >= DestAlign) return; 5883b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5884b7f4ffe073fa419613946461a2583ba2fcb72280John McCall Diag(TRange.getBegin(), diag::warn_cast_align) 5885b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << Op->getType() << T 5886b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(SrcAlign.getQuantity()) 5887b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(DestAlign.getQuantity()) 5888b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << TRange << Op->getSourceRange(); 5889b7f4ffe073fa419613946461a2583ba2fcb72280John McCall} 5890b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5891d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainstatic const Type* getElementType(const Expr *BaseExpr) { 5892d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* EltType = BaseExpr->getType().getTypePtr(); 5893d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (EltType->isAnyPointerType()) 5894d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getPointeeType().getTypePtr(); 5895d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain else if (EltType->isArrayType()) 5896d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getBaseElementTypeUnsafe(); 5897d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType; 5898d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain} 5899d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5900c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// \brief Check whether this array fits the idiom of a size-one tail padded 5901c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// array member of a struct. 5902c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// 5903c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// We avoid emitting out-of-bounds access warnings for such arrays as they are 5904c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// commonly used to emulate flexible arrays in C89 code. 5905c268434b332bbe57950d977633369bf5822d9554Chandler Carruthstatic bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size, 5906c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const NamedDecl *ND) { 5907c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (Size != 1 || !ND) return false; 5908c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5909c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const FieldDecl *FD = dyn_cast<FieldDecl>(ND); 5910c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!FD) return false; 5911c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5912c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // Don't consider sizes resulting from macro expansions or template argument 5913c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // substitution to form C89 tail-padded arrays. 5914d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan 5915d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan TypeSourceInfo *TInfo = FD->getTypeSourceInfo(); 591600e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek while (TInfo) { 591700e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek TypeLoc TL = TInfo->getTypeLoc(); 591800e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek // Look through typedefs. 591939e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie if (TypedefTypeLoc TTL = TL.getAs<TypedefTypeLoc>()) { 592039e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie const TypedefNameDecl *TDL = TTL.getTypedefNameDecl(); 592100e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek TInfo = TDL->getTypeSourceInfo(); 592200e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek continue; 592300e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek } 592439e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie if (ConstantArrayTypeLoc CTL = TL.getAs<ConstantArrayTypeLoc>()) { 592539e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie const Expr *SizeExpr = dyn_cast<IntegerLiteral>(CTL.getSizeExpr()); 59265e25301c24c92a9b7018cee20e524c4eb7192bf0Chad Rosier if (!SizeExpr || SizeExpr->getExprLoc().isMacroID()) 59275e25301c24c92a9b7018cee20e524c4eb7192bf0Chad Rosier return false; 59285e25301c24c92a9b7018cee20e524c4eb7192bf0Chad Rosier } 592900e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek break; 5930d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan } 5931c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5932c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext()); 5933381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!RD) return false; 5934381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (RD->isUnion()) return false; 5935381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) { 5936381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!CRD->isStandardLayout()) return false; 5937381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay } 5938c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 593922d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer // See if this is the last field decl in the record. 594022d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer const Decl *D = FD; 594122d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer while ((D = D->getNextDeclInContext())) 594222d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer if (isa<FieldDecl>(D)) 594322d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return false; 594422d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return true; 5945c268434b332bbe57950d977633369bf5822d9554Chandler Carruth} 5946c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5947d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainvoid Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr, 594880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const ArraySubscriptExpr *ASE, 594925b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith bool AllowOnePastEnd, bool IndexNegated) { 595092b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman IndexExpr = IndexExpr->IgnoreParenImpCasts(); 595180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (IndexExpr->isValueDependent()) 595280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 5953d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 595480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const Type *EffectiveType = getElementType(BaseExpr); 595580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay BaseExpr = BaseExpr->IgnoreParenCasts(); 59563406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const ConstantArrayType *ArrayTy = 5957d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain Context.getAsConstantArrayType(BaseExpr->getType()); 59583406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (!ArrayTy) 5959a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 596035001ca261f895817916b468379b696d6d45959dChandler Carruth 59613406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth llvm::APSInt index; 596280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!IndexExpr->EvaluateAsInt(index, Context)) 5963a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 596425b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith if (IndexNegated) 596525b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith index = -index; 59668fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek 5967ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth const NamedDecl *ND = NULL; 5968ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 5969ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(DRE->getDecl()); 5970c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 5971ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 5972ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 59739e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek if (index.isUnsigned() || !index.isNegative()) { 597425b3b849e3ad340b04442707038c86980035765bTed Kremenek llvm::APInt size = ArrayTy->getSize(); 597535001ca261f895817916b468379b696d6d45959dChandler Carruth if (!size.isStrictlyPositive()) 597635001ca261f895817916b468379b696d6d45959dChandler Carruth return; 5977d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5978d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* BaseType = getElementType(BaseExpr); 5979de5998f1d7dcecb777257ec932142d65de636eb8Nico Weber if (BaseType != EffectiveType) { 5980d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Make sure we're comparing apples to apples when comparing index to size 5981d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType); 5982d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t array_typesize = Context.getTypeSize(BaseType); 5983d10f4bc5a05ce0cdc1646dbb0f706bb9d3dfc0c5Kaelyn Uhrain // Handle ptrarith_typesize being zero, such as when casting to void* 598418f169770d9d3f826bad8f1359c8c5770c5ab16fKaelyn Uhrain if (!ptrarith_typesize) ptrarith_typesize = 1; 5985d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize != array_typesize) { 5986d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // There's a cast to a different size type involved 5987d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ratio = array_typesize / ptrarith_typesize; 5988d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // TODO: Be smarter about handling cases where array_typesize is not a 5989d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // multiple of ptrarith_typesize 5990d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize * ratio == array_typesize) 5991d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain size *= llvm::APInt(size.getBitWidth(), ratio); 5992d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 5993d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 5994d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 59953406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (size.getBitWidth() > index.getBitWidth()) 599692b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman index = index.zext(size.getBitWidth()); 599725b3b849e3ad340b04442707038c86980035765bTed Kremenek else if (size.getBitWidth() < index.getBitWidth()) 599892b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman size = size.zext(index.getBitWidth()); 599925b3b849e3ad340b04442707038c86980035765bTed Kremenek 6000d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // For array subscripting the index must be less than size, but for pointer 6001d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // arithmetic also allow the index (offset) to be equal to size since 6002d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // computing the next address after the end of the array is legal and 6003d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // commonly done e.g. in C++ iterators and range-based for loops. 600492b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman if (AllowOnePastEnd ? index.ule(size) : index.ult(size)) 6005ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth return; 6006ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 6007ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // Also don't warn for arrays of size 1 which are members of some 6008ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // structure. These are often used to approximate flexible arrays in C89 6009ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // code. 6010d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (IsTailPaddedMemberArray(*this, size, ND)) 60118fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek return; 60123406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth 601380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // Suppress the warning if the subscript expression (as identified by the 601480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // ']' location) and the index expression are both from macro expansions 601580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // within a system header. 601680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) { 601780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation RBracketLoc = SourceMgr.getSpellingLoc( 601880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay ASE->getRBracketLoc()); 601980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isInSystemHeader(RBracketLoc)) { 602080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation IndexLoc = SourceMgr.getSpellingLoc( 602180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay IndexExpr->getLocStart()); 602280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isFromSameFile(RBracketLoc, IndexLoc)) 602380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 602480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 602580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 602680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay 6027d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds; 602880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) 6029d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_array_index_exceeds_bounds; 6030d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 6031d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 6032d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 6033d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << size.toString(10, true) 6034d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << (unsigned)size.getLimitedValue(~0U) 6035d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 60363406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth } else { 6037d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_array_index_precedes_bounds; 603880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!ASE) { 6039d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_ptr_arith_precedes_bounds; 6040d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (index.isNegative()) index = -index; 6041d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 6042d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 6043d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 6044d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 6045d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 6046a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek } 604735001ca261f895817916b468379b696d6d45959dChandler Carruth 6048cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (!ND) { 6049cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay // Try harder to find a NamedDecl to point at in the note. 6050cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay while (const ArraySubscriptExpr *ASE = 6051cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay dyn_cast<ArraySubscriptExpr>(BaseExpr)) 6052cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay BaseExpr = ASE->getBase()->IgnoreParenCasts(); 6053cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 6054cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(DRE->getDecl()); 6055cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 6056cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 6057cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay } 6058cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay 605935001ca261f895817916b468379b696d6d45959dChandler Carruth if (ND) 6060d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(ND->getLocStart(), BaseExpr, 6061d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(diag::note_array_index_out_of_bounds) 6062d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << ND->getDeclName()); 60633aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek} 60643aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek 60653aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) { 6066d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain int AllowOnePastEnd = 0; 6067d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain while (expr) { 6068d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = expr->IgnoreParenImpCasts(); 60693aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek switch (expr->getStmtClass()) { 6070d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::ArraySubscriptExprClass: { 6071d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr); 607280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE, 6073d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd > 0); 60743aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 6075d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 6076d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::UnaryOperatorClass: { 6077d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Only unwrap the * and & unary operators 6078d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const UnaryOperator *UO = cast<UnaryOperator>(expr); 6079d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = UO->getSubExpr(); 6080d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain switch (UO->getOpcode()) { 6081d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_AddrOf: 6082d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd++; 6083d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 6084d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_Deref: 6085d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd--; 6086d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 6087d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain default: 6088d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return; 6089d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 6090d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 6091d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 60923aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek case Stmt::ConditionalOperatorClass: { 60933aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek const ConditionalOperator *cond = cast<ConditionalOperator>(expr); 60943aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *lhs = cond->getLHS()) 60953aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(lhs); 60963aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *rhs = cond->getRHS()) 60973aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(rhs); 60983aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 60993aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 61003aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek default: 61013aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 61023aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 6103f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne } 6104a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek} 6105f85e193739c953358c865005855253af4f68a497John McCall 6106f85e193739c953358c865005855253af4f68a497John McCall//===--- CHECK: Objective-C retain cycles ----------------------------------// 6107f85e193739c953358c865005855253af4f68a497John McCall 6108f85e193739c953358c865005855253af4f68a497John McCallnamespace { 6109f85e193739c953358c865005855253af4f68a497John McCall struct RetainCycleOwner { 6110f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner() : Variable(0), Indirect(false) {} 6111f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 6112f85e193739c953358c865005855253af4f68a497John McCall SourceRange Range; 6113f85e193739c953358c865005855253af4f68a497John McCall SourceLocation Loc; 6114f85e193739c953358c865005855253af4f68a497John McCall bool Indirect; 6115f85e193739c953358c865005855253af4f68a497John McCall 6116f85e193739c953358c865005855253af4f68a497John McCall void setLocsFrom(Expr *e) { 6117f85e193739c953358c865005855253af4f68a497John McCall Loc = e->getExprLoc(); 6118f85e193739c953358c865005855253af4f68a497John McCall Range = e->getSourceRange(); 6119f85e193739c953358c865005855253af4f68a497John McCall } 6120f85e193739c953358c865005855253af4f68a497John McCall }; 6121f85e193739c953358c865005855253af4f68a497John McCall} 6122f85e193739c953358c865005855253af4f68a497John McCall 6123f85e193739c953358c865005855253af4f68a497John McCall/// Consider whether capturing the given variable can possibly lead to 6124f85e193739c953358c865005855253af4f68a497John McCall/// a retain cycle. 6125f85e193739c953358c865005855253af4f68a497John McCallstatic bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) { 6126f3477c13eeaf11b32a41f181398fb5deffd0dd73Sylvestre Ledru // In ARC, it's captured strongly iff the variable has __strong 6127f85e193739c953358c865005855253af4f68a497John McCall // lifetime. In MRR, it's captured strongly if the variable is 6128f85e193739c953358c865005855253af4f68a497John McCall // __block and has an appropriate type. 6129f85e193739c953358c865005855253af4f68a497John McCall if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 6130f85e193739c953358c865005855253af4f68a497John McCall return false; 6131f85e193739c953358c865005855253af4f68a497John McCall 6132f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = var; 6133e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose if (ref) 6134e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose owner.setLocsFrom(ref); 6135f85e193739c953358c865005855253af4f68a497John McCall return true; 6136f85e193739c953358c865005855253af4f68a497John McCall} 6137f85e193739c953358c865005855253af4f68a497John McCall 61386e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanianstatic bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) { 6139f85e193739c953358c865005855253af4f68a497John McCall while (true) { 6140f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParens(); 6141f85e193739c953358c865005855253af4f68a497John McCall if (CastExpr *cast = dyn_cast<CastExpr>(e)) { 6142f85e193739c953358c865005855253af4f68a497John McCall switch (cast->getCastKind()) { 6143f85e193739c953358c865005855253af4f68a497John McCall case CK_BitCast: 6144f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueBitCast: 6145f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueToRValue: 614633e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall case CK_ARCReclaimReturnedObject: 6147f85e193739c953358c865005855253af4f68a497John McCall e = cast->getSubExpr(); 6148f85e193739c953358c865005855253af4f68a497John McCall continue; 6149f85e193739c953358c865005855253af4f68a497John McCall 6150f85e193739c953358c865005855253af4f68a497John McCall default: 6151f85e193739c953358c865005855253af4f68a497John McCall return false; 6152f85e193739c953358c865005855253af4f68a497John McCall } 6153f85e193739c953358c865005855253af4f68a497John McCall } 6154f85e193739c953358c865005855253af4f68a497John McCall 6155f85e193739c953358c865005855253af4f68a497John McCall if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) { 6156f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar = ref->getDecl(); 6157f85e193739c953358c865005855253af4f68a497John McCall if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 6158f85e193739c953358c865005855253af4f68a497John McCall return false; 6159f85e193739c953358c865005855253af4f68a497John McCall 6160f85e193739c953358c865005855253af4f68a497John McCall // Try to find a retain cycle in the base. 61616e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(S, ref->getBase(), owner)) 6162f85e193739c953358c865005855253af4f68a497John McCall return false; 6163f85e193739c953358c865005855253af4f68a497John McCall 6164f85e193739c953358c865005855253af4f68a497John McCall if (ref->isFreeIvar()) owner.setLocsFrom(ref); 6165f85e193739c953358c865005855253af4f68a497John McCall owner.Indirect = true; 6166f85e193739c953358c865005855253af4f68a497John McCall return true; 6167f85e193739c953358c865005855253af4f68a497John McCall } 6168f85e193739c953358c865005855253af4f68a497John McCall 6169f85e193739c953358c865005855253af4f68a497John McCall if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) { 6170f85e193739c953358c865005855253af4f68a497John McCall VarDecl *var = dyn_cast<VarDecl>(ref->getDecl()); 6171f85e193739c953358c865005855253af4f68a497John McCall if (!var) return false; 6172f85e193739c953358c865005855253af4f68a497John McCall return considerVariable(var, ref, owner); 6173f85e193739c953358c865005855253af4f68a497John McCall } 6174f85e193739c953358c865005855253af4f68a497John McCall 6175f85e193739c953358c865005855253af4f68a497John McCall if (MemberExpr *member = dyn_cast<MemberExpr>(e)) { 6176f85e193739c953358c865005855253af4f68a497John McCall if (member->isArrow()) return false; 6177f85e193739c953358c865005855253af4f68a497John McCall 6178f85e193739c953358c865005855253af4f68a497John McCall // Don't count this as an indirect ownership. 6179f85e193739c953358c865005855253af4f68a497John McCall e = member->getBase(); 6180f85e193739c953358c865005855253af4f68a497John McCall continue; 6181f85e193739c953358c865005855253af4f68a497John McCall } 6182f85e193739c953358c865005855253af4f68a497John McCall 61834b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) { 61844b9c2d235fb9449e249d74f48ecfec601650de93John McCall // Only pay attention to pseudo-objects on property references. 61854b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyRefExpr *pre 61864b9c2d235fb9449e249d74f48ecfec601650de93John McCall = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm() 61874b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->IgnoreParens()); 61884b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!pre) return false; 61894b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (pre->isImplicitProperty()) return false; 61904b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyDecl *property = pre->getExplicitProperty(); 61914b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!property->isRetaining() && 61924b9c2d235fb9449e249d74f48ecfec601650de93John McCall !(property->getPropertyIvarDecl() && 61934b9c2d235fb9449e249d74f48ecfec601650de93John McCall property->getPropertyIvarDecl()->getType() 61944b9c2d235fb9449e249d74f48ecfec601650de93John McCall .getObjCLifetime() == Qualifiers::OCL_Strong)) 61954b9c2d235fb9449e249d74f48ecfec601650de93John McCall return false; 61964b9c2d235fb9449e249d74f48ecfec601650de93John McCall 61974b9c2d235fb9449e249d74f48ecfec601650de93John McCall owner.Indirect = true; 61986e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (pre->isSuperReceiver()) { 61996e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Variable = S.getCurMethodDecl()->getSelfDecl(); 62006e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!owner.Variable) 62016e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return false; 62026e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Loc = pre->getLocation(); 62036e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Range = pre->getSourceRange(); 62046e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return true; 62056e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian } 62064b9c2d235fb9449e249d74f48ecfec601650de93John McCall e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase()) 62074b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->getSourceExpr()); 62084b9c2d235fb9449e249d74f48ecfec601650de93John McCall continue; 62094b9c2d235fb9449e249d74f48ecfec601650de93John McCall } 62104b9c2d235fb9449e249d74f48ecfec601650de93John McCall 6211f85e193739c953358c865005855253af4f68a497John McCall // Array ivars? 6212f85e193739c953358c865005855253af4f68a497John McCall 6213f85e193739c953358c865005855253af4f68a497John McCall return false; 6214f85e193739c953358c865005855253af4f68a497John McCall } 6215f85e193739c953358c865005855253af4f68a497John McCall} 6216f85e193739c953358c865005855253af4f68a497John McCall 6217f85e193739c953358c865005855253af4f68a497John McCallnamespace { 6218f85e193739c953358c865005855253af4f68a497John McCall struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> { 6219f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor(ASTContext &Context, VarDecl *variable) 6220f85e193739c953358c865005855253af4f68a497John McCall : EvaluatedExprVisitor<FindCaptureVisitor>(Context), 6221f85e193739c953358c865005855253af4f68a497John McCall Variable(variable), Capturer(0) {} 6222f85e193739c953358c865005855253af4f68a497John McCall 6223f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 6224f85e193739c953358c865005855253af4f68a497John McCall Expr *Capturer; 6225f85e193739c953358c865005855253af4f68a497John McCall 6226f85e193739c953358c865005855253af4f68a497John McCall void VisitDeclRefExpr(DeclRefExpr *ref) { 6227f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 6228f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 6229f85e193739c953358c865005855253af4f68a497John McCall } 6230f85e193739c953358c865005855253af4f68a497John McCall 6231f85e193739c953358c865005855253af4f68a497John McCall void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) { 6232f85e193739c953358c865005855253af4f68a497John McCall if (Capturer) return; 6233f85e193739c953358c865005855253af4f68a497John McCall Visit(ref->getBase()); 6234f85e193739c953358c865005855253af4f68a497John McCall if (Capturer && ref->isFreeIvar()) 6235f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 6236f85e193739c953358c865005855253af4f68a497John McCall } 6237f85e193739c953358c865005855253af4f68a497John McCall 6238f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockExpr(BlockExpr *block) { 6239f85e193739c953358c865005855253af4f68a497John McCall // Look inside nested blocks 6240f85e193739c953358c865005855253af4f68a497John McCall if (block->getBlockDecl()->capturesVariable(Variable)) 6241f85e193739c953358c865005855253af4f68a497John McCall Visit(block->getBlockDecl()->getBody()); 6242f85e193739c953358c865005855253af4f68a497John McCall } 62437e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian 62447e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian void VisitOpaqueValueExpr(OpaqueValueExpr *OVE) { 62457e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian if (Capturer) return; 62467e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian if (OVE->getSourceExpr()) 62477e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian Visit(OVE->getSourceExpr()); 62487e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian } 6249f85e193739c953358c865005855253af4f68a497John McCall }; 6250f85e193739c953358c865005855253af4f68a497John McCall} 6251f85e193739c953358c865005855253af4f68a497John McCall 6252f85e193739c953358c865005855253af4f68a497John McCall/// Check whether the given argument is a block which captures a 6253f85e193739c953358c865005855253af4f68a497John McCall/// variable. 6254f85e193739c953358c865005855253af4f68a497John McCallstatic Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) { 6255f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 6256f85e193739c953358c865005855253af4f68a497John McCall 6257f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParenCasts(); 62581fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose 62591fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose // Look through [^{...} copy] and Block_copy(^{...}). 62601fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (ObjCMessageExpr *ME = dyn_cast<ObjCMessageExpr>(e)) { 62611fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose Selector Cmd = ME->getSelector(); 62621fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (Cmd.isUnarySelector() && Cmd.getNameForSlot(0) == "copy") { 62631fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose e = ME->getInstanceReceiver(); 62641fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (!e) 62651fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose return 0; 62661fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose e = e->IgnoreParenCasts(); 62671fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } 62681fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } else if (CallExpr *CE = dyn_cast<CallExpr>(e)) { 62691fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (CE->getNumArgs() == 1) { 62701fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose FunctionDecl *Fn = dyn_cast_or_null<FunctionDecl>(CE->getCalleeDecl()); 6271d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek if (Fn) { 6272d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek const IdentifierInfo *FnI = Fn->getIdentifier(); 6273d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek if (FnI && FnI->isStr("_Block_copy")) { 6274d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek e = CE->getArg(0)->IgnoreParenCasts(); 6275d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek } 6276d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek } 62771fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } 62781fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } 62791fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose 6280f85e193739c953358c865005855253af4f68a497John McCall BlockExpr *block = dyn_cast<BlockExpr>(e); 6281f85e193739c953358c865005855253af4f68a497John McCall if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable)) 6282f85e193739c953358c865005855253af4f68a497John McCall return 0; 6283f85e193739c953358c865005855253af4f68a497John McCall 6284f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor visitor(S.Context, owner.Variable); 6285f85e193739c953358c865005855253af4f68a497John McCall visitor.Visit(block->getBlockDecl()->getBody()); 6286f85e193739c953358c865005855253af4f68a497John McCall return visitor.Capturer; 6287f85e193739c953358c865005855253af4f68a497John McCall} 6288f85e193739c953358c865005855253af4f68a497John McCall 6289f85e193739c953358c865005855253af4f68a497John McCallstatic void diagnoseRetainCycle(Sema &S, Expr *capturer, 6290f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner &owner) { 6291f85e193739c953358c865005855253af4f68a497John McCall assert(capturer); 6292f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 6293f85e193739c953358c865005855253af4f68a497John McCall 6294f85e193739c953358c865005855253af4f68a497John McCall S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle) 6295f85e193739c953358c865005855253af4f68a497John McCall << owner.Variable << capturer->getSourceRange(); 6296f85e193739c953358c865005855253af4f68a497John McCall S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner) 6297f85e193739c953358c865005855253af4f68a497John McCall << owner.Indirect << owner.Range; 6298f85e193739c953358c865005855253af4f68a497John McCall} 6299f85e193739c953358c865005855253af4f68a497John McCall 6300f85e193739c953358c865005855253af4f68a497John McCall/// Check for a keyword selector that starts with the word 'add' or 6301f85e193739c953358c865005855253af4f68a497John McCall/// 'set'. 6302f85e193739c953358c865005855253af4f68a497John McCallstatic bool isSetterLikeSelector(Selector sel) { 6303f85e193739c953358c865005855253af4f68a497John McCall if (sel.isUnarySelector()) return false; 6304f85e193739c953358c865005855253af4f68a497John McCall 63055f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef str = sel.getNameForSlot(0); 6306f85e193739c953358c865005855253af4f68a497John McCall while (!str.empty() && str.front() == '_') str = str.substr(1); 6307968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (str.startswith("set")) 6308f85e193739c953358c865005855253af4f68a497John McCall str = str.substr(3); 6309968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek else if (str.startswith("add")) { 6310968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek // Specially whitelist 'addOperationWithBlock:'. 6311968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock")) 6312968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek return false; 6313968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek str = str.substr(3); 6314968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek } 6315f85e193739c953358c865005855253af4f68a497John McCall else 6316f85e193739c953358c865005855253af4f68a497John McCall return false; 6317f85e193739c953358c865005855253af4f68a497John McCall 6318f85e193739c953358c865005855253af4f68a497John McCall if (str.empty()) return true; 63193f6f51e28231f65de9c2dd150a2d757b2162cfa3Jordan Rose return !isLowercase(str.front()); 6320f85e193739c953358c865005855253af4f68a497John McCall} 6321f85e193739c953358c865005855253af4f68a497John McCall 6322f85e193739c953358c865005855253af4f68a497John McCall/// Check a message send to see if it's likely to cause a retain cycle. 6323f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(ObjCMessageExpr *msg) { 6324f85e193739c953358c865005855253af4f68a497John McCall // Only check instance methods whose selector looks like a setter. 6325f85e193739c953358c865005855253af4f68a497John McCall if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector())) 6326f85e193739c953358c865005855253af4f68a497John McCall return; 6327f85e193739c953358c865005855253af4f68a497John McCall 6328f85e193739c953358c865005855253af4f68a497John McCall // Try to find a variable that the receiver is strongly owned by. 6329f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 6330f85e193739c953358c865005855253af4f68a497John McCall if (msg->getReceiverKind() == ObjCMessageExpr::Instance) { 63316e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner)) 6332f85e193739c953358c865005855253af4f68a497John McCall return; 6333f85e193739c953358c865005855253af4f68a497John McCall } else { 6334f85e193739c953358c865005855253af4f68a497John McCall assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance); 6335f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = getCurMethodDecl()->getSelfDecl(); 6336f85e193739c953358c865005855253af4f68a497John McCall owner.Loc = msg->getSuperLoc(); 6337f85e193739c953358c865005855253af4f68a497John McCall owner.Range = msg->getSuperLoc(); 6338f85e193739c953358c865005855253af4f68a497John McCall } 6339f85e193739c953358c865005855253af4f68a497John McCall 6340f85e193739c953358c865005855253af4f68a497John McCall // Check whether the receiver is captured by any of the arguments. 6341f85e193739c953358c865005855253af4f68a497John McCall for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i) 6342f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner)) 6343f85e193739c953358c865005855253af4f68a497John McCall return diagnoseRetainCycle(*this, capturer, owner); 6344f85e193739c953358c865005855253af4f68a497John McCall} 6345f85e193739c953358c865005855253af4f68a497John McCall 6346f85e193739c953358c865005855253af4f68a497John McCall/// Check a property assign to see if it's likely to cause a retain cycle. 6347f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(Expr *receiver, Expr *argument) { 6348f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 63496e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, receiver, owner)) 6350f85e193739c953358c865005855253af4f68a497John McCall return; 6351f85e193739c953358c865005855253af4f68a497John McCall 6352f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, argument, owner)) 6353f85e193739c953358c865005855253af4f68a497John McCall diagnoseRetainCycle(*this, capturer, owner); 6354f85e193739c953358c865005855253af4f68a497John McCall} 6355f85e193739c953358c865005855253af4f68a497John McCall 6356e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rosevoid Sema::checkRetainCycles(VarDecl *Var, Expr *Init) { 6357e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose RetainCycleOwner Owner; 6358e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose if (!considerVariable(Var, /*DeclRefExpr=*/0, Owner)) 6359e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose return; 6360e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose 6361e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose // Because we don't have an expression for the variable, we have to set the 6362e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose // location explicitly here. 6363e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose Owner.Loc = Var->getLocation(); 6364e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose Owner.Range = Var->getSourceRange(); 6365e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose 6366e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose if (Expr *Capturer = findCapturingExpr(*this, Init, Owner)) 6367e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose diagnoseRetainCycle(*this, Capturer, Owner); 6368e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose} 6369e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose 63709d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenekstatic bool checkUnsafeAssignLiteral(Sema &S, SourceLocation Loc, 63719d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek Expr *RHS, bool isProperty) { 63729d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek // Check if RHS is an Objective-C object literal, which also can get 63739d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek // immediately zapped in a weak reference. Note that we explicitly 63749d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek // allow ObjCStringLiterals, since those are designed to never really die. 63759d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek RHS = RHS->IgnoreParenImpCasts(); 6376f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek 6377d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek // This enum needs to match with the 'select' in 6378d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek // warn_objc_arc_literal_assign (off-by-1). 6379d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek Sema::ObjCLiteralKind Kind = S.CheckLiteralKind(RHS); 6380d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek if (Kind == Sema::LK_String || Kind == Sema::LK_None) 6381d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek return false; 6382f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek 6383f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek S.Diag(Loc, diag::warn_arc_literal_assign) 6384d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek << (unsigned) Kind 63859d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek << (isProperty ? 0 : 1) 63869d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek << RHS->getSourceRange(); 6387f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek 6388f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek return true; 63899d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek} 63909d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek 6391b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenekstatic bool checkUnsafeAssignObject(Sema &S, SourceLocation Loc, 6392b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek Qualifiers::ObjCLifetime LT, 6393b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek Expr *RHS, bool isProperty) { 6394b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek // Strip off any implicit cast added to get to the one ARC-specific. 6395b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 6396b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek if (cast->getCastKind() == CK_ARCConsumeObject) { 6397b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek S.Diag(Loc, diag::warn_arc_retained_assign) 6398b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek << (LT == Qualifiers::OCL_ExplicitNone) 6399b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek << (isProperty ? 0 : 1) 6400b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek << RHS->getSourceRange(); 6401b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek return true; 6402b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek } 6403b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek RHS = cast->getSubExpr(); 6404b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek } 6405b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek 6406b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek if (LT == Qualifiers::OCL_Weak && 6407b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek checkUnsafeAssignLiteral(S, Loc, RHS, isProperty)) 6408b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek return true; 6409b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek 6410b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek return false; 6411b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek} 6412b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek 6413b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenekbool Sema::checkUnsafeAssigns(SourceLocation Loc, 6414b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek QualType LHS, Expr *RHS) { 6415b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime(); 6416b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6417b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone) 6418b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return false; 6419b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6420b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek if (checkUnsafeAssignObject(*this, Loc, LT, RHS, false)) 6421b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return true; 6422b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6423b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return false; 6424b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek} 6425b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6426921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianvoid Sema::checkUnsafeExprAssigns(SourceLocation Loc, 6427921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Expr *LHS, Expr *RHS) { 642887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian QualType LHSType; 642987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // PropertyRef on LHS type need be directly obtained from 643087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // its declaration as it has a PsuedoType. 643187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian ObjCPropertyRefExpr *PRE 643287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens()); 643387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PRE && !PRE->isImplicitProperty()) { 643487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 643587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PD) 643687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType = PD->getType(); 643787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian } 643887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian 643987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (LHSType.isNull()) 644087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType = LHS->getType(); 64417a2704800943fbb69207e125d28186278712af36Jordan Rose 64427a2704800943fbb69207e125d28186278712af36Jordan Rose Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime(); 64437a2704800943fbb69207e125d28186278712af36Jordan Rose 64447a2704800943fbb69207e125d28186278712af36Jordan Rose if (LT == Qualifiers::OCL_Weak) { 64457a2704800943fbb69207e125d28186278712af36Jordan Rose DiagnosticsEngine::Level Level = 64467a2704800943fbb69207e125d28186278712af36Jordan Rose Diags.getDiagnosticLevel(diag::warn_arc_repeated_use_of_weak, Loc); 64477a2704800943fbb69207e125d28186278712af36Jordan Rose if (Level != DiagnosticsEngine::Ignored) 64487a2704800943fbb69207e125d28186278712af36Jordan Rose getCurFunction()->markSafeWeakUse(LHS); 64497a2704800943fbb69207e125d28186278712af36Jordan Rose } 64507a2704800943fbb69207e125d28186278712af36Jordan Rose 6451921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (checkUnsafeAssigns(Loc, LHSType, RHS)) 6452921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 64537a2704800943fbb69207e125d28186278712af36Jordan Rose 6454921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // FIXME. Check for other life times. 6455921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (LT != Qualifiers::OCL_None) 6456921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6457921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 645887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PRE) { 6459921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (PRE->isImplicitProperty()) 6460921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6461921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 6462921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (!PD) 6463921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6464921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 6465ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned Attributes = PD->getPropertyAttributes(); 6466ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) { 646787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // when 'assign' attribute was not explicitly specified 646887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // by user, ignore it and rely on property type itself 646987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // for lifetime info. 647087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten(); 647187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) && 647287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType->isObjCRetainableType()) 647387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian return; 647487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian 6475921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 647633e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 6477921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Diag(Loc, diag::warn_arc_retained_property_assign) 6478921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian << RHS->getSourceRange(); 6479921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6480921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 6481921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 6482921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 648387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian } 6484ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if (Attributes & ObjCPropertyDecl::OBJC_PR_weak) { 6485b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek if (checkUnsafeAssignObject(*this, Loc, Qualifiers::OCL_Weak, RHS, true)) 6486b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return; 6487bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian } 6488921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 6489921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian} 6490625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6491625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko//===--- CHECK: Empty statement body (-Wempty-body) ---------------------===// 6492625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6493625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkonamespace { 6494625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkobool ShouldDiagnoseEmptyStmtBody(const SourceManager &SourceMgr, 6495625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko SourceLocation StmtLoc, 6496625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *Body) { 6497625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do not warn if the body is a macro that expands to nothing, e.g: 6498625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // 6499625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // #define CALL(x) 6500625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // if (condition) 6501625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // CALL(0); 6502625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // 6503625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (Body->hasLeadingEmptyMacro()) 6504625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6505625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6506625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Get line numbers of statement and body. 6507625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool StmtLineInvalid; 6508625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned StmtLine = SourceMgr.getSpellingLineNumber(StmtLoc, 6509625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &StmtLineInvalid); 6510625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtLineInvalid) 6511625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6512625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6513625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool BodyLineInvalid; 6514625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned BodyLine = SourceMgr.getSpellingLineNumber(Body->getSemiLoc(), 6515625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &BodyLineInvalid); 6516625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyLineInvalid) 6517625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6518625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6519625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Warn if null statement and body are on the same line. 6520625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtLine != BodyLine) 6521625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6522625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6523625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return true; 6524625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 6525625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} // Unnamed namespace 6526625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6527625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyStmtBody(SourceLocation StmtLoc, 6528625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *Body, 6529625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned DiagID) { 6530625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Since this is a syntactic check, don't emit diagnostic for template 6531625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // instantiations, this just adds noise. 6532625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (CurrentInstantiationScope) 6533625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6534625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6535625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // The body should be a null statement. 6536625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *NBody = dyn_cast<NullStmt>(Body); 6537625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!NBody) 6538625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6539625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6540625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do the usual checks. 6541625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 6542625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6543625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6544625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), DiagID); 6545625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 6546625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 6547625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6548625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyLoopBody(const Stmt *S, 6549625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *PossibleBody) { 6550625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko assert(!CurrentInstantiationScope); // Ensured by caller 6551625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6552625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko SourceLocation StmtLoc; 6553625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *Body; 6554625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned DiagID; 6555625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (const ForStmt *FS = dyn_cast<ForStmt>(S)) { 6556625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko StmtLoc = FS->getRParenLoc(); 6557625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Body = FS->getBody(); 6558625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagID = diag::warn_empty_for_body; 6559625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } else if (const WhileStmt *WS = dyn_cast<WhileStmt>(S)) { 6560625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko StmtLoc = WS->getCond()->getSourceRange().getEnd(); 6561625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Body = WS->getBody(); 6562625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagID = diag::warn_empty_while_body; 6563625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } else 6564625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; // Neither `for' nor `while'. 6565625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6566625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // The body should be a null statement. 6567625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *NBody = dyn_cast<NullStmt>(Body); 6568625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!NBody) 6569625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6570625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6571625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Skip expensive checks if diagnostic is disabled. 6572625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (Diags.getDiagnosticLevel(DiagID, NBody->getSemiLoc()) == 6573625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagnosticsEngine::Ignored) 6574625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6575625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6576625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do the usual checks. 6577625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 6578625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6579625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6580625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // `for(...);' and `while(...);' are popular idioms, so in order to keep 6581625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // noise level low, emit diagnostics only if for/while is followed by a 6582625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // CompoundStmt, e.g.: 6583625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // for (int i = 0; i < n; i++); 6584625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // { 6585625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // a(i); 6586625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // } 6587625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // or if for/while is followed by a statement with more indentation 6588625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // than for/while itself: 6589625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // for (int i = 0; i < n; i++); 6590625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // a(i); 6591625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool ProbableTypo = isa<CompoundStmt>(PossibleBody); 6592625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ProbableTypo) { 6593625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool BodyColInvalid; 6594625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned BodyCol = SourceMgr.getPresumedColumnNumber( 6595625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko PossibleBody->getLocStart(), 6596625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &BodyColInvalid); 6597625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyColInvalid) 6598625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6599625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6600625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool StmtColInvalid; 6601625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned StmtCol = SourceMgr.getPresumedColumnNumber( 6602625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko S->getLocStart(), 6603625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &StmtColInvalid); 6604625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtColInvalid) 6605625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6606625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6607625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyCol > StmtCol) 6608625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko ProbableTypo = true; 6609625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } 6610625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6611625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (ProbableTypo) { 6612625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), DiagID); 6613625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 6614625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } 6615625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 66160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- Layout compatibility ----------------------------------------------// 66180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 66200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2); 66220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two enumeration types are layout-compatible. 66240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, EnumDecl *ED1, EnumDecl *ED2) { 66250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [dcl.enum] p8: 66260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Two enumeration types are layout-compatible if they have the same 66270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // underlying type. 66280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return ED1->isComplete() && ED2->isComplete() && 66290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko C.hasSameType(ED1->getIntegerType(), ED2->getIntegerType()); 66300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 66310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two fields are layout-compatible. 66330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, FieldDecl *Field1, FieldDecl *Field2) { 66340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, Field1->getType(), Field2->getType())) 66350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1->isBitField() != Field2->isBitField()) 66380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1->isBitField()) { 66410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Make sure that the bit-fields are the same length. 66420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko unsigned Bits1 = Field1->getBitWidthValue(C); 66430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko unsigned Bits2 = Field2->getBitWidthValue(C); 66440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Bits1 != Bits2) 66460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 66480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 66500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 66510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout structs are layout-compatible. 66530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p17) 66540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleStruct(ASTContext &C, 66550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD1, 66560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD2) { 66570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If both records are C++ classes, check that base classes match. 66580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (const CXXRecordDecl *D1CXX = dyn_cast<CXXRecordDecl>(RD1)) { 66590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If one of records is a CXXRecordDecl we are in C++ mode, 66600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // thus the other one is a CXXRecordDecl, too. 66610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const CXXRecordDecl *D2CXX = cast<CXXRecordDecl>(RD2); 66620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check number of base classes. 66630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (D1CXX->getNumBases() != D2CXX->getNumBases()) 66640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check the base classes. 66670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (CXXRecordDecl::base_class_const_iterator 66680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base1 = D1CXX->bases_begin(), 66690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BaseEnd1 = D1CXX->bases_end(), 66700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base2 = D2CXX->bases_begin(); 66710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base1 != BaseEnd1; 66720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ++Base1, ++Base2) { 66730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, Base1->getType(), Base2->getType())) 66740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 66760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else if (const CXXRecordDecl *D2CXX = dyn_cast<CXXRecordDecl>(RD2)) { 66770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If only RD2 is a C++ class, it should have zero base classes. 66780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (D2CXX->getNumBases() > 0) 66790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 66810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check the fields. 66830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl::field_iterator Field2 = RD2->field_begin(), 66840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2End = RD2->field_end(), 66850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1 = RD1->field_begin(), 66860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1End = RD1->field_end(); 66870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for ( ; Field1 != Field1End && Field2 != Field2End; ++Field1, ++Field2) { 66880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, *Field1, *Field2)) 66890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 66910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1 != Field1End || Field2 != Field2End) 66920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 66950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 66960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout unions are layout-compatible. 66980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p18) 66990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleUnion(ASTContext &C, 67000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD1, 67010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD2) { 67020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::SmallPtrSet<FieldDecl *, 8> UnmatchedFields; 67030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (RecordDecl::field_iterator Field2 = RD2->field_begin(), 67040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2End = RD2->field_end(); 67050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2 != Field2End; ++Field2) { 67060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko UnmatchedFields.insert(*Field2); 67070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (RecordDecl::field_iterator Field1 = RD1->field_begin(), 67100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1End = RD1->field_end(); 67110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1 != Field1End; ++Field1) { 67120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::SmallPtrSet<FieldDecl *, 8>::iterator 67130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I = UnmatchedFields.begin(), 67140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko E = UnmatchedFields.end(); 67150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for ( ; I != E; ++I) { 67170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (isLayoutCompatible(C, *Field1, *I)) { 67180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool Result = UnmatchedFields.erase(*I); 67190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (void) Result; 67200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko assert(Result); 67210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko break; 67220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I == E) 67250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return UnmatchedFields.empty(); 67290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 67300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, RecordDecl *RD1, RecordDecl *RD2) { 67320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (RD1->isUnion() != RD2->isUnion()) 67330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (RD1->isUnion()) 67360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatibleUnion(C, RD1, RD2); 67370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 67380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatibleStruct(C, RD1, RD2); 67390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 67400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two types are layout-compatible in C++11 sense. 67420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2) { 67430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (T1.isNull() || T2.isNull()) 67440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [basic.types] p11: 67470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If two types T1 and T2 are the same type, then T1 and T2 are 67480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // layout-compatible types. 67490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (C.hasSameType(T1, T2)) 67500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 67510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko T1 = T1.getCanonicalType().getUnqualifiedType(); 67530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko T2 = T2.getCanonicalType().getUnqualifiedType(); 67540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Type::TypeClass TC1 = T1->getTypeClass(); 67560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Type::TypeClass TC2 = T2->getTypeClass(); 67570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TC1 != TC2) 67590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TC1 == Type::Enum) { 67620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatible(C, 67630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<EnumType>(T1)->getDecl(), 67640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<EnumType>(T2)->getDecl()); 67650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else if (TC1 == Type::Record) { 67660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!T1->isStandardLayoutType() || !T2->isStandardLayoutType()) 67670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatible(C, 67700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<RecordType>(T1)->getDecl(), 67710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<RecordType>(T2)->getDecl()); 67720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 67760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 67770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- CHECK: pointer_with_type_tag attribute: datatypes should match ----// 67790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 67810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Given a type tag expression find the type tag itself. 67820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 67830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Type tag expression, as it appears in user's code. 67840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 67850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param VD Declaration of an identifier that appears in a type tag. 67860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 67870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValue Type tag magic value. 67880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool FindTypeTagExpr(const Expr *TypeExpr, const ASTContext &Ctx, 67890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const ValueDecl **VD, uint64_t *MagicValue) { 67900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko while(true) { 67910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeExpr) 67920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = TypeExpr->IgnoreParenImpCasts()->IgnoreParenCasts(); 67950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko switch (TypeExpr->getStmtClass()) { 67970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::UnaryOperatorClass: { 67980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const UnaryOperator *UO = cast<UnaryOperator>(TypeExpr); 67990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (UO->getOpcode() == UO_AddrOf || UO->getOpcode() == UO_Deref) { 68000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = UO->getSubExpr(); 68010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 68020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::DeclRefExprClass: { 68070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const DeclRefExpr *DRE = cast<DeclRefExpr>(TypeExpr); 68080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko *VD = DRE->getDecl(); 68090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 68100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::IntegerLiteralClass: { 68130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IntegerLiteral *IL = cast<IntegerLiteral>(TypeExpr); 68140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::APInt MagicValueAPInt = IL->getValue(); 68150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (MagicValueAPInt.getActiveBits() <= 64) { 68160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko *MagicValue = MagicValueAPInt.getZExtValue(); 68170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 68180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else 68190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::BinaryConditionalOperatorClass: 68230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::ConditionalOperatorClass: { 68240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const AbstractConditionalOperator *ACO = 68250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<AbstractConditionalOperator>(TypeExpr); 68260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool Result; 68270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (ACO->getCond()->EvaluateAsBooleanCondition(Result, Ctx)) { 68280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Result) 68290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = ACO->getTrueExpr(); 68300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 68310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = ACO->getFalseExpr(); 68320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 68330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::BinaryOperatorClass: { 68380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BinaryOperator *BO = cast<BinaryOperator>(TypeExpr); 68390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (BO->getOpcode() == BO_Comma) { 68400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = BO->getRHS(); 68410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 68420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko default: 68470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 68510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Retrieve the C type corresponding to type tag TypeExpr. 68530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 68540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Expression that specifies a type tag. 68550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 68560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValues Registered magic values. 68570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 68580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param FoundWrongKind Set to true if a type tag was found, but of a wrong 68590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// kind. 68600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 68610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeInfo Information about the corresponding C type. 68620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 68630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \returns true if the corresponding C type was found. 68640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool GetMatchingCType( 68650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IdentifierInfo *ArgumentKind, 68660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *TypeExpr, const ASTContext &Ctx, 68670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const llvm::DenseMap<Sema::TypeTagMagicValue, 68680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData> *MagicValues, 68690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool &FoundWrongKind, 68700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData &TypeInfo) { 68710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind = false; 68720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Variable declaration that has type_tag_for_datatype attribute. 68740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const ValueDecl *VD = NULL; 68750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko uint64_t MagicValue; 68770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!FindTypeTagExpr(TypeExpr, Ctx, &VD, &MagicValue)) 68790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (VD) { 68820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (specific_attr_iterator<TypeTagForDatatypeAttr> 68830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I = VD->specific_attr_begin<TypeTagForDatatypeAttr>(), 68840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko E = VD->specific_attr_end<TypeTagForDatatypeAttr>(); 68850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I != E; ++I) { 68860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I->getArgumentKind() != ArgumentKind) { 68870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind = true; 68880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.Type = I->getMatchingCType(); 68910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.LayoutCompatible = I->getLayoutCompatible(); 68920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.MustBeNull = I->getMustBeNull(); 68930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 68940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!MagicValues) 68990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::DenseMap<Sema::TypeTagMagicValue, 69020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData>::const_iterator I = 69030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko MagicValues->find(std::make_pair(ArgumentKind, MagicValue)); 69040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I == MagicValues->end()) 69050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo = I->second; 69080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 69090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 69100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace 69110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::RegisterTypeTagForDatatype(const IdentifierInfo *ArgumentKind, 69130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko uint64_t MagicValue, QualType Type, 69140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool LayoutCompatible, 69150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool MustBeNull) { 69160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeTagForDatatypeMagicValues) 69170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagForDatatypeMagicValues.reset( 69180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko new llvm::DenseMap<TypeTagMagicValue, TypeTagData>); 69190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagMagicValue Magic(ArgumentKind, MagicValue); 69210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (*TypeTagForDatatypeMagicValues)[Magic] = 69220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagData(Type, LayoutCompatible, MustBeNull); 69230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 69240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 69260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool IsSameCharType(QualType T1, QualType T2) { 69270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BuiltinType *BT1 = T1->getAs<BuiltinType>(); 69280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!BT1) 69290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BuiltinType *BT2 = T2->getAs<BuiltinType>(); 69320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!BT2) 69330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BuiltinType::Kind T1Kind = BT1->getKind(); 69360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BuiltinType::Kind T2Kind = BT2->getKind(); 69370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return (T1Kind == BuiltinType::SChar && T2Kind == BuiltinType::Char_S) || 69390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::UChar && T2Kind == BuiltinType::Char_U) || 69400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::Char_U && T2Kind == BuiltinType::UChar) || 69410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::Char_S && T2Kind == BuiltinType::SChar); 69420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 69430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace 69440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::CheckArgumentWithTypeTag(const ArgumentWithTypeTagAttr *Attr, 69460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr * const *ExprArgs) { 69470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IdentifierInfo *ArgumentKind = Attr->getArgumentKind(); 69480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool IsPointerAttr = Attr->getIsPointer(); 69490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *TypeTagExpr = ExprArgs[Attr->getTypeTagIdx()]; 69510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool FoundWrongKind; 69520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagData TypeInfo; 69530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!GetMatchingCType(ArgumentKind, TypeTagExpr, Context, 69540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagForDatatypeMagicValues.get(), 69550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind, TypeInfo)) { 69560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (FoundWrongKind) 69570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(TypeTagExpr->getExprLoc(), 69580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko diag::warn_type_tag_for_datatype_wrong_kind) 69590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 69600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 69610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *ArgumentExpr = ExprArgs[Attr->getArgumentIdx()]; 69640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) { 69650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Skip implicit cast of pointer to `void *' (as a function argument). 69660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(ArgumentExpr)) 69675a24980d059cd9fbe8375a4c549313101ad20698Dmitri Gribenko if (ICE->getType()->isVoidPointerType() && 6968b57ce4e8918656f5f4070f59d74354fcefbbb6f8Dmitri Gribenko ICE->getCastKind() == CK_BitCast) 69690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ArgumentExpr = ICE->getSubExpr(); 69700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko QualType ArgumentType = ArgumentExpr->getType(); 69720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Passing a `void*' pointer shouldn't trigger a warning. 69740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr && ArgumentType->isVoidPointerType()) 69750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 69760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TypeInfo.MustBeNull) { 69780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Type tag with matching void type requires a null pointer. 69790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!ArgumentExpr->isNullPointerConstant(Context, 69800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Expr::NPC_ValueDependentIsNotNull)) { 69810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(ArgumentExpr->getExprLoc(), 69820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko diag::warn_type_safety_null_pointer_required) 69830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentKind->getName() 69840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentExpr->getSourceRange() 69850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 69860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 69880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko QualType RequiredType = TypeInfo.Type; 69910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) 69920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType = Context.getPointerType(RequiredType); 69930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool mismatch = false; 69950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeInfo.LayoutCompatible) { 69960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !Context.hasSameType(ArgumentType, RequiredType); 69970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [basic.fundamental] p1: 69990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Plain char, signed char, and unsigned char are three distinct types. 70000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // 70010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // But we treat plain `char' as equivalent to `signed char' or `unsigned 70020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // char' depending on the current char signedness mode. 70030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (mismatch) 70040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if ((IsPointerAttr && IsSameCharType(ArgumentType->getPointeeType(), 70050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType->getPointeeType())) || 70060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (!IsPointerAttr && IsSameCharType(ArgumentType, RequiredType))) 70070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = false; 70080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else 70090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) 70100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !isLayoutCompatible(Context, 70110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ArgumentType->getPointeeType(), 70120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType->getPointeeType()); 70130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 70140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !isLayoutCompatible(Context, ArgumentType, RequiredType); 70150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (mismatch) 70170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(ArgumentExpr->getExprLoc(), diag::warn_type_safety_type_mismatch) 70180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentType << ArgumentKind->getName() 70190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeInfo.LayoutCompatible << RequiredType 70200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentExpr->getSourceRange() 70210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 70220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 7023