SemaChecking.cpp revision 0a151a137a68bb656acbcce7ff2407613bb80cfc
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// The LLVM Compiler Infrastructure 459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source 60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details. 759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump// This file implements extra semantic analysis beyond what is enforced 1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// by the C type system. 1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 155f8d604246976a93a73549b07bbc8ee0b2061b50John McCall#include "clang/Sema/Initialization.h" 16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Sema.h" 172d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 18276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman#include "clang/Sema/Initialization.h" 19781472fe99a120098c631b0cbe33c89f8cef5e70John McCall#include "clang/Sema/ScopeInfo.h" 20826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek#include "clang/Analysis/Analyses/FormatString.h" 2159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h" 22199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h" 23384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 24c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h" 252324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h" 267ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h" 27f85e193739c953358c865005855253af4f68a497John McCall#include "clang/AST/EvaluatedExprVisitor.h" 28f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/DeclObjC.h" 29f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h" 30f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h" 3159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h" 32f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h" 33f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h" 343bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h" 35691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher#include "clang/Basic/TargetBuiltins.h" 3626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman#include "clang/Basic/TargetInfo.h" 377da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian#include "clang/Basic/ConvertUTF.h" 38a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits> 3959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang; 40781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema; 4159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 4260800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 4360800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned ByteNo) const { 4408f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner return SL->getLocationOfByte(ByteNo, PP.getSourceManager(), 4508f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner PP.getLangOptions(), PP.getTargetInfo()); 4660800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner} 4708f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner 4860800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 494403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// CheckablePrintfAttr - does a function call have a "printf" attribute 504403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// and arguments that merit checking? 514403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynnbool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) { 524403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf") return true; 534403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf0") { 544403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn // printf0 allows null "format" string; if so don't check format/args 554403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn unsigned format_idx = Format->getFormatIdx() - 1; 564a2614e94672c47395abcde60518776fbebec589Sebastian Redl // Does the index refer to the implicit object argument? 574a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 584a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (format_idx == 0) 594a2614e94672c47395abcde60518776fbebec589Sebastian Redl return false; 604a2614e94672c47395abcde60518776fbebec589Sebastian Redl --format_idx; 614a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 624403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (format_idx < TheCall->getNumArgs()) { 634403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts(); 64efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!Format->isNullPointerConstant(Context, 65efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek Expr::NPC_ValueDependentIsNull)) 664403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return true; 674403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 684403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 694403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return false; 704403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn} 7160800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 728e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number. 738e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking. Returns true on error. 748e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) { 758e10f3b9cc1db43645bbc2999eb163af8997d468John McCall unsigned argCount = call->getNumArgs(); 768e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount == desiredArgCount) return false; 778e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 788e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount < desiredArgCount) 798e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args) 808e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 818e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getSourceRange(); 828e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 838e10f3b9cc1db43645bbc2999eb163af8997d468John McCall // Highlight all the excess arguments. 848e10f3b9cc1db43645bbc2999eb163af8997d468John McCall SourceRange range(call->getArg(desiredArgCount)->getLocStart(), 858e10f3b9cc1db43645bbc2999eb163af8997d468John McCall call->getArg(argCount - 1)->getLocEnd()); 868e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 878e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args) 888e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 898e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getArg(1)->getSourceRange(); 908e10f3b9cc1db43645bbc2999eb163af8997d468John McCall} 918e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 9277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge/// CheckBuiltinAnnotationString - Checks that string argument to the builtin 9377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge/// annotation is a non wide string literal. 9477f68bb90af93b95045fb994e7cd68137adcc132Julien Lerougestatic bool CheckBuiltinAnnotationString(Sema &S, Expr *Arg) { 9577f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge Arg = Arg->IgnoreParenCasts(); 9677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 9777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge if (!Literal || !Literal->isAscii()) { 9877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge S.Diag(Arg->getLocStart(), diag::err_builtin_annotation_not_string_constant) 9977f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge << Arg->getSourceRange(); 10077f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return true; 10177f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge } 10277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return false; 10377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge} 10477f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge 10560d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 106d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 10760d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult TheCallResult(Owned(TheCall)); 1082def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor 109946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Find out if any arguments are required to be integer constant expressions. 110946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner unsigned ICEArguments = 0; 111946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ASTContext::GetBuiltinTypeError Error; 112946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 113946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (Error != ASTContext::GE_None) 114946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments = 0; // Don't diagnose previously diagnosed errors. 115946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 116946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // If any arguments are required to be ICE's, check and diagnose. 117946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 118946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Skip arguments not required to be ICE's. 119946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if ((ICEArguments & (1 << ArgNo)) == 0) continue; 120946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 121946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner llvm::APSInt Result; 122946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 123946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner return true; 124946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments &= ~(1 << ArgNo); 125946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner } 126946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 127d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson switch (BuiltinID) { 12830ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin___CFStringMakeConstantString: 129925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner assert(TheCall->getNumArgs() == 1 && 1301b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner "Wrong # arguments to builtin CFStringMakeConstantString"); 131690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner if (CheckObjCString(TheCall->getArg(0))) 1320eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 133d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 13449ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek case Builtin::BI__builtin_stdarg_start: 13530ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin_va_start: 1360eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinVAStart(TheCall)) 1370eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 138d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1391b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreater: 1401b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreaterequal: 1411b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isless: 1421b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessequal: 1431b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessgreater: 1441b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isunordered: 1450eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinUnorderedCompare(TheCall)) 1460eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 147d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 148e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer case Builtin::BI__builtin_fpclassify: 149e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer if (SemaBuiltinFPClassification(TheCall, 6)) 150e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer return ExprError(); 151e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer break; 1529ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isfinite: 1539ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf: 1549ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf_sign: 1559ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnan: 1569ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnormal: 1573b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (SemaBuiltinFPClassification(TheCall, 1)) 1589ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return ExprError(); 1599ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman break; 160d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman case Builtin::BI__builtin_shufflevector: 1610eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return SemaBuiltinShuffleVector(TheCall); 1620eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // TheCall will be freed by the smart pointer here, but that's fine, since 1630eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // SemaBuiltinShuffleVector guts it, but then doesn't release it. 1644493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar case Builtin::BI__builtin_prefetch: 1650eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinPrefetch(TheCall)) 1660eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 167d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 168d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar case Builtin::BI__builtin_object_size: 1690eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinObjectSize(TheCall)) 1700eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 171d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 172d875fed28578835de89cd407e9db4be788596d7cEli Friedman case Builtin::BI__builtin_longjmp: 173d875fed28578835de89cd407e9db4be788596d7cEli Friedman if (SemaBuiltinLongjmp(TheCall)) 174d875fed28578835de89cd407e9db4be788596d7cEli Friedman return ExprError(); 175d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1768e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 1778e10f3b9cc1db43645bbc2999eb163af8997d468John McCall case Builtin::BI__builtin_classify_type: 1788e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1798e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 1808e10f3b9cc1db43645bbc2999eb163af8997d468John McCall break; 18175c29a012793292ff4578015a9113bf086156d7fChris Lattner case Builtin::BI__builtin_constant_p: 1828e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1838e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 18475c29a012793292ff4578015a9113bf086156d7fChris Lattner break; 1855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: 186a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 187a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 188a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 189a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 190a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 1915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: 192a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 193a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 194a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 195a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 196a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 1975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: 198a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 199a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 200a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 201a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 202a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 2035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: 204a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 205a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 206a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 207a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 208a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 2095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: 210a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 211a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 212a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 213a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 214a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 2155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_add_and_fetch: 216a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 217a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 218a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 219a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 220a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 2215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_sub_and_fetch: 222a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 223a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 224a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 225a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 226a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 2275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_and_and_fetch: 228a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 229a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 230a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 231a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 232a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 2335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_or_and_fetch: 234a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 235a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 236a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 237a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 238a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 2395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_xor_and_fetch: 240a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 241a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 242a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 243a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 244a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 2455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 246a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 247a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 248a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 249a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 250a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 2515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 252a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 253a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 254a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 255a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 256a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 2575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_test_and_set: 258a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 259a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 260a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 261a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 262a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 2635caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 264a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 265a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 266a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 267a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 268a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 26923aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: 270a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 271a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 272a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 273a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 274a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 275d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return SemaBuiltinAtomicOverloaded(move(TheCallResult)); 276276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_load: 277276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Load); 278276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_store: 279276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Store); 2807a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall case Builtin::BI__atomic_init: 2817a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Init); 282276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_exchange: 283276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Xchg); 284276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_compare_exchange_strong: 285276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), 286276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman AtomicExpr::CmpXchgStrong); 287276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_compare_exchange_weak: 288276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), 289276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman AtomicExpr::CmpXchgWeak); 290276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_add: 291276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Add); 292276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_sub: 293276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Sub); 294276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_and: 295276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::And); 296276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_or: 297276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Or); 298276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_xor: 299276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Xor); 30077f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge case Builtin::BI__builtin_annotation: 30177f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge if (CheckBuiltinAnnotationString(*this, TheCall->getArg(1))) 30277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return ExprError(); 30377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge break; 30426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 30526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 30626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // Since the target specific builtins for each arch overlap, only check those 30726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // of the arch we are compiling for. 30826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (BuiltinID >= Builtin::FirstTSBuiltin) { 309bcfd1f55bfbb3e5944cd5e03d07b343e280838c4Douglas Gregor switch (Context.getTargetInfo().getTriple().getArch()) { 31026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::arm: 31126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::thumb: 31226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 31326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return ExprError(); 31426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 31526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman default: 31626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 31726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 31826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 31926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 32026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return move(TheCallResult); 32126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman} 32226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 32361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code. 32461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) { 325da95f73b59f9af964e33725c515139d34c90c863Bob Wilson NeonTypeFlags Type(t); 326da95f73b59f9af964e33725c515139d34c90c863Bob Wilson int IsQuad = Type.isQuad(); 327da95f73b59f9af964e33725c515139d34c90c863Bob Wilson switch (Type.getEltType()) { 328da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int8: 329da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly8: 330da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 7 : (8 << IsQuad) - 1; 331da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int16: 332da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly16: 333da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 15 : (4 << IsQuad) - 1; 334da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int32: 335da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 31 : (2 << IsQuad) - 1; 336da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int64: 337da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 63 : (1 << IsQuad) - 1; 338da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float16: 339da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 340da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (4 << IsQuad) - 1; 341da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float32: 342da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 343da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (2 << IsQuad) - 1; 34461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman } 34561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman return 0; 34661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman} 34761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 3486f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// getNeonEltType - Return the QualType corresponding to the elements of 3496f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the vector type specified by the NeonTypeFlags. This is used to check 3506f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the pointer arguments for Neon load/store intrinsics. 3516f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilsonstatic QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context) { 3526f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson switch (Flags.getEltType()) { 3536f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int8: 3546f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy; 3556f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int16: 3566f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy; 3576f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int32: 3586f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy; 3596f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int64: 3606f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedLongLongTy : Context.LongLongTy; 3616f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly8: 3626f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.SignedCharTy; 3636f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly16: 3646f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.ShortTy; 3656f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float16: 3666f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.UnsignedShortTy; 3676f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float32: 3686f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.FloatTy; 3696f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 3706f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return QualType(); 3716f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson} 3726f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 37326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 3741c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman llvm::APSInt Result; 3751c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 3760d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned mask = 0; 37761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned TV = 0; 3784648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson int PtrArgNum = -1; 3796f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson bool HasConstPtr = false; 3801c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman switch (BuiltinID) { 381a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK 382a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 383a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK 3841c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman } 3851c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 3860d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which are overloaded on vector element type, validate 3870d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // the immediate which specifies which variant to emit. 3886f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson unsigned ImmArg = TheCall->getNumArgs()-1; 3890d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (mask) { 3906f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson if (SemaBuiltinConstantArg(TheCall, ImmArg, Result)) 3910d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 3920d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 393da95f73b59f9af964e33725c515139d34c90c863Bob Wilson TV = Result.getLimitedValue(64); 394da95f73b59f9af964e33725c515139d34c90c863Bob Wilson if ((TV > 63) || (mask & (1 << TV)) == 0) 3950d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 3966f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson << TheCall->getArg(ImmArg)->getSourceRange(); 3976f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 3986f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 3994648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (PtrArgNum >= 0) { 4006f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson // Check that pointer arguments have the specified type. 4014648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Expr *Arg = TheCall->getArg(PtrArgNum); 4024648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) 4034648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Arg = ICE->getSubExpr(); 4044648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg); 4054648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType RHSTy = RHS.get()->getType(); 4064648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context); 4074648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (HasConstPtr) 4084648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson EltTy = EltTy.withConst(); 4094648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType LHSTy = Context.getPointerType(EltTy); 4104648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson AssignConvertType ConvTy; 4114648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS); 4124648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (RHS.isInvalid()) 4134648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 4144648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy, 4154648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson RHS.get(), AA_Assigning)) 4164648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 4170d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman } 4181c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 4190d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which take an immediate value as part of the 4200d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // instruction, range check them here. 42161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned i = 0, l = 0, u = 0; 4220d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman switch (BuiltinID) { 4230d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman default: return false; 424bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 425bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 42699c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_f: 42799c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 428a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK 429a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 430a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK 4310d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman }; 4320d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 43361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Check that the immediate argument is actually a constant. 4340d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, i, Result)) 4350d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 4360d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 43761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Range check against the upper/lower values for this isntruction. 4380d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned Val = Result.getZExtValue(); 43961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if (Val < l || Val > (u + l)) 4400d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 441476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer << l << u+l << TheCall->getArg(i)->getSourceRange(); 4420d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 44399c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman // FIXME: VFP Intrinsics should error if VFP not present. 44426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return false; 445d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson} 446d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 447d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// CheckFunctionCall - Check a direct function call for various correctness 448d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// and safety properties not strictly enforced by the C type system. 449d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) { 450d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // Get the IdentifierInfo* for the called function. 451d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson IdentifierInfo *FnInfo = FDecl->getIdentifier(); 452de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 453d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // None of the checks below are needed for functions that don't have 454d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // simple names (e.g., C++ conversion functions). 455d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson if (!FnInfo) 456d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 4571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 458de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // FIXME: This mechanism should be abstracted to be less fragile and 459de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // more efficient. For example, just map function ids to custom 460de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // handlers. 461de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 462c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek // Printf and scanf checking. 463c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<FormatAttr> 464c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<FormatAttr>(), 465c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<FormatAttr>(); i != e ; ++i) { 466c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek 467c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek const FormatAttr *Format = *i; 468826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 469826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (b || CheckablePrintfAttr(Format, TheCall)) { 4703d692df4b9c58895f9843b03543ec57447c93679Ted Kremenek bool HasVAListArg = Format->getFirstArg() == 0; 471826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, 472826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Format->getFormatIdx() - 1, 473826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, 474826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek !b); 4753c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor } 47659907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner } 4771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 478c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<NonNullAttr> 479c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<NonNullAttr>(), 480c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<NonNullAttr>(); i != e; ++i) { 481909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky CheckNonNullArguments(*i, TheCall->getArgs(), 482909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky TheCall->getCallee()->getLocStart()); 483c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek } 4840eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 4850a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned CMId = FDecl->getMemoryFunctionKind(); 4860a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == 0) 487d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks return false; 488bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 489d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks // Handle memory setting and copying functions. 4900a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat) 491bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CheckStrlcpycatArguments(TheCall, FnInfo); 492d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks else 4930a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks CheckMemaccessArguments(TheCall, CMId, FnInfo); 4947ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 495d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 49671993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson} 49771993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 498d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) { 499725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian // Printf checking. 50040b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis const FormatAttr *Format = NDecl->getAttr<FormatAttr>(); 501725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Format) 502d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 5031eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 504725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian const VarDecl *V = dyn_cast<VarDecl>(NDecl); 505725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!V) 506d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 5071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 508725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian QualType Ty = V->getType(); 509725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Ty->isBlockPointerType()) 510d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 5111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 512826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 513826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!b && !CheckablePrintfAttr(Format, TheCall)) 514d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 5151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 516d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson bool HasVAListArg = Format->getFirstArg() == 0; 517826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1, 518826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, !b); 519d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 520d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 521725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian} 522725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian 523276b061970939293f1abaf694bd3ef05b2cbda79Eli FriedmanExprResult 524276b061970939293f1abaf694bd3ef05b2cbda79Eli FriedmanSema::SemaAtomicOpsOverloaded(ExprResult TheCallResult, AtomicExpr::AtomicOp Op) { 525276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman CallExpr *TheCall = cast<CallExpr>(TheCallResult.get()); 526276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 527276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 528276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // All these operations take one of the following four forms: 529276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // T __atomic_load(_Atomic(T)*, int) (loads) 530276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // T* __atomic_add(_Atomic(T*)*, ptrdiff_t, int) (pointer add/sub) 531276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // int __atomic_compare_exchange_strong(_Atomic(T)*, T*, T, int, int) 532276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // (cmpxchg) 533276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // T __atomic_exchange(_Atomic(T)*, T, int) (everything else) 534276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // where T is an appropriate type, and the int paremeterss are for orderings. 535276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman unsigned NumVals = 1; 536276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman unsigned NumOrders = 1; 537276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Op == AtomicExpr::Load) { 538276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman NumVals = 0; 539276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else if (Op == AtomicExpr::CmpXchgWeak || Op == AtomicExpr::CmpXchgStrong) { 540276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman NumVals = 2; 541276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman NumOrders = 2; 542276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 5437a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall if (Op == AtomicExpr::Init) 5447a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall NumOrders = 0; 545276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 546276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (TheCall->getNumArgs() < NumVals+NumOrders+1) { 547276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 548276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << 0 << NumVals+NumOrders+1 << TheCall->getNumArgs() 549276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 550276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 551276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else if (TheCall->getNumArgs() > NumVals+NumOrders+1) { 552276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(TheCall->getArg(NumVals+NumOrders+1)->getLocStart(), 553276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman diag::err_typecheck_call_too_many_args) 554276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << 0 << NumVals+NumOrders+1 << TheCall->getNumArgs() 555276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 556276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 557276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 558276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 559276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // Inspect the first argument of the atomic operation. This should always be 560276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // a pointer to an _Atomic type. 561dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman Expr *Ptr = TheCall->getArg(0); 562276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get(); 563276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman const PointerType *pointerType = Ptr->getType()->getAs<PointerType>(); 564276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!pointerType) { 565276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic) 566276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 567276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 568276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 569276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 570276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType AtomTy = pointerType->getPointeeType(); 571276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!AtomTy->isAtomicType()) { 572276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic) 573276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 574276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 575276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 576276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType ValType = AtomTy->getAs<AtomicType>()->getValueType(); 577276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 578276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if ((Op == AtomicExpr::Add || Op == AtomicExpr::Sub) && 579276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman !ValType->isIntegerType() && !ValType->isPointerType()) { 580276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 581276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 582276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 583276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 584276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 585276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!ValType->isIntegerType() && 586276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman (Op == AtomicExpr::And || Op == AtomicExpr::Or || Op == AtomicExpr::Xor)){ 587276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_logical_needs_atomic_int) 588276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 589276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 590276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 591276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 592276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman switch (ValType.getObjCLifetime()) { 593276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_None: 594276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_ExplicitNone: 595276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // okay 596276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman break; 597276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 598276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Weak: 599276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Strong: 600276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Autoreleasing: 601276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 602276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << ValType << Ptr->getSourceRange(); 603276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 604276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 605276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 606276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType ResultType = ValType; 6077a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall if (Op == AtomicExpr::Store || Op == AtomicExpr::Init) 608276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.VoidTy; 609276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman else if (Op == AtomicExpr::CmpXchgWeak || Op == AtomicExpr::CmpXchgStrong) 610276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.BoolTy; 611276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 612276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The first argument --- the pointer --- has a fixed type; we 613276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // deduce the types of the rest of the arguments accordingly. Walk 614276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // the remaining arguments, converting them to the deduced value type. 615276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman for (unsigned i = 1; i != NumVals+NumOrders+1; ++i) { 616276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ExprResult Arg = TheCall->getArg(i); 617276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType Ty; 618276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (i < NumVals+1) { 619276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The second argument to a cmpxchg is a pointer to the data which will 620276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // be exchanged. The second argument to a pointer add/subtract is the 621276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // amount to add/subtract, which must be a ptrdiff_t. The third 622276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // argument to a cmpxchg and the second argument in all other cases 623276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // is the type of the value. 624276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (i == 1 && (Op == AtomicExpr::CmpXchgWeak || 625276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Op == AtomicExpr::CmpXchgStrong)) 626276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.getPointerType(ValType.getUnqualifiedType()); 627276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman else if (!ValType->isIntegerType() && 628276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman (Op == AtomicExpr::Add || Op == AtomicExpr::Sub)) 629276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.getPointerDiffType(); 630276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman else 631276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = ValType; 632276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else { 633276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The order(s) are always converted to int. 634276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.IntTy; 635276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 636276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity Entity = 637276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity::InitializeParameter(Context, Ty, false); 638276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 639276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Arg.isInvalid()) 640276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return true; 641276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman TheCall->setArg(i, Arg.get()); 642276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 643276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 644dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SmallVector<Expr*, 5> SubExprs; 645dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(Ptr); 646276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Op == AtomicExpr::Load) { 647dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Order 6487a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall } else if (Op == AtomicExpr::Init) { 6497a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall SubExprs.push_back(TheCall->getArg(1)); // Val1 650276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else if (Op != AtomicExpr::CmpXchgWeak && Op != AtomicExpr::CmpXchgStrong) { 651dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(2)); // Order 652dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 653276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else { 654dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(3)); // Order 655dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 656dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(2)); // Val2 657dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(4)); // OrderFail 658276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 659dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman 660dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman return Owned(new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(), 661dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.data(), SubExprs.size(), 662dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman ResultType, Op, 663dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman TheCall->getRParenLoc())); 664276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman} 665276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 666276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 6675f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// checkBuiltinArgument - Given a call to a builtin function, perform 6685f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// normal type-checking on the given argument, updating the call in 6695f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// place. This is useful when a builtin function requires custom 6705f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// type-checking for some of its arguments but not necessarily all of 6715f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// them. 6725f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// 6735f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// Returns true on error. 6745f8d604246976a93a73549b07bbc8ee0b2061b50John McCallstatic bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) { 6755f8d604246976a93a73549b07bbc8ee0b2061b50John McCall FunctionDecl *Fn = E->getDirectCallee(); 6765f8d604246976a93a73549b07bbc8ee0b2061b50John McCall assert(Fn && "builtin call without direct callee!"); 6775f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 6785f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ParmVarDecl *Param = Fn->getParamDecl(ArgIndex); 6795f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity Entity = 6805f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity::InitializeParameter(S.Context, Param); 6815f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 6825f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ExprResult Arg = E->getArg(0); 6835f8d604246976a93a73549b07bbc8ee0b2061b50John McCall Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg); 6845f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (Arg.isInvalid()) 6855f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 6865f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 6875f8d604246976a93a73549b07bbc8ee0b2061b50John McCall E->setArg(ArgIndex, Arg.take()); 6885f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return false; 6895f8d604246976a93a73549b07bbc8ee0b2061b50John McCall} 6905f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 6915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like 6925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer 6935caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument. The main ActOnCallExpr routines have already 6945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as 6955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...). 6965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// 6975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these 6985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins, 69960d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 70060d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 701d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 7025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 7035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 7045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 7055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Ensure that we have at least one argument to do type inference from. 706d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1) { 707d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 708d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1 << TheCall->getNumArgs() 709d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 710d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 711d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 7121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Inspect the first argument of the atomic builtin. This should always be 7145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // a pointer type, whose element is an integral scalar or pointer type. 7155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Because it is a pointer type, we don't have to worry about any implicit 7165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // casts here. 717d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth // FIXME: We don't allow floating point scalars as input. 7185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *FirstArg = TheCall->getArg(0); 719f85e193739c953358c865005855253af4f68a497John McCall const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>(); 720f85e193739c953358c865005855253af4f68a497John McCall if (!pointerType) { 721d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 722d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 723d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 724d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 7251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 726f85e193739c953358c865005855253af4f68a497John McCall QualType ValType = pointerType->getPointeeType(); 727dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 728d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth !ValType->isBlockPointerType()) { 729d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 730d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 731d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 732d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 7335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 734f85e193739c953358c865005855253af4f68a497John McCall switch (ValType.getObjCLifetime()) { 735f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 736f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 737f85e193739c953358c865005855253af4f68a497John McCall // okay 738f85e193739c953358c865005855253af4f68a497John McCall break; 739f85e193739c953358c865005855253af4f68a497John McCall 740f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 741f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 742f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 743b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 744f85e193739c953358c865005855253af4f68a497John McCall << ValType << FirstArg->getSourceRange(); 745f85e193739c953358c865005855253af4f68a497John McCall return ExprError(); 746f85e193739c953358c865005855253af4f68a497John McCall } 747f85e193739c953358c865005855253af4f68a497John McCall 748b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Strip any qualifiers off ValType. 749b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType = ValType.getUnqualifiedType(); 750b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall 7518d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // The majority of builtins return a value, but a few have special return 7528d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // types, so allow them to override appropriately below. 7538d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth QualType ResultType = ValType; 7548d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth 7555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // We need to figure out which concrete builtin this maps onto. For example, 7565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add with a 2 byte object turns into 7575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add_2. 7585caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \ 7595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 7605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Builtin::BI##x##_8, Builtin::BI##x##_16 } 7611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7625caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner static const unsigned BuiltinIndices[][5] = { 7635caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_add), 7645caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_sub), 7655caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_or), 7665caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_and), 7675caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_xor), 7681eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7695caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_add_and_fetch), 7705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_sub_and_fetch), 7715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_and_and_fetch), 7725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_or_and_fetch), 7735caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_xor_and_fetch), 7741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7755caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_val_compare_and_swap), 7765caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_bool_compare_and_swap), 7775caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_test_and_set), 77823aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_lock_release), 77923aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_swap) 7805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner }; 7811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW 7821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Determine the index of the size. 7845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned SizeIndex; 785199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 7865caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 1: SizeIndex = 0; break; 7875caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 2: SizeIndex = 1; break; 7885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 4: SizeIndex = 2; break; 7895caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 8: SizeIndex = 3; break; 7905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 16: SizeIndex = 4; break; 7915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: 792d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 793d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 794d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 7955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 7961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Each of these builtins has one pointer argument, followed by some number of 7985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // values (0, 1 or 2) followed by a potentially empty varags list of stuff 7995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // that we ignore. Find out which row of BuiltinIndices to read from as well 8005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // as the number of fixed args. 8017814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor unsigned BuiltinID = FDecl->getBuiltinID(); 8025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned BuiltinIndex, NumFixed = 1; 8035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner switch (BuiltinID) { 804b219cfc4d75f0a03630b7c4509ef791b7e97b2c8David Blaikie default: llvm_unreachable("Unknown overloaded atomic builtin!"); 805a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add: 806a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 807a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 808a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 809a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 810a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 811a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 0; 812a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 813a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 814a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub: 815a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 816a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 817a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 818a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 819a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 820a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 1; 821a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 822a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 823a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or: 824a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 825a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 826a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 827a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 828a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 829a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 2; 830a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 831a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 832a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and: 833a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 834a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 835a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 836a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 837a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 838a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 3; 839a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 840a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 841a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor: 842a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 843a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 844a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 845a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 846a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 847a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 4; 848a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 849a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 850a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch: 851a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 852a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 853a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 854a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 855a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 856a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 5; 857a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 858a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 859a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch: 860a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 861a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 862a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 863a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 864a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 865a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 6; 866a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 867a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 868a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch: 869a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 870a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 871a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 872a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 873a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 874a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 7; 875a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 876a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 877a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch: 878a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 879a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 880a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 881a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 882a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 883a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 8; 884a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 885a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 886a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch: 887a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 888a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 889a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 890a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 891a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 892a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 9; 893a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 8941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 896a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 897a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 898a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 899a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 900a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 9017eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 10; 9025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 9035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 904a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 9055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 906a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 907a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 908a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 909a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 910a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 9117eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 11; 9125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 9138d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.BoolTy; 9145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 915a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 916a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set: 917a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 918a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 919a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 920a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 921a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 922a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 12; 923a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 924a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 9255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 926a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 927a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 928a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 929a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 930a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 9317eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 13; 9325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 0; 9338d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.VoidTy; 9345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 935a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 936a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap: 937a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 938a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 939a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 940a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 941a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 942a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 14; 943a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 9445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 9451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Now that we know how many fixed arguments we expect, first check that we 9475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // have at least that many. 948d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1+NumFixed) { 949d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 950d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1+NumFixed << TheCall->getNumArgs() 951d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 952d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 953d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 9541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 955e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // Get the decl for the concrete builtin from this, we can tell what the 956e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // concrete integer type we should convert to is. 957e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 958e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 959e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName); 9601eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump FunctionDecl *NewBuiltinDecl = 961e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID, 962e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner TUScope, false, DRE->getLocStart())); 963d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 964f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // The first argument --- the pointer --- has a fixed type; we 965f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // deduce the types of the rest of the arguments accordingly. Walk 966f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // the remaining arguments, converting them to the deduced value type. 9675caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner for (unsigned i = 0; i != NumFixed; ++i) { 968429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult Arg = TheCall->getArg(i+1); 9691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // GCC does an implicit conversion to the pointer or integer ValType. This 9715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // can fail in some cases (1i -> int**), check for this error case now. 972b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Initialize the argument. 973b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall InitializedEntity Entity = InitializedEntity::InitializeParameter(Context, 974b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType, /*consume*/ false); 975b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 976429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (Arg.isInvalid()) 977d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 9781eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Okay, we have something that *can* be converted to the right type. Check 9805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // to see if there is a potentially weird extension going on here. This can 9815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // happen when you do an atomic operation on something like an char* and 9825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // pass in 42. The 42 gets converted to char. This is even more strange 9835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // for things like 45.123 -> char, etc. 9841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // FIXME: Do this check. 985b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall TheCall->setArg(i+1, Arg.take()); 9865caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 9871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 988bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor ASTContext& Context = this->getASTContext(); 989bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor 990bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor // Create a new DeclRefExpr to refer to the new decl. 991bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DeclRefExpr* NewDRE = DeclRefExpr::Create( 992bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor Context, 993bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getQualifierLoc(), 994bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor NewBuiltinDecl, 995bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getLocation(), 996bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor NewBuiltinDecl->getType(), 997bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getValueKind()); 9981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Set the callee in the CallExpr. 10005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // FIXME: This leaks the original parens and implicit casts. 1001bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor ExprResult PromotedCall = UsualUnaryConversions(NewDRE); 1002429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (PromotedCall.isInvalid()) 1003429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return ExprError(); 1004429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setCallee(PromotedCall.take()); 10051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1006db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // Change the result type of the call to match the original value type. This 1007db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // is arbitrary, but the codegen for these builtins ins design to handle it 1008db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // gracefully. 10098d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth TheCall->setType(ResultType); 1010d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 1011d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return move(TheCallResult); 10125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner} 10135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 1014690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin 101571993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct 1016fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would 1017fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend). 1018690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) { 101956f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner Arg = Arg->IgnoreParenCasts(); 102071993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 102171993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 10225cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!Literal || !Literal->isAscii()) { 1023fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 1024fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << Arg->getSourceRange(); 10259cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return true; 102671993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson } 10271eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10287da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Literal->containsNonAsciiOrNull()) { 10295f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef String = Literal->getString(); 10307da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian unsigned NumBytes = String.size(); 10315f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<UTF16, 128> ToBuf(NumBytes); 10327da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian const UTF8 *FromPtr = (UTF8 *)String.data(); 10337da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian UTF16 *ToPtr = &ToBuf[0]; 10347da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 10357da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 10367da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian &ToPtr, ToPtr + NumBytes, 10377da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian strictConversion); 10387da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian // Check for conversion failure. 10397da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Result != conversionOK) 10407da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian Diag(Arg->getLocStart(), 10417da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian diag::warn_cfstring_truncated) << Arg->getSourceRange(); 10427da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian } 10439cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return false; 104459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner} 104559907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 1046c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 1047c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success. 1048925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 1049925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *Fn = TheCall->getCallee(); 1050925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) { 10512c21a073525cdfa68e4439b7af551385dc2796abChris Lattner Diag(TheCall->getArg(2)->getLocStart(), 1052fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1053ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1054ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << Fn->getSourceRange() 10551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(2)->getLocStart(), 1056fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 105730ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 105830ce344307f8a8b00054021307015571f83c7364Chris Lattner } 105956f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 106056f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman if (TheCall->getNumArgs() < 2) { 1061d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher return Diag(TheCall->getLocEnd(), 1062d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 1063d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 106456f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman } 106556f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 10665f8d604246976a93a73549b07bbc8ee0b2061b50John McCall // Type-check the first argument normally. 10675f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (checkBuiltinArgument(*this, TheCall, 0)) 10685f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 10695f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 1070c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner // Determine whether the current function is variadic or not. 10719ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor BlockScopeInfo *CurBlock = getCurBlock(); 1072c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner bool isVariadic; 1073cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1074c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall isVariadic = CurBlock->TheDecl->isVariadic(); 10759498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else if (FunctionDecl *FD = getCurFunctionDecl()) 10769498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek isVariadic = FD->isVariadic(); 10779498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else 107853d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis isVariadic = getCurMethodDecl()->isVariadic(); 10791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1080c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner if (!isVariadic) { 108130ce344307f8a8b00054021307015571f83c7364Chris Lattner Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 108230ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 108330ce344307f8a8b00054021307015571f83c7364Chris Lattner } 10841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 108530ce344307f8a8b00054021307015571f83c7364Chris Lattner // Verify that the second argument to the builtin is the last argument of the 108630ce344307f8a8b00054021307015571f83c7364Chris Lattner // current function or method. 108730ce344307f8a8b00054021307015571f83c7364Chris Lattner bool SecondArgIsLastNamedArgument = false; 1088e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 10891eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 109088cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 109188cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 109230ce344307f8a8b00054021307015571f83c7364Chris Lattner // FIXME: This isn't correct for methods (results in bogus warning). 109330ce344307f8a8b00054021307015571f83c7364Chris Lattner // Get the last formal in the current function. 109488cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson const ParmVarDecl *LastArg; 1095cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1096cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff LastArg = *(CurBlock->TheDecl->param_end()-1); 1097cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff else if (FunctionDecl *FD = getCurFunctionDecl()) 1098371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner LastArg = *(FD->param_end()-1); 109930ce344307f8a8b00054021307015571f83c7364Chris Lattner else 110053d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis LastArg = *(getCurMethodDecl()->param_end()-1); 110130ce344307f8a8b00054021307015571f83c7364Chris Lattner SecondArgIsLastNamedArgument = PV == LastArg; 110230ce344307f8a8b00054021307015571f83c7364Chris Lattner } 110330ce344307f8a8b00054021307015571f83c7364Chris Lattner } 11041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 110530ce344307f8a8b00054021307015571f83c7364Chris Lattner if (!SecondArgIsLastNamedArgument) 11061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(1)->getLocStart(), 110730ce344307f8a8b00054021307015571f83c7364Chris Lattner diag::warn_second_parameter_of_va_start_not_last_named_argument); 110830ce344307f8a8b00054021307015571f83c7364Chris Lattner return false; 11096cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman} 111030ce344307f8a8b00054021307015571f83c7364Chris Lattner 11111b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 11121b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends. This is declared to take (...), so we have to check everything. 1113925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 1114925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() < 2) 11152c21a073525cdfa68e4439b7af551385dc2796abChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1116d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << 2 << TheCall->getNumArgs()/*function call*/; 1117925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) 11181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(TheCall->getArg(2)->getLocStart(), 1119fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1120ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1121fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(TheCall->getArg(2)->getLocStart(), 1122fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 11231eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1124429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg0 = TheCall->getArg(0); 1125429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg1 = TheCall->getArg(1); 1126cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 11271b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // Do standard promotions between the two arguments, returning their common 11281b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // type. 1129925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 1130429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.isInvalid() || OrigArg1.isInvalid()) 1131429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return true; 1132403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar 1133403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // Make sure any conversions are pushed back into the call; this is 1134403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // type safe since unordered compare builtins are declared as "_Bool 1135403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // foo(...)". 1136429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(0, OrigArg0.get()); 1137429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(1, OrigArg1.get()); 11381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1139429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent()) 1140cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 1141cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 11421b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // If the common type isn't a real floating type, then the arguments were 11431b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // invalid for this operation. 11441b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner if (!Res->isRealFloatingType()) 1145429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return Diag(OrigArg0.get()->getLocStart(), 1146fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_invalid_ordered_compare) 1147429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << OrigArg0.get()->getType() << OrigArg1.get()->getType() 1148429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd()); 11491eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11501b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner return false; 11511b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner} 11521b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner 1153e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 1154e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends. This is declared to take (...), so we have 11553b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point 11563b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value. 11573b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 11583b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() < NumArgs) 11599ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1160d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 11613b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() > NumArgs) 11623b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer return Diag(TheCall->getArg(NumArgs)->getLocStart(), 11639ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_too_many_args) 1164ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 11653b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 11669ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman (*(TheCall->arg_end()-1))->getLocEnd()); 11679ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 11683b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer Expr *OrigArg = TheCall->getArg(NumArgs-1); 11691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11709ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (OrigArg->isTypeDependent()) 11719ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 11729ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 117381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // This operation requires a non-_Complex floating-point number. 11749ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (!OrigArg->getType()->isRealFloatingType()) 11751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg->getLocStart(), 11769ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_invalid_unary_fp) 11779ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman << OrigArg->getType() << OrigArg->getSourceRange(); 11781eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 117981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // If this is an implicit conversion from float -> double, remove it. 118081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 118181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Expr *CastArg = Cast->getSubExpr(); 118281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 118381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 118481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner "promotion from float to double is the only expected cast here"); 118581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Cast->setSubExpr(0); 118681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner TheCall->setArg(NumArgs-1, CastArg); 118781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner OrigArg = CastArg; 118881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 118981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 119081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner 11919ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 11929ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman} 11939ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 1194d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 1195d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything. 119660d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 119737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() < 2) 11980eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocEnd(), 1199d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 120037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1201d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << TheCall->getSourceRange()); 1202d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 120337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Determine which of the following types of shufflevector we're checking: 120437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 1) unary, vector mask: (lhs, mask) 120537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 2) binary, vector mask: (lhs, rhs, mask) 120637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 120737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType resType = TheCall->getArg(0)->getType(); 120837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numElements = 0; 120937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 1210cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (!TheCall->getArg(0)->isTypeDependent() && 1211cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor !TheCall->getArg(1)->isTypeDependent()) { 121237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType LHSType = TheCall->getArg(0)->getType(); 121337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType RHSType = TheCall->getArg(1)->getType(); 121437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 121537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!LHSType->isVectorType() || !RHSType->isVectorType()) { 1216cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) 12171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1218cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1219cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 1220cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 122137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 122237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numElements = LHSType->getAs<VectorType>()->getNumElements(); 122337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numResElements = TheCall->getNumArgs() - 2; 122437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 122537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Check to see if we have a call with 2 vector arguments, the unary shuffle 122637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // with mask. If so, verify that RHS is an integer vector type with the 122737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // same number of elts as lhs. 122837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() == 2) { 1229f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (!RHSType->hasIntegerRepresentation() || 123037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman RHSType->getAs<VectorType>()->getNumElements() != numElements) 123137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 123237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << SourceRange(TheCall->getArg(1)->getLocStart(), 123337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman TheCall->getArg(1)->getLocEnd()); 123437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numResElements = numElements; 123537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } 123637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 1237cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 12381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1239cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1240cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 124137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } else if (numElements != numResElements) { 124237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 1243788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner resType = Context.getVectorType(eltType, numResElements, 1244e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson VectorType::GenericVector); 1245cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 1246d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1247d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1248d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 1249cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 1250cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(i)->isValueDependent()) 1251cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor continue; 1252cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 125337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman llvm::APSInt Result(32); 125437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 125537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman return ExprError(Diag(TheCall->getLocStart(), 125637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman diag::err_shufflevector_nonconstant_argument) 125737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << TheCall->getArg(i)->getSourceRange()); 12580eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 1259d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 12600eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocStart(), 1261fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_shufflevector_argument_too_large) 12620eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl << TheCall->getArg(i)->getSourceRange()); 1263d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1264d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 12655f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<Expr*, 32> exprs; 1266d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1267d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 1268d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman exprs.push_back(TheCall->getArg(i)); 1269d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman TheCall->setArg(i, 0); 1270d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1271d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1272a88dc3079bedf70a5cfc39791727e43a10383006Nate Begeman return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(), 127337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman exprs.size(), resType, 12748189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getCallee()->getLocStart(), 12758189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getRParenLoc())); 1276d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman} 127730ce344307f8a8b00054021307015571f83c7364Chris Lattner 12784493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 12794493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two 12804493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args. 12814493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 1282fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner unsigned NumArgs = TheCall->getNumArgs(); 12834493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1284fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (NumArgs > 3) 1285ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher return Diag(TheCall->getLocEnd(), 1286ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher diag::err_typecheck_call_too_many_args_at_most) 1287ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 3 << NumArgs 1288ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << TheCall->getSourceRange(); 12894493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 12904493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // Argument 0 is checked for us and the remaining arguments must be 12914493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // constant integers. 1292fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner for (unsigned i = 1; i != NumArgs; ++i) { 12934493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar Expr *Arg = TheCall->getArg(i); 1294691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 12959aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman llvm::APSInt Result; 1296691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, i, Result)) 1297691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 12981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12994493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // FIXME: gcc issues a warning and rewrites these to 0. These 13004493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // seems especially odd for the third argument since the default 13014493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // is 3. 1302fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (i == 1) { 13039aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 1) 1304fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 130521fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "1" << Arg->getSourceRange(); 13064493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } else { 13079aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 3) 1308fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 130921fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "3" << Arg->getSourceRange(); 13104493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 13114493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 13124493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1313fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return false; 13144493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar} 13154493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1316691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 1317691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression. 1318691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 1319691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt &Result) { 1320691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(ArgNum); 1321691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 1322691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 1323691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1324691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 1325691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1326691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (!Arg->isIntegerConstantExpr(Result, Context)) 1327691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 13285e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher << FDecl->getDeclName() << Arg->getSourceRange(); 1329691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 133021fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner return false; 133121fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner} 133221fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner 1333d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 1334d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined 1335d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3). 1336fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner// For compatibility check 0-3, llvm only handles 0 and 2. 1337d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 1338691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1339691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1340691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // Check constant-ness first. 1341691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1342691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1343d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1344691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(1); 1345d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 1346fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 1347fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1348d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar } 1349d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1350d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar return false; 1351d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar} 1352d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1353586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 1354d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1. 1355d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 1356d875fed28578835de89cd407e9db4be788596d7cEli Friedman Expr *Arg = TheCall->getArg(1); 1357691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1358cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 1359691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // TODO: This is less than ideal. Overload this to take a value. 1360691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1361691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1362691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1363691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Result != 1) 1364d875fed28578835de89cd407e9db4be788596d7cEli Friedman return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 1365d875fed28578835de89cd407e9db4be788596d7cEli Friedman << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1366d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1367d875fed28578835de89cd407e9db4be788596d7cEli Friedman return false; 1368d875fed28578835de89cd407e9db4be788596d7cEli Friedman} 1369d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1370b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek// Handle i > 1 ? "x" : "y", recursively. 1371082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenekbool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall, 1372082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool HasVAListArg, 1373826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 137455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool isPrintf, bool inFunctionCall) { 13754fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain: 1376cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 1377cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 1378d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1379f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 1380f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 1381d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek switch (E->getStmtClass()) { 138256ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::BinaryConditionalOperatorClass: 1383d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ConditionalOperatorClass: { 138456ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall const AbstractConditionalOperator *C = cast<AbstractConditionalOperator>(E); 1385826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return SemaCheckStringLiteral(C->getTrueExpr(), TheCall, HasVAListArg, 138655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu format_idx, firstDataArg, isPrintf, 138755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu inFunctionCall) 138856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall && SemaCheckStringLiteral(C->getFalseExpr(), TheCall, HasVAListArg, 138955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu format_idx, firstDataArg, isPrintf, 139055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu inFunctionCall); 1391d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1392d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 139395355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek case Stmt::IntegerLiteralClass: 139495355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // Technically -Wformat-nonliteral does not warn about this case. 139595355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // The behavior of printf and friends in this case is implementation 139695355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // dependent. Ideally if the format string cannot be null then 139795355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // it should have a 'nonnull' attribute in the function prototype. 139895355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek return true; 139995355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek 1400d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ImplicitCastExprClass: { 14014fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ImplicitCastExpr>(E)->getSubExpr(); 14024fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 1403d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1404d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 140556ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::OpaqueValueExprClass: 140656ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) { 140756ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall E = src; 140856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall goto tryAgain; 140956ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall } 141056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall return false; 141156ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall 1412b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek case Stmt::PredefinedExprClass: 1413b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // While __func__, etc., are technically not string literals, they 1414b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // cannot contain format specifiers and thus are not a security 1415b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // liability. 1416b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek return true; 1417b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek 1418082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::DeclRefExprClass: { 1419082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const DeclRefExpr *DR = cast<DeclRefExpr>(E); 14201eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1421082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // As an exception, do not flag errors for variables binding to 1422082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // const string literals. 1423082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 1424082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool isConstant = false; 1425082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek QualType T = DR->getType(); 1426082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek 1427082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ArrayType *AT = Context.getAsArrayType(T)) { 1428082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek isConstant = AT->getElementType().isConstant(Context); 1429ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (const PointerType *PT = T->getAs<PointerType>()) { 14301eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump isConstant = T.isConstant(Context) && 1431082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek PT->getPointeeType().isConstant(Context); 1432082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 14331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1434082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (isConstant) { 143531310a21fb2a9f13950f864f681c86080b05d5b2Sebastian Redl if (const Expr *Init = VD->getAnyInitializer()) 1436082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return SemaCheckStringLiteral(Init, TheCall, 1437826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, format_idx, firstDataArg, 143855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu isPrintf, /*inFunctionCall*/false); 1439082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 14401eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1441d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // For vprintf* functions (i.e., HasVAListArg==true), we add a 1442d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // special check to see if the format string is a function parameter 1443d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // of the function calling the printf function. If the function 1444d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // has an attribute indicating it is a printf-like function, then we 1445d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // should suppress warnings concerning non-literals being used in a call 1446d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // to a vprintf function. For example: 1447d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1448d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // void 1449d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 1450d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_list ap; 1451d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_start(ap, fmt); 1452d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 1453d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // ... 1454d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1455d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1456d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // FIXME: We don't have full attribute support yet, so just check to see 1457d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // if the argument is a DeclRefExpr that references a parameter. We'll 1458d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // add proper support for checking the attribute later. 1459d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (HasVAListArg) 1460d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (isa<ParmVarDecl>(VD)) 1461d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson return true; 1462082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 14631eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1464082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1465082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 1466d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 14678f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson case Stmt::CallExprClass: { 14688f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const CallExpr *CE = cast<CallExpr>(E); 14691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump if (const ImplicitCastExpr *ICE 14708f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson = dyn_cast<ImplicitCastExpr>(CE->getCallee())) { 14718f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) { 14728f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) { 147340b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) { 14748f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson unsigned ArgIndex = FA->getFormatIdx(); 14758f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const Expr *Arg = CE->getArg(ArgIndex - 1); 14761eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 14771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg, 147855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu format_idx, firstDataArg, isPrintf, 147955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu inFunctionCall); 14808f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 14818f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 14828f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 14838f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 14841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 14858f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson return false; 14868f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 1487082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::ObjCStringLiteralClass: 1488082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::StringLiteralClass: { 1489082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const StringLiteral *StrE = NULL; 14901eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1491082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 1492d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek StrE = ObjCFExpr->getString(); 1493d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek else 1494082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek StrE = cast<StringLiteral>(E); 14951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1496d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek if (StrE) { 1497826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatString(StrE, E, TheCall, HasVAListArg, format_idx, 149855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu firstDataArg, isPrintf, inFunctionCall); 1499d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return true; 1500d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 15011eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1502d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return false; 1503d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 15041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1505082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek default: 1506082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1507d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1508d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1509d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1510e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid 15111eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull, 1512909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr * const *ExprArgs, 1513909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky SourceLocation CallSiteLoc) { 1514cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt for (NonNullAttr::args_iterator i = NonNull->args_begin(), 1515cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt e = NonNull->args_end(); 1516e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian i != e; ++i) { 1517909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr *ArgExpr = ExprArgs[*i]; 15184e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (ArgExpr->isNullPointerConstant(Context, 1519ce94049b69f75b44c18584fe79cd238978b6b0d5Douglas Gregor Expr::NPC_ValueDependentIsNotNull)) 1520909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange(); 1521e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian } 1522e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian} 1523d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1524826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar 1525826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings. 152659907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnervoid 1527826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSema::CheckPrintfScanfArguments(const CallExpr *TheCall, bool HasVAListArg, 1528826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1529826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 1530826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1531082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *Fn = TheCall->getCallee(); 1532925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner 15334a2614e94672c47395abcde60518776fbebec589Sebastian Redl // The way the format attribute works in GCC, the implicit this argument 15344a2614e94672c47395abcde60518776fbebec589Sebastian Redl // of member functions is counted. However, it doesn't appear in our own 15354a2614e94672c47395abcde60518776fbebec589Sebastian Redl // lists, so decrement format_idx in that case. 15364a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 15379263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth const CXXMethodDecl *method_decl = 15389263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth dyn_cast<CXXMethodDecl>(TheCall->getCalleeDecl()); 15399263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if (method_decl && method_decl->isInstance()) { 15409263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth // Catch a format attribute mistakenly referring to the object argument. 15419263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if (format_idx == 0) 15429263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth return; 15439263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth --format_idx; 15449263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if(firstDataArg != 0) 15459263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth --firstDataArg; 15469263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth } 15474a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 15484a2614e94672c47395abcde60518776fbebec589Sebastian Redl 1549826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // CHECK: printf/scanf-like function is called with no format string. 1550925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (format_idx >= TheCall->getNumArgs()) { 1551826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Diag(TheCall->getRParenLoc(), diag::warn_missing_format_string) 1552dcd5ef12488e4c7ea844327835896ca86b609a97Chris Lattner << Fn->getSourceRange(); 155371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek return; 155471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek } 15551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1556082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts(); 15571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 155859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner // CHECK: format string is not a string literal. 15591eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // 156071895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // Dynamically generated format strings are difficult to 156171895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // automatically vet at compile time. Requiring that format strings 156271895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // are string literals: (1) permits the checking of format strings by 156371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // the compiler and thereby (2) can practically remove the source of 156471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // many format string exploits. 15657ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek 15661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // Format string can be either ObjC string (e.g. @"%d") or 15677ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // C string (e.g. "%d") 15681eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // ObjC string uses the same format specifiers as C string, so we can use 15697ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // the same format string checking logic for both ObjC and C strings. 15701cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx, 1571826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek firstDataArg, isPrintf)) 15721cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner return; // Literal format string found, check done! 15731cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner 1574655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // If there are no arguments specified, warn with -Wformat-security, otherwise 1575655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // warn only with -Wformat-nonliteral. 1576655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner if (TheCall->getNumArgs() == format_idx+1) 15771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1578826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral_noargs) 1579655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1580655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner else 15811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1582826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral) 1583655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1584d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1585d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1586e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace { 1587826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler { 1588826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1589e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Sema &S; 1590e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const StringLiteral *FExpr; 1591e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const Expr *OrigFormatExpr; 15926ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const unsigned FirstDataArg; 1593e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const unsigned NumDataArgs; 1594e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const bool IsObjCLiteral; 1595e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *Beg; // Start of format string. 15960d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const bool HasVAListArg; 15970d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const CallExpr *TheCall; 15980d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek unsigned FormatIdx; 15997f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek llvm::BitVector CoveredArgs; 1600efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool usesPositionalArgs; 1601efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool atFirstArg; 160255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool inFunctionCall; 16034e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic: 1604826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 16056ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1606e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 16070d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const char *beg, bool hasVAListArg, 160855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const CallExpr *theCall, unsigned formatIdx, 160955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool inFunctionCall) 1610e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 16116ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek FirstDataArg(firstDataArg), 16127f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek NumDataArgs(numDataArgs), 16130d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek IsObjCLiteral(isObjCLiteral), Beg(beg), 16140d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek HasVAListArg(hasVAListArg), 1615efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek TheCall(theCall), FormatIdx(formatIdx), 161655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu usesPositionalArgs(false), atFirstArg(true), 161755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu inFunctionCall(inFunctionCall) { 16187f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.resize(numDataArgs); 16197f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.reset(); 16207f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 16214e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 162207d161f38e708a91486bf1c031d525faebbb249dTed Kremenek void DoneProcessing(); 16234e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1624826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIncompleteSpecifier(const char *startSpecifier, 1625826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1626826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1627efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleInvalidPosition(const char *startSpecifier, 1628efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned specifierLen, 1629826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p); 1630efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1631efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 1632efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1633e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek void HandleNullChar(const char *nullCharacter); 16344e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 163555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 163655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu static void EmitFormatDiagnostic(Sema &S, bool inFunctionCall, 163755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 163855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 163955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation StringLoc, 164055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 164155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint Fixit = FixItHint()); 164255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 1643826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1644c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 1645c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1646c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1647c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, unsigned csLen); 164855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 164955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void HandlePositionalNonpositionalArgs(SourceLocation Loc, 165055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 165155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen); 1652c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1653f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek SourceRange getFormatStringRange(); 1654826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CharSourceRange getSpecifierRange(const char *startSpecifier, 1655826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1656e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek SourceLocation getLocationOfByte(const char *x); 16574e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 16580d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const Expr *getDataArg(unsigned i) const; 1659666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1660666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 1661666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1662666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, 1663666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek unsigned argIndex); 166455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 166555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 166655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc, 166755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 166855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint Fixit = FixItHint()); 166955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 167055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void CheckPositionalAndNonpositionalArgs( 167155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const analyze_format_string::FormatSpecifier *FS); 1672e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}; 1673e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1674e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1675826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() { 1676e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return OrigFormatExpr->getSourceRange(); 1677e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1678e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1679826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler:: 1680826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 168145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation Start = getLocationOfByte(startSpecifier); 168245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 168345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 168445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care // Advance the end SourceLocation by one due to half-open ranges. 1685a64ccefdf0ea4e03ec88805d71b0af74950c7472Argyrios Kyrtzidis End = End.getLocWithOffset(1); 168645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 168745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care return CharSourceRange::getCharRange(Start, End); 1688f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek} 1689f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek 1690826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 16914e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 1692e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1693e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1694826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 1695826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen){ 169655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier), 169755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startSpecifier), 169855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 169955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 1700808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek} 1701808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek 1702efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid 1703826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 1704826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p) { 170555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier) 170655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (unsigned) p, 170755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), /*IsStringLocation*/true, 170855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 1709efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1710efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1711826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos, 1712efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned posLen) { 171355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier), 171455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), 171555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 171655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 1717efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1718efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1719826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 17200c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek if (!IsObjCLiteral) { 17210c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek // The presence of a null character is likely an error. 172255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 172355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_format_string_contains_null_char), 172455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(nullCharacter), /*IsStringLocation*/true, 172555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getFormatStringRange()); 17260c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek } 1727826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1728826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1729826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const { 1730826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return TheCall->getArg(FirstDataArg + i); 1731826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 17324e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1733826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() { 1734826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Does the number of data arguments exceed the number of 1735826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // format conversions in the format string? 1736826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!HasVAListArg) { 1737826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Find any arguments that weren't covered. 1738826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.flip(); 1739826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek signed notCoveredArg = CoveredArgs.find_first(); 1740826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (notCoveredArg >= 0) { 1741826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek assert((unsigned)notCoveredArg < NumDataArgs); 174255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_data_arg_not_used), 174355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getDataArg((unsigned) notCoveredArg)->getLocStart(), 174455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/false, getFormatStringRange()); 1745826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1746826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1747826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1748826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1749c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool 1750c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 1751c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek SourceLocation Loc, 1752c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1753c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1754c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, 1755c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned csLen) { 1756c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1757c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool keepGoing = true; 1758c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek if (argIndex < NumDataArgs) { 1759c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // Consider the argument coverered, even though the specifier doesn't 1760c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // make sense. 1761c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CoveredArgs.set(argIndex); 1762c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1763c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek else { 1764c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // If argIndex exceeds the number of data arguments we 1765c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // don't issue a warning because that is just a cascade of warnings (and 1766c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // they may have intended '%%' anyway). We don't want to continue processing 1767c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // the format string after this point, however, as we will like just get 1768c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // gibberish when trying to match arguments. 1769c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek keepGoing = false; 1770c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1771c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 177255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_conversion) 177355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << StringRef(csStart, csLen), 177455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*IsStringLocation*/true, 177555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpec, specifierLen)); 1776c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1777c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return keepGoing; 1778c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1779c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 178055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid 178155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard TrieuCheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc, 178255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 178355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen) { 178455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 178555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_format_mix_positional_nonpositional_args), 178655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen)); 178755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 178855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 1789666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool 1790666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs( 1791666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::FormatSpecifier &FS, 1792666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1793666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 1794666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1795666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (argIndex >= NumDataArgs) { 179655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag = FS.usesPositionalArg() 179755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args) 179855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (argIndex+1) << NumDataArgs) 179955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : S.PDiag(diag::warn_printf_insufficient_data_args); 180055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 180155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true, 180255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 1803666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return false; 1804666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1805666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return true; 1806666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek} 1807666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 180855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 180955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag, 181055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 181155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 181255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 181355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint FixIt) { 181455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S, inFunctionCall, TheCall->getArg(FormatIdx), PDiag, 181555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, IsStringLocation, StringRange, FixIt); 181655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 181755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 181855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \brief If the format string is not within the funcion call, emit a note 181955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// so that the function call and string are in diagnostic messages. 182055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 182155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param inFunctionCall if true, the format string is within the function 182255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// call and only one diagnostic message will be produced. Otherwise, an 182355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// extra note will be emitted pointing to location of the format string. 182455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 182555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param ArgumentExpr the expression that is passed as the format string 182655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// argument in the function call. Used for getting locations when two 182755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostics are emitted. 182855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 182955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param PDiag the callee should already have provided any strings for the 183055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostic message. This function only adds locations and fixits 183155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// to diagnostics. 183255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 183355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param Loc primary location for diagnostic. If two diagnostics are 183455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// required, one will be at Loc and a new SourceLocation will be created for 183555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// the other one. 183655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 183755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param IsStringLocation if true, Loc points to the format string should be 183855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// used for the note. Otherwise, Loc points to the argument list and will 183955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// be used with PDiag. 184055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 184155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param StringRange some or all of the string to highlight. This is 184255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// templated so it can accept either a CharSourceRange or a SourceRange. 184355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 184455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param Fixit optional fix it hint for the format string. 184555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 184655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(Sema &S, bool InFunctionCall, 184755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 184855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 184955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 185055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 185155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 185255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint FixIt) { 185355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu if (InFunctionCall) 185455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.Diag(Loc, PDiag) << StringRange << FixIt; 185555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu else { 185655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag) 185755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ArgumentExpr->getSourceRange(); 185855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.Diag(IsStringLocation ? Loc : StringRange.getBegin(), 185955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu diag::note_format_string_defined) 186055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << StringRange << FixIt; 186155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu } 186255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 186355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 1864826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===// 1865826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1866826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 1867826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler { 1868826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 1869826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 1870826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1871826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 1872826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 187355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const CallExpr *theCall, unsigned formatIdx, 187455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool inFunctionCall) 1875826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1876826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 187755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu theCall, formatIdx, inFunctionCall) {} 1878826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1879826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1880826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleInvalidPrintfConversionSpecifier( 1881826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1882826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1883826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1884826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1885826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 1886826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1887826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1888826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1889826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 1890826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1891826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 1892826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalAmount &Amt, 1893826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned type, 1894826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1895826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1896826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1897826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1898826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 1899826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &ignoredFlag, 1900826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1901826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1902826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 1903826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1904826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1905826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 1906826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1907826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1908826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 19096ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 1910c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 1911826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1912c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1913c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 1914c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 1915c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 191626ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek} 191726ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek 1918826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount( 1919826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_format_string::OptionalAmount &Amt, 1920826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned k, const char *startSpecifier, 1921826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 19220d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 19230d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (Amt.hasDataArgument()) { 19240d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (!HasVAListArg) { 19257f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = Amt.getArgIndex(); 19267f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (argIndex >= NumDataArgs) { 192755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg) 192855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << k, 192955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 193055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 193155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 19320d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 19330d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 19340d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 19350d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 19364e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 19370d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Type check the data argument. It should be an 'int'. 193831f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // Although not in conformance with C99, we also allow the argument to be 193931f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // an 'unsigned int' as that is a reasonably safe case. GCC also 194031f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // doesn't emit a warning for that case. 19417f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.set(argIndex); 19427f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek const Expr *Arg = getDataArg(argIndex); 19430d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek QualType T = Arg->getType(); 19444e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 19454e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context); 19464e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek assert(ATR.isValid()); 19474e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 19484e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (!ATR.matchesType(S.Context, T)) { 194955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type) 1950a792aff1c7de253b89c473fdb7eef4a5bba83aecHans Wennborg << k << ATR.getRepresentativeTypeName(S.Context) 195155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << T << Arg->getSourceRange(), 195255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 195355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 195455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 19550d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 19560d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 19570d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 19580d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 19590d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 19600d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 19610d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return true; 19620d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek} 19630d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1964e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount( 1965826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1966e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalAmount &Amt, 1967e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned type, 1968e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1969e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 19706ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 19716ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1972e4ee9663168dfb2b4122c768091e30217328c9faTom Care 197355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint fixit = 197455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant 197555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 197655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getConstantLength())) 197755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : FixItHint(); 197855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 197955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount) 198055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << type << CS.toString(), 198155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 198255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 198355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 198455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu fixit); 1985e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1986e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1987826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1988e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 1989e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1990e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 1991e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about pointless flag with a fixit removal. 19926ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 19936ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 199455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag) 199555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << flag.toString() << CS.toString(), 199655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(flag.getPosition()), 199755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 199855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 199955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 200055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(flag.getPosition(), 1))); 2001e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2002e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2003e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag( 2004826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2005e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &ignoredFlag, 2006e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 2007e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2008e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 2009e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about ignored flag with a fixit removal. 201055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag) 201155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ignoredFlag.toString() << flag.toString(), 201255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(ignoredFlag.getPosition()), 201355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 201455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 201555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 201655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(ignoredFlag.getPosition(), 1))); 2017e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2018e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2019e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool 2020826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 20215c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek &FS, 2022e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *startSpecifier, 2023e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned specifierLen) { 2024e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 20256ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek using namespace analyze_format_string; 2026efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek using namespace analyze_printf; 20276ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 2028e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2029baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 2030baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 2031baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 2032baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 2033baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2034baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 203555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 203655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 2037baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 2038baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2039efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek } 2040efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 20410d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // First check if the field width, precision, and conversion specifier 20420d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // have matching data arguments. 2043efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 2044efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 20450d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 20460d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 20474e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2048efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 2049efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 20500d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 20510d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 20520d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 2053f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek if (!CS.consumesDataArgument()) { 2054f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // FIXME: Technically specifying a precision or field width here 2055f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // makes no sense. Worth issuing a warning at some point. 20560e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek return true; 2057f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek } 20584e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 20597f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Consume the argument. 20607f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = FS.getArgIndex(); 2061e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek if (argIndex < NumDataArgs) { 2062e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // The check to see if the argIndex is valid will come later. 2063e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // We set the bit here because we may exit early from this 2064e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // function if we encounter some other error. 2065e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek CoveredArgs.set(argIndex); 2066e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek } 20677f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek 20687f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Check for using an Objective-C specific conversion specifier 20697f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // in a non-ObjC literal. 20707f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (!IsObjCLiteral && CS.isObjCArg()) { 2071826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 2072826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek specifierLen); 20737f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 20744e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2075e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of field width 2076e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidFieldWidth()) { 207745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 2078e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2079e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2080e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2081e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of precision 2082e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPrecision()) { 2083e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 2084e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2085e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2086e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2087e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check each flag does not conflict with any other component. 208865197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek if (!FS.hasValidThousandsGroupingPrefix()) 208965197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen); 2090e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeadingZeros()) 2091e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 2092e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPlusPrefix()) 2093e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 209445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (!FS.hasValidSpacePrefix()) 209545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 2096e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidAlternativeForm()) 2097e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 2098e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeftJustified()) 2099e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 2100e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2101e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check that flags are not ignored by another flag 210245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 210345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 210445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care startSpecifier, specifierLen); 2105e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 2106e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 2107e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2108e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2109e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check the length modifier is valid with the given conversion specifier. 2110e4ee9663168dfb2b4122c768091e30217328c9faTom Care const LengthModifier &LM = FS.getLengthModifier(); 2111e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLengthModifier()) 211255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_nonsensical_length) 211355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << LM.toString() << CS.toString(), 211455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(LM.getStart()), 211555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 211655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 211755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 211855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(LM.getStart(), 211955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu LM.getLength()))); 2120e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2121e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Are we using '%n'? 212235d353b47bce29200b910371dd9b8ba7f3058ab8Ted Kremenek if (CS.getKind() == ConversionSpecifier::nArg) { 2123e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Issue a warning about this being a possible security issue. 212455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_write_back), 212555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(CS.getStart()), 212655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 212755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 2128e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek // Continue checking the other format specifiers. 2129e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek return true; 2130e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek } 21315c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek 2132da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek // The remaining checks depend on the data arguments. 2133da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek if (HasVAListArg) 2134da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return true; 21354e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2136666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 2137da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return false; 21384e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 213996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Now type check the data expression that matches the 214096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // format specifier. 214196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const Expr *Ex = getDataArg(argIndex); 2142687b5df89d4ba91219df578d02087c68c09a0332Nick Lewycky const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context); 214396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) { 214496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Check if we didn't match because of an implicit cast from a 'char' 214596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // or 'short' to an 'int'. This is done because printf is a varargs 214696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // function. 214796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex)) 21484d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ICE->getType() == S.Context.IntTy) { 21494d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek // All further checking is done on the subexpression. 21504d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek Ex = ICE->getSubExpr(); 21514d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ATR.matchesType(S.Context, Ex->getType())) 215296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer return true; 21534d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek } 215496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 215596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // We may be able to offer a FixItHint if it is a supported type. 215696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer PrintfSpecifier fixedFS = FS; 2157a7da2155167676a6a5d9fca4de947a9cab2a4908Hans Wennborg bool success = fixedFS.fixType(Ex->getType(), S.getLangOptions()); 215896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 215996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (success) { 216096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Get the fix string from the fixed format specifier 216196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::SmallString<128> buf; 216296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::raw_svector_ostream os(buf); 216396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer fixedFS.toString(os); 216496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 216555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 216655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 2167a792aff1c7de253b89c473fdb7eef4a5bba83aecHans Wennborg << ATR.getRepresentativeTypeName(S.Context) << Ex->getType() 216855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << Ex->getSourceRange(), 216955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(CS.getStart()), 217055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 217155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 217255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateReplacement( 217355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 217455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu os.str())); 217596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 217696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer else { 217796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer S.Diag(getLocationOfByte(CS.getStart()), 217896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer diag::warn_printf_conversion_argument_type_mismatch) 2179a792aff1c7de253b89c473fdb7eef4a5bba83aecHans Wennborg << ATR.getRepresentativeTypeName(S.Context) << Ex->getType() 218096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << getSpecifierRange(startSpecifier, specifierLen) 218196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << Ex->getSourceRange(); 218296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 218396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 218496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2185e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return true; 2186e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2187e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2188826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===// 2189826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2190826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 2191826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler { 2192826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 2193826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 2194826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 2195826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 2196826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 219755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const CallExpr *theCall, unsigned formatIdx, 219855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool inFunctionCall) 2199826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 2200826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 220155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu theCall, formatIdx, inFunctionCall) {} 2202826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2203826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 2204826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2205826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2206c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2207c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidScanfConversionSpecifier( 2208c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2209c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 2210c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen); 2211b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 2212b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek void HandleIncompleteScanList(const char *start, const char *end); 2213826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 2214826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2215826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2216b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start, 2217b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek const char *end) { 221855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete), 221955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(end), /*IsStringLocation*/true, 222055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(start, end - start)); 2221b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek} 2222b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 2223c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 2224c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2225c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 2226c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen) { 2227c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 22286ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_scanf::ScanfConversionSpecifier &CS = 2229c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 2230c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2231c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 2232c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 2233c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 2234c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 2235c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 2236c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2237826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier( 2238826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2239826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2240826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 2241826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2242826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_scanf; 2243826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_format_string; 2244826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 22456ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 2246826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2247baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Handle case where '%' and '*' don't consume an argument. These shouldn't 2248baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // be used to decide if we are using positional arguments consistently. 2249baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 2250baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 2251baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 2252baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 2253baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2254baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 225555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 225655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 2257baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 2258baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2259826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2260826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2261826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Check if the field with is non-zero. 2262826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const OptionalAmount &Amt = FS.getFieldWidth(); 2263826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getHowSpecified() == OptionalAmount::Constant) { 2264826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getConstantAmount() == 0) { 2265826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 2266826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Amt.getConstantLength()); 226755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width), 226855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 226955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, R, 227055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval(R)); 22717f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 22727f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 2273826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2274826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!FS.consumesDataArgument()) { 2275826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Technically specifying a precision or field width here 2276826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // makes no sense. Worth issuing a warning at some point. 2277826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 2278826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2279826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2280826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Consume the argument. 2281826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned argIndex = FS.getArgIndex(); 2282826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (argIndex < NumDataArgs) { 2283826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The check to see if the argIndex is valid will come later. 2284826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // We set the bit here because we may exit early from this 2285826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // function if we encounter some other error. 2286826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.set(argIndex); 2287826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2288826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 22891e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek // Check the length modifier is valid with the given conversion specifier. 22901e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek const LengthModifier &LM = FS.getLengthModifier(); 22911e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek if (!FS.hasValidLengthModifier()) { 22921e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek S.Diag(getLocationOfByte(LM.getStart()), 22931e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek diag::warn_format_nonsensical_length) 22941e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << LM.toString() << CS.toString() 22951e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 22961e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 22971e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek LM.getLength())); 22981e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek } 22991e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek 2300826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The remaining checks depend on the data arguments. 2301826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (HasVAListArg) 2302826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 2303826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2304666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 2305826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return false; 2306826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 23076fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Check that the argument type matches the format specifier. 23086fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg const Expr *Ex = getDataArg(argIndex); 23096fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg const analyze_scanf::ScanfArgTypeResult &ATR = FS.getArgType(S.Context); 23106fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) { 23116fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg ScanfSpecifier fixedFS = FS; 23126fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg bool success = fixedFS.fixType(Ex->getType(), S.getLangOptions()); 23136fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 23146fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg if (success) { 23156fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Get the fix string from the fixed format specifier. 23166fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg llvm::SmallString<128> buf; 23176fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg llvm::raw_svector_ostream os(buf); 23186fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg fixedFS.toString(os); 23196fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 23206fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg EmitFormatDiagnostic( 23216fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 23226fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg << ATR.getRepresentativeTypeName(S.Context) << Ex->getType() 23236fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg << Ex->getSourceRange(), 23246fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getLocationOfByte(CS.getStart()), 23256fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg /*IsStringLocation*/true, 23266fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 23276fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg FixItHint::CreateReplacement( 23286fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 23296fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg os.str())); 23306fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } else { 23316fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg S.Diag(getLocationOfByte(CS.getStart()), 23326fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg diag::warn_printf_conversion_argument_type_mismatch) 23336fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg << ATR.getRepresentativeTypeName(S.Context) << Ex->getType() 23346fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg << getSpecifierRange(startSpecifier, specifierLen) 23356fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg << Ex->getSourceRange(); 23366fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 23376fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 23386fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 2339826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 234007d161f38e708a91486bf1c031d525faebbb249dTed Kremenek} 2341e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2342826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr, 23430e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const Expr *OrigFormatExpr, 23440e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const CallExpr *TheCall, bool HasVAListArg, 2345826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 234655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool isPrintf, bool inFunctionCall) { 2347826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2348e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: is the format string a wide literal? 23495cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!FExpr->isAscii()) { 235055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 235155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu *this, inFunctionCall, TheCall->getArg(format_idx), 235255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(), 235355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 2354e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 2355e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 2356826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2357e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // Str - The format string. NOTE: this is NOT null-terminated! 23585f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef StrRef = FExpr->getString(); 23592f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer const char *Str = StrRef.data(); 23602f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer unsigned StrLen = StrRef.size(); 23614cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek const unsigned numDataArgs = TheCall->getNumArgs() - firstDataArg; 2362826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2363e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: empty format string? 23644cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek if (StrLen == 0 && numDataArgs > 0) { 236555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 236655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu *this, inFunctionCall, TheCall->getArg(format_idx), 236755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_empty_format_string), FExpr->getLocStart(), 236855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 2369e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 2370e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 2371826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2372826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (isPrintf) { 2373826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 23744cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek numDataArgs, isa<ObjCStringLiteral>(OrigFormatExpr), 237555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Str, HasVAListArg, TheCall, format_idx, 237655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu inFunctionCall); 2377826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2378d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen, 2379d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg getLangOptions())) 2380826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 2381826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2382826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek else { 2383826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 23844cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek numDataArgs, isa<ObjCStringLiteral>(OrigFormatExpr), 238555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Str, HasVAListArg, TheCall, format_idx, 238655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu inFunctionCall); 2387826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2388d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen, 2389d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg getLangOptions())) 2390826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 2391826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2392ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek} 2393ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek 23947ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth//===--- CHECK: Standard memory functions ---------------------------------===// 23957ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 23962a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// \brief Determine whether the given type is a dynamic class type (e.g., 23972a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// whether it has a vtable). 23982a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregorstatic bool isDynamicClassType(QualType T) { 23992a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Record = T->getAsCXXRecordDecl()) 24002a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Definition = Record->getDefinition()) 24012a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (Definition->isDynamicClass()) 24022a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return true; 24032a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 24042a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return false; 24052a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor} 24062a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 2407a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument expression, 2408000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth/// otherwise returns NULL. 2409000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic const Expr *getSizeOfExprArg(const Expr* E) { 2410e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber if (const UnaryExprOrTypeTraitExpr *SizeOf = 2411000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 2412000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType()) 2413000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getArgumentExpr()->IgnoreParenImpCasts(); 2414e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 2415000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return 0; 2416000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth} 2417000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2418a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument type. 2419000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic QualType getSizeOfArgType(const Expr* E) { 2420000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryExprOrTypeTraitExpr *SizeOf = 2421000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 2422000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf) 2423000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getTypeOfArgument(); 2424000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2425000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return QualType(); 2426e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber} 2427e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 24287ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \brief Check for dangerous or invalid arguments to memset(). 24297ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 2430929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth/// This issues warnings on known problematic, dangerous or unspecified 2431cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp' 2432cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// function calls. 24337ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 24347ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \param Call The call expression to diagnose. 2435cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gayvoid Sema::CheckMemaccessArguments(const CallExpr *Call, 24360a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned BId, 2437cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay IdentifierInfo *FnName) { 24380a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks assert(BId != 0); 24390a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 24401d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek // It is possible to have a non-standard definition of memset. Validate 2441707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor // we have enough arguments, and if not, abort further checking. 24420a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned ExpectedNumArgs = (BId == Builtin::BIstrndup ? 2 : 3); 2443cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber if (Call->getNumArgs() < ExpectedNumArgs) 24441d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek return; 24451d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek 24460a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LastArg = (BId == Builtin::BImemset || 24470a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId == Builtin::BIstrndup ? 1 : 2); 24480a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LenArg = (BId == Builtin::BIstrndup ? 1 : 2); 2449cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts(); 2450000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2451000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We have special checking when the length is a sizeof expression. 2452000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth QualType SizeOfArgTy = getSizeOfArgType(LenExpr); 2453000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth const Expr *SizeOfArg = getSizeOfExprArg(LenExpr); 2454000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID SizeOfArgID; 2455000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 245606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) { 245706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts(); 2458e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange(); 245906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 246006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType DestTy = Dest->getType(); 246106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) { 246206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType PointeeTy = DestPtrTy->getPointeeType(); 2463f85e193739c953358c865005855253af4f68a497John McCall 2464000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Never warn about void type pointers. This can be used to suppress 2465000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // false positives. 2466000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isVoidType()) 246706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 246806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 2469000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by 2470000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // actually comparing the expressions for equality. Because computing the 2471000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // expression IDs can be expensive, we only do this if the diagnostic is 2472000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // enabled. 2473000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArg && 2474000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess, 2475000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->getExprLoc())) { 2476000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We only compute IDs for expressions if the warning is enabled, and 2477000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // cache the sizeof arg's ID. 2478000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgID == llvm::FoldingSetNodeID()) 2479000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->Profile(SizeOfArgID, Context, true); 2480000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID DestID; 2481000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Dest->Profile(DestID, Context, true); 2482000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (DestID == SizeOfArgID) { 2483cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // TODO: For strncpy() and friends, this could suggest sizeof(dst) 2484cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // over sizeof(src) as well. 2485000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth unsigned ActionIdx = 0; // Default is to suggest dereferencing. 2486000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest)) 2487000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (UnaryOp->getOpcode() == UO_AddrOf) 2488000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 1; // If its an address-of operator, just remove it. 2489000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (Context.getTypeSize(PointeeTy) == Context.getCharWidth()) 2490000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 2; // If the pointee's size is sizeof(char), 2491000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // suggest an explicit length. 2492d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks unsigned DestSrcSelect = 24930a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks (BId == Builtin::BIstrndup ? 1 : ArgIdx); 2494000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(SizeOfArg->getExprLoc(), Dest, 2495000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_expr_memaccess) 2496cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber << FnName << DestSrcSelect << ActionIdx 2497000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << Dest->getSourceRange() 2498000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << SizeOfArg->getSourceRange()); 2499000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 2500000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 2501000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 2502000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2503000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Also check for cases where the sizeof argument is the exact same 2504000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // type as the memory argument, and where it points to a user-defined 2505000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // record type. 2506000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgTy != QualType()) { 2507000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isRecordType() && 2508000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Context.typesAreCompatible(SizeOfArgTy, DestTy)) { 2509000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest, 2510000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_type_memaccess) 2511000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << FnName << SizeOfArgTy << ArgIdx 2512000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << PointeeTy << Dest->getSourceRange() 2513000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << LenExpr->getSourceRange()); 2514000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 2515000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 2516e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber } 2517e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 251806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor // Always complain about dynamic classes. 25190a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (isDynamicClassType(PointeeTy)) { 25200a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 25210a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned OperationType = 0; 25220a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // "overwritten" if we're warning about the destination for any call 25230a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // but memcmp; otherwise a verb appropriate to the call. 25240a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (ArgIdx != 0 || BId == Builtin::BImemcmp) { 25250a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (BId == Builtin::BImemcpy) 25260a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 1; 25270a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if(BId == Builtin::BImemmove) 25280a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 2; 25290a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if (BId == Builtin::BImemcmp) 25300a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 3; 25310a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } 25320a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 25335c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 25345c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 25355c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_dyn_class_memaccess) 25360a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx) 2537d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks << FnName << PointeeTy 25380a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << OperationType 25395c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 25400a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } else if (PointeeTy.hasNonTrivialObjCLifetime() && 25410a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId != Builtin::BImemset) 25425c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 25435c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 25445c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_arc_object_memaccess) 25455c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << ArgIdx << FnName << PointeeTy 25465c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 2547f85e193739c953358c865005855253af4f68a497John McCall else 254806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 2549f85e193739c953358c865005855253af4f68a497John McCall 2550f85e193739c953358c865005855253af4f68a497John McCall DiagRuntimeBehavior( 2551f85e193739c953358c865005855253af4f68a497John McCall Dest->getExprLoc(), Dest, 2552929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth PDiag(diag::note_bad_memaccess_silence) 255306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)")); 255406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor break; 255506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 25567ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth } 25577ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth} 25587ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 2559bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// A little helper routine: ignore addition and subtraction of integer literals. 2560bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// This intentionally does not ignore all integer constant expressions because 2561bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// we don't want to remove sizeof(). 2562bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekstatic const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) { 2563bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = Ex->IgnoreParenCasts(); 2564bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2565bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek for (;;) { 2566bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex); 2567bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!BO || !BO->isAdditiveOp()) 2568bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 2569bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2570bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *RHS = BO->getRHS()->IgnoreParenCasts(); 2571bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *LHS = BO->getLHS()->IgnoreParenCasts(); 2572bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2573bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (isa<IntegerLiteral>(RHS)) 2574bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = LHS; 2575bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else if (isa<IntegerLiteral>(LHS)) 2576bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = RHS; 2577bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else 2578bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 2579bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2580bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2581bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return Ex; 2582bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 2583bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2584bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// Warn if the user has made the 'size' argument to strlcpy or strlcat 2585bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// be the size of the source, instead of the destination. 2586bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekvoid Sema::CheckStrlcpycatArguments(const CallExpr *Call, 2587bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek IdentifierInfo *FnName) { 2588bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2589bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Don't crash if the user has the wrong number of arguments 2590bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (Call->getNumArgs() != 3) 2591bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2592bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2593bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context); 2594bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context); 2595bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *CompareWithSrc = NULL; 2596bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2597bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, sizeof(x))' 2598bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const Expr *Ex = getSizeOfExprArg(SizeArg)) 2599bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = Ex; 2600bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else { 2601bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, strlen(x))' 2602bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) { 2603180f47959a066795cc0f409433023af448bb0328Richard Smith if (SizeCall->isBuiltinCall() == Builtin::BIstrlen 2604bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek && SizeCall->getNumArgs() == 1) 2605bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context); 2606bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2607bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2608bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2609bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrc) 2610bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2611bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2612bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Determine if the argument to sizeof/strlen is equal to the source 2613bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // argument. In principle there's all kinds of things you could do 2614bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // here, for instance creating an == expression and evaluating it with 2615bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // EvaluateAsBooleanCondition, but this uses a more direct technique: 2616bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg); 2617bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!SrcArgDRE) 2618bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2619bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2620bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc); 2621bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrcDRE || 2622bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl()) 2623bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2624bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2625bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *OriginalSizeArg = Call->getArg(2); 2626bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size) 2627bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek << OriginalSizeArg->getSourceRange() << FnName; 2628bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2629bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Output a FIXIT hint if the destination is an array (rather than a 2630bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointer to an array). This could be enhanced to handle some 2631bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointers if we know the actual size, like if DstArg is 'array+2' 2632bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // we could say 'sizeof(array)-2'. 2633bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts(); 26348f7462237ff542a4556775f98709ed300aa1731aTed Kremenek QualType DstArgTy = DstArg->getType(); 2635bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 26368f7462237ff542a4556775f98709ed300aa1731aTed Kremenek // Only handle constant-sized or VLAs, but not flexible members. 26378f7462237ff542a4556775f98709ed300aa1731aTed Kremenek if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(DstArgTy)) { 26388f7462237ff542a4556775f98709ed300aa1731aTed Kremenek // Only issue the FIXIT for arrays of size > 1. 26398f7462237ff542a4556775f98709ed300aa1731aTed Kremenek if (CAT->getSize().getSExtValue() <= 1) 26408f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 26418f7462237ff542a4556775f98709ed300aa1731aTed Kremenek } else if (!DstArgTy->isVariableArrayType()) { 26428f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 2643bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 26448f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 26458f7462237ff542a4556775f98709ed300aa1731aTed Kremenek llvm::SmallString<128> sizeString; 26468f7462237ff542a4556775f98709ed300aa1731aTed Kremenek llvm::raw_svector_ostream OS(sizeString); 26478f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << "sizeof("; 26488987b2385d9ba63ada66e1344ace79b04d5cb5c3Douglas Gregor DstArg->printPretty(OS, Context, 0, getPrintingPolicy()); 26498f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << ")"; 26508f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 26518f7462237ff542a4556775f98709ed300aa1731aTed Kremenek Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size) 26528f7462237ff542a4556775f98709ed300aa1731aTed Kremenek << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(), 26538f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS.str()); 2654bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 2655bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 265606de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===// 265706de276fff91264437fa75111ed76de43097e089Ted Kremenek 26585f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars); 26595f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars); 266006de276fff91264437fa75111ed76de43097e089Ted Kremenek 266106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address 266206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable. 266306de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid 266406de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 266506de276fff91264437fa75111ed76de43097e089Ted Kremenek SourceLocation ReturnLoc) { 26661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 266726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Expr *stackE = 0; 26685f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<DeclRefExpr *, 8> refVars; 26694e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 267026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Perform checking for returned stack addresses, local blocks, 267126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // label addresses or references to temporaries. 2672f85e193739c953358c865005855253af4f68a497John McCall if (lhsType->isPointerType() || 2673f85e193739c953358c865005855253af4f68a497John McCall (!getLangOptions().ObjCAutoRefCount && lhsType->isBlockPointerType())) { 267426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalAddr(RetValExp, refVars); 2675ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (lhsType->isReferenceType()) { 267626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalVal(RetValExp, refVars); 267726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 267826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 267926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (stackE == 0) 268026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return; // Nothing suspicious was found. 268126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 268226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceLocation diagLoc; 268326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange diagRange; 268426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (refVars.empty()) { 268526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = stackE->getLocStart(); 268626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = stackE->getSourceRange(); 268726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { 268826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // We followed through a reference variable. 'stackE' contains the 268926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // problematic expression but we will warn at the return statement pointing 269026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // at the reference variable. We will later display the "trail" of 269126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // reference variables using notes. 269226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = refVars[0]->getLocStart(); 269326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = refVars[0]->getSourceRange(); 269426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 269526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 269626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var. 269726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref 269826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_stack_addr) 269926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << DR->getDecl()->getDeclName() << diagRange; 270026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<BlockExpr>(stackE)) { // local block. 270126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::err_ret_local_block) << diagRange; 270226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 270326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 270426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { // local temporary. 270526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref 270626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_local_temp_addr) 270726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << diagRange; 270826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 270926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 271026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Display the "trail" of reference variables that we followed until we 271126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // found the problematic expression using notes. 271226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 271326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 271426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this var binds to another reference var, show the range of the next 271526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // var, otherwise the var binds to the problematic expression, in which case 271626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // show the range of the expression. 271726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange() 271826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : stackE->getSourceRange(); 271926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(VD->getLocation(), diag::note_ref_var_local_bind) 272026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << VD->getDeclName() << range; 272106de276fff91264437fa75111ed76de43097e089Ted Kremenek } 272206de276fff91264437fa75111ed76de43097e089Ted Kremenek} 272306de276fff91264437fa75111ed76de43097e089Ted Kremenek 272406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 272506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// check if the expression in a return statement evaluates to an address 272626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// to a location on the stack, a local block, an address of a label, or a 272726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// reference to local temporary. The recursion is used to traverse the 272806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// AST of the return expression, with recursion backtracking when we 272926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// encounter a subexpression that (1) clearly does not lead to one of the 273026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// above problematic expressions (2) is something we cannot determine leads to 273126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// a problematic expression based on such local checking. 273226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 273326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// Both EvalAddr and EvalVal follow through reference variables to evaluate 273426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// the expression that they point to. Such variables are added to the 273526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 'refVars' vector so that we know what the reference variable "trail" was. 273606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 2737e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// EvalAddr processes expressions that are pointers that are used as 2738e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// references (and not L-values). EvalVal handles all other values. 273926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// At the base case of the recursion is a check for the above problematic 274026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// expressions. 274106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 274206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// This implementation handles: 274306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 274406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer-to-pointer casts 274506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * implicit conversions from array references to pointers 274606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of fields 274706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * arbitrary interplay between "&" and "*" operators 274806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer arithmetic from an address of a stack variable 274906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of an array element where the array is on the stack 27505f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars) { 275126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (E->isTypeDependent()) 275226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 275326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 275406de276fff91264437fa75111ed76de43097e089Ted Kremenek // We should only be called for evaluating pointer expressions. 27550f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall assert((E->getType()->isAnyPointerType() || 2756dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff E->getType()->isBlockPointerType() || 2757a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek E->getType()->isObjCQualifiedIdType()) && 2758fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner "EvalAddr only works on pointers"); 27591eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2760f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 2761f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 276206de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 276306de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 276406de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 276506de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 276626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::DeclRefExprClass: { 276726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis DeclRefExpr *DR = cast<DeclRefExpr>(E); 276826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 276926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 277026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this is a reference variable, follow through to the expression that 277126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 277226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage() && 277326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis V->getType()->isReferenceType() && V->hasInit()) { 277426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 277526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 277626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(V->getInit(), refVars); 277726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 277826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 277926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 278026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 278106de276fff91264437fa75111ed76de43097e089Ted Kremenek 2782fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::UnaryOperatorClass: { 2783fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // The only unary operator that make sense to handle here 2784fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // is AddrOf. All others don't make sense as pointers. 2785fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner UnaryOperator *U = cast<UnaryOperator>(E); 27861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 27872de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_AddrOf) 278826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(U->getSubExpr(), refVars); 2789fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 2790fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 2791fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 27921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2793fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::BinaryOperatorClass: { 2794fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle pointer arithmetic. All other binary operators are not valid 2795fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // in this context. 2796fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner BinaryOperator *B = cast<BinaryOperator>(E); 27972de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = B->getOpcode(); 27981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 27992de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op != BO_Add && op != BO_Sub) 2800fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 28011eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2802fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner Expr *Base = B->getLHS(); 28033907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 2804fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Determine which argument is the real pointer base. It could be 2805fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // the RHS argument instead of the LHS. 2806fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner if (!Base->getType()->isPointerType()) Base = B->getRHS(); 28071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2808fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner assert (Base->getType()->isPointerType()); 280926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(Base, refVars); 2810fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 281161f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff 2812fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // For conditional operators we need to see if either the LHS or RHS are 2813fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // valid DeclRefExpr*s. If one of them is valid, we return it. 2814fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ConditionalOperatorClass: { 2815fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner ConditionalOperator *C = cast<ConditionalOperator>(E); 28161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2817fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle the GNU extension for missing LHS. 28189ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (Expr *lhsExpr = C->getLHS()) { 28199ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 28209ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (!lhsExpr->getType()->isVoidType()) 282126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr* LHS = EvalAddr(lhsExpr, refVars)) 28229ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return LHS; 28239ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor } 28249ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor 28259ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 28269ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (C->getRHS()->getType()->isVoidType()) 28279ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return NULL; 282806de276fff91264437fa75111ed76de43097e089Ted Kremenek 282926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(C->getRHS(), refVars); 2830fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 283126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 283226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::BlockExprClass: 2833469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures()) 283426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // local block. 283526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 283626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 283726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::AddrLabelExprClass: 283826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // address of label. 28391eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 284080ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 284180ee6e878a169e6255d4686a91bb696151ff229fJohn McCall return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars); 284280ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 284354b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // For casts, we need to handle conversions from arrays to 284454b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // pointer values, and pointer-to-pointer conversions. 284549badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::ImplicitCastExprClass: 28466eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor case Stmt::CStyleCastExprClass: 2847f85e193739c953358c865005855253af4f68a497John McCall case Stmt::CXXFunctionalCastExprClass: 2848f85e193739c953358c865005855253af4f68a497John McCall case Stmt::ObjCBridgedCastExprClass: { 28490835a3cdeefe714b4959d31127ea155e56393125Argyrios Kyrtzidis Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 285054b5274f2c190331438375ad114dad12ae098b57Ted Kremenek QualType T = SubExpr->getType(); 28511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2852dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (SubExpr->getType()->isPointerType() || 2853dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isBlockPointerType() || 2854dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isObjCQualifiedIdType()) 285526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(SubExpr, refVars); 285654b5274f2c190331438375ad114dad12ae098b57Ted Kremenek else if (T->isArrayType()) 285726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(SubExpr, refVars); 2858fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 285954b5274f2c190331438375ad114dad12ae098b57Ted Kremenek return 0; 2860fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 28611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2862fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // C++ casts. For dynamic casts, static casts, and const casts, we 2863fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // are always converting from a pointer-to-pointer, so we just blow 286449badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // through the cast. In the case the dynamic cast doesn't fail (and 286549badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // return NULL), we take the conservative route and report cases 2866fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // where we return the address of a stack variable. For Reinterpre 286749badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // FIXME: The comment about is wrong; we're not always converting 286849badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // from pointer to pointer. I'm guessing that this code should also 28691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // handle references to objects. 28701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXStaticCastExprClass: 28711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXDynamicCastExprClass: 287249badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXConstCastExprClass: 287349badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXReinterpretCastExprClass: { 287449badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr(); 2875dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (S->getType()->isPointerType() || S->getType()->isBlockPointerType()) 287626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(S, refVars); 287706de276fff91264437fa75111ed76de43097e089Ted Kremenek else 287806de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 2879fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 28801eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 288103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 288203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalAddr( 288303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 288403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor refVars)) 288503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 288603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 288703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 288803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 2889fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Everything else: we simply don't reason about them. 2890fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner default: 2891fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 289206de276fff91264437fa75111ed76de43097e089Ted Kremenek } 289306de276fff91264437fa75111ed76de43097e089Ted Kremenek} 28941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 289506de276fff91264437fa75111ed76de43097e089Ted Kremenek 289606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalVal - This function is complements EvalAddr in the mutual recursion. 289706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// See the comments for EvalAddr for more details. 28985f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars) { 289968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo { 2900e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // We should only be called for evaluating non-pointer expressions, or 2901e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // expressions with a pointer type that are not used as references but instead 2902e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // are l-values (e.g., DeclRefExpr with a pointer type). 29031eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 290406de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 290506de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 290606de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 2907f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 2908f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 290906de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 291068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ImplicitCastExprClass: { 291168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 29125baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall if (IE->getValueKind() == VK_LValue) { 291368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = IE->getSubExpr(); 291468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 291568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 291668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek return NULL; 291768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 291868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek 291980ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 292080ee6e878a169e6255d4686a91bb696151ff229fJohn McCall return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars); 292180ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 2922a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor case Stmt::DeclRefExprClass: { 292326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // When we hit a DeclRefExpr we are looking at code that refers to a 292426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // variable's name. If it's not a reference variable we check if it has 292526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // local storage within the function, and if so, return the expression. 292606de276fff91264437fa75111ed76de43097e089Ted Kremenek DeclRefExpr *DR = cast<DeclRefExpr>(E); 29271eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 292806de276fff91264437fa75111ed76de43097e089Ted Kremenek if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 292926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage()) { 293026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!V->getType()->isReferenceType()) 293126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return DR; 293226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 293326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Reference variable, follow through to the expression that 293426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 293526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasInit()) { 293626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 293726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 293826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(V->getInit(), refVars); 293926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 294026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 29411eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 294206de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 294306de276fff91264437fa75111ed76de43097e089Ted Kremenek } 29441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 294506de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::UnaryOperatorClass: { 294606de276fff91264437fa75111ed76de43097e089Ted Kremenek // The only unary operator that make sense to handle here 294706de276fff91264437fa75111ed76de43097e089Ted Kremenek // is Deref. All others don't resolve to a "name." This includes 294806de276fff91264437fa75111ed76de43097e089Ted Kremenek // handling all sorts of rvalues passed to a unary operator. 294906de276fff91264437fa75111ed76de43097e089Ted Kremenek UnaryOperator *U = cast<UnaryOperator>(E); 29501eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 29512de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_Deref) 295226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(U->getSubExpr(), refVars); 295306de276fff91264437fa75111ed76de43097e089Ted Kremenek 295406de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 295506de276fff91264437fa75111ed76de43097e089Ted Kremenek } 29561eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 295706de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ArraySubscriptExprClass: { 295806de276fff91264437fa75111ed76de43097e089Ted Kremenek // Array subscripts are potential references to data on the stack. We 295906de276fff91264437fa75111ed76de43097e089Ted Kremenek // retrieve the DeclRefExpr* for the array variable if it indeed 296006de276fff91264437fa75111ed76de43097e089Ted Kremenek // has local storage. 296126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars); 296206de276fff91264437fa75111ed76de43097e089Ted Kremenek } 29631eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 296406de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ConditionalOperatorClass: { 296506de276fff91264437fa75111ed76de43097e089Ted Kremenek // For conditional operators we need to see if either the LHS or RHS are 296626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // non-NULL Expr's. If one is non-NULL, we return it. 296706de276fff91264437fa75111ed76de43097e089Ted Kremenek ConditionalOperator *C = cast<ConditionalOperator>(E); 296806de276fff91264437fa75111ed76de43097e089Ted Kremenek 29693907323dd6665c0c4e383435cb145233f4533406Anders Carlsson // Handle the GNU extension for missing LHS. 29703907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (Expr *lhsExpr = C->getLHS()) 297126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr *LHS = EvalVal(lhsExpr, refVars)) 29723907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return LHS; 29733907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 297426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(C->getRHS(), refVars); 297506de276fff91264437fa75111ed76de43097e089Ted Kremenek } 29761eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 297706de276fff91264437fa75111ed76de43097e089Ted Kremenek // Accesses to members are potential references to data on the stack. 297883f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor case Stmt::MemberExprClass: { 297906de276fff91264437fa75111ed76de43097e089Ted Kremenek MemberExpr *M = cast<MemberExpr>(E); 29801eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 298106de276fff91264437fa75111ed76de43097e089Ted Kremenek // Check for indirect access. We only want direct field accesses. 2982a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->isArrow()) 2983a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return NULL; 2984a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 2985a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // Check whether the member type is itself a reference, in which case 2986a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // we're not going to refer to the member, but to what the member refers to. 2987a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->getMemberDecl()->getType()->isReferenceType()) 298806de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 2989a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 299026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(M->getBase(), refVars); 299106de276fff91264437fa75111ed76de43097e089Ted Kremenek } 29921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 299303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 299403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalVal( 299503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 299603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor refVars)) 299703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 299803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 299903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 300003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 300106de276fff91264437fa75111ed76de43097e089Ted Kremenek default: 300226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Check that we don't return or take the address of a reference to a 300326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // temporary. This is only useful in C++. 300426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!E->isTypeDependent() && E->isRValue()) 300526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; 300626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 300726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Everything else: we simply don't reason about them. 300806de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 300906de276fff91264437fa75111ed76de43097e089Ted Kremenek } 301068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true); 301106de276fff91264437fa75111ed76de43097e089Ted Kremenek} 3012588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3013588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 3014588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3015588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==. 3016588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely 3017588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended. 3018dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieuvoid Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) { 3019588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek bool EmitWarning = true; 30201eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3021dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts(); 3022dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* RightExprSansParen = RHS->IgnoreParenImpCasts(); 3023588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3024588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Special case: check for x == x (which is OK). 3025588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Do not emit warnings for such cases. 3026588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 3027588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 3028588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DRL->getDecl() == DRR->getDecl()) 3029588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 30301eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 30311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 30321b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // Special case: check for comparisons against literals that can be exactly 30331b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // represented by APFloat. In such cases, do not emit a warning. This 30341b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // is a heuristic: often comparison against such literals are used to 30351b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // detect if a value in a variable has not changed. This clearly can 30361b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // lead to false negatives. 30371b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (EmitWarning) { 30381b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 30391b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLL->isExact()) 30401b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 3041ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else 30421b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){ 30431b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLR->isExact()) 30441b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 30451b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 30461b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 30471eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3048588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Check for comparisons with builtin types. 30490eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 3050588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 3051180f47959a066795cc0f409433023af448bb0328Richard Smith if (CL->isBuiltinCall()) 3052588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 30531eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 30540eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 3055588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 3056180f47959a066795cc0f409433023af448bb0328Richard Smith if (CR->isBuiltinCall()) 3057588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 30581eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3059588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Emit the diagnostic. 3060588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (EmitWarning) 3061dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Diag(Loc, diag::warn_floatingpoint_eq) 3062dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu << LHS->getSourceRange() << RHS->getSourceRange(); 3063588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek} 3064ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3065f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 3066f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 3067ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3068f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace { 3069ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3070f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued 3071f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression. 3072f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange { 3073f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// The number of bits active in the int. 3074f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned Width; 3075ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3076f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// True if the int is known not to have negative values. 3077f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool NonNegative; 307851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3079f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange(unsigned Width, bool NonNegative) 3080f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : Width(Width), NonNegative(NonNegative) 3081f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall {} 308251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 30831844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of the bool type. 3084f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall static IntRange forBoolType() { 3085f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(1, true); 3086f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 308751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 30881844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of the given integral type. 30891844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfType(ASTContext &C, QualType T) { 30901844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return forValueOfCanonicalType(C, 30911844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T->getCanonicalTypeInternal().getTypePtr()); 309251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 309351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 30941844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of a canonical integral type. 30951844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 3096f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(T->isCanonicalUnqualified()); 309751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3098f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 3099f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = VT->getElementType().getTypePtr(); 3100f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 3101f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = CT->getElementType().getTypePtr(); 3102323ed74658bc8375278eabf074b4777458376540John McCall 3103091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // For enum types, use the known bit width of the enumerators. 3104323ed74658bc8375278eabf074b4777458376540John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) { 3105323ed74658bc8375278eabf074b4777458376540John McCall EnumDecl *Enum = ET->getDecl(); 31065e1cdac63c3d9c9b32fa41fa0b2d242a58a20d49John McCall if (!Enum->isCompleteDefinition()) 3107091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return IntRange(C.getIntWidth(QualType(T, 0)), false); 3108091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3109323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumPositive = Enum->getNumPositiveBits(); 3110323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumNegative = Enum->getNumNegativeBits(); 3111323ed74658bc8375278eabf074b4777458376540John McCall 3112323ed74658bc8375278eabf074b4777458376540John McCall return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0); 3113323ed74658bc8375278eabf074b4777458376540John McCall } 311451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3115f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const BuiltinType *BT = cast<BuiltinType>(T); 3116f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(BT->isInteger()); 311751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3118f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 311951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 312051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 31211844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the "target" range of a canonical integral type, i.e. 31221844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// the range of values expressible in the type. 31231844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// 31241844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// This matches forValueOfCanonicalType except that enums have the 31251844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// full range of their type, not the range of their enumerators. 31261844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 31271844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(T->isCanonicalUnqualified()); 31281844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 31291844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 31301844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = VT->getElementType().getTypePtr(); 31311844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 31321844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = CT->getElementType().getTypePtr(); 31331844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) 313469ff26bd1e7a2faffec0c3b9740cfb0c6bb354c5Douglas Gregor T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr(); 31351844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 31361844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall const BuiltinType *BT = cast<BuiltinType>(T); 31371844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(BT->isInteger()); 31381844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 31391844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 31401844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall } 31411844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 31421844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the supremum of two ranges: i.e. their conservative merge. 3143c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange join(IntRange L, IntRange R) { 3144f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(std::max(L.Width, R.Width), 314560fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative && R.NonNegative); 314660fad45739b764886f707bd204eae9ecce6db1f2John McCall } 314760fad45739b764886f707bd204eae9ecce6db1f2John McCall 31481844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the infinum of two ranges: i.e. their aggressive merge. 3149c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange meet(IntRange L, IntRange R) { 315060fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange(std::min(L.Width, R.Width), 315160fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative || R.NonNegative); 315251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 3153f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}; 315451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3155f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) { 3156f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isSigned() && value.isNegative()) 3157f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getMinSignedBits(), false); 315851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3159f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.getBitWidth() > MaxWidth) 31609f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad value = value.trunc(MaxWidth); 316151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3162f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // isNonNegative() just checks the sign bit without considering 3163f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // signedness. 3164f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getActiveBits(), true); 316551313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 316651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 31670acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCallIntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 3168f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned MaxWidth) { 3169f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isInt()) 3170f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetValueRange(C, result.getInt(), MaxWidth); 317151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3172f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isVector()) { 31730acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 31740acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 31750acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 31760acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall R = IntRange::join(R, El); 31770acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall } 3178f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return R; 317951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 318051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3181f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isComplexInt()) { 3182f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 3183f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 3184f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(R, I); 3185f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 3186f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3187f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // This can happen with lossless casts to intptr_t of "based" lvalues. 3188f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume it might use arbitrary bits. 31890acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // FIXME: The only reason we need to pass the type in here is to get 31900acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // the sign right on this one case. It would be nice if APValue 31910acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // preserved this. 319265639284118d54ddf2e51a05d2ffccda567fe246Eli Friedman assert(result.isLValue() || result.isAddrLabelDiff()); 31935e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType()); 319451313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 319551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3196f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the 3197f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take. 3198f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 3199f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated 3200f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 320151313c39c84407dd6a323be99a8c322bf8d052a9John McCall E = E->IgnoreParens(); 320251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3203f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Try a full evaluation first. 3204f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall Expr::EvalResult result; 320551f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, C)) 32060acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall return GetValueRange(C, result.Val, E->getType(), MaxWidth); 320751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3208f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // I think we only want to look through implicit casts here; if the 3209f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // user has an explicit widening cast, we should treat the value as 3210f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // being of the new, wider type. 3211f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 3212b17ee5bff0d7986c14cdddb279e0131bd7f9678dEli Friedman if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue) 3213f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CE->getSubExpr(), MaxWidth); 321451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 32151844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType()); 321651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 32172de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 321860fad45739b764886f707bd204eae9ecce6db1f2John McCall 3219f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume that non-integer casts can span the full range of the type. 322060fad45739b764886f707bd204eae9ecce6db1f2John McCall if (!isIntegerCast) 3221f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 322251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3223f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange SubRange 3224f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall = GetExprRange(C, CE->getSubExpr(), 3225f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall std::min(MaxWidth, OutputTypeRange.Width)); 322651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3227f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Bail out if the subexpr's range is as wide as the cast type. 3228f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SubRange.Width >= OutputTypeRange.Width) 3229f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 323051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3231f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, we take the smaller width, and we're non-negative if 3232f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // either the output type or the subexpr is. 3233f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(SubRange.Width, 3234f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall SubRange.NonNegative || OutputTypeRange.NonNegative); 3235f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 3236f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3237f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 3238f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // If we can fold the condition, just take that operand. 3239f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool CondResult; 3240f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 3241f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CondResult ? CO->getTrueExpr() 3242f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : CO->getFalseExpr(), 3243f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall MaxWidth); 3244f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3245f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, conservatively merge. 3246f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 3247f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 3248f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 324951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 325051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 325151313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 325251313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (BO->getOpcode()) { 325351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3254f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Boolean-valued operations are single-bit and positive. 32552de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LAnd: 32562de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LOr: 32572de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LT: 32582de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GT: 32592de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LE: 32602de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GE: 32612de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_EQ: 32622de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_NE: 3263f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 326451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3265862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // The type of the assignments is the type of the LHS, so the RHS 3266862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // is not necessarily the same type. 32672de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_MulAssign: 32682de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_DivAssign: 32692de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_RemAssign: 32702de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AddAssign: 32712de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_SubAssign: 3272862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_XorAssign: 3273862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_OrAssign: 3274862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 32751844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 3276c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall 3277862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // Simple assignments just pass through the RHS, which will have 3278862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // been coerced to the LHS type. 3279862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_Assign: 3280862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 3281862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 3282862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall 328351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 32842de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemD: 32852de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemI: 32861844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 328751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 328860fad45739b764886f707bd204eae9ecce6db1f2John McCall // Bitwise-and uses the *infinum* of the two source ranges. 32892de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_And: 32902de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AndAssign: 329160fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 329260fad45739b764886f707bd204eae9ecce6db1f2John McCall GetExprRange(C, BO->getRHS(), MaxWidth)); 329360fad45739b764886f707bd204eae9ecce6db1f2John McCall 329451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Left shift gets black-listed based on a judgement call. 32952de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shl: 32963aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // ...except that we want to treat '1 << (blah)' as logically 32973aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // positive. It's an important idiom. 32983aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (IntegerLiteral *I 32993aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 33003aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (I->getValue() == 1) { 33011844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange R = IntRange::forValueOfType(C, E->getType()); 33023aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall return IntRange(R.Width, /*NonNegative*/ true); 33033aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 33043aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 33053aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // fallthrough 33063aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall 33072de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShlAssign: 33081844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 330951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 331060fad45739b764886f707bd204eae9ecce6db1f2John McCall // Right shift by a constant can narrow its left argument. 33112de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shr: 33122de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShrAssign: { 331360fad45739b764886f707bd204eae9ecce6db1f2John McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 331460fad45739b764886f707bd204eae9ecce6db1f2John McCall 331560fad45739b764886f707bd204eae9ecce6db1f2John McCall // If the shift amount is a positive constant, drop the width by 331660fad45739b764886f707bd204eae9ecce6db1f2John McCall // that much. 331760fad45739b764886f707bd204eae9ecce6db1f2John McCall llvm::APSInt shift; 331860fad45739b764886f707bd204eae9ecce6db1f2John McCall if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 331960fad45739b764886f707bd204eae9ecce6db1f2John McCall shift.isNonNegative()) { 332060fad45739b764886f707bd204eae9ecce6db1f2John McCall unsigned zext = shift.getZExtValue(); 332160fad45739b764886f707bd204eae9ecce6db1f2John McCall if (zext >= L.Width) 332260fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width = (L.NonNegative ? 0 : 1); 332360fad45739b764886f707bd204eae9ecce6db1f2John McCall else 332460fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width -= zext; 332560fad45739b764886f707bd204eae9ecce6db1f2John McCall } 332660fad45739b764886f707bd204eae9ecce6db1f2John McCall 332760fad45739b764886f707bd204eae9ecce6db1f2John McCall return L; 332860fad45739b764886f707bd204eae9ecce6db1f2John McCall } 332960fad45739b764886f707bd204eae9ecce6db1f2John McCall 333060fad45739b764886f707bd204eae9ecce6db1f2John McCall // Comma acts as its right operand. 33312de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Comma: 3332f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 3333f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 333460fad45739b764886f707bd204eae9ecce6db1f2John McCall // Black-list pointer subtractions. 33352de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Sub: 333651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BO->getLHS()->getType()->isPointerType()) 33371844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 333800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall break; 333900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 334000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The width of a division result is mostly determined by the size 334100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // of the LHS. 334200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Div: { 334300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 334400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 334500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 334600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 334700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // If the divisor is constant, use that. 334800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall llvm::APSInt divisor; 334900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) { 335000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned log2 = divisor.logBase2(); // floor(log_2(divisor)) 335100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (log2 >= L.Width) 335200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = (L.NonNegative ? 0 : 1); 335300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall else 335400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = std::min(L.Width - log2, MaxWidth); 335500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return L; 335600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 335700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 335800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Otherwise, just use the LHS's width. 335900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 336000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return IntRange(L.Width, L.NonNegative && R.NonNegative); 336100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 336200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 336300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The result of a remainder can't be larger than the result of 336400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // either side. 336500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Rem: { 336600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 336700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 336800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 336900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 337000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 337100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange meet = IntRange::meet(L, R); 337200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall meet.Width = std::min(meet.Width, MaxWidth); 337300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return meet; 337400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 33754e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 337600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default behavior is okay for these. 337700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Mul: 337800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Add: 337900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Xor: 338000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Or: 3381f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall break; 338251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 3383f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 338400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default case is to treat the operation as if it were closed 338500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // on the narrowest type that encompasses both operands. 3386f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 3387f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 3388f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 338951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 339051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 339151313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 339251313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (UO->getOpcode()) { 339351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Boolean-valued operations are white-listed. 33942de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_LNot: 3395f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 339651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 339751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 33982de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_Deref: 33992de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_AddrOf: // should be impossible 34001844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 340151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 340251313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 3403f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, UO->getSubExpr(), MaxWidth); 340451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 340551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 34068ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor 34078ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor if (dyn_cast<OffsetOfExpr>(E)) { 34081844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange::forValueOfType(C, E->getType()); 34098ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor } 341051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3411a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith if (FieldDecl *BitField = E->getBitField()) 3412a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith return IntRange(BitField->getBitWidthValue(C), 34135e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor BitField->getType()->isUnsignedIntegerOrEnumerationType()); 3414f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 34151844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 3416f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 3417f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3418323ed74658bc8375278eabf074b4777458376540John McCallIntRange GetExprRange(ASTContext &C, Expr *E) { 3419323ed74658bc8375278eabf074b4777458376540John McCall return GetExprRange(C, E, C.getIntWidth(E->getType())); 3420323ed74658bc8375278eabf074b4777458376540John McCall} 3421323ed74658bc8375278eabf074b4777458376540John McCall 3422f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 3423f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 3424f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 3425f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const llvm::APFloat &value, 3426f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 3427f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 3428f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APFloat truncated = value; 3429f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3430f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool ignored; 3431f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 3432f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 3433f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3434f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return truncated.bitwiseIsEqual(value); 343551313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 343651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3437f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 3438f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 3439f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 3440f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 3441f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number). 3442f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const APValue &value, 3443f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 3444f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 3445f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isFloat()) 3446f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 3447f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3448f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isVector()) { 3449f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 3450f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 3451f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return false; 3452f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return true; 3453f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 3454f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3455f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(value.isComplexFloat()); 3456f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 3457f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 3458f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 3459f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3460b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 3461323ed74658bc8375278eabf074b4777458376540John McCall 3462e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) { 3463e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where we are comparing against an enum constant. 3464e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (const DeclRefExpr *DR = 3465e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 3466e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (isa<EnumConstantDecl>(DR->getDecl())) 3467e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 3468e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 3469e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where the '0' value is expanded from a macro. 3470e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (E->getLocStart().isMacroID()) 3471e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 3472e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 3473323ed74658bc8375278eabf074b4777458376540John McCall llvm::APSInt Value; 3474323ed74658bc8375278eabf074b4777458376540John McCall return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 3475323ed74658bc8375278eabf074b4777458376540John McCall} 3476323ed74658bc8375278eabf074b4777458376540John McCall 3477372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) { 3478372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall // Strip off implicit integral promotions. 3479372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 348063b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis if (ICE->getCastKind() != CK_IntegralCast && 348163b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis ICE->getCastKind() != CK_NoOp) 3482372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall break; 348363b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis E = ICE->getSubExpr(); 3484372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall } 3485372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 3486372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall return E->getType()->isEnumeralType(); 3487372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall} 3488372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 3489323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 34902de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = E->getOpcode(); 349114af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor if (E->isValueDependent()) 349214af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor return; 349314af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor 34942de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op == BO_LT && IsZero(S, E->getRHS())) { 3495323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 3496372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "< 0" << "false" << HasEnumType(E->getLHS()) 3497323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 34982de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GE && IsZero(S, E->getRHS())) { 3499323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 3500372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << ">= 0" << "true" << HasEnumType(E->getLHS()) 3501323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 35022de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GT && IsZero(S, E->getLHS())) { 3503323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 3504372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 >" << "false" << HasEnumType(E->getRHS()) 3505323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 35062de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_LE && IsZero(S, E->getLHS())) { 3507323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 3508372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 <=" << "true" << HasEnumType(E->getRHS()) 3509323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 3510323ed74658bc8375278eabf074b4777458376540John McCall } 3511323ed74658bc8375278eabf074b4777458376540John McCall} 3512323ed74658bc8375278eabf074b4777458376540John McCall 3513323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison. Implements the 3514323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison. 3515323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 3516b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 3517b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 3518323ed74658bc8375278eabf074b4777458376540John McCall} 3519f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3520ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare. 3521ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// 3522dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu/// \param E the binary operator to check for warnings 3523323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeComparison(Sema &S, BinaryOperator *E) { 3524323ed74658bc8375278eabf074b4777458376540John McCall // The type the comparison is being performed in. 3525323ed74658bc8375278eabf074b4777458376540John McCall QualType T = E->getLHS()->getType(); 3526323ed74658bc8375278eabf074b4777458376540John McCall assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 3527323ed74658bc8375278eabf074b4777458376540John McCall && "comparison with mismatched types"); 3528323ed74658bc8375278eabf074b4777458376540John McCall 3529323ed74658bc8375278eabf074b4777458376540John McCall // We don't do anything special if this isn't an unsigned integral 3530323ed74658bc8375278eabf074b4777458376540John McCall // comparison: we're only interested in integral comparisons, and 3531323ed74658bc8375278eabf074b4777458376540John McCall // signed comparisons only happen in cases we don't care to warn about. 35323e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // 35333e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // We also don't care about value-dependent expressions or expressions 35343e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // whose result is a constant. 35353e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor if (!T->hasUnsignedIntegerRepresentation() 35363e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor || E->isValueDependent() || E->isIntegerConstantExpr(S.Context)) 3537323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 3538323ed74658bc8375278eabf074b4777458376540John McCall 3539dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr *LHS = E->getLHS()->IgnoreParenImpCasts(); 3540dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr *RHS = E->getRHS()->IgnoreParenImpCasts(); 3541323ed74658bc8375278eabf074b4777458376540John McCall 3542323ed74658bc8375278eabf074b4777458376540John McCall // Check to see if one of the (unmodified) operands is of different 3543323ed74658bc8375278eabf074b4777458376540John McCall // signedness. 3544323ed74658bc8375278eabf074b4777458376540John McCall Expr *signedOperand, *unsignedOperand; 3545dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu if (LHS->getType()->hasSignedIntegerRepresentation()) { 3546dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu assert(!RHS->getType()->hasSignedIntegerRepresentation() && 3547323ed74658bc8375278eabf074b4777458376540John McCall "unsigned comparison between two signed integer expressions?"); 3548dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = LHS; 3549dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = RHS; 3550dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu } else if (RHS->getType()->hasSignedIntegerRepresentation()) { 3551dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = RHS; 3552dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = LHS; 3553ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } else { 3554323ed74658bc8375278eabf074b4777458376540John McCall CheckTrivialUnsignedComparison(S, E); 3555323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 3556ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } 3557ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3558323ed74658bc8375278eabf074b4777458376540John McCall // Otherwise, calculate the effective range of the signed operand. 3559323ed74658bc8375278eabf074b4777458376540John McCall IntRange signedRange = GetExprRange(S.Context, signedOperand); 3560f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3561323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and analyze implicit conversions in the operands. Note 3562323ed74658bc8375278eabf074b4777458376540John McCall // that we skip the implicit conversions on both sides. 3563dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc()); 3564dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc()); 3565ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3566323ed74658bc8375278eabf074b4777458376540John McCall // If the signed range is non-negative, -Wsign-compare won't fire, 3567323ed74658bc8375278eabf074b4777458376540John McCall // but we should still check for comparisons which are always true 3568323ed74658bc8375278eabf074b4777458376540John McCall // or false. 3569323ed74658bc8375278eabf074b4777458376540John McCall if (signedRange.NonNegative) 3570323ed74658bc8375278eabf074b4777458376540John McCall return CheckTrivialUnsignedComparison(S, E); 3571ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3572ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // For (in)equality comparisons, if the unsigned operand is a 3573ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // constant which cannot collide with a overflowed signed operand, 3574ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // then reinterpreting the signed operand as unsigned will not 3575ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // change the result of the comparison. 3576323ed74658bc8375278eabf074b4777458376540John McCall if (E->isEqualityOp()) { 3577323ed74658bc8375278eabf074b4777458376540John McCall unsigned comparisonWidth = S.Context.getIntWidth(T); 3578323ed74658bc8375278eabf074b4777458376540John McCall IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 3579323ed74658bc8375278eabf074b4777458376540John McCall 3580323ed74658bc8375278eabf074b4777458376540John McCall // We should never be unable to prove that the unsigned operand is 3581323ed74658bc8375278eabf074b4777458376540John McCall // non-negative. 3582323ed74658bc8375278eabf074b4777458376540John McCall assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 3583ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3584323ed74658bc8375278eabf074b4777458376540John McCall if (unsignedRange.Width < comparisonWidth) 3585323ed74658bc8375278eabf074b4777458376540John McCall return; 3586323ed74658bc8375278eabf074b4777458376540John McCall } 3587323ed74658bc8375278eabf074b4777458376540John McCall 3588323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison) 3589dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu << LHS->getType() << RHS->getType() 3590dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu << LHS->getSourceRange() << RHS->getSourceRange(); 3591ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall} 3592ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 359315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield. 359415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// 359515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt. 359615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallbool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 359715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall SourceLocation InitLoc) { 359815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall assert(Bitfield->isBitField()); 359915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Bitfield->isInvalidDecl()) 360015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 360115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 360291b6014876e9186f968f74a8975ab8fc08ef1b68John McCall // White-list bool bitfields. 360391b6014876e9186f968f74a8975ab8fc08ef1b68John McCall if (Bitfield->getType()->isBooleanType()) 360491b6014876e9186f968f74a8975ab8fc08ef1b68John McCall return false; 360591b6014876e9186f968f74a8975ab8fc08ef1b68John McCall 360646ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor // Ignore value- or type-dependent expressions. 360746ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor if (Bitfield->getBitWidth()->isValueDependent() || 360846ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Bitfield->getBitWidth()->isTypeDependent() || 360946ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isValueDependent() || 361046ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isTypeDependent()) 361146ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor return false; 361246ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor 361315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *OriginalInit = Init->IgnoreParenImpCasts(); 361415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 361580d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith llvm::APSInt Value; 361680d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith if (!OriginalInit->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects)) 361715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 361815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 361915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned OriginalWidth = Value.getBitWidth(); 3620a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context); 362115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 362215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (OriginalWidth <= FieldWidth) 362315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 362415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 36259f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad llvm::APSInt TruncatedValue = Value.trunc(FieldWidth); 362615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 362715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // It's fairly common to write values into signed bitfields 362815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // that, if sign-extended, would end up becoming a different 362915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // value. We don't want to warn about that. 363015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value.isSigned() && Value.isNegative()) 36319f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad TruncatedValue = TruncatedValue.sext(OriginalWidth); 363215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall else 36339f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad TruncatedValue = TruncatedValue.zext(OriginalWidth); 363415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 363515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value == TruncatedValue) 363615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 363715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 363815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyValue = Value.toString(10); 363915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyTrunc = TruncatedValue.toString(10); 364015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 364115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 364215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << PrettyValue << PrettyTrunc << OriginalInit->getType() 364315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << Init->getSourceRange(); 364415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 364515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return true; 364615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 364715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 3648beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy 3649beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations. 3650beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCallvoid AnalyzeAssignment(Sema &S, BinaryOperator *E) { 3651beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Just recurse on the LHS. 3652beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 3653beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 3654beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // We want to recurse on the RHS as normal unless we're assigning to 3655beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // a bitfield. 3656beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (FieldDecl *Bitfield = E->getLHS()->getBitField()) { 365715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 365815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc())) { 365915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // Recurse, ignoring any implicit conversions on the RHS. 366015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 366115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc()); 3662beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 3663beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 3664beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 3665beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 3666beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall} 3667beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 366851313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 36695a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregorvoid DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T, 36705a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceLocation CContext, unsigned diag) { 36715a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor S.Diag(E->getExprLoc(), diag) 36725a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor << SourceType << T << E->getSourceRange() << SourceRange(CContext); 36735a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor} 36745a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 3675e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 3676e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruthvoid DiagnoseImpCast(Sema &S, Expr *E, QualType T, SourceLocation CContext, 3677e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth unsigned diag) { 3678e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth DiagnoseImpCast(S, E, E->getType(), T, CContext, diag); 3679e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth} 3680e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth 36819ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// Diagnose an implicit cast from a literal expression. Does not warn when the 36829ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// cast wouldn't lose information. 3683f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruthvoid DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T, 3684f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth SourceLocation CContext) { 36859ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay // Try to convert the literal exactly to an integer. If we can, don't warn. 3686f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth bool isExact = false; 36879ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay const llvm::APFloat &Value = FL->getValue(); 36883e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin llvm::APSInt IntegerValue(S.Context.getIntWidth(T), 36893e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin T->hasUnsignedIntegerRepresentation()); 36903e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin if (Value.convertToInteger(IntegerValue, 3691f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth llvm::APFloat::rmTowardZero, &isExact) 36929ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay == llvm::APFloat::opOK && isExact) 3693f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth return; 3694f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 36959ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer) 36969ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay << FL->getType() << T << FL->getSourceRange() << SourceRange(CContext); 3697f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth} 3698f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 3699091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 3700091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Range.Width) return "0"; 3701091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3702091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt ValueInRange = Value; 3703091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.setIsSigned(!Range.NonNegative); 37049f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad ValueInRange = ValueInRange.trunc(Range.Width); 3705091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return ValueInRange.toString(10); 3706091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall} 3707091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3708323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T, 3709b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool *ICContext = 0) { 3710323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) return; 371151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3712323ed74658bc8375278eabf074b4777458376540John McCall const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 3713323ed74658bc8375278eabf074b4777458376540John McCall const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 3714323ed74658bc8375278eabf074b4777458376540John McCall if (Source == Target) return; 3715323ed74658bc8375278eabf074b4777458376540John McCall if (Target->isDependentType()) return; 371651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3717108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // If the conversion context location is invalid don't complain. We also 3718108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // don't want to emit a warning if the issue occurs from the expansion of 3719108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // a system macro. The problem is that 'getSpellingLoc()' is slow, so we 3720108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // delay this check as long as possible. Once we detect we are in that 3721108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // scenario, we just return. 3722ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (CC.isInvalid()) 3723b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return; 3724b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 3725f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Diagnose implicit casts to bool. 3726f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (Target->isSpecificBuiltinType(BuiltinType::Bool)) { 3727f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (isa<StringLiteral>(E)) 3728f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Warn on string literal to bool. Checks for string literals in logical 3729f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // expressions, for instances, assert(0 && "error here"), is prevented 3730f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // by a check in AnalyzeImplicitConversions(). 3731f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu return DiagnoseImpCast(S, E, T, CC, 3732f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu diag::warn_impcast_string_literal_to_bool); 3733e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (Source->isFunctionType()) { 3734e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // Warn on function to bool. Checks free functions and static member 3735e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // functions. Weakly imported functions are excluded from the check, 3736e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // since it's common to test their value to check whether the linker 3737e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // found a definition for them. 3738e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames ValueDecl *D = 0; 3739e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (DeclRefExpr* R = dyn_cast<DeclRefExpr>(E)) { 3740e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = R->getDecl(); 3741e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) { 3742e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = M->getMemberDecl(); 3743e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 3744e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames 3745e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (D && !D->isWeak()) { 374626b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu if (FunctionDecl* F = dyn_cast<FunctionDecl>(D)) { 374726b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu S.Diag(E->getExprLoc(), diag::warn_impcast_function_to_bool) 374826b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu << F << E->getSourceRange() << SourceRange(CC); 37492def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_silence) 37502def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion(E->getExprLoc(), "&"); 37512def77399ab3088106a2d61372344f5b7104e1a2David Blaikie QualType ReturnType; 37522def77399ab3088106a2d61372344f5b7104e1a2David Blaikie UnresolvedSet<4> NonTemplateOverloads; 37532def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.isExprCallable(*E, ReturnType, NonTemplateOverloads); 37542def77399ab3088106a2d61372344f5b7104e1a2David Blaikie if (!ReturnType.isNull() 37552def77399ab3088106a2d61372344f5b7104e1a2David Blaikie && ReturnType->isSpecificBuiltinType(BuiltinType::Bool)) 37562def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_call) 37572def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion( 37582def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()), "()"); 375926b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu return; 376026b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu } 3761e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 3762e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 3763e37cdc42bf7298a974dfdfa9c03ef11398e7c889David Blaikie return; // Other casts to bool are not checked. 3764f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 376551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 376651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip vector types. 376751313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<VectorType>(Source)) { 3768ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<VectorType>(Target)) { 3769d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 3770ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3771b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 3772ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 3773b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner 3774b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // If the vector cast is cast between two vectors of the same size, it is 3775b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // a bitcast, not a conversion. 3776b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target)) 3777b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner return; 377851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 377951313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 378051313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 378151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 378251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 378351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip complex types. 378451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<ComplexType>(Source)) { 3785ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<ComplexType>(Target)) { 3786d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 3787ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3788ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3789b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 3790ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 379151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 379251313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 379351313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 379451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 379551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 379651313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 379751313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 379851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 379951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the source is floating point... 380051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT && SourceBT->isFloatingPoint()) { 380151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...and the target is floating point... 380251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (TargetBT && TargetBT->isFloatingPoint()) { 380351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...then warn if we're dropping FP rank. 380451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 380551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Builtin FP kinds are ordered by increasing FP rank. 380651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT->getKind() > TargetBT->getKind()) { 380751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Don't warn about float constants that are precisely 380851313c39c84407dd6a323be99a8c322bf8d052a9John McCall // representable in the target type. 380951313c39c84407dd6a323be99a8c322bf8d052a9John McCall Expr::EvalResult result; 381051f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, S.Context)) { 381151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Value might be a float, a float vector, or a float complex. 381251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (IsSameFloatAfterCast(result.Val, 3813323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 3814323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 381551313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 381651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 381751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3818d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 3819ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3820ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3821b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 382251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 382351313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 382451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 382551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3826ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // If the target is integral, always warn. 3827a5b9332418f25338f118358e27303cd510d54107Chandler Carruth if ((TargetBT && TargetBT->isInteger())) { 3828d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 3829ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3830ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3831a5b9332418f25338f118358e27303cd510d54107Chandler Carruth Expr *InnerE = E->IgnoreParenImpCasts(); 3832634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay // We also want to warn on, e.g., "int i = -1.234" 3833634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE)) 3834634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus) 3835634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay InnerE = UOp->getSubExpr()->IgnoreParenImpCasts(); 3836634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay 3837f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) { 3838f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth DiagnoseFloatingLiteralImpCast(S, FL, T, CC); 3839a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } else { 3840a5b9332418f25338f118358e27303cd510d54107Chandler Carruth DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 3841a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 3842a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 384351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 384451313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 384551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 384651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3847f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!Source->isIntegerType() || !Target->isIntegerType()) 384851313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 384951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 38501838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull) 38511838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu == Expr::NPCK_GNUNull) && Target->isIntegerType()) { 38521838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu S.Diag(E->getExprLoc(), diag::warn_impcast_null_pointer_to_integer) 38531838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu << E->getSourceRange() << clang::SourceRange(CC); 38541838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu return; 38551838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu } 38561838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu 3857323ed74658bc8375278eabf074b4777458376540John McCall IntRange SourceRange = GetExprRange(S.Context, E); 38581844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 385951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3860f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width > TargetRange.Width) { 3861091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // If the source is a constant, use a default-on diagnostic. 3862091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // TODO: this should happen for bitfield stores, too. 3863091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt Value(32); 3864091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (E->isIntegerConstantExpr(Value, S.Context)) { 3865d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 3866ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3867ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3868091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettySourceValue = Value.toString(10); 3869091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 3870091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 38715e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.DiagRuntimeBehavior(E->getExprLoc(), E, 38725e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.PDiag(diag::warn_impcast_integer_precision_constant) 38735e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << PrettySourceValue << PrettyTargetValue 38745e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << E->getType() << T << E->getSourceRange() 38755e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << clang::SourceRange(CC)); 3876091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return; 3877091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall } 3878091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3879b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // People want to build with -Wshorten-64-to-32 and not -Wconversion. 3880d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 3881ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3882ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3883f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width == 64 && TargetRange.Width == 32) 3884b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32); 3885b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 3886323ed74658bc8375278eabf074b4777458376540John McCall } 3887323ed74658bc8375278eabf074b4777458376540John McCall 3888323ed74658bc8375278eabf074b4777458376540John McCall if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 3889323ed74658bc8375278eabf074b4777458376540John McCall (!TargetRange.NonNegative && SourceRange.NonNegative && 3890323ed74658bc8375278eabf074b4777458376540John McCall SourceRange.Width == TargetRange.Width)) { 3891ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3892d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 3893ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3894ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3895323ed74658bc8375278eabf074b4777458376540John McCall unsigned DiagID = diag::warn_impcast_integer_sign; 3896323ed74658bc8375278eabf074b4777458376540John McCall 3897323ed74658bc8375278eabf074b4777458376540John McCall // Traditionally, gcc has warned about this under -Wsign-compare. 3898323ed74658bc8375278eabf074b4777458376540John McCall // We also want to warn about it in -Wconversion. 3899323ed74658bc8375278eabf074b4777458376540John McCall // So if -Wconversion is off, use a completely identical diagnostic 3900323ed74658bc8375278eabf074b4777458376540John McCall // in the sign-compare group. 3901323ed74658bc8375278eabf074b4777458376540John McCall // The conditional-checking code will 3902323ed74658bc8375278eabf074b4777458376540John McCall if (ICContext) { 3903323ed74658bc8375278eabf074b4777458376540John McCall DiagID = diag::warn_impcast_integer_sign_conditional; 3904323ed74658bc8375278eabf074b4777458376540John McCall *ICContext = true; 3905323ed74658bc8375278eabf074b4777458376540John McCall } 3906323ed74658bc8375278eabf074b4777458376540John McCall 3907b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, DiagID); 390851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 390951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3910284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor // Diagnose conversions between different enumeration types. 39115a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // In C, we pretend that the type of an EnumConstantDecl is its enumeration 39125a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // type, to give us better diagnostics. 39135a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor QualType SourceType = E->getType(); 39145a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (!S.getLangOptions().CPlusPlus) { 39155a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 39165a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) { 39175a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext()); 39185a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceType = S.Context.getTypeDeclType(Enum); 39195a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor Source = S.Context.getCanonicalType(SourceType).getTypePtr(); 39205a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 39215a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 39225a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 3923284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *SourceEnum = Source->getAs<EnumType>()) 3924284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *TargetEnum = Target->getAs<EnumType>()) 3925284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if ((SourceEnum->getDecl()->getIdentifier() || 3926162e1c1b487352434552147967c3dd296ebee2f7Richard Smith SourceEnum->getDecl()->getTypedefNameForAnonDecl()) && 3927284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor (TargetEnum->getDecl()->getIdentifier() || 3928162e1c1b487352434552147967c3dd296ebee2f7Richard Smith TargetEnum->getDecl()->getTypedefNameForAnonDecl()) && 3929ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceEnum != TargetEnum) { 3930d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 3931ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3932ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 39335a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor return DiagnoseImpCast(S, E, SourceType, T, CC, 3934284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor diag::warn_impcast_different_enum_types); 3935ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 3936284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor 393751313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 393851313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 393951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3940323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T); 3941323ed74658bc8375278eabf074b4777458376540John McCall 3942323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T, 3943b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool &ICContext) { 3944323ed74658bc8375278eabf074b4777458376540John McCall E = E->IgnoreParenImpCasts(); 3945323ed74658bc8375278eabf074b4777458376540John McCall 3946323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) 3947323ed74658bc8375278eabf074b4777458376540John McCall return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T); 3948323ed74658bc8375278eabf074b4777458376540John McCall 3949b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E, CC); 3950323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 3951b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return CheckImplicitConversion(S, E, T, CC, &ICContext); 3952323ed74658bc8375278eabf074b4777458376540John McCall return; 3953323ed74658bc8375278eabf074b4777458376540John McCall} 3954323ed74658bc8375278eabf074b4777458376540John McCall 3955323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) { 3956b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC = E->getQuestionLoc(); 3957b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 3958b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getCond(), CC); 3959323ed74658bc8375278eabf074b4777458376540John McCall 3960323ed74658bc8375278eabf074b4777458376540John McCall bool Suspicious = false; 3961b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 3962b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 3963323ed74658bc8375278eabf074b4777458376540John McCall 3964323ed74658bc8375278eabf074b4777458376540John McCall // If -Wconversion would have warned about either of the candidates 3965323ed74658bc8375278eabf074b4777458376540John McCall // for a signedness conversion to the context type... 3966323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) return; 3967323ed74658bc8375278eabf074b4777458376540John McCall 3968323ed74658bc8375278eabf074b4777458376540John McCall // ...but it's currently ignored... 39690827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional, 39700827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis CC)) 3971323ed74658bc8375278eabf074b4777458376540John McCall return; 3972323ed74658bc8375278eabf074b4777458376540John McCall 3973323ed74658bc8375278eabf074b4777458376540John McCall // ...then check whether it would have warned about either of the 3974323ed74658bc8375278eabf074b4777458376540John McCall // candidates for a signedness conversion to the condition type. 39755254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (E->getType() == T) return; 39765254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu 39775254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu Suspicious = false; 39785254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 39795254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu E->getType(), CC, &Suspicious); 39805254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (!Suspicious) 39815254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 3982b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 3983323ed74658bc8375278eabf074b4777458376540John McCall} 3984323ed74658bc8375278eabf074b4777458376540John McCall 3985323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting 3986323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression. There are a couple 3987323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare. 3988b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 3989323ed74658bc8375278eabf074b4777458376540John McCall QualType T = OrigE->getType(); 3990323ed74658bc8375278eabf074b4777458376540John McCall Expr *E = OrigE->IgnoreParenImpCasts(); 3991323ed74658bc8375278eabf074b4777458376540John McCall 3992f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 3993f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor return; 3994f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor 3995323ed74658bc8375278eabf074b4777458376540John McCall // For conditional operators, we analyze the arguments as if they 3996323ed74658bc8375278eabf074b4777458376540John McCall // were being fed directly into the output. 3997323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) { 3998323ed74658bc8375278eabf074b4777458376540John McCall ConditionalOperator *CO = cast<ConditionalOperator>(E); 3999323ed74658bc8375278eabf074b4777458376540John McCall CheckConditionalOperator(S, CO, T); 4000323ed74658bc8375278eabf074b4777458376540John McCall return; 4001323ed74658bc8375278eabf074b4777458376540John McCall } 4002323ed74658bc8375278eabf074b4777458376540John McCall 4003323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and check any implicit conversions we might have skipped. 4004323ed74658bc8375278eabf074b4777458376540John McCall // The non-canonical typecheck is just an optimization; 4005323ed74658bc8375278eabf074b4777458376540John McCall // CheckImplicitConversion will filter out dead implicit conversions. 4006323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 4007b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckImplicitConversion(S, E, T, CC); 4008323ed74658bc8375278eabf074b4777458376540John McCall 4009323ed74658bc8375278eabf074b4777458376540John McCall // Now continue drilling into this expression. 4010323ed74658bc8375278eabf074b4777458376540John McCall 4011323ed74658bc8375278eabf074b4777458376540John McCall // Skip past explicit casts. 4012323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ExplicitCastExpr>(E)) { 4013323ed74658bc8375278eabf074b4777458376540John McCall E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 4014b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return AnalyzeImplicitConversions(S, E, CC); 4015323ed74658bc8375278eabf074b4777458376540John McCall } 4016323ed74658bc8375278eabf074b4777458376540John McCall 4017beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 4018beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Do a somewhat different check with comparison operators. 4019beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isComparisonOp()) 4020beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeComparison(S, BO); 4021beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 4022beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // And with assignments and compound assignments. 4023beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isAssignmentOp()) 4024beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeAssignment(S, BO); 4025beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4026323ed74658bc8375278eabf074b4777458376540John McCall 4027323ed74658bc8375278eabf074b4777458376540John McCall // These break the otherwise-useful invariant below. Fortunately, 4028323ed74658bc8375278eabf074b4777458376540John McCall // we don't really need to recurse into them, because any internal 4029323ed74658bc8375278eabf074b4777458376540John McCall // expressions should have been analyzed already when they were 4030323ed74658bc8375278eabf074b4777458376540John McCall // built into statements. 4031323ed74658bc8375278eabf074b4777458376540John McCall if (isa<StmtExpr>(E)) return; 4032323ed74658bc8375278eabf074b4777458376540John McCall 4033323ed74658bc8375278eabf074b4777458376540John McCall // Don't descend into unevaluated contexts. 4034f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne if (isa<UnaryExprOrTypeTraitExpr>(E)) return; 4035323ed74658bc8375278eabf074b4777458376540John McCall 4036323ed74658bc8375278eabf074b4777458376540John McCall // Now just recurse over the expression's children. 4037b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CC = E->getExprLoc(); 4038f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu BinaryOperator *BO = dyn_cast<BinaryOperator>(E); 4039f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu bool IsLogicalOperator = BO && BO->isLogicalOp(); 4040f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu for (Stmt::child_range I = E->children(); I; ++I) { 4041f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu Expr *ChildExpr = cast<Expr>(*I); 4042f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (IsLogicalOperator && 4043f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts())) 4044f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Ignore checking string literals that are in logical operators. 4045f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu continue; 4046f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu AnalyzeImplicitConversions(S, ChildExpr, CC); 4047f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 4048323ed74658bc8375278eabf074b4777458376540John McCall} 4049323ed74658bc8375278eabf074b4777458376540John McCall 4050323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace 4051323ed74658bc8375278eabf074b4777458376540John McCall 4052323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given 4053323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression). Implements -Wconversion 4054323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare. 4055b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// 4056b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e. 4057b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// the most location of the syntactic entity requiring the implicit 4058b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// conversion 4059b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 4060323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose in unevaluated contexts. 4061323ed74658bc8375278eabf074b4777458376540John McCall if (ExprEvalContexts.back().Context == Sema::Unevaluated) 4062323ed74658bc8375278eabf074b4777458376540John McCall return; 4063323ed74658bc8375278eabf074b4777458376540John McCall 4064323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose for value- or type-dependent expressions. 4065323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) 4066323ed74658bc8375278eabf074b4777458376540John McCall return; 4067323ed74658bc8375278eabf074b4777458376540John McCall 4068d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Check for array bounds violations in cases where the check isn't triggered 4069d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // elsewhere for other Expr types (like BinaryOperators), e.g. when an 4070d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // ArraySubscriptExpr is on the RHS of a variable initialization. 4071d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain CheckArrayAccess(E); 4072d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 4073b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // This is not the right CC for (e.g.) a variable initialization. 4074b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(*this, E, CC); 4075323ed74658bc8375278eabf074b4777458376540John McCall} 4076323ed74658bc8375278eabf074b4777458376540John McCall 407715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 407815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall FieldDecl *BitField, 407915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *Init) { 408015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 408115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 408215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 4083f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given 4084f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This 4085f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the 4086f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function 4087f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete. 408882aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregorbool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd, 408982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor bool CheckParameterNames) { 4090f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump bool HasInvalidParm = false; 409182aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor for (; P != PEnd; ++P) { 409282aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor ParmVarDecl *Param = *P; 409382aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor 4094f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.7.5.3p4: the parameters in a parameter type list in a 4095f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // function declarator that is part of a function definition of 4096f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // that function shall not have incomplete type. 4097f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // 4098f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // This is also C++ [dcl.fct]p6. 4099f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump if (!Param->isInvalidDecl() && 4100f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump RequireCompleteType(Param->getLocation(), Param->getType(), 4101f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump diag::err_typecheck_decl_incomplete_type)) { 4102f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Param->setInvalidDecl(); 4103f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump HasInvalidParm = true; 4104f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 4105f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 4106f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.9.1p5: If the declarator includes a parameter type list, the 4107f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // declaration of each parameter shall include an identifier. 410882aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor if (CheckParameterNames && 410982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor Param->getIdentifier() == 0 && 4110f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !Param->isImplicit() && 4111f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !getLangOptions().CPlusPlus) 4112f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Diag(Param->getLocation(), diag::err_parameter_name_omitted); 4113d17e340e2d516139931768697bf080f60920ba9dSam Weinig 4114d17e340e2d516139931768697bf080f60920ba9dSam Weinig // C99 6.7.5.3p12: 4115d17e340e2d516139931768697bf080f60920ba9dSam Weinig // If the function declarator is not part of a definition of that 4116d17e340e2d516139931768697bf080f60920ba9dSam Weinig // function, parameters may have incomplete type and may use the [*] 4117d17e340e2d516139931768697bf080f60920ba9dSam Weinig // notation in their sequences of declarator specifiers to specify 4118d17e340e2d516139931768697bf080f60920ba9dSam Weinig // variable length array types. 4119d17e340e2d516139931768697bf080f60920ba9dSam Weinig QualType PType = Param->getOriginalType(); 4120d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (const ArrayType *AT = Context.getAsArrayType(PType)) { 4121d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (AT->getSizeModifier() == ArrayType::Star) { 4122d17e340e2d516139931768697bf080f60920ba9dSam Weinig // FIXME: This diagnosic should point the the '[*]' if source-location 4123d17e340e2d516139931768697bf080f60920ba9dSam Weinig // information is added for it. 4124d17e340e2d516139931768697bf080f60920ba9dSam Weinig Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 4125d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 4126d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 4127f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 4128f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 4129f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump return HasInvalidParm; 4130f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump} 4131b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4132b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a 4133b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements. 4134b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 4135b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // This is actually a lot of work to potentially be doing on every 4136b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // cast; don't do it if we're ignoring -Wcast_align (as is the default). 41370827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align, 41380827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis TRange.getBegin()) 4139d6471f7c1921c7802804ce3ff6fe9768310f72b9David Blaikie == DiagnosticsEngine::Ignored) 4140b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 4141b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4142b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Ignore dependent types. 4143b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (T->isDependentType() || Op->getType()->isDependentType()) 4144b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 4145b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4146b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the destination be a pointer type. 4147b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *DestPtr = T->getAs<PointerType>(); 4148b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!DestPtr) return; 4149b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4150b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // If the destination has alignment 1, we're done. 4151b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType DestPointee = DestPtr->getPointeeType(); 4152b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestPointee->isIncompleteType()) return; 4153b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 4154b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestAlign.isOne()) return; 4155b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4156b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the source be a pointer type. 4157b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 4158b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!SrcPtr) return; 4159b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType SrcPointee = SrcPtr->getPointeeType(); 4160b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4161b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Whitelist casts from cv void*. We already implicitly 4162b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // whitelisted casts to cv void*, since they have alignment 1. 4163b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Also whitelist casts involving incomplete types, which implicitly 4164b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // includes 'void'. 4165b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcPointee->isIncompleteType()) return; 4166b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4167b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 4168b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcAlign >= DestAlign) return; 4169b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4170b7f4ffe073fa419613946461a2583ba2fcb72280John McCall Diag(TRange.getBegin(), diag::warn_cast_align) 4171b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << Op->getType() << T 4172b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(SrcAlign.getQuantity()) 4173b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(DestAlign.getQuantity()) 4174b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << TRange << Op->getSourceRange(); 4175b7f4ffe073fa419613946461a2583ba2fcb72280John McCall} 4176b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4177d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainstatic const Type* getElementType(const Expr *BaseExpr) { 4178d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* EltType = BaseExpr->getType().getTypePtr(); 4179d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (EltType->isAnyPointerType()) 4180d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getPointeeType().getTypePtr(); 4181d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain else if (EltType->isArrayType()) 4182d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getBaseElementTypeUnsafe(); 4183d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType; 4184d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain} 4185d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 4186c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// \brief Check whether this array fits the idiom of a size-one tail padded 4187c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// array member of a struct. 4188c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// 4189c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// We avoid emitting out-of-bounds access warnings for such arrays as they are 4190c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// commonly used to emulate flexible arrays in C89 code. 4191c268434b332bbe57950d977633369bf5822d9554Chandler Carruthstatic bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size, 4192c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const NamedDecl *ND) { 4193c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (Size != 1 || !ND) return false; 4194c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 4195c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const FieldDecl *FD = dyn_cast<FieldDecl>(ND); 4196c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!FD) return false; 4197c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 4198c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // Don't consider sizes resulting from macro expansions or template argument 4199c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // substitution to form C89 tail-padded arrays. 4200c268434b332bbe57950d977633369bf5822d9554Chandler Carruth ConstantArrayTypeLoc TL = 4201c268434b332bbe57950d977633369bf5822d9554Chandler Carruth cast<ConstantArrayTypeLoc>(FD->getTypeSourceInfo()->getTypeLoc()); 4202c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const Expr *SizeExpr = dyn_cast<IntegerLiteral>(TL.getSizeExpr()); 4203c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!SizeExpr || SizeExpr->getExprLoc().isMacroID()) 4204c268434b332bbe57950d977633369bf5822d9554Chandler Carruth return false; 4205c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 4206c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext()); 4207381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!RD) return false; 4208381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (RD->isUnion()) return false; 4209381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) { 4210381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!CRD->isStandardLayout()) return false; 4211381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay } 4212c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 421322d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer // See if this is the last field decl in the record. 421422d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer const Decl *D = FD; 421522d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer while ((D = D->getNextDeclInContext())) 421622d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer if (isa<FieldDecl>(D)) 421722d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return false; 421822d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return true; 4219c268434b332bbe57950d977633369bf5822d9554Chandler Carruth} 4220c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 4221d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainvoid Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr, 422280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const ArraySubscriptExpr *ASE, 422325b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith bool AllowOnePastEnd, bool IndexNegated) { 4224d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain IndexExpr = IndexExpr->IgnoreParenCasts(); 422580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (IndexExpr->isValueDependent()) 422680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 4227d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 422880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const Type *EffectiveType = getElementType(BaseExpr); 422980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay BaseExpr = BaseExpr->IgnoreParenCasts(); 42303406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const ConstantArrayType *ArrayTy = 4231d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain Context.getAsConstantArrayType(BaseExpr->getType()); 42323406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (!ArrayTy) 4233a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 423435001ca261f895817916b468379b696d6d45959dChandler Carruth 42353406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth llvm::APSInt index; 423680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!IndexExpr->EvaluateAsInt(index, Context)) 4237a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 423825b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith if (IndexNegated) 423925b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith index = -index; 42408fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek 4241ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth const NamedDecl *ND = NULL; 4242ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 4243ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(DRE->getDecl()); 4244c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 4245ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 4246ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 42479e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek if (index.isUnsigned() || !index.isNegative()) { 424825b3b849e3ad340b04442707038c86980035765bTed Kremenek llvm::APInt size = ArrayTy->getSize(); 424935001ca261f895817916b468379b696d6d45959dChandler Carruth if (!size.isStrictlyPositive()) 425035001ca261f895817916b468379b696d6d45959dChandler Carruth return; 4251d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 4252d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* BaseType = getElementType(BaseExpr); 4253de5998f1d7dcecb777257ec932142d65de636eb8Nico Weber if (BaseType != EffectiveType) { 4254d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Make sure we're comparing apples to apples when comparing index to size 4255d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType); 4256d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t array_typesize = Context.getTypeSize(BaseType); 4257d10f4bc5a05ce0cdc1646dbb0f706bb9d3dfc0c5Kaelyn Uhrain // Handle ptrarith_typesize being zero, such as when casting to void* 425818f169770d9d3f826bad8f1359c8c5770c5ab16fKaelyn Uhrain if (!ptrarith_typesize) ptrarith_typesize = 1; 4259d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize != array_typesize) { 4260d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // There's a cast to a different size type involved 4261d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ratio = array_typesize / ptrarith_typesize; 4262d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // TODO: Be smarter about handling cases where array_typesize is not a 4263d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // multiple of ptrarith_typesize 4264d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize * ratio == array_typesize) 4265d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain size *= llvm::APInt(size.getBitWidth(), ratio); 4266d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 4267d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 4268d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 42693406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (size.getBitWidth() > index.getBitWidth()) 42703406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth index = index.sext(size.getBitWidth()); 427125b3b849e3ad340b04442707038c86980035765bTed Kremenek else if (size.getBitWidth() < index.getBitWidth()) 427225b3b849e3ad340b04442707038c86980035765bTed Kremenek size = size.sext(index.getBitWidth()); 427325b3b849e3ad340b04442707038c86980035765bTed Kremenek 4274d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // For array subscripting the index must be less than size, but for pointer 4275d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // arithmetic also allow the index (offset) to be equal to size since 4276d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // computing the next address after the end of the array is legal and 4277d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // commonly done e.g. in C++ iterators and range-based for loops. 4278d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (AllowOnePastEnd ? index.sle(size) : index.slt(size)) 4279ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth return; 4280ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 4281ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // Also don't warn for arrays of size 1 which are members of some 4282ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // structure. These are often used to approximate flexible arrays in C89 4283ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // code. 4284d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (IsTailPaddedMemberArray(*this, size, ND)) 42858fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek return; 42863406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth 428780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // Suppress the warning if the subscript expression (as identified by the 428880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // ']' location) and the index expression are both from macro expansions 428980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // within a system header. 429080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) { 429180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation RBracketLoc = SourceMgr.getSpellingLoc( 429280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay ASE->getRBracketLoc()); 429380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isInSystemHeader(RBracketLoc)) { 429480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation IndexLoc = SourceMgr.getSpellingLoc( 429580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay IndexExpr->getLocStart()); 429680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isFromSameFile(RBracketLoc, IndexLoc)) 429780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 429880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 429980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 430080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay 4301d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds; 430280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) 4303d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_array_index_exceeds_bounds; 4304d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 4305d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 4306d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 4307d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << size.toString(10, true) 4308d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << (unsigned)size.getLimitedValue(~0U) 4309d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 43103406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth } else { 4311d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_array_index_precedes_bounds; 431280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!ASE) { 4313d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_ptr_arith_precedes_bounds; 4314d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (index.isNegative()) index = -index; 4315d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 4316d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 4317d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 4318d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 4319d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 4320a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek } 432135001ca261f895817916b468379b696d6d45959dChandler Carruth 4322cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (!ND) { 4323cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay // Try harder to find a NamedDecl to point at in the note. 4324cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay while (const ArraySubscriptExpr *ASE = 4325cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay dyn_cast<ArraySubscriptExpr>(BaseExpr)) 4326cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay BaseExpr = ASE->getBase()->IgnoreParenCasts(); 4327cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 4328cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(DRE->getDecl()); 4329cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 4330cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 4331cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay } 4332cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay 433335001ca261f895817916b468379b696d6d45959dChandler Carruth if (ND) 4334d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(ND->getLocStart(), BaseExpr, 4335d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(diag::note_array_index_out_of_bounds) 4336d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << ND->getDeclName()); 43373aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek} 43383aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek 43393aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) { 4340d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain int AllowOnePastEnd = 0; 4341d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain while (expr) { 4342d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = expr->IgnoreParenImpCasts(); 43433aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek switch (expr->getStmtClass()) { 4344d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::ArraySubscriptExprClass: { 4345d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr); 434680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE, 4347d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd > 0); 43483aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 4349d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 4350d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::UnaryOperatorClass: { 4351d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Only unwrap the * and & unary operators 4352d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const UnaryOperator *UO = cast<UnaryOperator>(expr); 4353d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = UO->getSubExpr(); 4354d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain switch (UO->getOpcode()) { 4355d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_AddrOf: 4356d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd++; 4357d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 4358d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_Deref: 4359d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd--; 4360d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 4361d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain default: 4362d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return; 4363d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 4364d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 4365d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 43663aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek case Stmt::ConditionalOperatorClass: { 43673aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek const ConditionalOperator *cond = cast<ConditionalOperator>(expr); 43683aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *lhs = cond->getLHS()) 43693aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(lhs); 43703aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *rhs = cond->getRHS()) 43713aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(rhs); 43723aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 43733aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 43743aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek default: 43753aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 43763aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 4377f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne } 4378a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek} 4379f85e193739c953358c865005855253af4f68a497John McCall 4380f85e193739c953358c865005855253af4f68a497John McCall//===--- CHECK: Objective-C retain cycles ----------------------------------// 4381f85e193739c953358c865005855253af4f68a497John McCall 4382f85e193739c953358c865005855253af4f68a497John McCallnamespace { 4383f85e193739c953358c865005855253af4f68a497John McCall struct RetainCycleOwner { 4384f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner() : Variable(0), Indirect(false) {} 4385f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 4386f85e193739c953358c865005855253af4f68a497John McCall SourceRange Range; 4387f85e193739c953358c865005855253af4f68a497John McCall SourceLocation Loc; 4388f85e193739c953358c865005855253af4f68a497John McCall bool Indirect; 4389f85e193739c953358c865005855253af4f68a497John McCall 4390f85e193739c953358c865005855253af4f68a497John McCall void setLocsFrom(Expr *e) { 4391f85e193739c953358c865005855253af4f68a497John McCall Loc = e->getExprLoc(); 4392f85e193739c953358c865005855253af4f68a497John McCall Range = e->getSourceRange(); 4393f85e193739c953358c865005855253af4f68a497John McCall } 4394f85e193739c953358c865005855253af4f68a497John McCall }; 4395f85e193739c953358c865005855253af4f68a497John McCall} 4396f85e193739c953358c865005855253af4f68a497John McCall 4397f85e193739c953358c865005855253af4f68a497John McCall/// Consider whether capturing the given variable can possibly lead to 4398f85e193739c953358c865005855253af4f68a497John McCall/// a retain cycle. 4399f85e193739c953358c865005855253af4f68a497John McCallstatic bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) { 4400f85e193739c953358c865005855253af4f68a497John McCall // In ARC, it's captured strongly iff the variable has __strong 4401f85e193739c953358c865005855253af4f68a497John McCall // lifetime. In MRR, it's captured strongly if the variable is 4402f85e193739c953358c865005855253af4f68a497John McCall // __block and has an appropriate type. 4403f85e193739c953358c865005855253af4f68a497John McCall if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 4404f85e193739c953358c865005855253af4f68a497John McCall return false; 4405f85e193739c953358c865005855253af4f68a497John McCall 4406f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = var; 4407f85e193739c953358c865005855253af4f68a497John McCall owner.setLocsFrom(ref); 4408f85e193739c953358c865005855253af4f68a497John McCall return true; 4409f85e193739c953358c865005855253af4f68a497John McCall} 4410f85e193739c953358c865005855253af4f68a497John McCall 44116e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanianstatic bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) { 4412f85e193739c953358c865005855253af4f68a497John McCall while (true) { 4413f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParens(); 4414f85e193739c953358c865005855253af4f68a497John McCall if (CastExpr *cast = dyn_cast<CastExpr>(e)) { 4415f85e193739c953358c865005855253af4f68a497John McCall switch (cast->getCastKind()) { 4416f85e193739c953358c865005855253af4f68a497John McCall case CK_BitCast: 4417f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueBitCast: 4418f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueToRValue: 441933e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall case CK_ARCReclaimReturnedObject: 4420f85e193739c953358c865005855253af4f68a497John McCall e = cast->getSubExpr(); 4421f85e193739c953358c865005855253af4f68a497John McCall continue; 4422f85e193739c953358c865005855253af4f68a497John McCall 4423f85e193739c953358c865005855253af4f68a497John McCall default: 4424f85e193739c953358c865005855253af4f68a497John McCall return false; 4425f85e193739c953358c865005855253af4f68a497John McCall } 4426f85e193739c953358c865005855253af4f68a497John McCall } 4427f85e193739c953358c865005855253af4f68a497John McCall 4428f85e193739c953358c865005855253af4f68a497John McCall if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) { 4429f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar = ref->getDecl(); 4430f85e193739c953358c865005855253af4f68a497John McCall if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 4431f85e193739c953358c865005855253af4f68a497John McCall return false; 4432f85e193739c953358c865005855253af4f68a497John McCall 4433f85e193739c953358c865005855253af4f68a497John McCall // Try to find a retain cycle in the base. 44346e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(S, ref->getBase(), owner)) 4435f85e193739c953358c865005855253af4f68a497John McCall return false; 4436f85e193739c953358c865005855253af4f68a497John McCall 4437f85e193739c953358c865005855253af4f68a497John McCall if (ref->isFreeIvar()) owner.setLocsFrom(ref); 4438f85e193739c953358c865005855253af4f68a497John McCall owner.Indirect = true; 4439f85e193739c953358c865005855253af4f68a497John McCall return true; 4440f85e193739c953358c865005855253af4f68a497John McCall } 4441f85e193739c953358c865005855253af4f68a497John McCall 4442f85e193739c953358c865005855253af4f68a497John McCall if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) { 4443f85e193739c953358c865005855253af4f68a497John McCall VarDecl *var = dyn_cast<VarDecl>(ref->getDecl()); 4444f85e193739c953358c865005855253af4f68a497John McCall if (!var) return false; 4445f85e193739c953358c865005855253af4f68a497John McCall return considerVariable(var, ref, owner); 4446f85e193739c953358c865005855253af4f68a497John McCall } 4447f85e193739c953358c865005855253af4f68a497John McCall 4448f85e193739c953358c865005855253af4f68a497John McCall if (BlockDeclRefExpr *ref = dyn_cast<BlockDeclRefExpr>(e)) { 4449f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = ref->getDecl(); 4450f85e193739c953358c865005855253af4f68a497John McCall owner.setLocsFrom(ref); 4451f85e193739c953358c865005855253af4f68a497John McCall return true; 4452f85e193739c953358c865005855253af4f68a497John McCall } 4453f85e193739c953358c865005855253af4f68a497John McCall 4454f85e193739c953358c865005855253af4f68a497John McCall if (MemberExpr *member = dyn_cast<MemberExpr>(e)) { 4455f85e193739c953358c865005855253af4f68a497John McCall if (member->isArrow()) return false; 4456f85e193739c953358c865005855253af4f68a497John McCall 4457f85e193739c953358c865005855253af4f68a497John McCall // Don't count this as an indirect ownership. 4458f85e193739c953358c865005855253af4f68a497John McCall e = member->getBase(); 4459f85e193739c953358c865005855253af4f68a497John McCall continue; 4460f85e193739c953358c865005855253af4f68a497John McCall } 4461f85e193739c953358c865005855253af4f68a497John McCall 44624b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) { 44634b9c2d235fb9449e249d74f48ecfec601650de93John McCall // Only pay attention to pseudo-objects on property references. 44644b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyRefExpr *pre 44654b9c2d235fb9449e249d74f48ecfec601650de93John McCall = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm() 44664b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->IgnoreParens()); 44674b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!pre) return false; 44684b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (pre->isImplicitProperty()) return false; 44694b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyDecl *property = pre->getExplicitProperty(); 44704b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!property->isRetaining() && 44714b9c2d235fb9449e249d74f48ecfec601650de93John McCall !(property->getPropertyIvarDecl() && 44724b9c2d235fb9449e249d74f48ecfec601650de93John McCall property->getPropertyIvarDecl()->getType() 44734b9c2d235fb9449e249d74f48ecfec601650de93John McCall .getObjCLifetime() == Qualifiers::OCL_Strong)) 44744b9c2d235fb9449e249d74f48ecfec601650de93John McCall return false; 44754b9c2d235fb9449e249d74f48ecfec601650de93John McCall 44764b9c2d235fb9449e249d74f48ecfec601650de93John McCall owner.Indirect = true; 44776e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (pre->isSuperReceiver()) { 44786e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Variable = S.getCurMethodDecl()->getSelfDecl(); 44796e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!owner.Variable) 44806e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return false; 44816e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Loc = pre->getLocation(); 44826e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Range = pre->getSourceRange(); 44836e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return true; 44846e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian } 44854b9c2d235fb9449e249d74f48ecfec601650de93John McCall e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase()) 44864b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->getSourceExpr()); 44874b9c2d235fb9449e249d74f48ecfec601650de93John McCall continue; 44884b9c2d235fb9449e249d74f48ecfec601650de93John McCall } 44894b9c2d235fb9449e249d74f48ecfec601650de93John McCall 4490f85e193739c953358c865005855253af4f68a497John McCall // Array ivars? 4491f85e193739c953358c865005855253af4f68a497John McCall 4492f85e193739c953358c865005855253af4f68a497John McCall return false; 4493f85e193739c953358c865005855253af4f68a497John McCall } 4494f85e193739c953358c865005855253af4f68a497John McCall} 4495f85e193739c953358c865005855253af4f68a497John McCall 4496f85e193739c953358c865005855253af4f68a497John McCallnamespace { 4497f85e193739c953358c865005855253af4f68a497John McCall struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> { 4498f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor(ASTContext &Context, VarDecl *variable) 4499f85e193739c953358c865005855253af4f68a497John McCall : EvaluatedExprVisitor<FindCaptureVisitor>(Context), 4500f85e193739c953358c865005855253af4f68a497John McCall Variable(variable), Capturer(0) {} 4501f85e193739c953358c865005855253af4f68a497John McCall 4502f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 4503f85e193739c953358c865005855253af4f68a497John McCall Expr *Capturer; 4504f85e193739c953358c865005855253af4f68a497John McCall 4505f85e193739c953358c865005855253af4f68a497John McCall void VisitDeclRefExpr(DeclRefExpr *ref) { 4506f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 4507f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 4508f85e193739c953358c865005855253af4f68a497John McCall } 4509f85e193739c953358c865005855253af4f68a497John McCall 4510f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockDeclRefExpr(BlockDeclRefExpr *ref) { 4511f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 4512f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 4513f85e193739c953358c865005855253af4f68a497John McCall } 4514f85e193739c953358c865005855253af4f68a497John McCall 4515f85e193739c953358c865005855253af4f68a497John McCall void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) { 4516f85e193739c953358c865005855253af4f68a497John McCall if (Capturer) return; 4517f85e193739c953358c865005855253af4f68a497John McCall Visit(ref->getBase()); 4518f85e193739c953358c865005855253af4f68a497John McCall if (Capturer && ref->isFreeIvar()) 4519f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 4520f85e193739c953358c865005855253af4f68a497John McCall } 4521f85e193739c953358c865005855253af4f68a497John McCall 4522f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockExpr(BlockExpr *block) { 4523f85e193739c953358c865005855253af4f68a497John McCall // Look inside nested blocks 4524f85e193739c953358c865005855253af4f68a497John McCall if (block->getBlockDecl()->capturesVariable(Variable)) 4525f85e193739c953358c865005855253af4f68a497John McCall Visit(block->getBlockDecl()->getBody()); 4526f85e193739c953358c865005855253af4f68a497John McCall } 4527f85e193739c953358c865005855253af4f68a497John McCall }; 4528f85e193739c953358c865005855253af4f68a497John McCall} 4529f85e193739c953358c865005855253af4f68a497John McCall 4530f85e193739c953358c865005855253af4f68a497John McCall/// Check whether the given argument is a block which captures a 4531f85e193739c953358c865005855253af4f68a497John McCall/// variable. 4532f85e193739c953358c865005855253af4f68a497John McCallstatic Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) { 4533f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 4534f85e193739c953358c865005855253af4f68a497John McCall 4535f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParenCasts(); 4536f85e193739c953358c865005855253af4f68a497John McCall BlockExpr *block = dyn_cast<BlockExpr>(e); 4537f85e193739c953358c865005855253af4f68a497John McCall if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable)) 4538f85e193739c953358c865005855253af4f68a497John McCall return 0; 4539f85e193739c953358c865005855253af4f68a497John McCall 4540f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor visitor(S.Context, owner.Variable); 4541f85e193739c953358c865005855253af4f68a497John McCall visitor.Visit(block->getBlockDecl()->getBody()); 4542f85e193739c953358c865005855253af4f68a497John McCall return visitor.Capturer; 4543f85e193739c953358c865005855253af4f68a497John McCall} 4544f85e193739c953358c865005855253af4f68a497John McCall 4545f85e193739c953358c865005855253af4f68a497John McCallstatic void diagnoseRetainCycle(Sema &S, Expr *capturer, 4546f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner &owner) { 4547f85e193739c953358c865005855253af4f68a497John McCall assert(capturer); 4548f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 4549f85e193739c953358c865005855253af4f68a497John McCall 4550f85e193739c953358c865005855253af4f68a497John McCall S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle) 4551f85e193739c953358c865005855253af4f68a497John McCall << owner.Variable << capturer->getSourceRange(); 4552f85e193739c953358c865005855253af4f68a497John McCall S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner) 4553f85e193739c953358c865005855253af4f68a497John McCall << owner.Indirect << owner.Range; 4554f85e193739c953358c865005855253af4f68a497John McCall} 4555f85e193739c953358c865005855253af4f68a497John McCall 4556f85e193739c953358c865005855253af4f68a497John McCall/// Check for a keyword selector that starts with the word 'add' or 4557f85e193739c953358c865005855253af4f68a497John McCall/// 'set'. 4558f85e193739c953358c865005855253af4f68a497John McCallstatic bool isSetterLikeSelector(Selector sel) { 4559f85e193739c953358c865005855253af4f68a497John McCall if (sel.isUnarySelector()) return false; 4560f85e193739c953358c865005855253af4f68a497John McCall 45615f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef str = sel.getNameForSlot(0); 4562f85e193739c953358c865005855253af4f68a497John McCall while (!str.empty() && str.front() == '_') str = str.substr(1); 4563968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (str.startswith("set")) 4564f85e193739c953358c865005855253af4f68a497John McCall str = str.substr(3); 4565968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek else if (str.startswith("add")) { 4566968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek // Specially whitelist 'addOperationWithBlock:'. 4567968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock")) 4568968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek return false; 4569968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek str = str.substr(3); 4570968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek } 4571f85e193739c953358c865005855253af4f68a497John McCall else 4572f85e193739c953358c865005855253af4f68a497John McCall return false; 4573f85e193739c953358c865005855253af4f68a497John McCall 4574f85e193739c953358c865005855253af4f68a497John McCall if (str.empty()) return true; 4575f85e193739c953358c865005855253af4f68a497John McCall return !islower(str.front()); 4576f85e193739c953358c865005855253af4f68a497John McCall} 4577f85e193739c953358c865005855253af4f68a497John McCall 4578f85e193739c953358c865005855253af4f68a497John McCall/// Check a message send to see if it's likely to cause a retain cycle. 4579f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(ObjCMessageExpr *msg) { 4580f85e193739c953358c865005855253af4f68a497John McCall // Only check instance methods whose selector looks like a setter. 4581f85e193739c953358c865005855253af4f68a497John McCall if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector())) 4582f85e193739c953358c865005855253af4f68a497John McCall return; 4583f85e193739c953358c865005855253af4f68a497John McCall 4584f85e193739c953358c865005855253af4f68a497John McCall // Try to find a variable that the receiver is strongly owned by. 4585f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 4586f85e193739c953358c865005855253af4f68a497John McCall if (msg->getReceiverKind() == ObjCMessageExpr::Instance) { 45876e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner)) 4588f85e193739c953358c865005855253af4f68a497John McCall return; 4589f85e193739c953358c865005855253af4f68a497John McCall } else { 4590f85e193739c953358c865005855253af4f68a497John McCall assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance); 4591f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = getCurMethodDecl()->getSelfDecl(); 4592f85e193739c953358c865005855253af4f68a497John McCall owner.Loc = msg->getSuperLoc(); 4593f85e193739c953358c865005855253af4f68a497John McCall owner.Range = msg->getSuperLoc(); 4594f85e193739c953358c865005855253af4f68a497John McCall } 4595f85e193739c953358c865005855253af4f68a497John McCall 4596f85e193739c953358c865005855253af4f68a497John McCall // Check whether the receiver is captured by any of the arguments. 4597f85e193739c953358c865005855253af4f68a497John McCall for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i) 4598f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner)) 4599f85e193739c953358c865005855253af4f68a497John McCall return diagnoseRetainCycle(*this, capturer, owner); 4600f85e193739c953358c865005855253af4f68a497John McCall} 4601f85e193739c953358c865005855253af4f68a497John McCall 4602f85e193739c953358c865005855253af4f68a497John McCall/// Check a property assign to see if it's likely to cause a retain cycle. 4603f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(Expr *receiver, Expr *argument) { 4604f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 46056e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, receiver, owner)) 4606f85e193739c953358c865005855253af4f68a497John McCall return; 4607f85e193739c953358c865005855253af4f68a497John McCall 4608f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, argument, owner)) 4609f85e193739c953358c865005855253af4f68a497John McCall diagnoseRetainCycle(*this, capturer, owner); 4610f85e193739c953358c865005855253af4f68a497John McCall} 4611f85e193739c953358c865005855253af4f68a497John McCall 4612921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianbool Sema::checkUnsafeAssigns(SourceLocation Loc, 4613f85e193739c953358c865005855253af4f68a497John McCall QualType LHS, Expr *RHS) { 4614f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime(); 4615f85e193739c953358c865005855253af4f68a497John McCall if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone) 4616921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return false; 4617921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // strip off any implicit cast added to get to the one arc-specific 4618921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 461933e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 4620f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::warn_arc_retained_assign) 4621f85e193739c953358c865005855253af4f68a497John McCall << (LT == Qualifiers::OCL_ExplicitNone) 4622f85e193739c953358c865005855253af4f68a497John McCall << RHS->getSourceRange(); 4623921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return true; 4624921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4625921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 4626921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4627921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return false; 4628f85e193739c953358c865005855253af4f68a497John McCall} 4629f85e193739c953358c865005855253af4f68a497John McCall 4630921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianvoid Sema::checkUnsafeExprAssigns(SourceLocation Loc, 4631921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Expr *LHS, Expr *RHS) { 4632921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian QualType LHSType = LHS->getType(); 4633921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (checkUnsafeAssigns(Loc, LHSType, RHS)) 4634921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4635921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime(); 4636921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // FIXME. Check for other life times. 4637921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (LT != Qualifiers::OCL_None) 4638921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4639921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 46403c3b7f90a863af43fa63043d396553ecf205351cJohn McCall if (ObjCPropertyRefExpr *PRE 46413c3b7f90a863af43fa63043d396553ecf205351cJohn McCall = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens())) { 4642921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (PRE->isImplicitProperty()) 4643921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4644921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 4645921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (!PD) 4646921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4647921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 4648921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian unsigned Attributes = PD->getPropertyAttributes(); 4649921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) 4650921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 465133e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 4652921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Diag(Loc, diag::warn_arc_retained_property_assign) 4653921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian << RHS->getSourceRange(); 4654921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4655921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4656921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 4657921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4658921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4659921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian} 4660