SemaChecking.cpp revision 1844a6e1074a5c1fd8eadac7fc7317c3e29d4653
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// The LLVM Compiler Infrastructure 459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source 60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details. 759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump// This file implements extra semantic analysis beyond what is enforced 1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// by the C type system. 1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 15e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Sema.h" 162d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 17781472fe99a120098c631b0cbe33c89f8cef5e70John McCall#include "clang/Sema/ScopeInfo.h" 18826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek#include "clang/Analysis/Analyses/FormatString.h" 1959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h" 20199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h" 21384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 22c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h" 232324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h" 247ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h" 25f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/DeclObjC.h" 26f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h" 27f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h" 28719e61573f27c11057ecfe0dd8f141621602c571Chris Lattner#include "clang/Lex/LiteralSupport.h" 2959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h" 30f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h" 31f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h" 323bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h" 33691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher#include "clang/Basic/TargetBuiltins.h" 3426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman#include "clang/Basic/TargetInfo.h" 357da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian#include "clang/Basic/ConvertUTF.h" 367da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 37a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits> 3859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang; 39781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema; 4059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 4160800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner/// getLocationOfStringLiteralByte - Return a source location that points to the 4260800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner/// specified byte of the specified string literal. 4360800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner/// 4460800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner/// Strings are amazingly complex. They can be formed from multiple tokens and 4560800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner/// can have escape sequences in them in addition to the usual trigraph and 4660800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner/// escaped newline business. This routine handles this complexity. 4760800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner/// 4860800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 4960800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned ByteNo) const { 5060800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner assert(!SL->isWide() && "This doesn't work for wide strings yet"); 511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5260800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner // Loop over all of the tokens in this string until we find the one that 5360800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner // contains the byte we're looking for. 5460800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned TokNo = 0; 5560800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner while (1) { 5660800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner assert(TokNo < SL->getNumConcatenated() && "Invalid byte number!"); 5760800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner SourceLocation StrTokLoc = SL->getStrTokenLoc(TokNo); 581eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5960800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner // Get the spelling of the string so that we can get the data that makes up 6060800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner // the string literal, not the identifier for the macro it is potentially 6160800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner // expanded through. 6260800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner SourceLocation StrTokSpellingLoc = SourceMgr.getSpellingLoc(StrTokLoc); 6360800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 6460800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner // Re-lex the token to get its length and original spelling. 6560800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner std::pair<FileID, unsigned> LocInfo = 6660800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner SourceMgr.getDecomposedLoc(StrTokSpellingLoc); 67f715ca12bfc9fddfde75f98a197424434428b821Douglas Gregor bool Invalid = false; 68f6ac97b101c8840efa92bf29166077ce4049e293Benjamin Kramer llvm::StringRef Buffer = SourceMgr.getBufferData(LocInfo.first, &Invalid); 69f715ca12bfc9fddfde75f98a197424434428b821Douglas Gregor if (Invalid) 70aea67dbd653a2dd6dd5cc2159279e81e855b2482Douglas Gregor return StrTokSpellingLoc; 71aea67dbd653a2dd6dd5cc2159279e81e855b2482Douglas Gregor 72f6ac97b101c8840efa92bf29166077ce4049e293Benjamin Kramer const char *StrData = Buffer.data()+LocInfo.second; 731eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7460800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner // Create a langops struct and enable trigraphs. This is sufficient for 7560800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner // relexing tokens. 7660800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner LangOptions LangOpts; 7760800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner LangOpts.Trigraphs = true; 781eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7960800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner // Create a lexer starting at the beginning of this token. 80f6ac97b101c8840efa92bf29166077ce4049e293Benjamin Kramer Lexer TheLexer(StrTokSpellingLoc, LangOpts, Buffer.begin(), StrData, 81f6ac97b101c8840efa92bf29166077ce4049e293Benjamin Kramer Buffer.end()); 8260800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner Token TheTok; 8360800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner TheLexer.LexFromRawLexer(TheTok); 841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 85443e53c7845f01c8ed693ccd137abb0bd76564f6Chris Lattner // Use the StringLiteralParser to compute the length of the string in bytes. 86b90f4b3fb94056609da9cca5eef7358d95a363b2Douglas Gregor StringLiteralParser SLP(&TheTok, 1, PP, /*Complain=*/false); 87443e53c7845f01c8ed693ccd137abb0bd76564f6Chris Lattner unsigned TokNumBytes = SLP.GetStringLength(); 881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 892197c963543397777919cec22b65feb31a9ddf79Chris Lattner // If the byte is in this token, return the location of the byte. 9060800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner if (ByteNo < TokNumBytes || 9160800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner (ByteNo == TokNumBytes && TokNo == SL->getNumConcatenated())) { 921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump unsigned Offset = 93b90f4b3fb94056609da9cca5eef7358d95a363b2Douglas Gregor StringLiteralParser::getOffsetOfStringByte(TheTok, ByteNo, PP, 94b90f4b3fb94056609da9cca5eef7358d95a363b2Douglas Gregor /*Complain=*/false); 951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 96719e61573f27c11057ecfe0dd8f141621602c571Chris Lattner // Now that we know the offset of the token in the spelling, use the 97719e61573f27c11057ecfe0dd8f141621602c571Chris Lattner // preprocessor to get the offset in the original source. 98719e61573f27c11057ecfe0dd8f141621602c571Chris Lattner return PP.AdvanceToTokenCharacter(StrTokLoc, Offset); 9960800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner } 1001eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10160800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner // Move to the next string token. 10260800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner ++TokNo; 10360800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner ByteNo -= TokNumBytes; 10460800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner } 10560800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner} 10660800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 1074403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// CheckablePrintfAttr - does a function call have a "printf" attribute 1084403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// and arguments that merit checking? 1094403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynnbool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) { 1104403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf") return true; 1114403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf0") { 1124403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn // printf0 allows null "format" string; if so don't check format/args 1134403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn unsigned format_idx = Format->getFormatIdx() - 1; 1144a2614e94672c47395abcde60518776fbebec589Sebastian Redl // Does the index refer to the implicit object argument? 1154a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 1164a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (format_idx == 0) 1174a2614e94672c47395abcde60518776fbebec589Sebastian Redl return false; 1184a2614e94672c47395abcde60518776fbebec589Sebastian Redl --format_idx; 1194a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 1204403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (format_idx < TheCall->getNumArgs()) { 1214403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts(); 122efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!Format->isNullPointerConstant(Context, 123efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek Expr::NPC_ValueDependentIsNull)) 1244403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return true; 1254403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 1264403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 1274403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return false; 1284403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn} 12960800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 13060d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 131d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 13260d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult TheCallResult(Owned(TheCall)); 1332def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor 134946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Find out if any arguments are required to be integer constant expressions. 135946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner unsigned ICEArguments = 0; 136946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ASTContext::GetBuiltinTypeError Error; 137946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 138946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (Error != ASTContext::GE_None) 139946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments = 0; // Don't diagnose previously diagnosed errors. 140946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 141946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // If any arguments are required to be ICE's, check and diagnose. 142946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 143946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Skip arguments not required to be ICE's. 144946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if ((ICEArguments & (1 << ArgNo)) == 0) continue; 145946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 146946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner llvm::APSInt Result; 147946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 148946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner return true; 149946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments &= ~(1 << ArgNo); 150946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner } 151946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 152d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson switch (BuiltinID) { 15330ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin___CFStringMakeConstantString: 154925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner assert(TheCall->getNumArgs() == 1 && 1551b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner "Wrong # arguments to builtin CFStringMakeConstantString"); 156690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner if (CheckObjCString(TheCall->getArg(0))) 1570eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 158d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 15949ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek case Builtin::BI__builtin_stdarg_start: 16030ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin_va_start: 1610eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinVAStart(TheCall)) 1620eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 163d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1641b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreater: 1651b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreaterequal: 1661b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isless: 1671b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessequal: 1681b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessgreater: 1691b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isunordered: 1700eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinUnorderedCompare(TheCall)) 1710eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 172d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 173e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer case Builtin::BI__builtin_fpclassify: 174e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer if (SemaBuiltinFPClassification(TheCall, 6)) 175e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer return ExprError(); 176e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer break; 1779ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isfinite: 1789ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf: 1799ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf_sign: 1809ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnan: 1819ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnormal: 1823b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (SemaBuiltinFPClassification(TheCall, 1)) 1839ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return ExprError(); 1849ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman break; 185d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman case Builtin::BI__builtin_shufflevector: 1860eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return SemaBuiltinShuffleVector(TheCall); 1870eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // TheCall will be freed by the smart pointer here, but that's fine, since 1880eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // SemaBuiltinShuffleVector guts it, but then doesn't release it. 1894493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar case Builtin::BI__builtin_prefetch: 1900eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinPrefetch(TheCall)) 1910eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 192d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 193d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar case Builtin::BI__builtin_object_size: 1940eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinObjectSize(TheCall)) 1950eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 196d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 197d875fed28578835de89cd407e9db4be788596d7cEli Friedman case Builtin::BI__builtin_longjmp: 198d875fed28578835de89cd407e9db4be788596d7cEli Friedman if (SemaBuiltinLongjmp(TheCall)) 199d875fed28578835de89cd407e9db4be788596d7cEli Friedman return ExprError(); 200d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 20175c29a012793292ff4578015a9113bf086156d7fChris Lattner case Builtin::BI__builtin_constant_p: 20275c29a012793292ff4578015a9113bf086156d7fChris Lattner if (TheCall->getNumArgs() == 0) 20375c29a012793292ff4578015a9113bf086156d7fChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 20475c29a012793292ff4578015a9113bf086156d7fChris Lattner << 0 /*function call*/ << 1 << 0 << TheCall->getSourceRange(); 20575c29a012793292ff4578015a9113bf086156d7fChris Lattner if (TheCall->getNumArgs() > 1) 20675c29a012793292ff4578015a9113bf086156d7fChris Lattner return Diag(TheCall->getArg(1)->getLocStart(), 20775c29a012793292ff4578015a9113bf086156d7fChris Lattner diag::err_typecheck_call_too_many_args) 20875c29a012793292ff4578015a9113bf086156d7fChris Lattner << 0 /*function call*/ << 1 << TheCall->getNumArgs() 20975c29a012793292ff4578015a9113bf086156d7fChris Lattner << TheCall->getArg(1)->getSourceRange(); 21075c29a012793292ff4578015a9113bf086156d7fChris Lattner break; 2115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: 2125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: 2135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: 2145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: 2155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: 2165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_add_and_fetch: 2175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_sub_and_fetch: 2185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_and_and_fetch: 2195caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_or_and_fetch: 2205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_xor_and_fetch: 2215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 2225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 2235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_test_and_set: 2245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 225d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return SemaBuiltinAtomicOverloaded(move(TheCallResult)); 22626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 22726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 22826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // Since the target specific builtins for each arch overlap, only check those 22926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // of the arch we are compiling for. 23026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (BuiltinID >= Builtin::FirstTSBuiltin) { 23126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman switch (Context.Target.getTriple().getArch()) { 23226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::arm: 23326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::thumb: 23426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 23526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return ExprError(); 23626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 23726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman default: 23826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 23926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 24026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 24126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 24226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return move(TheCallResult); 24326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman} 24426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 24561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code. 24661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) { 24761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman bool quad = t & 0x10; 24861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 24961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman switch (t & 0x7) { 25061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 0: // i8 251d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 7 : (8 << (int)quad) - 1; 25261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 1: // i16 253d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 15 : (4 << (int)quad) - 1; 25461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 2: // i32 255d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 31 : (2 << (int)quad) - 1; 25661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 3: // i64 257d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 63 : (1 << (int)quad) - 1; 25861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 4: // f32 25961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift float types!"); 260d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (2 << (int)quad) - 1; 26161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 5: // poly8 26261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift polynomial types!"); 263d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (8 << (int)quad) - 1; 26461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 6: // poly16 26561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift polynomial types!"); 266d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (4 << (int)quad) - 1; 26761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 7: // float16 26861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift float types!"); 269d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (4 << (int)quad) - 1; 27061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman } 27161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman return 0; 27261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman} 27361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 27426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 2751c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman llvm::APSInt Result; 2761c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2770d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned mask = 0; 27861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned TV = 0; 2791c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman switch (BuiltinID) { 280a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK 281a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 282a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK 2831c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman } 2841c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2850d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which are overloaded on vector element type, validate 2860d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // the immediate which specifies which variant to emit. 2870d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (mask) { 2880d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned ArgNo = TheCall->getNumArgs()-1; 2890d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 2900d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 2910d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 29261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman TV = Result.getLimitedValue(32); 29361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if ((TV > 31) || (mask & (1 << TV)) == 0) 2940d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 2950d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman << TheCall->getArg(ArgNo)->getSourceRange(); 2960d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman } 2971c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2980d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which take an immediate value as part of the 2990d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // instruction, range check them here. 30061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned i = 0, l = 0, u = 0; 3010d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman switch (BuiltinID) { 3020d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman default: return false; 303bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 304bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 30599c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_f: 30699c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 307a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK 308a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 309a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK 3100d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman }; 3110d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 31261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Check that the immediate argument is actually a constant. 3130d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, i, Result)) 3140d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 3150d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 31661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Range check against the upper/lower values for this isntruction. 3170d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned Val = Result.getZExtValue(); 31861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if (Val < l || Val > (u + l)) 3190d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 320476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer << l << u+l << TheCall->getArg(i)->getSourceRange(); 3210d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 32299c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman // FIXME: VFP Intrinsics should error if VFP not present. 32326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return false; 324d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson} 325d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 326d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// CheckFunctionCall - Check a direct function call for various correctness 327d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// and safety properties not strictly enforced by the C type system. 328d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) { 329d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // Get the IdentifierInfo* for the called function. 330d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson IdentifierInfo *FnInfo = FDecl->getIdentifier(); 331de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 332d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // None of the checks below are needed for functions that don't have 333d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // simple names (e.g., C++ conversion functions). 334d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson if (!FnInfo) 335d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 337de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // FIXME: This mechanism should be abstracted to be less fragile and 338de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // more efficient. For example, just map function ids to custom 339de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // handlers. 340de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 341c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek // Printf and scanf checking. 342c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<FormatAttr> 343c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<FormatAttr>(), 344c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<FormatAttr>(); i != e ; ++i) { 345c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek 346c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek const FormatAttr *Format = *i; 347826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 348826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (b || CheckablePrintfAttr(Format, TheCall)) { 3493d692df4b9c58895f9843b03543ec57447c93679Ted Kremenek bool HasVAListArg = Format->getFirstArg() == 0; 350826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, 351826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Format->getFormatIdx() - 1, 352826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, 353826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek !b); 3543c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor } 35559907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner } 3561eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 357c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<NonNullAttr> 358c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<NonNullAttr>(), 359c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<NonNullAttr>(); i != e; ++i) { 360cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt CheckNonNullArguments(*i, TheCall); 361c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek } 3620eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 363d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 36471993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson} 36571993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 366d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) { 367725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian // Printf checking. 36840b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis const FormatAttr *Format = NDecl->getAttr<FormatAttr>(); 369725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Format) 370d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 372725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian const VarDecl *V = dyn_cast<VarDecl>(NDecl); 373725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!V) 374d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 376725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian QualType Ty = V->getType(); 377725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Ty->isBlockPointerType()) 378d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 380826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 381826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!b && !CheckablePrintfAttr(Format, TheCall)) 382d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 384d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson bool HasVAListArg = Format->getFirstArg() == 0; 385826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1, 386826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, !b); 387d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 388d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 389725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian} 390725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian 3915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like 3925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer 3935caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument. The main ActOnCallExpr routines have already 3945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as 3955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...). 3965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// 3975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these 3985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins, 39960d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 40060d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 401d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 4025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 4035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 4045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 4055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Ensure that we have at least one argument to do type inference from. 406d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1) { 407d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 408d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1 << TheCall->getNumArgs() 409d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 410d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 411d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 4121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Inspect the first argument of the atomic builtin. This should always be 4145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // a pointer type, whose element is an integral scalar or pointer type. 4155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Because it is a pointer type, we don't have to worry about any implicit 4165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // casts here. 417d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth // FIXME: We don't allow floating point scalars as input. 4185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *FirstArg = TheCall->getArg(0); 419d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (!FirstArg->getType()->isPointerType()) { 420d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 421d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 422d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 423d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 4241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 425d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth QualType ValType = 426d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth FirstArg->getType()->getAs<PointerType>()->getPointeeType(); 427dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 428d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth !ValType->isBlockPointerType()) { 429d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 430d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 431d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 432d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 4335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 4348d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // The majority of builtins return a value, but a few have special return 4358d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // types, so allow them to override appropriately below. 4368d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth QualType ResultType = ValType; 4378d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth 4385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // We need to figure out which concrete builtin this maps onto. For example, 4395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add with a 2 byte object turns into 4405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add_2. 4415caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \ 4425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 4435caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Builtin::BI##x##_8, Builtin::BI##x##_16 } 4441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner static const unsigned BuiltinIndices[][5] = { 4465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_add), 4475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_sub), 4485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_or), 4495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_and), 4505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_xor), 4511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_add_and_fetch), 4535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_sub_and_fetch), 4545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_and_and_fetch), 4555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_or_and_fetch), 4565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_xor_and_fetch), 4571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4585caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_val_compare_and_swap), 4595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_bool_compare_and_swap), 4605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_test_and_set), 4615caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_release) 4625caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner }; 4631eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW 4641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4655caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Determine the index of the size. 4665caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned SizeIndex; 467199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 4685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 1: SizeIndex = 0; break; 4695caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 2: SizeIndex = 1; break; 4705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 4: SizeIndex = 2; break; 4715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 8: SizeIndex = 3; break; 4725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 16: SizeIndex = 4; break; 4735caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: 474d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 475d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 476d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 4775caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 4781eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Each of these builtins has one pointer argument, followed by some number of 4805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // values (0, 1 or 2) followed by a potentially empty varags list of stuff 4815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // that we ignore. Find out which row of BuiltinIndices to read from as well 4825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // as the number of fixed args. 4837814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor unsigned BuiltinID = FDecl->getBuiltinID(); 4845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned BuiltinIndex, NumFixed = 1; 4855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner switch (BuiltinID) { 4865caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: assert(0 && "Unknown overloaded atomic builtin!"); 4875caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break; 4885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break; 4895caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break; 4905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break; 4915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break; 4921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4937eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break; 4947eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break; 4957eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break; 4967eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break; 4977eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break; 4981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 5007eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 10; 5015caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 5025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 5035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 5047eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 11; 5055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 5068d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.BoolTy; 5075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 5087eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break; 5095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 5107eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 13; 5115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 0; 5128d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.VoidTy; 5135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 5145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 5151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Now that we know how many fixed arguments we expect, first check that we 5175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // have at least that many. 518d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1+NumFixed) { 519d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 520d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1+NumFixed << TheCall->getNumArgs() 521d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 522d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 523d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 5241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 525e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // Get the decl for the concrete builtin from this, we can tell what the 526e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // concrete integer type we should convert to is. 527e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 528e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 529e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName); 5301eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump FunctionDecl *NewBuiltinDecl = 531e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID, 532e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner TUScope, false, DRE->getLocStart())); 533d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 534f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // The first argument --- the pointer --- has a fixed type; we 535f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // deduce the types of the rest of the arguments accordingly. Walk 536f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // the remaining arguments, converting them to the deduced value type. 5375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner for (unsigned i = 0; i != NumFixed; ++i) { 5385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *Arg = TheCall->getArg(i+1); 5391eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // If the argument is an implicit cast, then there was a promotion due to 5415caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // "...", just remove it now. 5425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) { 5435caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Arg = ICE->getSubExpr(); 5445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner ICE->setSubExpr(0); 5455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner TheCall->setArg(i+1, Arg); 5465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 5471eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // GCC does an implicit conversion to the pointer or integer ValType. This 5495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // can fail in some cases (1i -> int**), check for this error case now. 5502de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall CastKind Kind = CK_Unknown; 551f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall CXXCastPath BasePath; 5525cf86ba6b5a724bf91cb52feade1158f1fbeb605Anders Carlsson if (CheckCastTypes(Arg->getSourceRange(), ValType, Arg, Kind, BasePath)) 553d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 5541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Okay, we have something that *can* be converted to the right type. Check 5565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // to see if there is a potentially weird extension going on here. This can 5575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // happen when you do an atomic operation on something like an char* and 5585caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // pass in 42. The 42 gets converted to char. This is even more strange 5595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // for things like 45.123 -> char, etc. 5601eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // FIXME: Do this check. 5615baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall ImpCastExprToType(Arg, ValType, Kind, VK_RValue, &BasePath); 5625caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner TheCall->setArg(i+1, Arg); 5635caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 5641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5655caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Switch the DeclRefExpr to refer to the new decl. 5665caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DRE->setDecl(NewBuiltinDecl); 5675caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DRE->setType(NewBuiltinDecl->getType()); 5681eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5695caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Set the callee in the CallExpr. 5705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // FIXME: This leaks the original parens and implicit casts. 5715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *PromotedCall = DRE; 5725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner UsualUnaryConversions(PromotedCall); 5735caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner TheCall->setCallee(PromotedCall); 5741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 575db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // Change the result type of the call to match the original value type. This 576db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // is arbitrary, but the codegen for these builtins ins design to handle it 577db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // gracefully. 5788d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth TheCall->setType(ResultType); 579d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 580d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return move(TheCallResult); 5815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner} 5825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 5835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 584690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin 58571993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct 586fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would 587fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend). 588690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) { 58956f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner Arg = Arg->IgnoreParenCasts(); 59071993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 59171993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 59271993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson if (!Literal || Literal->isWide()) { 593fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 594fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << Arg->getSourceRange(); 5959cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return true; 59671993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson } 5971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5982f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer size_t NulPos = Literal->getString().find('\0'); 5992f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer if (NulPos != llvm::StringRef::npos) { 6002f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer Diag(getLocationOfStringLiteralByte(Literal, NulPos), 6012f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer diag::warn_cfstring_literal_contains_nul_character) 6022f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer << Arg->getSourceRange(); 603f015b034159d40e7033309e50036804eb1971787Daniel Dunbar } 6047da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Literal->containsNonAsciiOrNull()) { 6057da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian llvm::StringRef String = Literal->getString(); 6067da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian unsigned NumBytes = String.size(); 6077da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian llvm::SmallVector<UTF16, 128> ToBuf(NumBytes); 6087da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian const UTF8 *FromPtr = (UTF8 *)String.data(); 6097da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian UTF16 *ToPtr = &ToBuf[0]; 6107da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 6117da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 6127da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian &ToPtr, ToPtr + NumBytes, 6137da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian strictConversion); 6147da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian // Check for conversion failure. 6157da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Result != conversionOK) 6167da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian Diag(Arg->getLocStart(), 6177da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian diag::warn_cfstring_truncated) << Arg->getSourceRange(); 6187da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian } 6199cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return false; 62059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner} 62159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 622c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 623c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success. 624925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 625925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *Fn = TheCall->getCallee(); 626925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) { 6272c21a073525cdfa68e4439b7af551385dc2796abChris Lattner Diag(TheCall->getArg(2)->getLocStart(), 628fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 629ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 630ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << Fn->getSourceRange() 6311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(2)->getLocStart(), 632fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 63330ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 63430ce344307f8a8b00054021307015571f83c7364Chris Lattner } 63556f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 63656f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman if (TheCall->getNumArgs() < 2) { 637d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher return Diag(TheCall->getLocEnd(), 638d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 639d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 64056f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman } 64156f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 642c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner // Determine whether the current function is variadic or not. 6439ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor BlockScopeInfo *CurBlock = getCurBlock(); 644c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner bool isVariadic; 645cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 646c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall isVariadic = CurBlock->TheDecl->isVariadic(); 6479498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else if (FunctionDecl *FD = getCurFunctionDecl()) 6489498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek isVariadic = FD->isVariadic(); 6499498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else 65053d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis isVariadic = getCurMethodDecl()->isVariadic(); 6511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 652c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner if (!isVariadic) { 65330ce344307f8a8b00054021307015571f83c7364Chris Lattner Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 65430ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 65530ce344307f8a8b00054021307015571f83c7364Chris Lattner } 6561eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 65730ce344307f8a8b00054021307015571f83c7364Chris Lattner // Verify that the second argument to the builtin is the last argument of the 65830ce344307f8a8b00054021307015571f83c7364Chris Lattner // current function or method. 65930ce344307f8a8b00054021307015571f83c7364Chris Lattner bool SecondArgIsLastNamedArgument = false; 660e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 6611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 66288cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 66388cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 66430ce344307f8a8b00054021307015571f83c7364Chris Lattner // FIXME: This isn't correct for methods (results in bogus warning). 66530ce344307f8a8b00054021307015571f83c7364Chris Lattner // Get the last formal in the current function. 66688cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson const ParmVarDecl *LastArg; 667cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 668cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff LastArg = *(CurBlock->TheDecl->param_end()-1); 669cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff else if (FunctionDecl *FD = getCurFunctionDecl()) 670371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner LastArg = *(FD->param_end()-1); 67130ce344307f8a8b00054021307015571f83c7364Chris Lattner else 67253d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis LastArg = *(getCurMethodDecl()->param_end()-1); 67330ce344307f8a8b00054021307015571f83c7364Chris Lattner SecondArgIsLastNamedArgument = PV == LastArg; 67430ce344307f8a8b00054021307015571f83c7364Chris Lattner } 67530ce344307f8a8b00054021307015571f83c7364Chris Lattner } 6761eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 67730ce344307f8a8b00054021307015571f83c7364Chris Lattner if (!SecondArgIsLastNamedArgument) 6781eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(1)->getLocStart(), 67930ce344307f8a8b00054021307015571f83c7364Chris Lattner diag::warn_second_parameter_of_va_start_not_last_named_argument); 68030ce344307f8a8b00054021307015571f83c7364Chris Lattner return false; 6816cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman} 68230ce344307f8a8b00054021307015571f83c7364Chris Lattner 6831b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 6841b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends. This is declared to take (...), so we have to check everything. 685925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 686925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() < 2) 6872c21a073525cdfa68e4439b7af551385dc2796abChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 688d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << 2 << TheCall->getNumArgs()/*function call*/; 689925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) 6901eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(TheCall->getArg(2)->getLocStart(), 691fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 692ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 693fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(TheCall->getArg(2)->getLocStart(), 694fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 6951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 696925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *OrigArg0 = TheCall->getArg(0); 697925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *OrigArg1 = TheCall->getArg(1); 698cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 6991b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // Do standard promotions between the two arguments, returning their common 7001b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // type. 701925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 702403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar 703403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // Make sure any conversions are pushed back into the call; this is 704403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // type safe since unordered compare builtins are declared as "_Bool 705403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // foo(...)". 706403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar TheCall->setArg(0, OrigArg0); 707403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar TheCall->setArg(1, OrigArg1); 7081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 709cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (OrigArg0->isTypeDependent() || OrigArg1->isTypeDependent()) 710cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 711cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 7121b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // If the common type isn't a real floating type, then the arguments were 7131b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // invalid for this operation. 7141b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner if (!Res->isRealFloatingType()) 7151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg0->getLocStart(), 716fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_invalid_ordered_compare) 717d162584991885ab004a02573a73ce06422b921fcChris Lattner << OrigArg0->getType() << OrigArg1->getType() 718fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(OrigArg0->getLocStart(), OrigArg1->getLocEnd()); 7191eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7201b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner return false; 7211b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner} 7221b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner 723e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 724e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends. This is declared to take (...), so we have 7253b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point 7263b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value. 7273b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 7283b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() < NumArgs) 7299ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 730d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 7313b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() > NumArgs) 7323b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer return Diag(TheCall->getArg(NumArgs)->getLocStart(), 7339ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_too_many_args) 734ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 7353b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 7369ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman (*(TheCall->arg_end()-1))->getLocEnd()); 7379ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 7383b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer Expr *OrigArg = TheCall->getArg(NumArgs-1); 7391eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7409ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (OrigArg->isTypeDependent()) 7419ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 7429ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 74381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // This operation requires a non-_Complex floating-point number. 7449ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (!OrigArg->getType()->isRealFloatingType()) 7451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg->getLocStart(), 7469ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_invalid_unary_fp) 7479ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman << OrigArg->getType() << OrigArg->getSourceRange(); 7481eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 74981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // If this is an implicit conversion from float -> double, remove it. 75081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 75181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Expr *CastArg = Cast->getSubExpr(); 75281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 75381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 75481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner "promotion from float to double is the only expected cast here"); 75581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Cast->setSubExpr(0); 75681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner TheCall->setArg(NumArgs-1, CastArg); 75781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner OrigArg = CastArg; 75881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 75981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 76081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner 7619ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 7629ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman} 7639ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 764d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 765d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything. 76660d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 76737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() < 2) 7680eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocEnd(), 769d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 77037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << 0 /*function call*/ << 2 << TheCall->getNumArgs() 771d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << TheCall->getSourceRange()); 772d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 77337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Determine which of the following types of shufflevector we're checking: 77437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 1) unary, vector mask: (lhs, mask) 77537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 2) binary, vector mask: (lhs, rhs, mask) 77637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 77737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType resType = TheCall->getArg(0)->getType(); 77837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numElements = 0; 77937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 780cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (!TheCall->getArg(0)->isTypeDependent() && 781cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor !TheCall->getArg(1)->isTypeDependent()) { 78237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType LHSType = TheCall->getArg(0)->getType(); 78337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType RHSType = TheCall->getArg(1)->getType(); 78437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 78537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!LHSType->isVectorType() || !RHSType->isVectorType()) { 786cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) 7871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 788cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 789cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 790cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 79137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 79237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numElements = LHSType->getAs<VectorType>()->getNumElements(); 79337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numResElements = TheCall->getNumArgs() - 2; 79437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 79537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Check to see if we have a call with 2 vector arguments, the unary shuffle 79637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // with mask. If so, verify that RHS is an integer vector type with the 79737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // same number of elts as lhs. 79837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() == 2) { 799f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (!RHSType->hasIntegerRepresentation() || 80037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman RHSType->getAs<VectorType>()->getNumElements() != numElements) 80137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 80237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << SourceRange(TheCall->getArg(1)->getLocStart(), 80337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman TheCall->getArg(1)->getLocEnd()); 80437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numResElements = numElements; 80537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } 80637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 807cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 8081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 809cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 810cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 81137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } else if (numElements != numResElements) { 81237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 813788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner resType = Context.getVectorType(eltType, numResElements, 814e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson VectorType::GenericVector); 815cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 816d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 817d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 818d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 819cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 820cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(i)->isValueDependent()) 821cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor continue; 822cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 82337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman llvm::APSInt Result(32); 82437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 82537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman return ExprError(Diag(TheCall->getLocStart(), 82637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman diag::err_shufflevector_nonconstant_argument) 82737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << TheCall->getArg(i)->getSourceRange()); 8280eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 829d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 8300eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocStart(), 831fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_shufflevector_argument_too_large) 8320eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl << TheCall->getArg(i)->getSourceRange()); 833d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 834d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 835d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman llvm::SmallVector<Expr*, 32> exprs; 836d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 837d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 838d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman exprs.push_back(TheCall->getArg(i)); 839d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman TheCall->setArg(i, 0); 840d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 841d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 842a88dc3079bedf70a5cfc39791727e43a10383006Nate Begeman return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(), 84337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman exprs.size(), resType, 8448189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getCallee()->getLocStart(), 8458189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getRParenLoc())); 846d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman} 84730ce344307f8a8b00054021307015571f83c7364Chris Lattner 8484493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 8494493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two 8504493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args. 8514493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 852fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner unsigned NumArgs = TheCall->getNumArgs(); 8534493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 854fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (NumArgs > 3) 855ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher return Diag(TheCall->getLocEnd(), 856ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher diag::err_typecheck_call_too_many_args_at_most) 857ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 3 << NumArgs 858ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << TheCall->getSourceRange(); 8594493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 8604493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // Argument 0 is checked for us and the remaining arguments must be 8614493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // constant integers. 862fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner for (unsigned i = 1; i != NumArgs; ++i) { 8634493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar Expr *Arg = TheCall->getArg(i); 864691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 8659aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman llvm::APSInt Result; 866691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, i, Result)) 867691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 8681eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8694493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // FIXME: gcc issues a warning and rewrites these to 0. These 8704493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // seems especially odd for the third argument since the default 8714493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // is 3. 872fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (i == 1) { 8739aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 1) 874fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 87521fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "1" << Arg->getSourceRange(); 8764493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } else { 8779aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 3) 878fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 87921fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "3" << Arg->getSourceRange(); 8804493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 8814493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 8824493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 883fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return false; 8844493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar} 8854493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 886691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 887691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression. 888691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 889691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt &Result) { 890691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(ArgNum); 891691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 892691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 893691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 894691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 895691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 896691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (!Arg->isIntegerConstantExpr(Result, Context)) 897691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 8985e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher << FDecl->getDeclName() << Arg->getSourceRange(); 899691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 90021fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner return false; 90121fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner} 90221fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner 903d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 904d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined 905d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3). 906fee667f35e64751baa7fefe70b4e7bab06c8cd86Eric Christopher// For compatability check 0-3, llvm only handles 0 and 2. 907d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 908691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 909691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 910691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // Check constant-ness first. 911691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 912691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 913d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 914691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(1); 915d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 916fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 917fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 918d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar } 919d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 920d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar return false; 921d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar} 922d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 923586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 924d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1. 925d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 926d875fed28578835de89cd407e9db4be788596d7cEli Friedman Expr *Arg = TheCall->getArg(1); 927691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 928cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 929691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // TODO: This is less than ideal. Overload this to take a value. 930691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 931691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 932691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 933691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Result != 1) 934d875fed28578835de89cd407e9db4be788596d7cEli Friedman return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 935d875fed28578835de89cd407e9db4be788596d7cEli Friedman << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 936d875fed28578835de89cd407e9db4be788596d7cEli Friedman 937d875fed28578835de89cd407e9db4be788596d7cEli Friedman return false; 938d875fed28578835de89cd407e9db4be788596d7cEli Friedman} 939d875fed28578835de89cd407e9db4be788596d7cEli Friedman 940d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek// Handle i > 1 ? "x" : "y", recursivelly 941082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenekbool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall, 942082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool HasVAListArg, 943826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 944826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 9454fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain: 946cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 947cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 948d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 949d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek switch (E->getStmtClass()) { 950d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ConditionalOperatorClass: { 951082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const ConditionalOperator *C = cast<ConditionalOperator>(E); 952826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return SemaCheckStringLiteral(C->getTrueExpr(), TheCall, HasVAListArg, 953826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf) 954826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek && SemaCheckStringLiteral(C->getRHS(), TheCall, HasVAListArg, 955826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf); 956d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 957d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 95895355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek case Stmt::IntegerLiteralClass: 95995355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // Technically -Wformat-nonliteral does not warn about this case. 96095355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // The behavior of printf and friends in this case is implementation 96195355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // dependent. Ideally if the format string cannot be null then 96295355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // it should have a 'nonnull' attribute in the function prototype. 96395355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek return true; 96495355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek 965d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ImplicitCastExprClass: { 9664fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ImplicitCastExpr>(E)->getSubExpr(); 9674fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 968d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 969d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 970d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ParenExprClass: { 9714fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ParenExpr>(E)->getSubExpr(); 9724fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 973d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 9741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 975082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::DeclRefExprClass: { 976082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const DeclRefExpr *DR = cast<DeclRefExpr>(E); 9771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 978082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // As an exception, do not flag errors for variables binding to 979082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // const string literals. 980082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 981082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool isConstant = false; 982082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek QualType T = DR->getType(); 983082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek 984082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ArrayType *AT = Context.getAsArrayType(T)) { 985082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek isConstant = AT->getElementType().isConstant(Context); 986ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (const PointerType *PT = T->getAs<PointerType>()) { 9871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump isConstant = T.isConstant(Context) && 988082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek PT->getPointeeType().isConstant(Context); 989082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 9901eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 991082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (isConstant) { 99231310a21fb2a9f13950f864f681c86080b05d5b2Sebastian Redl if (const Expr *Init = VD->getAnyInitializer()) 993082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return SemaCheckStringLiteral(Init, TheCall, 994826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, format_idx, firstDataArg, 995826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isPrintf); 996082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 9971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 998d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // For vprintf* functions (i.e., HasVAListArg==true), we add a 999d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // special check to see if the format string is a function parameter 1000d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // of the function calling the printf function. If the function 1001d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // has an attribute indicating it is a printf-like function, then we 1002d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // should suppress warnings concerning non-literals being used in a call 1003d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // to a vprintf function. For example: 1004d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1005d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // void 1006d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 1007d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_list ap; 1008d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_start(ap, fmt); 1009d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 1010d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // ... 1011d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1012d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1013d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // FIXME: We don't have full attribute support yet, so just check to see 1014d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // if the argument is a DeclRefExpr that references a parameter. We'll 1015d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // add proper support for checking the attribute later. 1016d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (HasVAListArg) 1017d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (isa<ParmVarDecl>(VD)) 1018d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson return true; 1019082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 10201eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1021082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1022082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 1023d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 10248f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson case Stmt::CallExprClass: { 10258f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const CallExpr *CE = cast<CallExpr>(E); 10261eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump if (const ImplicitCastExpr *ICE 10278f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson = dyn_cast<ImplicitCastExpr>(CE->getCallee())) { 10288f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) { 10298f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) { 103040b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) { 10318f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson unsigned ArgIndex = FA->getFormatIdx(); 10328f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const Expr *Arg = CE->getArg(ArgIndex - 1); 10331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10341eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg, 1035826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf); 10368f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 10378f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 10388f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 10398f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 10401eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10418f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson return false; 10428f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 1043082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::ObjCStringLiteralClass: 1044082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::StringLiteralClass: { 1045082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const StringLiteral *StrE = NULL; 10461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1047082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 1048d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek StrE = ObjCFExpr->getString(); 1049d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek else 1050082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek StrE = cast<StringLiteral>(E); 10511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1052d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek if (StrE) { 1053826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatString(StrE, E, TheCall, HasVAListArg, format_idx, 1054826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek firstDataArg, isPrintf); 1055d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return true; 1056d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 10571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1058d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return false; 1059d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 10601eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1061082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek default: 1062082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1063d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1064d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1065d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1066e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid 10671eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull, 10681eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump const CallExpr *TheCall) { 1069cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt for (NonNullAttr::args_iterator i = NonNull->args_begin(), 1070cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt e = NonNull->args_end(); 1071e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian i != e; ++i) { 107212b97ff9ce1412e388444f03049bfa6ad1bb5eb9Chris Lattner const Expr *ArgExpr = TheCall->getArg(*i); 10734e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (ArgExpr->isNullPointerConstant(Context, 1074ce94049b69f75b44c18584fe79cd238978b6b0d5Douglas Gregor Expr::NPC_ValueDependentIsNotNull)) 107512b97ff9ce1412e388444f03049bfa6ad1bb5eb9Chris Lattner Diag(TheCall->getCallee()->getLocStart(), diag::warn_null_arg) 107612b97ff9ce1412e388444f03049bfa6ad1bb5eb9Chris Lattner << ArgExpr->getSourceRange(); 1077e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian } 1078e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian} 1079d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1080826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar 1081826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings. 108259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnervoid 1083826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSema::CheckPrintfScanfArguments(const CallExpr *TheCall, bool HasVAListArg, 1084826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1085826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 1086826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1087082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *Fn = TheCall->getCallee(); 1088925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner 10894a2614e94672c47395abcde60518776fbebec589Sebastian Redl // The way the format attribute works in GCC, the implicit this argument 10904a2614e94672c47395abcde60518776fbebec589Sebastian Redl // of member functions is counted. However, it doesn't appear in our own 10914a2614e94672c47395abcde60518776fbebec589Sebastian Redl // lists, so decrement format_idx in that case. 10924a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 10934a2614e94672c47395abcde60518776fbebec589Sebastian Redl // Catch a format attribute mistakenly referring to the object argument. 10944a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (format_idx == 0) 10954a2614e94672c47395abcde60518776fbebec589Sebastian Redl return; 10964a2614e94672c47395abcde60518776fbebec589Sebastian Redl --format_idx; 10974a2614e94672c47395abcde60518776fbebec589Sebastian Redl if(firstDataArg != 0) 10984a2614e94672c47395abcde60518776fbebec589Sebastian Redl --firstDataArg; 10994a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 11004a2614e94672c47395abcde60518776fbebec589Sebastian Redl 1101826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // CHECK: printf/scanf-like function is called with no format string. 1102925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (format_idx >= TheCall->getNumArgs()) { 1103826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Diag(TheCall->getRParenLoc(), diag::warn_missing_format_string) 1104dcd5ef12488e4c7ea844327835896ca86b609a97Chris Lattner << Fn->getSourceRange(); 110571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek return; 110671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek } 11071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1108082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts(); 11091eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 111059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner // CHECK: format string is not a string literal. 11111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // 111271895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // Dynamically generated format strings are difficult to 111371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // automatically vet at compile time. Requiring that format strings 111471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // are string literals: (1) permits the checking of format strings by 111571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // the compiler and thereby (2) can practically remove the source of 111671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // many format string exploits. 11177ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek 11181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // Format string can be either ObjC string (e.g. @"%d") or 11197ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // C string (e.g. "%d") 11201eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // ObjC string uses the same format specifiers as C string, so we can use 11217ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // the same format string checking logic for both ObjC and C strings. 11221cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx, 1123826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek firstDataArg, isPrintf)) 11241cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner return; // Literal format string found, check done! 11251cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner 1126655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // If there are no arguments specified, warn with -Wformat-security, otherwise 1127655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // warn only with -Wformat-nonliteral. 1128655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner if (TheCall->getNumArgs() == format_idx+1) 11291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1130826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral_noargs) 1131655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1132655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner else 11331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1134826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral) 1135655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1136d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1137d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1138e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace { 1139826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler { 1140826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1141e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Sema &S; 1142e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const StringLiteral *FExpr; 1143e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const Expr *OrigFormatExpr; 11446ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const unsigned FirstDataArg; 1145e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const unsigned NumDataArgs; 1146e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const bool IsObjCLiteral; 1147e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *Beg; // Start of format string. 11480d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const bool HasVAListArg; 11490d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const CallExpr *TheCall; 11500d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek unsigned FormatIdx; 11517f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek llvm::BitVector CoveredArgs; 1152efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool usesPositionalArgs; 1153efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool atFirstArg; 11544e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic: 1155826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 11566ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1157e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 11580d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const char *beg, bool hasVAListArg, 11590d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1160e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 11616ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek FirstDataArg(firstDataArg), 11627f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek NumDataArgs(numDataArgs), 11630d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek IsObjCLiteral(isObjCLiteral), Beg(beg), 11640d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek HasVAListArg(hasVAListArg), 1165efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek TheCall(theCall), FormatIdx(formatIdx), 1166efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek usesPositionalArgs(false), atFirstArg(true) { 11677f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.resize(numDataArgs); 11687f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.reset(); 11697f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 11704e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 117107d161f38e708a91486bf1c031d525faebbb249dTed Kremenek void DoneProcessing(); 11724e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1173826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIncompleteSpecifier(const char *startSpecifier, 1174826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1175826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1176efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleInvalidPosition(const char *startSpecifier, 1177efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned specifierLen, 1178826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p); 1179efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1180efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 1181efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1182e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek void HandleNullChar(const char *nullCharacter); 11834e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1184826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1185c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 1186c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1187c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1188c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, unsigned csLen); 1189c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1190f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek SourceRange getFormatStringRange(); 1191826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CharSourceRange getSpecifierRange(const char *startSpecifier, 1192826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1193e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek SourceLocation getLocationOfByte(const char *x); 11944e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 11950d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const Expr *getDataArg(unsigned i) const; 1196666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1197666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 1198666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1199666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, 1200666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek unsigned argIndex); 1201e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}; 1202e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1203e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1204826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() { 1205e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return OrigFormatExpr->getSourceRange(); 1206e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1207e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1208826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler:: 1209826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 121045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation Start = getLocationOfByte(startSpecifier); 121145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 121245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 121345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care // Advance the end SourceLocation by one due to half-open ranges. 121445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care End = End.getFileLocWithOffset(1); 121545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 121645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care return CharSourceRange::getCharRange(Start, End); 1217f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek} 1218f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek 1219826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 12204e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 1221e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1222e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1223826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 1224826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen){ 1225808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek SourceLocation Loc = getLocationOfByte(startSpecifier); 1226808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek S.Diag(Loc, diag::warn_printf_incomplete_specifier) 1227826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1228808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek} 1229808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek 1230efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid 1231826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 1232826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p) { 1233efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek SourceLocation Loc = getLocationOfByte(startPos); 1234826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(Loc, diag::warn_format_invalid_positional_specifier) 1235826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << (unsigned) p << getSpecifierRange(startPos, posLen); 1236efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1237efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1238826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos, 1239efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned posLen) { 1240efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek SourceLocation Loc = getLocationOfByte(startPos); 1241826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(Loc, diag::warn_format_zero_positional_specifier) 1242826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startPos, posLen); 1243efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1244efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1245826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 1246826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The presence of a null character is likely an error. 1247826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getLocationOfByte(nullCharacter), 1248826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_printf_format_string_contains_null_char) 1249826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getFormatStringRange(); 1250826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1251826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1252826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const { 1253826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return TheCall->getArg(FirstDataArg + i); 1254826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 12554e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1256826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() { 1257826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Does the number of data arguments exceed the number of 1258826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // format conversions in the format string? 1259826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!HasVAListArg) { 1260826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Find any arguments that weren't covered. 1261826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.flip(); 1262826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek signed notCoveredArg = CoveredArgs.find_first(); 1263826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (notCoveredArg >= 0) { 1264826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek assert((unsigned)notCoveredArg < NumDataArgs); 1265826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(), 1266826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_printf_data_arg_not_used) 1267826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getFormatStringRange(); 1268826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1269826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1270826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1271826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1272c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool 1273c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 1274c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek SourceLocation Loc, 1275c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1276c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1277c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, 1278c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned csLen) { 1279c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1280c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool keepGoing = true; 1281c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek if (argIndex < NumDataArgs) { 1282c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // Consider the argument coverered, even though the specifier doesn't 1283c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // make sense. 1284c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CoveredArgs.set(argIndex); 1285c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1286c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek else { 1287c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // If argIndex exceeds the number of data arguments we 1288c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // don't issue a warning because that is just a cascade of warnings (and 1289c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // they may have intended '%%' anyway). We don't want to continue processing 1290c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // the format string after this point, however, as we will like just get 1291c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // gibberish when trying to match arguments. 1292c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek keepGoing = false; 1293c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1294c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1295c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek S.Diag(Loc, diag::warn_format_invalid_conversion) 1296c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek << llvm::StringRef(csStart, csLen) 1297c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek << getSpecifierRange(startSpec, specifierLen); 1298c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1299c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return keepGoing; 1300c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1301c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1302666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool 1303666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs( 1304666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::FormatSpecifier &FS, 1305666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1306666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 1307666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1308666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (argIndex >= NumDataArgs) { 1309666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (FS.usesPositionalArg()) { 1310666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1311666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek diag::warn_printf_positional_arg_exceeds_data_args) 1312666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << (argIndex+1) << NumDataArgs 1313666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1314666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1315666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek else { 1316666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1317666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek diag::warn_printf_insufficient_data_args) 1318666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1319666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1320666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1321666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return false; 1322666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1323666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return true; 1324666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek} 1325666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1326826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===// 1327826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1328826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 1329826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler { 1330826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 1331826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 1332826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1333826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 1334826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 1335826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1336826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1337826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 1338826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek theCall, formatIdx) {} 1339826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1340826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1341826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleInvalidPrintfConversionSpecifier( 1342826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1343826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1344826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1345826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1346826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 1347826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1348826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1349826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1350826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 1351826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1352826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 1353826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalAmount &Amt, 1354826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned type, 1355826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1356826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1357826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1358826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1359826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 1360826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &ignoredFlag, 1361826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1362826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1363826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 1364826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1365826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1366826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 1367826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1368826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1369826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 13706ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 1371c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 1372826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1373c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1374c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 1375c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 1376c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 137726ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek} 137826ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek 1379826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount( 1380826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_format_string::OptionalAmount &Amt, 1381826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned k, const char *startSpecifier, 1382826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 13830d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 13840d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (Amt.hasDataArgument()) { 13850d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (!HasVAListArg) { 13867f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = Amt.getArgIndex(); 13877f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (argIndex >= NumDataArgs) { 1388efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1389efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek diag::warn_printf_asterisk_missing_arg) 1390826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << k << getSpecifierRange(startSpecifier, specifierLen); 13910d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 13920d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 13930d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 13940d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 13954e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 13960d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Type check the data argument. It should be an 'int'. 139731f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // Although not in conformance with C99, we also allow the argument to be 139831f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // an 'unsigned int' as that is a reasonably safe case. GCC also 139931f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // doesn't emit a warning for that case. 14007f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.set(argIndex); 14017f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek const Expr *Arg = getDataArg(argIndex); 14020d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek QualType T = Arg->getType(); 14034e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 14044e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context); 14054e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek assert(ATR.isValid()); 14064e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 14074e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (!ATR.matchesType(S.Context, T)) { 1408efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1409efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek diag::warn_printf_asterisk_wrong_type) 1410efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek << k 14114e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek << ATR.getRepresentativeType(S.Context) << T 1412826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1413d635c5fcc45c952b75743dd2f4c86d6950e4954eTed Kremenek << Arg->getSourceRange(); 14140d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 14150d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 14160d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 14170d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 14180d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 14190d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 14200d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return true; 14210d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek} 14220d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1423e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount( 1424826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1425e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalAmount &Amt, 1426e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned type, 1427e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1428e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 14296ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 14306ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1431e4ee9663168dfb2b4122c768091e30217328c9faTom Care switch (Amt.getHowSpecified()) { 1432e4ee9663168dfb2b4122c768091e30217328c9faTom Care case analyze_printf::OptionalAmount::Constant: 1433e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(Amt.getStart()), 1434e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_optional_amount) 1435e4ee9663168dfb2b4122c768091e30217328c9faTom Care << type 1436e4ee9663168dfb2b4122c768091e30217328c9faTom Care << CS.toString() 1437826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1438826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 1439e4ee9663168dfb2b4122c768091e30217328c9faTom Care Amt.getConstantLength())); 1440e4ee9663168dfb2b4122c768091e30217328c9faTom Care break; 1441e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1442e4ee9663168dfb2b4122c768091e30217328c9faTom Care default: 1443e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(Amt.getStart()), 1444e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_optional_amount) 1445e4ee9663168dfb2b4122c768091e30217328c9faTom Care << type 1446e4ee9663168dfb2b4122c768091e30217328c9faTom Care << CS.toString() 1447826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1448e4ee9663168dfb2b4122c768091e30217328c9faTom Care break; 1449e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1450e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1451e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1452826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1453e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 1454e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1455e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 1456e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about pointless flag with a fixit removal. 14576ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 14586ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1459e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(flag.getPosition()), 1460e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_flag) 1461e4ee9663168dfb2b4122c768091e30217328c9faTom Care << flag.toString() << CS.toString() 1462826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1463826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(flag.getPosition(), 1)); 1464e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1465e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1466e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag( 1467826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1468e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &ignoredFlag, 1469e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 1470e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1471e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 1472e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about ignored flag with a fixit removal. 1473e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(ignoredFlag.getPosition()), 1474e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_ignored_flag) 1475e4ee9663168dfb2b4122c768091e30217328c9faTom Care << ignoredFlag.toString() << flag.toString() 1476826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1477826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange( 1478e4ee9663168dfb2b4122c768091e30217328c9faTom Care ignoredFlag.getPosition(), 1)); 1479e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1480e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1481e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool 1482826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 14835c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek &FS, 1484e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *startSpecifier, 1485e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned specifierLen) { 1486e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 14876ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek using namespace analyze_format_string; 1488efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek using namespace analyze_printf; 14896ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 1490e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1491baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 1492baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 1493baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 1494baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 1495baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1496baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 1497baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Cannot mix-and-match positional and non-positional arguments. 1498baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1499baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek diag::warn_format_mix_positional_nonpositional_args) 1500baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1501baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 1502baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1503efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek } 1504efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 15050d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // First check if the field width, precision, and conversion specifier 15060d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // have matching data arguments. 1507efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 1508efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 15090d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 15100d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 15114e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1512efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 1513efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 15140d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 15150d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 15160d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1517f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek if (!CS.consumesDataArgument()) { 1518f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // FIXME: Technically specifying a precision or field width here 1519f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // makes no sense. Worth issuing a warning at some point. 15200e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek return true; 1521f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek } 15224e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 15237f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Consume the argument. 15247f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = FS.getArgIndex(); 1525e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek if (argIndex < NumDataArgs) { 1526e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // The check to see if the argIndex is valid will come later. 1527e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // We set the bit here because we may exit early from this 1528e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // function if we encounter some other error. 1529e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek CoveredArgs.set(argIndex); 1530e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek } 15317f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek 15327f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Check for using an Objective-C specific conversion specifier 15337f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // in a non-ObjC literal. 15347f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (!IsObjCLiteral && CS.isObjCArg()) { 1535826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 1536826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek specifierLen); 15377f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 15384e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1539e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of field width 1540e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidFieldWidth()) { 154145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 1542e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1543e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1544e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1545e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of precision 1546e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPrecision()) { 1547e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 1548e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1549e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1550e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1551e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check each flag does not conflict with any other component. 1552e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeadingZeros()) 1553e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 1554e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPlusPrefix()) 1555e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 155645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (!FS.hasValidSpacePrefix()) 155745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 1558e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidAlternativeForm()) 1559e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 1560e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeftJustified()) 1561e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 1562e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1563e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check that flags are not ignored by another flag 156445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 156545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 156645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care startSpecifier, specifierLen); 1567e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 1568e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 1569e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1570e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1571e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check the length modifier is valid with the given conversion specifier. 1572e4ee9663168dfb2b4122c768091e30217328c9faTom Care const LengthModifier &LM = FS.getLengthModifier(); 1573e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLengthModifier()) 1574e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(LM.getStart()), 1575649aecf55670682efb2a04a85810eef4d038c527Ted Kremenek diag::warn_format_nonsensical_length) 1576e4ee9663168dfb2b4122c768091e30217328c9faTom Care << LM.toString() << CS.toString() 1577826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1578826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 1579e4ee9663168dfb2b4122c768091e30217328c9faTom Care LM.getLength())); 1580e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1581e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Are we using '%n'? 158235d353b47bce29200b910371dd9b8ba7f3058ab8Ted Kremenek if (CS.getKind() == ConversionSpecifier::nArg) { 1583e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Issue a warning about this being a possible security issue. 1584e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back) 1585826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1586e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek // Continue checking the other format specifiers. 1587e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek return true; 1588e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek } 15895c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek 1590da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek // The remaining checks depend on the data arguments. 1591da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek if (HasVAListArg) 1592da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return true; 15934e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1594666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 1595da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return false; 15964e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 159796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Now type check the data expression that matches the 159896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // format specifier. 159996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const Expr *Ex = getDataArg(argIndex); 160096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context); 160196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) { 160296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Check if we didn't match because of an implicit cast from a 'char' 160396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // or 'short' to an 'int'. This is done because printf is a varargs 160496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // function. 160596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex)) 16064d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ICE->getType() == S.Context.IntTy) { 16074d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek // All further checking is done on the subexpression. 16084d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek Ex = ICE->getSubExpr(); 16094d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ATR.matchesType(S.Context, Ex->getType())) 161096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer return true; 16114d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek } 161296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 161396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // We may be able to offer a FixItHint if it is a supported type. 161496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer PrintfSpecifier fixedFS = FS; 161596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer bool success = fixedFS.fixType(Ex->getType()); 161696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 161796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (success) { 161896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Get the fix string from the fixed format specifier 161996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::SmallString<128> buf; 162096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::raw_svector_ostream os(buf); 162196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer fixedFS.toString(os); 162296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 16239325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // FIXME: getRepresentativeType() perhaps should return a string 16249325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // instead of a QualType to better handle when the representative 16259325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // type is 'wint_t' (which is defined in the system headers). 162696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer S.Diag(getLocationOfByte(CS.getStart()), 162796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer diag::warn_printf_conversion_argument_type_mismatch) 162896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << ATR.getRepresentativeType(S.Context) << Ex->getType() 162996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << getSpecifierRange(startSpecifier, specifierLen) 163096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << Ex->getSourceRange() 163196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << FixItHint::CreateReplacement( 163296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer getSpecifierRange(startSpecifier, specifierLen), 163396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer os.str()); 163496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 163596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer else { 163696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer S.Diag(getLocationOfByte(CS.getStart()), 163796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer diag::warn_printf_conversion_argument_type_mismatch) 163896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << ATR.getRepresentativeType(S.Context) << Ex->getType() 163996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << getSpecifierRange(startSpecifier, specifierLen) 164096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << Ex->getSourceRange(); 164196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 164296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 164396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 1644e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return true; 1645e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1646e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1647826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===// 1648826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1649826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 1650826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler { 1651826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 1652826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 1653826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1654826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 1655826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 1656826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1657826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1658826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 1659826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek theCall, formatIdx) {} 1660826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1661826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 1662826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1663826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1664c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1665c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidScanfConversionSpecifier( 1666c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1667c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 1668c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen); 1669b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 1670b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek void HandleIncompleteScanList(const char *start, const char *end); 1671826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 1672826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1673826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1674b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start, 1675b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek const char *end) { 1676b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek S.Diag(getLocationOfByte(end), diag::warn_scanf_scanlist_incomplete) 1677b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek << getSpecifierRange(start, end - start); 1678b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek} 1679b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 1680c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 1681c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1682c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 1683c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen) { 1684c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 16856ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_scanf::ScanfConversionSpecifier &CS = 1686c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 1687c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1688c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1689c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 1690c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 1691c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 1692c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1693c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1694826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier( 1695826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1696826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1697826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 1698826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1699826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_scanf; 1700826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_format_string; 1701826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 17026ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 1703826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1704baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Handle case where '%' and '*' don't consume an argument. These shouldn't 1705baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // be used to decide if we are using positional arguments consistently. 1706baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 1707baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 1708baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 1709baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 1710baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1711baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 1712baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Cannot mix-and-match positional and non-positional arguments. 1713baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1714baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek diag::warn_format_mix_positional_nonpositional_args) 1715baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1716baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 1717baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1718826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1719826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1720826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Check if the field with is non-zero. 1721826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const OptionalAmount &Amt = FS.getFieldWidth(); 1722826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getHowSpecified() == OptionalAmount::Constant) { 1723826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getConstantAmount() == 0) { 1724826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 1725826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Amt.getConstantLength()); 1726826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1727826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_scanf_nonzero_width) 1728826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << R << FixItHint::CreateRemoval(R); 17297f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 17307f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 1731826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1732826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!FS.consumesDataArgument()) { 1733826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Technically specifying a precision or field width here 1734826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // makes no sense. Worth issuing a warning at some point. 1735826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 1736826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1737826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1738826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Consume the argument. 1739826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned argIndex = FS.getArgIndex(); 1740826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (argIndex < NumDataArgs) { 1741826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The check to see if the argIndex is valid will come later. 1742826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // We set the bit here because we may exit early from this 1743826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // function if we encounter some other error. 1744826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.set(argIndex); 1745826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1746826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 17471e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek // Check the length modifier is valid with the given conversion specifier. 17481e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek const LengthModifier &LM = FS.getLengthModifier(); 17491e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek if (!FS.hasValidLengthModifier()) { 17501e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek S.Diag(getLocationOfByte(LM.getStart()), 17511e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek diag::warn_format_nonsensical_length) 17521e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << LM.toString() << CS.toString() 17531e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 17541e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 17551e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek LM.getLength())); 17561e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek } 17571e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek 1758826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The remaining checks depend on the data arguments. 1759826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (HasVAListArg) 1760826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 1761826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1762666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 1763826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return false; 1764826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1765826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Check that the argument type matches the format specifier. 1766826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1767826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 176807d161f38e708a91486bf1c031d525faebbb249dTed Kremenek} 1769e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1770826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr, 17710e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const Expr *OrigFormatExpr, 17720e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const CallExpr *TheCall, bool HasVAListArg, 1773826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1774826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 1775826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1776e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: is the format string a wide literal? 1777e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek if (FExpr->isWide()) { 1778e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Diag(FExpr->getLocStart(), 1779826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_string_is_wide_literal) 1780e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek << OrigFormatExpr->getSourceRange(); 1781e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 1782e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 1783826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1784e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // Str - The format string. NOTE: this is NOT null-terminated! 17852f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer llvm::StringRef StrRef = FExpr->getString(); 17862f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer const char *Str = StrRef.data(); 17872f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer unsigned StrLen = StrRef.size(); 1788826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1789e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: empty format string? 1790e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek if (StrLen == 0) { 1791826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Diag(FExpr->getLocStart(), diag::warn_empty_format_string) 1792e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek << OrigFormatExpr->getSourceRange(); 1793e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 1794e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 1795826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1796826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (isPrintf) { 1797826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 1798826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek TheCall->getNumArgs() - firstDataArg, 1799826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isa<ObjCStringLiteral>(OrigFormatExpr), Str, 1800826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, TheCall, format_idx); 1801826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1802826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen)) 1803826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 1804826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1805826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek else { 1806826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 1807826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek TheCall->getNumArgs() - firstDataArg, 1808826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isa<ObjCStringLiteral>(OrigFormatExpr), Str, 1809826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, TheCall, format_idx); 1810826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1811826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen)) 1812826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 1813826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1814ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek} 1815ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek 181606de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===// 181706de276fff91264437fa75111ed76de43097e089Ted Kremenek 181806de276fff91264437fa75111ed76de43097e089Ted Kremenekstatic DeclRefExpr* EvalVal(Expr *E); 181906de276fff91264437fa75111ed76de43097e089Ted Kremenekstatic DeclRefExpr* EvalAddr(Expr* E); 182006de276fff91264437fa75111ed76de43097e089Ted Kremenek 182106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address 182206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable. 182306de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid 182406de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 182506de276fff91264437fa75111ed76de43097e089Ted Kremenek SourceLocation ReturnLoc) { 18261eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 182706de276fff91264437fa75111ed76de43097e089Ted Kremenek // Perform checking for returned stack addresses. 1828dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (lhsType->isPointerType() || lhsType->isBlockPointerType()) { 182906de276fff91264437fa75111ed76de43097e089Ted Kremenek if (DeclRefExpr *DR = EvalAddr(RetValExp)) 18303c73c41cefcfe76f36b7bed72c9f1ec195490951Chris Lattner Diag(DR->getLocStart(), diag::warn_ret_stack_addr) 183108631c5fa053867146b5ee8be658c229f6bf127cChris Lattner << DR->getDecl()->getDeclName() << RetValExp->getSourceRange(); 18321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1833c50a4a5f2eac14ac4c631d50b0a55cadc87700ceSteve Naroff // Skip over implicit cast expressions when checking for block expressions. 18344ca606e898293ae58f1793f988500e2218c7a9beChris Lattner RetValExp = RetValExp->IgnoreParenCasts(); 1835c50a4a5f2eac14ac4c631d50b0a55cadc87700ceSteve Naroff 18369e6b37a9f1d499e7ca0950edacd0b6569e491d7fChris Lattner if (BlockExpr *C = dyn_cast<BlockExpr>(RetValExp)) 1837397195bf3077fb42789b326f69f7d417227a0588Mike Stump if (C->hasBlockDeclRefExprs()) 1838397195bf3077fb42789b326f69f7d417227a0588Mike Stump Diag(C->getLocStart(), diag::err_ret_local_block) 1839397195bf3077fb42789b326f69f7d417227a0588Mike Stump << C->getSourceRange(); 18404e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 18419e6b37a9f1d499e7ca0950edacd0b6569e491d7fChris Lattner if (AddrLabelExpr *ALE = dyn_cast<AddrLabelExpr>(RetValExp)) 18429e6b37a9f1d499e7ca0950edacd0b6569e491d7fChris Lattner Diag(ALE->getLocStart(), diag::warn_ret_addr_label) 18439e6b37a9f1d499e7ca0950edacd0b6569e491d7fChris Lattner << ALE->getSourceRange(); 18444e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1845ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (lhsType->isReferenceType()) { 1846ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump // Perform checking for stack values returned by reference. 184749badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // Check for a reference to the stack 184849badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor if (DeclRefExpr *DR = EvalVal(RetValExp)) 1849dcd5ef12488e4c7ea844327835896ca86b609a97Chris Lattner Diag(DR->getLocStart(), diag::warn_ret_stack_ref) 185008631c5fa053867146b5ee8be658c229f6bf127cChris Lattner << DR->getDecl()->getDeclName() << RetValExp->getSourceRange(); 185106de276fff91264437fa75111ed76de43097e089Ted Kremenek } 185206de276fff91264437fa75111ed76de43097e089Ted Kremenek} 185306de276fff91264437fa75111ed76de43097e089Ted Kremenek 185406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 185506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// check if the expression in a return statement evaluates to an address 185606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// to a location on the stack. The recursion is used to traverse the 185706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// AST of the return expression, with recursion backtracking when we 185806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// encounter a subexpression that (1) clearly does not lead to the address 185906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable or (2) is something we cannot determine leads to 186006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// the address of a stack variable based on such local checking. 186106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 1862e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// EvalAddr processes expressions that are pointers that are used as 1863e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// references (and not L-values). EvalVal handles all other values. 18641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump/// At the base case of the recursion is a check for a DeclRefExpr* in 186506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// the refers to a stack variable. 186606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 186706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// This implementation handles: 186806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 186906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer-to-pointer casts 187006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * implicit conversions from array references to pointers 187106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of fields 187206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * arbitrary interplay between "&" and "*" operators 187306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer arithmetic from an address of a stack variable 187406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of an array element where the array is on the stack 187506de276fff91264437fa75111ed76de43097e089Ted Kremenekstatic DeclRefExpr* EvalAddr(Expr *E) { 187606de276fff91264437fa75111ed76de43097e089Ted Kremenek // We should only be called for evaluating pointer expressions. 18770f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall assert((E->getType()->isAnyPointerType() || 1878dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff E->getType()->isBlockPointerType() || 1879a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek E->getType()->isObjCQualifiedIdType()) && 1880fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner "EvalAddr only works on pointers"); 18811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 188206de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 188306de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 188406de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 188506de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 1886fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ParenExprClass: 1887fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Ignore parentheses. 1888fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return EvalAddr(cast<ParenExpr>(E)->getSubExpr()); 188906de276fff91264437fa75111ed76de43097e089Ted Kremenek 1890fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::UnaryOperatorClass: { 1891fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // The only unary operator that make sense to handle here 1892fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // is AddrOf. All others don't make sense as pointers. 1893fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner UnaryOperator *U = cast<UnaryOperator>(E); 18941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 18952de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_AddrOf) 1896fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return EvalVal(U->getSubExpr()); 1897fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 1898fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 1899fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 19001eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1901fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::BinaryOperatorClass: { 1902fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle pointer arithmetic. All other binary operators are not valid 1903fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // in this context. 1904fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner BinaryOperator *B = cast<BinaryOperator>(E); 19052de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = B->getOpcode(); 19061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 19072de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op != BO_Add && op != BO_Sub) 1908fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 19091eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1910fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner Expr *Base = B->getLHS(); 19113907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 1912fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Determine which argument is the real pointer base. It could be 1913fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // the RHS argument instead of the LHS. 1914fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner if (!Base->getType()->isPointerType()) Base = B->getRHS(); 19151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1916fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner assert (Base->getType()->isPointerType()); 1917fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return EvalAddr(Base); 1918fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 191961f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff 1920fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // For conditional operators we need to see if either the LHS or RHS are 1921fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // valid DeclRefExpr*s. If one of them is valid, we return it. 1922fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ConditionalOperatorClass: { 1923fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner ConditionalOperator *C = cast<ConditionalOperator>(E); 19241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1925fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle the GNU extension for missing LHS. 19269ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (Expr *lhsExpr = C->getLHS()) { 19279ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 19289ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (!lhsExpr->getType()->isVoidType()) 19299ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (DeclRefExpr* LHS = EvalAddr(lhsExpr)) 19309ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return LHS; 19319ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor } 19329ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor 19339ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 19349ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (C->getRHS()->getType()->isVoidType()) 19359ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return NULL; 193606de276fff91264437fa75111ed76de43097e089Ted Kremenek 19379ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return EvalAddr(C->getRHS()); 1938fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 19391eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 194054b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // For casts, we need to handle conversions from arrays to 194154b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // pointer values, and pointer-to-pointer conversions. 194249badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::ImplicitCastExprClass: 19436eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor case Stmt::CStyleCastExprClass: 194449badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXFunctionalCastExprClass: { 19450835a3cdeefe714b4959d31127ea155e56393125Argyrios Kyrtzidis Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 194654b5274f2c190331438375ad114dad12ae098b57Ted Kremenek QualType T = SubExpr->getType(); 19471eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1948dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (SubExpr->getType()->isPointerType() || 1949dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isBlockPointerType() || 1950dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isObjCQualifiedIdType()) 1951fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return EvalAddr(SubExpr); 195254b5274f2c190331438375ad114dad12ae098b57Ted Kremenek else if (T->isArrayType()) 195354b5274f2c190331438375ad114dad12ae098b57Ted Kremenek return EvalVal(SubExpr); 1954fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 195554b5274f2c190331438375ad114dad12ae098b57Ted Kremenek return 0; 1956fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 19571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1958fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // C++ casts. For dynamic casts, static casts, and const casts, we 1959fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // are always converting from a pointer-to-pointer, so we just blow 196049badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // through the cast. In the case the dynamic cast doesn't fail (and 196149badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // return NULL), we take the conservative route and report cases 1962fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // where we return the address of a stack variable. For Reinterpre 196349badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // FIXME: The comment about is wrong; we're not always converting 196449badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // from pointer to pointer. I'm guessing that this code should also 19651eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // handle references to objects. 19661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXStaticCastExprClass: 19671eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXDynamicCastExprClass: 196849badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXConstCastExprClass: 196949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXReinterpretCastExprClass: { 197049badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr(); 1971dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (S->getType()->isPointerType() || S->getType()->isBlockPointerType()) 1972fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return EvalAddr(S); 197306de276fff91264437fa75111ed76de43097e089Ted Kremenek else 197406de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 1975fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 19761eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1977fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Everything else: we simply don't reason about them. 1978fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner default: 1979fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 198006de276fff91264437fa75111ed76de43097e089Ted Kremenek } 198106de276fff91264437fa75111ed76de43097e089Ted Kremenek} 19821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 198306de276fff91264437fa75111ed76de43097e089Ted Kremenek 198406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalVal - This function is complements EvalAddr in the mutual recursion. 198506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// See the comments for EvalAddr for more details. 198606de276fff91264437fa75111ed76de43097e089Ted Kremenekstatic DeclRefExpr* EvalVal(Expr *E) { 198768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo { 1988e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // We should only be called for evaluating non-pointer expressions, or 1989e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // expressions with a pointer type that are not used as references but instead 1990e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // are l-values (e.g., DeclRefExpr with a pointer type). 19911eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 199206de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 199306de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 199406de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 199506de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 199668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ImplicitCastExprClass: { 199768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 19985baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall if (IE->getValueKind() == VK_LValue) { 199968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = IE->getSubExpr(); 200068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 200168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 200268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek return NULL; 200368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 200468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek 2005a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor case Stmt::DeclRefExprClass: { 200606de276fff91264437fa75111ed76de43097e089Ted Kremenek // DeclRefExpr: the base case. When we hit a DeclRefExpr we are looking 200706de276fff91264437fa75111ed76de43097e089Ted Kremenek // at code that refers to a variable's name. We check if it has local 200806de276fff91264437fa75111ed76de43097e089Ted Kremenek // storage within the function, and if so, return the expression. 200906de276fff91264437fa75111ed76de43097e089Ted Kremenek DeclRefExpr *DR = cast<DeclRefExpr>(E); 20101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 201106de276fff91264437fa75111ed76de43097e089Ted Kremenek if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 20121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump if (V->hasLocalStorage() && !V->getType()->isReferenceType()) return DR; 20131eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 201406de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 201506de276fff91264437fa75111ed76de43097e089Ted Kremenek } 20161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 201768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ParenExprClass: { 201806de276fff91264437fa75111ed76de43097e089Ted Kremenek // Ignore parentheses. 201968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = cast<ParenExpr>(E)->getSubExpr(); 202068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 202168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 20221eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 202306de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::UnaryOperatorClass: { 202406de276fff91264437fa75111ed76de43097e089Ted Kremenek // The only unary operator that make sense to handle here 202506de276fff91264437fa75111ed76de43097e089Ted Kremenek // is Deref. All others don't resolve to a "name." This includes 202606de276fff91264437fa75111ed76de43097e089Ted Kremenek // handling all sorts of rvalues passed to a unary operator. 202706de276fff91264437fa75111ed76de43097e089Ted Kremenek UnaryOperator *U = cast<UnaryOperator>(E); 20281eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 20292de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_Deref) 203006de276fff91264437fa75111ed76de43097e089Ted Kremenek return EvalAddr(U->getSubExpr()); 203106de276fff91264437fa75111ed76de43097e089Ted Kremenek 203206de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 203306de276fff91264437fa75111ed76de43097e089Ted Kremenek } 20341eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 203506de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ArraySubscriptExprClass: { 203606de276fff91264437fa75111ed76de43097e089Ted Kremenek // Array subscripts are potential references to data on the stack. We 203706de276fff91264437fa75111ed76de43097e089Ted Kremenek // retrieve the DeclRefExpr* for the array variable if it indeed 203806de276fff91264437fa75111ed76de43097e089Ted Kremenek // has local storage. 20392324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase()); 204006de276fff91264437fa75111ed76de43097e089Ted Kremenek } 20411eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 204206de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ConditionalOperatorClass: { 204306de276fff91264437fa75111ed76de43097e089Ted Kremenek // For conditional operators we need to see if either the LHS or RHS are 204406de276fff91264437fa75111ed76de43097e089Ted Kremenek // non-NULL DeclRefExpr's. If one is non-NULL, we return it. 204506de276fff91264437fa75111ed76de43097e089Ted Kremenek ConditionalOperator *C = cast<ConditionalOperator>(E); 204606de276fff91264437fa75111ed76de43097e089Ted Kremenek 20473907323dd6665c0c4e383435cb145233f4533406Anders Carlsson // Handle the GNU extension for missing LHS. 20483907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (Expr *lhsExpr = C->getLHS()) 20493907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (DeclRefExpr *LHS = EvalVal(lhsExpr)) 20503907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return LHS; 20513907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 20523907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return EvalVal(C->getRHS()); 205306de276fff91264437fa75111ed76de43097e089Ted Kremenek } 20541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 205506de276fff91264437fa75111ed76de43097e089Ted Kremenek // Accesses to members are potential references to data on the stack. 205683f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor case Stmt::MemberExprClass: { 205706de276fff91264437fa75111ed76de43097e089Ted Kremenek MemberExpr *M = cast<MemberExpr>(E); 20581eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 205906de276fff91264437fa75111ed76de43097e089Ted Kremenek // Check for indirect access. We only want direct field accesses. 2060a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->isArrow()) 2061a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return NULL; 2062a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 2063a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // Check whether the member type is itself a reference, in which case 2064a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // we're not going to refer to the member, but to what the member refers to. 2065a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->getMemberDecl()->getType()->isReferenceType()) 206606de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 2067a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 2068a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return EvalVal(M->getBase()); 206906de276fff91264437fa75111ed76de43097e089Ted Kremenek } 20701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 207106de276fff91264437fa75111ed76de43097e089Ted Kremenek // Everything else: we simply don't reason about them. 207206de276fff91264437fa75111ed76de43097e089Ted Kremenek default: 207306de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 207406de276fff91264437fa75111ed76de43097e089Ted Kremenek } 207568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true); 207606de276fff91264437fa75111ed76de43097e089Ted Kremenek} 2077588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2078588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 2079588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2080588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==. 2081588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely 2082588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended. 2083588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenekvoid Sema::CheckFloatComparison(SourceLocation loc, Expr* lex, Expr *rex) { 2084588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek bool EmitWarning = true; 20851eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 20864e99a5fc3b203397a91136c6e695e405fb8fc606Ted Kremenek Expr* LeftExprSansParen = lex->IgnoreParens(); 208732e97b66bbce16c9e81c877794fb7a0aeeb66ccbTed Kremenek Expr* RightExprSansParen = rex->IgnoreParens(); 2088588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2089588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Special case: check for x == x (which is OK). 2090588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Do not emit warnings for such cases. 2091588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 2092588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 2093588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DRL->getDecl() == DRR->getDecl()) 2094588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 20951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 20961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 20971b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // Special case: check for comparisons against literals that can be exactly 20981b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // represented by APFloat. In such cases, do not emit a warning. This 20991b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // is a heuristic: often comparison against such literals are used to 21001b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // detect if a value in a variable has not changed. This clearly can 21011b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // lead to false negatives. 21021b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (EmitWarning) { 21031b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 21041b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLL->isExact()) 21051b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 2106ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else 21071b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){ 21081b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLR->isExact()) 21091b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 21101b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 21111b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 21121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2113588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Check for comparisons with builtin types. 21140eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 2115588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 21163c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor if (CL->isBuiltinCall(Context)) 2117588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 21181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 21190eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 2120588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 21213c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor if (CR->isBuiltinCall(Context)) 2122588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 21231eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2124588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Emit the diagnostic. 2125588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (EmitWarning) 2126fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(loc, diag::warn_floatingpoint_eq) 2127fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << lex->getSourceRange() << rex->getSourceRange(); 2128588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek} 2129ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2130f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 2131f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 2132ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2133f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace { 2134ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2135f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued 2136f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression. 2137f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange { 2138f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// The number of bits active in the int. 2139f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned Width; 2140ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2141f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// True if the int is known not to have negative values. 2142f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool NonNegative; 214351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2144f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange(unsigned Width, bool NonNegative) 2145f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : Width(Width), NonNegative(NonNegative) 2146f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall {} 214751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 21481844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of the bool type. 2149f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall static IntRange forBoolType() { 2150f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(1, true); 2151f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 215251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 21531844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of the given integral type. 21541844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfType(ASTContext &C, QualType T) { 21551844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return forValueOfCanonicalType(C, 21561844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T->getCanonicalTypeInternal().getTypePtr()); 215751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 215851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 21591844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of a canonical integral type. 21601844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 2161f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(T->isCanonicalUnqualified()); 216251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2163f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 2164f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = VT->getElementType().getTypePtr(); 2165f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 2166f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = CT->getElementType().getTypePtr(); 2167323ed74658bc8375278eabf074b4777458376540John McCall 2168091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // For enum types, use the known bit width of the enumerators. 2169323ed74658bc8375278eabf074b4777458376540John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) { 2170323ed74658bc8375278eabf074b4777458376540John McCall EnumDecl *Enum = ET->getDecl(); 2171091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Enum->isDefinition()) 2172091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return IntRange(C.getIntWidth(QualType(T, 0)), false); 2173091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2174323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumPositive = Enum->getNumPositiveBits(); 2175323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumNegative = Enum->getNumNegativeBits(); 2176323ed74658bc8375278eabf074b4777458376540John McCall 2177323ed74658bc8375278eabf074b4777458376540John McCall return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0); 2178323ed74658bc8375278eabf074b4777458376540John McCall } 217951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2180f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const BuiltinType *BT = cast<BuiltinType>(T); 2181f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(BT->isInteger()); 218251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2183f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 218451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 218551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 21861844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the "target" range of a canonical integral type, i.e. 21871844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// the range of values expressible in the type. 21881844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// 21891844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// This matches forValueOfCanonicalType except that enums have the 21901844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// full range of their type, not the range of their enumerators. 21911844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 21921844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(T->isCanonicalUnqualified()); 21931844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 21941844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 21951844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = VT->getElementType().getTypePtr(); 21961844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 21971844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = CT->getElementType().getTypePtr(); 21981844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) 21991844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = ET->getDecl()->getIntegerType().getTypePtr(); 22001844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 22011844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall const BuiltinType *BT = cast<BuiltinType>(T); 22021844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(BT->isInteger()); 22031844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 22041844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 22051844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall } 22061844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 22071844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the supremum of two ranges: i.e. their conservative merge. 2208c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange join(IntRange L, IntRange R) { 2209f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(std::max(L.Width, R.Width), 221060fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative && R.NonNegative); 221160fad45739b764886f707bd204eae9ecce6db1f2John McCall } 221260fad45739b764886f707bd204eae9ecce6db1f2John McCall 22131844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the infinum of two ranges: i.e. their aggressive merge. 2214c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange meet(IntRange L, IntRange R) { 221560fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange(std::min(L.Width, R.Width), 221660fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative || R.NonNegative); 221751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 2218f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}; 221951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2220f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) { 2221f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isSigned() && value.isNegative()) 2222f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getMinSignedBits(), false); 222351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2224f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.getBitWidth() > MaxWidth) 2225f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall value.trunc(MaxWidth); 222651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2227f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // isNonNegative() just checks the sign bit without considering 2228f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // signedness. 2229f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getActiveBits(), true); 223051313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 223151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 22320acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCallIntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 2233f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned MaxWidth) { 2234f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isInt()) 2235f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetValueRange(C, result.getInt(), MaxWidth); 223651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2237f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isVector()) { 22380acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 22390acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 22400acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 22410acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall R = IntRange::join(R, El); 22420acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall } 2243f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return R; 224451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 224551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2246f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isComplexInt()) { 2247f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 2248f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 2249f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(R, I); 2250f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2251f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2252f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // This can happen with lossless casts to intptr_t of "based" lvalues. 2253f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume it might use arbitrary bits. 22540acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // FIXME: The only reason we need to pass the type in here is to get 22550acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // the sign right on this one case. It would be nice if APValue 22560acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // preserved this. 2257f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(result.isLValue()); 22580acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall return IntRange(MaxWidth, Ty->isUnsignedIntegerType()); 225951313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 226051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2261f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the 2262f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take. 2263f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 2264f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated 2265f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 226651313c39c84407dd6a323be99a8c322bf8d052a9John McCall E = E->IgnoreParens(); 226751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2268f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Try a full evaluation first. 2269f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall Expr::EvalResult result; 2270f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (E->Evaluate(result, C)) 22710acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall return GetValueRange(C, result.Val, E->getType(), MaxWidth); 227251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2273f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // I think we only want to look through implicit casts here; if the 2274f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // user has an explicit widening cast, we should treat the value as 2275f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // being of the new, wider type. 2276f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 22772de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (CE->getCastKind() == CK_NoOp) 2278f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CE->getSubExpr(), MaxWidth); 227951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 22801844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType()); 228151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 22822de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 22832de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (!isIntegerCast && CE->getCastKind() == CK_Unknown) 228460fad45739b764886f707bd204eae9ecce6db1f2John McCall isIntegerCast = CE->getSubExpr()->getType()->isIntegerType(); 228560fad45739b764886f707bd204eae9ecce6db1f2John McCall 2286f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume that non-integer casts can span the full range of the type. 228760fad45739b764886f707bd204eae9ecce6db1f2John McCall if (!isIntegerCast) 2288f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 228951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2290f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange SubRange 2291f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall = GetExprRange(C, CE->getSubExpr(), 2292f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall std::min(MaxWidth, OutputTypeRange.Width)); 229351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2294f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Bail out if the subexpr's range is as wide as the cast type. 2295f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SubRange.Width >= OutputTypeRange.Width) 2296f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 229751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2298f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, we take the smaller width, and we're non-negative if 2299f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // either the output type or the subexpr is. 2300f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(SubRange.Width, 2301f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall SubRange.NonNegative || OutputTypeRange.NonNegative); 2302f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2303f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2304f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 2305f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // If we can fold the condition, just take that operand. 2306f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool CondResult; 2307f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 2308f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CondResult ? CO->getTrueExpr() 2309f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : CO->getFalseExpr(), 2310f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall MaxWidth); 2311f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2312f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, conservatively merge. 2313f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 2314f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 2315f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 231651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 231751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 231851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 231951313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (BO->getOpcode()) { 232051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2321f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Boolean-valued operations are single-bit and positive. 23222de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LAnd: 23232de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LOr: 23242de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LT: 23252de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GT: 23262de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LE: 23272de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GE: 23282de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_EQ: 23292de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_NE: 2330f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 233151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2332c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall // The type of these compound assignments is the type of the LHS, 2333c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall // so the RHS is not necessarily an integer. 23342de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_MulAssign: 23352de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_DivAssign: 23362de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_RemAssign: 23372de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AddAssign: 23382de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_SubAssign: 23391844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 2340c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall 234151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 23422de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemD: 23432de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemI: 23441844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 234551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 234660fad45739b764886f707bd204eae9ecce6db1f2John McCall // Bitwise-and uses the *infinum* of the two source ranges. 23472de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_And: 23482de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AndAssign: 234960fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 235060fad45739b764886f707bd204eae9ecce6db1f2John McCall GetExprRange(C, BO->getRHS(), MaxWidth)); 235160fad45739b764886f707bd204eae9ecce6db1f2John McCall 235251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Left shift gets black-listed based on a judgement call. 23532de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shl: 23543aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // ...except that we want to treat '1 << (blah)' as logically 23553aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // positive. It's an important idiom. 23563aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (IntegerLiteral *I 23573aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 23583aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (I->getValue() == 1) { 23591844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange R = IntRange::forValueOfType(C, E->getType()); 23603aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall return IntRange(R.Width, /*NonNegative*/ true); 23613aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 23623aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 23633aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // fallthrough 23643aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall 23652de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShlAssign: 23661844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 236751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 236860fad45739b764886f707bd204eae9ecce6db1f2John McCall // Right shift by a constant can narrow its left argument. 23692de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shr: 23702de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShrAssign: { 237160fad45739b764886f707bd204eae9ecce6db1f2John McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 237260fad45739b764886f707bd204eae9ecce6db1f2John McCall 237360fad45739b764886f707bd204eae9ecce6db1f2John McCall // If the shift amount is a positive constant, drop the width by 237460fad45739b764886f707bd204eae9ecce6db1f2John McCall // that much. 237560fad45739b764886f707bd204eae9ecce6db1f2John McCall llvm::APSInt shift; 237660fad45739b764886f707bd204eae9ecce6db1f2John McCall if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 237760fad45739b764886f707bd204eae9ecce6db1f2John McCall shift.isNonNegative()) { 237860fad45739b764886f707bd204eae9ecce6db1f2John McCall unsigned zext = shift.getZExtValue(); 237960fad45739b764886f707bd204eae9ecce6db1f2John McCall if (zext >= L.Width) 238060fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width = (L.NonNegative ? 0 : 1); 238160fad45739b764886f707bd204eae9ecce6db1f2John McCall else 238260fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width -= zext; 238360fad45739b764886f707bd204eae9ecce6db1f2John McCall } 238460fad45739b764886f707bd204eae9ecce6db1f2John McCall 238560fad45739b764886f707bd204eae9ecce6db1f2John McCall return L; 238660fad45739b764886f707bd204eae9ecce6db1f2John McCall } 238760fad45739b764886f707bd204eae9ecce6db1f2John McCall 238860fad45739b764886f707bd204eae9ecce6db1f2John McCall // Comma acts as its right operand. 23892de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Comma: 2390f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 2391f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 239260fad45739b764886f707bd204eae9ecce6db1f2John McCall // Black-list pointer subtractions. 23932de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Sub: 239451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BO->getLHS()->getType()->isPointerType()) 23951844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 239651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // fallthrough 23974e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 239851313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 2399f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall break; 240051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 2401f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2402f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Treat every other operator as if it were closed on the 2403f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // narrowest type that encompasses both operands. 2404f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 2405f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 2406f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 240751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 240851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 240951313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 241051313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (UO->getOpcode()) { 241151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Boolean-valued operations are white-listed. 24122de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_LNot: 2413f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 241451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 241551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 24162de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_Deref: 24172de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_AddrOf: // should be impossible 24181844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 241951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 242051313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 2421f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, UO->getSubExpr(), MaxWidth); 242251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 242351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 24248ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor 24258ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor if (dyn_cast<OffsetOfExpr>(E)) { 24261844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange::forValueOfType(C, E->getType()); 24278ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor } 242851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2429f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall FieldDecl *BitField = E->getBitField(); 2430f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (BitField) { 2431f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APSInt BitWidthAP = BitField->getBitWidth()->EvaluateAsInt(C); 2432f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned BitWidth = BitWidthAP.getZExtValue(); 243351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2434f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(BitWidth, BitField->getType()->isUnsignedIntegerType()); 2435f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2436f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 24371844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 2438f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 2439f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2440323ed74658bc8375278eabf074b4777458376540John McCallIntRange GetExprRange(ASTContext &C, Expr *E) { 2441323ed74658bc8375278eabf074b4777458376540John McCall return GetExprRange(C, E, C.getIntWidth(E->getType())); 2442323ed74658bc8375278eabf074b4777458376540John McCall} 2443323ed74658bc8375278eabf074b4777458376540John McCall 2444f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 2445f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 2446f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 2447f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const llvm::APFloat &value, 2448f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 2449f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 2450f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APFloat truncated = value; 2451f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2452f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool ignored; 2453f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 2454f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 2455f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2456f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return truncated.bitwiseIsEqual(value); 245751313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 245851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2459f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 2460f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 2461f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 2462f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 2463f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number). 2464f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const APValue &value, 2465f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 2466f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 2467f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isFloat()) 2468f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 2469f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2470f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isVector()) { 2471f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 2472f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 2473f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return false; 2474f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return true; 2475f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2476f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2477f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(value.isComplexFloat()); 2478f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 2479f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 2480f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 2481f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2482b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 2483323ed74658bc8375278eabf074b4777458376540John McCall 2484e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) { 2485e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where we are comparing against an enum constant. 2486e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (const DeclRefExpr *DR = 2487e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 2488e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (isa<EnumConstantDecl>(DR->getDecl())) 2489e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 2490e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 2491e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where the '0' value is expanded from a macro. 2492e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (E->getLocStart().isMacroID()) 2493e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 2494e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 2495323ed74658bc8375278eabf074b4777458376540John McCall llvm::APSInt Value; 2496323ed74658bc8375278eabf074b4777458376540John McCall return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 2497323ed74658bc8375278eabf074b4777458376540John McCall} 2498323ed74658bc8375278eabf074b4777458376540John McCall 2499372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) { 2500372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall // Strip off implicit integral promotions. 2501372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 250263b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis if (ICE->getCastKind() != CK_IntegralCast && 250363b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis ICE->getCastKind() != CK_NoOp) 2504372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall break; 250563b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis E = ICE->getSubExpr(); 2506372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall } 2507372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 2508372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall return E->getType()->isEnumeralType(); 2509372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall} 2510372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 2511323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 25122de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = E->getOpcode(); 25132de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op == BO_LT && IsZero(S, E->getRHS())) { 2514323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 2515372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "< 0" << "false" << HasEnumType(E->getLHS()) 2516323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 25172de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GE && IsZero(S, E->getRHS())) { 2518323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 2519372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << ">= 0" << "true" << HasEnumType(E->getLHS()) 2520323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 25212de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GT && IsZero(S, E->getLHS())) { 2522323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 2523372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 >" << "false" << HasEnumType(E->getRHS()) 2524323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 25252de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_LE && IsZero(S, E->getLHS())) { 2526323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 2527372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 <=" << "true" << HasEnumType(E->getRHS()) 2528323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 2529323ed74658bc8375278eabf074b4777458376540John McCall } 2530323ed74658bc8375278eabf074b4777458376540John McCall} 2531323ed74658bc8375278eabf074b4777458376540John McCall 2532323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison. Implements the 2533323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison. 2534323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 2535b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 2536b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 2537323ed74658bc8375278eabf074b4777458376540John McCall} 2538f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2539ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare. 2540ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// 2541ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \param lex the left-hand expression 2542ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \param rex the right-hand expression 2543ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \param OpLoc the location of the joining operator 2544d1b47bf17fde73fac67d8664bd65273742c00ecdJohn McCall/// \param BinOpc binary opcode or 0 2545323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeComparison(Sema &S, BinaryOperator *E) { 2546323ed74658bc8375278eabf074b4777458376540John McCall // The type the comparison is being performed in. 2547323ed74658bc8375278eabf074b4777458376540John McCall QualType T = E->getLHS()->getType(); 2548323ed74658bc8375278eabf074b4777458376540John McCall assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 2549323ed74658bc8375278eabf074b4777458376540John McCall && "comparison with mismatched types"); 2550323ed74658bc8375278eabf074b4777458376540John McCall 2551323ed74658bc8375278eabf074b4777458376540John McCall // We don't do anything special if this isn't an unsigned integral 2552323ed74658bc8375278eabf074b4777458376540John McCall // comparison: we're only interested in integral comparisons, and 2553323ed74658bc8375278eabf074b4777458376540John McCall // signed comparisons only happen in cases we don't care to warn about. 2554f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (!T->hasUnsignedIntegerRepresentation()) 2555323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 2556323ed74658bc8375278eabf074b4777458376540John McCall 2557323ed74658bc8375278eabf074b4777458376540John McCall Expr *lex = E->getLHS()->IgnoreParenImpCasts(); 2558323ed74658bc8375278eabf074b4777458376540John McCall Expr *rex = E->getRHS()->IgnoreParenImpCasts(); 2559323ed74658bc8375278eabf074b4777458376540John McCall 2560323ed74658bc8375278eabf074b4777458376540John McCall // Check to see if one of the (unmodified) operands is of different 2561323ed74658bc8375278eabf074b4777458376540John McCall // signedness. 2562323ed74658bc8375278eabf074b4777458376540John McCall Expr *signedOperand, *unsignedOperand; 2563f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (lex->getType()->hasSignedIntegerRepresentation()) { 2564f60946222721d9ba3c059563935c17b84703187aDouglas Gregor assert(!rex->getType()->hasSignedIntegerRepresentation() && 2565323ed74658bc8375278eabf074b4777458376540John McCall "unsigned comparison between two signed integer expressions?"); 2566323ed74658bc8375278eabf074b4777458376540John McCall signedOperand = lex; 2567323ed74658bc8375278eabf074b4777458376540John McCall unsignedOperand = rex; 2568f60946222721d9ba3c059563935c17b84703187aDouglas Gregor } else if (rex->getType()->hasSignedIntegerRepresentation()) { 2569323ed74658bc8375278eabf074b4777458376540John McCall signedOperand = rex; 2570323ed74658bc8375278eabf074b4777458376540John McCall unsignedOperand = lex; 2571ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } else { 2572323ed74658bc8375278eabf074b4777458376540John McCall CheckTrivialUnsignedComparison(S, E); 2573323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 2574ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } 2575ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2576323ed74658bc8375278eabf074b4777458376540John McCall // Otherwise, calculate the effective range of the signed operand. 2577323ed74658bc8375278eabf074b4777458376540John McCall IntRange signedRange = GetExprRange(S.Context, signedOperand); 2578f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2579323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and analyze implicit conversions in the operands. Note 2580323ed74658bc8375278eabf074b4777458376540John McCall // that we skip the implicit conversions on both sides. 2581b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, lex, E->getOperatorLoc()); 2582b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, rex, E->getOperatorLoc()); 2583ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2584323ed74658bc8375278eabf074b4777458376540John McCall // If the signed range is non-negative, -Wsign-compare won't fire, 2585323ed74658bc8375278eabf074b4777458376540John McCall // but we should still check for comparisons which are always true 2586323ed74658bc8375278eabf074b4777458376540John McCall // or false. 2587323ed74658bc8375278eabf074b4777458376540John McCall if (signedRange.NonNegative) 2588323ed74658bc8375278eabf074b4777458376540John McCall return CheckTrivialUnsignedComparison(S, E); 2589ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2590ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // For (in)equality comparisons, if the unsigned operand is a 2591ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // constant which cannot collide with a overflowed signed operand, 2592ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // then reinterpreting the signed operand as unsigned will not 2593ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // change the result of the comparison. 2594323ed74658bc8375278eabf074b4777458376540John McCall if (E->isEqualityOp()) { 2595323ed74658bc8375278eabf074b4777458376540John McCall unsigned comparisonWidth = S.Context.getIntWidth(T); 2596323ed74658bc8375278eabf074b4777458376540John McCall IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 2597323ed74658bc8375278eabf074b4777458376540John McCall 2598323ed74658bc8375278eabf074b4777458376540John McCall // We should never be unable to prove that the unsigned operand is 2599323ed74658bc8375278eabf074b4777458376540John McCall // non-negative. 2600323ed74658bc8375278eabf074b4777458376540John McCall assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 2601ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2602323ed74658bc8375278eabf074b4777458376540John McCall if (unsignedRange.Width < comparisonWidth) 2603323ed74658bc8375278eabf074b4777458376540John McCall return; 2604323ed74658bc8375278eabf074b4777458376540John McCall } 2605323ed74658bc8375278eabf074b4777458376540John McCall 2606323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison) 2607323ed74658bc8375278eabf074b4777458376540John McCall << lex->getType() << rex->getType() 2608323ed74658bc8375278eabf074b4777458376540John McCall << lex->getSourceRange() << rex->getSourceRange(); 2609ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall} 2610ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2611beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy 2612beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations. 2613beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCallvoid AnalyzeAssignment(Sema &S, BinaryOperator *E) { 2614beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Just recurse on the LHS. 2615beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 2616beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 2617beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // We want to recurse on the RHS as normal unless we're assigning to 2618beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // a bitfield. 2619beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (FieldDecl *Bitfield = E->getLHS()->getBitField()) { 2620beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall assert(Bitfield->isBitField()); 2621beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 2622beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall Expr *RHS = E->getRHS()->IgnoreParenImpCasts(); 2623beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 2624beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall llvm::APSInt Width(32); 2625beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall Expr::EvalResult RHSValue; 2626beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (!Bitfield->isInvalidDecl() && 2627beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall Bitfield->getBitWidth()->isIntegerConstantExpr(Width, S.Context) && 2628beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall RHS->Evaluate(RHSValue, S.Context) && RHSValue.Val.isInt()) { 2629beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall const llvm::APSInt &Value = RHSValue.Val.getInt(); 2630beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall unsigned OriginalWidth = Value.getBitWidth(); 2631beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall unsigned FieldWidth = Width.getZExtValue(); 2632beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 2633beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (OriginalWidth > FieldWidth) { 2634beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall llvm::APSInt TruncatedValue = Value; 2635beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall TruncatedValue.trunc(FieldWidth); 2636935cd6e8529edbb3b0eba660bd934b508766de37John McCall 2637935cd6e8529edbb3b0eba660bd934b508766de37John McCall // It's fairly common to write values into signed bitfields 2638935cd6e8529edbb3b0eba660bd934b508766de37John McCall // that, if sign-extended, would end up becoming a different 2639935cd6e8529edbb3b0eba660bd934b508766de37John McCall // value. We don't want to warn about that. 2640935cd6e8529edbb3b0eba660bd934b508766de37John McCall if (Value.isSigned() && Value.isNegative()) 2641935cd6e8529edbb3b0eba660bd934b508766de37John McCall TruncatedValue.sext(OriginalWidth); 2642935cd6e8529edbb3b0eba660bd934b508766de37John McCall else 2643935cd6e8529edbb3b0eba660bd934b508766de37John McCall TruncatedValue.zext(OriginalWidth); 2644beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 2645beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (Value != TruncatedValue) { 2646beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall std::string PrettyValue = Value.toString(10); 2647beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall std::string PrettyTrunc = TruncatedValue.toString(10); 2648beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 2649beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall S.Diag(E->getOperatorLoc(), 2650beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall diag::warn_impcast_bitfield_precision_constant) 2651beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall << PrettyValue << PrettyTrunc << RHS->getType() 2652beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall << E->getRHS()->getSourceRange(); 2653beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 2654beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Recurse, ignoring any implicit conversions on the RHS. 2655beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc()); 2656beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 2657beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 2658beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 2659beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 2660beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 2661beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 2662beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall} 2663beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 266451313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 2665b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid DiagnoseImpCast(Sema &S, Expr *E, QualType T, SourceLocation CContext, 2666b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall unsigned diag) { 2667b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall S.Diag(E->getExprLoc(), diag) 2668b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall << E->getType() << T << E->getSourceRange() << SourceRange(CContext); 266951313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 267051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2671091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 2672091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Range.Width) return "0"; 2673091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2674091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt ValueInRange = Value; 2675091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.setIsSigned(!Range.NonNegative); 2676091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.trunc(Range.Width); 2677091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return ValueInRange.toString(10); 2678091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall} 2679091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2680323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T, 2681b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool *ICContext = 0) { 2682323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) return; 268351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2684323ed74658bc8375278eabf074b4777458376540John McCall const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 2685323ed74658bc8375278eabf074b4777458376540John McCall const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 2686323ed74658bc8375278eabf074b4777458376540John McCall if (Source == Target) return; 2687323ed74658bc8375278eabf074b4777458376540John McCall if (Target->isDependentType()) return; 268851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2689b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // If the conversion context location is invalid or instantiated 2690b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // from a system macro, don't complain. 2691b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall if (CC.isInvalid() || 2692b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall (CC.isMacroID() && S.Context.getSourceManager().isInSystemHeader( 2693b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall S.Context.getSourceManager().getSpellingLoc(CC)))) 2694b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return; 2695b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 269651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Never diagnose implicit casts to bool. 269751313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (Target->isSpecificBuiltinType(BuiltinType::Bool)) 269851313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 269951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 270051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip vector types. 270151313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<VectorType>(Source)) { 270251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (!isa<VectorType>(Target)) 2703b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 270451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 270551313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 270651313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 270751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 270851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 270951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip complex types. 271051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<ComplexType>(Source)) { 271151313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (!isa<ComplexType>(Target)) 2712b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 271351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 271451313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 271551313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 271651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 271751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 271851313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 271951313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 272051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 272151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the source is floating point... 272251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT && SourceBT->isFloatingPoint()) { 272351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...and the target is floating point... 272451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (TargetBT && TargetBT->isFloatingPoint()) { 272551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...then warn if we're dropping FP rank. 272651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 272751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Builtin FP kinds are ordered by increasing FP rank. 272851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT->getKind() > TargetBT->getKind()) { 272951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Don't warn about float constants that are precisely 273051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // representable in the target type. 273151313c39c84407dd6a323be99a8c322bf8d052a9John McCall Expr::EvalResult result; 2732323ed74658bc8375278eabf074b4777458376540John McCall if (E->Evaluate(result, S.Context)) { 273351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Value might be a float, a float vector, or a float complex. 273451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (IsSameFloatAfterCast(result.Val, 2735323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 2736323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 273751313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 273851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 273951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2740b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 274151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 274251313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 274351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 274451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 274551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the target is integral, always warn. 274651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if ((TargetBT && TargetBT->isInteger())) 274751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // TODO: don't warn for integer values? 2748b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 274951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 275051313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 275151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 275251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2753f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!Source->isIntegerType() || !Target->isIntegerType()) 275451313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 275551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2756323ed74658bc8375278eabf074b4777458376540John McCall IntRange SourceRange = GetExprRange(S.Context, E); 27571844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 275851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2759f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width > TargetRange.Width) { 2760091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // If the source is a constant, use a default-on diagnostic. 2761091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // TODO: this should happen for bitfield stores, too. 2762091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt Value(32); 2763091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (E->isIntegerConstantExpr(Value, S.Context)) { 2764091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettySourceValue = Value.toString(10); 2765091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 2766091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2767091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall S.Diag(E->getExprLoc(), diag::warn_impcast_integer_precision_constant) 2768091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall << PrettySourceValue << PrettyTargetValue 2769091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall << E->getType() << T << E->getSourceRange() << clang::SourceRange(CC); 2770091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return; 2771091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall } 2772091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 277351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // People want to build with -Wshorten-64-to-32 and not -Wconversion 277451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // and by god we'll let them. 2775f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width == 64 && TargetRange.Width == 32) 2776b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32); 2777b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 2778323ed74658bc8375278eabf074b4777458376540John McCall } 2779323ed74658bc8375278eabf074b4777458376540John McCall 2780323ed74658bc8375278eabf074b4777458376540John McCall if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 2781323ed74658bc8375278eabf074b4777458376540John McCall (!TargetRange.NonNegative && SourceRange.NonNegative && 2782323ed74658bc8375278eabf074b4777458376540John McCall SourceRange.Width == TargetRange.Width)) { 2783323ed74658bc8375278eabf074b4777458376540John McCall unsigned DiagID = diag::warn_impcast_integer_sign; 2784323ed74658bc8375278eabf074b4777458376540John McCall 2785323ed74658bc8375278eabf074b4777458376540John McCall // Traditionally, gcc has warned about this under -Wsign-compare. 2786323ed74658bc8375278eabf074b4777458376540John McCall // We also want to warn about it in -Wconversion. 2787323ed74658bc8375278eabf074b4777458376540John McCall // So if -Wconversion is off, use a completely identical diagnostic 2788323ed74658bc8375278eabf074b4777458376540John McCall // in the sign-compare group. 2789323ed74658bc8375278eabf074b4777458376540John McCall // The conditional-checking code will 2790323ed74658bc8375278eabf074b4777458376540John McCall if (ICContext) { 2791323ed74658bc8375278eabf074b4777458376540John McCall DiagID = diag::warn_impcast_integer_sign_conditional; 2792323ed74658bc8375278eabf074b4777458376540John McCall *ICContext = true; 2793323ed74658bc8375278eabf074b4777458376540John McCall } 2794323ed74658bc8375278eabf074b4777458376540John McCall 2795b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, DiagID); 279651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 279751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 279851313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 279951313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 280051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2801323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T); 2802323ed74658bc8375278eabf074b4777458376540John McCall 2803323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T, 2804b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool &ICContext) { 2805323ed74658bc8375278eabf074b4777458376540John McCall E = E->IgnoreParenImpCasts(); 2806323ed74658bc8375278eabf074b4777458376540John McCall 2807323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) 2808323ed74658bc8375278eabf074b4777458376540John McCall return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T); 2809323ed74658bc8375278eabf074b4777458376540John McCall 2810b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E, CC); 2811323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 2812b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return CheckImplicitConversion(S, E, T, CC, &ICContext); 2813323ed74658bc8375278eabf074b4777458376540John McCall return; 2814323ed74658bc8375278eabf074b4777458376540John McCall} 2815323ed74658bc8375278eabf074b4777458376540John McCall 2816323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) { 2817b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC = E->getQuestionLoc(); 2818b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 2819b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getCond(), CC); 2820323ed74658bc8375278eabf074b4777458376540John McCall 2821323ed74658bc8375278eabf074b4777458376540John McCall bool Suspicious = false; 2822b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 2823b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 2824323ed74658bc8375278eabf074b4777458376540John McCall 2825323ed74658bc8375278eabf074b4777458376540John McCall // If -Wconversion would have warned about either of the candidates 2826323ed74658bc8375278eabf074b4777458376540John McCall // for a signedness conversion to the context type... 2827323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) return; 2828323ed74658bc8375278eabf074b4777458376540John McCall 2829323ed74658bc8375278eabf074b4777458376540John McCall // ...but it's currently ignored... 2830323ed74658bc8375278eabf074b4777458376540John McCall if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional)) 2831323ed74658bc8375278eabf074b4777458376540John McCall return; 2832323ed74658bc8375278eabf074b4777458376540John McCall 2833323ed74658bc8375278eabf074b4777458376540John McCall // ...and -Wsign-compare isn't... 2834323ed74658bc8375278eabf074b4777458376540John McCall if (!S.Diags.getDiagnosticLevel(diag::warn_mixed_sign_conditional)) 2835323ed74658bc8375278eabf074b4777458376540John McCall return; 2836323ed74658bc8375278eabf074b4777458376540John McCall 2837323ed74658bc8375278eabf074b4777458376540John McCall // ...then check whether it would have warned about either of the 2838323ed74658bc8375278eabf074b4777458376540John McCall // candidates for a signedness conversion to the condition type. 2839323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) { 2840323ed74658bc8375278eabf074b4777458376540John McCall Suspicious = false; 2841323ed74658bc8375278eabf074b4777458376540John McCall CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 2842b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 2843323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) 2844323ed74658bc8375278eabf074b4777458376540John McCall CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 2845b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 2846323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) 2847323ed74658bc8375278eabf074b4777458376540John McCall return; 2848323ed74658bc8375278eabf074b4777458376540John McCall } 2849323ed74658bc8375278eabf074b4777458376540John McCall 2850323ed74658bc8375278eabf074b4777458376540John McCall // If so, emit a diagnostic under -Wsign-compare. 2851323ed74658bc8375278eabf074b4777458376540John McCall Expr *lex = E->getTrueExpr()->IgnoreParenImpCasts(); 2852323ed74658bc8375278eabf074b4777458376540John McCall Expr *rex = E->getFalseExpr()->IgnoreParenImpCasts(); 2853323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getQuestionLoc(), diag::warn_mixed_sign_conditional) 2854323ed74658bc8375278eabf074b4777458376540John McCall << lex->getType() << rex->getType() 2855323ed74658bc8375278eabf074b4777458376540John McCall << lex->getSourceRange() << rex->getSourceRange(); 2856323ed74658bc8375278eabf074b4777458376540John McCall} 2857323ed74658bc8375278eabf074b4777458376540John McCall 2858323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting 2859323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression. There are a couple 2860323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare. 2861b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 2862323ed74658bc8375278eabf074b4777458376540John McCall QualType T = OrigE->getType(); 2863323ed74658bc8375278eabf074b4777458376540John McCall Expr *E = OrigE->IgnoreParenImpCasts(); 2864323ed74658bc8375278eabf074b4777458376540John McCall 2865323ed74658bc8375278eabf074b4777458376540John McCall // For conditional operators, we analyze the arguments as if they 2866323ed74658bc8375278eabf074b4777458376540John McCall // were being fed directly into the output. 2867323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) { 2868323ed74658bc8375278eabf074b4777458376540John McCall ConditionalOperator *CO = cast<ConditionalOperator>(E); 2869323ed74658bc8375278eabf074b4777458376540John McCall CheckConditionalOperator(S, CO, T); 2870323ed74658bc8375278eabf074b4777458376540John McCall return; 2871323ed74658bc8375278eabf074b4777458376540John McCall } 2872323ed74658bc8375278eabf074b4777458376540John McCall 2873323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and check any implicit conversions we might have skipped. 2874323ed74658bc8375278eabf074b4777458376540John McCall // The non-canonical typecheck is just an optimization; 2875323ed74658bc8375278eabf074b4777458376540John McCall // CheckImplicitConversion will filter out dead implicit conversions. 2876323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 2877b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckImplicitConversion(S, E, T, CC); 2878323ed74658bc8375278eabf074b4777458376540John McCall 2879323ed74658bc8375278eabf074b4777458376540John McCall // Now continue drilling into this expression. 2880323ed74658bc8375278eabf074b4777458376540John McCall 2881323ed74658bc8375278eabf074b4777458376540John McCall // Skip past explicit casts. 2882323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ExplicitCastExpr>(E)) { 2883323ed74658bc8375278eabf074b4777458376540John McCall E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 2884b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return AnalyzeImplicitConversions(S, E, CC); 2885323ed74658bc8375278eabf074b4777458376540John McCall } 2886323ed74658bc8375278eabf074b4777458376540John McCall 2887beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 2888beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Do a somewhat different check with comparison operators. 2889beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isComparisonOp()) 2890beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeComparison(S, BO); 2891beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 2892beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // And with assignments and compound assignments. 2893beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isAssignmentOp()) 2894beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeAssignment(S, BO); 2895beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 2896323ed74658bc8375278eabf074b4777458376540John McCall 2897323ed74658bc8375278eabf074b4777458376540John McCall // These break the otherwise-useful invariant below. Fortunately, 2898323ed74658bc8375278eabf074b4777458376540John McCall // we don't really need to recurse into them, because any internal 2899323ed74658bc8375278eabf074b4777458376540John McCall // expressions should have been analyzed already when they were 2900323ed74658bc8375278eabf074b4777458376540John McCall // built into statements. 2901323ed74658bc8375278eabf074b4777458376540John McCall if (isa<StmtExpr>(E)) return; 2902323ed74658bc8375278eabf074b4777458376540John McCall 2903323ed74658bc8375278eabf074b4777458376540John McCall // Don't descend into unevaluated contexts. 2904323ed74658bc8375278eabf074b4777458376540John McCall if (isa<SizeOfAlignOfExpr>(E)) return; 2905323ed74658bc8375278eabf074b4777458376540John McCall 2906323ed74658bc8375278eabf074b4777458376540John McCall // Now just recurse over the expression's children. 2907b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CC = E->getExprLoc(); 2908323ed74658bc8375278eabf074b4777458376540John McCall for (Stmt::child_iterator I = E->child_begin(), IE = E->child_end(); 2909323ed74658bc8375278eabf074b4777458376540John McCall I != IE; ++I) 2910b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, cast<Expr>(*I), CC); 2911323ed74658bc8375278eabf074b4777458376540John McCall} 2912323ed74658bc8375278eabf074b4777458376540John McCall 2913323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace 2914323ed74658bc8375278eabf074b4777458376540John McCall 2915323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given 2916323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression). Implements -Wconversion 2917323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare. 2918b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// 2919b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e. 2920b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// the most location of the syntactic entity requiring the implicit 2921b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// conversion 2922b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 2923323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose in unevaluated contexts. 2924323ed74658bc8375278eabf074b4777458376540John McCall if (ExprEvalContexts.back().Context == Sema::Unevaluated) 2925323ed74658bc8375278eabf074b4777458376540John McCall return; 2926323ed74658bc8375278eabf074b4777458376540John McCall 2927323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose for value- or type-dependent expressions. 2928323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) 2929323ed74658bc8375278eabf074b4777458376540John McCall return; 2930323ed74658bc8375278eabf074b4777458376540John McCall 2931b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // This is not the right CC for (e.g.) a variable initialization. 2932b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(*this, E, CC); 2933323ed74658bc8375278eabf074b4777458376540John McCall} 2934323ed74658bc8375278eabf074b4777458376540John McCall 2935f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given 2936f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This 2937f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the 2938f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function 2939f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete. 294082aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregorbool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd, 294182aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor bool CheckParameterNames) { 2942f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump bool HasInvalidParm = false; 294382aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor for (; P != PEnd; ++P) { 294482aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor ParmVarDecl *Param = *P; 294582aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor 2946f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.7.5.3p4: the parameters in a parameter type list in a 2947f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // function declarator that is part of a function definition of 2948f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // that function shall not have incomplete type. 2949f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // 2950f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // This is also C++ [dcl.fct]p6. 2951f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump if (!Param->isInvalidDecl() && 2952f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump RequireCompleteType(Param->getLocation(), Param->getType(), 2953f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump diag::err_typecheck_decl_incomplete_type)) { 2954f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Param->setInvalidDecl(); 2955f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump HasInvalidParm = true; 2956f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 2957f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 2958f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.9.1p5: If the declarator includes a parameter type list, the 2959f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // declaration of each parameter shall include an identifier. 296082aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor if (CheckParameterNames && 296182aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor Param->getIdentifier() == 0 && 2962f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !Param->isImplicit() && 2963f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !getLangOptions().CPlusPlus) 2964f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Diag(Param->getLocation(), diag::err_parameter_name_omitted); 2965d17e340e2d516139931768697bf080f60920ba9dSam Weinig 2966d17e340e2d516139931768697bf080f60920ba9dSam Weinig // C99 6.7.5.3p12: 2967d17e340e2d516139931768697bf080f60920ba9dSam Weinig // If the function declarator is not part of a definition of that 2968d17e340e2d516139931768697bf080f60920ba9dSam Weinig // function, parameters may have incomplete type and may use the [*] 2969d17e340e2d516139931768697bf080f60920ba9dSam Weinig // notation in their sequences of declarator specifiers to specify 2970d17e340e2d516139931768697bf080f60920ba9dSam Weinig // variable length array types. 2971d17e340e2d516139931768697bf080f60920ba9dSam Weinig QualType PType = Param->getOriginalType(); 2972d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (const ArrayType *AT = Context.getAsArrayType(PType)) { 2973d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (AT->getSizeModifier() == ArrayType::Star) { 2974d17e340e2d516139931768697bf080f60920ba9dSam Weinig // FIXME: This diagnosic should point the the '[*]' if source-location 2975d17e340e2d516139931768697bf080f60920ba9dSam Weinig // information is added for it. 2976d17e340e2d516139931768697bf080f60920ba9dSam Weinig Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 2977d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 2978d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 2979f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 2980f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 2981f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump return HasInvalidParm; 2982f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump} 2983b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 2984b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a 2985b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements. 2986b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 2987b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // This is actually a lot of work to potentially be doing on every 2988b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // cast; don't do it if we're ignoring -Wcast_align (as is the default). 2989b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align) 2990b7f4ffe073fa419613946461a2583ba2fcb72280John McCall == Diagnostic::Ignored) 2991b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 2992b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 2993b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Ignore dependent types. 2994b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (T->isDependentType() || Op->getType()->isDependentType()) 2995b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 2996b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 2997b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the destination be a pointer type. 2998b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *DestPtr = T->getAs<PointerType>(); 2999b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!DestPtr) return; 3000b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3001b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // If the destination has alignment 1, we're done. 3002b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType DestPointee = DestPtr->getPointeeType(); 3003b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestPointee->isIncompleteType()) return; 3004b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 3005b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestAlign.isOne()) return; 3006b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3007b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the source be a pointer type. 3008b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 3009b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!SrcPtr) return; 3010b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType SrcPointee = SrcPtr->getPointeeType(); 3011b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3012b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Whitelist casts from cv void*. We already implicitly 3013b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // whitelisted casts to cv void*, since they have alignment 1. 3014b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Also whitelist casts involving incomplete types, which implicitly 3015b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // includes 'void'. 3016b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcPointee->isIncompleteType()) return; 3017b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3018b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 3019b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcAlign >= DestAlign) return; 3020b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3021b7f4ffe073fa419613946461a2583ba2fcb72280John McCall Diag(TRange.getBegin(), diag::warn_cast_align) 3022b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << Op->getType() << T 3023b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(SrcAlign.getQuantity()) 3024b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(DestAlign.getQuantity()) 3025b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << TRange << Op->getSourceRange(); 3026b7f4ffe073fa419613946461a2583ba2fcb72280John McCall} 3027b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3028