SemaChecking.cpp revision 284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// The LLVM Compiler Infrastructure 459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source 60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details. 759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump// This file implements extra semantic analysis beyond what is enforced 1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// by the C type system. 1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 15e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Sema.h" 162d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 17781472fe99a120098c631b0cbe33c89f8cef5e70John McCall#include "clang/Sema/ScopeInfo.h" 18826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek#include "clang/Analysis/Analyses/FormatString.h" 1959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h" 20199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h" 21384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 22c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h" 232324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h" 247ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h" 25f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/DeclObjC.h" 26f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h" 27f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h" 2859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h" 29f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h" 30f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h" 313bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h" 32691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher#include "clang/Basic/TargetBuiltins.h" 3326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman#include "clang/Basic/TargetInfo.h" 347da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian#include "clang/Basic/ConvertUTF.h" 35a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits> 3659907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang; 37781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema; 3859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 3960800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 4060800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned ByteNo) const { 4108f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner return SL->getLocationOfByte(ByteNo, PP.getSourceManager(), 4208f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner PP.getLangOptions(), PP.getTargetInfo()); 4360800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner} 4408f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner 4560800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 464403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// CheckablePrintfAttr - does a function call have a "printf" attribute 474403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// and arguments that merit checking? 484403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynnbool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) { 494403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf") return true; 504403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf0") { 514403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn // printf0 allows null "format" string; if so don't check format/args 524403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn unsigned format_idx = Format->getFormatIdx() - 1; 534a2614e94672c47395abcde60518776fbebec589Sebastian Redl // Does the index refer to the implicit object argument? 544a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 554a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (format_idx == 0) 564a2614e94672c47395abcde60518776fbebec589Sebastian Redl return false; 574a2614e94672c47395abcde60518776fbebec589Sebastian Redl --format_idx; 584a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 594403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (format_idx < TheCall->getNumArgs()) { 604403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts(); 61efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!Format->isNullPointerConstant(Context, 62efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek Expr::NPC_ValueDependentIsNull)) 634403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return true; 644403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 654403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 664403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return false; 674403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn} 6860800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 6960d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 70d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 7160d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult TheCallResult(Owned(TheCall)); 722def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor 73946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Find out if any arguments are required to be integer constant expressions. 74946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner unsigned ICEArguments = 0; 75946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ASTContext::GetBuiltinTypeError Error; 76946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 77946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (Error != ASTContext::GE_None) 78946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments = 0; // Don't diagnose previously diagnosed errors. 79946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 80946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // If any arguments are required to be ICE's, check and diagnose. 81946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 82946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Skip arguments not required to be ICE's. 83946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if ((ICEArguments & (1 << ArgNo)) == 0) continue; 84946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 85946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner llvm::APSInt Result; 86946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 87946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner return true; 88946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments &= ~(1 << ArgNo); 89946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner } 90946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 91d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson switch (BuiltinID) { 9230ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin___CFStringMakeConstantString: 93925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner assert(TheCall->getNumArgs() == 1 && 941b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner "Wrong # arguments to builtin CFStringMakeConstantString"); 95690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner if (CheckObjCString(TheCall->getArg(0))) 960eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 97d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 9849ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek case Builtin::BI__builtin_stdarg_start: 9930ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin_va_start: 1000eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinVAStart(TheCall)) 1010eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 102d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1031b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreater: 1041b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreaterequal: 1051b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isless: 1061b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessequal: 1071b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessgreater: 1081b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isunordered: 1090eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinUnorderedCompare(TheCall)) 1100eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 111d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 112e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer case Builtin::BI__builtin_fpclassify: 113e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer if (SemaBuiltinFPClassification(TheCall, 6)) 114e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer return ExprError(); 115e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer break; 1169ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isfinite: 1179ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf: 1189ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf_sign: 1199ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnan: 1209ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnormal: 1213b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (SemaBuiltinFPClassification(TheCall, 1)) 1229ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return ExprError(); 1239ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman break; 124d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman case Builtin::BI__builtin_shufflevector: 1250eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return SemaBuiltinShuffleVector(TheCall); 1260eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // TheCall will be freed by the smart pointer here, but that's fine, since 1270eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // SemaBuiltinShuffleVector guts it, but then doesn't release it. 1284493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar case Builtin::BI__builtin_prefetch: 1290eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinPrefetch(TheCall)) 1300eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 131d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 132d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar case Builtin::BI__builtin_object_size: 1330eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinObjectSize(TheCall)) 1340eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 135d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 136d875fed28578835de89cd407e9db4be788596d7cEli Friedman case Builtin::BI__builtin_longjmp: 137d875fed28578835de89cd407e9db4be788596d7cEli Friedman if (SemaBuiltinLongjmp(TheCall)) 138d875fed28578835de89cd407e9db4be788596d7cEli Friedman return ExprError(); 139d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 14075c29a012793292ff4578015a9113bf086156d7fChris Lattner case Builtin::BI__builtin_constant_p: 14175c29a012793292ff4578015a9113bf086156d7fChris Lattner if (TheCall->getNumArgs() == 0) 14275c29a012793292ff4578015a9113bf086156d7fChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 14375c29a012793292ff4578015a9113bf086156d7fChris Lattner << 0 /*function call*/ << 1 << 0 << TheCall->getSourceRange(); 14475c29a012793292ff4578015a9113bf086156d7fChris Lattner if (TheCall->getNumArgs() > 1) 14575c29a012793292ff4578015a9113bf086156d7fChris Lattner return Diag(TheCall->getArg(1)->getLocStart(), 14675c29a012793292ff4578015a9113bf086156d7fChris Lattner diag::err_typecheck_call_too_many_args) 14775c29a012793292ff4578015a9113bf086156d7fChris Lattner << 0 /*function call*/ << 1 << TheCall->getNumArgs() 14875c29a012793292ff4578015a9113bf086156d7fChris Lattner << TheCall->getArg(1)->getSourceRange(); 14975c29a012793292ff4578015a9113bf086156d7fChris Lattner break; 1505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: 1515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: 1525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: 1535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: 1545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: 1555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_add_and_fetch: 1565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_sub_and_fetch: 1575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_and_and_fetch: 1585caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_or_and_fetch: 1595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_xor_and_fetch: 1605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 1615caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 1625caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_test_and_set: 1635caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 164d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return SemaBuiltinAtomicOverloaded(move(TheCallResult)); 16526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 16626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 16726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // Since the target specific builtins for each arch overlap, only check those 16826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // of the arch we are compiling for. 16926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (BuiltinID >= Builtin::FirstTSBuiltin) { 17026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman switch (Context.Target.getTriple().getArch()) { 17126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::arm: 17226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::thumb: 17326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 17426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return ExprError(); 17526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 17626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman default: 17726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 17826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 17926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 18026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 18126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return move(TheCallResult); 18226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman} 18326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 18461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code. 18561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) { 18661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman bool quad = t & 0x10; 18761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 18861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman switch (t & 0x7) { 18961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 0: // i8 190d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 7 : (8 << (int)quad) - 1; 19161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 1: // i16 192d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 15 : (4 << (int)quad) - 1; 19361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 2: // i32 194d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 31 : (2 << (int)quad) - 1; 19561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 3: // i64 196d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 63 : (1 << (int)quad) - 1; 19761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 4: // f32 19861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift float types!"); 199d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (2 << (int)quad) - 1; 20061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 5: // poly8 20142499f94069c73d7a9c82da98a4245ea9fe2c526Bob Wilson return shift ? 7 : (8 << (int)quad) - 1; 20261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 6: // poly16 20342499f94069c73d7a9c82da98a4245ea9fe2c526Bob Wilson return shift ? 15 : (4 << (int)quad) - 1; 20461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 7: // float16 20561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift float types!"); 206d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (4 << (int)quad) - 1; 20761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman } 20861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman return 0; 20961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman} 21061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 21126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 2121c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman llvm::APSInt Result; 2131c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2140d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned mask = 0; 21561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned TV = 0; 2161c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman switch (BuiltinID) { 217a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK 218a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 219a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK 2201c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman } 2211c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2220d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which are overloaded on vector element type, validate 2230d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // the immediate which specifies which variant to emit. 2240d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (mask) { 2250d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned ArgNo = TheCall->getNumArgs()-1; 2260d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 2270d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 2280d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 22961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman TV = Result.getLimitedValue(32); 23061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if ((TV > 31) || (mask & (1 << TV)) == 0) 2310d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 2320d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman << TheCall->getArg(ArgNo)->getSourceRange(); 2330d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman } 2341c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2350d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which take an immediate value as part of the 2360d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // instruction, range check them here. 23761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned i = 0, l = 0, u = 0; 2380d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman switch (BuiltinID) { 2390d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman default: return false; 240bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 241bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 24299c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_f: 24399c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 244a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK 245a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 246a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK 2470d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman }; 2480d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 24961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Check that the immediate argument is actually a constant. 2500d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, i, Result)) 2510d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 2520d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 25361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Range check against the upper/lower values for this isntruction. 2540d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned Val = Result.getZExtValue(); 25561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if (Val < l || Val > (u + l)) 2560d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 257476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer << l << u+l << TheCall->getArg(i)->getSourceRange(); 2580d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 25999c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman // FIXME: VFP Intrinsics should error if VFP not present. 26026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return false; 261d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson} 262d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 263d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// CheckFunctionCall - Check a direct function call for various correctness 264d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// and safety properties not strictly enforced by the C type system. 265d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) { 266d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // Get the IdentifierInfo* for the called function. 267d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson IdentifierInfo *FnInfo = FDecl->getIdentifier(); 268de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 269d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // None of the checks below are needed for functions that don't have 270d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // simple names (e.g., C++ conversion functions). 271d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson if (!FnInfo) 272d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 2731eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 274de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // FIXME: This mechanism should be abstracted to be less fragile and 275de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // more efficient. For example, just map function ids to custom 276de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // handlers. 277de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 278c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek // Printf and scanf checking. 279c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<FormatAttr> 280c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<FormatAttr>(), 281c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<FormatAttr>(); i != e ; ++i) { 282c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek 283c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek const FormatAttr *Format = *i; 284826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 285826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (b || CheckablePrintfAttr(Format, TheCall)) { 2863d692df4b9c58895f9843b03543ec57447c93679Ted Kremenek bool HasVAListArg = Format->getFirstArg() == 0; 287826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, 288826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Format->getFormatIdx() - 1, 289826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, 290826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek !b); 2913c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor } 29259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner } 2931eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 294c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<NonNullAttr> 295c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<NonNullAttr>(), 296c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<NonNullAttr>(); i != e; ++i) { 297cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt CheckNonNullArguments(*i, TheCall); 298c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek } 2990eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 300d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 30171993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson} 30271993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 303d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) { 304725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian // Printf checking. 30540b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis const FormatAttr *Format = NDecl->getAttr<FormatAttr>(); 306725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Format) 307d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 309725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian const VarDecl *V = dyn_cast<VarDecl>(NDecl); 310725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!V) 311d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 313725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian QualType Ty = V->getType(); 314725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Ty->isBlockPointerType()) 315d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 317826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 318826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!b && !CheckablePrintfAttr(Format, TheCall)) 319d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3201eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 321d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson bool HasVAListArg = Format->getFirstArg() == 0; 322826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1, 323826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, !b); 324d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 325d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 326725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian} 327725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian 3285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like 3295caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer 3305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument. The main ActOnCallExpr routines have already 3315caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as 3325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...). 3335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// 3345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these 3355caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins, 33660d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 33760d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 338d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 3395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 3405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 3415caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 3425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Ensure that we have at least one argument to do type inference from. 343d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1) { 344d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 345d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1 << TheCall->getNumArgs() 346d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 347d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 348d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 3491eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Inspect the first argument of the atomic builtin. This should always be 3515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // a pointer type, whose element is an integral scalar or pointer type. 3525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Because it is a pointer type, we don't have to worry about any implicit 3535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // casts here. 354d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth // FIXME: We don't allow floating point scalars as input. 3555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *FirstArg = TheCall->getArg(0); 356d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (!FirstArg->getType()->isPointerType()) { 357d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 358d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 359d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 360d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 3611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 362d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth QualType ValType = 363d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth FirstArg->getType()->getAs<PointerType>()->getPointeeType(); 364dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 365d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth !ValType->isBlockPointerType()) { 366d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 367d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 368d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 369d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 3705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 3718d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // The majority of builtins return a value, but a few have special return 3728d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // types, so allow them to override appropriately below. 3738d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth QualType ResultType = ValType; 3748d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth 3755caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // We need to figure out which concrete builtin this maps onto. For example, 3765caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add with a 2 byte object turns into 3775caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add_2. 3785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \ 3795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 3805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Builtin::BI##x##_8, Builtin::BI##x##_16 } 3811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner static const unsigned BuiltinIndices[][5] = { 3835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_add), 3845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_sub), 3855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_or), 3865caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_and), 3875caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_xor), 3881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3895caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_add_and_fetch), 3905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_sub_and_fetch), 3915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_and_and_fetch), 3925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_or_and_fetch), 3935caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_xor_and_fetch), 3941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_val_compare_and_swap), 3965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_bool_compare_and_swap), 3975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_test_and_set), 3985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_release) 3995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner }; 4001eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW 4011eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Determine the index of the size. 4035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned SizeIndex; 404199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 4055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 1: SizeIndex = 0; break; 4065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 2: SizeIndex = 1; break; 4075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 4: SizeIndex = 2; break; 4085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 8: SizeIndex = 3; break; 4095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 16: SizeIndex = 4; break; 4105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: 411d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 412d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 413d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 4145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 4151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Each of these builtins has one pointer argument, followed by some number of 4175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // values (0, 1 or 2) followed by a potentially empty varags list of stuff 4185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // that we ignore. Find out which row of BuiltinIndices to read from as well 4195caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // as the number of fixed args. 4207814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor unsigned BuiltinID = FDecl->getBuiltinID(); 4215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned BuiltinIndex, NumFixed = 1; 4225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner switch (BuiltinID) { 4235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: assert(0 && "Unknown overloaded atomic builtin!"); 4245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break; 4255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break; 4265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break; 4275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break; 4285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break; 4291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4307eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break; 4317eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break; 4327eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break; 4337eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break; 4347eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break; 4351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 4377eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 10; 4385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 4395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 4405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 4417eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 11; 4425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 4438d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.BoolTy; 4445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 4457eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break; 4465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 4477eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 13; 4485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 0; 4498d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.VoidTy; 4505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 4515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 4521eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Now that we know how many fixed arguments we expect, first check that we 4545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // have at least that many. 455d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1+NumFixed) { 456d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 457d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1+NumFixed << TheCall->getNumArgs() 458d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 459d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 460d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 4611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 462e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // Get the decl for the concrete builtin from this, we can tell what the 463e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // concrete integer type we should convert to is. 464e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 465e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 466e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName); 4671eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump FunctionDecl *NewBuiltinDecl = 468e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID, 469e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner TUScope, false, DRE->getLocStart())); 470d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 471f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // The first argument --- the pointer --- has a fixed type; we 472f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // deduce the types of the rest of the arguments accordingly. Walk 473f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // the remaining arguments, converting them to the deduced value type. 4745caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner for (unsigned i = 0; i != NumFixed; ++i) { 4755caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *Arg = TheCall->getArg(i+1); 4761eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4775caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // If the argument is an implicit cast, then there was a promotion due to 4785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // "...", just remove it now. 4795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) { 4805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Arg = ICE->getSubExpr(); 4815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner ICE->setSubExpr(0); 4825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner TheCall->setArg(i+1, Arg); 4835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 4841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // GCC does an implicit conversion to the pointer or integer ValType. This 4865caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // can fail in some cases (1i -> int**), check for this error case now. 487daa8e4e888758d55a7a759dd4a91b83921cef222John McCall CastKind Kind = CK_Invalid; 488f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall ExprValueKind VK = VK_RValue; 489f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall CXXCastPath BasePath; 490f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall if (CheckCastTypes(Arg->getSourceRange(), ValType, Arg, Kind, VK, BasePath)) 491d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 4921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4935caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Okay, we have something that *can* be converted to the right type. Check 4945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // to see if there is a potentially weird extension going on here. This can 4955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // happen when you do an atomic operation on something like an char* and 4965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // pass in 42. The 42 gets converted to char. This is even more strange 4975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // for things like 45.123 -> char, etc. 4981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // FIXME: Do this check. 499f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall ImpCastExprToType(Arg, ValType, Kind, VK, &BasePath); 5005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner TheCall->setArg(i+1, Arg); 5015caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 5021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Switch the DeclRefExpr to refer to the new decl. 5045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DRE->setDecl(NewBuiltinDecl); 5055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DRE->setType(NewBuiltinDecl->getType()); 5061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Set the callee in the CallExpr. 5085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // FIXME: This leaks the original parens and implicit casts. 5095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *PromotedCall = DRE; 5105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner UsualUnaryConversions(PromotedCall); 5115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner TheCall->setCallee(PromotedCall); 5121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 513db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // Change the result type of the call to match the original value type. This 514db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // is arbitrary, but the codegen for these builtins ins design to handle it 515db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // gracefully. 5168d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth TheCall->setType(ResultType); 517d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 518d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return move(TheCallResult); 5195caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner} 5205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 5215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 522690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin 52371993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct 524fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would 525fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend). 526690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) { 52756f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner Arg = Arg->IgnoreParenCasts(); 52871993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 52971993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 53071993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson if (!Literal || Literal->isWide()) { 531fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 532fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << Arg->getSourceRange(); 5339cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return true; 53471993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson } 5351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5362f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer size_t NulPos = Literal->getString().find('\0'); 5372f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer if (NulPos != llvm::StringRef::npos) { 5382f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer Diag(getLocationOfStringLiteralByte(Literal, NulPos), 5392f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer diag::warn_cfstring_literal_contains_nul_character) 5402f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer << Arg->getSourceRange(); 541f015b034159d40e7033309e50036804eb1971787Daniel Dunbar } 5427da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Literal->containsNonAsciiOrNull()) { 5437da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian llvm::StringRef String = Literal->getString(); 5447da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian unsigned NumBytes = String.size(); 5457da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian llvm::SmallVector<UTF16, 128> ToBuf(NumBytes); 5467da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian const UTF8 *FromPtr = (UTF8 *)String.data(); 5477da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian UTF16 *ToPtr = &ToBuf[0]; 5487da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 5497da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 5507da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian &ToPtr, ToPtr + NumBytes, 5517da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian strictConversion); 5527da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian // Check for conversion failure. 5537da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Result != conversionOK) 5547da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian Diag(Arg->getLocStart(), 5557da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian diag::warn_cfstring_truncated) << Arg->getSourceRange(); 5567da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian } 5579cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return false; 55859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner} 55959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 560c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 561c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success. 562925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 563925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *Fn = TheCall->getCallee(); 564925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) { 5652c21a073525cdfa68e4439b7af551385dc2796abChris Lattner Diag(TheCall->getArg(2)->getLocStart(), 566fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 567ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 568ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << Fn->getSourceRange() 5691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(2)->getLocStart(), 570fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 57130ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 57230ce344307f8a8b00054021307015571f83c7364Chris Lattner } 57356f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 57456f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman if (TheCall->getNumArgs() < 2) { 575d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher return Diag(TheCall->getLocEnd(), 576d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 577d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 57856f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman } 57956f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 580c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner // Determine whether the current function is variadic or not. 5819ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor BlockScopeInfo *CurBlock = getCurBlock(); 582c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner bool isVariadic; 583cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 584c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall isVariadic = CurBlock->TheDecl->isVariadic(); 5859498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else if (FunctionDecl *FD = getCurFunctionDecl()) 5869498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek isVariadic = FD->isVariadic(); 5879498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else 58853d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis isVariadic = getCurMethodDecl()->isVariadic(); 5891eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 590c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner if (!isVariadic) { 59130ce344307f8a8b00054021307015571f83c7364Chris Lattner Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 59230ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 59330ce344307f8a8b00054021307015571f83c7364Chris Lattner } 5941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 59530ce344307f8a8b00054021307015571f83c7364Chris Lattner // Verify that the second argument to the builtin is the last argument of the 59630ce344307f8a8b00054021307015571f83c7364Chris Lattner // current function or method. 59730ce344307f8a8b00054021307015571f83c7364Chris Lattner bool SecondArgIsLastNamedArgument = false; 598e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 5991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 60088cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 60188cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 60230ce344307f8a8b00054021307015571f83c7364Chris Lattner // FIXME: This isn't correct for methods (results in bogus warning). 60330ce344307f8a8b00054021307015571f83c7364Chris Lattner // Get the last formal in the current function. 60488cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson const ParmVarDecl *LastArg; 605cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 606cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff LastArg = *(CurBlock->TheDecl->param_end()-1); 607cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff else if (FunctionDecl *FD = getCurFunctionDecl()) 608371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner LastArg = *(FD->param_end()-1); 60930ce344307f8a8b00054021307015571f83c7364Chris Lattner else 61053d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis LastArg = *(getCurMethodDecl()->param_end()-1); 61130ce344307f8a8b00054021307015571f83c7364Chris Lattner SecondArgIsLastNamedArgument = PV == LastArg; 61230ce344307f8a8b00054021307015571f83c7364Chris Lattner } 61330ce344307f8a8b00054021307015571f83c7364Chris Lattner } 6141eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 61530ce344307f8a8b00054021307015571f83c7364Chris Lattner if (!SecondArgIsLastNamedArgument) 6161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(1)->getLocStart(), 61730ce344307f8a8b00054021307015571f83c7364Chris Lattner diag::warn_second_parameter_of_va_start_not_last_named_argument); 61830ce344307f8a8b00054021307015571f83c7364Chris Lattner return false; 6196cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman} 62030ce344307f8a8b00054021307015571f83c7364Chris Lattner 6211b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 6221b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends. This is declared to take (...), so we have to check everything. 623925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 624925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() < 2) 6252c21a073525cdfa68e4439b7af551385dc2796abChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 626d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << 2 << TheCall->getNumArgs()/*function call*/; 627925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) 6281eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(TheCall->getArg(2)->getLocStart(), 629fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 630ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 631fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(TheCall->getArg(2)->getLocStart(), 632fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 6331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 634925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *OrigArg0 = TheCall->getArg(0); 635925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *OrigArg1 = TheCall->getArg(1); 636cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 6371b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // Do standard promotions between the two arguments, returning their common 6381b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // type. 639925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 640403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar 641403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // Make sure any conversions are pushed back into the call; this is 642403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // type safe since unordered compare builtins are declared as "_Bool 643403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // foo(...)". 644403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar TheCall->setArg(0, OrigArg0); 645403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar TheCall->setArg(1, OrigArg1); 6461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 647cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (OrigArg0->isTypeDependent() || OrigArg1->isTypeDependent()) 648cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 649cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 6501b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // If the common type isn't a real floating type, then the arguments were 6511b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // invalid for this operation. 6521b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner if (!Res->isRealFloatingType()) 6531eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg0->getLocStart(), 654fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_invalid_ordered_compare) 655d162584991885ab004a02573a73ce06422b921fcChris Lattner << OrigArg0->getType() << OrigArg1->getType() 656fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(OrigArg0->getLocStart(), OrigArg1->getLocEnd()); 6571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 6581b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner return false; 6591b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner} 6601b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner 661e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 662e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends. This is declared to take (...), so we have 6633b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point 6643b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value. 6653b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 6663b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() < NumArgs) 6679ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 668d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 6693b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() > NumArgs) 6703b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer return Diag(TheCall->getArg(NumArgs)->getLocStart(), 6719ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_too_many_args) 672ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 6733b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 6749ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman (*(TheCall->arg_end()-1))->getLocEnd()); 6759ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 6763b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer Expr *OrigArg = TheCall->getArg(NumArgs-1); 6771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 6789ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (OrigArg->isTypeDependent()) 6799ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 6809ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 68181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // This operation requires a non-_Complex floating-point number. 6829ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (!OrigArg->getType()->isRealFloatingType()) 6831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg->getLocStart(), 6849ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_invalid_unary_fp) 6859ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman << OrigArg->getType() << OrigArg->getSourceRange(); 6861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 68781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // If this is an implicit conversion from float -> double, remove it. 68881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 68981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Expr *CastArg = Cast->getSubExpr(); 69081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 69181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 69281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner "promotion from float to double is the only expected cast here"); 69381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Cast->setSubExpr(0); 69481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner TheCall->setArg(NumArgs-1, CastArg); 69581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner OrigArg = CastArg; 69681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 69781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 69881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner 6999ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 7009ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman} 7019ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 702d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 703d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything. 70460d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 70537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() < 2) 7060eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocEnd(), 707d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 70837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << 0 /*function call*/ << 2 << TheCall->getNumArgs() 709d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << TheCall->getSourceRange()); 710d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 71137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Determine which of the following types of shufflevector we're checking: 71237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 1) unary, vector mask: (lhs, mask) 71337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 2) binary, vector mask: (lhs, rhs, mask) 71437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 71537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType resType = TheCall->getArg(0)->getType(); 71637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numElements = 0; 71737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 718cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (!TheCall->getArg(0)->isTypeDependent() && 719cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor !TheCall->getArg(1)->isTypeDependent()) { 72037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType LHSType = TheCall->getArg(0)->getType(); 72137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType RHSType = TheCall->getArg(1)->getType(); 72237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 72337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!LHSType->isVectorType() || !RHSType->isVectorType()) { 724cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) 7251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 726cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 727cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 728cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 72937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 73037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numElements = LHSType->getAs<VectorType>()->getNumElements(); 73137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numResElements = TheCall->getNumArgs() - 2; 73237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 73337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Check to see if we have a call with 2 vector arguments, the unary shuffle 73437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // with mask. If so, verify that RHS is an integer vector type with the 73537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // same number of elts as lhs. 73637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() == 2) { 737f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (!RHSType->hasIntegerRepresentation() || 73837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman RHSType->getAs<VectorType>()->getNumElements() != numElements) 73937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 74037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << SourceRange(TheCall->getArg(1)->getLocStart(), 74137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman TheCall->getArg(1)->getLocEnd()); 74237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numResElements = numElements; 74337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } 74437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 745cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 7461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 747cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 748cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 74937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } else if (numElements != numResElements) { 75037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 751788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner resType = Context.getVectorType(eltType, numResElements, 752e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson VectorType::GenericVector); 753cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 754d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 755d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 756d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 757cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 758cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(i)->isValueDependent()) 759cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor continue; 760cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 76137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman llvm::APSInt Result(32); 76237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 76337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman return ExprError(Diag(TheCall->getLocStart(), 76437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman diag::err_shufflevector_nonconstant_argument) 76537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << TheCall->getArg(i)->getSourceRange()); 7660eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 767d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 7680eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocStart(), 769fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_shufflevector_argument_too_large) 7700eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl << TheCall->getArg(i)->getSourceRange()); 771d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 772d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 773d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman llvm::SmallVector<Expr*, 32> exprs; 774d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 775d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 776d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman exprs.push_back(TheCall->getArg(i)); 777d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman TheCall->setArg(i, 0); 778d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 779d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 780a88dc3079bedf70a5cfc39791727e43a10383006Nate Begeman return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(), 78137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman exprs.size(), resType, 7828189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getCallee()->getLocStart(), 7838189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getRParenLoc())); 784d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman} 78530ce344307f8a8b00054021307015571f83c7364Chris Lattner 7864493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 7874493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two 7884493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args. 7894493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 790fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner unsigned NumArgs = TheCall->getNumArgs(); 7914493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 792fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (NumArgs > 3) 793ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher return Diag(TheCall->getLocEnd(), 794ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher diag::err_typecheck_call_too_many_args_at_most) 795ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 3 << NumArgs 796ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << TheCall->getSourceRange(); 7974493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 7984493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // Argument 0 is checked for us and the remaining arguments must be 7994493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // constant integers. 800fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner for (unsigned i = 1; i != NumArgs; ++i) { 8014493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar Expr *Arg = TheCall->getArg(i); 802691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 8039aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman llvm::APSInt Result; 804691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, i, Result)) 805691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 8061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8074493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // FIXME: gcc issues a warning and rewrites these to 0. These 8084493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // seems especially odd for the third argument since the default 8094493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // is 3. 810fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (i == 1) { 8119aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 1) 812fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 81321fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "1" << Arg->getSourceRange(); 8144493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } else { 8159aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 3) 816fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 81721fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "3" << Arg->getSourceRange(); 8184493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 8194493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 8204493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 821fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return false; 8224493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar} 8234493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 824691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 825691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression. 826691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 827691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt &Result) { 828691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(ArgNum); 829691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 830691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 831691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 832691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 833691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 834691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (!Arg->isIntegerConstantExpr(Result, Context)) 835691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 8365e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher << FDecl->getDeclName() << Arg->getSourceRange(); 837691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 83821fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner return false; 83921fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner} 84021fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner 841d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 842d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined 843d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3). 844fee667f35e64751baa7fefe70b4e7bab06c8cd86Eric Christopher// For compatability check 0-3, llvm only handles 0 and 2. 845d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 846691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 847691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 848691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // Check constant-ness first. 849691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 850691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 851d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 852691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(1); 853d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 854fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 855fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 856d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar } 857d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 858d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar return false; 859d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar} 860d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 861586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 862d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1. 863d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 864d875fed28578835de89cd407e9db4be788596d7cEli Friedman Expr *Arg = TheCall->getArg(1); 865691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 866cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 867691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // TODO: This is less than ideal. Overload this to take a value. 868691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 869691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 870691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 871691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Result != 1) 872d875fed28578835de89cd407e9db4be788596d7cEli Friedman return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 873d875fed28578835de89cd407e9db4be788596d7cEli Friedman << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 874d875fed28578835de89cd407e9db4be788596d7cEli Friedman 875d875fed28578835de89cd407e9db4be788596d7cEli Friedman return false; 876d875fed28578835de89cd407e9db4be788596d7cEli Friedman} 877d875fed28578835de89cd407e9db4be788596d7cEli Friedman 878d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek// Handle i > 1 ? "x" : "y", recursivelly 879082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenekbool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall, 880082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool HasVAListArg, 881826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 882826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 8834fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain: 884cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 885cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 886d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 887d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek switch (E->getStmtClass()) { 88856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::BinaryConditionalOperatorClass: 889d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ConditionalOperatorClass: { 89056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall const AbstractConditionalOperator *C = cast<AbstractConditionalOperator>(E); 891826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return SemaCheckStringLiteral(C->getTrueExpr(), TheCall, HasVAListArg, 892826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf) 89356ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall && SemaCheckStringLiteral(C->getFalseExpr(), TheCall, HasVAListArg, 894826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf); 895d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 896d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 89795355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek case Stmt::IntegerLiteralClass: 89895355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // Technically -Wformat-nonliteral does not warn about this case. 89995355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // The behavior of printf and friends in this case is implementation 90095355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // dependent. Ideally if the format string cannot be null then 90195355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // it should have a 'nonnull' attribute in the function prototype. 90295355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek return true; 90395355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek 904d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ImplicitCastExprClass: { 9054fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ImplicitCastExpr>(E)->getSubExpr(); 9064fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 907d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 908d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 909d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ParenExprClass: { 9104fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ParenExpr>(E)->getSubExpr(); 9114fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 912d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 9131eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 91456ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::OpaqueValueExprClass: 91556ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) { 91656ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall E = src; 91756ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall goto tryAgain; 91856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall } 91956ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall return false; 92056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall 921082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::DeclRefExprClass: { 922082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const DeclRefExpr *DR = cast<DeclRefExpr>(E); 9231eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 924082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // As an exception, do not flag errors for variables binding to 925082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // const string literals. 926082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 927082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool isConstant = false; 928082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek QualType T = DR->getType(); 929082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek 930082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ArrayType *AT = Context.getAsArrayType(T)) { 931082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek isConstant = AT->getElementType().isConstant(Context); 932ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (const PointerType *PT = T->getAs<PointerType>()) { 9331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump isConstant = T.isConstant(Context) && 934082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek PT->getPointeeType().isConstant(Context); 935082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 9361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 937082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (isConstant) { 93831310a21fb2a9f13950f864f681c86080b05d5b2Sebastian Redl if (const Expr *Init = VD->getAnyInitializer()) 939082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return SemaCheckStringLiteral(Init, TheCall, 940826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, format_idx, firstDataArg, 941826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isPrintf); 942082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 9431eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 944d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // For vprintf* functions (i.e., HasVAListArg==true), we add a 945d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // special check to see if the format string is a function parameter 946d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // of the function calling the printf function. If the function 947d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // has an attribute indicating it is a printf-like function, then we 948d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // should suppress warnings concerning non-literals being used in a call 949d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // to a vprintf function. For example: 950d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 951d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // void 952d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 953d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_list ap; 954d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_start(ap, fmt); 955d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 956d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // ... 957d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 958d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 959d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // FIXME: We don't have full attribute support yet, so just check to see 960d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // if the argument is a DeclRefExpr that references a parameter. We'll 961d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // add proper support for checking the attribute later. 962d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (HasVAListArg) 963d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (isa<ParmVarDecl>(VD)) 964d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson return true; 965082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 9661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 967082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 968082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 969d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 9708f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson case Stmt::CallExprClass: { 9718f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const CallExpr *CE = cast<CallExpr>(E); 9721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump if (const ImplicitCastExpr *ICE 9738f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson = dyn_cast<ImplicitCastExpr>(CE->getCallee())) { 9748f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) { 9758f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) { 97640b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) { 9778f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson unsigned ArgIndex = FA->getFormatIdx(); 9788f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const Expr *Arg = CE->getArg(ArgIndex - 1); 9791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9801eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg, 981826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf); 9828f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 9838f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 9848f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 9858f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 9861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9878f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson return false; 9888f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 989082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::ObjCStringLiteralClass: 990082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::StringLiteralClass: { 991082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const StringLiteral *StrE = NULL; 9921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 993082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 994d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek StrE = ObjCFExpr->getString(); 995d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek else 996082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek StrE = cast<StringLiteral>(E); 9971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 998d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek if (StrE) { 999826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatString(StrE, E, TheCall, HasVAListArg, format_idx, 1000826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek firstDataArg, isPrintf); 1001d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return true; 1002d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 10031eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1004d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return false; 1005d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 10061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1007082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek default: 1008082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1009d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1010d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1011d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1012e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid 10131eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull, 10141eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump const CallExpr *TheCall) { 1015cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt for (NonNullAttr::args_iterator i = NonNull->args_begin(), 1016cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt e = NonNull->args_end(); 1017e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian i != e; ++i) { 101812b97ff9ce1412e388444f03049bfa6ad1bb5eb9Chris Lattner const Expr *ArgExpr = TheCall->getArg(*i); 10194e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (ArgExpr->isNullPointerConstant(Context, 1020ce94049b69f75b44c18584fe79cd238978b6b0d5Douglas Gregor Expr::NPC_ValueDependentIsNotNull)) 102112b97ff9ce1412e388444f03049bfa6ad1bb5eb9Chris Lattner Diag(TheCall->getCallee()->getLocStart(), diag::warn_null_arg) 102212b97ff9ce1412e388444f03049bfa6ad1bb5eb9Chris Lattner << ArgExpr->getSourceRange(); 1023e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian } 1024e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian} 1025d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1026826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar 1027826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings. 102859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnervoid 1029826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSema::CheckPrintfScanfArguments(const CallExpr *TheCall, bool HasVAListArg, 1030826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1031826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 1032826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1033082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *Fn = TheCall->getCallee(); 1034925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner 10354a2614e94672c47395abcde60518776fbebec589Sebastian Redl // The way the format attribute works in GCC, the implicit this argument 10364a2614e94672c47395abcde60518776fbebec589Sebastian Redl // of member functions is counted. However, it doesn't appear in our own 10374a2614e94672c47395abcde60518776fbebec589Sebastian Redl // lists, so decrement format_idx in that case. 10384a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 10399263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth const CXXMethodDecl *method_decl = 10409263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth dyn_cast<CXXMethodDecl>(TheCall->getCalleeDecl()); 10419263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if (method_decl && method_decl->isInstance()) { 10429263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth // Catch a format attribute mistakenly referring to the object argument. 10439263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if (format_idx == 0) 10449263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth return; 10459263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth --format_idx; 10469263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if(firstDataArg != 0) 10479263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth --firstDataArg; 10489263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth } 10494a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 10504a2614e94672c47395abcde60518776fbebec589Sebastian Redl 1051826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // CHECK: printf/scanf-like function is called with no format string. 1052925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (format_idx >= TheCall->getNumArgs()) { 1053826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Diag(TheCall->getRParenLoc(), diag::warn_missing_format_string) 1054dcd5ef12488e4c7ea844327835896ca86b609a97Chris Lattner << Fn->getSourceRange(); 105571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek return; 105671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek } 10571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1058082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts(); 10591eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 106059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner // CHECK: format string is not a string literal. 10611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // 106271895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // Dynamically generated format strings are difficult to 106371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // automatically vet at compile time. Requiring that format strings 106471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // are string literals: (1) permits the checking of format strings by 106571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // the compiler and thereby (2) can practically remove the source of 106671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // many format string exploits. 10677ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek 10681eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // Format string can be either ObjC string (e.g. @"%d") or 10697ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // C string (e.g. "%d") 10701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // ObjC string uses the same format specifiers as C string, so we can use 10717ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // the same format string checking logic for both ObjC and C strings. 10721cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx, 1073826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek firstDataArg, isPrintf)) 10741cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner return; // Literal format string found, check done! 10751cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner 1076655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // If there are no arguments specified, warn with -Wformat-security, otherwise 1077655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // warn only with -Wformat-nonliteral. 1078655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner if (TheCall->getNumArgs() == format_idx+1) 10791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1080826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral_noargs) 1081655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1082655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner else 10831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1084826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral) 1085655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1086d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1087d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1088e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace { 1089826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler { 1090826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1091e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Sema &S; 1092e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const StringLiteral *FExpr; 1093e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const Expr *OrigFormatExpr; 10946ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const unsigned FirstDataArg; 1095e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const unsigned NumDataArgs; 1096e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const bool IsObjCLiteral; 1097e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *Beg; // Start of format string. 10980d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const bool HasVAListArg; 10990d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const CallExpr *TheCall; 11000d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek unsigned FormatIdx; 11017f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek llvm::BitVector CoveredArgs; 1102efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool usesPositionalArgs; 1103efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool atFirstArg; 11044e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic: 1105826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 11066ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1107e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 11080d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const char *beg, bool hasVAListArg, 11090d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1110e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 11116ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek FirstDataArg(firstDataArg), 11127f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek NumDataArgs(numDataArgs), 11130d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek IsObjCLiteral(isObjCLiteral), Beg(beg), 11140d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek HasVAListArg(hasVAListArg), 1115efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek TheCall(theCall), FormatIdx(formatIdx), 1116efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek usesPositionalArgs(false), atFirstArg(true) { 11177f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.resize(numDataArgs); 11187f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.reset(); 11197f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 11204e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 112107d161f38e708a91486bf1c031d525faebbb249dTed Kremenek void DoneProcessing(); 11224e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1123826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIncompleteSpecifier(const char *startSpecifier, 1124826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1125826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1126efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleInvalidPosition(const char *startSpecifier, 1127efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned specifierLen, 1128826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p); 1129efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1130efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 1131efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1132e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek void HandleNullChar(const char *nullCharacter); 11334e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1134826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1135c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 1136c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1137c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1138c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, unsigned csLen); 1139c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1140f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek SourceRange getFormatStringRange(); 1141826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CharSourceRange getSpecifierRange(const char *startSpecifier, 1142826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1143e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek SourceLocation getLocationOfByte(const char *x); 11444e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 11450d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const Expr *getDataArg(unsigned i) const; 1146666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1147666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 1148666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1149666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, 1150666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek unsigned argIndex); 1151e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}; 1152e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1153e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1154826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() { 1155e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return OrigFormatExpr->getSourceRange(); 1156e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1157e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1158826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler:: 1159826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 116045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation Start = getLocationOfByte(startSpecifier); 116145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 116245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 116345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care // Advance the end SourceLocation by one due to half-open ranges. 116445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care End = End.getFileLocWithOffset(1); 116545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 116645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care return CharSourceRange::getCharRange(Start, End); 1167f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek} 1168f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek 1169826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 11704e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 1171e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1172e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1173826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 1174826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen){ 1175808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek SourceLocation Loc = getLocationOfByte(startSpecifier); 1176808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek S.Diag(Loc, diag::warn_printf_incomplete_specifier) 1177826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1178808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek} 1179808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek 1180efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid 1181826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 1182826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p) { 1183efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek SourceLocation Loc = getLocationOfByte(startPos); 1184826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(Loc, diag::warn_format_invalid_positional_specifier) 1185826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << (unsigned) p << getSpecifierRange(startPos, posLen); 1186efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1187efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1188826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos, 1189efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned posLen) { 1190efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek SourceLocation Loc = getLocationOfByte(startPos); 1191826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(Loc, diag::warn_format_zero_positional_specifier) 1192826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startPos, posLen); 1193efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1194efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1195826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 1196826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The presence of a null character is likely an error. 1197826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getLocationOfByte(nullCharacter), 1198826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_printf_format_string_contains_null_char) 1199826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getFormatStringRange(); 1200826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1201826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1202826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const { 1203826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return TheCall->getArg(FirstDataArg + i); 1204826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 12054e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1206826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() { 1207826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Does the number of data arguments exceed the number of 1208826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // format conversions in the format string? 1209826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!HasVAListArg) { 1210826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Find any arguments that weren't covered. 1211826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.flip(); 1212826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek signed notCoveredArg = CoveredArgs.find_first(); 1213826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (notCoveredArg >= 0) { 1214826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek assert((unsigned)notCoveredArg < NumDataArgs); 1215826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(), 1216826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_printf_data_arg_not_used) 1217826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getFormatStringRange(); 1218826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1219826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1220826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1221826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1222c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool 1223c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 1224c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek SourceLocation Loc, 1225c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1226c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1227c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, 1228c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned csLen) { 1229c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1230c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool keepGoing = true; 1231c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek if (argIndex < NumDataArgs) { 1232c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // Consider the argument coverered, even though the specifier doesn't 1233c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // make sense. 1234c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CoveredArgs.set(argIndex); 1235c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1236c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek else { 1237c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // If argIndex exceeds the number of data arguments we 1238c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // don't issue a warning because that is just a cascade of warnings (and 1239c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // they may have intended '%%' anyway). We don't want to continue processing 1240c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // the format string after this point, however, as we will like just get 1241c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // gibberish when trying to match arguments. 1242c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek keepGoing = false; 1243c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1244c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1245c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek S.Diag(Loc, diag::warn_format_invalid_conversion) 1246c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek << llvm::StringRef(csStart, csLen) 1247c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek << getSpecifierRange(startSpec, specifierLen); 1248c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1249c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return keepGoing; 1250c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1251c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1252666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool 1253666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs( 1254666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::FormatSpecifier &FS, 1255666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1256666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 1257666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1258666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (argIndex >= NumDataArgs) { 1259666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (FS.usesPositionalArg()) { 1260666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1261666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek diag::warn_printf_positional_arg_exceeds_data_args) 1262666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << (argIndex+1) << NumDataArgs 1263666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1264666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1265666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek else { 1266666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1267666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek diag::warn_printf_insufficient_data_args) 1268666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1269666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1270666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1271666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return false; 1272666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1273666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return true; 1274666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek} 1275666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1276826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===// 1277826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1278826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 1279826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler { 1280826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 1281826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 1282826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1283826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 1284826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 1285826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1286826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1287826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 1288826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek theCall, formatIdx) {} 1289826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1290826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1291826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleInvalidPrintfConversionSpecifier( 1292826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1293826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1294826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1295826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1296826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 1297826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1298826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1299826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1300826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 1301826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1302826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 1303826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalAmount &Amt, 1304826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned type, 1305826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1306826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1307826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1308826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1309826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 1310826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &ignoredFlag, 1311826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1312826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1313826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 1314826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1315826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1316826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 1317826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1318826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1319826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 13206ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 1321c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 1322826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1323c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1324c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 1325c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 1326c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 132726ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek} 132826ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek 1329826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount( 1330826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_format_string::OptionalAmount &Amt, 1331826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned k, const char *startSpecifier, 1332826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 13330d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 13340d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (Amt.hasDataArgument()) { 13350d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (!HasVAListArg) { 13367f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = Amt.getArgIndex(); 13377f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (argIndex >= NumDataArgs) { 1338efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1339efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek diag::warn_printf_asterisk_missing_arg) 1340826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << k << getSpecifierRange(startSpecifier, specifierLen); 13410d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 13420d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 13430d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 13440d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 13454e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 13460d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Type check the data argument. It should be an 'int'. 134731f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // Although not in conformance with C99, we also allow the argument to be 134831f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // an 'unsigned int' as that is a reasonably safe case. GCC also 134931f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // doesn't emit a warning for that case. 13507f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.set(argIndex); 13517f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek const Expr *Arg = getDataArg(argIndex); 13520d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek QualType T = Arg->getType(); 13534e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 13544e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context); 13554e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek assert(ATR.isValid()); 13564e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 13574e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (!ATR.matchesType(S.Context, T)) { 1358efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1359efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek diag::warn_printf_asterisk_wrong_type) 1360efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek << k 13614e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek << ATR.getRepresentativeType(S.Context) << T 1362826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1363d635c5fcc45c952b75743dd2f4c86d6950e4954eTed Kremenek << Arg->getSourceRange(); 13640d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 13650d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 13660d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 13670d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 13680d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 13690d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 13700d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return true; 13710d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek} 13720d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1373e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount( 1374826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1375e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalAmount &Amt, 1376e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned type, 1377e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1378e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 13796ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 13806ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1381e4ee9663168dfb2b4122c768091e30217328c9faTom Care switch (Amt.getHowSpecified()) { 1382e4ee9663168dfb2b4122c768091e30217328c9faTom Care case analyze_printf::OptionalAmount::Constant: 1383e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(Amt.getStart()), 1384e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_optional_amount) 1385e4ee9663168dfb2b4122c768091e30217328c9faTom Care << type 1386e4ee9663168dfb2b4122c768091e30217328c9faTom Care << CS.toString() 1387826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1388826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 1389e4ee9663168dfb2b4122c768091e30217328c9faTom Care Amt.getConstantLength())); 1390e4ee9663168dfb2b4122c768091e30217328c9faTom Care break; 1391e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1392e4ee9663168dfb2b4122c768091e30217328c9faTom Care default: 1393e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(Amt.getStart()), 1394e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_optional_amount) 1395e4ee9663168dfb2b4122c768091e30217328c9faTom Care << type 1396e4ee9663168dfb2b4122c768091e30217328c9faTom Care << CS.toString() 1397826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1398e4ee9663168dfb2b4122c768091e30217328c9faTom Care break; 1399e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1400e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1401e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1402826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1403e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 1404e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1405e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 1406e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about pointless flag with a fixit removal. 14076ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 14086ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1409e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(flag.getPosition()), 1410e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_flag) 1411e4ee9663168dfb2b4122c768091e30217328c9faTom Care << flag.toString() << CS.toString() 1412826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1413826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(flag.getPosition(), 1)); 1414e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1415e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1416e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag( 1417826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1418e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &ignoredFlag, 1419e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 1420e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1421e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 1422e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about ignored flag with a fixit removal. 1423e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(ignoredFlag.getPosition()), 1424e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_ignored_flag) 1425e4ee9663168dfb2b4122c768091e30217328c9faTom Care << ignoredFlag.toString() << flag.toString() 1426826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1427826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange( 1428e4ee9663168dfb2b4122c768091e30217328c9faTom Care ignoredFlag.getPosition(), 1)); 1429e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1430e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1431e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool 1432826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 14335c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek &FS, 1434e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *startSpecifier, 1435e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned specifierLen) { 1436e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 14376ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek using namespace analyze_format_string; 1438efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek using namespace analyze_printf; 14396ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 1440e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1441baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 1442baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 1443baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 1444baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 1445baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1446baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 1447baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Cannot mix-and-match positional and non-positional arguments. 1448baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1449baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek diag::warn_format_mix_positional_nonpositional_args) 1450baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1451baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 1452baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1453efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek } 1454efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 14550d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // First check if the field width, precision, and conversion specifier 14560d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // have matching data arguments. 1457efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 1458efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 14590d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 14600d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 14614e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1462efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 1463efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 14640d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 14650d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 14660d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1467f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek if (!CS.consumesDataArgument()) { 1468f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // FIXME: Technically specifying a precision or field width here 1469f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // makes no sense. Worth issuing a warning at some point. 14700e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek return true; 1471f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek } 14724e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 14737f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Consume the argument. 14747f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = FS.getArgIndex(); 1475e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek if (argIndex < NumDataArgs) { 1476e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // The check to see if the argIndex is valid will come later. 1477e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // We set the bit here because we may exit early from this 1478e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // function if we encounter some other error. 1479e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek CoveredArgs.set(argIndex); 1480e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek } 14817f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek 14827f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Check for using an Objective-C specific conversion specifier 14837f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // in a non-ObjC literal. 14847f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (!IsObjCLiteral && CS.isObjCArg()) { 1485826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 1486826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek specifierLen); 14877f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 14884e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1489e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of field width 1490e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidFieldWidth()) { 149145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 1492e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1493e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1494e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1495e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of precision 1496e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPrecision()) { 1497e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 1498e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1499e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1500e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1501e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check each flag does not conflict with any other component. 150265197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek if (!FS.hasValidThousandsGroupingPrefix()) 150365197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen); 1504e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeadingZeros()) 1505e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 1506e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPlusPrefix()) 1507e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 150845f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (!FS.hasValidSpacePrefix()) 150945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 1510e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidAlternativeForm()) 1511e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 1512e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeftJustified()) 1513e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 1514e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1515e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check that flags are not ignored by another flag 151645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 151745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 151845f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care startSpecifier, specifierLen); 1519e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 1520e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 1521e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1522e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1523e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check the length modifier is valid with the given conversion specifier. 1524e4ee9663168dfb2b4122c768091e30217328c9faTom Care const LengthModifier &LM = FS.getLengthModifier(); 1525e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLengthModifier()) 1526e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(LM.getStart()), 1527649aecf55670682efb2a04a85810eef4d038c527Ted Kremenek diag::warn_format_nonsensical_length) 1528e4ee9663168dfb2b4122c768091e30217328c9faTom Care << LM.toString() << CS.toString() 1529826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1530826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 1531e4ee9663168dfb2b4122c768091e30217328c9faTom Care LM.getLength())); 1532e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1533e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Are we using '%n'? 153435d353b47bce29200b910371dd9b8ba7f3058ab8Ted Kremenek if (CS.getKind() == ConversionSpecifier::nArg) { 1535e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Issue a warning about this being a possible security issue. 1536e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back) 1537826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1538e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek // Continue checking the other format specifiers. 1539e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek return true; 1540e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek } 15415c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek 1542da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek // The remaining checks depend on the data arguments. 1543da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek if (HasVAListArg) 1544da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return true; 15454e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1546666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 1547da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return false; 15484e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 154996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Now type check the data expression that matches the 155096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // format specifier. 155196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const Expr *Ex = getDataArg(argIndex); 155296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context); 155396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) { 155496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Check if we didn't match because of an implicit cast from a 'char' 155596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // or 'short' to an 'int'. This is done because printf is a varargs 155696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // function. 155796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex)) 15584d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ICE->getType() == S.Context.IntTy) { 15594d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek // All further checking is done on the subexpression. 15604d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek Ex = ICE->getSubExpr(); 15614d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ATR.matchesType(S.Context, Ex->getType())) 156296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer return true; 15634d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek } 156496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 156596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // We may be able to offer a FixItHint if it is a supported type. 156696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer PrintfSpecifier fixedFS = FS; 156796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer bool success = fixedFS.fixType(Ex->getType()); 156896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 156996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (success) { 157096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Get the fix string from the fixed format specifier 157196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::SmallString<128> buf; 157296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::raw_svector_ostream os(buf); 157396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer fixedFS.toString(os); 157496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 15759325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // FIXME: getRepresentativeType() perhaps should return a string 15769325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // instead of a QualType to better handle when the representative 15779325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // type is 'wint_t' (which is defined in the system headers). 157896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer S.Diag(getLocationOfByte(CS.getStart()), 157996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer diag::warn_printf_conversion_argument_type_mismatch) 158096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << ATR.getRepresentativeType(S.Context) << Ex->getType() 158196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << getSpecifierRange(startSpecifier, specifierLen) 158296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << Ex->getSourceRange() 158396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << FixItHint::CreateReplacement( 158496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer getSpecifierRange(startSpecifier, specifierLen), 158596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer os.str()); 158696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 158796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer else { 158896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer S.Diag(getLocationOfByte(CS.getStart()), 158996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer diag::warn_printf_conversion_argument_type_mismatch) 159096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << ATR.getRepresentativeType(S.Context) << Ex->getType() 159196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << getSpecifierRange(startSpecifier, specifierLen) 159296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << Ex->getSourceRange(); 159396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 159496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 159596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 1596e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return true; 1597e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1598e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1599826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===// 1600826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1601826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 1602826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler { 1603826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 1604826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 1605826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1606826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 1607826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 1608826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1609826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1610826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 1611826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek theCall, formatIdx) {} 1612826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1613826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 1614826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1615826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1616c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1617c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidScanfConversionSpecifier( 1618c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1619c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 1620c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen); 1621b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 1622b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek void HandleIncompleteScanList(const char *start, const char *end); 1623826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 1624826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1625826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1626b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start, 1627b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek const char *end) { 1628b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek S.Diag(getLocationOfByte(end), diag::warn_scanf_scanlist_incomplete) 1629b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek << getSpecifierRange(start, end - start); 1630b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek} 1631b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 1632c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 1633c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1634c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 1635c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen) { 1636c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 16376ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_scanf::ScanfConversionSpecifier &CS = 1638c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 1639c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1640c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1641c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 1642c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 1643c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 1644c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1645c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1646826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier( 1647826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1648826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1649826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 1650826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1651826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_scanf; 1652826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_format_string; 1653826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 16546ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 1655826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1656baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Handle case where '%' and '*' don't consume an argument. These shouldn't 1657baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // be used to decide if we are using positional arguments consistently. 1658baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 1659baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 1660baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 1661baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 1662baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1663baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 1664baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Cannot mix-and-match positional and non-positional arguments. 1665baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1666baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek diag::warn_format_mix_positional_nonpositional_args) 1667baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1668baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 1669baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1670826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1671826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1672826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Check if the field with is non-zero. 1673826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const OptionalAmount &Amt = FS.getFieldWidth(); 1674826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getHowSpecified() == OptionalAmount::Constant) { 1675826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getConstantAmount() == 0) { 1676826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 1677826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Amt.getConstantLength()); 1678826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1679826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_scanf_nonzero_width) 1680826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << R << FixItHint::CreateRemoval(R); 16817f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 16827f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 1683826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1684826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!FS.consumesDataArgument()) { 1685826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Technically specifying a precision or field width here 1686826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // makes no sense. Worth issuing a warning at some point. 1687826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 1688826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1689826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1690826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Consume the argument. 1691826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned argIndex = FS.getArgIndex(); 1692826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (argIndex < NumDataArgs) { 1693826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The check to see if the argIndex is valid will come later. 1694826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // We set the bit here because we may exit early from this 1695826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // function if we encounter some other error. 1696826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.set(argIndex); 1697826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1698826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 16991e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek // Check the length modifier is valid with the given conversion specifier. 17001e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek const LengthModifier &LM = FS.getLengthModifier(); 17011e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek if (!FS.hasValidLengthModifier()) { 17021e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek S.Diag(getLocationOfByte(LM.getStart()), 17031e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek diag::warn_format_nonsensical_length) 17041e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << LM.toString() << CS.toString() 17051e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 17061e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 17071e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek LM.getLength())); 17081e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek } 17091e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek 1710826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The remaining checks depend on the data arguments. 1711826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (HasVAListArg) 1712826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 1713826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1714666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 1715826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return false; 1716826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1717826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Check that the argument type matches the format specifier. 1718826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1719826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 172007d161f38e708a91486bf1c031d525faebbb249dTed Kremenek} 1721e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1722826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr, 17230e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const Expr *OrigFormatExpr, 17240e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const CallExpr *TheCall, bool HasVAListArg, 1725826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1726826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 1727826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1728e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: is the format string a wide literal? 1729e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek if (FExpr->isWide()) { 1730e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Diag(FExpr->getLocStart(), 1731826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_string_is_wide_literal) 1732e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek << OrigFormatExpr->getSourceRange(); 1733e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 1734e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 1735826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1736e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // Str - The format string. NOTE: this is NOT null-terminated! 17372f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer llvm::StringRef StrRef = FExpr->getString(); 17382f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer const char *Str = StrRef.data(); 17392f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer unsigned StrLen = StrRef.size(); 1740826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1741e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: empty format string? 1742e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek if (StrLen == 0) { 1743826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Diag(FExpr->getLocStart(), diag::warn_empty_format_string) 1744e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek << OrigFormatExpr->getSourceRange(); 1745e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 1746e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 1747826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1748826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (isPrintf) { 1749826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 1750826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek TheCall->getNumArgs() - firstDataArg, 1751826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isa<ObjCStringLiteral>(OrigFormatExpr), Str, 1752826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, TheCall, format_idx); 1753826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1754826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen)) 1755826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 1756826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1757826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek else { 1758826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 1759826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek TheCall->getNumArgs() - firstDataArg, 1760826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isa<ObjCStringLiteral>(OrigFormatExpr), Str, 1761826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, TheCall, format_idx); 1762826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1763826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen)) 1764826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 1765826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1766ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek} 1767ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek 176806de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===// 176906de276fff91264437fa75111ed76de43097e089Ted Kremenek 177026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, llvm::SmallVectorImpl<DeclRefExpr *> &refVars); 177126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidisstatic Expr *EvalAddr(Expr* E, llvm::SmallVectorImpl<DeclRefExpr *> &refVars); 177206de276fff91264437fa75111ed76de43097e089Ted Kremenek 177306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address 177406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable. 177506de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid 177606de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 177706de276fff91264437fa75111ed76de43097e089Ted Kremenek SourceLocation ReturnLoc) { 17781eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 177926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Expr *stackE = 0; 178026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis llvm::SmallVector<DeclRefExpr *, 8> refVars; 17814e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 178226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Perform checking for returned stack addresses, local blocks, 178326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // label addresses or references to temporaries. 178426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (lhsType->isPointerType() || lhsType->isBlockPointerType()) { 178526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalAddr(RetValExp, refVars); 1786ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (lhsType->isReferenceType()) { 178726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalVal(RetValExp, refVars); 178826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 178926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 179026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (stackE == 0) 179126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return; // Nothing suspicious was found. 179226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 179326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceLocation diagLoc; 179426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange diagRange; 179526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (refVars.empty()) { 179626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = stackE->getLocStart(); 179726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = stackE->getSourceRange(); 179826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { 179926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // We followed through a reference variable. 'stackE' contains the 180026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // problematic expression but we will warn at the return statement pointing 180126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // at the reference variable. We will later display the "trail" of 180226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // reference variables using notes. 180326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = refVars[0]->getLocStart(); 180426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = refVars[0]->getSourceRange(); 180526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 180626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 180726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var. 180826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref 180926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_stack_addr) 181026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << DR->getDecl()->getDeclName() << diagRange; 181126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<BlockExpr>(stackE)) { // local block. 181226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::err_ret_local_block) << diagRange; 181326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 181426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 181526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { // local temporary. 181626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref 181726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_local_temp_addr) 181826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << diagRange; 181926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 182026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 182126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Display the "trail" of reference variables that we followed until we 182226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // found the problematic expression using notes. 182326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 182426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 182526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this var binds to another reference var, show the range of the next 182626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // var, otherwise the var binds to the problematic expression, in which case 182726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // show the range of the expression. 182826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange() 182926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : stackE->getSourceRange(); 183026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(VD->getLocation(), diag::note_ref_var_local_bind) 183126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << VD->getDeclName() << range; 183206de276fff91264437fa75111ed76de43097e089Ted Kremenek } 183306de276fff91264437fa75111ed76de43097e089Ted Kremenek} 183406de276fff91264437fa75111ed76de43097e089Ted Kremenek 183506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 183606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// check if the expression in a return statement evaluates to an address 183726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// to a location on the stack, a local block, an address of a label, or a 183826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// reference to local temporary. The recursion is used to traverse the 183906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// AST of the return expression, with recursion backtracking when we 184026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// encounter a subexpression that (1) clearly does not lead to one of the 184126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// above problematic expressions (2) is something we cannot determine leads to 184226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// a problematic expression based on such local checking. 184326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 184426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// Both EvalAddr and EvalVal follow through reference variables to evaluate 184526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// the expression that they point to. Such variables are added to the 184626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 'refVars' vector so that we know what the reference variable "trail" was. 184706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 1848e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// EvalAddr processes expressions that are pointers that are used as 1849e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// references (and not L-values). EvalVal handles all other values. 185026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// At the base case of the recursion is a check for the above problematic 185126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// expressions. 185206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 185306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// This implementation handles: 185406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 185506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer-to-pointer casts 185606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * implicit conversions from array references to pointers 185706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of fields 185806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * arbitrary interplay between "&" and "*" operators 185906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer arithmetic from an address of a stack variable 186006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of an array element where the array is on the stack 186126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidisstatic Expr *EvalAddr(Expr *E, llvm::SmallVectorImpl<DeclRefExpr *> &refVars) { 186226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (E->isTypeDependent()) 186326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 186426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 186506de276fff91264437fa75111ed76de43097e089Ted Kremenek // We should only be called for evaluating pointer expressions. 18660f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall assert((E->getType()->isAnyPointerType() || 1867dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff E->getType()->isBlockPointerType() || 1868a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek E->getType()->isObjCQualifiedIdType()) && 1869fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner "EvalAddr only works on pointers"); 18701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 187106de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 187206de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 187306de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 187406de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 1875fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ParenExprClass: 1876fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Ignore parentheses. 187726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(cast<ParenExpr>(E)->getSubExpr(), refVars); 187826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 187926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::DeclRefExprClass: { 188026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis DeclRefExpr *DR = cast<DeclRefExpr>(E); 188126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 188226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 188326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this is a reference variable, follow through to the expression that 188426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 188526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage() && 188626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis V->getType()->isReferenceType() && V->hasInit()) { 188726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 188826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 188926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(V->getInit(), refVars); 189026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 189126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 189226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 189326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 189406de276fff91264437fa75111ed76de43097e089Ted Kremenek 1895fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::UnaryOperatorClass: { 1896fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // The only unary operator that make sense to handle here 1897fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // is AddrOf. All others don't make sense as pointers. 1898fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner UnaryOperator *U = cast<UnaryOperator>(E); 18991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 19002de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_AddrOf) 190126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(U->getSubExpr(), refVars); 1902fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 1903fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 1904fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 19051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1906fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::BinaryOperatorClass: { 1907fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle pointer arithmetic. All other binary operators are not valid 1908fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // in this context. 1909fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner BinaryOperator *B = cast<BinaryOperator>(E); 19102de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = B->getOpcode(); 19111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 19122de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op != BO_Add && op != BO_Sub) 1913fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 19141eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1915fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner Expr *Base = B->getLHS(); 19163907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 1917fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Determine which argument is the real pointer base. It could be 1918fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // the RHS argument instead of the LHS. 1919fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner if (!Base->getType()->isPointerType()) Base = B->getRHS(); 19201eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1921fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner assert (Base->getType()->isPointerType()); 192226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(Base, refVars); 1923fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 192461f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff 1925fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // For conditional operators we need to see if either the LHS or RHS are 1926fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // valid DeclRefExpr*s. If one of them is valid, we return it. 1927fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ConditionalOperatorClass: { 1928fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner ConditionalOperator *C = cast<ConditionalOperator>(E); 19291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1930fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle the GNU extension for missing LHS. 19319ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (Expr *lhsExpr = C->getLHS()) { 19329ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 19339ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (!lhsExpr->getType()->isVoidType()) 193426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr* LHS = EvalAddr(lhsExpr, refVars)) 19359ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return LHS; 19369ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor } 19379ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor 19389ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 19399ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (C->getRHS()->getType()->isVoidType()) 19409ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return NULL; 194106de276fff91264437fa75111ed76de43097e089Ted Kremenek 194226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(C->getRHS(), refVars); 1943fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 194426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 194526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::BlockExprClass: 1946469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures()) 194726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // local block. 194826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 194926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 195026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::AddrLabelExprClass: 195126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // address of label. 19521eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 195354b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // For casts, we need to handle conversions from arrays to 195454b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // pointer values, and pointer-to-pointer conversions. 195549badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::ImplicitCastExprClass: 19566eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor case Stmt::CStyleCastExprClass: 195749badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXFunctionalCastExprClass: { 19580835a3cdeefe714b4959d31127ea155e56393125Argyrios Kyrtzidis Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 195954b5274f2c190331438375ad114dad12ae098b57Ted Kremenek QualType T = SubExpr->getType(); 19601eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1961dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (SubExpr->getType()->isPointerType() || 1962dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isBlockPointerType() || 1963dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isObjCQualifiedIdType()) 196426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(SubExpr, refVars); 196554b5274f2c190331438375ad114dad12ae098b57Ted Kremenek else if (T->isArrayType()) 196626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(SubExpr, refVars); 1967fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 196854b5274f2c190331438375ad114dad12ae098b57Ted Kremenek return 0; 1969fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 19701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1971fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // C++ casts. For dynamic casts, static casts, and const casts, we 1972fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // are always converting from a pointer-to-pointer, so we just blow 197349badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // through the cast. In the case the dynamic cast doesn't fail (and 197449badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // return NULL), we take the conservative route and report cases 1975fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // where we return the address of a stack variable. For Reinterpre 197649badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // FIXME: The comment about is wrong; we're not always converting 197749badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // from pointer to pointer. I'm guessing that this code should also 19781eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // handle references to objects. 19791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXStaticCastExprClass: 19801eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXDynamicCastExprClass: 198149badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXConstCastExprClass: 198249badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXReinterpretCastExprClass: { 198349badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr(); 1984dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (S->getType()->isPointerType() || S->getType()->isBlockPointerType()) 198526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(S, refVars); 198606de276fff91264437fa75111ed76de43097e089Ted Kremenek else 198706de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 1988fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 19891eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1990fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Everything else: we simply don't reason about them. 1991fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner default: 1992fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 199306de276fff91264437fa75111ed76de43097e089Ted Kremenek } 199406de276fff91264437fa75111ed76de43097e089Ted Kremenek} 19951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 199606de276fff91264437fa75111ed76de43097e089Ted Kremenek 199706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalVal - This function is complements EvalAddr in the mutual recursion. 199806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// See the comments for EvalAddr for more details. 199926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, llvm::SmallVectorImpl<DeclRefExpr *> &refVars) { 200068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo { 2001e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // We should only be called for evaluating non-pointer expressions, or 2002e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // expressions with a pointer type that are not used as references but instead 2003e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // are l-values (e.g., DeclRefExpr with a pointer type). 20041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 200506de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 200606de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 200706de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 200806de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 200968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ImplicitCastExprClass: { 201068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 20115baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall if (IE->getValueKind() == VK_LValue) { 201268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = IE->getSubExpr(); 201368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 201468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 201568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek return NULL; 201668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 201768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek 2018a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor case Stmt::DeclRefExprClass: { 201926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // When we hit a DeclRefExpr we are looking at code that refers to a 202026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // variable's name. If it's not a reference variable we check if it has 202126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // local storage within the function, and if so, return the expression. 202206de276fff91264437fa75111ed76de43097e089Ted Kremenek DeclRefExpr *DR = cast<DeclRefExpr>(E); 20231eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 202406de276fff91264437fa75111ed76de43097e089Ted Kremenek if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 202526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage()) { 202626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!V->getType()->isReferenceType()) 202726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return DR; 202826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 202926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Reference variable, follow through to the expression that 203026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 203126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasInit()) { 203226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 203326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 203426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(V->getInit(), refVars); 203526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 203626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 20371eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 203806de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 203906de276fff91264437fa75111ed76de43097e089Ted Kremenek } 20401eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 204168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ParenExprClass: { 204206de276fff91264437fa75111ed76de43097e089Ted Kremenek // Ignore parentheses. 204368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = cast<ParenExpr>(E)->getSubExpr(); 204468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 204568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 20461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 204706de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::UnaryOperatorClass: { 204806de276fff91264437fa75111ed76de43097e089Ted Kremenek // The only unary operator that make sense to handle here 204906de276fff91264437fa75111ed76de43097e089Ted Kremenek // is Deref. All others don't resolve to a "name." This includes 205006de276fff91264437fa75111ed76de43097e089Ted Kremenek // handling all sorts of rvalues passed to a unary operator. 205106de276fff91264437fa75111ed76de43097e089Ted Kremenek UnaryOperator *U = cast<UnaryOperator>(E); 20521eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 20532de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_Deref) 205426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(U->getSubExpr(), refVars); 205506de276fff91264437fa75111ed76de43097e089Ted Kremenek 205606de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 205706de276fff91264437fa75111ed76de43097e089Ted Kremenek } 20581eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 205906de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ArraySubscriptExprClass: { 206006de276fff91264437fa75111ed76de43097e089Ted Kremenek // Array subscripts are potential references to data on the stack. We 206106de276fff91264437fa75111ed76de43097e089Ted Kremenek // retrieve the DeclRefExpr* for the array variable if it indeed 206206de276fff91264437fa75111ed76de43097e089Ted Kremenek // has local storage. 206326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars); 206406de276fff91264437fa75111ed76de43097e089Ted Kremenek } 20651eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 206606de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ConditionalOperatorClass: { 206706de276fff91264437fa75111ed76de43097e089Ted Kremenek // For conditional operators we need to see if either the LHS or RHS are 206826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // non-NULL Expr's. If one is non-NULL, we return it. 206906de276fff91264437fa75111ed76de43097e089Ted Kremenek ConditionalOperator *C = cast<ConditionalOperator>(E); 207006de276fff91264437fa75111ed76de43097e089Ted Kremenek 20713907323dd6665c0c4e383435cb145233f4533406Anders Carlsson // Handle the GNU extension for missing LHS. 20723907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (Expr *lhsExpr = C->getLHS()) 207326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr *LHS = EvalVal(lhsExpr, refVars)) 20743907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return LHS; 20753907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 207626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(C->getRHS(), refVars); 207706de276fff91264437fa75111ed76de43097e089Ted Kremenek } 20781eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 207906de276fff91264437fa75111ed76de43097e089Ted Kremenek // Accesses to members are potential references to data on the stack. 208083f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor case Stmt::MemberExprClass: { 208106de276fff91264437fa75111ed76de43097e089Ted Kremenek MemberExpr *M = cast<MemberExpr>(E); 20821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 208306de276fff91264437fa75111ed76de43097e089Ted Kremenek // Check for indirect access. We only want direct field accesses. 2084a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->isArrow()) 2085a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return NULL; 2086a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 2087a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // Check whether the member type is itself a reference, in which case 2088a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // we're not going to refer to the member, but to what the member refers to. 2089a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->getMemberDecl()->getType()->isReferenceType()) 209006de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 2091a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 209226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(M->getBase(), refVars); 209306de276fff91264437fa75111ed76de43097e089Ted Kremenek } 20941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 209506de276fff91264437fa75111ed76de43097e089Ted Kremenek default: 209626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Check that we don't return or take the address of a reference to a 209726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // temporary. This is only useful in C++. 209826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!E->isTypeDependent() && E->isRValue()) 209926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; 210026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 210126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Everything else: we simply don't reason about them. 210206de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 210306de276fff91264437fa75111ed76de43097e089Ted Kremenek } 210468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true); 210506de276fff91264437fa75111ed76de43097e089Ted Kremenek} 2106588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2107588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 2108588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2109588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==. 2110588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely 2111588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended. 2112588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenekvoid Sema::CheckFloatComparison(SourceLocation loc, Expr* lex, Expr *rex) { 2113588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek bool EmitWarning = true; 21141eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2115f6a1648197562e0b133440d612d9af297d0a86ccJohn McCall Expr* LeftExprSansParen = lex->IgnoreParenImpCasts(); 2116f6a1648197562e0b133440d612d9af297d0a86ccJohn McCall Expr* RightExprSansParen = rex->IgnoreParenImpCasts(); 2117588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2118588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Special case: check for x == x (which is OK). 2119588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Do not emit warnings for such cases. 2120588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 2121588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 2122588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DRL->getDecl() == DRR->getDecl()) 2123588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 21241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 21251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 21261b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // Special case: check for comparisons against literals that can be exactly 21271b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // represented by APFloat. In such cases, do not emit a warning. This 21281b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // is a heuristic: often comparison against such literals are used to 21291b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // detect if a value in a variable has not changed. This clearly can 21301b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // lead to false negatives. 21311b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (EmitWarning) { 21321b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 21331b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLL->isExact()) 21341b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 2135ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else 21361b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){ 21371b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLR->isExact()) 21381b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 21391b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 21401b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 21411eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2142588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Check for comparisons with builtin types. 21430eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 2144588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 21453c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor if (CL->isBuiltinCall(Context)) 2146588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 21471eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 21480eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 2149588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 21503c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor if (CR->isBuiltinCall(Context)) 2151588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 21521eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2153588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Emit the diagnostic. 2154588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (EmitWarning) 2155fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(loc, diag::warn_floatingpoint_eq) 2156fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << lex->getSourceRange() << rex->getSourceRange(); 2157588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek} 2158ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2159f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 2160f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 2161ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2162f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace { 2163ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2164f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued 2165f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression. 2166f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange { 2167f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// The number of bits active in the int. 2168f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned Width; 2169ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2170f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// True if the int is known not to have negative values. 2171f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool NonNegative; 217251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2173f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange(unsigned Width, bool NonNegative) 2174f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : Width(Width), NonNegative(NonNegative) 2175f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall {} 217651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 21771844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of the bool type. 2178f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall static IntRange forBoolType() { 2179f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(1, true); 2180f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 218151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 21821844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of the given integral type. 21831844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfType(ASTContext &C, QualType T) { 21841844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return forValueOfCanonicalType(C, 21851844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T->getCanonicalTypeInternal().getTypePtr()); 218651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 218751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 21881844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of a canonical integral type. 21891844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 2190f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(T->isCanonicalUnqualified()); 219151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2192f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 2193f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = VT->getElementType().getTypePtr(); 2194f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 2195f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = CT->getElementType().getTypePtr(); 2196323ed74658bc8375278eabf074b4777458376540John McCall 2197091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // For enum types, use the known bit width of the enumerators. 2198323ed74658bc8375278eabf074b4777458376540John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) { 2199323ed74658bc8375278eabf074b4777458376540John McCall EnumDecl *Enum = ET->getDecl(); 2200091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Enum->isDefinition()) 2201091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return IntRange(C.getIntWidth(QualType(T, 0)), false); 2202091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2203323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumPositive = Enum->getNumPositiveBits(); 2204323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumNegative = Enum->getNumNegativeBits(); 2205323ed74658bc8375278eabf074b4777458376540John McCall 2206323ed74658bc8375278eabf074b4777458376540John McCall return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0); 2207323ed74658bc8375278eabf074b4777458376540John McCall } 220851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2209f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const BuiltinType *BT = cast<BuiltinType>(T); 2210f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(BT->isInteger()); 221151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2212f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 221351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 221451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 22151844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the "target" range of a canonical integral type, i.e. 22161844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// the range of values expressible in the type. 22171844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// 22181844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// This matches forValueOfCanonicalType except that enums have the 22191844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// full range of their type, not the range of their enumerators. 22201844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 22211844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(T->isCanonicalUnqualified()); 22221844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 22231844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 22241844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = VT->getElementType().getTypePtr(); 22251844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 22261844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = CT->getElementType().getTypePtr(); 22271844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) 22281844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = ET->getDecl()->getIntegerType().getTypePtr(); 22291844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 22301844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall const BuiltinType *BT = cast<BuiltinType>(T); 22311844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(BT->isInteger()); 22321844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 22331844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 22341844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall } 22351844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 22361844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the supremum of two ranges: i.e. their conservative merge. 2237c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange join(IntRange L, IntRange R) { 2238f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(std::max(L.Width, R.Width), 223960fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative && R.NonNegative); 224060fad45739b764886f707bd204eae9ecce6db1f2John McCall } 224160fad45739b764886f707bd204eae9ecce6db1f2John McCall 22421844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the infinum of two ranges: i.e. their aggressive merge. 2243c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange meet(IntRange L, IntRange R) { 224460fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange(std::min(L.Width, R.Width), 224560fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative || R.NonNegative); 224651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 2247f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}; 224851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2249f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) { 2250f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isSigned() && value.isNegative()) 2251f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getMinSignedBits(), false); 225251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2253f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.getBitWidth() > MaxWidth) 22549f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad value = value.trunc(MaxWidth); 225551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2256f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // isNonNegative() just checks the sign bit without considering 2257f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // signedness. 2258f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getActiveBits(), true); 225951313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 226051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 22610acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCallIntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 2262f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned MaxWidth) { 2263f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isInt()) 2264f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetValueRange(C, result.getInt(), MaxWidth); 226551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2266f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isVector()) { 22670acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 22680acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 22690acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 22700acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall R = IntRange::join(R, El); 22710acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall } 2272f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return R; 227351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 227451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2275f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isComplexInt()) { 2276f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 2277f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 2278f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(R, I); 2279f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2280f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2281f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // This can happen with lossless casts to intptr_t of "based" lvalues. 2282f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume it might use arbitrary bits. 22830acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // FIXME: The only reason we need to pass the type in here is to get 22840acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // the sign right on this one case. It would be nice if APValue 22850acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // preserved this. 2286f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(result.isLValue()); 22870acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall return IntRange(MaxWidth, Ty->isUnsignedIntegerType()); 228851313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 228951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2290f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the 2291f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take. 2292f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 2293f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated 2294f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 229551313c39c84407dd6a323be99a8c322bf8d052a9John McCall E = E->IgnoreParens(); 229651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2297f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Try a full evaluation first. 2298f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall Expr::EvalResult result; 2299f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (E->Evaluate(result, C)) 23000acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall return GetValueRange(C, result.Val, E->getType(), MaxWidth); 230151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2302f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // I think we only want to look through implicit casts here; if the 2303f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // user has an explicit widening cast, we should treat the value as 2304f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // being of the new, wider type. 2305f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 23062de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (CE->getCastKind() == CK_NoOp) 2307f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CE->getSubExpr(), MaxWidth); 230851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 23091844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType()); 231051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 23112de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 231260fad45739b764886f707bd204eae9ecce6db1f2John McCall 2313f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume that non-integer casts can span the full range of the type. 231460fad45739b764886f707bd204eae9ecce6db1f2John McCall if (!isIntegerCast) 2315f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 231651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2317f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange SubRange 2318f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall = GetExprRange(C, CE->getSubExpr(), 2319f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall std::min(MaxWidth, OutputTypeRange.Width)); 232051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2321f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Bail out if the subexpr's range is as wide as the cast type. 2322f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SubRange.Width >= OutputTypeRange.Width) 2323f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 232451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2325f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, we take the smaller width, and we're non-negative if 2326f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // either the output type or the subexpr is. 2327f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(SubRange.Width, 2328f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall SubRange.NonNegative || OutputTypeRange.NonNegative); 2329f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2330f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2331f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 2332f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // If we can fold the condition, just take that operand. 2333f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool CondResult; 2334f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 2335f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CondResult ? CO->getTrueExpr() 2336f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : CO->getFalseExpr(), 2337f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall MaxWidth); 2338f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2339f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, conservatively merge. 2340f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 2341f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 2342f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 234351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 234451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 234551313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 234651313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (BO->getOpcode()) { 234751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2348f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Boolean-valued operations are single-bit and positive. 23492de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LAnd: 23502de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LOr: 23512de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LT: 23522de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GT: 23532de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LE: 23542de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GE: 23552de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_EQ: 23562de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_NE: 2357f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 235851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2359c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall // The type of these compound assignments is the type of the LHS, 2360c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall // so the RHS is not necessarily an integer. 23612de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_MulAssign: 23622de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_DivAssign: 23632de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_RemAssign: 23642de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AddAssign: 23652de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_SubAssign: 23661844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 2367c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall 236851313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 23692de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemD: 23702de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemI: 23711844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 237251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 237360fad45739b764886f707bd204eae9ecce6db1f2John McCall // Bitwise-and uses the *infinum* of the two source ranges. 23742de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_And: 23752de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AndAssign: 237660fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 237760fad45739b764886f707bd204eae9ecce6db1f2John McCall GetExprRange(C, BO->getRHS(), MaxWidth)); 237860fad45739b764886f707bd204eae9ecce6db1f2John McCall 237951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Left shift gets black-listed based on a judgement call. 23802de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shl: 23813aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // ...except that we want to treat '1 << (blah)' as logically 23823aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // positive. It's an important idiom. 23833aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (IntegerLiteral *I 23843aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 23853aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (I->getValue() == 1) { 23861844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange R = IntRange::forValueOfType(C, E->getType()); 23873aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall return IntRange(R.Width, /*NonNegative*/ true); 23883aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 23893aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 23903aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // fallthrough 23913aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall 23922de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShlAssign: 23931844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 239451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 239560fad45739b764886f707bd204eae9ecce6db1f2John McCall // Right shift by a constant can narrow its left argument. 23962de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shr: 23972de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShrAssign: { 239860fad45739b764886f707bd204eae9ecce6db1f2John McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 239960fad45739b764886f707bd204eae9ecce6db1f2John McCall 240060fad45739b764886f707bd204eae9ecce6db1f2John McCall // If the shift amount is a positive constant, drop the width by 240160fad45739b764886f707bd204eae9ecce6db1f2John McCall // that much. 240260fad45739b764886f707bd204eae9ecce6db1f2John McCall llvm::APSInt shift; 240360fad45739b764886f707bd204eae9ecce6db1f2John McCall if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 240460fad45739b764886f707bd204eae9ecce6db1f2John McCall shift.isNonNegative()) { 240560fad45739b764886f707bd204eae9ecce6db1f2John McCall unsigned zext = shift.getZExtValue(); 240660fad45739b764886f707bd204eae9ecce6db1f2John McCall if (zext >= L.Width) 240760fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width = (L.NonNegative ? 0 : 1); 240860fad45739b764886f707bd204eae9ecce6db1f2John McCall else 240960fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width -= zext; 241060fad45739b764886f707bd204eae9ecce6db1f2John McCall } 241160fad45739b764886f707bd204eae9ecce6db1f2John McCall 241260fad45739b764886f707bd204eae9ecce6db1f2John McCall return L; 241360fad45739b764886f707bd204eae9ecce6db1f2John McCall } 241460fad45739b764886f707bd204eae9ecce6db1f2John McCall 241560fad45739b764886f707bd204eae9ecce6db1f2John McCall // Comma acts as its right operand. 24162de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Comma: 2417f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 2418f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 241960fad45739b764886f707bd204eae9ecce6db1f2John McCall // Black-list pointer subtractions. 24202de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Sub: 242151313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BO->getLHS()->getType()->isPointerType()) 24221844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 242351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // fallthrough 24244e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 242551313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 2426f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall break; 242751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 2428f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2429f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Treat every other operator as if it were closed on the 2430f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // narrowest type that encompasses both operands. 2431f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 2432f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 2433f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 243451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 243551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 243651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 243751313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (UO->getOpcode()) { 243851313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Boolean-valued operations are white-listed. 24392de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_LNot: 2440f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 244151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 244251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 24432de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_Deref: 24442de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_AddrOf: // should be impossible 24451844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 244651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 244751313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 2448f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, UO->getSubExpr(), MaxWidth); 244951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 245051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 24518ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor 24528ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor if (dyn_cast<OffsetOfExpr>(E)) { 24531844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange::forValueOfType(C, E->getType()); 24548ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor } 245551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2456f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall FieldDecl *BitField = E->getBitField(); 2457f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (BitField) { 2458f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APSInt BitWidthAP = BitField->getBitWidth()->EvaluateAsInt(C); 2459f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned BitWidth = BitWidthAP.getZExtValue(); 246051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2461f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(BitWidth, BitField->getType()->isUnsignedIntegerType()); 2462f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2463f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 24641844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 2465f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 2466f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2467323ed74658bc8375278eabf074b4777458376540John McCallIntRange GetExprRange(ASTContext &C, Expr *E) { 2468323ed74658bc8375278eabf074b4777458376540John McCall return GetExprRange(C, E, C.getIntWidth(E->getType())); 2469323ed74658bc8375278eabf074b4777458376540John McCall} 2470323ed74658bc8375278eabf074b4777458376540John McCall 2471f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 2472f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 2473f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 2474f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const llvm::APFloat &value, 2475f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 2476f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 2477f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APFloat truncated = value; 2478f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2479f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool ignored; 2480f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 2481f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 2482f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2483f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return truncated.bitwiseIsEqual(value); 248451313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 248551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2486f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 2487f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 2488f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 2489f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 2490f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number). 2491f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const APValue &value, 2492f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 2493f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 2494f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isFloat()) 2495f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 2496f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2497f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isVector()) { 2498f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 2499f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 2500f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return false; 2501f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return true; 2502f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2503f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2504f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(value.isComplexFloat()); 2505f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 2506f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 2507f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 2508f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2509b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 2510323ed74658bc8375278eabf074b4777458376540John McCall 2511e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) { 2512e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where we are comparing against an enum constant. 2513e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (const DeclRefExpr *DR = 2514e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 2515e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (isa<EnumConstantDecl>(DR->getDecl())) 2516e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 2517e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 2518e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where the '0' value is expanded from a macro. 2519e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (E->getLocStart().isMacroID()) 2520e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 2521e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 2522323ed74658bc8375278eabf074b4777458376540John McCall llvm::APSInt Value; 2523323ed74658bc8375278eabf074b4777458376540John McCall return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 2524323ed74658bc8375278eabf074b4777458376540John McCall} 2525323ed74658bc8375278eabf074b4777458376540John McCall 2526372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) { 2527372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall // Strip off implicit integral promotions. 2528372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 252963b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis if (ICE->getCastKind() != CK_IntegralCast && 253063b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis ICE->getCastKind() != CK_NoOp) 2531372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall break; 253263b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis E = ICE->getSubExpr(); 2533372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall } 2534372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 2535372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall return E->getType()->isEnumeralType(); 2536372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall} 2537372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 2538323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 25392de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = E->getOpcode(); 254014af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor if (E->isValueDependent()) 254114af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor return; 254214af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor 25432de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op == BO_LT && IsZero(S, E->getRHS())) { 2544323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 2545372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "< 0" << "false" << HasEnumType(E->getLHS()) 2546323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 25472de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GE && IsZero(S, E->getRHS())) { 2548323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 2549372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << ">= 0" << "true" << HasEnumType(E->getLHS()) 2550323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 25512de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GT && IsZero(S, E->getLHS())) { 2552323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 2553372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 >" << "false" << HasEnumType(E->getRHS()) 2554323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 25552de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_LE && IsZero(S, E->getLHS())) { 2556323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 2557372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 <=" << "true" << HasEnumType(E->getRHS()) 2558323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 2559323ed74658bc8375278eabf074b4777458376540John McCall } 2560323ed74658bc8375278eabf074b4777458376540John McCall} 2561323ed74658bc8375278eabf074b4777458376540John McCall 2562323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison. Implements the 2563323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison. 2564323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 2565b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 2566b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 2567323ed74658bc8375278eabf074b4777458376540John McCall} 2568f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2569ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare. 2570ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// 2571ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \param lex the left-hand expression 2572ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \param rex the right-hand expression 2573ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \param OpLoc the location of the joining operator 2574d1b47bf17fde73fac67d8664bd65273742c00ecdJohn McCall/// \param BinOpc binary opcode or 0 2575323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeComparison(Sema &S, BinaryOperator *E) { 2576323ed74658bc8375278eabf074b4777458376540John McCall // The type the comparison is being performed in. 2577323ed74658bc8375278eabf074b4777458376540John McCall QualType T = E->getLHS()->getType(); 2578323ed74658bc8375278eabf074b4777458376540John McCall assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 2579323ed74658bc8375278eabf074b4777458376540John McCall && "comparison with mismatched types"); 2580323ed74658bc8375278eabf074b4777458376540John McCall 2581323ed74658bc8375278eabf074b4777458376540John McCall // We don't do anything special if this isn't an unsigned integral 2582323ed74658bc8375278eabf074b4777458376540John McCall // comparison: we're only interested in integral comparisons, and 2583323ed74658bc8375278eabf074b4777458376540John McCall // signed comparisons only happen in cases we don't care to warn about. 25843e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // 25853e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // We also don't care about value-dependent expressions or expressions 25863e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // whose result is a constant. 25873e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor if (!T->hasUnsignedIntegerRepresentation() 25883e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor || E->isValueDependent() || E->isIntegerConstantExpr(S.Context)) 2589323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 2590323ed74658bc8375278eabf074b4777458376540John McCall 2591323ed74658bc8375278eabf074b4777458376540John McCall Expr *lex = E->getLHS()->IgnoreParenImpCasts(); 2592323ed74658bc8375278eabf074b4777458376540John McCall Expr *rex = E->getRHS()->IgnoreParenImpCasts(); 2593323ed74658bc8375278eabf074b4777458376540John McCall 2594323ed74658bc8375278eabf074b4777458376540John McCall // Check to see if one of the (unmodified) operands is of different 2595323ed74658bc8375278eabf074b4777458376540John McCall // signedness. 2596323ed74658bc8375278eabf074b4777458376540John McCall Expr *signedOperand, *unsignedOperand; 2597f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (lex->getType()->hasSignedIntegerRepresentation()) { 2598f60946222721d9ba3c059563935c17b84703187aDouglas Gregor assert(!rex->getType()->hasSignedIntegerRepresentation() && 2599323ed74658bc8375278eabf074b4777458376540John McCall "unsigned comparison between two signed integer expressions?"); 2600323ed74658bc8375278eabf074b4777458376540John McCall signedOperand = lex; 2601323ed74658bc8375278eabf074b4777458376540John McCall unsignedOperand = rex; 2602f60946222721d9ba3c059563935c17b84703187aDouglas Gregor } else if (rex->getType()->hasSignedIntegerRepresentation()) { 2603323ed74658bc8375278eabf074b4777458376540John McCall signedOperand = rex; 2604323ed74658bc8375278eabf074b4777458376540John McCall unsignedOperand = lex; 2605ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } else { 2606323ed74658bc8375278eabf074b4777458376540John McCall CheckTrivialUnsignedComparison(S, E); 2607323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 2608ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } 2609ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2610323ed74658bc8375278eabf074b4777458376540John McCall // Otherwise, calculate the effective range of the signed operand. 2611323ed74658bc8375278eabf074b4777458376540John McCall IntRange signedRange = GetExprRange(S.Context, signedOperand); 2612f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2613323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and analyze implicit conversions in the operands. Note 2614323ed74658bc8375278eabf074b4777458376540John McCall // that we skip the implicit conversions on both sides. 2615b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, lex, E->getOperatorLoc()); 2616b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, rex, E->getOperatorLoc()); 2617ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2618323ed74658bc8375278eabf074b4777458376540John McCall // If the signed range is non-negative, -Wsign-compare won't fire, 2619323ed74658bc8375278eabf074b4777458376540John McCall // but we should still check for comparisons which are always true 2620323ed74658bc8375278eabf074b4777458376540John McCall // or false. 2621323ed74658bc8375278eabf074b4777458376540John McCall if (signedRange.NonNegative) 2622323ed74658bc8375278eabf074b4777458376540John McCall return CheckTrivialUnsignedComparison(S, E); 2623ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2624ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // For (in)equality comparisons, if the unsigned operand is a 2625ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // constant which cannot collide with a overflowed signed operand, 2626ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // then reinterpreting the signed operand as unsigned will not 2627ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // change the result of the comparison. 2628323ed74658bc8375278eabf074b4777458376540John McCall if (E->isEqualityOp()) { 2629323ed74658bc8375278eabf074b4777458376540John McCall unsigned comparisonWidth = S.Context.getIntWidth(T); 2630323ed74658bc8375278eabf074b4777458376540John McCall IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 2631323ed74658bc8375278eabf074b4777458376540John McCall 2632323ed74658bc8375278eabf074b4777458376540John McCall // We should never be unable to prove that the unsigned operand is 2633323ed74658bc8375278eabf074b4777458376540John McCall // non-negative. 2634323ed74658bc8375278eabf074b4777458376540John McCall assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 2635ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2636323ed74658bc8375278eabf074b4777458376540John McCall if (unsignedRange.Width < comparisonWidth) 2637323ed74658bc8375278eabf074b4777458376540John McCall return; 2638323ed74658bc8375278eabf074b4777458376540John McCall } 2639323ed74658bc8375278eabf074b4777458376540John McCall 2640323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison) 2641323ed74658bc8375278eabf074b4777458376540John McCall << lex->getType() << rex->getType() 2642323ed74658bc8375278eabf074b4777458376540John McCall << lex->getSourceRange() << rex->getSourceRange(); 2643ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall} 2644ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 264515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield. 264615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// 264715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt. 264815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallbool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 264915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall SourceLocation InitLoc) { 265015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall assert(Bitfield->isBitField()); 265115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Bitfield->isInvalidDecl()) 265215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 265315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 265491b6014876e9186f968f74a8975ab8fc08ef1b68John McCall // White-list bool bitfields. 265591b6014876e9186f968f74a8975ab8fc08ef1b68John McCall if (Bitfield->getType()->isBooleanType()) 265691b6014876e9186f968f74a8975ab8fc08ef1b68John McCall return false; 265791b6014876e9186f968f74a8975ab8fc08ef1b68John McCall 265846ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor // Ignore value- or type-dependent expressions. 265946ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor if (Bitfield->getBitWidth()->isValueDependent() || 266046ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Bitfield->getBitWidth()->isTypeDependent() || 266146ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isValueDependent() || 266246ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isTypeDependent()) 266346ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor return false; 266446ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor 266515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *OriginalInit = Init->IgnoreParenImpCasts(); 266615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 266715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall llvm::APSInt Width(32); 266815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr::EvalResult InitValue; 266915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (!Bitfield->getBitWidth()->isIntegerConstantExpr(Width, S.Context) || 267091b6014876e9186f968f74a8975ab8fc08ef1b68John McCall !OriginalInit->Evaluate(InitValue, S.Context) || 267115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall !InitValue.Val.isInt()) 267215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 267315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 267415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall const llvm::APSInt &Value = InitValue.Val.getInt(); 267515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned OriginalWidth = Value.getBitWidth(); 267615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned FieldWidth = Width.getZExtValue(); 267715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 267815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (OriginalWidth <= FieldWidth) 267915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 268015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 26819f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad llvm::APSInt TruncatedValue = Value.trunc(FieldWidth); 268215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 268315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // It's fairly common to write values into signed bitfields 268415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // that, if sign-extended, would end up becoming a different 268515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // value. We don't want to warn about that. 268615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value.isSigned() && Value.isNegative()) 26879f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad TruncatedValue = TruncatedValue.sext(OriginalWidth); 268815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall else 26899f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad TruncatedValue = TruncatedValue.zext(OriginalWidth); 269015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 269115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value == TruncatedValue) 269215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 269315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 269415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyValue = Value.toString(10); 269515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyTrunc = TruncatedValue.toString(10); 269615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 269715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 269815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << PrettyValue << PrettyTrunc << OriginalInit->getType() 269915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << Init->getSourceRange(); 270015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 270115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return true; 270215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 270315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 2704beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy 2705beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations. 2706beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCallvoid AnalyzeAssignment(Sema &S, BinaryOperator *E) { 2707beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Just recurse on the LHS. 2708beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 2709beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 2710beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // We want to recurse on the RHS as normal unless we're assigning to 2711beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // a bitfield. 2712beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (FieldDecl *Bitfield = E->getLHS()->getBitField()) { 271315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 271415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc())) { 271515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // Recurse, ignoring any implicit conversions on the RHS. 271615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 271715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc()); 2718beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 2719beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 2720beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 2721beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 2722beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall} 2723beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 272451313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 2725b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid DiagnoseImpCast(Sema &S, Expr *E, QualType T, SourceLocation CContext, 2726b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall unsigned diag) { 2727b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall S.Diag(E->getExprLoc(), diag) 2728b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall << E->getType() << T << E->getSourceRange() << SourceRange(CContext); 272951313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 273051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2731091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 2732091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Range.Width) return "0"; 2733091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2734091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt ValueInRange = Value; 2735091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.setIsSigned(!Range.NonNegative); 27369f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad ValueInRange = ValueInRange.trunc(Range.Width); 2737091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return ValueInRange.toString(10); 2738091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall} 2739091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2740323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T, 2741b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool *ICContext = 0) { 2742323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) return; 274351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2744323ed74658bc8375278eabf074b4777458376540John McCall const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 2745323ed74658bc8375278eabf074b4777458376540John McCall const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 2746323ed74658bc8375278eabf074b4777458376540John McCall if (Source == Target) return; 2747323ed74658bc8375278eabf074b4777458376540John McCall if (Target->isDependentType()) return; 274851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2749b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // If the conversion context location is invalid or instantiated 2750b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // from a system macro, don't complain. 2751b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall if (CC.isInvalid() || 2752b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall (CC.isMacroID() && S.Context.getSourceManager().isInSystemHeader( 2753b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall S.Context.getSourceManager().getSpellingLoc(CC)))) 2754b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return; 2755b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 275651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Never diagnose implicit casts to bool. 275751313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (Target->isSpecificBuiltinType(BuiltinType::Bool)) 275851313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 275951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 276051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip vector types. 276151313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<VectorType>(Source)) { 276251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (!isa<VectorType>(Target)) 2763b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 276451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 276551313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 276651313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 276751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 276851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 276951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip complex types. 277051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<ComplexType>(Source)) { 277151313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (!isa<ComplexType>(Target)) 2772b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 277351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 277451313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 277551313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 277651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 277751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 277851313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 277951313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 278051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 278151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the source is floating point... 278251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT && SourceBT->isFloatingPoint()) { 278351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...and the target is floating point... 278451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (TargetBT && TargetBT->isFloatingPoint()) { 278551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...then warn if we're dropping FP rank. 278651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 278751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Builtin FP kinds are ordered by increasing FP rank. 278851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT->getKind() > TargetBT->getKind()) { 278951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Don't warn about float constants that are precisely 279051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // representable in the target type. 279151313c39c84407dd6a323be99a8c322bf8d052a9John McCall Expr::EvalResult result; 2792323ed74658bc8375278eabf074b4777458376540John McCall if (E->Evaluate(result, S.Context)) { 279351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Value might be a float, a float vector, or a float complex. 279451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (IsSameFloatAfterCast(result.Val, 2795323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 2796323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 279751313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 279851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 279951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2800b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 280151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 280251313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 280351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 280451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 280551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the target is integral, always warn. 2806a5b9332418f25338f118358e27303cd510d54107Chandler Carruth if ((TargetBT && TargetBT->isInteger())) { 2807a5b9332418f25338f118358e27303cd510d54107Chandler Carruth Expr *InnerE = E->IgnoreParenImpCasts(); 2808a5b9332418f25338f118358e27303cd510d54107Chandler Carruth if (FloatingLiteral *LiteralExpr = dyn_cast<FloatingLiteral>(InnerE)) { 2809a5b9332418f25338f118358e27303cd510d54107Chandler Carruth DiagnoseImpCast(S, LiteralExpr, T, CC, 2810a5b9332418f25338f118358e27303cd510d54107Chandler Carruth diag::warn_impcast_literal_float_to_integer); 2811a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } else { 2812a5b9332418f25338f118358e27303cd510d54107Chandler Carruth DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 2813a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 2814a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 281551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 281651313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 281751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 281851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2819f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!Source->isIntegerType() || !Target->isIntegerType()) 282051313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 282151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2822323ed74658bc8375278eabf074b4777458376540John McCall IntRange SourceRange = GetExprRange(S.Context, E); 28231844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 282451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2825f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width > TargetRange.Width) { 2826091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // If the source is a constant, use a default-on diagnostic. 2827091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // TODO: this should happen for bitfield stores, too. 2828091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt Value(32); 2829091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (E->isIntegerConstantExpr(Value, S.Context)) { 2830091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettySourceValue = Value.toString(10); 2831091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 2832091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2833091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall S.Diag(E->getExprLoc(), diag::warn_impcast_integer_precision_constant) 2834091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall << PrettySourceValue << PrettyTargetValue 2835091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall << E->getType() << T << E->getSourceRange() << clang::SourceRange(CC); 2836091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return; 2837091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall } 2838091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 283951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // People want to build with -Wshorten-64-to-32 and not -Wconversion 284051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // and by god we'll let them. 2841f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width == 64 && TargetRange.Width == 32) 2842b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32); 2843b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 2844323ed74658bc8375278eabf074b4777458376540John McCall } 2845323ed74658bc8375278eabf074b4777458376540John McCall 2846323ed74658bc8375278eabf074b4777458376540John McCall if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 2847323ed74658bc8375278eabf074b4777458376540John McCall (!TargetRange.NonNegative && SourceRange.NonNegative && 2848323ed74658bc8375278eabf074b4777458376540John McCall SourceRange.Width == TargetRange.Width)) { 2849323ed74658bc8375278eabf074b4777458376540John McCall unsigned DiagID = diag::warn_impcast_integer_sign; 2850323ed74658bc8375278eabf074b4777458376540John McCall 2851323ed74658bc8375278eabf074b4777458376540John McCall // Traditionally, gcc has warned about this under -Wsign-compare. 2852323ed74658bc8375278eabf074b4777458376540John McCall // We also want to warn about it in -Wconversion. 2853323ed74658bc8375278eabf074b4777458376540John McCall // So if -Wconversion is off, use a completely identical diagnostic 2854323ed74658bc8375278eabf074b4777458376540John McCall // in the sign-compare group. 2855323ed74658bc8375278eabf074b4777458376540John McCall // The conditional-checking code will 2856323ed74658bc8375278eabf074b4777458376540John McCall if (ICContext) { 2857323ed74658bc8375278eabf074b4777458376540John McCall DiagID = diag::warn_impcast_integer_sign_conditional; 2858323ed74658bc8375278eabf074b4777458376540John McCall *ICContext = true; 2859323ed74658bc8375278eabf074b4777458376540John McCall } 2860323ed74658bc8375278eabf074b4777458376540John McCall 2861b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, DiagID); 286251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 286351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2864284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor // Diagnose conversions between different enumeration types. 2865284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *SourceEnum = Source->getAs<EnumType>()) 2866284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *TargetEnum = Target->getAs<EnumType>()) 2867284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if ((SourceEnum->getDecl()->getIdentifier() || 2868284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor SourceEnum->getDecl()->getTypedefForAnonDecl()) && 2869284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor (TargetEnum->getDecl()->getIdentifier() || 2870284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor TargetEnum->getDecl()->getTypedefForAnonDecl()) && 2871284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor SourceEnum != TargetEnum) 2872284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor return DiagnoseImpCast(S, E, T, CC, 2873284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor diag::warn_impcast_different_enum_types); 2874284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor 287551313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 287651313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 287751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2878323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T); 2879323ed74658bc8375278eabf074b4777458376540John McCall 2880323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T, 2881b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool &ICContext) { 2882323ed74658bc8375278eabf074b4777458376540John McCall E = E->IgnoreParenImpCasts(); 2883323ed74658bc8375278eabf074b4777458376540John McCall 2884323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) 2885323ed74658bc8375278eabf074b4777458376540John McCall return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T); 2886323ed74658bc8375278eabf074b4777458376540John McCall 2887b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E, CC); 2888323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 2889b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return CheckImplicitConversion(S, E, T, CC, &ICContext); 2890323ed74658bc8375278eabf074b4777458376540John McCall return; 2891323ed74658bc8375278eabf074b4777458376540John McCall} 2892323ed74658bc8375278eabf074b4777458376540John McCall 2893323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) { 2894b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC = E->getQuestionLoc(); 2895b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 2896b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getCond(), CC); 2897323ed74658bc8375278eabf074b4777458376540John McCall 2898323ed74658bc8375278eabf074b4777458376540John McCall bool Suspicious = false; 2899b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 2900b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 2901323ed74658bc8375278eabf074b4777458376540John McCall 2902323ed74658bc8375278eabf074b4777458376540John McCall // If -Wconversion would have warned about either of the candidates 2903323ed74658bc8375278eabf074b4777458376540John McCall // for a signedness conversion to the context type... 2904323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) return; 2905323ed74658bc8375278eabf074b4777458376540John McCall 2906323ed74658bc8375278eabf074b4777458376540John McCall // ...but it's currently ignored... 29070827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional, 29080827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis CC)) 2909323ed74658bc8375278eabf074b4777458376540John McCall return; 2910323ed74658bc8375278eabf074b4777458376540John McCall 2911323ed74658bc8375278eabf074b4777458376540John McCall // ...and -Wsign-compare isn't... 29120827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (!S.Diags.getDiagnosticLevel(diag::warn_mixed_sign_conditional, CC)) 2913323ed74658bc8375278eabf074b4777458376540John McCall return; 2914323ed74658bc8375278eabf074b4777458376540John McCall 2915323ed74658bc8375278eabf074b4777458376540John McCall // ...then check whether it would have warned about either of the 2916323ed74658bc8375278eabf074b4777458376540John McCall // candidates for a signedness conversion to the condition type. 2917323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) { 2918323ed74658bc8375278eabf074b4777458376540John McCall Suspicious = false; 2919323ed74658bc8375278eabf074b4777458376540John McCall CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 2920b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 2921323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) 2922323ed74658bc8375278eabf074b4777458376540John McCall CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 2923b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 2924323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) 2925323ed74658bc8375278eabf074b4777458376540John McCall return; 2926323ed74658bc8375278eabf074b4777458376540John McCall } 2927323ed74658bc8375278eabf074b4777458376540John McCall 2928323ed74658bc8375278eabf074b4777458376540John McCall // If so, emit a diagnostic under -Wsign-compare. 2929323ed74658bc8375278eabf074b4777458376540John McCall Expr *lex = E->getTrueExpr()->IgnoreParenImpCasts(); 2930323ed74658bc8375278eabf074b4777458376540John McCall Expr *rex = E->getFalseExpr()->IgnoreParenImpCasts(); 2931323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getQuestionLoc(), diag::warn_mixed_sign_conditional) 2932323ed74658bc8375278eabf074b4777458376540John McCall << lex->getType() << rex->getType() 2933323ed74658bc8375278eabf074b4777458376540John McCall << lex->getSourceRange() << rex->getSourceRange(); 2934323ed74658bc8375278eabf074b4777458376540John McCall} 2935323ed74658bc8375278eabf074b4777458376540John McCall 2936323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting 2937323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression. There are a couple 2938323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare. 2939b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 2940323ed74658bc8375278eabf074b4777458376540John McCall QualType T = OrigE->getType(); 2941323ed74658bc8375278eabf074b4777458376540John McCall Expr *E = OrigE->IgnoreParenImpCasts(); 2942323ed74658bc8375278eabf074b4777458376540John McCall 2943323ed74658bc8375278eabf074b4777458376540John McCall // For conditional operators, we analyze the arguments as if they 2944323ed74658bc8375278eabf074b4777458376540John McCall // were being fed directly into the output. 2945323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) { 2946323ed74658bc8375278eabf074b4777458376540John McCall ConditionalOperator *CO = cast<ConditionalOperator>(E); 2947323ed74658bc8375278eabf074b4777458376540John McCall CheckConditionalOperator(S, CO, T); 2948323ed74658bc8375278eabf074b4777458376540John McCall return; 2949323ed74658bc8375278eabf074b4777458376540John McCall } 2950323ed74658bc8375278eabf074b4777458376540John McCall 2951323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and check any implicit conversions we might have skipped. 2952323ed74658bc8375278eabf074b4777458376540John McCall // The non-canonical typecheck is just an optimization; 2953323ed74658bc8375278eabf074b4777458376540John McCall // CheckImplicitConversion will filter out dead implicit conversions. 2954323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 2955b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckImplicitConversion(S, E, T, CC); 2956323ed74658bc8375278eabf074b4777458376540John McCall 2957323ed74658bc8375278eabf074b4777458376540John McCall // Now continue drilling into this expression. 2958323ed74658bc8375278eabf074b4777458376540John McCall 2959323ed74658bc8375278eabf074b4777458376540John McCall // Skip past explicit casts. 2960323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ExplicitCastExpr>(E)) { 2961323ed74658bc8375278eabf074b4777458376540John McCall E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 2962b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return AnalyzeImplicitConversions(S, E, CC); 2963323ed74658bc8375278eabf074b4777458376540John McCall } 2964323ed74658bc8375278eabf074b4777458376540John McCall 2965beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 2966beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Do a somewhat different check with comparison operators. 2967beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isComparisonOp()) 2968beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeComparison(S, BO); 2969beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 2970beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // And with assignments and compound assignments. 2971beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isAssignmentOp()) 2972beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeAssignment(S, BO); 2973beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 2974323ed74658bc8375278eabf074b4777458376540John McCall 2975323ed74658bc8375278eabf074b4777458376540John McCall // These break the otherwise-useful invariant below. Fortunately, 2976323ed74658bc8375278eabf074b4777458376540John McCall // we don't really need to recurse into them, because any internal 2977323ed74658bc8375278eabf074b4777458376540John McCall // expressions should have been analyzed already when they were 2978323ed74658bc8375278eabf074b4777458376540John McCall // built into statements. 2979323ed74658bc8375278eabf074b4777458376540John McCall if (isa<StmtExpr>(E)) return; 2980323ed74658bc8375278eabf074b4777458376540John McCall 2981323ed74658bc8375278eabf074b4777458376540John McCall // Don't descend into unevaluated contexts. 2982323ed74658bc8375278eabf074b4777458376540John McCall if (isa<SizeOfAlignOfExpr>(E)) return; 2983323ed74658bc8375278eabf074b4777458376540John McCall 2984323ed74658bc8375278eabf074b4777458376540John McCall // Now just recurse over the expression's children. 2985b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CC = E->getExprLoc(); 29867502c1d3ce8bb97bcc4f7bebef507040bd93b26fJohn McCall for (Stmt::child_range I = E->children(); I; ++I) 2987b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, cast<Expr>(*I), CC); 2988323ed74658bc8375278eabf074b4777458376540John McCall} 2989323ed74658bc8375278eabf074b4777458376540John McCall 2990323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace 2991323ed74658bc8375278eabf074b4777458376540John McCall 2992323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given 2993323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression). Implements -Wconversion 2994323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare. 2995b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// 2996b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e. 2997b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// the most location of the syntactic entity requiring the implicit 2998b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// conversion 2999b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 3000323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose in unevaluated contexts. 3001323ed74658bc8375278eabf074b4777458376540John McCall if (ExprEvalContexts.back().Context == Sema::Unevaluated) 3002323ed74658bc8375278eabf074b4777458376540John McCall return; 3003323ed74658bc8375278eabf074b4777458376540John McCall 3004323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose for value- or type-dependent expressions. 3005323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) 3006323ed74658bc8375278eabf074b4777458376540John McCall return; 3007323ed74658bc8375278eabf074b4777458376540John McCall 3008b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // This is not the right CC for (e.g.) a variable initialization. 3009b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(*this, E, CC); 3010323ed74658bc8375278eabf074b4777458376540John McCall} 3011323ed74658bc8375278eabf074b4777458376540John McCall 301215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 301315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall FieldDecl *BitField, 301415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *Init) { 301515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 301615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 301715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 3018f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given 3019f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This 3020f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the 3021f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function 3022f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete. 302382aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregorbool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd, 302482aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor bool CheckParameterNames) { 3025f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump bool HasInvalidParm = false; 302682aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor for (; P != PEnd; ++P) { 302782aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor ParmVarDecl *Param = *P; 302882aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor 3029f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.7.5.3p4: the parameters in a parameter type list in a 3030f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // function declarator that is part of a function definition of 3031f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // that function shall not have incomplete type. 3032f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // 3033f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // This is also C++ [dcl.fct]p6. 3034f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump if (!Param->isInvalidDecl() && 3035f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump RequireCompleteType(Param->getLocation(), Param->getType(), 3036f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump diag::err_typecheck_decl_incomplete_type)) { 3037f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Param->setInvalidDecl(); 3038f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump HasInvalidParm = true; 3039f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 3040f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 3041f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.9.1p5: If the declarator includes a parameter type list, the 3042f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // declaration of each parameter shall include an identifier. 304382aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor if (CheckParameterNames && 304482aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor Param->getIdentifier() == 0 && 3045f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !Param->isImplicit() && 3046f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !getLangOptions().CPlusPlus) 3047f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Diag(Param->getLocation(), diag::err_parameter_name_omitted); 3048d17e340e2d516139931768697bf080f60920ba9dSam Weinig 3049d17e340e2d516139931768697bf080f60920ba9dSam Weinig // C99 6.7.5.3p12: 3050d17e340e2d516139931768697bf080f60920ba9dSam Weinig // If the function declarator is not part of a definition of that 3051d17e340e2d516139931768697bf080f60920ba9dSam Weinig // function, parameters may have incomplete type and may use the [*] 3052d17e340e2d516139931768697bf080f60920ba9dSam Weinig // notation in their sequences of declarator specifiers to specify 3053d17e340e2d516139931768697bf080f60920ba9dSam Weinig // variable length array types. 3054d17e340e2d516139931768697bf080f60920ba9dSam Weinig QualType PType = Param->getOriginalType(); 3055d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (const ArrayType *AT = Context.getAsArrayType(PType)) { 3056d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (AT->getSizeModifier() == ArrayType::Star) { 3057d17e340e2d516139931768697bf080f60920ba9dSam Weinig // FIXME: This diagnosic should point the the '[*]' if source-location 3058d17e340e2d516139931768697bf080f60920ba9dSam Weinig // information is added for it. 3059d17e340e2d516139931768697bf080f60920ba9dSam Weinig Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 3060d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 3061d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 3062f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 3063f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 3064f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump return HasInvalidParm; 3065f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump} 3066b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3067b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a 3068b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements. 3069b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 3070b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // This is actually a lot of work to potentially be doing on every 3071b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // cast; don't do it if we're ignoring -Wcast_align (as is the default). 30720827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align, 30730827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis TRange.getBegin()) 3074b7f4ffe073fa419613946461a2583ba2fcb72280John McCall == Diagnostic::Ignored) 3075b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 3076b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3077b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Ignore dependent types. 3078b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (T->isDependentType() || Op->getType()->isDependentType()) 3079b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 3080b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3081b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the destination be a pointer type. 3082b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *DestPtr = T->getAs<PointerType>(); 3083b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!DestPtr) return; 3084b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3085b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // If the destination has alignment 1, we're done. 3086b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType DestPointee = DestPtr->getPointeeType(); 3087b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestPointee->isIncompleteType()) return; 3088b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 3089b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestAlign.isOne()) return; 3090b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3091b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the source be a pointer type. 3092b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 3093b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!SrcPtr) return; 3094b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType SrcPointee = SrcPtr->getPointeeType(); 3095b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3096b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Whitelist casts from cv void*. We already implicitly 3097b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // whitelisted casts to cv void*, since they have alignment 1. 3098b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Also whitelist casts involving incomplete types, which implicitly 3099b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // includes 'void'. 3100b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcPointee->isIncompleteType()) return; 3101b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3102b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 3103b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcAlign >= DestAlign) return; 3104b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3105b7f4ffe073fa419613946461a2583ba2fcb72280John McCall Diag(TRange.getBegin(), diag::warn_cast_align) 3106b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << Op->getType() << T 3107b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(SrcAlign.getQuantity()) 3108b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(DestAlign.getQuantity()) 3109b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << TRange << Op->getSourceRange(); 3110b7f4ffe073fa419613946461a2583ba2fcb72280John McCall} 3111b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 31123406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruthvoid Sema::CheckArrayAccess(const clang::ArraySubscriptExpr *E) { 311335001ca261f895817916b468379b696d6d45959dChandler Carruth const Expr *BaseExpr = E->getBase()->IgnoreParenImpCasts(); 31143406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const ConstantArrayType *ArrayTy = 311535001ca261f895817916b468379b696d6d45959dChandler Carruth Context.getAsConstantArrayType(BaseExpr->getType()); 31163406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (!ArrayTy) 3117a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 311835001ca261f895817916b468379b696d6d45959dChandler Carruth 31193406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const Expr *IndexExpr = E->getIdx(); 31203406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (IndexExpr->isValueDependent()) 3121a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 31223406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth llvm::APSInt index; 31233406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (!IndexExpr->isIntegerConstantExpr(index, Context)) 3124a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 31258fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek 31263406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (!index.isNegative()) { 312725b3b849e3ad340b04442707038c86980035765bTed Kremenek llvm::APInt size = ArrayTy->getSize(); 312835001ca261f895817916b468379b696d6d45959dChandler Carruth if (!size.isStrictlyPositive()) 312935001ca261f895817916b468379b696d6d45959dChandler Carruth return; 31303406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (size.getBitWidth() > index.getBitWidth()) 31313406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth index = index.sext(size.getBitWidth()); 313225b3b849e3ad340b04442707038c86980035765bTed Kremenek else if (size.getBitWidth() < index.getBitWidth()) 313325b3b849e3ad340b04442707038c86980035765bTed Kremenek size = size.sext(index.getBitWidth()); 313425b3b849e3ad340b04442707038c86980035765bTed Kremenek 31353406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (index.slt(size)) 31368fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek return; 31373406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth 31383406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth Diag(E->getBase()->getLocStart(), diag::warn_array_index_exceeds_bounds) 31393406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth << index.toString(10, true) << size.toString(10, true) 31403406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth << IndexExpr->getSourceRange(); 31413406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth } else { 31423406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth Diag(E->getBase()->getLocStart(), diag::warn_array_index_precedes_bounds) 31433406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth << index.toString(10, true) << IndexExpr->getSourceRange(); 3144a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek } 314535001ca261f895817916b468379b696d6d45959dChandler Carruth 314635001ca261f895817916b468379b696d6d45959dChandler Carruth const NamedDecl *ND = NULL; 314735001ca261f895817916b468379b696d6d45959dChandler Carruth if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 314835001ca261f895817916b468379b696d6d45959dChandler Carruth ND = dyn_cast<NamedDecl>(DRE->getDecl()); 314935001ca261f895817916b468379b696d6d45959dChandler Carruth if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 315035001ca261f895817916b468379b696d6d45959dChandler Carruth ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 315135001ca261f895817916b468379b696d6d45959dChandler Carruth if (ND) 315235001ca261f895817916b468379b696d6d45959dChandler Carruth Diag(ND->getLocStart(), diag::note_array_index_out_of_bounds) 315335001ca261f895817916b468379b696d6d45959dChandler Carruth << ND->getDeclName(); 3154a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek} 3155a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek 3156