SemaChecking.cpp revision 37050841d7b852497b85d5275d9ea92c07ddf059
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// The LLVM Compiler Infrastructure 459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source 60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details. 759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump// This file implements extra semantic analysis beyond what is enforced 1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// by the C type system. 1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 155f8d604246976a93a73549b07bbc8ee0b2061b50John McCall#include "clang/Sema/Initialization.h" 16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Sema.h" 172d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 18276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman#include "clang/Sema/Initialization.h" 19781472fe99a120098c631b0cbe33c89f8cef5e70John McCall#include "clang/Sema/ScopeInfo.h" 20826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek#include "clang/Analysis/Analyses/FormatString.h" 2159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h" 22199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h" 23384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 24c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h" 252324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h" 267ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h" 27f85e193739c953358c865005855253af4f68a497John McCall#include "clang/AST/EvaluatedExprVisitor.h" 28f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/DeclObjC.h" 29f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h" 30f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h" 3159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h" 32f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h" 338fe83e1df954d72c0f4ffc15d20a5222ec151c21Benjamin Kramer#include "llvm/ADT/SmallString.h" 34f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h" 353bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h" 36691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher#include "clang/Basic/TargetBuiltins.h" 3726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman#include "clang/Basic/TargetInfo.h" 387da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian#include "clang/Basic/ConvertUTF.h" 39a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits> 4059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang; 41781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema; 4259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 4360800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 4460800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned ByteNo) const { 4508f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner return SL->getLocationOfByte(ByteNo, PP.getSourceManager(), 464e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie PP.getLangOpts(), PP.getTargetInfo()); 4760800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner} 4860800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 498e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number. 508e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking. Returns true on error. 518e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) { 528e10f3b9cc1db43645bbc2999eb163af8997d468John McCall unsigned argCount = call->getNumArgs(); 538e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount == desiredArgCount) return false; 548e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 558e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount < desiredArgCount) 568e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args) 578e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 588e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getSourceRange(); 598e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 608e10f3b9cc1db43645bbc2999eb163af8997d468John McCall // Highlight all the excess arguments. 618e10f3b9cc1db43645bbc2999eb163af8997d468John McCall SourceRange range(call->getArg(desiredArgCount)->getLocStart(), 628e10f3b9cc1db43645bbc2999eb163af8997d468John McCall call->getArg(argCount - 1)->getLocEnd()); 638e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 648e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args) 658e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 668e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getArg(1)->getSourceRange(); 678e10f3b9cc1db43645bbc2999eb163af8997d468John McCall} 688e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 6977f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge/// CheckBuiltinAnnotationString - Checks that string argument to the builtin 7077f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge/// annotation is a non wide string literal. 7177f68bb90af93b95045fb994e7cd68137adcc132Julien Lerougestatic bool CheckBuiltinAnnotationString(Sema &S, Expr *Arg) { 7277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge Arg = Arg->IgnoreParenCasts(); 7377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 7477f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge if (!Literal || !Literal->isAscii()) { 7577f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge S.Diag(Arg->getLocStart(), diag::err_builtin_annotation_not_string_constant) 7677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge << Arg->getSourceRange(); 7777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return true; 7877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge } 7977f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return false; 8077f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge} 8177f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge 8260d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 83d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 8460d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult TheCallResult(Owned(TheCall)); 852def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor 86946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Find out if any arguments are required to be integer constant expressions. 87946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner unsigned ICEArguments = 0; 88946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ASTContext::GetBuiltinTypeError Error; 89946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 90946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (Error != ASTContext::GE_None) 91946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments = 0; // Don't diagnose previously diagnosed errors. 92946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 93946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // If any arguments are required to be ICE's, check and diagnose. 94946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 95946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Skip arguments not required to be ICE's. 96946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if ((ICEArguments & (1 << ArgNo)) == 0) continue; 97946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 98946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner llvm::APSInt Result; 99946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 100946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner return true; 101946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments &= ~(1 << ArgNo); 102946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner } 103946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 104d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson switch (BuiltinID) { 10530ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin___CFStringMakeConstantString: 106925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner assert(TheCall->getNumArgs() == 1 && 1071b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner "Wrong # arguments to builtin CFStringMakeConstantString"); 108690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner if (CheckObjCString(TheCall->getArg(0))) 1090eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 110d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 11149ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek case Builtin::BI__builtin_stdarg_start: 11230ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin_va_start: 1130eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinVAStart(TheCall)) 1140eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 115d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1161b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreater: 1171b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreaterequal: 1181b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isless: 1191b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessequal: 1201b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessgreater: 1211b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isunordered: 1220eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinUnorderedCompare(TheCall)) 1230eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 124d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 125e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer case Builtin::BI__builtin_fpclassify: 126e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer if (SemaBuiltinFPClassification(TheCall, 6)) 127e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer return ExprError(); 128e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer break; 1299ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isfinite: 1309ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf: 1319ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf_sign: 1329ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnan: 1339ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnormal: 1343b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (SemaBuiltinFPClassification(TheCall, 1)) 1359ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return ExprError(); 1369ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman break; 137d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman case Builtin::BI__builtin_shufflevector: 1380eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return SemaBuiltinShuffleVector(TheCall); 1390eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // TheCall will be freed by the smart pointer here, but that's fine, since 1400eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // SemaBuiltinShuffleVector guts it, but then doesn't release it. 1414493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar case Builtin::BI__builtin_prefetch: 1420eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinPrefetch(TheCall)) 1430eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 144d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 145d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar case Builtin::BI__builtin_object_size: 1460eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinObjectSize(TheCall)) 1470eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 148d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 149d875fed28578835de89cd407e9db4be788596d7cEli Friedman case Builtin::BI__builtin_longjmp: 150d875fed28578835de89cd407e9db4be788596d7cEli Friedman if (SemaBuiltinLongjmp(TheCall)) 151d875fed28578835de89cd407e9db4be788596d7cEli Friedman return ExprError(); 152d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1538e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 1548e10f3b9cc1db43645bbc2999eb163af8997d468John McCall case Builtin::BI__builtin_classify_type: 1558e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1568e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 1578e10f3b9cc1db43645bbc2999eb163af8997d468John McCall break; 15875c29a012793292ff4578015a9113bf086156d7fChris Lattner case Builtin::BI__builtin_constant_p: 1598e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1608e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 16175c29a012793292ff4578015a9113bf086156d7fChris Lattner break; 1625caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: 163a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 164a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 165a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 166a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 167a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 1685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: 169a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 170a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 171a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 172a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 173a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 1745caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: 175a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 176a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 177a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 178a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 179a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 1805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: 181a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 182a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 183a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 184a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 185a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 1865caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: 187a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 188a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 189a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 190a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 191a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 1925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_add_and_fetch: 193a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 194a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 195a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 196a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 197a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 1985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_sub_and_fetch: 199a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 200a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 201a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 202a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 203a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 2045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_and_and_fetch: 205a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 206a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 207a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 208a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 209a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 2105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_or_and_fetch: 211a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 212a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 213a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 214a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 215a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 2165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_xor_and_fetch: 217a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 218a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 219a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 220a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 221a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 2225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 223a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 224a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 225a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 226a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 227a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 2285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 229a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 230a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 231a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 232a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 233a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 2345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_test_and_set: 235a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 236a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 237a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 238a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 239a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 2405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 241a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 242a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 243a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 244a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 245a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 24623aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: 247a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 248a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 249a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 250a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 251a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 252d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return SemaBuiltinAtomicOverloaded(move(TheCallResult)); 253ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define BUILTIN(ID, TYPE, ATTRS) 254ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define ATOMIC_BUILTIN(ID, TYPE, ATTRS) \ 255ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Builtin::BI##ID: \ 256ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::AO##ID); 257ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#include "clang/Basic/Builtins.def" 25877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge case Builtin::BI__builtin_annotation: 25977f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge if (CheckBuiltinAnnotationString(*this, TheCall->getArg(1))) 26077f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return ExprError(); 26177f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge break; 26226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 26326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 26426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // Since the target specific builtins for each arch overlap, only check those 26526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // of the arch we are compiling for. 26626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (BuiltinID >= Builtin::FirstTSBuiltin) { 267bcfd1f55bfbb3e5944cd5e03d07b343e280838c4Douglas Gregor switch (Context.getTargetInfo().getTriple().getArch()) { 26826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::arm: 26926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::thumb: 27026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 27126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return ExprError(); 27226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 27326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman default: 27426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 27526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 27626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 27726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 27826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return move(TheCallResult); 27926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman} 28026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 28161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code. 28261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) { 283da95f73b59f9af964e33725c515139d34c90c863Bob Wilson NeonTypeFlags Type(t); 284da95f73b59f9af964e33725c515139d34c90c863Bob Wilson int IsQuad = Type.isQuad(); 285da95f73b59f9af964e33725c515139d34c90c863Bob Wilson switch (Type.getEltType()) { 286da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int8: 287da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly8: 288da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 7 : (8 << IsQuad) - 1; 289da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int16: 290da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly16: 291da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 15 : (4 << IsQuad) - 1; 292da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int32: 293da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 31 : (2 << IsQuad) - 1; 294da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int64: 295da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 63 : (1 << IsQuad) - 1; 296da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float16: 297da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 298da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (4 << IsQuad) - 1; 299da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float32: 300da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 301da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (2 << IsQuad) - 1; 30261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman } 3037530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie llvm_unreachable("Invalid NeonTypeFlag!"); 30461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman} 30561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 3066f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// getNeonEltType - Return the QualType corresponding to the elements of 3076f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the vector type specified by the NeonTypeFlags. This is used to check 3086f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the pointer arguments for Neon load/store intrinsics. 3096f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilsonstatic QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context) { 3106f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson switch (Flags.getEltType()) { 3116f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int8: 3126f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy; 3136f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int16: 3146f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy; 3156f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int32: 3166f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy; 3176f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int64: 3186f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedLongLongTy : Context.LongLongTy; 3196f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly8: 3206f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.SignedCharTy; 3216f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly16: 3226f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.ShortTy; 3236f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float16: 3246f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.UnsignedShortTy; 3256f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float32: 3266f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.FloatTy; 3276f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 3287530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie llvm_unreachable("Invalid NeonTypeFlag!"); 3296f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson} 3306f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 33126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 3321c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman llvm::APSInt Result; 3331c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 3340d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned mask = 0; 33561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned TV = 0; 3364648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson int PtrArgNum = -1; 3376f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson bool HasConstPtr = false; 3381c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman switch (BuiltinID) { 339a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK 340a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 341a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK 3421c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman } 3431c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 3440d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which are overloaded on vector element type, validate 3450d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // the immediate which specifies which variant to emit. 3466f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson unsigned ImmArg = TheCall->getNumArgs()-1; 3470d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (mask) { 3486f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson if (SemaBuiltinConstantArg(TheCall, ImmArg, Result)) 3490d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 3500d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 351da95f73b59f9af964e33725c515139d34c90c863Bob Wilson TV = Result.getLimitedValue(64); 352da95f73b59f9af964e33725c515139d34c90c863Bob Wilson if ((TV > 63) || (mask & (1 << TV)) == 0) 3530d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 3546f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson << TheCall->getArg(ImmArg)->getSourceRange(); 3556f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 3566f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 3574648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (PtrArgNum >= 0) { 3586f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson // Check that pointer arguments have the specified type. 3594648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Expr *Arg = TheCall->getArg(PtrArgNum); 3604648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) 3614648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Arg = ICE->getSubExpr(); 3624648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg); 3634648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType RHSTy = RHS.get()->getType(); 3644648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context); 3654648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (HasConstPtr) 3664648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson EltTy = EltTy.withConst(); 3674648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType LHSTy = Context.getPointerType(EltTy); 3684648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson AssignConvertType ConvTy; 3694648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS); 3704648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (RHS.isInvalid()) 3714648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 3724648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy, 3734648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson RHS.get(), AA_Assigning)) 3744648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 3750d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman } 3761c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 3770d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which take an immediate value as part of the 3780d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // instruction, range check them here. 37961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned i = 0, l = 0, u = 0; 3800d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman switch (BuiltinID) { 3810d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman default: return false; 382bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 383bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 38499c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_f: 38599c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 386a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK 387a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 388a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK 3890d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman }; 3900d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 39161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Check that the immediate argument is actually a constant. 3920d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, i, Result)) 3930d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 3940d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 39561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Range check against the upper/lower values for this isntruction. 3960d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned Val = Result.getZExtValue(); 39761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if (Val < l || Val > (u + l)) 3980d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 399476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer << l << u+l << TheCall->getArg(i)->getSourceRange(); 4000d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 40199c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman // FIXME: VFP Intrinsics should error if VFP not present. 40226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return false; 403d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson} 404d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 405d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// CheckFunctionCall - Check a direct function call for various correctness 406d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// and safety properties not strictly enforced by the C type system. 407d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) { 408d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // Get the IdentifierInfo* for the called function. 409d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson IdentifierInfo *FnInfo = FDecl->getIdentifier(); 410de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 411d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // None of the checks below are needed for functions that don't have 412d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // simple names (e.g., C++ conversion functions). 413d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson if (!FnInfo) 414d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 4151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 416de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // FIXME: This mechanism should be abstracted to be less fragile and 417de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // more efficient. For example, just map function ids to custom 418de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // handlers. 419de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 420c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek // Printf and scanf checking. 421c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<FormatAttr> 422c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<FormatAttr>(), 423c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<FormatAttr>(); i != e ; ++i) { 42429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas CheckFormatArguments(*i, TheCall); 42559907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner } 4261eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 427c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<NonNullAttr> 428c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<NonNullAttr>(), 429c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<NonNullAttr>(); i != e; ++i) { 430909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky CheckNonNullArguments(*i, TheCall->getArgs(), 431909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky TheCall->getCallee()->getLocStart()); 432c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek } 4330eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 4340a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned CMId = FDecl->getMemoryFunctionKind(); 4350a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == 0) 436d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks return false; 437bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 438d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks // Handle memory setting and copying functions. 4390a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat) 440bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CheckStrlcpycatArguments(TheCall, FnInfo); 441c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (CMId == Builtin::BIstrncat) 442c36bedc90c687caa71748480c60707ea4608b092Anna Zaks CheckStrncatArguments(TheCall, FnInfo); 443d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks else 4440a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks CheckMemaccessArguments(TheCall, CMId, FnInfo); 4457ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 446d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 44771993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson} 44871993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 44929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupasbool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac, 45029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **Args, unsigned NumArgs) { 45129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas for (specific_attr_iterator<FormatAttr> 45229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas i = Method->specific_attr_begin<FormatAttr>(), 45329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas e = Method->specific_attr_end<FormatAttr>(); i != e ; ++i) { 45429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 45529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas CheckFormatArguments(*i, Args, NumArgs, false, lbrac, 45629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Method->getSourceRange()); 45729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas } 45829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 45929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas // diagnose nonnull arguments. 46029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas for (specific_attr_iterator<NonNullAttr> 46129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas i = Method->specific_attr_begin<NonNullAttr>(), 46229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas e = Method->specific_attr_end<NonNullAttr>(); i != e; ++i) { 46329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas CheckNonNullArguments(*i, Args, lbrac); 46429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas } 46529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 46629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return false; 46729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 46829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 469d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) { 470725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian const VarDecl *V = dyn_cast<VarDecl>(NDecl); 471725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!V) 472d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 4731eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 474725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian QualType Ty = V->getType(); 475725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Ty->isBlockPointerType()) 476d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 4771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 47843d1251a471d19ce83aa8ce91c0104addada5addJean-Daniel Dupas // format string checking. 47943d1251a471d19ce83aa8ce91c0104addada5addJean-Daniel Dupas for (specific_attr_iterator<FormatAttr> 48043d1251a471d19ce83aa8ce91c0104addada5addJean-Daniel Dupas i = NDecl->specific_attr_begin<FormatAttr>(), 48143d1251a471d19ce83aa8ce91c0104addada5addJean-Daniel Dupas e = NDecl->specific_attr_end<FormatAttr>(); i != e ; ++i) { 48243d1251a471d19ce83aa8ce91c0104addada5addJean-Daniel Dupas CheckFormatArguments(*i, TheCall); 48343d1251a471d19ce83aa8ce91c0104addada5addJean-Daniel Dupas } 484d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 485d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 486725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian} 487725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian 488ff34d401ff385ef7173ca612432b4ea717fff690Richard SmithExprResult Sema::SemaAtomicOpsOverloaded(ExprResult TheCallResult, 489ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith AtomicExpr::AtomicOp Op) { 490276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman CallExpr *TheCall = cast<CallExpr>(TheCallResult.get()); 491276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 492276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 493ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // All these operations take one of the following forms: 494ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith enum { 495ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_init(A *, C) 496ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Init, 497ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_load(A *, int) 498ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Load, 499ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // void __atomic_load(A *, CP, int) 500ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Copy, 501ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_add(A *, M, int) 502ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Arithmetic, 503ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __atomic_exchange_n(A *, CP, int) 504ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Xchg, 505ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // void __atomic_exchange(A *, C *, CP, int) 506ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith GNUXchg, 507ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // bool __c11_atomic_compare_exchange_strong(A *, C *, CP, int, int) 508ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith C11CmpXchg, 509ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // bool __atomic_compare_exchange(A *, C *, CP, bool, int, int) 510ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith GNUCmpXchg 511ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } Form = Init; 512ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith const unsigned NumArgs[] = { 2, 2, 3, 3, 3, 4, 5, 6 }; 513ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith const unsigned NumVals[] = { 1, 0, 1, 1, 1, 2, 2, 3 }; 514ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // where: 515ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C is an appropriate type, 516ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // A is volatile _Atomic(C) for __c11 builtins and is C for GNU builtins, 517ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // CP is C for __c11 builtins and GNU _n builtins and is C * otherwise, 518ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // M is C if C is an integer, and ptrdiff_t if C is a pointer, and 519ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // the int parameters are for orderings. 520ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 521ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith assert(AtomicExpr::AO__c11_atomic_init == 0 && 522ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith AtomicExpr::AO__c11_atomic_fetch_xor + 1 == AtomicExpr::AO__atomic_load 523ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith && "need to update code for modified C11 atomics"); 524ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsC11 = Op >= AtomicExpr::AO__c11_atomic_init && 525ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op <= AtomicExpr::AO__c11_atomic_fetch_xor; 526ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsN = Op == AtomicExpr::AO__atomic_load_n || 527ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_store_n || 528ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_exchange_n || 529ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_compare_exchange_n; 530ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsAddSub = false; 531ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 532ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (Op) { 533ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_init: 534ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Init; 535ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 536ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 537ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_load: 538ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_load_n: 539ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Load; 540ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 541ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 542ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_store: 543ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_load: 544ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_store: 545ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_store_n: 546ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Copy; 547ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 548ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 549ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_add: 550ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_sub: 551ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_add: 552ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_sub: 553ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_add_fetch: 554ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_sub_fetch: 555ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith IsAddSub = true; 556ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Fall through. 557ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_and: 558ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_or: 559ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_xor: 560ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_and: 561ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_or: 562ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_xor: 563ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_and_fetch: 564ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_or_fetch: 565ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_xor_fetch: 566ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Arithmetic; 567ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 568ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 569ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_exchange: 570ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_exchange_n: 571ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Xchg; 572ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 573ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 574ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_exchange: 575ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = GNUXchg; 576ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 577ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 578ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_compare_exchange_strong: 579ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_compare_exchange_weak: 580ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = C11CmpXchg; 581ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 582ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 583ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_compare_exchange: 584ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_compare_exchange_n: 585ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = GNUCmpXchg; 586ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 587276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 588276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 589ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Check we have the right number of arguments. 590ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (TheCall->getNumArgs() < NumArgs[Form]) { 591276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 592ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << 0 << NumArgs[Form] << TheCall->getNumArgs() 593276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 594276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 595ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } else if (TheCall->getNumArgs() > NumArgs[Form]) { 596ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(TheCall->getArg(NumArgs[Form])->getLocStart(), 597276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman diag::err_typecheck_call_too_many_args) 598ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << 0 << NumArgs[Form] << TheCall->getNumArgs() 599276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 600276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 601276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 602276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 603ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Inspect the first argument of the atomic operation. 604dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman Expr *Ptr = TheCall->getArg(0); 605276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get(); 606276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman const PointerType *pointerType = Ptr->getType()->getAs<PointerType>(); 607276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!pointerType) { 608ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 609276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 610276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 611276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 612276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 613ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For a __c11 builtin, this should be a pointer to an _Atomic type. 614ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType AtomTy = pointerType->getPointeeType(); // 'A' 615ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType ValType = AtomTy; // 'C' 616ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (IsC11) { 617ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!AtomTy->isAtomicType()) { 618ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic) 619ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << Ptr->getType() << Ptr->getSourceRange(); 620ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 621ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 622ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ValType = AtomTy->getAs<AtomicType>()->getValueType(); 623276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 624276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 625ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For an arithmetic operation, the implied arithmetic must be well-formed. 626ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Arithmetic) { 627ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // gcc does not enforce these rules for GNU atomics, but we do so for sanity. 628ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (IsAddSub && !ValType->isIntegerType() && !ValType->isPointerType()) { 629ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 630ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 631ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 632ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 633ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsAddSub && !ValType->isIntegerType()) { 634ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_bitwise_needs_atomic_int) 635ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 636ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 637ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 638ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } else if (IsN && !ValType->isIntegerType() && !ValType->isPointerType()) { 639ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For __atomic_*_n operations, the value type must be a scalar integral or 640ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // pointer type which is 1, 2, 4, 8 or 16 bytes in length. 641276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 642ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 643276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 644276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 645276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 646ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsC11 && !AtomTy.isTriviallyCopyableType(Context)) { 647ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For GNU atomics, require a trivially-copyable type. This is not part of 648ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // the GNU atomics specification, but we enforce it for sanity. 649ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_trivial_copy) 650276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 651276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 652276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 653276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 654ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // FIXME: For any builtin other than a load, the ValType must not be 655ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // const-qualified. 656ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 657276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman switch (ValType.getObjCLifetime()) { 658276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_None: 659276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_ExplicitNone: 660276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // okay 661276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman break; 662276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 663276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Weak: 664276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Strong: 665276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Autoreleasing: 666ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // FIXME: Can this happen? By this point, ValType should be known 667ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // to be trivially copyable. 668276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 669276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << ValType << Ptr->getSourceRange(); 670276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 671276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 672276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 673276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType ResultType = ValType; 674ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Copy || Form == GNUXchg || Form == Init) 675276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.VoidTy; 676ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == C11CmpXchg || Form == GNUCmpXchg) 677276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.BoolTy; 678276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 679ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The type of a parameter passed 'by value'. In the GNU atomics, such 680ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // arguments are actually passed as pointers. 681ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType ByValType = ValType; // 'CP' 682ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsC11 && !IsN) 683ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ByValType = Ptr->getType(); 684ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 685276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The first argument --- the pointer --- has a fixed type; we 686276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // deduce the types of the rest of the arguments accordingly. Walk 687276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // the remaining arguments, converting them to the deduced value type. 688ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith for (unsigned i = 1; i != NumArgs[Form]; ++i) { 689276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType Ty; 690ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (i < NumVals[Form] + 1) { 691ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (i) { 692ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 1: 693ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The second argument is the non-atomic operand. For arithmetic, this 694ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // is always passed by value, and for a compare_exchange it is always 695ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // passed by address. For the rest, GNU uses by-address and C11 uses 696ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // by-value. 697ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith assert(Form != Load); 698ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Init || (Form == Arithmetic && ValType->isIntegerType())) 699ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ValType; 700ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == Copy || Form == Xchg) 701ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ByValType; 702ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == Arithmetic) 703ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.getPointerDiffType(); 704ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else 705ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.getPointerType(ValType.getUnqualifiedType()); 706ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 707ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 2: 708ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The third argument to compare_exchange / GNU exchange is a 709ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // (pointer to a) desired value. 710ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ByValType; 711ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 712ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 3: 713ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The fourth argument to GNU compare_exchange is a 'weak' flag. 714ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.BoolTy; 715ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 716ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 717276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else { 718276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The order(s) are always converted to int. 719276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.IntTy; 720276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 721ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 722276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity Entity = 723276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity::InitializeParameter(Context, Ty, false); 724ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ExprResult Arg = TheCall->getArg(i); 725276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 726276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Arg.isInvalid()) 727276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return true; 728276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman TheCall->setArg(i, Arg.get()); 729276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 730276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 731ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Permute the arguments into a 'consistent' order. 732dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SmallVector<Expr*, 5> SubExprs; 733dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(Ptr); 734ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (Form) { 735ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Init: 736ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Note, AtomicExpr::getVal1() has a special case for this atomic. 7377a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall SubExprs.push_back(TheCall->getArg(1)); // Val1 738ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 739ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Load: 740ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Order 741ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 742ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Copy: 743ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Arithmetic: 744ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Xchg: 745dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(2)); // Order 746dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 747ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 748ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case GNUXchg: 749ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Note, AtomicExpr::getVal2() has a special case for this atomic. 750ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(3)); // Order 751ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Val1 752ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(2)); // Val2 753ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 754ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case C11CmpXchg: 755dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(3)); // Order 756dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 757dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(4)); // OrderFail 7582ebb98a78471f2039af4321bae657e7daacc2a62David Chisnall SubExprs.push_back(TheCall->getArg(2)); // Val2 759ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 760ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case GNUCmpXchg: 761ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(4)); // Order 762ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Val1 763ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(5)); // OrderFail 764ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(2)); // Val2 765ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(3)); // Weak 766ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 767276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 768dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman 769dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman return Owned(new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(), 770dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.data(), SubExprs.size(), 771dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman ResultType, Op, 772dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman TheCall->getRParenLoc())); 773276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman} 774276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 775276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 7765f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// checkBuiltinArgument - Given a call to a builtin function, perform 7775f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// normal type-checking on the given argument, updating the call in 7785f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// place. This is useful when a builtin function requires custom 7795f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// type-checking for some of its arguments but not necessarily all of 7805f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// them. 7815f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// 7825f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// Returns true on error. 7835f8d604246976a93a73549b07bbc8ee0b2061b50John McCallstatic bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) { 7845f8d604246976a93a73549b07bbc8ee0b2061b50John McCall FunctionDecl *Fn = E->getDirectCallee(); 7855f8d604246976a93a73549b07bbc8ee0b2061b50John McCall assert(Fn && "builtin call without direct callee!"); 7865f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 7875f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ParmVarDecl *Param = Fn->getParamDecl(ArgIndex); 7885f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity Entity = 7895f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity::InitializeParameter(S.Context, Param); 7905f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 7915f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ExprResult Arg = E->getArg(0); 7925f8d604246976a93a73549b07bbc8ee0b2061b50John McCall Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg); 7935f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (Arg.isInvalid()) 7945f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 7955f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 7965f8d604246976a93a73549b07bbc8ee0b2061b50John McCall E->setArg(ArgIndex, Arg.take()); 7975f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return false; 7985f8d604246976a93a73549b07bbc8ee0b2061b50John McCall} 7995f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 8005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like 8015caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer 8025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument. The main ActOnCallExpr routines have already 8035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as 8045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...). 8055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// 8065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these 8075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins, 80860d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 80960d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 810d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 8115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 8125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 8135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 8145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Ensure that we have at least one argument to do type inference from. 815d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1) { 816d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 817d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1 << TheCall->getNumArgs() 818d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 819d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 820d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 8211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Inspect the first argument of the atomic builtin. This should always be 8235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // a pointer type, whose element is an integral scalar or pointer type. 8245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Because it is a pointer type, we don't have to worry about any implicit 8255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // casts here. 826d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth // FIXME: We don't allow floating point scalars as input. 8275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *FirstArg = TheCall->getArg(0); 8288c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg); 8298c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman if (FirstArgResult.isInvalid()) 8308c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman return ExprError(); 8318c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman FirstArg = FirstArgResult.take(); 8328c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman TheCall->setArg(0, FirstArg); 8338c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman 834f85e193739c953358c865005855253af4f68a497John McCall const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>(); 835f85e193739c953358c865005855253af4f68a497John McCall if (!pointerType) { 836d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 837d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 838d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 839d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 8401eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 841f85e193739c953358c865005855253af4f68a497John McCall QualType ValType = pointerType->getPointeeType(); 842dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 843d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth !ValType->isBlockPointerType()) { 844d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 845d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 846d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 847d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 8485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 849f85e193739c953358c865005855253af4f68a497John McCall switch (ValType.getObjCLifetime()) { 850f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 851f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 852f85e193739c953358c865005855253af4f68a497John McCall // okay 853f85e193739c953358c865005855253af4f68a497John McCall break; 854f85e193739c953358c865005855253af4f68a497John McCall 855f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 856f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 857f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 858b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 859f85e193739c953358c865005855253af4f68a497John McCall << ValType << FirstArg->getSourceRange(); 860f85e193739c953358c865005855253af4f68a497John McCall return ExprError(); 861f85e193739c953358c865005855253af4f68a497John McCall } 862f85e193739c953358c865005855253af4f68a497John McCall 863b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Strip any qualifiers off ValType. 864b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType = ValType.getUnqualifiedType(); 865b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall 8668d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // The majority of builtins return a value, but a few have special return 8678d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // types, so allow them to override appropriately below. 8688d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth QualType ResultType = ValType; 8698d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth 8705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // We need to figure out which concrete builtin this maps onto. For example, 8715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add with a 2 byte object turns into 8725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add_2. 8735caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \ 8745caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 8755caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Builtin::BI##x##_8, Builtin::BI##x##_16 } 8761eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8775caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner static const unsigned BuiltinIndices[][5] = { 8785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_add), 8795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_sub), 8805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_or), 8815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_and), 8825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_xor), 8831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_add_and_fetch), 8855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_sub_and_fetch), 8865caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_and_and_fetch), 8875caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_or_and_fetch), 8885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_xor_and_fetch), 8891eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_val_compare_and_swap), 8915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_bool_compare_and_swap), 8925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_test_and_set), 89323aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_lock_release), 89423aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_swap) 8955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner }; 8961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW 8971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Determine the index of the size. 8995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned SizeIndex; 900199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 9015caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 1: SizeIndex = 0; break; 9025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 2: SizeIndex = 1; break; 9035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 4: SizeIndex = 2; break; 9045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 8: SizeIndex = 3; break; 9055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 16: SizeIndex = 4; break; 9065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: 907d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 908d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 909d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 9105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 9111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Each of these builtins has one pointer argument, followed by some number of 9135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // values (0, 1 or 2) followed by a potentially empty varags list of stuff 9145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // that we ignore. Find out which row of BuiltinIndices to read from as well 9155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // as the number of fixed args. 9167814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor unsigned BuiltinID = FDecl->getBuiltinID(); 9175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned BuiltinIndex, NumFixed = 1; 9185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner switch (BuiltinID) { 919b219cfc4d75f0a03630b7c4509ef791b7e97b2c8David Blaikie default: llvm_unreachable("Unknown overloaded atomic builtin!"); 920a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add: 921a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 922a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 923a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 924a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 925a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 926a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 0; 927a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 928a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 929a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub: 930a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 931a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 932a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 933a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 934a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 935a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 1; 936a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 937a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 938a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or: 939a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 940a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 941a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 942a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 943a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 944a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 2; 945a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 946a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 947a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and: 948a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 949a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 950a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 951a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 952a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 953a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 3; 954a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 955a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 956a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor: 957a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 958a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 959a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 960a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 961a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 962a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 4; 963a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 964a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 965a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch: 966a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 967a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 968a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 969a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 970a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 971a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 5; 972a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 973a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 974a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch: 975a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 976a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 977a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 978a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 979a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 980a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 6; 981a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 982a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 983a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch: 984a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 985a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 986a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 987a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 988a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 989a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 7; 990a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 991a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 992a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch: 993a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 994a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 995a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 996a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 997a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 998a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 8; 999a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1000a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1001a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch: 1002a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 1003a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 1004a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 1005a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 1006a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 1007a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 9; 1008a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 10091eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 1011a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 1012a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 1013a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 1014a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 1015a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 10167eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 10; 10175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 10185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1019a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 10205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 1021a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 1022a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 1023a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 1024a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 1025a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 10267eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 11; 10275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 10288d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.BoolTy; 10295caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1030a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1031a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set: 1032a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 1033a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 1034a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 1035a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 1036a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 1037a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 12; 1038a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1039a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 10405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 1041a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 1042a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 1043a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 1044a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 1045a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 10467eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 13; 10475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 0; 10488d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.VoidTy; 10495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1050a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1051a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap: 1052a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 1053a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 1054a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 1055a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 1056a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 1057a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 14; 1058a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 10595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 10601eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10615caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Now that we know how many fixed arguments we expect, first check that we 10625caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // have at least that many. 1063d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1+NumFixed) { 1064d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 1065d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1+NumFixed << TheCall->getNumArgs() 1066d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 1067d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 1068d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 10691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1070e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // Get the decl for the concrete builtin from this, we can tell what the 1071e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // concrete integer type we should convert to is. 1072e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 1073e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 1074e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName); 10751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump FunctionDecl *NewBuiltinDecl = 1076e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID, 1077e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner TUScope, false, DRE->getLocStart())); 1078d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 1079f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // The first argument --- the pointer --- has a fixed type; we 1080f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // deduce the types of the rest of the arguments accordingly. Walk 1081f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // the remaining arguments, converting them to the deduced value type. 10825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner for (unsigned i = 0; i != NumFixed; ++i) { 1083429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult Arg = TheCall->getArg(i+1); 10841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // GCC does an implicit conversion to the pointer or integer ValType. This 10865caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // can fail in some cases (1i -> int**), check for this error case now. 1087b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Initialize the argument. 1088b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall InitializedEntity Entity = InitializedEntity::InitializeParameter(Context, 1089b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType, /*consume*/ false); 1090b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 1091429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (Arg.isInvalid()) 1092d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 10931eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Okay, we have something that *can* be converted to the right type. Check 10955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // to see if there is a potentially weird extension going on here. This can 10965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // happen when you do an atomic operation on something like an char* and 10975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // pass in 42. The 42 gets converted to char. This is even more strange 10985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // for things like 45.123 -> char, etc. 10991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // FIXME: Do this check. 1100b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall TheCall->setArg(i+1, Arg.take()); 11015caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 11021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1103bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor ASTContext& Context = this->getASTContext(); 1104bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor 1105bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor // Create a new DeclRefExpr to refer to the new decl. 1106bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DeclRefExpr* NewDRE = DeclRefExpr::Create( 1107bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor Context, 1108bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getQualifierLoc(), 1109e4b92761b43ced611c417ae478568610f1ad7b1eAbramo Bagnara SourceLocation(), 1110bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor NewBuiltinDecl, 1111f4b88a45902af1802a1cb42ba48b1c474474f228John McCall /*enclosing*/ false, 1112bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getLocation(), 1113bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor NewBuiltinDecl->getType(), 1114bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getValueKind()); 11151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Set the callee in the CallExpr. 11175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // FIXME: This leaks the original parens and implicit casts. 1118bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor ExprResult PromotedCall = UsualUnaryConversions(NewDRE); 1119429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (PromotedCall.isInvalid()) 1120429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return ExprError(); 1121429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setCallee(PromotedCall.take()); 11221eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1123db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // Change the result type of the call to match the original value type. This 1124db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // is arbitrary, but the codegen for these builtins ins design to handle it 1125db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // gracefully. 11268d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth TheCall->setType(ResultType); 1127d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 1128d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return move(TheCallResult); 11295caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner} 11305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 1131690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin 113271993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct 1133fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would 1134fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend). 1135690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) { 113656f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner Arg = Arg->IgnoreParenCasts(); 113771993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 113871993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 11395cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!Literal || !Literal->isAscii()) { 1140fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 1141fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << Arg->getSourceRange(); 11429cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return true; 114371993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson } 11441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11457da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Literal->containsNonAsciiOrNull()) { 11465f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef String = Literal->getString(); 11477da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian unsigned NumBytes = String.size(); 11485f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<UTF16, 128> ToBuf(NumBytes); 11497da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian const UTF8 *FromPtr = (UTF8 *)String.data(); 11507da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian UTF16 *ToPtr = &ToBuf[0]; 11517da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 11527da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 11537da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian &ToPtr, ToPtr + NumBytes, 11547da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian strictConversion); 11557da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian // Check for conversion failure. 11567da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Result != conversionOK) 11577da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian Diag(Arg->getLocStart(), 11587da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian diag::warn_cfstring_truncated) << Arg->getSourceRange(); 11597da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian } 11609cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return false; 116159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner} 116259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 1163c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 1164c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success. 1165925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 1166925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *Fn = TheCall->getCallee(); 1167925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) { 11682c21a073525cdfa68e4439b7af551385dc2796abChris Lattner Diag(TheCall->getArg(2)->getLocStart(), 1169fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1170ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1171ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << Fn->getSourceRange() 11721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(2)->getLocStart(), 1173fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 117430ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 117530ce344307f8a8b00054021307015571f83c7364Chris Lattner } 117656f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 117756f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman if (TheCall->getNumArgs() < 2) { 1178d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher return Diag(TheCall->getLocEnd(), 1179d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 1180d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 118156f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman } 118256f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 11835f8d604246976a93a73549b07bbc8ee0b2061b50John McCall // Type-check the first argument normally. 11845f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (checkBuiltinArgument(*this, TheCall, 0)) 11855f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 11865f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 1187c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner // Determine whether the current function is variadic or not. 11889ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor BlockScopeInfo *CurBlock = getCurBlock(); 1189c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner bool isVariadic; 1190cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1191c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall isVariadic = CurBlock->TheDecl->isVariadic(); 11929498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else if (FunctionDecl *FD = getCurFunctionDecl()) 11939498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek isVariadic = FD->isVariadic(); 11949498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else 119553d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis isVariadic = getCurMethodDecl()->isVariadic(); 11961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1197c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner if (!isVariadic) { 119830ce344307f8a8b00054021307015571f83c7364Chris Lattner Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 119930ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 120030ce344307f8a8b00054021307015571f83c7364Chris Lattner } 12011eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 120230ce344307f8a8b00054021307015571f83c7364Chris Lattner // Verify that the second argument to the builtin is the last argument of the 120330ce344307f8a8b00054021307015571f83c7364Chris Lattner // current function or method. 120430ce344307f8a8b00054021307015571f83c7364Chris Lattner bool SecondArgIsLastNamedArgument = false; 1205e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 12061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 120788cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 120888cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 120930ce344307f8a8b00054021307015571f83c7364Chris Lattner // FIXME: This isn't correct for methods (results in bogus warning). 121030ce344307f8a8b00054021307015571f83c7364Chris Lattner // Get the last formal in the current function. 121188cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson const ParmVarDecl *LastArg; 1212cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1213cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff LastArg = *(CurBlock->TheDecl->param_end()-1); 1214cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff else if (FunctionDecl *FD = getCurFunctionDecl()) 1215371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner LastArg = *(FD->param_end()-1); 121630ce344307f8a8b00054021307015571f83c7364Chris Lattner else 121753d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis LastArg = *(getCurMethodDecl()->param_end()-1); 121830ce344307f8a8b00054021307015571f83c7364Chris Lattner SecondArgIsLastNamedArgument = PV == LastArg; 121930ce344307f8a8b00054021307015571f83c7364Chris Lattner } 122030ce344307f8a8b00054021307015571f83c7364Chris Lattner } 12211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 122230ce344307f8a8b00054021307015571f83c7364Chris Lattner if (!SecondArgIsLastNamedArgument) 12231eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(1)->getLocStart(), 122430ce344307f8a8b00054021307015571f83c7364Chris Lattner diag::warn_second_parameter_of_va_start_not_last_named_argument); 122530ce344307f8a8b00054021307015571f83c7364Chris Lattner return false; 12266cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman} 122730ce344307f8a8b00054021307015571f83c7364Chris Lattner 12281b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 12291b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends. This is declared to take (...), so we have to check everything. 1230925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 1231925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() < 2) 12322c21a073525cdfa68e4439b7af551385dc2796abChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1233d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << 2 << TheCall->getNumArgs()/*function call*/; 1234925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) 12351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(TheCall->getArg(2)->getLocStart(), 1236fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1237ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1238fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(TheCall->getArg(2)->getLocStart(), 1239fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 12401eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1241429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg0 = TheCall->getArg(0); 1242429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg1 = TheCall->getArg(1); 1243cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 12441b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // Do standard promotions between the two arguments, returning their common 12451b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // type. 1246925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 1247429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.isInvalid() || OrigArg1.isInvalid()) 1248429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return true; 1249403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar 1250403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // Make sure any conversions are pushed back into the call; this is 1251403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // type safe since unordered compare builtins are declared as "_Bool 1252403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // foo(...)". 1253429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(0, OrigArg0.get()); 1254429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(1, OrigArg1.get()); 12551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1256429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent()) 1257cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 1258cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 12591b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // If the common type isn't a real floating type, then the arguments were 12601b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // invalid for this operation. 12611b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner if (!Res->isRealFloatingType()) 1262429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return Diag(OrigArg0.get()->getLocStart(), 1263fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_invalid_ordered_compare) 1264429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << OrigArg0.get()->getType() << OrigArg1.get()->getType() 1265429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd()); 12661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12671b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner return false; 12681b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner} 12691b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner 1270e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 1271e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends. This is declared to take (...), so we have 12723b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point 12733b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value. 12743b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 12753b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() < NumArgs) 12769ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1277d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 12783b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() > NumArgs) 12793b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer return Diag(TheCall->getArg(NumArgs)->getLocStart(), 12809ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_too_many_args) 1281ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 12823b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 12839ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman (*(TheCall->arg_end()-1))->getLocEnd()); 12849ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 12853b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer Expr *OrigArg = TheCall->getArg(NumArgs-1); 12861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12879ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (OrigArg->isTypeDependent()) 12889ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 12899ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 129081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // This operation requires a non-_Complex floating-point number. 12919ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (!OrigArg->getType()->isRealFloatingType()) 12921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg->getLocStart(), 12939ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_invalid_unary_fp) 12949ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman << OrigArg->getType() << OrigArg->getSourceRange(); 12951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 129681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // If this is an implicit conversion from float -> double, remove it. 129781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 129881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Expr *CastArg = Cast->getSubExpr(); 129981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 130081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 130181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner "promotion from float to double is the only expected cast here"); 130281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Cast->setSubExpr(0); 130381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner TheCall->setArg(NumArgs-1, CastArg); 130481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 130581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 130681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner 13079ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 13089ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman} 13099ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 1310d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 1311d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything. 131260d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 131337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() < 2) 13140eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocEnd(), 1315d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 131637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1317d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << TheCall->getSourceRange()); 1318d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 131937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Determine which of the following types of shufflevector we're checking: 132037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 1) unary, vector mask: (lhs, mask) 132137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 2) binary, vector mask: (lhs, rhs, mask) 132237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 132337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType resType = TheCall->getArg(0)->getType(); 132437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numElements = 0; 132537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 1326cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (!TheCall->getArg(0)->isTypeDependent() && 1327cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor !TheCall->getArg(1)->isTypeDependent()) { 132837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType LHSType = TheCall->getArg(0)->getType(); 132937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType RHSType = TheCall->getArg(1)->getType(); 133037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 133137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!LHSType->isVectorType() || !RHSType->isVectorType()) { 1332cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) 13331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1334cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1335cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 1336cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 133737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 133837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numElements = LHSType->getAs<VectorType>()->getNumElements(); 133937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numResElements = TheCall->getNumArgs() - 2; 134037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 134137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Check to see if we have a call with 2 vector arguments, the unary shuffle 134237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // with mask. If so, verify that RHS is an integer vector type with the 134337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // same number of elts as lhs. 134437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() == 2) { 1345f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (!RHSType->hasIntegerRepresentation() || 134637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman RHSType->getAs<VectorType>()->getNumElements() != numElements) 134737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 134837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << SourceRange(TheCall->getArg(1)->getLocStart(), 134937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman TheCall->getArg(1)->getLocEnd()); 135037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numResElements = numElements; 135137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } 135237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 1353cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 13541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1355cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1356cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 135737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } else if (numElements != numResElements) { 135837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 1359788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner resType = Context.getVectorType(eltType, numResElements, 1360e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson VectorType::GenericVector); 1361cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 1362d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1363d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1364d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 1365cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 1366cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(i)->isValueDependent()) 1367cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor continue; 1368cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 136937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman llvm::APSInt Result(32); 137037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 137137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman return ExprError(Diag(TheCall->getLocStart(), 137237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman diag::err_shufflevector_nonconstant_argument) 137337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << TheCall->getArg(i)->getSourceRange()); 13740eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 1375d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 13760eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocStart(), 1377fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_shufflevector_argument_too_large) 13780eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl << TheCall->getArg(i)->getSourceRange()); 1379d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1380d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 13815f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<Expr*, 32> exprs; 1382d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1383d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 1384d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman exprs.push_back(TheCall->getArg(i)); 1385d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman TheCall->setArg(i, 0); 1386d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1387d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1388a88dc3079bedf70a5cfc39791727e43a10383006Nate Begeman return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(), 138937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman exprs.size(), resType, 13908189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getCallee()->getLocStart(), 13918189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getRParenLoc())); 1392d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman} 139330ce344307f8a8b00054021307015571f83c7364Chris Lattner 13944493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 13954493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two 13964493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args. 13974493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 1398fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner unsigned NumArgs = TheCall->getNumArgs(); 13994493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1400fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (NumArgs > 3) 1401ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher return Diag(TheCall->getLocEnd(), 1402ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher diag::err_typecheck_call_too_many_args_at_most) 1403ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 3 << NumArgs 1404ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << TheCall->getSourceRange(); 14054493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 14064493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // Argument 0 is checked for us and the remaining arguments must be 14074493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // constant integers. 1408fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner for (unsigned i = 1; i != NumArgs; ++i) { 14094493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar Expr *Arg = TheCall->getArg(i); 1410691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 14119aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman llvm::APSInt Result; 1412691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, i, Result)) 1413691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 14141eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 14154493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // FIXME: gcc issues a warning and rewrites these to 0. These 14164493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // seems especially odd for the third argument since the default 14174493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // is 3. 1418fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (i == 1) { 14199aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 1) 1420fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 142121fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "1" << Arg->getSourceRange(); 14224493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } else { 14239aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 3) 1424fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 142521fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "3" << Arg->getSourceRange(); 14264493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 14274493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 14284493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1429fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return false; 14304493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar} 14314493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1432691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 1433691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression. 1434691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 1435691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt &Result) { 1436691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(ArgNum); 1437691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 1438691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 1439691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1440691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 1441691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1442691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (!Arg->isIntegerConstantExpr(Result, Context)) 1443691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 14445e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher << FDecl->getDeclName() << Arg->getSourceRange(); 1445691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 144621fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner return false; 144721fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner} 144821fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner 1449d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 1450d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined 1451d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3). 1452fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner// For compatibility check 0-3, llvm only handles 0 and 2. 1453d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 1454691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1455691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1456691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // Check constant-ness first. 1457691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1458691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1459d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1460691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(1); 1461d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 1462fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 1463fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1464d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar } 1465d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1466d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar return false; 1467d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar} 1468d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1469586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 1470d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1. 1471d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 1472d875fed28578835de89cd407e9db4be788596d7cEli Friedman Expr *Arg = TheCall->getArg(1); 1473691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1474cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 1475691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // TODO: This is less than ideal. Overload this to take a value. 1476691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1477691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1478691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1479691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Result != 1) 1480d875fed28578835de89cd407e9db4be788596d7cEli Friedman return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 1481d875fed28578835de89cd407e9db4be788596d7cEli Friedman << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1482d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1483d875fed28578835de89cd407e9db4be788596d7cEli Friedman return false; 1484d875fed28578835de89cd407e9db4be788596d7cEli Friedman} 1485d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1486b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek// Handle i > 1 ? "x" : "y", recursively. 148729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupasbool Sema::SemaCheckStringLiteral(const Expr *E, Expr **Args, 148829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas unsigned NumArgs, bool HasVAListArg, 1489826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 149034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas FormatStringType Type, bool inFunctionCall) { 14914fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain: 1492cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 1493cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 1494d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 149534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas E = E->IgnoreParenCasts(); 1496f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 1497a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie if (E->isNullPointerConstant(Context, Expr::NPC_ValueDependentIsNotNull)) 1498a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // Technically -Wformat-nonliteral does not warn about this case. 1499a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // The behavior of printf and friends in this case is implementation 1500a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // dependent. Ideally if the format string cannot be null then 1501a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // it should have a 'nonnull' attribute in the function prototype. 1502a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie return true; 1503a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie 1504d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek switch (E->getStmtClass()) { 150556ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::BinaryConditionalOperatorClass: 1506d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ConditionalOperatorClass: { 150756ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall const AbstractConditionalOperator *C = cast<AbstractConditionalOperator>(E); 150829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return SemaCheckStringLiteral(C->getTrueExpr(), Args, NumArgs, HasVAListArg, 150934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas format_idx, firstDataArg, Type, 151055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu inFunctionCall) 151134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas && SemaCheckStringLiteral(C->getFalseExpr(), Args, NumArgs, HasVAListArg, 151234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas format_idx, firstDataArg, Type, 151334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas inFunctionCall); 1514d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1515d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1516d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ImplicitCastExprClass: { 15174fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ImplicitCastExpr>(E)->getSubExpr(); 15184fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 1519d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1520d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 152156ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::OpaqueValueExprClass: 152256ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) { 152356ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall E = src; 152456ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall goto tryAgain; 152556ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall } 152656ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall return false; 152756ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall 1528b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek case Stmt::PredefinedExprClass: 1529b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // While __func__, etc., are technically not string literals, they 1530b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // cannot contain format specifiers and thus are not a security 1531b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // liability. 1532b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek return true; 1533b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek 1534082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::DeclRefExprClass: { 1535082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const DeclRefExpr *DR = cast<DeclRefExpr>(E); 15361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1537082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // As an exception, do not flag errors for variables binding to 1538082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // const string literals. 1539082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 1540082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool isConstant = false; 1541082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek QualType T = DR->getType(); 1542082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek 1543082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ArrayType *AT = Context.getAsArrayType(T)) { 1544082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek isConstant = AT->getElementType().isConstant(Context); 1545ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (const PointerType *PT = T->getAs<PointerType>()) { 15461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump isConstant = T.isConstant(Context) && 1547082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek PT->getPointeeType().isConstant(Context); 1548e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas } else if (T->isObjCObjectPointerType()) { 1549e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas // In ObjC, there is usually no "const ObjectPointer" type, 1550e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas // so don't check if the pointee type is constant. 1551e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas isConstant = T.isConstant(Context); 1552082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 15531eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1554082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (isConstant) { 155531310a21fb2a9f13950f864f681c86080b05d5b2Sebastian Redl if (const Expr *Init = VD->getAnyInitializer()) 155629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return SemaCheckStringLiteral(Init, Args, NumArgs, 1557826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, format_idx, firstDataArg, 155834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas Type, /*inFunctionCall*/false); 1559082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 15601eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1561d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // For vprintf* functions (i.e., HasVAListArg==true), we add a 1562d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // special check to see if the format string is a function parameter 1563d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // of the function calling the printf function. If the function 1564d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // has an attribute indicating it is a printf-like function, then we 1565d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // should suppress warnings concerning non-literals being used in a call 1566d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // to a vprintf function. For example: 1567d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1568d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // void 1569d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 1570d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_list ap; 1571d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_start(ap, fmt); 1572d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 1573d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // ... 1574d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1575f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (HasVAListArg) { 1576f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(VD)) { 1577f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const NamedDecl *ND = dyn_cast<NamedDecl>(PV->getDeclContext())) { 1578f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas int PVIndex = PV->getFunctionScopeIndex() + 1; 1579f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas for (specific_attr_iterator<FormatAttr> 1580f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas i = ND->specific_attr_begin<FormatAttr>(), 1581f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas e = ND->specific_attr_end<FormatAttr>(); i != e ; ++i) { 1582f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas FormatAttr *PVFormat = *i; 1583f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // adjust for implicit parameter 1584f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 1585f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (MD->isInstance()) 1586f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas ++PVIndex; 1587f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // We also check if the formats are compatible. 1588f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // We can't pass a 'scanf' string to a 'printf' function. 1589f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (PVIndex == PVFormat->getFormatIdx() && 1590f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas Type == GetFormatStringType(PVFormat)) 1591f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas return true; 1592f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1593f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1594f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1595f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1596082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 15971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1598082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1599082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 1600d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 160152aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas case Stmt::CallExprClass: 160252aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas case Stmt::CXXMemberCallExprClass: { 16038f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const CallExpr *CE = cast<CallExpr>(E); 160452aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const NamedDecl *ND = dyn_cast_or_null<NamedDecl>(CE->getCalleeDecl())) { 160552aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) { 160652aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas unsigned ArgIndex = FA->getFormatIdx(); 160752aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 160852aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (MD->isInstance()) 160952aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas --ArgIndex; 161052aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas const Expr *Arg = CE->getArg(ArgIndex - 1); 161152aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas 161252aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas return SemaCheckStringLiteral(Arg, Args, NumArgs, HasVAListArg, 161352aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas format_idx, firstDataArg, Type, 161452aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas inFunctionCall); 16158f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 16168f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 16171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 16188f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson return false; 16198f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 1620082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::ObjCStringLiteralClass: 1621082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::StringLiteralClass: { 1622082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const StringLiteral *StrE = NULL; 16231eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1624082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 1625d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek StrE = ObjCFExpr->getString(); 1626d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek else 1627082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek StrE = cast<StringLiteral>(E); 16281eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1629d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek if (StrE) { 163029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas CheckFormatString(StrE, E, Args, NumArgs, HasVAListArg, format_idx, 163134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas firstDataArg, Type, inFunctionCall); 1632d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return true; 1633d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 16341eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1635d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return false; 1636d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 16371eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1638082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek default: 1639082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1640d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1641d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1642d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1643e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid 16441eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull, 1645909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr * const *ExprArgs, 1646909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky SourceLocation CallSiteLoc) { 1647cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt for (NonNullAttr::args_iterator i = NonNull->args_begin(), 1648cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt e = NonNull->args_end(); 1649e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian i != e; ++i) { 1650909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr *ArgExpr = ExprArgs[*i]; 16514e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (ArgExpr->isNullPointerConstant(Context, 1652ce94049b69f75b44c18584fe79cd238978b6b0d5Douglas Gregor Expr::NPC_ValueDependentIsNotNull)) 1653909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange(); 1654e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian } 1655e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian} 1656d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 165734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel DupasSema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) { 165834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas return llvm::StringSwitch<FormatStringType>(Format->getType()) 165934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("scanf", FST_Scanf) 166034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("printf", "printf0", FST_Printf) 166134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("NSString", "CFString", FST_NSString) 166234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("strftime", FST_Strftime) 166334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("strfmon", FST_Strfmon) 166434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf) 166534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Default(FST_Unknown); 166634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas} 166734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas 1668826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar 1669826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings. 167029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupasvoid Sema::CheckFormatArguments(const FormatAttr *Format, CallExpr *TheCall) { 167129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas bool IsCXXMember = false; 16724a2614e94672c47395abcde60518776fbebec589Sebastian Redl // The way the format attribute works in GCC, the implicit this argument 16734a2614e94672c47395abcde60518776fbebec589Sebastian Redl // of member functions is counted. However, it doesn't appear in our own 16744a2614e94672c47395abcde60518776fbebec589Sebastian Redl // lists, so decrement format_idx in that case. 167552aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas IsCXXMember = isa<CXXMemberCallExpr>(TheCall); 167629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas CheckFormatArguments(Format, TheCall->getArgs(), TheCall->getNumArgs(), 167729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas IsCXXMember, TheCall->getRParenLoc(), 167829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas TheCall->getCallee()->getSourceRange()); 167929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 168029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 168129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupasvoid Sema::CheckFormatArguments(const FormatAttr *Format, Expr **Args, 168229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas unsigned NumArgs, bool IsCXXMember, 168329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas SourceLocation Loc, SourceRange Range) { 168434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas bool HasVAListArg = Format->getFirstArg() == 0; 168534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned format_idx = Format->getFormatIdx() - 1; 168634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg = HasVAListArg ? 0 : Format->getFirstArg() - 1; 168734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas if (IsCXXMember) { 168834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas if (format_idx == 0) 168934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas return; 169034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas --format_idx; 169134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas if(firstDataArg != 0) 169234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas --firstDataArg; 169334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } 169434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas CheckFormatArguments(Args, NumArgs, HasVAListArg, format_idx, 169534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas firstDataArg, GetFormatStringType(Format), Loc, Range); 169629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 16974a2614e94672c47395abcde60518776fbebec589Sebastian Redl 169834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupasvoid Sema::CheckFormatArguments(Expr **Args, unsigned NumArgs, 169934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas bool HasVAListArg, unsigned format_idx, 170034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg, FormatStringType Type, 170134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas SourceLocation Loc, SourceRange Range) { 1702826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // CHECK: printf/scanf-like function is called with no format string. 170329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas if (format_idx >= NumArgs) { 170429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Loc, diag::warn_missing_format_string) << Range; 170571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek return; 170671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek } 17071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 170829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts(); 17091eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 171059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner // CHECK: format string is not a string literal. 17111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // 171271895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // Dynamically generated format strings are difficult to 171371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // automatically vet at compile time. Requiring that format strings 171471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // are string literals: (1) permits the checking of format strings by 171571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // the compiler and thereby (2) can practically remove the source of 171671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // many format string exploits. 17177ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek 17181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // Format string can be either ObjC string (e.g. @"%d") or 17197ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // C string (e.g. "%d") 17201eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // ObjC string uses the same format specifiers as C string, so we can use 17217ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // the same format string checking logic for both ObjC and C strings. 172229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas if (SemaCheckStringLiteral(OrigFormatExpr, Args, NumArgs, HasVAListArg, 172334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas format_idx, firstDataArg, Type)) 17241cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner return; // Literal format string found, check done! 17251cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner 17262837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas // Strftime is particular as it always uses a single 'time' argument, 17272837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas // so it is safe to pass a non-literal string. 17282837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas if (Type == FST_Strftime) 17292837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas return; 17302837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas 1731ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // Do not emit diag when the string param is a macro expansion and the 1732ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // format is either NSString or CFString. This is a hack to prevent 1733ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // diag when using the NSLocalizedString and CFCopyLocalizedString macros 1734ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // which are usually used in place of NS and CF string literals. 1735ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas if (Type == FST_NSString && Args[format_idx]->getLocStart().isMacroID()) 1736ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas return; 1737ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas 1738655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // If there are no arguments specified, warn with -Wformat-security, otherwise 1739655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // warn only with -Wformat-nonliteral. 174029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas if (NumArgs == format_idx+1) 174129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Args[format_idx]->getLocStart(), 1742826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral_noargs) 1743655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1744655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner else 174529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Args[format_idx]->getLocStart(), 1746826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral) 1747655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1748d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1749d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1750e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace { 1751826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler { 1752826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1753e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Sema &S; 1754e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const StringLiteral *FExpr; 1755e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const Expr *OrigFormatExpr; 17566ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const unsigned FirstDataArg; 1757e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const unsigned NumDataArgs; 1758e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const bool IsObjCLiteral; 1759e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *Beg; // Start of format string. 17600d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const bool HasVAListArg; 176129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const Expr * const *Args; 176229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const unsigned NumArgs; 17630d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek unsigned FormatIdx; 17647f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek llvm::BitVector CoveredArgs; 1765efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool usesPositionalArgs; 1766efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool atFirstArg; 176755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool inFunctionCall; 17684e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic: 1769826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 17706ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1771e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 17720d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const char *beg, bool hasVAListArg, 177329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **args, unsigned numArgs, 177429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas unsigned formatIdx, bool inFunctionCall) 1775e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 17766ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek FirstDataArg(firstDataArg), 17777f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek NumDataArgs(numDataArgs), 17780d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek IsObjCLiteral(isObjCLiteral), Beg(beg), 17790d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek HasVAListArg(hasVAListArg), 178029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Args(args), NumArgs(numArgs), FormatIdx(formatIdx), 178155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu usesPositionalArgs(false), atFirstArg(true), 178255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu inFunctionCall(inFunctionCall) { 17837f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.resize(numDataArgs); 17847f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.reset(); 17857f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 17864e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 178707d161f38e708a91486bf1c031d525faebbb249dTed Kremenek void DoneProcessing(); 17884e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1789826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIncompleteSpecifier(const char *startSpecifier, 1790826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 179176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 179276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg void HandleNonStandardLengthModifier( 179376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::LengthModifier &LM, 179476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen); 179576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 179676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg void HandleNonStandardConversionSpecifier( 179776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 179876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen); 179976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 180076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg void HandleNonStandardConversionSpecification( 180176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::LengthModifier &LM, 180276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 180376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen); 180476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 1805f85626453123f9691bcef13cff963f556e209c27Hans Wennborg virtual void HandlePosition(const char *startPos, unsigned posLen); 1806f85626453123f9691bcef13cff963f556e209c27Hans Wennborg 1807efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleInvalidPosition(const char *startSpecifier, 1808efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned specifierLen, 1809826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p); 1810efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1811efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 1812efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1813e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek void HandleNullChar(const char *nullCharacter); 18144e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 181555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 181655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu static void EmitFormatDiagnostic(Sema &S, bool inFunctionCall, 181755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 181855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 181955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation StringLoc, 182055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 182155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint Fixit = FixItHint()); 182255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 1823826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1824c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 1825c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1826c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1827c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, unsigned csLen); 182855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 182955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void HandlePositionalNonpositionalArgs(SourceLocation Loc, 183055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 183155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen); 1832c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1833f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek SourceRange getFormatStringRange(); 1834826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CharSourceRange getSpecifierRange(const char *startSpecifier, 1835826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1836e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek SourceLocation getLocationOfByte(const char *x); 18374e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 18380d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const Expr *getDataArg(unsigned i) const; 1839666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1840666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 1841666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1842666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, 1843666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek unsigned argIndex); 184455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 184555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 184655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc, 184755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 184855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint Fixit = FixItHint()); 184955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 185055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void CheckPositionalAndNonpositionalArgs( 185155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const analyze_format_string::FormatSpecifier *FS); 1852e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}; 1853e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1854e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1855826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() { 1856e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return OrigFormatExpr->getSourceRange(); 1857e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1858e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1859826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler:: 1860826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 186145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation Start = getLocationOfByte(startSpecifier); 186245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 186345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 186445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care // Advance the end SourceLocation by one due to half-open ranges. 1865a64ccefdf0ea4e03ec88805d71b0af74950c7472Argyrios Kyrtzidis End = End.getLocWithOffset(1); 186645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 186745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care return CharSourceRange::getCharRange(Start, End); 1868f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek} 1869f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek 1870826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 18714e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 1872e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1873e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1874826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 1875826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen){ 187655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier), 187755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startSpecifier), 187855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 187955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 1880808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek} 1881808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek 188276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardLengthModifier( 188376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::LengthModifier &LM, 188476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen) { 188576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) << LM.toString() 1886f85626453123f9691bcef13cff963f556e209c27Hans Wennborg << 0, 188776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg getLocationOfByte(LM.getStart()), 188876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg /*IsStringLocation*/true, 188976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg getSpecifierRange(startSpecifier, specifierLen)); 189076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg} 189176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 189276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardConversionSpecifier( 189376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 189476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen) { 189576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) << CS.toString() 1896f85626453123f9691bcef13cff963f556e209c27Hans Wennborg << 1, 189776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg getLocationOfByte(CS.getStart()), 189876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg /*IsStringLocation*/true, 189976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg getSpecifierRange(startSpecifier, specifierLen)); 190076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg} 190176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 190276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardConversionSpecification( 190376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::LengthModifier &LM, 190476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 190576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen) { 190676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_conversion_spec) 190776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg << LM.toString() << CS.toString(), 190876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg getLocationOfByte(LM.getStart()), 190976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg /*IsStringLocation*/true, 191076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg getSpecifierRange(startSpecifier, specifierLen)); 191176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg} 191276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 1913f85626453123f9691bcef13cff963f556e209c27Hans Wennborgvoid CheckFormatHandler::HandlePosition(const char *startPos, 1914f85626453123f9691bcef13cff963f556e209c27Hans Wennborg unsigned posLen) { 1915f85626453123f9691bcef13cff963f556e209c27Hans Wennborg EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_positional_arg), 1916f85626453123f9691bcef13cff963f556e209c27Hans Wennborg getLocationOfByte(startPos), 1917f85626453123f9691bcef13cff963f556e209c27Hans Wennborg /*IsStringLocation*/true, 1918f85626453123f9691bcef13cff963f556e209c27Hans Wennborg getSpecifierRange(startPos, posLen)); 1919f85626453123f9691bcef13cff963f556e209c27Hans Wennborg} 1920f85626453123f9691bcef13cff963f556e209c27Hans Wennborg 1921efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid 1922826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 1923826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p) { 192455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier) 192555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (unsigned) p, 192655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), /*IsStringLocation*/true, 192755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 1928efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1929efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1930826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos, 1931efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned posLen) { 193255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier), 193355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), 193455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 193555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 1936efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1937efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1938826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 19390c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek if (!IsObjCLiteral) { 19400c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek // The presence of a null character is likely an error. 194155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 194255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_format_string_contains_null_char), 194355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(nullCharacter), /*IsStringLocation*/true, 194455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getFormatStringRange()); 19450c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek } 1946826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1947826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1948826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const { 194929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return Args[FirstDataArg + i]; 1950826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 19514e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1952826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() { 1953826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Does the number of data arguments exceed the number of 1954826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // format conversions in the format string? 1955826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!HasVAListArg) { 1956826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Find any arguments that weren't covered. 1957826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.flip(); 1958826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek signed notCoveredArg = CoveredArgs.find_first(); 1959826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (notCoveredArg >= 0) { 1960826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek assert((unsigned)notCoveredArg < NumDataArgs); 196155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_data_arg_not_used), 196255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getDataArg((unsigned) notCoveredArg)->getLocStart(), 196355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/false, getFormatStringRange()); 1964826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1965826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1966826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1967826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1968c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool 1969c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 1970c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek SourceLocation Loc, 1971c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1972c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1973c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, 1974c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned csLen) { 1975c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1976c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool keepGoing = true; 1977c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek if (argIndex < NumDataArgs) { 1978c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // Consider the argument coverered, even though the specifier doesn't 1979c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // make sense. 1980c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CoveredArgs.set(argIndex); 1981c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1982c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek else { 1983c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // If argIndex exceeds the number of data arguments we 1984c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // don't issue a warning because that is just a cascade of warnings (and 1985c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // they may have intended '%%' anyway). We don't want to continue processing 1986c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // the format string after this point, however, as we will like just get 1987c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // gibberish when trying to match arguments. 1988c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek keepGoing = false; 1989c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1990c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 199155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_conversion) 199255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << StringRef(csStart, csLen), 199355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*IsStringLocation*/true, 199455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpec, specifierLen)); 1995c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1996c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return keepGoing; 1997c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1998c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 199955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid 200055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard TrieuCheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc, 200155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 200255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen) { 200355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 200455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_format_mix_positional_nonpositional_args), 200555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen)); 200655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 200755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2008666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool 2009666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs( 2010666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::FormatSpecifier &FS, 2011666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 2012666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 2013666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 2014666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (argIndex >= NumDataArgs) { 201555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag = FS.usesPositionalArg() 201655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args) 201755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (argIndex+1) << NumDataArgs) 201855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : S.PDiag(diag::warn_printf_insufficient_data_args); 201955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 202055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true, 202155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 2022666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return false; 2023666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 2024666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return true; 2025666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek} 2026666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 202755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 202855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag, 202955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 203055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 203155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 203255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint FixIt) { 203329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag, 203455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, IsStringLocation, StringRange, FixIt); 203555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 203655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 203755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \brief If the format string is not within the funcion call, emit a note 203855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// so that the function call and string are in diagnostic messages. 203955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 204055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param inFunctionCall if true, the format string is within the function 204155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// call and only one diagnostic message will be produced. Otherwise, an 204255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// extra note will be emitted pointing to location of the format string. 204355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 204455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param ArgumentExpr the expression that is passed as the format string 204555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// argument in the function call. Used for getting locations when two 204655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostics are emitted. 204755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 204855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param PDiag the callee should already have provided any strings for the 204955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostic message. This function only adds locations and fixits 205055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// to diagnostics. 205155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 205255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param Loc primary location for diagnostic. If two diagnostics are 205355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// required, one will be at Loc and a new SourceLocation will be created for 205455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// the other one. 205555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 205655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param IsStringLocation if true, Loc points to the format string should be 205755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// used for the note. Otherwise, Loc points to the argument list and will 205855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// be used with PDiag. 205955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 206055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param StringRange some or all of the string to highlight. This is 206155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// templated so it can accept either a CharSourceRange or a SourceRange. 206255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 206355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param Fixit optional fix it hint for the format string. 206455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 206555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(Sema &S, bool InFunctionCall, 206655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 206755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 206855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 206955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 207055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 207155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint FixIt) { 207255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu if (InFunctionCall) 207355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.Diag(Loc, PDiag) << StringRange << FixIt; 207455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu else { 207555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag) 207655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ArgumentExpr->getSourceRange(); 207755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.Diag(IsStringLocation ? Loc : StringRange.getBegin(), 207855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu diag::note_format_string_defined) 207955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << StringRange << FixIt; 208055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu } 208155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 208255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2083826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===// 2084826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2085826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 2086826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler { 2087826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 2088826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 2089826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 2090826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 2091826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 209229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **Args, unsigned NumArgs, 209329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas unsigned formatIdx, bool inFunctionCall) 2094826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 2095826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 209629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Args, NumArgs, formatIdx, inFunctionCall) {} 2097826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2098826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2099826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleInvalidPrintfConversionSpecifier( 2100826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2101826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2102826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2103826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2104826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 2105826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2106826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2107826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2108826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 2109826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2110826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 2111826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalAmount &Amt, 2112826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned type, 2113826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2114826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 2115826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 2116826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2117826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 2118826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &ignoredFlag, 2119826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 2120826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2121826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 2122826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2123826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2124826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 2125826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2126826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2127826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 21286ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 2129c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 2130826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2131c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 2132c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 2133c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 2134c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 213526ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek} 213626ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek 2137826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount( 2138826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_format_string::OptionalAmount &Amt, 2139826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned k, const char *startSpecifier, 2140826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 21410d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 21420d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (Amt.hasDataArgument()) { 21430d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (!HasVAListArg) { 21447f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = Amt.getArgIndex(); 21457f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (argIndex >= NumDataArgs) { 214655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg) 214755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << k, 214855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 214955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 215055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 21510d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 21520d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 21530d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 21540d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 21554e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 21560d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Type check the data argument. It should be an 'int'. 215731f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // Although not in conformance with C99, we also allow the argument to be 215831f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // an 'unsigned int' as that is a reasonably safe case. GCC also 215931f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // doesn't emit a warning for that case. 21607f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.set(argIndex); 21617f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek const Expr *Arg = getDataArg(argIndex); 21620d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek QualType T = Arg->getType(); 21634e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 21644e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context); 21654e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek assert(ATR.isValid()); 21664e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 21674e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (!ATR.matchesType(S.Context, T)) { 216855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type) 2169a792aff1c7de253b89c473fdb7eef4a5bba83aecHans Wennborg << k << ATR.getRepresentativeTypeName(S.Context) 217055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << T << Arg->getSourceRange(), 217155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 217255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 217355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 21740d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 21750d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 21760d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 21770d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 21780d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 21790d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 21800d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return true; 21810d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek} 21820d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 2183e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount( 2184826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2185e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalAmount &Amt, 2186e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned type, 2187e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2188e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 21896ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 21906ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 2191e4ee9663168dfb2b4122c768091e30217328c9faTom Care 219255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint fixit = 219355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant 219455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 219555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getConstantLength())) 219655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : FixItHint(); 219755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 219855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount) 219955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << type << CS.toString(), 220055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 220155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 220255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 220355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu fixit); 2204e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2205e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2206826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 2207e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 2208e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2209e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 2210e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about pointless flag with a fixit removal. 22116ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 22126ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 221355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag) 221455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << flag.toString() << CS.toString(), 221555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(flag.getPosition()), 221655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 221755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 221855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 221955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(flag.getPosition(), 1))); 2220e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2221e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2222e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag( 2223826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2224e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &ignoredFlag, 2225e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 2226e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2227e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 2228e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about ignored flag with a fixit removal. 222955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag) 223055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ignoredFlag.toString() << flag.toString(), 223155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(ignoredFlag.getPosition()), 223255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 223355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 223455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 223555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(ignoredFlag.getPosition(), 1))); 2236e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2237e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2238e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool 2239826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 22405c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek &FS, 2241e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *startSpecifier, 2242e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned specifierLen) { 2243e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 22446ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek using namespace analyze_format_string; 2245efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek using namespace analyze_printf; 22466ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 2247e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2248baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 2249baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 2250baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 2251baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 2252baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2253baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 225455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 225555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 2256baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 2257baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2258efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek } 2259efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 22600d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // First check if the field width, precision, and conversion specifier 22610d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // have matching data arguments. 2262efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 2263efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 22640d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 22650d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 22664e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2267efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 2268efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 22690d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 22700d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 22710d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 2272f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek if (!CS.consumesDataArgument()) { 2273f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // FIXME: Technically specifying a precision or field width here 2274f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // makes no sense. Worth issuing a warning at some point. 22750e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek return true; 2276f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek } 22774e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 22787f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Consume the argument. 22797f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = FS.getArgIndex(); 2280e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek if (argIndex < NumDataArgs) { 2281e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // The check to see if the argIndex is valid will come later. 2282e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // We set the bit here because we may exit early from this 2283e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // function if we encounter some other error. 2284e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek CoveredArgs.set(argIndex); 2285e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek } 22867f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek 22877f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Check for using an Objective-C specific conversion specifier 22887f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // in a non-ObjC literal. 22897f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (!IsObjCLiteral && CS.isObjCArg()) { 2290826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 2291826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek specifierLen); 22927f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 22934e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2294e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of field width 2295e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidFieldWidth()) { 229645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 2297e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2298e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2299e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2300e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of precision 2301e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPrecision()) { 2302e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 2303e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2304e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2305e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2306e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check each flag does not conflict with any other component. 230765197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek if (!FS.hasValidThousandsGroupingPrefix()) 230865197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen); 2309e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeadingZeros()) 2310e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 2311e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPlusPrefix()) 2312e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 231345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (!FS.hasValidSpacePrefix()) 231445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 2315e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidAlternativeForm()) 2316e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 2317e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeftJustified()) 2318e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 2319e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2320e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check that flags are not ignored by another flag 232145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 232245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 232345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care startSpecifier, specifierLen); 2324e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 2325e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 2326e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2327e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2328e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check the length modifier is valid with the given conversion specifier. 2329e4ee9663168dfb2b4122c768091e30217328c9faTom Care const LengthModifier &LM = FS.getLengthModifier(); 2330e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLengthModifier()) 233155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_nonsensical_length) 233255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << LM.toString() << CS.toString(), 233355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(LM.getStart()), 233455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 233555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 233655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 233755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(LM.getStart(), 233855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu LM.getLength()))); 233976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg if (!FS.hasStandardLengthModifier()) 234076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg HandleNonStandardLengthModifier(LM, startSpecifier, specifierLen); 23414e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 234276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 234376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg if (!FS.hasStandardLengthConversionCombination()) 234476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg HandleNonStandardConversionSpecification(LM, CS, startSpecifier, 234576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg specifierLen); 2346e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2347e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Are we using '%n'? 234835d353b47bce29200b910371dd9b8ba7f3058ab8Ted Kremenek if (CS.getKind() == ConversionSpecifier::nArg) { 2349e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Issue a warning about this being a possible security issue. 235055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_write_back), 235155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(CS.getStart()), 235255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 235355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 2354e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek // Continue checking the other format specifiers. 2355e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek return true; 2356e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek } 23575c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek 2358da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek // The remaining checks depend on the data arguments. 2359da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek if (HasVAListArg) 2360da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return true; 23614e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2362666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 2363da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return false; 23644e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 236596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Now type check the data expression that matches the 236696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // format specifier. 236796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const Expr *Ex = getDataArg(argIndex); 2368339b9072e26a2a0fe796dc69c4d28d964d0ec86dNico Weber const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context, 2369339b9072e26a2a0fe796dc69c4d28d964d0ec86dNico Weber IsObjCLiteral); 237096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) { 237196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Check if we didn't match because of an implicit cast from a 'char' 237296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // or 'short' to an 'int'. This is done because printf is a varargs 237396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // function. 237496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex)) 23754d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ICE->getType() == S.Context.IntTy) { 23764d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek // All further checking is done on the subexpression. 23774d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek Ex = ICE->getSubExpr(); 23784d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ATR.matchesType(S.Context, Ex->getType())) 237996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer return true; 23804d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek } 238196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 238296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // We may be able to offer a FixItHint if it is a supported type. 238396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer PrintfSpecifier fixedFS = FS; 23844e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie bool success = fixedFS.fixType(Ex->getType(), S.getLangOpts(), 2385be6126a2a784e1446460b8d15c2b26f880c871fcHans Wennborg S.Context, IsObjCLiteral); 238696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 238796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (success) { 238896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Get the fix string from the fixed format specifier 2389f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> buf; 239096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::raw_svector_ostream os(buf); 239196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer fixedFS.toString(os); 239296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 239355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 239455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 2395a792aff1c7de253b89c473fdb7eef4a5bba83aecHans Wennborg << ATR.getRepresentativeTypeName(S.Context) << Ex->getType() 239655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << Ex->getSourceRange(), 239755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(CS.getStart()), 239855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 239955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 240055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateReplacement( 240155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 240255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu os.str())); 240396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 240496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer else { 2405220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas EmitFormatDiagnostic( 2406220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 2407220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << ATR.getRepresentativeTypeName(S.Context) << Ex->getType() 2408220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << getSpecifierRange(startSpecifier, specifierLen) 2409220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << Ex->getSourceRange(), 2410220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas getLocationOfByte(CS.getStart()), 2411220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas true, 2412220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas getSpecifierRange(startSpecifier, specifierLen)); 241396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 241496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 241596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2416e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return true; 2417e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2418e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2419826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===// 2420826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2421826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 2422826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler { 2423826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 2424826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 2425826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 2426826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 2427826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 242829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **Args, unsigned NumArgs, 242929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas unsigned formatIdx, bool inFunctionCall) 2430826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 2431826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 243229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Args, NumArgs, formatIdx, inFunctionCall) {} 2433826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2434826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 2435826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2436826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2437c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2438c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidScanfConversionSpecifier( 2439c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2440c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 2441c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen); 2442b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 2443b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek void HandleIncompleteScanList(const char *start, const char *end); 2444826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 2445826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2446826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2447b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start, 2448b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek const char *end) { 244955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete), 245055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(end), /*IsStringLocation*/true, 245155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(start, end - start)); 2452b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek} 2453b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 2454c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 2455c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2456c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 2457c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen) { 2458c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 24596ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_scanf::ScanfConversionSpecifier &CS = 2460c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 2461c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2462c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 2463c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 2464c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 2465c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 2466c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 2467c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2468826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier( 2469826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2470826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2471826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 2472826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2473826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_scanf; 2474826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_format_string; 2475826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 24766ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 2477826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2478baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Handle case where '%' and '*' don't consume an argument. These shouldn't 2479baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // be used to decide if we are using positional arguments consistently. 2480baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 2481baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 2482baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 2483baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 2484baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2485baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 248655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 248755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 2488baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 2489baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2490826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2491826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2492826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Check if the field with is non-zero. 2493826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const OptionalAmount &Amt = FS.getFieldWidth(); 2494826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getHowSpecified() == OptionalAmount::Constant) { 2495826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getConstantAmount() == 0) { 2496826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 2497826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Amt.getConstantLength()); 249855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width), 249955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 250055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, R, 250155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval(R)); 25027f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 25037f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 2504826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2505826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!FS.consumesDataArgument()) { 2506826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Technically specifying a precision or field width here 2507826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // makes no sense. Worth issuing a warning at some point. 2508826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 2509826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2510826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2511826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Consume the argument. 2512826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned argIndex = FS.getArgIndex(); 2513826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (argIndex < NumDataArgs) { 2514826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The check to see if the argIndex is valid will come later. 2515826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // We set the bit here because we may exit early from this 2516826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // function if we encounter some other error. 2517826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.set(argIndex); 2518826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2519826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 25201e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek // Check the length modifier is valid with the given conversion specifier. 25211e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek const LengthModifier &LM = FS.getLengthModifier(); 25221e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek if (!FS.hasValidLengthModifier()) { 2523220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas const CharSourceRange &R = getSpecifierRange(LM.getStart(), LM.getLength()); 2524220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas EmitFormatDiagnostic(S.PDiag(diag::warn_format_nonsensical_length) 2525220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << LM.toString() << CS.toString() 2526220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << getSpecifierRange(startSpecifier, specifierLen), 2527220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas getLocationOfByte(LM.getStart()), 2528220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas /*IsStringLocation*/true, R, 2529220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas FixItHint::CreateRemoval(R)); 25301e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek } 25311e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek 253276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg if (!FS.hasStandardLengthModifier()) 253376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg HandleNonStandardLengthModifier(LM, startSpecifier, specifierLen); 25344e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 253576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 253676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg if (!FS.hasStandardLengthConversionCombination()) 253776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg HandleNonStandardConversionSpecification(LM, CS, startSpecifier, 253876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg specifierLen); 253976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 2540826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The remaining checks depend on the data arguments. 2541826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (HasVAListArg) 2542826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 2543826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2544666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 2545826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return false; 2546826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 25476fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Check that the argument type matches the format specifier. 25486fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg const Expr *Ex = getDataArg(argIndex); 25496fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg const analyze_scanf::ScanfArgTypeResult &ATR = FS.getArgType(S.Context); 25506fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) { 25516fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg ScanfSpecifier fixedFS = FS; 25524e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie bool success = fixedFS.fixType(Ex->getType(), S.getLangOpts(), 2553be6126a2a784e1446460b8d15c2b26f880c871fcHans Wennborg S.Context); 25546fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 25556fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg if (success) { 25566fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Get the fix string from the fixed format specifier. 2557f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> buf; 25586fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg llvm::raw_svector_ostream os(buf); 25596fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg fixedFS.toString(os); 25606fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 25616fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg EmitFormatDiagnostic( 25626fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 25636fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg << ATR.getRepresentativeTypeName(S.Context) << Ex->getType() 25646fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg << Ex->getSourceRange(), 25656fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getLocationOfByte(CS.getStart()), 25666fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg /*IsStringLocation*/true, 25676fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 25686fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg FixItHint::CreateReplacement( 25696fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 25706fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg os.str())); 25716fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } else { 2572220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas EmitFormatDiagnostic( 2573220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 25746fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg << ATR.getRepresentativeTypeName(S.Context) << Ex->getType() 2575220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << Ex->getSourceRange(), 2576220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas getLocationOfByte(CS.getStart()), 2577220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas /*IsStringLocation*/true, 2578220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas getSpecifierRange(startSpecifier, specifierLen)); 25796fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 25806fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 25816fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 2582826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 258307d161f38e708a91486bf1c031d525faebbb249dTed Kremenek} 2584e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2585826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr, 25860e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const Expr *OrigFormatExpr, 258729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **Args, unsigned NumArgs, 258829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas bool HasVAListArg, unsigned format_idx, 258934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg, FormatStringType Type, 259029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas bool inFunctionCall) { 2591826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2592e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: is the format string a wide literal? 25935cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!FExpr->isAscii()) { 259455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 259529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas *this, inFunctionCall, Args[format_idx], 259655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(), 259755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 2598e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 2599e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 2600826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2601e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // Str - The format string. NOTE: this is NOT null-terminated! 26025f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef StrRef = FExpr->getString(); 26032f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer const char *Str = StrRef.data(); 26042f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer unsigned StrLen = StrRef.size(); 260529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const unsigned numDataArgs = NumArgs - firstDataArg; 2606826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2607e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: empty format string? 26084cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek if (StrLen == 0 && numDataArgs > 0) { 260955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 261029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas *this, inFunctionCall, Args[format_idx], 261155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_empty_format_string), FExpr->getLocStart(), 261255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 2613e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 2614e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 2615826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 261634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas if (Type == FST_Printf || Type == FST_NSString) { 2617826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 26184cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek numDataArgs, isa<ObjCStringLiteral>(OrigFormatExpr), 261929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Str, HasVAListArg, Args, NumArgs, format_idx, 262055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu inFunctionCall); 2621826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2622d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen, 26234e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts())) 2624826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 262534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } else if (Type == FST_Scanf) { 2626826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 26274cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek numDataArgs, isa<ObjCStringLiteral>(OrigFormatExpr), 262829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Str, HasVAListArg, Args, NumArgs, format_idx, 262955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu inFunctionCall); 2630826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2631d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen, 26324e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie getLangOpts())) 2633826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 263434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } // TODO: handle other formats 2635ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek} 2636ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek 26377ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth//===--- CHECK: Standard memory functions ---------------------------------===// 26387ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 26392a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// \brief Determine whether the given type is a dynamic class type (e.g., 26402a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// whether it has a vtable). 26412a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregorstatic bool isDynamicClassType(QualType T) { 26422a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Record = T->getAsCXXRecordDecl()) 26432a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Definition = Record->getDefinition()) 26442a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (Definition->isDynamicClass()) 26452a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return true; 26462a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 26472a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return false; 26482a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor} 26492a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 2650a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument expression, 2651000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth/// otherwise returns NULL. 2652000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic const Expr *getSizeOfExprArg(const Expr* E) { 2653e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber if (const UnaryExprOrTypeTraitExpr *SizeOf = 2654000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 2655000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType()) 2656000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getArgumentExpr()->IgnoreParenImpCasts(); 2657e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 2658000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return 0; 2659000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth} 2660000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2661a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument type. 2662000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic QualType getSizeOfArgType(const Expr* E) { 2663000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryExprOrTypeTraitExpr *SizeOf = 2664000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 2665000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf) 2666000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getTypeOfArgument(); 2667000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2668000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return QualType(); 2669e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber} 2670e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 26717ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \brief Check for dangerous or invalid arguments to memset(). 26727ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 2673929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth/// This issues warnings on known problematic, dangerous or unspecified 2674cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp' 2675cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// function calls. 26767ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 26777ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \param Call The call expression to diagnose. 2678cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gayvoid Sema::CheckMemaccessArguments(const CallExpr *Call, 26790a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned BId, 2680cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay IdentifierInfo *FnName) { 26810a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks assert(BId != 0); 26820a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 26831d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek // It is possible to have a non-standard definition of memset. Validate 2684707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor // we have enough arguments, and if not, abort further checking. 26850a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned ExpectedNumArgs = (BId == Builtin::BIstrndup ? 2 : 3); 2686cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber if (Call->getNumArgs() < ExpectedNumArgs) 26871d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek return; 26881d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek 26890a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LastArg = (BId == Builtin::BImemset || 26900a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId == Builtin::BIstrndup ? 1 : 2); 26910a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LenArg = (BId == Builtin::BIstrndup ? 1 : 2); 2692cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts(); 2693000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2694000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We have special checking when the length is a sizeof expression. 2695000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth QualType SizeOfArgTy = getSizeOfArgType(LenExpr); 2696000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth const Expr *SizeOfArg = getSizeOfExprArg(LenExpr); 2697000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID SizeOfArgID; 2698000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 269906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) { 270006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts(); 2701e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange(); 270206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 270306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType DestTy = Dest->getType(); 270406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) { 270506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType PointeeTy = DestPtrTy->getPointeeType(); 2706f85e193739c953358c865005855253af4f68a497John McCall 2707000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Never warn about void type pointers. This can be used to suppress 2708000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // false positives. 2709000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isVoidType()) 271006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 271106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 2712000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by 2713000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // actually comparing the expressions for equality. Because computing the 2714000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // expression IDs can be expensive, we only do this if the diagnostic is 2715000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // enabled. 2716000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArg && 2717000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess, 2718000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->getExprLoc())) { 2719000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We only compute IDs for expressions if the warning is enabled, and 2720000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // cache the sizeof arg's ID. 2721000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgID == llvm::FoldingSetNodeID()) 2722000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->Profile(SizeOfArgID, Context, true); 2723000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID DestID; 2724000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Dest->Profile(DestID, Context, true); 2725000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (DestID == SizeOfArgID) { 2726cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // TODO: For strncpy() and friends, this could suggest sizeof(dst) 2727cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // over sizeof(src) as well. 2728000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth unsigned ActionIdx = 0; // Default is to suggest dereferencing. 2729000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest)) 2730000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (UnaryOp->getOpcode() == UO_AddrOf) 2731000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 1; // If its an address-of operator, just remove it. 2732000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (Context.getTypeSize(PointeeTy) == Context.getCharWidth()) 2733000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 2; // If the pointee's size is sizeof(char), 2734000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // suggest an explicit length. 2735d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks unsigned DestSrcSelect = 27360a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks (BId == Builtin::BIstrndup ? 1 : ArgIdx); 2737000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(SizeOfArg->getExprLoc(), Dest, 2738000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_expr_memaccess) 2739cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber << FnName << DestSrcSelect << ActionIdx 2740000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << Dest->getSourceRange() 2741000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << SizeOfArg->getSourceRange()); 2742000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 2743000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 2744000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 2745000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2746000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Also check for cases where the sizeof argument is the exact same 2747000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // type as the memory argument, and where it points to a user-defined 2748000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // record type. 2749000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgTy != QualType()) { 2750000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isRecordType() && 2751000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Context.typesAreCompatible(SizeOfArgTy, DestTy)) { 2752000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest, 2753000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_type_memaccess) 2754000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << FnName << SizeOfArgTy << ArgIdx 2755000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << PointeeTy << Dest->getSourceRange() 2756000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << LenExpr->getSourceRange()); 2757000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 2758000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 2759e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber } 2760e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 276106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor // Always complain about dynamic classes. 27620a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (isDynamicClassType(PointeeTy)) { 27630a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 27640a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned OperationType = 0; 27650a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // "overwritten" if we're warning about the destination for any call 27660a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // but memcmp; otherwise a verb appropriate to the call. 27670a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (ArgIdx != 0 || BId == Builtin::BImemcmp) { 27680a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (BId == Builtin::BImemcpy) 27690a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 1; 27700a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if(BId == Builtin::BImemmove) 27710a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 2; 27720a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if (BId == Builtin::BImemcmp) 27730a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 3; 27740a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } 27750a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 27765c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 27775c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 27785c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_dyn_class_memaccess) 27790a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx) 2780d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks << FnName << PointeeTy 27810a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << OperationType 27825c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 27830a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } else if (PointeeTy.hasNonTrivialObjCLifetime() && 27840a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId != Builtin::BImemset) 27855c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 27865c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 27875c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_arc_object_memaccess) 27885c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << ArgIdx << FnName << PointeeTy 27895c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 2790f85e193739c953358c865005855253af4f68a497John McCall else 279106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 2792f85e193739c953358c865005855253af4f68a497John McCall 2793f85e193739c953358c865005855253af4f68a497John McCall DiagRuntimeBehavior( 2794f85e193739c953358c865005855253af4f68a497John McCall Dest->getExprLoc(), Dest, 2795929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth PDiag(diag::note_bad_memaccess_silence) 279606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)")); 279706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor break; 279806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 27997ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth } 28007ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth} 28017ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 2802bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// A little helper routine: ignore addition and subtraction of integer literals. 2803bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// This intentionally does not ignore all integer constant expressions because 2804bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// we don't want to remove sizeof(). 2805bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekstatic const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) { 2806bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = Ex->IgnoreParenCasts(); 2807bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2808bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek for (;;) { 2809bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex); 2810bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!BO || !BO->isAdditiveOp()) 2811bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 2812bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2813bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *RHS = BO->getRHS()->IgnoreParenCasts(); 2814bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *LHS = BO->getLHS()->IgnoreParenCasts(); 2815bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2816bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (isa<IntegerLiteral>(RHS)) 2817bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = LHS; 2818bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else if (isa<IntegerLiteral>(LHS)) 2819bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = RHS; 2820bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else 2821bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 2822bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2823bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2824bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return Ex; 2825bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 2826bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2827bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// Warn if the user has made the 'size' argument to strlcpy or strlcat 2828bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// be the size of the source, instead of the destination. 2829bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekvoid Sema::CheckStrlcpycatArguments(const CallExpr *Call, 2830bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek IdentifierInfo *FnName) { 2831bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2832bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Don't crash if the user has the wrong number of arguments 2833bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (Call->getNumArgs() != 3) 2834bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2835bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2836bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context); 2837bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context); 2838bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *CompareWithSrc = NULL; 2839bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2840bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, sizeof(x))' 2841bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const Expr *Ex = getSizeOfExprArg(SizeArg)) 2842bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = Ex; 2843bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else { 2844bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, strlen(x))' 2845bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) { 2846180f47959a066795cc0f409433023af448bb0328Richard Smith if (SizeCall->isBuiltinCall() == Builtin::BIstrlen 2847bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek && SizeCall->getNumArgs() == 1) 2848bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context); 2849bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2850bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2851bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2852bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrc) 2853bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2854bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2855bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Determine if the argument to sizeof/strlen is equal to the source 2856bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // argument. In principle there's all kinds of things you could do 2857bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // here, for instance creating an == expression and evaluating it with 2858bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // EvaluateAsBooleanCondition, but this uses a more direct technique: 2859bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg); 2860bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!SrcArgDRE) 2861bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2862bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2863bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc); 2864bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrcDRE || 2865bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl()) 2866bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2867bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2868bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *OriginalSizeArg = Call->getArg(2); 2869bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size) 2870bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek << OriginalSizeArg->getSourceRange() << FnName; 2871bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2872bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Output a FIXIT hint if the destination is an array (rather than a 2873bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointer to an array). This could be enhanced to handle some 2874bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointers if we know the actual size, like if DstArg is 'array+2' 2875bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // we could say 'sizeof(array)-2'. 2876bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts(); 28778f7462237ff542a4556775f98709ed300aa1731aTed Kremenek QualType DstArgTy = DstArg->getType(); 2878bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 28798f7462237ff542a4556775f98709ed300aa1731aTed Kremenek // Only handle constant-sized or VLAs, but not flexible members. 28808f7462237ff542a4556775f98709ed300aa1731aTed Kremenek if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(DstArgTy)) { 28818f7462237ff542a4556775f98709ed300aa1731aTed Kremenek // Only issue the FIXIT for arrays of size > 1. 28828f7462237ff542a4556775f98709ed300aa1731aTed Kremenek if (CAT->getSize().getSExtValue() <= 1) 28838f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 28848f7462237ff542a4556775f98709ed300aa1731aTed Kremenek } else if (!DstArgTy->isVariableArrayType()) { 28858f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 2886bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 28878f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 2888f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> sizeString; 28898f7462237ff542a4556775f98709ed300aa1731aTed Kremenek llvm::raw_svector_ostream OS(sizeString); 28908f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << "sizeof("; 28918987b2385d9ba63ada66e1344ace79b04d5cb5c3Douglas Gregor DstArg->printPretty(OS, Context, 0, getPrintingPolicy()); 28928f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << ")"; 28938f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 28948f7462237ff542a4556775f98709ed300aa1731aTed Kremenek Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size) 28958f7462237ff542a4556775f98709ed300aa1731aTed Kremenek << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(), 28968f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS.str()); 2897bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 2898bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2899c36bedc90c687caa71748480c60707ea4608b092Anna Zaks/// Check if two expressions refer to the same declaration. 2900c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic bool referToTheSameDecl(const Expr *E1, const Expr *E2) { 2901c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const DeclRefExpr *D1 = dyn_cast_or_null<DeclRefExpr>(E1)) 2902c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const DeclRefExpr *D2 = dyn_cast_or_null<DeclRefExpr>(E2)) 2903c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return D1->getDecl() == D2->getDecl(); 2904c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return false; 2905c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 2906c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 2907c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic const Expr *getStrlenExprArg(const Expr *E) { 2908c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const CallExpr *CE = dyn_cast<CallExpr>(E)) { 2909c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const FunctionDecl *FD = CE->getDirectCallee(); 2910c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (!FD || FD->getMemoryFunctionKind() != Builtin::BIstrlen) 2911c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return 0; 2912c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return CE->getArg(0)->IgnoreParenCasts(); 2913c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 2914c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return 0; 2915c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 2916c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 2917c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// Warn on anti-patterns as the 'size' argument to strncat. 2918c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// The correct size argument should look like following: 2919c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// strncat(dst, src, sizeof(dst) - strlen(dest) - 1); 2920c36bedc90c687caa71748480c60707ea4608b092Anna Zaksvoid Sema::CheckStrncatArguments(const CallExpr *CE, 2921c36bedc90c687caa71748480c60707ea4608b092Anna Zaks IdentifierInfo *FnName) { 2922c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Don't crash if the user has the wrong number of arguments. 2923c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (CE->getNumArgs() < 3) 2924c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 2925c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *DstArg = CE->getArg(0)->IgnoreParenCasts(); 2926c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *SrcArg = CE->getArg(1)->IgnoreParenCasts(); 2927c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *LenArg = CE->getArg(2)->IgnoreParenCasts(); 2928c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 2929c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Identify common expressions, which are wrongly used as the size argument 2930c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // to strncat and may lead to buffer overflows. 2931c36bedc90c687caa71748480c60707ea4608b092Anna Zaks unsigned PatternType = 0; 2932c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const Expr *SizeOfArg = getSizeOfExprArg(LenArg)) { 2933c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(dst) 2934c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (referToTheSameDecl(SizeOfArg, DstArg)) 2935c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 1; 2936c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(src) 2937c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (referToTheSameDecl(SizeOfArg, SrcArg)) 2938c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 2; 2939c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } else if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(LenArg)) { 2940c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (BE->getOpcode() == BO_Sub) { 2941c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *L = BE->getLHS()->IgnoreParenCasts(); 2942c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *R = BE->getRHS()->IgnoreParenCasts(); 2943c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(dst) - strlen(dst) 2944c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (referToTheSameDecl(DstArg, getSizeOfExprArg(L)) && 2945c36bedc90c687caa71748480c60707ea4608b092Anna Zaks referToTheSameDecl(DstArg, getStrlenExprArg(R))) 2946c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 1; 2947c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(src) - (anything) 2948c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (referToTheSameDecl(SrcArg, getSizeOfExprArg(L))) 2949c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 2; 2950c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 2951c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 2952c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 2953c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (PatternType == 0) 2954c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 2955c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 2956afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks // Generate the diagnostic. 2957afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceLocation SL = LenArg->getLocStart(); 2958afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceRange SR = LenArg->getSourceRange(); 2959afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceManager &SM = PP.getSourceManager(); 2960afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks 2961afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks // If the function is defined as a builtin macro, do not show macro expansion. 2962afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks if (SM.isMacroArgExpansion(SL)) { 2963afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SL = SM.getSpellingLoc(SL); 2964afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SR = SourceRange(SM.getSpellingLoc(SR.getBegin()), 2965afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SM.getSpellingLoc(SR.getEnd())); 2966afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks } 2967afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks 2968c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (PatternType == 1) 2969afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::warn_strncat_large_size) << SR; 2970c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else 2971afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::warn_strncat_src_size) << SR; 2972c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 2973c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Output a FIXIT hint if the destination is an array (rather than a 2974c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // pointer to an array). This could be enhanced to handle some 2975c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // pointers if we know the actual size, like if DstArg is 'array+2' 2976c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // we could say 'sizeof(array)-2'. 2977c36bedc90c687caa71748480c60707ea4608b092Anna Zaks QualType DstArgTy = DstArg->getType(); 2978c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 2979c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Only handle constant-sized or VLAs, but not flexible members. 2980c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(DstArgTy)) { 2981c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Only issue the FIXIT for arrays of size > 1. 2982c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (CAT->getSize().getSExtValue() <= 1) 2983c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 2984c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } else if (!DstArgTy->isVariableArrayType()) { 2985c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 2986c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 2987c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 2988f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> sizeString; 2989c36bedc90c687caa71748480c60707ea4608b092Anna Zaks llvm::raw_svector_ostream OS(sizeString); 2990c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << "sizeof("; 2991c36bedc90c687caa71748480c60707ea4608b092Anna Zaks DstArg->printPretty(OS, Context, 0, getPrintingPolicy()); 2992c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << ") - "; 2993c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << "strlen("; 2994c36bedc90c687caa71748480c60707ea4608b092Anna Zaks DstArg->printPretty(OS, Context, 0, getPrintingPolicy()); 2995c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << ") - 1"; 2996c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 2997afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::note_strncat_wrong_size) 2998afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks << FixItHint::CreateReplacement(SR, OS.str()); 2999c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3000c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 300106de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===// 300206de276fff91264437fa75111ed76de43097e089Ted Kremenek 30035f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars); 30045f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars); 300506de276fff91264437fa75111ed76de43097e089Ted Kremenek 300606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address 300706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable. 300806de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid 300906de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 301006de276fff91264437fa75111ed76de43097e089Ted Kremenek SourceLocation ReturnLoc) { 30111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 301226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Expr *stackE = 0; 30135f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<DeclRefExpr *, 8> refVars; 30144e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 301526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Perform checking for returned stack addresses, local blocks, 301626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // label addresses or references to temporaries. 3017f85e193739c953358c865005855253af4f68a497John McCall if (lhsType->isPointerType() || 30184e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie (!getLangOpts().ObjCAutoRefCount && lhsType->isBlockPointerType())) { 301926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalAddr(RetValExp, refVars); 3020ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (lhsType->isReferenceType()) { 302126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalVal(RetValExp, refVars); 302226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 302326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 302426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (stackE == 0) 302526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return; // Nothing suspicious was found. 302626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 302726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceLocation diagLoc; 302826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange diagRange; 302926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (refVars.empty()) { 303026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = stackE->getLocStart(); 303126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = stackE->getSourceRange(); 303226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { 303326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // We followed through a reference variable. 'stackE' contains the 303426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // problematic expression but we will warn at the return statement pointing 303526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // at the reference variable. We will later display the "trail" of 303626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // reference variables using notes. 303726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = refVars[0]->getLocStart(); 303826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = refVars[0]->getSourceRange(); 303926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 304026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 304126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var. 304226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref 304326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_stack_addr) 304426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << DR->getDecl()->getDeclName() << diagRange; 304526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<BlockExpr>(stackE)) { // local block. 304626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::err_ret_local_block) << diagRange; 304726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 304826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 304926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { // local temporary. 305026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref 305126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_local_temp_addr) 305226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << diagRange; 305326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 305426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 305526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Display the "trail" of reference variables that we followed until we 305626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // found the problematic expression using notes. 305726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 305826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 305926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this var binds to another reference var, show the range of the next 306026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // var, otherwise the var binds to the problematic expression, in which case 306126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // show the range of the expression. 306226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange() 306326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : stackE->getSourceRange(); 306426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(VD->getLocation(), diag::note_ref_var_local_bind) 306526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << VD->getDeclName() << range; 306606de276fff91264437fa75111ed76de43097e089Ted Kremenek } 306706de276fff91264437fa75111ed76de43097e089Ted Kremenek} 306806de276fff91264437fa75111ed76de43097e089Ted Kremenek 306906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 307006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// check if the expression in a return statement evaluates to an address 307126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// to a location on the stack, a local block, an address of a label, or a 307226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// reference to local temporary. The recursion is used to traverse the 307306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// AST of the return expression, with recursion backtracking when we 307426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// encounter a subexpression that (1) clearly does not lead to one of the 307526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// above problematic expressions (2) is something we cannot determine leads to 307626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// a problematic expression based on such local checking. 307726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 307826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// Both EvalAddr and EvalVal follow through reference variables to evaluate 307926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// the expression that they point to. Such variables are added to the 308026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 'refVars' vector so that we know what the reference variable "trail" was. 308106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 3082e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// EvalAddr processes expressions that are pointers that are used as 3083e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// references (and not L-values). EvalVal handles all other values. 308426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// At the base case of the recursion is a check for the above problematic 308526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// expressions. 308606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 308706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// This implementation handles: 308806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 308906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer-to-pointer casts 309006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * implicit conversions from array references to pointers 309106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of fields 309206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * arbitrary interplay between "&" and "*" operators 309306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer arithmetic from an address of a stack variable 309406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of an array element where the array is on the stack 30955f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars) { 309626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (E->isTypeDependent()) 309726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 309826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 309906de276fff91264437fa75111ed76de43097e089Ted Kremenek // We should only be called for evaluating pointer expressions. 31000f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall assert((E->getType()->isAnyPointerType() || 3101dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff E->getType()->isBlockPointerType() || 3102a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek E->getType()->isObjCQualifiedIdType()) && 3103fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner "EvalAddr only works on pointers"); 31041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3105f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 3106f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 310706de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 310806de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 310906de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 311006de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 311126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::DeclRefExprClass: { 311226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis DeclRefExpr *DR = cast<DeclRefExpr>(E); 311326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 311426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 311526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this is a reference variable, follow through to the expression that 311626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 311726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage() && 311826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis V->getType()->isReferenceType() && V->hasInit()) { 311926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 312026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 312126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(V->getInit(), refVars); 312226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 312326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 312426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 312526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 312606de276fff91264437fa75111ed76de43097e089Ted Kremenek 3127fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::UnaryOperatorClass: { 3128fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // The only unary operator that make sense to handle here 3129fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // is AddrOf. All others don't make sense as pointers. 3130fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner UnaryOperator *U = cast<UnaryOperator>(E); 31311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 31322de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_AddrOf) 313326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(U->getSubExpr(), refVars); 3134fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 3135fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 3136fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 31371eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3138fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::BinaryOperatorClass: { 3139fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle pointer arithmetic. All other binary operators are not valid 3140fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // in this context. 3141fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner BinaryOperator *B = cast<BinaryOperator>(E); 31422de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = B->getOpcode(); 31431eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 31442de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op != BO_Add && op != BO_Sub) 3145fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 31461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3147fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner Expr *Base = B->getLHS(); 31483907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 3149fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Determine which argument is the real pointer base. It could be 3150fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // the RHS argument instead of the LHS. 3151fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner if (!Base->getType()->isPointerType()) Base = B->getRHS(); 31521eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3153fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner assert (Base->getType()->isPointerType()); 315426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(Base, refVars); 3155fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 315661f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff 3157fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // For conditional operators we need to see if either the LHS or RHS are 3158fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // valid DeclRefExpr*s. If one of them is valid, we return it. 3159fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ConditionalOperatorClass: { 3160fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner ConditionalOperator *C = cast<ConditionalOperator>(E); 31611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3162fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle the GNU extension for missing LHS. 31639ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (Expr *lhsExpr = C->getLHS()) { 31649ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 31659ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (!lhsExpr->getType()->isVoidType()) 316626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr* LHS = EvalAddr(lhsExpr, refVars)) 31679ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return LHS; 31689ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor } 31699ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor 31709ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 31719ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (C->getRHS()->getType()->isVoidType()) 31729ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return NULL; 317306de276fff91264437fa75111ed76de43097e089Ted Kremenek 317426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(C->getRHS(), refVars); 3175fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 317626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 317726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::BlockExprClass: 3178469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures()) 317926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // local block. 318026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 318126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 318226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::AddrLabelExprClass: 318326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // address of label. 31841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 318580ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 318680ee6e878a169e6255d4686a91bb696151ff229fJohn McCall return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars); 318780ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 318854b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // For casts, we need to handle conversions from arrays to 318954b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // pointer values, and pointer-to-pointer conversions. 319049badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::ImplicitCastExprClass: 31916eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor case Stmt::CStyleCastExprClass: 3192f85e193739c953358c865005855253af4f68a497John McCall case Stmt::CXXFunctionalCastExprClass: 31938b9414e868853fc052251455674bf7512261e14aEli Friedman case Stmt::ObjCBridgedCastExprClass: 31941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXStaticCastExprClass: 31951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXDynamicCastExprClass: 319649badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXConstCastExprClass: 319749badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXReinterpretCastExprClass: { 31988b9414e868853fc052251455674bf7512261e14aEli Friedman Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 31998b9414e868853fc052251455674bf7512261e14aEli Friedman switch (cast<CastExpr>(E)->getCastKind()) { 32008b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BitCast: 32018b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_LValueToRValue: 32028b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_NoOp: 32038b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BaseToDerived: 32048b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_DerivedToBase: 32058b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_UncheckedDerivedToBase: 32068b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_Dynamic: 32078b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_CPointerToObjCPointerCast: 32088b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BlockPointerToObjCPointerCast: 32098b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_AnyPointerToBlockPointerCast: 32108b9414e868853fc052251455674bf7512261e14aEli Friedman return EvalAddr(SubExpr, refVars); 32118b9414e868853fc052251455674bf7512261e14aEli Friedman 32128b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_ArrayToPointerDecay: 32138b9414e868853fc052251455674bf7512261e14aEli Friedman return EvalVal(SubExpr, refVars); 32148b9414e868853fc052251455674bf7512261e14aEli Friedman 32158b9414e868853fc052251455674bf7512261e14aEli Friedman default: 32168b9414e868853fc052251455674bf7512261e14aEli Friedman return 0; 32178b9414e868853fc052251455674bf7512261e14aEli Friedman } 3218fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 32191eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 322003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 322103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalAddr( 322203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 322303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor refVars)) 322403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 322503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 322603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 322703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 3228fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Everything else: we simply don't reason about them. 3229fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner default: 3230fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 323106de276fff91264437fa75111ed76de43097e089Ted Kremenek } 323206de276fff91264437fa75111ed76de43097e089Ted Kremenek} 32331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 323406de276fff91264437fa75111ed76de43097e089Ted Kremenek 323506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalVal - This function is complements EvalAddr in the mutual recursion. 323606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// See the comments for EvalAddr for more details. 32375f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars) { 323868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo { 3239e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // We should only be called for evaluating non-pointer expressions, or 3240e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // expressions with a pointer type that are not used as references but instead 3241e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // are l-values (e.g., DeclRefExpr with a pointer type). 32421eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 324306de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 324406de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 324506de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 3246f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 3247f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 324806de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 324968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ImplicitCastExprClass: { 325068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 32515baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall if (IE->getValueKind() == VK_LValue) { 325268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = IE->getSubExpr(); 325368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 325468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 325568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek return NULL; 325668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 325768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek 325880ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 325980ee6e878a169e6255d4686a91bb696151ff229fJohn McCall return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars); 326080ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 3261a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor case Stmt::DeclRefExprClass: { 326226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // When we hit a DeclRefExpr we are looking at code that refers to a 326326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // variable's name. If it's not a reference variable we check if it has 326426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // local storage within the function, and if so, return the expression. 326506de276fff91264437fa75111ed76de43097e089Ted Kremenek DeclRefExpr *DR = cast<DeclRefExpr>(E); 32661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 326706de276fff91264437fa75111ed76de43097e089Ted Kremenek if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 326826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage()) { 326926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!V->getType()->isReferenceType()) 327026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return DR; 327126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 327226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Reference variable, follow through to the expression that 327326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 327426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasInit()) { 327526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 327626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 327726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(V->getInit(), refVars); 327826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 327926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 32801eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 328106de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 328206de276fff91264437fa75111ed76de43097e089Ted Kremenek } 32831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 328406de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::UnaryOperatorClass: { 328506de276fff91264437fa75111ed76de43097e089Ted Kremenek // The only unary operator that make sense to handle here 328606de276fff91264437fa75111ed76de43097e089Ted Kremenek // is Deref. All others don't resolve to a "name." This includes 328706de276fff91264437fa75111ed76de43097e089Ted Kremenek // handling all sorts of rvalues passed to a unary operator. 328806de276fff91264437fa75111ed76de43097e089Ted Kremenek UnaryOperator *U = cast<UnaryOperator>(E); 32891eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 32902de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_Deref) 329126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(U->getSubExpr(), refVars); 329206de276fff91264437fa75111ed76de43097e089Ted Kremenek 329306de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 329406de276fff91264437fa75111ed76de43097e089Ted Kremenek } 32951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 329606de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ArraySubscriptExprClass: { 329706de276fff91264437fa75111ed76de43097e089Ted Kremenek // Array subscripts are potential references to data on the stack. We 329806de276fff91264437fa75111ed76de43097e089Ted Kremenek // retrieve the DeclRefExpr* for the array variable if it indeed 329906de276fff91264437fa75111ed76de43097e089Ted Kremenek // has local storage. 330026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars); 330106de276fff91264437fa75111ed76de43097e089Ted Kremenek } 33021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 330306de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ConditionalOperatorClass: { 330406de276fff91264437fa75111ed76de43097e089Ted Kremenek // For conditional operators we need to see if either the LHS or RHS are 330526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // non-NULL Expr's. If one is non-NULL, we return it. 330606de276fff91264437fa75111ed76de43097e089Ted Kremenek ConditionalOperator *C = cast<ConditionalOperator>(E); 330706de276fff91264437fa75111ed76de43097e089Ted Kremenek 33083907323dd6665c0c4e383435cb145233f4533406Anders Carlsson // Handle the GNU extension for missing LHS. 33093907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (Expr *lhsExpr = C->getLHS()) 331026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr *LHS = EvalVal(lhsExpr, refVars)) 33113907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return LHS; 33123907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 331326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(C->getRHS(), refVars); 331406de276fff91264437fa75111ed76de43097e089Ted Kremenek } 33151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 331606de276fff91264437fa75111ed76de43097e089Ted Kremenek // Accesses to members are potential references to data on the stack. 331783f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor case Stmt::MemberExprClass: { 331806de276fff91264437fa75111ed76de43097e089Ted Kremenek MemberExpr *M = cast<MemberExpr>(E); 33191eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 332006de276fff91264437fa75111ed76de43097e089Ted Kremenek // Check for indirect access. We only want direct field accesses. 3321a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->isArrow()) 3322a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return NULL; 3323a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 3324a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // Check whether the member type is itself a reference, in which case 3325a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // we're not going to refer to the member, but to what the member refers to. 3326a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->getMemberDecl()->getType()->isReferenceType()) 332706de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 3328a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 332926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(M->getBase(), refVars); 333006de276fff91264437fa75111ed76de43097e089Ted Kremenek } 33311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 333203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 333303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalVal( 333403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 333503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor refVars)) 333603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 333703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 333803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 333903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 334006de276fff91264437fa75111ed76de43097e089Ted Kremenek default: 334126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Check that we don't return or take the address of a reference to a 334226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // temporary. This is only useful in C++. 334326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!E->isTypeDependent() && E->isRValue()) 334426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; 334526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 334626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Everything else: we simply don't reason about them. 334706de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 334806de276fff91264437fa75111ed76de43097e089Ted Kremenek } 334968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true); 335006de276fff91264437fa75111ed76de43097e089Ted Kremenek} 3351588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3352588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 3353588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3354588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==. 3355588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely 3356588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended. 3357dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieuvoid Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) { 3358588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek bool EmitWarning = true; 33591eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3360dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts(); 3361dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* RightExprSansParen = RHS->IgnoreParenImpCasts(); 3362588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3363588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Special case: check for x == x (which is OK). 3364588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Do not emit warnings for such cases. 3365588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 3366588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 3367588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DRL->getDecl() == DRR->getDecl()) 3368588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 33691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 33701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 33711b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // Special case: check for comparisons against literals that can be exactly 33721b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // represented by APFloat. In such cases, do not emit a warning. This 33731b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // is a heuristic: often comparison against such literals are used to 33741b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // detect if a value in a variable has not changed. This clearly can 33751b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // lead to false negatives. 33761b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (EmitWarning) { 33771b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 33781b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLL->isExact()) 33791b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 3380ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else 33811b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){ 33821b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLR->isExact()) 33831b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 33841b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 33851b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 33861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3387588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Check for comparisons with builtin types. 33880eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 3389588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 3390180f47959a066795cc0f409433023af448bb0328Richard Smith if (CL->isBuiltinCall()) 3391588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 33921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 33930eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 3394588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 3395180f47959a066795cc0f409433023af448bb0328Richard Smith if (CR->isBuiltinCall()) 3396588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 33971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3398588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Emit the diagnostic. 3399588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (EmitWarning) 3400dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Diag(Loc, diag::warn_floatingpoint_eq) 3401dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu << LHS->getSourceRange() << RHS->getSourceRange(); 3402588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek} 3403ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3404f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 3405f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 3406ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3407f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace { 3408ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3409f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued 3410f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression. 3411f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange { 3412f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// The number of bits active in the int. 3413f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned Width; 3414ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3415f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// True if the int is known not to have negative values. 3416f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool NonNegative; 341751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3418f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange(unsigned Width, bool NonNegative) 3419f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : Width(Width), NonNegative(NonNegative) 3420f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall {} 342151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 34221844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of the bool type. 3423f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall static IntRange forBoolType() { 3424f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(1, true); 3425f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 342651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 34271844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of the given integral type. 34281844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfType(ASTContext &C, QualType T) { 34291844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return forValueOfCanonicalType(C, 34301844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T->getCanonicalTypeInternal().getTypePtr()); 343151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 343251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 34331844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of a canonical integral type. 34341844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 3435f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(T->isCanonicalUnqualified()); 343651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3437f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 3438f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = VT->getElementType().getTypePtr(); 3439f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 3440f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = CT->getElementType().getTypePtr(); 3441323ed74658bc8375278eabf074b4777458376540John McCall 3442091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // For enum types, use the known bit width of the enumerators. 3443323ed74658bc8375278eabf074b4777458376540John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) { 3444323ed74658bc8375278eabf074b4777458376540John McCall EnumDecl *Enum = ET->getDecl(); 34455e1cdac63c3d9c9b32fa41fa0b2d242a58a20d49John McCall if (!Enum->isCompleteDefinition()) 3446091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return IntRange(C.getIntWidth(QualType(T, 0)), false); 3447091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3448323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumPositive = Enum->getNumPositiveBits(); 3449323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumNegative = Enum->getNumNegativeBits(); 3450323ed74658bc8375278eabf074b4777458376540John McCall 3451323ed74658bc8375278eabf074b4777458376540John McCall return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0); 3452323ed74658bc8375278eabf074b4777458376540John McCall } 345351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3454f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const BuiltinType *BT = cast<BuiltinType>(T); 3455f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(BT->isInteger()); 345651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3457f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 345851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 345951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 34601844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the "target" range of a canonical integral type, i.e. 34611844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// the range of values expressible in the type. 34621844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// 34631844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// This matches forValueOfCanonicalType except that enums have the 34641844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// full range of their type, not the range of their enumerators. 34651844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 34661844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(T->isCanonicalUnqualified()); 34671844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 34681844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 34691844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = VT->getElementType().getTypePtr(); 34701844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 34711844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = CT->getElementType().getTypePtr(); 34721844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) 347369ff26bd1e7a2faffec0c3b9740cfb0c6bb354c5Douglas Gregor T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr(); 34741844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 34751844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall const BuiltinType *BT = cast<BuiltinType>(T); 34761844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(BT->isInteger()); 34771844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 34781844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 34791844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall } 34801844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 34811844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the supremum of two ranges: i.e. their conservative merge. 3482c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange join(IntRange L, IntRange R) { 3483f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(std::max(L.Width, R.Width), 348460fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative && R.NonNegative); 348560fad45739b764886f707bd204eae9ecce6db1f2John McCall } 348660fad45739b764886f707bd204eae9ecce6db1f2John McCall 34871844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the infinum of two ranges: i.e. their aggressive merge. 3488c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange meet(IntRange L, IntRange R) { 348960fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange(std::min(L.Width, R.Width), 349060fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative || R.NonNegative); 349151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 3492f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}; 349351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 34940692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, 34950692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek unsigned MaxWidth) { 3496f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isSigned() && value.isNegative()) 3497f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getMinSignedBits(), false); 349851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3499f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.getBitWidth() > MaxWidth) 35009f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad value = value.trunc(MaxWidth); 350151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3502f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // isNonNegative() just checks the sign bit without considering 3503f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // signedness. 3504f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getActiveBits(), true); 350551313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 350651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 35070692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 35080692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek unsigned MaxWidth) { 3509f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isInt()) 3510f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetValueRange(C, result.getInt(), MaxWidth); 351151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3512f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isVector()) { 35130acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 35140acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 35150acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 35160acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall R = IntRange::join(R, El); 35170acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall } 3518f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return R; 351951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 352051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3521f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isComplexInt()) { 3522f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 3523f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 3524f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(R, I); 3525f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 3526f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3527f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // This can happen with lossless casts to intptr_t of "based" lvalues. 3528f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume it might use arbitrary bits. 35290acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // FIXME: The only reason we need to pass the type in here is to get 35300acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // the sign right on this one case. It would be nice if APValue 35310acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // preserved this. 353265639284118d54ddf2e51a05d2ffccda567fe246Eli Friedman assert(result.isLValue() || result.isAddrLabelDiff()); 35335e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType()); 353451313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 353551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3536f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the 3537f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take. 3538f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 3539f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated 35400692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 354151313c39c84407dd6a323be99a8c322bf8d052a9John McCall E = E->IgnoreParens(); 354251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3543f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Try a full evaluation first. 3544f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall Expr::EvalResult result; 354551f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, C)) 35460acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall return GetValueRange(C, result.Val, E->getType(), MaxWidth); 354751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3548f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // I think we only want to look through implicit casts here; if the 3549f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // user has an explicit widening cast, we should treat the value as 3550f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // being of the new, wider type. 3551f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 3552b17ee5bff0d7986c14cdddb279e0131bd7f9678dEli Friedman if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue) 3553f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CE->getSubExpr(), MaxWidth); 355451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 35551844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType()); 355651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 35572de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 355860fad45739b764886f707bd204eae9ecce6db1f2John McCall 3559f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume that non-integer casts can span the full range of the type. 356060fad45739b764886f707bd204eae9ecce6db1f2John McCall if (!isIntegerCast) 3561f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 356251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3563f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange SubRange 3564f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall = GetExprRange(C, CE->getSubExpr(), 3565f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall std::min(MaxWidth, OutputTypeRange.Width)); 356651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3567f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Bail out if the subexpr's range is as wide as the cast type. 3568f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SubRange.Width >= OutputTypeRange.Width) 3569f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 357051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3571f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, we take the smaller width, and we're non-negative if 3572f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // either the output type or the subexpr is. 3573f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(SubRange.Width, 3574f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall SubRange.NonNegative || OutputTypeRange.NonNegative); 3575f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 3576f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3577f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 3578f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // If we can fold the condition, just take that operand. 3579f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool CondResult; 3580f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 3581f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CondResult ? CO->getTrueExpr() 3582f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : CO->getFalseExpr(), 3583f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall MaxWidth); 3584f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3585f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, conservatively merge. 3586f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 3587f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 3588f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 358951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 359051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 359151313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 359251313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (BO->getOpcode()) { 359351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3594f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Boolean-valued operations are single-bit and positive. 35952de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LAnd: 35962de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LOr: 35972de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LT: 35982de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GT: 35992de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LE: 36002de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GE: 36012de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_EQ: 36022de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_NE: 3603f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 360451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3605862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // The type of the assignments is the type of the LHS, so the RHS 3606862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // is not necessarily the same type. 36072de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_MulAssign: 36082de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_DivAssign: 36092de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_RemAssign: 36102de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AddAssign: 36112de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_SubAssign: 3612862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_XorAssign: 3613862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_OrAssign: 3614862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 36151844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 3616c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall 3617862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // Simple assignments just pass through the RHS, which will have 3618862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // been coerced to the LHS type. 3619862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_Assign: 3620862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 3621862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 3622862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall 362351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 36242de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemD: 36252de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemI: 36261844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 362751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 362860fad45739b764886f707bd204eae9ecce6db1f2John McCall // Bitwise-and uses the *infinum* of the two source ranges. 36292de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_And: 36302de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AndAssign: 363160fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 363260fad45739b764886f707bd204eae9ecce6db1f2John McCall GetExprRange(C, BO->getRHS(), MaxWidth)); 363360fad45739b764886f707bd204eae9ecce6db1f2John McCall 363451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Left shift gets black-listed based on a judgement call. 36352de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shl: 36363aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // ...except that we want to treat '1 << (blah)' as logically 36373aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // positive. It's an important idiom. 36383aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (IntegerLiteral *I 36393aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 36403aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (I->getValue() == 1) { 36411844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange R = IntRange::forValueOfType(C, E->getType()); 36423aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall return IntRange(R.Width, /*NonNegative*/ true); 36433aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 36443aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 36453aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // fallthrough 36463aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall 36472de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShlAssign: 36481844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 364951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 365060fad45739b764886f707bd204eae9ecce6db1f2John McCall // Right shift by a constant can narrow its left argument. 36512de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shr: 36522de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShrAssign: { 365360fad45739b764886f707bd204eae9ecce6db1f2John McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 365460fad45739b764886f707bd204eae9ecce6db1f2John McCall 365560fad45739b764886f707bd204eae9ecce6db1f2John McCall // If the shift amount is a positive constant, drop the width by 365660fad45739b764886f707bd204eae9ecce6db1f2John McCall // that much. 365760fad45739b764886f707bd204eae9ecce6db1f2John McCall llvm::APSInt shift; 365860fad45739b764886f707bd204eae9ecce6db1f2John McCall if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 365960fad45739b764886f707bd204eae9ecce6db1f2John McCall shift.isNonNegative()) { 366060fad45739b764886f707bd204eae9ecce6db1f2John McCall unsigned zext = shift.getZExtValue(); 366160fad45739b764886f707bd204eae9ecce6db1f2John McCall if (zext >= L.Width) 366260fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width = (L.NonNegative ? 0 : 1); 366360fad45739b764886f707bd204eae9ecce6db1f2John McCall else 366460fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width -= zext; 366560fad45739b764886f707bd204eae9ecce6db1f2John McCall } 366660fad45739b764886f707bd204eae9ecce6db1f2John McCall 366760fad45739b764886f707bd204eae9ecce6db1f2John McCall return L; 366860fad45739b764886f707bd204eae9ecce6db1f2John McCall } 366960fad45739b764886f707bd204eae9ecce6db1f2John McCall 367060fad45739b764886f707bd204eae9ecce6db1f2John McCall // Comma acts as its right operand. 36712de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Comma: 3672f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 3673f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 367460fad45739b764886f707bd204eae9ecce6db1f2John McCall // Black-list pointer subtractions. 36752de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Sub: 367651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BO->getLHS()->getType()->isPointerType()) 36771844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 367800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall break; 367900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 368000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The width of a division result is mostly determined by the size 368100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // of the LHS. 368200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Div: { 368300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 368400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 368500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 368600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 368700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // If the divisor is constant, use that. 368800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall llvm::APSInt divisor; 368900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) { 369000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned log2 = divisor.logBase2(); // floor(log_2(divisor)) 369100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (log2 >= L.Width) 369200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = (L.NonNegative ? 0 : 1); 369300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall else 369400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = std::min(L.Width - log2, MaxWidth); 369500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return L; 369600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 369700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 369800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Otherwise, just use the LHS's width. 369900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 370000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return IntRange(L.Width, L.NonNegative && R.NonNegative); 370100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 370200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 370300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The result of a remainder can't be larger than the result of 370400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // either side. 370500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Rem: { 370600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 370700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 370800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 370900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 371000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 371100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange meet = IntRange::meet(L, R); 371200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall meet.Width = std::min(meet.Width, MaxWidth); 371300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return meet; 371400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 37154e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 371600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default behavior is okay for these. 371700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Mul: 371800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Add: 371900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Xor: 372000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Or: 3721f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall break; 372251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 3723f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 372400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default case is to treat the operation as if it were closed 372500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // on the narrowest type that encompasses both operands. 3726f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 3727f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 3728f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 372951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 373051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 373151313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 373251313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (UO->getOpcode()) { 373351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Boolean-valued operations are white-listed. 37342de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_LNot: 3735f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 373651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 373751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 37382de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_Deref: 37392de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_AddrOf: // should be impossible 37401844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 374151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 374251313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 3743f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, UO->getSubExpr(), MaxWidth); 374451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 374551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 37468ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor 37478ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor if (dyn_cast<OffsetOfExpr>(E)) { 37481844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange::forValueOfType(C, E->getType()); 37498ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor } 375051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3751a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith if (FieldDecl *BitField = E->getBitField()) 3752a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith return IntRange(BitField->getBitWidthValue(C), 37535e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor BitField->getType()->isUnsignedIntegerOrEnumerationType()); 3754f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 37551844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 3756f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 3757f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 37580692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E) { 3759323ed74658bc8375278eabf074b4777458376540John McCall return GetExprRange(C, E, C.getIntWidth(E->getType())); 3760323ed74658bc8375278eabf074b4777458376540John McCall} 3761323ed74658bc8375278eabf074b4777458376540John McCall 3762f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 3763f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 3764f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 37650692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const llvm::APFloat &value, 37660692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Src, 37670692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Tgt) { 3768f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APFloat truncated = value; 3769f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3770f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool ignored; 3771f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 3772f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 3773f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3774f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return truncated.bitwiseIsEqual(value); 377551313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 377651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3777f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 3778f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 3779f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 3780f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 3781f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number). 37820692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const APValue &value, 37830692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Src, 37840692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Tgt) { 3785f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isFloat()) 3786f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 3787f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3788f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isVector()) { 3789f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 3790f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 3791f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return false; 3792f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return true; 3793f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 3794f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3795f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(value.isComplexFloat()); 3796f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 3797f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 3798f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 3799f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 38000692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 3801323ed74658bc8375278eabf074b4777458376540John McCall 3802e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) { 3803e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where we are comparing against an enum constant. 3804e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (const DeclRefExpr *DR = 3805e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 3806e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (isa<EnumConstantDecl>(DR->getDecl())) 3807e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 3808e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 3809e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where the '0' value is expanded from a macro. 3810e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (E->getLocStart().isMacroID()) 3811e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 3812e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 3813323ed74658bc8375278eabf074b4777458376540John McCall llvm::APSInt Value; 3814323ed74658bc8375278eabf074b4777458376540John McCall return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 3815323ed74658bc8375278eabf074b4777458376540John McCall} 3816323ed74658bc8375278eabf074b4777458376540John McCall 3817372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) { 3818372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall // Strip off implicit integral promotions. 3819372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 382063b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis if (ICE->getCastKind() != CK_IntegralCast && 382163b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis ICE->getCastKind() != CK_NoOp) 3822372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall break; 382363b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis E = ICE->getSubExpr(); 3824372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall } 3825372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 3826372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall return E->getType()->isEnumeralType(); 3827372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall} 3828372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 38290692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 38302de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = E->getOpcode(); 383114af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor if (E->isValueDependent()) 383214af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor return; 383314af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor 38342de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op == BO_LT && IsZero(S, E->getRHS())) { 3835323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 3836372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "< 0" << "false" << HasEnumType(E->getLHS()) 3837323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 38382de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GE && IsZero(S, E->getRHS())) { 3839323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 3840372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << ">= 0" << "true" << HasEnumType(E->getLHS()) 3841323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 38422de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GT && IsZero(S, E->getLHS())) { 3843323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 3844372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 >" << "false" << HasEnumType(E->getRHS()) 3845323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 38462de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_LE && IsZero(S, E->getLHS())) { 3847323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 3848372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 <=" << "true" << HasEnumType(E->getRHS()) 3849323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 3850323ed74658bc8375278eabf074b4777458376540John McCall } 3851323ed74658bc8375278eabf074b4777458376540John McCall} 3852323ed74658bc8375278eabf074b4777458376540John McCall 3853323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison. Implements the 3854323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison. 38550692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 3856b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 3857b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 3858323ed74658bc8375278eabf074b4777458376540John McCall} 3859f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3860ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare. 3861ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// 3862dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu/// \param E the binary operator to check for warnings 38630692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeComparison(Sema &S, BinaryOperator *E) { 3864323ed74658bc8375278eabf074b4777458376540John McCall // The type the comparison is being performed in. 3865323ed74658bc8375278eabf074b4777458376540John McCall QualType T = E->getLHS()->getType(); 3866323ed74658bc8375278eabf074b4777458376540John McCall assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 3867323ed74658bc8375278eabf074b4777458376540John McCall && "comparison with mismatched types"); 3868323ed74658bc8375278eabf074b4777458376540John McCall 3869323ed74658bc8375278eabf074b4777458376540John McCall // We don't do anything special if this isn't an unsigned integral 3870323ed74658bc8375278eabf074b4777458376540John McCall // comparison: we're only interested in integral comparisons, and 3871323ed74658bc8375278eabf074b4777458376540John McCall // signed comparisons only happen in cases we don't care to warn about. 38723e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // 38733e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // We also don't care about value-dependent expressions or expressions 38743e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // whose result is a constant. 38753e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor if (!T->hasUnsignedIntegerRepresentation() 38763e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor || E->isValueDependent() || E->isIntegerConstantExpr(S.Context)) 3877323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 3878323ed74658bc8375278eabf074b4777458376540John McCall 3879dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr *LHS = E->getLHS()->IgnoreParenImpCasts(); 3880dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr *RHS = E->getRHS()->IgnoreParenImpCasts(); 3881323ed74658bc8375278eabf074b4777458376540John McCall 3882323ed74658bc8375278eabf074b4777458376540John McCall // Check to see if one of the (unmodified) operands is of different 3883323ed74658bc8375278eabf074b4777458376540John McCall // signedness. 3884323ed74658bc8375278eabf074b4777458376540John McCall Expr *signedOperand, *unsignedOperand; 3885dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu if (LHS->getType()->hasSignedIntegerRepresentation()) { 3886dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu assert(!RHS->getType()->hasSignedIntegerRepresentation() && 3887323ed74658bc8375278eabf074b4777458376540John McCall "unsigned comparison between two signed integer expressions?"); 3888dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = LHS; 3889dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = RHS; 3890dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu } else if (RHS->getType()->hasSignedIntegerRepresentation()) { 3891dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = RHS; 3892dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = LHS; 3893ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } else { 3894323ed74658bc8375278eabf074b4777458376540John McCall CheckTrivialUnsignedComparison(S, E); 3895323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 3896ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } 3897ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3898323ed74658bc8375278eabf074b4777458376540John McCall // Otherwise, calculate the effective range of the signed operand. 3899323ed74658bc8375278eabf074b4777458376540John McCall IntRange signedRange = GetExprRange(S.Context, signedOperand); 3900f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3901323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and analyze implicit conversions in the operands. Note 3902323ed74658bc8375278eabf074b4777458376540John McCall // that we skip the implicit conversions on both sides. 3903dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc()); 3904dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc()); 3905ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3906323ed74658bc8375278eabf074b4777458376540John McCall // If the signed range is non-negative, -Wsign-compare won't fire, 3907323ed74658bc8375278eabf074b4777458376540John McCall // but we should still check for comparisons which are always true 3908323ed74658bc8375278eabf074b4777458376540John McCall // or false. 3909323ed74658bc8375278eabf074b4777458376540John McCall if (signedRange.NonNegative) 3910323ed74658bc8375278eabf074b4777458376540John McCall return CheckTrivialUnsignedComparison(S, E); 3911ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3912ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // For (in)equality comparisons, if the unsigned operand is a 3913ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // constant which cannot collide with a overflowed signed operand, 3914ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // then reinterpreting the signed operand as unsigned will not 3915ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // change the result of the comparison. 3916323ed74658bc8375278eabf074b4777458376540John McCall if (E->isEqualityOp()) { 3917323ed74658bc8375278eabf074b4777458376540John McCall unsigned comparisonWidth = S.Context.getIntWidth(T); 3918323ed74658bc8375278eabf074b4777458376540John McCall IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 3919323ed74658bc8375278eabf074b4777458376540John McCall 3920323ed74658bc8375278eabf074b4777458376540John McCall // We should never be unable to prove that the unsigned operand is 3921323ed74658bc8375278eabf074b4777458376540John McCall // non-negative. 3922323ed74658bc8375278eabf074b4777458376540John McCall assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 3923ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3924323ed74658bc8375278eabf074b4777458376540John McCall if (unsignedRange.Width < comparisonWidth) 3925323ed74658bc8375278eabf074b4777458376540John McCall return; 3926323ed74658bc8375278eabf074b4777458376540John McCall } 3927323ed74658bc8375278eabf074b4777458376540John McCall 3928323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison) 3929dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu << LHS->getType() << RHS->getType() 3930dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu << LHS->getSourceRange() << RHS->getSourceRange(); 3931ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall} 3932ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 393315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield. 393415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// 393515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt. 39360692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 39370692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek SourceLocation InitLoc) { 393815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall assert(Bitfield->isBitField()); 393915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Bitfield->isInvalidDecl()) 394015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 394115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 394291b6014876e9186f968f74a8975ab8fc08ef1b68John McCall // White-list bool bitfields. 394391b6014876e9186f968f74a8975ab8fc08ef1b68John McCall if (Bitfield->getType()->isBooleanType()) 394491b6014876e9186f968f74a8975ab8fc08ef1b68John McCall return false; 394591b6014876e9186f968f74a8975ab8fc08ef1b68John McCall 394646ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor // Ignore value- or type-dependent expressions. 394746ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor if (Bitfield->getBitWidth()->isValueDependent() || 394846ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Bitfield->getBitWidth()->isTypeDependent() || 394946ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isValueDependent() || 395046ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isTypeDependent()) 395146ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor return false; 395246ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor 395315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *OriginalInit = Init->IgnoreParenImpCasts(); 395415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 395580d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith llvm::APSInt Value; 395680d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith if (!OriginalInit->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects)) 395715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 395815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 395915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned OriginalWidth = Value.getBitWidth(); 3960a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context); 396115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 396215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (OriginalWidth <= FieldWidth) 396315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 396415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 39653a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Compute the value which the bitfield will contain. 39669f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad llvm::APSInt TruncatedValue = Value.trunc(FieldWidth); 39673a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman TruncatedValue.setIsSigned(Bitfield->getType()->isSignedIntegerType()); 396815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 39693a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Check whether the stored value is equal to the original value. 39703a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman TruncatedValue = TruncatedValue.extend(OriginalWidth); 397115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value == TruncatedValue) 397215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 397315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 39743a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Special-case bitfields of width 1: booleans are naturally 0/1, and 397534ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman // therefore don't strictly fit into a signed bitfield of width 1. 397634ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman if (FieldWidth == 1 && Value == 1) 39773a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman return false; 39783a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman 397915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyValue = Value.toString(10); 398015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyTrunc = TruncatedValue.toString(10); 398115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 398215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 398315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << PrettyValue << PrettyTrunc << OriginalInit->getType() 398415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << Init->getSourceRange(); 398515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 398615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return true; 398715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 398815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 3989beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy 3990beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations. 39910692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeAssignment(Sema &S, BinaryOperator *E) { 3992beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Just recurse on the LHS. 3993beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 3994beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 3995beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // We want to recurse on the RHS as normal unless we're assigning to 3996beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // a bitfield. 3997beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (FieldDecl *Bitfield = E->getLHS()->getBitField()) { 399815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 399915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc())) { 400015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // Recurse, ignoring any implicit conversions on the RHS. 400115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 400215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc()); 4003beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4004beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4005beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 4006beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 4007beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall} 4008beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 400951313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 40100692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T, 4011c36bedc90c687caa71748480c60707ea4608b092Anna Zaks SourceLocation CContext, unsigned diag, 4012c36bedc90c687caa71748480c60707ea4608b092Anna Zaks bool pruneControlFlow = false) { 4013c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (pruneControlFlow) { 4014c36bedc90c687caa71748480c60707ea4608b092Anna Zaks S.DiagRuntimeBehavior(E->getExprLoc(), E, 4015c36bedc90c687caa71748480c60707ea4608b092Anna Zaks S.PDiag(diag) 4016c36bedc90c687caa71748480c60707ea4608b092Anna Zaks << SourceType << T << E->getSourceRange() 4017c36bedc90c687caa71748480c60707ea4608b092Anna Zaks << SourceRange(CContext)); 4018c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 4019c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 40205a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor S.Diag(E->getExprLoc(), diag) 40215a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor << SourceType << T << E->getSourceRange() << SourceRange(CContext); 40225a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor} 40235a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 4024e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 40250692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType T, 4026c36bedc90c687caa71748480c60707ea4608b092Anna Zaks SourceLocation CContext, unsigned diag, 4027c36bedc90c687caa71748480c60707ea4608b092Anna Zaks bool pruneControlFlow = false) { 4028c36bedc90c687caa71748480c60707ea4608b092Anna Zaks DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow); 4029e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth} 4030e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth 40319ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// Diagnose an implicit cast from a literal expression. Does not warn when the 40329ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// cast wouldn't lose information. 4033f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruthvoid DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T, 4034f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth SourceLocation CContext) { 40359ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay // Try to convert the literal exactly to an integer. If we can, don't warn. 4036f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth bool isExact = false; 40379ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay const llvm::APFloat &Value = FL->getValue(); 40383e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin llvm::APSInt IntegerValue(S.Context.getIntWidth(T), 40393e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin T->hasUnsignedIntegerRepresentation()); 40403e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin if (Value.convertToInteger(IntegerValue, 4041f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth llvm::APFloat::rmTowardZero, &isExact) 40429ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay == llvm::APFloat::opOK && isExact) 4043f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth return; 4044f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 40459ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer) 40469ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay << FL->getType() << T << FL->getSourceRange() << SourceRange(CContext); 4047f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth} 4048f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 4049091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 4050091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Range.Width) return "0"; 4051091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 4052091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt ValueInRange = Value; 4053091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.setIsSigned(!Range.NonNegative); 40549f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad ValueInRange = ValueInRange.trunc(Range.Width); 4055091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return ValueInRange.toString(10); 4056091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall} 4057091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 4058323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T, 4059b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool *ICContext = 0) { 4060323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) return; 406151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4062323ed74658bc8375278eabf074b4777458376540John McCall const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 4063323ed74658bc8375278eabf074b4777458376540John McCall const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 4064323ed74658bc8375278eabf074b4777458376540John McCall if (Source == Target) return; 4065323ed74658bc8375278eabf074b4777458376540John McCall if (Target->isDependentType()) return; 406651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4067108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // If the conversion context location is invalid don't complain. We also 4068108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // don't want to emit a warning if the issue occurs from the expansion of 4069108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // a system macro. The problem is that 'getSpellingLoc()' is slow, so we 4070108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // delay this check as long as possible. Once we detect we are in that 4071108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // scenario, we just return. 4072ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (CC.isInvalid()) 4073b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return; 4074b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 4075f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Diagnose implicit casts to bool. 4076f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (Target->isSpecificBuiltinType(BuiltinType::Bool)) { 4077f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (isa<StringLiteral>(E)) 4078f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Warn on string literal to bool. Checks for string literals in logical 4079f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // expressions, for instances, assert(0 && "error here"), is prevented 4080f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // by a check in AnalyzeImplicitConversions(). 4081f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu return DiagnoseImpCast(S, E, T, CC, 4082f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu diag::warn_impcast_string_literal_to_bool); 4083e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (Source->isFunctionType()) { 4084e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // Warn on function to bool. Checks free functions and static member 4085e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // functions. Weakly imported functions are excluded from the check, 4086e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // since it's common to test their value to check whether the linker 4087e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // found a definition for them. 4088e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames ValueDecl *D = 0; 4089e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (DeclRefExpr* R = dyn_cast<DeclRefExpr>(E)) { 4090e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = R->getDecl(); 4091e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) { 4092e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = M->getMemberDecl(); 4093e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 4094e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames 4095e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (D && !D->isWeak()) { 409626b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu if (FunctionDecl* F = dyn_cast<FunctionDecl>(D)) { 409726b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu S.Diag(E->getExprLoc(), diag::warn_impcast_function_to_bool) 409826b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu << F << E->getSourceRange() << SourceRange(CC); 40992def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_silence) 41002def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion(E->getExprLoc(), "&"); 41012def77399ab3088106a2d61372344f5b7104e1a2David Blaikie QualType ReturnType; 41022def77399ab3088106a2d61372344f5b7104e1a2David Blaikie UnresolvedSet<4> NonTemplateOverloads; 41032def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.isExprCallable(*E, ReturnType, NonTemplateOverloads); 41042def77399ab3088106a2d61372344f5b7104e1a2David Blaikie if (!ReturnType.isNull() 41052def77399ab3088106a2d61372344f5b7104e1a2David Blaikie && ReturnType->isSpecificBuiltinType(BuiltinType::Bool)) 41062def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_call) 41072def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion( 41082def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()), "()"); 410926b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu return; 411026b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu } 4111e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 4112e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 4113e37cdc42bf7298a974dfdfa9c03ef11398e7c889David Blaikie return; // Other casts to bool are not checked. 4114f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 411551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 411651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip vector types. 411751313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<VectorType>(Source)) { 4118ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<VectorType>(Target)) { 4119d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4120ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4121b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 4122ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 4123b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner 4124b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // If the vector cast is cast between two vectors of the same size, it is 4125b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // a bitcast, not a conversion. 4126b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target)) 4127b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner return; 412851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 412951313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 413051313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 413151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 413251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 413351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip complex types. 413451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<ComplexType>(Source)) { 4135ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<ComplexType>(Target)) { 4136d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4137ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4138ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4139b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 4140ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 414151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 414251313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 414351313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 414451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 414551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 414651313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 414751313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 414851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 414951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the source is floating point... 415051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT && SourceBT->isFloatingPoint()) { 415151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...and the target is floating point... 415251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (TargetBT && TargetBT->isFloatingPoint()) { 415351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...then warn if we're dropping FP rank. 415451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 415551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Builtin FP kinds are ordered by increasing FP rank. 415651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT->getKind() > TargetBT->getKind()) { 415751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Don't warn about float constants that are precisely 415851313c39c84407dd6a323be99a8c322bf8d052a9John McCall // representable in the target type. 415951313c39c84407dd6a323be99a8c322bf8d052a9John McCall Expr::EvalResult result; 416051f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, S.Context)) { 416151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Value might be a float, a float vector, or a float complex. 416251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (IsSameFloatAfterCast(result.Val, 4163323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 4164323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 416551313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 416651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 416751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4168d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4169ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4170ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4171b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 417251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 417351313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 417451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 417551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4176ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // If the target is integral, always warn. 4177a5b9332418f25338f118358e27303cd510d54107Chandler Carruth if ((TargetBT && TargetBT->isInteger())) { 4178d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4179ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4180ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4181a5b9332418f25338f118358e27303cd510d54107Chandler Carruth Expr *InnerE = E->IgnoreParenImpCasts(); 4182634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay // We also want to warn on, e.g., "int i = -1.234" 4183634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE)) 4184634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus) 4185634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay InnerE = UOp->getSubExpr()->IgnoreParenImpCasts(); 4186634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay 4187f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) { 4188f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth DiagnoseFloatingLiteralImpCast(S, FL, T, CC); 4189a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } else { 4190a5b9332418f25338f118358e27303cd510d54107Chandler Carruth DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 4191a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 4192a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 419351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 419451313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 419551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 419651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4197f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!Source->isIntegerType() || !Target->isIntegerType()) 419851313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 419951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 42001838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull) 42011838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu == Expr::NPCK_GNUNull) && Target->isIntegerType()) { 4202b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie SourceLocation Loc = E->getSourceRange().getBegin(); 4203b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie if (Loc.isMacroID()) 4204b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie Loc = S.SourceMgr.getImmediateExpansionRange(Loc).first; 4205b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie S.Diag(Loc, diag::warn_impcast_null_pointer_to_integer) 4206b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie << T << Loc << clang::SourceRange(CC); 42071838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu return; 42081838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu } 42091838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu 4210323ed74658bc8375278eabf074b4777458376540John McCall IntRange SourceRange = GetExprRange(S.Context, E); 42111844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 421251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4213f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width > TargetRange.Width) { 4214091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // If the source is a constant, use a default-on diagnostic. 4215091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // TODO: this should happen for bitfield stores, too. 4216091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt Value(32); 4217091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (E->isIntegerConstantExpr(Value, S.Context)) { 4218d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4219ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4220ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4221091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettySourceValue = Value.toString(10); 4222091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 4223091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 42245e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.DiagRuntimeBehavior(E->getExprLoc(), E, 42255e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.PDiag(diag::warn_impcast_integer_precision_constant) 42265e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << PrettySourceValue << PrettyTargetValue 42275e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << E->getType() << T << E->getSourceRange() 42285e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << clang::SourceRange(CC)); 4229091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return; 4230091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall } 4231091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 4232b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // People want to build with -Wshorten-64-to-32 and not -Wconversion. 4233d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4234ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4235ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 423637050841d7b852497b85d5275d9ea92c07ddf059David Blaikie if (TargetRange.Width == 32 && S.Context.getIntWidth(E->getType()) == 64) 4237c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32, 4238c36bedc90c687caa71748480c60707ea4608b092Anna Zaks /* pruneControlFlow */ true); 4239b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 4240323ed74658bc8375278eabf074b4777458376540John McCall } 4241323ed74658bc8375278eabf074b4777458376540John McCall 4242323ed74658bc8375278eabf074b4777458376540John McCall if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 4243323ed74658bc8375278eabf074b4777458376540John McCall (!TargetRange.NonNegative && SourceRange.NonNegative && 4244323ed74658bc8375278eabf074b4777458376540John McCall SourceRange.Width == TargetRange.Width)) { 4245ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4246d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4247ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4248ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4249323ed74658bc8375278eabf074b4777458376540John McCall unsigned DiagID = diag::warn_impcast_integer_sign; 4250323ed74658bc8375278eabf074b4777458376540John McCall 4251323ed74658bc8375278eabf074b4777458376540John McCall // Traditionally, gcc has warned about this under -Wsign-compare. 4252323ed74658bc8375278eabf074b4777458376540John McCall // We also want to warn about it in -Wconversion. 4253323ed74658bc8375278eabf074b4777458376540John McCall // So if -Wconversion is off, use a completely identical diagnostic 4254323ed74658bc8375278eabf074b4777458376540John McCall // in the sign-compare group. 4255323ed74658bc8375278eabf074b4777458376540John McCall // The conditional-checking code will 4256323ed74658bc8375278eabf074b4777458376540John McCall if (ICContext) { 4257323ed74658bc8375278eabf074b4777458376540John McCall DiagID = diag::warn_impcast_integer_sign_conditional; 4258323ed74658bc8375278eabf074b4777458376540John McCall *ICContext = true; 4259323ed74658bc8375278eabf074b4777458376540John McCall } 4260323ed74658bc8375278eabf074b4777458376540John McCall 4261b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, DiagID); 426251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 426351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4264284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor // Diagnose conversions between different enumeration types. 42655a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // In C, we pretend that the type of an EnumConstantDecl is its enumeration 42665a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // type, to give us better diagnostics. 42675a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor QualType SourceType = E->getType(); 42684e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (!S.getLangOpts().CPlusPlus) { 42695a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 42705a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) { 42715a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext()); 42725a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceType = S.Context.getTypeDeclType(Enum); 42735a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor Source = S.Context.getCanonicalType(SourceType).getTypePtr(); 42745a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 42755a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 42765a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 4277284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *SourceEnum = Source->getAs<EnumType>()) 4278284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *TargetEnum = Target->getAs<EnumType>()) 4279284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if ((SourceEnum->getDecl()->getIdentifier() || 4280162e1c1b487352434552147967c3dd296ebee2f7Richard Smith SourceEnum->getDecl()->getTypedefNameForAnonDecl()) && 4281284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor (TargetEnum->getDecl()->getIdentifier() || 4282162e1c1b487352434552147967c3dd296ebee2f7Richard Smith TargetEnum->getDecl()->getTypedefNameForAnonDecl()) && 4283ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceEnum != TargetEnum) { 4284d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4285ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4286ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 42875a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor return DiagnoseImpCast(S, E, SourceType, T, CC, 4288284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor diag::warn_impcast_different_enum_types); 4289ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 4290284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor 429151313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 429251313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 429351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4294323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T); 4295323ed74658bc8375278eabf074b4777458376540John McCall 4296323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T, 4297b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool &ICContext) { 4298323ed74658bc8375278eabf074b4777458376540John McCall E = E->IgnoreParenImpCasts(); 4299323ed74658bc8375278eabf074b4777458376540John McCall 4300323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) 4301323ed74658bc8375278eabf074b4777458376540John McCall return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T); 4302323ed74658bc8375278eabf074b4777458376540John McCall 4303b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E, CC); 4304323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 4305b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return CheckImplicitConversion(S, E, T, CC, &ICContext); 4306323ed74658bc8375278eabf074b4777458376540John McCall return; 4307323ed74658bc8375278eabf074b4777458376540John McCall} 4308323ed74658bc8375278eabf074b4777458376540John McCall 4309323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) { 4310b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC = E->getQuestionLoc(); 4311b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 4312b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getCond(), CC); 4313323ed74658bc8375278eabf074b4777458376540John McCall 4314323ed74658bc8375278eabf074b4777458376540John McCall bool Suspicious = false; 4315b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 4316b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 4317323ed74658bc8375278eabf074b4777458376540John McCall 4318323ed74658bc8375278eabf074b4777458376540John McCall // If -Wconversion would have warned about either of the candidates 4319323ed74658bc8375278eabf074b4777458376540John McCall // for a signedness conversion to the context type... 4320323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) return; 4321323ed74658bc8375278eabf074b4777458376540John McCall 4322323ed74658bc8375278eabf074b4777458376540John McCall // ...but it's currently ignored... 43230827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional, 43240827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis CC)) 4325323ed74658bc8375278eabf074b4777458376540John McCall return; 4326323ed74658bc8375278eabf074b4777458376540John McCall 4327323ed74658bc8375278eabf074b4777458376540John McCall // ...then check whether it would have warned about either of the 4328323ed74658bc8375278eabf074b4777458376540John McCall // candidates for a signedness conversion to the condition type. 43295254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (E->getType() == T) return; 43305254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu 43315254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu Suspicious = false; 43325254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 43335254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu E->getType(), CC, &Suspicious); 43345254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (!Suspicious) 43355254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 4336b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 4337323ed74658bc8375278eabf074b4777458376540John McCall} 4338323ed74658bc8375278eabf074b4777458376540John McCall 4339323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting 4340323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression. There are a couple 4341323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare. 4342b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 4343323ed74658bc8375278eabf074b4777458376540John McCall QualType T = OrigE->getType(); 4344323ed74658bc8375278eabf074b4777458376540John McCall Expr *E = OrigE->IgnoreParenImpCasts(); 4345323ed74658bc8375278eabf074b4777458376540John McCall 4346f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 4347f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor return; 4348f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor 4349323ed74658bc8375278eabf074b4777458376540John McCall // For conditional operators, we analyze the arguments as if they 4350323ed74658bc8375278eabf074b4777458376540John McCall // were being fed directly into the output. 4351323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) { 4352323ed74658bc8375278eabf074b4777458376540John McCall ConditionalOperator *CO = cast<ConditionalOperator>(E); 4353323ed74658bc8375278eabf074b4777458376540John McCall CheckConditionalOperator(S, CO, T); 4354323ed74658bc8375278eabf074b4777458376540John McCall return; 4355323ed74658bc8375278eabf074b4777458376540John McCall } 4356323ed74658bc8375278eabf074b4777458376540John McCall 4357323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and check any implicit conversions we might have skipped. 4358323ed74658bc8375278eabf074b4777458376540John McCall // The non-canonical typecheck is just an optimization; 4359323ed74658bc8375278eabf074b4777458376540John McCall // CheckImplicitConversion will filter out dead implicit conversions. 4360323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 4361b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckImplicitConversion(S, E, T, CC); 4362323ed74658bc8375278eabf074b4777458376540John McCall 4363323ed74658bc8375278eabf074b4777458376540John McCall // Now continue drilling into this expression. 4364323ed74658bc8375278eabf074b4777458376540John McCall 4365323ed74658bc8375278eabf074b4777458376540John McCall // Skip past explicit casts. 4366323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ExplicitCastExpr>(E)) { 4367323ed74658bc8375278eabf074b4777458376540John McCall E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 4368b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return AnalyzeImplicitConversions(S, E, CC); 4369323ed74658bc8375278eabf074b4777458376540John McCall } 4370323ed74658bc8375278eabf074b4777458376540John McCall 4371beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 4372beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Do a somewhat different check with comparison operators. 4373beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isComparisonOp()) 4374beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeComparison(S, BO); 4375beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 43760fa063816818ac53a0015a5d2b0328812005b40eEli Friedman // And with simple assignments. 43770fa063816818ac53a0015a5d2b0328812005b40eEli Friedman if (BO->getOpcode() == BO_Assign) 4378beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeAssignment(S, BO); 4379beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4380323ed74658bc8375278eabf074b4777458376540John McCall 4381323ed74658bc8375278eabf074b4777458376540John McCall // These break the otherwise-useful invariant below. Fortunately, 4382323ed74658bc8375278eabf074b4777458376540John McCall // we don't really need to recurse into them, because any internal 4383323ed74658bc8375278eabf074b4777458376540John McCall // expressions should have been analyzed already when they were 4384323ed74658bc8375278eabf074b4777458376540John McCall // built into statements. 4385323ed74658bc8375278eabf074b4777458376540John McCall if (isa<StmtExpr>(E)) return; 4386323ed74658bc8375278eabf074b4777458376540John McCall 4387323ed74658bc8375278eabf074b4777458376540John McCall // Don't descend into unevaluated contexts. 4388f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne if (isa<UnaryExprOrTypeTraitExpr>(E)) return; 4389323ed74658bc8375278eabf074b4777458376540John McCall 4390323ed74658bc8375278eabf074b4777458376540John McCall // Now just recurse over the expression's children. 4391b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CC = E->getExprLoc(); 4392f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu BinaryOperator *BO = dyn_cast<BinaryOperator>(E); 4393f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu bool IsLogicalOperator = BO && BO->isLogicalOp(); 4394f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu for (Stmt::child_range I = E->children(); I; ++I) { 439554042f1bd78f1f1ea86be7d4af541462e127d2edDouglas Gregor Expr *ChildExpr = dyn_cast_or_null<Expr>(*I); 4396503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor if (!ChildExpr) 4397503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor continue; 4398503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor 4399f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (IsLogicalOperator && 4400f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts())) 4401f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Ignore checking string literals that are in logical operators. 4402f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu continue; 4403f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu AnalyzeImplicitConversions(S, ChildExpr, CC); 4404f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 4405323ed74658bc8375278eabf074b4777458376540John McCall} 4406323ed74658bc8375278eabf074b4777458376540John McCall 4407323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace 4408323ed74658bc8375278eabf074b4777458376540John McCall 4409323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given 4410323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression). Implements -Wconversion 4411323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare. 4412b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// 4413b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e. 4414b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// the most location of the syntactic entity requiring the implicit 4415b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// conversion 4416b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 4417323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose in unevaluated contexts. 4418323ed74658bc8375278eabf074b4777458376540John McCall if (ExprEvalContexts.back().Context == Sema::Unevaluated) 4419323ed74658bc8375278eabf074b4777458376540John McCall return; 4420323ed74658bc8375278eabf074b4777458376540John McCall 4421323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose for value- or type-dependent expressions. 4422323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) 4423323ed74658bc8375278eabf074b4777458376540John McCall return; 4424323ed74658bc8375278eabf074b4777458376540John McCall 4425d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Check for array bounds violations in cases where the check isn't triggered 4426d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // elsewhere for other Expr types (like BinaryOperators), e.g. when an 4427d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // ArraySubscriptExpr is on the RHS of a variable initialization. 4428d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain CheckArrayAccess(E); 4429d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 4430b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // This is not the right CC for (e.g.) a variable initialization. 4431b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(*this, E, CC); 4432323ed74658bc8375278eabf074b4777458376540John McCall} 4433323ed74658bc8375278eabf074b4777458376540John McCall 443415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 443515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall FieldDecl *BitField, 443615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *Init) { 443715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 443815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 443915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 4440f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given 4441f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This 4442f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the 4443f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function 4444f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete. 444582aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregorbool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd, 444682aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor bool CheckParameterNames) { 4447f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump bool HasInvalidParm = false; 444882aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor for (; P != PEnd; ++P) { 444982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor ParmVarDecl *Param = *P; 445082aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor 4451f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.7.5.3p4: the parameters in a parameter type list in a 4452f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // function declarator that is part of a function definition of 4453f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // that function shall not have incomplete type. 4454f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // 4455f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // This is also C++ [dcl.fct]p6. 4456f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump if (!Param->isInvalidDecl() && 4457f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump RequireCompleteType(Param->getLocation(), Param->getType(), 4458f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump diag::err_typecheck_decl_incomplete_type)) { 4459f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Param->setInvalidDecl(); 4460f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump HasInvalidParm = true; 4461f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 4462f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 4463f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.9.1p5: If the declarator includes a parameter type list, the 4464f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // declaration of each parameter shall include an identifier. 446582aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor if (CheckParameterNames && 446682aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor Param->getIdentifier() == 0 && 4467f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !Param->isImplicit() && 44684e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie !getLangOpts().CPlusPlus) 4469f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Diag(Param->getLocation(), diag::err_parameter_name_omitted); 4470d17e340e2d516139931768697bf080f60920ba9dSam Weinig 4471d17e340e2d516139931768697bf080f60920ba9dSam Weinig // C99 6.7.5.3p12: 4472d17e340e2d516139931768697bf080f60920ba9dSam Weinig // If the function declarator is not part of a definition of that 4473d17e340e2d516139931768697bf080f60920ba9dSam Weinig // function, parameters may have incomplete type and may use the [*] 4474d17e340e2d516139931768697bf080f60920ba9dSam Weinig // notation in their sequences of declarator specifiers to specify 4475d17e340e2d516139931768697bf080f60920ba9dSam Weinig // variable length array types. 4476d17e340e2d516139931768697bf080f60920ba9dSam Weinig QualType PType = Param->getOriginalType(); 4477d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (const ArrayType *AT = Context.getAsArrayType(PType)) { 4478d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (AT->getSizeModifier() == ArrayType::Star) { 4479d17e340e2d516139931768697bf080f60920ba9dSam Weinig // FIXME: This diagnosic should point the the '[*]' if source-location 4480d17e340e2d516139931768697bf080f60920ba9dSam Weinig // information is added for it. 4481d17e340e2d516139931768697bf080f60920ba9dSam Weinig Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 4482d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 4483d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 4484f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 4485f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 4486f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump return HasInvalidParm; 4487f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump} 4488b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4489b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a 4490b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements. 4491b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 4492b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // This is actually a lot of work to potentially be doing on every 4493b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // cast; don't do it if we're ignoring -Wcast_align (as is the default). 44940827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align, 44950827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis TRange.getBegin()) 4496d6471f7c1921c7802804ce3ff6fe9768310f72b9David Blaikie == DiagnosticsEngine::Ignored) 4497b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 4498b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4499b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Ignore dependent types. 4500b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (T->isDependentType() || Op->getType()->isDependentType()) 4501b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 4502b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4503b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the destination be a pointer type. 4504b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *DestPtr = T->getAs<PointerType>(); 4505b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!DestPtr) return; 4506b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4507b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // If the destination has alignment 1, we're done. 4508b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType DestPointee = DestPtr->getPointeeType(); 4509b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestPointee->isIncompleteType()) return; 4510b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 4511b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestAlign.isOne()) return; 4512b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4513b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the source be a pointer type. 4514b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 4515b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!SrcPtr) return; 4516b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType SrcPointee = SrcPtr->getPointeeType(); 4517b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4518b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Whitelist casts from cv void*. We already implicitly 4519b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // whitelisted casts to cv void*, since they have alignment 1. 4520b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Also whitelist casts involving incomplete types, which implicitly 4521b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // includes 'void'. 4522b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcPointee->isIncompleteType()) return; 4523b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4524b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 4525b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcAlign >= DestAlign) return; 4526b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4527b7f4ffe073fa419613946461a2583ba2fcb72280John McCall Diag(TRange.getBegin(), diag::warn_cast_align) 4528b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << Op->getType() << T 4529b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(SrcAlign.getQuantity()) 4530b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(DestAlign.getQuantity()) 4531b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << TRange << Op->getSourceRange(); 4532b7f4ffe073fa419613946461a2583ba2fcb72280John McCall} 4533b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4534d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainstatic const Type* getElementType(const Expr *BaseExpr) { 4535d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* EltType = BaseExpr->getType().getTypePtr(); 4536d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (EltType->isAnyPointerType()) 4537d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getPointeeType().getTypePtr(); 4538d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain else if (EltType->isArrayType()) 4539d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getBaseElementTypeUnsafe(); 4540d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType; 4541d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain} 4542d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 4543c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// \brief Check whether this array fits the idiom of a size-one tail padded 4544c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// array member of a struct. 4545c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// 4546c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// We avoid emitting out-of-bounds access warnings for such arrays as they are 4547c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// commonly used to emulate flexible arrays in C89 code. 4548c268434b332bbe57950d977633369bf5822d9554Chandler Carruthstatic bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size, 4549c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const NamedDecl *ND) { 4550c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (Size != 1 || !ND) return false; 4551c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 4552c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const FieldDecl *FD = dyn_cast<FieldDecl>(ND); 4553c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!FD) return false; 4554c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 4555c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // Don't consider sizes resulting from macro expansions or template argument 4556c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // substitution to form C89 tail-padded arrays. 4557c268434b332bbe57950d977633369bf5822d9554Chandler Carruth ConstantArrayTypeLoc TL = 4558c268434b332bbe57950d977633369bf5822d9554Chandler Carruth cast<ConstantArrayTypeLoc>(FD->getTypeSourceInfo()->getTypeLoc()); 4559c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const Expr *SizeExpr = dyn_cast<IntegerLiteral>(TL.getSizeExpr()); 4560c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!SizeExpr || SizeExpr->getExprLoc().isMacroID()) 4561c268434b332bbe57950d977633369bf5822d9554Chandler Carruth return false; 4562c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 4563c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext()); 4564381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!RD) return false; 4565381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (RD->isUnion()) return false; 4566381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) { 4567381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!CRD->isStandardLayout()) return false; 4568381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay } 4569c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 457022d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer // See if this is the last field decl in the record. 457122d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer const Decl *D = FD; 457222d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer while ((D = D->getNextDeclInContext())) 457322d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer if (isa<FieldDecl>(D)) 457422d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return false; 457522d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return true; 4576c268434b332bbe57950d977633369bf5822d9554Chandler Carruth} 4577c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 4578d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainvoid Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr, 457980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const ArraySubscriptExpr *ASE, 458025b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith bool AllowOnePastEnd, bool IndexNegated) { 458192b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman IndexExpr = IndexExpr->IgnoreParenImpCasts(); 458280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (IndexExpr->isValueDependent()) 458380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 4584d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 458580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const Type *EffectiveType = getElementType(BaseExpr); 458680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay BaseExpr = BaseExpr->IgnoreParenCasts(); 45873406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const ConstantArrayType *ArrayTy = 4588d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain Context.getAsConstantArrayType(BaseExpr->getType()); 45893406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (!ArrayTy) 4590a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 459135001ca261f895817916b468379b696d6d45959dChandler Carruth 45923406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth llvm::APSInt index; 459380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!IndexExpr->EvaluateAsInt(index, Context)) 4594a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 459525b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith if (IndexNegated) 459625b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith index = -index; 45978fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek 4598ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth const NamedDecl *ND = NULL; 4599ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 4600ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(DRE->getDecl()); 4601c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 4602ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 4603ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 46049e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek if (index.isUnsigned() || !index.isNegative()) { 460525b3b849e3ad340b04442707038c86980035765bTed Kremenek llvm::APInt size = ArrayTy->getSize(); 460635001ca261f895817916b468379b696d6d45959dChandler Carruth if (!size.isStrictlyPositive()) 460735001ca261f895817916b468379b696d6d45959dChandler Carruth return; 4608d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 4609d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* BaseType = getElementType(BaseExpr); 4610de5998f1d7dcecb777257ec932142d65de636eb8Nico Weber if (BaseType != EffectiveType) { 4611d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Make sure we're comparing apples to apples when comparing index to size 4612d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType); 4613d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t array_typesize = Context.getTypeSize(BaseType); 4614d10f4bc5a05ce0cdc1646dbb0f706bb9d3dfc0c5Kaelyn Uhrain // Handle ptrarith_typesize being zero, such as when casting to void* 461518f169770d9d3f826bad8f1359c8c5770c5ab16fKaelyn Uhrain if (!ptrarith_typesize) ptrarith_typesize = 1; 4616d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize != array_typesize) { 4617d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // There's a cast to a different size type involved 4618d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ratio = array_typesize / ptrarith_typesize; 4619d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // TODO: Be smarter about handling cases where array_typesize is not a 4620d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // multiple of ptrarith_typesize 4621d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize * ratio == array_typesize) 4622d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain size *= llvm::APInt(size.getBitWidth(), ratio); 4623d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 4624d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 4625d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 46263406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (size.getBitWidth() > index.getBitWidth()) 462792b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman index = index.zext(size.getBitWidth()); 462825b3b849e3ad340b04442707038c86980035765bTed Kremenek else if (size.getBitWidth() < index.getBitWidth()) 462992b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman size = size.zext(index.getBitWidth()); 463025b3b849e3ad340b04442707038c86980035765bTed Kremenek 4631d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // For array subscripting the index must be less than size, but for pointer 4632d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // arithmetic also allow the index (offset) to be equal to size since 4633d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // computing the next address after the end of the array is legal and 4634d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // commonly done e.g. in C++ iterators and range-based for loops. 463592b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman if (AllowOnePastEnd ? index.ule(size) : index.ult(size)) 4636ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth return; 4637ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 4638ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // Also don't warn for arrays of size 1 which are members of some 4639ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // structure. These are often used to approximate flexible arrays in C89 4640ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // code. 4641d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (IsTailPaddedMemberArray(*this, size, ND)) 46428fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek return; 46433406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth 464480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // Suppress the warning if the subscript expression (as identified by the 464580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // ']' location) and the index expression are both from macro expansions 464680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // within a system header. 464780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) { 464880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation RBracketLoc = SourceMgr.getSpellingLoc( 464980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay ASE->getRBracketLoc()); 465080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isInSystemHeader(RBracketLoc)) { 465180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation IndexLoc = SourceMgr.getSpellingLoc( 465280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay IndexExpr->getLocStart()); 465380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isFromSameFile(RBracketLoc, IndexLoc)) 465480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 465580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 465680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 465780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay 4658d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds; 465980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) 4660d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_array_index_exceeds_bounds; 4661d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 4662d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 4663d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 4664d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << size.toString(10, true) 4665d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << (unsigned)size.getLimitedValue(~0U) 4666d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 46673406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth } else { 4668d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_array_index_precedes_bounds; 466980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!ASE) { 4670d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_ptr_arith_precedes_bounds; 4671d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (index.isNegative()) index = -index; 4672d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 4673d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 4674d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 4675d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 4676d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 4677a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek } 467835001ca261f895817916b468379b696d6d45959dChandler Carruth 4679cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (!ND) { 4680cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay // Try harder to find a NamedDecl to point at in the note. 4681cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay while (const ArraySubscriptExpr *ASE = 4682cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay dyn_cast<ArraySubscriptExpr>(BaseExpr)) 4683cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay BaseExpr = ASE->getBase()->IgnoreParenCasts(); 4684cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 4685cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(DRE->getDecl()); 4686cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 4687cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 4688cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay } 4689cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay 469035001ca261f895817916b468379b696d6d45959dChandler Carruth if (ND) 4691d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(ND->getLocStart(), BaseExpr, 4692d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(diag::note_array_index_out_of_bounds) 4693d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << ND->getDeclName()); 46943aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek} 46953aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek 46963aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) { 4697d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain int AllowOnePastEnd = 0; 4698d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain while (expr) { 4699d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = expr->IgnoreParenImpCasts(); 47003aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek switch (expr->getStmtClass()) { 4701d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::ArraySubscriptExprClass: { 4702d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr); 470380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE, 4704d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd > 0); 47053aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 4706d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 4707d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::UnaryOperatorClass: { 4708d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Only unwrap the * and & unary operators 4709d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const UnaryOperator *UO = cast<UnaryOperator>(expr); 4710d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = UO->getSubExpr(); 4711d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain switch (UO->getOpcode()) { 4712d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_AddrOf: 4713d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd++; 4714d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 4715d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_Deref: 4716d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd--; 4717d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 4718d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain default: 4719d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return; 4720d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 4721d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 4722d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 47233aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek case Stmt::ConditionalOperatorClass: { 47243aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek const ConditionalOperator *cond = cast<ConditionalOperator>(expr); 47253aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *lhs = cond->getLHS()) 47263aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(lhs); 47273aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *rhs = cond->getRHS()) 47283aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(rhs); 47293aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 47303aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 47313aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek default: 47323aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 47333aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 4734f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne } 4735a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek} 4736f85e193739c953358c865005855253af4f68a497John McCall 4737f85e193739c953358c865005855253af4f68a497John McCall//===--- CHECK: Objective-C retain cycles ----------------------------------// 4738f85e193739c953358c865005855253af4f68a497John McCall 4739f85e193739c953358c865005855253af4f68a497John McCallnamespace { 4740f85e193739c953358c865005855253af4f68a497John McCall struct RetainCycleOwner { 4741f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner() : Variable(0), Indirect(false) {} 4742f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 4743f85e193739c953358c865005855253af4f68a497John McCall SourceRange Range; 4744f85e193739c953358c865005855253af4f68a497John McCall SourceLocation Loc; 4745f85e193739c953358c865005855253af4f68a497John McCall bool Indirect; 4746f85e193739c953358c865005855253af4f68a497John McCall 4747f85e193739c953358c865005855253af4f68a497John McCall void setLocsFrom(Expr *e) { 4748f85e193739c953358c865005855253af4f68a497John McCall Loc = e->getExprLoc(); 4749f85e193739c953358c865005855253af4f68a497John McCall Range = e->getSourceRange(); 4750f85e193739c953358c865005855253af4f68a497John McCall } 4751f85e193739c953358c865005855253af4f68a497John McCall }; 4752f85e193739c953358c865005855253af4f68a497John McCall} 4753f85e193739c953358c865005855253af4f68a497John McCall 4754f85e193739c953358c865005855253af4f68a497John McCall/// Consider whether capturing the given variable can possibly lead to 4755f85e193739c953358c865005855253af4f68a497John McCall/// a retain cycle. 4756f85e193739c953358c865005855253af4f68a497John McCallstatic bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) { 4757f85e193739c953358c865005855253af4f68a497John McCall // In ARC, it's captured strongly iff the variable has __strong 4758f85e193739c953358c865005855253af4f68a497John McCall // lifetime. In MRR, it's captured strongly if the variable is 4759f85e193739c953358c865005855253af4f68a497John McCall // __block and has an appropriate type. 4760f85e193739c953358c865005855253af4f68a497John McCall if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 4761f85e193739c953358c865005855253af4f68a497John McCall return false; 4762f85e193739c953358c865005855253af4f68a497John McCall 4763f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = var; 4764f85e193739c953358c865005855253af4f68a497John McCall owner.setLocsFrom(ref); 4765f85e193739c953358c865005855253af4f68a497John McCall return true; 4766f85e193739c953358c865005855253af4f68a497John McCall} 4767f85e193739c953358c865005855253af4f68a497John McCall 47686e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanianstatic bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) { 4769f85e193739c953358c865005855253af4f68a497John McCall while (true) { 4770f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParens(); 4771f85e193739c953358c865005855253af4f68a497John McCall if (CastExpr *cast = dyn_cast<CastExpr>(e)) { 4772f85e193739c953358c865005855253af4f68a497John McCall switch (cast->getCastKind()) { 4773f85e193739c953358c865005855253af4f68a497John McCall case CK_BitCast: 4774f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueBitCast: 4775f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueToRValue: 477633e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall case CK_ARCReclaimReturnedObject: 4777f85e193739c953358c865005855253af4f68a497John McCall e = cast->getSubExpr(); 4778f85e193739c953358c865005855253af4f68a497John McCall continue; 4779f85e193739c953358c865005855253af4f68a497John McCall 4780f85e193739c953358c865005855253af4f68a497John McCall default: 4781f85e193739c953358c865005855253af4f68a497John McCall return false; 4782f85e193739c953358c865005855253af4f68a497John McCall } 4783f85e193739c953358c865005855253af4f68a497John McCall } 4784f85e193739c953358c865005855253af4f68a497John McCall 4785f85e193739c953358c865005855253af4f68a497John McCall if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) { 4786f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar = ref->getDecl(); 4787f85e193739c953358c865005855253af4f68a497John McCall if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 4788f85e193739c953358c865005855253af4f68a497John McCall return false; 4789f85e193739c953358c865005855253af4f68a497John McCall 4790f85e193739c953358c865005855253af4f68a497John McCall // Try to find a retain cycle in the base. 47916e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(S, ref->getBase(), owner)) 4792f85e193739c953358c865005855253af4f68a497John McCall return false; 4793f85e193739c953358c865005855253af4f68a497John McCall 4794f85e193739c953358c865005855253af4f68a497John McCall if (ref->isFreeIvar()) owner.setLocsFrom(ref); 4795f85e193739c953358c865005855253af4f68a497John McCall owner.Indirect = true; 4796f85e193739c953358c865005855253af4f68a497John McCall return true; 4797f85e193739c953358c865005855253af4f68a497John McCall } 4798f85e193739c953358c865005855253af4f68a497John McCall 4799f85e193739c953358c865005855253af4f68a497John McCall if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) { 4800f85e193739c953358c865005855253af4f68a497John McCall VarDecl *var = dyn_cast<VarDecl>(ref->getDecl()); 4801f85e193739c953358c865005855253af4f68a497John McCall if (!var) return false; 4802f85e193739c953358c865005855253af4f68a497John McCall return considerVariable(var, ref, owner); 4803f85e193739c953358c865005855253af4f68a497John McCall } 4804f85e193739c953358c865005855253af4f68a497John McCall 4805f85e193739c953358c865005855253af4f68a497John McCall if (MemberExpr *member = dyn_cast<MemberExpr>(e)) { 4806f85e193739c953358c865005855253af4f68a497John McCall if (member->isArrow()) return false; 4807f85e193739c953358c865005855253af4f68a497John McCall 4808f85e193739c953358c865005855253af4f68a497John McCall // Don't count this as an indirect ownership. 4809f85e193739c953358c865005855253af4f68a497John McCall e = member->getBase(); 4810f85e193739c953358c865005855253af4f68a497John McCall continue; 4811f85e193739c953358c865005855253af4f68a497John McCall } 4812f85e193739c953358c865005855253af4f68a497John McCall 48134b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) { 48144b9c2d235fb9449e249d74f48ecfec601650de93John McCall // Only pay attention to pseudo-objects on property references. 48154b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyRefExpr *pre 48164b9c2d235fb9449e249d74f48ecfec601650de93John McCall = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm() 48174b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->IgnoreParens()); 48184b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!pre) return false; 48194b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (pre->isImplicitProperty()) return false; 48204b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyDecl *property = pre->getExplicitProperty(); 48214b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!property->isRetaining() && 48224b9c2d235fb9449e249d74f48ecfec601650de93John McCall !(property->getPropertyIvarDecl() && 48234b9c2d235fb9449e249d74f48ecfec601650de93John McCall property->getPropertyIvarDecl()->getType() 48244b9c2d235fb9449e249d74f48ecfec601650de93John McCall .getObjCLifetime() == Qualifiers::OCL_Strong)) 48254b9c2d235fb9449e249d74f48ecfec601650de93John McCall return false; 48264b9c2d235fb9449e249d74f48ecfec601650de93John McCall 48274b9c2d235fb9449e249d74f48ecfec601650de93John McCall owner.Indirect = true; 48286e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (pre->isSuperReceiver()) { 48296e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Variable = S.getCurMethodDecl()->getSelfDecl(); 48306e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!owner.Variable) 48316e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return false; 48326e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Loc = pre->getLocation(); 48336e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Range = pre->getSourceRange(); 48346e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return true; 48356e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian } 48364b9c2d235fb9449e249d74f48ecfec601650de93John McCall e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase()) 48374b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->getSourceExpr()); 48384b9c2d235fb9449e249d74f48ecfec601650de93John McCall continue; 48394b9c2d235fb9449e249d74f48ecfec601650de93John McCall } 48404b9c2d235fb9449e249d74f48ecfec601650de93John McCall 4841f85e193739c953358c865005855253af4f68a497John McCall // Array ivars? 4842f85e193739c953358c865005855253af4f68a497John McCall 4843f85e193739c953358c865005855253af4f68a497John McCall return false; 4844f85e193739c953358c865005855253af4f68a497John McCall } 4845f85e193739c953358c865005855253af4f68a497John McCall} 4846f85e193739c953358c865005855253af4f68a497John McCall 4847f85e193739c953358c865005855253af4f68a497John McCallnamespace { 4848f85e193739c953358c865005855253af4f68a497John McCall struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> { 4849f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor(ASTContext &Context, VarDecl *variable) 4850f85e193739c953358c865005855253af4f68a497John McCall : EvaluatedExprVisitor<FindCaptureVisitor>(Context), 4851f85e193739c953358c865005855253af4f68a497John McCall Variable(variable), Capturer(0) {} 4852f85e193739c953358c865005855253af4f68a497John McCall 4853f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 4854f85e193739c953358c865005855253af4f68a497John McCall Expr *Capturer; 4855f85e193739c953358c865005855253af4f68a497John McCall 4856f85e193739c953358c865005855253af4f68a497John McCall void VisitDeclRefExpr(DeclRefExpr *ref) { 4857f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 4858f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 4859f85e193739c953358c865005855253af4f68a497John McCall } 4860f85e193739c953358c865005855253af4f68a497John McCall 4861f85e193739c953358c865005855253af4f68a497John McCall void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) { 4862f85e193739c953358c865005855253af4f68a497John McCall if (Capturer) return; 4863f85e193739c953358c865005855253af4f68a497John McCall Visit(ref->getBase()); 4864f85e193739c953358c865005855253af4f68a497John McCall if (Capturer && ref->isFreeIvar()) 4865f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 4866f85e193739c953358c865005855253af4f68a497John McCall } 4867f85e193739c953358c865005855253af4f68a497John McCall 4868f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockExpr(BlockExpr *block) { 4869f85e193739c953358c865005855253af4f68a497John McCall // Look inside nested blocks 4870f85e193739c953358c865005855253af4f68a497John McCall if (block->getBlockDecl()->capturesVariable(Variable)) 4871f85e193739c953358c865005855253af4f68a497John McCall Visit(block->getBlockDecl()->getBody()); 4872f85e193739c953358c865005855253af4f68a497John McCall } 4873f85e193739c953358c865005855253af4f68a497John McCall }; 4874f85e193739c953358c865005855253af4f68a497John McCall} 4875f85e193739c953358c865005855253af4f68a497John McCall 4876f85e193739c953358c865005855253af4f68a497John McCall/// Check whether the given argument is a block which captures a 4877f85e193739c953358c865005855253af4f68a497John McCall/// variable. 4878f85e193739c953358c865005855253af4f68a497John McCallstatic Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) { 4879f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 4880f85e193739c953358c865005855253af4f68a497John McCall 4881f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParenCasts(); 4882f85e193739c953358c865005855253af4f68a497John McCall BlockExpr *block = dyn_cast<BlockExpr>(e); 4883f85e193739c953358c865005855253af4f68a497John McCall if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable)) 4884f85e193739c953358c865005855253af4f68a497John McCall return 0; 4885f85e193739c953358c865005855253af4f68a497John McCall 4886f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor visitor(S.Context, owner.Variable); 4887f85e193739c953358c865005855253af4f68a497John McCall visitor.Visit(block->getBlockDecl()->getBody()); 4888f85e193739c953358c865005855253af4f68a497John McCall return visitor.Capturer; 4889f85e193739c953358c865005855253af4f68a497John McCall} 4890f85e193739c953358c865005855253af4f68a497John McCall 4891f85e193739c953358c865005855253af4f68a497John McCallstatic void diagnoseRetainCycle(Sema &S, Expr *capturer, 4892f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner &owner) { 4893f85e193739c953358c865005855253af4f68a497John McCall assert(capturer); 4894f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 4895f85e193739c953358c865005855253af4f68a497John McCall 4896f85e193739c953358c865005855253af4f68a497John McCall S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle) 4897f85e193739c953358c865005855253af4f68a497John McCall << owner.Variable << capturer->getSourceRange(); 4898f85e193739c953358c865005855253af4f68a497John McCall S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner) 4899f85e193739c953358c865005855253af4f68a497John McCall << owner.Indirect << owner.Range; 4900f85e193739c953358c865005855253af4f68a497John McCall} 4901f85e193739c953358c865005855253af4f68a497John McCall 4902f85e193739c953358c865005855253af4f68a497John McCall/// Check for a keyword selector that starts with the word 'add' or 4903f85e193739c953358c865005855253af4f68a497John McCall/// 'set'. 4904f85e193739c953358c865005855253af4f68a497John McCallstatic bool isSetterLikeSelector(Selector sel) { 4905f85e193739c953358c865005855253af4f68a497John McCall if (sel.isUnarySelector()) return false; 4906f85e193739c953358c865005855253af4f68a497John McCall 49075f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef str = sel.getNameForSlot(0); 4908f85e193739c953358c865005855253af4f68a497John McCall while (!str.empty() && str.front() == '_') str = str.substr(1); 4909968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (str.startswith("set")) 4910f85e193739c953358c865005855253af4f68a497John McCall str = str.substr(3); 4911968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek else if (str.startswith("add")) { 4912968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek // Specially whitelist 'addOperationWithBlock:'. 4913968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock")) 4914968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek return false; 4915968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek str = str.substr(3); 4916968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek } 4917f85e193739c953358c865005855253af4f68a497John McCall else 4918f85e193739c953358c865005855253af4f68a497John McCall return false; 4919f85e193739c953358c865005855253af4f68a497John McCall 4920f85e193739c953358c865005855253af4f68a497John McCall if (str.empty()) return true; 4921f85e193739c953358c865005855253af4f68a497John McCall return !islower(str.front()); 4922f85e193739c953358c865005855253af4f68a497John McCall} 4923f85e193739c953358c865005855253af4f68a497John McCall 4924f85e193739c953358c865005855253af4f68a497John McCall/// Check a message send to see if it's likely to cause a retain cycle. 4925f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(ObjCMessageExpr *msg) { 4926f85e193739c953358c865005855253af4f68a497John McCall // Only check instance methods whose selector looks like a setter. 4927f85e193739c953358c865005855253af4f68a497John McCall if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector())) 4928f85e193739c953358c865005855253af4f68a497John McCall return; 4929f85e193739c953358c865005855253af4f68a497John McCall 4930f85e193739c953358c865005855253af4f68a497John McCall // Try to find a variable that the receiver is strongly owned by. 4931f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 4932f85e193739c953358c865005855253af4f68a497John McCall if (msg->getReceiverKind() == ObjCMessageExpr::Instance) { 49336e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner)) 4934f85e193739c953358c865005855253af4f68a497John McCall return; 4935f85e193739c953358c865005855253af4f68a497John McCall } else { 4936f85e193739c953358c865005855253af4f68a497John McCall assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance); 4937f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = getCurMethodDecl()->getSelfDecl(); 4938f85e193739c953358c865005855253af4f68a497John McCall owner.Loc = msg->getSuperLoc(); 4939f85e193739c953358c865005855253af4f68a497John McCall owner.Range = msg->getSuperLoc(); 4940f85e193739c953358c865005855253af4f68a497John McCall } 4941f85e193739c953358c865005855253af4f68a497John McCall 4942f85e193739c953358c865005855253af4f68a497John McCall // Check whether the receiver is captured by any of the arguments. 4943f85e193739c953358c865005855253af4f68a497John McCall for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i) 4944f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner)) 4945f85e193739c953358c865005855253af4f68a497John McCall return diagnoseRetainCycle(*this, capturer, owner); 4946f85e193739c953358c865005855253af4f68a497John McCall} 4947f85e193739c953358c865005855253af4f68a497John McCall 4948f85e193739c953358c865005855253af4f68a497John McCall/// Check a property assign to see if it's likely to cause a retain cycle. 4949f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(Expr *receiver, Expr *argument) { 4950f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 49516e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, receiver, owner)) 4952f85e193739c953358c865005855253af4f68a497John McCall return; 4953f85e193739c953358c865005855253af4f68a497John McCall 4954f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, argument, owner)) 4955f85e193739c953358c865005855253af4f68a497John McCall diagnoseRetainCycle(*this, capturer, owner); 4956f85e193739c953358c865005855253af4f68a497John McCall} 4957f85e193739c953358c865005855253af4f68a497John McCall 4958921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianbool Sema::checkUnsafeAssigns(SourceLocation Loc, 4959f85e193739c953358c865005855253af4f68a497John McCall QualType LHS, Expr *RHS) { 4960f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime(); 4961f85e193739c953358c865005855253af4f68a497John McCall if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone) 4962921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return false; 4963921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // strip off any implicit cast added to get to the one arc-specific 4964921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 496533e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 4966f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::warn_arc_retained_assign) 4967f85e193739c953358c865005855253af4f68a497John McCall << (LT == Qualifiers::OCL_ExplicitNone) 4968f85e193739c953358c865005855253af4f68a497John McCall << RHS->getSourceRange(); 4969921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return true; 4970921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4971921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 4972921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4973921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return false; 4974f85e193739c953358c865005855253af4f68a497John McCall} 4975f85e193739c953358c865005855253af4f68a497John McCall 4976921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianvoid Sema::checkUnsafeExprAssigns(SourceLocation Loc, 4977921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Expr *LHS, Expr *RHS) { 497887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian QualType LHSType; 497987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // PropertyRef on LHS type need be directly obtained from 498087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // its declaration as it has a PsuedoType. 498187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian ObjCPropertyRefExpr *PRE 498287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens()); 498387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PRE && !PRE->isImplicitProperty()) { 498487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 498587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PD) 498687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType = PD->getType(); 498787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian } 498887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian 498987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (LHSType.isNull()) 499087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType = LHS->getType(); 4991921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (checkUnsafeAssigns(Loc, LHSType, RHS)) 4992921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4993921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime(); 4994921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // FIXME. Check for other life times. 4995921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (LT != Qualifiers::OCL_None) 4996921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4997921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 499887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PRE) { 4999921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (PRE->isImplicitProperty()) 5000921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 5001921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 5002921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (!PD) 5003921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 5004921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 5005921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian unsigned Attributes = PD->getPropertyAttributes(); 500687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) { 500787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // when 'assign' attribute was not explicitly specified 500887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // by user, ignore it and rely on property type itself 500987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // for lifetime info. 501087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten(); 501187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) && 501287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType->isObjCRetainableType()) 501387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian return; 501487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian 5015921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 501633e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 5017921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Diag(Loc, diag::warn_arc_retained_property_assign) 5018921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian << RHS->getSourceRange(); 5019921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 5020921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 5021921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 5022921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 502387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian } 5024921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 5025921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian} 5026625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5027625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko//===--- CHECK: Empty statement body (-Wempty-body) ---------------------===// 5028625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5029625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkonamespace { 5030625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkobool ShouldDiagnoseEmptyStmtBody(const SourceManager &SourceMgr, 5031625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko SourceLocation StmtLoc, 5032625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *Body) { 5033625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do not warn if the body is a macro that expands to nothing, e.g: 5034625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // 5035625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // #define CALL(x) 5036625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // if (condition) 5037625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // CALL(0); 5038625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // 5039625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (Body->hasLeadingEmptyMacro()) 5040625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 5041625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5042625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Get line numbers of statement and body. 5043625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool StmtLineInvalid; 5044625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned StmtLine = SourceMgr.getSpellingLineNumber(StmtLoc, 5045625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &StmtLineInvalid); 5046625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtLineInvalid) 5047625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 5048625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5049625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool BodyLineInvalid; 5050625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned BodyLine = SourceMgr.getSpellingLineNumber(Body->getSemiLoc(), 5051625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &BodyLineInvalid); 5052625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyLineInvalid) 5053625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 5054625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5055625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Warn if null statement and body are on the same line. 5056625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtLine != BodyLine) 5057625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 5058625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5059625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return true; 5060625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 5061625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} // Unnamed namespace 5062625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5063625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyStmtBody(SourceLocation StmtLoc, 5064625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *Body, 5065625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned DiagID) { 5066625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Since this is a syntactic check, don't emit diagnostic for template 5067625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // instantiations, this just adds noise. 5068625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (CurrentInstantiationScope) 5069625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5070625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5071625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // The body should be a null statement. 5072625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *NBody = dyn_cast<NullStmt>(Body); 5073625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!NBody) 5074625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5075625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5076625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do the usual checks. 5077625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 5078625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5079625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5080625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), DiagID); 5081625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 5082625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 5083625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5084625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyLoopBody(const Stmt *S, 5085625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *PossibleBody) { 5086625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko assert(!CurrentInstantiationScope); // Ensured by caller 5087625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5088625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko SourceLocation StmtLoc; 5089625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *Body; 5090625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned DiagID; 5091625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (const ForStmt *FS = dyn_cast<ForStmt>(S)) { 5092625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko StmtLoc = FS->getRParenLoc(); 5093625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Body = FS->getBody(); 5094625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagID = diag::warn_empty_for_body; 5095625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } else if (const WhileStmt *WS = dyn_cast<WhileStmt>(S)) { 5096625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko StmtLoc = WS->getCond()->getSourceRange().getEnd(); 5097625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Body = WS->getBody(); 5098625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagID = diag::warn_empty_while_body; 5099625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } else 5100625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; // Neither `for' nor `while'. 5101625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5102625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // The body should be a null statement. 5103625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *NBody = dyn_cast<NullStmt>(Body); 5104625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!NBody) 5105625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5106625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5107625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Skip expensive checks if diagnostic is disabled. 5108625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (Diags.getDiagnosticLevel(DiagID, NBody->getSemiLoc()) == 5109625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagnosticsEngine::Ignored) 5110625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5111625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5112625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do the usual checks. 5113625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 5114625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5115625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5116625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // `for(...);' and `while(...);' are popular idioms, so in order to keep 5117625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // noise level low, emit diagnostics only if for/while is followed by a 5118625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // CompoundStmt, e.g.: 5119625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // for (int i = 0; i < n; i++); 5120625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // { 5121625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // a(i); 5122625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // } 5123625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // or if for/while is followed by a statement with more indentation 5124625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // than for/while itself: 5125625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // for (int i = 0; i < n; i++); 5126625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // a(i); 5127625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool ProbableTypo = isa<CompoundStmt>(PossibleBody); 5128625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ProbableTypo) { 5129625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool BodyColInvalid; 5130625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned BodyCol = SourceMgr.getPresumedColumnNumber( 5131625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko PossibleBody->getLocStart(), 5132625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &BodyColInvalid); 5133625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyColInvalid) 5134625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5135625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5136625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool StmtColInvalid; 5137625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned StmtCol = SourceMgr.getPresumedColumnNumber( 5138625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko S->getLocStart(), 5139625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &StmtColInvalid); 5140625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtColInvalid) 5141625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5142625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5143625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyCol > StmtCol) 5144625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko ProbableTypo = true; 5145625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } 5146625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5147625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (ProbableTypo) { 5148625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), DiagID); 5149625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 5150625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } 5151625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 5152