SemaChecking.cpp revision 3c3b7f90a863af43fa63043d396553ecf205351c
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// The LLVM Compiler Infrastructure 459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source 60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details. 759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump// This file implements extra semantic analysis beyond what is enforced 1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// by the C type system. 1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 155f8d604246976a93a73549b07bbc8ee0b2061b50John McCall#include "clang/Sema/Initialization.h" 16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Sema.h" 172d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 18276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman#include "clang/Sema/Initialization.h" 19781472fe99a120098c631b0cbe33c89f8cef5e70John McCall#include "clang/Sema/ScopeInfo.h" 20826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek#include "clang/Analysis/Analyses/FormatString.h" 2159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h" 22199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h" 23384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 24c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h" 252324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h" 267ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h" 27f85e193739c953358c865005855253af4f68a497John McCall#include "clang/AST/EvaluatedExprVisitor.h" 28f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/DeclObjC.h" 29f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h" 30f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h" 3159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h" 32f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h" 33f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h" 343bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h" 35691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher#include "clang/Basic/TargetBuiltins.h" 3626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman#include "clang/Basic/TargetInfo.h" 377da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian#include "clang/Basic/ConvertUTF.h" 38a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits> 3959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang; 40781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema; 4159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 4260800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 4360800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned ByteNo) const { 4408f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner return SL->getLocationOfByte(ByteNo, PP.getSourceManager(), 4508f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner PP.getLangOptions(), PP.getTargetInfo()); 4660800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner} 4708f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner 4860800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 494403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// CheckablePrintfAttr - does a function call have a "printf" attribute 504403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// and arguments that merit checking? 514403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynnbool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) { 524403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf") return true; 534403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf0") { 544403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn // printf0 allows null "format" string; if so don't check format/args 554403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn unsigned format_idx = Format->getFormatIdx() - 1; 564a2614e94672c47395abcde60518776fbebec589Sebastian Redl // Does the index refer to the implicit object argument? 574a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 584a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (format_idx == 0) 594a2614e94672c47395abcde60518776fbebec589Sebastian Redl return false; 604a2614e94672c47395abcde60518776fbebec589Sebastian Redl --format_idx; 614a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 624403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (format_idx < TheCall->getNumArgs()) { 634403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts(); 64efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!Format->isNullPointerConstant(Context, 65efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek Expr::NPC_ValueDependentIsNull)) 664403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return true; 674403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 684403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 694403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return false; 704403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn} 7160800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 728e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number. 738e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking. Returns true on error. 748e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) { 758e10f3b9cc1db43645bbc2999eb163af8997d468John McCall unsigned argCount = call->getNumArgs(); 768e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount == desiredArgCount) return false; 778e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 788e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount < desiredArgCount) 798e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args) 808e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 818e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getSourceRange(); 828e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 838e10f3b9cc1db43645bbc2999eb163af8997d468John McCall // Highlight all the excess arguments. 848e10f3b9cc1db43645bbc2999eb163af8997d468John McCall SourceRange range(call->getArg(desiredArgCount)->getLocStart(), 858e10f3b9cc1db43645bbc2999eb163af8997d468John McCall call->getArg(argCount - 1)->getLocEnd()); 868e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 878e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args) 888e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 898e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getArg(1)->getSourceRange(); 908e10f3b9cc1db43645bbc2999eb163af8997d468John McCall} 918e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 9277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge/// CheckBuiltinAnnotationString - Checks that string argument to the builtin 9377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge/// annotation is a non wide string literal. 9477f68bb90af93b95045fb994e7cd68137adcc132Julien Lerougestatic bool CheckBuiltinAnnotationString(Sema &S, Expr *Arg) { 9577f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge Arg = Arg->IgnoreParenCasts(); 9677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 9777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge if (!Literal || !Literal->isAscii()) { 9877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge S.Diag(Arg->getLocStart(), diag::err_builtin_annotation_not_string_constant) 9977f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge << Arg->getSourceRange(); 10077f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return true; 10177f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge } 10277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return false; 10377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge} 10477f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge 10560d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 106d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 10760d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult TheCallResult(Owned(TheCall)); 1082def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor 109946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Find out if any arguments are required to be integer constant expressions. 110946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner unsigned ICEArguments = 0; 111946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ASTContext::GetBuiltinTypeError Error; 112946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 113946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (Error != ASTContext::GE_None) 114946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments = 0; // Don't diagnose previously diagnosed errors. 115946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 116946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // If any arguments are required to be ICE's, check and diagnose. 117946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 118946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Skip arguments not required to be ICE's. 119946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if ((ICEArguments & (1 << ArgNo)) == 0) continue; 120946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 121946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner llvm::APSInt Result; 122946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 123946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner return true; 124946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments &= ~(1 << ArgNo); 125946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner } 126946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 127d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson switch (BuiltinID) { 12830ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin___CFStringMakeConstantString: 129925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner assert(TheCall->getNumArgs() == 1 && 1301b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner "Wrong # arguments to builtin CFStringMakeConstantString"); 131690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner if (CheckObjCString(TheCall->getArg(0))) 1320eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 133d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 13449ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek case Builtin::BI__builtin_stdarg_start: 13530ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin_va_start: 1360eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinVAStart(TheCall)) 1370eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 138d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1391b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreater: 1401b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreaterequal: 1411b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isless: 1421b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessequal: 1431b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessgreater: 1441b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isunordered: 1450eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinUnorderedCompare(TheCall)) 1460eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 147d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 148e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer case Builtin::BI__builtin_fpclassify: 149e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer if (SemaBuiltinFPClassification(TheCall, 6)) 150e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer return ExprError(); 151e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer break; 1529ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isfinite: 1539ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf: 1549ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf_sign: 1559ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnan: 1569ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnormal: 1573b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (SemaBuiltinFPClassification(TheCall, 1)) 1589ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return ExprError(); 1599ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman break; 160d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman case Builtin::BI__builtin_shufflevector: 1610eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return SemaBuiltinShuffleVector(TheCall); 1620eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // TheCall will be freed by the smart pointer here, but that's fine, since 1630eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // SemaBuiltinShuffleVector guts it, but then doesn't release it. 1644493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar case Builtin::BI__builtin_prefetch: 1650eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinPrefetch(TheCall)) 1660eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 167d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 168d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar case Builtin::BI__builtin_object_size: 1690eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinObjectSize(TheCall)) 1700eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 171d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 172d875fed28578835de89cd407e9db4be788596d7cEli Friedman case Builtin::BI__builtin_longjmp: 173d875fed28578835de89cd407e9db4be788596d7cEli Friedman if (SemaBuiltinLongjmp(TheCall)) 174d875fed28578835de89cd407e9db4be788596d7cEli Friedman return ExprError(); 175d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1768e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 1778e10f3b9cc1db43645bbc2999eb163af8997d468John McCall case Builtin::BI__builtin_classify_type: 1788e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1798e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 1808e10f3b9cc1db43645bbc2999eb163af8997d468John McCall break; 18175c29a012793292ff4578015a9113bf086156d7fChris Lattner case Builtin::BI__builtin_constant_p: 1828e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1838e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 18475c29a012793292ff4578015a9113bf086156d7fChris Lattner break; 1855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: 1865caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: 1875caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: 1885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: 1895caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: 1905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_add_and_fetch: 1915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_sub_and_fetch: 1925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_and_and_fetch: 1935caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_or_and_fetch: 1945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_xor_and_fetch: 1955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 1965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 1975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_test_and_set: 1985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 19923aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: 200d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return SemaBuiltinAtomicOverloaded(move(TheCallResult)); 201276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_load: 202276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Load); 203276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_store: 204276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Store); 205276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_exchange: 206276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Xchg); 207276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_compare_exchange_strong: 208276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), 209276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman AtomicExpr::CmpXchgStrong); 210276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_compare_exchange_weak: 211276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), 212276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman AtomicExpr::CmpXchgWeak); 213276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_add: 214276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Add); 215276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_sub: 216276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Sub); 217276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_and: 218276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::And); 219276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_or: 220276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Or); 221276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_xor: 222276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Xor); 22377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge case Builtin::BI__builtin_annotation: 22477f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge if (CheckBuiltinAnnotationString(*this, TheCall->getArg(1))) 22577f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return ExprError(); 22677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge break; 22726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 22826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 22926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // Since the target specific builtins for each arch overlap, only check those 23026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // of the arch we are compiling for. 23126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (BuiltinID >= Builtin::FirstTSBuiltin) { 232bcfd1f55bfbb3e5944cd5e03d07b343e280838c4Douglas Gregor switch (Context.getTargetInfo().getTriple().getArch()) { 23326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::arm: 23426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::thumb: 23526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 23626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return ExprError(); 23726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 23826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman default: 23926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 24026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 24126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 24226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 24326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return move(TheCallResult); 24426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman} 24526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 24661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code. 24761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) { 24861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman bool quad = t & 0x10; 24961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 25061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman switch (t & 0x7) { 25161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 0: // i8 252d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 7 : (8 << (int)quad) - 1; 25361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 1: // i16 254d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 15 : (4 << (int)quad) - 1; 25561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 2: // i32 256d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 31 : (2 << (int)quad) - 1; 25761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 3: // i64 258d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 63 : (1 << (int)quad) - 1; 25961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 4: // f32 26061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift float types!"); 261d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (2 << (int)quad) - 1; 26261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 5: // poly8 26342499f94069c73d7a9c82da98a4245ea9fe2c526Bob Wilson return shift ? 7 : (8 << (int)quad) - 1; 26461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 6: // poly16 26542499f94069c73d7a9c82da98a4245ea9fe2c526Bob Wilson return shift ? 15 : (4 << (int)quad) - 1; 26661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 7: // float16 26761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift float types!"); 268d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (4 << (int)quad) - 1; 26961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman } 27061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman return 0; 27161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman} 27261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 27326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 2741c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman llvm::APSInt Result; 2751c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2760d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned mask = 0; 27761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned TV = 0; 2781c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman switch (BuiltinID) { 279a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK 280a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 281a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK 2821c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman } 2831c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2840d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which are overloaded on vector element type, validate 2850d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // the immediate which specifies which variant to emit. 2860d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (mask) { 2870d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned ArgNo = TheCall->getNumArgs()-1; 2880d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 2890d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 2900d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 29161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman TV = Result.getLimitedValue(32); 29261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if ((TV > 31) || (mask & (1 << TV)) == 0) 2930d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 2940d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman << TheCall->getArg(ArgNo)->getSourceRange(); 2950d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman } 2961c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2970d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which take an immediate value as part of the 2980d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // instruction, range check them here. 29961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned i = 0, l = 0, u = 0; 3000d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman switch (BuiltinID) { 3010d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman default: return false; 302bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 303bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 30499c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_f: 30599c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 306a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK 307a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 308a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK 3090d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman }; 3100d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 31161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Check that the immediate argument is actually a constant. 3120d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, i, Result)) 3130d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 3140d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 31561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Range check against the upper/lower values for this isntruction. 3160d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned Val = Result.getZExtValue(); 31761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if (Val < l || Val > (u + l)) 3180d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 319476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer << l << u+l << TheCall->getArg(i)->getSourceRange(); 3200d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 32199c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman // FIXME: VFP Intrinsics should error if VFP not present. 32226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return false; 323d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson} 324d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 325d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// CheckFunctionCall - Check a direct function call for various correctness 326d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// and safety properties not strictly enforced by the C type system. 327d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) { 328d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // Get the IdentifierInfo* for the called function. 329d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson IdentifierInfo *FnInfo = FDecl->getIdentifier(); 330de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 331d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // None of the checks below are needed for functions that don't have 332d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // simple names (e.g., C++ conversion functions). 333d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson if (!FnInfo) 334d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 336de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // FIXME: This mechanism should be abstracted to be less fragile and 337de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // more efficient. For example, just map function ids to custom 338de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // handlers. 339de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 340c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek // Printf and scanf checking. 341c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<FormatAttr> 342c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<FormatAttr>(), 343c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<FormatAttr>(); i != e ; ++i) { 344c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek 345c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek const FormatAttr *Format = *i; 346826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 347826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (b || CheckablePrintfAttr(Format, TheCall)) { 3483d692df4b9c58895f9843b03543ec57447c93679Ted Kremenek bool HasVAListArg = Format->getFirstArg() == 0; 349826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, 350826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Format->getFormatIdx() - 1, 351826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, 352826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek !b); 3533c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor } 35459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner } 3551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 356c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<NonNullAttr> 357c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<NonNullAttr>(), 358c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<NonNullAttr>(); i != e; ++i) { 359909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky CheckNonNullArguments(*i, TheCall->getArgs(), 360909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky TheCall->getCallee()->getLocStart()); 361c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek } 3620eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 363bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Builtin handling 364707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor int CMF = -1; 365707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor switch (FDecl->getBuiltinID()) { 366707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin_memset: 367707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin___memset_chk: 368707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BImemset: 369707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memset; 370707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor break; 371707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor 372707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin_memcpy: 373707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin___memcpy_chk: 374707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BImemcpy: 375707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memcpy; 376707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor break; 377707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor 378707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin_memmove: 379707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin___memmove_chk: 380707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BImemmove: 381707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memmove; 382707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor break; 383bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 384bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek case Builtin::BIstrlcpy: 385bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek case Builtin::BIstrlcat: 386bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CheckStrlcpycatArguments(TheCall, FnInfo); 387bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 388707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor 389cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay case Builtin::BI__builtin_memcmp: 390cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay CMF = CMF_Memcmp; 391cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay break; 392cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay 393cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber case Builtin::BI__builtin_strncpy: 394cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber case Builtin::BI__builtin___strncpy_chk: 395cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber case Builtin::BIstrncpy: 396cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strncpy; 397cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber break; 398cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber 399cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber case Builtin::BI__builtin_strncmp: 400cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strncmp; 401cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber break; 402cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber 403cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber case Builtin::BI__builtin_strncasecmp: 404cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strncasecmp; 405cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber break; 406cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber 407cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber case Builtin::BI__builtin_strncat: 408cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber case Builtin::BIstrncat: 409cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strncat; 410cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber break; 411cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber 412cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber case Builtin::BI__builtin_strndup: 413cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber case Builtin::BIstrndup: 414cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strndup; 415cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber break; 416cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber 417707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor default: 418707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor if (FDecl->getLinkage() == ExternalLinkage && 419707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor (!getLangOptions().CPlusPlus || FDecl->isExternC())) { 420707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor if (FnInfo->isStr("memset")) 421707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memset; 422707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor else if (FnInfo->isStr("memcpy")) 423707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memcpy; 424707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor else if (FnInfo->isStr("memmove")) 425707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memmove; 426cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay else if (FnInfo->isStr("memcmp")) 427cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay CMF = CMF_Memcmp; 428cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber else if (FnInfo->isStr("strncpy")) 429cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strncpy; 430cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber else if (FnInfo->isStr("strncmp")) 431cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strncmp; 432cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber else if (FnInfo->isStr("strncasecmp")) 433cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strncasecmp; 434cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber else if (FnInfo->isStr("strncat")) 435cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strncat; 436cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber else if (FnInfo->isStr("strndup")) 437cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strndup; 438707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor } 439707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor break; 44006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 441707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor 442bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Memset/memcpy/memmove handling 443707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor if (CMF != -1) 444cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay CheckMemaccessArguments(TheCall, CheckedMemoryFunction(CMF), FnInfo); 4457ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 446d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 44771993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson} 44871993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 449d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) { 450725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian // Printf checking. 45140b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis const FormatAttr *Format = NDecl->getAttr<FormatAttr>(); 452725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Format) 453d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 4541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 455725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian const VarDecl *V = dyn_cast<VarDecl>(NDecl); 456725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!V) 457d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 4581eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 459725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian QualType Ty = V->getType(); 460725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Ty->isBlockPointerType()) 461d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 4621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 463826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 464826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!b && !CheckablePrintfAttr(Format, TheCall)) 465d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 4661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 467d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson bool HasVAListArg = Format->getFirstArg() == 0; 468826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1, 469826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, !b); 470d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 471d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 472725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian} 473725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian 474276b061970939293f1abaf694bd3ef05b2cbda79Eli FriedmanExprResult 475276b061970939293f1abaf694bd3ef05b2cbda79Eli FriedmanSema::SemaAtomicOpsOverloaded(ExprResult TheCallResult, AtomicExpr::AtomicOp Op) { 476276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman CallExpr *TheCall = cast<CallExpr>(TheCallResult.get()); 477276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 478276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 479276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // All these operations take one of the following four forms: 480276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // T __atomic_load(_Atomic(T)*, int) (loads) 481276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // T* __atomic_add(_Atomic(T*)*, ptrdiff_t, int) (pointer add/sub) 482276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // int __atomic_compare_exchange_strong(_Atomic(T)*, T*, T, int, int) 483276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // (cmpxchg) 484276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // T __atomic_exchange(_Atomic(T)*, T, int) (everything else) 485276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // where T is an appropriate type, and the int paremeterss are for orderings. 486276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman unsigned NumVals = 1; 487276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman unsigned NumOrders = 1; 488276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Op == AtomicExpr::Load) { 489276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman NumVals = 0; 490276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else if (Op == AtomicExpr::CmpXchgWeak || Op == AtomicExpr::CmpXchgStrong) { 491276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman NumVals = 2; 492276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman NumOrders = 2; 493276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 494276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 495276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (TheCall->getNumArgs() < NumVals+NumOrders+1) { 496276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 497276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << 0 << NumVals+NumOrders+1 << TheCall->getNumArgs() 498276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 499276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 500276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else if (TheCall->getNumArgs() > NumVals+NumOrders+1) { 501276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(TheCall->getArg(NumVals+NumOrders+1)->getLocStart(), 502276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman diag::err_typecheck_call_too_many_args) 503276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << 0 << NumVals+NumOrders+1 << TheCall->getNumArgs() 504276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 505276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 506276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 507276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 508276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // Inspect the first argument of the atomic operation. This should always be 509276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // a pointer to an _Atomic type. 510dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman Expr *Ptr = TheCall->getArg(0); 511276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get(); 512276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman const PointerType *pointerType = Ptr->getType()->getAs<PointerType>(); 513276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!pointerType) { 514276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic) 515276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 516276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 517276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 518276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 519276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType AtomTy = pointerType->getPointeeType(); 520276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!AtomTy->isAtomicType()) { 521276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic) 522276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 523276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 524276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 525276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType ValType = AtomTy->getAs<AtomicType>()->getValueType(); 526276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 527276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if ((Op == AtomicExpr::Add || Op == AtomicExpr::Sub) && 528276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman !ValType->isIntegerType() && !ValType->isPointerType()) { 529276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 530276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 531276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 532276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 533276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 534276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!ValType->isIntegerType() && 535276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman (Op == AtomicExpr::And || Op == AtomicExpr::Or || Op == AtomicExpr::Xor)){ 536276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_logical_needs_atomic_int) 537276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 538276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 539276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 540276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 541276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman switch (ValType.getObjCLifetime()) { 542276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_None: 543276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_ExplicitNone: 544276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // okay 545276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman break; 546276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 547276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Weak: 548276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Strong: 549276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Autoreleasing: 550276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 551276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << ValType << Ptr->getSourceRange(); 552276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 553276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 554276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 555276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType ResultType = ValType; 556276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Op == AtomicExpr::Store) 557276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.VoidTy; 558276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman else if (Op == AtomicExpr::CmpXchgWeak || Op == AtomicExpr::CmpXchgStrong) 559276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.BoolTy; 560276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 561276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The first argument --- the pointer --- has a fixed type; we 562276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // deduce the types of the rest of the arguments accordingly. Walk 563276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // the remaining arguments, converting them to the deduced value type. 564276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman for (unsigned i = 1; i != NumVals+NumOrders+1; ++i) { 565276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ExprResult Arg = TheCall->getArg(i); 566276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType Ty; 567276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (i < NumVals+1) { 568276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The second argument to a cmpxchg is a pointer to the data which will 569276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // be exchanged. The second argument to a pointer add/subtract is the 570276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // amount to add/subtract, which must be a ptrdiff_t. The third 571276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // argument to a cmpxchg and the second argument in all other cases 572276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // is the type of the value. 573276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (i == 1 && (Op == AtomicExpr::CmpXchgWeak || 574276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Op == AtomicExpr::CmpXchgStrong)) 575276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.getPointerType(ValType.getUnqualifiedType()); 576276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman else if (!ValType->isIntegerType() && 577276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman (Op == AtomicExpr::Add || Op == AtomicExpr::Sub)) 578276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.getPointerDiffType(); 579276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman else 580276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = ValType; 581276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else { 582276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The order(s) are always converted to int. 583276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.IntTy; 584276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 585276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity Entity = 586276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity::InitializeParameter(Context, Ty, false); 587276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 588276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Arg.isInvalid()) 589276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return true; 590276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman TheCall->setArg(i, Arg.get()); 591276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 592276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 593dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SmallVector<Expr*, 5> SubExprs; 594dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(Ptr); 595276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Op == AtomicExpr::Load) { 596dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Order 597276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else if (Op != AtomicExpr::CmpXchgWeak && Op != AtomicExpr::CmpXchgStrong) { 598dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(2)); // Order 599dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 600276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else { 601dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(3)); // Order 602dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 603dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(2)); // Val2 604dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(4)); // OrderFail 605276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 606dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman 607dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman return Owned(new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(), 608dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.data(), SubExprs.size(), 609dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman ResultType, Op, 610dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman TheCall->getRParenLoc())); 611276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman} 612276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 613276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 6145f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// checkBuiltinArgument - Given a call to a builtin function, perform 6155f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// normal type-checking on the given argument, updating the call in 6165f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// place. This is useful when a builtin function requires custom 6175f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// type-checking for some of its arguments but not necessarily all of 6185f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// them. 6195f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// 6205f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// Returns true on error. 6215f8d604246976a93a73549b07bbc8ee0b2061b50John McCallstatic bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) { 6225f8d604246976a93a73549b07bbc8ee0b2061b50John McCall FunctionDecl *Fn = E->getDirectCallee(); 6235f8d604246976a93a73549b07bbc8ee0b2061b50John McCall assert(Fn && "builtin call without direct callee!"); 6245f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 6255f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ParmVarDecl *Param = Fn->getParamDecl(ArgIndex); 6265f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity Entity = 6275f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity::InitializeParameter(S.Context, Param); 6285f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 6295f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ExprResult Arg = E->getArg(0); 6305f8d604246976a93a73549b07bbc8ee0b2061b50John McCall Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg); 6315f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (Arg.isInvalid()) 6325f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 6335f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 6345f8d604246976a93a73549b07bbc8ee0b2061b50John McCall E->setArg(ArgIndex, Arg.take()); 6355f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return false; 6365f8d604246976a93a73549b07bbc8ee0b2061b50John McCall} 6375f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 6385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like 6395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer 6405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument. The main ActOnCallExpr routines have already 6415caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as 6425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...). 6435caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// 6445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these 6455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins, 64660d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 64760d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 648d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 6495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 6505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 6515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 6525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Ensure that we have at least one argument to do type inference from. 653d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1) { 654d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 655d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1 << TheCall->getNumArgs() 656d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 657d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 658d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 6591eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 6605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Inspect the first argument of the atomic builtin. This should always be 6615caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // a pointer type, whose element is an integral scalar or pointer type. 6625caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Because it is a pointer type, we don't have to worry about any implicit 6635caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // casts here. 664d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth // FIXME: We don't allow floating point scalars as input. 6655caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *FirstArg = TheCall->getArg(0); 666f85e193739c953358c865005855253af4f68a497John McCall const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>(); 667f85e193739c953358c865005855253af4f68a497John McCall if (!pointerType) { 668d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 669d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 670d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 671d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 6721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 673f85e193739c953358c865005855253af4f68a497John McCall QualType ValType = pointerType->getPointeeType(); 674dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 675d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth !ValType->isBlockPointerType()) { 676d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 677d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 678d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 679d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 6805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 681f85e193739c953358c865005855253af4f68a497John McCall switch (ValType.getObjCLifetime()) { 682f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 683f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 684f85e193739c953358c865005855253af4f68a497John McCall // okay 685f85e193739c953358c865005855253af4f68a497John McCall break; 686f85e193739c953358c865005855253af4f68a497John McCall 687f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 688f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 689f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 690b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 691f85e193739c953358c865005855253af4f68a497John McCall << ValType << FirstArg->getSourceRange(); 692f85e193739c953358c865005855253af4f68a497John McCall return ExprError(); 693f85e193739c953358c865005855253af4f68a497John McCall } 694f85e193739c953358c865005855253af4f68a497John McCall 695b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Strip any qualifiers off ValType. 696b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType = ValType.getUnqualifiedType(); 697b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall 6988d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // The majority of builtins return a value, but a few have special return 6998d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // types, so allow them to override appropriately below. 7008d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth QualType ResultType = ValType; 7018d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth 7025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // We need to figure out which concrete builtin this maps onto. For example, 7035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add with a 2 byte object turns into 7045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add_2. 7055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \ 7065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 7075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Builtin::BI##x##_8, Builtin::BI##x##_16 } 7081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner static const unsigned BuiltinIndices[][5] = { 7105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_add), 7115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_sub), 7125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_or), 7135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_and), 7145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_xor), 7151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_add_and_fetch), 7175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_sub_and_fetch), 7185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_and_and_fetch), 7195caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_or_and_fetch), 7205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_xor_and_fetch), 7211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_val_compare_and_swap), 7235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_bool_compare_and_swap), 7245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_test_and_set), 72523aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_lock_release), 72623aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_swap) 7275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner }; 7281eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW 7291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Determine the index of the size. 7315caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned SizeIndex; 732199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 7335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 1: SizeIndex = 0; break; 7345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 2: SizeIndex = 1; break; 7355caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 4: SizeIndex = 2; break; 7365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 8: SizeIndex = 3; break; 7375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 16: SizeIndex = 4; break; 7385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: 739d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 740d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 741d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 7425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 7431eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Each of these builtins has one pointer argument, followed by some number of 7455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // values (0, 1 or 2) followed by a potentially empty varags list of stuff 7465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // that we ignore. Find out which row of BuiltinIndices to read from as well 7475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // as the number of fixed args. 7487814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor unsigned BuiltinID = FDecl->getBuiltinID(); 7495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned BuiltinIndex, NumFixed = 1; 7505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner switch (BuiltinID) { 751b219cfc4d75f0a03630b7c4509ef791b7e97b2c8David Blaikie default: llvm_unreachable("Unknown overloaded atomic builtin!"); 7525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break; 7535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break; 7545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break; 7555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break; 7565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break; 7571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7587eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break; 7597eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break; 7607eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break; 7617eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break; 7627eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break; 7631eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7645caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 7657eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 10; 7665caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 7675caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 7685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 7697eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 11; 7705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 7718d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.BoolTy; 7725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 7737eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break; 7745caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 7757eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 13; 7765caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 0; 7778d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.VoidTy; 7785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 77923aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: BuiltinIndex = 14; break; 7805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 7811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Now that we know how many fixed arguments we expect, first check that we 7835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // have at least that many. 784d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1+NumFixed) { 785d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 786d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1+NumFixed << TheCall->getNumArgs() 787d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 788d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 789d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 7901eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 791e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // Get the decl for the concrete builtin from this, we can tell what the 792e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // concrete integer type we should convert to is. 793e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 794e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 795e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName); 7961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump FunctionDecl *NewBuiltinDecl = 797e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID, 798e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner TUScope, false, DRE->getLocStart())); 799d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 800f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // The first argument --- the pointer --- has a fixed type; we 801f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // deduce the types of the rest of the arguments accordingly. Walk 802f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // the remaining arguments, converting them to the deduced value type. 8035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner for (unsigned i = 0; i != NumFixed; ++i) { 804429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult Arg = TheCall->getArg(i+1); 8051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // If the argument is an implicit cast, then there was a promotion due to 8075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // "...", just remove it now. 808429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg.get())) { 8095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Arg = ICE->getSubExpr(); 8105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner ICE->setSubExpr(0); 811429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(i+1, Arg.get()); 8125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 8131eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // GCC does an implicit conversion to the pointer or integer ValType. This 8155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // can fail in some cases (1i -> int**), check for this error case now. 816b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Initialize the argument. 817b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall InitializedEntity Entity = InitializedEntity::InitializeParameter(Context, 818b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType, /*consume*/ false); 819b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 820429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (Arg.isInvalid()) 821d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 8221eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Okay, we have something that *can* be converted to the right type. Check 8245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // to see if there is a potentially weird extension going on here. This can 8255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // happen when you do an atomic operation on something like an char* and 8265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // pass in 42. The 42 gets converted to char. This is even more strange 8275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // for things like 45.123 -> char, etc. 8281eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // FIXME: Do this check. 829b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall TheCall->setArg(i+1, Arg.take()); 8305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 8311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 832bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor ASTContext& Context = this->getASTContext(); 833bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor 834bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor // Create a new DeclRefExpr to refer to the new decl. 835bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DeclRefExpr* NewDRE = DeclRefExpr::Create( 836bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor Context, 837bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getQualifierLoc(), 838bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor NewBuiltinDecl, 839bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getLocation(), 840bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor NewBuiltinDecl->getType(), 841bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getValueKind()); 8421eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8435caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Set the callee in the CallExpr. 8445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // FIXME: This leaks the original parens and implicit casts. 845bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor ExprResult PromotedCall = UsualUnaryConversions(NewDRE); 846429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (PromotedCall.isInvalid()) 847429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return ExprError(); 848429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setCallee(PromotedCall.take()); 8491eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 850db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // Change the result type of the call to match the original value type. This 851db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // is arbitrary, but the codegen for these builtins ins design to handle it 852db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // gracefully. 8538d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth TheCall->setType(ResultType); 854d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 855d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return move(TheCallResult); 8565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner} 8575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 858690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin 85971993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct 860fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would 861fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend). 862690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) { 86356f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner Arg = Arg->IgnoreParenCasts(); 86471993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 86571993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 8665cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!Literal || !Literal->isAscii()) { 867fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 868fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << Arg->getSourceRange(); 8699cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return true; 87071993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson } 8711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8727da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Literal->containsNonAsciiOrNull()) { 8735f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef String = Literal->getString(); 8747da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian unsigned NumBytes = String.size(); 8755f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<UTF16, 128> ToBuf(NumBytes); 8767da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian const UTF8 *FromPtr = (UTF8 *)String.data(); 8777da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian UTF16 *ToPtr = &ToBuf[0]; 8787da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 8797da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 8807da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian &ToPtr, ToPtr + NumBytes, 8817da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian strictConversion); 8827da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian // Check for conversion failure. 8837da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Result != conversionOK) 8847da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian Diag(Arg->getLocStart(), 8857da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian diag::warn_cfstring_truncated) << Arg->getSourceRange(); 8867da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian } 8879cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return false; 88859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner} 88959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 890c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 891c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success. 892925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 893925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *Fn = TheCall->getCallee(); 894925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) { 8952c21a073525cdfa68e4439b7af551385dc2796abChris Lattner Diag(TheCall->getArg(2)->getLocStart(), 896fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 897ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 898ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << Fn->getSourceRange() 8991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(2)->getLocStart(), 900fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 90130ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 90230ce344307f8a8b00054021307015571f83c7364Chris Lattner } 90356f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 90456f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman if (TheCall->getNumArgs() < 2) { 905d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher return Diag(TheCall->getLocEnd(), 906d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 907d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 90856f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman } 90956f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 9105f8d604246976a93a73549b07bbc8ee0b2061b50John McCall // Type-check the first argument normally. 9115f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (checkBuiltinArgument(*this, TheCall, 0)) 9125f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 9135f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 914c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner // Determine whether the current function is variadic or not. 9159ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor BlockScopeInfo *CurBlock = getCurBlock(); 916c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner bool isVariadic; 917cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 918c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall isVariadic = CurBlock->TheDecl->isVariadic(); 9199498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else if (FunctionDecl *FD = getCurFunctionDecl()) 9209498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek isVariadic = FD->isVariadic(); 9219498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else 92253d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis isVariadic = getCurMethodDecl()->isVariadic(); 9231eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 924c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner if (!isVariadic) { 92530ce344307f8a8b00054021307015571f83c7364Chris Lattner Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 92630ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 92730ce344307f8a8b00054021307015571f83c7364Chris Lattner } 9281eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 92930ce344307f8a8b00054021307015571f83c7364Chris Lattner // Verify that the second argument to the builtin is the last argument of the 93030ce344307f8a8b00054021307015571f83c7364Chris Lattner // current function or method. 93130ce344307f8a8b00054021307015571f83c7364Chris Lattner bool SecondArgIsLastNamedArgument = false; 932e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 9331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 93488cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 93588cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 93630ce344307f8a8b00054021307015571f83c7364Chris Lattner // FIXME: This isn't correct for methods (results in bogus warning). 93730ce344307f8a8b00054021307015571f83c7364Chris Lattner // Get the last formal in the current function. 93888cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson const ParmVarDecl *LastArg; 939cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 940cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff LastArg = *(CurBlock->TheDecl->param_end()-1); 941cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff else if (FunctionDecl *FD = getCurFunctionDecl()) 942371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner LastArg = *(FD->param_end()-1); 94330ce344307f8a8b00054021307015571f83c7364Chris Lattner else 94453d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis LastArg = *(getCurMethodDecl()->param_end()-1); 94530ce344307f8a8b00054021307015571f83c7364Chris Lattner SecondArgIsLastNamedArgument = PV == LastArg; 94630ce344307f8a8b00054021307015571f83c7364Chris Lattner } 94730ce344307f8a8b00054021307015571f83c7364Chris Lattner } 9481eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 94930ce344307f8a8b00054021307015571f83c7364Chris Lattner if (!SecondArgIsLastNamedArgument) 9501eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(1)->getLocStart(), 95130ce344307f8a8b00054021307015571f83c7364Chris Lattner diag::warn_second_parameter_of_va_start_not_last_named_argument); 95230ce344307f8a8b00054021307015571f83c7364Chris Lattner return false; 9536cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman} 95430ce344307f8a8b00054021307015571f83c7364Chris Lattner 9551b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 9561b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends. This is declared to take (...), so we have to check everything. 957925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 958925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() < 2) 9592c21a073525cdfa68e4439b7af551385dc2796abChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 960d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << 2 << TheCall->getNumArgs()/*function call*/; 961925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) 9621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(TheCall->getArg(2)->getLocStart(), 963fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 964ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 965fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(TheCall->getArg(2)->getLocStart(), 966fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 9671eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 968429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg0 = TheCall->getArg(0); 969429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg1 = TheCall->getArg(1); 970cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 9711b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // Do standard promotions between the two arguments, returning their common 9721b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // type. 973925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 974429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.isInvalid() || OrigArg1.isInvalid()) 975429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return true; 976403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar 977403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // Make sure any conversions are pushed back into the call; this is 978403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // type safe since unordered compare builtins are declared as "_Bool 979403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // foo(...)". 980429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(0, OrigArg0.get()); 981429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(1, OrigArg1.get()); 9821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 983429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent()) 984cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 985cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 9861b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // If the common type isn't a real floating type, then the arguments were 9871b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // invalid for this operation. 9881b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner if (!Res->isRealFloatingType()) 989429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return Diag(OrigArg0.get()->getLocStart(), 990fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_invalid_ordered_compare) 991429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << OrigArg0.get()->getType() << OrigArg1.get()->getType() 992429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd()); 9931eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9941b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner return false; 9951b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner} 9961b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner 997e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 998e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends. This is declared to take (...), so we have 9993b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point 10003b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value. 10013b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 10023b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() < NumArgs) 10039ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1004d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 10053b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() > NumArgs) 10063b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer return Diag(TheCall->getArg(NumArgs)->getLocStart(), 10079ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_too_many_args) 1008ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 10093b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 10109ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman (*(TheCall->arg_end()-1))->getLocEnd()); 10119ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 10123b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer Expr *OrigArg = TheCall->getArg(NumArgs-1); 10131eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10149ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (OrigArg->isTypeDependent()) 10159ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 10169ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 101781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // This operation requires a non-_Complex floating-point number. 10189ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (!OrigArg->getType()->isRealFloatingType()) 10191eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg->getLocStart(), 10209ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_invalid_unary_fp) 10219ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman << OrigArg->getType() << OrigArg->getSourceRange(); 10221eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 102381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // If this is an implicit conversion from float -> double, remove it. 102481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 102581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Expr *CastArg = Cast->getSubExpr(); 102681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 102781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 102881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner "promotion from float to double is the only expected cast here"); 102981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Cast->setSubExpr(0); 103081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner TheCall->setArg(NumArgs-1, CastArg); 103181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner OrigArg = CastArg; 103281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 103381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 103481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner 10359ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 10369ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman} 10379ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 1038d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 1039d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything. 104060d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 104137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() < 2) 10420eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocEnd(), 1043d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 104437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1045d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << TheCall->getSourceRange()); 1046d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 104737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Determine which of the following types of shufflevector we're checking: 104837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 1) unary, vector mask: (lhs, mask) 104937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 2) binary, vector mask: (lhs, rhs, mask) 105037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 105137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType resType = TheCall->getArg(0)->getType(); 105237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numElements = 0; 105337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 1054cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (!TheCall->getArg(0)->isTypeDependent() && 1055cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor !TheCall->getArg(1)->isTypeDependent()) { 105637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType LHSType = TheCall->getArg(0)->getType(); 105737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType RHSType = TheCall->getArg(1)->getType(); 105837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 105937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!LHSType->isVectorType() || !RHSType->isVectorType()) { 1060cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) 10611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1062cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1063cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 1064cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 106537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 106637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numElements = LHSType->getAs<VectorType>()->getNumElements(); 106737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numResElements = TheCall->getNumArgs() - 2; 106837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 106937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Check to see if we have a call with 2 vector arguments, the unary shuffle 107037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // with mask. If so, verify that RHS is an integer vector type with the 107137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // same number of elts as lhs. 107237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() == 2) { 1073f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (!RHSType->hasIntegerRepresentation() || 107437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman RHSType->getAs<VectorType>()->getNumElements() != numElements) 107537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 107637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << SourceRange(TheCall->getArg(1)->getLocStart(), 107737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman TheCall->getArg(1)->getLocEnd()); 107837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numResElements = numElements; 107937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } 108037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 1081cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 10821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1083cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1084cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 108537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } else if (numElements != numResElements) { 108637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 1087788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner resType = Context.getVectorType(eltType, numResElements, 1088e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson VectorType::GenericVector); 1089cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 1090d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1091d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1092d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 1093cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 1094cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(i)->isValueDependent()) 1095cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor continue; 1096cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 109737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman llvm::APSInt Result(32); 109837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 109937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman return ExprError(Diag(TheCall->getLocStart(), 110037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman diag::err_shufflevector_nonconstant_argument) 110137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << TheCall->getArg(i)->getSourceRange()); 11020eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 1103d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 11040eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocStart(), 1105fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_shufflevector_argument_too_large) 11060eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl << TheCall->getArg(i)->getSourceRange()); 1107d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1108d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 11095f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<Expr*, 32> exprs; 1110d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1111d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 1112d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman exprs.push_back(TheCall->getArg(i)); 1113d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman TheCall->setArg(i, 0); 1114d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1115d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1116a88dc3079bedf70a5cfc39791727e43a10383006Nate Begeman return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(), 111737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman exprs.size(), resType, 11188189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getCallee()->getLocStart(), 11198189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getRParenLoc())); 1120d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman} 112130ce344307f8a8b00054021307015571f83c7364Chris Lattner 11224493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 11234493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two 11244493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args. 11254493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 1126fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner unsigned NumArgs = TheCall->getNumArgs(); 11274493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1128fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (NumArgs > 3) 1129ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher return Diag(TheCall->getLocEnd(), 1130ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher diag::err_typecheck_call_too_many_args_at_most) 1131ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 3 << NumArgs 1132ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << TheCall->getSourceRange(); 11334493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 11344493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // Argument 0 is checked for us and the remaining arguments must be 11354493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // constant integers. 1136fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner for (unsigned i = 1; i != NumArgs; ++i) { 11374493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar Expr *Arg = TheCall->getArg(i); 1138691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 11399aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman llvm::APSInt Result; 1140691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, i, Result)) 1141691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 11421eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11434493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // FIXME: gcc issues a warning and rewrites these to 0. These 11444493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // seems especially odd for the third argument since the default 11454493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // is 3. 1146fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (i == 1) { 11479aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 1) 1148fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 114921fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "1" << Arg->getSourceRange(); 11504493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } else { 11519aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 3) 1152fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 115321fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "3" << Arg->getSourceRange(); 11544493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 11554493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 11564493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1157fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return false; 11584493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar} 11594493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1160691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 1161691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression. 1162691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 1163691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt &Result) { 1164691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(ArgNum); 1165691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 1166691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 1167691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1168691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 1169691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1170691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (!Arg->isIntegerConstantExpr(Result, Context)) 1171691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 11725e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher << FDecl->getDeclName() << Arg->getSourceRange(); 1173691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 117421fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner return false; 117521fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner} 117621fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner 1177d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 1178d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined 1179d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3). 1180fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner// For compatibility check 0-3, llvm only handles 0 and 2. 1181d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 1182691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1183691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1184691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // Check constant-ness first. 1185691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1186691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1187d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1188691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(1); 1189d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 1190fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 1191fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1192d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar } 1193d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1194d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar return false; 1195d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar} 1196d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1197586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 1198d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1. 1199d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 1200d875fed28578835de89cd407e9db4be788596d7cEli Friedman Expr *Arg = TheCall->getArg(1); 1201691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1202cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 1203691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // TODO: This is less than ideal. Overload this to take a value. 1204691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1205691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1206691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1207691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Result != 1) 1208d875fed28578835de89cd407e9db4be788596d7cEli Friedman return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 1209d875fed28578835de89cd407e9db4be788596d7cEli Friedman << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1210d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1211d875fed28578835de89cd407e9db4be788596d7cEli Friedman return false; 1212d875fed28578835de89cd407e9db4be788596d7cEli Friedman} 1213d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1214b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek// Handle i > 1 ? "x" : "y", recursively. 1215082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenekbool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall, 1216082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool HasVAListArg, 1217826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1218826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 12194fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain: 1220cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 1221cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 1222d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1223f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 1224f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 1225d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek switch (E->getStmtClass()) { 122656ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::BinaryConditionalOperatorClass: 1227d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ConditionalOperatorClass: { 122856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall const AbstractConditionalOperator *C = cast<AbstractConditionalOperator>(E); 1229826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return SemaCheckStringLiteral(C->getTrueExpr(), TheCall, HasVAListArg, 1230826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf) 123156ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall && SemaCheckStringLiteral(C->getFalseExpr(), TheCall, HasVAListArg, 1232826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf); 1233d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1234d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 123595355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek case Stmt::IntegerLiteralClass: 123695355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // Technically -Wformat-nonliteral does not warn about this case. 123795355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // The behavior of printf and friends in this case is implementation 123895355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // dependent. Ideally if the format string cannot be null then 123995355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // it should have a 'nonnull' attribute in the function prototype. 124095355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek return true; 124195355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek 1242d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ImplicitCastExprClass: { 12434fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ImplicitCastExpr>(E)->getSubExpr(); 12444fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 1245d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1246d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 124756ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::OpaqueValueExprClass: 124856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) { 124956ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall E = src; 125056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall goto tryAgain; 125156ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall } 125256ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall return false; 125356ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall 1254b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek case Stmt::PredefinedExprClass: 1255b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // While __func__, etc., are technically not string literals, they 1256b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // cannot contain format specifiers and thus are not a security 1257b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // liability. 1258b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek return true; 1259b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek 1260082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::DeclRefExprClass: { 1261082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const DeclRefExpr *DR = cast<DeclRefExpr>(E); 12621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1263082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // As an exception, do not flag errors for variables binding to 1264082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // const string literals. 1265082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 1266082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool isConstant = false; 1267082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek QualType T = DR->getType(); 1268082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek 1269082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ArrayType *AT = Context.getAsArrayType(T)) { 1270082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek isConstant = AT->getElementType().isConstant(Context); 1271ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (const PointerType *PT = T->getAs<PointerType>()) { 12721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump isConstant = T.isConstant(Context) && 1273082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek PT->getPointeeType().isConstant(Context); 1274082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 12751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1276082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (isConstant) { 127731310a21fb2a9f13950f864f681c86080b05d5b2Sebastian Redl if (const Expr *Init = VD->getAnyInitializer()) 1278082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return SemaCheckStringLiteral(Init, TheCall, 1279826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, format_idx, firstDataArg, 1280826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isPrintf); 1281082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 12821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1283d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // For vprintf* functions (i.e., HasVAListArg==true), we add a 1284d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // special check to see if the format string is a function parameter 1285d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // of the function calling the printf function. If the function 1286d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // has an attribute indicating it is a printf-like function, then we 1287d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // should suppress warnings concerning non-literals being used in a call 1288d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // to a vprintf function. For example: 1289d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1290d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // void 1291d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 1292d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_list ap; 1293d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_start(ap, fmt); 1294d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 1295d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // ... 1296d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1297d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1298d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // FIXME: We don't have full attribute support yet, so just check to see 1299d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // if the argument is a DeclRefExpr that references a parameter. We'll 1300d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // add proper support for checking the attribute later. 1301d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (HasVAListArg) 1302d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (isa<ParmVarDecl>(VD)) 1303d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson return true; 1304082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 13051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1306082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1307082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 1308d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 13098f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson case Stmt::CallExprClass: { 13108f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const CallExpr *CE = cast<CallExpr>(E); 13111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump if (const ImplicitCastExpr *ICE 13128f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson = dyn_cast<ImplicitCastExpr>(CE->getCallee())) { 13138f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) { 13148f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) { 131540b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) { 13168f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson unsigned ArgIndex = FA->getFormatIdx(); 13178f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const Expr *Arg = CE->getArg(ArgIndex - 1); 13181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 13191eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg, 1320826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf); 13218f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 13228f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 13238f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 13248f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 13251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 13268f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson return false; 13278f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 1328082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::ObjCStringLiteralClass: 1329082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::StringLiteralClass: { 1330082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const StringLiteral *StrE = NULL; 13311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1332082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 1333d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek StrE = ObjCFExpr->getString(); 1334d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek else 1335082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek StrE = cast<StringLiteral>(E); 13361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1337d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek if (StrE) { 1338826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatString(StrE, E, TheCall, HasVAListArg, format_idx, 1339826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek firstDataArg, isPrintf); 1340d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return true; 1341d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 13421eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1343d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return false; 1344d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 13451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1346082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek default: 1347082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1348d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1349d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1350d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1351e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid 13521eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull, 1353909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr * const *ExprArgs, 1354909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky SourceLocation CallSiteLoc) { 1355cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt for (NonNullAttr::args_iterator i = NonNull->args_begin(), 1356cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt e = NonNull->args_end(); 1357e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian i != e; ++i) { 1358909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr *ArgExpr = ExprArgs[*i]; 13594e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (ArgExpr->isNullPointerConstant(Context, 1360ce94049b69f75b44c18584fe79cd238978b6b0d5Douglas Gregor Expr::NPC_ValueDependentIsNotNull)) 1361909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange(); 1362e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian } 1363e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian} 1364d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1365826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar 1366826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings. 136759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnervoid 1368826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSema::CheckPrintfScanfArguments(const CallExpr *TheCall, bool HasVAListArg, 1369826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1370826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 1371826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1372082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *Fn = TheCall->getCallee(); 1373925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner 13744a2614e94672c47395abcde60518776fbebec589Sebastian Redl // The way the format attribute works in GCC, the implicit this argument 13754a2614e94672c47395abcde60518776fbebec589Sebastian Redl // of member functions is counted. However, it doesn't appear in our own 13764a2614e94672c47395abcde60518776fbebec589Sebastian Redl // lists, so decrement format_idx in that case. 13774a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 13789263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth const CXXMethodDecl *method_decl = 13799263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth dyn_cast<CXXMethodDecl>(TheCall->getCalleeDecl()); 13809263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if (method_decl && method_decl->isInstance()) { 13819263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth // Catch a format attribute mistakenly referring to the object argument. 13829263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if (format_idx == 0) 13839263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth return; 13849263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth --format_idx; 13859263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if(firstDataArg != 0) 13869263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth --firstDataArg; 13879263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth } 13884a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 13894a2614e94672c47395abcde60518776fbebec589Sebastian Redl 1390826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // CHECK: printf/scanf-like function is called with no format string. 1391925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (format_idx >= TheCall->getNumArgs()) { 1392826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Diag(TheCall->getRParenLoc(), diag::warn_missing_format_string) 1393dcd5ef12488e4c7ea844327835896ca86b609a97Chris Lattner << Fn->getSourceRange(); 139471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek return; 139571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek } 13961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1397082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts(); 13981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 139959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner // CHECK: format string is not a string literal. 14001eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // 140171895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // Dynamically generated format strings are difficult to 140271895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // automatically vet at compile time. Requiring that format strings 140371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // are string literals: (1) permits the checking of format strings by 140471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // the compiler and thereby (2) can practically remove the source of 140571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // many format string exploits. 14067ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek 14071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // Format string can be either ObjC string (e.g. @"%d") or 14087ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // C string (e.g. "%d") 14091eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // ObjC string uses the same format specifiers as C string, so we can use 14107ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // the same format string checking logic for both ObjC and C strings. 14111cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx, 1412826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek firstDataArg, isPrintf)) 14131cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner return; // Literal format string found, check done! 14141cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner 1415655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // If there are no arguments specified, warn with -Wformat-security, otherwise 1416655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // warn only with -Wformat-nonliteral. 1417655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner if (TheCall->getNumArgs() == format_idx+1) 14181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1419826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral_noargs) 1420655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1421655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner else 14221eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1423826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral) 1424655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1425d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1426d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1427e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace { 1428826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler { 1429826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1430e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Sema &S; 1431e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const StringLiteral *FExpr; 1432e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const Expr *OrigFormatExpr; 14336ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const unsigned FirstDataArg; 1434e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const unsigned NumDataArgs; 1435e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const bool IsObjCLiteral; 1436e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *Beg; // Start of format string. 14370d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const bool HasVAListArg; 14380d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const CallExpr *TheCall; 14390d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek unsigned FormatIdx; 14407f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek llvm::BitVector CoveredArgs; 1441efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool usesPositionalArgs; 1442efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool atFirstArg; 14434e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic: 1444826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 14456ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1446e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 14470d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const char *beg, bool hasVAListArg, 14480d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1449e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 14506ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek FirstDataArg(firstDataArg), 14517f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek NumDataArgs(numDataArgs), 14520d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek IsObjCLiteral(isObjCLiteral), Beg(beg), 14530d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek HasVAListArg(hasVAListArg), 1454efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek TheCall(theCall), FormatIdx(formatIdx), 1455efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek usesPositionalArgs(false), atFirstArg(true) { 14567f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.resize(numDataArgs); 14577f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.reset(); 14587f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 14594e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 146007d161f38e708a91486bf1c031d525faebbb249dTed Kremenek void DoneProcessing(); 14614e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1462826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIncompleteSpecifier(const char *startSpecifier, 1463826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1464826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1465efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleInvalidPosition(const char *startSpecifier, 1466efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned specifierLen, 1467826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p); 1468efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1469efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 1470efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1471e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek void HandleNullChar(const char *nullCharacter); 14724e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1473826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1474c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 1475c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1476c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1477c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, unsigned csLen); 1478c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1479f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek SourceRange getFormatStringRange(); 1480826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CharSourceRange getSpecifierRange(const char *startSpecifier, 1481826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1482e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek SourceLocation getLocationOfByte(const char *x); 14834e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 14840d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const Expr *getDataArg(unsigned i) const; 1485666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1486666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 1487666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1488666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, 1489666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek unsigned argIndex); 1490e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}; 1491e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1492e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1493826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() { 1494e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return OrigFormatExpr->getSourceRange(); 1495e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1496e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1497826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler:: 1498826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 149945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation Start = getLocationOfByte(startSpecifier); 150045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 150145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 150245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care // Advance the end SourceLocation by one due to half-open ranges. 1503a64ccefdf0ea4e03ec88805d71b0af74950c7472Argyrios Kyrtzidis End = End.getLocWithOffset(1); 150445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 150545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care return CharSourceRange::getCharRange(Start, End); 1506f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek} 1507f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek 1508826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 15094e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 1510e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1511e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1512826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 1513826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen){ 1514808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek SourceLocation Loc = getLocationOfByte(startSpecifier); 1515808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek S.Diag(Loc, diag::warn_printf_incomplete_specifier) 1516826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1517808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek} 1518808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek 1519efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid 1520826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 1521826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p) { 1522efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek SourceLocation Loc = getLocationOfByte(startPos); 1523826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(Loc, diag::warn_format_invalid_positional_specifier) 1524826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << (unsigned) p << getSpecifierRange(startPos, posLen); 1525efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1526efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1527826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos, 1528efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned posLen) { 1529efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek SourceLocation Loc = getLocationOfByte(startPos); 1530826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(Loc, diag::warn_format_zero_positional_specifier) 1531826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startPos, posLen); 1532efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1533efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1534826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 15350c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek if (!IsObjCLiteral) { 15360c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek // The presence of a null character is likely an error. 15370c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek S.Diag(getLocationOfByte(nullCharacter), 15380c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek diag::warn_printf_format_string_contains_null_char) 15390c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek << getFormatStringRange(); 15400c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek } 1541826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1542826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1543826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const { 1544826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return TheCall->getArg(FirstDataArg + i); 1545826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 15464e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1547826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() { 1548826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Does the number of data arguments exceed the number of 1549826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // format conversions in the format string? 1550826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!HasVAListArg) { 1551826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Find any arguments that weren't covered. 1552826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.flip(); 1553826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek signed notCoveredArg = CoveredArgs.find_first(); 1554826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (notCoveredArg >= 0) { 1555826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek assert((unsigned)notCoveredArg < NumDataArgs); 1556826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(), 1557826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_printf_data_arg_not_used) 1558826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getFormatStringRange(); 1559826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1560826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1561826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1562826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1563c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool 1564c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 1565c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek SourceLocation Loc, 1566c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1567c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1568c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, 1569c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned csLen) { 1570c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1571c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool keepGoing = true; 1572c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek if (argIndex < NumDataArgs) { 1573c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // Consider the argument coverered, even though the specifier doesn't 1574c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // make sense. 1575c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CoveredArgs.set(argIndex); 1576c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1577c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek else { 1578c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // If argIndex exceeds the number of data arguments we 1579c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // don't issue a warning because that is just a cascade of warnings (and 1580c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // they may have intended '%%' anyway). We don't want to continue processing 1581c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // the format string after this point, however, as we will like just get 1582c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // gibberish when trying to match arguments. 1583c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek keepGoing = false; 1584c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1585c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1586c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek S.Diag(Loc, diag::warn_format_invalid_conversion) 15875f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner << StringRef(csStart, csLen) 1588c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek << getSpecifierRange(startSpec, specifierLen); 1589c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1590c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return keepGoing; 1591c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1592c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1593666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool 1594666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs( 1595666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::FormatSpecifier &FS, 1596666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1597666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 1598666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1599666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (argIndex >= NumDataArgs) { 1600666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (FS.usesPositionalArg()) { 1601666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1602666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek diag::warn_printf_positional_arg_exceeds_data_args) 1603666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << (argIndex+1) << NumDataArgs 1604666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1605666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1606666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek else { 1607666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1608666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek diag::warn_printf_insufficient_data_args) 1609666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1610666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1611666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1612666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return false; 1613666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1614666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return true; 1615666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek} 1616666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1617826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===// 1618826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1619826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 1620826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler { 1621826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 1622826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 1623826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1624826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 1625826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 1626826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1627826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1628826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 1629826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek theCall, formatIdx) {} 1630826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1631826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1632826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleInvalidPrintfConversionSpecifier( 1633826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1634826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1635826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1636826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1637826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 1638826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1639826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1640826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1641826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 1642826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1643826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 1644826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalAmount &Amt, 1645826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned type, 1646826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1647826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1648826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1649826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1650826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 1651826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &ignoredFlag, 1652826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1653826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1654826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 1655826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1656826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1657826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 1658826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1659826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1660826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 16616ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 1662c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 1663826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1664c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1665c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 1666c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 1667c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 166826ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek} 166926ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek 1670826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount( 1671826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_format_string::OptionalAmount &Amt, 1672826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned k, const char *startSpecifier, 1673826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 16740d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 16750d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (Amt.hasDataArgument()) { 16760d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (!HasVAListArg) { 16777f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = Amt.getArgIndex(); 16787f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (argIndex >= NumDataArgs) { 1679efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1680efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek diag::warn_printf_asterisk_missing_arg) 1681826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << k << getSpecifierRange(startSpecifier, specifierLen); 16820d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 16830d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 16840d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 16850d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 16864e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 16870d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Type check the data argument. It should be an 'int'. 168831f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // Although not in conformance with C99, we also allow the argument to be 168931f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // an 'unsigned int' as that is a reasonably safe case. GCC also 169031f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // doesn't emit a warning for that case. 16917f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.set(argIndex); 16927f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek const Expr *Arg = getDataArg(argIndex); 16930d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek QualType T = Arg->getType(); 16944e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 16954e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context); 16964e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek assert(ATR.isValid()); 16974e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 16984e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (!ATR.matchesType(S.Context, T)) { 1699efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1700efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek diag::warn_printf_asterisk_wrong_type) 1701efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek << k 17024e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek << ATR.getRepresentativeType(S.Context) << T 1703826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1704d635c5fcc45c952b75743dd2f4c86d6950e4954eTed Kremenek << Arg->getSourceRange(); 17050d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 17060d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 17070d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 17080d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 17090d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 17100d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 17110d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return true; 17120d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek} 17130d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1714e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount( 1715826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1716e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalAmount &Amt, 1717e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned type, 1718e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1719e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 17206ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 17216ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1722e4ee9663168dfb2b4122c768091e30217328c9faTom Care switch (Amt.getHowSpecified()) { 1723e4ee9663168dfb2b4122c768091e30217328c9faTom Care case analyze_printf::OptionalAmount::Constant: 1724e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(Amt.getStart()), 1725e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_optional_amount) 1726e4ee9663168dfb2b4122c768091e30217328c9faTom Care << type 1727e4ee9663168dfb2b4122c768091e30217328c9faTom Care << CS.toString() 1728826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1729826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 1730e4ee9663168dfb2b4122c768091e30217328c9faTom Care Amt.getConstantLength())); 1731e4ee9663168dfb2b4122c768091e30217328c9faTom Care break; 1732e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1733e4ee9663168dfb2b4122c768091e30217328c9faTom Care default: 1734e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(Amt.getStart()), 1735e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_optional_amount) 1736e4ee9663168dfb2b4122c768091e30217328c9faTom Care << type 1737e4ee9663168dfb2b4122c768091e30217328c9faTom Care << CS.toString() 1738826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1739e4ee9663168dfb2b4122c768091e30217328c9faTom Care break; 1740e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1741e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1742e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1743826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1744e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 1745e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1746e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 1747e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about pointless flag with a fixit removal. 17486ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 17496ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1750e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(flag.getPosition()), 1751e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_flag) 1752e4ee9663168dfb2b4122c768091e30217328c9faTom Care << flag.toString() << CS.toString() 1753826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1754826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(flag.getPosition(), 1)); 1755e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1756e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1757e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag( 1758826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1759e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &ignoredFlag, 1760e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 1761e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1762e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 1763e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about ignored flag with a fixit removal. 1764e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(ignoredFlag.getPosition()), 1765e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_ignored_flag) 1766e4ee9663168dfb2b4122c768091e30217328c9faTom Care << ignoredFlag.toString() << flag.toString() 1767826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1768826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange( 1769e4ee9663168dfb2b4122c768091e30217328c9faTom Care ignoredFlag.getPosition(), 1)); 1770e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1771e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1772e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool 1773826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 17745c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek &FS, 1775e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *startSpecifier, 1776e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned specifierLen) { 1777e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 17786ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek using namespace analyze_format_string; 1779efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek using namespace analyze_printf; 17806ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 1781e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1782baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 1783baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 1784baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 1785baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 1786baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1787baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 1788baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Cannot mix-and-match positional and non-positional arguments. 1789baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1790baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek diag::warn_format_mix_positional_nonpositional_args) 1791baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1792baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 1793baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1794efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek } 1795efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 17960d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // First check if the field width, precision, and conversion specifier 17970d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // have matching data arguments. 1798efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 1799efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 18000d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 18010d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 18024e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1803efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 1804efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 18050d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 18060d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 18070d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1808f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek if (!CS.consumesDataArgument()) { 1809f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // FIXME: Technically specifying a precision or field width here 1810f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // makes no sense. Worth issuing a warning at some point. 18110e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek return true; 1812f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek } 18134e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 18147f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Consume the argument. 18157f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = FS.getArgIndex(); 1816e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek if (argIndex < NumDataArgs) { 1817e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // The check to see if the argIndex is valid will come later. 1818e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // We set the bit here because we may exit early from this 1819e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // function if we encounter some other error. 1820e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek CoveredArgs.set(argIndex); 1821e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek } 18227f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek 18237f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Check for using an Objective-C specific conversion specifier 18247f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // in a non-ObjC literal. 18257f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (!IsObjCLiteral && CS.isObjCArg()) { 1826826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 1827826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek specifierLen); 18287f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 18294e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1830e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of field width 1831e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidFieldWidth()) { 183245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 1833e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1834e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1835e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1836e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of precision 1837e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPrecision()) { 1838e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 1839e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1840e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1841e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1842e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check each flag does not conflict with any other component. 184365197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek if (!FS.hasValidThousandsGroupingPrefix()) 184465197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen); 1845e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeadingZeros()) 1846e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 1847e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPlusPrefix()) 1848e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 184945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (!FS.hasValidSpacePrefix()) 185045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 1851e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidAlternativeForm()) 1852e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 1853e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeftJustified()) 1854e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 1855e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1856e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check that flags are not ignored by another flag 185745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 185845f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 185945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care startSpecifier, specifierLen); 1860e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 1861e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 1862e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1863e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1864e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check the length modifier is valid with the given conversion specifier. 1865e4ee9663168dfb2b4122c768091e30217328c9faTom Care const LengthModifier &LM = FS.getLengthModifier(); 1866e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLengthModifier()) 1867e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(LM.getStart()), 1868649aecf55670682efb2a04a85810eef4d038c527Ted Kremenek diag::warn_format_nonsensical_length) 1869e4ee9663168dfb2b4122c768091e30217328c9faTom Care << LM.toString() << CS.toString() 1870826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1871826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 1872e4ee9663168dfb2b4122c768091e30217328c9faTom Care LM.getLength())); 1873e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1874e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Are we using '%n'? 187535d353b47bce29200b910371dd9b8ba7f3058ab8Ted Kremenek if (CS.getKind() == ConversionSpecifier::nArg) { 1876e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Issue a warning about this being a possible security issue. 1877e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back) 1878826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1879e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek // Continue checking the other format specifiers. 1880e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek return true; 1881e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek } 18825c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek 1883da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek // The remaining checks depend on the data arguments. 1884da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek if (HasVAListArg) 1885da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return true; 18864e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1887666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 1888da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return false; 18894e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 189096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Now type check the data expression that matches the 189196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // format specifier. 189296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const Expr *Ex = getDataArg(argIndex); 189396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context); 189496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) { 189596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Check if we didn't match because of an implicit cast from a 'char' 189696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // or 'short' to an 'int'. This is done because printf is a varargs 189796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // function. 189896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex)) 18994d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ICE->getType() == S.Context.IntTy) { 19004d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek // All further checking is done on the subexpression. 19014d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek Ex = ICE->getSubExpr(); 19024d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ATR.matchesType(S.Context, Ex->getType())) 190396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer return true; 19044d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek } 190596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 190696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // We may be able to offer a FixItHint if it is a supported type. 190796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer PrintfSpecifier fixedFS = FS; 1908a7da2155167676a6a5d9fca4de947a9cab2a4908Hans Wennborg bool success = fixedFS.fixType(Ex->getType(), S.getLangOptions()); 190996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 191096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (success) { 191196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Get the fix string from the fixed format specifier 191296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::SmallString<128> buf; 191396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::raw_svector_ostream os(buf); 191496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer fixedFS.toString(os); 191596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 19169325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // FIXME: getRepresentativeType() perhaps should return a string 19179325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // instead of a QualType to better handle when the representative 19189325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // type is 'wint_t' (which is defined in the system headers). 191996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer S.Diag(getLocationOfByte(CS.getStart()), 192096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer diag::warn_printf_conversion_argument_type_mismatch) 192196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << ATR.getRepresentativeType(S.Context) << Ex->getType() 192296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << getSpecifierRange(startSpecifier, specifierLen) 192396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << Ex->getSourceRange() 192496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << FixItHint::CreateReplacement( 192596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer getSpecifierRange(startSpecifier, specifierLen), 192696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer os.str()); 192796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 192896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer else { 192996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer S.Diag(getLocationOfByte(CS.getStart()), 193096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer diag::warn_printf_conversion_argument_type_mismatch) 193196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << ATR.getRepresentativeType(S.Context) << Ex->getType() 193296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << getSpecifierRange(startSpecifier, specifierLen) 193396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << Ex->getSourceRange(); 193496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 193596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 193696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 1937e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return true; 1938e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1939e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1940826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===// 1941826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1942826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 1943826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler { 1944826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 1945826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 1946826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1947826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 1948826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 1949826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1950826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1951826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 1952826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek theCall, formatIdx) {} 1953826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1954826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 1955826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1956826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1957c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1958c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidScanfConversionSpecifier( 1959c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1960c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 1961c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen); 1962b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 1963b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek void HandleIncompleteScanList(const char *start, const char *end); 1964826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 1965826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1966826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1967b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start, 1968b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek const char *end) { 1969b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek S.Diag(getLocationOfByte(end), diag::warn_scanf_scanlist_incomplete) 1970b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek << getSpecifierRange(start, end - start); 1971b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek} 1972b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 1973c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 1974c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1975c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 1976c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen) { 1977c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 19786ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_scanf::ScanfConversionSpecifier &CS = 1979c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 1980c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1981c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1982c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 1983c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 1984c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 1985c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1986c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1987826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier( 1988826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1989826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1990826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 1991826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1992826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_scanf; 1993826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_format_string; 1994826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 19956ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 1996826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1997baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Handle case where '%' and '*' don't consume an argument. These shouldn't 1998baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // be used to decide if we are using positional arguments consistently. 1999baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 2000baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 2001baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 2002baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 2003baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2004baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 2005baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Cannot mix-and-match positional and non-positional arguments. 2006baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 2007baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek diag::warn_format_mix_positional_nonpositional_args) 2008baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 2009baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 2010baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2011826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2012826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2013826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Check if the field with is non-zero. 2014826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const OptionalAmount &Amt = FS.getFieldWidth(); 2015826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getHowSpecified() == OptionalAmount::Constant) { 2016826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getConstantAmount() == 0) { 2017826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 2018826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Amt.getConstantLength()); 2019826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 2020826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_scanf_nonzero_width) 2021826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << R << FixItHint::CreateRemoval(R); 20227f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 20237f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 2024826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2025826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!FS.consumesDataArgument()) { 2026826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Technically specifying a precision or field width here 2027826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // makes no sense. Worth issuing a warning at some point. 2028826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 2029826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2030826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2031826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Consume the argument. 2032826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned argIndex = FS.getArgIndex(); 2033826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (argIndex < NumDataArgs) { 2034826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The check to see if the argIndex is valid will come later. 2035826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // We set the bit here because we may exit early from this 2036826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // function if we encounter some other error. 2037826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.set(argIndex); 2038826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2039826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 20401e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek // Check the length modifier is valid with the given conversion specifier. 20411e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek const LengthModifier &LM = FS.getLengthModifier(); 20421e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek if (!FS.hasValidLengthModifier()) { 20431e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek S.Diag(getLocationOfByte(LM.getStart()), 20441e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek diag::warn_format_nonsensical_length) 20451e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << LM.toString() << CS.toString() 20461e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 20471e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 20481e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek LM.getLength())); 20491e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek } 20501e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek 2051826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The remaining checks depend on the data arguments. 2052826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (HasVAListArg) 2053826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 2054826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2055666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 2056826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return false; 2057826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2058826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Check that the argument type matches the format specifier. 2059826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2060826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 206107d161f38e708a91486bf1c031d525faebbb249dTed Kremenek} 2062e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2063826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr, 20640e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const Expr *OrigFormatExpr, 20650e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const CallExpr *TheCall, bool HasVAListArg, 2066826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 2067826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 2068826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2069e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: is the format string a wide literal? 20705cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!FExpr->isAscii()) { 2071e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Diag(FExpr->getLocStart(), 2072826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_string_is_wide_literal) 2073e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek << OrigFormatExpr->getSourceRange(); 2074e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 2075e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 2076826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2077e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // Str - The format string. NOTE: this is NOT null-terminated! 20785f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef StrRef = FExpr->getString(); 20792f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer const char *Str = StrRef.data(); 20802f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer unsigned StrLen = StrRef.size(); 20814cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek const unsigned numDataArgs = TheCall->getNumArgs() - firstDataArg; 2082826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2083e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: empty format string? 20844cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek if (StrLen == 0 && numDataArgs > 0) { 2085826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Diag(FExpr->getLocStart(), diag::warn_empty_format_string) 2086e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek << OrigFormatExpr->getSourceRange(); 2087e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 2088e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 2089826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2090826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (isPrintf) { 2091826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 20924cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek numDataArgs, isa<ObjCStringLiteral>(OrigFormatExpr), 20934cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek Str, HasVAListArg, TheCall, format_idx); 2094826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2095826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen)) 2096826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 2097826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2098826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek else { 2099826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 21004cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek numDataArgs, isa<ObjCStringLiteral>(OrigFormatExpr), 21014cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek Str, HasVAListArg, TheCall, format_idx); 2102826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2103826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen)) 2104826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 2105826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2106ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek} 2107ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek 21087ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth//===--- CHECK: Standard memory functions ---------------------------------===// 21097ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 21102a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// \brief Determine whether the given type is a dynamic class type (e.g., 21112a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// whether it has a vtable). 21122a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregorstatic bool isDynamicClassType(QualType T) { 21132a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Record = T->getAsCXXRecordDecl()) 21142a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Definition = Record->getDefinition()) 21152a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (Definition->isDynamicClass()) 21162a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return true; 21172a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 21182a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return false; 21192a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor} 21202a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 2121a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument expression, 2122000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth/// otherwise returns NULL. 2123000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic const Expr *getSizeOfExprArg(const Expr* E) { 2124e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber if (const UnaryExprOrTypeTraitExpr *SizeOf = 2125000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 2126000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType()) 2127000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getArgumentExpr()->IgnoreParenImpCasts(); 2128e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 2129000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return 0; 2130000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth} 2131000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2132a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument type. 2133000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic QualType getSizeOfArgType(const Expr* E) { 2134000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryExprOrTypeTraitExpr *SizeOf = 2135000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 2136000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf) 2137000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getTypeOfArgument(); 2138000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2139000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return QualType(); 2140e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber} 2141e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 21427ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \brief Check for dangerous or invalid arguments to memset(). 21437ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 2144929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth/// This issues warnings on known problematic, dangerous or unspecified 2145cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp' 2146cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// function calls. 21477ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 21487ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \param Call The call expression to diagnose. 2149cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gayvoid Sema::CheckMemaccessArguments(const CallExpr *Call, 2150cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay CheckedMemoryFunction CMF, 2151cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay IdentifierInfo *FnName) { 21521d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek // It is possible to have a non-standard definition of memset. Validate 2153707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor // we have enough arguments, and if not, abort further checking. 2154cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber unsigned ExpectedNumArgs = (CMF == CMF_Strndup ? 2 : 3); 2155cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber if (Call->getNumArgs() < ExpectedNumArgs) 21561d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek return; 21571d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek 2158cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber unsigned LastArg = (CMF == CMF_Memset || CMF == CMF_Strndup ? 1 : 2); 2159cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber unsigned LenArg = (CMF == CMF_Strndup ? 1 : 2); 2160cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts(); 2161000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2162000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We have special checking when the length is a sizeof expression. 2163000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth QualType SizeOfArgTy = getSizeOfArgType(LenExpr); 2164000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth const Expr *SizeOfArg = getSizeOfExprArg(LenExpr); 2165000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID SizeOfArgID; 2166000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 216706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) { 216806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts(); 2169e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange(); 217006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 217106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType DestTy = Dest->getType(); 217206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) { 217306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType PointeeTy = DestPtrTy->getPointeeType(); 2174f85e193739c953358c865005855253af4f68a497John McCall 2175000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Never warn about void type pointers. This can be used to suppress 2176000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // false positives. 2177000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isVoidType()) 217806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 217906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 2180000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by 2181000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // actually comparing the expressions for equality. Because computing the 2182000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // expression IDs can be expensive, we only do this if the diagnostic is 2183000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // enabled. 2184000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArg && 2185000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess, 2186000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->getExprLoc())) { 2187000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We only compute IDs for expressions if the warning is enabled, and 2188000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // cache the sizeof arg's ID. 2189000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgID == llvm::FoldingSetNodeID()) 2190000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->Profile(SizeOfArgID, Context, true); 2191000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID DestID; 2192000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Dest->Profile(DestID, Context, true); 2193000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (DestID == SizeOfArgID) { 2194cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // TODO: For strncpy() and friends, this could suggest sizeof(dst) 2195cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // over sizeof(src) as well. 2196000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth unsigned ActionIdx = 0; // Default is to suggest dereferencing. 2197000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest)) 2198000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (UnaryOp->getOpcode() == UO_AddrOf) 2199000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 1; // If its an address-of operator, just remove it. 2200000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (Context.getTypeSize(PointeeTy) == Context.getCharWidth()) 2201000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 2; // If the pointee's size is sizeof(char), 2202000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // suggest an explicit length. 2203cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber unsigned DestSrcSelect = (CMF == CMF_Strndup ? 1 : ArgIdx); 2204000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(SizeOfArg->getExprLoc(), Dest, 2205000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_expr_memaccess) 2206cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber << FnName << DestSrcSelect << ActionIdx 2207000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << Dest->getSourceRange() 2208000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << SizeOfArg->getSourceRange()); 2209000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 2210000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 2211000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 2212000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2213000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Also check for cases where the sizeof argument is the exact same 2214000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // type as the memory argument, and where it points to a user-defined 2215000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // record type. 2216000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgTy != QualType()) { 2217000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isRecordType() && 2218000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Context.typesAreCompatible(SizeOfArgTy, DestTy)) { 2219000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest, 2220000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_type_memaccess) 2221000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << FnName << SizeOfArgTy << ArgIdx 2222000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << PointeeTy << Dest->getSourceRange() 2223000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << LenExpr->getSourceRange()); 2224000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 2225000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 2226e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber } 2227e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 222806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor // Always complain about dynamic classes. 2229f85e193739c953358c865005855253af4f68a497John McCall if (isDynamicClassType(PointeeTy)) 22305c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 22315c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 22325c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_dyn_class_memaccess) 22335c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << (CMF == CMF_Memcmp ? ArgIdx + 2 : ArgIdx) << FnName << PointeeTy 22345c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay // "overwritten" if we're warning about the destination for any call 22355c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay // but memcmp; otherwise a verb appropriate to the call. 22365c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << (ArgIdx == 0 && CMF != CMF_Memcmp ? 0 : (unsigned)CMF) 22375c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 2238707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor else if (PointeeTy.hasNonTrivialObjCLifetime() && CMF != CMF_Memset) 22395c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 22405c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 22415c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_arc_object_memaccess) 22425c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << ArgIdx << FnName << PointeeTy 22435c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 2244f85e193739c953358c865005855253af4f68a497John McCall else 224506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 2246f85e193739c953358c865005855253af4f68a497John McCall 2247f85e193739c953358c865005855253af4f68a497John McCall DiagRuntimeBehavior( 2248f85e193739c953358c865005855253af4f68a497John McCall Dest->getExprLoc(), Dest, 2249929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth PDiag(diag::note_bad_memaccess_silence) 225006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)")); 225106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor break; 225206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 22537ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth } 22547ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth} 22557ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 2256bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// A little helper routine: ignore addition and subtraction of integer literals. 2257bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// This intentionally does not ignore all integer constant expressions because 2258bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// we don't want to remove sizeof(). 2259bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekstatic const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) { 2260bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = Ex->IgnoreParenCasts(); 2261bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2262bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek for (;;) { 2263bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex); 2264bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!BO || !BO->isAdditiveOp()) 2265bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 2266bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2267bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *RHS = BO->getRHS()->IgnoreParenCasts(); 2268bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *LHS = BO->getLHS()->IgnoreParenCasts(); 2269bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2270bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (isa<IntegerLiteral>(RHS)) 2271bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = LHS; 2272bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else if (isa<IntegerLiteral>(LHS)) 2273bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = RHS; 2274bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else 2275bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 2276bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2277bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2278bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return Ex; 2279bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 2280bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2281bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// Warn if the user has made the 'size' argument to strlcpy or strlcat 2282bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// be the size of the source, instead of the destination. 2283bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekvoid Sema::CheckStrlcpycatArguments(const CallExpr *Call, 2284bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek IdentifierInfo *FnName) { 2285bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2286bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Don't crash if the user has the wrong number of arguments 2287bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (Call->getNumArgs() != 3) 2288bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2289bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2290bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context); 2291bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context); 2292bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *CompareWithSrc = NULL; 2293bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2294bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, sizeof(x))' 2295bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const Expr *Ex = getSizeOfExprArg(SizeArg)) 2296bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = Ex; 2297bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else { 2298bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, strlen(x))' 2299bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) { 2300bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (SizeCall->isBuiltinCall(Context) == Builtin::BIstrlen 2301bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek && SizeCall->getNumArgs() == 1) 2302bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context); 2303bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2304bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2305bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2306bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrc) 2307bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2308bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2309bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Determine if the argument to sizeof/strlen is equal to the source 2310bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // argument. In principle there's all kinds of things you could do 2311bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // here, for instance creating an == expression and evaluating it with 2312bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // EvaluateAsBooleanCondition, but this uses a more direct technique: 2313bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg); 2314bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!SrcArgDRE) 2315bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2316bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2317bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc); 2318bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrcDRE || 2319bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl()) 2320bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2321bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2322bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *OriginalSizeArg = Call->getArg(2); 2323bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size) 2324bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek << OriginalSizeArg->getSourceRange() << FnName; 2325bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2326bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Output a FIXIT hint if the destination is an array (rather than a 2327bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointer to an array). This could be enhanced to handle some 2328bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointers if we know the actual size, like if DstArg is 'array+2' 2329bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // we could say 'sizeof(array)-2'. 2330bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts(); 23318f7462237ff542a4556775f98709ed300aa1731aTed Kremenek QualType DstArgTy = DstArg->getType(); 2332bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 23338f7462237ff542a4556775f98709ed300aa1731aTed Kremenek // Only handle constant-sized or VLAs, but not flexible members. 23348f7462237ff542a4556775f98709ed300aa1731aTed Kremenek if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(DstArgTy)) { 23358f7462237ff542a4556775f98709ed300aa1731aTed Kremenek // Only issue the FIXIT for arrays of size > 1. 23368f7462237ff542a4556775f98709ed300aa1731aTed Kremenek if (CAT->getSize().getSExtValue() <= 1) 23378f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 23388f7462237ff542a4556775f98709ed300aa1731aTed Kremenek } else if (!DstArgTy->isVariableArrayType()) { 23398f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 2340bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 23418f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 23428f7462237ff542a4556775f98709ed300aa1731aTed Kremenek llvm::SmallString<128> sizeString; 23438f7462237ff542a4556775f98709ed300aa1731aTed Kremenek llvm::raw_svector_ostream OS(sizeString); 23448f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << "sizeof("; 23458987b2385d9ba63ada66e1344ace79b04d5cb5c3Douglas Gregor DstArg->printPretty(OS, Context, 0, getPrintingPolicy()); 23468f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << ")"; 23478f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 23488f7462237ff542a4556775f98709ed300aa1731aTed Kremenek Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size) 23498f7462237ff542a4556775f98709ed300aa1731aTed Kremenek << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(), 23508f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS.str()); 2351bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 2352bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 235306de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===// 235406de276fff91264437fa75111ed76de43097e089Ted Kremenek 23555f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars); 23565f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars); 235706de276fff91264437fa75111ed76de43097e089Ted Kremenek 235806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address 235906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable. 236006de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid 236106de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 236206de276fff91264437fa75111ed76de43097e089Ted Kremenek SourceLocation ReturnLoc) { 23631eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 236426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Expr *stackE = 0; 23655f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<DeclRefExpr *, 8> refVars; 23664e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 236726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Perform checking for returned stack addresses, local blocks, 236826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // label addresses or references to temporaries. 2369f85e193739c953358c865005855253af4f68a497John McCall if (lhsType->isPointerType() || 2370f85e193739c953358c865005855253af4f68a497John McCall (!getLangOptions().ObjCAutoRefCount && lhsType->isBlockPointerType())) { 237126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalAddr(RetValExp, refVars); 2372ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (lhsType->isReferenceType()) { 237326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalVal(RetValExp, refVars); 237426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 237526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 237626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (stackE == 0) 237726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return; // Nothing suspicious was found. 237826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 237926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceLocation diagLoc; 238026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange diagRange; 238126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (refVars.empty()) { 238226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = stackE->getLocStart(); 238326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = stackE->getSourceRange(); 238426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { 238526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // We followed through a reference variable. 'stackE' contains the 238626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // problematic expression but we will warn at the return statement pointing 238726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // at the reference variable. We will later display the "trail" of 238826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // reference variables using notes. 238926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = refVars[0]->getLocStart(); 239026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = refVars[0]->getSourceRange(); 239126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 239226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 239326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var. 239426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref 239526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_stack_addr) 239626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << DR->getDecl()->getDeclName() << diagRange; 239726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<BlockExpr>(stackE)) { // local block. 239826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::err_ret_local_block) << diagRange; 239926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 240026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 240126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { // local temporary. 240226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref 240326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_local_temp_addr) 240426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << diagRange; 240526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 240626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 240726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Display the "trail" of reference variables that we followed until we 240826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // found the problematic expression using notes. 240926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 241026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 241126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this var binds to another reference var, show the range of the next 241226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // var, otherwise the var binds to the problematic expression, in which case 241326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // show the range of the expression. 241426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange() 241526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : stackE->getSourceRange(); 241626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(VD->getLocation(), diag::note_ref_var_local_bind) 241726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << VD->getDeclName() << range; 241806de276fff91264437fa75111ed76de43097e089Ted Kremenek } 241906de276fff91264437fa75111ed76de43097e089Ted Kremenek} 242006de276fff91264437fa75111ed76de43097e089Ted Kremenek 242106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 242206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// check if the expression in a return statement evaluates to an address 242326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// to a location on the stack, a local block, an address of a label, or a 242426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// reference to local temporary. The recursion is used to traverse the 242506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// AST of the return expression, with recursion backtracking when we 242626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// encounter a subexpression that (1) clearly does not lead to one of the 242726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// above problematic expressions (2) is something we cannot determine leads to 242826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// a problematic expression based on such local checking. 242926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 243026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// Both EvalAddr and EvalVal follow through reference variables to evaluate 243126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// the expression that they point to. Such variables are added to the 243226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 'refVars' vector so that we know what the reference variable "trail" was. 243306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 2434e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// EvalAddr processes expressions that are pointers that are used as 2435e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// references (and not L-values). EvalVal handles all other values. 243626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// At the base case of the recursion is a check for the above problematic 243726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// expressions. 243806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 243906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// This implementation handles: 244006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 244106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer-to-pointer casts 244206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * implicit conversions from array references to pointers 244306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of fields 244406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * arbitrary interplay between "&" and "*" operators 244506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer arithmetic from an address of a stack variable 244606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of an array element where the array is on the stack 24475f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars) { 244826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (E->isTypeDependent()) 244926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 245026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 245106de276fff91264437fa75111ed76de43097e089Ted Kremenek // We should only be called for evaluating pointer expressions. 24520f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall assert((E->getType()->isAnyPointerType() || 2453dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff E->getType()->isBlockPointerType() || 2454a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek E->getType()->isObjCQualifiedIdType()) && 2455fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner "EvalAddr only works on pointers"); 24561eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2457f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 2458f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 245906de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 246006de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 246106de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 246206de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 246326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::DeclRefExprClass: { 246426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis DeclRefExpr *DR = cast<DeclRefExpr>(E); 246526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 246626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 246726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this is a reference variable, follow through to the expression that 246826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 246926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage() && 247026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis V->getType()->isReferenceType() && V->hasInit()) { 247126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 247226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 247326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(V->getInit(), refVars); 247426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 247526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 247626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 247726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 247806de276fff91264437fa75111ed76de43097e089Ted Kremenek 2479fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::UnaryOperatorClass: { 2480fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // The only unary operator that make sense to handle here 2481fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // is AddrOf. All others don't make sense as pointers. 2482fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner UnaryOperator *U = cast<UnaryOperator>(E); 24831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 24842de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_AddrOf) 248526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(U->getSubExpr(), refVars); 2486fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 2487fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 2488fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 24891eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2490fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::BinaryOperatorClass: { 2491fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle pointer arithmetic. All other binary operators are not valid 2492fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // in this context. 2493fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner BinaryOperator *B = cast<BinaryOperator>(E); 24942de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = B->getOpcode(); 24951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 24962de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op != BO_Add && op != BO_Sub) 2497fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 24981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2499fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner Expr *Base = B->getLHS(); 25003907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 2501fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Determine which argument is the real pointer base. It could be 2502fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // the RHS argument instead of the LHS. 2503fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner if (!Base->getType()->isPointerType()) Base = B->getRHS(); 25041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2505fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner assert (Base->getType()->isPointerType()); 250626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(Base, refVars); 2507fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 250861f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff 2509fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // For conditional operators we need to see if either the LHS or RHS are 2510fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // valid DeclRefExpr*s. If one of them is valid, we return it. 2511fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ConditionalOperatorClass: { 2512fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner ConditionalOperator *C = cast<ConditionalOperator>(E); 25131eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2514fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle the GNU extension for missing LHS. 25159ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (Expr *lhsExpr = C->getLHS()) { 25169ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 25179ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (!lhsExpr->getType()->isVoidType()) 251826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr* LHS = EvalAddr(lhsExpr, refVars)) 25199ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return LHS; 25209ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor } 25219ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor 25229ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 25239ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (C->getRHS()->getType()->isVoidType()) 25249ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return NULL; 252506de276fff91264437fa75111ed76de43097e089Ted Kremenek 252626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(C->getRHS(), refVars); 2527fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 252826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 252926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::BlockExprClass: 2530469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures()) 253126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // local block. 253226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 253326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 253426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::AddrLabelExprClass: 253526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // address of label. 25361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 253754b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // For casts, we need to handle conversions from arrays to 253854b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // pointer values, and pointer-to-pointer conversions. 253949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::ImplicitCastExprClass: 25406eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor case Stmt::CStyleCastExprClass: 2541f85e193739c953358c865005855253af4f68a497John McCall case Stmt::CXXFunctionalCastExprClass: 2542f85e193739c953358c865005855253af4f68a497John McCall case Stmt::ObjCBridgedCastExprClass: { 25430835a3cdeefe714b4959d31127ea155e56393125Argyrios Kyrtzidis Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 254454b5274f2c190331438375ad114dad12ae098b57Ted Kremenek QualType T = SubExpr->getType(); 25451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2546dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (SubExpr->getType()->isPointerType() || 2547dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isBlockPointerType() || 2548dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isObjCQualifiedIdType()) 254926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(SubExpr, refVars); 255054b5274f2c190331438375ad114dad12ae098b57Ted Kremenek else if (T->isArrayType()) 255126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(SubExpr, refVars); 2552fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 255354b5274f2c190331438375ad114dad12ae098b57Ted Kremenek return 0; 2554fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 25551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2556fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // C++ casts. For dynamic casts, static casts, and const casts, we 2557fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // are always converting from a pointer-to-pointer, so we just blow 255849badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // through the cast. In the case the dynamic cast doesn't fail (and 255949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // return NULL), we take the conservative route and report cases 2560fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // where we return the address of a stack variable. For Reinterpre 256149badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // FIXME: The comment about is wrong; we're not always converting 256249badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // from pointer to pointer. I'm guessing that this code should also 25631eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // handle references to objects. 25641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXStaticCastExprClass: 25651eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXDynamicCastExprClass: 256649badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXConstCastExprClass: 256749badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXReinterpretCastExprClass: { 256849badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr(); 2569dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (S->getType()->isPointerType() || S->getType()->isBlockPointerType()) 257026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(S, refVars); 257106de276fff91264437fa75111ed76de43097e089Ted Kremenek else 257206de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 2573fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 25741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 257503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 257603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalAddr( 257703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 257803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor refVars)) 257903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 258003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 258103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 258203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 2583fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Everything else: we simply don't reason about them. 2584fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner default: 2585fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 258606de276fff91264437fa75111ed76de43097e089Ted Kremenek } 258706de276fff91264437fa75111ed76de43097e089Ted Kremenek} 25881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 258906de276fff91264437fa75111ed76de43097e089Ted Kremenek 259006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalVal - This function is complements EvalAddr in the mutual recursion. 259106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// See the comments for EvalAddr for more details. 25925f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars) { 259368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo { 2594e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // We should only be called for evaluating non-pointer expressions, or 2595e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // expressions with a pointer type that are not used as references but instead 2596e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // are l-values (e.g., DeclRefExpr with a pointer type). 25971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 259806de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 259906de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 260006de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 2601f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 2602f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 260306de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 260468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ImplicitCastExprClass: { 260568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 26065baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall if (IE->getValueKind() == VK_LValue) { 260768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = IE->getSubExpr(); 260868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 260968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 261068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek return NULL; 261168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 261268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek 2613a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor case Stmt::DeclRefExprClass: { 261426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // When we hit a DeclRefExpr we are looking at code that refers to a 261526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // variable's name. If it's not a reference variable we check if it has 261626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // local storage within the function, and if so, return the expression. 261706de276fff91264437fa75111ed76de43097e089Ted Kremenek DeclRefExpr *DR = cast<DeclRefExpr>(E); 26181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 261906de276fff91264437fa75111ed76de43097e089Ted Kremenek if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 262026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage()) { 262126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!V->getType()->isReferenceType()) 262226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return DR; 262326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 262426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Reference variable, follow through to the expression that 262526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 262626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasInit()) { 262726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 262826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 262926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(V->getInit(), refVars); 263026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 263126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 26321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 263306de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 263406de276fff91264437fa75111ed76de43097e089Ted Kremenek } 26351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 263606de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::UnaryOperatorClass: { 263706de276fff91264437fa75111ed76de43097e089Ted Kremenek // The only unary operator that make sense to handle here 263806de276fff91264437fa75111ed76de43097e089Ted Kremenek // is Deref. All others don't resolve to a "name." This includes 263906de276fff91264437fa75111ed76de43097e089Ted Kremenek // handling all sorts of rvalues passed to a unary operator. 264006de276fff91264437fa75111ed76de43097e089Ted Kremenek UnaryOperator *U = cast<UnaryOperator>(E); 26411eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 26422de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_Deref) 264326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(U->getSubExpr(), refVars); 264406de276fff91264437fa75111ed76de43097e089Ted Kremenek 264506de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 264606de276fff91264437fa75111ed76de43097e089Ted Kremenek } 26471eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 264806de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ArraySubscriptExprClass: { 264906de276fff91264437fa75111ed76de43097e089Ted Kremenek // Array subscripts are potential references to data on the stack. We 265006de276fff91264437fa75111ed76de43097e089Ted Kremenek // retrieve the DeclRefExpr* for the array variable if it indeed 265106de276fff91264437fa75111ed76de43097e089Ted Kremenek // has local storage. 265226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars); 265306de276fff91264437fa75111ed76de43097e089Ted Kremenek } 26541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 265506de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ConditionalOperatorClass: { 265606de276fff91264437fa75111ed76de43097e089Ted Kremenek // For conditional operators we need to see if either the LHS or RHS are 265726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // non-NULL Expr's. If one is non-NULL, we return it. 265806de276fff91264437fa75111ed76de43097e089Ted Kremenek ConditionalOperator *C = cast<ConditionalOperator>(E); 265906de276fff91264437fa75111ed76de43097e089Ted Kremenek 26603907323dd6665c0c4e383435cb145233f4533406Anders Carlsson // Handle the GNU extension for missing LHS. 26613907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (Expr *lhsExpr = C->getLHS()) 266226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr *LHS = EvalVal(lhsExpr, refVars)) 26633907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return LHS; 26643907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 266526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(C->getRHS(), refVars); 266606de276fff91264437fa75111ed76de43097e089Ted Kremenek } 26671eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 266806de276fff91264437fa75111ed76de43097e089Ted Kremenek // Accesses to members are potential references to data on the stack. 266983f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor case Stmt::MemberExprClass: { 267006de276fff91264437fa75111ed76de43097e089Ted Kremenek MemberExpr *M = cast<MemberExpr>(E); 26711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 267206de276fff91264437fa75111ed76de43097e089Ted Kremenek // Check for indirect access. We only want direct field accesses. 2673a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->isArrow()) 2674a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return NULL; 2675a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 2676a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // Check whether the member type is itself a reference, in which case 2677a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // we're not going to refer to the member, but to what the member refers to. 2678a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->getMemberDecl()->getType()->isReferenceType()) 267906de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 2680a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 268126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(M->getBase(), refVars); 268206de276fff91264437fa75111ed76de43097e089Ted Kremenek } 26831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 268403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 268503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalVal( 268603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 268703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor refVars)) 268803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 268903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 269003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 269103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 269206de276fff91264437fa75111ed76de43097e089Ted Kremenek default: 269326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Check that we don't return or take the address of a reference to a 269426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // temporary. This is only useful in C++. 269526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!E->isTypeDependent() && E->isRValue()) 269626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; 269726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 269826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Everything else: we simply don't reason about them. 269906de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 270006de276fff91264437fa75111ed76de43097e089Ted Kremenek } 270168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true); 270206de276fff91264437fa75111ed76de43097e089Ted Kremenek} 2703588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2704588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 2705588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2706588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==. 2707588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely 2708588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended. 2709dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieuvoid Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) { 2710588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek bool EmitWarning = true; 27111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2712dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts(); 2713dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* RightExprSansParen = RHS->IgnoreParenImpCasts(); 2714588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2715588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Special case: check for x == x (which is OK). 2716588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Do not emit warnings for such cases. 2717588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 2718588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 2719588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DRL->getDecl() == DRR->getDecl()) 2720588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 27211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 27221eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 27231b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // Special case: check for comparisons against literals that can be exactly 27241b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // represented by APFloat. In such cases, do not emit a warning. This 27251b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // is a heuristic: often comparison against such literals are used to 27261b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // detect if a value in a variable has not changed. This clearly can 27271b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // lead to false negatives. 27281b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (EmitWarning) { 27291b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 27301b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLL->isExact()) 27311b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 2732ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else 27331b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){ 27341b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLR->isExact()) 27351b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 27361b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 27371b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 27381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2739588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Check for comparisons with builtin types. 27400eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 2741588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 27423c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor if (CL->isBuiltinCall(Context)) 2743588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 27441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 27450eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 2746588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 27473c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor if (CR->isBuiltinCall(Context)) 2748588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 27491eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2750588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Emit the diagnostic. 2751588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (EmitWarning) 2752dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Diag(Loc, diag::warn_floatingpoint_eq) 2753dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu << LHS->getSourceRange() << RHS->getSourceRange(); 2754588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek} 2755ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2756f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 2757f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 2758ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2759f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace { 2760ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2761f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued 2762f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression. 2763f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange { 2764f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// The number of bits active in the int. 2765f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned Width; 2766ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2767f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// True if the int is known not to have negative values. 2768f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool NonNegative; 276951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2770f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange(unsigned Width, bool NonNegative) 2771f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : Width(Width), NonNegative(NonNegative) 2772f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall {} 277351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 27741844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of the bool type. 2775f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall static IntRange forBoolType() { 2776f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(1, true); 2777f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 277851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 27791844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of the given integral type. 27801844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfType(ASTContext &C, QualType T) { 27811844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return forValueOfCanonicalType(C, 27821844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T->getCanonicalTypeInternal().getTypePtr()); 278351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 278451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 27851844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of a canonical integral type. 27861844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 2787f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(T->isCanonicalUnqualified()); 278851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2789f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 2790f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = VT->getElementType().getTypePtr(); 2791f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 2792f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = CT->getElementType().getTypePtr(); 2793323ed74658bc8375278eabf074b4777458376540John McCall 2794091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // For enum types, use the known bit width of the enumerators. 2795323ed74658bc8375278eabf074b4777458376540John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) { 2796323ed74658bc8375278eabf074b4777458376540John McCall EnumDecl *Enum = ET->getDecl(); 27975e1cdac63c3d9c9b32fa41fa0b2d242a58a20d49John McCall if (!Enum->isCompleteDefinition()) 2798091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return IntRange(C.getIntWidth(QualType(T, 0)), false); 2799091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2800323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumPositive = Enum->getNumPositiveBits(); 2801323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumNegative = Enum->getNumNegativeBits(); 2802323ed74658bc8375278eabf074b4777458376540John McCall 2803323ed74658bc8375278eabf074b4777458376540John McCall return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0); 2804323ed74658bc8375278eabf074b4777458376540John McCall } 280551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2806f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const BuiltinType *BT = cast<BuiltinType>(T); 2807f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(BT->isInteger()); 280851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2809f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 281051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 281151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 28121844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the "target" range of a canonical integral type, i.e. 28131844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// the range of values expressible in the type. 28141844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// 28151844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// This matches forValueOfCanonicalType except that enums have the 28161844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// full range of their type, not the range of their enumerators. 28171844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 28181844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(T->isCanonicalUnqualified()); 28191844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 28201844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 28211844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = VT->getElementType().getTypePtr(); 28221844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 28231844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = CT->getElementType().getTypePtr(); 28241844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) 282569ff26bd1e7a2faffec0c3b9740cfb0c6bb354c5Douglas Gregor T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr(); 28261844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 28271844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall const BuiltinType *BT = cast<BuiltinType>(T); 28281844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(BT->isInteger()); 28291844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 28301844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 28311844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall } 28321844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 28331844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the supremum of two ranges: i.e. their conservative merge. 2834c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange join(IntRange L, IntRange R) { 2835f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(std::max(L.Width, R.Width), 283660fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative && R.NonNegative); 283760fad45739b764886f707bd204eae9ecce6db1f2John McCall } 283860fad45739b764886f707bd204eae9ecce6db1f2John McCall 28391844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the infinum of two ranges: i.e. their aggressive merge. 2840c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange meet(IntRange L, IntRange R) { 284160fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange(std::min(L.Width, R.Width), 284260fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative || R.NonNegative); 284351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 2844f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}; 284551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2846f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) { 2847f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isSigned() && value.isNegative()) 2848f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getMinSignedBits(), false); 284951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2850f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.getBitWidth() > MaxWidth) 28519f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad value = value.trunc(MaxWidth); 285251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2853f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // isNonNegative() just checks the sign bit without considering 2854f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // signedness. 2855f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getActiveBits(), true); 285651313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 285751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 28580acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCallIntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 2859f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned MaxWidth) { 2860f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isInt()) 2861f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetValueRange(C, result.getInt(), MaxWidth); 286251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2863f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isVector()) { 28640acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 28650acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 28660acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 28670acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall R = IntRange::join(R, El); 28680acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall } 2869f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return R; 287051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 287151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2872f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isComplexInt()) { 2873f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 2874f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 2875f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(R, I); 2876f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2877f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2878f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // This can happen with lossless casts to intptr_t of "based" lvalues. 2879f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume it might use arbitrary bits. 28800acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // FIXME: The only reason we need to pass the type in here is to get 28810acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // the sign right on this one case. It would be nice if APValue 28820acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // preserved this. 2883f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(result.isLValue()); 28845e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType()); 288551313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 288651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2887f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the 2888f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take. 2889f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 2890f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated 2891f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 289251313c39c84407dd6a323be99a8c322bf8d052a9John McCall E = E->IgnoreParens(); 289351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2894f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Try a full evaluation first. 2895f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall Expr::EvalResult result; 2896f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (E->Evaluate(result, C)) 28970acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall return GetValueRange(C, result.Val, E->getType(), MaxWidth); 289851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2899f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // I think we only want to look through implicit casts here; if the 2900f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // user has an explicit widening cast, we should treat the value as 2901f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // being of the new, wider type. 2902f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 29032de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (CE->getCastKind() == CK_NoOp) 2904f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CE->getSubExpr(), MaxWidth); 290551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 29061844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType()); 290751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 29082de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 290960fad45739b764886f707bd204eae9ecce6db1f2John McCall 2910f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume that non-integer casts can span the full range of the type. 291160fad45739b764886f707bd204eae9ecce6db1f2John McCall if (!isIntegerCast) 2912f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 291351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2914f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange SubRange 2915f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall = GetExprRange(C, CE->getSubExpr(), 2916f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall std::min(MaxWidth, OutputTypeRange.Width)); 291751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2918f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Bail out if the subexpr's range is as wide as the cast type. 2919f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SubRange.Width >= OutputTypeRange.Width) 2920f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 292151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2922f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, we take the smaller width, and we're non-negative if 2923f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // either the output type or the subexpr is. 2924f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(SubRange.Width, 2925f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall SubRange.NonNegative || OutputTypeRange.NonNegative); 2926f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2927f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2928f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 2929f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // If we can fold the condition, just take that operand. 2930f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool CondResult; 2931f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 2932f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CondResult ? CO->getTrueExpr() 2933f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : CO->getFalseExpr(), 2934f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall MaxWidth); 2935f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2936f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, conservatively merge. 2937f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 2938f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 2939f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 294051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 294151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 294251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 294351313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (BO->getOpcode()) { 294451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2945f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Boolean-valued operations are single-bit and positive. 29462de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LAnd: 29472de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LOr: 29482de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LT: 29492de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GT: 29502de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LE: 29512de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GE: 29522de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_EQ: 29532de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_NE: 2954f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 295551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2956862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // The type of the assignments is the type of the LHS, so the RHS 2957862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // is not necessarily the same type. 29582de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_MulAssign: 29592de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_DivAssign: 29602de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_RemAssign: 29612de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AddAssign: 29622de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_SubAssign: 2963862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_XorAssign: 2964862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_OrAssign: 2965862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 29661844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 2967c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall 2968862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // Simple assignments just pass through the RHS, which will have 2969862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // been coerced to the LHS type. 2970862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_Assign: 2971862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 2972862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 2973862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall 297451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 29752de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemD: 29762de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemI: 29771844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 297851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 297960fad45739b764886f707bd204eae9ecce6db1f2John McCall // Bitwise-and uses the *infinum* of the two source ranges. 29802de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_And: 29812de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AndAssign: 298260fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 298360fad45739b764886f707bd204eae9ecce6db1f2John McCall GetExprRange(C, BO->getRHS(), MaxWidth)); 298460fad45739b764886f707bd204eae9ecce6db1f2John McCall 298551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Left shift gets black-listed based on a judgement call. 29862de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shl: 29873aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // ...except that we want to treat '1 << (blah)' as logically 29883aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // positive. It's an important idiom. 29893aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (IntegerLiteral *I 29903aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 29913aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (I->getValue() == 1) { 29921844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange R = IntRange::forValueOfType(C, E->getType()); 29933aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall return IntRange(R.Width, /*NonNegative*/ true); 29943aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 29953aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 29963aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // fallthrough 29973aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall 29982de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShlAssign: 29991844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 300051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 300160fad45739b764886f707bd204eae9ecce6db1f2John McCall // Right shift by a constant can narrow its left argument. 30022de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shr: 30032de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShrAssign: { 300460fad45739b764886f707bd204eae9ecce6db1f2John McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 300560fad45739b764886f707bd204eae9ecce6db1f2John McCall 300660fad45739b764886f707bd204eae9ecce6db1f2John McCall // If the shift amount is a positive constant, drop the width by 300760fad45739b764886f707bd204eae9ecce6db1f2John McCall // that much. 300860fad45739b764886f707bd204eae9ecce6db1f2John McCall llvm::APSInt shift; 300960fad45739b764886f707bd204eae9ecce6db1f2John McCall if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 301060fad45739b764886f707bd204eae9ecce6db1f2John McCall shift.isNonNegative()) { 301160fad45739b764886f707bd204eae9ecce6db1f2John McCall unsigned zext = shift.getZExtValue(); 301260fad45739b764886f707bd204eae9ecce6db1f2John McCall if (zext >= L.Width) 301360fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width = (L.NonNegative ? 0 : 1); 301460fad45739b764886f707bd204eae9ecce6db1f2John McCall else 301560fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width -= zext; 301660fad45739b764886f707bd204eae9ecce6db1f2John McCall } 301760fad45739b764886f707bd204eae9ecce6db1f2John McCall 301860fad45739b764886f707bd204eae9ecce6db1f2John McCall return L; 301960fad45739b764886f707bd204eae9ecce6db1f2John McCall } 302060fad45739b764886f707bd204eae9ecce6db1f2John McCall 302160fad45739b764886f707bd204eae9ecce6db1f2John McCall // Comma acts as its right operand. 30222de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Comma: 3023f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 3024f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 302560fad45739b764886f707bd204eae9ecce6db1f2John McCall // Black-list pointer subtractions. 30262de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Sub: 302751313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BO->getLHS()->getType()->isPointerType()) 30281844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 302900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall break; 303000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 303100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The width of a division result is mostly determined by the size 303200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // of the LHS. 303300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Div: { 303400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 303500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 303600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 303700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 303800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // If the divisor is constant, use that. 303900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall llvm::APSInt divisor; 304000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) { 304100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned log2 = divisor.logBase2(); // floor(log_2(divisor)) 304200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (log2 >= L.Width) 304300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = (L.NonNegative ? 0 : 1); 304400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall else 304500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = std::min(L.Width - log2, MaxWidth); 304600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return L; 304700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 304800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 304900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Otherwise, just use the LHS's width. 305000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 305100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return IntRange(L.Width, L.NonNegative && R.NonNegative); 305200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 305300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 305400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The result of a remainder can't be larger than the result of 305500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // either side. 305600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Rem: { 305700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 305800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 305900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 306000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 306100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 306200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange meet = IntRange::meet(L, R); 306300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall meet.Width = std::min(meet.Width, MaxWidth); 306400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return meet; 306500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 30664e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 306700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default behavior is okay for these. 306800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Mul: 306900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Add: 307000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Xor: 307100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Or: 3072f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall break; 307351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 3074f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 307500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default case is to treat the operation as if it were closed 307600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // on the narrowest type that encompasses both operands. 3077f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 3078f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 3079f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 308051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 308151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 308251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 308351313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (UO->getOpcode()) { 308451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Boolean-valued operations are white-listed. 30852de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_LNot: 3086f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 308751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 308851313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 30892de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_Deref: 30902de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_AddrOf: // should be impossible 30911844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 309251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 309351313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 3094f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, UO->getSubExpr(), MaxWidth); 309551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 309651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 30978ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor 30988ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor if (dyn_cast<OffsetOfExpr>(E)) { 30991844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange::forValueOfType(C, E->getType()); 31008ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor } 310151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3102a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith if (FieldDecl *BitField = E->getBitField()) 3103a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith return IntRange(BitField->getBitWidthValue(C), 31045e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor BitField->getType()->isUnsignedIntegerOrEnumerationType()); 3105f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 31061844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 3107f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 3108f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3109323ed74658bc8375278eabf074b4777458376540John McCallIntRange GetExprRange(ASTContext &C, Expr *E) { 3110323ed74658bc8375278eabf074b4777458376540John McCall return GetExprRange(C, E, C.getIntWidth(E->getType())); 3111323ed74658bc8375278eabf074b4777458376540John McCall} 3112323ed74658bc8375278eabf074b4777458376540John McCall 3113f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 3114f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 3115f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 3116f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const llvm::APFloat &value, 3117f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 3118f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 3119f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APFloat truncated = value; 3120f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3121f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool ignored; 3122f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 3123f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 3124f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3125f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return truncated.bitwiseIsEqual(value); 312651313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 312751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3128f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 3129f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 3130f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 3131f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 3132f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number). 3133f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const APValue &value, 3134f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 3135f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 3136f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isFloat()) 3137f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 3138f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3139f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isVector()) { 3140f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 3141f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 3142f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return false; 3143f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return true; 3144f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 3145f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3146f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(value.isComplexFloat()); 3147f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 3148f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 3149f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 3150f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3151b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 3152323ed74658bc8375278eabf074b4777458376540John McCall 3153e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) { 3154e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where we are comparing against an enum constant. 3155e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (const DeclRefExpr *DR = 3156e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 3157e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (isa<EnumConstantDecl>(DR->getDecl())) 3158e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 3159e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 3160e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where the '0' value is expanded from a macro. 3161e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (E->getLocStart().isMacroID()) 3162e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 3163e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 3164323ed74658bc8375278eabf074b4777458376540John McCall llvm::APSInt Value; 3165323ed74658bc8375278eabf074b4777458376540John McCall return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 3166323ed74658bc8375278eabf074b4777458376540John McCall} 3167323ed74658bc8375278eabf074b4777458376540John McCall 3168372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) { 3169372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall // Strip off implicit integral promotions. 3170372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 317163b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis if (ICE->getCastKind() != CK_IntegralCast && 317263b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis ICE->getCastKind() != CK_NoOp) 3173372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall break; 317463b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis E = ICE->getSubExpr(); 3175372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall } 3176372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 3177372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall return E->getType()->isEnumeralType(); 3178372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall} 3179372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 3180323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 31812de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = E->getOpcode(); 318214af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor if (E->isValueDependent()) 318314af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor return; 318414af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor 31852de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op == BO_LT && IsZero(S, E->getRHS())) { 3186323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 3187372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "< 0" << "false" << HasEnumType(E->getLHS()) 3188323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 31892de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GE && IsZero(S, E->getRHS())) { 3190323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 3191372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << ">= 0" << "true" << HasEnumType(E->getLHS()) 3192323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 31932de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GT && IsZero(S, E->getLHS())) { 3194323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 3195372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 >" << "false" << HasEnumType(E->getRHS()) 3196323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 31972de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_LE && IsZero(S, E->getLHS())) { 3198323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 3199372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 <=" << "true" << HasEnumType(E->getRHS()) 3200323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 3201323ed74658bc8375278eabf074b4777458376540John McCall } 3202323ed74658bc8375278eabf074b4777458376540John McCall} 3203323ed74658bc8375278eabf074b4777458376540John McCall 3204323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison. Implements the 3205323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison. 3206323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 3207b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 3208b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 3209323ed74658bc8375278eabf074b4777458376540John McCall} 3210f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3211ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare. 3212ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// 3213dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu/// \param E the binary operator to check for warnings 3214323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeComparison(Sema &S, BinaryOperator *E) { 3215323ed74658bc8375278eabf074b4777458376540John McCall // The type the comparison is being performed in. 3216323ed74658bc8375278eabf074b4777458376540John McCall QualType T = E->getLHS()->getType(); 3217323ed74658bc8375278eabf074b4777458376540John McCall assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 3218323ed74658bc8375278eabf074b4777458376540John McCall && "comparison with mismatched types"); 3219323ed74658bc8375278eabf074b4777458376540John McCall 3220323ed74658bc8375278eabf074b4777458376540John McCall // We don't do anything special if this isn't an unsigned integral 3221323ed74658bc8375278eabf074b4777458376540John McCall // comparison: we're only interested in integral comparisons, and 3222323ed74658bc8375278eabf074b4777458376540John McCall // signed comparisons only happen in cases we don't care to warn about. 32233e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // 32243e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // We also don't care about value-dependent expressions or expressions 32253e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // whose result is a constant. 32263e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor if (!T->hasUnsignedIntegerRepresentation() 32273e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor || E->isValueDependent() || E->isIntegerConstantExpr(S.Context)) 3228323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 3229323ed74658bc8375278eabf074b4777458376540John McCall 3230dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr *LHS = E->getLHS()->IgnoreParenImpCasts(); 3231dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr *RHS = E->getRHS()->IgnoreParenImpCasts(); 3232323ed74658bc8375278eabf074b4777458376540John McCall 3233323ed74658bc8375278eabf074b4777458376540John McCall // Check to see if one of the (unmodified) operands is of different 3234323ed74658bc8375278eabf074b4777458376540John McCall // signedness. 3235323ed74658bc8375278eabf074b4777458376540John McCall Expr *signedOperand, *unsignedOperand; 3236dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu if (LHS->getType()->hasSignedIntegerRepresentation()) { 3237dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu assert(!RHS->getType()->hasSignedIntegerRepresentation() && 3238323ed74658bc8375278eabf074b4777458376540John McCall "unsigned comparison between two signed integer expressions?"); 3239dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = LHS; 3240dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = RHS; 3241dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu } else if (RHS->getType()->hasSignedIntegerRepresentation()) { 3242dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = RHS; 3243dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = LHS; 3244ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } else { 3245323ed74658bc8375278eabf074b4777458376540John McCall CheckTrivialUnsignedComparison(S, E); 3246323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 3247ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } 3248ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3249323ed74658bc8375278eabf074b4777458376540John McCall // Otherwise, calculate the effective range of the signed operand. 3250323ed74658bc8375278eabf074b4777458376540John McCall IntRange signedRange = GetExprRange(S.Context, signedOperand); 3251f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3252323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and analyze implicit conversions in the operands. Note 3253323ed74658bc8375278eabf074b4777458376540John McCall // that we skip the implicit conversions on both sides. 3254dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc()); 3255dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc()); 3256ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3257323ed74658bc8375278eabf074b4777458376540John McCall // If the signed range is non-negative, -Wsign-compare won't fire, 3258323ed74658bc8375278eabf074b4777458376540John McCall // but we should still check for comparisons which are always true 3259323ed74658bc8375278eabf074b4777458376540John McCall // or false. 3260323ed74658bc8375278eabf074b4777458376540John McCall if (signedRange.NonNegative) 3261323ed74658bc8375278eabf074b4777458376540John McCall return CheckTrivialUnsignedComparison(S, E); 3262ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3263ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // For (in)equality comparisons, if the unsigned operand is a 3264ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // constant which cannot collide with a overflowed signed operand, 3265ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // then reinterpreting the signed operand as unsigned will not 3266ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // change the result of the comparison. 3267323ed74658bc8375278eabf074b4777458376540John McCall if (E->isEqualityOp()) { 3268323ed74658bc8375278eabf074b4777458376540John McCall unsigned comparisonWidth = S.Context.getIntWidth(T); 3269323ed74658bc8375278eabf074b4777458376540John McCall IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 3270323ed74658bc8375278eabf074b4777458376540John McCall 3271323ed74658bc8375278eabf074b4777458376540John McCall // We should never be unable to prove that the unsigned operand is 3272323ed74658bc8375278eabf074b4777458376540John McCall // non-negative. 3273323ed74658bc8375278eabf074b4777458376540John McCall assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 3274ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3275323ed74658bc8375278eabf074b4777458376540John McCall if (unsignedRange.Width < comparisonWidth) 3276323ed74658bc8375278eabf074b4777458376540John McCall return; 3277323ed74658bc8375278eabf074b4777458376540John McCall } 3278323ed74658bc8375278eabf074b4777458376540John McCall 3279323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison) 3280dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu << LHS->getType() << RHS->getType() 3281dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu << LHS->getSourceRange() << RHS->getSourceRange(); 3282ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall} 3283ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 328415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield. 328515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// 328615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt. 328715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallbool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 328815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall SourceLocation InitLoc) { 328915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall assert(Bitfield->isBitField()); 329015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Bitfield->isInvalidDecl()) 329115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 329215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 329391b6014876e9186f968f74a8975ab8fc08ef1b68John McCall // White-list bool bitfields. 329491b6014876e9186f968f74a8975ab8fc08ef1b68John McCall if (Bitfield->getType()->isBooleanType()) 329591b6014876e9186f968f74a8975ab8fc08ef1b68John McCall return false; 329691b6014876e9186f968f74a8975ab8fc08ef1b68John McCall 329746ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor // Ignore value- or type-dependent expressions. 329846ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor if (Bitfield->getBitWidth()->isValueDependent() || 329946ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Bitfield->getBitWidth()->isTypeDependent() || 330046ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isValueDependent() || 330146ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isTypeDependent()) 330246ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor return false; 330346ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor 330415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *OriginalInit = Init->IgnoreParenImpCasts(); 330515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 330615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr::EvalResult InitValue; 3307a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith if (!OriginalInit->Evaluate(InitValue, S.Context) || 330815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall !InitValue.Val.isInt()) 330915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 331015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 331115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall const llvm::APSInt &Value = InitValue.Val.getInt(); 331215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned OriginalWidth = Value.getBitWidth(); 3313a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context); 331415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 331515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (OriginalWidth <= FieldWidth) 331615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 331715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 33189f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad llvm::APSInt TruncatedValue = Value.trunc(FieldWidth); 331915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 332015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // It's fairly common to write values into signed bitfields 332115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // that, if sign-extended, would end up becoming a different 332215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // value. We don't want to warn about that. 332315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value.isSigned() && Value.isNegative()) 33249f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad TruncatedValue = TruncatedValue.sext(OriginalWidth); 332515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall else 33269f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad TruncatedValue = TruncatedValue.zext(OriginalWidth); 332715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 332815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value == TruncatedValue) 332915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 333015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 333115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyValue = Value.toString(10); 333215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyTrunc = TruncatedValue.toString(10); 333315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 333415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 333515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << PrettyValue << PrettyTrunc << OriginalInit->getType() 333615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << Init->getSourceRange(); 333715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 333815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return true; 333915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 334015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 3341beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy 3342beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations. 3343beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCallvoid AnalyzeAssignment(Sema &S, BinaryOperator *E) { 3344beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Just recurse on the LHS. 3345beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 3346beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 3347beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // We want to recurse on the RHS as normal unless we're assigning to 3348beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // a bitfield. 3349beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (FieldDecl *Bitfield = E->getLHS()->getBitField()) { 335015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 335115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc())) { 335215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // Recurse, ignoring any implicit conversions on the RHS. 335315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 335415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc()); 3355beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 3356beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 3357beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 3358beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 3359beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall} 3360beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 336151313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 33625a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregorvoid DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T, 33635a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceLocation CContext, unsigned diag) { 33645a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor S.Diag(E->getExprLoc(), diag) 33655a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor << SourceType << T << E->getSourceRange() << SourceRange(CContext); 33665a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor} 33675a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 3368e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 3369e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruthvoid DiagnoseImpCast(Sema &S, Expr *E, QualType T, SourceLocation CContext, 3370e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth unsigned diag) { 3371e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth DiagnoseImpCast(S, E, E->getType(), T, CContext, diag); 3372e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth} 3373e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth 33749ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// Diagnose an implicit cast from a literal expression. Does not warn when the 33759ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// cast wouldn't lose information. 3376f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruthvoid DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T, 3377f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth SourceLocation CContext) { 33789ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay // Try to convert the literal exactly to an integer. If we can, don't warn. 3379f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth bool isExact = false; 33809ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay const llvm::APFloat &Value = FL->getValue(); 33813e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin llvm::APSInt IntegerValue(S.Context.getIntWidth(T), 33823e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin T->hasUnsignedIntegerRepresentation()); 33833e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin if (Value.convertToInteger(IntegerValue, 3384f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth llvm::APFloat::rmTowardZero, &isExact) 33859ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay == llvm::APFloat::opOK && isExact) 3386f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth return; 3387f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 33889ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer) 33899ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay << FL->getType() << T << FL->getSourceRange() << SourceRange(CContext); 3390f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth} 3391f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 3392091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 3393091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Range.Width) return "0"; 3394091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3395091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt ValueInRange = Value; 3396091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.setIsSigned(!Range.NonNegative); 33979f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad ValueInRange = ValueInRange.trunc(Range.Width); 3398091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return ValueInRange.toString(10); 3399091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall} 3400091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3401ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenekstatic bool isFromSystemMacro(Sema &S, SourceLocation loc) { 3402ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceManager &smgr = S.Context.getSourceManager(); 3403ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return loc.isMacroID() && smgr.isInSystemHeader(smgr.getSpellingLoc(loc)); 3404ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek} 3405f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 3406323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T, 3407b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool *ICContext = 0) { 3408323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) return; 340951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3410323ed74658bc8375278eabf074b4777458376540John McCall const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 3411323ed74658bc8375278eabf074b4777458376540John McCall const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 3412323ed74658bc8375278eabf074b4777458376540John McCall if (Source == Target) return; 3413323ed74658bc8375278eabf074b4777458376540John McCall if (Target->isDependentType()) return; 341451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3415108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // If the conversion context location is invalid don't complain. We also 3416108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // don't want to emit a warning if the issue occurs from the expansion of 3417108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // a system macro. The problem is that 'getSpellingLoc()' is slow, so we 3418108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // delay this check as long as possible. Once we detect we are in that 3419108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // scenario, we just return. 3420ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (CC.isInvalid()) 3421b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return; 3422b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 3423f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Diagnose implicit casts to bool. 3424f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (Target->isSpecificBuiltinType(BuiltinType::Bool)) { 3425f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (isa<StringLiteral>(E)) 3426f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Warn on string literal to bool. Checks for string literals in logical 3427f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // expressions, for instances, assert(0 && "error here"), is prevented 3428f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // by a check in AnalyzeImplicitConversions(). 3429f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu return DiagnoseImpCast(S, E, T, CC, 3430f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu diag::warn_impcast_string_literal_to_bool); 3431e37cdc42bf7298a974dfdfa9c03ef11398e7c889David Blaikie return; // Other casts to bool are not checked. 3432f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 343351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 343451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip vector types. 343551313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<VectorType>(Source)) { 3436ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<VectorType>(Target)) { 3437ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3438ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3439b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 3440ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 3441b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner 3442b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // If the vector cast is cast between two vectors of the same size, it is 3443b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // a bitcast, not a conversion. 3444b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target)) 3445b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner return; 344651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 344751313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 344851313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 344951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 345051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 345151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip complex types. 345251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<ComplexType>(Source)) { 3453ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<ComplexType>(Target)) { 3454ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3455ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3456ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3457b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 3458ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 345951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 346051313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 346151313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 346251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 346351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 346451313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 346551313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 346651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 346751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the source is floating point... 346851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT && SourceBT->isFloatingPoint()) { 346951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...and the target is floating point... 347051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (TargetBT && TargetBT->isFloatingPoint()) { 347151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...then warn if we're dropping FP rank. 347251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 347351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Builtin FP kinds are ordered by increasing FP rank. 347451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT->getKind() > TargetBT->getKind()) { 347551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Don't warn about float constants that are precisely 347651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // representable in the target type. 347751313c39c84407dd6a323be99a8c322bf8d052a9John McCall Expr::EvalResult result; 3478323ed74658bc8375278eabf074b4777458376540John McCall if (E->Evaluate(result, S.Context)) { 347951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Value might be a float, a float vector, or a float complex. 348051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (IsSameFloatAfterCast(result.Val, 3481323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 3482323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 348351313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 348451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 348551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3486ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3487ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3488ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3489b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 349051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 349151313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 349251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 349351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3494ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // If the target is integral, always warn. 3495a5b9332418f25338f118358e27303cd510d54107Chandler Carruth if ((TargetBT && TargetBT->isInteger())) { 3496ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3497ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3498ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3499a5b9332418f25338f118358e27303cd510d54107Chandler Carruth Expr *InnerE = E->IgnoreParenImpCasts(); 3500634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay // We also want to warn on, e.g., "int i = -1.234" 3501634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE)) 3502634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus) 3503634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay InnerE = UOp->getSubExpr()->IgnoreParenImpCasts(); 3504634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay 3505f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) { 3506f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth DiagnoseFloatingLiteralImpCast(S, FL, T, CC); 3507a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } else { 3508a5b9332418f25338f118358e27303cd510d54107Chandler Carruth DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 3509a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 3510a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 351151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 351251313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 351351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 351451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3515f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!Source->isIntegerType() || !Target->isIntegerType()) 351651313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 351751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 35181838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull) 35191838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu == Expr::NPCK_GNUNull) && Target->isIntegerType()) { 35201838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu S.Diag(E->getExprLoc(), diag::warn_impcast_null_pointer_to_integer) 35211838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu << E->getSourceRange() << clang::SourceRange(CC); 35221838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu return; 35231838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu } 35241838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu 3525323ed74658bc8375278eabf074b4777458376540John McCall IntRange SourceRange = GetExprRange(S.Context, E); 35261844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 352751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3528f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width > TargetRange.Width) { 3529091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // If the source is a constant, use a default-on diagnostic. 3530091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // TODO: this should happen for bitfield stores, too. 3531091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt Value(32); 3532091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (E->isIntegerConstantExpr(Value, S.Context)) { 3533ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3534ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3535ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3536091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettySourceValue = Value.toString(10); 3537091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 3538091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 35395e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.DiagRuntimeBehavior(E->getExprLoc(), E, 35405e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.PDiag(diag::warn_impcast_integer_precision_constant) 35415e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << PrettySourceValue << PrettyTargetValue 35425e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << E->getType() << T << E->getSourceRange() 35435e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << clang::SourceRange(CC)); 3544091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return; 3545091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall } 3546091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3547b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // People want to build with -Wshorten-64-to-32 and not -Wconversion. 3548ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3549ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3550ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3551f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width == 64 && TargetRange.Width == 32) 3552b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32); 3553b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 3554323ed74658bc8375278eabf074b4777458376540John McCall } 3555323ed74658bc8375278eabf074b4777458376540John McCall 3556323ed74658bc8375278eabf074b4777458376540John McCall if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 3557323ed74658bc8375278eabf074b4777458376540John McCall (!TargetRange.NonNegative && SourceRange.NonNegative && 3558323ed74658bc8375278eabf074b4777458376540John McCall SourceRange.Width == TargetRange.Width)) { 3559ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3560ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3561ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3562ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3563323ed74658bc8375278eabf074b4777458376540John McCall unsigned DiagID = diag::warn_impcast_integer_sign; 3564323ed74658bc8375278eabf074b4777458376540John McCall 3565323ed74658bc8375278eabf074b4777458376540John McCall // Traditionally, gcc has warned about this under -Wsign-compare. 3566323ed74658bc8375278eabf074b4777458376540John McCall // We also want to warn about it in -Wconversion. 3567323ed74658bc8375278eabf074b4777458376540John McCall // So if -Wconversion is off, use a completely identical diagnostic 3568323ed74658bc8375278eabf074b4777458376540John McCall // in the sign-compare group. 3569323ed74658bc8375278eabf074b4777458376540John McCall // The conditional-checking code will 3570323ed74658bc8375278eabf074b4777458376540John McCall if (ICContext) { 3571323ed74658bc8375278eabf074b4777458376540John McCall DiagID = diag::warn_impcast_integer_sign_conditional; 3572323ed74658bc8375278eabf074b4777458376540John McCall *ICContext = true; 3573323ed74658bc8375278eabf074b4777458376540John McCall } 3574323ed74658bc8375278eabf074b4777458376540John McCall 3575b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, DiagID); 357651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 357751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3578284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor // Diagnose conversions between different enumeration types. 35795a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // In C, we pretend that the type of an EnumConstantDecl is its enumeration 35805a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // type, to give us better diagnostics. 35815a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor QualType SourceType = E->getType(); 35825a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (!S.getLangOptions().CPlusPlus) { 35835a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 35845a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) { 35855a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext()); 35865a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceType = S.Context.getTypeDeclType(Enum); 35875a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor Source = S.Context.getCanonicalType(SourceType).getTypePtr(); 35885a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 35895a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 35905a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 3591284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *SourceEnum = Source->getAs<EnumType>()) 3592284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *TargetEnum = Target->getAs<EnumType>()) 3593284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if ((SourceEnum->getDecl()->getIdentifier() || 3594162e1c1b487352434552147967c3dd296ebee2f7Richard Smith SourceEnum->getDecl()->getTypedefNameForAnonDecl()) && 3595284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor (TargetEnum->getDecl()->getIdentifier() || 3596162e1c1b487352434552147967c3dd296ebee2f7Richard Smith TargetEnum->getDecl()->getTypedefNameForAnonDecl()) && 3597ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceEnum != TargetEnum) { 3598ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3599ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3600ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 36015a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor return DiagnoseImpCast(S, E, SourceType, T, CC, 3602284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor diag::warn_impcast_different_enum_types); 3603ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 3604284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor 360551313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 360651313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 360751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3608323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T); 3609323ed74658bc8375278eabf074b4777458376540John McCall 3610323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T, 3611b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool &ICContext) { 3612323ed74658bc8375278eabf074b4777458376540John McCall E = E->IgnoreParenImpCasts(); 3613323ed74658bc8375278eabf074b4777458376540John McCall 3614323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) 3615323ed74658bc8375278eabf074b4777458376540John McCall return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T); 3616323ed74658bc8375278eabf074b4777458376540John McCall 3617b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E, CC); 3618323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 3619b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return CheckImplicitConversion(S, E, T, CC, &ICContext); 3620323ed74658bc8375278eabf074b4777458376540John McCall return; 3621323ed74658bc8375278eabf074b4777458376540John McCall} 3622323ed74658bc8375278eabf074b4777458376540John McCall 3623323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) { 3624b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC = E->getQuestionLoc(); 3625b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 3626b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getCond(), CC); 3627323ed74658bc8375278eabf074b4777458376540John McCall 3628323ed74658bc8375278eabf074b4777458376540John McCall bool Suspicious = false; 3629b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 3630b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 3631323ed74658bc8375278eabf074b4777458376540John McCall 3632323ed74658bc8375278eabf074b4777458376540John McCall // If -Wconversion would have warned about either of the candidates 3633323ed74658bc8375278eabf074b4777458376540John McCall // for a signedness conversion to the context type... 3634323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) return; 3635323ed74658bc8375278eabf074b4777458376540John McCall 3636323ed74658bc8375278eabf074b4777458376540John McCall // ...but it's currently ignored... 36370827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional, 36380827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis CC)) 3639323ed74658bc8375278eabf074b4777458376540John McCall return; 3640323ed74658bc8375278eabf074b4777458376540John McCall 3641323ed74658bc8375278eabf074b4777458376540John McCall // ...then check whether it would have warned about either of the 3642323ed74658bc8375278eabf074b4777458376540John McCall // candidates for a signedness conversion to the condition type. 36435254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (E->getType() == T) return; 36445254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu 36455254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu Suspicious = false; 36465254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 36475254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu E->getType(), CC, &Suspicious); 36485254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (!Suspicious) 36495254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 3650b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 3651323ed74658bc8375278eabf074b4777458376540John McCall} 3652323ed74658bc8375278eabf074b4777458376540John McCall 3653323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting 3654323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression. There are a couple 3655323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare. 3656b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 3657323ed74658bc8375278eabf074b4777458376540John McCall QualType T = OrigE->getType(); 3658323ed74658bc8375278eabf074b4777458376540John McCall Expr *E = OrigE->IgnoreParenImpCasts(); 3659323ed74658bc8375278eabf074b4777458376540John McCall 3660f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 3661f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor return; 3662f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor 3663323ed74658bc8375278eabf074b4777458376540John McCall // For conditional operators, we analyze the arguments as if they 3664323ed74658bc8375278eabf074b4777458376540John McCall // were being fed directly into the output. 3665323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) { 3666323ed74658bc8375278eabf074b4777458376540John McCall ConditionalOperator *CO = cast<ConditionalOperator>(E); 3667323ed74658bc8375278eabf074b4777458376540John McCall CheckConditionalOperator(S, CO, T); 3668323ed74658bc8375278eabf074b4777458376540John McCall return; 3669323ed74658bc8375278eabf074b4777458376540John McCall } 3670323ed74658bc8375278eabf074b4777458376540John McCall 3671323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and check any implicit conversions we might have skipped. 3672323ed74658bc8375278eabf074b4777458376540John McCall // The non-canonical typecheck is just an optimization; 3673323ed74658bc8375278eabf074b4777458376540John McCall // CheckImplicitConversion will filter out dead implicit conversions. 3674323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 3675b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckImplicitConversion(S, E, T, CC); 3676323ed74658bc8375278eabf074b4777458376540John McCall 3677323ed74658bc8375278eabf074b4777458376540John McCall // Now continue drilling into this expression. 3678323ed74658bc8375278eabf074b4777458376540John McCall 3679323ed74658bc8375278eabf074b4777458376540John McCall // Skip past explicit casts. 3680323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ExplicitCastExpr>(E)) { 3681323ed74658bc8375278eabf074b4777458376540John McCall E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 3682b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return AnalyzeImplicitConversions(S, E, CC); 3683323ed74658bc8375278eabf074b4777458376540John McCall } 3684323ed74658bc8375278eabf074b4777458376540John McCall 3685beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 3686beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Do a somewhat different check with comparison operators. 3687beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isComparisonOp()) 3688beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeComparison(S, BO); 3689beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 3690beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // And with assignments and compound assignments. 3691beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isAssignmentOp()) 3692beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeAssignment(S, BO); 3693beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 3694323ed74658bc8375278eabf074b4777458376540John McCall 3695323ed74658bc8375278eabf074b4777458376540John McCall // These break the otherwise-useful invariant below. Fortunately, 3696323ed74658bc8375278eabf074b4777458376540John McCall // we don't really need to recurse into them, because any internal 3697323ed74658bc8375278eabf074b4777458376540John McCall // expressions should have been analyzed already when they were 3698323ed74658bc8375278eabf074b4777458376540John McCall // built into statements. 3699323ed74658bc8375278eabf074b4777458376540John McCall if (isa<StmtExpr>(E)) return; 3700323ed74658bc8375278eabf074b4777458376540John McCall 3701323ed74658bc8375278eabf074b4777458376540John McCall // Don't descend into unevaluated contexts. 3702f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne if (isa<UnaryExprOrTypeTraitExpr>(E)) return; 3703323ed74658bc8375278eabf074b4777458376540John McCall 3704323ed74658bc8375278eabf074b4777458376540John McCall // Now just recurse over the expression's children. 3705b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CC = E->getExprLoc(); 3706f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu BinaryOperator *BO = dyn_cast<BinaryOperator>(E); 3707f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu bool IsLogicalOperator = BO && BO->isLogicalOp(); 3708f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu for (Stmt::child_range I = E->children(); I; ++I) { 3709f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu Expr *ChildExpr = cast<Expr>(*I); 3710f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (IsLogicalOperator && 3711f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts())) 3712f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Ignore checking string literals that are in logical operators. 3713f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu continue; 3714f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu AnalyzeImplicitConversions(S, ChildExpr, CC); 3715f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 3716323ed74658bc8375278eabf074b4777458376540John McCall} 3717323ed74658bc8375278eabf074b4777458376540John McCall 3718323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace 3719323ed74658bc8375278eabf074b4777458376540John McCall 3720323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given 3721323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression). Implements -Wconversion 3722323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare. 3723b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// 3724b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e. 3725b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// the most location of the syntactic entity requiring the implicit 3726b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// conversion 3727b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 3728323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose in unevaluated contexts. 3729323ed74658bc8375278eabf074b4777458376540John McCall if (ExprEvalContexts.back().Context == Sema::Unevaluated) 3730323ed74658bc8375278eabf074b4777458376540John McCall return; 3731323ed74658bc8375278eabf074b4777458376540John McCall 3732323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose for value- or type-dependent expressions. 3733323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) 3734323ed74658bc8375278eabf074b4777458376540John McCall return; 3735323ed74658bc8375278eabf074b4777458376540John McCall 3736d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Check for array bounds violations in cases where the check isn't triggered 3737d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // elsewhere for other Expr types (like BinaryOperators), e.g. when an 3738d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // ArraySubscriptExpr is on the RHS of a variable initialization. 3739d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain CheckArrayAccess(E); 3740d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 3741b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // This is not the right CC for (e.g.) a variable initialization. 3742b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(*this, E, CC); 3743323ed74658bc8375278eabf074b4777458376540John McCall} 3744323ed74658bc8375278eabf074b4777458376540John McCall 374515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 374615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall FieldDecl *BitField, 374715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *Init) { 374815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 374915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 375015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 3751f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given 3752f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This 3753f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the 3754f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function 3755f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete. 375682aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregorbool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd, 375782aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor bool CheckParameterNames) { 3758f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump bool HasInvalidParm = false; 375982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor for (; P != PEnd; ++P) { 376082aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor ParmVarDecl *Param = *P; 376182aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor 3762f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.7.5.3p4: the parameters in a parameter type list in a 3763f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // function declarator that is part of a function definition of 3764f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // that function shall not have incomplete type. 3765f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // 3766f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // This is also C++ [dcl.fct]p6. 3767f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump if (!Param->isInvalidDecl() && 3768f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump RequireCompleteType(Param->getLocation(), Param->getType(), 3769f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump diag::err_typecheck_decl_incomplete_type)) { 3770f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Param->setInvalidDecl(); 3771f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump HasInvalidParm = true; 3772f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 3773f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 3774f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.9.1p5: If the declarator includes a parameter type list, the 3775f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // declaration of each parameter shall include an identifier. 377682aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor if (CheckParameterNames && 377782aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor Param->getIdentifier() == 0 && 3778f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !Param->isImplicit() && 3779f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !getLangOptions().CPlusPlus) 3780f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Diag(Param->getLocation(), diag::err_parameter_name_omitted); 3781d17e340e2d516139931768697bf080f60920ba9dSam Weinig 3782d17e340e2d516139931768697bf080f60920ba9dSam Weinig // C99 6.7.5.3p12: 3783d17e340e2d516139931768697bf080f60920ba9dSam Weinig // If the function declarator is not part of a definition of that 3784d17e340e2d516139931768697bf080f60920ba9dSam Weinig // function, parameters may have incomplete type and may use the [*] 3785d17e340e2d516139931768697bf080f60920ba9dSam Weinig // notation in their sequences of declarator specifiers to specify 3786d17e340e2d516139931768697bf080f60920ba9dSam Weinig // variable length array types. 3787d17e340e2d516139931768697bf080f60920ba9dSam Weinig QualType PType = Param->getOriginalType(); 3788d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (const ArrayType *AT = Context.getAsArrayType(PType)) { 3789d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (AT->getSizeModifier() == ArrayType::Star) { 3790d17e340e2d516139931768697bf080f60920ba9dSam Weinig // FIXME: This diagnosic should point the the '[*]' if source-location 3791d17e340e2d516139931768697bf080f60920ba9dSam Weinig // information is added for it. 3792d17e340e2d516139931768697bf080f60920ba9dSam Weinig Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 3793d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 3794d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 3795f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 3796f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 3797f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump return HasInvalidParm; 3798f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump} 3799b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3800b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a 3801b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements. 3802b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 3803b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // This is actually a lot of work to potentially be doing on every 3804b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // cast; don't do it if we're ignoring -Wcast_align (as is the default). 38050827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align, 38060827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis TRange.getBegin()) 3807d6471f7c1921c7802804ce3ff6fe9768310f72b9David Blaikie == DiagnosticsEngine::Ignored) 3808b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 3809b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3810b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Ignore dependent types. 3811b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (T->isDependentType() || Op->getType()->isDependentType()) 3812b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 3813b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3814b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the destination be a pointer type. 3815b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *DestPtr = T->getAs<PointerType>(); 3816b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!DestPtr) return; 3817b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3818b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // If the destination has alignment 1, we're done. 3819b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType DestPointee = DestPtr->getPointeeType(); 3820b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestPointee->isIncompleteType()) return; 3821b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 3822b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestAlign.isOne()) return; 3823b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3824b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the source be a pointer type. 3825b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 3826b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!SrcPtr) return; 3827b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType SrcPointee = SrcPtr->getPointeeType(); 3828b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3829b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Whitelist casts from cv void*. We already implicitly 3830b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // whitelisted casts to cv void*, since they have alignment 1. 3831b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Also whitelist casts involving incomplete types, which implicitly 3832b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // includes 'void'. 3833b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcPointee->isIncompleteType()) return; 3834b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3835b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 3836b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcAlign >= DestAlign) return; 3837b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3838b7f4ffe073fa419613946461a2583ba2fcb72280John McCall Diag(TRange.getBegin(), diag::warn_cast_align) 3839b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << Op->getType() << T 3840b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(SrcAlign.getQuantity()) 3841b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(DestAlign.getQuantity()) 3842b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << TRange << Op->getSourceRange(); 3843b7f4ffe073fa419613946461a2583ba2fcb72280John McCall} 3844b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3845d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainstatic const Type* getElementType(const Expr *BaseExpr) { 3846d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* EltType = BaseExpr->getType().getTypePtr(); 3847d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (EltType->isAnyPointerType()) 3848d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getPointeeType().getTypePtr(); 3849d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain else if (EltType->isArrayType()) 3850d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getBaseElementTypeUnsafe(); 3851d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType; 3852d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain} 3853d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 3854c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// \brief Check whether this array fits the idiom of a size-one tail padded 3855c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// array member of a struct. 3856c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// 3857c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// We avoid emitting out-of-bounds access warnings for such arrays as they are 3858c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// commonly used to emulate flexible arrays in C89 code. 3859c268434b332bbe57950d977633369bf5822d9554Chandler Carruthstatic bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size, 3860c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const NamedDecl *ND) { 3861c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (Size != 1 || !ND) return false; 3862c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 3863c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const FieldDecl *FD = dyn_cast<FieldDecl>(ND); 3864c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!FD) return false; 3865c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 3866c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // Don't consider sizes resulting from macro expansions or template argument 3867c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // substitution to form C89 tail-padded arrays. 3868c268434b332bbe57950d977633369bf5822d9554Chandler Carruth ConstantArrayTypeLoc TL = 3869c268434b332bbe57950d977633369bf5822d9554Chandler Carruth cast<ConstantArrayTypeLoc>(FD->getTypeSourceInfo()->getTypeLoc()); 3870c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const Expr *SizeExpr = dyn_cast<IntegerLiteral>(TL.getSizeExpr()); 3871c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!SizeExpr || SizeExpr->getExprLoc().isMacroID()) 3872c268434b332bbe57950d977633369bf5822d9554Chandler Carruth return false; 3873c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 3874c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext()); 3875c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!RD || !RD->isStruct()) 3876c268434b332bbe57950d977633369bf5822d9554Chandler Carruth return false; 3877c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 387822d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer // See if this is the last field decl in the record. 387922d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer const Decl *D = FD; 388022d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer while ((D = D->getNextDeclInContext())) 388122d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer if (isa<FieldDecl>(D)) 388222d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return false; 388322d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return true; 3884c268434b332bbe57950d977633369bf5822d9554Chandler Carruth} 3885c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 3886d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainvoid Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr, 3887d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain bool isSubscript, bool AllowOnePastEnd) { 3888d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* EffectiveType = getElementType(BaseExpr); 3889d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain BaseExpr = BaseExpr->IgnoreParenCasts(); 3890d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain IndexExpr = IndexExpr->IgnoreParenCasts(); 3891d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 38923406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const ConstantArrayType *ArrayTy = 3893d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain Context.getAsConstantArrayType(BaseExpr->getType()); 38943406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (!ArrayTy) 3895a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 389635001ca261f895817916b468379b696d6d45959dChandler Carruth 38973406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (IndexExpr->isValueDependent()) 3898a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 38993406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth llvm::APSInt index; 3900d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (!IndexExpr->isIntegerConstantExpr(index, Context)) 3901a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 39028fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek 3903ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth const NamedDecl *ND = NULL; 3904ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 3905ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(DRE->getDecl()); 3906c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 3907ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 3908ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 39099e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek if (index.isUnsigned() || !index.isNegative()) { 391025b3b849e3ad340b04442707038c86980035765bTed Kremenek llvm::APInt size = ArrayTy->getSize(); 391135001ca261f895817916b468379b696d6d45959dChandler Carruth if (!size.isStrictlyPositive()) 391235001ca261f895817916b468379b696d6d45959dChandler Carruth return; 3913d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 3914d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* BaseType = getElementType(BaseExpr); 3915de5998f1d7dcecb777257ec932142d65de636eb8Nico Weber if (BaseType != EffectiveType) { 3916d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Make sure we're comparing apples to apples when comparing index to size 3917d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType); 3918d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t array_typesize = Context.getTypeSize(BaseType); 3919d10f4bc5a05ce0cdc1646dbb0f706bb9d3dfc0c5Kaelyn Uhrain // Handle ptrarith_typesize being zero, such as when casting to void* 392018f169770d9d3f826bad8f1359c8c5770c5ab16fKaelyn Uhrain if (!ptrarith_typesize) ptrarith_typesize = 1; 3921d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize != array_typesize) { 3922d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // There's a cast to a different size type involved 3923d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ratio = array_typesize / ptrarith_typesize; 3924d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // TODO: Be smarter about handling cases where array_typesize is not a 3925d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // multiple of ptrarith_typesize 3926d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize * ratio == array_typesize) 3927d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain size *= llvm::APInt(size.getBitWidth(), ratio); 3928d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 3929d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 3930d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 39313406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (size.getBitWidth() > index.getBitWidth()) 39323406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth index = index.sext(size.getBitWidth()); 393325b3b849e3ad340b04442707038c86980035765bTed Kremenek else if (size.getBitWidth() < index.getBitWidth()) 393425b3b849e3ad340b04442707038c86980035765bTed Kremenek size = size.sext(index.getBitWidth()); 393525b3b849e3ad340b04442707038c86980035765bTed Kremenek 3936d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // For array subscripting the index must be less than size, but for pointer 3937d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // arithmetic also allow the index (offset) to be equal to size since 3938d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // computing the next address after the end of the array is legal and 3939d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // commonly done e.g. in C++ iterators and range-based for loops. 3940d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (AllowOnePastEnd ? index.sle(size) : index.slt(size)) 3941ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth return; 3942ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 3943ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // Also don't warn for arrays of size 1 which are members of some 3944ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // structure. These are often used to approximate flexible arrays in C89 3945ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // code. 3946d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (IsTailPaddedMemberArray(*this, size, ND)) 39478fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek return; 39483406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth 3949d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds; 3950d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (isSubscript) 3951d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_array_index_exceeds_bounds; 3952d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 3953d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 3954d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 3955d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << size.toString(10, true) 3956d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << (unsigned)size.getLimitedValue(~0U) 3957d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 39583406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth } else { 3959d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_array_index_precedes_bounds; 3960d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (!isSubscript) { 3961d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_ptr_arith_precedes_bounds; 3962d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (index.isNegative()) index = -index; 3963d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 3964d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 3965d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 3966d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 3967d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 3968a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek } 396935001ca261f895817916b468379b696d6d45959dChandler Carruth 397035001ca261f895817916b468379b696d6d45959dChandler Carruth if (ND) 3971d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(ND->getLocStart(), BaseExpr, 3972d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(diag::note_array_index_out_of_bounds) 3973d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << ND->getDeclName()); 39743aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek} 39753aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek 39763aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) { 3977d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain int AllowOnePastEnd = 0; 3978d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain while (expr) { 3979d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = expr->IgnoreParenImpCasts(); 39803aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek switch (expr->getStmtClass()) { 3981d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::ArraySubscriptExprClass: { 3982d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr); 3983d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain CheckArrayAccess(ASE->getBase(), ASE->getIdx(), true, 3984d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd > 0); 39853aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 3986d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 3987d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::UnaryOperatorClass: { 3988d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Only unwrap the * and & unary operators 3989d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const UnaryOperator *UO = cast<UnaryOperator>(expr); 3990d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = UO->getSubExpr(); 3991d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain switch (UO->getOpcode()) { 3992d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_AddrOf: 3993d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd++; 3994d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 3995d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_Deref: 3996d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd--; 3997d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 3998d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain default: 3999d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return; 4000d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 4001d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 4002d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 40033aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek case Stmt::ConditionalOperatorClass: { 40043aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek const ConditionalOperator *cond = cast<ConditionalOperator>(expr); 40053aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *lhs = cond->getLHS()) 40063aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(lhs); 40073aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *rhs = cond->getRHS()) 40083aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(rhs); 40093aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 40103aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 40113aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek default: 40123aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 40133aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 4014f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne } 4015a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek} 4016f85e193739c953358c865005855253af4f68a497John McCall 4017f85e193739c953358c865005855253af4f68a497John McCall//===--- CHECK: Objective-C retain cycles ----------------------------------// 4018f85e193739c953358c865005855253af4f68a497John McCall 4019f85e193739c953358c865005855253af4f68a497John McCallnamespace { 4020f85e193739c953358c865005855253af4f68a497John McCall struct RetainCycleOwner { 4021f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner() : Variable(0), Indirect(false) {} 4022f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 4023f85e193739c953358c865005855253af4f68a497John McCall SourceRange Range; 4024f85e193739c953358c865005855253af4f68a497John McCall SourceLocation Loc; 4025f85e193739c953358c865005855253af4f68a497John McCall bool Indirect; 4026f85e193739c953358c865005855253af4f68a497John McCall 4027f85e193739c953358c865005855253af4f68a497John McCall void setLocsFrom(Expr *e) { 4028f85e193739c953358c865005855253af4f68a497John McCall Loc = e->getExprLoc(); 4029f85e193739c953358c865005855253af4f68a497John McCall Range = e->getSourceRange(); 4030f85e193739c953358c865005855253af4f68a497John McCall } 4031f85e193739c953358c865005855253af4f68a497John McCall }; 4032f85e193739c953358c865005855253af4f68a497John McCall} 4033f85e193739c953358c865005855253af4f68a497John McCall 4034f85e193739c953358c865005855253af4f68a497John McCall/// Consider whether capturing the given variable can possibly lead to 4035f85e193739c953358c865005855253af4f68a497John McCall/// a retain cycle. 4036f85e193739c953358c865005855253af4f68a497John McCallstatic bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) { 4037f85e193739c953358c865005855253af4f68a497John McCall // In ARC, it's captured strongly iff the variable has __strong 4038f85e193739c953358c865005855253af4f68a497John McCall // lifetime. In MRR, it's captured strongly if the variable is 4039f85e193739c953358c865005855253af4f68a497John McCall // __block and has an appropriate type. 4040f85e193739c953358c865005855253af4f68a497John McCall if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 4041f85e193739c953358c865005855253af4f68a497John McCall return false; 4042f85e193739c953358c865005855253af4f68a497John McCall 4043f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = var; 4044f85e193739c953358c865005855253af4f68a497John McCall owner.setLocsFrom(ref); 4045f85e193739c953358c865005855253af4f68a497John McCall return true; 4046f85e193739c953358c865005855253af4f68a497John McCall} 4047f85e193739c953358c865005855253af4f68a497John McCall 4048f85e193739c953358c865005855253af4f68a497John McCallstatic bool findRetainCycleOwner(Expr *e, RetainCycleOwner &owner) { 4049f85e193739c953358c865005855253af4f68a497John McCall while (true) { 4050f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParens(); 4051f85e193739c953358c865005855253af4f68a497John McCall if (CastExpr *cast = dyn_cast<CastExpr>(e)) { 4052f85e193739c953358c865005855253af4f68a497John McCall switch (cast->getCastKind()) { 4053f85e193739c953358c865005855253af4f68a497John McCall case CK_BitCast: 4054f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueBitCast: 4055f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueToRValue: 405633e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall case CK_ARCReclaimReturnedObject: 4057f85e193739c953358c865005855253af4f68a497John McCall e = cast->getSubExpr(); 4058f85e193739c953358c865005855253af4f68a497John McCall continue; 4059f85e193739c953358c865005855253af4f68a497John McCall 4060f85e193739c953358c865005855253af4f68a497John McCall case CK_GetObjCProperty: { 4061f85e193739c953358c865005855253af4f68a497John McCall // Bail out if this isn't a strong explicit property. 4062f85e193739c953358c865005855253af4f68a497John McCall const ObjCPropertyRefExpr *pre = cast->getSubExpr()->getObjCProperty(); 4063f85e193739c953358c865005855253af4f68a497John McCall if (pre->isImplicitProperty()) return false; 4064f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *property = pre->getExplicitProperty(); 4065265941bc308d65cc270d5c4de5806f37ce405606John McCall if (!property->isRetaining() && 4066f85e193739c953358c865005855253af4f68a497John McCall !(property->getPropertyIvarDecl() && 4067f85e193739c953358c865005855253af4f68a497John McCall property->getPropertyIvarDecl()->getType() 4068f85e193739c953358c865005855253af4f68a497John McCall .getObjCLifetime() == Qualifiers::OCL_Strong)) 4069f85e193739c953358c865005855253af4f68a497John McCall return false; 4070f85e193739c953358c865005855253af4f68a497John McCall 4071f85e193739c953358c865005855253af4f68a497John McCall owner.Indirect = true; 4072f85e193739c953358c865005855253af4f68a497John McCall e = const_cast<Expr*>(pre->getBase()); 4073f85e193739c953358c865005855253af4f68a497John McCall continue; 4074f85e193739c953358c865005855253af4f68a497John McCall } 4075f85e193739c953358c865005855253af4f68a497John McCall 4076f85e193739c953358c865005855253af4f68a497John McCall default: 4077f85e193739c953358c865005855253af4f68a497John McCall return false; 4078f85e193739c953358c865005855253af4f68a497John McCall } 4079f85e193739c953358c865005855253af4f68a497John McCall } 4080f85e193739c953358c865005855253af4f68a497John McCall 4081f85e193739c953358c865005855253af4f68a497John McCall if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) { 4082f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar = ref->getDecl(); 4083f85e193739c953358c865005855253af4f68a497John McCall if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 4084f85e193739c953358c865005855253af4f68a497John McCall return false; 4085f85e193739c953358c865005855253af4f68a497John McCall 4086f85e193739c953358c865005855253af4f68a497John McCall // Try to find a retain cycle in the base. 4087f85e193739c953358c865005855253af4f68a497John McCall if (!findRetainCycleOwner(ref->getBase(), owner)) 4088f85e193739c953358c865005855253af4f68a497John McCall return false; 4089f85e193739c953358c865005855253af4f68a497John McCall 4090f85e193739c953358c865005855253af4f68a497John McCall if (ref->isFreeIvar()) owner.setLocsFrom(ref); 4091f85e193739c953358c865005855253af4f68a497John McCall owner.Indirect = true; 4092f85e193739c953358c865005855253af4f68a497John McCall return true; 4093f85e193739c953358c865005855253af4f68a497John McCall } 4094f85e193739c953358c865005855253af4f68a497John McCall 4095f85e193739c953358c865005855253af4f68a497John McCall if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) { 4096f85e193739c953358c865005855253af4f68a497John McCall VarDecl *var = dyn_cast<VarDecl>(ref->getDecl()); 4097f85e193739c953358c865005855253af4f68a497John McCall if (!var) return false; 4098f85e193739c953358c865005855253af4f68a497John McCall return considerVariable(var, ref, owner); 4099f85e193739c953358c865005855253af4f68a497John McCall } 4100f85e193739c953358c865005855253af4f68a497John McCall 4101f85e193739c953358c865005855253af4f68a497John McCall if (BlockDeclRefExpr *ref = dyn_cast<BlockDeclRefExpr>(e)) { 4102f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = ref->getDecl(); 4103f85e193739c953358c865005855253af4f68a497John McCall owner.setLocsFrom(ref); 4104f85e193739c953358c865005855253af4f68a497John McCall return true; 4105f85e193739c953358c865005855253af4f68a497John McCall } 4106f85e193739c953358c865005855253af4f68a497John McCall 4107f85e193739c953358c865005855253af4f68a497John McCall if (MemberExpr *member = dyn_cast<MemberExpr>(e)) { 4108f85e193739c953358c865005855253af4f68a497John McCall if (member->isArrow()) return false; 4109f85e193739c953358c865005855253af4f68a497John McCall 4110f85e193739c953358c865005855253af4f68a497John McCall // Don't count this as an indirect ownership. 4111f85e193739c953358c865005855253af4f68a497John McCall e = member->getBase(); 4112f85e193739c953358c865005855253af4f68a497John McCall continue; 4113f85e193739c953358c865005855253af4f68a497John McCall } 4114f85e193739c953358c865005855253af4f68a497John McCall 4115f85e193739c953358c865005855253af4f68a497John McCall // Array ivars? 4116f85e193739c953358c865005855253af4f68a497John McCall 4117f85e193739c953358c865005855253af4f68a497John McCall return false; 4118f85e193739c953358c865005855253af4f68a497John McCall } 4119f85e193739c953358c865005855253af4f68a497John McCall} 4120f85e193739c953358c865005855253af4f68a497John McCall 4121f85e193739c953358c865005855253af4f68a497John McCallnamespace { 4122f85e193739c953358c865005855253af4f68a497John McCall struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> { 4123f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor(ASTContext &Context, VarDecl *variable) 4124f85e193739c953358c865005855253af4f68a497John McCall : EvaluatedExprVisitor<FindCaptureVisitor>(Context), 4125f85e193739c953358c865005855253af4f68a497John McCall Variable(variable), Capturer(0) {} 4126f85e193739c953358c865005855253af4f68a497John McCall 4127f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 4128f85e193739c953358c865005855253af4f68a497John McCall Expr *Capturer; 4129f85e193739c953358c865005855253af4f68a497John McCall 4130f85e193739c953358c865005855253af4f68a497John McCall void VisitDeclRefExpr(DeclRefExpr *ref) { 4131f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 4132f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 4133f85e193739c953358c865005855253af4f68a497John McCall } 4134f85e193739c953358c865005855253af4f68a497John McCall 4135f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockDeclRefExpr(BlockDeclRefExpr *ref) { 4136f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 4137f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 4138f85e193739c953358c865005855253af4f68a497John McCall } 4139f85e193739c953358c865005855253af4f68a497John McCall 4140f85e193739c953358c865005855253af4f68a497John McCall void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) { 4141f85e193739c953358c865005855253af4f68a497John McCall if (Capturer) return; 4142f85e193739c953358c865005855253af4f68a497John McCall Visit(ref->getBase()); 4143f85e193739c953358c865005855253af4f68a497John McCall if (Capturer && ref->isFreeIvar()) 4144f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 4145f85e193739c953358c865005855253af4f68a497John McCall } 4146f85e193739c953358c865005855253af4f68a497John McCall 4147f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockExpr(BlockExpr *block) { 4148f85e193739c953358c865005855253af4f68a497John McCall // Look inside nested blocks 4149f85e193739c953358c865005855253af4f68a497John McCall if (block->getBlockDecl()->capturesVariable(Variable)) 4150f85e193739c953358c865005855253af4f68a497John McCall Visit(block->getBlockDecl()->getBody()); 4151f85e193739c953358c865005855253af4f68a497John McCall } 4152f85e193739c953358c865005855253af4f68a497John McCall }; 4153f85e193739c953358c865005855253af4f68a497John McCall} 4154f85e193739c953358c865005855253af4f68a497John McCall 4155f85e193739c953358c865005855253af4f68a497John McCall/// Check whether the given argument is a block which captures a 4156f85e193739c953358c865005855253af4f68a497John McCall/// variable. 4157f85e193739c953358c865005855253af4f68a497John McCallstatic Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) { 4158f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 4159f85e193739c953358c865005855253af4f68a497John McCall 4160f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParenCasts(); 4161f85e193739c953358c865005855253af4f68a497John McCall BlockExpr *block = dyn_cast<BlockExpr>(e); 4162f85e193739c953358c865005855253af4f68a497John McCall if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable)) 4163f85e193739c953358c865005855253af4f68a497John McCall return 0; 4164f85e193739c953358c865005855253af4f68a497John McCall 4165f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor visitor(S.Context, owner.Variable); 4166f85e193739c953358c865005855253af4f68a497John McCall visitor.Visit(block->getBlockDecl()->getBody()); 4167f85e193739c953358c865005855253af4f68a497John McCall return visitor.Capturer; 4168f85e193739c953358c865005855253af4f68a497John McCall} 4169f85e193739c953358c865005855253af4f68a497John McCall 4170f85e193739c953358c865005855253af4f68a497John McCallstatic void diagnoseRetainCycle(Sema &S, Expr *capturer, 4171f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner &owner) { 4172f85e193739c953358c865005855253af4f68a497John McCall assert(capturer); 4173f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 4174f85e193739c953358c865005855253af4f68a497John McCall 4175f85e193739c953358c865005855253af4f68a497John McCall S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle) 4176f85e193739c953358c865005855253af4f68a497John McCall << owner.Variable << capturer->getSourceRange(); 4177f85e193739c953358c865005855253af4f68a497John McCall S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner) 4178f85e193739c953358c865005855253af4f68a497John McCall << owner.Indirect << owner.Range; 4179f85e193739c953358c865005855253af4f68a497John McCall} 4180f85e193739c953358c865005855253af4f68a497John McCall 4181f85e193739c953358c865005855253af4f68a497John McCall/// Check for a keyword selector that starts with the word 'add' or 4182f85e193739c953358c865005855253af4f68a497John McCall/// 'set'. 4183f85e193739c953358c865005855253af4f68a497John McCallstatic bool isSetterLikeSelector(Selector sel) { 4184f85e193739c953358c865005855253af4f68a497John McCall if (sel.isUnarySelector()) return false; 4185f85e193739c953358c865005855253af4f68a497John McCall 41865f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef str = sel.getNameForSlot(0); 4187f85e193739c953358c865005855253af4f68a497John McCall while (!str.empty() && str.front() == '_') str = str.substr(1); 4188f85e193739c953358c865005855253af4f68a497John McCall if (str.startswith("set") || str.startswith("add")) 4189f85e193739c953358c865005855253af4f68a497John McCall str = str.substr(3); 4190f85e193739c953358c865005855253af4f68a497John McCall else 4191f85e193739c953358c865005855253af4f68a497John McCall return false; 4192f85e193739c953358c865005855253af4f68a497John McCall 4193f85e193739c953358c865005855253af4f68a497John McCall if (str.empty()) return true; 4194f85e193739c953358c865005855253af4f68a497John McCall return !islower(str.front()); 4195f85e193739c953358c865005855253af4f68a497John McCall} 4196f85e193739c953358c865005855253af4f68a497John McCall 4197f85e193739c953358c865005855253af4f68a497John McCall/// Check a message send to see if it's likely to cause a retain cycle. 4198f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(ObjCMessageExpr *msg) { 4199f85e193739c953358c865005855253af4f68a497John McCall // Only check instance methods whose selector looks like a setter. 4200f85e193739c953358c865005855253af4f68a497John McCall if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector())) 4201f85e193739c953358c865005855253af4f68a497John McCall return; 4202f85e193739c953358c865005855253af4f68a497John McCall 4203f85e193739c953358c865005855253af4f68a497John McCall // Try to find a variable that the receiver is strongly owned by. 4204f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 4205f85e193739c953358c865005855253af4f68a497John McCall if (msg->getReceiverKind() == ObjCMessageExpr::Instance) { 4206f85e193739c953358c865005855253af4f68a497John McCall if (!findRetainCycleOwner(msg->getInstanceReceiver(), owner)) 4207f85e193739c953358c865005855253af4f68a497John McCall return; 4208f85e193739c953358c865005855253af4f68a497John McCall } else { 4209f85e193739c953358c865005855253af4f68a497John McCall assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance); 4210f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = getCurMethodDecl()->getSelfDecl(); 4211f85e193739c953358c865005855253af4f68a497John McCall owner.Loc = msg->getSuperLoc(); 4212f85e193739c953358c865005855253af4f68a497John McCall owner.Range = msg->getSuperLoc(); 4213f85e193739c953358c865005855253af4f68a497John McCall } 4214f85e193739c953358c865005855253af4f68a497John McCall 4215f85e193739c953358c865005855253af4f68a497John McCall // Check whether the receiver is captured by any of the arguments. 4216f85e193739c953358c865005855253af4f68a497John McCall for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i) 4217f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner)) 4218f85e193739c953358c865005855253af4f68a497John McCall return diagnoseRetainCycle(*this, capturer, owner); 4219f85e193739c953358c865005855253af4f68a497John McCall} 4220f85e193739c953358c865005855253af4f68a497John McCall 4221f85e193739c953358c865005855253af4f68a497John McCall/// Check a property assign to see if it's likely to cause a retain cycle. 4222f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(Expr *receiver, Expr *argument) { 4223f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 4224f85e193739c953358c865005855253af4f68a497John McCall if (!findRetainCycleOwner(receiver, owner)) 4225f85e193739c953358c865005855253af4f68a497John McCall return; 4226f85e193739c953358c865005855253af4f68a497John McCall 4227f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, argument, owner)) 4228f85e193739c953358c865005855253af4f68a497John McCall diagnoseRetainCycle(*this, capturer, owner); 4229f85e193739c953358c865005855253af4f68a497John McCall} 4230f85e193739c953358c865005855253af4f68a497John McCall 4231921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianbool Sema::checkUnsafeAssigns(SourceLocation Loc, 4232f85e193739c953358c865005855253af4f68a497John McCall QualType LHS, Expr *RHS) { 4233f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime(); 4234f85e193739c953358c865005855253af4f68a497John McCall if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone) 4235921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return false; 4236921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // strip off any implicit cast added to get to the one arc-specific 4237921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 423833e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 4239f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::warn_arc_retained_assign) 4240f85e193739c953358c865005855253af4f68a497John McCall << (LT == Qualifiers::OCL_ExplicitNone) 4241f85e193739c953358c865005855253af4f68a497John McCall << RHS->getSourceRange(); 4242921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return true; 4243921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4244921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 4245921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4246921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return false; 4247f85e193739c953358c865005855253af4f68a497John McCall} 4248f85e193739c953358c865005855253af4f68a497John McCall 4249921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianvoid Sema::checkUnsafeExprAssigns(SourceLocation Loc, 4250921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Expr *LHS, Expr *RHS) { 4251921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian QualType LHSType = LHS->getType(); 4252921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (checkUnsafeAssigns(Loc, LHSType, RHS)) 4253921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4254921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime(); 4255921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // FIXME. Check for other life times. 4256921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (LT != Qualifiers::OCL_None) 4257921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4258921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 42593c3b7f90a863af43fa63043d396553ecf205351cJohn McCall if (ObjCPropertyRefExpr *PRE 42603c3b7f90a863af43fa63043d396553ecf205351cJohn McCall = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens())) { 4261921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (PRE->isImplicitProperty()) 4262921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4263921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 4264921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (!PD) 4265921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4266921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 4267921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian unsigned Attributes = PD->getPropertyAttributes(); 4268921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) 4269921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 427033e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 4271921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Diag(Loc, diag::warn_arc_retained_property_assign) 4272921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian << RHS->getSourceRange(); 4273921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4274921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4275921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 4276921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4277921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4278921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian} 4279