SemaChecking.cpp revision 4cd5791f4aa6deb572979bb38c1deedbc155efe0
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// The LLVM Compiler Infrastructure 459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source 60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details. 759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump// This file implements extra semantic analysis beyond what is enforced 1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// by the C type system. 1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 155f8d604246976a93a73549b07bbc8ee0b2061b50John McCall#include "clang/Sema/Initialization.h" 16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Sema.h" 172d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 18781472fe99a120098c631b0cbe33c89f8cef5e70John McCall#include "clang/Sema/ScopeInfo.h" 19826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek#include "clang/Analysis/Analyses/FormatString.h" 2059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h" 21199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h" 22384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 23c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h" 242324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h" 257ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h" 26f85e193739c953358c865005855253af4f68a497John McCall#include "clang/AST/EvaluatedExprVisitor.h" 27f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/DeclObjC.h" 28f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h" 29f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h" 3059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h" 31f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h" 32f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h" 333bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h" 34691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher#include "clang/Basic/TargetBuiltins.h" 3526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman#include "clang/Basic/TargetInfo.h" 367da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian#include "clang/Basic/ConvertUTF.h" 37a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits> 3859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang; 39781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema; 4059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 4160800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 4260800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned ByteNo) const { 4308f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner return SL->getLocationOfByte(ByteNo, PP.getSourceManager(), 4408f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner PP.getLangOptions(), PP.getTargetInfo()); 4560800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner} 4608f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner 4760800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 484403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// CheckablePrintfAttr - does a function call have a "printf" attribute 494403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// and arguments that merit checking? 504403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynnbool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) { 514403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf") return true; 524403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf0") { 534403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn // printf0 allows null "format" string; if so don't check format/args 544403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn unsigned format_idx = Format->getFormatIdx() - 1; 554a2614e94672c47395abcde60518776fbebec589Sebastian Redl // Does the index refer to the implicit object argument? 564a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 574a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (format_idx == 0) 584a2614e94672c47395abcde60518776fbebec589Sebastian Redl return false; 594a2614e94672c47395abcde60518776fbebec589Sebastian Redl --format_idx; 604a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 614403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (format_idx < TheCall->getNumArgs()) { 624403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts(); 63efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!Format->isNullPointerConstant(Context, 64efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek Expr::NPC_ValueDependentIsNull)) 654403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return true; 664403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 674403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 684403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return false; 694403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn} 7060800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 718e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number. 728e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking. Returns true on error. 738e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) { 748e10f3b9cc1db43645bbc2999eb163af8997d468John McCall unsigned argCount = call->getNumArgs(); 758e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount == desiredArgCount) return false; 768e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 778e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount < desiredArgCount) 788e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args) 798e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 808e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getSourceRange(); 818e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 828e10f3b9cc1db43645bbc2999eb163af8997d468John McCall // Highlight all the excess arguments. 838e10f3b9cc1db43645bbc2999eb163af8997d468John McCall SourceRange range(call->getArg(desiredArgCount)->getLocStart(), 848e10f3b9cc1db43645bbc2999eb163af8997d468John McCall call->getArg(argCount - 1)->getLocEnd()); 858e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 868e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args) 878e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 888e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getArg(1)->getSourceRange(); 898e10f3b9cc1db43645bbc2999eb163af8997d468John McCall} 908e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 9177f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge/// CheckBuiltinAnnotationString - Checks that string argument to the builtin 9277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge/// annotation is a non wide string literal. 9377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerougestatic bool CheckBuiltinAnnotationString(Sema &S, Expr *Arg) { 9477f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge Arg = Arg->IgnoreParenCasts(); 9577f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 9677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge if (!Literal || !Literal->isAscii()) { 9777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge S.Diag(Arg->getLocStart(), diag::err_builtin_annotation_not_string_constant) 9877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge << Arg->getSourceRange(); 9977f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return true; 10077f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge } 10177f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return false; 10277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge} 10377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge 10460d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 105d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 10660d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult TheCallResult(Owned(TheCall)); 1072def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor 108946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Find out if any arguments are required to be integer constant expressions. 109946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner unsigned ICEArguments = 0; 110946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ASTContext::GetBuiltinTypeError Error; 111946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 112946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (Error != ASTContext::GE_None) 113946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments = 0; // Don't diagnose previously diagnosed errors. 114946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 115946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // If any arguments are required to be ICE's, check and diagnose. 116946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 117946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Skip arguments not required to be ICE's. 118946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if ((ICEArguments & (1 << ArgNo)) == 0) continue; 119946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 120946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner llvm::APSInt Result; 121946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 122946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner return true; 123946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments &= ~(1 << ArgNo); 124946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner } 125946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 126d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson switch (BuiltinID) { 12730ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin___CFStringMakeConstantString: 128925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner assert(TheCall->getNumArgs() == 1 && 1291b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner "Wrong # arguments to builtin CFStringMakeConstantString"); 130690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner if (CheckObjCString(TheCall->getArg(0))) 1310eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 132d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 13349ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek case Builtin::BI__builtin_stdarg_start: 13430ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin_va_start: 1350eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinVAStart(TheCall)) 1360eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 137d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1381b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreater: 1391b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreaterequal: 1401b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isless: 1411b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessequal: 1421b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessgreater: 1431b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isunordered: 1440eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinUnorderedCompare(TheCall)) 1450eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 146d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 147e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer case Builtin::BI__builtin_fpclassify: 148e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer if (SemaBuiltinFPClassification(TheCall, 6)) 149e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer return ExprError(); 150e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer break; 1519ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isfinite: 1529ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf: 1539ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf_sign: 1549ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnan: 1559ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnormal: 1563b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (SemaBuiltinFPClassification(TheCall, 1)) 1579ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return ExprError(); 1589ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman break; 159d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman case Builtin::BI__builtin_shufflevector: 1600eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return SemaBuiltinShuffleVector(TheCall); 1610eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // TheCall will be freed by the smart pointer here, but that's fine, since 1620eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // SemaBuiltinShuffleVector guts it, but then doesn't release it. 1634493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar case Builtin::BI__builtin_prefetch: 1640eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinPrefetch(TheCall)) 1650eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 166d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 167d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar case Builtin::BI__builtin_object_size: 1680eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinObjectSize(TheCall)) 1690eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 170d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 171d875fed28578835de89cd407e9db4be788596d7cEli Friedman case Builtin::BI__builtin_longjmp: 172d875fed28578835de89cd407e9db4be788596d7cEli Friedman if (SemaBuiltinLongjmp(TheCall)) 173d875fed28578835de89cd407e9db4be788596d7cEli Friedman return ExprError(); 174d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1758e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 1768e10f3b9cc1db43645bbc2999eb163af8997d468John McCall case Builtin::BI__builtin_classify_type: 1778e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1788e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 1798e10f3b9cc1db43645bbc2999eb163af8997d468John McCall break; 18075c29a012793292ff4578015a9113bf086156d7fChris Lattner case Builtin::BI__builtin_constant_p: 1818e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1828e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 18375c29a012793292ff4578015a9113bf086156d7fChris Lattner break; 1845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: 1855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: 1865caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: 1875caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: 1885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: 1895caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_add_and_fetch: 1905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_sub_and_fetch: 1915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_and_and_fetch: 1925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_or_and_fetch: 1935caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_xor_and_fetch: 1945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 1955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 1965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_test_and_set: 1975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 19823aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: 199d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return SemaBuiltinAtomicOverloaded(move(TheCallResult)); 20077f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge case Builtin::BI__builtin_annotation: 20177f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge if (CheckBuiltinAnnotationString(*this, TheCall->getArg(1))) 20277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return ExprError(); 20377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge break; 20426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 20526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 20626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // Since the target specific builtins for each arch overlap, only check those 20726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // of the arch we are compiling for. 20826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (BuiltinID >= Builtin::FirstTSBuiltin) { 209bcfd1f55bfbb3e5944cd5e03d07b343e280838c4Douglas Gregor switch (Context.getTargetInfo().getTriple().getArch()) { 21026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::arm: 21126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::thumb: 21226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 21326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return ExprError(); 21426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 21526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman default: 21626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 21726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 21826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 21926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 22026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return move(TheCallResult); 22126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman} 22226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 22361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code. 22461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) { 22561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman bool quad = t & 0x10; 22661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 22761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman switch (t & 0x7) { 22861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 0: // i8 229d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 7 : (8 << (int)quad) - 1; 23061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 1: // i16 231d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 15 : (4 << (int)quad) - 1; 23261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 2: // i32 233d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 31 : (2 << (int)quad) - 1; 23461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 3: // i64 235d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 63 : (1 << (int)quad) - 1; 23661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 4: // f32 23761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift float types!"); 238d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (2 << (int)quad) - 1; 23961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 5: // poly8 24042499f94069c73d7a9c82da98a4245ea9fe2c526Bob Wilson return shift ? 7 : (8 << (int)quad) - 1; 24161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 6: // poly16 24242499f94069c73d7a9c82da98a4245ea9fe2c526Bob Wilson return shift ? 15 : (4 << (int)quad) - 1; 24361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 7: // float16 24461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift float types!"); 245d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (4 << (int)quad) - 1; 24661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman } 24761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman return 0; 24861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman} 24961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 25026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 2511c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman llvm::APSInt Result; 2521c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2530d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned mask = 0; 25461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned TV = 0; 2551c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman switch (BuiltinID) { 256a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK 257a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 258a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK 2591c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman } 2601c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2610d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which are overloaded on vector element type, validate 2620d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // the immediate which specifies which variant to emit. 2630d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (mask) { 2640d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned ArgNo = TheCall->getNumArgs()-1; 2650d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 2660d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 2670d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 26861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman TV = Result.getLimitedValue(32); 26961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if ((TV > 31) || (mask & (1 << TV)) == 0) 2700d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 2710d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman << TheCall->getArg(ArgNo)->getSourceRange(); 2720d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman } 2731c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2740d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which take an immediate value as part of the 2750d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // instruction, range check them here. 27661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned i = 0, l = 0, u = 0; 2770d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman switch (BuiltinID) { 2780d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman default: return false; 279bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 280bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 28199c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_f: 28299c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 283a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK 284a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 285a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK 2860d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman }; 2870d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 28861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Check that the immediate argument is actually a constant. 2890d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, i, Result)) 2900d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 2910d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 29261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Range check against the upper/lower values for this isntruction. 2930d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned Val = Result.getZExtValue(); 29461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if (Val < l || Val > (u + l)) 2950d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 296476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer << l << u+l << TheCall->getArg(i)->getSourceRange(); 2970d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 29899c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman // FIXME: VFP Intrinsics should error if VFP not present. 29926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return false; 300d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson} 301d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 302d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// CheckFunctionCall - Check a direct function call for various correctness 303d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// and safety properties not strictly enforced by the C type system. 304d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) { 305d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // Get the IdentifierInfo* for the called function. 306d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson IdentifierInfo *FnInfo = FDecl->getIdentifier(); 307de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 308d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // None of the checks below are needed for functions that don't have 309d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // simple names (e.g., C++ conversion functions). 310d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson if (!FnInfo) 311d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 313de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // FIXME: This mechanism should be abstracted to be less fragile and 314de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // more efficient. For example, just map function ids to custom 315de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // handlers. 316de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 317c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek // Printf and scanf checking. 318c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<FormatAttr> 319c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<FormatAttr>(), 320c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<FormatAttr>(); i != e ; ++i) { 321c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek 322c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek const FormatAttr *Format = *i; 323826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 324826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (b || CheckablePrintfAttr(Format, TheCall)) { 3253d692df4b9c58895f9843b03543ec57447c93679Ted Kremenek bool HasVAListArg = Format->getFirstArg() == 0; 326826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, 327826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Format->getFormatIdx() - 1, 328826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, 329826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek !b); 3303c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor } 33159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner } 3321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 333c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<NonNullAttr> 334c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<NonNullAttr>(), 335c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<NonNullAttr>(); i != e; ++i) { 336909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky CheckNonNullArguments(*i, TheCall->getArgs(), 337909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky TheCall->getCallee()->getLocStart()); 338c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek } 3390eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 340bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Builtin handling 341707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor int CMF = -1; 342707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor switch (FDecl->getBuiltinID()) { 343707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin_memset: 344707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin___memset_chk: 345707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BImemset: 346707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memset; 347707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor break; 348707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor 349707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin_memcpy: 350707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin___memcpy_chk: 351707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BImemcpy: 352707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memcpy; 353707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor break; 354707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor 355707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin_memmove: 356707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin___memmove_chk: 357707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BImemmove: 358707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memmove; 359707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor break; 360bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 361bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek case Builtin::BIstrlcpy: 362bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek case Builtin::BIstrlcat: 363bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CheckStrlcpycatArguments(TheCall, FnInfo); 364bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 365707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor 366cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay case Builtin::BI__builtin_memcmp: 367cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay CMF = CMF_Memcmp; 368cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay break; 369cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay 370707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor default: 371707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor if (FDecl->getLinkage() == ExternalLinkage && 372707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor (!getLangOptions().CPlusPlus || FDecl->isExternC())) { 373707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor if (FnInfo->isStr("memset")) 374707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memset; 375707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor else if (FnInfo->isStr("memcpy")) 376707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memcpy; 377707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor else if (FnInfo->isStr("memmove")) 378707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memmove; 379cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay else if (FnInfo->isStr("memcmp")) 380cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay CMF = CMF_Memcmp; 381707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor } 382707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor break; 38306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 384707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor 385bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Memset/memcpy/memmove handling 386707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor if (CMF != -1) 387cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay CheckMemaccessArguments(TheCall, CheckedMemoryFunction(CMF), FnInfo); 3887ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 389d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 39071993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson} 39171993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 392d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) { 393725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian // Printf checking. 39440b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis const FormatAttr *Format = NDecl->getAttr<FormatAttr>(); 395725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Format) 396d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 398725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian const VarDecl *V = dyn_cast<VarDecl>(NDecl); 399725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!V) 400d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 4011eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 402725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian QualType Ty = V->getType(); 403725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Ty->isBlockPointerType()) 404d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 4051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 406826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 407826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!b && !CheckablePrintfAttr(Format, TheCall)) 408d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 4091eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 410d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson bool HasVAListArg = Format->getFirstArg() == 0; 411826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1, 412826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, !b); 413d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 414d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 415725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian} 416725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian 4175f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// checkBuiltinArgument - Given a call to a builtin function, perform 4185f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// normal type-checking on the given argument, updating the call in 4195f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// place. This is useful when a builtin function requires custom 4205f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// type-checking for some of its arguments but not necessarily all of 4215f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// them. 4225f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// 4235f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// Returns true on error. 4245f8d604246976a93a73549b07bbc8ee0b2061b50John McCallstatic bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) { 4255f8d604246976a93a73549b07bbc8ee0b2061b50John McCall FunctionDecl *Fn = E->getDirectCallee(); 4265f8d604246976a93a73549b07bbc8ee0b2061b50John McCall assert(Fn && "builtin call without direct callee!"); 4275f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 4285f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ParmVarDecl *Param = Fn->getParamDecl(ArgIndex); 4295f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity Entity = 4305f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity::InitializeParameter(S.Context, Param); 4315f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 4325f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ExprResult Arg = E->getArg(0); 4335f8d604246976a93a73549b07bbc8ee0b2061b50John McCall Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg); 4345f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (Arg.isInvalid()) 4355f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 4365f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 4375f8d604246976a93a73549b07bbc8ee0b2061b50John McCall E->setArg(ArgIndex, Arg.take()); 4385f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return false; 4395f8d604246976a93a73549b07bbc8ee0b2061b50John McCall} 4405f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 4415caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like 4425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer 4435caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument. The main ActOnCallExpr routines have already 4445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as 4455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...). 4465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// 4475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these 4485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins, 44960d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 45060d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 451d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 4525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 4535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 4545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 4555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Ensure that we have at least one argument to do type inference from. 456d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1) { 457d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 458d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1 << TheCall->getNumArgs() 459d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 460d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 461d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 4621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4635caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Inspect the first argument of the atomic builtin. This should always be 4645caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // a pointer type, whose element is an integral scalar or pointer type. 4655caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Because it is a pointer type, we don't have to worry about any implicit 4665caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // casts here. 467d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth // FIXME: We don't allow floating point scalars as input. 4685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *FirstArg = TheCall->getArg(0); 469f85e193739c953358c865005855253af4f68a497John McCall const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>(); 470f85e193739c953358c865005855253af4f68a497John McCall if (!pointerType) { 471d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 472d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 473d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 474d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 4751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 476f85e193739c953358c865005855253af4f68a497John McCall QualType ValType = pointerType->getPointeeType(); 477dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 478d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth !ValType->isBlockPointerType()) { 479d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 480d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 481d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 482d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 4835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 484f85e193739c953358c865005855253af4f68a497John McCall switch (ValType.getObjCLifetime()) { 485f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 486f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 487f85e193739c953358c865005855253af4f68a497John McCall // okay 488f85e193739c953358c865005855253af4f68a497John McCall break; 489f85e193739c953358c865005855253af4f68a497John McCall 490f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 491f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 492f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 493b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 494f85e193739c953358c865005855253af4f68a497John McCall << ValType << FirstArg->getSourceRange(); 495f85e193739c953358c865005855253af4f68a497John McCall return ExprError(); 496f85e193739c953358c865005855253af4f68a497John McCall } 497f85e193739c953358c865005855253af4f68a497John McCall 4988d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // The majority of builtins return a value, but a few have special return 4998d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // types, so allow them to override appropriately below. 5008d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth QualType ResultType = ValType; 5018d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth 5025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // We need to figure out which concrete builtin this maps onto. For example, 5035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add with a 2 byte object turns into 5045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add_2. 5055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \ 5065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 5075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Builtin::BI##x##_8, Builtin::BI##x##_16 } 5081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner static const unsigned BuiltinIndices[][5] = { 5105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_add), 5115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_sub), 5125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_or), 5135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_and), 5145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_xor), 5151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_add_and_fetch), 5175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_sub_and_fetch), 5185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_and_and_fetch), 5195caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_or_and_fetch), 5205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_xor_and_fetch), 5211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_val_compare_and_swap), 5235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_bool_compare_and_swap), 5245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_test_and_set), 52523aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_lock_release), 52623aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_swap) 5275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner }; 5281eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW 5291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Determine the index of the size. 5315caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned SizeIndex; 532199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 5335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 1: SizeIndex = 0; break; 5345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 2: SizeIndex = 1; break; 5355caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 4: SizeIndex = 2; break; 5365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 8: SizeIndex = 3; break; 5375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 16: SizeIndex = 4; break; 5385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: 539d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 540d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 541d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 5425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 5431eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Each of these builtins has one pointer argument, followed by some number of 5455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // values (0, 1 or 2) followed by a potentially empty varags list of stuff 5465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // that we ignore. Find out which row of BuiltinIndices to read from as well 5475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // as the number of fixed args. 5487814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor unsigned BuiltinID = FDecl->getBuiltinID(); 5495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned BuiltinIndex, NumFixed = 1; 5505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner switch (BuiltinID) { 551b219cfc4d75f0a03630b7c4509ef791b7e97b2c8David Blaikie default: llvm_unreachable("Unknown overloaded atomic builtin!"); 5525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break; 5535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break; 5545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break; 5555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break; 5565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break; 5571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5587eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break; 5597eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break; 5607eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break; 5617eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break; 5627eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break; 5631eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5645caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 5657eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 10; 5665caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 5675caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 5685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 5697eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 11; 5705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 5718d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.BoolTy; 5725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 5737eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break; 5745caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 5757eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 13; 5765caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 0; 5778d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.VoidTy; 5785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 57923aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: BuiltinIndex = 14; break; 5805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 5811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Now that we know how many fixed arguments we expect, first check that we 5835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // have at least that many. 584d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1+NumFixed) { 585d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 586d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1+NumFixed << TheCall->getNumArgs() 587d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 588d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 589d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 5901eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 591e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // Get the decl for the concrete builtin from this, we can tell what the 592e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // concrete integer type we should convert to is. 593e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 594e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 595e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName); 5961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump FunctionDecl *NewBuiltinDecl = 597e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID, 598e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner TUScope, false, DRE->getLocStart())); 599d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 600f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // The first argument --- the pointer --- has a fixed type; we 601f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // deduce the types of the rest of the arguments accordingly. Walk 602f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // the remaining arguments, converting them to the deduced value type. 6035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner for (unsigned i = 0; i != NumFixed; ++i) { 604429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult Arg = TheCall->getArg(i+1); 6051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 6065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // If the argument is an implicit cast, then there was a promotion due to 6075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // "...", just remove it now. 608429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg.get())) { 6095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Arg = ICE->getSubExpr(); 6105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner ICE->setSubExpr(0); 611429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(i+1, Arg.get()); 6125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 6131eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 6145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // GCC does an implicit conversion to the pointer or integer ValType. This 6155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // can fail in some cases (1i -> int**), check for this error case now. 616daa8e4e888758d55a7a759dd4a91b83921cef222John McCall CastKind Kind = CK_Invalid; 617f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall ExprValueKind VK = VK_RValue; 618f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall CXXCastPath BasePath; 619f85e193739c953358c865005855253af4f68a497John McCall Arg = CheckCastTypes(Arg.get()->getLocStart(), Arg.get()->getSourceRange(), 620f85e193739c953358c865005855253af4f68a497John McCall ValType, Arg.take(), Kind, VK, BasePath); 621429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (Arg.isInvalid()) 622d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 6231eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 6245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Okay, we have something that *can* be converted to the right type. Check 6255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // to see if there is a potentially weird extension going on here. This can 6265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // happen when you do an atomic operation on something like an char* and 6275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // pass in 42. The 42 gets converted to char. This is even more strange 6285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // for things like 45.123 -> char, etc. 6291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // FIXME: Do this check. 630429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley Arg = ImpCastExprToType(Arg.take(), ValType, Kind, VK, &BasePath); 631429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(i+1, Arg.get()); 6325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 6331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 634bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor ASTContext& Context = this->getASTContext(); 635bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor 636bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor // Create a new DeclRefExpr to refer to the new decl. 637bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DeclRefExpr* NewDRE = DeclRefExpr::Create( 638bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor Context, 639bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getQualifierLoc(), 640bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor NewBuiltinDecl, 641bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getLocation(), 642bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor NewBuiltinDecl->getType(), 643bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getValueKind()); 6441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 6455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Set the callee in the CallExpr. 6465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // FIXME: This leaks the original parens and implicit casts. 647bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor ExprResult PromotedCall = UsualUnaryConversions(NewDRE); 648429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (PromotedCall.isInvalid()) 649429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return ExprError(); 650429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setCallee(PromotedCall.take()); 6511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 652db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // Change the result type of the call to match the original value type. This 653db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // is arbitrary, but the codegen for these builtins ins design to handle it 654db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // gracefully. 6558d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth TheCall->setType(ResultType); 656d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 657d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return move(TheCallResult); 6585caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner} 6595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 660690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin 66171993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct 662fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would 663fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend). 664690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) { 66556f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner Arg = Arg->IgnoreParenCasts(); 66671993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 66771993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 6685cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!Literal || !Literal->isAscii()) { 669fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 670fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << Arg->getSourceRange(); 6719cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return true; 67271993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson } 6731eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 6747da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Literal->containsNonAsciiOrNull()) { 6755f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef String = Literal->getString(); 6767da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian unsigned NumBytes = String.size(); 6775f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<UTF16, 128> ToBuf(NumBytes); 6787da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian const UTF8 *FromPtr = (UTF8 *)String.data(); 6797da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian UTF16 *ToPtr = &ToBuf[0]; 6807da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 6817da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 6827da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian &ToPtr, ToPtr + NumBytes, 6837da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian strictConversion); 6847da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian // Check for conversion failure. 6857da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Result != conversionOK) 6867da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian Diag(Arg->getLocStart(), 6877da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian diag::warn_cfstring_truncated) << Arg->getSourceRange(); 6887da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian } 6899cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return false; 69059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner} 69159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 692c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 693c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success. 694925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 695925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *Fn = TheCall->getCallee(); 696925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) { 6972c21a073525cdfa68e4439b7af551385dc2796abChris Lattner Diag(TheCall->getArg(2)->getLocStart(), 698fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 699ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 700ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << Fn->getSourceRange() 7011eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(2)->getLocStart(), 702fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 70330ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 70430ce344307f8a8b00054021307015571f83c7364Chris Lattner } 70556f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 70656f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman if (TheCall->getNumArgs() < 2) { 707d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher return Diag(TheCall->getLocEnd(), 708d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 709d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 71056f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman } 71156f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 7125f8d604246976a93a73549b07bbc8ee0b2061b50John McCall // Type-check the first argument normally. 7135f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (checkBuiltinArgument(*this, TheCall, 0)) 7145f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 7155f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 716c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner // Determine whether the current function is variadic or not. 7179ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor BlockScopeInfo *CurBlock = getCurBlock(); 718c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner bool isVariadic; 719cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 720c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall isVariadic = CurBlock->TheDecl->isVariadic(); 7219498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else if (FunctionDecl *FD = getCurFunctionDecl()) 7229498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek isVariadic = FD->isVariadic(); 7239498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else 72453d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis isVariadic = getCurMethodDecl()->isVariadic(); 7251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 726c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner if (!isVariadic) { 72730ce344307f8a8b00054021307015571f83c7364Chris Lattner Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 72830ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 72930ce344307f8a8b00054021307015571f83c7364Chris Lattner } 7301eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 73130ce344307f8a8b00054021307015571f83c7364Chris Lattner // Verify that the second argument to the builtin is the last argument of the 73230ce344307f8a8b00054021307015571f83c7364Chris Lattner // current function or method. 73330ce344307f8a8b00054021307015571f83c7364Chris Lattner bool SecondArgIsLastNamedArgument = false; 734e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 7351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 73688cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 73788cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 73830ce344307f8a8b00054021307015571f83c7364Chris Lattner // FIXME: This isn't correct for methods (results in bogus warning). 73930ce344307f8a8b00054021307015571f83c7364Chris Lattner // Get the last formal in the current function. 74088cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson const ParmVarDecl *LastArg; 741cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 742cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff LastArg = *(CurBlock->TheDecl->param_end()-1); 743cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff else if (FunctionDecl *FD = getCurFunctionDecl()) 744371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner LastArg = *(FD->param_end()-1); 74530ce344307f8a8b00054021307015571f83c7364Chris Lattner else 74653d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis LastArg = *(getCurMethodDecl()->param_end()-1); 74730ce344307f8a8b00054021307015571f83c7364Chris Lattner SecondArgIsLastNamedArgument = PV == LastArg; 74830ce344307f8a8b00054021307015571f83c7364Chris Lattner } 74930ce344307f8a8b00054021307015571f83c7364Chris Lattner } 7501eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 75130ce344307f8a8b00054021307015571f83c7364Chris Lattner if (!SecondArgIsLastNamedArgument) 7521eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(1)->getLocStart(), 75330ce344307f8a8b00054021307015571f83c7364Chris Lattner diag::warn_second_parameter_of_va_start_not_last_named_argument); 75430ce344307f8a8b00054021307015571f83c7364Chris Lattner return false; 7556cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman} 75630ce344307f8a8b00054021307015571f83c7364Chris Lattner 7571b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 7581b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends. This is declared to take (...), so we have to check everything. 759925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 760925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() < 2) 7612c21a073525cdfa68e4439b7af551385dc2796abChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 762d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << 2 << TheCall->getNumArgs()/*function call*/; 763925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) 7641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(TheCall->getArg(2)->getLocStart(), 765fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 766ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 767fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(TheCall->getArg(2)->getLocStart(), 768fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 7691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 770429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg0 = TheCall->getArg(0); 771429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg1 = TheCall->getArg(1); 772cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 7731b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // Do standard promotions between the two arguments, returning their common 7741b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // type. 775925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 776429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.isInvalid() || OrigArg1.isInvalid()) 777429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return true; 778403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar 779403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // Make sure any conversions are pushed back into the call; this is 780403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // type safe since unordered compare builtins are declared as "_Bool 781403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // foo(...)". 782429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(0, OrigArg0.get()); 783429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(1, OrigArg1.get()); 7841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 785429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent()) 786cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 787cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 7881b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // If the common type isn't a real floating type, then the arguments were 7891b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // invalid for this operation. 7901b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner if (!Res->isRealFloatingType()) 791429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return Diag(OrigArg0.get()->getLocStart(), 792fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_invalid_ordered_compare) 793429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << OrigArg0.get()->getType() << OrigArg1.get()->getType() 794429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd()); 7951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7961b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner return false; 7971b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner} 7981b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner 799e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 800e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends. This is declared to take (...), so we have 8013b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point 8023b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value. 8033b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 8043b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() < NumArgs) 8059ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 806d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 8073b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() > NumArgs) 8083b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer return Diag(TheCall->getArg(NumArgs)->getLocStart(), 8099ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_too_many_args) 810ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 8113b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 8129ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman (*(TheCall->arg_end()-1))->getLocEnd()); 8139ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 8143b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer Expr *OrigArg = TheCall->getArg(NumArgs-1); 8151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8169ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (OrigArg->isTypeDependent()) 8179ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 8189ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 81981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // This operation requires a non-_Complex floating-point number. 8209ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (!OrigArg->getType()->isRealFloatingType()) 8211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg->getLocStart(), 8229ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_invalid_unary_fp) 8239ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman << OrigArg->getType() << OrigArg->getSourceRange(); 8241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 82581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // If this is an implicit conversion from float -> double, remove it. 82681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 82781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Expr *CastArg = Cast->getSubExpr(); 82881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 82981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 83081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner "promotion from float to double is the only expected cast here"); 83181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Cast->setSubExpr(0); 83281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner TheCall->setArg(NumArgs-1, CastArg); 83381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner OrigArg = CastArg; 83481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 83581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 83681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner 8379ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 8389ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman} 8399ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 840d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 841d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything. 84260d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 84337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() < 2) 8440eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocEnd(), 845d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 84637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << 0 /*function call*/ << 2 << TheCall->getNumArgs() 847d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << TheCall->getSourceRange()); 848d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 84937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Determine which of the following types of shufflevector we're checking: 85037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 1) unary, vector mask: (lhs, mask) 85137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 2) binary, vector mask: (lhs, rhs, mask) 85237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 85337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType resType = TheCall->getArg(0)->getType(); 85437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numElements = 0; 85537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 856cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (!TheCall->getArg(0)->isTypeDependent() && 857cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor !TheCall->getArg(1)->isTypeDependent()) { 85837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType LHSType = TheCall->getArg(0)->getType(); 85937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType RHSType = TheCall->getArg(1)->getType(); 86037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 86137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!LHSType->isVectorType() || !RHSType->isVectorType()) { 862cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) 8631eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 864cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 865cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 866cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 86737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 86837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numElements = LHSType->getAs<VectorType>()->getNumElements(); 86937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numResElements = TheCall->getNumArgs() - 2; 87037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 87137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Check to see if we have a call with 2 vector arguments, the unary shuffle 87237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // with mask. If so, verify that RHS is an integer vector type with the 87337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // same number of elts as lhs. 87437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() == 2) { 875f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (!RHSType->hasIntegerRepresentation() || 87637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman RHSType->getAs<VectorType>()->getNumElements() != numElements) 87737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 87837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << SourceRange(TheCall->getArg(1)->getLocStart(), 87937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman TheCall->getArg(1)->getLocEnd()); 88037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numResElements = numElements; 88137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } 88237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 883cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 8841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 885cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 886cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 88737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } else if (numElements != numResElements) { 88837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 889788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner resType = Context.getVectorType(eltType, numResElements, 890e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson VectorType::GenericVector); 891cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 892d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 893d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 894d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 895cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 896cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(i)->isValueDependent()) 897cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor continue; 898cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 89937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman llvm::APSInt Result(32); 90037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 90137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman return ExprError(Diag(TheCall->getLocStart(), 90237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman diag::err_shufflevector_nonconstant_argument) 90337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << TheCall->getArg(i)->getSourceRange()); 9040eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 905d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 9060eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocStart(), 907fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_shufflevector_argument_too_large) 9080eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl << TheCall->getArg(i)->getSourceRange()); 909d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 910d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 9115f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<Expr*, 32> exprs; 912d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 913d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 914d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman exprs.push_back(TheCall->getArg(i)); 915d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman TheCall->setArg(i, 0); 916d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 917d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 918a88dc3079bedf70a5cfc39791727e43a10383006Nate Begeman return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(), 91937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman exprs.size(), resType, 9208189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getCallee()->getLocStart(), 9218189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getRParenLoc())); 922d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman} 92330ce344307f8a8b00054021307015571f83c7364Chris Lattner 9244493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 9254493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two 9264493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args. 9274493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 928fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner unsigned NumArgs = TheCall->getNumArgs(); 9294493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 930fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (NumArgs > 3) 931ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher return Diag(TheCall->getLocEnd(), 932ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher diag::err_typecheck_call_too_many_args_at_most) 933ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 3 << NumArgs 934ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << TheCall->getSourceRange(); 9354493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 9364493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // Argument 0 is checked for us and the remaining arguments must be 9374493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // constant integers. 938fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner for (unsigned i = 1; i != NumArgs; ++i) { 9394493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar Expr *Arg = TheCall->getArg(i); 940691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 9419aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman llvm::APSInt Result; 942691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, i, Result)) 943691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 9441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9454493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // FIXME: gcc issues a warning and rewrites these to 0. These 9464493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // seems especially odd for the third argument since the default 9474493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // is 3. 948fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (i == 1) { 9499aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 1) 950fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 95121fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "1" << Arg->getSourceRange(); 9524493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } else { 9539aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 3) 954fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 95521fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "3" << Arg->getSourceRange(); 9564493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 9574493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 9584493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 959fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return false; 9604493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar} 9614493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 962691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 963691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression. 964691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 965691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt &Result) { 966691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(ArgNum); 967691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 968691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 969691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 970691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 971691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 972691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (!Arg->isIntegerConstantExpr(Result, Context)) 973691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 9745e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher << FDecl->getDeclName() << Arg->getSourceRange(); 975691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 97621fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner return false; 97721fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner} 97821fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner 979d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 980d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined 981d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3). 982fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner// For compatibility check 0-3, llvm only handles 0 and 2. 983d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 984691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 985691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 986691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // Check constant-ness first. 987691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 988691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 989d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 990691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(1); 991d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 992fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 993fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 994d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar } 995d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 996d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar return false; 997d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar} 998d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 999586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 1000d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1. 1001d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 1002d875fed28578835de89cd407e9db4be788596d7cEli Friedman Expr *Arg = TheCall->getArg(1); 1003691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1004cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 1005691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // TODO: This is less than ideal. Overload this to take a value. 1006691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1007691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1008691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1009691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Result != 1) 1010d875fed28578835de89cd407e9db4be788596d7cEli Friedman return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 1011d875fed28578835de89cd407e9db4be788596d7cEli Friedman << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1012d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1013d875fed28578835de89cd407e9db4be788596d7cEli Friedman return false; 1014d875fed28578835de89cd407e9db4be788596d7cEli Friedman} 1015d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1016b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek// Handle i > 1 ? "x" : "y", recursively. 1017082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenekbool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall, 1018082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool HasVAListArg, 1019826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1020826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 10214fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain: 1022cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 1023cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 1024d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1025f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 1026f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 1027d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek switch (E->getStmtClass()) { 102856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::BinaryConditionalOperatorClass: 1029d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ConditionalOperatorClass: { 103056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall const AbstractConditionalOperator *C = cast<AbstractConditionalOperator>(E); 1031826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return SemaCheckStringLiteral(C->getTrueExpr(), TheCall, HasVAListArg, 1032826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf) 103356ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall && SemaCheckStringLiteral(C->getFalseExpr(), TheCall, HasVAListArg, 1034826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf); 1035d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1036d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 103795355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek case Stmt::IntegerLiteralClass: 103895355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // Technically -Wformat-nonliteral does not warn about this case. 103995355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // The behavior of printf and friends in this case is implementation 104095355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // dependent. Ideally if the format string cannot be null then 104195355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // it should have a 'nonnull' attribute in the function prototype. 104295355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek return true; 104395355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek 1044d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ImplicitCastExprClass: { 10454fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ImplicitCastExpr>(E)->getSubExpr(); 10464fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 1047d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1048d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 104956ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::OpaqueValueExprClass: 105056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) { 105156ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall E = src; 105256ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall goto tryAgain; 105356ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall } 105456ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall return false; 105556ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall 1056b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek case Stmt::PredefinedExprClass: 1057b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // While __func__, etc., are technically not string literals, they 1058b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // cannot contain format specifiers and thus are not a security 1059b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // liability. 1060b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek return true; 1061b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek 1062082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::DeclRefExprClass: { 1063082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const DeclRefExpr *DR = cast<DeclRefExpr>(E); 10641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1065082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // As an exception, do not flag errors for variables binding to 1066082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // const string literals. 1067082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 1068082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool isConstant = false; 1069082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek QualType T = DR->getType(); 1070082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek 1071082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ArrayType *AT = Context.getAsArrayType(T)) { 1072082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek isConstant = AT->getElementType().isConstant(Context); 1073ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (const PointerType *PT = T->getAs<PointerType>()) { 10741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump isConstant = T.isConstant(Context) && 1075082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek PT->getPointeeType().isConstant(Context); 1076082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 10771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1078082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (isConstant) { 107931310a21fb2a9f13950f864f681c86080b05d5b2Sebastian Redl if (const Expr *Init = VD->getAnyInitializer()) 1080082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return SemaCheckStringLiteral(Init, TheCall, 1081826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, format_idx, firstDataArg, 1082826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isPrintf); 1083082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 10841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1085d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // For vprintf* functions (i.e., HasVAListArg==true), we add a 1086d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // special check to see if the format string is a function parameter 1087d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // of the function calling the printf function. If the function 1088d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // has an attribute indicating it is a printf-like function, then we 1089d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // should suppress warnings concerning non-literals being used in a call 1090d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // to a vprintf function. For example: 1091d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1092d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // void 1093d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 1094d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_list ap; 1095d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_start(ap, fmt); 1096d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 1097d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // ... 1098d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1099d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1100d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // FIXME: We don't have full attribute support yet, so just check to see 1101d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // if the argument is a DeclRefExpr that references a parameter. We'll 1102d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // add proper support for checking the attribute later. 1103d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (HasVAListArg) 1104d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (isa<ParmVarDecl>(VD)) 1105d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson return true; 1106082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 11071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1108082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1109082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 1110d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 11118f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson case Stmt::CallExprClass: { 11128f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const CallExpr *CE = cast<CallExpr>(E); 11131eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump if (const ImplicitCastExpr *ICE 11148f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson = dyn_cast<ImplicitCastExpr>(CE->getCallee())) { 11158f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) { 11168f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) { 111740b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) { 11188f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson unsigned ArgIndex = FA->getFormatIdx(); 11198f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const Expr *Arg = CE->getArg(ArgIndex - 1); 11201eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg, 1122826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf); 11238f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 11248f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 11258f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 11268f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 11271eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11288f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson return false; 11298f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 1130082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::ObjCStringLiteralClass: 1131082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::StringLiteralClass: { 1132082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const StringLiteral *StrE = NULL; 11331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1134082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 1135d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek StrE = ObjCFExpr->getString(); 1136d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek else 1137082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek StrE = cast<StringLiteral>(E); 11381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1139d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek if (StrE) { 1140826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatString(StrE, E, TheCall, HasVAListArg, format_idx, 1141826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek firstDataArg, isPrintf); 1142d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return true; 1143d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 11441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1145d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return false; 1146d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 11471eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1148082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek default: 1149082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1150d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1151d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1152d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1153e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid 11541eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull, 1155909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr * const *ExprArgs, 1156909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky SourceLocation CallSiteLoc) { 1157cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt for (NonNullAttr::args_iterator i = NonNull->args_begin(), 1158cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt e = NonNull->args_end(); 1159e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian i != e; ++i) { 1160909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr *ArgExpr = ExprArgs[*i]; 11614e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (ArgExpr->isNullPointerConstant(Context, 1162ce94049b69f75b44c18584fe79cd238978b6b0d5Douglas Gregor Expr::NPC_ValueDependentIsNotNull)) 1163909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange(); 1164e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian } 1165e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian} 1166d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1167826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar 1168826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings. 116959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnervoid 1170826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSema::CheckPrintfScanfArguments(const CallExpr *TheCall, bool HasVAListArg, 1171826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1172826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 1173826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1174082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *Fn = TheCall->getCallee(); 1175925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner 11764a2614e94672c47395abcde60518776fbebec589Sebastian Redl // The way the format attribute works in GCC, the implicit this argument 11774a2614e94672c47395abcde60518776fbebec589Sebastian Redl // of member functions is counted. However, it doesn't appear in our own 11784a2614e94672c47395abcde60518776fbebec589Sebastian Redl // lists, so decrement format_idx in that case. 11794a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 11809263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth const CXXMethodDecl *method_decl = 11819263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth dyn_cast<CXXMethodDecl>(TheCall->getCalleeDecl()); 11829263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if (method_decl && method_decl->isInstance()) { 11839263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth // Catch a format attribute mistakenly referring to the object argument. 11849263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if (format_idx == 0) 11859263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth return; 11869263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth --format_idx; 11879263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if(firstDataArg != 0) 11889263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth --firstDataArg; 11899263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth } 11904a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 11914a2614e94672c47395abcde60518776fbebec589Sebastian Redl 1192826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // CHECK: printf/scanf-like function is called with no format string. 1193925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (format_idx >= TheCall->getNumArgs()) { 1194826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Diag(TheCall->getRParenLoc(), diag::warn_missing_format_string) 1195dcd5ef12488e4c7ea844327835896ca86b609a97Chris Lattner << Fn->getSourceRange(); 119671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek return; 119771895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek } 11981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1199082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts(); 12001eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 120159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner // CHECK: format string is not a string literal. 12021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // 120371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // Dynamically generated format strings are difficult to 120471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // automatically vet at compile time. Requiring that format strings 120571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // are string literals: (1) permits the checking of format strings by 120671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // the compiler and thereby (2) can practically remove the source of 120771895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // many format string exploits. 12087ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek 12091eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // Format string can be either ObjC string (e.g. @"%d") or 12107ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // C string (e.g. "%d") 12111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // ObjC string uses the same format specifiers as C string, so we can use 12127ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // the same format string checking logic for both ObjC and C strings. 12131cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx, 1214826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek firstDataArg, isPrintf)) 12151cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner return; // Literal format string found, check done! 12161cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner 1217655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // If there are no arguments specified, warn with -Wformat-security, otherwise 1218655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // warn only with -Wformat-nonliteral. 1219655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner if (TheCall->getNumArgs() == format_idx+1) 12201eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1221826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral_noargs) 1222655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1223655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner else 12241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1225826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral) 1226655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1227d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1228d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1229e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace { 1230826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler { 1231826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1232e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Sema &S; 1233e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const StringLiteral *FExpr; 1234e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const Expr *OrigFormatExpr; 12356ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const unsigned FirstDataArg; 1236e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const unsigned NumDataArgs; 1237e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const bool IsObjCLiteral; 1238e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *Beg; // Start of format string. 12390d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const bool HasVAListArg; 12400d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const CallExpr *TheCall; 12410d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek unsigned FormatIdx; 12427f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek llvm::BitVector CoveredArgs; 1243efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool usesPositionalArgs; 1244efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool atFirstArg; 12454e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic: 1246826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 12476ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1248e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 12490d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const char *beg, bool hasVAListArg, 12500d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1251e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 12526ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek FirstDataArg(firstDataArg), 12537f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek NumDataArgs(numDataArgs), 12540d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek IsObjCLiteral(isObjCLiteral), Beg(beg), 12550d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek HasVAListArg(hasVAListArg), 1256efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek TheCall(theCall), FormatIdx(formatIdx), 1257efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek usesPositionalArgs(false), atFirstArg(true) { 12587f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.resize(numDataArgs); 12597f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.reset(); 12607f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 12614e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 126207d161f38e708a91486bf1c031d525faebbb249dTed Kremenek void DoneProcessing(); 12634e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1264826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIncompleteSpecifier(const char *startSpecifier, 1265826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1266826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1267efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleInvalidPosition(const char *startSpecifier, 1268efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned specifierLen, 1269826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p); 1270efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1271efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 1272efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1273e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek void HandleNullChar(const char *nullCharacter); 12744e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1275826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1276c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 1277c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1278c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1279c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, unsigned csLen); 1280c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1281f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek SourceRange getFormatStringRange(); 1282826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CharSourceRange getSpecifierRange(const char *startSpecifier, 1283826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1284e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek SourceLocation getLocationOfByte(const char *x); 12854e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 12860d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const Expr *getDataArg(unsigned i) const; 1287666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1288666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 1289666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1290666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, 1291666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek unsigned argIndex); 1292e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}; 1293e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1294e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1295826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() { 1296e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return OrigFormatExpr->getSourceRange(); 1297e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1298e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1299826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler:: 1300826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 130145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation Start = getLocationOfByte(startSpecifier); 130245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 130345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 130445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care // Advance the end SourceLocation by one due to half-open ranges. 1305a64ccefdf0ea4e03ec88805d71b0af74950c7472Argyrios Kyrtzidis End = End.getLocWithOffset(1); 130645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 130745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care return CharSourceRange::getCharRange(Start, End); 1308f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek} 1309f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek 1310826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 13114e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 1312e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1313e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1314826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 1315826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen){ 1316808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek SourceLocation Loc = getLocationOfByte(startSpecifier); 1317808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek S.Diag(Loc, diag::warn_printf_incomplete_specifier) 1318826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1319808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek} 1320808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek 1321efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid 1322826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 1323826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p) { 1324efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek SourceLocation Loc = getLocationOfByte(startPos); 1325826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(Loc, diag::warn_format_invalid_positional_specifier) 1326826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << (unsigned) p << getSpecifierRange(startPos, posLen); 1327efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1328efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1329826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos, 1330efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned posLen) { 1331efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek SourceLocation Loc = getLocationOfByte(startPos); 1332826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(Loc, diag::warn_format_zero_positional_specifier) 1333826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startPos, posLen); 1334efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1335efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1336826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 13370c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek if (!IsObjCLiteral) { 13380c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek // The presence of a null character is likely an error. 13390c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek S.Diag(getLocationOfByte(nullCharacter), 13400c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek diag::warn_printf_format_string_contains_null_char) 13410c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek << getFormatStringRange(); 13420c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek } 1343826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1344826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1345826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const { 1346826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return TheCall->getArg(FirstDataArg + i); 1347826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 13484e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1349826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() { 1350826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Does the number of data arguments exceed the number of 1351826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // format conversions in the format string? 1352826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!HasVAListArg) { 1353826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Find any arguments that weren't covered. 1354826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.flip(); 1355826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek signed notCoveredArg = CoveredArgs.find_first(); 1356826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (notCoveredArg >= 0) { 1357826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek assert((unsigned)notCoveredArg < NumDataArgs); 1358826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(), 1359826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_printf_data_arg_not_used) 1360826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getFormatStringRange(); 1361826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1362826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1363826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1364826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1365c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool 1366c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 1367c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek SourceLocation Loc, 1368c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1369c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1370c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, 1371c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned csLen) { 1372c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1373c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool keepGoing = true; 1374c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek if (argIndex < NumDataArgs) { 1375c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // Consider the argument coverered, even though the specifier doesn't 1376c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // make sense. 1377c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CoveredArgs.set(argIndex); 1378c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1379c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek else { 1380c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // If argIndex exceeds the number of data arguments we 1381c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // don't issue a warning because that is just a cascade of warnings (and 1382c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // they may have intended '%%' anyway). We don't want to continue processing 1383c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // the format string after this point, however, as we will like just get 1384c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // gibberish when trying to match arguments. 1385c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek keepGoing = false; 1386c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1387c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1388c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek S.Diag(Loc, diag::warn_format_invalid_conversion) 13895f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner << StringRef(csStart, csLen) 1390c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek << getSpecifierRange(startSpec, specifierLen); 1391c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1392c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return keepGoing; 1393c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1394c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1395666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool 1396666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs( 1397666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::FormatSpecifier &FS, 1398666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1399666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 1400666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1401666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (argIndex >= NumDataArgs) { 1402666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (FS.usesPositionalArg()) { 1403666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1404666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek diag::warn_printf_positional_arg_exceeds_data_args) 1405666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << (argIndex+1) << NumDataArgs 1406666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1407666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1408666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek else { 1409666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1410666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek diag::warn_printf_insufficient_data_args) 1411666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1412666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1413666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1414666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return false; 1415666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1416666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return true; 1417666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek} 1418666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1419826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===// 1420826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1421826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 1422826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler { 1423826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 1424826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 1425826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1426826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 1427826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 1428826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1429826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1430826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 1431826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek theCall, formatIdx) {} 1432826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1433826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1434826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleInvalidPrintfConversionSpecifier( 1435826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1436826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1437826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1438826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1439826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 1440826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1441826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1442826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1443826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 1444826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1445826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 1446826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalAmount &Amt, 1447826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned type, 1448826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1449826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1450826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1451826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1452826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 1453826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &ignoredFlag, 1454826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1455826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1456826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 1457826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1458826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1459826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 1460826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1461826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1462826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 14636ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 1464c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 1465826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1466c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1467c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 1468c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 1469c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 147026ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek} 147126ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek 1472826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount( 1473826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_format_string::OptionalAmount &Amt, 1474826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned k, const char *startSpecifier, 1475826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 14760d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 14770d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (Amt.hasDataArgument()) { 14780d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (!HasVAListArg) { 14797f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = Amt.getArgIndex(); 14807f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (argIndex >= NumDataArgs) { 1481efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1482efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek diag::warn_printf_asterisk_missing_arg) 1483826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << k << getSpecifierRange(startSpecifier, specifierLen); 14840d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 14850d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 14860d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 14870d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 14884e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 14890d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Type check the data argument. It should be an 'int'. 149031f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // Although not in conformance with C99, we also allow the argument to be 149131f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // an 'unsigned int' as that is a reasonably safe case. GCC also 149231f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // doesn't emit a warning for that case. 14937f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.set(argIndex); 14947f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek const Expr *Arg = getDataArg(argIndex); 14950d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek QualType T = Arg->getType(); 14964e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 14974e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context); 14984e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek assert(ATR.isValid()); 14994e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 15004e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (!ATR.matchesType(S.Context, T)) { 1501efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1502efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek diag::warn_printf_asterisk_wrong_type) 1503efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek << k 15044e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek << ATR.getRepresentativeType(S.Context) << T 1505826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1506d635c5fcc45c952b75743dd2f4c86d6950e4954eTed Kremenek << Arg->getSourceRange(); 15070d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 15080d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 15090d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 15100d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 15110d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 15120d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 15130d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return true; 15140d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek} 15150d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1516e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount( 1517826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1518e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalAmount &Amt, 1519e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned type, 1520e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1521e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 15226ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 15236ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1524e4ee9663168dfb2b4122c768091e30217328c9faTom Care switch (Amt.getHowSpecified()) { 1525e4ee9663168dfb2b4122c768091e30217328c9faTom Care case analyze_printf::OptionalAmount::Constant: 1526e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(Amt.getStart()), 1527e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_optional_amount) 1528e4ee9663168dfb2b4122c768091e30217328c9faTom Care << type 1529e4ee9663168dfb2b4122c768091e30217328c9faTom Care << CS.toString() 1530826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1531826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 1532e4ee9663168dfb2b4122c768091e30217328c9faTom Care Amt.getConstantLength())); 1533e4ee9663168dfb2b4122c768091e30217328c9faTom Care break; 1534e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1535e4ee9663168dfb2b4122c768091e30217328c9faTom Care default: 1536e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(Amt.getStart()), 1537e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_optional_amount) 1538e4ee9663168dfb2b4122c768091e30217328c9faTom Care << type 1539e4ee9663168dfb2b4122c768091e30217328c9faTom Care << CS.toString() 1540826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1541e4ee9663168dfb2b4122c768091e30217328c9faTom Care break; 1542e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1543e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1544e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1545826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1546e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 1547e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1548e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 1549e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about pointless flag with a fixit removal. 15506ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 15516ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1552e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(flag.getPosition()), 1553e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_flag) 1554e4ee9663168dfb2b4122c768091e30217328c9faTom Care << flag.toString() << CS.toString() 1555826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1556826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(flag.getPosition(), 1)); 1557e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1558e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1559e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag( 1560826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1561e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &ignoredFlag, 1562e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 1563e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1564e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 1565e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about ignored flag with a fixit removal. 1566e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(ignoredFlag.getPosition()), 1567e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_ignored_flag) 1568e4ee9663168dfb2b4122c768091e30217328c9faTom Care << ignoredFlag.toString() << flag.toString() 1569826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1570826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange( 1571e4ee9663168dfb2b4122c768091e30217328c9faTom Care ignoredFlag.getPosition(), 1)); 1572e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1573e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1574e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool 1575826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 15765c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek &FS, 1577e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *startSpecifier, 1578e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned specifierLen) { 1579e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 15806ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek using namespace analyze_format_string; 1581efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek using namespace analyze_printf; 15826ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 1583e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1584baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 1585baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 1586baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 1587baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 1588baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1589baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 1590baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Cannot mix-and-match positional and non-positional arguments. 1591baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1592baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek diag::warn_format_mix_positional_nonpositional_args) 1593baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1594baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 1595baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1596efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek } 1597efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 15980d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // First check if the field width, precision, and conversion specifier 15990d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // have matching data arguments. 1600efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 1601efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 16020d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 16030d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 16044e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1605efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 1606efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 16070d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 16080d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 16090d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1610f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek if (!CS.consumesDataArgument()) { 1611f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // FIXME: Technically specifying a precision or field width here 1612f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // makes no sense. Worth issuing a warning at some point. 16130e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek return true; 1614f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek } 16154e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 16167f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Consume the argument. 16177f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = FS.getArgIndex(); 1618e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek if (argIndex < NumDataArgs) { 1619e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // The check to see if the argIndex is valid will come later. 1620e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // We set the bit here because we may exit early from this 1621e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // function if we encounter some other error. 1622e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek CoveredArgs.set(argIndex); 1623e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek } 16247f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek 16257f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Check for using an Objective-C specific conversion specifier 16267f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // in a non-ObjC literal. 16277f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (!IsObjCLiteral && CS.isObjCArg()) { 1628826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 1629826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek specifierLen); 16307f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 16314e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1632e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of field width 1633e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidFieldWidth()) { 163445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 1635e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1636e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1637e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1638e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of precision 1639e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPrecision()) { 1640e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 1641e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1642e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1643e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1644e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check each flag does not conflict with any other component. 164565197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek if (!FS.hasValidThousandsGroupingPrefix()) 164665197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen); 1647e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeadingZeros()) 1648e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 1649e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPlusPrefix()) 1650e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 165145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (!FS.hasValidSpacePrefix()) 165245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 1653e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidAlternativeForm()) 1654e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 1655e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeftJustified()) 1656e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 1657e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1658e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check that flags are not ignored by another flag 165945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 166045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 166145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care startSpecifier, specifierLen); 1662e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 1663e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 1664e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1665e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1666e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check the length modifier is valid with the given conversion specifier. 1667e4ee9663168dfb2b4122c768091e30217328c9faTom Care const LengthModifier &LM = FS.getLengthModifier(); 1668e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLengthModifier()) 1669e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(LM.getStart()), 1670649aecf55670682efb2a04a85810eef4d038c527Ted Kremenek diag::warn_format_nonsensical_length) 1671e4ee9663168dfb2b4122c768091e30217328c9faTom Care << LM.toString() << CS.toString() 1672826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1673826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 1674e4ee9663168dfb2b4122c768091e30217328c9faTom Care LM.getLength())); 1675e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1676e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Are we using '%n'? 167735d353b47bce29200b910371dd9b8ba7f3058ab8Ted Kremenek if (CS.getKind() == ConversionSpecifier::nArg) { 1678e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Issue a warning about this being a possible security issue. 1679e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back) 1680826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1681e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek // Continue checking the other format specifiers. 1682e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek return true; 1683e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek } 16845c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek 1685da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek // The remaining checks depend on the data arguments. 1686da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek if (HasVAListArg) 1687da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return true; 16884e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1689666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 1690da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return false; 16914e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 169296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Now type check the data expression that matches the 169396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // format specifier. 169496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const Expr *Ex = getDataArg(argIndex); 169596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context); 169696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) { 169796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Check if we didn't match because of an implicit cast from a 'char' 169896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // or 'short' to an 'int'. This is done because printf is a varargs 169996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // function. 170096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex)) 17014d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ICE->getType() == S.Context.IntTy) { 17024d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek // All further checking is done on the subexpression. 17034d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek Ex = ICE->getSubExpr(); 17044d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ATR.matchesType(S.Context, Ex->getType())) 170596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer return true; 17064d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek } 170796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 170896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // We may be able to offer a FixItHint if it is a supported type. 170996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer PrintfSpecifier fixedFS = FS; 171096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer bool success = fixedFS.fixType(Ex->getType()); 171196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 171296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (success) { 171396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Get the fix string from the fixed format specifier 171496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::SmallString<128> buf; 171596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::raw_svector_ostream os(buf); 171696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer fixedFS.toString(os); 171796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 17189325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // FIXME: getRepresentativeType() perhaps should return a string 17199325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // instead of a QualType to better handle when the representative 17209325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // type is 'wint_t' (which is defined in the system headers). 172196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer S.Diag(getLocationOfByte(CS.getStart()), 172296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer diag::warn_printf_conversion_argument_type_mismatch) 172396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << ATR.getRepresentativeType(S.Context) << Ex->getType() 172496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << getSpecifierRange(startSpecifier, specifierLen) 172596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << Ex->getSourceRange() 172696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << FixItHint::CreateReplacement( 172796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer getSpecifierRange(startSpecifier, specifierLen), 172896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer os.str()); 172996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 173096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer else { 173196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer S.Diag(getLocationOfByte(CS.getStart()), 173296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer diag::warn_printf_conversion_argument_type_mismatch) 173396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << ATR.getRepresentativeType(S.Context) << Ex->getType() 173496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << getSpecifierRange(startSpecifier, specifierLen) 173596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << Ex->getSourceRange(); 173696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 173796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 173896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 1739e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return true; 1740e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1741e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1742826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===// 1743826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1744826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 1745826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler { 1746826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 1747826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 1748826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1749826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 1750826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 1751826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1752826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1753826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 1754826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek theCall, formatIdx) {} 1755826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1756826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 1757826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1758826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1759c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1760c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidScanfConversionSpecifier( 1761c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1762c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 1763c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen); 1764b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 1765b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek void HandleIncompleteScanList(const char *start, const char *end); 1766826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 1767826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1768826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1769b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start, 1770b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek const char *end) { 1771b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek S.Diag(getLocationOfByte(end), diag::warn_scanf_scanlist_incomplete) 1772b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek << getSpecifierRange(start, end - start); 1773b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek} 1774b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 1775c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 1776c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1777c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 1778c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen) { 1779c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 17806ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_scanf::ScanfConversionSpecifier &CS = 1781c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 1782c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1783c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1784c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 1785c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 1786c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 1787c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1788c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1789826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier( 1790826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1791826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1792826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 1793826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1794826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_scanf; 1795826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_format_string; 1796826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 17976ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 1798826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1799baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Handle case where '%' and '*' don't consume an argument. These shouldn't 1800baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // be used to decide if we are using positional arguments consistently. 1801baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 1802baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 1803baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 1804baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 1805baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1806baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 1807baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Cannot mix-and-match positional and non-positional arguments. 1808baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1809baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek diag::warn_format_mix_positional_nonpositional_args) 1810baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1811baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 1812baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1813826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1814826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1815826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Check if the field with is non-zero. 1816826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const OptionalAmount &Amt = FS.getFieldWidth(); 1817826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getHowSpecified() == OptionalAmount::Constant) { 1818826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getConstantAmount() == 0) { 1819826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 1820826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Amt.getConstantLength()); 1821826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1822826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_scanf_nonzero_width) 1823826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << R << FixItHint::CreateRemoval(R); 18247f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 18257f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 1826826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1827826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!FS.consumesDataArgument()) { 1828826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Technically specifying a precision or field width here 1829826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // makes no sense. Worth issuing a warning at some point. 1830826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 1831826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1832826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1833826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Consume the argument. 1834826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned argIndex = FS.getArgIndex(); 1835826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (argIndex < NumDataArgs) { 1836826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The check to see if the argIndex is valid will come later. 1837826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // We set the bit here because we may exit early from this 1838826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // function if we encounter some other error. 1839826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.set(argIndex); 1840826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1841826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 18421e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek // Check the length modifier is valid with the given conversion specifier. 18431e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek const LengthModifier &LM = FS.getLengthModifier(); 18441e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek if (!FS.hasValidLengthModifier()) { 18451e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek S.Diag(getLocationOfByte(LM.getStart()), 18461e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek diag::warn_format_nonsensical_length) 18471e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << LM.toString() << CS.toString() 18481e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 18491e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 18501e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek LM.getLength())); 18511e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek } 18521e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek 1853826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The remaining checks depend on the data arguments. 1854826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (HasVAListArg) 1855826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 1856826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1857666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 1858826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return false; 1859826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1860826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Check that the argument type matches the format specifier. 1861826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1862826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 186307d161f38e708a91486bf1c031d525faebbb249dTed Kremenek} 1864e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1865826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr, 18660e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const Expr *OrigFormatExpr, 18670e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const CallExpr *TheCall, bool HasVAListArg, 1868826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1869826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 1870826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1871e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: is the format string a wide literal? 18725cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!FExpr->isAscii()) { 1873e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Diag(FExpr->getLocStart(), 1874826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_string_is_wide_literal) 1875e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek << OrigFormatExpr->getSourceRange(); 1876e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 1877e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 1878826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1879e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // Str - The format string. NOTE: this is NOT null-terminated! 18805f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef StrRef = FExpr->getString(); 18812f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer const char *Str = StrRef.data(); 18822f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer unsigned StrLen = StrRef.size(); 18834cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek const unsigned numDataArgs = TheCall->getNumArgs() - firstDataArg; 1884826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1885e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: empty format string? 18864cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek if (StrLen == 0 && numDataArgs > 0) { 1887826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Diag(FExpr->getLocStart(), diag::warn_empty_format_string) 1888e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek << OrigFormatExpr->getSourceRange(); 1889e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 1890e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 1891826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1892826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (isPrintf) { 1893826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 18944cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek numDataArgs, isa<ObjCStringLiteral>(OrigFormatExpr), 18954cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek Str, HasVAListArg, TheCall, format_idx); 1896826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1897826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen)) 1898826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 1899826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1900826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek else { 1901826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 19024cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek numDataArgs, isa<ObjCStringLiteral>(OrigFormatExpr), 19034cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek Str, HasVAListArg, TheCall, format_idx); 1904826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1905826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen)) 1906826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 1907826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1908ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek} 1909ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek 19107ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth//===--- CHECK: Standard memory functions ---------------------------------===// 19117ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 19122a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// \brief Determine whether the given type is a dynamic class type (e.g., 19132a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// whether it has a vtable). 19142a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregorstatic bool isDynamicClassType(QualType T) { 19152a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Record = T->getAsCXXRecordDecl()) 19162a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Definition = Record->getDefinition()) 19172a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (Definition->isDynamicClass()) 19182a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return true; 19192a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 19202a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return false; 19212a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor} 19222a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 1923a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument expression, 1924000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth/// otherwise returns NULL. 1925000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic const Expr *getSizeOfExprArg(const Expr* E) { 1926e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber if (const UnaryExprOrTypeTraitExpr *SizeOf = 1927000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 1928000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType()) 1929000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getArgumentExpr()->IgnoreParenImpCasts(); 1930e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 1931000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return 0; 1932000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth} 1933000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 1934a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument type. 1935000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic QualType getSizeOfArgType(const Expr* E) { 1936000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryExprOrTypeTraitExpr *SizeOf = 1937000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 1938000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf) 1939000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getTypeOfArgument(); 1940000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 1941000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return QualType(); 1942e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber} 1943e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 19447ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \brief Check for dangerous or invalid arguments to memset(). 19457ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 1946929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth/// This issues warnings on known problematic, dangerous or unspecified 1947cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp' 1948cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// function calls. 19497ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 19507ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \param Call The call expression to diagnose. 1951cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gayvoid Sema::CheckMemaccessArguments(const CallExpr *Call, 1952cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay CheckedMemoryFunction CMF, 1953cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay IdentifierInfo *FnName) { 19541d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek // It is possible to have a non-standard definition of memset. Validate 1955707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor // we have enough arguments, and if not, abort further checking. 1956707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor if (Call->getNumArgs() < 3) 19571d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek return; 19581d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek 1959707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor unsigned LastArg = (CMF == CMF_Memset? 1 : 2); 1960e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber const Expr *LenExpr = Call->getArg(2)->IgnoreParenImpCasts(); 1961000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 1962000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We have special checking when the length is a sizeof expression. 1963000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth QualType SizeOfArgTy = getSizeOfArgType(LenExpr); 1964000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth const Expr *SizeOfArg = getSizeOfExprArg(LenExpr); 1965000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID SizeOfArgID; 1966000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 196706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) { 196806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts(); 1969e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange(); 197006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 197106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType DestTy = Dest->getType(); 197206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) { 197306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType PointeeTy = DestPtrTy->getPointeeType(); 1974f85e193739c953358c865005855253af4f68a497John McCall 1975000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Never warn about void type pointers. This can be used to suppress 1976000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // false positives. 1977000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isVoidType()) 197806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 197906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 1980000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by 1981000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // actually comparing the expressions for equality. Because computing the 1982000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // expression IDs can be expensive, we only do this if the diagnostic is 1983000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // enabled. 1984000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArg && 1985000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess, 1986000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->getExprLoc())) { 1987000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We only compute IDs for expressions if the warning is enabled, and 1988000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // cache the sizeof arg's ID. 1989000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgID == llvm::FoldingSetNodeID()) 1990000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->Profile(SizeOfArgID, Context, true); 1991000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID DestID; 1992000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Dest->Profile(DestID, Context, true); 1993000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (DestID == SizeOfArgID) { 1994000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth unsigned ActionIdx = 0; // Default is to suggest dereferencing. 1995000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest)) 1996000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (UnaryOp->getOpcode() == UO_AddrOf) 1997000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 1; // If its an address-of operator, just remove it. 1998000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (Context.getTypeSize(PointeeTy) == Context.getCharWidth()) 1999000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 2; // If the pointee's size is sizeof(char), 2000000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // suggest an explicit length. 2001000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(SizeOfArg->getExprLoc(), Dest, 2002000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_expr_memaccess) 2003000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << FnName << ArgIdx << ActionIdx 2004000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << Dest->getSourceRange() 2005000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << SizeOfArg->getSourceRange()); 2006000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 2007000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 2008000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 2009000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2010000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Also check for cases where the sizeof argument is the exact same 2011000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // type as the memory argument, and where it points to a user-defined 2012000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // record type. 2013000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgTy != QualType()) { 2014000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isRecordType() && 2015000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Context.typesAreCompatible(SizeOfArgTy, DestTy)) { 2016000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest, 2017000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_type_memaccess) 2018000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << FnName << SizeOfArgTy << ArgIdx 2019000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << PointeeTy << Dest->getSourceRange() 2020000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << LenExpr->getSourceRange()); 2021000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 2022000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 2023e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber } 2024e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 202506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor // Always complain about dynamic classes. 2026f85e193739c953358c865005855253af4f68a497John McCall if (isDynamicClassType(PointeeTy)) 20275c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 20285c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 20295c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_dyn_class_memaccess) 20305c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << (CMF == CMF_Memcmp ? ArgIdx + 2 : ArgIdx) << FnName << PointeeTy 20315c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay // "overwritten" if we're warning about the destination for any call 20325c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay // but memcmp; otherwise a verb appropriate to the call. 20335c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << (ArgIdx == 0 && CMF != CMF_Memcmp ? 0 : (unsigned)CMF) 20345c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 2035707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor else if (PointeeTy.hasNonTrivialObjCLifetime() && CMF != CMF_Memset) 20365c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 20375c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 20385c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_arc_object_memaccess) 20395c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << ArgIdx << FnName << PointeeTy 20405c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 2041f85e193739c953358c865005855253af4f68a497John McCall else 204206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 2043f85e193739c953358c865005855253af4f68a497John McCall 2044f85e193739c953358c865005855253af4f68a497John McCall DiagRuntimeBehavior( 2045f85e193739c953358c865005855253af4f68a497John McCall Dest->getExprLoc(), Dest, 2046929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth PDiag(diag::note_bad_memaccess_silence) 204706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)")); 204806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor break; 204906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 20507ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth } 20517ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth} 20527ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 2053bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// A little helper routine: ignore addition and subtraction of integer literals. 2054bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// This intentionally does not ignore all integer constant expressions because 2055bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// we don't want to remove sizeof(). 2056bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekstatic const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) { 2057bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = Ex->IgnoreParenCasts(); 2058bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2059bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek for (;;) { 2060bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex); 2061bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!BO || !BO->isAdditiveOp()) 2062bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 2063bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2064bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *RHS = BO->getRHS()->IgnoreParenCasts(); 2065bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *LHS = BO->getLHS()->IgnoreParenCasts(); 2066bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2067bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (isa<IntegerLiteral>(RHS)) 2068bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = LHS; 2069bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else if (isa<IntegerLiteral>(LHS)) 2070bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = RHS; 2071bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else 2072bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 2073bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2074bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2075bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return Ex; 2076bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 2077bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2078bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// Warn if the user has made the 'size' argument to strlcpy or strlcat 2079bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// be the size of the source, instead of the destination. 2080bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekvoid Sema::CheckStrlcpycatArguments(const CallExpr *Call, 2081bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek IdentifierInfo *FnName) { 2082bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2083bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Don't crash if the user has the wrong number of arguments 2084bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (Call->getNumArgs() != 3) 2085bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2086bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2087bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context); 2088bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context); 2089bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *CompareWithSrc = NULL; 2090bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2091bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, sizeof(x))' 2092bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const Expr *Ex = getSizeOfExprArg(SizeArg)) 2093bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = Ex; 2094bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else { 2095bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, strlen(x))' 2096bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) { 2097bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (SizeCall->isBuiltinCall(Context) == Builtin::BIstrlen 2098bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek && SizeCall->getNumArgs() == 1) 2099bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context); 2100bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2101bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2102bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2103bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrc) 2104bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2105bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2106bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Determine if the argument to sizeof/strlen is equal to the source 2107bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // argument. In principle there's all kinds of things you could do 2108bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // here, for instance creating an == expression and evaluating it with 2109bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // EvaluateAsBooleanCondition, but this uses a more direct technique: 2110bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg); 2111bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!SrcArgDRE) 2112bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2113bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2114bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc); 2115bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrcDRE || 2116bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl()) 2117bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2118bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2119bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *OriginalSizeArg = Call->getArg(2); 2120bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size) 2121bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek << OriginalSizeArg->getSourceRange() << FnName; 2122bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2123bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Output a FIXIT hint if the destination is an array (rather than a 2124bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointer to an array). This could be enhanced to handle some 2125bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointers if we know the actual size, like if DstArg is 'array+2' 2126bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // we could say 'sizeof(array)-2'. 2127bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts(); 21288f7462237ff542a4556775f98709ed300aa1731aTed Kremenek QualType DstArgTy = DstArg->getType(); 2129bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 21308f7462237ff542a4556775f98709ed300aa1731aTed Kremenek // Only handle constant-sized or VLAs, but not flexible members. 21318f7462237ff542a4556775f98709ed300aa1731aTed Kremenek if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(DstArgTy)) { 21328f7462237ff542a4556775f98709ed300aa1731aTed Kremenek // Only issue the FIXIT for arrays of size > 1. 21338f7462237ff542a4556775f98709ed300aa1731aTed Kremenek if (CAT->getSize().getSExtValue() <= 1) 21348f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 21358f7462237ff542a4556775f98709ed300aa1731aTed Kremenek } else if (!DstArgTy->isVariableArrayType()) { 21368f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 2137bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 21388f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 21398f7462237ff542a4556775f98709ed300aa1731aTed Kremenek llvm::SmallString<128> sizeString; 21408f7462237ff542a4556775f98709ed300aa1731aTed Kremenek llvm::raw_svector_ostream OS(sizeString); 21418f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << "sizeof("; 21428987b2385d9ba63ada66e1344ace79b04d5cb5c3Douglas Gregor DstArg->printPretty(OS, Context, 0, getPrintingPolicy()); 21438f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << ")"; 21448f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 21458f7462237ff542a4556775f98709ed300aa1731aTed Kremenek Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size) 21468f7462237ff542a4556775f98709ed300aa1731aTed Kremenek << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(), 21478f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS.str()); 2148bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 2149bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 215006de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===// 215106de276fff91264437fa75111ed76de43097e089Ted Kremenek 21525f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars); 21535f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars); 215406de276fff91264437fa75111ed76de43097e089Ted Kremenek 215506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address 215606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable. 215706de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid 215806de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 215906de276fff91264437fa75111ed76de43097e089Ted Kremenek SourceLocation ReturnLoc) { 21601eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 216126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Expr *stackE = 0; 21625f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<DeclRefExpr *, 8> refVars; 21634e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 216426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Perform checking for returned stack addresses, local blocks, 216526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // label addresses or references to temporaries. 2166f85e193739c953358c865005855253af4f68a497John McCall if (lhsType->isPointerType() || 2167f85e193739c953358c865005855253af4f68a497John McCall (!getLangOptions().ObjCAutoRefCount && lhsType->isBlockPointerType())) { 216826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalAddr(RetValExp, refVars); 2169ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (lhsType->isReferenceType()) { 217026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalVal(RetValExp, refVars); 217126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 217226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 217326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (stackE == 0) 217426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return; // Nothing suspicious was found. 217526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 217626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceLocation diagLoc; 217726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange diagRange; 217826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (refVars.empty()) { 217926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = stackE->getLocStart(); 218026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = stackE->getSourceRange(); 218126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { 218226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // We followed through a reference variable. 'stackE' contains the 218326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // problematic expression but we will warn at the return statement pointing 218426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // at the reference variable. We will later display the "trail" of 218526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // reference variables using notes. 218626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = refVars[0]->getLocStart(); 218726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = refVars[0]->getSourceRange(); 218826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 218926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 219026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var. 219126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref 219226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_stack_addr) 219326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << DR->getDecl()->getDeclName() << diagRange; 219426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<BlockExpr>(stackE)) { // local block. 219526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::err_ret_local_block) << diagRange; 219626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 219726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 219826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { // local temporary. 219926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref 220026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_local_temp_addr) 220126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << diagRange; 220226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 220326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 220426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Display the "trail" of reference variables that we followed until we 220526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // found the problematic expression using notes. 220626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 220726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 220826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this var binds to another reference var, show the range of the next 220926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // var, otherwise the var binds to the problematic expression, in which case 221026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // show the range of the expression. 221126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange() 221226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : stackE->getSourceRange(); 221326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(VD->getLocation(), diag::note_ref_var_local_bind) 221426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << VD->getDeclName() << range; 221506de276fff91264437fa75111ed76de43097e089Ted Kremenek } 221606de276fff91264437fa75111ed76de43097e089Ted Kremenek} 221706de276fff91264437fa75111ed76de43097e089Ted Kremenek 221806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 221906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// check if the expression in a return statement evaluates to an address 222026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// to a location on the stack, a local block, an address of a label, or a 222126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// reference to local temporary. The recursion is used to traverse the 222206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// AST of the return expression, with recursion backtracking when we 222326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// encounter a subexpression that (1) clearly does not lead to one of the 222426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// above problematic expressions (2) is something we cannot determine leads to 222526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// a problematic expression based on such local checking. 222626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 222726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// Both EvalAddr and EvalVal follow through reference variables to evaluate 222826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// the expression that they point to. Such variables are added to the 222926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 'refVars' vector so that we know what the reference variable "trail" was. 223006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 2231e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// EvalAddr processes expressions that are pointers that are used as 2232e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// references (and not L-values). EvalVal handles all other values. 223326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// At the base case of the recursion is a check for the above problematic 223426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// expressions. 223506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 223606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// This implementation handles: 223706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 223806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer-to-pointer casts 223906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * implicit conversions from array references to pointers 224006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of fields 224106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * arbitrary interplay between "&" and "*" operators 224206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer arithmetic from an address of a stack variable 224306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of an array element where the array is on the stack 22445f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars) { 224526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (E->isTypeDependent()) 224626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 224726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 224806de276fff91264437fa75111ed76de43097e089Ted Kremenek // We should only be called for evaluating pointer expressions. 22490f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall assert((E->getType()->isAnyPointerType() || 2250dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff E->getType()->isBlockPointerType() || 2251a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek E->getType()->isObjCQualifiedIdType()) && 2252fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner "EvalAddr only works on pointers"); 22531eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2254f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 2255f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 225606de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 225706de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 225806de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 225906de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 226026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::DeclRefExprClass: { 226126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis DeclRefExpr *DR = cast<DeclRefExpr>(E); 226226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 226326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 226426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this is a reference variable, follow through to the expression that 226526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 226626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage() && 226726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis V->getType()->isReferenceType() && V->hasInit()) { 226826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 226926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 227026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(V->getInit(), refVars); 227126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 227226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 227326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 227426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 227506de276fff91264437fa75111ed76de43097e089Ted Kremenek 2276fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::UnaryOperatorClass: { 2277fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // The only unary operator that make sense to handle here 2278fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // is AddrOf. All others don't make sense as pointers. 2279fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner UnaryOperator *U = cast<UnaryOperator>(E); 22801eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 22812de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_AddrOf) 228226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(U->getSubExpr(), refVars); 2283fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 2284fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 2285fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 22861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2287fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::BinaryOperatorClass: { 2288fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle pointer arithmetic. All other binary operators are not valid 2289fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // in this context. 2290fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner BinaryOperator *B = cast<BinaryOperator>(E); 22912de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = B->getOpcode(); 22921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 22932de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op != BO_Add && op != BO_Sub) 2294fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 22951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2296fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner Expr *Base = B->getLHS(); 22973907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 2298fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Determine which argument is the real pointer base. It could be 2299fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // the RHS argument instead of the LHS. 2300fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner if (!Base->getType()->isPointerType()) Base = B->getRHS(); 23011eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2302fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner assert (Base->getType()->isPointerType()); 230326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(Base, refVars); 2304fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 230561f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff 2306fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // For conditional operators we need to see if either the LHS or RHS are 2307fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // valid DeclRefExpr*s. If one of them is valid, we return it. 2308fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ConditionalOperatorClass: { 2309fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner ConditionalOperator *C = cast<ConditionalOperator>(E); 23101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2311fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle the GNU extension for missing LHS. 23129ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (Expr *lhsExpr = C->getLHS()) { 23139ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 23149ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (!lhsExpr->getType()->isVoidType()) 231526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr* LHS = EvalAddr(lhsExpr, refVars)) 23169ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return LHS; 23179ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor } 23189ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor 23199ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 23209ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (C->getRHS()->getType()->isVoidType()) 23219ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return NULL; 232206de276fff91264437fa75111ed76de43097e089Ted Kremenek 232326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(C->getRHS(), refVars); 2324fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 232526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 232626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::BlockExprClass: 2327469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures()) 232826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // local block. 232926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 233026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 233126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::AddrLabelExprClass: 233226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // address of label. 23331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 233454b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // For casts, we need to handle conversions from arrays to 233554b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // pointer values, and pointer-to-pointer conversions. 233649badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::ImplicitCastExprClass: 23376eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor case Stmt::CStyleCastExprClass: 2338f85e193739c953358c865005855253af4f68a497John McCall case Stmt::CXXFunctionalCastExprClass: 2339f85e193739c953358c865005855253af4f68a497John McCall case Stmt::ObjCBridgedCastExprClass: { 23400835a3cdeefe714b4959d31127ea155e56393125Argyrios Kyrtzidis Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 234154b5274f2c190331438375ad114dad12ae098b57Ted Kremenek QualType T = SubExpr->getType(); 23421eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2343dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (SubExpr->getType()->isPointerType() || 2344dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isBlockPointerType() || 2345dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isObjCQualifiedIdType()) 234626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(SubExpr, refVars); 234754b5274f2c190331438375ad114dad12ae098b57Ted Kremenek else if (T->isArrayType()) 234826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(SubExpr, refVars); 2349fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 235054b5274f2c190331438375ad114dad12ae098b57Ted Kremenek return 0; 2351fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 23521eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2353fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // C++ casts. For dynamic casts, static casts, and const casts, we 2354fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // are always converting from a pointer-to-pointer, so we just blow 235549badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // through the cast. In the case the dynamic cast doesn't fail (and 235649badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // return NULL), we take the conservative route and report cases 2357fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // where we return the address of a stack variable. For Reinterpre 235849badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // FIXME: The comment about is wrong; we're not always converting 235949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // from pointer to pointer. I'm guessing that this code should also 23601eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // handle references to objects. 23611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXStaticCastExprClass: 23621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXDynamicCastExprClass: 236349badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXConstCastExprClass: 236449badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXReinterpretCastExprClass: { 236549badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr(); 2366dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (S->getType()->isPointerType() || S->getType()->isBlockPointerType()) 236726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(S, refVars); 236806de276fff91264437fa75111ed76de43097e089Ted Kremenek else 236906de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 2370fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 23711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 237203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 237303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalAddr( 237403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 237503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor refVars)) 237603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 237703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 237803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 237903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 2380fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Everything else: we simply don't reason about them. 2381fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner default: 2382fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 238306de276fff91264437fa75111ed76de43097e089Ted Kremenek } 238406de276fff91264437fa75111ed76de43097e089Ted Kremenek} 23851eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 238606de276fff91264437fa75111ed76de43097e089Ted Kremenek 238706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalVal - This function is complements EvalAddr in the mutual recursion. 238806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// See the comments for EvalAddr for more details. 23895f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars) { 239068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo { 2391e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // We should only be called for evaluating non-pointer expressions, or 2392e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // expressions with a pointer type that are not used as references but instead 2393e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // are l-values (e.g., DeclRefExpr with a pointer type). 23941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 239506de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 239606de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 239706de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 2398f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 2399f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 240006de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 240168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ImplicitCastExprClass: { 240268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 24035baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall if (IE->getValueKind() == VK_LValue) { 240468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = IE->getSubExpr(); 240568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 240668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 240768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek return NULL; 240868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 240968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek 2410a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor case Stmt::DeclRefExprClass: { 241126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // When we hit a DeclRefExpr we are looking at code that refers to a 241226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // variable's name. If it's not a reference variable we check if it has 241326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // local storage within the function, and if so, return the expression. 241406de276fff91264437fa75111ed76de43097e089Ted Kremenek DeclRefExpr *DR = cast<DeclRefExpr>(E); 24151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 241606de276fff91264437fa75111ed76de43097e089Ted Kremenek if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 241726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage()) { 241826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!V->getType()->isReferenceType()) 241926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return DR; 242026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 242126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Reference variable, follow through to the expression that 242226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 242326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasInit()) { 242426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 242526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 242626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(V->getInit(), refVars); 242726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 242826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 24291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 243006de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 243106de276fff91264437fa75111ed76de43097e089Ted Kremenek } 24321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 243306de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::UnaryOperatorClass: { 243406de276fff91264437fa75111ed76de43097e089Ted Kremenek // The only unary operator that make sense to handle here 243506de276fff91264437fa75111ed76de43097e089Ted Kremenek // is Deref. All others don't resolve to a "name." This includes 243606de276fff91264437fa75111ed76de43097e089Ted Kremenek // handling all sorts of rvalues passed to a unary operator. 243706de276fff91264437fa75111ed76de43097e089Ted Kremenek UnaryOperator *U = cast<UnaryOperator>(E); 24381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 24392de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_Deref) 244026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(U->getSubExpr(), refVars); 244106de276fff91264437fa75111ed76de43097e089Ted Kremenek 244206de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 244306de276fff91264437fa75111ed76de43097e089Ted Kremenek } 24441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 244506de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ArraySubscriptExprClass: { 244606de276fff91264437fa75111ed76de43097e089Ted Kremenek // Array subscripts are potential references to data on the stack. We 244706de276fff91264437fa75111ed76de43097e089Ted Kremenek // retrieve the DeclRefExpr* for the array variable if it indeed 244806de276fff91264437fa75111ed76de43097e089Ted Kremenek // has local storage. 244926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars); 245006de276fff91264437fa75111ed76de43097e089Ted Kremenek } 24511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 245206de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ConditionalOperatorClass: { 245306de276fff91264437fa75111ed76de43097e089Ted Kremenek // For conditional operators we need to see if either the LHS or RHS are 245426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // non-NULL Expr's. If one is non-NULL, we return it. 245506de276fff91264437fa75111ed76de43097e089Ted Kremenek ConditionalOperator *C = cast<ConditionalOperator>(E); 245606de276fff91264437fa75111ed76de43097e089Ted Kremenek 24573907323dd6665c0c4e383435cb145233f4533406Anders Carlsson // Handle the GNU extension for missing LHS. 24583907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (Expr *lhsExpr = C->getLHS()) 245926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr *LHS = EvalVal(lhsExpr, refVars)) 24603907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return LHS; 24613907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 246226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(C->getRHS(), refVars); 246306de276fff91264437fa75111ed76de43097e089Ted Kremenek } 24641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 246506de276fff91264437fa75111ed76de43097e089Ted Kremenek // Accesses to members are potential references to data on the stack. 246683f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor case Stmt::MemberExprClass: { 246706de276fff91264437fa75111ed76de43097e089Ted Kremenek MemberExpr *M = cast<MemberExpr>(E); 24681eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 246906de276fff91264437fa75111ed76de43097e089Ted Kremenek // Check for indirect access. We only want direct field accesses. 2470a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->isArrow()) 2471a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return NULL; 2472a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 2473a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // Check whether the member type is itself a reference, in which case 2474a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // we're not going to refer to the member, but to what the member refers to. 2475a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->getMemberDecl()->getType()->isReferenceType()) 247606de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 2477a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 247826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(M->getBase(), refVars); 247906de276fff91264437fa75111ed76de43097e089Ted Kremenek } 24801eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 248103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 248203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalVal( 248303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 248403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor refVars)) 248503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 248603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 248703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 248803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 248906de276fff91264437fa75111ed76de43097e089Ted Kremenek default: 249026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Check that we don't return or take the address of a reference to a 249126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // temporary. This is only useful in C++. 249226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!E->isTypeDependent() && E->isRValue()) 249326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; 249426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 249526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Everything else: we simply don't reason about them. 249606de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 249706de276fff91264437fa75111ed76de43097e089Ted Kremenek } 249868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true); 249906de276fff91264437fa75111ed76de43097e089Ted Kremenek} 2500588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2501588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 2502588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2503588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==. 2504588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely 2505588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended. 2506dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieuvoid Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) { 2507588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek bool EmitWarning = true; 25081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2509dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts(); 2510dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* RightExprSansParen = RHS->IgnoreParenImpCasts(); 2511588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2512588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Special case: check for x == x (which is OK). 2513588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Do not emit warnings for such cases. 2514588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 2515588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 2516588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DRL->getDecl() == DRR->getDecl()) 2517588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 25181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 25191eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 25201b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // Special case: check for comparisons against literals that can be exactly 25211b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // represented by APFloat. In such cases, do not emit a warning. This 25221b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // is a heuristic: often comparison against such literals are used to 25231b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // detect if a value in a variable has not changed. This clearly can 25241b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // lead to false negatives. 25251b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (EmitWarning) { 25261b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 25271b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLL->isExact()) 25281b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 2529ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else 25301b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){ 25311b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLR->isExact()) 25321b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 25331b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 25341b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 25351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2536588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Check for comparisons with builtin types. 25370eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 2538588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 25393c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor if (CL->isBuiltinCall(Context)) 2540588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 25411eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 25420eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 2543588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 25443c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor if (CR->isBuiltinCall(Context)) 2545588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 25461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2547588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Emit the diagnostic. 2548588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (EmitWarning) 2549dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Diag(Loc, diag::warn_floatingpoint_eq) 2550dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu << LHS->getSourceRange() << RHS->getSourceRange(); 2551588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek} 2552ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2553f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 2554f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 2555ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2556f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace { 2557ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2558f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued 2559f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression. 2560f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange { 2561f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// The number of bits active in the int. 2562f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned Width; 2563ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2564f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// True if the int is known not to have negative values. 2565f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool NonNegative; 256651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2567f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange(unsigned Width, bool NonNegative) 2568f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : Width(Width), NonNegative(NonNegative) 2569f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall {} 257051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 25711844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of the bool type. 2572f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall static IntRange forBoolType() { 2573f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(1, true); 2574f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 257551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 25761844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of the given integral type. 25771844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfType(ASTContext &C, QualType T) { 25781844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return forValueOfCanonicalType(C, 25791844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T->getCanonicalTypeInternal().getTypePtr()); 258051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 258151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 25821844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of a canonical integral type. 25831844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 2584f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(T->isCanonicalUnqualified()); 258551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2586f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 2587f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = VT->getElementType().getTypePtr(); 2588f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 2589f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = CT->getElementType().getTypePtr(); 2590323ed74658bc8375278eabf074b4777458376540John McCall 2591091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // For enum types, use the known bit width of the enumerators. 2592323ed74658bc8375278eabf074b4777458376540John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) { 2593323ed74658bc8375278eabf074b4777458376540John McCall EnumDecl *Enum = ET->getDecl(); 2594091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Enum->isDefinition()) 2595091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return IntRange(C.getIntWidth(QualType(T, 0)), false); 2596091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2597323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumPositive = Enum->getNumPositiveBits(); 2598323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumNegative = Enum->getNumNegativeBits(); 2599323ed74658bc8375278eabf074b4777458376540John McCall 2600323ed74658bc8375278eabf074b4777458376540John McCall return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0); 2601323ed74658bc8375278eabf074b4777458376540John McCall } 260251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2603f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const BuiltinType *BT = cast<BuiltinType>(T); 2604f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(BT->isInteger()); 260551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2606f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 260751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 260851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 26091844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the "target" range of a canonical integral type, i.e. 26101844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// the range of values expressible in the type. 26111844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// 26121844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// This matches forValueOfCanonicalType except that enums have the 26131844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// full range of their type, not the range of their enumerators. 26141844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 26151844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(T->isCanonicalUnqualified()); 26161844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 26171844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 26181844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = VT->getElementType().getTypePtr(); 26191844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 26201844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = CT->getElementType().getTypePtr(); 26211844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) 262269ff26bd1e7a2faffec0c3b9740cfb0c6bb354c5Douglas Gregor T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr(); 26231844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 26241844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall const BuiltinType *BT = cast<BuiltinType>(T); 26251844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(BT->isInteger()); 26261844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 26271844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 26281844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall } 26291844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 26301844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the supremum of two ranges: i.e. their conservative merge. 2631c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange join(IntRange L, IntRange R) { 2632f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(std::max(L.Width, R.Width), 263360fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative && R.NonNegative); 263460fad45739b764886f707bd204eae9ecce6db1f2John McCall } 263560fad45739b764886f707bd204eae9ecce6db1f2John McCall 26361844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the infinum of two ranges: i.e. their aggressive merge. 2637c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange meet(IntRange L, IntRange R) { 263860fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange(std::min(L.Width, R.Width), 263960fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative || R.NonNegative); 264051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 2641f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}; 264251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2643f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) { 2644f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isSigned() && value.isNegative()) 2645f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getMinSignedBits(), false); 264651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2647f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.getBitWidth() > MaxWidth) 26489f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad value = value.trunc(MaxWidth); 264951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2650f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // isNonNegative() just checks the sign bit without considering 2651f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // signedness. 2652f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getActiveBits(), true); 265351313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 265451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 26550acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCallIntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 2656f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned MaxWidth) { 2657f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isInt()) 2658f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetValueRange(C, result.getInt(), MaxWidth); 265951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2660f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isVector()) { 26610acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 26620acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 26630acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 26640acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall R = IntRange::join(R, El); 26650acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall } 2666f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return R; 266751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 266851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2669f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isComplexInt()) { 2670f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 2671f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 2672f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(R, I); 2673f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2674f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2675f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // This can happen with lossless casts to intptr_t of "based" lvalues. 2676f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume it might use arbitrary bits. 26770acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // FIXME: The only reason we need to pass the type in here is to get 26780acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // the sign right on this one case. It would be nice if APValue 26790acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // preserved this. 2680f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(result.isLValue()); 26815e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType()); 268251313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 268351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2684f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the 2685f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take. 2686f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 2687f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated 2688f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 268951313c39c84407dd6a323be99a8c322bf8d052a9John McCall E = E->IgnoreParens(); 269051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2691f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Try a full evaluation first. 2692f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall Expr::EvalResult result; 2693f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (E->Evaluate(result, C)) 26940acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall return GetValueRange(C, result.Val, E->getType(), MaxWidth); 269551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2696f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // I think we only want to look through implicit casts here; if the 2697f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // user has an explicit widening cast, we should treat the value as 2698f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // being of the new, wider type. 2699f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 27002de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (CE->getCastKind() == CK_NoOp) 2701f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CE->getSubExpr(), MaxWidth); 270251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 27031844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType()); 270451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 27052de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 270660fad45739b764886f707bd204eae9ecce6db1f2John McCall 2707f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume that non-integer casts can span the full range of the type. 270860fad45739b764886f707bd204eae9ecce6db1f2John McCall if (!isIntegerCast) 2709f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 271051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2711f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange SubRange 2712f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall = GetExprRange(C, CE->getSubExpr(), 2713f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall std::min(MaxWidth, OutputTypeRange.Width)); 271451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2715f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Bail out if the subexpr's range is as wide as the cast type. 2716f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SubRange.Width >= OutputTypeRange.Width) 2717f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 271851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2719f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, we take the smaller width, and we're non-negative if 2720f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // either the output type or the subexpr is. 2721f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(SubRange.Width, 2722f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall SubRange.NonNegative || OutputTypeRange.NonNegative); 2723f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2724f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2725f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 2726f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // If we can fold the condition, just take that operand. 2727f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool CondResult; 2728f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 2729f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CondResult ? CO->getTrueExpr() 2730f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : CO->getFalseExpr(), 2731f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall MaxWidth); 2732f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2733f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, conservatively merge. 2734f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 2735f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 2736f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 273751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 273851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 273951313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 274051313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (BO->getOpcode()) { 274151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2742f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Boolean-valued operations are single-bit and positive. 27432de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LAnd: 27442de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LOr: 27452de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LT: 27462de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GT: 27472de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LE: 27482de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GE: 27492de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_EQ: 27502de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_NE: 2751f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 275251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2753862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // The type of the assignments is the type of the LHS, so the RHS 2754862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // is not necessarily the same type. 27552de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_MulAssign: 27562de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_DivAssign: 27572de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_RemAssign: 27582de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AddAssign: 27592de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_SubAssign: 2760862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_XorAssign: 2761862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_OrAssign: 2762862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 27631844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 2764c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall 2765862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // Simple assignments just pass through the RHS, which will have 2766862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // been coerced to the LHS type. 2767862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_Assign: 2768862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 2769862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 2770862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall 277151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 27722de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemD: 27732de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemI: 27741844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 277551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 277660fad45739b764886f707bd204eae9ecce6db1f2John McCall // Bitwise-and uses the *infinum* of the two source ranges. 27772de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_And: 27782de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AndAssign: 277960fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 278060fad45739b764886f707bd204eae9ecce6db1f2John McCall GetExprRange(C, BO->getRHS(), MaxWidth)); 278160fad45739b764886f707bd204eae9ecce6db1f2John McCall 278251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Left shift gets black-listed based on a judgement call. 27832de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shl: 27843aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // ...except that we want to treat '1 << (blah)' as logically 27853aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // positive. It's an important idiom. 27863aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (IntegerLiteral *I 27873aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 27883aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (I->getValue() == 1) { 27891844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange R = IntRange::forValueOfType(C, E->getType()); 27903aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall return IntRange(R.Width, /*NonNegative*/ true); 27913aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 27923aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 27933aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // fallthrough 27943aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall 27952de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShlAssign: 27961844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 279751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 279860fad45739b764886f707bd204eae9ecce6db1f2John McCall // Right shift by a constant can narrow its left argument. 27992de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shr: 28002de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShrAssign: { 280160fad45739b764886f707bd204eae9ecce6db1f2John McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 280260fad45739b764886f707bd204eae9ecce6db1f2John McCall 280360fad45739b764886f707bd204eae9ecce6db1f2John McCall // If the shift amount is a positive constant, drop the width by 280460fad45739b764886f707bd204eae9ecce6db1f2John McCall // that much. 280560fad45739b764886f707bd204eae9ecce6db1f2John McCall llvm::APSInt shift; 280660fad45739b764886f707bd204eae9ecce6db1f2John McCall if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 280760fad45739b764886f707bd204eae9ecce6db1f2John McCall shift.isNonNegative()) { 280860fad45739b764886f707bd204eae9ecce6db1f2John McCall unsigned zext = shift.getZExtValue(); 280960fad45739b764886f707bd204eae9ecce6db1f2John McCall if (zext >= L.Width) 281060fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width = (L.NonNegative ? 0 : 1); 281160fad45739b764886f707bd204eae9ecce6db1f2John McCall else 281260fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width -= zext; 281360fad45739b764886f707bd204eae9ecce6db1f2John McCall } 281460fad45739b764886f707bd204eae9ecce6db1f2John McCall 281560fad45739b764886f707bd204eae9ecce6db1f2John McCall return L; 281660fad45739b764886f707bd204eae9ecce6db1f2John McCall } 281760fad45739b764886f707bd204eae9ecce6db1f2John McCall 281860fad45739b764886f707bd204eae9ecce6db1f2John McCall // Comma acts as its right operand. 28192de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Comma: 2820f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 2821f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 282260fad45739b764886f707bd204eae9ecce6db1f2John McCall // Black-list pointer subtractions. 28232de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Sub: 282451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BO->getLHS()->getType()->isPointerType()) 28251844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 282600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall break; 282700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 282800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The width of a division result is mostly determined by the size 282900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // of the LHS. 283000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Div: { 283100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 283200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 283300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 283400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 283500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // If the divisor is constant, use that. 283600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall llvm::APSInt divisor; 283700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) { 283800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned log2 = divisor.logBase2(); // floor(log_2(divisor)) 283900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (log2 >= L.Width) 284000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = (L.NonNegative ? 0 : 1); 284100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall else 284200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = std::min(L.Width - log2, MaxWidth); 284300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return L; 284400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 284500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 284600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Otherwise, just use the LHS's width. 284700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 284800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return IntRange(L.Width, L.NonNegative && R.NonNegative); 284900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 285000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 285100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The result of a remainder can't be larger than the result of 285200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // either side. 285300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Rem: { 285400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 285500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 285600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 285700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 285800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 285900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange meet = IntRange::meet(L, R); 286000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall meet.Width = std::min(meet.Width, MaxWidth); 286100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return meet; 286200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 28634e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 286400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default behavior is okay for these. 286500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Mul: 286600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Add: 286700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Xor: 286800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Or: 2869f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall break; 287051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 2871f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 287200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default case is to treat the operation as if it were closed 287300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // on the narrowest type that encompasses both operands. 2874f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 2875f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 2876f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 287751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 287851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 287951313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 288051313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (UO->getOpcode()) { 288151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Boolean-valued operations are white-listed. 28822de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_LNot: 2883f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 288451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 288551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 28862de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_Deref: 28872de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_AddrOf: // should be impossible 28881844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 288951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 289051313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 2891f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, UO->getSubExpr(), MaxWidth); 289251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 289351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 28948ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor 28958ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor if (dyn_cast<OffsetOfExpr>(E)) { 28961844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange::forValueOfType(C, E->getType()); 28978ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor } 289851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2899f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall FieldDecl *BitField = E->getBitField(); 2900f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (BitField) { 2901f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APSInt BitWidthAP = BitField->getBitWidth()->EvaluateAsInt(C); 2902f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned BitWidth = BitWidthAP.getZExtValue(); 290351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 29045e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor return IntRange(BitWidth, 29055e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor BitField->getType()->isUnsignedIntegerOrEnumerationType()); 2906f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2907f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 29081844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 2909f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 2910f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2911323ed74658bc8375278eabf074b4777458376540John McCallIntRange GetExprRange(ASTContext &C, Expr *E) { 2912323ed74658bc8375278eabf074b4777458376540John McCall return GetExprRange(C, E, C.getIntWidth(E->getType())); 2913323ed74658bc8375278eabf074b4777458376540John McCall} 2914323ed74658bc8375278eabf074b4777458376540John McCall 2915f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 2916f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 2917f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 2918f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const llvm::APFloat &value, 2919f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 2920f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 2921f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APFloat truncated = value; 2922f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2923f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool ignored; 2924f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 2925f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 2926f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2927f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return truncated.bitwiseIsEqual(value); 292851313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 292951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2930f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 2931f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 2932f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 2933f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 2934f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number). 2935f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const APValue &value, 2936f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 2937f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 2938f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isFloat()) 2939f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 2940f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2941f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isVector()) { 2942f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 2943f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 2944f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return false; 2945f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return true; 2946f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2947f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2948f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(value.isComplexFloat()); 2949f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 2950f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 2951f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 2952f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2953b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 2954323ed74658bc8375278eabf074b4777458376540John McCall 2955e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) { 2956e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where we are comparing against an enum constant. 2957e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (const DeclRefExpr *DR = 2958e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 2959e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (isa<EnumConstantDecl>(DR->getDecl())) 2960e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 2961e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 2962e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where the '0' value is expanded from a macro. 2963e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (E->getLocStart().isMacroID()) 2964e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 2965e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 2966323ed74658bc8375278eabf074b4777458376540John McCall llvm::APSInt Value; 2967323ed74658bc8375278eabf074b4777458376540John McCall return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 2968323ed74658bc8375278eabf074b4777458376540John McCall} 2969323ed74658bc8375278eabf074b4777458376540John McCall 2970372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) { 2971372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall // Strip off implicit integral promotions. 2972372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 297363b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis if (ICE->getCastKind() != CK_IntegralCast && 297463b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis ICE->getCastKind() != CK_NoOp) 2975372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall break; 297663b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis E = ICE->getSubExpr(); 2977372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall } 2978372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 2979372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall return E->getType()->isEnumeralType(); 2980372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall} 2981372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 2982323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 29832de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = E->getOpcode(); 298414af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor if (E->isValueDependent()) 298514af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor return; 298614af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor 29872de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op == BO_LT && IsZero(S, E->getRHS())) { 2988323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 2989372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "< 0" << "false" << HasEnumType(E->getLHS()) 2990323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 29912de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GE && IsZero(S, E->getRHS())) { 2992323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 2993372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << ">= 0" << "true" << HasEnumType(E->getLHS()) 2994323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 29952de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GT && IsZero(S, E->getLHS())) { 2996323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 2997372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 >" << "false" << HasEnumType(E->getRHS()) 2998323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 29992de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_LE && IsZero(S, E->getLHS())) { 3000323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 3001372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 <=" << "true" << HasEnumType(E->getRHS()) 3002323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 3003323ed74658bc8375278eabf074b4777458376540John McCall } 3004323ed74658bc8375278eabf074b4777458376540John McCall} 3005323ed74658bc8375278eabf074b4777458376540John McCall 3006323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison. Implements the 3007323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison. 3008323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 3009b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 3010b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 3011323ed74658bc8375278eabf074b4777458376540John McCall} 3012f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3013ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare. 3014ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// 3015dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu/// \param E the binary operator to check for warnings 3016323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeComparison(Sema &S, BinaryOperator *E) { 3017323ed74658bc8375278eabf074b4777458376540John McCall // The type the comparison is being performed in. 3018323ed74658bc8375278eabf074b4777458376540John McCall QualType T = E->getLHS()->getType(); 3019323ed74658bc8375278eabf074b4777458376540John McCall assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 3020323ed74658bc8375278eabf074b4777458376540John McCall && "comparison with mismatched types"); 3021323ed74658bc8375278eabf074b4777458376540John McCall 3022323ed74658bc8375278eabf074b4777458376540John McCall // We don't do anything special if this isn't an unsigned integral 3023323ed74658bc8375278eabf074b4777458376540John McCall // comparison: we're only interested in integral comparisons, and 3024323ed74658bc8375278eabf074b4777458376540John McCall // signed comparisons only happen in cases we don't care to warn about. 30253e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // 30263e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // We also don't care about value-dependent expressions or expressions 30273e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // whose result is a constant. 30283e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor if (!T->hasUnsignedIntegerRepresentation() 30293e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor || E->isValueDependent() || E->isIntegerConstantExpr(S.Context)) 3030323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 3031323ed74658bc8375278eabf074b4777458376540John McCall 3032dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr *LHS = E->getLHS()->IgnoreParenImpCasts(); 3033dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr *RHS = E->getRHS()->IgnoreParenImpCasts(); 3034323ed74658bc8375278eabf074b4777458376540John McCall 3035323ed74658bc8375278eabf074b4777458376540John McCall // Check to see if one of the (unmodified) operands is of different 3036323ed74658bc8375278eabf074b4777458376540John McCall // signedness. 3037323ed74658bc8375278eabf074b4777458376540John McCall Expr *signedOperand, *unsignedOperand; 3038dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu if (LHS->getType()->hasSignedIntegerRepresentation()) { 3039dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu assert(!RHS->getType()->hasSignedIntegerRepresentation() && 3040323ed74658bc8375278eabf074b4777458376540John McCall "unsigned comparison between two signed integer expressions?"); 3041dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = LHS; 3042dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = RHS; 3043dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu } else if (RHS->getType()->hasSignedIntegerRepresentation()) { 3044dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = RHS; 3045dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = LHS; 3046ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } else { 3047323ed74658bc8375278eabf074b4777458376540John McCall CheckTrivialUnsignedComparison(S, E); 3048323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 3049ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } 3050ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3051323ed74658bc8375278eabf074b4777458376540John McCall // Otherwise, calculate the effective range of the signed operand. 3052323ed74658bc8375278eabf074b4777458376540John McCall IntRange signedRange = GetExprRange(S.Context, signedOperand); 3053f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3054323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and analyze implicit conversions in the operands. Note 3055323ed74658bc8375278eabf074b4777458376540John McCall // that we skip the implicit conversions on both sides. 3056dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc()); 3057dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc()); 3058ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3059323ed74658bc8375278eabf074b4777458376540John McCall // If the signed range is non-negative, -Wsign-compare won't fire, 3060323ed74658bc8375278eabf074b4777458376540John McCall // but we should still check for comparisons which are always true 3061323ed74658bc8375278eabf074b4777458376540John McCall // or false. 3062323ed74658bc8375278eabf074b4777458376540John McCall if (signedRange.NonNegative) 3063323ed74658bc8375278eabf074b4777458376540John McCall return CheckTrivialUnsignedComparison(S, E); 3064ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3065ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // For (in)equality comparisons, if the unsigned operand is a 3066ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // constant which cannot collide with a overflowed signed operand, 3067ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // then reinterpreting the signed operand as unsigned will not 3068ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // change the result of the comparison. 3069323ed74658bc8375278eabf074b4777458376540John McCall if (E->isEqualityOp()) { 3070323ed74658bc8375278eabf074b4777458376540John McCall unsigned comparisonWidth = S.Context.getIntWidth(T); 3071323ed74658bc8375278eabf074b4777458376540John McCall IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 3072323ed74658bc8375278eabf074b4777458376540John McCall 3073323ed74658bc8375278eabf074b4777458376540John McCall // We should never be unable to prove that the unsigned operand is 3074323ed74658bc8375278eabf074b4777458376540John McCall // non-negative. 3075323ed74658bc8375278eabf074b4777458376540John McCall assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 3076ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3077323ed74658bc8375278eabf074b4777458376540John McCall if (unsignedRange.Width < comparisonWidth) 3078323ed74658bc8375278eabf074b4777458376540John McCall return; 3079323ed74658bc8375278eabf074b4777458376540John McCall } 3080323ed74658bc8375278eabf074b4777458376540John McCall 3081323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison) 3082dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu << LHS->getType() << RHS->getType() 3083dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu << LHS->getSourceRange() << RHS->getSourceRange(); 3084ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall} 3085ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 308615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield. 308715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// 308815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt. 308915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallbool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 309015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall SourceLocation InitLoc) { 309115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall assert(Bitfield->isBitField()); 309215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Bitfield->isInvalidDecl()) 309315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 309415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 309591b6014876e9186f968f74a8975ab8fc08ef1b68John McCall // White-list bool bitfields. 309691b6014876e9186f968f74a8975ab8fc08ef1b68John McCall if (Bitfield->getType()->isBooleanType()) 309791b6014876e9186f968f74a8975ab8fc08ef1b68John McCall return false; 309891b6014876e9186f968f74a8975ab8fc08ef1b68John McCall 309946ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor // Ignore value- or type-dependent expressions. 310046ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor if (Bitfield->getBitWidth()->isValueDependent() || 310146ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Bitfield->getBitWidth()->isTypeDependent() || 310246ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isValueDependent() || 310346ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isTypeDependent()) 310446ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor return false; 310546ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor 310615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *OriginalInit = Init->IgnoreParenImpCasts(); 310715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 310815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall llvm::APSInt Width(32); 310915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr::EvalResult InitValue; 311015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (!Bitfield->getBitWidth()->isIntegerConstantExpr(Width, S.Context) || 311191b6014876e9186f968f74a8975ab8fc08ef1b68John McCall !OriginalInit->Evaluate(InitValue, S.Context) || 311215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall !InitValue.Val.isInt()) 311315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 311415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 311515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall const llvm::APSInt &Value = InitValue.Val.getInt(); 311615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned OriginalWidth = Value.getBitWidth(); 311715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned FieldWidth = Width.getZExtValue(); 311815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 311915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (OriginalWidth <= FieldWidth) 312015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 312115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 31229f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad llvm::APSInt TruncatedValue = Value.trunc(FieldWidth); 312315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 312415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // It's fairly common to write values into signed bitfields 312515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // that, if sign-extended, would end up becoming a different 312615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // value. We don't want to warn about that. 312715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value.isSigned() && Value.isNegative()) 31289f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad TruncatedValue = TruncatedValue.sext(OriginalWidth); 312915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall else 31309f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad TruncatedValue = TruncatedValue.zext(OriginalWidth); 313115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 313215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value == TruncatedValue) 313315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 313415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 313515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyValue = Value.toString(10); 313615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyTrunc = TruncatedValue.toString(10); 313715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 313815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 313915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << PrettyValue << PrettyTrunc << OriginalInit->getType() 314015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << Init->getSourceRange(); 314115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 314215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return true; 314315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 314415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 3145beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy 3146beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations. 3147beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCallvoid AnalyzeAssignment(Sema &S, BinaryOperator *E) { 3148beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Just recurse on the LHS. 3149beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 3150beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 3151beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // We want to recurse on the RHS as normal unless we're assigning to 3152beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // a bitfield. 3153beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (FieldDecl *Bitfield = E->getLHS()->getBitField()) { 315415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 315515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc())) { 315615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // Recurse, ignoring any implicit conversions on the RHS. 315715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 315815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc()); 3159beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 3160beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 3161beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 3162beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 3163beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall} 3164beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 316551313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 31665a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregorvoid DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T, 31675a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceLocation CContext, unsigned diag) { 31685a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor S.Diag(E->getExprLoc(), diag) 31695a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor << SourceType << T << E->getSourceRange() << SourceRange(CContext); 31705a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor} 31715a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 3172e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 3173e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruthvoid DiagnoseImpCast(Sema &S, Expr *E, QualType T, SourceLocation CContext, 3174e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth unsigned diag) { 3175e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth DiagnoseImpCast(S, E, E->getType(), T, CContext, diag); 3176e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth} 3177e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth 3178f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth/// Diagnose an implicit cast from a literal expression. Also attemps to supply 3179f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth/// fixit hints when the cast wouldn't lose information to simply write the 3180f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth/// expression with the expected type. 3181f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruthvoid DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T, 3182f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth SourceLocation CContext) { 3183f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth // Emit the primary warning first, then try to emit a fixit hint note if 3184f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth // reasonable. 3185f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer) 3186f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth << FL->getType() << T << FL->getSourceRange() << SourceRange(CContext); 3187f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 3188f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth const llvm::APFloat &Value = FL->getValue(); 3189f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 3190f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth // Don't attempt to fix PPC double double literals. 3191f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth if (&Value.getSemantics() == &llvm::APFloat::PPCDoubleDouble) 3192f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth return; 3193f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 31943e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin // Try to convert this exactly to an integer. 3195f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth bool isExact = false; 31963e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin llvm::APSInt IntegerValue(S.Context.getIntWidth(T), 31973e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin T->hasUnsignedIntegerRepresentation()); 31983e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin if (Value.convertToInteger(IntegerValue, 3199f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth llvm::APFloat::rmTowardZero, &isExact) 3200f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth != llvm::APFloat::opOK || !isExact) 3201f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth return; 3202f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 32033e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin std::string LiteralValue = IntegerValue.toString(10); 3204f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth S.Diag(FL->getExprLoc(), diag::note_fix_integral_float_as_integer) 3205f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth << FixItHint::CreateReplacement(FL->getSourceRange(), LiteralValue); 3206f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth} 3207f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 3208091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 3209091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Range.Width) return "0"; 3210091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3211091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt ValueInRange = Value; 3212091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.setIsSigned(!Range.NonNegative); 32139f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad ValueInRange = ValueInRange.trunc(Range.Width); 3214091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return ValueInRange.toString(10); 3215091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall} 3216091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3217ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenekstatic bool isFromSystemMacro(Sema &S, SourceLocation loc) { 3218ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceManager &smgr = S.Context.getSourceManager(); 3219ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return loc.isMacroID() && smgr.isInSystemHeader(smgr.getSpellingLoc(loc)); 3220ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek} 3221f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 3222323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T, 3223b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool *ICContext = 0) { 3224323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) return; 322551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3226323ed74658bc8375278eabf074b4777458376540John McCall const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 3227323ed74658bc8375278eabf074b4777458376540John McCall const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 3228323ed74658bc8375278eabf074b4777458376540John McCall if (Source == Target) return; 3229323ed74658bc8375278eabf074b4777458376540John McCall if (Target->isDependentType()) return; 323051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3231108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // If the conversion context location is invalid don't complain. We also 3232108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // don't want to emit a warning if the issue occurs from the expansion of 3233108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // a system macro. The problem is that 'getSpellingLoc()' is slow, so we 3234108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // delay this check as long as possible. Once we detect we are in that 3235108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // scenario, we just return. 3236ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (CC.isInvalid()) 3237b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return; 3238b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 3239f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Diagnose implicit casts to bool. 3240f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (Target->isSpecificBuiltinType(BuiltinType::Bool)) { 3241f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (isa<StringLiteral>(E)) 3242f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Warn on string literal to bool. Checks for string literals in logical 3243f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // expressions, for instances, assert(0 && "error here"), is prevented 3244f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // by a check in AnalyzeImplicitConversions(). 3245f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu return DiagnoseImpCast(S, E, T, CC, 3246f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu diag::warn_impcast_string_literal_to_bool); 3247e37cdc42bf7298a974dfdfa9c03ef11398e7c889David Blaikie return; // Other casts to bool are not checked. 3248f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 324951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 325051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip vector types. 325151313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<VectorType>(Source)) { 3252ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<VectorType>(Target)) { 3253ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3254ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3255b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 3256ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 3257b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner 3258b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // If the vector cast is cast between two vectors of the same size, it is 3259b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // a bitcast, not a conversion. 3260b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target)) 3261b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner return; 326251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 326351313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 326451313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 326551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 326651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 326751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip complex types. 326851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<ComplexType>(Source)) { 3269ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<ComplexType>(Target)) { 3270ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3271ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3272ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3273b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 3274ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 327551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 327651313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 327751313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 327851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 327951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 328051313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 328151313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 328251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 328351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the source is floating point... 328451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT && SourceBT->isFloatingPoint()) { 328551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...and the target is floating point... 328651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (TargetBT && TargetBT->isFloatingPoint()) { 328751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...then warn if we're dropping FP rank. 328851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 328951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Builtin FP kinds are ordered by increasing FP rank. 329051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT->getKind() > TargetBT->getKind()) { 329151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Don't warn about float constants that are precisely 329251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // representable in the target type. 329351313c39c84407dd6a323be99a8c322bf8d052a9John McCall Expr::EvalResult result; 3294323ed74658bc8375278eabf074b4777458376540John McCall if (E->Evaluate(result, S.Context)) { 329551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Value might be a float, a float vector, or a float complex. 329651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (IsSameFloatAfterCast(result.Val, 3297323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 3298323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 329951313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 330051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 330151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3302ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3303ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3304ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3305b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 330651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 330751313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 330851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 330951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3310ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // If the target is integral, always warn. 3311a5b9332418f25338f118358e27303cd510d54107Chandler Carruth if ((TargetBT && TargetBT->isInteger())) { 3312ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3313ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3314ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3315a5b9332418f25338f118358e27303cd510d54107Chandler Carruth Expr *InnerE = E->IgnoreParenImpCasts(); 3316634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay // We also want to warn on, e.g., "int i = -1.234" 3317634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE)) 3318634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus) 3319634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay InnerE = UOp->getSubExpr()->IgnoreParenImpCasts(); 3320634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay 3321f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) { 3322f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth DiagnoseFloatingLiteralImpCast(S, FL, T, CC); 3323a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } else { 3324a5b9332418f25338f118358e27303cd510d54107Chandler Carruth DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 3325a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 3326a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 332751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 332851313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 332951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 333051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3331f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!Source->isIntegerType() || !Target->isIntegerType()) 333251313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 333351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 33341838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull) 33351838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu == Expr::NPCK_GNUNull) && Target->isIntegerType()) { 33361838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu S.Diag(E->getExprLoc(), diag::warn_impcast_null_pointer_to_integer) 33371838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu << E->getSourceRange() << clang::SourceRange(CC); 33381838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu return; 33391838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu } 33401838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu 3341323ed74658bc8375278eabf074b4777458376540John McCall IntRange SourceRange = GetExprRange(S.Context, E); 33421844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 334351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3344f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width > TargetRange.Width) { 3345091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // If the source is a constant, use a default-on diagnostic. 3346091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // TODO: this should happen for bitfield stores, too. 3347091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt Value(32); 3348091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (E->isIntegerConstantExpr(Value, S.Context)) { 3349ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3350ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3351ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3352091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettySourceValue = Value.toString(10); 3353091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 3354091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3355091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall S.Diag(E->getExprLoc(), diag::warn_impcast_integer_precision_constant) 3356091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall << PrettySourceValue << PrettyTargetValue 3357091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall << E->getType() << T << E->getSourceRange() << clang::SourceRange(CC); 3358091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return; 3359091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall } 3360091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3361b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // People want to build with -Wshorten-64-to-32 and not -Wconversion. 3362ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3363ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3364ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3365f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width == 64 && TargetRange.Width == 32) 3366b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32); 3367b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 3368323ed74658bc8375278eabf074b4777458376540John McCall } 3369323ed74658bc8375278eabf074b4777458376540John McCall 3370323ed74658bc8375278eabf074b4777458376540John McCall if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 3371323ed74658bc8375278eabf074b4777458376540John McCall (!TargetRange.NonNegative && SourceRange.NonNegative && 3372323ed74658bc8375278eabf074b4777458376540John McCall SourceRange.Width == TargetRange.Width)) { 3373ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3374ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3375ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3376ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3377323ed74658bc8375278eabf074b4777458376540John McCall unsigned DiagID = diag::warn_impcast_integer_sign; 3378323ed74658bc8375278eabf074b4777458376540John McCall 3379323ed74658bc8375278eabf074b4777458376540John McCall // Traditionally, gcc has warned about this under -Wsign-compare. 3380323ed74658bc8375278eabf074b4777458376540John McCall // We also want to warn about it in -Wconversion. 3381323ed74658bc8375278eabf074b4777458376540John McCall // So if -Wconversion is off, use a completely identical diagnostic 3382323ed74658bc8375278eabf074b4777458376540John McCall // in the sign-compare group. 3383323ed74658bc8375278eabf074b4777458376540John McCall // The conditional-checking code will 3384323ed74658bc8375278eabf074b4777458376540John McCall if (ICContext) { 3385323ed74658bc8375278eabf074b4777458376540John McCall DiagID = diag::warn_impcast_integer_sign_conditional; 3386323ed74658bc8375278eabf074b4777458376540John McCall *ICContext = true; 3387323ed74658bc8375278eabf074b4777458376540John McCall } 3388323ed74658bc8375278eabf074b4777458376540John McCall 3389b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, DiagID); 339051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 339151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3392284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor // Diagnose conversions between different enumeration types. 33935a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // In C, we pretend that the type of an EnumConstantDecl is its enumeration 33945a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // type, to give us better diagnostics. 33955a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor QualType SourceType = E->getType(); 33965a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (!S.getLangOptions().CPlusPlus) { 33975a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 33985a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) { 33995a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext()); 34005a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceType = S.Context.getTypeDeclType(Enum); 34015a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor Source = S.Context.getCanonicalType(SourceType).getTypePtr(); 34025a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 34035a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 34045a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 3405284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *SourceEnum = Source->getAs<EnumType>()) 3406284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *TargetEnum = Target->getAs<EnumType>()) 3407284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if ((SourceEnum->getDecl()->getIdentifier() || 3408162e1c1b487352434552147967c3dd296ebee2f7Richard Smith SourceEnum->getDecl()->getTypedefNameForAnonDecl()) && 3409284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor (TargetEnum->getDecl()->getIdentifier() || 3410162e1c1b487352434552147967c3dd296ebee2f7Richard Smith TargetEnum->getDecl()->getTypedefNameForAnonDecl()) && 3411ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceEnum != TargetEnum) { 3412ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3413ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3414ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 34155a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor return DiagnoseImpCast(S, E, SourceType, T, CC, 3416284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor diag::warn_impcast_different_enum_types); 3417ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 3418284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor 341951313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 342051313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 342151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3422323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T); 3423323ed74658bc8375278eabf074b4777458376540John McCall 3424323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T, 3425b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool &ICContext) { 3426323ed74658bc8375278eabf074b4777458376540John McCall E = E->IgnoreParenImpCasts(); 3427323ed74658bc8375278eabf074b4777458376540John McCall 3428323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) 3429323ed74658bc8375278eabf074b4777458376540John McCall return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T); 3430323ed74658bc8375278eabf074b4777458376540John McCall 3431b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E, CC); 3432323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 3433b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return CheckImplicitConversion(S, E, T, CC, &ICContext); 3434323ed74658bc8375278eabf074b4777458376540John McCall return; 3435323ed74658bc8375278eabf074b4777458376540John McCall} 3436323ed74658bc8375278eabf074b4777458376540John McCall 3437323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) { 3438b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC = E->getQuestionLoc(); 3439b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 3440b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getCond(), CC); 3441323ed74658bc8375278eabf074b4777458376540John McCall 3442323ed74658bc8375278eabf074b4777458376540John McCall bool Suspicious = false; 3443b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 3444b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 3445323ed74658bc8375278eabf074b4777458376540John McCall 3446323ed74658bc8375278eabf074b4777458376540John McCall // If -Wconversion would have warned about either of the candidates 3447323ed74658bc8375278eabf074b4777458376540John McCall // for a signedness conversion to the context type... 3448323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) return; 3449323ed74658bc8375278eabf074b4777458376540John McCall 3450323ed74658bc8375278eabf074b4777458376540John McCall // ...but it's currently ignored... 34510827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional, 34520827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis CC)) 3453323ed74658bc8375278eabf074b4777458376540John McCall return; 3454323ed74658bc8375278eabf074b4777458376540John McCall 3455323ed74658bc8375278eabf074b4777458376540John McCall // ...then check whether it would have warned about either of the 3456323ed74658bc8375278eabf074b4777458376540John McCall // candidates for a signedness conversion to the condition type. 34575254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (E->getType() == T) return; 34585254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu 34595254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu Suspicious = false; 34605254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 34615254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu E->getType(), CC, &Suspicious); 34625254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (!Suspicious) 34635254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 3464b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 3465323ed74658bc8375278eabf074b4777458376540John McCall} 3466323ed74658bc8375278eabf074b4777458376540John McCall 3467323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting 3468323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression. There are a couple 3469323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare. 3470b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 3471323ed74658bc8375278eabf074b4777458376540John McCall QualType T = OrigE->getType(); 3472323ed74658bc8375278eabf074b4777458376540John McCall Expr *E = OrigE->IgnoreParenImpCasts(); 3473323ed74658bc8375278eabf074b4777458376540John McCall 3474323ed74658bc8375278eabf074b4777458376540John McCall // For conditional operators, we analyze the arguments as if they 3475323ed74658bc8375278eabf074b4777458376540John McCall // were being fed directly into the output. 3476323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) { 3477323ed74658bc8375278eabf074b4777458376540John McCall ConditionalOperator *CO = cast<ConditionalOperator>(E); 3478323ed74658bc8375278eabf074b4777458376540John McCall CheckConditionalOperator(S, CO, T); 3479323ed74658bc8375278eabf074b4777458376540John McCall return; 3480323ed74658bc8375278eabf074b4777458376540John McCall } 3481323ed74658bc8375278eabf074b4777458376540John McCall 3482323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and check any implicit conversions we might have skipped. 3483323ed74658bc8375278eabf074b4777458376540John McCall // The non-canonical typecheck is just an optimization; 3484323ed74658bc8375278eabf074b4777458376540John McCall // CheckImplicitConversion will filter out dead implicit conversions. 3485323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 3486b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckImplicitConversion(S, E, T, CC); 3487323ed74658bc8375278eabf074b4777458376540John McCall 3488323ed74658bc8375278eabf074b4777458376540John McCall // Now continue drilling into this expression. 3489323ed74658bc8375278eabf074b4777458376540John McCall 3490323ed74658bc8375278eabf074b4777458376540John McCall // Skip past explicit casts. 3491323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ExplicitCastExpr>(E)) { 3492323ed74658bc8375278eabf074b4777458376540John McCall E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 3493b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return AnalyzeImplicitConversions(S, E, CC); 3494323ed74658bc8375278eabf074b4777458376540John McCall } 3495323ed74658bc8375278eabf074b4777458376540John McCall 3496beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 3497beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Do a somewhat different check with comparison operators. 3498beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isComparisonOp()) 3499beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeComparison(S, BO); 3500beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 3501beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // And with assignments and compound assignments. 3502beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isAssignmentOp()) 3503beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeAssignment(S, BO); 3504beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 3505323ed74658bc8375278eabf074b4777458376540John McCall 3506323ed74658bc8375278eabf074b4777458376540John McCall // These break the otherwise-useful invariant below. Fortunately, 3507323ed74658bc8375278eabf074b4777458376540John McCall // we don't really need to recurse into them, because any internal 3508323ed74658bc8375278eabf074b4777458376540John McCall // expressions should have been analyzed already when they were 3509323ed74658bc8375278eabf074b4777458376540John McCall // built into statements. 3510323ed74658bc8375278eabf074b4777458376540John McCall if (isa<StmtExpr>(E)) return; 3511323ed74658bc8375278eabf074b4777458376540John McCall 3512323ed74658bc8375278eabf074b4777458376540John McCall // Don't descend into unevaluated contexts. 3513f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne if (isa<UnaryExprOrTypeTraitExpr>(E)) return; 3514323ed74658bc8375278eabf074b4777458376540John McCall 3515323ed74658bc8375278eabf074b4777458376540John McCall // Now just recurse over the expression's children. 3516b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CC = E->getExprLoc(); 3517f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu BinaryOperator *BO = dyn_cast<BinaryOperator>(E); 3518f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu bool IsLogicalOperator = BO && BO->isLogicalOp(); 3519f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu for (Stmt::child_range I = E->children(); I; ++I) { 3520f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu Expr *ChildExpr = cast<Expr>(*I); 3521f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (IsLogicalOperator && 3522f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts())) 3523f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Ignore checking string literals that are in logical operators. 3524f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu continue; 3525f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu AnalyzeImplicitConversions(S, ChildExpr, CC); 3526f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 3527323ed74658bc8375278eabf074b4777458376540John McCall} 3528323ed74658bc8375278eabf074b4777458376540John McCall 3529323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace 3530323ed74658bc8375278eabf074b4777458376540John McCall 3531323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given 3532323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression). Implements -Wconversion 3533323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare. 3534b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// 3535b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e. 3536b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// the most location of the syntactic entity requiring the implicit 3537b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// conversion 3538b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 3539323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose in unevaluated contexts. 3540323ed74658bc8375278eabf074b4777458376540John McCall if (ExprEvalContexts.back().Context == Sema::Unevaluated) 3541323ed74658bc8375278eabf074b4777458376540John McCall return; 3542323ed74658bc8375278eabf074b4777458376540John McCall 3543323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose for value- or type-dependent expressions. 3544323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) 3545323ed74658bc8375278eabf074b4777458376540John McCall return; 3546323ed74658bc8375278eabf074b4777458376540John McCall 3547d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Check for array bounds violations in cases where the check isn't triggered 3548d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // elsewhere for other Expr types (like BinaryOperators), e.g. when an 3549d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // ArraySubscriptExpr is on the RHS of a variable initialization. 3550d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain CheckArrayAccess(E); 3551d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 3552b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // This is not the right CC for (e.g.) a variable initialization. 3553b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(*this, E, CC); 3554323ed74658bc8375278eabf074b4777458376540John McCall} 3555323ed74658bc8375278eabf074b4777458376540John McCall 355615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 355715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall FieldDecl *BitField, 355815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *Init) { 355915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 356015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 356115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 3562f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given 3563f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This 3564f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the 3565f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function 3566f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete. 356782aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregorbool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd, 356882aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor bool CheckParameterNames) { 3569f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump bool HasInvalidParm = false; 357082aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor for (; P != PEnd; ++P) { 357182aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor ParmVarDecl *Param = *P; 357282aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor 3573f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.7.5.3p4: the parameters in a parameter type list in a 3574f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // function declarator that is part of a function definition of 3575f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // that function shall not have incomplete type. 3576f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // 3577f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // This is also C++ [dcl.fct]p6. 3578f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump if (!Param->isInvalidDecl() && 3579f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump RequireCompleteType(Param->getLocation(), Param->getType(), 3580f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump diag::err_typecheck_decl_incomplete_type)) { 3581f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Param->setInvalidDecl(); 3582f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump HasInvalidParm = true; 3583f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 3584f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 3585f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.9.1p5: If the declarator includes a parameter type list, the 3586f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // declaration of each parameter shall include an identifier. 358782aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor if (CheckParameterNames && 358882aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor Param->getIdentifier() == 0 && 3589f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !Param->isImplicit() && 3590f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !getLangOptions().CPlusPlus) 3591f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Diag(Param->getLocation(), diag::err_parameter_name_omitted); 3592d17e340e2d516139931768697bf080f60920ba9dSam Weinig 3593d17e340e2d516139931768697bf080f60920ba9dSam Weinig // C99 6.7.5.3p12: 3594d17e340e2d516139931768697bf080f60920ba9dSam Weinig // If the function declarator is not part of a definition of that 3595d17e340e2d516139931768697bf080f60920ba9dSam Weinig // function, parameters may have incomplete type and may use the [*] 3596d17e340e2d516139931768697bf080f60920ba9dSam Weinig // notation in their sequences of declarator specifiers to specify 3597d17e340e2d516139931768697bf080f60920ba9dSam Weinig // variable length array types. 3598d17e340e2d516139931768697bf080f60920ba9dSam Weinig QualType PType = Param->getOriginalType(); 3599d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (const ArrayType *AT = Context.getAsArrayType(PType)) { 3600d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (AT->getSizeModifier() == ArrayType::Star) { 3601d17e340e2d516139931768697bf080f60920ba9dSam Weinig // FIXME: This diagnosic should point the the '[*]' if source-location 3602d17e340e2d516139931768697bf080f60920ba9dSam Weinig // information is added for it. 3603d17e340e2d516139931768697bf080f60920ba9dSam Weinig Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 3604d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 3605d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 3606f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 3607f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 3608f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump return HasInvalidParm; 3609f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump} 3610b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3611b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a 3612b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements. 3613b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 3614b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // This is actually a lot of work to potentially be doing on every 3615b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // cast; don't do it if we're ignoring -Wcast_align (as is the default). 36160827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align, 36170827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis TRange.getBegin()) 3618d6471f7c1921c7802804ce3ff6fe9768310f72b9David Blaikie == DiagnosticsEngine::Ignored) 3619b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 3620b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3621b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Ignore dependent types. 3622b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (T->isDependentType() || Op->getType()->isDependentType()) 3623b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 3624b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3625b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the destination be a pointer type. 3626b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *DestPtr = T->getAs<PointerType>(); 3627b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!DestPtr) return; 3628b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3629b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // If the destination has alignment 1, we're done. 3630b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType DestPointee = DestPtr->getPointeeType(); 3631b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestPointee->isIncompleteType()) return; 3632b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 3633b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestAlign.isOne()) return; 3634b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3635b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the source be a pointer type. 3636b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 3637b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!SrcPtr) return; 3638b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType SrcPointee = SrcPtr->getPointeeType(); 3639b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3640b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Whitelist casts from cv void*. We already implicitly 3641b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // whitelisted casts to cv void*, since they have alignment 1. 3642b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Also whitelist casts involving incomplete types, which implicitly 3643b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // includes 'void'. 3644b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcPointee->isIncompleteType()) return; 3645b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3646b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 3647b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcAlign >= DestAlign) return; 3648b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3649b7f4ffe073fa419613946461a2583ba2fcb72280John McCall Diag(TRange.getBegin(), diag::warn_cast_align) 3650b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << Op->getType() << T 3651b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(SrcAlign.getQuantity()) 3652b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(DestAlign.getQuantity()) 3653b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << TRange << Op->getSourceRange(); 3654b7f4ffe073fa419613946461a2583ba2fcb72280John McCall} 3655b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3656d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainstatic const Type* getElementType(const Expr *BaseExpr) { 3657d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* EltType = BaseExpr->getType().getTypePtr(); 3658d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (EltType->isAnyPointerType()) 3659d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getPointeeType().getTypePtr(); 3660d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain else if (EltType->isArrayType()) 3661d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getBaseElementTypeUnsafe(); 3662d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType; 3663d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain} 3664d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 3665c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// \brief Check whether this array fits the idiom of a size-one tail padded 3666c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// array member of a struct. 3667c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// 3668c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// We avoid emitting out-of-bounds access warnings for such arrays as they are 3669c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// commonly used to emulate flexible arrays in C89 code. 3670c268434b332bbe57950d977633369bf5822d9554Chandler Carruthstatic bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size, 3671c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const NamedDecl *ND) { 3672c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (Size != 1 || !ND) return false; 3673c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 3674c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const FieldDecl *FD = dyn_cast<FieldDecl>(ND); 3675c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!FD) return false; 3676c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 3677c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // Don't consider sizes resulting from macro expansions or template argument 3678c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // substitution to form C89 tail-padded arrays. 3679c268434b332bbe57950d977633369bf5822d9554Chandler Carruth ConstantArrayTypeLoc TL = 3680c268434b332bbe57950d977633369bf5822d9554Chandler Carruth cast<ConstantArrayTypeLoc>(FD->getTypeSourceInfo()->getTypeLoc()); 3681c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const Expr *SizeExpr = dyn_cast<IntegerLiteral>(TL.getSizeExpr()); 3682c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!SizeExpr || SizeExpr->getExprLoc().isMacroID()) 3683c268434b332bbe57950d977633369bf5822d9554Chandler Carruth return false; 3684c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 3685c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext()); 3686c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!RD || !RD->isStruct()) 3687c268434b332bbe57950d977633369bf5822d9554Chandler Carruth return false; 3688c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 368922d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer // See if this is the last field decl in the record. 369022d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer const Decl *D = FD; 369122d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer while ((D = D->getNextDeclInContext())) 369222d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer if (isa<FieldDecl>(D)) 369322d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return false; 369422d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return true; 3695c268434b332bbe57950d977633369bf5822d9554Chandler Carruth} 3696c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 3697d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainvoid Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr, 3698d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain bool isSubscript, bool AllowOnePastEnd) { 3699d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* EffectiveType = getElementType(BaseExpr); 3700d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain BaseExpr = BaseExpr->IgnoreParenCasts(); 3701d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain IndexExpr = IndexExpr->IgnoreParenCasts(); 3702d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 37033406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const ConstantArrayType *ArrayTy = 3704d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain Context.getAsConstantArrayType(BaseExpr->getType()); 37053406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (!ArrayTy) 3706a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 370735001ca261f895817916b468379b696d6d45959dChandler Carruth 37083406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (IndexExpr->isValueDependent()) 3709a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 37103406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth llvm::APSInt index; 3711d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (!IndexExpr->isIntegerConstantExpr(index, Context)) 3712a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 37138fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek 3714ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth const NamedDecl *ND = NULL; 3715ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 3716ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(DRE->getDecl()); 3717c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 3718ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 3719ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 37209e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek if (index.isUnsigned() || !index.isNegative()) { 372125b3b849e3ad340b04442707038c86980035765bTed Kremenek llvm::APInt size = ArrayTy->getSize(); 372235001ca261f895817916b468379b696d6d45959dChandler Carruth if (!size.isStrictlyPositive()) 372335001ca261f895817916b468379b696d6d45959dChandler Carruth return; 3724d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 3725d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* BaseType = getElementType(BaseExpr); 3726de5998f1d7dcecb777257ec932142d65de636eb8Nico Weber if (BaseType != EffectiveType) { 3727d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Make sure we're comparing apples to apples when comparing index to size 3728d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType); 3729d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t array_typesize = Context.getTypeSize(BaseType); 3730d10f4bc5a05ce0cdc1646dbb0f706bb9d3dfc0c5Kaelyn Uhrain // Handle ptrarith_typesize being zero, such as when casting to void* 373118f169770d9d3f826bad8f1359c8c5770c5ab16fKaelyn Uhrain if (!ptrarith_typesize) ptrarith_typesize = 1; 3732d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize != array_typesize) { 3733d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // There's a cast to a different size type involved 3734d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ratio = array_typesize / ptrarith_typesize; 3735d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // TODO: Be smarter about handling cases where array_typesize is not a 3736d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // multiple of ptrarith_typesize 3737d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize * ratio == array_typesize) 3738d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain size *= llvm::APInt(size.getBitWidth(), ratio); 3739d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 3740d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 3741d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 37423406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (size.getBitWidth() > index.getBitWidth()) 37433406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth index = index.sext(size.getBitWidth()); 374425b3b849e3ad340b04442707038c86980035765bTed Kremenek else if (size.getBitWidth() < index.getBitWidth()) 374525b3b849e3ad340b04442707038c86980035765bTed Kremenek size = size.sext(index.getBitWidth()); 374625b3b849e3ad340b04442707038c86980035765bTed Kremenek 3747d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // For array subscripting the index must be less than size, but for pointer 3748d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // arithmetic also allow the index (offset) to be equal to size since 3749d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // computing the next address after the end of the array is legal and 3750d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // commonly done e.g. in C++ iterators and range-based for loops. 3751d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (AllowOnePastEnd ? index.sle(size) : index.slt(size)) 3752ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth return; 3753ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 3754ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // Also don't warn for arrays of size 1 which are members of some 3755ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // structure. These are often used to approximate flexible arrays in C89 3756ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // code. 3757d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (IsTailPaddedMemberArray(*this, size, ND)) 37588fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek return; 37593406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth 3760d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds; 3761d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (isSubscript) 3762d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_array_index_exceeds_bounds; 3763d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 3764d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 3765d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 3766d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << size.toString(10, true) 3767d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << (unsigned)size.getLimitedValue(~0U) 3768d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 37693406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth } else { 3770d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_array_index_precedes_bounds; 3771d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (!isSubscript) { 3772d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_ptr_arith_precedes_bounds; 3773d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (index.isNegative()) index = -index; 3774d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 3775d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 3776d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 3777d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 3778d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 3779a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek } 378035001ca261f895817916b468379b696d6d45959dChandler Carruth 378135001ca261f895817916b468379b696d6d45959dChandler Carruth if (ND) 3782d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(ND->getLocStart(), BaseExpr, 3783d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(diag::note_array_index_out_of_bounds) 3784d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << ND->getDeclName()); 37853aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek} 37863aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek 37873aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) { 3788d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain int AllowOnePastEnd = 0; 3789d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain while (expr) { 3790d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = expr->IgnoreParenImpCasts(); 37913aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek switch (expr->getStmtClass()) { 3792d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::ArraySubscriptExprClass: { 3793d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr); 3794d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain CheckArrayAccess(ASE->getBase(), ASE->getIdx(), true, 3795d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd > 0); 37963aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 3797d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 3798d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::UnaryOperatorClass: { 3799d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Only unwrap the * and & unary operators 3800d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const UnaryOperator *UO = cast<UnaryOperator>(expr); 3801d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = UO->getSubExpr(); 3802d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain switch (UO->getOpcode()) { 3803d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_AddrOf: 3804d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd++; 3805d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 3806d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_Deref: 3807d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd--; 3808d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 3809d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain default: 3810d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return; 3811d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 3812d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 3813d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 38143aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek case Stmt::ConditionalOperatorClass: { 38153aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek const ConditionalOperator *cond = cast<ConditionalOperator>(expr); 38163aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *lhs = cond->getLHS()) 38173aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(lhs); 38183aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *rhs = cond->getRHS()) 38193aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(rhs); 38203aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 38213aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 38223aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek default: 38233aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 38243aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 3825f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne } 3826a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek} 3827f85e193739c953358c865005855253af4f68a497John McCall 3828f85e193739c953358c865005855253af4f68a497John McCall//===--- CHECK: Objective-C retain cycles ----------------------------------// 3829f85e193739c953358c865005855253af4f68a497John McCall 3830f85e193739c953358c865005855253af4f68a497John McCallnamespace { 3831f85e193739c953358c865005855253af4f68a497John McCall struct RetainCycleOwner { 3832f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner() : Variable(0), Indirect(false) {} 3833f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 3834f85e193739c953358c865005855253af4f68a497John McCall SourceRange Range; 3835f85e193739c953358c865005855253af4f68a497John McCall SourceLocation Loc; 3836f85e193739c953358c865005855253af4f68a497John McCall bool Indirect; 3837f85e193739c953358c865005855253af4f68a497John McCall 3838f85e193739c953358c865005855253af4f68a497John McCall void setLocsFrom(Expr *e) { 3839f85e193739c953358c865005855253af4f68a497John McCall Loc = e->getExprLoc(); 3840f85e193739c953358c865005855253af4f68a497John McCall Range = e->getSourceRange(); 3841f85e193739c953358c865005855253af4f68a497John McCall } 3842f85e193739c953358c865005855253af4f68a497John McCall }; 3843f85e193739c953358c865005855253af4f68a497John McCall} 3844f85e193739c953358c865005855253af4f68a497John McCall 3845f85e193739c953358c865005855253af4f68a497John McCall/// Consider whether capturing the given variable can possibly lead to 3846f85e193739c953358c865005855253af4f68a497John McCall/// a retain cycle. 3847f85e193739c953358c865005855253af4f68a497John McCallstatic bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) { 3848f85e193739c953358c865005855253af4f68a497John McCall // In ARC, it's captured strongly iff the variable has __strong 3849f85e193739c953358c865005855253af4f68a497John McCall // lifetime. In MRR, it's captured strongly if the variable is 3850f85e193739c953358c865005855253af4f68a497John McCall // __block and has an appropriate type. 3851f85e193739c953358c865005855253af4f68a497John McCall if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 3852f85e193739c953358c865005855253af4f68a497John McCall return false; 3853f85e193739c953358c865005855253af4f68a497John McCall 3854f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = var; 3855f85e193739c953358c865005855253af4f68a497John McCall owner.setLocsFrom(ref); 3856f85e193739c953358c865005855253af4f68a497John McCall return true; 3857f85e193739c953358c865005855253af4f68a497John McCall} 3858f85e193739c953358c865005855253af4f68a497John McCall 3859f85e193739c953358c865005855253af4f68a497John McCallstatic bool findRetainCycleOwner(Expr *e, RetainCycleOwner &owner) { 3860f85e193739c953358c865005855253af4f68a497John McCall while (true) { 3861f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParens(); 3862f85e193739c953358c865005855253af4f68a497John McCall if (CastExpr *cast = dyn_cast<CastExpr>(e)) { 3863f85e193739c953358c865005855253af4f68a497John McCall switch (cast->getCastKind()) { 3864f85e193739c953358c865005855253af4f68a497John McCall case CK_BitCast: 3865f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueBitCast: 3866f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueToRValue: 386733e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall case CK_ARCReclaimReturnedObject: 3868f85e193739c953358c865005855253af4f68a497John McCall e = cast->getSubExpr(); 3869f85e193739c953358c865005855253af4f68a497John McCall continue; 3870f85e193739c953358c865005855253af4f68a497John McCall 3871f85e193739c953358c865005855253af4f68a497John McCall case CK_GetObjCProperty: { 3872f85e193739c953358c865005855253af4f68a497John McCall // Bail out if this isn't a strong explicit property. 3873f85e193739c953358c865005855253af4f68a497John McCall const ObjCPropertyRefExpr *pre = cast->getSubExpr()->getObjCProperty(); 3874f85e193739c953358c865005855253af4f68a497John McCall if (pre->isImplicitProperty()) return false; 3875f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *property = pre->getExplicitProperty(); 3876265941bc308d65cc270d5c4de5806f37ce405606John McCall if (!property->isRetaining() && 3877f85e193739c953358c865005855253af4f68a497John McCall !(property->getPropertyIvarDecl() && 3878f85e193739c953358c865005855253af4f68a497John McCall property->getPropertyIvarDecl()->getType() 3879f85e193739c953358c865005855253af4f68a497John McCall .getObjCLifetime() == Qualifiers::OCL_Strong)) 3880f85e193739c953358c865005855253af4f68a497John McCall return false; 3881f85e193739c953358c865005855253af4f68a497John McCall 3882f85e193739c953358c865005855253af4f68a497John McCall owner.Indirect = true; 3883f85e193739c953358c865005855253af4f68a497John McCall e = const_cast<Expr*>(pre->getBase()); 3884f85e193739c953358c865005855253af4f68a497John McCall continue; 3885f85e193739c953358c865005855253af4f68a497John McCall } 3886f85e193739c953358c865005855253af4f68a497John McCall 3887f85e193739c953358c865005855253af4f68a497John McCall default: 3888f85e193739c953358c865005855253af4f68a497John McCall return false; 3889f85e193739c953358c865005855253af4f68a497John McCall } 3890f85e193739c953358c865005855253af4f68a497John McCall } 3891f85e193739c953358c865005855253af4f68a497John McCall 3892f85e193739c953358c865005855253af4f68a497John McCall if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) { 3893f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar = ref->getDecl(); 3894f85e193739c953358c865005855253af4f68a497John McCall if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 3895f85e193739c953358c865005855253af4f68a497John McCall return false; 3896f85e193739c953358c865005855253af4f68a497John McCall 3897f85e193739c953358c865005855253af4f68a497John McCall // Try to find a retain cycle in the base. 3898f85e193739c953358c865005855253af4f68a497John McCall if (!findRetainCycleOwner(ref->getBase(), owner)) 3899f85e193739c953358c865005855253af4f68a497John McCall return false; 3900f85e193739c953358c865005855253af4f68a497John McCall 3901f85e193739c953358c865005855253af4f68a497John McCall if (ref->isFreeIvar()) owner.setLocsFrom(ref); 3902f85e193739c953358c865005855253af4f68a497John McCall owner.Indirect = true; 3903f85e193739c953358c865005855253af4f68a497John McCall return true; 3904f85e193739c953358c865005855253af4f68a497John McCall } 3905f85e193739c953358c865005855253af4f68a497John McCall 3906f85e193739c953358c865005855253af4f68a497John McCall if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) { 3907f85e193739c953358c865005855253af4f68a497John McCall VarDecl *var = dyn_cast<VarDecl>(ref->getDecl()); 3908f85e193739c953358c865005855253af4f68a497John McCall if (!var) return false; 3909f85e193739c953358c865005855253af4f68a497John McCall return considerVariable(var, ref, owner); 3910f85e193739c953358c865005855253af4f68a497John McCall } 3911f85e193739c953358c865005855253af4f68a497John McCall 3912f85e193739c953358c865005855253af4f68a497John McCall if (BlockDeclRefExpr *ref = dyn_cast<BlockDeclRefExpr>(e)) { 3913f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = ref->getDecl(); 3914f85e193739c953358c865005855253af4f68a497John McCall owner.setLocsFrom(ref); 3915f85e193739c953358c865005855253af4f68a497John McCall return true; 3916f85e193739c953358c865005855253af4f68a497John McCall } 3917f85e193739c953358c865005855253af4f68a497John McCall 3918f85e193739c953358c865005855253af4f68a497John McCall if (MemberExpr *member = dyn_cast<MemberExpr>(e)) { 3919f85e193739c953358c865005855253af4f68a497John McCall if (member->isArrow()) return false; 3920f85e193739c953358c865005855253af4f68a497John McCall 3921f85e193739c953358c865005855253af4f68a497John McCall // Don't count this as an indirect ownership. 3922f85e193739c953358c865005855253af4f68a497John McCall e = member->getBase(); 3923f85e193739c953358c865005855253af4f68a497John McCall continue; 3924f85e193739c953358c865005855253af4f68a497John McCall } 3925f85e193739c953358c865005855253af4f68a497John McCall 3926f85e193739c953358c865005855253af4f68a497John McCall // Array ivars? 3927f85e193739c953358c865005855253af4f68a497John McCall 3928f85e193739c953358c865005855253af4f68a497John McCall return false; 3929f85e193739c953358c865005855253af4f68a497John McCall } 3930f85e193739c953358c865005855253af4f68a497John McCall} 3931f85e193739c953358c865005855253af4f68a497John McCall 3932f85e193739c953358c865005855253af4f68a497John McCallnamespace { 3933f85e193739c953358c865005855253af4f68a497John McCall struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> { 3934f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor(ASTContext &Context, VarDecl *variable) 3935f85e193739c953358c865005855253af4f68a497John McCall : EvaluatedExprVisitor<FindCaptureVisitor>(Context), 3936f85e193739c953358c865005855253af4f68a497John McCall Variable(variable), Capturer(0) {} 3937f85e193739c953358c865005855253af4f68a497John McCall 3938f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 3939f85e193739c953358c865005855253af4f68a497John McCall Expr *Capturer; 3940f85e193739c953358c865005855253af4f68a497John McCall 3941f85e193739c953358c865005855253af4f68a497John McCall void VisitDeclRefExpr(DeclRefExpr *ref) { 3942f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 3943f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 3944f85e193739c953358c865005855253af4f68a497John McCall } 3945f85e193739c953358c865005855253af4f68a497John McCall 3946f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockDeclRefExpr(BlockDeclRefExpr *ref) { 3947f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 3948f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 3949f85e193739c953358c865005855253af4f68a497John McCall } 3950f85e193739c953358c865005855253af4f68a497John McCall 3951f85e193739c953358c865005855253af4f68a497John McCall void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) { 3952f85e193739c953358c865005855253af4f68a497John McCall if (Capturer) return; 3953f85e193739c953358c865005855253af4f68a497John McCall Visit(ref->getBase()); 3954f85e193739c953358c865005855253af4f68a497John McCall if (Capturer && ref->isFreeIvar()) 3955f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 3956f85e193739c953358c865005855253af4f68a497John McCall } 3957f85e193739c953358c865005855253af4f68a497John McCall 3958f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockExpr(BlockExpr *block) { 3959f85e193739c953358c865005855253af4f68a497John McCall // Look inside nested blocks 3960f85e193739c953358c865005855253af4f68a497John McCall if (block->getBlockDecl()->capturesVariable(Variable)) 3961f85e193739c953358c865005855253af4f68a497John McCall Visit(block->getBlockDecl()->getBody()); 3962f85e193739c953358c865005855253af4f68a497John McCall } 3963f85e193739c953358c865005855253af4f68a497John McCall }; 3964f85e193739c953358c865005855253af4f68a497John McCall} 3965f85e193739c953358c865005855253af4f68a497John McCall 3966f85e193739c953358c865005855253af4f68a497John McCall/// Check whether the given argument is a block which captures a 3967f85e193739c953358c865005855253af4f68a497John McCall/// variable. 3968f85e193739c953358c865005855253af4f68a497John McCallstatic Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) { 3969f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 3970f85e193739c953358c865005855253af4f68a497John McCall 3971f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParenCasts(); 3972f85e193739c953358c865005855253af4f68a497John McCall BlockExpr *block = dyn_cast<BlockExpr>(e); 3973f85e193739c953358c865005855253af4f68a497John McCall if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable)) 3974f85e193739c953358c865005855253af4f68a497John McCall return 0; 3975f85e193739c953358c865005855253af4f68a497John McCall 3976f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor visitor(S.Context, owner.Variable); 3977f85e193739c953358c865005855253af4f68a497John McCall visitor.Visit(block->getBlockDecl()->getBody()); 3978f85e193739c953358c865005855253af4f68a497John McCall return visitor.Capturer; 3979f85e193739c953358c865005855253af4f68a497John McCall} 3980f85e193739c953358c865005855253af4f68a497John McCall 3981f85e193739c953358c865005855253af4f68a497John McCallstatic void diagnoseRetainCycle(Sema &S, Expr *capturer, 3982f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner &owner) { 3983f85e193739c953358c865005855253af4f68a497John McCall assert(capturer); 3984f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 3985f85e193739c953358c865005855253af4f68a497John McCall 3986f85e193739c953358c865005855253af4f68a497John McCall S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle) 3987f85e193739c953358c865005855253af4f68a497John McCall << owner.Variable << capturer->getSourceRange(); 3988f85e193739c953358c865005855253af4f68a497John McCall S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner) 3989f85e193739c953358c865005855253af4f68a497John McCall << owner.Indirect << owner.Range; 3990f85e193739c953358c865005855253af4f68a497John McCall} 3991f85e193739c953358c865005855253af4f68a497John McCall 3992f85e193739c953358c865005855253af4f68a497John McCall/// Check for a keyword selector that starts with the word 'add' or 3993f85e193739c953358c865005855253af4f68a497John McCall/// 'set'. 3994f85e193739c953358c865005855253af4f68a497John McCallstatic bool isSetterLikeSelector(Selector sel) { 3995f85e193739c953358c865005855253af4f68a497John McCall if (sel.isUnarySelector()) return false; 3996f85e193739c953358c865005855253af4f68a497John McCall 39975f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef str = sel.getNameForSlot(0); 3998f85e193739c953358c865005855253af4f68a497John McCall while (!str.empty() && str.front() == '_') str = str.substr(1); 3999f85e193739c953358c865005855253af4f68a497John McCall if (str.startswith("set") || str.startswith("add")) 4000f85e193739c953358c865005855253af4f68a497John McCall str = str.substr(3); 4001f85e193739c953358c865005855253af4f68a497John McCall else 4002f85e193739c953358c865005855253af4f68a497John McCall return false; 4003f85e193739c953358c865005855253af4f68a497John McCall 4004f85e193739c953358c865005855253af4f68a497John McCall if (str.empty()) return true; 4005f85e193739c953358c865005855253af4f68a497John McCall return !islower(str.front()); 4006f85e193739c953358c865005855253af4f68a497John McCall} 4007f85e193739c953358c865005855253af4f68a497John McCall 4008f85e193739c953358c865005855253af4f68a497John McCall/// Check a message send to see if it's likely to cause a retain cycle. 4009f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(ObjCMessageExpr *msg) { 4010f85e193739c953358c865005855253af4f68a497John McCall // Only check instance methods whose selector looks like a setter. 4011f85e193739c953358c865005855253af4f68a497John McCall if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector())) 4012f85e193739c953358c865005855253af4f68a497John McCall return; 4013f85e193739c953358c865005855253af4f68a497John McCall 4014f85e193739c953358c865005855253af4f68a497John McCall // Try to find a variable that the receiver is strongly owned by. 4015f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 4016f85e193739c953358c865005855253af4f68a497John McCall if (msg->getReceiverKind() == ObjCMessageExpr::Instance) { 4017f85e193739c953358c865005855253af4f68a497John McCall if (!findRetainCycleOwner(msg->getInstanceReceiver(), owner)) 4018f85e193739c953358c865005855253af4f68a497John McCall return; 4019f85e193739c953358c865005855253af4f68a497John McCall } else { 4020f85e193739c953358c865005855253af4f68a497John McCall assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance); 4021f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = getCurMethodDecl()->getSelfDecl(); 4022f85e193739c953358c865005855253af4f68a497John McCall owner.Loc = msg->getSuperLoc(); 4023f85e193739c953358c865005855253af4f68a497John McCall owner.Range = msg->getSuperLoc(); 4024f85e193739c953358c865005855253af4f68a497John McCall } 4025f85e193739c953358c865005855253af4f68a497John McCall 4026f85e193739c953358c865005855253af4f68a497John McCall // Check whether the receiver is captured by any of the arguments. 4027f85e193739c953358c865005855253af4f68a497John McCall for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i) 4028f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner)) 4029f85e193739c953358c865005855253af4f68a497John McCall return diagnoseRetainCycle(*this, capturer, owner); 4030f85e193739c953358c865005855253af4f68a497John McCall} 4031f85e193739c953358c865005855253af4f68a497John McCall 4032f85e193739c953358c865005855253af4f68a497John McCall/// Check a property assign to see if it's likely to cause a retain cycle. 4033f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(Expr *receiver, Expr *argument) { 4034f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 4035f85e193739c953358c865005855253af4f68a497John McCall if (!findRetainCycleOwner(receiver, owner)) 4036f85e193739c953358c865005855253af4f68a497John McCall return; 4037f85e193739c953358c865005855253af4f68a497John McCall 4038f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, argument, owner)) 4039f85e193739c953358c865005855253af4f68a497John McCall diagnoseRetainCycle(*this, capturer, owner); 4040f85e193739c953358c865005855253af4f68a497John McCall} 4041f85e193739c953358c865005855253af4f68a497John McCall 4042921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianbool Sema::checkUnsafeAssigns(SourceLocation Loc, 4043f85e193739c953358c865005855253af4f68a497John McCall QualType LHS, Expr *RHS) { 4044f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime(); 4045f85e193739c953358c865005855253af4f68a497John McCall if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone) 4046921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return false; 4047921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // strip off any implicit cast added to get to the one arc-specific 4048921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 404933e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 4050f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::warn_arc_retained_assign) 4051f85e193739c953358c865005855253af4f68a497John McCall << (LT == Qualifiers::OCL_ExplicitNone) 4052f85e193739c953358c865005855253af4f68a497John McCall << RHS->getSourceRange(); 4053921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return true; 4054921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4055921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 4056921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4057921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return false; 4058f85e193739c953358c865005855253af4f68a497John McCall} 4059f85e193739c953358c865005855253af4f68a497John McCall 4060921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianvoid Sema::checkUnsafeExprAssigns(SourceLocation Loc, 4061921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Expr *LHS, Expr *RHS) { 4062921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian QualType LHSType = LHS->getType(); 4063921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (checkUnsafeAssigns(Loc, LHSType, RHS)) 4064921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4065921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime(); 4066921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // FIXME. Check for other life times. 4067921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (LT != Qualifiers::OCL_None) 4068921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4069921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 4070921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (ObjCPropertyRefExpr *PRE = dyn_cast<ObjCPropertyRefExpr>(LHS)) { 4071921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (PRE->isImplicitProperty()) 4072921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4073921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 4074921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (!PD) 4075921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4076921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 4077921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian unsigned Attributes = PD->getPropertyAttributes(); 4078921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) 4079921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 408033e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 4081921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Diag(Loc, diag::warn_arc_retained_property_assign) 4082921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian << RHS->getSourceRange(); 4083921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4084921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4085921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 4086921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4087921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4088921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian} 4089