SemaChecking.cpp revision 5154dce6388e3aaa445467030df7a45ed1211abe
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// The LLVM Compiler Infrastructure 459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source 60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details. 759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump// This file implements extra semantic analysis beyond what is enforced 1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// by the C type system. 1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 1659907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h" 17199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h" 18384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 19c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h" 2055fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/AST/EvaluatedExprVisitor.h" 21be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie#include "clang/AST/Expr.h" 222324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h" 237ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h" 24f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h" 25f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h" 2655fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Analysis/Analyses/FormatString.h" 273f6f51e28231f65de9c2dd150a2d757b2162cfa3Jordan Rose#include "clang/Basic/CharInfo.h" 2855fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Basic/TargetBuiltins.h" 2955fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Basic/TargetInfo.h" 3059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h" 3155fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Initialization.h" 3255fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Lookup.h" 3355fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/ScopeInfo.h" 3455fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Sema.h" 35f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h" 36f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h" 3755fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "llvm/ADT/SmallString.h" 38cb5620c9b213f4bd323912159fdddda35e258a14Dmitri Gribenko#include "llvm/Support/ConvertUTF.h" 393bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h" 40a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits> 4159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang; 42781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema; 4359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 4460800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 4560800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned ByteNo) const { 4608f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner return SL->getLocationOfByte(ByteNo, PP.getSourceManager(), 474e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie PP.getLangOpts(), PP.getTargetInfo()); 4860800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner} 4960800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 508e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number. 518e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking. Returns true on error. 528e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) { 538e10f3b9cc1db43645bbc2999eb163af8997d468John McCall unsigned argCount = call->getNumArgs(); 548e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount == desiredArgCount) return false; 558e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 568e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount < desiredArgCount) 578e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args) 588e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 598e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getSourceRange(); 608e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 618e10f3b9cc1db43645bbc2999eb163af8997d468John McCall // Highlight all the excess arguments. 628e10f3b9cc1db43645bbc2999eb163af8997d468John McCall SourceRange range(call->getArg(desiredArgCount)->getLocStart(), 638e10f3b9cc1db43645bbc2999eb163af8997d468John McCall call->getArg(argCount - 1)->getLocEnd()); 648e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 658e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args) 668e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 678e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getArg(1)->getSourceRange(); 688e10f3b9cc1db43645bbc2999eb163af8997d468John McCall} 698e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 70e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// Check that the first argument to __builtin_annotation is an integer 71e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// and the second argument is a non-wide string literal. 72e59392176c2369df2bdd11b7786cb38abac00198Julien Lerougestatic bool SemaBuiltinAnnotation(Sema &S, CallExpr *TheCall) { 73e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (checkArgCount(S, TheCall, 2)) 74e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge return true; 75e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 76e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge // First argument should be an integer. 77e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge Expr *ValArg = TheCall->getArg(0); 78e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge QualType Ty = ValArg->getType(); 79e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (!Ty->isIntegerType()) { 80e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge S.Diag(ValArg->getLocStart(), diag::err_builtin_annotation_first_arg) 81e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge << ValArg->getSourceRange(); 82e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge return true; 83e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge } 84e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 85e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge // Second argument should be a constant string. 86e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge Expr *StrArg = TheCall->getArg(1)->IgnoreParenCasts(); 87e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge StringLiteral *Literal = dyn_cast<StringLiteral>(StrArg); 8877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge if (!Literal || !Literal->isAscii()) { 89e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge S.Diag(StrArg->getLocStart(), diag::err_builtin_annotation_second_arg) 90e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge << StrArg->getSourceRange(); 9177f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return true; 9277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge } 93e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 94e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge TheCall->setType(Ty); 9577f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return false; 9677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge} 9777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge 985154dce6388e3aaa445467030df7a45ed1211abeRichard Smith/// Check that the argument to __builtin_addressof is a glvalue, and set the 995154dce6388e3aaa445467030df7a45ed1211abeRichard Smith/// result type to the corresponding pointer type. 1005154dce6388e3aaa445467030df7a45ed1211abeRichard Smithstatic bool SemaBuiltinAddressof(Sema &S, CallExpr *TheCall) { 1015154dce6388e3aaa445467030df7a45ed1211abeRichard Smith if (checkArgCount(S, TheCall, 1)) 1025154dce6388e3aaa445467030df7a45ed1211abeRichard Smith return true; 1035154dce6388e3aaa445467030df7a45ed1211abeRichard Smith 1045154dce6388e3aaa445467030df7a45ed1211abeRichard Smith ExprResult Arg(S.Owned(TheCall->getArg(0))); 1055154dce6388e3aaa445467030df7a45ed1211abeRichard Smith QualType ResultType = S.CheckAddressOfOperand(Arg, TheCall->getLocStart()); 1065154dce6388e3aaa445467030df7a45ed1211abeRichard Smith if (ResultType.isNull()) 1075154dce6388e3aaa445467030df7a45ed1211abeRichard Smith return true; 1085154dce6388e3aaa445467030df7a45ed1211abeRichard Smith 1095154dce6388e3aaa445467030df7a45ed1211abeRichard Smith TheCall->setArg(0, Arg.take()); 1105154dce6388e3aaa445467030df7a45ed1211abeRichard Smith TheCall->setType(ResultType); 1115154dce6388e3aaa445467030df7a45ed1211abeRichard Smith return false; 1125154dce6388e3aaa445467030df7a45ed1211abeRichard Smith} 1135154dce6388e3aaa445467030df7a45ed1211abeRichard Smith 11460d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 115d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 11660d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult TheCallResult(Owned(TheCall)); 1172def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor 118946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Find out if any arguments are required to be integer constant expressions. 119946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner unsigned ICEArguments = 0; 120946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ASTContext::GetBuiltinTypeError Error; 121946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 122946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (Error != ASTContext::GE_None) 123946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments = 0; // Don't diagnose previously diagnosed errors. 124946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 125946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // If any arguments are required to be ICE's, check and diagnose. 126946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 127946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Skip arguments not required to be ICE's. 128946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if ((ICEArguments & (1 << ArgNo)) == 0) continue; 129946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 130946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner llvm::APSInt Result; 131946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 132946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner return true; 133946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments &= ~(1 << ArgNo); 134946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner } 135946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 136d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson switch (BuiltinID) { 13730ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin___CFStringMakeConstantString: 138925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner assert(TheCall->getNumArgs() == 1 && 1391b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner "Wrong # arguments to builtin CFStringMakeConstantString"); 140690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner if (CheckObjCString(TheCall->getArg(0))) 1410eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 142d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 14349ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek case Builtin::BI__builtin_stdarg_start: 14430ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin_va_start: 1450eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinVAStart(TheCall)) 1460eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 147d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1481b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreater: 1491b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreaterequal: 1501b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isless: 1511b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessequal: 1521b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessgreater: 1531b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isunordered: 1540eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinUnorderedCompare(TheCall)) 1550eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 156d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 157e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer case Builtin::BI__builtin_fpclassify: 158e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer if (SemaBuiltinFPClassification(TheCall, 6)) 159e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer return ExprError(); 160e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer break; 1619ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isfinite: 1629ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf: 1639ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf_sign: 1649ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnan: 1659ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnormal: 1663b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (SemaBuiltinFPClassification(TheCall, 1)) 1679ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return ExprError(); 1689ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman break; 169d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman case Builtin::BI__builtin_shufflevector: 1700eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return SemaBuiltinShuffleVector(TheCall); 1710eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // TheCall will be freed by the smart pointer here, but that's fine, since 1720eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // SemaBuiltinShuffleVector guts it, but then doesn't release it. 1734493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar case Builtin::BI__builtin_prefetch: 1740eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinPrefetch(TheCall)) 1750eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 176d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 177d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar case Builtin::BI__builtin_object_size: 1780eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinObjectSize(TheCall)) 1790eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 180d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 181d875fed28578835de89cd407e9db4be788596d7cEli Friedman case Builtin::BI__builtin_longjmp: 182d875fed28578835de89cd407e9db4be788596d7cEli Friedman if (SemaBuiltinLongjmp(TheCall)) 183d875fed28578835de89cd407e9db4be788596d7cEli Friedman return ExprError(); 184d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1858e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 1868e10f3b9cc1db43645bbc2999eb163af8997d468John McCall case Builtin::BI__builtin_classify_type: 1878e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1888e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 1898e10f3b9cc1db43645bbc2999eb163af8997d468John McCall break; 19075c29a012793292ff4578015a9113bf086156d7fChris Lattner case Builtin::BI__builtin_constant_p: 1918e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1928e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 19375c29a012793292ff4578015a9113bf086156d7fChris Lattner break; 1945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: 195a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 196a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 197a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 198a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 199a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 2005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: 201a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 202a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 203a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 204a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 205a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 2065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: 207a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 208a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 209a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 210a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 211a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 2125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: 213a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 214a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 215a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 216a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 217a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 2185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: 219a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 220a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 221a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 222a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 223a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 2245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_add_and_fetch: 225a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 226a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 227a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 228a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 229a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 2305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_sub_and_fetch: 231a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 232a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 233a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 234a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 235a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 2365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_and_and_fetch: 237a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 238a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 239a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 240a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 241a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 2425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_or_and_fetch: 243a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 244a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 245a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 246a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 247a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 2485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_xor_and_fetch: 249a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 250a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 251a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 252a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 253a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 2545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 255a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 256a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 257a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 258a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 259a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 2605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 261a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 262a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 263a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 264a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 265a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 2665caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_test_and_set: 267a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 268a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 269a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 270a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 271a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 2725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 273a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 274a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 275a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 276a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 277a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 27823aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: 279a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 280a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 281a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 282a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 283a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 2843fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return SemaBuiltinAtomicOverloaded(TheCallResult); 285ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define BUILTIN(ID, TYPE, ATTRS) 286ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define ATOMIC_BUILTIN(ID, TYPE, ATTRS) \ 287ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Builtin::BI##ID: \ 2883fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return SemaAtomicOpsOverloaded(TheCallResult, AtomicExpr::AO##ID); 289ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#include "clang/Basic/Builtins.def" 29077f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge case Builtin::BI__builtin_annotation: 291e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (SemaBuiltinAnnotation(*this, TheCall)) 29277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return ExprError(); 29377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge break; 2945154dce6388e3aaa445467030df7a45ed1211abeRichard Smith case Builtin::BI__builtin_addressof: 2955154dce6388e3aaa445467030df7a45ed1211abeRichard Smith if (SemaBuiltinAddressof(*this, TheCall)) 2965154dce6388e3aaa445467030df7a45ed1211abeRichard Smith return ExprError(); 2975154dce6388e3aaa445467030df7a45ed1211abeRichard Smith break; 29826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 29926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 30026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // Since the target specific builtins for each arch overlap, only check those 30126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // of the arch we are compiling for. 30226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (BuiltinID >= Builtin::FirstTSBuiltin) { 303bcfd1f55bfbb3e5944cd5e03d07b343e280838c4Douglas Gregor switch (Context.getTargetInfo().getTriple().getArch()) { 30426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::arm: 30526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::thumb: 30626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 30726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return ExprError(); 30826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 309fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips: 310fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mipsel: 311fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips64: 312fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips64el: 313fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (CheckMipsBuiltinFunctionCall(BuiltinID, TheCall)) 314fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return ExprError(); 315fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan break; 31626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman default: 31726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 31826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 31926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 32026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 3213fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return TheCallResult; 32226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman} 32326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 32461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code. 32561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) { 326da95f73b59f9af964e33725c515139d34c90c863Bob Wilson NeonTypeFlags Type(t); 327da95f73b59f9af964e33725c515139d34c90c863Bob Wilson int IsQuad = Type.isQuad(); 328da95f73b59f9af964e33725c515139d34c90c863Bob Wilson switch (Type.getEltType()) { 329da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int8: 330da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly8: 331da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 7 : (8 << IsQuad) - 1; 332da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int16: 333da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly16: 334da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 15 : (4 << IsQuad) - 1; 335da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int32: 336da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 31 : (2 << IsQuad) - 1; 337da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int64: 338da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 63 : (1 << IsQuad) - 1; 339da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float16: 340da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 341da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (4 << IsQuad) - 1; 342da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float32: 343da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 344da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (2 << IsQuad) - 1; 34561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman } 3467530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie llvm_unreachable("Invalid NeonTypeFlag!"); 34761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman} 34861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 3496f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// getNeonEltType - Return the QualType corresponding to the elements of 3506f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the vector type specified by the NeonTypeFlags. This is used to check 3516f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the pointer arguments for Neon load/store intrinsics. 3526f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilsonstatic QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context) { 3536f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson switch (Flags.getEltType()) { 3546f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int8: 3556f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy; 3566f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int16: 3576f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy; 3586f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int32: 3596f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy; 3606f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int64: 3616f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedLongLongTy : Context.LongLongTy; 3626f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly8: 3636f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.SignedCharTy; 3646f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly16: 3656f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.ShortTy; 3666f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float16: 3676f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.UnsignedShortTy; 3686f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float32: 3696f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.FloatTy; 3706f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 3717530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie llvm_unreachable("Invalid NeonTypeFlag!"); 3726f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson} 3736f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 37426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 3751c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman llvm::APSInt Result; 3761c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 377f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith uint64_t mask = 0; 37861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned TV = 0; 3794648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson int PtrArgNum = -1; 3806f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson bool HasConstPtr = false; 3811c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman switch (BuiltinID) { 382a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK 383a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 384a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK 3851c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman } 3861c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 3870d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which are overloaded on vector element type, validate 3880d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // the immediate which specifies which variant to emit. 3896f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson unsigned ImmArg = TheCall->getNumArgs()-1; 3900d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (mask) { 3916f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson if (SemaBuiltinConstantArg(TheCall, ImmArg, Result)) 3920d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 3930d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 394da95f73b59f9af964e33725c515139d34c90c863Bob Wilson TV = Result.getLimitedValue(64); 395f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith if ((TV > 63) || (mask & (1ULL << TV)) == 0) 3960d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 3976f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson << TheCall->getArg(ImmArg)->getSourceRange(); 3986f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 3996f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 4004648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (PtrArgNum >= 0) { 4016f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson // Check that pointer arguments have the specified type. 4024648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Expr *Arg = TheCall->getArg(PtrArgNum); 4034648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) 4044648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Arg = ICE->getSubExpr(); 4054648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg); 4064648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType RHSTy = RHS.get()->getType(); 4074648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context); 4084648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (HasConstPtr) 4094648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson EltTy = EltTy.withConst(); 4104648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType LHSTy = Context.getPointerType(EltTy); 4114648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson AssignConvertType ConvTy; 4124648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS); 4134648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (RHS.isInvalid()) 4144648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 4154648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy, 4164648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson RHS.get(), AA_Assigning)) 4174648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 4180d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman } 4191c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 4200d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which take an immediate value as part of the 4210d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // instruction, range check them here. 42261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned i = 0, l = 0, u = 0; 4230d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman switch (BuiltinID) { 4240d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman default: return false; 425bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 426bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 42799c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_f: 42899c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 429a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK 430a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 431a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK 4320d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman }; 4330d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 434592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 435592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 436592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor TheCall->getArg(i)->isValueDependent()) 437592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor return false; 438592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 43961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Check that the immediate argument is actually a constant. 4400d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, i, Result)) 4410d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 4420d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 44361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Range check against the upper/lower values for this isntruction. 4440d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned Val = Result.getZExtValue(); 44561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if (Val < l || Val > (u + l)) 4460d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 447476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer << l << u+l << TheCall->getArg(i)->getSourceRange(); 4480d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 44999c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman // FIXME: VFP Intrinsics should error if VFP not present. 45026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return false; 451d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson} 452d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 453fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyanbool Sema::CheckMipsBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 454fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan unsigned i = 0, l = 0, u = 0; 455fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan switch (BuiltinID) { 456fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan default: return false; 457fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case Mips::BI__builtin_mips_wrdsp: i = 1; l = 0; u = 63; break; 458fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case Mips::BI__builtin_mips_rddsp: i = 0; l = 0; u = 63; break; 459be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_append: i = 2; l = 0; u = 31; break; 460be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_balign: i = 2; l = 0; u = 3; break; 461be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_precr_sra_ph_w: i = 2; l = 0; u = 31; break; 462be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_precr_sra_r_ph_w: i = 2; l = 0; u = 31; break; 463be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_prepend: i = 2; l = 0; u = 31; break; 464fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan }; 465fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 466fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // We can't check the value of a dependent argument. 467fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (TheCall->getArg(i)->isTypeDependent() || 468fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan TheCall->getArg(i)->isValueDependent()) 469fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return false; 470fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 471fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // Check that the immediate argument is actually a constant. 472fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan llvm::APSInt Result; 473fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (SemaBuiltinConstantArg(TheCall, i, Result)) 474fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return true; 475fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 476fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // Range check against the upper/lower values for this instruction. 477fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan unsigned Val = Result.getZExtValue(); 478fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (Val < l || Val > u) 479fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 480fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan << l << u << TheCall->getArg(i)->getSourceRange(); 481fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 482fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return false; 483fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan} 484fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 485831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Given a FunctionDecl's FormatAttr, attempts to populate the FomatStringInfo 486831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// parameter with the FormatAttr's correct format_idx and firstDataArg. 487831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true when the format fits the function and the FormatStringInfo has 488831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// been populated. 489831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::getFormatStringInfo(const FormatAttr *Format, bool IsCXXMember, 490831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FormatStringInfo *FSI) { 491831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->HasVAListArg = Format->getFirstArg() == 0; 492831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->FormatIdx = Format->getFormatIdx() - 1; 493831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->FirstDataArg = FSI->HasVAListArg ? 0 : Format->getFirstArg() - 1; 494de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 495831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // The way the format attribute works in GCC, the implicit this argument 496831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // of member functions is counted. However, it doesn't appear in our own 497831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // lists, so decrement format_idx in that case. 498831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (IsCXXMember) { 499831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if(FSI->FormatIdx == 0) 500831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 501831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith --FSI->FormatIdx; 502831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (FSI->FirstDataArg != 0) 503831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith --FSI->FirstDataArg; 504831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 505831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return true; 506831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 5071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 508831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Handles the checks for format strings, non-POD arguments to vararg 509831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// functions, and NULL arguments passed to non-NULL parameters. 5101c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkovoid Sema::checkCall(NamedDecl *FDecl, 5111c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 512831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs, 513831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool IsMemberFunction, 514831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation Loc, 515831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceRange Range, 516831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType) { 51766360e224689dc23a0acd8a6705ba50bec13bc97Jordan Rose if (CurContext->isDependentContext()) 51866360e224689dc23a0acd8a6705ba50bec13bc97Jordan Rose return; 519de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 520c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek // Printf and scanf checking. 521831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool HandledFormatString = false; 5220538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu if (FDecl) 5230538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu for (specific_attr_iterator<FormatAttr> 5240538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu I = FDecl->specific_attr_begin<FormatAttr>(), 5250538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu E = FDecl->specific_attr_end<FormatAttr>(); I != E ; ++I) 5260538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu if (CheckFormatArguments(*I, Args, IsMemberFunction, CallType, Loc, 5270538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu Range)) 5280538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu HandledFormatString = true; 529831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 530831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // Refuse POD arguments that weren't caught by the format string 531831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // checks above. 532831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!HandledFormatString && CallType != VariadicDoesNotApply) 5331c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko for (unsigned ArgIdx = NumProtoArgs; ArgIdx < Args.size(); ++ArgIdx) { 5340234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek // Args[ArgIdx] can be null in malformed code. 5351c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko if (const Expr *Arg = Args[ArgIdx]) 5360234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek variadicArgumentPODCheck(Arg, CallType); 5370234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek } 5381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5390538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu if (FDecl) { 5400538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu for (specific_attr_iterator<NonNullAttr> 5410538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu I = FDecl->specific_attr_begin<NonNullAttr>(), 5420538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu E = FDecl->specific_attr_end<NonNullAttr>(); I != E; ++I) 5430538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu CheckNonNullArguments(*I, Args.data(), Loc); 5440538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu 5450538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu // Type safety checking. 5460538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu for (specific_attr_iterator<ArgumentWithTypeTagAttr> 5470538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu i = FDecl->specific_attr_begin<ArgumentWithTypeTagAttr>(), 5480538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu e = FDecl->specific_attr_end<ArgumentWithTypeTagAttr>(); 5490538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu i != e; ++i) { 5500538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu CheckArgumentWithTypeTag(*i, Args.data()); 5510538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu } 5520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 553831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 554831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 555831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckConstructorCall - Check a constructor call for correctness and safety 556831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// properties not enforced by the C type system. 5571c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkovoid Sema::CheckConstructorCall(FunctionDecl *FDecl, 5581c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 559831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const FunctionProtoType *Proto, 560831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation Loc) { 561831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = 562831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Proto->isVariadic() ? VariadicConstructor : VariadicDoesNotApply; 5631c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkCall(FDecl, Args, Proto->getNumArgs(), 564831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*IsMemberFunction=*/true, Loc, SourceRange(), CallType); 565831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 566831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 567831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckFunctionCall - Check a direct function call for various correctness 568831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// and safety properties not strictly enforced by the C type system. 569831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall, 570831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const FunctionProtoType *Proto) { 5712edcde8747a000113b434a5c88b4648beed4197bEli Friedman bool IsMemberOperatorCall = isa<CXXOperatorCallExpr>(TheCall) && 5722edcde8747a000113b434a5c88b4648beed4197bEli Friedman isa<CXXMethodDecl>(FDecl); 5732edcde8747a000113b434a5c88b4648beed4197bEli Friedman bool IsMemberFunction = isa<CXXMemberCallExpr>(TheCall) || 5742edcde8747a000113b434a5c88b4648beed4197bEli Friedman IsMemberOperatorCall; 575831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = getVariadicCallType(FDecl, Proto, 576831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()); 577831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0; 5782edcde8747a000113b434a5c88b4648beed4197bEli Friedman Expr** Args = TheCall->getArgs(); 5792edcde8747a000113b434a5c88b4648beed4197bEli Friedman unsigned NumArgs = TheCall->getNumArgs(); 580df75b0c74b277c6b46af2f9e90e13160fbc14d6fEli Friedman if (IsMemberOperatorCall) { 5812edcde8747a000113b434a5c88b4648beed4197bEli Friedman // If this is a call to a member operator, hide the first argument 5822edcde8747a000113b434a5c88b4648beed4197bEli Friedman // from checkCall. 5832edcde8747a000113b434a5c88b4648beed4197bEli Friedman // FIXME: Our choice of AST representation here is less than ideal. 5842edcde8747a000113b434a5c88b4648beed4197bEli Friedman ++Args; 5852edcde8747a000113b434a5c88b4648beed4197bEli Friedman --NumArgs; 5862edcde8747a000113b434a5c88b4648beed4197bEli Friedman } 5871c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkCall(FDecl, llvm::makeArrayRef<const Expr *>(Args, NumArgs), 5881c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko NumProtoArgs, 589831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith IsMemberFunction, TheCall->getRParenLoc(), 590831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()->getSourceRange(), CallType); 591831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 592831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith IdentifierInfo *FnInfo = FDecl->getIdentifier(); 593831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // None of the checks below are needed for functions that don't have 594831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // simple names (e.g., C++ conversion functions). 595831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!FnInfo) 596831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 5970eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 5980a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned CMId = FDecl->getMemoryFunctionKind(); 5990a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == 0) 600d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks return false; 601bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 602d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks // Handle memory setting and copying functions. 6030a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat) 604bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CheckStrlcpycatArguments(TheCall, FnInfo); 605c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (CMId == Builtin::BIstrncat) 606c36bedc90c687caa71748480c60707ea4608b092Anna Zaks CheckStrncatArguments(TheCall, FnInfo); 607d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks else 6080a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks CheckMemaccessArguments(TheCall, CMId, FnInfo); 6097ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 610d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 61171993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson} 61271993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 61329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupasbool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac, 614287f24d3991994b9a263af9e2a873f4feadfb8faDmitri Gribenko ArrayRef<const Expr *> Args) { 615831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = 616831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Method->isVariadic() ? VariadicMethod : VariadicDoesNotApply; 61729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 618287f24d3991994b9a263af9e2a873f4feadfb8faDmitri Gribenko checkCall(Method, Args, Method->param_size(), 619831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*IsMemberFunction=*/false, 620831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith lbrac, Method->getSourceRange(), CallType); 62129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 62229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return false; 62329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 62429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 625f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieubool Sema::CheckPointerCall(NamedDecl *NDecl, CallExpr *TheCall, 626f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu const FunctionProtoType *Proto) { 627725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian const VarDecl *V = dyn_cast<VarDecl>(NDecl); 628725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!V) 629d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 6301eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 631725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian QualType Ty = V->getType(); 632f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu if (!Ty->isBlockPointerType() && !Ty->isFunctionPointerType()) 633d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 6341eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 635f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu VariadicCallType CallType; 636a4993778f65212f01168c857cf3043e99ba85c9fRichard Trieu if (!Proto || !Proto->isVariadic()) { 637f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu CallType = VariadicDoesNotApply; 638f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu } else if (Ty->isBlockPointerType()) { 639f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu CallType = VariadicBlock; 640f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu } else { // Ty->isFunctionPointerType() 641f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu CallType = VariadicFunction; 642f462b0152f10eed0b989b07bcf457b6fb0d83bdbRichard Trieu } 643831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0; 644d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 6451c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkCall(NDecl, 6461c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko llvm::makeArrayRef<const Expr *>(TheCall->getArgs(), 6471c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko TheCall->getNumArgs()), 648831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith NumProtoArgs, /*IsMemberFunction=*/false, 649831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getRParenLoc(), 650831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()->getSourceRange(), CallType); 651831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 652d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 653725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian} 654725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian 6550538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu/// Checks function calls when a FunctionDecl or a NamedDecl is not available, 6560538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu/// such as function pointers returned from functions. 6570538f0e9200df56974b5a71bc276dbce456e9781Richard Trieubool Sema::CheckOtherCall(CallExpr *TheCall, const FunctionProtoType *Proto) { 6580538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu VariadicCallType CallType = getVariadicCallType(/*FDecl=*/0, Proto, 6590538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu TheCall->getCallee()); 6600538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0; 6610538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu 6620538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu checkCall(/*FDecl=*/0, 6630538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu llvm::makeArrayRef<const Expr *>(TheCall->getArgs(), 6640538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu TheCall->getNumArgs()), 6650538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu NumProtoArgs, /*IsMemberFunction=*/false, 6660538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu TheCall->getRParenLoc(), 6670538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu TheCall->getCallee()->getSourceRange(), CallType); 6680538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu 6690538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu return false; 6700538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu} 6710538f0e9200df56974b5a71bc276dbce456e9781Richard Trieu 672ff34d401ff385ef7173ca612432b4ea717fff690Richard SmithExprResult Sema::SemaAtomicOpsOverloaded(ExprResult TheCallResult, 673ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith AtomicExpr::AtomicOp Op) { 674276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman CallExpr *TheCall = cast<CallExpr>(TheCallResult.get()); 675276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 676276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 677ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // All these operations take one of the following forms: 678ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith enum { 679ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_init(A *, C) 680ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Init, 681ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_load(A *, int) 682ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Load, 683ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // void __atomic_load(A *, CP, int) 684ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Copy, 685ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_add(A *, M, int) 686ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Arithmetic, 687ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __atomic_exchange_n(A *, CP, int) 688ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Xchg, 689ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // void __atomic_exchange(A *, C *, CP, int) 690ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith GNUXchg, 691ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // bool __c11_atomic_compare_exchange_strong(A *, C *, CP, int, int) 692ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith C11CmpXchg, 693ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // bool __atomic_compare_exchange(A *, C *, CP, bool, int, int) 694ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith GNUCmpXchg 695ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } Form = Init; 696ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith const unsigned NumArgs[] = { 2, 2, 3, 3, 3, 4, 5, 6 }; 697ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith const unsigned NumVals[] = { 1, 0, 1, 1, 1, 2, 2, 3 }; 698ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // where: 699ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C is an appropriate type, 700ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // A is volatile _Atomic(C) for __c11 builtins and is C for GNU builtins, 701ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // CP is C for __c11 builtins and GNU _n builtins and is C * otherwise, 702ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // M is C if C is an integer, and ptrdiff_t if C is a pointer, and 703ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // the int parameters are for orderings. 704ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 705ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith assert(AtomicExpr::AO__c11_atomic_init == 0 && 706ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith AtomicExpr::AO__c11_atomic_fetch_xor + 1 == AtomicExpr::AO__atomic_load 707ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith && "need to update code for modified C11 atomics"); 708ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsC11 = Op >= AtomicExpr::AO__c11_atomic_init && 709ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op <= AtomicExpr::AO__c11_atomic_fetch_xor; 710ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsN = Op == AtomicExpr::AO__atomic_load_n || 711ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_store_n || 712ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_exchange_n || 713ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_compare_exchange_n; 714ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsAddSub = false; 715ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 716ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (Op) { 717ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_init: 718ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Init; 719ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 720ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 721ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_load: 722ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_load_n: 723ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Load; 724ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 725ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 726ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_store: 727ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_load: 728ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_store: 729ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_store_n: 730ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Copy; 731ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 732ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 733ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_add: 734ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_sub: 735ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_add: 736ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_sub: 737ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_add_fetch: 738ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_sub_fetch: 739ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith IsAddSub = true; 740ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Fall through. 741ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_and: 742ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_or: 743ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_xor: 744ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_and: 745ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_or: 746ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_xor: 74751b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith case AtomicExpr::AO__atomic_fetch_nand: 748ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_and_fetch: 749ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_or_fetch: 750ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_xor_fetch: 75151b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith case AtomicExpr::AO__atomic_nand_fetch: 752ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Arithmetic; 753ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 754ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 755ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_exchange: 756ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_exchange_n: 757ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Xchg; 758ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 759ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 760ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_exchange: 761ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = GNUXchg; 762ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 763ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 764ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_compare_exchange_strong: 765ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_compare_exchange_weak: 766ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = C11CmpXchg; 767ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 768ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 769ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_compare_exchange: 770ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_compare_exchange_n: 771ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = GNUCmpXchg; 772ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 773276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 774276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 775ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Check we have the right number of arguments. 776ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (TheCall->getNumArgs() < NumArgs[Form]) { 777276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 778ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << 0 << NumArgs[Form] << TheCall->getNumArgs() 779276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 780276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 781ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } else if (TheCall->getNumArgs() > NumArgs[Form]) { 782ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(TheCall->getArg(NumArgs[Form])->getLocStart(), 783276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman diag::err_typecheck_call_too_many_args) 784ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << 0 << NumArgs[Form] << TheCall->getNumArgs() 785276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 786276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 787276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 788276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 789ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Inspect the first argument of the atomic operation. 790dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman Expr *Ptr = TheCall->getArg(0); 791276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get(); 792276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman const PointerType *pointerType = Ptr->getType()->getAs<PointerType>(); 793276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!pointerType) { 794ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 795276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 796276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 797276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 798276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 799ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For a __c11 builtin, this should be a pointer to an _Atomic type. 800ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType AtomTy = pointerType->getPointeeType(); // 'A' 801ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType ValType = AtomTy; // 'C' 802ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (IsC11) { 803ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!AtomTy->isAtomicType()) { 804ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic) 805ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << Ptr->getType() << Ptr->getSourceRange(); 806ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 807ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 808bc57b108b2253e26b83768dba196c28564952f18Richard Smith if (AtomTy.isConstQualified()) { 809bc57b108b2253e26b83768dba196c28564952f18Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_non_const_atomic) 810bc57b108b2253e26b83768dba196c28564952f18Richard Smith << Ptr->getType() << Ptr->getSourceRange(); 811bc57b108b2253e26b83768dba196c28564952f18Richard Smith return ExprError(); 812bc57b108b2253e26b83768dba196c28564952f18Richard Smith } 813ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ValType = AtomTy->getAs<AtomicType>()->getValueType(); 814276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 815276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 816ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For an arithmetic operation, the implied arithmetic must be well-formed. 817ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Arithmetic) { 818ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // gcc does not enforce these rules for GNU atomics, but we do so for sanity. 819ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (IsAddSub && !ValType->isIntegerType() && !ValType->isPointerType()) { 820ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 821ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 822ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 823ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 824ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsAddSub && !ValType->isIntegerType()) { 825ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_bitwise_needs_atomic_int) 826ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 827ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 828ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 829ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } else if (IsN && !ValType->isIntegerType() && !ValType->isPointerType()) { 830ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For __atomic_*_n operations, the value type must be a scalar integral or 831ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // pointer type which is 1, 2, 4, 8 or 16 bytes in length. 832276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 833ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 834276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 835276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 836276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 837ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsC11 && !AtomTy.isTriviallyCopyableType(Context)) { 838ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For GNU atomics, require a trivially-copyable type. This is not part of 839ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // the GNU atomics specification, but we enforce it for sanity. 840ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_trivial_copy) 841276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 842276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 843276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 844276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 845ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // FIXME: For any builtin other than a load, the ValType must not be 846ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // const-qualified. 847ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 848276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman switch (ValType.getObjCLifetime()) { 849276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_None: 850276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_ExplicitNone: 851276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // okay 852276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman break; 853276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 854276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Weak: 855276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Strong: 856276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Autoreleasing: 857ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // FIXME: Can this happen? By this point, ValType should be known 858ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // to be trivially copyable. 859276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 860276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << ValType << Ptr->getSourceRange(); 861276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 862276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 863276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 864276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType ResultType = ValType; 865ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Copy || Form == GNUXchg || Form == Init) 866276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.VoidTy; 867ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == C11CmpXchg || Form == GNUCmpXchg) 868276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.BoolTy; 869276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 870ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The type of a parameter passed 'by value'. In the GNU atomics, such 871ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // arguments are actually passed as pointers. 872ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType ByValType = ValType; // 'CP' 873ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsC11 && !IsN) 874ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ByValType = Ptr->getType(); 875ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 876276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The first argument --- the pointer --- has a fixed type; we 877276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // deduce the types of the rest of the arguments accordingly. Walk 878276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // the remaining arguments, converting them to the deduced value type. 879ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith for (unsigned i = 1; i != NumArgs[Form]; ++i) { 880276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType Ty; 881ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (i < NumVals[Form] + 1) { 882ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (i) { 883ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 1: 884ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The second argument is the non-atomic operand. For arithmetic, this 885ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // is always passed by value, and for a compare_exchange it is always 886ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // passed by address. For the rest, GNU uses by-address and C11 uses 887ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // by-value. 888ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith assert(Form != Load); 889ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Init || (Form == Arithmetic && ValType->isIntegerType())) 890ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ValType; 891ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == Copy || Form == Xchg) 892ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ByValType; 893ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == Arithmetic) 894ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.getPointerDiffType(); 895ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else 896ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.getPointerType(ValType.getUnqualifiedType()); 897ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 898ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 2: 899ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The third argument to compare_exchange / GNU exchange is a 900ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // (pointer to a) desired value. 901ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ByValType; 902ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 903ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 3: 904ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The fourth argument to GNU compare_exchange is a 'weak' flag. 905ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.BoolTy; 906ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 907ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 908276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else { 909276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The order(s) are always converted to int. 910276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.IntTy; 911276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 912ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 913276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity Entity = 914276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity::InitializeParameter(Context, Ty, false); 915ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ExprResult Arg = TheCall->getArg(i); 916276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 917276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Arg.isInvalid()) 918276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return true; 919276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman TheCall->setArg(i, Arg.get()); 920276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 921276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 922ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Permute the arguments into a 'consistent' order. 923dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SmallVector<Expr*, 5> SubExprs; 924dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(Ptr); 925ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (Form) { 926ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Init: 927ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Note, AtomicExpr::getVal1() has a special case for this atomic. 9287a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall SubExprs.push_back(TheCall->getArg(1)); // Val1 929ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 930ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Load: 931ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Order 932ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 933ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Copy: 934ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Arithmetic: 935ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Xchg: 936dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(2)); // Order 937dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 938ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 939ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case GNUXchg: 940ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Note, AtomicExpr::getVal2() has a special case for this atomic. 941ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(3)); // Order 942ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Val1 943ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(2)); // Val2 944ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 945ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case C11CmpXchg: 946dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(3)); // Order 947dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 948dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(4)); // OrderFail 9492ebb98a78471f2039af4321bae657e7daacc2a62David Chisnall SubExprs.push_back(TheCall->getArg(2)); // Val2 950ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 951ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case GNUCmpXchg: 952ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(4)); // Order 953ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Val1 954ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(5)); // OrderFail 955ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(2)); // Val2 956ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(3)); // Weak 957ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 958276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 959538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian 960538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian AtomicExpr *AE = new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(), 961538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian SubExprs, ResultType, Op, 962538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian TheCall->getRParenLoc()); 963538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian 964538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian if ((Op == AtomicExpr::AO__c11_atomic_load || 965538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian (Op == AtomicExpr::AO__c11_atomic_store)) && 966538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian Context.AtomicUsesUnsupportedLibcall(AE)) 967538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian Diag(AE->getLocStart(), diag::err_atomic_load_store_uses_lib) << 968538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian ((Op == AtomicExpr::AO__c11_atomic_load) ? 0 : 1); 969dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman 970538bbe597b935a74d95c668ad209536753f13481Fariborz Jahanian return Owned(AE); 971276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman} 972276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 973276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 9745f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// checkBuiltinArgument - Given a call to a builtin function, perform 9755f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// normal type-checking on the given argument, updating the call in 9765f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// place. This is useful when a builtin function requires custom 9775f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// type-checking for some of its arguments but not necessarily all of 9785f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// them. 9795f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// 9805f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// Returns true on error. 9815f8d604246976a93a73549b07bbc8ee0b2061b50John McCallstatic bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) { 9825f8d604246976a93a73549b07bbc8ee0b2061b50John McCall FunctionDecl *Fn = E->getDirectCallee(); 9835f8d604246976a93a73549b07bbc8ee0b2061b50John McCall assert(Fn && "builtin call without direct callee!"); 9845f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9855f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ParmVarDecl *Param = Fn->getParamDecl(ArgIndex); 9865f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity Entity = 9875f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity::InitializeParameter(S.Context, Param); 9885f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9895f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ExprResult Arg = E->getArg(0); 9905f8d604246976a93a73549b07bbc8ee0b2061b50John McCall Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg); 9915f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (Arg.isInvalid()) 9925f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 9935f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9945f8d604246976a93a73549b07bbc8ee0b2061b50John McCall E->setArg(ArgIndex, Arg.take()); 9955f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return false; 9965f8d604246976a93a73549b07bbc8ee0b2061b50John McCall} 9975f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like 9995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer 10005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument. The main ActOnCallExpr routines have already 10015caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as 10025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...). 10035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// 10045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these 10055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins, 100660d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 100760d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 1008d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 10095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 10105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 10115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 10125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Ensure that we have at least one argument to do type inference from. 1013d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1) { 1014d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 1015d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1 << TheCall->getNumArgs() 1016d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 1017d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 1018d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 10191eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Inspect the first argument of the atomic builtin. This should always be 10215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // a pointer type, whose element is an integral scalar or pointer type. 10225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Because it is a pointer type, we don't have to worry about any implicit 10235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // casts here. 1024d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth // FIXME: We don't allow floating point scalars as input. 10255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *FirstArg = TheCall->getArg(0); 10268c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg); 10278c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman if (FirstArgResult.isInvalid()) 10288c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman return ExprError(); 10298c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman FirstArg = FirstArgResult.take(); 10308c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman TheCall->setArg(0, FirstArg); 10318c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman 1032f85e193739c953358c865005855253af4f68a497John McCall const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>(); 1033f85e193739c953358c865005855253af4f68a497John McCall if (!pointerType) { 1034d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 1035d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 1036d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 1037d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 10381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1039f85e193739c953358c865005855253af4f68a497John McCall QualType ValType = pointerType->getPointeeType(); 1040dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 1041d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth !ValType->isBlockPointerType()) { 1042d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 1043d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 1044d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 1045d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 10465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 1047f85e193739c953358c865005855253af4f68a497John McCall switch (ValType.getObjCLifetime()) { 1048f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 1049f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 1050f85e193739c953358c865005855253af4f68a497John McCall // okay 1051f85e193739c953358c865005855253af4f68a497John McCall break; 1052f85e193739c953358c865005855253af4f68a497John McCall 1053f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 1054f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 1055f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 1056b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 1057f85e193739c953358c865005855253af4f68a497John McCall << ValType << FirstArg->getSourceRange(); 1058f85e193739c953358c865005855253af4f68a497John McCall return ExprError(); 1059f85e193739c953358c865005855253af4f68a497John McCall } 1060f85e193739c953358c865005855253af4f68a497John McCall 1061b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Strip any qualifiers off ValType. 1062b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType = ValType.getUnqualifiedType(); 1063b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall 10648d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // The majority of builtins return a value, but a few have special return 10658d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // types, so allow them to override appropriately below. 10668d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth QualType ResultType = ValType; 10678d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth 10685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // We need to figure out which concrete builtin this maps onto. For example, 10695caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add with a 2 byte object turns into 10705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add_2. 10715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \ 10725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 10735caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Builtin::BI##x##_8, Builtin::BI##x##_16 } 10741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10755caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner static const unsigned BuiltinIndices[][5] = { 10765caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_add), 10775caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_sub), 10785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_or), 10795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_and), 10805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_xor), 10811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_add_and_fetch), 10835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_sub_and_fetch), 10845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_and_and_fetch), 10855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_or_and_fetch), 10865caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_xor_and_fetch), 10871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_val_compare_and_swap), 10895caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_bool_compare_and_swap), 10905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_test_and_set), 109123aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_lock_release), 109223aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_swap) 10935caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner }; 10941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW 10951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Determine the index of the size. 10975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned SizeIndex; 1098199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 10995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 1: SizeIndex = 0; break; 11005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 2: SizeIndex = 1; break; 11015caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 4: SizeIndex = 2; break; 11025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 8: SizeIndex = 3; break; 11035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 16: SizeIndex = 4; break; 11045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: 1105d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 1106d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 1107d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 11085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 11091eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Each of these builtins has one pointer argument, followed by some number of 11115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // values (0, 1 or 2) followed by a potentially empty varags list of stuff 11125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // that we ignore. Find out which row of BuiltinIndices to read from as well 11135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // as the number of fixed args. 11147814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor unsigned BuiltinID = FDecl->getBuiltinID(); 11155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned BuiltinIndex, NumFixed = 1; 11165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner switch (BuiltinID) { 1117b219cfc4d75f0a03630b7c4509ef791b7e97b2c8David Blaikie default: llvm_unreachable("Unknown overloaded atomic builtin!"); 1118a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add: 1119a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 1120a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 1121a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 1122a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 1123a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 1124a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 0; 1125a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1126a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1127a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub: 1128a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 1129a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 1130a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 1131a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 1132a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 1133a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 1; 1134a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1135a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1136a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or: 1137a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 1138a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 1139a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 1140a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 1141a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 1142a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 2; 1143a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1144a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1145a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and: 1146a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 1147a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 1148a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 1149a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 1150a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 1151a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 3; 1152a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1153a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1154a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor: 1155a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 1156a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 1157a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 1158a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 1159a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 1160a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 4; 1161a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1162a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1163a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch: 1164a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 1165a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 1166a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 1167a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 1168a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 1169a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 5; 1170a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1171a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1172a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch: 1173a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 1174a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 1175a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 1176a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 1177a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 1178a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 6; 1179a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1180a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1181a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch: 1182a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 1183a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 1184a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 1185a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 1186a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 1187a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 7; 1188a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1189a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1190a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch: 1191a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 1192a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 1193a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 1194a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 1195a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 1196a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 8; 1197a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1198a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1199a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch: 1200a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 1201a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 1202a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 1203a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 1204a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 1205a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 9; 1206a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 12071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 1209a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 1210a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 1211a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 1212a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 1213a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 12147eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 10; 12155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 12165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1217a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 12185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 1219a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 1220a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 1221a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 1222a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 1223a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 12247eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 11; 12255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 12268d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.BoolTy; 12275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1228a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1229a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set: 1230a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 1231a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 1232a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 1233a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 1234a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 1235a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 12; 1236a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1237a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 12385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 1239a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 1240a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 1241a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 1242a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 1243a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 12447eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 13; 12455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 0; 12468d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.VoidTy; 12475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1248a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1249a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap: 1250a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 1251a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 1252a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 1253a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 1254a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 1255a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 14; 1256a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 12575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 12581eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Now that we know how many fixed arguments we expect, first check that we 12605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // have at least that many. 1261d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1+NumFixed) { 1262d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 1263d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1+NumFixed << TheCall->getNumArgs() 1264d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 1265d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 1266d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 12671eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1268e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // Get the decl for the concrete builtin from this, we can tell what the 1269e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // concrete integer type we should convert to is. 1270e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 1271e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 12722ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara FunctionDecl *NewBuiltinDecl; 12732ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara if (NewBuiltinID == BuiltinID) 12742ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara NewBuiltinDecl = FDecl; 12752ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara else { 12762ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara // Perform builtin lookup to avoid redeclaring it. 12772ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara DeclarationName DN(&Context.Idents.get(NewBuiltinName)); 12782ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara LookupResult Res(*this, DN, DRE->getLocStart(), LookupOrdinaryName); 12792ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara LookupName(Res, TUScope, /*AllowBuiltinCreation=*/true); 12802ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara assert(Res.getFoundDecl()); 12812ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara NewBuiltinDecl = dyn_cast<FunctionDecl>(Res.getFoundDecl()); 12822ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara if (NewBuiltinDecl == 0) 12832ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara return ExprError(); 12842ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara } 1285d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 1286f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // The first argument --- the pointer --- has a fixed type; we 1287f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // deduce the types of the rest of the arguments accordingly. Walk 1288f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // the remaining arguments, converting them to the deduced value type. 12895caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner for (unsigned i = 0; i != NumFixed; ++i) { 1290429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult Arg = TheCall->getArg(i+1); 12911eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // GCC does an implicit conversion to the pointer or integer ValType. This 12935caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // can fail in some cases (1i -> int**), check for this error case now. 1294b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Initialize the argument. 1295b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall InitializedEntity Entity = InitializedEntity::InitializeParameter(Context, 1296b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType, /*consume*/ false); 1297b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 1298429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (Arg.isInvalid()) 1299d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 13001eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 13015caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Okay, we have something that *can* be converted to the right type. Check 13025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // to see if there is a potentially weird extension going on here. This can 13035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // happen when you do an atomic operation on something like an char* and 13045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // pass in 42. The 42 gets converted to char. This is even more strange 13055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // for things like 45.123 -> char, etc. 13061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // FIXME: Do this check. 1307b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall TheCall->setArg(i+1, Arg.take()); 13085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 13091eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1310bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor ASTContext& Context = this->getASTContext(); 1311bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor 1312bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor // Create a new DeclRefExpr to refer to the new decl. 1313bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DeclRefExpr* NewDRE = DeclRefExpr::Create( 1314bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor Context, 1315bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getQualifierLoc(), 1316e4b92761b43ced611c417ae478568610f1ad7b1eAbramo Bagnara SourceLocation(), 1317bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor NewBuiltinDecl, 1318f4b88a45902af1802a1cb42ba48b1c474474f228John McCall /*enclosing*/ false, 1319bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getLocation(), 1320a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman Context.BuiltinFnTy, 1321bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getValueKind()); 13221eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 13235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Set the callee in the CallExpr. 1324a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman // FIXME: This loses syntactic information. 1325a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman QualType CalleePtrTy = Context.getPointerType(NewBuiltinDecl->getType()); 1326a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman ExprResult PromotedCall = ImpCastExprToType(NewDRE, CalleePtrTy, 1327a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman CK_BuiltinFnToFnPtr); 1328429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setCallee(PromotedCall.take()); 13291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1330db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // Change the result type of the call to match the original value type. This 1331db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // is arbitrary, but the codegen for these builtins ins design to handle it 1332db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // gracefully. 13338d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth TheCall->setType(ResultType); 1334d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 13353fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return TheCallResult; 13365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner} 13375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 1338690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin 133971993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct 1340fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would 1341fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend). 1342690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) { 134356f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner Arg = Arg->IgnoreParenCasts(); 134471993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 134571993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 13465cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!Literal || !Literal->isAscii()) { 1347fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 1348fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << Arg->getSourceRange(); 13499cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return true; 135071993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson } 13511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 13527da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Literal->containsNonAsciiOrNull()) { 13535f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef String = Literal->getString(); 13547da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian unsigned NumBytes = String.size(); 13555f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<UTF16, 128> ToBuf(NumBytes); 135631ba6135375433b617a8587ea6cc836a014ebd86Roman Divacky const UTF8 *FromPtr = (const UTF8 *)String.data(); 13577da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian UTF16 *ToPtr = &ToBuf[0]; 13587da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 13597da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 13607da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian &ToPtr, ToPtr + NumBytes, 13617da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian strictConversion); 13627da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian // Check for conversion failure. 13637da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Result != conversionOK) 13647da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian Diag(Arg->getLocStart(), 13657da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian diag::warn_cfstring_truncated) << Arg->getSourceRange(); 13667da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian } 13679cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return false; 136859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner} 136959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 1370c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 1371c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success. 1372925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 1373925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *Fn = TheCall->getCallee(); 1374925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) { 13752c21a073525cdfa68e4439b7af551385dc2796abChris Lattner Diag(TheCall->getArg(2)->getLocStart(), 1376fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1377ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1378ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << Fn->getSourceRange() 13791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(2)->getLocStart(), 1380fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 138130ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 138230ce344307f8a8b00054021307015571f83c7364Chris Lattner } 138356f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 138456f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman if (TheCall->getNumArgs() < 2) { 1385d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher return Diag(TheCall->getLocEnd(), 1386d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 1387d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 138856f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman } 138956f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 13905f8d604246976a93a73549b07bbc8ee0b2061b50John McCall // Type-check the first argument normally. 13915f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (checkBuiltinArgument(*this, TheCall, 0)) 13925f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 13935f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 1394c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner // Determine whether the current function is variadic or not. 13959ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor BlockScopeInfo *CurBlock = getCurBlock(); 1396c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner bool isVariadic; 1397cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1398c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall isVariadic = CurBlock->TheDecl->isVariadic(); 13999498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else if (FunctionDecl *FD = getCurFunctionDecl()) 14009498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek isVariadic = FD->isVariadic(); 14019498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else 140253d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis isVariadic = getCurMethodDecl()->isVariadic(); 14031eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1404c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner if (!isVariadic) { 140530ce344307f8a8b00054021307015571f83c7364Chris Lattner Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 140630ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 140730ce344307f8a8b00054021307015571f83c7364Chris Lattner } 14081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 140930ce344307f8a8b00054021307015571f83c7364Chris Lattner // Verify that the second argument to the builtin is the last argument of the 141030ce344307f8a8b00054021307015571f83c7364Chris Lattner // current function or method. 141130ce344307f8a8b00054021307015571f83c7364Chris Lattner bool SecondArgIsLastNamedArgument = false; 1412e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 14131eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1414b07d448a625d7399d871079d55491c6b10316e6fNico Weber // These are valid if SecondArgIsLastNamedArgument is false after the next 1415b07d448a625d7399d871079d55491c6b10316e6fNico Weber // block. 1416b07d448a625d7399d871079d55491c6b10316e6fNico Weber QualType Type; 1417b07d448a625d7399d871079d55491c6b10316e6fNico Weber SourceLocation ParamLoc; 1418b07d448a625d7399d871079d55491c6b10316e6fNico Weber 141988cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 142088cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 142130ce344307f8a8b00054021307015571f83c7364Chris Lattner // FIXME: This isn't correct for methods (results in bogus warning). 142230ce344307f8a8b00054021307015571f83c7364Chris Lattner // Get the last formal in the current function. 142388cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson const ParmVarDecl *LastArg; 1424cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1425cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff LastArg = *(CurBlock->TheDecl->param_end()-1); 1426cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff else if (FunctionDecl *FD = getCurFunctionDecl()) 1427371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner LastArg = *(FD->param_end()-1); 142830ce344307f8a8b00054021307015571f83c7364Chris Lattner else 142953d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis LastArg = *(getCurMethodDecl()->param_end()-1); 143030ce344307f8a8b00054021307015571f83c7364Chris Lattner SecondArgIsLastNamedArgument = PV == LastArg; 1431b07d448a625d7399d871079d55491c6b10316e6fNico Weber 1432b07d448a625d7399d871079d55491c6b10316e6fNico Weber Type = PV->getType(); 1433b07d448a625d7399d871079d55491c6b10316e6fNico Weber ParamLoc = PV->getLocation(); 143430ce344307f8a8b00054021307015571f83c7364Chris Lattner } 143530ce344307f8a8b00054021307015571f83c7364Chris Lattner } 14361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 143730ce344307f8a8b00054021307015571f83c7364Chris Lattner if (!SecondArgIsLastNamedArgument) 14381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(1)->getLocStart(), 143930ce344307f8a8b00054021307015571f83c7364Chris Lattner diag::warn_second_parameter_of_va_start_not_last_named_argument); 1440b07d448a625d7399d871079d55491c6b10316e6fNico Weber else if (Type->isReferenceType()) { 1441b07d448a625d7399d871079d55491c6b10316e6fNico Weber Diag(Arg->getLocStart(), 1442b07d448a625d7399d871079d55491c6b10316e6fNico Weber diag::warn_va_start_of_reference_type_is_undefined); 1443b07d448a625d7399d871079d55491c6b10316e6fNico Weber Diag(ParamLoc, diag::note_parameter_type) << Type; 1444b07d448a625d7399d871079d55491c6b10316e6fNico Weber } 1445b07d448a625d7399d871079d55491c6b10316e6fNico Weber 144630ce344307f8a8b00054021307015571f83c7364Chris Lattner return false; 14476cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman} 144830ce344307f8a8b00054021307015571f83c7364Chris Lattner 14491b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 14501b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends. This is declared to take (...), so we have to check everything. 1451925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 1452925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() < 2) 14532c21a073525cdfa68e4439b7af551385dc2796abChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1454d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << 2 << TheCall->getNumArgs()/*function call*/; 1455925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) 14561eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(TheCall->getArg(2)->getLocStart(), 1457fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1458ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1459fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(TheCall->getArg(2)->getLocStart(), 1460fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 14611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1462429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg0 = TheCall->getArg(0); 1463429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg1 = TheCall->getArg(1); 1464cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 14651b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // Do standard promotions between the two arguments, returning their common 14661b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // type. 1467925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 1468429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.isInvalid() || OrigArg1.isInvalid()) 1469429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return true; 1470403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar 1471403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // Make sure any conversions are pushed back into the call; this is 1472403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // type safe since unordered compare builtins are declared as "_Bool 1473403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // foo(...)". 1474429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(0, OrigArg0.get()); 1475429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(1, OrigArg1.get()); 14761eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1477429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent()) 1478cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 1479cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 14801b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // If the common type isn't a real floating type, then the arguments were 14811b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // invalid for this operation. 1482860a319e62b0e256817a458396d191aa91c0787aEli Friedman if (Res.isNull() || !Res->isRealFloatingType()) 1483429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return Diag(OrigArg0.get()->getLocStart(), 1484fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_invalid_ordered_compare) 1485429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << OrigArg0.get()->getType() << OrigArg1.get()->getType() 1486429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd()); 14871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 14881b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner return false; 14891b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner} 14901b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner 1491e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 1492e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends. This is declared to take (...), so we have 14933b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point 14943b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value. 14953b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 14963b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() < NumArgs) 14979ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1498d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 14993b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() > NumArgs) 15003b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer return Diag(TheCall->getArg(NumArgs)->getLocStart(), 15019ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_too_many_args) 1502ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 15033b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 15049ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman (*(TheCall->arg_end()-1))->getLocEnd()); 15059ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 15063b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer Expr *OrigArg = TheCall->getArg(NumArgs-1); 15071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 15089ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (OrigArg->isTypeDependent()) 15099ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 15109ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 151181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // This operation requires a non-_Complex floating-point number. 15129ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (!OrigArg->getType()->isRealFloatingType()) 15131eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg->getLocStart(), 15149ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_invalid_unary_fp) 15159ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman << OrigArg->getType() << OrigArg->getSourceRange(); 15161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 151781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // If this is an implicit conversion from float -> double, remove it. 151881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 151981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Expr *CastArg = Cast->getSubExpr(); 152081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 152181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 152281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner "promotion from float to double is the only expected cast here"); 152381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Cast->setSubExpr(0); 152481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner TheCall->setArg(NumArgs-1, CastArg); 152581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 152681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 152781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner 15289ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 15299ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman} 15309ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 1531d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 1532d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything. 153360d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 153437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() < 2) 15350eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocEnd(), 1536d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 153737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1538d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << TheCall->getSourceRange()); 1539d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 154037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Determine which of the following types of shufflevector we're checking: 154137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 1) unary, vector mask: (lhs, mask) 154237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 2) binary, vector mask: (lhs, rhs, mask) 154337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 154437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType resType = TheCall->getArg(0)->getType(); 154537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numElements = 0; 154637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 1547cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (!TheCall->getArg(0)->isTypeDependent() && 1548cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor !TheCall->getArg(1)->isTypeDependent()) { 154937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType LHSType = TheCall->getArg(0)->getType(); 155037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType RHSType = TheCall->getArg(1)->getType(); 155137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 155237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!LHSType->isVectorType() || !RHSType->isVectorType()) { 1553cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) 15541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1555cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1556cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 1557cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 155837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 155937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numElements = LHSType->getAs<VectorType>()->getNumElements(); 156037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numResElements = TheCall->getNumArgs() - 2; 156137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 156237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Check to see if we have a call with 2 vector arguments, the unary shuffle 156337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // with mask. If so, verify that RHS is an integer vector type with the 156437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // same number of elts as lhs. 156537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() == 2) { 15664cb3d909cb4af5efc073fd4122d4998c466a220eSylvestre Ledru if (!RHSType->hasIntegerRepresentation() || 156737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman RHSType->getAs<VectorType>()->getNumElements() != numElements) 156837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 156937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << SourceRange(TheCall->getArg(1)->getLocStart(), 157037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman TheCall->getArg(1)->getLocEnd()); 157137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } 157237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 1573cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 15741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1575cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1576cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 157737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } else if (numElements != numResElements) { 157837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 1579788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner resType = Context.getVectorType(eltType, numResElements, 1580e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson VectorType::GenericVector); 1581cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 1582d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1583d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1584d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 1585cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 1586cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(i)->isValueDependent()) 1587cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor continue; 1588cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 158937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman llvm::APSInt Result(32); 159037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 159137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman return ExprError(Diag(TheCall->getLocStart(), 159237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman diag::err_shufflevector_nonconstant_argument) 159337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << TheCall->getArg(i)->getSourceRange()); 15940eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 1595d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 15960eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocStart(), 1597fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_shufflevector_argument_too_large) 15980eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl << TheCall->getArg(i)->getSourceRange()); 1599d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1600d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 16015f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<Expr*, 32> exprs; 1602d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1603d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 1604d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman exprs.push_back(TheCall->getArg(i)); 1605d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman TheCall->setArg(i, 0); 1606d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1607d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 16083b6bef9a213249c6ab6d67c07b1ac6380961be3eBenjamin Kramer return Owned(new (Context) ShuffleVectorExpr(Context, exprs, resType, 16098189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getCallee()->getLocStart(), 16108189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getRParenLoc())); 1611d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman} 161230ce344307f8a8b00054021307015571f83c7364Chris Lattner 16134493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 16144493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two 16154493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args. 16164493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 1617fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner unsigned NumArgs = TheCall->getNumArgs(); 16184493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1619fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (NumArgs > 3) 1620ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher return Diag(TheCall->getLocEnd(), 1621ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher diag::err_typecheck_call_too_many_args_at_most) 1622ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 3 << NumArgs 1623ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << TheCall->getSourceRange(); 16244493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 16254493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // Argument 0 is checked for us and the remaining arguments must be 16264493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // constant integers. 1627fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner for (unsigned i = 1; i != NumArgs; ++i) { 16284493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar Expr *Arg = TheCall->getArg(i); 1629592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1630592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 1631592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (Arg->isTypeDependent() || Arg->isValueDependent()) 1632592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor continue; 1633592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 16349aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman llvm::APSInt Result; 1635691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, i, Result)) 1636691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 16371eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 16384493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // FIXME: gcc issues a warning and rewrites these to 0. These 16394493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // seems especially odd for the third argument since the default 16404493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // is 3. 1641fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (i == 1) { 16429aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 1) 1643fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 164421fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "1" << Arg->getSourceRange(); 16454493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } else { 16469aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 3) 1647fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 164821fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "3" << Arg->getSourceRange(); 16494493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 16504493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 16514493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1652fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return false; 16534493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar} 16544493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1655691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 1656691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression. 1657691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 1658691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt &Result) { 1659691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(ArgNum); 1660691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 1661691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 1662691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1663691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 1664691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1665691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (!Arg->isIntegerConstantExpr(Result, Context)) 1666691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 16675e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher << FDecl->getDeclName() << Arg->getSourceRange(); 1668691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 166921fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner return false; 167021fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner} 167121fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner 1672d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 1673d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined 1674d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3). 1675fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner// For compatibility check 0-3, llvm only handles 0 and 2. 1676d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 1677691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1678592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1679592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 1680592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (TheCall->getArg(1)->isTypeDependent() || 1681592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor TheCall->getArg(1)->isValueDependent()) 1682592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor return false; 1683592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1684691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // Check constant-ness first. 1685691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1686691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1687d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1688691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(1); 1689d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 1690fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 1691fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1692d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar } 1693d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1694d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar return false; 1695d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar} 1696d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1697586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 1698d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1. 1699d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 1700d875fed28578835de89cd407e9db4be788596d7cEli Friedman Expr *Arg = TheCall->getArg(1); 1701691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1702cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 1703691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // TODO: This is less than ideal. Overload this to take a value. 1704691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1705691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1706691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1707691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Result != 1) 1708d875fed28578835de89cd407e9db4be788596d7cEli Friedman return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 1709d875fed28578835de89cd407e9db4be788596d7cEli Friedman << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1710d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1711d875fed28578835de89cd407e9db4be788596d7cEli Friedman return false; 1712d875fed28578835de89cd407e9db4be788596d7cEli Friedman} 1713d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1714831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determine if an expression is a string literal or constant string. 1715831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// If this function returns false on the arguments to a function expecting a 1716831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// format string, we will usually need to emit a warning. 1717831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// True string literals are then checked by CheckFormatString. 1718831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithSema::StringLiteralCheckType 17191c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri GribenkoSema::checkFormatStringExpr(const Expr *E, ArrayRef<const Expr *> Args, 17201c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko bool HasVAListArg, 1721831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned format_idx, unsigned firstDataArg, 1722ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose FormatStringType Type, VariadicCallType CallType, 1723ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose bool inFunctionCall) { 17244fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain: 1725cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 1726831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1727d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 172834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas E = E->IgnoreParenCasts(); 1729f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 1730a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie if (E->isNullPointerConstant(Context, Expr::NPC_ValueDependentIsNotNull)) 1731a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // Technically -Wformat-nonliteral does not warn about this case. 1732a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // The behavior of printf and friends in this case is implementation 1733a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // dependent. Ideally if the format string cannot be null then 1734a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // it should have a 'nonnull' attribute in the function prototype. 1735831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_CheckedLiteral; 1736a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie 1737d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek switch (E->getStmtClass()) { 173856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::BinaryConditionalOperatorClass: 1739d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ConditionalOperatorClass: { 1740831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // The expression is a literal if both sub-expressions were, and it was 1741831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // completely checked only if both sub-expressions were checked. 1742831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const AbstractConditionalOperator *C = 1743831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith cast<AbstractConditionalOperator>(E); 1744831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType Left = 17451c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkFormatStringExpr(C->getTrueExpr(), Args, 1746831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1747ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 1748831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (Left == SLCT_NotALiteral) 1749831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1750831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType Right = 17511c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkFormatStringExpr(C->getFalseExpr(), Args, 1752831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1753ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 1754831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Left < Right ? Left : Right; 1755d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1756d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1757d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ImplicitCastExprClass: { 17584fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ImplicitCastExpr>(E)->getSubExpr(); 17594fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 1760d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1761d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 176256ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::OpaqueValueExprClass: 176356ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) { 176456ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall E = src; 176556ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall goto tryAgain; 176656ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall } 1767831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 176856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall 1769b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek case Stmt::PredefinedExprClass: 1770b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // While __func__, etc., are technically not string literals, they 1771b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // cannot contain format specifiers and thus are not a security 1772b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // liability. 1773831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_UncheckedLiteral; 1774b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek 1775082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::DeclRefExprClass: { 1776082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const DeclRefExpr *DR = cast<DeclRefExpr>(E); 17771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1778082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // As an exception, do not flag errors for variables binding to 1779082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // const string literals. 1780082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 1781082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool isConstant = false; 1782082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek QualType T = DR->getType(); 1783082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek 1784082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ArrayType *AT = Context.getAsArrayType(T)) { 1785082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek isConstant = AT->getElementType().isConstant(Context); 1786ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (const PointerType *PT = T->getAs<PointerType>()) { 17871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump isConstant = T.isConstant(Context) && 1788082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek PT->getPointeeType().isConstant(Context); 1789e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas } else if (T->isObjCObjectPointerType()) { 1790e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas // In ObjC, there is usually no "const ObjectPointer" type, 1791e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas // so don't check if the pointee type is constant. 1792e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas isConstant = T.isConstant(Context); 1793082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 17941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1795082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (isConstant) { 1796e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (const Expr *Init = VD->getAnyInitializer()) { 1797e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay // Look through initializers like const char c[] = { "foo" } 1798e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (const InitListExpr *InitList = dyn_cast<InitListExpr>(Init)) { 1799e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (InitList->isStringLiteralInit()) 1800e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay Init = InitList->getInit(0)->IgnoreParenImpCasts(); 1801e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay } 18021c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return checkFormatStringExpr(Init, Args, 1803831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, 1804ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, CallType, 1805831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*inFunctionCall*/false); 1806e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay } 1807082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 18081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1809d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // For vprintf* functions (i.e., HasVAListArg==true), we add a 1810d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // special check to see if the format string is a function parameter 1811d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // of the function calling the printf function. If the function 1812d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // has an attribute indicating it is a printf-like function, then we 1813d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // should suppress warnings concerning non-literals being used in a call 1814d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // to a vprintf function. For example: 1815d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1816d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // void 1817d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 1818d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_list ap; 1819d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_start(ap, fmt); 1820d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 1821d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // ... 1822d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1823f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (HasVAListArg) { 1824f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(VD)) { 1825f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const NamedDecl *ND = dyn_cast<NamedDecl>(PV->getDeclContext())) { 1826f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas int PVIndex = PV->getFunctionScopeIndex() + 1; 1827f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas for (specific_attr_iterator<FormatAttr> 1828f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas i = ND->specific_attr_begin<FormatAttr>(), 1829f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas e = ND->specific_attr_end<FormatAttr>(); i != e ; ++i) { 1830f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas FormatAttr *PVFormat = *i; 1831f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // adjust for implicit parameter 1832f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 1833f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (MD->isInstance()) 1834f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas ++PVIndex; 1835f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // We also check if the formats are compatible. 1836f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // We can't pass a 'scanf' string to a 'printf' function. 1837f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (PVIndex == PVFormat->getFormatIdx() && 1838f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas Type == GetFormatStringType(PVFormat)) 1839831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_UncheckedLiteral; 1840f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1841f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1842f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1843f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1844082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 18451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1846831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1847082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 1848d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 184952aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas case Stmt::CallExprClass: 185052aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas case Stmt::CXXMemberCallExprClass: { 18518f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const CallExpr *CE = cast<CallExpr>(E); 185252aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const NamedDecl *ND = dyn_cast_or_null<NamedDecl>(CE->getCalleeDecl())) { 185352aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) { 185452aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas unsigned ArgIndex = FA->getFormatIdx(); 185552aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 185652aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (MD->isInstance()) 185752aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas --ArgIndex; 185852aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas const Expr *Arg = CE->getArg(ArgIndex - 1); 185952aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas 18601c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return checkFormatStringExpr(Arg, Args, 1861831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1862ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 186350687314f87b67073c202fe46d84d12fb55e25cfJordan Rose } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(ND)) { 186450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned BuiltinID = FD->getBuiltinID(); 186550687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (BuiltinID == Builtin::BI__builtin___CFStringMakeConstantString || 186650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose BuiltinID == Builtin::BI__builtin___NSStringMakeConstantString) { 186750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose const Expr *Arg = CE->getArg(0); 18681c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return checkFormatStringExpr(Arg, Args, 1869831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, 1870ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, CallType, 1871ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall); 187250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose } 18738f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 18748f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 18751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1876831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 18778f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 1878082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::ObjCStringLiteralClass: 1879082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::StringLiteralClass: { 1880082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const StringLiteral *StrE = NULL; 18811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1882082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 1883d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek StrE = ObjCFExpr->getString(); 1884d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek else 1885082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek StrE = cast<StringLiteral>(E); 18861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1887d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek if (StrE) { 18881c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko CheckFormatString(StrE, E, Args, HasVAListArg, format_idx, 1889ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, inFunctionCall, CallType); 1890831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_CheckedLiteral; 1891d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 18921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1893831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1894d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 18951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1896082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek default: 1897831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1898d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1899d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1900d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1901e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid 19021eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull, 1903909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr * const *ExprArgs, 1904909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky SourceLocation CallSiteLoc) { 1905cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt for (NonNullAttr::args_iterator i = NonNull->args_begin(), 1906cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt e = NonNull->args_end(); 1907e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian i != e; ++i) { 1908909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr *ArgExpr = ExprArgs[*i]; 19093edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky 19103edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky // As a special case, transparent unions initialized with zero are 19113edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky // considered null for the purposes of the nonnull attribute. 19123edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (const RecordType *UT = ArgExpr->getType()->getAsUnionType()) { 19133edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (UT->getDecl()->hasAttr<TransparentUnionAttr>()) 19143edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (const CompoundLiteralExpr *CLE = 19153edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky dyn_cast<CompoundLiteralExpr>(ArgExpr)) 19163edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (const InitListExpr *ILE = 19173edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky dyn_cast<InitListExpr>(CLE->getInitializer())) 19183edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky ArgExpr = ILE->getInit(0); 19193edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky } 19203edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky 19213edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky bool Result; 19223edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (ArgExpr->EvaluateAsBooleanCondition(Result, Context) && !Result) 1923909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange(); 1924e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian } 1925e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian} 1926d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 192734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel DupasSema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) { 192834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas return llvm::StringSwitch<FormatStringType>(Format->getType()) 192934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("scanf", FST_Scanf) 193034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("printf", "printf0", FST_Printf) 193134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("NSString", "CFString", FST_NSString) 193234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("strftime", FST_Strftime) 193334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("strfmon", FST_Strfmon) 193434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf) 193534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Default(FST_Unknown); 193634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas} 193734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas 1938ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose/// CheckFormatArguments - Check calls to printf and scanf (and similar 1939826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings. 1940831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true if a format string has been fully checked. 19411c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkobool Sema::CheckFormatArguments(const FormatAttr *Format, 19421c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 19431c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko bool IsCXXMember, 1944ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose VariadicCallType CallType, 194529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas SourceLocation Loc, SourceRange Range) { 1946831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FormatStringInfo FSI; 1947831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (getFormatStringInfo(Format, IsCXXMember, &FSI)) 19481c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return CheckFormatArguments(Args, FSI.HasVAListArg, FSI.FormatIdx, 1949831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI.FirstDataArg, GetFormatStringType(Format), 1950ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose CallType, Loc, Range); 1951831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 195229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 19534a2614e94672c47395abcde60518776fbebec589Sebastian Redl 19541c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkobool Sema::CheckFormatArguments(ArrayRef<const Expr *> Args, 195534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas bool HasVAListArg, unsigned format_idx, 195634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg, FormatStringType Type, 1957ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose VariadicCallType CallType, 195834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas SourceLocation Loc, SourceRange Range) { 1959826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // CHECK: printf/scanf-like function is called with no format string. 19601c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko if (format_idx >= Args.size()) { 196129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Loc, diag::warn_missing_format_string) << Range; 1962831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 196371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek } 19641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 196529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts(); 19661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 196759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner // CHECK: format string is not a string literal. 19681eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // 196971895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // Dynamically generated format strings are difficult to 197071895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // automatically vet at compile time. Requiring that format strings 197171895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // are string literals: (1) permits the checking of format strings by 197271895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // the compiler and thereby (2) can practically remove the source of 197371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // many format string exploits. 19747ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek 19751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // Format string can be either ObjC string (e.g. @"%d") or 19767ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // C string (e.g. "%d") 19771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // ObjC string uses the same format specifiers as C string, so we can use 19787ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // the same format string checking logic for both ObjC and C strings. 1979831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType CT = 19801c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkFormatStringExpr(OrigFormatExpr, Args, HasVAListArg, 1981ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose format_idx, firstDataArg, Type, CallType); 1982831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (CT != SLCT_NotALiteral) 1983831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // Literal format string found, check done! 1984831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return CT == SLCT_CheckedLiteral; 19851cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner 19862837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas // Strftime is particular as it always uses a single 'time' argument, 19872837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas // so it is safe to pass a non-literal string. 19882837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas if (Type == FST_Strftime) 1989831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 19902837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas 1991ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // Do not emit diag when the string param is a macro expansion and the 1992ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // format is either NSString or CFString. This is a hack to prevent 1993ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // diag when using the NSLocalizedString and CFCopyLocalizedString macros 1994ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // which are usually used in place of NS and CF string literals. 1995dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas if (Type == FST_NSString && 1996dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas SourceMgr.isInSystemMacro(Args[format_idx]->getLocStart())) 1997831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 1998ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas 1999655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // If there are no arguments specified, warn with -Wformat-security, otherwise 2000655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // warn only with -Wformat-nonliteral. 20012243e78a6580ead4d17b76c924cd4b630b50d6aeEli Friedman if (Args.size() == firstDataArg) 200229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Args[format_idx]->getLocStart(), 2003826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral_noargs) 2004655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 2005655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner else 200629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Args[format_idx]->getLocStart(), 2007826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral) 2008655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 2009831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 2010d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 2011d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 2012e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace { 2013826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler { 2014826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 2015e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Sema &S; 2016e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const StringLiteral *FExpr; 2017e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const Expr *OrigFormatExpr; 20186ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const unsigned FirstDataArg; 2019e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const unsigned NumDataArgs; 2020e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *Beg; // Start of format string. 20210d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const bool HasVAListArg; 20221c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args; 20230d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek unsigned FormatIdx; 20247f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek llvm::BitVector CoveredArgs; 2025efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool usesPositionalArgs; 2026efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool atFirstArg; 202755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool inFunctionCall; 2028ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType; 20294e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic: 2030826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 20316ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 203250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, const char *beg, bool hasVAListArg, 20331c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 2034ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 2035ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType callType) 2036e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 203750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose FirstDataArg(firstDataArg), NumDataArgs(numDataArgs), 203850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose Beg(beg), HasVAListArg(hasVAListArg), 20391c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Args(Args), FormatIdx(formatIdx), 204055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu usesPositionalArgs(false), atFirstArg(true), 2041ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall(inFunctionCall), CallType(callType) { 20427f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.resize(numDataArgs); 20437f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.reset(); 20447f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 20454e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 204607d161f38e708a91486bf1c031d525faebbb249dTed Kremenek void DoneProcessing(); 20474e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2048826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIncompleteSpecifier(const char *startSpecifier, 2049826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 205076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 2051bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose void HandleInvalidLengthModifier( 2052bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::FormatSpecifier &FS, 2053bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::ConversionSpecifier &CS, 20548be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const char *startSpecifier, unsigned specifierLen, unsigned DiagID); 2055bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 205676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg void HandleNonStandardLengthModifier( 20578be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const analyze_format_string::FormatSpecifier &FS, 205876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen); 205976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 206076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg void HandleNonStandardConversionSpecifier( 206176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 206276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen); 206376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 2064f85626453123f9691bcef13cff963f556e209c27Hans Wennborg virtual void HandlePosition(const char *startPos, unsigned posLen); 2065f85626453123f9691bcef13cff963f556e209c27Hans Wennborg 2066efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleInvalidPosition(const char *startSpecifier, 2067efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned specifierLen, 2068826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p); 2069efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2070efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 2071efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2072e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek void HandleNullChar(const char *nullCharacter); 20734e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 207455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 207555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu static void EmitFormatDiagnostic(Sema &S, bool inFunctionCall, 207655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 207755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 207855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation StringLoc, 207955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 20805543169296beeb183b9c9392debc774fcf493eebDmitri Gribenko ArrayRef<FixItHint> Fixit = None); 208155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2082826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 2083c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 2084c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 2085c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 2086c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, unsigned csLen); 208755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 208855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void HandlePositionalNonpositionalArgs(SourceLocation Loc, 208955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 209055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen); 2091c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2092f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek SourceRange getFormatStringRange(); 2093826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CharSourceRange getSpecifierRange(const char *startSpecifier, 2094826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2095e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek SourceLocation getLocationOfByte(const char *x); 20964e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 20970d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const Expr *getDataArg(unsigned i) const; 2098666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 2099666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 2100666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 2101666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, 2102666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek unsigned argIndex); 210355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 210455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 210555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc, 210655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 21075543169296beeb183b9c9392debc774fcf493eebDmitri Gribenko ArrayRef<FixItHint> Fixit = None); 210855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 210955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void CheckPositionalAndNonpositionalArgs( 211055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const analyze_format_string::FormatSpecifier *FS); 2111e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}; 2112e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2113e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2114826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() { 2115e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return OrigFormatExpr->getSourceRange(); 2116e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2117e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2118826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler:: 2119826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 212045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation Start = getLocationOfByte(startSpecifier); 212145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 212245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 212345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care // Advance the end SourceLocation by one due to half-open ranges. 2124a64ccefdf0ea4e03ec88805d71b0af74950c7472Argyrios Kyrtzidis End = End.getLocWithOffset(1); 212545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 212645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care return CharSourceRange::getCharRange(Start, End); 2127f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek} 2128f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek 2129826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 21304e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 2131e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2132e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2133826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 2134826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen){ 213555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier), 213655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startSpecifier), 213755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 213855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 2139808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek} 2140808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek 2141bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rosevoid CheckFormatHandler::HandleInvalidLengthModifier( 2142bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::FormatSpecifier &FS, 2143bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::ConversionSpecifier &CS, 21448be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const char *startSpecifier, unsigned specifierLen, unsigned DiagID) { 2145bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose using namespace analyze_format_string; 2146bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2147bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const LengthModifier &LM = FS.getLengthModifier(); 2148bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength()); 2149bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2150bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose // See if we know how to fix this length modifier. 2151dc84cd5efdd3430efb22546b4ac656aa0540b210David Blaikie Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier(); 2152bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (FixedLM) { 21538be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(), 2154bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getLocationOfByte(LM.getStart()), 2155bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose /*IsStringLocation*/true, 2156bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 2157bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2158bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier) 2159bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose << FixedLM->toString() 2160bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose << FixItHint::CreateReplacement(LMRange, FixedLM->toString()); 2161bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2162bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose } else { 21638be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose FixItHint Hint; 21648be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose if (DiagID == diag::warn_format_nonsensical_length) 21658be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose Hint = FixItHint::CreateRemoval(LMRange); 21668be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 21678be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(), 2168bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getLocationOfByte(LM.getStart()), 2169bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose /*IsStringLocation*/true, 2170bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getSpecifierRange(startSpecifier, specifierLen), 21718be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose Hint); 2172bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose } 2173bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose} 2174bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 217576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardLengthModifier( 21768be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const analyze_format_string::FormatSpecifier &FS, 217776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen) { 21788be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose using namespace analyze_format_string; 21798be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 21808be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const LengthModifier &LM = FS.getLengthModifier(); 21818be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength()); 21828be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 21838be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose // See if we know how to fix this length modifier. 2184dc84cd5efdd3430efb22546b4ac656aa0540b210David Blaikie Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier(); 21858be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose if (FixedLM) { 21868be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 21878be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << LM.toString() << 0, 21888be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getLocationOfByte(LM.getStart()), 21898be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose /*IsStringLocation*/true, 21908be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 21918be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 21928be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier) 21938be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << FixedLM->toString() 21948be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << FixItHint::CreateReplacement(LMRange, FixedLM->toString()); 21958be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 21968be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose } else { 21978be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 21988be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << LM.toString() << 0, 21998be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getLocationOfByte(LM.getStart()), 22008be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose /*IsStringLocation*/true, 22018be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 22028be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose } 220376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg} 220476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 220576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardConversionSpecifier( 220676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 220776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen) { 2208670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose using namespace analyze_format_string; 2209670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose 2210670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose // See if we know how to fix this conversion specifier. 2211dc84cd5efdd3430efb22546b4ac656aa0540b210David Blaikie Optional<ConversionSpecifier> FixedCS = CS.getStandardSpecifier(); 2212670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose if (FixedCS) { 2213670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 2214670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << CS.toString() << /*conversion specifier*/1, 2215670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getLocationOfByte(CS.getStart()), 2216670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose /*IsStringLocation*/true, 2217670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 2218670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose 2219670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose CharSourceRange CSRange = getSpecifierRange(CS.getStart(), CS.getLength()); 2220670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose S.Diag(getLocationOfByte(CS.getStart()), diag::note_format_fix_specifier) 2221670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << FixedCS->toString() 2222670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << FixItHint::CreateReplacement(CSRange, FixedCS->toString()); 2223670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose } else { 2224670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 2225670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << CS.toString() << /*conversion specifier*/1, 2226670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getLocationOfByte(CS.getStart()), 2227670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose /*IsStringLocation*/true, 2228670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 2229670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose } 223076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg} 223176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 2232f85626453123f9691bcef13cff963f556e209c27Hans Wennborgvoid CheckFormatHandler::HandlePosition(const char *startPos, 2233f85626453123f9691bcef13cff963f556e209c27Hans Wennborg unsigned posLen) { 2234f85626453123f9691bcef13cff963f556e209c27Hans Wennborg EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_positional_arg), 2235f85626453123f9691bcef13cff963f556e209c27Hans Wennborg getLocationOfByte(startPos), 2236f85626453123f9691bcef13cff963f556e209c27Hans Wennborg /*IsStringLocation*/true, 2237f85626453123f9691bcef13cff963f556e209c27Hans Wennborg getSpecifierRange(startPos, posLen)); 2238f85626453123f9691bcef13cff963f556e209c27Hans Wennborg} 2239f85626453123f9691bcef13cff963f556e209c27Hans Wennborg 2240efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid 2241826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 2242826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p) { 224355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier) 224455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (unsigned) p, 224555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), /*IsStringLocation*/true, 224655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 2247efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 2248efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2249826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos, 2250efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned posLen) { 225155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier), 225255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), 225355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 225455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 2255efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 2256efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2257826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 225850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (!isa<ObjCStringLiteral>(OrigFormatExpr)) { 22590c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek // The presence of a null character is likely an error. 226055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 226155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_format_string_contains_null_char), 226255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(nullCharacter), /*IsStringLocation*/true, 226355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getFormatStringRange()); 22640c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek } 2265826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2266826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 226748716663e421472cbd590af160a372bc490205e8Jordan Rose// Note that this may return NULL if there was an error parsing or building 226848716663e421472cbd590af160a372bc490205e8Jordan Rose// one of the argument expressions. 2269826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const { 227029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return Args[FirstDataArg + i]; 2271826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 22724e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2273826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() { 2274826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Does the number of data arguments exceed the number of 2275826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // format conversions in the format string? 2276826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!HasVAListArg) { 2277826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Find any arguments that weren't covered. 2278826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.flip(); 2279826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek signed notCoveredArg = CoveredArgs.find_first(); 2280826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (notCoveredArg >= 0) { 2281826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek assert((unsigned)notCoveredArg < NumDataArgs); 228248716663e421472cbd590af160a372bc490205e8Jordan Rose if (const Expr *E = getDataArg((unsigned) notCoveredArg)) { 228348716663e421472cbd590af160a372bc490205e8Jordan Rose SourceLocation Loc = E->getLocStart(); 228448716663e421472cbd590af160a372bc490205e8Jordan Rose if (!S.getSourceManager().isInSystemMacro(Loc)) { 228548716663e421472cbd590af160a372bc490205e8Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_printf_data_arg_not_used), 228648716663e421472cbd590af160a372bc490205e8Jordan Rose Loc, /*IsStringLocation*/false, 228748716663e421472cbd590af160a372bc490205e8Jordan Rose getFormatStringRange()); 228848716663e421472cbd590af160a372bc490205e8Jordan Rose } 2289c03f2df2a2b097bf2686bf32411d5022323988b2Bob Wilson } 2290826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2291826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2292826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2293826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2294c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool 2295c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 2296c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek SourceLocation Loc, 2297c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 2298c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 2299c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, 2300c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned csLen) { 2301c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2302c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool keepGoing = true; 2303c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek if (argIndex < NumDataArgs) { 2304c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // Consider the argument coverered, even though the specifier doesn't 2305c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // make sense. 2306c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CoveredArgs.set(argIndex); 2307c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 2308c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek else { 2309c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // If argIndex exceeds the number of data arguments we 2310c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // don't issue a warning because that is just a cascade of warnings (and 2311c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // they may have intended '%%' anyway). We don't want to continue processing 2312c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // the format string after this point, however, as we will like just get 2313c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // gibberish when trying to match arguments. 2314c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek keepGoing = false; 2315c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 2316c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 231755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_conversion) 231855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << StringRef(csStart, csLen), 231955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*IsStringLocation*/true, 232055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpec, specifierLen)); 2321c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2322c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return keepGoing; 2323c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 2324c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 232555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid 232655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard TrieuCheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc, 232755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 232855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen) { 232955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 233055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_format_mix_positional_nonpositional_args), 233155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen)); 233255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 233355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2334666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool 2335666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs( 2336666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::FormatSpecifier &FS, 2337666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 2338666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 2339666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 2340666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (argIndex >= NumDataArgs) { 234155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag = FS.usesPositionalArg() 234255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args) 234355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (argIndex+1) << NumDataArgs) 234455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : S.PDiag(diag::warn_printf_insufficient_data_args); 234555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 234655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true, 234755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 2348666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return false; 2349666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 2350666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return true; 2351666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek} 2352666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 235355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 235455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag, 235555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 235655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 235755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 2358ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose ArrayRef<FixItHint> FixIt) { 235929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag, 236055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, IsStringLocation, StringRange, FixIt); 236155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 236255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 236355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \brief If the format string is not within the funcion call, emit a note 236455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// so that the function call and string are in diagnostic messages. 236555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 236670517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param InFunctionCall if true, the format string is within the function 236755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// call and only one diagnostic message will be produced. Otherwise, an 236855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// extra note will be emitted pointing to location of the format string. 236955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 237055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param ArgumentExpr the expression that is passed as the format string 237155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// argument in the function call. Used for getting locations when two 237255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostics are emitted. 237355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 237455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param PDiag the callee should already have provided any strings for the 237555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostic message. This function only adds locations and fixits 237655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// to diagnostics. 237755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 237855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param Loc primary location for diagnostic. If two diagnostics are 237955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// required, one will be at Loc and a new SourceLocation will be created for 238055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// the other one. 238155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 238255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param IsStringLocation if true, Loc points to the format string should be 238355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// used for the note. Otherwise, Loc points to the argument list and will 238455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// be used with PDiag. 238555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 238655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param StringRange some or all of the string to highlight. This is 238755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// templated so it can accept either a CharSourceRange or a SourceRange. 238855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 238970517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param FixIt optional fix it hint for the format string. 239055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 239155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(Sema &S, bool InFunctionCall, 239255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 239355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 239455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 239555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 239655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 2397ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose ArrayRef<FixItHint> FixIt) { 2398ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (InFunctionCall) { 2399ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Sema::SemaDiagnosticBuilder &D = S.Diag(Loc, PDiag); 2400ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose D << StringRange; 2401ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end(); 2402ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose I != E; ++I) { 2403ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose D << *I; 2404ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2405ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else { 240655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag) 240755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ArgumentExpr->getSourceRange(); 2408ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2409ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Sema::SemaDiagnosticBuilder &Note = 2410ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose S.Diag(IsStringLocation ? Loc : StringRange.getBegin(), 2411ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose diag::note_format_string_defined); 2412ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2413ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Note << StringRange; 2414ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end(); 2415ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose I != E; ++I) { 2416ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Note << *I; 2417ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 241855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu } 241955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 242055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2421826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===// 2422826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2423826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 2424826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler { 242550687314f87b67073c202fe46d84d12fb55e25cfJordan Rose bool ObjCContext; 2426826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 2427826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 2428826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 242950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, bool isObjC, 2430826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 24311c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 2432ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 2433ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType) 2434826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 24351c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko numDataArgs, beg, hasVAListArg, Args, 2436ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose formatIdx, inFunctionCall, CallType), ObjCContext(isObjC) 2437ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose {} 2438ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose 2439826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2440826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleInvalidPrintfConversionSpecifier( 2441826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2442826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2443826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2444826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2445826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 2446826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2447826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2448831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool checkFormatExpr(const analyze_printf::PrintfSpecifier &FS, 2449831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const char *StartSpecifier, 2450831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned SpecifierLen, 2451831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E); 2452831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2453826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 2454826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2455826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 2456826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalAmount &Amt, 2457826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned type, 2458826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2459826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 2460826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 2461826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2462826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 2463826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &ignoredFlag, 2464826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 2465826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2466f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg bool checkForCStrMembers(const analyze_printf::ArgType &AT, 2467831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E, const CharSourceRange &CSR); 2468831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2469826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 2470826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2471826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2472826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 2473826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2474826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2475826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 24766ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 2477c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 2478826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2479c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 2480c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 2481c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 2482c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 248326ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek} 248426ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek 2485826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount( 2486826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_format_string::OptionalAmount &Amt, 2487826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned k, const char *startSpecifier, 2488826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 24890d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 24900d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (Amt.hasDataArgument()) { 24910d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (!HasVAListArg) { 24927f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = Amt.getArgIndex(); 24937f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (argIndex >= NumDataArgs) { 249455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg) 249555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << k, 249655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 249755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 249855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 24990d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 25000d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 25010d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 25020d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 25034e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 25040d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Type check the data argument. It should be an 'int'. 250531f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // Although not in conformance with C99, we also allow the argument to be 250631f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // an 'unsigned int' as that is a reasonably safe case. GCC also 250731f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // doesn't emit a warning for that case. 25087f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.set(argIndex); 25097f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek const Expr *Arg = getDataArg(argIndex); 251048716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Arg) 251148716663e421472cbd590af160a372bc490205e8Jordan Rose return false; 251248716663e421472cbd590af160a372bc490205e8Jordan Rose 25130d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek QualType T = Arg->getType(); 25144e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2515f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT = Amt.getArgType(S.Context); 2516f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg assert(AT.isValid()); 25174e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2518f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg if (!AT.matchesType(S.Context, T)) { 251955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type) 2520f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg << k << AT.getRepresentativeTypeName(S.Context) 252155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << T << Arg->getSourceRange(), 252255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 252355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 252455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 25250d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 25260d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 25270d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 25280d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 25290d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 25300d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 25310d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return true; 25320d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek} 25330d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 2534e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount( 2535826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2536e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalAmount &Amt, 2537e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned type, 2538e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2539e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 25406ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 25416ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 2542e4ee9663168dfb2b4122c768091e30217328c9faTom Care 254355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint fixit = 254455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant 254555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 254655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getConstantLength())) 254755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : FixItHint(); 254855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 254955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount) 255055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << type << CS.toString(), 255155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 255255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 255355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 255455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu fixit); 2555e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2556e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2557826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 2558e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 2559e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2560e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 2561e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about pointless flag with a fixit removal. 25626ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 25636ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 256455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag) 256555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << flag.toString() << CS.toString(), 256655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(flag.getPosition()), 256755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 256855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 256955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 257055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(flag.getPosition(), 1))); 2571e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2572e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2573e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag( 2574826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2575e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &ignoredFlag, 2576e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 2577e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2578e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 2579e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about ignored flag with a fixit removal. 258055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag) 258155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ignoredFlag.toString() << flag.toString(), 258255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(ignoredFlag.getPosition()), 258355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 258455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 258555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 258655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(ignoredFlag.getPosition(), 1))); 2587e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2588e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2589831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determines if the specified is a C++ class or struct containing 2590831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// a member with the specified name and kind (e.g. a CXXMethodDecl named 2591831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// "c_str()"). 2592831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithtemplate<typename MemberKind> 2593831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithstatic llvm::SmallPtrSet<MemberKind*, 1> 2594831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCXXRecordMembersNamed(StringRef Name, Sema &S, QualType Ty) { 2595831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const RecordType *RT = Ty->getAs<RecordType>(); 2596831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith llvm::SmallPtrSet<MemberKind*, 1> Results; 2597831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2598831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!RT) 2599831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2600831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl()); 2601831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!RD) 2602831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2603831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2604831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith LookupResult R(S, &S.PP.getIdentifierTable().get(Name), SourceLocation(), 2605831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Sema::LookupMemberName); 2606831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2607831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // We just need to include all members of the right kind turned up by the 2608831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // filter, at this point. 2609831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (S.LookupQualifiedName(R, RT->getDecl())) 2610831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith for (LookupResult::iterator I = R.begin(), E = R.end(); I != E; ++I) { 2611831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith NamedDecl *decl = (*I)->getUnderlyingDecl(); 2612831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (MemberKind *FK = dyn_cast<MemberKind>(decl)) 2613831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Results.insert(FK); 2614831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2615831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2616831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2617831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2618831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Check if a (w)string was passed when a (w)char* was needed, and offer a 2619f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg// better diagnostic if so. AT is assumed to be valid. 2620831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Returns true when a c_str() conversion method is found. 2621831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool CheckPrintfHandler::checkForCStrMembers( 2622f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT, const Expr *E, 2623831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CharSourceRange &CSR) { 2624831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith typedef llvm::SmallPtrSet<CXXMethodDecl*, 1> MethodSet; 2625831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2626831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith MethodSet Results = 2627831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith CXXRecordMembersNamed<CXXMethodDecl>("c_str", S, E->getType()); 2628831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2629831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith for (MethodSet::iterator MI = Results.begin(), ME = Results.end(); 2630831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith MI != ME; ++MI) { 2631831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CXXMethodDecl *Method = *MI; 2632831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (Method->getNumParams() == 0 && 2633f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg AT.matchesType(S.Context, Method->getResultType())) { 2634831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // FIXME: Suggest parens if the expression needs them. 2635831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation EndLoc = 2636831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()); 2637831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith S.Diag(E->getLocStart(), diag::note_printf_c_str) 2638831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << "c_str()" 2639831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << FixItHint::CreateInsertion(EndLoc, ".c_str()"); 2640831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return true; 2641831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2642831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2643831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2644831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 2645831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2646831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2647e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool 2648826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 26495c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek &FS, 2650e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *startSpecifier, 2651e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned specifierLen) { 2652e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 26536ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek using namespace analyze_format_string; 2654efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek using namespace analyze_printf; 26556ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 2656e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2657baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 2658baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 2659baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 2660baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 2661baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2662baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 266355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 266455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 2665baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 2666baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2667efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek } 2668efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 26690d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // First check if the field width, precision, and conversion specifier 26700d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // have matching data arguments. 2671efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 2672efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 26730d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 26740d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 26754e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2676efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 2677efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 26780d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 26790d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 26800d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 2681f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek if (!CS.consumesDataArgument()) { 2682f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // FIXME: Technically specifying a precision or field width here 2683f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // makes no sense. Worth issuing a warning at some point. 26840e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek return true; 2685f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek } 26864e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 26877f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Consume the argument. 26887f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = FS.getArgIndex(); 2689e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek if (argIndex < NumDataArgs) { 2690e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // The check to see if the argIndex is valid will come later. 2691e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // We set the bit here because we may exit early from this 2692e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // function if we encounter some other error. 2693e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek CoveredArgs.set(argIndex); 2694e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek } 26957f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek 26967f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Check for using an Objective-C specific conversion specifier 26977f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // in a non-ObjC literal. 269850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (!ObjCContext && CS.isObjCArg()) { 2699826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 2700826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek specifierLen); 27017f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 27024e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2703e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of field width 2704e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidFieldWidth()) { 270545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 2706e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2707e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2708e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2709e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of precision 2710e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPrecision()) { 2711e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 2712e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2713e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2714e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2715e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check each flag does not conflict with any other component. 271665197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek if (!FS.hasValidThousandsGroupingPrefix()) 271765197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen); 2718e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeadingZeros()) 2719e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 2720e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPlusPrefix()) 2721e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 272245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (!FS.hasValidSpacePrefix()) 272345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 2724e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidAlternativeForm()) 2725e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 2726e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeftJustified()) 2727e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 2728e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2729e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check that flags are not ignored by another flag 273045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 273145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 273245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care startSpecifier, specifierLen); 2733e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 2734e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 2735e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2736e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2737e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check the length modifier is valid with the given conversion specifier. 2738bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo())) 27398be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 27408be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_nonsensical_length); 2741bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthModifier()) 27428be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen); 2743bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthConversionCombination()) 27448be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 27458be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_non_standard_conversion_spec); 2746e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2747bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 2748bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 2749bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2750da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek // The remaining checks depend on the data arguments. 2751da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek if (HasVAListArg) 2752da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return true; 27534e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2754666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 2755da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return false; 27564e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 275748716663e421472cbd590af160a372bc490205e8Jordan Rose const Expr *Arg = getDataArg(argIndex); 275848716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Arg) 275948716663e421472cbd590af160a372bc490205e8Jordan Rose return true; 276048716663e421472cbd590af160a372bc490205e8Jordan Rose 276148716663e421472cbd590af160a372bc490205e8Jordan Rose return checkFormatExpr(FS, startSpecifier, specifierLen, Arg); 2762831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2763831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2764ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rosestatic bool requiresParensToAddCast(const Expr *E) { 2765ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // FIXME: We should have a general way to reason about operator 2766ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // precedence and whether parens are actually needed here. 2767ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Take care of a few common cases where they aren't. 2768ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Expr *Inside = E->IgnoreImpCasts(); 2769ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (const PseudoObjectExpr *POE = dyn_cast<PseudoObjectExpr>(Inside)) 2770ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Inside = POE->getSyntacticForm()->IgnoreImpCasts(); 2771ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2772ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose switch (Inside->getStmtClass()) { 2773ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ArraySubscriptExprClass: 2774ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::CallExprClass: 277517ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::CharacterLiteralClass: 277617ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::CXXBoolLiteralExprClass: 2777ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::DeclRefExprClass: 277817ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::FloatingLiteralClass: 277917ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::IntegerLiteralClass: 2780ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::MemberExprClass: 278117ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCArrayLiteralClass: 278217ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCBoolLiteralExprClass: 278317ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCBoxedExprClass: 278417ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCDictionaryLiteralClass: 278517ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCEncodeExprClass: 2786ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCIvarRefExprClass: 2787ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCMessageExprClass: 2788ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCPropertyRefExprClass: 278917ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCStringLiteralClass: 279017ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCSubscriptRefExprClass: 2791ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ParenExprClass: 279217ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::StringLiteralClass: 2793ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::UnaryOperatorClass: 2794ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose return false; 2795ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose default: 2796ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose return true; 2797ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2798ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose} 2799ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2800831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool 2801831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCheckPrintfHandler::checkFormatExpr(const analyze_printf::PrintfSpecifier &FS, 2802831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const char *StartSpecifier, 2803831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned SpecifierLen, 2804831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E) { 2805831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith using namespace analyze_format_string; 2806831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith using namespace analyze_printf; 280796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Now type check the data expression that matches the 280896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // format specifier. 2809f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT = FS.getArgType(S.Context, 2810f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg ObjCContext); 2811614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (!AT.isValid()) 2812614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 2813ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2814448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose QualType ExprTy = E->getType(); 281502be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek while (const TypeOfExprType *TET = dyn_cast<TypeOfExprType>(ExprTy)) { 281602be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek ExprTy = TET->getUnderlyingExpr()->getType(); 281702be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek } 281802be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek 2819448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (AT.matchesType(S.Context, ExprTy)) 2820614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 2821614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 2822614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Look through argument promotions for our error message's reported type. 2823614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // This includes the integral and floating promotions, but excludes array 2824614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // and function pointer decay; seeing that an argument intended to be a 2825614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // string has type 'char [6]' is probably more confusing than 'char *'. 2826614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 2827614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (ICE->getCastKind() == CK_IntegralCast || 2828614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose ICE->getCastKind() == CK_FloatingCast) { 2829614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E = ICE->getSubExpr(); 2830448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose ExprTy = E->getType(); 2831614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 2832614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Check if we didn't match because of an implicit cast from a 'char' 2833614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // or 'short' to an 'int'. This is done because printf is a varargs 2834614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // function. 2835614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (ICE->getType() == S.Context.IntTy || 2836614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose ICE->getType() == S.Context.UnsignedIntTy) { 2837614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // All further checking is done on the subexpression. 2838448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (AT.matchesType(S.Context, ExprTy)) 2839614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 28404d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek } 2841ee0259d308e72141982a85b40863e760a8447edfJordan Rose } 2842448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose } else if (const CharacterLiteral *CL = dyn_cast<CharacterLiteral>(E)) { 2843448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose // Special case for 'a', which has type 'int' in C. 2844448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose // Note, however, that we do /not/ want to treat multibyte constants like 2845448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose // 'MooV' as characters! This form is deprecated but still exists. 2846448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (ExprTy == S.Context.IntTy) 2847448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (llvm::isUIntN(S.Context.getCharWidth(), CL->getValue())) 2848448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose ExprTy = S.Context.CharTy; 2849614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } 2850614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 28512cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // %C in an Objective-C context prints a unichar, not a wchar_t. 28522cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // If the argument is an integer of some kind, believe the %C and suggest 28532cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // a cast instead of changing the conversion specifier. 2854448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose QualType IntendedTy = ExprTy; 28552cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (ObjCContext && 28562cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose FS.getConversionSpecifier().getKind() == ConversionSpecifier::CArg) { 28572cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (ExprTy->isIntegralOrUnscopedEnumerationType() && 28582cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose !ExprTy->isCharType()) { 28592cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // 'unichar' is defined as a typedef of unsigned short, but we should 28602cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // prefer using the typedef if it is visible. 28612cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose IntendedTy = S.Context.UnsignedShortTy; 28622cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 28632cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose LookupResult Result(S, &S.Context.Idents.get("unichar"), E->getLocStart(), 28642cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose Sema::LookupOrdinaryName); 28652cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (S.LookupName(Result, S.getCurScope())) { 28662cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose NamedDecl *ND = Result.getFoundDecl(); 28672cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (TypedefNameDecl *TD = dyn_cast<TypedefNameDecl>(ND)) 28682cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (TD->getUnderlyingType() == IntendedTy) 28692cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose IntendedTy = S.Context.getTypedefType(TD); 28702cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 28712cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 28722cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 28732cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 28742cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // Special-case some of Darwin's platform-independence types by suggesting 28752cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // casts to primitive types that are known to be large enough. 28762cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose bool ShouldNotPrintDirectly = false; 2877ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (S.Context.getTargetInfo().getTriple().isOSDarwin()) { 28786edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek // Use a 'while' to peel off layers of typedefs. 28796edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek QualType TyTy = IntendedTy; 28806edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek while (const TypedefType *UserTy = TyTy->getAs<TypedefType>()) { 2881ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose StringRef Name = UserTy->getDecl()->getName(); 28822cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose QualType CastTy = llvm::StringSwitch<QualType>(Name) 2883ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("NSInteger", S.Context.LongTy) 2884ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("NSUInteger", S.Context.UnsignedLongTy) 2885ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("SInt32", S.Context.IntTy) 2886ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("UInt32", S.Context.UnsignedIntTy) 28872cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose .Default(QualType()); 28882cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 28892cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (!CastTy.isNull()) { 28902cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose ShouldNotPrintDirectly = true; 28912cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose IntendedTy = CastTy; 28926edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek break; 28932cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 28946edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek TyTy = UserTy->desugar(); 2895ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2896ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2897ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2898614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // We may be able to offer a FixItHint if it is a supported type. 2899614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose PrintfSpecifier fixedFS = FS; 2900ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose bool success = fixedFS.fixType(IntendedTy, S.getLangOpts(), 2901614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose S.Context, ObjCContext); 290296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2903614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (success) { 2904614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Get the fix string from the fixed format specifier 2905614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose SmallString<16> buf; 2906614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose llvm::raw_svector_ostream os(buf); 2907614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose fixedFS.toString(os); 2908614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 2909ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CharSourceRange SpecRange = getSpecifierRange(StartSpecifier, SpecifierLen); 2910ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 29112cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (IntendedTy == ExprTy) { 29122cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // In this case, the specifier is wrong and should be changed to match 29132cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // the argument. 29142cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose EmitFormatDiagnostic( 29152cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 29162cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << AT.getRepresentativeTypeName(S.Context) << IntendedTy 29172cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << E->getSourceRange(), 29182cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose E->getLocStart(), 29192cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose /*IsStringLocation*/false, 29202cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose SpecRange, 29212cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose FixItHint::CreateReplacement(SpecRange, os.str())); 29222cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 29232cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } else { 2924ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // The canonical type for formatting this value is different from the 2925ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // actual type of the expression. (This occurs, for example, with Darwin's 2926ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // NSInteger on 32-bit platforms, where it is typedef'd as 'int', but 2927ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // should be printed as 'long' for 64-bit compatibility.) 2928ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Rather than emitting a normal format/argument mismatch, we want to 2929ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // add a cast to the recommended type (and correct the format string 2930ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // if necessary). 2931ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SmallString<16> CastBuf; 2932ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose llvm::raw_svector_ostream CastFix(CastBuf); 2933ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << "("; 2934ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose IntendedTy.print(CastFix, S.Context.getPrintingPolicy()); 2935ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << ")"; 2936ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2937ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SmallVector<FixItHint,4> Hints; 2938ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (!AT.matchesType(S.Context, IntendedTy)) 2939ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateReplacement(SpecRange, os.str())); 2940ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2941ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (const CStyleCastExpr *CCast = dyn_cast<CStyleCastExpr>(E)) { 2942ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // If there's already a cast present, just replace it. 2943ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SourceRange CastRange(CCast->getLParenLoc(), CCast->getRParenLoc()); 2944ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateReplacement(CastRange, CastFix.str())); 2945ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2946ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else if (!requiresParensToAddCast(E)) { 2947ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // If the expression has high enough precedence, 2948ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // just write the C-style cast. 2949ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(), 2950ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix.str())); 2951ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else { 2952ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Otherwise, add parens around the expression as well as the cast. 2953ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << "("; 2954ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(), 2955ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix.str())); 2956ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2957ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SourceLocation After = S.PP.getLocForEndOfToken(E->getLocEnd()); 2958ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(After, ")")); 2959ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2960ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 29612cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (ShouldNotPrintDirectly) { 29622cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // The expression has a type that should not be printed directly. 29632cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // We extract the name from the typedef because we don't want to show 29642cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // the underlying type in the diagnostic. 29652cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose StringRef Name = cast<TypedefType>(ExprTy)->getDecl()->getName(); 29662cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 29672cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_argument_needs_cast) 29682cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << Name << IntendedTy 29692cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << E->getSourceRange(), 29702cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose E->getLocStart(), /*IsStringLocation=*/false, 29712cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose SpecRange, Hints); 29722cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } else { 29732cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // In this case, the expression could be printed using a different 29742cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // specifier, but we've decided that the specifier is probably correct 29752cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // and we should cast instead. Just use the normal warning message. 29762cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose EmitFormatDiagnostic( 29772cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 29782cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << AT.getRepresentativeTypeName(S.Context) << ExprTy 29792cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << E->getSourceRange(), 29802cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose E->getLocStart(), /*IsStringLocation*/false, 29812cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose SpecRange, Hints); 29822cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 2983ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2984614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } else { 2985614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose const CharSourceRange &CSR = getSpecifierRange(StartSpecifier, 2986614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose SpecifierLen); 2987614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Since the warning for passing non-POD types to variadic functions 2988614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // was deferred until now, we emit a warning for non-POD 2989614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // arguments here. 2990448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (S.isValidVarArgType(ExprTy) == Sema::VAK_Invalid) { 2991614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose unsigned DiagKind; 2992448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (ExprTy->isObjCObjectType()) 2993614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose DiagKind = diag::err_cannot_pass_objc_interface_to_vararg_format; 2994614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose else 2995614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose DiagKind = diag::warn_non_pod_vararg_with_format_string; 299696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2997614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose EmitFormatDiagnostic( 2998614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose S.PDiag(DiagKind) 299980ad52f327b532bded5c5b0ee38779d841c6cd35Richard Smith << S.getLangOpts().CPlusPlus11 3000448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose << ExprTy 3001614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CallType 3002614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << AT.getRepresentativeTypeName(S.Context) 3003614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CSR 3004614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << E->getSourceRange(), 3005614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E->getLocStart(), /*IsStringLocation*/false, CSR); 300696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 3007614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose checkForCStrMembers(AT, E, CSR); 3008614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } else 300955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 301055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 3011448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose << AT.getRepresentativeTypeName(S.Context) << ExprTy 3012614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CSR 3013831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << E->getSourceRange(), 3014614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E->getLocStart(), /*IsStringLocation*/false, CSR); 301596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 301696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 3017e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return true; 3018e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 3019e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 3020826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===// 3021826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3022826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 3023826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler { 3024826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 3025826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 3026826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 302750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, const char *beg, bool hasVAListArg, 30281c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 3029ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 3030ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType) 3031826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 303250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose numDataArgs, beg, hasVAListArg, 30331c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Args, formatIdx, inFunctionCall, CallType) 3034ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose {} 3035826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3036826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 3037826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 3038826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 3039c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 3040c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidScanfConversionSpecifier( 3041c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 3042c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 3043c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen); 3044b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 3045b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek void HandleIncompleteScanList(const char *start, const char *end); 3046826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 3047826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 3048826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3049b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start, 3050b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek const char *end) { 305155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete), 305255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(end), /*IsStringLocation*/true, 305355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(start, end - start)); 3054b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek} 3055b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 3056c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 3057c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 3058c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 3059c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen) { 3060c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 30616ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_scanf::ScanfConversionSpecifier &CS = 3062c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 3063c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 3064c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 3065c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 3066c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 3067c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 3068c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 3069c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 3070826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier( 3071826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 3072826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 3073826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 3074826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3075826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_scanf; 3076826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_format_string; 3077826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 30786ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 3079826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3080baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Handle case where '%' and '*' don't consume an argument. These shouldn't 3081baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // be used to decide if we are using positional arguments consistently. 3082baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 3083baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 3084baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 3085baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 3086baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 3087baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 308855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 308955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 3090baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 3091baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 3092826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 3093826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3094826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Check if the field with is non-zero. 3095826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const OptionalAmount &Amt = FS.getFieldWidth(); 3096826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getHowSpecified() == OptionalAmount::Constant) { 3097826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getConstantAmount() == 0) { 3098826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 3099826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Amt.getConstantLength()); 310055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width), 310155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 310255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, R, 310355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval(R)); 31047f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 31057f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 3106826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3107826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!FS.consumesDataArgument()) { 3108826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Technically specifying a precision or field width here 3109826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // makes no sense. Worth issuing a warning at some point. 3110826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 3111826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 3112826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3113826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Consume the argument. 3114826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned argIndex = FS.getArgIndex(); 3115826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (argIndex < NumDataArgs) { 3116826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The check to see if the argIndex is valid will come later. 3117826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // We set the bit here because we may exit early from this 3118826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // function if we encounter some other error. 3119826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.set(argIndex); 3120826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 3121826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 31221e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek // Check the length modifier is valid with the given conversion specifier. 3123bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo())) 31248be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 31258be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_nonsensical_length); 3126bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthModifier()) 31278be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen); 3128bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthConversionCombination()) 31298be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 31308be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_non_standard_conversion_spec); 313176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 3132bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 3133bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 3134bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 3135826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The remaining checks depend on the data arguments. 3136826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (HasVAListArg) 3137826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 3138826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3139666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 3140826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return false; 3141826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 31426fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Check that the argument type matches the format specifier. 31436fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg const Expr *Ex = getDataArg(argIndex); 314448716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Ex) 314548716663e421472cbd590af160a372bc490205e8Jordan Rose return true; 314648716663e421472cbd590af160a372bc490205e8Jordan Rose 314758e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg const analyze_format_string::ArgType &AT = FS.getArgType(S.Context); 314858e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg if (AT.isValid() && !AT.matchesType(S.Context, Ex->getType())) { 31496fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg ScanfSpecifier fixedFS = FS; 31504e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie bool success = fixedFS.fixType(Ex->getType(), S.getLangOpts(), 3151be6126a2a784e1446460b8d15c2b26f880c871fcHans Wennborg S.Context); 31526fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 31536fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg if (success) { 31546fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Get the fix string from the fixed format specifier. 3155f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> buf; 31566fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg llvm::raw_svector_ostream os(buf); 31576fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg fixedFS.toString(os); 31586fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 31596fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg EmitFormatDiagnostic( 31606fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 316158e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg << AT.getRepresentativeTypeName(S.Context) << Ex->getType() 31626fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg << Ex->getSourceRange(), 3163abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay Ex->getLocStart(), 3164abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay /*IsStringLocation*/false, 31656fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 31666fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg FixItHint::CreateReplacement( 31676fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 31686fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg os.str())); 31696fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } else { 3170220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas EmitFormatDiagnostic( 3171220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 317258e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg << AT.getRepresentativeTypeName(S.Context) << Ex->getType() 3173220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << Ex->getSourceRange(), 3174abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay Ex->getLocStart(), 3175abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay /*IsStringLocation*/false, 3176220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas getSpecifierRange(startSpecifier, specifierLen)); 31776fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 31786fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 31796fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 3180826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 318107d161f38e708a91486bf1c031d525faebbb249dTed Kremenek} 3182e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 3183826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr, 31840e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const Expr *OrigFormatExpr, 31851c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 318629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas bool HasVAListArg, unsigned format_idx, 318734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg, FormatStringType Type, 3188ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose bool inFunctionCall, VariadicCallType CallType) { 3189826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3190e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: is the format string a wide literal? 3191df9ef1bc8c3780307ab2ed81bf5e31c23310b936Richard Smith if (!FExpr->isAscii() && !FExpr->isUTF8()) { 319255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 319329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas *this, inFunctionCall, Args[format_idx], 319455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(), 319555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 3196e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 3197e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 3198826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3199e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // Str - The format string. NOTE: this is NOT null-terminated! 32005f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef StrRef = FExpr->getString(); 32012f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer const char *Str = StrRef.data(); 32022f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer unsigned StrLen = StrRef.size(); 32031c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko const unsigned numDataArgs = Args.size() - firstDataArg; 3204826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3205e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: empty format string? 32064cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek if (StrLen == 0 && numDataArgs > 0) { 320755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 320829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas *this, inFunctionCall, Args[format_idx], 320955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_empty_format_string), FExpr->getLocStart(), 321055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 3211e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 3212e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 3213826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 321434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas if (Type == FST_Printf || Type == FST_NSString) { 3215826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 321650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose numDataArgs, (Type == FST_NSString), 32171c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Str, HasVAListArg, Args, format_idx, 3218ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall, CallType); 3219826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3220d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen, 3221275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose getLangOpts(), 3222275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose Context.getTargetInfo())) 3223826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 322434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } else if (Type == FST_Scanf) { 322550687314f87b67073c202fe46d84d12fb55e25cfJordan Rose CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, numDataArgs, 32261c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Str, HasVAListArg, Args, format_idx, 3227ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall, CallType); 3228826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3229d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen, 3230275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose getLangOpts(), 3231275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose Context.getTargetInfo())) 3232826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 323334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } // TODO: handle other formats 3234ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek} 3235ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek 32367ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth//===--- CHECK: Standard memory functions ---------------------------------===// 32377ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 32382a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// \brief Determine whether the given type is a dynamic class type (e.g., 32392a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// whether it has a vtable). 32402a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregorstatic bool isDynamicClassType(QualType T) { 32412a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Record = T->getAsCXXRecordDecl()) 32422a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Definition = Record->getDefinition()) 32432a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (Definition->isDynamicClass()) 32442a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return true; 32452a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 32462a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return false; 32472a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor} 32482a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 3249a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument expression, 3250000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth/// otherwise returns NULL. 3251000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic const Expr *getSizeOfExprArg(const Expr* E) { 3252e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber if (const UnaryExprOrTypeTraitExpr *SizeOf = 3253000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 3254000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType()) 3255000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getArgumentExpr()->IgnoreParenImpCasts(); 3256e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 3257000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return 0; 3258000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth} 3259000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3260a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument type. 3261000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic QualType getSizeOfArgType(const Expr* E) { 3262000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryExprOrTypeTraitExpr *SizeOf = 3263000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 3264000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf) 3265000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getTypeOfArgument(); 3266000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3267000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return QualType(); 3268e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber} 3269e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 32707ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \brief Check for dangerous or invalid arguments to memset(). 32717ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 3272929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth/// This issues warnings on known problematic, dangerous or unspecified 3273cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp' 3274cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// function calls. 32757ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 32767ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \param Call The call expression to diagnose. 3277cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gayvoid Sema::CheckMemaccessArguments(const CallExpr *Call, 32780a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned BId, 3279cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay IdentifierInfo *FnName) { 32800a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks assert(BId != 0); 32810a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 32821d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek // It is possible to have a non-standard definition of memset. Validate 3283707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor // we have enough arguments, and if not, abort further checking. 32840a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned ExpectedNumArgs = (BId == Builtin::BIstrndup ? 2 : 3); 3285cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber if (Call->getNumArgs() < ExpectedNumArgs) 32861d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek return; 32871d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek 32880a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LastArg = (BId == Builtin::BImemset || 32890a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId == Builtin::BIstrndup ? 1 : 2); 32900a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LenArg = (BId == Builtin::BIstrndup ? 1 : 2); 3291cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts(); 3292000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3293000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We have special checking when the length is a sizeof expression. 3294000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth QualType SizeOfArgTy = getSizeOfArgType(LenExpr); 3295000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth const Expr *SizeOfArg = getSizeOfExprArg(LenExpr); 3296000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID SizeOfArgID; 3297000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 329806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) { 329906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts(); 3300e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange(); 330106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 330206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType DestTy = Dest->getType(); 330306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) { 330406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType PointeeTy = DestPtrTy->getPointeeType(); 3305f85e193739c953358c865005855253af4f68a497John McCall 3306000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Never warn about void type pointers. This can be used to suppress 3307000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // false positives. 3308000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isVoidType()) 330906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 331006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 3311000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by 3312000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // actually comparing the expressions for equality. Because computing the 3313000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // expression IDs can be expensive, we only do this if the diagnostic is 3314000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // enabled. 3315000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArg && 3316000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess, 3317000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->getExprLoc())) { 3318000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We only compute IDs for expressions if the warning is enabled, and 3319000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // cache the sizeof arg's ID. 3320000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgID == llvm::FoldingSetNodeID()) 3321000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->Profile(SizeOfArgID, Context, true); 3322000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID DestID; 3323000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Dest->Profile(DestID, Context, true); 3324000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (DestID == SizeOfArgID) { 3325cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // TODO: For strncpy() and friends, this could suggest sizeof(dst) 3326cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // over sizeof(src) as well. 3327000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth unsigned ActionIdx = 0; // Default is to suggest dereferencing. 33286fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks StringRef ReadableName = FnName->getName(); 33296fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 3330000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest)) 333190c78328e70cb376754edf87708505a84c044271Anna Zaks if (UnaryOp->getOpcode() == UO_AddrOf) 3332000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 1; // If its an address-of operator, just remove it. 33337adf4179f827b14b025135829dadeaa2442e1d42Fariborz Jahanian if (!PointeeTy->isIncompleteType() && 33347adf4179f827b14b025135829dadeaa2442e1d42Fariborz Jahanian (Context.getTypeSize(PointeeTy) == Context.getCharWidth())) 3335000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 2; // If the pointee's size is sizeof(char), 3336000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // suggest an explicit length. 33376fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 33386fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks // If the function is defined as a builtin macro, do not show macro 33396fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks // expansion. 33406fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceLocation SL = SizeOfArg->getExprLoc(); 33416fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceRange DSR = Dest->getSourceRange(); 33426fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceRange SSR = SizeOfArg->getSourceRange(); 33436fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceManager &SM = PP.getSourceManager(); 33446fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 33456fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks if (SM.isMacroArgExpansion(SL)) { 33466fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks ReadableName = Lexer::getImmediateMacroName(SL, SM, LangOpts); 33476fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SL = SM.getSpellingLoc(SL); 33486fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks DSR = SourceRange(SM.getSpellingLoc(DSR.getBegin()), 33496fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SM.getSpellingLoc(DSR.getEnd())); 33506fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SSR = SourceRange(SM.getSpellingLoc(SSR.getBegin()), 33516fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SM.getSpellingLoc(SSR.getEnd())); 33526fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks } 33536fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 335490c78328e70cb376754edf87708505a84c044271Anna Zaks DiagRuntimeBehavior(SL, SizeOfArg, 3355000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_expr_memaccess) 33566fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks << ReadableName 335790c78328e70cb376754edf87708505a84c044271Anna Zaks << PointeeTy 335890c78328e70cb376754edf87708505a84c044271Anna Zaks << DestTy 33596fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks << DSR 336090c78328e70cb376754edf87708505a84c044271Anna Zaks << SSR); 336190c78328e70cb376754edf87708505a84c044271Anna Zaks DiagRuntimeBehavior(SL, SizeOfArg, 336290c78328e70cb376754edf87708505a84c044271Anna Zaks PDiag(diag::warn_sizeof_pointer_expr_memaccess_note) 336390c78328e70cb376754edf87708505a84c044271Anna Zaks << ActionIdx 336490c78328e70cb376754edf87708505a84c044271Anna Zaks << SSR); 336590c78328e70cb376754edf87708505a84c044271Anna Zaks 3366000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 3367000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3368000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3369000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3370000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Also check for cases where the sizeof argument is the exact same 3371000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // type as the memory argument, and where it points to a user-defined 3372000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // record type. 3373000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgTy != QualType()) { 3374000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isRecordType() && 3375000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Context.typesAreCompatible(SizeOfArgTy, DestTy)) { 3376000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest, 3377000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_type_memaccess) 3378000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << FnName << SizeOfArgTy << ArgIdx 3379000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << PointeeTy << Dest->getSourceRange() 3380000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << LenExpr->getSourceRange()); 3381000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 3382000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3383e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber } 3384e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 338506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor // Always complain about dynamic classes. 33860a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (isDynamicClassType(PointeeTy)) { 33870a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 33880a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned OperationType = 0; 33890a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // "overwritten" if we're warning about the destination for any call 33900a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // but memcmp; otherwise a verb appropriate to the call. 33910a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (ArgIdx != 0 || BId == Builtin::BImemcmp) { 33920a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (BId == Builtin::BImemcpy) 33930a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 1; 33940a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if(BId == Builtin::BImemmove) 33950a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 2; 33960a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if (BId == Builtin::BImemcmp) 33970a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 3; 33980a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } 33990a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 34005c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 34015c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 34025c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_dyn_class_memaccess) 34030a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx) 3404d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks << FnName << PointeeTy 34050a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << OperationType 34065c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 34070a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } else if (PointeeTy.hasNonTrivialObjCLifetime() && 34080a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId != Builtin::BImemset) 34095c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 34105c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 34115c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_arc_object_memaccess) 34125c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << ArgIdx << FnName << PointeeTy 34135c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 3414f85e193739c953358c865005855253af4f68a497John McCall else 341506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 3416f85e193739c953358c865005855253af4f68a497John McCall 3417f85e193739c953358c865005855253af4f68a497John McCall DiagRuntimeBehavior( 3418f85e193739c953358c865005855253af4f68a497John McCall Dest->getExprLoc(), Dest, 3419929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth PDiag(diag::note_bad_memaccess_silence) 342006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)")); 342106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor break; 342206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 34237ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth } 34247ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth} 34257ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 3426bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// A little helper routine: ignore addition and subtraction of integer literals. 3427bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// This intentionally does not ignore all integer constant expressions because 3428bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// we don't want to remove sizeof(). 3429bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekstatic const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) { 3430bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = Ex->IgnoreParenCasts(); 3431bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3432bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek for (;;) { 3433bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex); 3434bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!BO || !BO->isAdditiveOp()) 3435bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 3436bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3437bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *RHS = BO->getRHS()->IgnoreParenCasts(); 3438bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *LHS = BO->getLHS()->IgnoreParenCasts(); 3439bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3440bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (isa<IntegerLiteral>(RHS)) 3441bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = LHS; 3442bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else if (isa<IntegerLiteral>(LHS)) 3443bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = RHS; 3444bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else 3445bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 3446bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3447bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3448bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return Ex; 3449bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 3450bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 34510f38acee92014cb15af980808f87144e5564031dAnna Zaksstatic bool isConstantSizeArrayWithMoreThanOneElement(QualType Ty, 34520f38acee92014cb15af980808f87144e5564031dAnna Zaks ASTContext &Context) { 34530f38acee92014cb15af980808f87144e5564031dAnna Zaks // Only handle constant-sized or VLAs, but not flexible members. 34540f38acee92014cb15af980808f87144e5564031dAnna Zaks if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(Ty)) { 34550f38acee92014cb15af980808f87144e5564031dAnna Zaks // Only issue the FIXIT for arrays of size > 1. 34560f38acee92014cb15af980808f87144e5564031dAnna Zaks if (CAT->getSize().getSExtValue() <= 1) 34570f38acee92014cb15af980808f87144e5564031dAnna Zaks return false; 34580f38acee92014cb15af980808f87144e5564031dAnna Zaks } else if (!Ty->isVariableArrayType()) { 34590f38acee92014cb15af980808f87144e5564031dAnna Zaks return false; 34600f38acee92014cb15af980808f87144e5564031dAnna Zaks } 34610f38acee92014cb15af980808f87144e5564031dAnna Zaks return true; 34620f38acee92014cb15af980808f87144e5564031dAnna Zaks} 34630f38acee92014cb15af980808f87144e5564031dAnna Zaks 3464bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// Warn if the user has made the 'size' argument to strlcpy or strlcat 3465bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// be the size of the source, instead of the destination. 3466bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekvoid Sema::CheckStrlcpycatArguments(const CallExpr *Call, 3467bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek IdentifierInfo *FnName) { 3468bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3469bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Don't crash if the user has the wrong number of arguments 3470bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (Call->getNumArgs() != 3) 3471bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3472bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3473bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context); 3474bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context); 3475bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *CompareWithSrc = NULL; 3476bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3477bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, sizeof(x))' 3478bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const Expr *Ex = getSizeOfExprArg(SizeArg)) 3479bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = Ex; 3480bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else { 3481bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, strlen(x))' 3482bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) { 3483180f47959a066795cc0f409433023af448bb0328Richard Smith if (SizeCall->isBuiltinCall() == Builtin::BIstrlen 3484bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek && SizeCall->getNumArgs() == 1) 3485bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context); 3486bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3487bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3488bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3489bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrc) 3490bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3491bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3492bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Determine if the argument to sizeof/strlen is equal to the source 3493bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // argument. In principle there's all kinds of things you could do 3494bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // here, for instance creating an == expression and evaluating it with 3495bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // EvaluateAsBooleanCondition, but this uses a more direct technique: 3496bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg); 3497bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!SrcArgDRE) 3498bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3499bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3500bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc); 3501bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrcDRE || 3502bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl()) 3503bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3504bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3505bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *OriginalSizeArg = Call->getArg(2); 3506bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size) 3507bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek << OriginalSizeArg->getSourceRange() << FnName; 3508bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3509bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Output a FIXIT hint if the destination is an array (rather than a 3510bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointer to an array). This could be enhanced to handle some 3511bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointers if we know the actual size, like if DstArg is 'array+2' 3512bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // we could say 'sizeof(array)-2'. 3513bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts(); 35140f38acee92014cb15af980808f87144e5564031dAnna Zaks if (!isConstantSizeArrayWithMoreThanOneElement(DstArg->getType(), Context)) 35158f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 35168f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 3517f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> sizeString; 35188f7462237ff542a4556775f98709ed300aa1731aTed Kremenek llvm::raw_svector_ostream OS(sizeString); 35198f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << "sizeof("; 3520d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 35218f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << ")"; 35228f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 35238f7462237ff542a4556775f98709ed300aa1731aTed Kremenek Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size) 35248f7462237ff542a4556775f98709ed300aa1731aTed Kremenek << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(), 35258f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS.str()); 3526bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 3527bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3528c36bedc90c687caa71748480c60707ea4608b092Anna Zaks/// Check if two expressions refer to the same declaration. 3529c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic bool referToTheSameDecl(const Expr *E1, const Expr *E2) { 3530c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const DeclRefExpr *D1 = dyn_cast_or_null<DeclRefExpr>(E1)) 3531c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const DeclRefExpr *D2 = dyn_cast_or_null<DeclRefExpr>(E2)) 3532c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return D1->getDecl() == D2->getDecl(); 3533c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return false; 3534c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3535c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3536c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic const Expr *getStrlenExprArg(const Expr *E) { 3537c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const CallExpr *CE = dyn_cast<CallExpr>(E)) { 3538c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const FunctionDecl *FD = CE->getDirectCallee(); 3539c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (!FD || FD->getMemoryFunctionKind() != Builtin::BIstrlen) 3540c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return 0; 3541c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return CE->getArg(0)->IgnoreParenCasts(); 3542c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3543c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return 0; 3544c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3545c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3546c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// Warn on anti-patterns as the 'size' argument to strncat. 3547c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// The correct size argument should look like following: 3548c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// strncat(dst, src, sizeof(dst) - strlen(dest) - 1); 3549c36bedc90c687caa71748480c60707ea4608b092Anna Zaksvoid Sema::CheckStrncatArguments(const CallExpr *CE, 3550c36bedc90c687caa71748480c60707ea4608b092Anna Zaks IdentifierInfo *FnName) { 3551c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Don't crash if the user has the wrong number of arguments. 3552c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (CE->getNumArgs() < 3) 3553c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 3554c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *DstArg = CE->getArg(0)->IgnoreParenCasts(); 3555c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *SrcArg = CE->getArg(1)->IgnoreParenCasts(); 3556c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *LenArg = CE->getArg(2)->IgnoreParenCasts(); 3557c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3558c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Identify common expressions, which are wrongly used as the size argument 3559c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // to strncat and may lead to buffer overflows. 3560c36bedc90c687caa71748480c60707ea4608b092Anna Zaks unsigned PatternType = 0; 3561c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const Expr *SizeOfArg = getSizeOfExprArg(LenArg)) { 3562c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(dst) 3563c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (referToTheSameDecl(SizeOfArg, DstArg)) 3564c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 1; 3565c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(src) 3566c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (referToTheSameDecl(SizeOfArg, SrcArg)) 3567c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 2; 3568c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } else if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(LenArg)) { 3569c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (BE->getOpcode() == BO_Sub) { 3570c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *L = BE->getLHS()->IgnoreParenCasts(); 3571c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *R = BE->getRHS()->IgnoreParenCasts(); 3572c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(dst) - strlen(dst) 3573c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (referToTheSameDecl(DstArg, getSizeOfExprArg(L)) && 3574c36bedc90c687caa71748480c60707ea4608b092Anna Zaks referToTheSameDecl(DstArg, getStrlenExprArg(R))) 3575c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 1; 3576c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(src) - (anything) 3577c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (referToTheSameDecl(SrcArg, getSizeOfExprArg(L))) 3578c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 2; 3579c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3580c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3581c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3582c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (PatternType == 0) 3583c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 3584c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3585afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks // Generate the diagnostic. 3586afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceLocation SL = LenArg->getLocStart(); 3587afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceRange SR = LenArg->getSourceRange(); 3588afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceManager &SM = PP.getSourceManager(); 3589afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks 3590afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks // If the function is defined as a builtin macro, do not show macro expansion. 3591afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks if (SM.isMacroArgExpansion(SL)) { 3592afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SL = SM.getSpellingLoc(SL); 3593afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SR = SourceRange(SM.getSpellingLoc(SR.getBegin()), 3594afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SM.getSpellingLoc(SR.getEnd())); 3595afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks } 3596afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks 35970f38acee92014cb15af980808f87144e5564031dAnna Zaks // Check if the destination is an array (rather than a pointer to an array). 35980f38acee92014cb15af980808f87144e5564031dAnna Zaks QualType DstTy = DstArg->getType(); 35990f38acee92014cb15af980808f87144e5564031dAnna Zaks bool isKnownSizeArray = isConstantSizeArrayWithMoreThanOneElement(DstTy, 36000f38acee92014cb15af980808f87144e5564031dAnna Zaks Context); 36010f38acee92014cb15af980808f87144e5564031dAnna Zaks if (!isKnownSizeArray) { 36020f38acee92014cb15af980808f87144e5564031dAnna Zaks if (PatternType == 1) 36030f38acee92014cb15af980808f87144e5564031dAnna Zaks Diag(SL, diag::warn_strncat_wrong_size) << SR; 36040f38acee92014cb15af980808f87144e5564031dAnna Zaks else 36050f38acee92014cb15af980808f87144e5564031dAnna Zaks Diag(SL, diag::warn_strncat_src_size) << SR; 36060f38acee92014cb15af980808f87144e5564031dAnna Zaks return; 36070f38acee92014cb15af980808f87144e5564031dAnna Zaks } 36080f38acee92014cb15af980808f87144e5564031dAnna Zaks 3609c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (PatternType == 1) 3610afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::warn_strncat_large_size) << SR; 3611c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else 3612afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::warn_strncat_src_size) << SR; 3613c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3614f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> sizeString; 3615c36bedc90c687caa71748480c60707ea4608b092Anna Zaks llvm::raw_svector_ostream OS(sizeString); 3616c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << "sizeof("; 3617d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 3618c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << ") - "; 3619c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << "strlen("; 3620d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 3621c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << ") - 1"; 3622c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3623afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::note_strncat_wrong_size) 3624afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks << FixItHint::CreateReplacement(SR, OS.str()); 3625c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3626c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 362706de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===// 362806de276fff91264437fa75111ed76de43097e089Ted Kremenek 3629e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3630e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl); 3631e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars, 3632e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl); 363306de276fff91264437fa75111ed76de43097e089Ted Kremenek 363406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address 363506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable. 363606de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid 363706de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 363806de276fff91264437fa75111ed76de43097e089Ted Kremenek SourceLocation ReturnLoc) { 36391eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 364026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Expr *stackE = 0; 36415f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<DeclRefExpr *, 8> refVars; 36424e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 364326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Perform checking for returned stack addresses, local blocks, 364426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // label addresses or references to temporaries. 3645f85e193739c953358c865005855253af4f68a497John McCall if (lhsType->isPointerType() || 36464e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie (!getLangOpts().ObjCAutoRefCount && lhsType->isBlockPointerType())) { 3647e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/0); 3648ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (lhsType->isReferenceType()) { 3649e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis stackE = EvalVal(RetValExp, refVars, /*ParentDecl=*/0); 365026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 365126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 365226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (stackE == 0) 365326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return; // Nothing suspicious was found. 365426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 365526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceLocation diagLoc; 365626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange diagRange; 365726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (refVars.empty()) { 365826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = stackE->getLocStart(); 365926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = stackE->getSourceRange(); 366026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { 366126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // We followed through a reference variable. 'stackE' contains the 366226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // problematic expression but we will warn at the return statement pointing 366326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // at the reference variable. We will later display the "trail" of 366426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // reference variables using notes. 366526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = refVars[0]->getLocStart(); 366626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = refVars[0]->getSourceRange(); 366726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 366826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 366926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var. 367026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref 367126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_stack_addr) 367226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << DR->getDecl()->getDeclName() << diagRange; 367326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<BlockExpr>(stackE)) { // local block. 367426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::err_ret_local_block) << diagRange; 367526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 367626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 367726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { // local temporary. 367826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref 367926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_local_temp_addr) 368026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << diagRange; 368126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 368226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 368326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Display the "trail" of reference variables that we followed until we 368426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // found the problematic expression using notes. 368526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 368626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 368726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this var binds to another reference var, show the range of the next 368826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // var, otherwise the var binds to the problematic expression, in which case 368926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // show the range of the expression. 369026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange() 369126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : stackE->getSourceRange(); 369226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(VD->getLocation(), diag::note_ref_var_local_bind) 369326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << VD->getDeclName() << range; 369406de276fff91264437fa75111ed76de43097e089Ted Kremenek } 369506de276fff91264437fa75111ed76de43097e089Ted Kremenek} 369606de276fff91264437fa75111ed76de43097e089Ted Kremenek 369706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 369806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// check if the expression in a return statement evaluates to an address 369926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// to a location on the stack, a local block, an address of a label, or a 370026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// reference to local temporary. The recursion is used to traverse the 370106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// AST of the return expression, with recursion backtracking when we 370226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// encounter a subexpression that (1) clearly does not lead to one of the 370326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// above problematic expressions (2) is something we cannot determine leads to 370426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// a problematic expression based on such local checking. 370526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 370626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// Both EvalAddr and EvalVal follow through reference variables to evaluate 370726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// the expression that they point to. Such variables are added to the 370826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 'refVars' vector so that we know what the reference variable "trail" was. 370906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 3710e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// EvalAddr processes expressions that are pointers that are used as 3711e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// references (and not L-values). EvalVal handles all other values. 371226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// At the base case of the recursion is a check for the above problematic 371326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// expressions. 371406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 371506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// This implementation handles: 371606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 371706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer-to-pointer casts 371806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * implicit conversions from array references to pointers 371906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of fields 372006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * arbitrary interplay between "&" and "*" operators 372106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer arithmetic from an address of a stack variable 372206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of an array element where the array is on the stack 3723e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3724e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl) { 372526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (E->isTypeDependent()) 372626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 372726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 372806de276fff91264437fa75111ed76de43097e089Ted Kremenek // We should only be called for evaluating pointer expressions. 37290f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall assert((E->getType()->isAnyPointerType() || 3730dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff E->getType()->isBlockPointerType() || 3731a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek E->getType()->isObjCQualifiedIdType()) && 3732fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner "EvalAddr only works on pointers"); 37331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3734f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 3735f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 373606de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 373706de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 373806de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 373906de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 374026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::DeclRefExprClass: { 374126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis DeclRefExpr *DR = cast<DeclRefExpr>(E); 374226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 374326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 374426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this is a reference variable, follow through to the expression that 374526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 374626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage() && 374726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis V->getType()->isReferenceType() && V->hasInit()) { 374826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 374926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 3750e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(V->getInit(), refVars, ParentDecl); 375126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 375226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 375326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 375426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 375506de276fff91264437fa75111ed76de43097e089Ted Kremenek 3756fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::UnaryOperatorClass: { 3757fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // The only unary operator that make sense to handle here 3758fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // is AddrOf. All others don't make sense as pointers. 3759fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner UnaryOperator *U = cast<UnaryOperator>(E); 37601eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 37612de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_AddrOf) 3762e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(U->getSubExpr(), refVars, ParentDecl); 3763fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 3764fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 3765fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 37661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3767fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::BinaryOperatorClass: { 3768fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle pointer arithmetic. All other binary operators are not valid 3769fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // in this context. 3770fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner BinaryOperator *B = cast<BinaryOperator>(E); 37712de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = B->getOpcode(); 37721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 37732de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op != BO_Add && op != BO_Sub) 3774fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 37751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3776fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner Expr *Base = B->getLHS(); 37773907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 3778fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Determine which argument is the real pointer base. It could be 3779fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // the RHS argument instead of the LHS. 3780fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner if (!Base->getType()->isPointerType()) Base = B->getRHS(); 37811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3782fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner assert (Base->getType()->isPointerType()); 3783e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(Base, refVars, ParentDecl); 3784fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 378561f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff 3786fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // For conditional operators we need to see if either the LHS or RHS are 3787fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // valid DeclRefExpr*s. If one of them is valid, we return it. 3788fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ConditionalOperatorClass: { 3789fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner ConditionalOperator *C = cast<ConditionalOperator>(E); 37901eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3791fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle the GNU extension for missing LHS. 37929ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (Expr *lhsExpr = C->getLHS()) { 37939ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 37949ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (!lhsExpr->getType()->isVoidType()) 3795e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (Expr* LHS = EvalAddr(lhsExpr, refVars, ParentDecl)) 37969ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return LHS; 37979ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor } 37989ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor 37999ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 38009ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (C->getRHS()->getType()->isVoidType()) 38019ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return NULL; 380206de276fff91264437fa75111ed76de43097e089Ted Kremenek 3803e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(C->getRHS(), refVars, ParentDecl); 3804fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 380526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 380626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::BlockExprClass: 3807469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures()) 380826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // local block. 380926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 381026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 381126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::AddrLabelExprClass: 381226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // address of label. 38131eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 381480ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 3815e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars, 3816e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis ParentDecl); 381780ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 381854b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // For casts, we need to handle conversions from arrays to 381954b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // pointer values, and pointer-to-pointer conversions. 382049badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::ImplicitCastExprClass: 38216eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor case Stmt::CStyleCastExprClass: 3822f85e193739c953358c865005855253af4f68a497John McCall case Stmt::CXXFunctionalCastExprClass: 38238b9414e868853fc052251455674bf7512261e14aEli Friedman case Stmt::ObjCBridgedCastExprClass: 38241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXStaticCastExprClass: 38251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXDynamicCastExprClass: 382649badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXConstCastExprClass: 382749badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXReinterpretCastExprClass: { 38288b9414e868853fc052251455674bf7512261e14aEli Friedman Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 38298b9414e868853fc052251455674bf7512261e14aEli Friedman switch (cast<CastExpr>(E)->getCastKind()) { 38308b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BitCast: 38318b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_LValueToRValue: 38328b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_NoOp: 38338b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BaseToDerived: 38348b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_DerivedToBase: 38358b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_UncheckedDerivedToBase: 38368b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_Dynamic: 38378b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_CPointerToObjCPointerCast: 38388b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BlockPointerToObjCPointerCast: 38398b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_AnyPointerToBlockPointerCast: 3840e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(SubExpr, refVars, ParentDecl); 38418b9414e868853fc052251455674bf7512261e14aEli Friedman 38428b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_ArrayToPointerDecay: 3843e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(SubExpr, refVars, ParentDecl); 38448b9414e868853fc052251455674bf7512261e14aEli Friedman 38458b9414e868853fc052251455674bf7512261e14aEli Friedman default: 38468b9414e868853fc052251455674bf7512261e14aEli Friedman return 0; 38478b9414e868853fc052251455674bf7512261e14aEli Friedman } 3848fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 38491eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 385003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 385103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalAddr( 385203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 3853e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis refVars, ParentDecl)) 385403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 385503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 385603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 385703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 3858fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Everything else: we simply don't reason about them. 3859fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner default: 3860fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 386106de276fff91264437fa75111ed76de43097e089Ted Kremenek } 386206de276fff91264437fa75111ed76de43097e089Ted Kremenek} 38631eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 386406de276fff91264437fa75111ed76de43097e089Ted Kremenek 386506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalVal - This function is complements EvalAddr in the mutual recursion. 386606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// See the comments for EvalAddr for more details. 3867e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3868e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl) { 386968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo { 3870e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // We should only be called for evaluating non-pointer expressions, or 3871e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // expressions with a pointer type that are not used as references but instead 3872e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // are l-values (e.g., DeclRefExpr with a pointer type). 38731eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 387406de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 387506de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 387606de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 3877f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 3878f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 387906de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 388068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ImplicitCastExprClass: { 388168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 38825baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall if (IE->getValueKind() == VK_LValue) { 388368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = IE->getSubExpr(); 388468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 388568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 388668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek return NULL; 388768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 388868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek 388980ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 3890e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,ParentDecl); 389180ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 3892a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor case Stmt::DeclRefExprClass: { 389326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // When we hit a DeclRefExpr we are looking at code that refers to a 389426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // variable's name. If it's not a reference variable we check if it has 389526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // local storage within the function, and if so, return the expression. 389606de276fff91264437fa75111ed76de43097e089Ted Kremenek DeclRefExpr *DR = cast<DeclRefExpr>(E); 38971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3898e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) { 3899e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis // Check if it refers to itself, e.g. "int& i = i;". 3900e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (V == ParentDecl) 3901e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return DR; 3902e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis 390326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage()) { 390426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!V->getType()->isReferenceType()) 390526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return DR; 390626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 390726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Reference variable, follow through to the expression that 390826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 390926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasInit()) { 391026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 391126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 3912e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(V->getInit(), refVars, V); 391326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 391426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 3915e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis } 39161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 391706de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 391806de276fff91264437fa75111ed76de43097e089Ted Kremenek } 39191eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 392006de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::UnaryOperatorClass: { 392106de276fff91264437fa75111ed76de43097e089Ted Kremenek // The only unary operator that make sense to handle here 392206de276fff91264437fa75111ed76de43097e089Ted Kremenek // is Deref. All others don't resolve to a "name." This includes 392306de276fff91264437fa75111ed76de43097e089Ted Kremenek // handling all sorts of rvalues passed to a unary operator. 392406de276fff91264437fa75111ed76de43097e089Ted Kremenek UnaryOperator *U = cast<UnaryOperator>(E); 39251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 39262de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_Deref) 3927e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(U->getSubExpr(), refVars, ParentDecl); 392806de276fff91264437fa75111ed76de43097e089Ted Kremenek 392906de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 393006de276fff91264437fa75111ed76de43097e089Ted Kremenek } 39311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 393206de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ArraySubscriptExprClass: { 393306de276fff91264437fa75111ed76de43097e089Ted Kremenek // Array subscripts are potential references to data on the stack. We 393406de276fff91264437fa75111ed76de43097e089Ted Kremenek // retrieve the DeclRefExpr* for the array variable if it indeed 393506de276fff91264437fa75111ed76de43097e089Ted Kremenek // has local storage. 3936e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars,ParentDecl); 393706de276fff91264437fa75111ed76de43097e089Ted Kremenek } 39381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 393906de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ConditionalOperatorClass: { 394006de276fff91264437fa75111ed76de43097e089Ted Kremenek // For conditional operators we need to see if either the LHS or RHS are 394126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // non-NULL Expr's. If one is non-NULL, we return it. 394206de276fff91264437fa75111ed76de43097e089Ted Kremenek ConditionalOperator *C = cast<ConditionalOperator>(E); 394306de276fff91264437fa75111ed76de43097e089Ted Kremenek 39443907323dd6665c0c4e383435cb145233f4533406Anders Carlsson // Handle the GNU extension for missing LHS. 39453907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (Expr *lhsExpr = C->getLHS()) 3946e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (Expr *LHS = EvalVal(lhsExpr, refVars, ParentDecl)) 39473907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return LHS; 39483907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 3949e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(C->getRHS(), refVars, ParentDecl); 395006de276fff91264437fa75111ed76de43097e089Ted Kremenek } 39511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 395206de276fff91264437fa75111ed76de43097e089Ted Kremenek // Accesses to members are potential references to data on the stack. 395383f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor case Stmt::MemberExprClass: { 395406de276fff91264437fa75111ed76de43097e089Ted Kremenek MemberExpr *M = cast<MemberExpr>(E); 39551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 395606de276fff91264437fa75111ed76de43097e089Ted Kremenek // Check for indirect access. We only want direct field accesses. 3957a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->isArrow()) 3958a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return NULL; 3959a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 3960a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // Check whether the member type is itself a reference, in which case 3961a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // we're not going to refer to the member, but to what the member refers to. 3962a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->getMemberDecl()->getType()->isReferenceType()) 396306de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 3964a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 3965e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(M->getBase(), refVars, ParentDecl); 396606de276fff91264437fa75111ed76de43097e089Ted Kremenek } 39671eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 396803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 396903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalVal( 397003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 3971e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis refVars, ParentDecl)) 397203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 397303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 397403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 397503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 397606de276fff91264437fa75111ed76de43097e089Ted Kremenek default: 397726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Check that we don't return or take the address of a reference to a 397826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // temporary. This is only useful in C++. 397926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!E->isTypeDependent() && E->isRValue()) 398026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; 398126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 398226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Everything else: we simply don't reason about them. 398306de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 398406de276fff91264437fa75111ed76de43097e089Ted Kremenek } 398568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true); 398606de276fff91264437fa75111ed76de43097e089Ted Kremenek} 3987588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3988588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 3989588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3990588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==. 3991588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely 3992588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended. 3993dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieuvoid Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) { 3994dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts(); 3995dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* RightExprSansParen = RHS->IgnoreParenImpCasts(); 3996588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3997588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Special case: check for x == x (which is OK). 3998588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Do not emit warnings for such cases. 3999588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 4000588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 4001588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DRL->getDecl() == DRR->getDecl()) 4002980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 40031eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 40041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 40051b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // Special case: check for comparisons against literals that can be exactly 40061b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // represented by APFloat. In such cases, do not emit a warning. This 40071b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // is a heuristic: often comparison against such literals are used to 40081b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // detect if a value in a variable has not changed. This clearly can 40091b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // lead to false negatives. 4010980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 4011980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FLL->isExact()) 4012980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 4013980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie } else 4014980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)) 4015980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FLR->isExact()) 4016980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 40171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4018588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Check for comparisons with builtin types. 4019980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 4020980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CL->isBuiltinCall()) 4021980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 40221eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4023980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 4024980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CR->isBuiltinCall()) 4025980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 40261eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4027588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Emit the diagnostic. 4028980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie Diag(Loc, diag::warn_floatingpoint_eq) 4029980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie << LHS->getSourceRange() << RHS->getSourceRange(); 4030588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek} 4031ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4032f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 4033f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 4034ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4035f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace { 4036ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4037f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued 4038f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression. 4039f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange { 4040f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// The number of bits active in the int. 4041f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned Width; 4042ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4043f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// True if the int is known not to have negative values. 4044f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool NonNegative; 404551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4046f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange(unsigned Width, bool NonNegative) 4047f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : Width(Width), NonNegative(NonNegative) 4048f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall {} 404951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 40501844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of the bool type. 4051f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall static IntRange forBoolType() { 4052f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(1, true); 4053f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 405451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 40551844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of the given integral type. 40561844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfType(ASTContext &C, QualType T) { 40571844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return forValueOfCanonicalType(C, 40581844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T->getCanonicalTypeInternal().getTypePtr()); 405951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 406051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 40611844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of a canonical integral type. 40621844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 4063f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(T->isCanonicalUnqualified()); 406451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4065f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 4066f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = VT->getElementType().getTypePtr(); 4067f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 4068f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = CT->getElementType().getTypePtr(); 4069323ed74658bc8375278eabf074b4777458376540John McCall 4070f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer // For enum types, use the known bit width of the enumerators. 4071323ed74658bc8375278eabf074b4777458376540John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) { 4072f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer EnumDecl *Enum = ET->getDecl(); 4073f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer if (!Enum->isCompleteDefinition()) 4074f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer return IntRange(C.getIntWidth(QualType(T, 0)), false); 4075091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 4076f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer unsigned NumPositive = Enum->getNumPositiveBits(); 4077f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer unsigned NumNegative = Enum->getNumNegativeBits(); 4078323ed74658bc8375278eabf074b4777458376540John McCall 4079f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer if (NumNegative == 0) 4080f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer return IntRange(NumPositive, true/*NonNegative*/); 4081f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer else 4082f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer return IntRange(std::max(NumPositive + 1, NumNegative), 4083f9eaf98bf524f7e2dcb9875a9f4afd9e25fc615dDavid Majnemer false/*NonNegative*/); 4084323ed74658bc8375278eabf074b4777458376540John McCall } 408551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4086f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const BuiltinType *BT = cast<BuiltinType>(T); 4087f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(BT->isInteger()); 408851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4089f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 409051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 409151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 40921844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the "target" range of a canonical integral type, i.e. 40931844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// the range of values expressible in the type. 40941844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// 40951844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// This matches forValueOfCanonicalType except that enums have the 40961844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// full range of their type, not the range of their enumerators. 40971844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 40981844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(T->isCanonicalUnqualified()); 40991844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 41001844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 41011844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = VT->getElementType().getTypePtr(); 41021844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 41031844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = CT->getElementType().getTypePtr(); 41041844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) 410569ff26bd1e7a2faffec0c3b9740cfb0c6bb354c5Douglas Gregor T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr(); 41061844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 41071844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall const BuiltinType *BT = cast<BuiltinType>(T); 41081844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(BT->isInteger()); 41091844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 41101844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 41111844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall } 41121844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 41131844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the supremum of two ranges: i.e. their conservative merge. 4114c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange join(IntRange L, IntRange R) { 4115f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(std::max(L.Width, R.Width), 411660fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative && R.NonNegative); 411760fad45739b764886f707bd204eae9ecce6db1f2John McCall } 411860fad45739b764886f707bd204eae9ecce6db1f2John McCall 41191844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the infinum of two ranges: i.e. their aggressive merge. 4120c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange meet(IntRange L, IntRange R) { 412160fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange(std::min(L.Width, R.Width), 412260fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative || R.NonNegative); 412351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 4124f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}; 412551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 41260692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, 41270692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek unsigned MaxWidth) { 4128f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isSigned() && value.isNegative()) 4129f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getMinSignedBits(), false); 413051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4131f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.getBitWidth() > MaxWidth) 41329f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad value = value.trunc(MaxWidth); 413351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4134f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // isNonNegative() just checks the sign bit without considering 4135f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // signedness. 4136f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getActiveBits(), true); 413751313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 413851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 41390692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 41400692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek unsigned MaxWidth) { 4141f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isInt()) 4142f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetValueRange(C, result.getInt(), MaxWidth); 414351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4144f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isVector()) { 41450acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 41460acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 41470acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 41480acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall R = IntRange::join(R, El); 41490acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall } 4150f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return R; 415151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 415251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4153f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isComplexInt()) { 4154f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 4155f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 4156f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(R, I); 4157f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 4158f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4159f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // This can happen with lossless casts to intptr_t of "based" lvalues. 4160f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume it might use arbitrary bits. 41610acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // FIXME: The only reason we need to pass the type in here is to get 41620acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // the sign right on this one case. It would be nice if APValue 41630acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // preserved this. 416465639284118d54ddf2e51a05d2ffccda567fe246Eli Friedman assert(result.isLValue() || result.isAddrLabelDiff()); 41655e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType()); 416651313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 416751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 416809bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedmanstatic QualType GetExprType(Expr *E) { 416909bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman QualType Ty = E->getType(); 417009bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman if (const AtomicType *AtomicRHS = Ty->getAs<AtomicType>()) 417109bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman Ty = AtomicRHS->getValueType(); 417209bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return Ty; 417309bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman} 417409bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman 4175f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the 4176f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take. 4177f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 4178f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated 41790692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 418051313c39c84407dd6a323be99a8c322bf8d052a9John McCall E = E->IgnoreParens(); 418151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4182f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Try a full evaluation first. 4183f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall Expr::EvalResult result; 418451f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, C)) 418509bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return GetValueRange(C, result.Val, GetExprType(E), MaxWidth); 418651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4187f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // I think we only want to look through implicit casts here; if the 4188f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // user has an explicit widening cast, we should treat the value as 4189f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // being of the new, wider type. 4190f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 4191b17ee5bff0d7986c14cdddb279e0131bd7f9678dEli Friedman if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue) 4192f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CE->getSubExpr(), MaxWidth); 419351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 419409bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman IntRange OutputTypeRange = IntRange::forValueOfType(C, GetExprType(CE)); 419551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 41962de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 419760fad45739b764886f707bd204eae9ecce6db1f2John McCall 4198f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume that non-integer casts can span the full range of the type. 419960fad45739b764886f707bd204eae9ecce6db1f2John McCall if (!isIntegerCast) 4200f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 420151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4202f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange SubRange 4203f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall = GetExprRange(C, CE->getSubExpr(), 4204f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall std::min(MaxWidth, OutputTypeRange.Width)); 420551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4206f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Bail out if the subexpr's range is as wide as the cast type. 4207f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SubRange.Width >= OutputTypeRange.Width) 4208f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 420951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4210f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, we take the smaller width, and we're non-negative if 4211f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // either the output type or the subexpr is. 4212f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(SubRange.Width, 4213f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall SubRange.NonNegative || OutputTypeRange.NonNegative); 4214f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 4215f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4216f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 4217f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // If we can fold the condition, just take that operand. 4218f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool CondResult; 4219f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 4220f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CondResult ? CO->getTrueExpr() 4221f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : CO->getFalseExpr(), 4222f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall MaxWidth); 4223f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4224f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, conservatively merge. 4225f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 4226f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 4227f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 422851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 422951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 423051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 423151313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (BO->getOpcode()) { 423251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4233f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Boolean-valued operations are single-bit and positive. 42342de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LAnd: 42352de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LOr: 42362de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LT: 42372de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GT: 42382de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LE: 42392de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GE: 42402de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_EQ: 42412de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_NE: 4242f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 424351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4244862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // The type of the assignments is the type of the LHS, so the RHS 4245862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // is not necessarily the same type. 42462de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_MulAssign: 42472de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_DivAssign: 42482de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_RemAssign: 42492de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AddAssign: 42502de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_SubAssign: 4251862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_XorAssign: 4252862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_OrAssign: 4253862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 425409bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 4255c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall 4256862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // Simple assignments just pass through the RHS, which will have 4257862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // been coerced to the LHS type. 4258862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_Assign: 4259862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 4260862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 4261862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall 426251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 42632de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemD: 42642de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemI: 426509bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 426651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 426760fad45739b764886f707bd204eae9ecce6db1f2John McCall // Bitwise-and uses the *infinum* of the two source ranges. 42682de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_And: 42692de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AndAssign: 427060fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 427160fad45739b764886f707bd204eae9ecce6db1f2John McCall GetExprRange(C, BO->getRHS(), MaxWidth)); 427260fad45739b764886f707bd204eae9ecce6db1f2John McCall 427351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Left shift gets black-listed based on a judgement call. 42742de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shl: 42753aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // ...except that we want to treat '1 << (blah)' as logically 42763aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // positive. It's an important idiom. 42773aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (IntegerLiteral *I 42783aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 42793aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (I->getValue() == 1) { 428009bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman IntRange R = IntRange::forValueOfType(C, GetExprType(E)); 42813aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall return IntRange(R.Width, /*NonNegative*/ true); 42823aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 42833aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 42843aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // fallthrough 42853aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall 42862de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShlAssign: 428709bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 428851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 428960fad45739b764886f707bd204eae9ecce6db1f2John McCall // Right shift by a constant can narrow its left argument. 42902de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shr: 42912de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShrAssign: { 429260fad45739b764886f707bd204eae9ecce6db1f2John McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 429360fad45739b764886f707bd204eae9ecce6db1f2John McCall 429460fad45739b764886f707bd204eae9ecce6db1f2John McCall // If the shift amount is a positive constant, drop the width by 429560fad45739b764886f707bd204eae9ecce6db1f2John McCall // that much. 429660fad45739b764886f707bd204eae9ecce6db1f2John McCall llvm::APSInt shift; 429760fad45739b764886f707bd204eae9ecce6db1f2John McCall if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 429860fad45739b764886f707bd204eae9ecce6db1f2John McCall shift.isNonNegative()) { 429960fad45739b764886f707bd204eae9ecce6db1f2John McCall unsigned zext = shift.getZExtValue(); 430060fad45739b764886f707bd204eae9ecce6db1f2John McCall if (zext >= L.Width) 430160fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width = (L.NonNegative ? 0 : 1); 430260fad45739b764886f707bd204eae9ecce6db1f2John McCall else 430360fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width -= zext; 430460fad45739b764886f707bd204eae9ecce6db1f2John McCall } 430560fad45739b764886f707bd204eae9ecce6db1f2John McCall 430660fad45739b764886f707bd204eae9ecce6db1f2John McCall return L; 430760fad45739b764886f707bd204eae9ecce6db1f2John McCall } 430860fad45739b764886f707bd204eae9ecce6db1f2John McCall 430960fad45739b764886f707bd204eae9ecce6db1f2John McCall // Comma acts as its right operand. 43102de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Comma: 4311f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 4312f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 431360fad45739b764886f707bd204eae9ecce6db1f2John McCall // Black-list pointer subtractions. 43142de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Sub: 431551313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BO->getLHS()->getType()->isPointerType()) 431609bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 431700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall break; 431800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 431900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The width of a division result is mostly determined by the size 432000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // of the LHS. 432100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Div: { 432200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 432309bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman unsigned opWidth = C.getIntWidth(GetExprType(E)); 432400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 432500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 432600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // If the divisor is constant, use that. 432700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall llvm::APSInt divisor; 432800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) { 432900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned log2 = divisor.logBase2(); // floor(log_2(divisor)) 433000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (log2 >= L.Width) 433100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = (L.NonNegative ? 0 : 1); 433200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall else 433300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = std::min(L.Width - log2, MaxWidth); 433400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return L; 433500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 433600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 433700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Otherwise, just use the LHS's width. 433800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 433900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return IntRange(L.Width, L.NonNegative && R.NonNegative); 434000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 434100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 434200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The result of a remainder can't be larger than the result of 434300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // either side. 434400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Rem: { 434500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 434609bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman unsigned opWidth = C.getIntWidth(GetExprType(E)); 434700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 434800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 434900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 435000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange meet = IntRange::meet(L, R); 435100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall meet.Width = std::min(meet.Width, MaxWidth); 435200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return meet; 435300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 43544e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 435500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default behavior is okay for these. 435600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Mul: 435700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Add: 435800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Xor: 435900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Or: 4360f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall break; 436151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 4362f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 436300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default case is to treat the operation as if it were closed 436400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // on the narrowest type that encompasses both operands. 4365f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 4366f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 4367f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 436851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 436951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 437051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 437151313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (UO->getOpcode()) { 437251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Boolean-valued operations are white-listed. 43732de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_LNot: 4374f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 437551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 437651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 43772de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_Deref: 43782de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_AddrOf: // should be impossible 437909bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 438051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 438151313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 4382f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, UO->getSubExpr(), MaxWidth); 438351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 438451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 438551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4386993f43f24d7a45a5cd4678a3316b0852261fc5d4John McCall if (FieldDecl *BitField = E->getSourceBitField()) 4387a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith return IntRange(BitField->getBitWidthValue(C), 43885e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor BitField->getType()->isUnsignedIntegerOrEnumerationType()); 4389f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 439009bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return IntRange::forValueOfType(C, GetExprType(E)); 4391f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 4392f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 43930692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E) { 439409bddcf8c0ce4cc2f2a18e050e971539e8a396f8Eli Friedman return GetExprRange(C, E, C.getIntWidth(GetExprType(E))); 4395323ed74658bc8375278eabf074b4777458376540John McCall} 4396323ed74658bc8375278eabf074b4777458376540John McCall 4397f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 4398f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 4399f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 44000692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const llvm::APFloat &value, 44010692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Src, 44020692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Tgt) { 4403f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APFloat truncated = value; 4404f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4405f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool ignored; 4406f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 4407f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 4408f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4409f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return truncated.bitwiseIsEqual(value); 441051313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 441151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4412f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 4413f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 4414f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 4415f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 4416f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number). 44170692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const APValue &value, 44180692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Src, 44190692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Tgt) { 4420f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isFloat()) 4421f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 4422f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4423f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isVector()) { 4424f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 4425f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 4426f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return false; 4427f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return true; 4428f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 4429f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4430f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(value.isComplexFloat()); 4431f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 4432f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 4433f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 4434f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 44350692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 4436323ed74658bc8375278eabf074b4777458376540John McCall 4437e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) { 4438e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where we are comparing against an enum constant. 4439e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (const DeclRefExpr *DR = 4440e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 4441e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (isa<EnumConstantDecl>(DR->getDecl())) 4442e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 4443e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 4444e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where the '0' value is expanded from a macro. 4445e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (E->getLocStart().isMacroID()) 4446e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 4447e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 4448323ed74658bc8375278eabf074b4777458376540John McCall llvm::APSInt Value; 4449323ed74658bc8375278eabf074b4777458376540John McCall return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 4450323ed74658bc8375278eabf074b4777458376540John McCall} 4451323ed74658bc8375278eabf074b4777458376540John McCall 4452372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) { 4453372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall // Strip off implicit integral promotions. 4454372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 445563b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis if (ICE->getCastKind() != CK_IntegralCast && 445663b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis ICE->getCastKind() != CK_NoOp) 4457372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall break; 445863b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis E = ICE->getSubExpr(); 4459372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall } 4460372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 4461372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall return E->getType()->isEnumeralType(); 4462372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall} 4463372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 44640692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 44652de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = E->getOpcode(); 446614af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor if (E->isValueDependent()) 446714af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor return; 446814af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor 44692de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op == BO_LT && IsZero(S, E->getRHS())) { 4470323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 4471372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "< 0" << "false" << HasEnumType(E->getLHS()) 4472323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 44732de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GE && IsZero(S, E->getRHS())) { 4474323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 4475372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << ">= 0" << "true" << HasEnumType(E->getLHS()) 4476323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 44772de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GT && IsZero(S, E->getLHS())) { 4478323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 4479372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 >" << "false" << HasEnumType(E->getRHS()) 4480323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 44812de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_LE && IsZero(S, E->getLHS())) { 4482323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 4483372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 <=" << "true" << HasEnumType(E->getRHS()) 4484323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 4485323ed74658bc8375278eabf074b4777458376540John McCall } 4486323ed74658bc8375278eabf074b4777458376540John McCall} 4487323ed74658bc8375278eabf074b4777458376540John McCall 448815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanianstatic void DiagnoseOutOfRangeComparison(Sema &S, BinaryOperator *E, 4489a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian Expr *Constant, Expr *Other, 449015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian llvm::APSInt Value, 4491a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian bool RhsConstant) { 4492526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // 0 values are handled later by CheckTrivialUnsignedComparison(). 4493526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (Value == 0) 4494526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4495526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 449615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian BinaryOperatorKind op = E->getOpcode(); 4497a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian QualType OtherT = Other->getType(); 4498a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian QualType ConstantT = Constant->getType(); 4499526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu QualType CommonT = E->getLHS()->getType(); 4500a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian if (S.Context.hasSameUnqualifiedType(OtherT, ConstantT)) 450115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian return; 4502a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian assert((OtherT->isIntegerType() && ConstantT->isIntegerType()) 450315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian && "comparison with non-integer type"); 4504526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4505526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool ConstantSigned = ConstantT->isSignedIntegerType(); 4506526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool CommonSigned = CommonT->isSignedIntegerType(); 4507526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4508526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool EqualityOnly = false; 4509526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4510526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // TODO: Investigate using GetExprRange() to get tighter bounds on 4511526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // on the bit ranges. 451215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian IntRange OtherRange = IntRange::forValueOfType(S.Context, OtherT); 4513526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu unsigned OtherWidth = OtherRange.Width; 4514526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4515526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (CommonSigned) { 4516526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // The common type is signed, therefore no signed to unsigned conversion. 4517d87de7bdbc25dd84ae3dbefffda4539c443000d2Eli Friedman if (!OtherRange.NonNegative) { 4518526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check that the constant is representable in type OtherT. 4519526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (ConstantSigned) { 4520526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getMinSignedBits()) 4521526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4522526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !ConstantSigned 4523526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getActiveBits() + 1) 4524526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4525526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4526526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !OtherSigned 4527526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check that the constant is representable in type OtherT. 4528526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Negative values are out of range. 4529526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (ConstantSigned) { 4530526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (Value.isNonNegative() && OtherWidth >= Value.getActiveBits()) 4531526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4532526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !ConstantSigned 4533526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getActiveBits()) 4534526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4535526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4536526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4537526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !CommonSigned 4538d87de7bdbc25dd84ae3dbefffda4539c443000d2Eli Friedman if (OtherRange.NonNegative) { 4539526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getActiveBits()) 4540526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4541d87de7bdbc25dd84ae3dbefffda4539c443000d2Eli Friedman } else if (!OtherRange.NonNegative && !ConstantSigned) { 4542526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check to see if the constant is representable in OtherT. 4543526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth > Value.getActiveBits()) 4544526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4545526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check to see if the constant is equivalent to a negative value 4546526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // cast to CommonT. 4547526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (S.Context.getIntWidth(ConstantT) == S.Context.getIntWidth(CommonT) && 45485d1cf4f292cb060b1973eb197607fc6d5716bd12Richard Trieu Value.isNegative() && Value.getMinSignedBits() <= OtherWidth) 4549526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4550526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // The constant value rests between values that OtherT can represent after 4551526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // conversion. Relational comparison still works, but equality 4552526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // comparisons will be tautological. 4553526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu EqualityOnly = true; 4554526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // OtherSigned && ConstantSigned 4555526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu assert(0 && "Two signed types converted to unsigned types."); 4556526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4557526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4558526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4559526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool PositiveConstant = !ConstantSigned || Value.isNonNegative(); 4560526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 456115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsTrue = true; 4562526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (op == BO_EQ || op == BO_NE) { 4563526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = op == BO_NE; 4564526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else if (EqualityOnly) { 4565526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4566526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else if (RhsConstant) { 456715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (op == BO_GT || op == BO_GE) 4568526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = !PositiveConstant; 456915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else // op == BO_LT || op == BO_LE 4570526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = PositiveConstant; 4571a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian } else { 457215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (op == BO_LT || op == BO_LE) 4573526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = !PositiveConstant; 457415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else // op == BO_GT || op == BO_GE 4575526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = PositiveConstant; 457615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian } 45777adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek 45787adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek // If this is a comparison to an enum constant, include that 45797adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek // constant in the diagnostic. 45807adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek const EnumConstantDecl *ED = 0; 45817adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Constant)) 45827adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek ED = dyn_cast<EnumConstantDecl>(DR->getDecl()); 45837adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek 45847adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek SmallString<64> PrettySourceValue; 45857adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek llvm::raw_svector_ostream OS(PrettySourceValue); 45867adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek if (ED) 45879de50947ba381561a5236b3c878c83e4bb8c1088Ted Kremenek OS << '\'' << *ED << "' (" << Value << ")"; 45887adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek else 45897adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek OS << Value; 45907adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek 4591a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian S.Diag(E->getOperatorLoc(), diag::warn_out_of_range_compare) 45927adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek << OS.str() << OtherT << IsTrue 4593526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 459415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian} 459515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4596323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison. Implements the 4597323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison. 45980692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 4599b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 4600b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 4601323ed74658bc8375278eabf074b4777458376540John McCall} 4602f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4603ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare. 4604ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// 4605dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu/// \param E the binary operator to check for warnings 46060692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeComparison(Sema &S, BinaryOperator *E) { 4607323ed74658bc8375278eabf074b4777458376540John McCall // The type the comparison is being performed in. 4608323ed74658bc8375278eabf074b4777458376540John McCall QualType T = E->getLHS()->getType(); 4609323ed74658bc8375278eabf074b4777458376540John McCall assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 4610323ed74658bc8375278eabf074b4777458376540John McCall && "comparison with mismatched types"); 4611ab4702febef82409773f7c80ec02d53ddbb4d80eFariborz Jahanian if (E->isValueDependent()) 4612ab4702febef82409773f7c80ec02d53ddbb4d80eFariborz Jahanian return AnalyzeImpConvsInComparison(S, E); 4613323ed74658bc8375278eabf074b4777458376540John McCall 461415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian Expr *LHS = E->getLHS()->IgnoreParenImpCasts(); 461515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian Expr *RHS = E->getRHS()->IgnoreParenImpCasts(); 461615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 461715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsComparisonConstant = false; 461815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4619a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian // Check whether an integer constant comparison results in a value 462015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian // of 'true' or 'false'. 462115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (T->isIntegralType(S.Context)) { 462215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian llvm::APSInt RHSValue; 462315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsRHSIntegralLiteral = 462415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian RHS->isIntegerConstantExpr(RHSValue, S.Context); 462515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian llvm::APSInt LHSValue; 462615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsLHSIntegralLiteral = 462715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian LHS->isIntegerConstantExpr(LHSValue, S.Context); 462815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (IsRHSIntegralLiteral && !IsLHSIntegralLiteral) 462915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian DiagnoseOutOfRangeComparison(S, E, RHS, LHS, RHSValue, true); 463015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else if (!IsRHSIntegralLiteral && IsLHSIntegralLiteral) 463115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian DiagnoseOutOfRangeComparison(S, E, LHS, RHS, LHSValue, false); 463215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else 463315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian IsComparisonConstant = 463415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian (IsRHSIntegralLiteral && IsLHSIntegralLiteral); 4635a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian } else if (!T->hasUnsignedIntegerRepresentation()) 4636a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian IsComparisonConstant = E->isIntegerConstantExpr(S.Context); 463715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4638323ed74658bc8375278eabf074b4777458376540John McCall // We don't do anything special if this isn't an unsigned integral 4639323ed74658bc8375278eabf074b4777458376540John McCall // comparison: we're only interested in integral comparisons, and 4640323ed74658bc8375278eabf074b4777458376540John McCall // signed comparisons only happen in cases we don't care to warn about. 46413e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // 46423e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // We also don't care about value-dependent expressions or expressions 46433e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // whose result is a constant. 464415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (!T->hasUnsignedIntegerRepresentation() || IsComparisonConstant) 4645323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 464615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4647323ed74658bc8375278eabf074b4777458376540John McCall // Check to see if one of the (unmodified) operands is of different 4648323ed74658bc8375278eabf074b4777458376540John McCall // signedness. 4649323ed74658bc8375278eabf074b4777458376540John McCall Expr *signedOperand, *unsignedOperand; 4650dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu if (LHS->getType()->hasSignedIntegerRepresentation()) { 4651dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu assert(!RHS->getType()->hasSignedIntegerRepresentation() && 4652323ed74658bc8375278eabf074b4777458376540John McCall "unsigned comparison between two signed integer expressions?"); 4653dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = LHS; 4654dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = RHS; 4655dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu } else if (RHS->getType()->hasSignedIntegerRepresentation()) { 4656dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = RHS; 4657dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = LHS; 4658ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } else { 4659323ed74658bc8375278eabf074b4777458376540John McCall CheckTrivialUnsignedComparison(S, E); 4660323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 4661ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } 4662ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4663323ed74658bc8375278eabf074b4777458376540John McCall // Otherwise, calculate the effective range of the signed operand. 4664323ed74658bc8375278eabf074b4777458376540John McCall IntRange signedRange = GetExprRange(S.Context, signedOperand); 4665f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4666323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and analyze implicit conversions in the operands. Note 4667323ed74658bc8375278eabf074b4777458376540John McCall // that we skip the implicit conversions on both sides. 4668dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc()); 4669dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc()); 4670ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4671323ed74658bc8375278eabf074b4777458376540John McCall // If the signed range is non-negative, -Wsign-compare won't fire, 4672323ed74658bc8375278eabf074b4777458376540John McCall // but we should still check for comparisons which are always true 4673323ed74658bc8375278eabf074b4777458376540John McCall // or false. 4674323ed74658bc8375278eabf074b4777458376540John McCall if (signedRange.NonNegative) 4675323ed74658bc8375278eabf074b4777458376540John McCall return CheckTrivialUnsignedComparison(S, E); 4676ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4677ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // For (in)equality comparisons, if the unsigned operand is a 4678ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // constant which cannot collide with a overflowed signed operand, 4679ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // then reinterpreting the signed operand as unsigned will not 4680ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // change the result of the comparison. 4681323ed74658bc8375278eabf074b4777458376540John McCall if (E->isEqualityOp()) { 4682323ed74658bc8375278eabf074b4777458376540John McCall unsigned comparisonWidth = S.Context.getIntWidth(T); 4683323ed74658bc8375278eabf074b4777458376540John McCall IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 4684323ed74658bc8375278eabf074b4777458376540John McCall 4685323ed74658bc8375278eabf074b4777458376540John McCall // We should never be unable to prove that the unsigned operand is 4686323ed74658bc8375278eabf074b4777458376540John McCall // non-negative. 4687323ed74658bc8375278eabf074b4777458376540John McCall assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 4688ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4689323ed74658bc8375278eabf074b4777458376540John McCall if (unsignedRange.Width < comparisonWidth) 4690323ed74658bc8375278eabf074b4777458376540John McCall return; 4691323ed74658bc8375278eabf074b4777458376540John McCall } 4692323ed74658bc8375278eabf074b4777458376540John McCall 46936d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor S.DiagRuntimeBehavior(E->getOperatorLoc(), E, 46946d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor S.PDiag(diag::warn_mixed_sign_comparison) 46956d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor << LHS->getType() << RHS->getType() 46966d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor << LHS->getSourceRange() << RHS->getSourceRange()); 4697ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall} 4698ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 469915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield. 470015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// 470115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt. 47020692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 47030692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek SourceLocation InitLoc) { 470415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall assert(Bitfield->isBitField()); 470515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Bitfield->isInvalidDecl()) 470615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 470715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 470891b6014876e9186f968f74a8975ab8fc08ef1b68John McCall // White-list bool bitfields. 470991b6014876e9186f968f74a8975ab8fc08ef1b68John McCall if (Bitfield->getType()->isBooleanType()) 471091b6014876e9186f968f74a8975ab8fc08ef1b68John McCall return false; 471191b6014876e9186f968f74a8975ab8fc08ef1b68John McCall 471246ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor // Ignore value- or type-dependent expressions. 471346ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor if (Bitfield->getBitWidth()->isValueDependent() || 471446ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Bitfield->getBitWidth()->isTypeDependent() || 471546ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isValueDependent() || 471646ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isTypeDependent()) 471746ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor return false; 471846ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor 471915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *OriginalInit = Init->IgnoreParenImpCasts(); 472015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 472180d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith llvm::APSInt Value; 472280d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith if (!OriginalInit->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects)) 472315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 472415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 472515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned OriginalWidth = Value.getBitWidth(); 4726a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context); 472715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 472815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (OriginalWidth <= FieldWidth) 472915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 473015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 47313a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Compute the value which the bitfield will contain. 47329f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad llvm::APSInt TruncatedValue = Value.trunc(FieldWidth); 47333a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman TruncatedValue.setIsSigned(Bitfield->getType()->isSignedIntegerType()); 473415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 47353a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Check whether the stored value is equal to the original value. 47363a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman TruncatedValue = TruncatedValue.extend(OriginalWidth); 4737e1ecdc168175719d74e112bcacd4aae5e12d4631Richard Trieu if (llvm::APSInt::isSameValue(Value, TruncatedValue)) 473815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 473915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 47403a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Special-case bitfields of width 1: booleans are naturally 0/1, and 474134ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman // therefore don't strictly fit into a signed bitfield of width 1. 474234ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman if (FieldWidth == 1 && Value == 1) 47433a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman return false; 47443a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman 474515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyValue = Value.toString(10); 474615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyTrunc = TruncatedValue.toString(10); 474715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 474815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 474915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << PrettyValue << PrettyTrunc << OriginalInit->getType() 475015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << Init->getSourceRange(); 475115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 475215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return true; 475315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 475415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 4755beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy 4756beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations. 47570692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeAssignment(Sema &S, BinaryOperator *E) { 4758beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Just recurse on the LHS. 4759beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 4760beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 4761beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // We want to recurse on the RHS as normal unless we're assigning to 4762beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // a bitfield. 4763993f43f24d7a45a5cd4678a3316b0852261fc5d4John McCall if (FieldDecl *Bitfield = E->getLHS()->getSourceBitField()) { 4764dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 476515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc())) { 476615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // Recurse, ignoring any implicit conversions on the RHS. 476715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 476815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc()); 4769beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4770beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4771beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 4772beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 4773beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall} 4774beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 477551313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 47760692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T, 4777c36bedc90c687caa71748480c60707ea4608b092Anna Zaks SourceLocation CContext, unsigned diag, 4778c36bedc90c687caa71748480c60707ea4608b092Anna Zaks bool pruneControlFlow = false) { 4779c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (pruneControlFlow) { 4780c36bedc90c687caa71748480c60707ea4608b092Anna Zaks S.DiagRuntimeBehavior(E->getExprLoc(), E, 4781c36bedc90c687caa71748480c60707ea4608b092Anna Zaks S.PDiag(diag) 4782c36bedc90c687caa71748480c60707ea4608b092Anna Zaks << SourceType << T << E->getSourceRange() 4783c36bedc90c687caa71748480c60707ea4608b092Anna Zaks << SourceRange(CContext)); 4784c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 4785c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 47865a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor S.Diag(E->getExprLoc(), diag) 47875a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor << SourceType << T << E->getSourceRange() << SourceRange(CContext); 47885a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor} 47895a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 4790e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 47910692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType T, 4792c36bedc90c687caa71748480c60707ea4608b092Anna Zaks SourceLocation CContext, unsigned diag, 4793c36bedc90c687caa71748480c60707ea4608b092Anna Zaks bool pruneControlFlow = false) { 4794c36bedc90c687caa71748480c60707ea4608b092Anna Zaks DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow); 4795e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth} 4796e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth 47979ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// Diagnose an implicit cast from a literal expression. Does not warn when the 47989ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// cast wouldn't lose information. 4799f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruthvoid DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T, 4800f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth SourceLocation CContext) { 48019ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay // Try to convert the literal exactly to an integer. If we can, don't warn. 4802f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth bool isExact = false; 48039ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay const llvm::APFloat &Value = FL->getValue(); 48043e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin llvm::APSInt IntegerValue(S.Context.getIntWidth(T), 48053e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin T->hasUnsignedIntegerRepresentation()); 48063e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin if (Value.convertToInteger(IntegerValue, 4807f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth llvm::APFloat::rmTowardZero, &isExact) 48089ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay == llvm::APFloat::opOK && isExact) 4809f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth return; 4810f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 4811be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie SmallString<16> PrettySourceValue; 4812be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie Value.toString(PrettySourceValue); 4813de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie SmallString<16> PrettyTargetValue; 4814be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (T->isSpecificBuiltinType(BuiltinType::Bool)) 4815be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie PrettyTargetValue = IntegerValue == 0 ? "false" : "true"; 4816be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie else 4817de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie IntegerValue.toString(PrettyTargetValue); 4818be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie 48199ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer) 4820be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie << FL->getType() << T.getUnqualifiedType() << PrettySourceValue 4821be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie << PrettyTargetValue << FL->getSourceRange() << SourceRange(CContext); 4822f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth} 4823f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 4824091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 4825091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Range.Width) return "0"; 4826091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 4827091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt ValueInRange = Value; 4828091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.setIsSigned(!Range.NonNegative); 48299f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad ValueInRange = ValueInRange.trunc(Range.Width); 4830091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return ValueInRange.toString(10); 4831091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall} 4832091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 483388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgstatic bool IsImplicitBoolFloatConversion(Sema &S, Expr *Ex, bool ToBool) { 483488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (!isa<ImplicitCastExpr>(Ex)) 483588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return false; 483688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 483788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *InnerE = Ex->IgnoreParenImpCasts(); 483888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *Target = S.Context.getCanonicalType(Ex->getType()).getTypePtr(); 483988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *Source = 484088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg S.Context.getCanonicalType(InnerE->getType()).getTypePtr(); 484188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (Target->isDependentType()) 484288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return false; 484388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 484488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const BuiltinType *FloatCandidateBT = 484588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg dyn_cast<BuiltinType>(ToBool ? Source : Target); 484688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *BoolCandidateType = ToBool ? Target : Source; 484788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 484888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return (BoolCandidateType->isSpecificBuiltinType(BuiltinType::Bool) && 484988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg FloatCandidateBT && (FloatCandidateBT->isFloatingPoint())); 485088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg} 485188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 485288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgvoid CheckImplicitArgumentConversions(Sema &S, CallExpr *TheCall, 485388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg SourceLocation CC) { 485488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg unsigned NumArgs = TheCall->getNumArgs(); 485588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg for (unsigned i = 0; i < NumArgs; ++i) { 485688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *CurrA = TheCall->getArg(i); 485788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (!IsImplicitBoolFloatConversion(S, CurrA, true)) 485888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg continue; 485988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 486088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg bool IsSwapped = ((i > 0) && 486188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsImplicitBoolFloatConversion(S, TheCall->getArg(i - 1), false)); 486288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsSwapped |= ((i < (NumArgs - 1)) && 486388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsImplicitBoolFloatConversion(S, TheCall->getArg(i + 1), false)); 486488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (IsSwapped) { 486588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Warn on this floating-point to bool conversion. 486688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg DiagnoseImpCast(S, CurrA->IgnoreParenImpCasts(), 486788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CurrA->getType(), CC, 486888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg diag::warn_impcast_floating_point_to_bool); 486988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 487088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 487188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg} 487288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 4873323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T, 4874dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov SourceLocation CC, bool *ICContext = 0) { 4875323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) return; 487651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4877323ed74658bc8375278eabf074b4777458376540John McCall const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 4878323ed74658bc8375278eabf074b4777458376540John McCall const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 4879323ed74658bc8375278eabf074b4777458376540John McCall if (Source == Target) return; 4880323ed74658bc8375278eabf074b4777458376540John McCall if (Target->isDependentType()) return; 488151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4882108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // If the conversion context location is invalid don't complain. We also 4883108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // don't want to emit a warning if the issue occurs from the expansion of 4884108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // a system macro. The problem is that 'getSpellingLoc()' is slow, so we 4885108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // delay this check as long as possible. Once we detect we are in that 4886108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // scenario, we just return. 4887ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (CC.isInvalid()) 4888b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return; 4889b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 4890f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Diagnose implicit casts to bool. 4891f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (Target->isSpecificBuiltinType(BuiltinType::Bool)) { 4892f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (isa<StringLiteral>(E)) 4893f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Warn on string literal to bool. Checks for string literals in logical 4894f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // expressions, for instances, assert(0 && "error here"), is prevented 4895f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // by a check in AnalyzeImplicitConversions(). 4896f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu return DiagnoseImpCast(S, E, T, CC, 4897f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu diag::warn_impcast_string_literal_to_bool); 4898e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (Source->isFunctionType()) { 4899e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // Warn on function to bool. Checks free functions and static member 4900e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // functions. Weakly imported functions are excluded from the check, 4901e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // since it's common to test their value to check whether the linker 4902e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // found a definition for them. 4903e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames ValueDecl *D = 0; 4904e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (DeclRefExpr* R = dyn_cast<DeclRefExpr>(E)) { 4905e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = R->getDecl(); 4906e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) { 4907e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = M->getMemberDecl(); 4908e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 4909e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames 4910e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (D && !D->isWeak()) { 491126b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu if (FunctionDecl* F = dyn_cast<FunctionDecl>(D)) { 491226b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu S.Diag(E->getExprLoc(), diag::warn_impcast_function_to_bool) 491326b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu << F << E->getSourceRange() << SourceRange(CC); 49142def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_silence) 49152def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion(E->getExprLoc(), "&"); 49162def77399ab3088106a2d61372344f5b7104e1a2David Blaikie QualType ReturnType; 49172def77399ab3088106a2d61372344f5b7104e1a2David Blaikie UnresolvedSet<4> NonTemplateOverloads; 4918c8fa525b5b81eeb7a62294dd3218ca2a6ccf0a6aDavid Blaikie S.tryExprAsCall(*E, ReturnType, NonTemplateOverloads); 49192def77399ab3088106a2d61372344f5b7104e1a2David Blaikie if (!ReturnType.isNull() 49202def77399ab3088106a2d61372344f5b7104e1a2David Blaikie && ReturnType->isSpecificBuiltinType(BuiltinType::Bool)) 49212def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_call) 49222def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion( 49232def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()), "()"); 492426b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu return; 492526b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu } 4926e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 4927e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 4928f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 492951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 493051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip vector types. 493151313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<VectorType>(Source)) { 4932ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<VectorType>(Target)) { 4933d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4934ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4935b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 4936ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 4937b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner 4938b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // If the vector cast is cast between two vectors of the same size, it is 4939b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // a bitcast, not a conversion. 4940b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target)) 4941b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner return; 494251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 494351313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 494451313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 494551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 494651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 494751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip complex types. 494851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<ComplexType>(Source)) { 4949ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<ComplexType>(Target)) { 4950d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4951ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4952ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4953b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 4954ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 495551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 495651313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 495751313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 495851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 495951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 496051313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 496151313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 496251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 496351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the source is floating point... 496451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT && SourceBT->isFloatingPoint()) { 496551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...and the target is floating point... 496651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (TargetBT && TargetBT->isFloatingPoint()) { 496751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...then warn if we're dropping FP rank. 496851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 496951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Builtin FP kinds are ordered by increasing FP rank. 497051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT->getKind() > TargetBT->getKind()) { 497151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Don't warn about float constants that are precisely 497251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // representable in the target type. 497351313c39c84407dd6a323be99a8c322bf8d052a9John McCall Expr::EvalResult result; 497451f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, S.Context)) { 497551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Value might be a float, a float vector, or a float complex. 497651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (IsSameFloatAfterCast(result.Val, 4977323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 4978323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 497951313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 498051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 498151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4982d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4983ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4984ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4985b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 498651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 498751313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 498851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 498951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4990ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // If the target is integral, always warn. 4991be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (TargetBT && TargetBT->isInteger()) { 4992d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4993ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4994ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4995a5b9332418f25338f118358e27303cd510d54107Chandler Carruth Expr *InnerE = E->IgnoreParenImpCasts(); 4996634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay // We also want to warn on, e.g., "int i = -1.234" 4997634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE)) 4998634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus) 4999634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay InnerE = UOp->getSubExpr()->IgnoreParenImpCasts(); 5000634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay 5001f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) { 5002f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth DiagnoseFloatingLiteralImpCast(S, FL, T, CC); 5003a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } else { 5004a5b9332418f25338f118358e27303cd510d54107Chandler Carruth DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 5005a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 5006a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 500751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 500888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // If the target is bool, warn if expr is a function or method call. 500988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (Target->isSpecificBuiltinType(BuiltinType::Bool) && 501088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg isa<CallExpr>(E)) { 501188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Check last argument of function call to see if it is an 501288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // implicit cast from a type matching the type the result 501388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // is being cast to. 501488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CallExpr *CEx = cast<CallExpr>(E); 501588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg unsigned NumArgs = CEx->getNumArgs(); 501688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (NumArgs > 0) { 501788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *LastA = CEx->getArg(NumArgs - 1); 501888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *InnerE = LastA->IgnoreParenImpCasts(); 501988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *InnerType = 502088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg S.Context.getCanonicalType(InnerE->getType()).getTypePtr(); 502188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (isa<ImplicitCastExpr>(LastA) && (InnerType == Target)) { 502288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Warn on this floating-point to bool conversion 502388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg DiagnoseImpCast(S, E, T, CC, 502488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg diag::warn_impcast_floating_point_to_bool); 502588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 502688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 502788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 502851313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 502951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 503051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 50311838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull) 5032b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie == Expr::NPCK_GNUNull) && !Target->isAnyPointerType() 5033e81b43bc306d361fcf4d411aeb14b43f8464bf4aDavid Blaikie && !Target->isBlockPointerType() && !Target->isMemberPointerType() 5034896c7dd62801c0aacf14b05183c3c471c1fe9f7aDavid Blaikie && Target->isScalarType() && !Target->isNullPtrType()) { 5035b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie SourceLocation Loc = E->getSourceRange().getBegin(); 5036b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie if (Loc.isMacroID()) 5037b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie Loc = S.SourceMgr.getImmediateExpansionRange(Loc).first; 50389fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie if (!Loc.isMacroID() || CC.isMacroID()) 50399fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie S.Diag(Loc, diag::warn_impcast_null_pointer_to_integer) 50409fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie << T << clang::SourceRange(CC) 50419fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie << FixItHint::CreateReplacement(Loc, S.getFixItZeroLiteralForType(T)); 50421838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu } 50431838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu 5044b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie if (!Source->isIntegerType() || !Target->isIntegerType()) 5045b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie return; 5046b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie 5047be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie // TODO: remove this early return once the false positives for constant->bool 5048be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie // in templates, macros, etc, are reduced or removed. 5049be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (Target->isSpecificBuiltinType(BuiltinType::Bool)) 5050be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie return; 5051be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie 5052323ed74658bc8375278eabf074b4777458376540John McCall IntRange SourceRange = GetExprRange(S.Context, E); 50531844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 505451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 5055dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (SourceRange.Width > TargetRange.Width) { 505625ffbef84450f0c666957a2d00cdf928c61b44d7Sam Panzer // If the source is a constant, use a default-on diagnostic. 5057dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov // TODO: this should happen for bitfield stores, too. 5058dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov llvm::APSInt Value(32); 5059dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (E->isIntegerConstantExpr(Value, S.Context)) { 5060dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (S.SourceMgr.isInSystemMacro(CC)) 5061dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov return; 5062dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov 5063091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettySourceValue = Value.toString(10); 5064091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 5065dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov 50665e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.DiagRuntimeBehavior(E->getExprLoc(), E, 50675e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.PDiag(diag::warn_impcast_integer_precision_constant) 50685e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << PrettySourceValue << PrettyTargetValue 50695e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << E->getType() << T << E->getSourceRange() 50705e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << clang::SourceRange(CC)); 5071091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return; 5072091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall } 5073091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 5074dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov // People want to build with -Wshorten-64-to-32 and not -Wconversion. 5075dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (S.SourceMgr.isInSystemMacro(CC)) 5076dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov return; 5077dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov 507837050841d7b852497b85d5275d9ea92c07ddf059David Blaikie if (TargetRange.Width == 32 && S.Context.getIntWidth(E->getType()) == 64) 5079c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32, 5080c36bedc90c687caa71748480c60707ea4608b092Anna Zaks /* pruneControlFlow */ true); 5081b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 5082323ed74658bc8375278eabf074b4777458376540John McCall } 5083323ed74658bc8375278eabf074b4777458376540John McCall 5084323ed74658bc8375278eabf074b4777458376540John McCall if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 5085323ed74658bc8375278eabf074b4777458376540John McCall (!TargetRange.NonNegative && SourceRange.NonNegative && 5086323ed74658bc8375278eabf074b4777458376540John McCall SourceRange.Width == TargetRange.Width)) { 5087ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 5088d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 5089ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 5090ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 5091323ed74658bc8375278eabf074b4777458376540John McCall unsigned DiagID = diag::warn_impcast_integer_sign; 5092323ed74658bc8375278eabf074b4777458376540John McCall 5093323ed74658bc8375278eabf074b4777458376540John McCall // Traditionally, gcc has warned about this under -Wsign-compare. 5094323ed74658bc8375278eabf074b4777458376540John McCall // We also want to warn about it in -Wconversion. 5095323ed74658bc8375278eabf074b4777458376540John McCall // So if -Wconversion is off, use a completely identical diagnostic 5096323ed74658bc8375278eabf074b4777458376540John McCall // in the sign-compare group. 5097323ed74658bc8375278eabf074b4777458376540John McCall // The conditional-checking code will 5098323ed74658bc8375278eabf074b4777458376540John McCall if (ICContext) { 5099323ed74658bc8375278eabf074b4777458376540John McCall DiagID = diag::warn_impcast_integer_sign_conditional; 5100323ed74658bc8375278eabf074b4777458376540John McCall *ICContext = true; 5101323ed74658bc8375278eabf074b4777458376540John McCall } 5102323ed74658bc8375278eabf074b4777458376540John McCall 5103b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, DiagID); 510451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 510551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 5106284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor // Diagnose conversions between different enumeration types. 51075a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // In C, we pretend that the type of an EnumConstantDecl is its enumeration 51085a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // type, to give us better diagnostics. 51095a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor QualType SourceType = E->getType(); 51104e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (!S.getLangOpts().CPlusPlus) { 51115a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 51125a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) { 51135a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext()); 51145a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceType = S.Context.getTypeDeclType(Enum); 51155a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor Source = S.Context.getCanonicalType(SourceType).getTypePtr(); 51165a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 51175a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 51185a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 5119284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *SourceEnum = Source->getAs<EnumType>()) 5120284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *TargetEnum = Target->getAs<EnumType>()) 512183972f128e9218c051692bf96361327a701aeb79John McCall if (SourceEnum->getDecl()->hasNameForLinkage() && 512283972f128e9218c051692bf96361327a701aeb79John McCall TargetEnum->getDecl()->hasNameForLinkage() && 5123ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceEnum != TargetEnum) { 5124d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 5125ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 5126ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 51275a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor return DiagnoseImpCast(S, E, SourceType, T, CC, 5128284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor diag::warn_impcast_different_enum_types); 5129ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 5130284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor 513151313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 513251313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 513351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 51349fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, 51359fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie SourceLocation CC, QualType T); 5136323ed74658bc8375278eabf074b4777458376540John McCall 5137323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T, 5138b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool &ICContext) { 5139323ed74658bc8375278eabf074b4777458376540John McCall E = E->IgnoreParenImpCasts(); 5140323ed74658bc8375278eabf074b4777458376540John McCall 5141323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) 51429fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie return CheckConditionalOperator(S, cast<ConditionalOperator>(E), CC, T); 5143323ed74658bc8375278eabf074b4777458376540John McCall 5144b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E, CC); 5145323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 5146b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return CheckImplicitConversion(S, E, T, CC, &ICContext); 5147323ed74658bc8375278eabf074b4777458376540John McCall return; 5148323ed74658bc8375278eabf074b4777458376540John McCall} 5149323ed74658bc8375278eabf074b4777458376540John McCall 51509fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, 51519fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie SourceLocation CC, QualType T) { 5152b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getCond(), CC); 5153323ed74658bc8375278eabf074b4777458376540John McCall 5154323ed74658bc8375278eabf074b4777458376540John McCall bool Suspicious = false; 5155b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 5156b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 5157323ed74658bc8375278eabf074b4777458376540John McCall 5158323ed74658bc8375278eabf074b4777458376540John McCall // If -Wconversion would have warned about either of the candidates 5159323ed74658bc8375278eabf074b4777458376540John McCall // for a signedness conversion to the context type... 5160323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) return; 5161323ed74658bc8375278eabf074b4777458376540John McCall 5162323ed74658bc8375278eabf074b4777458376540John McCall // ...but it's currently ignored... 51630827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional, 51640827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis CC)) 5165323ed74658bc8375278eabf074b4777458376540John McCall return; 5166323ed74658bc8375278eabf074b4777458376540John McCall 5167323ed74658bc8375278eabf074b4777458376540John McCall // ...then check whether it would have warned about either of the 5168323ed74658bc8375278eabf074b4777458376540John McCall // candidates for a signedness conversion to the condition type. 51695254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (E->getType() == T) return; 51705254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu 51715254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu Suspicious = false; 51725254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 51735254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu E->getType(), CC, &Suspicious); 51745254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (!Suspicious) 51755254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 5176b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 5177323ed74658bc8375278eabf074b4777458376540John McCall} 5178323ed74658bc8375278eabf074b4777458376540John McCall 5179323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting 5180323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression. There are a couple 5181323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare. 5182b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 5183323ed74658bc8375278eabf074b4777458376540John McCall QualType T = OrigE->getType(); 5184323ed74658bc8375278eabf074b4777458376540John McCall Expr *E = OrigE->IgnoreParenImpCasts(); 5185323ed74658bc8375278eabf074b4777458376540John McCall 5186f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 5187f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor return; 5188f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor 5189323ed74658bc8375278eabf074b4777458376540John McCall // For conditional operators, we analyze the arguments as if they 5190323ed74658bc8375278eabf074b4777458376540John McCall // were being fed directly into the output. 5191323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) { 5192323ed74658bc8375278eabf074b4777458376540John McCall ConditionalOperator *CO = cast<ConditionalOperator>(E); 51939fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie CheckConditionalOperator(S, CO, CC, T); 5194323ed74658bc8375278eabf074b4777458376540John McCall return; 5195323ed74658bc8375278eabf074b4777458376540John McCall } 5196323ed74658bc8375278eabf074b4777458376540John McCall 519788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Check implicit argument conversions for function calls. 519888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (CallExpr *Call = dyn_cast<CallExpr>(E)) 519988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CheckImplicitArgumentConversions(S, Call, CC); 520088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 5201323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and check any implicit conversions we might have skipped. 5202323ed74658bc8375278eabf074b4777458376540John McCall // The non-canonical typecheck is just an optimization; 5203323ed74658bc8375278eabf074b4777458376540John McCall // CheckImplicitConversion will filter out dead implicit conversions. 5204323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 5205b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckImplicitConversion(S, E, T, CC); 5206323ed74658bc8375278eabf074b4777458376540John McCall 5207323ed74658bc8375278eabf074b4777458376540John McCall // Now continue drilling into this expression. 52086f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian 52096f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian if (PseudoObjectExpr * POE = dyn_cast<PseudoObjectExpr>(E)) { 5210a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian if (POE->getResultExpr()) 5211a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian E = POE->getResultExpr(); 52126f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian } 52136f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian 5214a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian if (const OpaqueValueExpr *OVE = dyn_cast<OpaqueValueExpr>(E)) 5215a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian return AnalyzeImplicitConversions(S, OVE->getSourceExpr(), CC); 5216a1bfe1ceeb633fe955bcaf218a101106ad97fc74Fariborz Jahanian 5217323ed74658bc8375278eabf074b4777458376540John McCall // Skip past explicit casts. 5218323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ExplicitCastExpr>(E)) { 5219323ed74658bc8375278eabf074b4777458376540John McCall E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 5220b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return AnalyzeImplicitConversions(S, E, CC); 5221323ed74658bc8375278eabf074b4777458376540John McCall } 5222323ed74658bc8375278eabf074b4777458376540John McCall 5223beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 5224beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Do a somewhat different check with comparison operators. 5225beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isComparisonOp()) 5226beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeComparison(S, BO); 5227beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 5228dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov // And with simple assignments. 5229dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (BO->getOpcode() == BO_Assign) 5230beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeAssignment(S, BO); 5231beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 5232323ed74658bc8375278eabf074b4777458376540John McCall 5233323ed74658bc8375278eabf074b4777458376540John McCall // These break the otherwise-useful invariant below. Fortunately, 5234323ed74658bc8375278eabf074b4777458376540John McCall // we don't really need to recurse into them, because any internal 5235323ed74658bc8375278eabf074b4777458376540John McCall // expressions should have been analyzed already when they were 5236323ed74658bc8375278eabf074b4777458376540John McCall // built into statements. 5237323ed74658bc8375278eabf074b4777458376540John McCall if (isa<StmtExpr>(E)) return; 5238323ed74658bc8375278eabf074b4777458376540John McCall 5239323ed74658bc8375278eabf074b4777458376540John McCall // Don't descend into unevaluated contexts. 5240f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne if (isa<UnaryExprOrTypeTraitExpr>(E)) return; 5241323ed74658bc8375278eabf074b4777458376540John McCall 5242323ed74658bc8375278eabf074b4777458376540John McCall // Now just recurse over the expression's children. 5243b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CC = E->getExprLoc(); 5244f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu BinaryOperator *BO = dyn_cast<BinaryOperator>(E); 5245f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu bool IsLogicalOperator = BO && BO->isLogicalOp(); 5246f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu for (Stmt::child_range I = E->children(); I; ++I) { 524754042f1bd78f1f1ea86be7d4af541462e127d2edDouglas Gregor Expr *ChildExpr = dyn_cast_or_null<Expr>(*I); 5248503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor if (!ChildExpr) 5249503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor continue; 5250503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor 5251f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (IsLogicalOperator && 5252f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts())) 5253f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Ignore checking string literals that are in logical operators. 5254f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu continue; 5255f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu AnalyzeImplicitConversions(S, ChildExpr, CC); 5256f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 5257323ed74658bc8375278eabf074b4777458376540John McCall} 5258323ed74658bc8375278eabf074b4777458376540John McCall 5259323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace 5260323ed74658bc8375278eabf074b4777458376540John McCall 5261323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given 5262323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression). Implements -Wconversion 5263323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare. 5264b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// 5265b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e. 5266b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// the most location of the syntactic entity requiring the implicit 5267b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// conversion 5268b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 5269323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose in unevaluated contexts. 527071f55f771794674a410171dbf3cb5dbedf95d033David Blaikie if (isUnevaluatedContext()) 5271323ed74658bc8375278eabf074b4777458376540John McCall return; 5272323ed74658bc8375278eabf074b4777458376540John McCall 5273323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose for value- or type-dependent expressions. 5274323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) 5275323ed74658bc8375278eabf074b4777458376540John McCall return; 5276323ed74658bc8375278eabf074b4777458376540John McCall 5277d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Check for array bounds violations in cases where the check isn't triggered 5278d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // elsewhere for other Expr types (like BinaryOperators), e.g. when an 5279d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // ArraySubscriptExpr is on the RHS of a variable initialization. 5280d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain CheckArrayAccess(E); 5281d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5282b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // This is not the right CC for (e.g.) a variable initialization. 5283b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(*this, E, CC); 5284323ed74658bc8375278eabf074b4777458376540John McCall} 5285323ed74658bc8375278eabf074b4777458376540John McCall 5286ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian/// Diagnose when expression is an integer constant expression and its evaluation 5287ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian/// results in integer overflow 5288ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanianvoid Sema::CheckForIntOverflow (Expr *E) { 52891fd8d46d222fab7f17b91846e2c50bef640a60a0Fariborz Jahanian if (isa<BinaryOperator>(E->IgnoreParens())) { 5290ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian llvm::SmallVector<PartialDiagnosticAt, 4> Diags; 5291ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian E->EvaluateForOverflow(Context, &Diags); 5292ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian } 5293ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian} 5294ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian 52956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithnamespace { 52966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith/// \brief Visitor for expressions which looks for unsequenced operations on the 52976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith/// same object. 52986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithclass SequenceChecker : public EvaluatedExprVisitor<SequenceChecker> { 52990c0b3909d11de7440d77556089516918b9c04cefRichard Smith typedef EvaluatedExprVisitor<SequenceChecker> Base; 53000c0b3909d11de7440d77556089516918b9c04cefRichard Smith 53016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief A tree of sequenced regions within an expression. Two regions are 53026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// unsequenced if one is an ancestor or a descendent of the other. When we 53036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// finish processing an expression with sequencing, such as a comma 53046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// expression, we fold its tree nodes into its parent, since they are 53056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// unsequenced with respect to nodes we will visit later. 53066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith class SequenceTree { 53076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct Value { 53086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith explicit Value(unsigned Parent) : Parent(Parent), Merged(false) {} 53096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned Parent : 31; 53106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Merged : 1; 53116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 53126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<Value, 8> Values; 53136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith public: 53156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief A region within an expression which may be sequenced with respect 53166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// to some other region. 53176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith class Seq { 53186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith explicit Seq(unsigned N) : Index(N) {} 53196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned Index; 53206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith friend class SequenceTree; 53216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith public: 53226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Seq() : Index(0) {} 53236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 53246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree() { Values.push_back(Value(0)); } 53266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Seq root() const { return Seq(0); } 53276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Create a new sequence of operations, which is an unsequenced 53296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// subset of \p Parent. This sequence of operations is sequenced with 53306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// respect to other children of \p Parent. 53316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Seq allocate(Seq Parent) { 53326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Values.push_back(Value(Parent.Index)); 53336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return Seq(Values.size() - 1); 53346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 53356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Merge a sequence of operations into its parent. 53376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void merge(Seq S) { 53386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Values[S.Index].Merged = true; 53396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 53406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Determine whether two operations are unsequenced. This operation 53426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// is asymmetric: \p Cur should be the more recent sequence, and \p Old 53436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// should have been merged into its parent as appropriate. 53446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool isUnsequenced(Seq Cur, Seq Old) { 53456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned C = representative(Cur.Index); 53466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned Target = representative(Old.Index); 53476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith while (C >= Target) { 53486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (C == Target) 53496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return true; 53506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith C = Values[C].Parent; 53516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 53526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return false; 53536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 53546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith private: 53566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Pick a representative for a sequence. 53576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned representative(unsigned K) { 53586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (Values[K].Merged) 53596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Perform path compression as we go. 53606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return Values[K].Parent = representative(Values[K].Parent); 53616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return K; 53626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 53636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 53646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// An object for which we can track unsequenced uses. 53666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith typedef NamedDecl *Object; 53676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Different flavors of object usage which we track. We only track the 53696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// least-sequenced usage of each kind. 53706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith enum UsageKind { 53716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// A read of an object. Multiple unsequenced reads are OK. 53726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_Use, 53736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// A modification of an object which is sequenced before the value 5374418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith /// computation of the expression, such as ++n in C++. 53756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_ModAsValue, 53766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// A modification of an object which is not sequenced before the value 53776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// computation of the expression, such as n++. 53786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_ModAsSideEffect, 53796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_Count = UK_ModAsSideEffect + 1 53816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 53826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct Usage { 53846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Usage() : Use(0), Seq() {} 53856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *Use; 53866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Seq; 53876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 53886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct UsageInfo { 53906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo() : Diagnosed(false) {} 53916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Usage Uses[UK_Count]; 53926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Have we issued a diagnostic for this variable already? 53936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Diagnosed; 53946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 53956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith typedef llvm::SmallDenseMap<Object, UsageInfo, 16> UsageInfoMap; 53966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Sema &SemaRef; 53986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Sequenced regions within the expression. 53996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree Tree; 54006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Declaration modifications and references which we have seen. 54016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfoMap UsageMap; 54026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// The region we are currently within. 54036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Region; 54046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Filled in with declarations which were modified as a side-effect 54056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// (that is, post-increment operations). 54066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVectorImpl<std::pair<Object, Usage> > *ModAsSideEffect; 54071a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith /// Expressions to check later. We defer checking these to reduce 54081a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith /// stack usage. 54091a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith llvm::SmallVectorImpl<Expr*> &WorkList; 54106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// RAII object wrapping the visitation of a sequenced subexpression of an 54126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// expression. At the end of this process, the side-effects of the evaluation 54136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// become sequenced with respect to the value computation of the result, so 54146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// we downgrade any UK_ModAsSideEffect within the evaluation to 54156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// UK_ModAsValue. 54166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct SequencedSubexpression { 54176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression(SequenceChecker &Self) 54186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith : Self(Self), OldModAsSideEffect(Self.ModAsSideEffect) { 54196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Self.ModAsSideEffect = &ModAsSideEffect; 54206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith ~SequencedSubexpression() { 54226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0, E = ModAsSideEffect.size(); I != E; ++I) { 54236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = Self.UsageMap[ModAsSideEffect[I].first]; 54246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith U.Uses[UK_ModAsSideEffect] = ModAsSideEffect[I].second; 54256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Self.addUsage(U, ModAsSideEffect[I].first, 54266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith ModAsSideEffect[I].second.Use, UK_ModAsValue); 54276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Self.ModAsSideEffect = OldModAsSideEffect; 54296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceChecker &Self; 54326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<std::pair<Object, Usage>, 4> ModAsSideEffect; 54336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVectorImpl<std::pair<Object, Usage> > *OldModAsSideEffect; 54346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 54356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 5436674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith /// RAII object wrapping the visitation of a subexpression which we might 5437674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith /// choose to evaluate as a constant. If any subexpression is evaluated and 5438674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith /// found to be non-constant, this allows us to suppress the evaluation of 5439674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith /// the outer expression. 5440674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith class EvaluationTracker { 5441674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith public: 5442674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker(SequenceChecker &Self) 5443674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith : Self(Self), Prev(Self.EvalTracker), EvalOK(true) { 5444674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith Self.EvalTracker = this; 5445674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith } 5446674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith ~EvaluationTracker() { 5447674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith Self.EvalTracker = Prev; 5448674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (Prev) 5449674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith Prev->EvalOK &= EvalOK; 5450674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith } 5451674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith 5452674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith bool evaluate(const Expr *E, bool &Result) { 5453674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (!EvalOK || E->isValueDependent()) 5454674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith return false; 5455674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvalOK = E->EvaluateAsBooleanCondition(Result, Self.SemaRef.Context); 5456674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith return EvalOK; 5457674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith } 5458674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith 5459674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith private: 5460674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith SequenceChecker &Self; 5461674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker *Prev; 5462674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith bool EvalOK; 5463674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith } *EvalTracker; 5464674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith 54656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Find the object which is produced by the specified expression, 54666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// if any. 54676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object getObject(Expr *E, bool Mod) const { 54686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith E = E->IgnoreParenCasts(); 54696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 54706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (Mod && (UO->getOpcode() == UO_PreInc || UO->getOpcode() == UO_PreDec)) 54716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return getObject(UO->getSubExpr(), Mod); 54726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 54736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (BO->getOpcode() == BO_Comma) 54746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return getObject(BO->getRHS(), Mod); 54756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (Mod && BO->isAssignmentOp()) 54766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return getObject(BO->getLHS(), Mod); 54776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } else if (MemberExpr *ME = dyn_cast<MemberExpr>(E)) { 54786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // FIXME: Check for more interesting cases, like "x.n = ++x.n". 54796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (isa<CXXThisExpr>(ME->getBase()->IgnoreParenCasts())) 54806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return ME->getMemberDecl(); 54816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } else if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 54826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // FIXME: If this is a reference, map through to its value. 54836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return DRE->getDecl(); 54846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return 0; 54856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Note that an object was modified or used by an expression. 54886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void addUsage(UsageInfo &UI, Object O, Expr *Ref, UsageKind UK) { 54896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Usage &U = UI.Uses[UK]; 54906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!U.Use || !Tree.isUnsequenced(Region, U.Seq)) { 54916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (UK == UK_ModAsSideEffect && ModAsSideEffect) 54926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith ModAsSideEffect->push_back(std::make_pair(O, U)); 54936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith U.Use = Ref; 54946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith U.Seq = Region; 54956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Check whether a modification or use conflicts with a prior usage. 54986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void checkUsage(Object O, UsageInfo &UI, Expr *Ref, UsageKind OtherKind, 54996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool IsModMod) { 55006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (UI.Diagnosed) 55016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return; 55026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith const Usage &U = UI.Uses[OtherKind]; 55046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!U.Use || !Tree.isUnsequenced(Region, U.Seq)) 55056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return; 55066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *Mod = U.Use; 55086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *ModOrUse = Ref; 55096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (OtherKind == UK_Use) 55106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith std::swap(Mod, ModOrUse); 55116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SemaRef.Diag(Mod->getExprLoc(), 55136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith IsModMod ? diag::warn_unsequenced_mod_mod 55146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith : diag::warn_unsequenced_mod_use) 55156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith << O << SourceRange(ModOrUse->getExprLoc()); 55166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UI.Diagnosed = true; 55176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePreUse(Object O, Expr *Use) { 55206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 55216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Uses conflict with other modifications. 55226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Use, UK_ModAsValue, false); 55236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePostUse(Object O, Expr *Use) { 55256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 55266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Use, UK_ModAsSideEffect, false); 55276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith addUsage(U, O, Use, UK_Use); 55286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePreMod(Object O, Expr *Mod) { 55316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 55326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Modifications conflict with other modifications and with uses. 55336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Mod, UK_ModAsValue, true); 55346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Mod, UK_Use, false); 55356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePostMod(Object O, Expr *Use, UsageKind UK) { 55376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 55386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Use, UK_ModAsSideEffect, true); 55396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith addUsage(U, O, Use, UK); 55406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithpublic: 55431a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith SequenceChecker(Sema &S, Expr *E, 55441a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith llvm::SmallVectorImpl<Expr*> &WorkList) 55450c0b3909d11de7440d77556089516918b9c04cefRichard Smith : Base(S.Context), SemaRef(S), Region(Tree.root()), 55460c0b3909d11de7440d77556089516918b9c04cefRichard Smith ModAsSideEffect(0), WorkList(WorkList), EvalTracker(0) { 55476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(E); 55486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitStmt(Stmt *S) { 55516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Skip all statements which aren't expressions for now. 55526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitExpr(Expr *E) { 55556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // By default, just recurse to evaluated subexpressions. 55560c0b3909d11de7440d77556089516918b9c04cefRichard Smith Base::VisitStmt(E); 55576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitCastExpr(CastExpr *E) { 55606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = Object(); 55616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (E->getCastKind() == CK_LValueToRValue) 55626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith O = getObject(E->getSubExpr(), false); 55636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (O) 55656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreUse(O, E); 55666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith VisitExpr(E); 55676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (O) 55686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePostUse(O, E); 55696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinComma(BinaryOperator *BO) { 55726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // C++11 [expr.comma]p1: 55736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Every value computation and side effect associated with the left 55746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // expression is sequenced before every value computation and side 55756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // effect associated with the right expression. 55766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq LHS = Tree.allocate(Region); 55776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq RHS = Tree.allocate(Region); 55786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq OldRegion = Region; 55796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith { 55816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression SeqLHS(*this); 55826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = LHS; 55836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 55846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = RHS; 55876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getRHS()); 55886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = OldRegion; 55906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Forget that LHS and RHS are sequenced. They are both unsequenced 55926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // with respect to other stuff. 55936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(LHS); 55946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(RHS); 55956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinAssign(BinaryOperator *BO) { 55986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // The modification is sequenced after the value computation of the LHS 55996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // and RHS, so check it before inspecting the operands and update the 56006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // map afterwards. 56016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = getObject(BO->getLHS(), true); 56026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!O) 56036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(BO); 56046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreMod(O, BO); 56066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // C++11 [expr.ass]p7: 56086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // E1 op= E2 is equivalent to E1 = E1 op E2, except that E1 is evaluated 56096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // only once. 56106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // 56116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Therefore, for a compound assignment operator, O is considered used 56126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // everywhere except within the evaluation of E1 itself. 56136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (isa<CompoundAssignOperator>(BO)) 56146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreUse(O, BO); 56156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 56176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (isa<CompoundAssignOperator>(BO)) 56196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePostUse(O, BO); 56206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getRHS()); 56226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 5623418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // C++11 [expr.ass]p1: 5624418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // the assignment is sequenced [...] before the value computation of the 5625418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // assignment expression. 5626418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // C11 6.5.16/3 has no such rule. 5627418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith notePostMod(O, BO, SemaRef.getLangOpts().CPlusPlus ? UK_ModAsValue 5628418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith : UK_ModAsSideEffect); 56296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitCompoundAssignOperator(CompoundAssignOperator *CAO) { 56316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith VisitBinAssign(CAO); 56326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPreInc(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); } 56356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPreDec(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); } 56366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPreIncDec(UnaryOperator *UO) { 56376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = getObject(UO->getSubExpr(), true); 56386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!O) 56396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(UO); 56406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreMod(O, UO); 56426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(UO->getSubExpr()); 5643418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // C++11 [expr.pre.incr]p1: 5644418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith // the expression ++x is equivalent to x+=1 5645418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith notePostMod(O, UO, SemaRef.getLangOpts().CPlusPlus ? UK_ModAsValue 5646418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith : UK_ModAsSideEffect); 56476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPostInc(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); } 56506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPostDec(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); } 56516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPostIncDec(UnaryOperator *UO) { 56526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = getObject(UO->getSubExpr(), true); 56536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!O) 56546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(UO); 56556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreMod(O, UO); 56576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(UO->getSubExpr()); 56586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePostMod(O, UO, UK_ModAsSideEffect); 56596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Don't visit the RHS of '&&' or '||' if it might not be evaluated. 56626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinLOr(BinaryOperator *BO) { 56636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // The side-effects of the LHS of an '&&' are sequenced before the 56646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // value computation of the RHS, and hence before the value computation 56656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // of the '&&' itself, unless the LHS evaluates to zero. We treat them 56666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // as if they were unconditionally sequenced. 5667674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker Eval(*this); 56686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith { 56696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression Sequenced(*this); 56706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 56716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Result; 5674674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (Eval.evaluate(BO->getLHS(), Result)) { 5675995e4a7530d705147c875b63608532c483c011a8Richard Smith if (!Result) 5676995e4a7530d705147c875b63608532c483c011a8Richard Smith Visit(BO->getRHS()); 5677995e4a7530d705147c875b63608532c483c011a8Richard Smith } else { 5678995e4a7530d705147c875b63608532c483c011a8Richard Smith // Check for unsequenced operations in the RHS, treating it as an 5679995e4a7530d705147c875b63608532c483c011a8Richard Smith // entirely separate evaluation. 5680995e4a7530d705147c875b63608532c483c011a8Richard Smith // 5681995e4a7530d705147c875b63608532c483c011a8Richard Smith // FIXME: If there are operations in the RHS which are unsequenced 5682995e4a7530d705147c875b63608532c483c011a8Richard Smith // with respect to operations outside the RHS, and those operations 5683995e4a7530d705147c875b63608532c483c011a8Richard Smith // are unconditionally evaluated, diagnose them. 56841a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(BO->getRHS()); 5685995e4a7530d705147c875b63608532c483c011a8Richard Smith } 56866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinLAnd(BinaryOperator *BO) { 5688674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker Eval(*this); 56896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith { 56906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression Sequenced(*this); 56916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 56926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Result; 5695674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (Eval.evaluate(BO->getLHS(), Result)) { 5696995e4a7530d705147c875b63608532c483c011a8Richard Smith if (Result) 5697995e4a7530d705147c875b63608532c483c011a8Richard Smith Visit(BO->getRHS()); 5698995e4a7530d705147c875b63608532c483c011a8Richard Smith } else { 56991a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(BO->getRHS()); 5700995e4a7530d705147c875b63608532c483c011a8Richard Smith } 57016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Only visit the condition, unless we can be sure which subexpression will 57046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // be chosen. 57056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitAbstractConditionalOperator(AbstractConditionalOperator *CO) { 5706674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith EvaluationTracker Eval(*this); 5707418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith { 5708418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith SequencedSubexpression Sequenced(*this); 5709418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith Visit(CO->getCond()); 5710418dd3eb3e813235af089b5c88182941f8a03d20Richard Smith } 57116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Result; 5713674700516fb7ef0277fbb2a01f56f0c2fa8e7ce5Richard Smith if (Eval.evaluate(CO->getCond(), Result)) 57146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(Result ? CO->getTrueExpr() : CO->getFalseExpr()); 5715995e4a7530d705147c875b63608532c483c011a8Richard Smith else { 57161a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(CO->getTrueExpr()); 57171a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(CO->getFalseExpr()); 5718995e4a7530d705147c875b63608532c483c011a8Richard Smith } 57196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57210c0b3909d11de7440d77556089516918b9c04cefRichard Smith void VisitCallExpr(CallExpr *CE) { 57220c0b3909d11de7440d77556089516918b9c04cefRichard Smith // C++11 [intro.execution]p15: 57230c0b3909d11de7440d77556089516918b9c04cefRichard Smith // When calling a function [...], every value computation and side effect 57240c0b3909d11de7440d77556089516918b9c04cefRichard Smith // associated with any argument expression, or with the postfix expression 57250c0b3909d11de7440d77556089516918b9c04cefRichard Smith // designating the called function, is sequenced before execution of every 57260c0b3909d11de7440d77556089516918b9c04cefRichard Smith // expression or statement in the body of the function [and thus before 57270c0b3909d11de7440d77556089516918b9c04cefRichard Smith // the value computation of its result]. 57280c0b3909d11de7440d77556089516918b9c04cefRichard Smith SequencedSubexpression Sequenced(*this); 57290c0b3909d11de7440d77556089516918b9c04cefRichard Smith Base::VisitCallExpr(CE); 57300c0b3909d11de7440d77556089516918b9c04cefRichard Smith 57310c0b3909d11de7440d77556089516918b9c04cefRichard Smith // FIXME: CXXNewExpr and CXXDeleteExpr implicitly call functions. 57320c0b3909d11de7440d77556089516918b9c04cefRichard Smith } 57330c0b3909d11de7440d77556089516918b9c04cefRichard Smith 57346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitCXXConstructExpr(CXXConstructExpr *CCE) { 57350c0b3909d11de7440d77556089516918b9c04cefRichard Smith // This is a call, so all subexpressions are sequenced before the result. 57360c0b3909d11de7440d77556089516918b9c04cefRichard Smith SequencedSubexpression Sequenced(*this); 57370c0b3909d11de7440d77556089516918b9c04cefRichard Smith 57386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!CCE->isListInitialization()) 57396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(CCE); 57406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // In C++11, list initializations are sequenced. 57426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<SequenceTree::Seq, 32> Elts; 57436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Parent = Region; 57446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (CXXConstructExpr::arg_iterator I = CCE->arg_begin(), 57456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith E = CCE->arg_end(); 57466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith I != E; ++I) { 57476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Tree.allocate(Parent); 57486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Elts.push_back(Region); 57496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(*I); 57506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Forget that the initializers are sequenced. 57536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Parent; 57546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0; I < Elts.size(); ++I) 57556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(Elts[I]); 57566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitInitListExpr(InitListExpr *ILE) { 57596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!SemaRef.getLangOpts().CPlusPlus11) 57606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(ILE); 57616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // In C++11, list initializations are sequenced. 57636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<SequenceTree::Seq, 32> Elts; 57646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Parent = Region; 57656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0; I < ILE->getNumInits(); ++I) { 57666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *E = ILE->getInit(I); 57676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!E) continue; 57686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Tree.allocate(Parent); 57696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Elts.push_back(Region); 57706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(E); 57716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Forget that the initializers are sequenced. 57746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Parent; 57756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0; I < Elts.size(); ++I) 57766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(Elts[I]); 57776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 57786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith}; 57796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith} 57806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 57816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithvoid Sema::CheckUnsequencedOperations(Expr *E) { 57821a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith llvm::SmallVector<Expr*, 8> WorkList; 57831a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(E); 57841a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith while (!WorkList.empty()) { 57851a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith Expr *Item = WorkList.back(); 57861a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.pop_back(); 57871a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith SequenceChecker(*this, Item, WorkList); 57881a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith } 57896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith} 57906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 5791ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanianvoid Sema::CheckCompletedExpr(Expr *E, SourceLocation CheckLoc, 5792ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian bool IsConstexpr) { 57936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith CheckImplicitConversions(E, CheckLoc); 57946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith CheckUnsequencedOperations(E); 5795ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian if (!IsConstexpr && !E->isValueDependent()) 5796ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian CheckForIntOverflow(E); 57976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith} 57986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 579915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 580015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall FieldDecl *BitField, 580115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *Init) { 580215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 580315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 580415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 5805f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given 5806f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This 5807f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the 5808f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function 5809f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete. 58108c0501c7370d894a735692b92fab62bbb05d86bdReid Klecknerbool Sema::CheckParmsForFunctionDef(ParmVarDecl *const *P, 58118c0501c7370d894a735692b92fab62bbb05d86bdReid Kleckner ParmVarDecl *const *PEnd, 581282aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor bool CheckParameterNames) { 5813f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump bool HasInvalidParm = false; 581482aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor for (; P != PEnd; ++P) { 581582aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor ParmVarDecl *Param = *P; 581682aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor 5817f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.7.5.3p4: the parameters in a parameter type list in a 5818f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // function declarator that is part of a function definition of 5819f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // that function shall not have incomplete type. 5820f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // 5821f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // This is also C++ [dcl.fct]p6. 5822f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump if (!Param->isInvalidDecl() && 5823f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump RequireCompleteType(Param->getLocation(), Param->getType(), 5824d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor diag::err_typecheck_decl_incomplete_type)) { 5825f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Param->setInvalidDecl(); 5826f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump HasInvalidParm = true; 5827f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 5828f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 5829f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.9.1p5: If the declarator includes a parameter type list, the 5830f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // declaration of each parameter shall include an identifier. 583182aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor if (CheckParameterNames && 583282aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor Param->getIdentifier() == 0 && 5833f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !Param->isImplicit() && 58344e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie !getLangOpts().CPlusPlus) 5835f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Diag(Param->getLocation(), diag::err_parameter_name_omitted); 5836d17e340e2d516139931768697bf080f60920ba9dSam Weinig 5837d17e340e2d516139931768697bf080f60920ba9dSam Weinig // C99 6.7.5.3p12: 5838d17e340e2d516139931768697bf080f60920ba9dSam Weinig // If the function declarator is not part of a definition of that 5839d17e340e2d516139931768697bf080f60920ba9dSam Weinig // function, parameters may have incomplete type and may use the [*] 5840d17e340e2d516139931768697bf080f60920ba9dSam Weinig // notation in their sequences of declarator specifiers to specify 5841d17e340e2d516139931768697bf080f60920ba9dSam Weinig // variable length array types. 5842d17e340e2d516139931768697bf080f60920ba9dSam Weinig QualType PType = Param->getOriginalType(); 5843d237d2e6b85a74f31c986dc585fa6c39733b74a2Fariborz Jahanian while (const ArrayType *AT = Context.getAsArrayType(PType)) { 5844d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (AT->getSizeModifier() == ArrayType::Star) { 5845fc09336a5965040736f9bc63a70416003972364eStefanus Du Toit // FIXME: This diagnostic should point the '[*]' if source-location 5846d17e340e2d516139931768697bf080f60920ba9dSam Weinig // information is added for it. 5847d17e340e2d516139931768697bf080f60920ba9dSam Weinig Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 5848d237d2e6b85a74f31c986dc585fa6c39733b74a2Fariborz Jahanian break; 5849d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 5850d237d2e6b85a74f31c986dc585fa6c39733b74a2Fariborz Jahanian PType= AT->getElementType(); 5851d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 58529b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner 58539b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner // MSVC destroys objects passed by value in the callee. Therefore a 58549b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner // function definition which takes such a parameter must be able to call the 58559b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner // object's destructor. 58569b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner if (getLangOpts().CPlusPlus && 58579b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner Context.getTargetInfo().getCXXABI().isArgumentDestroyedByCallee()) { 58589b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner if (const RecordType *RT = Param->getType()->getAs<RecordType>()) 58599b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner FinalizeVarWithDestructor(Param, RT); 58609b60195ad4843c9e2e231673a0dbc0d5c8c6eb2bReid Kleckner } 5861f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 5862f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 5863f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump return HasInvalidParm; 5864f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump} 5865b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5866b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a 5867b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements. 5868b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 5869b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // This is actually a lot of work to potentially be doing on every 5870b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // cast; don't do it if we're ignoring -Wcast_align (as is the default). 58710827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align, 58720827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis TRange.getBegin()) 5873d6471f7c1921c7802804ce3ff6fe9768310f72b9David Blaikie == DiagnosticsEngine::Ignored) 5874b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 5875b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5876b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Ignore dependent types. 5877b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (T->isDependentType() || Op->getType()->isDependentType()) 5878b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 5879b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5880b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the destination be a pointer type. 5881b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *DestPtr = T->getAs<PointerType>(); 5882b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!DestPtr) return; 5883b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5884b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // If the destination has alignment 1, we're done. 5885b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType DestPointee = DestPtr->getPointeeType(); 5886b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestPointee->isIncompleteType()) return; 5887b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 5888b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestAlign.isOne()) return; 5889b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5890b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the source be a pointer type. 5891b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 5892b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!SrcPtr) return; 5893b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType SrcPointee = SrcPtr->getPointeeType(); 5894b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5895b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Whitelist casts from cv void*. We already implicitly 5896b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // whitelisted casts to cv void*, since they have alignment 1. 5897b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Also whitelist casts involving incomplete types, which implicitly 5898b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // includes 'void'. 5899b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcPointee->isIncompleteType()) return; 5900b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5901b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 5902b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcAlign >= DestAlign) return; 5903b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5904b7f4ffe073fa419613946461a2583ba2fcb72280John McCall Diag(TRange.getBegin(), diag::warn_cast_align) 5905b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << Op->getType() << T 5906b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(SrcAlign.getQuantity()) 5907b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(DestAlign.getQuantity()) 5908b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << TRange << Op->getSourceRange(); 5909b7f4ffe073fa419613946461a2583ba2fcb72280John McCall} 5910b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5911d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainstatic const Type* getElementType(const Expr *BaseExpr) { 5912d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* EltType = BaseExpr->getType().getTypePtr(); 5913d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (EltType->isAnyPointerType()) 5914d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getPointeeType().getTypePtr(); 5915d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain else if (EltType->isArrayType()) 5916d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getBaseElementTypeUnsafe(); 5917d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType; 5918d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain} 5919d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5920c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// \brief Check whether this array fits the idiom of a size-one tail padded 5921c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// array member of a struct. 5922c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// 5923c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// We avoid emitting out-of-bounds access warnings for such arrays as they are 5924c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// commonly used to emulate flexible arrays in C89 code. 5925c268434b332bbe57950d977633369bf5822d9554Chandler Carruthstatic bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size, 5926c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const NamedDecl *ND) { 5927c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (Size != 1 || !ND) return false; 5928c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5929c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const FieldDecl *FD = dyn_cast<FieldDecl>(ND); 5930c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!FD) return false; 5931c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5932c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // Don't consider sizes resulting from macro expansions or template argument 5933c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // substitution to form C89 tail-padded arrays. 5934d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan 5935d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan TypeSourceInfo *TInfo = FD->getTypeSourceInfo(); 593600e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek while (TInfo) { 593700e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek TypeLoc TL = TInfo->getTypeLoc(); 593800e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek // Look through typedefs. 593939e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie if (TypedefTypeLoc TTL = TL.getAs<TypedefTypeLoc>()) { 594039e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie const TypedefNameDecl *TDL = TTL.getTypedefNameDecl(); 594100e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek TInfo = TDL->getTypeSourceInfo(); 594200e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek continue; 594300e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek } 594439e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie if (ConstantArrayTypeLoc CTL = TL.getAs<ConstantArrayTypeLoc>()) { 594539e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie const Expr *SizeExpr = dyn_cast<IntegerLiteral>(CTL.getSizeExpr()); 59465e25301c24c92a9b7018cee20e524c4eb7192bf0Chad Rosier if (!SizeExpr || SizeExpr->getExprLoc().isMacroID()) 59475e25301c24c92a9b7018cee20e524c4eb7192bf0Chad Rosier return false; 59485e25301c24c92a9b7018cee20e524c4eb7192bf0Chad Rosier } 594900e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek break; 5950d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan } 5951c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5952c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext()); 5953381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!RD) return false; 5954381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (RD->isUnion()) return false; 5955381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) { 5956381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!CRD->isStandardLayout()) return false; 5957381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay } 5958c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 595922d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer // See if this is the last field decl in the record. 596022d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer const Decl *D = FD; 596122d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer while ((D = D->getNextDeclInContext())) 596222d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer if (isa<FieldDecl>(D)) 596322d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return false; 596422d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return true; 5965c268434b332bbe57950d977633369bf5822d9554Chandler Carruth} 5966c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5967d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainvoid Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr, 596880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const ArraySubscriptExpr *ASE, 596925b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith bool AllowOnePastEnd, bool IndexNegated) { 597092b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman IndexExpr = IndexExpr->IgnoreParenImpCasts(); 597180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (IndexExpr->isValueDependent()) 597280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 5973d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 597480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const Type *EffectiveType = getElementType(BaseExpr); 597580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay BaseExpr = BaseExpr->IgnoreParenCasts(); 59763406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const ConstantArrayType *ArrayTy = 5977d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain Context.getAsConstantArrayType(BaseExpr->getType()); 59783406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (!ArrayTy) 5979a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 598035001ca261f895817916b468379b696d6d45959dChandler Carruth 59813406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth llvm::APSInt index; 598280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!IndexExpr->EvaluateAsInt(index, Context)) 5983a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 598425b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith if (IndexNegated) 598525b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith index = -index; 59868fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek 5987ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth const NamedDecl *ND = NULL; 5988ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 5989ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(DRE->getDecl()); 5990c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 5991ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 5992ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 59939e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek if (index.isUnsigned() || !index.isNegative()) { 599425b3b849e3ad340b04442707038c86980035765bTed Kremenek llvm::APInt size = ArrayTy->getSize(); 599535001ca261f895817916b468379b696d6d45959dChandler Carruth if (!size.isStrictlyPositive()) 599635001ca261f895817916b468379b696d6d45959dChandler Carruth return; 5997d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5998d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* BaseType = getElementType(BaseExpr); 5999de5998f1d7dcecb777257ec932142d65de636eb8Nico Weber if (BaseType != EffectiveType) { 6000d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Make sure we're comparing apples to apples when comparing index to size 6001d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType); 6002d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t array_typesize = Context.getTypeSize(BaseType); 6003d10f4bc5a05ce0cdc1646dbb0f706bb9d3dfc0c5Kaelyn Uhrain // Handle ptrarith_typesize being zero, such as when casting to void* 600418f169770d9d3f826bad8f1359c8c5770c5ab16fKaelyn Uhrain if (!ptrarith_typesize) ptrarith_typesize = 1; 6005d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize != array_typesize) { 6006d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // There's a cast to a different size type involved 6007d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ratio = array_typesize / ptrarith_typesize; 6008d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // TODO: Be smarter about handling cases where array_typesize is not a 6009d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // multiple of ptrarith_typesize 6010d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize * ratio == array_typesize) 6011d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain size *= llvm::APInt(size.getBitWidth(), ratio); 6012d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 6013d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 6014d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 60153406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (size.getBitWidth() > index.getBitWidth()) 601692b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman index = index.zext(size.getBitWidth()); 601725b3b849e3ad340b04442707038c86980035765bTed Kremenek else if (size.getBitWidth() < index.getBitWidth()) 601892b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman size = size.zext(index.getBitWidth()); 601925b3b849e3ad340b04442707038c86980035765bTed Kremenek 6020d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // For array subscripting the index must be less than size, but for pointer 6021d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // arithmetic also allow the index (offset) to be equal to size since 6022d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // computing the next address after the end of the array is legal and 6023d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // commonly done e.g. in C++ iterators and range-based for loops. 602492b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman if (AllowOnePastEnd ? index.ule(size) : index.ult(size)) 6025ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth return; 6026ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 6027ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // Also don't warn for arrays of size 1 which are members of some 6028ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // structure. These are often used to approximate flexible arrays in C89 6029ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // code. 6030d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (IsTailPaddedMemberArray(*this, size, ND)) 60318fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek return; 60323406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth 603380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // Suppress the warning if the subscript expression (as identified by the 603480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // ']' location) and the index expression are both from macro expansions 603580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // within a system header. 603680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) { 603780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation RBracketLoc = SourceMgr.getSpellingLoc( 603880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay ASE->getRBracketLoc()); 603980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isInSystemHeader(RBracketLoc)) { 604080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation IndexLoc = SourceMgr.getSpellingLoc( 604180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay IndexExpr->getLocStart()); 604280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isFromSameFile(RBracketLoc, IndexLoc)) 604380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 604480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 604580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 604680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay 6047d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds; 604880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) 6049d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_array_index_exceeds_bounds; 6050d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 6051d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 6052d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 6053d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << size.toString(10, true) 6054d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << (unsigned)size.getLimitedValue(~0U) 6055d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 60563406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth } else { 6057d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_array_index_precedes_bounds; 605880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!ASE) { 6059d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_ptr_arith_precedes_bounds; 6060d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (index.isNegative()) index = -index; 6061d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 6062d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 6063d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 6064d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 6065d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 6066a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek } 606735001ca261f895817916b468379b696d6d45959dChandler Carruth 6068cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (!ND) { 6069cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay // Try harder to find a NamedDecl to point at in the note. 6070cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay while (const ArraySubscriptExpr *ASE = 6071cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay dyn_cast<ArraySubscriptExpr>(BaseExpr)) 6072cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay BaseExpr = ASE->getBase()->IgnoreParenCasts(); 6073cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 6074cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(DRE->getDecl()); 6075cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 6076cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 6077cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay } 6078cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay 607935001ca261f895817916b468379b696d6d45959dChandler Carruth if (ND) 6080d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(ND->getLocStart(), BaseExpr, 6081d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(diag::note_array_index_out_of_bounds) 6082d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << ND->getDeclName()); 60833aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek} 60843aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek 60853aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) { 6086d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain int AllowOnePastEnd = 0; 6087d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain while (expr) { 6088d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = expr->IgnoreParenImpCasts(); 60893aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek switch (expr->getStmtClass()) { 6090d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::ArraySubscriptExprClass: { 6091d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr); 609280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE, 6093d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd > 0); 60943aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 6095d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 6096d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::UnaryOperatorClass: { 6097d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Only unwrap the * and & unary operators 6098d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const UnaryOperator *UO = cast<UnaryOperator>(expr); 6099d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = UO->getSubExpr(); 6100d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain switch (UO->getOpcode()) { 6101d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_AddrOf: 6102d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd++; 6103d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 6104d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_Deref: 6105d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd--; 6106d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 6107d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain default: 6108d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return; 6109d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 6110d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 6111d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 61123aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek case Stmt::ConditionalOperatorClass: { 61133aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek const ConditionalOperator *cond = cast<ConditionalOperator>(expr); 61143aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *lhs = cond->getLHS()) 61153aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(lhs); 61163aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *rhs = cond->getRHS()) 61173aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(rhs); 61183aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 61193aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 61203aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek default: 61213aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 61223aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 6123f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne } 6124a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek} 6125f85e193739c953358c865005855253af4f68a497John McCall 6126f85e193739c953358c865005855253af4f68a497John McCall//===--- CHECK: Objective-C retain cycles ----------------------------------// 6127f85e193739c953358c865005855253af4f68a497John McCall 6128f85e193739c953358c865005855253af4f68a497John McCallnamespace { 6129f85e193739c953358c865005855253af4f68a497John McCall struct RetainCycleOwner { 6130f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner() : Variable(0), Indirect(false) {} 6131f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 6132f85e193739c953358c865005855253af4f68a497John McCall SourceRange Range; 6133f85e193739c953358c865005855253af4f68a497John McCall SourceLocation Loc; 6134f85e193739c953358c865005855253af4f68a497John McCall bool Indirect; 6135f85e193739c953358c865005855253af4f68a497John McCall 6136f85e193739c953358c865005855253af4f68a497John McCall void setLocsFrom(Expr *e) { 6137f85e193739c953358c865005855253af4f68a497John McCall Loc = e->getExprLoc(); 6138f85e193739c953358c865005855253af4f68a497John McCall Range = e->getSourceRange(); 6139f85e193739c953358c865005855253af4f68a497John McCall } 6140f85e193739c953358c865005855253af4f68a497John McCall }; 6141f85e193739c953358c865005855253af4f68a497John McCall} 6142f85e193739c953358c865005855253af4f68a497John McCall 6143f85e193739c953358c865005855253af4f68a497John McCall/// Consider whether capturing the given variable can possibly lead to 6144f85e193739c953358c865005855253af4f68a497John McCall/// a retain cycle. 6145f85e193739c953358c865005855253af4f68a497John McCallstatic bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) { 6146f3477c13eeaf11b32a41f181398fb5deffd0dd73Sylvestre Ledru // In ARC, it's captured strongly iff the variable has __strong 6147f85e193739c953358c865005855253af4f68a497John McCall // lifetime. In MRR, it's captured strongly if the variable is 6148f85e193739c953358c865005855253af4f68a497John McCall // __block and has an appropriate type. 6149f85e193739c953358c865005855253af4f68a497John McCall if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 6150f85e193739c953358c865005855253af4f68a497John McCall return false; 6151f85e193739c953358c865005855253af4f68a497John McCall 6152f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = var; 6153e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose if (ref) 6154e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose owner.setLocsFrom(ref); 6155f85e193739c953358c865005855253af4f68a497John McCall return true; 6156f85e193739c953358c865005855253af4f68a497John McCall} 6157f85e193739c953358c865005855253af4f68a497John McCall 61586e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanianstatic bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) { 6159f85e193739c953358c865005855253af4f68a497John McCall while (true) { 6160f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParens(); 6161f85e193739c953358c865005855253af4f68a497John McCall if (CastExpr *cast = dyn_cast<CastExpr>(e)) { 6162f85e193739c953358c865005855253af4f68a497John McCall switch (cast->getCastKind()) { 6163f85e193739c953358c865005855253af4f68a497John McCall case CK_BitCast: 6164f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueBitCast: 6165f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueToRValue: 616633e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall case CK_ARCReclaimReturnedObject: 6167f85e193739c953358c865005855253af4f68a497John McCall e = cast->getSubExpr(); 6168f85e193739c953358c865005855253af4f68a497John McCall continue; 6169f85e193739c953358c865005855253af4f68a497John McCall 6170f85e193739c953358c865005855253af4f68a497John McCall default: 6171f85e193739c953358c865005855253af4f68a497John McCall return false; 6172f85e193739c953358c865005855253af4f68a497John McCall } 6173f85e193739c953358c865005855253af4f68a497John McCall } 6174f85e193739c953358c865005855253af4f68a497John McCall 6175f85e193739c953358c865005855253af4f68a497John McCall if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) { 6176f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar = ref->getDecl(); 6177f85e193739c953358c865005855253af4f68a497John McCall if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 6178f85e193739c953358c865005855253af4f68a497John McCall return false; 6179f85e193739c953358c865005855253af4f68a497John McCall 6180f85e193739c953358c865005855253af4f68a497John McCall // Try to find a retain cycle in the base. 61816e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(S, ref->getBase(), owner)) 6182f85e193739c953358c865005855253af4f68a497John McCall return false; 6183f85e193739c953358c865005855253af4f68a497John McCall 6184f85e193739c953358c865005855253af4f68a497John McCall if (ref->isFreeIvar()) owner.setLocsFrom(ref); 6185f85e193739c953358c865005855253af4f68a497John McCall owner.Indirect = true; 6186f85e193739c953358c865005855253af4f68a497John McCall return true; 6187f85e193739c953358c865005855253af4f68a497John McCall } 6188f85e193739c953358c865005855253af4f68a497John McCall 6189f85e193739c953358c865005855253af4f68a497John McCall if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) { 6190f85e193739c953358c865005855253af4f68a497John McCall VarDecl *var = dyn_cast<VarDecl>(ref->getDecl()); 6191f85e193739c953358c865005855253af4f68a497John McCall if (!var) return false; 6192f85e193739c953358c865005855253af4f68a497John McCall return considerVariable(var, ref, owner); 6193f85e193739c953358c865005855253af4f68a497John McCall } 6194f85e193739c953358c865005855253af4f68a497John McCall 6195f85e193739c953358c865005855253af4f68a497John McCall if (MemberExpr *member = dyn_cast<MemberExpr>(e)) { 6196f85e193739c953358c865005855253af4f68a497John McCall if (member->isArrow()) return false; 6197f85e193739c953358c865005855253af4f68a497John McCall 6198f85e193739c953358c865005855253af4f68a497John McCall // Don't count this as an indirect ownership. 6199f85e193739c953358c865005855253af4f68a497John McCall e = member->getBase(); 6200f85e193739c953358c865005855253af4f68a497John McCall continue; 6201f85e193739c953358c865005855253af4f68a497John McCall } 6202f85e193739c953358c865005855253af4f68a497John McCall 62034b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) { 62044b9c2d235fb9449e249d74f48ecfec601650de93John McCall // Only pay attention to pseudo-objects on property references. 62054b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyRefExpr *pre 62064b9c2d235fb9449e249d74f48ecfec601650de93John McCall = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm() 62074b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->IgnoreParens()); 62084b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!pre) return false; 62094b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (pre->isImplicitProperty()) return false; 62104b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyDecl *property = pre->getExplicitProperty(); 62114b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!property->isRetaining() && 62124b9c2d235fb9449e249d74f48ecfec601650de93John McCall !(property->getPropertyIvarDecl() && 62134b9c2d235fb9449e249d74f48ecfec601650de93John McCall property->getPropertyIvarDecl()->getType() 62144b9c2d235fb9449e249d74f48ecfec601650de93John McCall .getObjCLifetime() == Qualifiers::OCL_Strong)) 62154b9c2d235fb9449e249d74f48ecfec601650de93John McCall return false; 62164b9c2d235fb9449e249d74f48ecfec601650de93John McCall 62174b9c2d235fb9449e249d74f48ecfec601650de93John McCall owner.Indirect = true; 62186e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (pre->isSuperReceiver()) { 62196e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Variable = S.getCurMethodDecl()->getSelfDecl(); 62206e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!owner.Variable) 62216e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return false; 62226e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Loc = pre->getLocation(); 62236e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Range = pre->getSourceRange(); 62246e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return true; 62256e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian } 62264b9c2d235fb9449e249d74f48ecfec601650de93John McCall e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase()) 62274b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->getSourceExpr()); 62284b9c2d235fb9449e249d74f48ecfec601650de93John McCall continue; 62294b9c2d235fb9449e249d74f48ecfec601650de93John McCall } 62304b9c2d235fb9449e249d74f48ecfec601650de93John McCall 6231f85e193739c953358c865005855253af4f68a497John McCall // Array ivars? 6232f85e193739c953358c865005855253af4f68a497John McCall 6233f85e193739c953358c865005855253af4f68a497John McCall return false; 6234f85e193739c953358c865005855253af4f68a497John McCall } 6235f85e193739c953358c865005855253af4f68a497John McCall} 6236f85e193739c953358c865005855253af4f68a497John McCall 6237f85e193739c953358c865005855253af4f68a497John McCallnamespace { 6238f85e193739c953358c865005855253af4f68a497John McCall struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> { 6239f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor(ASTContext &Context, VarDecl *variable) 6240f85e193739c953358c865005855253af4f68a497John McCall : EvaluatedExprVisitor<FindCaptureVisitor>(Context), 6241f85e193739c953358c865005855253af4f68a497John McCall Variable(variable), Capturer(0) {} 6242f85e193739c953358c865005855253af4f68a497John McCall 6243f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 6244f85e193739c953358c865005855253af4f68a497John McCall Expr *Capturer; 6245f85e193739c953358c865005855253af4f68a497John McCall 6246f85e193739c953358c865005855253af4f68a497John McCall void VisitDeclRefExpr(DeclRefExpr *ref) { 6247f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 6248f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 6249f85e193739c953358c865005855253af4f68a497John McCall } 6250f85e193739c953358c865005855253af4f68a497John McCall 6251f85e193739c953358c865005855253af4f68a497John McCall void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) { 6252f85e193739c953358c865005855253af4f68a497John McCall if (Capturer) return; 6253f85e193739c953358c865005855253af4f68a497John McCall Visit(ref->getBase()); 6254f85e193739c953358c865005855253af4f68a497John McCall if (Capturer && ref->isFreeIvar()) 6255f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 6256f85e193739c953358c865005855253af4f68a497John McCall } 6257f85e193739c953358c865005855253af4f68a497John McCall 6258f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockExpr(BlockExpr *block) { 6259f85e193739c953358c865005855253af4f68a497John McCall // Look inside nested blocks 6260f85e193739c953358c865005855253af4f68a497John McCall if (block->getBlockDecl()->capturesVariable(Variable)) 6261f85e193739c953358c865005855253af4f68a497John McCall Visit(block->getBlockDecl()->getBody()); 6262f85e193739c953358c865005855253af4f68a497John McCall } 62637e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian 62647e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian void VisitOpaqueValueExpr(OpaqueValueExpr *OVE) { 62657e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian if (Capturer) return; 62667e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian if (OVE->getSourceExpr()) 62677e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian Visit(OVE->getSourceExpr()); 62687e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian } 6269f85e193739c953358c865005855253af4f68a497John McCall }; 6270f85e193739c953358c865005855253af4f68a497John McCall} 6271f85e193739c953358c865005855253af4f68a497John McCall 6272f85e193739c953358c865005855253af4f68a497John McCall/// Check whether the given argument is a block which captures a 6273f85e193739c953358c865005855253af4f68a497John McCall/// variable. 6274f85e193739c953358c865005855253af4f68a497John McCallstatic Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) { 6275f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 6276f85e193739c953358c865005855253af4f68a497John McCall 6277f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParenCasts(); 62781fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose 62791fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose // Look through [^{...} copy] and Block_copy(^{...}). 62801fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (ObjCMessageExpr *ME = dyn_cast<ObjCMessageExpr>(e)) { 62811fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose Selector Cmd = ME->getSelector(); 62821fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (Cmd.isUnarySelector() && Cmd.getNameForSlot(0) == "copy") { 62831fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose e = ME->getInstanceReceiver(); 62841fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (!e) 62851fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose return 0; 62861fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose e = e->IgnoreParenCasts(); 62871fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } 62881fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } else if (CallExpr *CE = dyn_cast<CallExpr>(e)) { 62891fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (CE->getNumArgs() == 1) { 62901fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose FunctionDecl *Fn = dyn_cast_or_null<FunctionDecl>(CE->getCalleeDecl()); 6291d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek if (Fn) { 6292d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek const IdentifierInfo *FnI = Fn->getIdentifier(); 6293d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek if (FnI && FnI->isStr("_Block_copy")) { 6294d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek e = CE->getArg(0)->IgnoreParenCasts(); 6295d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek } 6296d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek } 62971fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } 62981fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } 62991fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose 6300f85e193739c953358c865005855253af4f68a497John McCall BlockExpr *block = dyn_cast<BlockExpr>(e); 6301f85e193739c953358c865005855253af4f68a497John McCall if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable)) 6302f85e193739c953358c865005855253af4f68a497John McCall return 0; 6303f85e193739c953358c865005855253af4f68a497John McCall 6304f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor visitor(S.Context, owner.Variable); 6305f85e193739c953358c865005855253af4f68a497John McCall visitor.Visit(block->getBlockDecl()->getBody()); 6306f85e193739c953358c865005855253af4f68a497John McCall return visitor.Capturer; 6307f85e193739c953358c865005855253af4f68a497John McCall} 6308f85e193739c953358c865005855253af4f68a497John McCall 6309f85e193739c953358c865005855253af4f68a497John McCallstatic void diagnoseRetainCycle(Sema &S, Expr *capturer, 6310f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner &owner) { 6311f85e193739c953358c865005855253af4f68a497John McCall assert(capturer); 6312f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 6313f85e193739c953358c865005855253af4f68a497John McCall 6314f85e193739c953358c865005855253af4f68a497John McCall S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle) 6315f85e193739c953358c865005855253af4f68a497John McCall << owner.Variable << capturer->getSourceRange(); 6316f85e193739c953358c865005855253af4f68a497John McCall S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner) 6317f85e193739c953358c865005855253af4f68a497John McCall << owner.Indirect << owner.Range; 6318f85e193739c953358c865005855253af4f68a497John McCall} 6319f85e193739c953358c865005855253af4f68a497John McCall 6320f85e193739c953358c865005855253af4f68a497John McCall/// Check for a keyword selector that starts with the word 'add' or 6321f85e193739c953358c865005855253af4f68a497John McCall/// 'set'. 6322f85e193739c953358c865005855253af4f68a497John McCallstatic bool isSetterLikeSelector(Selector sel) { 6323f85e193739c953358c865005855253af4f68a497John McCall if (sel.isUnarySelector()) return false; 6324f85e193739c953358c865005855253af4f68a497John McCall 63255f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef str = sel.getNameForSlot(0); 6326f85e193739c953358c865005855253af4f68a497John McCall while (!str.empty() && str.front() == '_') str = str.substr(1); 6327968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (str.startswith("set")) 6328f85e193739c953358c865005855253af4f68a497John McCall str = str.substr(3); 6329968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek else if (str.startswith("add")) { 6330968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek // Specially whitelist 'addOperationWithBlock:'. 6331968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock")) 6332968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek return false; 6333968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek str = str.substr(3); 6334968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek } 6335f85e193739c953358c865005855253af4f68a497John McCall else 6336f85e193739c953358c865005855253af4f68a497John McCall return false; 6337f85e193739c953358c865005855253af4f68a497John McCall 6338f85e193739c953358c865005855253af4f68a497John McCall if (str.empty()) return true; 63393f6f51e28231f65de9c2dd150a2d757b2162cfa3Jordan Rose return !isLowercase(str.front()); 6340f85e193739c953358c865005855253af4f68a497John McCall} 6341f85e193739c953358c865005855253af4f68a497John McCall 6342f85e193739c953358c865005855253af4f68a497John McCall/// Check a message send to see if it's likely to cause a retain cycle. 6343f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(ObjCMessageExpr *msg) { 6344f85e193739c953358c865005855253af4f68a497John McCall // Only check instance methods whose selector looks like a setter. 6345f85e193739c953358c865005855253af4f68a497John McCall if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector())) 6346f85e193739c953358c865005855253af4f68a497John McCall return; 6347f85e193739c953358c865005855253af4f68a497John McCall 6348f85e193739c953358c865005855253af4f68a497John McCall // Try to find a variable that the receiver is strongly owned by. 6349f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 6350f85e193739c953358c865005855253af4f68a497John McCall if (msg->getReceiverKind() == ObjCMessageExpr::Instance) { 63516e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner)) 6352f85e193739c953358c865005855253af4f68a497John McCall return; 6353f85e193739c953358c865005855253af4f68a497John McCall } else { 6354f85e193739c953358c865005855253af4f68a497John McCall assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance); 6355f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = getCurMethodDecl()->getSelfDecl(); 6356f85e193739c953358c865005855253af4f68a497John McCall owner.Loc = msg->getSuperLoc(); 6357f85e193739c953358c865005855253af4f68a497John McCall owner.Range = msg->getSuperLoc(); 6358f85e193739c953358c865005855253af4f68a497John McCall } 6359f85e193739c953358c865005855253af4f68a497John McCall 6360f85e193739c953358c865005855253af4f68a497John McCall // Check whether the receiver is captured by any of the arguments. 6361f85e193739c953358c865005855253af4f68a497John McCall for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i) 6362f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner)) 6363f85e193739c953358c865005855253af4f68a497John McCall return diagnoseRetainCycle(*this, capturer, owner); 6364f85e193739c953358c865005855253af4f68a497John McCall} 6365f85e193739c953358c865005855253af4f68a497John McCall 6366f85e193739c953358c865005855253af4f68a497John McCall/// Check a property assign to see if it's likely to cause a retain cycle. 6367f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(Expr *receiver, Expr *argument) { 6368f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 63696e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, receiver, owner)) 6370f85e193739c953358c865005855253af4f68a497John McCall return; 6371f85e193739c953358c865005855253af4f68a497John McCall 6372f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, argument, owner)) 6373f85e193739c953358c865005855253af4f68a497John McCall diagnoseRetainCycle(*this, capturer, owner); 6374f85e193739c953358c865005855253af4f68a497John McCall} 6375f85e193739c953358c865005855253af4f68a497John McCall 6376e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rosevoid Sema::checkRetainCycles(VarDecl *Var, Expr *Init) { 6377e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose RetainCycleOwner Owner; 6378e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose if (!considerVariable(Var, /*DeclRefExpr=*/0, Owner)) 6379e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose return; 6380e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose 6381e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose // Because we don't have an expression for the variable, we have to set the 6382e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose // location explicitly here. 6383e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose Owner.Loc = Var->getLocation(); 6384e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose Owner.Range = Var->getSourceRange(); 6385e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose 6386e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose if (Expr *Capturer = findCapturingExpr(*this, Init, Owner)) 6387e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose diagnoseRetainCycle(*this, Capturer, Owner); 6388e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose} 6389e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose 63909d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenekstatic bool checkUnsafeAssignLiteral(Sema &S, SourceLocation Loc, 63919d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek Expr *RHS, bool isProperty) { 63929d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek // Check if RHS is an Objective-C object literal, which also can get 63939d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek // immediately zapped in a weak reference. Note that we explicitly 63949d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek // allow ObjCStringLiterals, since those are designed to never really die. 63959d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek RHS = RHS->IgnoreParenImpCasts(); 6396f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek 6397d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek // This enum needs to match with the 'select' in 6398d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek // warn_objc_arc_literal_assign (off-by-1). 6399d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek Sema::ObjCLiteralKind Kind = S.CheckLiteralKind(RHS); 6400d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek if (Kind == Sema::LK_String || Kind == Sema::LK_None) 6401d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek return false; 6402f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek 6403f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek S.Diag(Loc, diag::warn_arc_literal_assign) 6404d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek << (unsigned) Kind 64059d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek << (isProperty ? 0 : 1) 64069d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek << RHS->getSourceRange(); 6407f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek 6408f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek return true; 64099d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek} 64109d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek 6411b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenekstatic bool checkUnsafeAssignObject(Sema &S, SourceLocation Loc, 6412b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek Qualifiers::ObjCLifetime LT, 6413b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek Expr *RHS, bool isProperty) { 6414b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek // Strip off any implicit cast added to get to the one ARC-specific. 6415b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 6416b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek if (cast->getCastKind() == CK_ARCConsumeObject) { 6417b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek S.Diag(Loc, diag::warn_arc_retained_assign) 6418b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek << (LT == Qualifiers::OCL_ExplicitNone) 6419b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek << (isProperty ? 0 : 1) 6420b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek << RHS->getSourceRange(); 6421b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek return true; 6422b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek } 6423b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek RHS = cast->getSubExpr(); 6424b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek } 6425b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek 6426b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek if (LT == Qualifiers::OCL_Weak && 6427b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek checkUnsafeAssignLiteral(S, Loc, RHS, isProperty)) 6428b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek return true; 6429b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek 6430b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek return false; 6431b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek} 6432b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek 6433b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenekbool Sema::checkUnsafeAssigns(SourceLocation Loc, 6434b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek QualType LHS, Expr *RHS) { 6435b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime(); 6436b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6437b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone) 6438b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return false; 6439b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6440b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek if (checkUnsafeAssignObject(*this, Loc, LT, RHS, false)) 6441b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return true; 6442b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6443b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return false; 6444b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek} 6445b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6446921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianvoid Sema::checkUnsafeExprAssigns(SourceLocation Loc, 6447921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Expr *LHS, Expr *RHS) { 644887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian QualType LHSType; 644987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // PropertyRef on LHS type need be directly obtained from 645087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // its declaration as it has a PsuedoType. 645187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian ObjCPropertyRefExpr *PRE 645287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens()); 645387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PRE && !PRE->isImplicitProperty()) { 645487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 645587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PD) 645687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType = PD->getType(); 645787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian } 645887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian 645987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (LHSType.isNull()) 646087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType = LHS->getType(); 64617a2704800943fbb69207e125d28186278712af36Jordan Rose 64627a2704800943fbb69207e125d28186278712af36Jordan Rose Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime(); 64637a2704800943fbb69207e125d28186278712af36Jordan Rose 64647a2704800943fbb69207e125d28186278712af36Jordan Rose if (LT == Qualifiers::OCL_Weak) { 64657a2704800943fbb69207e125d28186278712af36Jordan Rose DiagnosticsEngine::Level Level = 64667a2704800943fbb69207e125d28186278712af36Jordan Rose Diags.getDiagnosticLevel(diag::warn_arc_repeated_use_of_weak, Loc); 64677a2704800943fbb69207e125d28186278712af36Jordan Rose if (Level != DiagnosticsEngine::Ignored) 64687a2704800943fbb69207e125d28186278712af36Jordan Rose getCurFunction()->markSafeWeakUse(LHS); 64697a2704800943fbb69207e125d28186278712af36Jordan Rose } 64707a2704800943fbb69207e125d28186278712af36Jordan Rose 6471921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (checkUnsafeAssigns(Loc, LHSType, RHS)) 6472921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 64737a2704800943fbb69207e125d28186278712af36Jordan Rose 6474921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // FIXME. Check for other life times. 6475921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (LT != Qualifiers::OCL_None) 6476921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6477921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 647887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PRE) { 6479921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (PRE->isImplicitProperty()) 6480921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6481921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 6482921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (!PD) 6483921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6484921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 6485ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned Attributes = PD->getPropertyAttributes(); 6486ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) { 648787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // when 'assign' attribute was not explicitly specified 648887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // by user, ignore it and rely on property type itself 648987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // for lifetime info. 649087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten(); 649187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) && 649287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType->isObjCRetainableType()) 649387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian return; 649487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian 6495921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 649633e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 6497921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Diag(Loc, diag::warn_arc_retained_property_assign) 6498921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian << RHS->getSourceRange(); 6499921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6500921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 6501921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 6502921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 650387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian } 6504ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if (Attributes & ObjCPropertyDecl::OBJC_PR_weak) { 6505b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek if (checkUnsafeAssignObject(*this, Loc, Qualifiers::OCL_Weak, RHS, true)) 6506b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return; 6507bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian } 6508921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 6509921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian} 6510625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6511625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko//===--- CHECK: Empty statement body (-Wempty-body) ---------------------===// 6512625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6513625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkonamespace { 6514625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkobool ShouldDiagnoseEmptyStmtBody(const SourceManager &SourceMgr, 6515625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko SourceLocation StmtLoc, 6516625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *Body) { 6517625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do not warn if the body is a macro that expands to nothing, e.g: 6518625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // 6519625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // #define CALL(x) 6520625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // if (condition) 6521625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // CALL(0); 6522625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // 6523625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (Body->hasLeadingEmptyMacro()) 6524625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6525625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6526625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Get line numbers of statement and body. 6527625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool StmtLineInvalid; 6528625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned StmtLine = SourceMgr.getSpellingLineNumber(StmtLoc, 6529625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &StmtLineInvalid); 6530625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtLineInvalid) 6531625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6532625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6533625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool BodyLineInvalid; 6534625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned BodyLine = SourceMgr.getSpellingLineNumber(Body->getSemiLoc(), 6535625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &BodyLineInvalid); 6536625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyLineInvalid) 6537625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6538625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6539625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Warn if null statement and body are on the same line. 6540625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtLine != BodyLine) 6541625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6542625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6543625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return true; 6544625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 6545625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} // Unnamed namespace 6546625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6547625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyStmtBody(SourceLocation StmtLoc, 6548625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *Body, 6549625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned DiagID) { 6550625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Since this is a syntactic check, don't emit diagnostic for template 6551625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // instantiations, this just adds noise. 6552625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (CurrentInstantiationScope) 6553625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6554625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6555625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // The body should be a null statement. 6556625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *NBody = dyn_cast<NullStmt>(Body); 6557625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!NBody) 6558625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6559625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6560625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do the usual checks. 6561625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 6562625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6563625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6564625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), DiagID); 6565625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 6566625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 6567625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6568625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyLoopBody(const Stmt *S, 6569625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *PossibleBody) { 6570625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko assert(!CurrentInstantiationScope); // Ensured by caller 6571625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6572625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko SourceLocation StmtLoc; 6573625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *Body; 6574625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned DiagID; 6575625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (const ForStmt *FS = dyn_cast<ForStmt>(S)) { 6576625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko StmtLoc = FS->getRParenLoc(); 6577625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Body = FS->getBody(); 6578625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagID = diag::warn_empty_for_body; 6579625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } else if (const WhileStmt *WS = dyn_cast<WhileStmt>(S)) { 6580625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko StmtLoc = WS->getCond()->getSourceRange().getEnd(); 6581625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Body = WS->getBody(); 6582625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagID = diag::warn_empty_while_body; 6583625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } else 6584625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; // Neither `for' nor `while'. 6585625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6586625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // The body should be a null statement. 6587625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *NBody = dyn_cast<NullStmt>(Body); 6588625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!NBody) 6589625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6590625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6591625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Skip expensive checks if diagnostic is disabled. 6592625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (Diags.getDiagnosticLevel(DiagID, NBody->getSemiLoc()) == 6593625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagnosticsEngine::Ignored) 6594625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6595625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6596625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do the usual checks. 6597625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 6598625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6599625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6600625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // `for(...);' and `while(...);' are popular idioms, so in order to keep 6601625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // noise level low, emit diagnostics only if for/while is followed by a 6602625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // CompoundStmt, e.g.: 6603625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // for (int i = 0; i < n; i++); 6604625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // { 6605625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // a(i); 6606625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // } 6607625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // or if for/while is followed by a statement with more indentation 6608625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // than for/while itself: 6609625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // for (int i = 0; i < n; i++); 6610625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // a(i); 6611625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool ProbableTypo = isa<CompoundStmt>(PossibleBody); 6612625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ProbableTypo) { 6613625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool BodyColInvalid; 6614625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned BodyCol = SourceMgr.getPresumedColumnNumber( 6615625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko PossibleBody->getLocStart(), 6616625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &BodyColInvalid); 6617625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyColInvalid) 6618625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6619625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6620625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool StmtColInvalid; 6621625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned StmtCol = SourceMgr.getPresumedColumnNumber( 6622625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko S->getLocStart(), 6623625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &StmtColInvalid); 6624625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtColInvalid) 6625625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6626625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6627625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyCol > StmtCol) 6628625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko ProbableTypo = true; 6629625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } 6630625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6631625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (ProbableTypo) { 6632625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), DiagID); 6633625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 6634625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } 6635625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 66360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- Layout compatibility ----------------------------------------------// 66380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 66400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2); 66420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two enumeration types are layout-compatible. 66440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, EnumDecl *ED1, EnumDecl *ED2) { 66450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [dcl.enum] p8: 66460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Two enumeration types are layout-compatible if they have the same 66470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // underlying type. 66480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return ED1->isComplete() && ED2->isComplete() && 66490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko C.hasSameType(ED1->getIntegerType(), ED2->getIntegerType()); 66500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 66510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two fields are layout-compatible. 66530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, FieldDecl *Field1, FieldDecl *Field2) { 66540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, Field1->getType(), Field2->getType())) 66550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1->isBitField() != Field2->isBitField()) 66580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1->isBitField()) { 66610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Make sure that the bit-fields are the same length. 66620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko unsigned Bits1 = Field1->getBitWidthValue(C); 66630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko unsigned Bits2 = Field2->getBitWidthValue(C); 66640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Bits1 != Bits2) 66660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 66680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 66700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 66710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout structs are layout-compatible. 66730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p17) 66740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleStruct(ASTContext &C, 66750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD1, 66760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD2) { 66770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If both records are C++ classes, check that base classes match. 66780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (const CXXRecordDecl *D1CXX = dyn_cast<CXXRecordDecl>(RD1)) { 66790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If one of records is a CXXRecordDecl we are in C++ mode, 66800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // thus the other one is a CXXRecordDecl, too. 66810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const CXXRecordDecl *D2CXX = cast<CXXRecordDecl>(RD2); 66820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check number of base classes. 66830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (D1CXX->getNumBases() != D2CXX->getNumBases()) 66840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check the base classes. 66870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (CXXRecordDecl::base_class_const_iterator 66880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base1 = D1CXX->bases_begin(), 66890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BaseEnd1 = D1CXX->bases_end(), 66900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base2 = D2CXX->bases_begin(); 66910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base1 != BaseEnd1; 66920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ++Base1, ++Base2) { 66930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, Base1->getType(), Base2->getType())) 66940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 66960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else if (const CXXRecordDecl *D2CXX = dyn_cast<CXXRecordDecl>(RD2)) { 66970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If only RD2 is a C++ class, it should have zero base classes. 66980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (D2CXX->getNumBases() > 0) 66990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check the fields. 67030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl::field_iterator Field2 = RD2->field_begin(), 67040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2End = RD2->field_end(), 67050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1 = RD1->field_begin(), 67060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1End = RD1->field_end(); 67070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for ( ; Field1 != Field1End && Field2 != Field2End; ++Field1, ++Field2) { 67080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, *Field1, *Field2)) 67090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1 != Field1End || Field2 != Field2End) 67120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 67150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 67160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout unions are layout-compatible. 67180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p18) 67190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleUnion(ASTContext &C, 67200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD1, 67210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD2) { 67220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::SmallPtrSet<FieldDecl *, 8> UnmatchedFields; 67230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (RecordDecl::field_iterator Field2 = RD2->field_begin(), 67240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2End = RD2->field_end(); 67250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2 != Field2End; ++Field2) { 67260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko UnmatchedFields.insert(*Field2); 67270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (RecordDecl::field_iterator Field1 = RD1->field_begin(), 67300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1End = RD1->field_end(); 67310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1 != Field1End; ++Field1) { 67320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::SmallPtrSet<FieldDecl *, 8>::iterator 67330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I = UnmatchedFields.begin(), 67340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko E = UnmatchedFields.end(); 67350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for ( ; I != E; ++I) { 67370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (isLayoutCompatible(C, *Field1, *I)) { 67380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool Result = UnmatchedFields.erase(*I); 67390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (void) Result; 67400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko assert(Result); 67410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko break; 67420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I == E) 67450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return UnmatchedFields.empty(); 67490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 67500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, RecordDecl *RD1, RecordDecl *RD2) { 67520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (RD1->isUnion() != RD2->isUnion()) 67530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (RD1->isUnion()) 67560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatibleUnion(C, RD1, RD2); 67570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 67580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatibleStruct(C, RD1, RD2); 67590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 67600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two types are layout-compatible in C++11 sense. 67620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2) { 67630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (T1.isNull() || T2.isNull()) 67640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [basic.types] p11: 67670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If two types T1 and T2 are the same type, then T1 and T2 are 67680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // layout-compatible types. 67690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (C.hasSameType(T1, T2)) 67700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 67710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko T1 = T1.getCanonicalType().getUnqualifiedType(); 67730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko T2 = T2.getCanonicalType().getUnqualifiedType(); 67740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Type::TypeClass TC1 = T1->getTypeClass(); 67760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Type::TypeClass TC2 = T2->getTypeClass(); 67770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TC1 != TC2) 67790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TC1 == Type::Enum) { 67820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatible(C, 67830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<EnumType>(T1)->getDecl(), 67840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<EnumType>(T2)->getDecl()); 67850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else if (TC1 == Type::Record) { 67860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!T1->isStandardLayoutType() || !T2->isStandardLayoutType()) 67870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatible(C, 67900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<RecordType>(T1)->getDecl(), 67910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<RecordType>(T2)->getDecl()); 67920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 67960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 67970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- CHECK: pointer_with_type_tag attribute: datatypes should match ----// 67990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 68010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Given a type tag expression find the type tag itself. 68020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 68030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Type tag expression, as it appears in user's code. 68040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 68050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param VD Declaration of an identifier that appears in a type tag. 68060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 68070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValue Type tag magic value. 68080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool FindTypeTagExpr(const Expr *TypeExpr, const ASTContext &Ctx, 68090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const ValueDecl **VD, uint64_t *MagicValue) { 68100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko while(true) { 68110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeExpr) 68120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = TypeExpr->IgnoreParenImpCasts()->IgnoreParenCasts(); 68150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko switch (TypeExpr->getStmtClass()) { 68170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::UnaryOperatorClass: { 68180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const UnaryOperator *UO = cast<UnaryOperator>(TypeExpr); 68190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (UO->getOpcode() == UO_AddrOf || UO->getOpcode() == UO_Deref) { 68200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = UO->getSubExpr(); 68210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 68220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::DeclRefExprClass: { 68270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const DeclRefExpr *DRE = cast<DeclRefExpr>(TypeExpr); 68280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko *VD = DRE->getDecl(); 68290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 68300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::IntegerLiteralClass: { 68330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IntegerLiteral *IL = cast<IntegerLiteral>(TypeExpr); 68340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::APInt MagicValueAPInt = IL->getValue(); 68350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (MagicValueAPInt.getActiveBits() <= 64) { 68360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko *MagicValue = MagicValueAPInt.getZExtValue(); 68370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 68380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else 68390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::BinaryConditionalOperatorClass: 68430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::ConditionalOperatorClass: { 68440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const AbstractConditionalOperator *ACO = 68450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<AbstractConditionalOperator>(TypeExpr); 68460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool Result; 68470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (ACO->getCond()->EvaluateAsBooleanCondition(Result, Ctx)) { 68480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Result) 68490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = ACO->getTrueExpr(); 68500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 68510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = ACO->getFalseExpr(); 68520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 68530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::BinaryOperatorClass: { 68580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BinaryOperator *BO = cast<BinaryOperator>(TypeExpr); 68590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (BO->getOpcode() == BO_Comma) { 68600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = BO->getRHS(); 68610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 68620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko default: 68670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 68710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Retrieve the C type corresponding to type tag TypeExpr. 68730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 68740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Expression that specifies a type tag. 68750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 68760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValues Registered magic values. 68770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 68780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param FoundWrongKind Set to true if a type tag was found, but of a wrong 68790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// kind. 68800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 68810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeInfo Information about the corresponding C type. 68820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 68830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \returns true if the corresponding C type was found. 68840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool GetMatchingCType( 68850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IdentifierInfo *ArgumentKind, 68860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *TypeExpr, const ASTContext &Ctx, 68870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const llvm::DenseMap<Sema::TypeTagMagicValue, 68880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData> *MagicValues, 68890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool &FoundWrongKind, 68900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData &TypeInfo) { 68910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind = false; 68920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Variable declaration that has type_tag_for_datatype attribute. 68940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const ValueDecl *VD = NULL; 68950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko uint64_t MagicValue; 68970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!FindTypeTagExpr(TypeExpr, Ctx, &VD, &MagicValue)) 68990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (VD) { 69020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (specific_attr_iterator<TypeTagForDatatypeAttr> 69030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I = VD->specific_attr_begin<TypeTagForDatatypeAttr>(), 69040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko E = VD->specific_attr_end<TypeTagForDatatypeAttr>(); 69050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I != E; ++I) { 69060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I->getArgumentKind() != ArgumentKind) { 69070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind = true; 69080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.Type = I->getMatchingCType(); 69110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.LayoutCompatible = I->getLayoutCompatible(); 69120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.MustBeNull = I->getMustBeNull(); 69130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 69140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!MagicValues) 69190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::DenseMap<Sema::TypeTagMagicValue, 69220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData>::const_iterator I = 69230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko MagicValues->find(std::make_pair(ArgumentKind, MagicValue)); 69240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I == MagicValues->end()) 69250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo = I->second; 69280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 69290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 69300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace 69310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::RegisterTypeTagForDatatype(const IdentifierInfo *ArgumentKind, 69330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko uint64_t MagicValue, QualType Type, 69340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool LayoutCompatible, 69350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool MustBeNull) { 69360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeTagForDatatypeMagicValues) 69370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagForDatatypeMagicValues.reset( 69380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko new llvm::DenseMap<TypeTagMagicValue, TypeTagData>); 69390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagMagicValue Magic(ArgumentKind, MagicValue); 69410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (*TypeTagForDatatypeMagicValues)[Magic] = 69420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagData(Type, LayoutCompatible, MustBeNull); 69430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 69440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 69460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool IsSameCharType(QualType T1, QualType T2) { 69470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BuiltinType *BT1 = T1->getAs<BuiltinType>(); 69480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!BT1) 69490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BuiltinType *BT2 = T2->getAs<BuiltinType>(); 69520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!BT2) 69530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 69540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BuiltinType::Kind T1Kind = BT1->getKind(); 69560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BuiltinType::Kind T2Kind = BT2->getKind(); 69570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return (T1Kind == BuiltinType::SChar && T2Kind == BuiltinType::Char_S) || 69590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::UChar && T2Kind == BuiltinType::Char_U) || 69600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::Char_U && T2Kind == BuiltinType::UChar) || 69610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::Char_S && T2Kind == BuiltinType::SChar); 69620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 69630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace 69640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::CheckArgumentWithTypeTag(const ArgumentWithTypeTagAttr *Attr, 69660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr * const *ExprArgs) { 69670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IdentifierInfo *ArgumentKind = Attr->getArgumentKind(); 69680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool IsPointerAttr = Attr->getIsPointer(); 69690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *TypeTagExpr = ExprArgs[Attr->getTypeTagIdx()]; 69710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool FoundWrongKind; 69720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagData TypeInfo; 69730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!GetMatchingCType(ArgumentKind, TypeTagExpr, Context, 69740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagForDatatypeMagicValues.get(), 69750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind, TypeInfo)) { 69760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (FoundWrongKind) 69770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(TypeTagExpr->getExprLoc(), 69780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko diag::warn_type_tag_for_datatype_wrong_kind) 69790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 69800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 69810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *ArgumentExpr = ExprArgs[Attr->getArgumentIdx()]; 69840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) { 69850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Skip implicit cast of pointer to `void *' (as a function argument). 69860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(ArgumentExpr)) 69875a24980d059cd9fbe8375a4c549313101ad20698Dmitri Gribenko if (ICE->getType()->isVoidPointerType() && 6988b57ce4e8918656f5f4070f59d74354fcefbbb6f8Dmitri Gribenko ICE->getCastKind() == CK_BitCast) 69890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ArgumentExpr = ICE->getSubExpr(); 69900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 69910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko QualType ArgumentType = ArgumentExpr->getType(); 69920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Passing a `void*' pointer shouldn't trigger a warning. 69940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr && ArgumentType->isVoidPointerType()) 69950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 69960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 69970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TypeInfo.MustBeNull) { 69980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Type tag with matching void type requires a null pointer. 69990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!ArgumentExpr->isNullPointerConstant(Context, 70000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Expr::NPC_ValueDependentIsNotNull)) { 70010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(ArgumentExpr->getExprLoc(), 70020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko diag::warn_type_safety_null_pointer_required) 70030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentKind->getName() 70040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentExpr->getSourceRange() 70050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 70060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 70070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 70080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 70090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko QualType RequiredType = TypeInfo.Type; 70110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) 70120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType = Context.getPointerType(RequiredType); 70130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool mismatch = false; 70150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeInfo.LayoutCompatible) { 70160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !Context.hasSameType(ArgumentType, RequiredType); 70170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [basic.fundamental] p1: 70190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Plain char, signed char, and unsigned char are three distinct types. 70200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // 70210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // But we treat plain `char' as equivalent to `signed char' or `unsigned 70220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // char' depending on the current char signedness mode. 70230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (mismatch) 70240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if ((IsPointerAttr && IsSameCharType(ArgumentType->getPointeeType(), 70250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType->getPointeeType())) || 70260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (!IsPointerAttr && IsSameCharType(ArgumentType, RequiredType))) 70270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = false; 70280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else 70290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) 70300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !isLayoutCompatible(Context, 70310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ArgumentType->getPointeeType(), 70320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType->getPointeeType()); 70330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 70340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !isLayoutCompatible(Context, ArgumentType, RequiredType); 70350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 70360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (mismatch) 70370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(ArgumentExpr->getExprLoc(), diag::warn_type_safety_type_mismatch) 70380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentType << ArgumentKind->getName() 70390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeInfo.LayoutCompatible << RequiredType 70400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentExpr->getSourceRange() 70410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 70420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 7043