SemaChecking.cpp revision 5a24980d059cd9fbe8375a4c549313101ad20698
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===//
259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//                     The LLVM Compiler Infrastructure
459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source
60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details.
759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===//
959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump//  This file implements extra semantic analysis beyond what is enforced
1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//  by the C type system.
1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===//
1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner
155f8d604246976a93a73549b07bbc8ee0b2061b50John McCall#include "clang/Sema/Initialization.h"
16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Sema.h"
172d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h"
18276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman#include "clang/Sema/Initialization.h"
19831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith#include "clang/Sema/Lookup.h"
20781472fe99a120098c631b0cbe33c89f8cef5e70John McCall#include "clang/Sema/ScopeInfo.h"
21826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek#include "clang/Analysis/Analyses/FormatString.h"
2259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h"
23199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h"
24384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h"
25c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h"
26be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie#include "clang/AST/Expr.h"
272324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h"
287ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h"
29f85e193739c953358c865005855253af4f68a497John McCall#include "clang/AST/EvaluatedExprVisitor.h"
30f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/DeclObjC.h"
31f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h"
32f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h"
3359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h"
34f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h"
358fe83e1df954d72c0f4ffc15d20a5222ec151c21Benjamin Kramer#include "llvm/ADT/SmallString.h"
36f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h"
373bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h"
38691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher#include "clang/Basic/TargetBuiltins.h"
3926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman#include "clang/Basic/TargetInfo.h"
407da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian#include "clang/Basic/ConvertUTF.h"
41a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits>
4259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang;
43781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema;
4459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner
4560800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL,
4660800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner                                                    unsigned ByteNo) const {
4708f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner  return SL->getLocationOfByte(ByteNo, PP.getSourceManager(),
484e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie                               PP.getLangOpts(), PP.getTargetInfo());
4960800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner}
5060800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner
518e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number.
528e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking.  Returns true on error.
538e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) {
548e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  unsigned argCount = call->getNumArgs();
558e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  if (argCount == desiredArgCount) return false;
568e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
578e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  if (argCount < desiredArgCount)
588e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args)
598e10f3b9cc1db43645bbc2999eb163af8997d468John McCall        << 0 /*function call*/ << desiredArgCount << argCount
608e10f3b9cc1db43645bbc2999eb163af8997d468John McCall        << call->getSourceRange();
618e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
628e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  // Highlight all the excess arguments.
638e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  SourceRange range(call->getArg(desiredArgCount)->getLocStart(),
648e10f3b9cc1db43645bbc2999eb163af8997d468John McCall                    call->getArg(argCount - 1)->getLocEnd());
658e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
668e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args)
678e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    << 0 /*function call*/ << desiredArgCount << argCount
688e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    << call->getArg(1)->getSourceRange();
698e10f3b9cc1db43645bbc2999eb163af8997d468John McCall}
708e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
71e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// Check that the first argument to __builtin_annotation is an integer
72e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// and the second argument is a non-wide string literal.
73e59392176c2369df2bdd11b7786cb38abac00198Julien Lerougestatic bool SemaBuiltinAnnotation(Sema &S, CallExpr *TheCall) {
74e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  if (checkArgCount(S, TheCall, 2))
75e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    return true;
76e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge
77e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  // First argument should be an integer.
78e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  Expr *ValArg = TheCall->getArg(0);
79e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  QualType Ty = ValArg->getType();
80e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  if (!Ty->isIntegerType()) {
81e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    S.Diag(ValArg->getLocStart(), diag::err_builtin_annotation_first_arg)
82e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge      << ValArg->getSourceRange();
83e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    return true;
84e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  }
85e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge
86e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  // Second argument should be a constant string.
87e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  Expr *StrArg = TheCall->getArg(1)->IgnoreParenCasts();
88e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  StringLiteral *Literal = dyn_cast<StringLiteral>(StrArg);
8977f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge  if (!Literal || !Literal->isAscii()) {
90e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    S.Diag(StrArg->getLocStart(), diag::err_builtin_annotation_second_arg)
91e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge      << StrArg->getSourceRange();
9277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge    return true;
9377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge  }
94e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge
95e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  TheCall->setType(Ty);
9677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge  return false;
9777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge}
9877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge
9960d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult
100d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
10160d7b3a319d84d688752be3870615ac0f111fb16John McCall  ExprResult TheCallResult(Owned(TheCall));
1022def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor
103946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  // Find out if any arguments are required to be integer constant expressions.
104946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  unsigned ICEArguments = 0;
105946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  ASTContext::GetBuiltinTypeError Error;
106946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  Context.GetBuiltinType(BuiltinID, Error, &ICEArguments);
107946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  if (Error != ASTContext::GE_None)
108946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    ICEArguments = 0;  // Don't diagnose previously diagnosed errors.
109946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner
110946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  // If any arguments are required to be ICE's, check and diagnose.
111946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) {
112946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    // Skip arguments not required to be ICE's.
113946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    if ((ICEArguments & (1 << ArgNo)) == 0) continue;
114946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner
115946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    llvm::APSInt Result;
116946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    if (SemaBuiltinConstantArg(TheCall, ArgNo, Result))
117946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner      return true;
118946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    ICEArguments &= ~(1 << ArgNo);
119946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  }
120946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner
121d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson  switch (BuiltinID) {
12230ce344307f8a8b00054021307015571f83c7364Chris Lattner  case Builtin::BI__builtin___CFStringMakeConstantString:
123925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner    assert(TheCall->getNumArgs() == 1 &&
1241b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner           "Wrong # arguments to builtin CFStringMakeConstantString");
125690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner    if (CheckObjCString(TheCall->getArg(0)))
1260eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
127d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
12849ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek  case Builtin::BI__builtin_stdarg_start:
12930ce344307f8a8b00054021307015571f83c7364Chris Lattner  case Builtin::BI__builtin_va_start:
1300eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    if (SemaBuiltinVAStart(TheCall))
1310eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
132d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
1331b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_isgreater:
1341b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_isgreaterequal:
1351b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_isless:
1361b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_islessequal:
1371b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_islessgreater:
1381b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_isunordered:
1390eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    if (SemaBuiltinUnorderedCompare(TheCall))
1400eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
141d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
142e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer  case Builtin::BI__builtin_fpclassify:
143e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer    if (SemaBuiltinFPClassification(TheCall, 6))
144e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer      return ExprError();
145e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer    break;
1469ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isfinite:
1479ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isinf:
1489ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isinf_sign:
1499ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isnan:
1509ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isnormal:
1513b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer    if (SemaBuiltinFPClassification(TheCall, 1))
1529ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman      return ExprError();
1539ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman    break;
154d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  case Builtin::BI__builtin_shufflevector:
1550eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    return SemaBuiltinShuffleVector(TheCall);
1560eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    // TheCall will be freed by the smart pointer here, but that's fine, since
1570eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    // SemaBuiltinShuffleVector guts it, but then doesn't release it.
1584493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar  case Builtin::BI__builtin_prefetch:
1590eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    if (SemaBuiltinPrefetch(TheCall))
1600eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
161d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
162d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar  case Builtin::BI__builtin_object_size:
1630eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    if (SemaBuiltinObjectSize(TheCall))
1640eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
165d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
166d875fed28578835de89cd407e9db4be788596d7cEli Friedman  case Builtin::BI__builtin_longjmp:
167d875fed28578835de89cd407e9db4be788596d7cEli Friedman    if (SemaBuiltinLongjmp(TheCall))
168d875fed28578835de89cd407e9db4be788596d7cEli Friedman      return ExprError();
169d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
1708e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
1718e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  case Builtin::BI__builtin_classify_type:
1728e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    if (checkArgCount(*this, TheCall, 1)) return true;
1738e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    TheCall->setType(Context.IntTy);
1748e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    break;
17575c29a012793292ff4578015a9113bf086156d7fChris Lattner  case Builtin::BI__builtin_constant_p:
1768e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    if (checkArgCount(*this, TheCall, 1)) return true;
1778e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    TheCall->setType(Context.IntTy);
17875c29a012793292ff4578015a9113bf086156d7fChris Lattner    break;
1795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_add:
180a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_1:
181a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_2:
182a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_4:
183a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_8:
184a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_16:
1855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_sub:
186a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_1:
187a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_2:
188a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_4:
189a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_8:
190a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_16:
1915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_or:
192a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_1:
193a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_2:
194a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_4:
195a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_8:
196a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_16:
1975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_and:
198a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_1:
199a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_2:
200a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_4:
201a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_8:
202a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_16:
2035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_xor:
204a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_1:
205a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_2:
206a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_4:
207a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_8:
208a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_16:
2095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_add_and_fetch:
210a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_1:
211a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_2:
212a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_4:
213a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_8:
214a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_16:
2155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_sub_and_fetch:
216a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_1:
217a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_2:
218a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_4:
219a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_8:
220a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_16:
2215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_and_and_fetch:
222a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_1:
223a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_2:
224a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_4:
225a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_8:
226a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_16:
2275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_or_and_fetch:
228a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_1:
229a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_2:
230a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_4:
231a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_8:
232a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_16:
2335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_xor_and_fetch:
234a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_1:
235a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_2:
236a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_4:
237a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_8:
238a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_16:
2395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_val_compare_and_swap:
240a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_1:
241a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_2:
242a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_4:
243a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_8:
244a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_16:
2455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_bool_compare_and_swap:
246a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_1:
247a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_2:
248a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_4:
249a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_8:
250a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_16:
2515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_lock_test_and_set:
252a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_1:
253a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_2:
254a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_4:
255a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_8:
256a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_16:
2575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_lock_release:
258a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_1:
259a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_2:
260a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_4:
261a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_8:
262a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_16:
26323aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner  case Builtin::BI__sync_swap:
264a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_1:
265a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_2:
266a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_4:
267a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_8:
268a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_16:
2693fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer    return SemaBuiltinAtomicOverloaded(TheCallResult);
270ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define BUILTIN(ID, TYPE, ATTRS)
271ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define ATOMIC_BUILTIN(ID, TYPE, ATTRS) \
272ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Builtin::BI##ID: \
2733fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer    return SemaAtomicOpsOverloaded(TheCallResult, AtomicExpr::AO##ID);
274ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#include "clang/Basic/Builtins.def"
27577f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge  case Builtin::BI__builtin_annotation:
276e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    if (SemaBuiltinAnnotation(*this, TheCall))
27777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge      return ExprError();
27877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge    break;
27926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  }
28026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman
28126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  // Since the target specific builtins for each arch overlap, only check those
28226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  // of the arch we are compiling for.
28326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  if (BuiltinID >= Builtin::FirstTSBuiltin) {
284bcfd1f55bfbb3e5944cd5e03d07b343e280838c4Douglas Gregor    switch (Context.getTargetInfo().getTriple().getArch()) {
28526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman      case llvm::Triple::arm:
28626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman      case llvm::Triple::thumb:
28726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman        if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall))
28826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman          return ExprError();
28926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman        break;
290fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      case llvm::Triple::mips:
291fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      case llvm::Triple::mipsel:
292fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      case llvm::Triple::mips64:
293fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      case llvm::Triple::mips64el:
294fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan        if (CheckMipsBuiltinFunctionCall(BuiltinID, TheCall))
295fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan          return ExprError();
296fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan        break;
29726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman      default:
29826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman        break;
29926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman    }
30026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  }
30126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman
3023fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer  return TheCallResult;
30326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman}
30426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman
30561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code.
30661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) {
307da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  NeonTypeFlags Type(t);
308da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  int IsQuad = Type.isQuad();
309da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  switch (Type.getEltType()) {
310da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Int8:
311da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Poly8:
312da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return shift ? 7 : (8 << IsQuad) - 1;
313da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Int16:
314da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Poly16:
315da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return shift ? 15 : (4 << IsQuad) - 1;
316da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Int32:
317da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return shift ? 31 : (2 << IsQuad) - 1;
318da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Int64:
319da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return shift ? 63 : (1 << IsQuad) - 1;
320da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Float16:
321da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    assert(!shift && "cannot shift float types!");
322da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return (4 << IsQuad) - 1;
323da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Float32:
324da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    assert(!shift && "cannot shift float types!");
325da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return (2 << IsQuad) - 1;
32661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  }
3277530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie  llvm_unreachable("Invalid NeonTypeFlag!");
32861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman}
32961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman
3306f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// getNeonEltType - Return the QualType corresponding to the elements of
3316f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the vector type specified by the NeonTypeFlags.  This is used to check
3326f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the pointer arguments for Neon load/store intrinsics.
3336f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilsonstatic QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context) {
3346f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  switch (Flags.getEltType()) {
3356f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Int8:
3366f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy;
3376f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Int16:
3386f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy;
3396f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Int32:
3406f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy;
3416f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Int64:
3426f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Flags.isUnsigned() ? Context.UnsignedLongLongTy : Context.LongLongTy;
3436f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Poly8:
3446f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Context.SignedCharTy;
3456f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Poly16:
3466f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Context.ShortTy;
3476f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Float16:
3486f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Context.UnsignedShortTy;
3496f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Float32:
3506f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Context.FloatTy;
3516f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  }
3527530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie  llvm_unreachable("Invalid NeonTypeFlag!");
3536f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson}
3546f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson
35526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
3561c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman  llvm::APSInt Result;
3571c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman
358f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith  uint64_t mask = 0;
35961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  unsigned TV = 0;
3604648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson  int PtrArgNum = -1;
3616f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  bool HasConstPtr = false;
3621c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman  switch (BuiltinID) {
363a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK
364a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc"
365a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK
3661c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman  }
3671c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman
3680d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  // For NEON intrinsics which are overloaded on vector element type, validate
3690d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  // the immediate which specifies which variant to emit.
3706f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  unsigned ImmArg = TheCall->getNumArgs()-1;
3710d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  if (mask) {
3726f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    if (SemaBuiltinConstantArg(TheCall, ImmArg, Result))
3730d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman      return true;
3740d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman
375da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    TV = Result.getLimitedValue(64);
376f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith    if ((TV > 63) || (mask & (1ULL << TV)) == 0)
3770d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman      return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code)
3786f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson        << TheCall->getArg(ImmArg)->getSourceRange();
3796f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  }
3806f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson
3814648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson  if (PtrArgNum >= 0) {
3826f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    // Check that pointer arguments have the specified type.
3834648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    Expr *Arg = TheCall->getArg(PtrArgNum);
3844648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg))
3854648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson      Arg = ICE->getSubExpr();
3864648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg);
3874648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    QualType RHSTy = RHS.get()->getType();
3884648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context);
3894648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    if (HasConstPtr)
3904648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson      EltTy = EltTy.withConst();
3914648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    QualType LHSTy = Context.getPointerType(EltTy);
3924648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    AssignConvertType ConvTy;
3934648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS);
3944648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    if (RHS.isInvalid())
3954648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson      return true;
3964648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy,
3974648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson                                 RHS.get(), AA_Assigning))
3984648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson      return true;
3990d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  }
4001c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman
4010d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  // For NEON intrinsics which take an immediate value as part of the
4020d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  // instruction, range check them here.
40361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  unsigned i = 0, l = 0, u = 0;
4040d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  switch (BuiltinID) {
4050d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  default: return false;
406bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman  case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break;
407bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman  case ARM::BI__builtin_arm_usat: i = 1; u = 31; break;
40899c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman  case ARM::BI__builtin_arm_vcvtr_f:
40999c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman  case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break;
410a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK
411a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc"
412a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK
4130d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  };
4140d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman
415592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor  // We can't check the value of a dependent argument.
416592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor  if (TheCall->getArg(i)->isTypeDependent() ||
417592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor      TheCall->getArg(i)->isValueDependent())
418592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor    return false;
419592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
42061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  // Check that the immediate argument is actually a constant.
4210d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  if (SemaBuiltinConstantArg(TheCall, i, Result))
4220d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman    return true;
4230d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman
42461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  // Range check against the upper/lower values for this isntruction.
4250d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  unsigned Val = Result.getZExtValue();
42661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  if (Val < l || Val > (u + l))
4270d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman    return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
428476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer      << l << u+l << TheCall->getArg(i)->getSourceRange();
4290d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman
43099c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman  // FIXME: VFP Intrinsics should error if VFP not present.
43126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  return false;
432d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson}
433d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson
434fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyanbool Sema::CheckMipsBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
435fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  unsigned i = 0, l = 0, u = 0;
436fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  switch (BuiltinID) {
437fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  default: return false;
438fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  case Mips::BI__builtin_mips_wrdsp: i = 1; l = 0; u = 63; break;
439fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  case Mips::BI__builtin_mips_rddsp: i = 0; l = 0; u = 63; break;
440be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan  case Mips::BI__builtin_mips_append: i = 2; l = 0; u = 31; break;
441be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan  case Mips::BI__builtin_mips_balign: i = 2; l = 0; u = 3; break;
442be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan  case Mips::BI__builtin_mips_precr_sra_ph_w: i = 2; l = 0; u = 31; break;
443be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan  case Mips::BI__builtin_mips_precr_sra_r_ph_w: i = 2; l = 0; u = 31; break;
444be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan  case Mips::BI__builtin_mips_prepend: i = 2; l = 0; u = 31; break;
445fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  };
446fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
447fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  // We can't check the value of a dependent argument.
448fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  if (TheCall->getArg(i)->isTypeDependent() ||
449fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      TheCall->getArg(i)->isValueDependent())
450fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan    return false;
451fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
452fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  // Check that the immediate argument is actually a constant.
453fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  llvm::APSInt Result;
454fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  if (SemaBuiltinConstantArg(TheCall, i, Result))
455fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan    return true;
456fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
457fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  // Range check against the upper/lower values for this instruction.
458fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  unsigned Val = Result.getZExtValue();
459fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  if (Val < l || Val > u)
460fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan    return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
461fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      << l << u << TheCall->getArg(i)->getSourceRange();
462fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
463fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  return false;
464fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan}
465fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
466831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Given a FunctionDecl's FormatAttr, attempts to populate the FomatStringInfo
467831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// parameter with the FormatAttr's correct format_idx and firstDataArg.
468831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true when the format fits the function and the FormatStringInfo has
469831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// been populated.
470831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::getFormatStringInfo(const FormatAttr *Format, bool IsCXXMember,
471831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                               FormatStringInfo *FSI) {
472831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  FSI->HasVAListArg = Format->getFirstArg() == 0;
473831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  FSI->FormatIdx = Format->getFormatIdx() - 1;
474831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  FSI->FirstDataArg = FSI->HasVAListArg ? 0 : Format->getFirstArg() - 1;
475de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar
476831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // The way the format attribute works in GCC, the implicit this argument
477831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // of member functions is counted. However, it doesn't appear in our own
478831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // lists, so decrement format_idx in that case.
479831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (IsCXXMember) {
480831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    if(FSI->FormatIdx == 0)
481831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      return false;
482831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    --FSI->FormatIdx;
483831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    if (FSI->FirstDataArg != 0)
484831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      --FSI->FirstDataArg;
485831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  }
486831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return true;
487831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
4881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
489831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Handles the checks for format strings, non-POD arguments to vararg
490831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// functions, and NULL arguments passed to non-NULL parameters.
491831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithvoid Sema::checkCall(NamedDecl *FDecl, Expr **Args,
492831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     unsigned NumArgs,
493831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     unsigned NumProtoArgs,
494831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     bool IsMemberFunction,
495831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     SourceLocation Loc,
496831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     SourceRange Range,
497831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     VariadicCallType CallType) {
49866360e224689dc23a0acd8a6705ba50bec13bc97Jordan Rose  if (CurContext->isDependentContext())
49966360e224689dc23a0acd8a6705ba50bec13bc97Jordan Rose    return;
500de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar
501c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek  // Printf and scanf checking.
502831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  bool HandledFormatString = false;
503c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek  for (specific_attr_iterator<FormatAttr>
504831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith         I = FDecl->specific_attr_begin<FormatAttr>(),
505831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith         E = FDecl->specific_attr_end<FormatAttr>(); I != E ; ++I)
506ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose    if (CheckFormatArguments(*I, Args, NumArgs, IsMemberFunction, CallType,
507ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                             Loc, Range))
508831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        HandledFormatString = true;
509831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
510831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // Refuse POD arguments that weren't caught by the format string
511831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // checks above.
512831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (!HandledFormatString && CallType != VariadicDoesNotApply)
5130234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek    for (unsigned ArgIdx = NumProtoArgs; ArgIdx < NumArgs; ++ArgIdx) {
5140234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek      // Args[ArgIdx] can be null in malformed code.
5150234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek      if (Expr *Arg = Args[ArgIdx])
5160234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek        variadicArgumentPODCheck(Arg, CallType);
5170234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek    }
5181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
519c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek  for (specific_attr_iterator<NonNullAttr>
520831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith         I = FDecl->specific_attr_begin<NonNullAttr>(),
521831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith         E = FDecl->specific_attr_end<NonNullAttr>(); I != E; ++I)
522831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    CheckNonNullArguments(*I, Args, Loc);
5230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
5240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // Type safety checking.
5250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  for (specific_attr_iterator<ArgumentWithTypeTagAttr>
5260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         i = FDecl->specific_attr_begin<ArgumentWithTypeTagAttr>(),
5270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         e = FDecl->specific_attr_end<ArgumentWithTypeTagAttr>(); i != e; ++i) {
5280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    CheckArgumentWithTypeTag(*i, Args);
5290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
530831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
531831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
532831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckConstructorCall - Check a constructor call for correctness and safety
533831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// properties not enforced by the C type system.
534831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithvoid Sema::CheckConstructorCall(FunctionDecl *FDecl, Expr **Args,
535831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                unsigned NumArgs,
536831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                const FunctionProtoType *Proto,
537831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                SourceLocation Loc) {
538831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  VariadicCallType CallType =
539831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    Proto->isVariadic() ? VariadicConstructor : VariadicDoesNotApply;
540831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  checkCall(FDecl, Args, NumArgs, Proto->getNumArgs(),
541831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            /*IsMemberFunction=*/true, Loc, SourceRange(), CallType);
542831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
543831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
544831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckFunctionCall - Check a direct function call for various correctness
545831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// and safety properties not strictly enforced by the C type system.
546831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall,
547831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                             const FunctionProtoType *Proto) {
5482edcde8747a000113b434a5c88b4648beed4197bEli Friedman  bool IsMemberOperatorCall = isa<CXXOperatorCallExpr>(TheCall) &&
5492edcde8747a000113b434a5c88b4648beed4197bEli Friedman                              isa<CXXMethodDecl>(FDecl);
5502edcde8747a000113b434a5c88b4648beed4197bEli Friedman  bool IsMemberFunction = isa<CXXMemberCallExpr>(TheCall) ||
5512edcde8747a000113b434a5c88b4648beed4197bEli Friedman                          IsMemberOperatorCall;
552831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  VariadicCallType CallType = getVariadicCallType(FDecl, Proto,
553831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                                  TheCall->getCallee());
554831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0;
5552edcde8747a000113b434a5c88b4648beed4197bEli Friedman  Expr** Args = TheCall->getArgs();
5562edcde8747a000113b434a5c88b4648beed4197bEli Friedman  unsigned NumArgs = TheCall->getNumArgs();
557df75b0c74b277c6b46af2f9e90e13160fbc14d6fEli Friedman  if (IsMemberOperatorCall) {
5582edcde8747a000113b434a5c88b4648beed4197bEli Friedman    // If this is a call to a member operator, hide the first argument
5592edcde8747a000113b434a5c88b4648beed4197bEli Friedman    // from checkCall.
5602edcde8747a000113b434a5c88b4648beed4197bEli Friedman    // FIXME: Our choice of AST representation here is less than ideal.
5612edcde8747a000113b434a5c88b4648beed4197bEli Friedman    ++Args;
5622edcde8747a000113b434a5c88b4648beed4197bEli Friedman    --NumArgs;
5632edcde8747a000113b434a5c88b4648beed4197bEli Friedman  }
5642edcde8747a000113b434a5c88b4648beed4197bEli Friedman  checkCall(FDecl, Args, NumArgs, NumProtoArgs,
565831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            IsMemberFunction, TheCall->getRParenLoc(),
566831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            TheCall->getCallee()->getSourceRange(), CallType);
567831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
568831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  IdentifierInfo *FnInfo = FDecl->getIdentifier();
569831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // None of the checks below are needed for functions that don't have
570831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // simple names (e.g., C++ conversion functions).
571831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (!FnInfo)
572831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return false;
5730eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl
5740a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  unsigned CMId = FDecl->getMemoryFunctionKind();
5750a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  if (CMId == 0)
576d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks    return false;
577bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
578d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks  // Handle memory setting and copying functions.
5790a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat)
580bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    CheckStrlcpycatArguments(TheCall, FnInfo);
581c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  else if (CMId == Builtin::BIstrncat)
582c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    CheckStrncatArguments(TheCall, FnInfo);
583d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks  else
5840a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks    CheckMemaccessArguments(TheCall, CMId, FnInfo);
5857ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth
586d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson  return false;
58771993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson}
58871993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson
58929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupasbool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac,
59029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                               Expr **Args, unsigned NumArgs) {
591831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  VariadicCallType CallType =
592831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      Method->isVariadic() ? VariadicMethod : VariadicDoesNotApply;
59329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas
594831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  checkCall(Method, Args, NumArgs, Method->param_size(),
595831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            /*IsMemberFunction=*/false,
596831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            lbrac, Method->getSourceRange(), CallType);
59729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas
59829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  return false;
59929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas}
60029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas
601831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall,
602831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                          const FunctionProtoType *Proto) {
603725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian  const VarDecl *V = dyn_cast<VarDecl>(NDecl);
604725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian  if (!V)
605d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    return false;
6061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
607725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian  QualType Ty = V->getType();
608725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian  if (!Ty->isBlockPointerType())
609d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    return false;
6101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
611831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  VariadicCallType CallType =
612831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      Proto && Proto->isVariadic() ? VariadicBlock : VariadicDoesNotApply ;
613831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0;
614d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson
615831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  checkCall(NDecl, TheCall->getArgs(), TheCall->getNumArgs(),
616831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            NumProtoArgs, /*IsMemberFunction=*/false,
617831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            TheCall->getRParenLoc(),
618831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            TheCall->getCallee()->getSourceRange(), CallType);
619831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
620d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson  return false;
621725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian}
622725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian
623ff34d401ff385ef7173ca612432b4ea717fff690Richard SmithExprResult Sema::SemaAtomicOpsOverloaded(ExprResult TheCallResult,
624ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith                                         AtomicExpr::AtomicOp Op) {
625276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  CallExpr *TheCall = cast<CallExpr>(TheCallResult.get());
626276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
627276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
628ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // All these operations take one of the following forms:
629ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  enum {
630ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // C    __c11_atomic_init(A *, C)
631ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Init,
632ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // C    __c11_atomic_load(A *, int)
633ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Load,
634ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // void __atomic_load(A *, CP, int)
635ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Copy,
636ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // C    __c11_atomic_add(A *, M, int)
637ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Arithmetic,
638ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // C    __atomic_exchange_n(A *, CP, int)
639ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Xchg,
640ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // void __atomic_exchange(A *, C *, CP, int)
641ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    GNUXchg,
642ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // bool __c11_atomic_compare_exchange_strong(A *, C *, CP, int, int)
643ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    C11CmpXchg,
644ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // bool __atomic_compare_exchange(A *, C *, CP, bool, int, int)
645ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    GNUCmpXchg
646ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  } Form = Init;
647ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  const unsigned NumArgs[] = { 2, 2, 3, 3, 3, 4, 5, 6 };
648ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  const unsigned NumVals[] = { 1, 0, 1, 1, 1, 2, 2, 3 };
649ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // where:
650ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   C is an appropriate type,
651ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   A is volatile _Atomic(C) for __c11 builtins and is C for GNU builtins,
652ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   CP is C for __c11 builtins and GNU _n builtins and is C * otherwise,
653ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   M is C if C is an integer, and ptrdiff_t if C is a pointer, and
654ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   the int parameters are for orderings.
655ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
656ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  assert(AtomicExpr::AO__c11_atomic_init == 0 &&
657ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith         AtomicExpr::AO__c11_atomic_fetch_xor + 1 == AtomicExpr::AO__atomic_load
658ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith         && "need to update code for modified C11 atomics");
659ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  bool IsC11 = Op >= AtomicExpr::AO__c11_atomic_init &&
660ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith               Op <= AtomicExpr::AO__c11_atomic_fetch_xor;
661ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  bool IsN = Op == AtomicExpr::AO__atomic_load_n ||
662ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith             Op == AtomicExpr::AO__atomic_store_n ||
663ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith             Op == AtomicExpr::AO__atomic_exchange_n ||
664ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith             Op == AtomicExpr::AO__atomic_compare_exchange_n;
665ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  bool IsAddSub = false;
666ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
667ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  switch (Op) {
668ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_init:
669ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Init;
670ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
671ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
672ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_load:
673ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_load_n:
674ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Load;
675ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
676ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
677ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_store:
678ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_load:
679ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_store:
680ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_store_n:
681ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Copy;
682ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
683ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
684ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_add:
685ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_sub:
686ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_add:
687ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_sub:
688ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_add_fetch:
689ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_sub_fetch:
690ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    IsAddSub = true;
691ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // Fall through.
692ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_and:
693ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_or:
694ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_xor:
695ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_and:
696ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_or:
697ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_xor:
69851b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith  case AtomicExpr::AO__atomic_fetch_nand:
699ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_and_fetch:
700ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_or_fetch:
701ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_xor_fetch:
70251b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith  case AtomicExpr::AO__atomic_nand_fetch:
703ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Arithmetic;
704ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
705ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
706ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_exchange:
707ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_exchange_n:
708ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Xchg;
709ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
710ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
711ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_exchange:
712ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = GNUXchg;
713ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
714ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
715ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_compare_exchange_strong:
716ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_compare_exchange_weak:
717ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = C11CmpXchg;
718ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
719ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
720ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_compare_exchange:
721ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_compare_exchange_n:
722ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = GNUCmpXchg;
723ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
724276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
725276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
726ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // Check we have the right number of arguments.
727ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (TheCall->getNumArgs() < NumArgs[Form]) {
728276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
729ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      << 0 << NumArgs[Form] << TheCall->getNumArgs()
730276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << TheCall->getCallee()->getSourceRange();
731276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
732ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  } else if (TheCall->getNumArgs() > NumArgs[Form]) {
733ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Diag(TheCall->getArg(NumArgs[Form])->getLocStart(),
734276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman         diag::err_typecheck_call_too_many_args)
735ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      << 0 << NumArgs[Form] << TheCall->getNumArgs()
736276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << TheCall->getCallee()->getSourceRange();
737276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
738276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
739276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
740ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // Inspect the first argument of the atomic operation.
741dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman  Expr *Ptr = TheCall->getArg(0);
742276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get();
743276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  const PointerType *pointerType = Ptr->getType()->getAs<PointerType>();
744276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  if (!pointerType) {
745ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
746276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << Ptr->getType() << Ptr->getSourceRange();
747276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
748276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
749276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
750ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // For a __c11 builtin, this should be a pointer to an _Atomic type.
751ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  QualType AtomTy = pointerType->getPointeeType(); // 'A'
752ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  QualType ValType = AtomTy; // 'C'
753ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (IsC11) {
754ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    if (!AtomTy->isAtomicType()) {
755ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic)
756ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        << Ptr->getType() << Ptr->getSourceRange();
757ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      return ExprError();
758ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    }
759bc57b108b2253e26b83768dba196c28564952f18Richard Smith    if (AtomTy.isConstQualified()) {
760bc57b108b2253e26b83768dba196c28564952f18Richard Smith      Diag(DRE->getLocStart(), diag::err_atomic_op_needs_non_const_atomic)
761bc57b108b2253e26b83768dba196c28564952f18Richard Smith        << Ptr->getType() << Ptr->getSourceRange();
762bc57b108b2253e26b83768dba196c28564952f18Richard Smith      return ExprError();
763bc57b108b2253e26b83768dba196c28564952f18Richard Smith    }
764ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    ValType = AtomTy->getAs<AtomicType>()->getValueType();
765276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
766276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
767ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // For an arithmetic operation, the implied arithmetic must be well-formed.
768ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (Form == Arithmetic) {
769ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // gcc does not enforce these rules for GNU atomics, but we do so for sanity.
770ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    if (IsAddSub && !ValType->isIntegerType() && !ValType->isPointerType()) {
771ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr)
772ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        << IsC11 << Ptr->getType() << Ptr->getSourceRange();
773ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      return ExprError();
774ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    }
775ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    if (!IsAddSub && !ValType->isIntegerType()) {
776ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      Diag(DRE->getLocStart(), diag::err_atomic_op_bitwise_needs_atomic_int)
777ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        << IsC11 << Ptr->getType() << Ptr->getSourceRange();
778ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      return ExprError();
779ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    }
780ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  } else if (IsN && !ValType->isIntegerType() && !ValType->isPointerType()) {
781ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // For __atomic_*_n operations, the value type must be a scalar integral or
782ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // pointer type which is 1, 2, 4, 8 or 16 bytes in length.
783276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr)
784ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      << IsC11 << Ptr->getType() << Ptr->getSourceRange();
785276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
786276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
787276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
788ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (!IsC11 && !AtomTy.isTriviallyCopyableType(Context)) {
789ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // For GNU atomics, require a trivially-copyable type. This is not part of
790ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // the GNU atomics specification, but we enforce it for sanity.
791ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Diag(DRE->getLocStart(), diag::err_atomic_op_needs_trivial_copy)
792276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << Ptr->getType() << Ptr->getSourceRange();
793276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
794276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
795276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
796ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // FIXME: For any builtin other than a load, the ValType must not be
797ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // const-qualified.
798ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
799276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  switch (ValType.getObjCLifetime()) {
800276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_None:
801276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_ExplicitNone:
802276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    // okay
803276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    break;
804276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
805276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_Weak:
806276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_Strong:
807276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_Autoreleasing:
808ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // FIXME: Can this happen? By this point, ValType should be known
809ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // to be trivially copyable.
810276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
811276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << ValType << Ptr->getSourceRange();
812276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
813276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
814276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
815276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  QualType ResultType = ValType;
816ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (Form == Copy || Form == GNUXchg || Form == Init)
817276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    ResultType = Context.VoidTy;
818ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  else if (Form == C11CmpXchg || Form == GNUCmpXchg)
819276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    ResultType = Context.BoolTy;
820276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
821ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // The type of a parameter passed 'by value'. In the GNU atomics, such
822ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // arguments are actually passed as pointers.
823ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  QualType ByValType = ValType; // 'CP'
824ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (!IsC11 && !IsN)
825ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    ByValType = Ptr->getType();
826ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
827276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  // The first argument --- the pointer --- has a fixed type; we
828276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  // deduce the types of the rest of the arguments accordingly.  Walk
829276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  // the remaining arguments, converting them to the deduced value type.
830ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  for (unsigned i = 1; i != NumArgs[Form]; ++i) {
831276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    QualType Ty;
832ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    if (i < NumVals[Form] + 1) {
833ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      switch (i) {
834ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      case 1:
835ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // The second argument is the non-atomic operand. For arithmetic, this
836ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // is always passed by value, and for a compare_exchange it is always
837ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // passed by address. For the rest, GNU uses by-address and C11 uses
838ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // by-value.
839ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        assert(Form != Load);
840ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        if (Form == Init || (Form == Arithmetic && ValType->isIntegerType()))
841ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith          Ty = ValType;
842ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        else if (Form == Copy || Form == Xchg)
843ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith          Ty = ByValType;
844ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        else if (Form == Arithmetic)
845ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith          Ty = Context.getPointerDiffType();
846ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        else
847ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith          Ty = Context.getPointerType(ValType.getUnqualifiedType());
848ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        break;
849ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      case 2:
850ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // The third argument to compare_exchange / GNU exchange is a
851ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // (pointer to a) desired value.
852ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        Ty = ByValType;
853ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        break;
854ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      case 3:
855ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // The fourth argument to GNU compare_exchange is a 'weak' flag.
856ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        Ty = Context.BoolTy;
857ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        break;
858ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      }
859276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    } else {
860276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      // The order(s) are always converted to int.
861276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      Ty = Context.IntTy;
862276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    }
863ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
864276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    InitializedEntity Entity =
865276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman        InitializedEntity::InitializeParameter(Context, Ty, false);
866ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    ExprResult Arg = TheCall->getArg(i);
867276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
868276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    if (Arg.isInvalid())
869276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      return true;
870276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    TheCall->setArg(i, Arg.get());
871276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
872276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
873ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // Permute the arguments into a 'consistent' order.
874dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman  SmallVector<Expr*, 5> SubExprs;
875dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman  SubExprs.push_back(Ptr);
876ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  switch (Form) {
877ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Init:
878ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // Note, AtomicExpr::getVal1() has a special case for this atomic.
8797a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall    SubExprs.push_back(TheCall->getArg(1)); // Val1
880ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
881ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Load:
882ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(1)); // Order
883ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
884ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Copy:
885ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Arithmetic:
886ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Xchg:
887dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(2)); // Order
888dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(1)); // Val1
889ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
890ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case GNUXchg:
891ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // Note, AtomicExpr::getVal2() has a special case for this atomic.
892ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(3)); // Order
893ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(1)); // Val1
894ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(2)); // Val2
895ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
896ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case C11CmpXchg:
897dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(3)); // Order
898dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(1)); // Val1
899dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(4)); // OrderFail
9002ebb98a78471f2039af4321bae657e7daacc2a62David Chisnall    SubExprs.push_back(TheCall->getArg(2)); // Val2
901ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
902ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case GNUCmpXchg:
903ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(4)); // Order
904ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(1)); // Val1
905ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(5)); // OrderFail
906ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(2)); // Val2
907ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(3)); // Weak
908ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
909276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
910dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman
911dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman  return Owned(new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(),
9123b6bef9a213249c6ab6d67c07b1ac6380961be3eBenjamin Kramer                                        SubExprs, ResultType, Op,
913dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman                                        TheCall->getRParenLoc()));
914276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman}
915276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
916276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
9175f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// checkBuiltinArgument - Given a call to a builtin function, perform
9185f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// normal type-checking on the given argument, updating the call in
9195f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// place.  This is useful when a builtin function requires custom
9205f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// type-checking for some of its arguments but not necessarily all of
9215f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// them.
9225f8d604246976a93a73549b07bbc8ee0b2061b50John McCall///
9235f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// Returns true on error.
9245f8d604246976a93a73549b07bbc8ee0b2061b50John McCallstatic bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) {
9255f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  FunctionDecl *Fn = E->getDirectCallee();
9265f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  assert(Fn && "builtin call without direct callee!");
9275f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
9285f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  ParmVarDecl *Param = Fn->getParamDecl(ArgIndex);
9295f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  InitializedEntity Entity =
9305f8d604246976a93a73549b07bbc8ee0b2061b50John McCall    InitializedEntity::InitializeParameter(S.Context, Param);
9315f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
9325f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  ExprResult Arg = E->getArg(0);
9335f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
9345f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  if (Arg.isInvalid())
9355f8d604246976a93a73549b07bbc8ee0b2061b50John McCall    return true;
9365f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
9375f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  E->setArg(ArgIndex, Arg.take());
9385f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  return false;
9395f8d604246976a93a73549b07bbc8ee0b2061b50John McCall}
9405f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
9415caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like
9425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer
9435caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument.  The main ActOnCallExpr routines have already
9445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as
9455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...).
9465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner///
9475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these
9485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins,
94960d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult
95060d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) {
951d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  CallExpr *TheCall = (CallExpr *)TheCallResult.get();
9525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
9535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
9545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner
9555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Ensure that we have at least one argument to do type inference from.
956d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  if (TheCall->getNumArgs() < 1) {
957d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
958d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << 0 << 1 << TheCall->getNumArgs()
959d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << TheCall->getCallee()->getSourceRange();
960d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
961d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  }
9621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
9635caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Inspect the first argument of the atomic builtin.  This should always be
9645caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // a pointer type, whose element is an integral scalar or pointer type.
9655caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Because it is a pointer type, we don't have to worry about any implicit
9665caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // casts here.
967d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  // FIXME: We don't allow floating point scalars as input.
9685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  Expr *FirstArg = TheCall->getArg(0);
9698c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman  ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg);
9708c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman  if (FirstArgResult.isInvalid())
9718c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman    return ExprError();
9728c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman  FirstArg = FirstArgResult.take();
9738c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman  TheCall->setArg(0, FirstArg);
9748c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman
975f85e193739c953358c865005855253af4f68a497John McCall  const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>();
976f85e193739c953358c865005855253af4f68a497John McCall  if (!pointerType) {
977d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
978d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << FirstArg->getType() << FirstArg->getSourceRange();
979d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
980d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  }
9811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
982f85e193739c953358c865005855253af4f68a497John McCall  QualType ValType = pointerType->getPointeeType();
983dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner  if (!ValType->isIntegerType() && !ValType->isAnyPointerType() &&
984d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      !ValType->isBlockPointerType()) {
985d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr)
986d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << FirstArg->getType() << FirstArg->getSourceRange();
987d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
988d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  }
9895caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner
990f85e193739c953358c865005855253af4f68a497John McCall  switch (ValType.getObjCLifetime()) {
991f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_None:
992f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_ExplicitNone:
993f85e193739c953358c865005855253af4f68a497John McCall    // okay
994f85e193739c953358c865005855253af4f68a497John McCall    break;
995f85e193739c953358c865005855253af4f68a497John McCall
996f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_Weak:
997f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_Strong:
998f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_Autoreleasing:
999b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis    Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
1000f85e193739c953358c865005855253af4f68a497John McCall      << ValType << FirstArg->getSourceRange();
1001f85e193739c953358c865005855253af4f68a497John McCall    return ExprError();
1002f85e193739c953358c865005855253af4f68a497John McCall  }
1003f85e193739c953358c865005855253af4f68a497John McCall
1004b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall  // Strip any qualifiers off ValType.
1005b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall  ValType = ValType.getUnqualifiedType();
1006b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall
10078d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth  // The majority of builtins return a value, but a few have special return
10088d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth  // types, so allow them to override appropriately below.
10098d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth  QualType ResultType = ValType;
10108d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth
10115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // We need to figure out which concrete builtin this maps onto.  For example,
10125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // __sync_fetch_and_add with a 2 byte object turns into
10135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // __sync_fetch_and_add_2.
10145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \
10155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \
10165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    Builtin::BI##x##_8, Builtin::BI##x##_16 }
10171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
10185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  static const unsigned BuiltinIndices[][5] = {
10195caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_add),
10205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_sub),
10215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_or),
10225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_and),
10235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_xor),
10241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
10255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_add_and_fetch),
10265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_sub_and_fetch),
10275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_and_and_fetch),
10285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_or_and_fetch),
10295caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_xor_and_fetch),
10301eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
10315caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_val_compare_and_swap),
10325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_bool_compare_and_swap),
10335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_lock_test_and_set),
103423aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner    BUILTIN_ROW(__sync_lock_release),
103523aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner    BUILTIN_ROW(__sync_swap)
10365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  };
10371eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW
10381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
10395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Determine the index of the size.
10405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  unsigned SizeIndex;
1041199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck  switch (Context.getTypeSizeInChars(ValType).getQuantity()) {
10425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 1: SizeIndex = 0; break;
10435caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 2: SizeIndex = 1; break;
10445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 4: SizeIndex = 2; break;
10455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 8: SizeIndex = 3; break;
10465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 16: SizeIndex = 4; break;
10475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  default:
1048d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size)
1049d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << FirstArg->getType() << FirstArg->getSourceRange();
1050d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
10515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  }
10521eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
10535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Each of these builtins has one pointer argument, followed by some number of
10545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // values (0, 1 or 2) followed by a potentially empty varags list of stuff
10555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // that we ignore.  Find out which row of BuiltinIndices to read from as well
10565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // as the number of fixed args.
10577814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor  unsigned BuiltinID = FDecl->getBuiltinID();
10585caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  unsigned BuiltinIndex, NumFixed = 1;
10595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  switch (BuiltinID) {
1060b219cfc4d75f0a03630b7c4509ef791b7e97b2c8David Blaikie  default: llvm_unreachable("Unknown overloaded atomic builtin!");
1061a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add:
1062a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_1:
1063a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_2:
1064a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_4:
1065a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_8:
1066a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_16:
1067a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 0;
1068a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1069a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1070a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub:
1071a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_1:
1072a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_2:
1073a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_4:
1074a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_8:
1075a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_16:
1076a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 1;
1077a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1078a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1079a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or:
1080a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_1:
1081a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_2:
1082a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_4:
1083a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_8:
1084a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_16:
1085a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 2;
1086a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1087a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1088a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and:
1089a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_1:
1090a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_2:
1091a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_4:
1092a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_8:
1093a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_16:
1094a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 3;
1095a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1096a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1097a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor:
1098a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_1:
1099a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_2:
1100a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_4:
1101a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_8:
1102a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_16:
1103a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 4;
1104a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1105a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1106a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch:
1107a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_1:
1108a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_2:
1109a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_4:
1110a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_8:
1111a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_16:
1112a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 5;
1113a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1114a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1115a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch:
1116a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_1:
1117a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_2:
1118a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_4:
1119a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_8:
1120a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_16:
1121a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 6;
1122a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1123a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1124a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch:
1125a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_1:
1126a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_2:
1127a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_4:
1128a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_8:
1129a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_16:
1130a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 7;
1131a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1132a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1133a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch:
1134a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_1:
1135a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_2:
1136a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_4:
1137a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_8:
1138a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_16:
1139a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 8;
1140a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1141a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1142a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch:
1143a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_1:
1144a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_2:
1145a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_4:
1146a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_8:
1147a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_16:
1148a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 9;
1149a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
11501eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
11515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_val_compare_and_swap:
1152a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_1:
1153a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_2:
1154a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_4:
1155a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_8:
1156a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_16:
11577eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar    BuiltinIndex = 10;
11585caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    NumFixed = 2;
11595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    break;
1160a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
11615caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_bool_compare_and_swap:
1162a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_1:
1163a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_2:
1164a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_4:
1165a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_8:
1166a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_16:
11677eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar    BuiltinIndex = 11;
11685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    NumFixed = 2;
11698d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth    ResultType = Context.BoolTy;
11705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    break;
1171a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1172a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set:
1173a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_1:
1174a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_2:
1175a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_4:
1176a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_8:
1177a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_16:
1178a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 12;
1179a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1180a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
11815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_lock_release:
1182a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_1:
1183a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_2:
1184a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_4:
1185a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_8:
1186a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_16:
11877eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar    BuiltinIndex = 13;
11885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    NumFixed = 0;
11898d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth    ResultType = Context.VoidTy;
11905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    break;
1191a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1192a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap:
1193a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_1:
1194a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_2:
1195a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_4:
1196a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_8:
1197a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_16:
1198a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 14;
1199a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
12005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  }
12011eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
12025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Now that we know how many fixed arguments we expect, first check that we
12035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // have at least that many.
1204d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  if (TheCall->getNumArgs() < 1+NumFixed) {
1205d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
1206d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << 0 << 1+NumFixed << TheCall->getNumArgs()
1207d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << TheCall->getCallee()->getSourceRange();
1208d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
1209d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  }
12101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1211e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner  // Get the decl for the concrete builtin from this, we can tell what the
1212e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner  // concrete integer type we should convert to is.
1213e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner  unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex];
1214e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner  const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID);
12152ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara  FunctionDecl *NewBuiltinDecl;
12162ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara  if (NewBuiltinID == BuiltinID)
12172ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara    NewBuiltinDecl = FDecl;
12182ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara  else {
12192ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara    // Perform builtin lookup to avoid redeclaring it.
12202ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara    DeclarationName DN(&Context.Idents.get(NewBuiltinName));
12212ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara    LookupResult Res(*this, DN, DRE->getLocStart(), LookupOrdinaryName);
12222ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara    LookupName(Res, TUScope, /*AllowBuiltinCreation=*/true);
12232ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara    assert(Res.getFoundDecl());
12242ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara    NewBuiltinDecl = dyn_cast<FunctionDecl>(Res.getFoundDecl());
12252ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara    if (NewBuiltinDecl == 0)
12262ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara      return ExprError();
12272ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara  }
1228d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth
1229f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall  // The first argument --- the pointer --- has a fixed type; we
1230f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall  // deduce the types of the rest of the arguments accordingly.  Walk
1231f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall  // the remaining arguments, converting them to the deduced value type.
12325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  for (unsigned i = 0; i != NumFixed; ++i) {
1233429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley    ExprResult Arg = TheCall->getArg(i+1);
12341eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
12355caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // GCC does an implicit conversion to the pointer or integer ValType.  This
12365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // can fail in some cases (1i -> int**), check for this error case now.
1237b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall    // Initialize the argument.
1238b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall    InitializedEntity Entity = InitializedEntity::InitializeParameter(Context,
1239b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall                                                   ValType, /*consume*/ false);
1240b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall    Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
1241429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley    if (Arg.isInvalid())
1242d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      return ExprError();
12431eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
12445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // Okay, we have something that *can* be converted to the right type.  Check
12455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // to see if there is a potentially weird extension going on here.  This can
12465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // happen when you do an atomic operation on something like an char* and
12475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // pass in 42.  The 42 gets converted to char.  This is even more strange
12485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // for things like 45.123 -> char, etc.
12491eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump    // FIXME: Do this check.
1250b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall    TheCall->setArg(i+1, Arg.take());
12515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  }
12521eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1253bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor  ASTContext& Context = this->getASTContext();
1254bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor
1255bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor  // Create a new DeclRefExpr to refer to the new decl.
1256bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor  DeclRefExpr* NewDRE = DeclRefExpr::Create(
1257bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      Context,
1258bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      DRE->getQualifierLoc(),
1259e4b92761b43ced611c417ae478568610f1ad7b1eAbramo Bagnara      SourceLocation(),
1260bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      NewBuiltinDecl,
1261f4b88a45902af1802a1cb42ba48b1c474474f228John McCall      /*enclosing*/ false,
1262bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      DRE->getLocation(),
1263a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman      Context.BuiltinFnTy,
1264bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      DRE->getValueKind());
12651eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
12665caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Set the callee in the CallExpr.
1267a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman  // FIXME: This loses syntactic information.
1268a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman  QualType CalleePtrTy = Context.getPointerType(NewBuiltinDecl->getType());
1269a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman  ExprResult PromotedCall = ImpCastExprToType(NewDRE, CalleePtrTy,
1270a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman                                              CK_BuiltinFnToFnPtr);
1271429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  TheCall->setCallee(PromotedCall.take());
12721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1273db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth  // Change the result type of the call to match the original value type. This
1274db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth  // is arbitrary, but the codegen for these builtins ins design to handle it
1275db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth  // gracefully.
12768d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth  TheCall->setType(ResultType);
1277d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth
12783fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer  return TheCallResult;
12795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner}
12805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner
1281690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin
128271993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct
1283fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would
1284fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend).
1285690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) {
128656f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner  Arg = Arg->IgnoreParenCasts();
128771993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson  StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
128871993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson
12895cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor  if (!Literal || !Literal->isAscii()) {
1290fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner    Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant)
1291fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner      << Arg->getSourceRange();
12929cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson    return true;
129371993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson  }
12941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
12957da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian  if (Literal->containsNonAsciiOrNull()) {
12965f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner    StringRef String = Literal->getString();
12977da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    unsigned NumBytes = String.size();
12985f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner    SmallVector<UTF16, 128> ToBuf(NumBytes);
129931ba6135375433b617a8587ea6cc836a014ebd86Roman Divacky    const UTF8 *FromPtr = (const UTF8 *)String.data();
13007da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    UTF16 *ToPtr = &ToBuf[0];
13017da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian
13027da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes,
13037da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian                                                 &ToPtr, ToPtr + NumBytes,
13047da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian                                                 strictConversion);
13057da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    // Check for conversion failure.
13067da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    if (Result != conversionOK)
13077da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian      Diag(Arg->getLocStart(),
13087da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian           diag::warn_cfstring_truncated) << Arg->getSourceRange();
13097da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian  }
13109cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson  return false;
131159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner}
131259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner
1313c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity.
1314c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success.
1315925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) {
1316925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  Expr *Fn = TheCall->getCallee();
1317925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  if (TheCall->getNumArgs() > 2) {
13182c21a073525cdfa68e4439b7af551385dc2796abChris Lattner    Diag(TheCall->getArg(2)->getLocStart(),
1319fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner         diag::err_typecheck_call_too_many_args)
1320ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher      << 0 /*function call*/ << 2 << TheCall->getNumArgs()
1321ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher      << Fn->getSourceRange()
13221eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump      << SourceRange(TheCall->getArg(2)->getLocStart(),
1323fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                     (*(TheCall->arg_end()-1))->getLocEnd());
132430ce344307f8a8b00054021307015571f83c7364Chris Lattner    return true;
132530ce344307f8a8b00054021307015571f83c7364Chris Lattner  }
132656f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman
132756f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman  if (TheCall->getNumArgs() < 2) {
1328d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher    return Diag(TheCall->getLocEnd(),
1329d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      diag::err_typecheck_call_too_few_args_at_least)
1330d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      << 0 /*function call*/ << 2 << TheCall->getNumArgs();
133156f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman  }
133256f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman
13335f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  // Type-check the first argument normally.
13345f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  if (checkBuiltinArgument(*this, TheCall, 0))
13355f8d604246976a93a73549b07bbc8ee0b2061b50John McCall    return true;
13365f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
1337c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner  // Determine whether the current function is variadic or not.
13389ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor  BlockScopeInfo *CurBlock = getCurBlock();
1339c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner  bool isVariadic;
1340cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff  if (CurBlock)
1341c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall    isVariadic = CurBlock->TheDecl->isVariadic();
13429498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek  else if (FunctionDecl *FD = getCurFunctionDecl())
13439498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek    isVariadic = FD->isVariadic();
13449498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek  else
134553d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis    isVariadic = getCurMethodDecl()->isVariadic();
13461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1347c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner  if (!isVariadic) {
134830ce344307f8a8b00054021307015571f83c7364Chris Lattner    Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
134930ce344307f8a8b00054021307015571f83c7364Chris Lattner    return true;
135030ce344307f8a8b00054021307015571f83c7364Chris Lattner  }
13511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
135230ce344307f8a8b00054021307015571f83c7364Chris Lattner  // Verify that the second argument to the builtin is the last argument of the
135330ce344307f8a8b00054021307015571f83c7364Chris Lattner  // current function or method.
135430ce344307f8a8b00054021307015571f83c7364Chris Lattner  bool SecondArgIsLastNamedArgument = false;
1355e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson  const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts();
13561eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
135788cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson  if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
135888cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson    if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
135930ce344307f8a8b00054021307015571f83c7364Chris Lattner      // FIXME: This isn't correct for methods (results in bogus warning).
136030ce344307f8a8b00054021307015571f83c7364Chris Lattner      // Get the last formal in the current function.
136188cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson      const ParmVarDecl *LastArg;
1362cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff      if (CurBlock)
1363cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff        LastArg = *(CurBlock->TheDecl->param_end()-1);
1364cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff      else if (FunctionDecl *FD = getCurFunctionDecl())
1365371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner        LastArg = *(FD->param_end()-1);
136630ce344307f8a8b00054021307015571f83c7364Chris Lattner      else
136753d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis        LastArg = *(getCurMethodDecl()->param_end()-1);
136830ce344307f8a8b00054021307015571f83c7364Chris Lattner      SecondArgIsLastNamedArgument = PV == LastArg;
136930ce344307f8a8b00054021307015571f83c7364Chris Lattner    }
137030ce344307f8a8b00054021307015571f83c7364Chris Lattner  }
13711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
137230ce344307f8a8b00054021307015571f83c7364Chris Lattner  if (!SecondArgIsLastNamedArgument)
13731eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump    Diag(TheCall->getArg(1)->getLocStart(),
137430ce344307f8a8b00054021307015571f83c7364Chris Lattner         diag::warn_second_parameter_of_va_start_not_last_named_argument);
137530ce344307f8a8b00054021307015571f83c7364Chris Lattner  return false;
13766cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman}
137730ce344307f8a8b00054021307015571f83c7364Chris Lattner
13781b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and
13791b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends.  This is declared to take (...), so we have to check everything.
1380925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) {
1381925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  if (TheCall->getNumArgs() < 2)
13822c21a073525cdfa68e4439b7af551385dc2796abChris Lattner    return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
1383d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      << 0 << 2 << TheCall->getNumArgs()/*function call*/;
1384925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  if (TheCall->getNumArgs() > 2)
13851eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump    return Diag(TheCall->getArg(2)->getLocStart(),
1386fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                diag::err_typecheck_call_too_many_args)
1387ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher      << 0 /*function call*/ << 2 << TheCall->getNumArgs()
1388fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner      << SourceRange(TheCall->getArg(2)->getLocStart(),
1389fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                     (*(TheCall->arg_end()-1))->getLocEnd());
13901eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1391429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  ExprResult OrigArg0 = TheCall->getArg(0);
1392429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  ExprResult OrigArg1 = TheCall->getArg(1);
1393cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor
13941b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  // Do standard promotions between the two arguments, returning their common
13951b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  // type.
1396925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false);
1397429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  if (OrigArg0.isInvalid() || OrigArg1.isInvalid())
1398429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley    return true;
1399403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar
1400403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar  // Make sure any conversions are pushed back into the call; this is
1401403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar  // type safe since unordered compare builtins are declared as "_Bool
1402403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar  // foo(...)".
1403429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  TheCall->setArg(0, OrigArg0.get());
1404429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  TheCall->setArg(1, OrigArg1.get());
14051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1406429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent())
1407cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor    return false;
1408cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor
14091b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  // If the common type isn't a real floating type, then the arguments were
14101b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  // invalid for this operation.
1411860a319e62b0e256817a458396d191aa91c0787aEli Friedman  if (Res.isNull() || !Res->isRealFloatingType())
1412429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley    return Diag(OrigArg0.get()->getLocStart(),
1413fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                diag::err_typecheck_call_invalid_ordered_compare)
1414429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley      << OrigArg0.get()->getType() << OrigArg1.get()->getType()
1415429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley      << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd());
14161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
14171b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  return false;
14181b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner}
14191b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner
1420e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like
1421e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends.  This is declared to take (...), so we have
14223b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point
14233b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value.
14243b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) {
14253b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer  if (TheCall->getNumArgs() < NumArgs)
14269ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman    return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
1427d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      << 0 << NumArgs << TheCall->getNumArgs()/*function call*/;
14283b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer  if (TheCall->getNumArgs() > NumArgs)
14293b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer    return Diag(TheCall->getArg(NumArgs)->getLocStart(),
14309ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman                diag::err_typecheck_call_too_many_args)
1431ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher      << 0 /*function call*/ << NumArgs << TheCall->getNumArgs()
14323b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer      << SourceRange(TheCall->getArg(NumArgs)->getLocStart(),
14339ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman                     (*(TheCall->arg_end()-1))->getLocEnd());
14349ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman
14353b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer  Expr *OrigArg = TheCall->getArg(NumArgs-1);
14361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
14379ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  if (OrigArg->isTypeDependent())
14389ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman    return false;
14399ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman
144081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner  // This operation requires a non-_Complex floating-point number.
14419ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  if (!OrigArg->getType()->isRealFloatingType())
14421eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump    return Diag(OrigArg->getLocStart(),
14439ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman                diag::err_typecheck_call_invalid_unary_fp)
14449ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman      << OrigArg->getType() << OrigArg->getSourceRange();
14451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
144681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner  // If this is an implicit conversion from float -> double, remove it.
144781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner  if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) {
144881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner    Expr *CastArg = Cast->getSubExpr();
144981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner    if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) {
145081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner      assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) &&
145181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner             "promotion from float to double is the only expected cast here");
145281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner      Cast->setSubExpr(0);
145381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner      TheCall->setArg(NumArgs-1, CastArg);
145481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner    }
145581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner  }
145681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner
14579ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  return false;
14589ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman}
14599ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman
1460d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector.
1461d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything.
146260d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) {
146337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  if (TheCall->getNumArgs() < 2)
14640eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    return ExprError(Diag(TheCall->getLocEnd(),
1465d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher                          diag::err_typecheck_call_too_few_args_at_least)
146637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman      << 0 /*function call*/ << 2 << TheCall->getNumArgs()
1467d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      << TheCall->getSourceRange());
1468d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
146937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  // Determine which of the following types of shufflevector we're checking:
147037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  // 1) unary, vector mask: (lhs, mask)
147137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  // 2) binary, vector mask: (lhs, rhs, mask)
147237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  // 3) binary, scalar mask: (lhs, rhs, index, ..., index)
147337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  QualType resType = TheCall->getArg(0)->getType();
147437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  unsigned numElements = 0;
147537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman
1476cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor  if (!TheCall->getArg(0)->isTypeDependent() &&
1477cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      !TheCall->getArg(1)->isTypeDependent()) {
147837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    QualType LHSType = TheCall->getArg(0)->getType();
147937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    QualType RHSType = TheCall->getArg(1)->getType();
148037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman
148137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    if (!LHSType->isVectorType() || !RHSType->isVectorType()) {
1482cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector)
14831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump        << SourceRange(TheCall->getArg(0)->getLocStart(),
1484cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor                       TheCall->getArg(1)->getLocEnd());
1485cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      return ExprError();
1486cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor    }
148737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman
148837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    numElements = LHSType->getAs<VectorType>()->getNumElements();
148937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    unsigned numResElements = TheCall->getNumArgs() - 2;
149037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman
149137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    // Check to see if we have a call with 2 vector arguments, the unary shuffle
149237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    // with mask.  If so, verify that RHS is an integer vector type with the
149337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    // same number of elts as lhs.
149437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    if (TheCall->getNumArgs() == 2) {
1495f60946222721d9ba3c059563935c17b84703187aDouglas Gregor      if (!RHSType->hasIntegerRepresentation() ||
149637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman          RHSType->getAs<VectorType>()->getNumElements() != numElements)
149737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman        Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
149837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman          << SourceRange(TheCall->getArg(1)->getLocStart(),
149937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman                         TheCall->getArg(1)->getLocEnd());
150037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman      numResElements = numElements;
150137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    }
150237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) {
1503cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
15041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump        << SourceRange(TheCall->getArg(0)->getLocStart(),
1505cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor                       TheCall->getArg(1)->getLocEnd());
1506cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      return ExprError();
150737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    } else if (numElements != numResElements) {
150837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman      QualType eltType = LHSType->getAs<VectorType>()->getElementType();
1509788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner      resType = Context.getVectorType(eltType, numResElements,
1510e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson                                      VectorType::GenericVector);
1511cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor    }
1512d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  }
1513d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
1514d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  for (unsigned i = 2; i < TheCall->getNumArgs(); i++) {
1515cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor    if (TheCall->getArg(i)->isTypeDependent() ||
1516cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor        TheCall->getArg(i)->isValueDependent())
1517cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      continue;
1518cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor
151937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    llvm::APSInt Result(32);
152037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context))
152137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman      return ExprError(Diag(TheCall->getLocStart(),
152237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman                  diag::err_shufflevector_nonconstant_argument)
152337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman                << TheCall->getArg(i)->getSourceRange());
15240eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl
1525d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner    if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2)
15260eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError(Diag(TheCall->getLocStart(),
1527fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                  diag::err_shufflevector_argument_too_large)
15280eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl               << TheCall->getArg(i)->getSourceRange());
1529d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  }
1530d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
15315f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner  SmallVector<Expr*, 32> exprs;
1532d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
1533d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner  for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) {
1534d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman    exprs.push_back(TheCall->getArg(i));
1535d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman    TheCall->setArg(i, 0);
1536d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  }
1537d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
15383b6bef9a213249c6ab6d67c07b1ac6380961be3eBenjamin Kramer  return Owned(new (Context) ShuffleVectorExpr(Context, exprs, resType,
15398189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek                                            TheCall->getCallee()->getLocStart(),
15408189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek                                            TheCall->getRParenLoc()));
1541d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman}
154230ce344307f8a8b00054021307015571f83c7364Chris Lattner
15434493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch.
15444493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two
15454493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args.
15464493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) {
1547fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner  unsigned NumArgs = TheCall->getNumArgs();
15484493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar
1549fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner  if (NumArgs > 3)
1550ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher    return Diag(TheCall->getLocEnd(),
1551ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher             diag::err_typecheck_call_too_many_args_at_most)
1552ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher             << 0 /*function call*/ << 3 << NumArgs
1553ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher             << TheCall->getSourceRange();
15544493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar
15554493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar  // Argument 0 is checked for us and the remaining arguments must be
15564493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar  // constant integers.
1557fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner  for (unsigned i = 1; i != NumArgs; ++i) {
15584493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    Expr *Arg = TheCall->getArg(i);
1559592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
1560592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor    // We can't check the value of a dependent argument.
1561592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor    if (Arg->isTypeDependent() || Arg->isValueDependent())
1562592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor      continue;
1563592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
15649aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman    llvm::APSInt Result;
1565691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher    if (SemaBuiltinConstantArg(TheCall, i, Result))
1566691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher      return true;
15671eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
15684493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    // FIXME: gcc issues a warning and rewrites these to 0. These
15694493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    // seems especially odd for the third argument since the default
15704493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    // is 3.
1571fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner    if (i == 1) {
15729aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman      if (Result.getLimitedValue() > 1)
1573fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner        return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
157421fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner             << "0" << "1" << Arg->getSourceRange();
15754493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    } else {
15769aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman      if (Result.getLimitedValue() > 3)
1577fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner        return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
157821fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner            << "0" << "3" << Arg->getSourceRange();
15794493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    }
15804493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar  }
15814493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar
1582fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner  return false;
15834493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar}
15844493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar
1585691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr
1586691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression.
1587691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum,
1588691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher                                  llvm::APSInt &Result) {
1589691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  Expr *Arg = TheCall->getArg(ArgNum);
1590691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
1591691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
1592691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher
1593691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (Arg->isTypeDependent() || Arg->isValueDependent()) return false;
1594691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher
1595691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (!Arg->isIntegerConstantExpr(Result, Context))
1596691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher    return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type)
15975e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher                << FDecl->getDeclName() <<  Arg->getSourceRange();
1598691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher
159921fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner  return false;
160021fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner}
160121fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner
1602d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr,
1603d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined
1604d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3).
1605fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner// For compatibility check 0-3, llvm only handles 0 and 2.
1606d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) {
1607691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  llvm::APSInt Result;
1608592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
1609592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor  // We can't check the value of a dependent argument.
1610592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor  if (TheCall->getArg(1)->isTypeDependent() ||
1611592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor      TheCall->getArg(1)->isValueDependent())
1612592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor    return false;
1613592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
1614691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  // Check constant-ness first.
1615691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (SemaBuiltinConstantArg(TheCall, 1, Result))
1616691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher    return true;
1617d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar
1618691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  Expr *Arg = TheCall->getArg(1);
1619d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar  if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) {
1620fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner    return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
1621fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner             << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
1622d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar  }
1623d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar
1624d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar  return false;
1625d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar}
1626d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar
1627586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val).
1628d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1.
1629d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) {
1630d875fed28578835de89cd407e9db4be788596d7cEli Friedman  Expr *Arg = TheCall->getArg(1);
1631691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  llvm::APSInt Result;
1632cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor
1633691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  // TODO: This is less than ideal. Overload this to take a value.
1634691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (SemaBuiltinConstantArg(TheCall, 1, Result))
1635691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher    return true;
1636691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher
1637691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (Result != 1)
1638d875fed28578835de89cd407e9db4be788596d7cEli Friedman    return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val)
1639d875fed28578835de89cd407e9db4be788596d7cEli Friedman             << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
1640d875fed28578835de89cd407e9db4be788596d7cEli Friedman
1641d875fed28578835de89cd407e9db4be788596d7cEli Friedman  return false;
1642d875fed28578835de89cd407e9db4be788596d7cEli Friedman}
1643d875fed28578835de89cd407e9db4be788596d7cEli Friedman
1644831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determine if an expression is a string literal or constant string.
1645831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// If this function returns false on the arguments to a function expecting a
1646831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// format string, we will usually need to emit a warning.
1647831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// True string literals are then checked by CheckFormatString.
1648831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithSema::StringLiteralCheckType
1649831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithSema::checkFormatStringExpr(const Expr *E, Expr **Args,
1650831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                            unsigned NumArgs, bool HasVAListArg,
1651831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                            unsigned format_idx, unsigned firstDataArg,
1652ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                            FormatStringType Type, VariadicCallType CallType,
1653ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                            bool inFunctionCall) {
16544fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain:
1655cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor  if (E->isTypeDependent() || E->isValueDependent())
1656831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
1657d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
165834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  E = E->IgnoreParenCasts();
1659f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne
1660a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie  if (E->isNullPointerConstant(Context, Expr::NPC_ValueDependentIsNotNull))
1661a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie    // Technically -Wformat-nonliteral does not warn about this case.
1662a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie    // The behavior of printf and friends in this case is implementation
1663a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie    // dependent.  Ideally if the format string cannot be null then
1664a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie    // it should have a 'nonnull' attribute in the function prototype.
1665831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_CheckedLiteral;
1666a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie
1667d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  switch (E->getStmtClass()) {
166856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall  case Stmt::BinaryConditionalOperatorClass:
1669d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  case Stmt::ConditionalOperatorClass: {
1670831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    // The expression is a literal if both sub-expressions were, and it was
1671831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    // completely checked only if both sub-expressions were checked.
1672831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    const AbstractConditionalOperator *C =
1673831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        cast<AbstractConditionalOperator>(E);
1674831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    StringLiteralCheckType Left =
1675831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        checkFormatStringExpr(C->getTrueExpr(), Args, NumArgs,
1676831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                              HasVAListArg, format_idx, firstDataArg,
1677ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                              Type, CallType, inFunctionCall);
1678831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    if (Left == SLCT_NotALiteral)
1679831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      return SLCT_NotALiteral;
1680831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    StringLiteralCheckType Right =
1681831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        checkFormatStringExpr(C->getFalseExpr(), Args, NumArgs,
1682831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                              HasVAListArg, format_idx, firstDataArg,
1683ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                              Type, CallType, inFunctionCall);
1684831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return Left < Right ? Left : Right;
1685d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  }
1686d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
1687d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  case Stmt::ImplicitCastExprClass: {
16884fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek    E = cast<ImplicitCastExpr>(E)->getSubExpr();
16894fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek    goto tryAgain;
1690d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  }
1691d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
169256ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall  case Stmt::OpaqueValueExprClass:
169356ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall    if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) {
169456ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall      E = src;
169556ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall      goto tryAgain;
169656ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall    }
1697831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
169856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall
1699b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek  case Stmt::PredefinedExprClass:
1700b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek    // While __func__, etc., are technically not string literals, they
1701b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek    // cannot contain format specifiers and thus are not a security
1702b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek    // liability.
1703831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_UncheckedLiteral;
1704b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek
1705082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  case Stmt::DeclRefExprClass: {
1706082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    const DeclRefExpr *DR = cast<DeclRefExpr>(E);
17071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1708082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    // As an exception, do not flag errors for variables binding to
1709082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    // const string literals.
1710082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
1711082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      bool isConstant = false;
1712082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      QualType T = DR->getType();
1713082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek
1714082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      if (const ArrayType *AT = Context.getAsArrayType(T)) {
1715082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek        isConstant = AT->getElementType().isConstant(Context);
1716ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump      } else if (const PointerType *PT = T->getAs<PointerType>()) {
17171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump        isConstant = T.isConstant(Context) &&
1718082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek                     PT->getPointeeType().isConstant(Context);
1719e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas      } else if (T->isObjCObjectPointerType()) {
1720e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas        // In ObjC, there is usually no "const ObjectPointer" type,
1721e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas        // so don't check if the pointee type is constant.
1722e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas        isConstant = T.isConstant(Context);
1723082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      }
17241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1725082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      if (isConstant) {
1726e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay        if (const Expr *Init = VD->getAnyInitializer()) {
1727e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay          // Look through initializers like const char c[] = { "foo" }
1728e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay          if (const InitListExpr *InitList = dyn_cast<InitListExpr>(Init)) {
1729e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay            if (InitList->isStringLiteralInit())
1730e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay              Init = InitList->getInit(0)->IgnoreParenImpCasts();
1731e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay          }
1732831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          return checkFormatStringExpr(Init, Args, NumArgs,
1733831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                       HasVAListArg, format_idx,
1734ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                       firstDataArg, Type, CallType,
1735831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                       /*inFunctionCall*/false);
1736e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay        }
1737082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      }
17381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1739d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // For vprintf* functions (i.e., HasVAListArg==true), we add a
1740d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // special check to see if the format string is a function parameter
1741d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // of the function calling the printf function.  If the function
1742d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // has an attribute indicating it is a printf-like function, then we
1743d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // should suppress warnings concerning non-literals being used in a call
1744d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // to a vprintf function.  For example:
1745d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //
1746d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // void
1747d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){
1748d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //      va_list ap;
1749d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //      va_start(ap, fmt);
1750d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //      vprintf(fmt, ap);  // Do NOT emit a warning about "fmt".
1751d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //      ...
1752d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //
1753f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas      if (HasVAListArg) {
1754f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas        if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(VD)) {
1755f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas          if (const NamedDecl *ND = dyn_cast<NamedDecl>(PV->getDeclContext())) {
1756f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas            int PVIndex = PV->getFunctionScopeIndex() + 1;
1757f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas            for (specific_attr_iterator<FormatAttr>
1758f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                 i = ND->specific_attr_begin<FormatAttr>(),
1759f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                 e = ND->specific_attr_end<FormatAttr>(); i != e ; ++i) {
1760f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              FormatAttr *PVFormat = *i;
1761f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              // adjust for implicit parameter
1762f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND))
1763f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                if (MD->isInstance())
1764f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                  ++PVIndex;
1765f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              // We also check if the formats are compatible.
1766f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              // We can't pass a 'scanf' string to a 'printf' function.
1767f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              if (PVIndex == PVFormat->getFormatIdx() &&
1768f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                  Type == GetFormatStringType(PVFormat))
1769831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                return SLCT_UncheckedLiteral;
1770f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas            }
1771f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas          }
1772f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas        }
1773f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas      }
1774082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    }
17751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1776831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
1777082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  }
1778d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
177952aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas  case Stmt::CallExprClass:
178052aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas  case Stmt::CXXMemberCallExprClass: {
17818f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson    const CallExpr *CE = cast<CallExpr>(E);
178252aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas    if (const NamedDecl *ND = dyn_cast_or_null<NamedDecl>(CE->getCalleeDecl())) {
178352aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas      if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) {
178452aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas        unsigned ArgIndex = FA->getFormatIdx();
178552aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas        if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND))
178652aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas          if (MD->isInstance())
178752aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas            --ArgIndex;
178852aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas        const Expr *Arg = CE->getArg(ArgIndex - 1);
178952aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas
1790831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        return checkFormatStringExpr(Arg, Args, NumArgs,
1791831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                     HasVAListArg, format_idx, firstDataArg,
1792ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                     Type, CallType, inFunctionCall);
179350687314f87b67073c202fe46d84d12fb55e25cfJordan Rose      } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(ND)) {
179450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose        unsigned BuiltinID = FD->getBuiltinID();
179550687314f87b67073c202fe46d84d12fb55e25cfJordan Rose        if (BuiltinID == Builtin::BI__builtin___CFStringMakeConstantString ||
179650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose            BuiltinID == Builtin::BI__builtin___NSStringMakeConstantString) {
179750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose          const Expr *Arg = CE->getArg(0);
1798831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          return checkFormatStringExpr(Arg, Args, NumArgs,
1799831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                       HasVAListArg, format_idx,
1800ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                       firstDataArg, Type, CallType,
1801ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                       inFunctionCall);
180250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose        }
18038f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson      }
18048f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson    }
18051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1806831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
18078f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson  }
1808082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  case Stmt::ObjCStringLiteralClass:
1809082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  case Stmt::StringLiteralClass: {
1810082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    const StringLiteral *StrE = NULL;
18111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1812082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E))
1813d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek      StrE = ObjCFExpr->getString();
1814d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek    else
1815082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      StrE = cast<StringLiteral>(E);
18161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1817d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek    if (StrE) {
181829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas      CheckFormatString(StrE, E, Args, NumArgs, HasVAListArg, format_idx,
1819ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                        firstDataArg, Type, inFunctionCall, CallType);
1820831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      return SLCT_CheckedLiteral;
1821d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek    }
18221eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1823831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
1824d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  }
18251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1826082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  default:
1827831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
1828d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  }
1829d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek}
1830d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
1831e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid
18321eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull,
1833909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky                            const Expr * const *ExprArgs,
1834909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky                            SourceLocation CallSiteLoc) {
1835cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt  for (NonNullAttr::args_iterator i = NonNull->args_begin(),
1836cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt                                  e = NonNull->args_end();
1837e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian       i != e; ++i) {
1838909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky    const Expr *ArgExpr = ExprArgs[*i];
18394e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek    if (ArgExpr->isNullPointerConstant(Context,
1840ce94049b69f75b44c18584fe79cd238978b6b0d5Douglas Gregor                                       Expr::NPC_ValueDependentIsNotNull))
1841909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky      Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange();
1842e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian  }
1843e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian}
1844d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
184534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel DupasSema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) {
184634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  return llvm::StringSwitch<FormatStringType>(Format->getType())
184734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Case("scanf", FST_Scanf)
184834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Cases("printf", "printf0", FST_Printf)
184934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Cases("NSString", "CFString", FST_NSString)
185034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Case("strftime", FST_Strftime)
185134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Case("strfmon", FST_Strfmon)
185234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf)
185334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Default(FST_Unknown);
185434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas}
185534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas
1856ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose/// CheckFormatArguments - Check calls to printf and scanf (and similar
1857826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings.
1858831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true if a format string has been fully checked.
1859831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFormatArguments(const FormatAttr *Format, Expr **Args,
186029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                                unsigned NumArgs, bool IsCXXMember,
1861ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                VariadicCallType CallType,
186229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                                SourceLocation Loc, SourceRange Range) {
1863831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  FormatStringInfo FSI;
1864831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (getFormatStringInfo(Format, IsCXXMember, &FSI))
1865831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return CheckFormatArguments(Args, NumArgs, FSI.HasVAListArg, FSI.FormatIdx,
1866831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                FSI.FirstDataArg, GetFormatStringType(Format),
1867ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                CallType, Loc, Range);
1868831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return false;
186929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas}
18704a2614e94672c47395abcde60518776fbebec589Sebastian Redl
1871831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFormatArguments(Expr **Args, unsigned NumArgs,
187234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas                                bool HasVAListArg, unsigned format_idx,
187334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas                                unsigned firstDataArg, FormatStringType Type,
1874ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                                VariadicCallType CallType,
187534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas                                SourceLocation Loc, SourceRange Range) {
1876826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  // CHECK: printf/scanf-like function is called with no format string.
187729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  if (format_idx >= NumArgs) {
187829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas    Diag(Loc, diag::warn_missing_format_string) << Range;
1879831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return false;
188071895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  }
18811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
188229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts();
18831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
188459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner  // CHECK: format string is not a string literal.
18851eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  //
188671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // Dynamically generated format strings are difficult to
188771895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // automatically vet at compile time.  Requiring that format strings
188871895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // are string literals: (1) permits the checking of format strings by
188971895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // the compiler and thereby (2) can practically remove the source of
189071895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // many format string exploits.
18917ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek
18921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  // Format string can be either ObjC string (e.g. @"%d") or
18937ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek  // C string (e.g. "%d")
18941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  // ObjC string uses the same format specifiers as C string, so we can use
18957ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek  // the same format string checking logic for both ObjC and C strings.
1896831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  StringLiteralCheckType CT =
1897831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      checkFormatStringExpr(OrigFormatExpr, Args, NumArgs, HasVAListArg,
1898ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                            format_idx, firstDataArg, Type, CallType);
1899831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (CT != SLCT_NotALiteral)
1900831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    // Literal format string found, check done!
1901831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return CT == SLCT_CheckedLiteral;
19021cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner
19032837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas  // Strftime is particular as it always uses a single 'time' argument,
19042837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas  // so it is safe to pass a non-literal string.
19052837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas  if (Type == FST_Strftime)
1906831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return false;
19072837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas
1908ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas  // Do not emit diag when the string param is a macro expansion and the
1909ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas  // format is either NSString or CFString. This is a hack to prevent
1910ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas  // diag when using the NSLocalizedString and CFCopyLocalizedString macros
1911ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas  // which are usually used in place of NS and CF string literals.
1912dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas  if (Type == FST_NSString &&
1913dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas      SourceMgr.isInSystemMacro(Args[format_idx]->getLocStart()))
1914831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return false;
1915ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas
1916655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner  // If there are no arguments specified, warn with -Wformat-security, otherwise
1917655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner  // warn only with -Wformat-nonliteral.
191829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  if (NumArgs == format_idx+1)
191929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas    Diag(Args[format_idx]->getLocStart(),
1920826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek         diag::warn_format_nonliteral_noargs)
1921655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner      << OrigFormatExpr->getSourceRange();
1922655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner  else
192329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas    Diag(Args[format_idx]->getLocStart(),
1924826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek         diag::warn_format_nonliteral)
1925655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner           << OrigFormatExpr->getSourceRange();
1926831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return false;
1927d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek}
1928d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
1929e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace {
1930826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler {
1931826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected:
1932e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  Sema &S;
1933e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  const StringLiteral *FExpr;
1934e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  const Expr *OrigFormatExpr;
19356ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek  const unsigned FirstDataArg;
1936e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  const unsigned NumDataArgs;
1937e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  const char *Beg; // Start of format string.
19380d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  const bool HasVAListArg;
193929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  const Expr * const *Args;
194029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  const unsigned NumArgs;
19410d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  unsigned FormatIdx;
19427f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  llvm::BitVector CoveredArgs;
1943efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  bool usesPositionalArgs;
1944efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  bool atFirstArg;
194555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  bool inFunctionCall;
1946ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose  Sema::VariadicCallType CallType;
19474e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic:
1948826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  CheckFormatHandler(Sema &s, const StringLiteral *fexpr,
19496ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek                     const Expr *origFormatExpr, unsigned firstDataArg,
195050687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                     unsigned numDataArgs, const char *beg, bool hasVAListArg,
195129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                     Expr **args, unsigned numArgs,
1952ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                     unsigned formatIdx, bool inFunctionCall,
1953ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                     Sema::VariadicCallType callType)
1954e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek    : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr),
195550687314f87b67073c202fe46d84d12fb55e25cfJordan Rose      FirstDataArg(firstDataArg), NumDataArgs(numDataArgs),
195650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose      Beg(beg), HasVAListArg(hasVAListArg),
195729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas      Args(args), NumArgs(numArgs), FormatIdx(formatIdx),
195855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      usesPositionalArgs(false), atFirstArg(true),
1959ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose      inFunctionCall(inFunctionCall), CallType(callType) {
19607f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek        CoveredArgs.resize(numDataArgs);
19617f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek        CoveredArgs.reset();
19627f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      }
19634e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
196407d161f38e708a91486bf1c031d525faebbb249dTed Kremenek  void DoneProcessing();
19654e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
1966826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  void HandleIncompleteSpecifier(const char *startSpecifier,
1967826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                 unsigned specifierLen);
196876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
1969bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  void HandleInvalidLengthModifier(
1970bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose      const analyze_format_string::FormatSpecifier &FS,
1971bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose      const analyze_format_string::ConversionSpecifier &CS,
19728be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose      const char *startSpecifier, unsigned specifierLen, unsigned DiagID);
1973bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
197476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg  void HandleNonStandardLengthModifier(
19758be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose      const analyze_format_string::FormatSpecifier &FS,
197676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg      const char *startSpecifier, unsigned specifierLen);
197776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
197876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg  void HandleNonStandardConversionSpecifier(
197976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg      const analyze_format_string::ConversionSpecifier &CS,
198076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg      const char *startSpecifier, unsigned specifierLen);
198176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
1982f85626453123f9691bcef13cff963f556e209c27Hans Wennborg  virtual void HandlePosition(const char *startPos, unsigned posLen);
1983f85626453123f9691bcef13cff963f556e209c27Hans Wennborg
1984efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  virtual void HandleInvalidPosition(const char *startSpecifier,
1985efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek                                     unsigned specifierLen,
1986826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                     analyze_format_string::PositionContext p);
1987efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
1988efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  virtual void HandleZeroPosition(const char *startPos, unsigned posLen);
1989efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
1990e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  void HandleNullChar(const char *nullCharacter);
19914e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
199255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  template <typename Range>
199355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  static void EmitFormatDiagnostic(Sema &S, bool inFunctionCall,
199455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                   const Expr *ArgumentExpr,
199555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                   PartialDiagnostic PDiag,
199655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                   SourceLocation StringLoc,
199755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                   bool IsStringLocation, Range StringRange,
1998ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                            ArrayRef<FixItHint> Fixit = ArrayRef<FixItHint>());
199955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
2000826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected:
2001c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc,
2002c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        const char *startSpec,
2003c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        unsigned specifierLen,
2004c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        const char *csStart, unsigned csLen);
200555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
200655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  void HandlePositionalNonpositionalArgs(SourceLocation Loc,
200755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                         const char *startSpec,
200855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                         unsigned specifierLen);
2009c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2010f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek  SourceRange getFormatStringRange();
2011826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  CharSourceRange getSpecifierRange(const char *startSpecifier,
2012826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                    unsigned specifierLen);
2013e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  SourceLocation getLocationOfByte(const char *x);
20144e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
20150d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  const Expr *getDataArg(unsigned i) const;
2016666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek
2017666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS,
2018666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek                    const analyze_format_string::ConversionSpecifier &CS,
2019666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek                    const char *startSpecifier, unsigned specifierLen,
2020666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek                    unsigned argIndex);
202155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
202255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  template <typename Range>
202355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc,
202455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                            bool IsStringLocation, Range StringRange,
2025ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                            ArrayRef<FixItHint> Fixit = ArrayRef<FixItHint>());
202655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
202755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  void CheckPositionalAndNonpositionalArgs(
202855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      const analyze_format_string::FormatSpecifier *FS);
2029e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek};
2030e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}
2031e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2032826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() {
2033e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  return OrigFormatExpr->getSourceRange();
2034e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}
2035e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2036826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler::
2037826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) {
203845f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  SourceLocation Start = getLocationOfByte(startSpecifier);
203945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  SourceLocation End   = getLocationOfByte(startSpecifier + specifierLen - 1);
204045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care
204145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  // Advance the end SourceLocation by one due to half-open ranges.
2042a64ccefdf0ea4e03ec88805d71b0af74950c7472Argyrios Kyrtzidis  End = End.getLocWithOffset(1);
204345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care
204445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  return CharSourceRange::getCharRange(Start, End);
2045f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek}
2046f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek
2047826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) {
20484e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek  return S.getLocationOfStringLiteralByte(FExpr, x - Beg);
2049e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}
2050e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2051826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier,
2052826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                                   unsigned specifierLen){
205355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier),
205455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(startSpecifier),
205555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       /*IsStringLocation*/true,
205655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpecifier, specifierLen));
2057808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek}
2058808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek
2059bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rosevoid CheckFormatHandler::HandleInvalidLengthModifier(
2060bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose    const analyze_format_string::FormatSpecifier &FS,
2061bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose    const analyze_format_string::ConversionSpecifier &CS,
20628be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    const char *startSpecifier, unsigned specifierLen, unsigned DiagID) {
2063bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  using namespace analyze_format_string;
2064bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
2065bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  const LengthModifier &LM = FS.getLengthModifier();
2066bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength());
2067bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
2068bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  // See if we know how to fix this length modifier.
2069bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  llvm::Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier();
2070bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  if (FixedLM) {
20718be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(),
2072bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose                         getLocationOfByte(LM.getStart()),
2073bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose                         /*IsStringLocation*/true,
2074bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose                         getSpecifierRange(startSpecifier, specifierLen));
2075bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
2076bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose    S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier)
2077bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose      << FixedLM->toString()
2078bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose      << FixItHint::CreateReplacement(LMRange, FixedLM->toString());
2079bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
2080bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  } else {
20818be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    FixItHint Hint;
20828be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    if (DiagID == diag::warn_format_nonsensical_length)
20838be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose      Hint = FixItHint::CreateRemoval(LMRange);
20848be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose
20858be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(),
2086bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose                         getLocationOfByte(LM.getStart()),
2087bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose                         /*IsStringLocation*/true,
2088bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose                         getSpecifierRange(startSpecifier, specifierLen),
20898be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         Hint);
2090bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  }
2091bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose}
2092bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
209376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardLengthModifier(
20948be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    const analyze_format_string::FormatSpecifier &FS,
209576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    const char *startSpecifier, unsigned specifierLen) {
20968be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  using namespace analyze_format_string;
20978be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose
20988be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  const LengthModifier &LM = FS.getLengthModifier();
20998be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength());
21008be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose
21018be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  // See if we know how to fix this length modifier.
21028be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  llvm::Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier();
21038be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  if (FixedLM) {
21048be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
21058be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                           << LM.toString() << 0,
21068be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         getLocationOfByte(LM.getStart()),
21078be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         /*IsStringLocation*/true,
21088be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         getSpecifierRange(startSpecifier, specifierLen));
21098be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose
21108be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier)
21118be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose      << FixedLM->toString()
21128be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose      << FixItHint::CreateReplacement(LMRange, FixedLM->toString());
21138be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose
21148be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  } else {
21158be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
21168be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                           << LM.toString() << 0,
21178be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         getLocationOfByte(LM.getStart()),
21188be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         /*IsStringLocation*/true,
21198be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                         getSpecifierRange(startSpecifier, specifierLen));
21208be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose  }
212176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg}
212276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
212376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardConversionSpecifier(
212476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    const analyze_format_string::ConversionSpecifier &CS,
212576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    const char *startSpecifier, unsigned specifierLen) {
2126670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose  using namespace analyze_format_string;
2127670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose
2128670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose  // See if we know how to fix this conversion specifier.
2129670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose  llvm::Optional<ConversionSpecifier> FixedCS = CS.getStandardSpecifier();
2130670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose  if (FixedCS) {
2131670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose    EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
2132670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose                          << CS.toString() << /*conversion specifier*/1,
2133670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose                         getLocationOfByte(CS.getStart()),
2134670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose                         /*IsStringLocation*/true,
2135670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose                         getSpecifierRange(startSpecifier, specifierLen));
2136670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose
2137670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose    CharSourceRange CSRange = getSpecifierRange(CS.getStart(), CS.getLength());
2138670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose    S.Diag(getLocationOfByte(CS.getStart()), diag::note_format_fix_specifier)
2139670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose      << FixedCS->toString()
2140670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose      << FixItHint::CreateReplacement(CSRange, FixedCS->toString());
2141670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose  } else {
2142670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose    EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
2143670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose                          << CS.toString() << /*conversion specifier*/1,
2144670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose                         getLocationOfByte(CS.getStart()),
2145670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose                         /*IsStringLocation*/true,
2146670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose                         getSpecifierRange(startSpecifier, specifierLen));
2147670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose  }
214876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg}
214976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
2150f85626453123f9691bcef13cff963f556e209c27Hans Wennborgvoid CheckFormatHandler::HandlePosition(const char *startPos,
2151f85626453123f9691bcef13cff963f556e209c27Hans Wennborg                                        unsigned posLen) {
2152f85626453123f9691bcef13cff963f556e209c27Hans Wennborg  EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_positional_arg),
2153f85626453123f9691bcef13cff963f556e209c27Hans Wennborg                               getLocationOfByte(startPos),
2154f85626453123f9691bcef13cff963f556e209c27Hans Wennborg                               /*IsStringLocation*/true,
2155f85626453123f9691bcef13cff963f556e209c27Hans Wennborg                               getSpecifierRange(startPos, posLen));
2156f85626453123f9691bcef13cff963f556e209c27Hans Wennborg}
2157f85626453123f9691bcef13cff963f556e209c27Hans Wennborg
2158efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid
2159826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen,
2160826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                     analyze_format_string::PositionContext p) {
216155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier)
216255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << (unsigned) p,
216355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(startPos), /*IsStringLocation*/true,
216455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startPos, posLen));
2165efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek}
2166efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
2167826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos,
2168efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek                                            unsigned posLen) {
216955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier),
217055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               getLocationOfByte(startPos),
217155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               /*IsStringLocation*/true,
217255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               getSpecifierRange(startPos, posLen));
2173efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek}
2174efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
2175826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) {
217650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose  if (!isa<ObjCStringLiteral>(OrigFormatExpr)) {
21770c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek    // The presence of a null character is likely an error.
217855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    EmitFormatDiagnostic(
217955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      S.PDiag(diag::warn_printf_format_string_contains_null_char),
218055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      getLocationOfByte(nullCharacter), /*IsStringLocation*/true,
218155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      getFormatStringRange());
21820c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek  }
2183826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
2184826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
218548716663e421472cbd590af160a372bc490205e8Jordan Rose// Note that this may return NULL if there was an error parsing or building
218648716663e421472cbd590af160a372bc490205e8Jordan Rose// one of the argument expressions.
2187826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const {
218829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  return Args[FirstDataArg + i];
2189826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
21904e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2191826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() {
2192826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    // Does the number of data arguments exceed the number of
2193826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    // format conversions in the format string?
2194826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (!HasVAListArg) {
2195826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      // Find any arguments that weren't covered.
2196826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    CoveredArgs.flip();
2197826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    signed notCoveredArg = CoveredArgs.find_first();
2198826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    if (notCoveredArg >= 0) {
2199826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      assert((unsigned)notCoveredArg < NumDataArgs);
220048716663e421472cbd590af160a372bc490205e8Jordan Rose      if (const Expr *E = getDataArg((unsigned) notCoveredArg)) {
220148716663e421472cbd590af160a372bc490205e8Jordan Rose        SourceLocation Loc = E->getLocStart();
220248716663e421472cbd590af160a372bc490205e8Jordan Rose        if (!S.getSourceManager().isInSystemMacro(Loc)) {
220348716663e421472cbd590af160a372bc490205e8Jordan Rose          EmitFormatDiagnostic(S.PDiag(diag::warn_printf_data_arg_not_used),
220448716663e421472cbd590af160a372bc490205e8Jordan Rose                               Loc, /*IsStringLocation*/false,
220548716663e421472cbd590af160a372bc490205e8Jordan Rose                               getFormatStringRange());
220648716663e421472cbd590af160a372bc490205e8Jordan Rose        }
2207c03f2df2a2b097bf2686bf32411d5022323988b2Bob Wilson      }
2208826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    }
2209826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  }
2210826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
2211826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2212c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool
2213c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex,
2214c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     SourceLocation Loc,
2215c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     const char *startSpec,
2216c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     unsigned specifierLen,
2217c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     const char *csStart,
2218c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     unsigned csLen) {
2219c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2220c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  bool keepGoing = true;
2221c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  if (argIndex < NumDataArgs) {
2222c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // Consider the argument coverered, even though the specifier doesn't
2223c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // make sense.
2224c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    CoveredArgs.set(argIndex);
2225c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  }
2226c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  else {
2227c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // If argIndex exceeds the number of data arguments we
2228c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // don't issue a warning because that is just a cascade of warnings (and
2229c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // they may have intended '%%' anyway). We don't want to continue processing
2230c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // the format string after this point, however, as we will like just get
2231c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // gibberish when trying to match arguments.
2232c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    keepGoing = false;
2233c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  }
2234c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
223555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_conversion)
223655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << StringRef(csStart, csLen),
223755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       Loc, /*IsStringLocation*/true,
223855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpec, specifierLen));
2239c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2240c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  return keepGoing;
2241c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek}
2242c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
224355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid
224455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard TrieuCheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc,
224555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                                      const char *startSpec,
224655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                                      unsigned specifierLen) {
224755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(
224855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    S.PDiag(diag::warn_format_mix_positional_nonpositional_args),
224955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen));
225055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu}
225155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
2252666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool
2253666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs(
2254666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  const analyze_format_string::FormatSpecifier &FS,
2255666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  const analyze_format_string::ConversionSpecifier &CS,
2256666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  const char *startSpecifier, unsigned specifierLen, unsigned argIndex) {
2257666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek
2258666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  if (argIndex >= NumDataArgs) {
225955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    PartialDiagnostic PDiag = FS.usesPositionalArg()
226055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args)
226155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu           << (argIndex+1) << NumDataArgs)
226255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      : S.PDiag(diag::warn_printf_insufficient_data_args);
226355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    EmitFormatDiagnostic(
226455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true,
226555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      getSpecifierRange(startSpecifier, specifierLen));
2266666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek    return false;
2267666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  }
2268666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  return true;
2269666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek}
2270666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek
227155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range>
227255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag,
227355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              SourceLocation Loc,
227455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              bool IsStringLocation,
227555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              Range StringRange,
2276ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                                              ArrayRef<FixItHint> FixIt) {
227729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag,
227855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       Loc, IsStringLocation, StringRange, FixIt);
227955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu}
228055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
228155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \brief If the format string is not within the funcion call, emit a note
228255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// so that the function call and string are in diagnostic messages.
228355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
228470517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param InFunctionCall if true, the format string is within the function
228555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// call and only one diagnostic message will be produced.  Otherwise, an
228655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// extra note will be emitted pointing to location of the format string.
228755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
228855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param ArgumentExpr the expression that is passed as the format string
228955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// argument in the function call.  Used for getting locations when two
229055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostics are emitted.
229155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
229255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param PDiag the callee should already have provided any strings for the
229355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostic message.  This function only adds locations and fixits
229455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// to diagnostics.
229555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
229655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param Loc primary location for diagnostic.  If two diagnostics are
229755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// required, one will be at Loc and a new SourceLocation will be created for
229855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// the other one.
229955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
230055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param IsStringLocation if true, Loc points to the format string should be
230155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// used for the note.  Otherwise, Loc points to the argument list and will
230255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// be used with PDiag.
230355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
230455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param StringRange some or all of the string to highlight.  This is
230555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// templated so it can accept either a CharSourceRange or a SourceRange.
230655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
230770517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param FixIt optional fix it hint for the format string.
230855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range>
230955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(Sema &S, bool InFunctionCall,
231055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              const Expr *ArgumentExpr,
231155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              PartialDiagnostic PDiag,
231255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              SourceLocation Loc,
231355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              bool IsStringLocation,
231455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              Range StringRange,
2315ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                                              ArrayRef<FixItHint> FixIt) {
2316ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  if (InFunctionCall) {
2317ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    const Sema::SemaDiagnosticBuilder &D = S.Diag(Loc, PDiag);
2318ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    D << StringRange;
2319ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end();
2320ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose         I != E; ++I) {
2321ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      D << *I;
2322ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    }
2323ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  } else {
232455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag)
232555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      << ArgumentExpr->getSourceRange();
2326ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2327ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    const Sema::SemaDiagnosticBuilder &Note =
2328ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      S.Diag(IsStringLocation ? Loc : StringRange.getBegin(),
2329ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose             diag::note_format_string_defined);
2330ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2331ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    Note << StringRange;
2332ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end();
2333ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose         I != E; ++I) {
2334ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      Note << *I;
2335ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    }
233655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  }
233755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu}
233855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
2339826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===//
2340826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2341826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace {
2342826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler {
234350687314f87b67073c202fe46d84d12fb55e25cfJordan Rose  bool ObjCContext;
2344826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic:
2345826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  CheckPrintfHandler(Sema &s, const StringLiteral *fexpr,
2346826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                     const Expr *origFormatExpr, unsigned firstDataArg,
234750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                     unsigned numDataArgs, bool isObjC,
2348826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                     const char *beg, bool hasVAListArg,
234929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                     Expr **Args, unsigned NumArgs,
2350ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                     unsigned formatIdx, bool inFunctionCall,
2351ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                     Sema::VariadicCallType CallType)
2352826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
235350687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                       numDataArgs, beg, hasVAListArg, Args, NumArgs,
2354ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                       formatIdx, inFunctionCall, CallType), ObjCContext(isObjC)
2355ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose  {}
2356ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose
2357826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2358826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  bool HandleInvalidPrintfConversionSpecifier(
2359826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const analyze_printf::PrintfSpecifier &FS,
2360826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const char *startSpecifier,
2361826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      unsigned specifierLen);
2362826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2363826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS,
2364826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                             const char *startSpecifier,
2365826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                             unsigned specifierLen);
2366831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  bool checkFormatExpr(const analyze_printf::PrintfSpecifier &FS,
2367831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                       const char *StartSpecifier,
2368831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                       unsigned SpecifierLen,
2369831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                       const Expr *E);
2370831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2371826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k,
2372826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                    const char *startSpecifier, unsigned specifierLen);
2373826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS,
2374826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                           const analyze_printf::OptionalAmount &Amt,
2375826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                           unsigned type,
2376826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                           const char *startSpecifier, unsigned specifierLen);
2377826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  void HandleFlag(const analyze_printf::PrintfSpecifier &FS,
2378826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                  const analyze_printf::OptionalFlag &flag,
2379826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                  const char *startSpecifier, unsigned specifierLen);
2380826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS,
2381826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                         const analyze_printf::OptionalFlag &ignoredFlag,
2382826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                         const analyze_printf::OptionalFlag &flag,
2383826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                         const char *startSpecifier, unsigned specifierLen);
2384f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg  bool checkForCStrMembers(const analyze_printf::ArgType &AT,
2385831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                           const Expr *E, const CharSourceRange &CSR);
2386831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2387826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek};
2388826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
2389826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2390826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier(
2391826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const analyze_printf::PrintfSpecifier &FS,
2392826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const char *startSpecifier,
2393826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      unsigned specifierLen) {
23946ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const analyze_printf::PrintfConversionSpecifier &CS =
2395c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    FS.getConversionSpecifier();
2396826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2397c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  return HandleInvalidConversionSpecifier(FS.getArgIndex(),
2398c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          getLocationOfByte(CS.getStart()),
2399c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          startSpecifier, specifierLen,
2400c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          CS.getStart(), CS.getLength());
240126ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek}
240226ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek
2403826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount(
2404826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                               const analyze_format_string::OptionalAmount &Amt,
2405826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                               unsigned k, const char *startSpecifier,
2406826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                               unsigned specifierLen) {
24070d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek
24080d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  if (Amt.hasDataArgument()) {
24090d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek    if (!HasVAListArg) {
24107f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      unsigned argIndex = Amt.getArgIndex();
24117f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      if (argIndex >= NumDataArgs) {
241255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu        EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg)
241355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               << k,
241455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             getLocationOfByte(Amt.getStart()),
241555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             /*IsStringLocation*/true,
241655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             getSpecifierRange(startSpecifier, specifierLen));
24170d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        // Don't do any more checking.  We will just emit
24180d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        // spurious errors.
24190d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        return false;
24200d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek      }
24214e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
24220d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek      // Type check the data argument.  It should be an 'int'.
242331f8e32788adb299acad455363eb7fd244642c82Ted Kremenek      // Although not in conformance with C99, we also allow the argument to be
242431f8e32788adb299acad455363eb7fd244642c82Ted Kremenek      // an 'unsigned int' as that is a reasonably safe case.  GCC also
242531f8e32788adb299acad455363eb7fd244642c82Ted Kremenek      // doesn't emit a warning for that case.
24267f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      CoveredArgs.set(argIndex);
24277f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      const Expr *Arg = getDataArg(argIndex);
242848716663e421472cbd590af160a372bc490205e8Jordan Rose      if (!Arg)
242948716663e421472cbd590af160a372bc490205e8Jordan Rose        return false;
243048716663e421472cbd590af160a372bc490205e8Jordan Rose
24310d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek      QualType T = Arg->getType();
24324e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2433f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg      const analyze_printf::ArgType &AT = Amt.getArgType(S.Context);
2434f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg      assert(AT.isValid());
24354e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2436f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg      if (!AT.matchesType(S.Context, T)) {
243755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu        EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type)
2438f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg                               << k << AT.getRepresentativeTypeName(S.Context)
243955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               << T << Arg->getSourceRange(),
244055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             getLocationOfByte(Amt.getStart()),
244155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             /*IsStringLocation*/true,
244255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             getSpecifierRange(startSpecifier, specifierLen));
24430d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        // Don't do any more checking.  We will just emit
24440d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        // spurious errors.
24450d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        return false;
24460d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek      }
24470d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek    }
24480d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  }
24490d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  return true;
24500d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek}
24510d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek
2452e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount(
2453826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const analyze_printf::PrintfSpecifier &FS,
2454e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                      const analyze_printf::OptionalAmount &Amt,
2455e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                      unsigned type,
2456e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                      const char *startSpecifier,
2457e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                      unsigned specifierLen) {
24586ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const analyze_printf::PrintfConversionSpecifier &CS =
24596ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek    FS.getConversionSpecifier();
2460e4ee9663168dfb2b4122c768091e30217328c9faTom Care
246155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  FixItHint fixit =
246255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant
246355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(),
246455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                 Amt.getConstantLength()))
246555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      : FixItHint();
246655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
246755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount)
246855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << type << CS.toString(),
246955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(Amt.getStart()),
247055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       /*IsStringLocation*/true,
247155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpecifier, specifierLen),
247255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       fixit);
2473e4ee9663168dfb2b4122c768091e30217328c9faTom Care}
2474e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2475826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS,
2476e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                    const analyze_printf::OptionalFlag &flag,
2477e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                    const char *startSpecifier,
2478e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                    unsigned specifierLen) {
2479e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Warn about pointless flag with a fixit removal.
24806ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const analyze_printf::PrintfConversionSpecifier &CS =
24816ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek    FS.getConversionSpecifier();
248255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag)
248355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << flag.toString() << CS.toString(),
248455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(flag.getPosition()),
248555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       /*IsStringLocation*/true,
248655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpecifier, specifierLen),
248755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       FixItHint::CreateRemoval(
248855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         getSpecifierRange(flag.getPosition(), 1)));
2489e4ee9663168dfb2b4122c768091e30217328c9faTom Care}
2490e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2491e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag(
2492826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                const analyze_printf::PrintfSpecifier &FS,
2493e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                const analyze_printf::OptionalFlag &ignoredFlag,
2494e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                const analyze_printf::OptionalFlag &flag,
2495e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                const char *startSpecifier,
2496e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                unsigned specifierLen) {
2497e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Warn about ignored flag with a fixit removal.
249855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag)
249955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << ignoredFlag.toString() << flag.toString(),
250055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(ignoredFlag.getPosition()),
250155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       /*IsStringLocation*/true,
250255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpecifier, specifierLen),
250355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       FixItHint::CreateRemoval(
250455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         getSpecifierRange(ignoredFlag.getPosition(), 1)));
2505e4ee9663168dfb2b4122c768091e30217328c9faTom Care}
2506e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2507831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determines if the specified is a C++ class or struct containing
2508831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// a member with the specified name and kind (e.g. a CXXMethodDecl named
2509831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// "c_str()").
2510831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithtemplate<typename MemberKind>
2511831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithstatic llvm::SmallPtrSet<MemberKind*, 1>
2512831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCXXRecordMembersNamed(StringRef Name, Sema &S, QualType Ty) {
2513831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  const RecordType *RT = Ty->getAs<RecordType>();
2514831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  llvm::SmallPtrSet<MemberKind*, 1> Results;
2515831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2516831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (!RT)
2517831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return Results;
2518831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl());
2519831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (!RD)
2520831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return Results;
2521831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2522831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  LookupResult R(S, &S.PP.getIdentifierTable().get(Name), SourceLocation(),
2523831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                 Sema::LookupMemberName);
2524831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2525831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // We just need to include all members of the right kind turned up by the
2526831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // filter, at this point.
2527831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (S.LookupQualifiedName(R, RT->getDecl()))
2528831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    for (LookupResult::iterator I = R.begin(), E = R.end(); I != E; ++I) {
2529831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      NamedDecl *decl = (*I)->getUnderlyingDecl();
2530831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      if (MemberKind *FK = dyn_cast<MemberKind>(decl))
2531831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        Results.insert(FK);
2532831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    }
2533831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return Results;
2534831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
2535831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2536831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Check if a (w)string was passed when a (w)char* was needed, and offer a
2537f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg// better diagnostic if so. AT is assumed to be valid.
2538831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Returns true when a c_str() conversion method is found.
2539831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool CheckPrintfHandler::checkForCStrMembers(
2540f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg    const analyze_printf::ArgType &AT, const Expr *E,
2541831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    const CharSourceRange &CSR) {
2542831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  typedef llvm::SmallPtrSet<CXXMethodDecl*, 1> MethodSet;
2543831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2544831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  MethodSet Results =
2545831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      CXXRecordMembersNamed<CXXMethodDecl>("c_str", S, E->getType());
2546831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2547831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  for (MethodSet::iterator MI = Results.begin(), ME = Results.end();
2548831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith       MI != ME; ++MI) {
2549831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    const CXXMethodDecl *Method = *MI;
2550831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    if (Method->getNumParams() == 0 &&
2551f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg          AT.matchesType(S.Context, Method->getResultType())) {
2552831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      // FIXME: Suggest parens if the expression needs them.
2553831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      SourceLocation EndLoc =
2554831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          S.getPreprocessor().getLocForEndOfToken(E->getLocEnd());
2555831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      S.Diag(E->getLocStart(), diag::note_printf_c_str)
2556831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          << "c_str()"
2557831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          << FixItHint::CreateInsertion(EndLoc, ".c_str()");
2558831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      return true;
2559831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    }
2560831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  }
2561831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2562831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return false;
2563831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
2564831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2565e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool
2566826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier
25675c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek                                            &FS,
2568e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek                                          const char *startSpecifier,
2569e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek                                          unsigned specifierLen) {
2570e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
25716ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  using namespace analyze_format_string;
2572efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  using namespace analyze_printf;
25736ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const PrintfConversionSpecifier &CS = FS.getConversionSpecifier();
2574e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2575baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek  if (FS.consumesDataArgument()) {
2576baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    if (atFirstArg) {
2577baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek        atFirstArg = false;
2578baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek        usesPositionalArgs = FS.usesPositionalArg();
2579baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    }
2580baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    else if (usesPositionalArgs != FS.usesPositionalArg()) {
258155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()),
258255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                        startSpecifier, specifierLen);
2583baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek      return false;
2584baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    }
2585efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  }
2586efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
25870d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  // First check if the field width, precision, and conversion specifier
25880d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  // have matching data arguments.
2589efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0,
2590efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek                    startSpecifier, specifierLen)) {
25910d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek    return false;
25920d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  }
25934e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2594efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  if (!HandleAmount(FS.getPrecision(), /* precision */ 1,
2595efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek                    startSpecifier, specifierLen)) {
25960d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek    return false;
25970d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  }
25980d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek
2599f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek  if (!CS.consumesDataArgument()) {
2600f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek    // FIXME: Technically specifying a precision or field width here
2601f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek    // makes no sense.  Worth issuing a warning at some point.
26020e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek    return true;
2603f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek  }
26044e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
26057f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  // Consume the argument.
26067f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  unsigned argIndex = FS.getArgIndex();
2607e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek  if (argIndex < NumDataArgs) {
2608e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek    // The check to see if the argIndex is valid will come later.
2609e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek    // We set the bit here because we may exit early from this
2610e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek    // function if we encounter some other error.
2611e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek    CoveredArgs.set(argIndex);
2612e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek  }
26137f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek
26147f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  // Check for using an Objective-C specific conversion specifier
26157f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  // in a non-ObjC literal.
261650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose  if (!ObjCContext && CS.isObjCArg()) {
2617826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier,
2618826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                                  specifierLen);
26197f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  }
26204e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2621e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check for invalid use of field width
2622e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidFieldWidth()) {
262345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care    HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0,
2624e4ee9663168dfb2b4122c768091e30217328c9faTom Care        startSpecifier, specifierLen);
2625e4ee9663168dfb2b4122c768091e30217328c9faTom Care  }
2626e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2627e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check for invalid use of precision
2628e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidPrecision()) {
2629e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1,
2630e4ee9663168dfb2b4122c768091e30217328c9faTom Care        startSpecifier, specifierLen);
2631e4ee9663168dfb2b4122c768091e30217328c9faTom Care  }
2632e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2633e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check each flag does not conflict with any other component.
263465197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek  if (!FS.hasValidThousandsGroupingPrefix())
263565197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek    HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen);
2636e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidLeadingZeros())
2637e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen);
2638e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidPlusPrefix())
2639e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen);
264045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  if (!FS.hasValidSpacePrefix())
264145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care    HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen);
2642e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidAlternativeForm())
2643e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen);
2644e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidLeftJustified())
2645e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen);
2646e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2647e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check that flags are not ignored by another flag
264845f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+'
264945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care    HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(),
265045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care        startSpecifier, specifierLen);
2651e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-'
2652e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(),
2653e4ee9663168dfb2b4122c768091e30217328c9faTom Care            startSpecifier, specifierLen);
2654e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2655e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check the length modifier is valid with the given conversion specifier.
2656bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo()))
26578be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
26588be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                                diag::warn_format_nonsensical_length);
2659bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  else if (!FS.hasStandardLengthModifier())
26608be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen);
2661bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  else if (!FS.hasStandardLengthConversionCombination())
26628be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
26638be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                                diag::warn_format_non_standard_conversion_spec);
2664e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2665bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  if (!FS.hasStandardConversionSpecifier(S.getLangOpts()))
2666bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose    HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen);
2667bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
2668da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek  // The remaining checks depend on the data arguments.
2669da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek  if (HasVAListArg)
2670da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek    return true;
26714e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2672666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
2673da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek    return false;
26744e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
267548716663e421472cbd590af160a372bc490205e8Jordan Rose  const Expr *Arg = getDataArg(argIndex);
267648716663e421472cbd590af160a372bc490205e8Jordan Rose  if (!Arg)
267748716663e421472cbd590af160a372bc490205e8Jordan Rose    return true;
267848716663e421472cbd590af160a372bc490205e8Jordan Rose
267948716663e421472cbd590af160a372bc490205e8Jordan Rose  return checkFormatExpr(FS, startSpecifier, specifierLen, Arg);
2680831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
2681831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2682ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rosestatic bool requiresParensToAddCast(const Expr *E) {
2683ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  // FIXME: We should have a general way to reason about operator
2684ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  // precedence and whether parens are actually needed here.
2685ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  // Take care of a few common cases where they aren't.
2686ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  const Expr *Inside = E->IgnoreImpCasts();
2687ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  if (const PseudoObjectExpr *POE = dyn_cast<PseudoObjectExpr>(Inside))
2688ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    Inside = POE->getSyntacticForm()->IgnoreImpCasts();
2689ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2690ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  switch (Inside->getStmtClass()) {
2691ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::ArraySubscriptExprClass:
2692ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::CallExprClass:
2693ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::DeclRefExprClass:
2694ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::MemberExprClass:
2695ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::ObjCIvarRefExprClass:
2696ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::ObjCMessageExprClass:
2697ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::ObjCPropertyRefExprClass:
2698ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::ParenExprClass:
2699ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  case Stmt::UnaryOperatorClass:
2700ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    return false;
2701ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  default:
2702ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    return true;
2703ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  }
2704ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose}
2705ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2706831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool
2707831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCheckPrintfHandler::checkFormatExpr(const analyze_printf::PrintfSpecifier &FS,
2708831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                    const char *StartSpecifier,
2709831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                    unsigned SpecifierLen,
2710831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                    const Expr *E) {
2711831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  using namespace analyze_format_string;
2712831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  using namespace analyze_printf;
271396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer  // Now type check the data expression that matches the
271496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer  // format specifier.
2715f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg  const analyze_printf::ArgType &AT = FS.getArgType(S.Context,
2716f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg                                                    ObjCContext);
2717614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  if (!AT.isValid())
2718614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    return true;
2719ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2720ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  QualType IntendedTy = E->getType();
2721ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  if (AT.matchesType(S.Context, IntendedTy))
2722614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    return true;
2723614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose
2724614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  // Look through argument promotions for our error message's reported type.
2725614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  // This includes the integral and floating promotions, but excludes array
2726614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  // and function pointer decay; seeing that an argument intended to be a
2727614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  // string has type 'char [6]' is probably more confusing than 'char *'.
2728614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) {
2729614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    if (ICE->getCastKind() == CK_IntegralCast ||
2730614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        ICE->getCastKind() == CK_FloatingCast) {
2731614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      E = ICE->getSubExpr();
2732ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      IntendedTy = E->getType();
2733614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose
2734614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      // Check if we didn't match because of an implicit cast from a 'char'
2735614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      // or 'short' to an 'int'.  This is done because printf is a varargs
2736614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      // function.
2737614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      if (ICE->getType() == S.Context.IntTy ||
2738614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          ICE->getType() == S.Context.UnsignedIntTy) {
2739614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        // All further checking is done on the subexpression.
2740ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        if (AT.matchesType(S.Context, IntendedTy))
2741614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          return true;
27424d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek      }
2743ee0259d308e72141982a85b40863e760a8447edfJordan Rose    }
2744614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  }
2745614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose
2746ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  if (S.Context.getTargetInfo().getTriple().isOSDarwin()) {
2747ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    // Special-case some of Darwin's platform-independence types.
2748ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    if (const TypedefType *UserTy = IntendedTy->getAs<TypedefType>()) {
2749ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      StringRef Name = UserTy->getDecl()->getName();
2750ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      IntendedTy = llvm::StringSwitch<QualType>(Name)
2751ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        .Case("NSInteger", S.Context.LongTy)
2752ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        .Case("NSUInteger", S.Context.UnsignedLongTy)
2753ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        .Case("SInt32", S.Context.IntTy)
2754ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        .Case("UInt32", S.Context.UnsignedIntTy)
2755ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        .Default(IntendedTy);
2756ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    }
2757ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  }
2758ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2759614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  // We may be able to offer a FixItHint if it is a supported type.
2760614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  PrintfSpecifier fixedFS = FS;
2761ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose  bool success = fixedFS.fixType(IntendedTy, S.getLangOpts(),
2762614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose                                 S.Context, ObjCContext);
276396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer
2764614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  if (success) {
2765614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    // Get the fix string from the fixed format specifier
2766614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    SmallString<16> buf;
2767614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    llvm::raw_svector_ostream os(buf);
2768614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    fixedFS.toString(os);
2769614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose
2770ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    CharSourceRange SpecRange = getSpecifierRange(StartSpecifier, SpecifierLen);
2771ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2772ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    if (IntendedTy != E->getType()) {
2773ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // The canonical type for formatting this value is different from the
2774ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // actual type of the expression. (This occurs, for example, with Darwin's
2775ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // NSInteger on 32-bit platforms, where it is typedef'd as 'int', but
2776ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // should be printed as 'long' for 64-bit compatibility.)
2777ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // Rather than emitting a normal format/argument mismatch, we want to
2778ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // add a cast to the recommended type (and correct the format string
2779ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // if necessary).
2780ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      SmallString<16> CastBuf;
2781ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      llvm::raw_svector_ostream CastFix(CastBuf);
2782ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      CastFix << "(";
2783ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      IntendedTy.print(CastFix, S.Context.getPrintingPolicy());
2784ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      CastFix << ")";
2785ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2786ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      SmallVector<FixItHint,4> Hints;
2787ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      if (!AT.matchesType(S.Context, IntendedTy))
2788ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        Hints.push_back(FixItHint::CreateReplacement(SpecRange, os.str()));
2789ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2790ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      if (const CStyleCastExpr *CCast = dyn_cast<CStyleCastExpr>(E)) {
2791ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        // If there's already a cast present, just replace it.
2792ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        SourceRange CastRange(CCast->getLParenLoc(), CCast->getRParenLoc());
2793ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        Hints.push_back(FixItHint::CreateReplacement(CastRange, CastFix.str()));
2794ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2795ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      } else if (!requiresParensToAddCast(E)) {
2796ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        // If the expression has high enough precedence,
2797ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        // just write the C-style cast.
2798ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(),
2799ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                                                   CastFix.str()));
2800ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      } else {
2801ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        // Otherwise, add parens around the expression as well as the cast.
2802ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        CastFix << "(";
2803ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(),
2804ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                                                   CastFix.str()));
2805ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2806ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        SourceLocation After = S.PP.getLocForEndOfToken(E->getLocEnd());
2807ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        Hints.push_back(FixItHint::CreateInsertion(After, ")"));
2808ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      }
2809ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2810ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // We extract the name from the typedef because we don't want to show
2811ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // the underlying type in the diagnostic.
2812ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      const TypedefType *UserTy = cast<TypedefType>(E->getType());
2813ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      StringRef Name = UserTy->getDecl()->getName();
2814ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose
2815ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      // Finally, emit the diagnostic.
2816ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      EmitFormatDiagnostic(S.PDiag(diag::warn_format_argument_needs_cast)
2817ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                             << Name << IntendedTy
2818ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                             << E->getSourceRange(),
2819ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                           E->getLocStart(), /*IsStringLocation=*/false,
2820ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose                           SpecRange, Hints);
2821ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    } else {
2822ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose      EmitFormatDiagnostic(
2823ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
2824ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose          << AT.getRepresentativeTypeName(S.Context) << IntendedTy
2825ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose          << E->getSourceRange(),
2826ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        E->getLocStart(),
2827ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        /*IsStringLocation*/false,
2828ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        SpecRange,
2829ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose        FixItHint::CreateReplacement(SpecRange, os.str()));
2830ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose    }
2831614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose  } else {
2832614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    const CharSourceRange &CSR = getSpecifierRange(StartSpecifier,
2833614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose                                                   SpecifierLen);
2834614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    // Since the warning for passing non-POD types to variadic functions
2835614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    // was deferred until now, we emit a warning for non-POD
2836614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    // arguments here.
2837614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    if (S.isValidVarArgType(E->getType()) == Sema::VAK_Invalid) {
2838614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      unsigned DiagKind;
2839614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      if (E->getType()->isObjCObjectType())
2840614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        DiagKind = diag::err_cannot_pass_objc_interface_to_vararg_format;
2841614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      else
2842614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        DiagKind = diag::warn_non_pod_vararg_with_format_string;
284396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer
2844614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      EmitFormatDiagnostic(
2845614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        S.PDiag(DiagKind)
2846614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          << S.getLangOpts().CPlusPlus0x
2847614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          << E->getType()
2848614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          << CallType
2849614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          << AT.getRepresentativeTypeName(S.Context)
2850614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          << CSR
2851614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          << E->getSourceRange(),
2852614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        E->getLocStart(), /*IsStringLocation*/false, CSR);
285396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer
2854614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose      checkForCStrMembers(AT, E, CSR);
2855614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose    } else
285655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      EmitFormatDiagnostic(
285755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu        S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
2858f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg          << AT.getRepresentativeTypeName(S.Context) << E->getType()
2859614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose          << CSR
2860831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          << E->getSourceRange(),
2861614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose        E->getLocStart(), /*IsStringLocation*/false, CSR);
286296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer  }
286396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer
2864e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  return true;
2865e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}
2866e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2867826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===//
2868826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2869826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace {
2870826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler {
2871826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic:
2872826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  CheckScanfHandler(Sema &s, const StringLiteral *fexpr,
2873826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                    const Expr *origFormatExpr, unsigned firstDataArg,
287450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                    unsigned numDataArgs, const char *beg, bool hasVAListArg,
287529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                    Expr **Args, unsigned NumArgs,
2876ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                    unsigned formatIdx, bool inFunctionCall,
2877ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                    Sema::VariadicCallType CallType)
2878826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
287950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                       numDataArgs, beg, hasVAListArg,
2880ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                       Args, NumArgs, formatIdx, inFunctionCall, CallType)
2881ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose  {}
2882826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2883826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS,
2884826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                            const char *startSpecifier,
2885826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                            unsigned specifierLen);
2886c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2887c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  bool HandleInvalidScanfConversionSpecifier(
2888c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek          const analyze_scanf::ScanfSpecifier &FS,
2889c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek          const char *startSpecifier,
2890c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek          unsigned specifierLen);
2891b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek
2892b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek  void HandleIncompleteScanList(const char *start, const char *end);
2893826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek};
2894826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
2895826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2896b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start,
2897b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek                                                 const char *end) {
289855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete),
289955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(end), /*IsStringLocation*/true,
290055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(start, end - start));
2901b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek}
2902b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek
2903c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier(
2904c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        const analyze_scanf::ScanfSpecifier &FS,
2905c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        const char *startSpecifier,
2906c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        unsigned specifierLen) {
2907c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
29086ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const analyze_scanf::ScanfConversionSpecifier &CS =
2909c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    FS.getConversionSpecifier();
2910c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2911c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  return HandleInvalidConversionSpecifier(FS.getArgIndex(),
2912c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          getLocationOfByte(CS.getStart()),
2913c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          startSpecifier, specifierLen,
2914c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          CS.getStart(), CS.getLength());
2915c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek}
2916c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2917826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier(
2918826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                       const analyze_scanf::ScanfSpecifier &FS,
2919826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                       const char *startSpecifier,
2920826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                       unsigned specifierLen) {
2921826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2922826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  using namespace analyze_scanf;
2923826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  using namespace analyze_format_string;
2924826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
29256ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const ScanfConversionSpecifier &CS = FS.getConversionSpecifier();
2926826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2927baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek  // Handle case where '%' and '*' don't consume an argument.  These shouldn't
2928baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek  // be used to decide if we are using positional arguments consistently.
2929baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek  if (FS.consumesDataArgument()) {
2930baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    if (atFirstArg) {
2931baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek      atFirstArg = false;
2932baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek      usesPositionalArgs = FS.usesPositionalArg();
2933baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    }
2934baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    else if (usesPositionalArgs != FS.usesPositionalArg()) {
293555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()),
293655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                        startSpecifier, specifierLen);
2937baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek      return false;
2938baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    }
2939826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  }
2940826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2941826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  // Check if the field with is non-zero.
2942826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  const OptionalAmount &Amt = FS.getFieldWidth();
2943826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (Amt.getHowSpecified() == OptionalAmount::Constant) {
2944826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    if (Amt.getConstantAmount() == 0) {
2945826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      const CharSourceRange &R = getSpecifierRange(Amt.getStart(),
2946826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                                   Amt.getConstantLength());
294755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width),
294855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                           getLocationOfByte(Amt.getStart()),
294955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                           /*IsStringLocation*/true, R,
295055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                           FixItHint::CreateRemoval(R));
29517f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek    }
29527f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  }
2953826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2954826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (!FS.consumesDataArgument()) {
2955826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    // FIXME: Technically specifying a precision or field width here
2956826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    // makes no sense.  Worth issuing a warning at some point.
2957826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    return true;
2958826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  }
2959826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2960826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  // Consume the argument.
2961826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  unsigned argIndex = FS.getArgIndex();
2962826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (argIndex < NumDataArgs) {
2963826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      // The check to see if the argIndex is valid will come later.
2964826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      // We set the bit here because we may exit early from this
2965826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      // function if we encounter some other error.
2966826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    CoveredArgs.set(argIndex);
2967826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  }
2968826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
29691e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek  // Check the length modifier is valid with the given conversion specifier.
2970bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo()))
29718be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
29728be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                                diag::warn_format_nonsensical_length);
2973bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  else if (!FS.hasStandardLengthModifier())
29748be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen);
2975bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  else if (!FS.hasStandardLengthConversionCombination())
29768be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose    HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
29778be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose                                diag::warn_format_non_standard_conversion_spec);
297876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
2979bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose  if (!FS.hasStandardConversionSpecifier(S.getLangOpts()))
2980bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose    HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen);
2981bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose
2982826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  // The remaining checks depend on the data arguments.
2983826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (HasVAListArg)
2984826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    return true;
2985826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2986666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
2987826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    return false;
2988826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
29896fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg  // Check that the argument type matches the format specifier.
29906fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg  const Expr *Ex = getDataArg(argIndex);
299148716663e421472cbd590af160a372bc490205e8Jordan Rose  if (!Ex)
299248716663e421472cbd590af160a372bc490205e8Jordan Rose    return true;
299348716663e421472cbd590af160a372bc490205e8Jordan Rose
299458e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg  const analyze_format_string::ArgType &AT = FS.getArgType(S.Context);
299558e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg  if (AT.isValid() && !AT.matchesType(S.Context, Ex->getType())) {
29966fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg    ScanfSpecifier fixedFS = FS;
29974e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie    bool success = fixedFS.fixType(Ex->getType(), S.getLangOpts(),
2998be6126a2a784e1446460b8d15c2b26f880c871fcHans Wennborg                                   S.Context);
29996fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg
30006fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg    if (success) {
30016fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg      // Get the fix string from the fixed format specifier.
3002f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith      SmallString<128> buf;
30036fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg      llvm::raw_svector_ostream os(buf);
30046fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg      fixedFS.toString(os);
30056fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg
30066fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg      EmitFormatDiagnostic(
30076fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg        S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
300858e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg          << AT.getRepresentativeTypeName(S.Context) << Ex->getType()
30096fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg          << Ex->getSourceRange(),
3010abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay        Ex->getLocStart(),
3011abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay        /*IsStringLocation*/false,
30126fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg        getSpecifierRange(startSpecifier, specifierLen),
30136fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg        FixItHint::CreateReplacement(
30146fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg          getSpecifierRange(startSpecifier, specifierLen),
30156fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg          os.str()));
30166fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg    } else {
3017220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas      EmitFormatDiagnostic(
3018220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas        S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
301958e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg          << AT.getRepresentativeTypeName(S.Context) << Ex->getType()
3020220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas          << Ex->getSourceRange(),
3021abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay        Ex->getLocStart(),
3022abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay        /*IsStringLocation*/false,
3023220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas        getSpecifierRange(startSpecifier, specifierLen));
30246fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg    }
30256fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg  }
30266fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg
3027826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  return true;
302807d161f38e708a91486bf1c031d525faebbb249dTed Kremenek}
3029e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
3030826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr,
30310e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek                             const Expr *OrigFormatExpr,
303229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                             Expr **Args, unsigned NumArgs,
303329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                             bool HasVAListArg, unsigned format_idx,
303434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas                             unsigned firstDataArg, FormatStringType Type,
3035ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                             bool inFunctionCall, VariadicCallType CallType) {
3036826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3037e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  // CHECK: is the format string a wide literal?
3038df9ef1bc8c3780307ab2ed81bf5e31c23310b936Richard Smith  if (!FExpr->isAscii() && !FExpr->isUTF8()) {
303955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    CheckFormatHandler::EmitFormatDiagnostic(
304029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas      *this, inFunctionCall, Args[format_idx],
304155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(),
304255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      /*IsStringLocation*/true, OrigFormatExpr->getSourceRange());
3043e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek    return;
3044e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  }
3045826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3046e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  // Str - The format string.  NOTE: this is NOT null-terminated!
30475f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner  StringRef StrRef = FExpr->getString();
30482f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer  const char *Str = StrRef.data();
30492f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer  unsigned StrLen = StrRef.size();
305029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  const unsigned numDataArgs = NumArgs - firstDataArg;
3051826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3052e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  // CHECK: empty format string?
30534cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek  if (StrLen == 0 && numDataArgs > 0) {
305455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    CheckFormatHandler::EmitFormatDiagnostic(
305529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas      *this, inFunctionCall, Args[format_idx],
305655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      PDiag(diag::warn_empty_format_string), FExpr->getLocStart(),
305755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      /*IsStringLocation*/true, OrigFormatExpr->getSourceRange());
3058e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek    return;
3059e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  }
3060826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
306134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  if (Type == FST_Printf || Type == FST_NSString) {
3062826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
306350687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                         numDataArgs, (Type == FST_NSString),
306429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                         Str, HasVAListArg, Args, NumArgs, format_idx,
3065ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                         inFunctionCall, CallType);
3066826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3067d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg    if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen,
3068275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose                                                  getLangOpts(),
3069275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose                                                  Context.getTargetInfo()))
3070826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      H.DoneProcessing();
307134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  } else if (Type == FST_Scanf) {
307250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose    CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, numDataArgs,
307329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                        Str, HasVAListArg, Args, NumArgs, format_idx,
3074ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose                        inFunctionCall, CallType);
3075826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
3076d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg    if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen,
3077275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose                                                 getLangOpts(),
3078275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose                                                 Context.getTargetInfo()))
3079826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      H.DoneProcessing();
308034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  } // TODO: handle other formats
3081ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek}
3082ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek
30837ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth//===--- CHECK: Standard memory functions ---------------------------------===//
30847ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth
30852a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// \brief Determine whether the given type is a dynamic class type (e.g.,
30862a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// whether it has a vtable).
30872a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregorstatic bool isDynamicClassType(QualType T) {
30882a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor  if (CXXRecordDecl *Record = T->getAsCXXRecordDecl())
30892a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor    if (CXXRecordDecl *Definition = Record->getDefinition())
30902a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor      if (Definition->isDynamicClass())
30912a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor        return true;
30922a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor
30932a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor  return false;
30942a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor}
30952a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor
3096a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument expression,
3097000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth/// otherwise returns NULL.
3098000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic const Expr *getSizeOfExprArg(const Expr* E) {
3099e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber  if (const UnaryExprOrTypeTraitExpr *SizeOf =
3100000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      dyn_cast<UnaryExprOrTypeTraitExpr>(E))
3101000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth    if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType())
3102000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      return SizeOf->getArgumentExpr()->IgnoreParenImpCasts();
3103e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber
3104000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  return 0;
3105000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth}
3106000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
3107a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument type.
3108000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic QualType getSizeOfArgType(const Expr* E) {
3109000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  if (const UnaryExprOrTypeTraitExpr *SizeOf =
3110000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      dyn_cast<UnaryExprOrTypeTraitExpr>(E))
3111000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth    if (SizeOf->getKind() == clang::UETT_SizeOf)
3112000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      return SizeOf->getTypeOfArgument();
3113000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
3114000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  return QualType();
3115e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber}
3116e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber
31177ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \brief Check for dangerous or invalid arguments to memset().
31187ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth///
3119929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth/// This issues warnings on known problematic, dangerous or unspecified
3120cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp'
3121cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// function calls.
31227ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth///
31237ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \param Call The call expression to diagnose.
3124cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gayvoid Sema::CheckMemaccessArguments(const CallExpr *Call,
31250a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks                                   unsigned BId,
3126cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay                                   IdentifierInfo *FnName) {
31270a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  assert(BId != 0);
31280a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks
31291d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek  // It is possible to have a non-standard definition of memset.  Validate
3130707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor  // we have enough arguments, and if not, abort further checking.
31310a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  unsigned ExpectedNumArgs = (BId == Builtin::BIstrndup ? 2 : 3);
3132cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber  if (Call->getNumArgs() < ExpectedNumArgs)
31331d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek    return;
31341d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek
31350a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  unsigned LastArg = (BId == Builtin::BImemset ||
31360a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks                      BId == Builtin::BIstrndup ? 1 : 2);
31370a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  unsigned LenArg = (BId == Builtin::BIstrndup ? 1 : 2);
3138cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber  const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts();
3139000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
3140000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  // We have special checking when the length is a sizeof expression.
3141000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  QualType SizeOfArgTy = getSizeOfArgType(LenExpr);
3142000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  const Expr *SizeOfArg = getSizeOfExprArg(LenExpr);
3143000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  llvm::FoldingSetNodeID SizeOfArgID;
3144000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
314506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor  for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) {
314606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor    const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts();
3147e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber    SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange();
314806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor
314906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor    QualType DestTy = Dest->getType();
315006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor    if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) {
315106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor      QualType PointeeTy = DestPtrTy->getPointeeType();
3152f85e193739c953358c865005855253af4f68a497John McCall
3153000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // Never warn about void type pointers. This can be used to suppress
3154000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // false positives.
3155000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      if (PointeeTy->isVoidType())
315606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor        continue;
315706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor
3158000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by
3159000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // actually comparing the expressions for equality. Because computing the
3160000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // expression IDs can be expensive, we only do this if the diagnostic is
3161000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // enabled.
3162000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      if (SizeOfArg &&
3163000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess,
3164000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                                   SizeOfArg->getExprLoc())) {
3165000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        // We only compute IDs for expressions if the warning is enabled, and
3166000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        // cache the sizeof arg's ID.
3167000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        if (SizeOfArgID == llvm::FoldingSetNodeID())
3168000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          SizeOfArg->Profile(SizeOfArgID, Context, true);
3169000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        llvm::FoldingSetNodeID DestID;
3170000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        Dest->Profile(DestID, Context, true);
3171000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        if (DestID == SizeOfArgID) {
3172cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber          // TODO: For strncpy() and friends, this could suggest sizeof(dst)
3173cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber          //       over sizeof(src) as well.
3174000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          unsigned ActionIdx = 0; // Default is to suggest dereferencing.
31756fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          StringRef ReadableName = FnName->getName();
31766fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks
3177000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest))
317890c78328e70cb376754edf87708505a84c044271Anna Zaks            if (UnaryOp->getOpcode() == UO_AddrOf)
3179000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth              ActionIdx = 1; // If its an address-of operator, just remove it.
3180000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          if (Context.getTypeSize(PointeeTy) == Context.getCharWidth())
3181000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth            ActionIdx = 2; // If the pointee's size is sizeof(char),
3182000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                           // suggest an explicit length.
31836fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks
31846fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          // If the function is defined as a builtin macro, do not show macro
31856fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          // expansion.
31866fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          SourceLocation SL = SizeOfArg->getExprLoc();
31876fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          SourceRange DSR = Dest->getSourceRange();
31886fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          SourceRange SSR = SizeOfArg->getSourceRange();
31896fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          SourceManager &SM  = PP.getSourceManager();
31906fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks
31916fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          if (SM.isMacroArgExpansion(SL)) {
31926fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks            ReadableName = Lexer::getImmediateMacroName(SL, SM, LangOpts);
31936fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks            SL = SM.getSpellingLoc(SL);
31946fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks            DSR = SourceRange(SM.getSpellingLoc(DSR.getBegin()),
31956fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks                             SM.getSpellingLoc(DSR.getEnd()));
31966fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks            SSR = SourceRange(SM.getSpellingLoc(SSR.getBegin()),
31976fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks                             SM.getSpellingLoc(SSR.getEnd()));
31986fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          }
31996fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks
320090c78328e70cb376754edf87708505a84c044271Anna Zaks          DiagRuntimeBehavior(SL, SizeOfArg,
3201000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                              PDiag(diag::warn_sizeof_pointer_expr_memaccess)
32026fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks                                << ReadableName
320390c78328e70cb376754edf87708505a84c044271Anna Zaks                                << PointeeTy
320490c78328e70cb376754edf87708505a84c044271Anna Zaks                                << DestTy
32056fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks                                << DSR
320690c78328e70cb376754edf87708505a84c044271Anna Zaks                                << SSR);
320790c78328e70cb376754edf87708505a84c044271Anna Zaks          DiagRuntimeBehavior(SL, SizeOfArg,
320890c78328e70cb376754edf87708505a84c044271Anna Zaks                         PDiag(diag::warn_sizeof_pointer_expr_memaccess_note)
320990c78328e70cb376754edf87708505a84c044271Anna Zaks                                << ActionIdx
321090c78328e70cb376754edf87708505a84c044271Anna Zaks                                << SSR);
321190c78328e70cb376754edf87708505a84c044271Anna Zaks
3212000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          break;
3213000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        }
3214000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      }
3215000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
3216000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // Also check for cases where the sizeof argument is the exact same
3217000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // type as the memory argument, and where it points to a user-defined
3218000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // record type.
3219000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      if (SizeOfArgTy != QualType()) {
3220000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        if (PointeeTy->isRecordType() &&
3221000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth            Context.typesAreCompatible(SizeOfArgTy, DestTy)) {
3222000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest,
3223000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                              PDiag(diag::warn_sizeof_pointer_type_memaccess)
3224000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                                << FnName << SizeOfArgTy << ArgIdx
3225000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                                << PointeeTy << Dest->getSourceRange()
3226000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                                << LenExpr->getSourceRange());
3227000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          break;
3228000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        }
3229e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber      }
3230e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber
323106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor      // Always complain about dynamic classes.
32320a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks      if (isDynamicClassType(PointeeTy)) {
32330a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks
32340a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        unsigned OperationType = 0;
32350a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        // "overwritten" if we're warning about the destination for any call
32360a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        // but memcmp; otherwise a verb appropriate to the call.
32370a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        if (ArgIdx != 0 || BId == Builtin::BImemcmp) {
32380a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks          if (BId == Builtin::BImemcpy)
32390a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            OperationType = 1;
32400a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks          else if(BId == Builtin::BImemmove)
32410a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            OperationType = 2;
32420a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks          else if (BId == Builtin::BImemcmp)
32430a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            OperationType = 3;
32440a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        }
32450a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks
32465c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay        DiagRuntimeBehavior(
32475c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay          Dest->getExprLoc(), Dest,
32485c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay          PDiag(diag::warn_dyn_class_memaccess)
32490a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx)
3250d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks            << FnName << PointeeTy
32510a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            << OperationType
32525c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay            << Call->getCallee()->getSourceRange());
32530a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks      } else if (PointeeTy.hasNonTrivialObjCLifetime() &&
32540a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks               BId != Builtin::BImemset)
32555c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay        DiagRuntimeBehavior(
32565c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay          Dest->getExprLoc(), Dest,
32575c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay          PDiag(diag::warn_arc_object_memaccess)
32585c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay            << ArgIdx << FnName << PointeeTy
32595c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay            << Call->getCallee()->getSourceRange());
3260f85e193739c953358c865005855253af4f68a497John McCall      else
326106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor        continue;
3262f85e193739c953358c865005855253af4f68a497John McCall
3263f85e193739c953358c865005855253af4f68a497John McCall      DiagRuntimeBehavior(
3264f85e193739c953358c865005855253af4f68a497John McCall        Dest->getExprLoc(), Dest,
3265929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth        PDiag(diag::note_bad_memaccess_silence)
326606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor          << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)"));
326706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor      break;
326806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor    }
32697ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth  }
32707ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth}
32717ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth
3272bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// A little helper routine: ignore addition and subtraction of integer literals.
3273bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// This intentionally does not ignore all integer constant expressions because
3274bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// we don't want to remove sizeof().
3275bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekstatic const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) {
3276bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  Ex = Ex->IgnoreParenCasts();
3277bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3278bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  for (;;) {
3279bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex);
3280bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    if (!BO || !BO->isAdditiveOp())
3281bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      break;
3282bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3283bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    const Expr *RHS = BO->getRHS()->IgnoreParenCasts();
3284bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    const Expr *LHS = BO->getLHS()->IgnoreParenCasts();
3285bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3286bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    if (isa<IntegerLiteral>(RHS))
3287bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      Ex = LHS;
3288bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    else if (isa<IntegerLiteral>(LHS))
3289bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      Ex = RHS;
3290bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    else
3291bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      break;
3292bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  }
3293bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3294bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  return Ex;
3295bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek}
3296bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
32970f38acee92014cb15af980808f87144e5564031dAnna Zaksstatic bool isConstantSizeArrayWithMoreThanOneElement(QualType Ty,
32980f38acee92014cb15af980808f87144e5564031dAnna Zaks                                                      ASTContext &Context) {
32990f38acee92014cb15af980808f87144e5564031dAnna Zaks  // Only handle constant-sized or VLAs, but not flexible members.
33000f38acee92014cb15af980808f87144e5564031dAnna Zaks  if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(Ty)) {
33010f38acee92014cb15af980808f87144e5564031dAnna Zaks    // Only issue the FIXIT for arrays of size > 1.
33020f38acee92014cb15af980808f87144e5564031dAnna Zaks    if (CAT->getSize().getSExtValue() <= 1)
33030f38acee92014cb15af980808f87144e5564031dAnna Zaks      return false;
33040f38acee92014cb15af980808f87144e5564031dAnna Zaks  } else if (!Ty->isVariableArrayType()) {
33050f38acee92014cb15af980808f87144e5564031dAnna Zaks    return false;
33060f38acee92014cb15af980808f87144e5564031dAnna Zaks  }
33070f38acee92014cb15af980808f87144e5564031dAnna Zaks  return true;
33080f38acee92014cb15af980808f87144e5564031dAnna Zaks}
33090f38acee92014cb15af980808f87144e5564031dAnna Zaks
3310bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// Warn if the user has made the 'size' argument to strlcpy or strlcat
3311bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// be the size of the source, instead of the destination.
3312bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekvoid Sema::CheckStrlcpycatArguments(const CallExpr *Call,
3313bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek                                    IdentifierInfo *FnName) {
3314bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3315bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // Don't crash if the user has the wrong number of arguments
3316bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (Call->getNumArgs() != 3)
3317bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    return;
3318bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3319bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context);
3320bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context);
3321bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *CompareWithSrc = NULL;
3322bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3323bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // Look for 'strlcpy(dst, x, sizeof(x))'
3324bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (const Expr *Ex = getSizeOfExprArg(SizeArg))
3325bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    CompareWithSrc = Ex;
3326bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  else {
3327bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    // Look for 'strlcpy(dst, x, strlen(x))'
3328bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) {
3329180f47959a066795cc0f409433023af448bb0328Richard Smith      if (SizeCall->isBuiltinCall() == Builtin::BIstrlen
3330bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek          && SizeCall->getNumArgs() == 1)
3331bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek        CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context);
3332bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    }
3333bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  }
3334bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3335bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (!CompareWithSrc)
3336bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    return;
3337bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3338bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // Determine if the argument to sizeof/strlen is equal to the source
3339bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // argument.  In principle there's all kinds of things you could do
3340bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // here, for instance creating an == expression and evaluating it with
3341bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // EvaluateAsBooleanCondition, but this uses a more direct technique:
3342bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg);
3343bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (!SrcArgDRE)
3344bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    return;
3345bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3346bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc);
3347bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (!CompareWithSrcDRE ||
3348bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl())
3349bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    return;
3350bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3351bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *OriginalSizeArg = Call->getArg(2);
3352bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size)
3353bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    << OriginalSizeArg->getSourceRange() << FnName;
3354bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3355bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // Output a FIXIT hint if the destination is an array (rather than a
3356bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // pointer to an array).  This could be enhanced to handle some
3357bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // pointers if we know the actual size, like if DstArg is 'array+2'
3358bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // we could say 'sizeof(array)-2'.
3359bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts();
33600f38acee92014cb15af980808f87144e5564031dAnna Zaks  if (!isConstantSizeArrayWithMoreThanOneElement(DstArg->getType(), Context))
33618f7462237ff542a4556775f98709ed300aa1731aTed Kremenek    return;
33628f7462237ff542a4556775f98709ed300aa1731aTed Kremenek
3363f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith  SmallString<128> sizeString;
33648f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  llvm::raw_svector_ostream OS(sizeString);
33658f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  OS << "sizeof(";
3366d1420c6fa788669e49f21e184927c7833881e399Richard Smith  DstArg->printPretty(OS, 0, getPrintingPolicy());
33678f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  OS << ")";
33688f7462237ff542a4556775f98709ed300aa1731aTed Kremenek
33698f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size)
33708f7462237ff542a4556775f98709ed300aa1731aTed Kremenek    << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(),
33718f7462237ff542a4556775f98709ed300aa1731aTed Kremenek                                    OS.str());
3372bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek}
3373bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3374c36bedc90c687caa71748480c60707ea4608b092Anna Zaks/// Check if two expressions refer to the same declaration.
3375c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic bool referToTheSameDecl(const Expr *E1, const Expr *E2) {
3376c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (const DeclRefExpr *D1 = dyn_cast_or_null<DeclRefExpr>(E1))
3377c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    if (const DeclRefExpr *D2 = dyn_cast_or_null<DeclRefExpr>(E2))
3378c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      return D1->getDecl() == D2->getDecl();
3379c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  return false;
3380c36bedc90c687caa71748480c60707ea4608b092Anna Zaks}
3381c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3382c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic const Expr *getStrlenExprArg(const Expr *E) {
3383c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (const CallExpr *CE = dyn_cast<CallExpr>(E)) {
3384c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    const FunctionDecl *FD = CE->getDirectCallee();
3385c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    if (!FD || FD->getMemoryFunctionKind() != Builtin::BIstrlen)
3386c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      return 0;
3387c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    return CE->getArg(0)->IgnoreParenCasts();
3388c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  }
3389c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  return 0;
3390c36bedc90c687caa71748480c60707ea4608b092Anna Zaks}
3391c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3392c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// Warn on anti-patterns as the 'size' argument to strncat.
3393c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// The correct size argument should look like following:
3394c36bedc90c687caa71748480c60707ea4608b092Anna Zaks//   strncat(dst, src, sizeof(dst) - strlen(dest) - 1);
3395c36bedc90c687caa71748480c60707ea4608b092Anna Zaksvoid Sema::CheckStrncatArguments(const CallExpr *CE,
3396c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                                 IdentifierInfo *FnName) {
3397c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  // Don't crash if the user has the wrong number of arguments.
3398c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (CE->getNumArgs() < 3)
3399c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    return;
3400c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  const Expr *DstArg = CE->getArg(0)->IgnoreParenCasts();
3401c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  const Expr *SrcArg = CE->getArg(1)->IgnoreParenCasts();
3402c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  const Expr *LenArg = CE->getArg(2)->IgnoreParenCasts();
3403c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3404c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  // Identify common expressions, which are wrongly used as the size argument
3405c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  // to strncat and may lead to buffer overflows.
3406c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  unsigned PatternType = 0;
3407c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (const Expr *SizeOfArg = getSizeOfExprArg(LenArg)) {
3408c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    // - sizeof(dst)
3409c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    if (referToTheSameDecl(SizeOfArg, DstArg))
3410c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      PatternType = 1;
3411c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    // - sizeof(src)
3412c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    else if (referToTheSameDecl(SizeOfArg, SrcArg))
3413c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      PatternType = 2;
3414c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  } else if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(LenArg)) {
3415c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    if (BE->getOpcode() == BO_Sub) {
3416c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      const Expr *L = BE->getLHS()->IgnoreParenCasts();
3417c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      const Expr *R = BE->getRHS()->IgnoreParenCasts();
3418c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      // - sizeof(dst) - strlen(dst)
3419c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      if (referToTheSameDecl(DstArg, getSizeOfExprArg(L)) &&
3420c36bedc90c687caa71748480c60707ea4608b092Anna Zaks          referToTheSameDecl(DstArg, getStrlenExprArg(R)))
3421c36bedc90c687caa71748480c60707ea4608b092Anna Zaks        PatternType = 1;
3422c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      // - sizeof(src) - (anything)
3423c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      else if (referToTheSameDecl(SrcArg, getSizeOfExprArg(L)))
3424c36bedc90c687caa71748480c60707ea4608b092Anna Zaks        PatternType = 2;
3425c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    }
3426c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  }
3427c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3428c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (PatternType == 0)
3429c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    return;
3430c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3431afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  // Generate the diagnostic.
3432afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  SourceLocation SL = LenArg->getLocStart();
3433afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  SourceRange SR = LenArg->getSourceRange();
3434afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  SourceManager &SM  = PP.getSourceManager();
3435afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks
3436afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  // If the function is defined as a builtin macro, do not show macro expansion.
3437afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  if (SM.isMacroArgExpansion(SL)) {
3438afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    SL = SM.getSpellingLoc(SL);
3439afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    SR = SourceRange(SM.getSpellingLoc(SR.getBegin()),
3440afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks                     SM.getSpellingLoc(SR.getEnd()));
3441afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  }
3442afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks
34430f38acee92014cb15af980808f87144e5564031dAnna Zaks  // Check if the destination is an array (rather than a pointer to an array).
34440f38acee92014cb15af980808f87144e5564031dAnna Zaks  QualType DstTy = DstArg->getType();
34450f38acee92014cb15af980808f87144e5564031dAnna Zaks  bool isKnownSizeArray = isConstantSizeArrayWithMoreThanOneElement(DstTy,
34460f38acee92014cb15af980808f87144e5564031dAnna Zaks                                                                    Context);
34470f38acee92014cb15af980808f87144e5564031dAnna Zaks  if (!isKnownSizeArray) {
34480f38acee92014cb15af980808f87144e5564031dAnna Zaks    if (PatternType == 1)
34490f38acee92014cb15af980808f87144e5564031dAnna Zaks      Diag(SL, diag::warn_strncat_wrong_size) << SR;
34500f38acee92014cb15af980808f87144e5564031dAnna Zaks    else
34510f38acee92014cb15af980808f87144e5564031dAnna Zaks      Diag(SL, diag::warn_strncat_src_size) << SR;
34520f38acee92014cb15af980808f87144e5564031dAnna Zaks    return;
34530f38acee92014cb15af980808f87144e5564031dAnna Zaks  }
34540f38acee92014cb15af980808f87144e5564031dAnna Zaks
3455c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (PatternType == 1)
3456afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    Diag(SL, diag::warn_strncat_large_size) << SR;
3457c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  else
3458afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    Diag(SL, diag::warn_strncat_src_size) << SR;
3459c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3460f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith  SmallString<128> sizeString;
3461c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  llvm::raw_svector_ostream OS(sizeString);
3462c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  OS << "sizeof(";
3463d1420c6fa788669e49f21e184927c7833881e399Richard Smith  DstArg->printPretty(OS, 0, getPrintingPolicy());
3464c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  OS << ") - ";
3465c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  OS << "strlen(";
3466d1420c6fa788669e49f21e184927c7833881e399Richard Smith  DstArg->printPretty(OS, 0, getPrintingPolicy());
3467c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  OS << ") - 1";
3468c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3469afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  Diag(SL, diag::note_strncat_wrong_size)
3470afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    << FixItHint::CreateReplacement(SR, OS.str());
3471c36bedc90c687caa71748480c60707ea4608b092Anna Zaks}
3472c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
347306de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===//
347406de276fff91264437fa75111ed76de43097e089Ted Kremenek
3475e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
3476e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                     Decl *ParentDecl);
3477e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars,
3478e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                      Decl *ParentDecl);
347906de276fff91264437fa75111ed76de43097e089Ted Kremenek
348006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address
348106de276fff91264437fa75111ed76de43097e089Ted Kremenek///   of a stack variable.
348206de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid
348306de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType,
348406de276fff91264437fa75111ed76de43097e089Ted Kremenek                           SourceLocation ReturnLoc) {
34851eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
348626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  Expr *stackE = 0;
34875f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner  SmallVector<DeclRefExpr *, 8> refVars;
34884e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
348926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  // Perform checking for returned stack addresses, local blocks,
349026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  // label addresses or references to temporaries.
3491f85e193739c953358c865005855253af4f68a497John McCall  if (lhsType->isPointerType() ||
34924e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie      (!getLangOpts().ObjCAutoRefCount && lhsType->isBlockPointerType())) {
3493e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/0);
3494ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump  } else if (lhsType->isReferenceType()) {
3495e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    stackE = EvalVal(RetValExp, refVars, /*ParentDecl=*/0);
349626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  }
349726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
349826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  if (stackE == 0)
349926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    return; // Nothing suspicious was found.
350026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
350126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  SourceLocation diagLoc;
350226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  SourceRange diagRange;
350326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  if (refVars.empty()) {
350426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    diagLoc = stackE->getLocStart();
350526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    diagRange = stackE->getSourceRange();
350626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  } else {
350726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // We followed through a reference variable. 'stackE' contains the
350826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // problematic expression but we will warn at the return statement pointing
350926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // at the reference variable. We will later display the "trail" of
351026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // reference variables using notes.
351126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    diagLoc = refVars[0]->getLocStart();
351226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    diagRange = refVars[0]->getSourceRange();
351326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  }
351426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
351526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var.
351626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref
351726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis                                             : diag::warn_ret_stack_addr)
351826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis     << DR->getDecl()->getDeclName() << diagRange;
351926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  } else if (isa<BlockExpr>(stackE)) { // local block.
352026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(diagLoc, diag::err_ret_local_block) << diagRange;
352126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  } else if (isa<AddrLabelExpr>(stackE)) { // address of label.
352226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(diagLoc, diag::warn_ret_addr_label) << diagRange;
352326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  } else { // local temporary.
352426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref
352526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis                                             : diag::warn_ret_local_temp_addr)
352626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis     << diagRange;
352726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  }
352826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
352926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  // Display the "trail" of reference variables that we followed until we
353026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  // found the problematic expression using notes.
353126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  for (unsigned i = 0, e = refVars.size(); i != e; ++i) {
353226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl());
353326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // If this var binds to another reference var, show the range of the next
353426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // var, otherwise the var binds to the problematic expression, in which case
353526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // show the range of the expression.
353626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange()
353726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis                                  : stackE->getSourceRange();
353826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(VD->getLocation(), diag::note_ref_var_local_bind)
353926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      << VD->getDeclName() << range;
354006de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
354106de276fff91264437fa75111ed76de43097e089Ted Kremenek}
354206de276fff91264437fa75111ed76de43097e089Ted Kremenek
354306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that
354406de276fff91264437fa75111ed76de43097e089Ted Kremenek///  check if the expression in a return statement evaluates to an address
354526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  to a location on the stack, a local block, an address of a label, or a
354626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  reference to local temporary. The recursion is used to traverse the
354706de276fff91264437fa75111ed76de43097e089Ted Kremenek///  AST of the return expression, with recursion backtracking when we
354826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  encounter a subexpression that (1) clearly does not lead to one of the
354926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  above problematic expressions (2) is something we cannot determine leads to
355026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  a problematic expression based on such local checking.
355126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///
355226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  Both EvalAddr and EvalVal follow through reference variables to evaluate
355326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  the expression that they point to. Such variables are added to the
355426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  'refVars' vector so that we know what the reference variable "trail" was.
355506de276fff91264437fa75111ed76de43097e089Ted Kremenek///
3556e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek///  EvalAddr processes expressions that are pointers that are used as
3557e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek///  references (and not L-values).  EvalVal handles all other values.
355826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  At the base case of the recursion is a check for the above problematic
355926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  expressions.
356006de276fff91264437fa75111ed76de43097e089Ted Kremenek///
356106de276fff91264437fa75111ed76de43097e089Ted Kremenek///  This implementation handles:
356206de276fff91264437fa75111ed76de43097e089Ted Kremenek///
356306de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * pointer-to-pointer casts
356406de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * implicit conversions from array references to pointers
356506de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * taking the address of fields
356606de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * arbitrary interplay between "&" and "*" operators
356706de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * pointer arithmetic from an address of a stack variable
356806de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * taking the address of an array element where the array is on the stack
3569e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
3570e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                      Decl *ParentDecl) {
357126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  if (E->isTypeDependent())
357226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      return NULL;
357326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
357406de276fff91264437fa75111ed76de43097e089Ted Kremenek  // We should only be called for evaluating pointer expressions.
35750f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall  assert((E->getType()->isAnyPointerType() ||
3576dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff          E->getType()->isBlockPointerType() ||
3577a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek          E->getType()->isObjCQualifiedIdType()) &&
3578fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner         "EvalAddr only works on pointers");
35791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3580f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne  E = E->IgnoreParens();
3581f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne
358206de276fff91264437fa75111ed76de43097e089Ted Kremenek  // Our "symbolic interpreter" is just a dispatch off the currently
358306de276fff91264437fa75111ed76de43097e089Ted Kremenek  // viewed AST node.  We then recursively traverse the AST by calling
358406de276fff91264437fa75111ed76de43097e089Ted Kremenek  // EvalAddr and EvalVal appropriately.
358506de276fff91264437fa75111ed76de43097e089Ted Kremenek  switch (E->getStmtClass()) {
358626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  case Stmt::DeclRefExprClass: {
358726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    DeclRefExpr *DR = cast<DeclRefExpr>(E);
358826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
358926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
359026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      // If this is a reference variable, follow through to the expression that
359126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      // it points to.
359226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      if (V->hasLocalStorage() &&
359326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis          V->getType()->isReferenceType() && V->hasInit()) {
359426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        // Add the reference variable to the "trail".
359526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        refVars.push_back(DR);
3596e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis        return EvalAddr(V->getInit(), refVars, ParentDecl);
359726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      }
359826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
359926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    return NULL;
360026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  }
360106de276fff91264437fa75111ed76de43097e089Ted Kremenek
3602fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  case Stmt::UnaryOperatorClass: {
3603fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // The only unary operator that make sense to handle here
3604fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // is AddrOf.  All others don't make sense as pointers.
3605fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    UnaryOperator *U = cast<UnaryOperator>(E);
36061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
36072de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    if (U->getOpcode() == UO_AddrOf)
3608e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      return EvalVal(U->getSubExpr(), refVars, ParentDecl);
3609fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    else
3610fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner      return NULL;
3611fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  }
36121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3613fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  case Stmt::BinaryOperatorClass: {
3614fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // Handle pointer arithmetic.  All other binary operators are not valid
3615fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // in this context.
3616fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    BinaryOperator *B = cast<BinaryOperator>(E);
36172de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    BinaryOperatorKind op = B->getOpcode();
36181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
36192de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    if (op != BO_Add && op != BO_Sub)
3620fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner      return NULL;
36211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3622fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    Expr *Base = B->getLHS();
36233907323dd6665c0c4e383435cb145233f4533406Anders Carlsson
3624fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // Determine which argument is the real pointer base.  It could be
3625fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // the RHS argument instead of the LHS.
3626fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    if (!Base->getType()->isPointerType()) Base = B->getRHS();
36271eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3628fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    assert (Base->getType()->isPointerType());
3629e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalAddr(Base, refVars, ParentDecl);
3630fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  }
363161f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff
3632fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  // For conditional operators we need to see if either the LHS or RHS are
3633fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  // valid DeclRefExpr*s.  If one of them is valid, we return it.
3634fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  case Stmt::ConditionalOperatorClass: {
3635fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    ConditionalOperator *C = cast<ConditionalOperator>(E);
36361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3637fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // Handle the GNU extension for missing LHS.
36389ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    if (Expr *lhsExpr = C->getLHS()) {
36399ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    // In C++, we can have a throw-expression, which has 'void' type.
36409ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor      if (!lhsExpr->getType()->isVoidType())
3641e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis        if (Expr* LHS = EvalAddr(lhsExpr, refVars, ParentDecl))
36429ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor          return LHS;
36439ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    }
36449ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor
36459ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    // In C++, we can have a throw-expression, which has 'void' type.
36469ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    if (C->getRHS()->getType()->isVoidType())
36479ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor      return NULL;
364806de276fff91264437fa75111ed76de43097e089Ted Kremenek
3649e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalAddr(C->getRHS(), refVars, ParentDecl);
3650fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  }
365126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
365226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  case Stmt::BlockExprClass:
3653469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall    if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures())
365426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      return E; // local block.
365526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    return NULL;
365626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
365726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  case Stmt::AddrLabelExprClass:
365826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    return E; // address of label.
36591eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
366080ee6e878a169e6255d4686a91bb696151ff229fJohn McCall  case Stmt::ExprWithCleanupsClass:
3661e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,
3662e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                    ParentDecl);
366380ee6e878a169e6255d4686a91bb696151ff229fJohn McCall
366454b5274f2c190331438375ad114dad12ae098b57Ted Kremenek  // For casts, we need to handle conversions from arrays to
366554b5274f2c190331438375ad114dad12ae098b57Ted Kremenek  // pointer values, and pointer-to-pointer conversions.
366649badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor  case Stmt::ImplicitCastExprClass:
36676eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor  case Stmt::CStyleCastExprClass:
3668f85e193739c953358c865005855253af4f68a497John McCall  case Stmt::CXXFunctionalCastExprClass:
36698b9414e868853fc052251455674bf7512261e14aEli Friedman  case Stmt::ObjCBridgedCastExprClass:
36701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  case Stmt::CXXStaticCastExprClass:
36711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  case Stmt::CXXDynamicCastExprClass:
367249badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor  case Stmt::CXXConstCastExprClass:
367349badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor  case Stmt::CXXReinterpretCastExprClass: {
36748b9414e868853fc052251455674bf7512261e14aEli Friedman    Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
36758b9414e868853fc052251455674bf7512261e14aEli Friedman    switch (cast<CastExpr>(E)->getCastKind()) {
36768b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_BitCast:
36778b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_LValueToRValue:
36788b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_NoOp:
36798b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_BaseToDerived:
36808b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_DerivedToBase:
36818b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_UncheckedDerivedToBase:
36828b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_Dynamic:
36838b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_CPointerToObjCPointerCast:
36848b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_BlockPointerToObjCPointerCast:
36858b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_AnyPointerToBlockPointerCast:
3686e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      return EvalAddr(SubExpr, refVars, ParentDecl);
36878b9414e868853fc052251455674bf7512261e14aEli Friedman
36888b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_ArrayToPointerDecay:
3689e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      return EvalVal(SubExpr, refVars, ParentDecl);
36908b9414e868853fc052251455674bf7512261e14aEli Friedman
36918b9414e868853fc052251455674bf7512261e14aEli Friedman    default:
36928b9414e868853fc052251455674bf7512261e14aEli Friedman      return 0;
36938b9414e868853fc052251455674bf7512261e14aEli Friedman    }
3694fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  }
36951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
369603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor  case Stmt::MaterializeTemporaryExprClass:
369703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor    if (Expr *Result = EvalAddr(
369803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor                         cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(),
3699e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                                refVars, ParentDecl))
370003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor      return Result;
370103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor
370203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor    return E;
370303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor
3704fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  // Everything else: we simply don't reason about them.
3705fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  default:
3706fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    return NULL;
370706de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
370806de276fff91264437fa75111ed76de43097e089Ted Kremenek}
37091eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
371006de276fff91264437fa75111ed76de43097e089Ted Kremenek
371106de276fff91264437fa75111ed76de43097e089Ted Kremenek///  EvalVal - This function is complements EvalAddr in the mutual recursion.
371206de276fff91264437fa75111ed76de43097e089Ted Kremenek///   See the comments for EvalAddr for more details.
3713e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
3714e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                     Decl *ParentDecl) {
371568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo {
3716e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek  // We should only be called for evaluating non-pointer expressions, or
3717e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek  // expressions with a pointer type that are not used as references but instead
3718e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek  // are l-values (e.g., DeclRefExpr with a pointer type).
37191eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
372006de276fff91264437fa75111ed76de43097e089Ted Kremenek  // Our "symbolic interpreter" is just a dispatch off the currently
372106de276fff91264437fa75111ed76de43097e089Ted Kremenek  // viewed AST node.  We then recursively traverse the AST by calling
372206de276fff91264437fa75111ed76de43097e089Ted Kremenek  // EvalAddr and EvalVal appropriately.
3723f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne
3724f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne  E = E->IgnoreParens();
372506de276fff91264437fa75111ed76de43097e089Ted Kremenek  switch (E->getStmtClass()) {
372668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek  case Stmt::ImplicitCastExprClass: {
372768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek    ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E);
37285baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall    if (IE->getValueKind() == VK_LValue) {
372968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek      E = IE->getSubExpr();
373068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek      continue;
373168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek    }
373268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek    return NULL;
373368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek  }
373468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek
373580ee6e878a169e6255d4686a91bb696151ff229fJohn McCall  case Stmt::ExprWithCleanupsClass:
3736e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,ParentDecl);
373780ee6e878a169e6255d4686a91bb696151ff229fJohn McCall
3738a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor  case Stmt::DeclRefExprClass: {
373926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // When we hit a DeclRefExpr we are looking at code that refers to a
374026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // variable's name. If it's not a reference variable we check if it has
374126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // local storage within the function, and if so, return the expression.
374206de276fff91264437fa75111ed76de43097e089Ted Kremenek    DeclRefExpr *DR = cast<DeclRefExpr>(E);
37431eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3744e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) {
3745e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      // Check if it refers to itself, e.g. "int& i = i;".
3746e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      if (V == ParentDecl)
3747e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis        return DR;
3748e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis
374926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      if (V->hasLocalStorage()) {
375026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        if (!V->getType()->isReferenceType())
375126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis          return DR;
375226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
375326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        // Reference variable, follow through to the expression that
375426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        // it points to.
375526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        if (V->hasInit()) {
375626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis          // Add the reference variable to the "trail".
375726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis          refVars.push_back(DR);
3758e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis          return EvalVal(V->getInit(), refVars, V);
375926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        }
376026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      }
3761e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    }
37621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
376306de276fff91264437fa75111ed76de43097e089Ted Kremenek    return NULL;
376406de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
37651eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
376606de276fff91264437fa75111ed76de43097e089Ted Kremenek  case Stmt::UnaryOperatorClass: {
376706de276fff91264437fa75111ed76de43097e089Ted Kremenek    // The only unary operator that make sense to handle here
376806de276fff91264437fa75111ed76de43097e089Ted Kremenek    // is Deref.  All others don't resolve to a "name."  This includes
376906de276fff91264437fa75111ed76de43097e089Ted Kremenek    // handling all sorts of rvalues passed to a unary operator.
377006de276fff91264437fa75111ed76de43097e089Ted Kremenek    UnaryOperator *U = cast<UnaryOperator>(E);
37711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
37722de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    if (U->getOpcode() == UO_Deref)
3773e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      return EvalAddr(U->getSubExpr(), refVars, ParentDecl);
377406de276fff91264437fa75111ed76de43097e089Ted Kremenek
377506de276fff91264437fa75111ed76de43097e089Ted Kremenek    return NULL;
377606de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
37771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
377806de276fff91264437fa75111ed76de43097e089Ted Kremenek  case Stmt::ArraySubscriptExprClass: {
377906de276fff91264437fa75111ed76de43097e089Ted Kremenek    // Array subscripts are potential references to data on the stack.  We
378006de276fff91264437fa75111ed76de43097e089Ted Kremenek    // retrieve the DeclRefExpr* for the array variable if it indeed
378106de276fff91264437fa75111ed76de43097e089Ted Kremenek    // has local storage.
3782e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars,ParentDecl);
378306de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
37841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
378506de276fff91264437fa75111ed76de43097e089Ted Kremenek  case Stmt::ConditionalOperatorClass: {
378606de276fff91264437fa75111ed76de43097e089Ted Kremenek    // For conditional operators we need to see if either the LHS or RHS are
378726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // non-NULL Expr's.  If one is non-NULL, we return it.
378806de276fff91264437fa75111ed76de43097e089Ted Kremenek    ConditionalOperator *C = cast<ConditionalOperator>(E);
378906de276fff91264437fa75111ed76de43097e089Ted Kremenek
37903907323dd6665c0c4e383435cb145233f4533406Anders Carlsson    // Handle the GNU extension for missing LHS.
37913907323dd6665c0c4e383435cb145233f4533406Anders Carlsson    if (Expr *lhsExpr = C->getLHS())
3792e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      if (Expr *LHS = EvalVal(lhsExpr, refVars, ParentDecl))
37933907323dd6665c0c4e383435cb145233f4533406Anders Carlsson        return LHS;
37943907323dd6665c0c4e383435cb145233f4533406Anders Carlsson
3795e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalVal(C->getRHS(), refVars, ParentDecl);
379606de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
37971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
379806de276fff91264437fa75111ed76de43097e089Ted Kremenek  // Accesses to members are potential references to data on the stack.
379983f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor  case Stmt::MemberExprClass: {
380006de276fff91264437fa75111ed76de43097e089Ted Kremenek    MemberExpr *M = cast<MemberExpr>(E);
38011eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
380206de276fff91264437fa75111ed76de43097e089Ted Kremenek    // Check for indirect access.  We only want direct field accesses.
3803a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek    if (M->isArrow())
3804a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek      return NULL;
3805a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek
3806a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek    // Check whether the member type is itself a reference, in which case
3807a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek    // we're not going to refer to the member, but to what the member refers to.
3808a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek    if (M->getMemberDecl()->getType()->isReferenceType())
380906de276fff91264437fa75111ed76de43097e089Ted Kremenek      return NULL;
3810a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek
3811e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalVal(M->getBase(), refVars, ParentDecl);
381206de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
38131eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
381403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor  case Stmt::MaterializeTemporaryExprClass:
381503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor    if (Expr *Result = EvalVal(
381603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor                          cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(),
3817e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                               refVars, ParentDecl))
381803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor      return Result;
381903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor
382003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor    return E;
382103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor
382206de276fff91264437fa75111ed76de43097e089Ted Kremenek  default:
382326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // Check that we don't return or take the address of a reference to a
382426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // temporary. This is only useful in C++.
382526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    if (!E->isTypeDependent() && E->isRValue())
382626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      return E;
382726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
382826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // Everything else: we simply don't reason about them.
382906de276fff91264437fa75111ed76de43097e089Ted Kremenek    return NULL;
383006de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
383168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true);
383206de276fff91264437fa75111ed76de43097e089Ted Kremenek}
3833588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek
3834588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===//
3835588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek
3836588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==.
3837588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely
3838588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended.
3839dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieuvoid Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) {
3840dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts();
3841dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  Expr* RightExprSansParen = RHS->IgnoreParenImpCasts();
3842588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek
3843588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  // Special case: check for x == x (which is OK).
3844588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  // Do not emit warnings for such cases.
3845588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen))
3846588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek    if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen))
3847588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek      if (DRL->getDecl() == DRR->getDecl())
3848980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie        return;
38491eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
38501eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
38511b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  // Special case: check for comparisons against literals that can be exactly
38521b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  //  represented by APFloat.  In such cases, do not emit a warning.  This
38531b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  //  is a heuristic: often comparison against such literals are used to
38541b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  //  detect if a value in a variable has not changed.  This clearly can
38551b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  //  lead to false negatives.
3856980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) {
3857980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    if (FLL->isExact())
3858980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie      return;
3859980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  } else
3860980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen))
3861980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie      if (FLR->isExact())
3862980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie        return;
38631eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3864588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  // Check for comparisons with builtin types.
3865980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen))
3866980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    if (CL->isBuiltinCall())
3867980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie      return;
38681eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3869980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen))
3870980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    if (CR->isBuiltinCall())
3871980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie      return;
38721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3873588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  // Emit the diagnostic.
3874980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  Diag(Loc, diag::warn_floatingpoint_eq)
3875980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    << LHS->getSourceRange() << RHS->getSourceRange();
3876588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek}
3877ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
3878f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===//
3879f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===//
3880ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
3881f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace {
3882ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
3883f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued
3884f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression.
3885f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange {
3886f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  /// The number of bits active in the int.
3887f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  unsigned Width;
3888ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
3889f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  /// True if the int is known not to have negative values.
3890f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  bool NonNegative;
389151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3892f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  IntRange(unsigned Width, bool NonNegative)
3893f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    : Width(Width), NonNegative(NonNegative)
3894f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  {}
389551313c39c84407dd6a323be99a8c322bf8d052a9John McCall
38961844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the range of the bool type.
3897f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  static IntRange forBoolType() {
3898f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(1, true);
3899f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  }
390051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
39011844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the range of an opaque value of the given integral type.
39021844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  static IntRange forValueOfType(ASTContext &C, QualType T) {
39031844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    return forValueOfCanonicalType(C,
39041844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall                          T->getCanonicalTypeInternal().getTypePtr());
390551313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
390651313c39c84407dd6a323be99a8c322bf8d052a9John McCall
39071844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the range of an opaque value of a canonical integral type.
39081844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) {
3909f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    assert(T->isCanonicalUnqualified());
391051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3911f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    if (const VectorType *VT = dyn_cast<VectorType>(T))
3912f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      T = VT->getElementType().getTypePtr();
3913f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    if (const ComplexType *CT = dyn_cast<ComplexType>(T))
3914f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      T = CT->getElementType().getTypePtr();
3915323ed74658bc8375278eabf074b4777458376540John McCall
3916091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    // For enum types, use the known bit width of the enumerators.
3917323ed74658bc8375278eabf074b4777458376540John McCall    if (const EnumType *ET = dyn_cast<EnumType>(T)) {
3918323ed74658bc8375278eabf074b4777458376540John McCall      EnumDecl *Enum = ET->getDecl();
39195e1cdac63c3d9c9b32fa41fa0b2d242a58a20d49John McCall      if (!Enum->isCompleteDefinition())
3920091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall        return IntRange(C.getIntWidth(QualType(T, 0)), false);
3921091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall
3922323ed74658bc8375278eabf074b4777458376540John McCall      unsigned NumPositive = Enum->getNumPositiveBits();
3923323ed74658bc8375278eabf074b4777458376540John McCall      unsigned NumNegative = Enum->getNumNegativeBits();
3924323ed74658bc8375278eabf074b4777458376540John McCall
3925323ed74658bc8375278eabf074b4777458376540John McCall      return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0);
3926323ed74658bc8375278eabf074b4777458376540John McCall    }
392751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3928f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    const BuiltinType *BT = cast<BuiltinType>(T);
3929f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    assert(BT->isInteger());
393051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3931f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
393251313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
393351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
39341844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the "target" range of a canonical integral type, i.e.
39351844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// the range of values expressible in the type.
39361844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  ///
39371844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// This matches forValueOfCanonicalType except that enums have the
39381844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// full range of their type, not the range of their enumerators.
39391844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) {
39401844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    assert(T->isCanonicalUnqualified());
39411844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall
39421844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    if (const VectorType *VT = dyn_cast<VectorType>(T))
39431844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      T = VT->getElementType().getTypePtr();
39441844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    if (const ComplexType *CT = dyn_cast<ComplexType>(T))
39451844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      T = CT->getElementType().getTypePtr();
39461844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    if (const EnumType *ET = dyn_cast<EnumType>(T))
394769ff26bd1e7a2faffec0c3b9740cfb0c6bb354c5Douglas Gregor      T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr();
39481844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall
39491844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    const BuiltinType *BT = cast<BuiltinType>(T);
39501844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    assert(BT->isInteger());
39511844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall
39521844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
39531844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  }
39541844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall
39551844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the supremum of two ranges: i.e. their conservative merge.
3956c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall  static IntRange join(IntRange L, IntRange R) {
3957f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(std::max(L.Width, R.Width),
395860fad45739b764886f707bd204eae9ecce6db1f2John McCall                    L.NonNegative && R.NonNegative);
395960fad45739b764886f707bd204eae9ecce6db1f2John McCall  }
396060fad45739b764886f707bd204eae9ecce6db1f2John McCall
39611844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the infinum of two ranges: i.e. their aggressive merge.
3962c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall  static IntRange meet(IntRange L, IntRange R) {
396360fad45739b764886f707bd204eae9ecce6db1f2John McCall    return IntRange(std::min(L.Width, R.Width),
396460fad45739b764886f707bd204eae9ecce6db1f2John McCall                    L.NonNegative || R.NonNegative);
396551313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
3966f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall};
396751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
39680692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, llvm::APSInt &value,
39690692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                              unsigned MaxWidth) {
3970f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (value.isSigned() && value.isNegative())
3971f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(value.getMinSignedBits(), false);
397251313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3973f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (value.getBitWidth() > MaxWidth)
39749f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad    value = value.trunc(MaxWidth);
397551313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3976f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // isNonNegative() just checks the sign bit without considering
3977f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // signedness.
3978f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  return IntRange(value.getActiveBits(), true);
397951313c39c84407dd6a323be99a8c322bf8d052a9John McCall}
398051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
39810692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty,
39820692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                              unsigned MaxWidth) {
3983f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (result.isInt())
3984f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return GetValueRange(C, result.getInt(), MaxWidth);
398551313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3986f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (result.isVector()) {
39870acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall    IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth);
39880acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall    for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) {
39890acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall      IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth);
39900acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall      R = IntRange::join(R, El);
39910acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall    }
3992f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return R;
399351313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
399451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3995f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (result.isComplexInt()) {
3996f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth);
3997f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth);
3998f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange::join(R, I);
3999f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  }
4000f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4001f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // This can happen with lossless casts to intptr_t of "based" lvalues.
4002f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // Assume it might use arbitrary bits.
40030acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall  // FIXME: The only reason we need to pass the type in here is to get
40040acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall  // the sign right on this one case.  It would be nice if APValue
40050acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall  // preserved this.
400665639284118d54ddf2e51a05d2ffccda567fe246Eli Friedman  assert(result.isLValue() || result.isAddrLabelDiff());
40075e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor  return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType());
400851313c39c84407dd6a323be99a8c322bf8d052a9John McCall}
400951313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4010f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the
4011f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take.
4012f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall///
4013f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated
40140692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) {
401551313c39c84407dd6a323be99a8c322bf8d052a9John McCall  E = E->IgnoreParens();
401651313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4017f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // Try a full evaluation first.
4018f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  Expr::EvalResult result;
401951f4708c00110940ca3f337961915f2ca1668375Richard Smith  if (E->EvaluateAsRValue(result, C))
40200acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall    return GetValueRange(C, result.Val, E->getType(), MaxWidth);
402151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4022f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // I think we only want to look through implicit casts here; if the
4023f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // user has an explicit widening cast, we should treat the value as
4024f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // being of the new, wider type.
4025f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) {
4026b17ee5bff0d7986c14cdddb279e0131bd7f9678dEli Friedman    if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue)
4027f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return GetExprRange(C, CE->getSubExpr(), MaxWidth);
402851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
40291844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType());
403051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
40312de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast);
403260fad45739b764886f707bd204eae9ecce6db1f2John McCall
4033f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Assume that non-integer casts can span the full range of the type.
403460fad45739b764886f707bd204eae9ecce6db1f2John McCall    if (!isIntegerCast)
4035f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return OutputTypeRange;
403651313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4037f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange SubRange
4038f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      = GetExprRange(C, CE->getSubExpr(),
4039f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall                     std::min(MaxWidth, OutputTypeRange.Width));
404051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4041f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Bail out if the subexpr's range is as wide as the cast type.
4042f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    if (SubRange.Width >= OutputTypeRange.Width)
4043f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return OutputTypeRange;
404451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4045f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Otherwise, we take the smaller width, and we're non-negative if
4046f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // either the output type or the subexpr is.
4047f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(SubRange.Width,
4048f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall                    SubRange.NonNegative || OutputTypeRange.NonNegative);
4049f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  }
4050f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4051f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
4052f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // If we can fold the condition, just take that operand.
4053f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    bool CondResult;
4054f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C))
4055f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return GetExprRange(C, CondResult ? CO->getTrueExpr()
4056f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall                                        : CO->getFalseExpr(),
4057f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall                          MaxWidth);
4058f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4059f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Otherwise, conservatively merge.
4060f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth);
4061f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth);
4062f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange::join(L, R);
406351313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
406451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
406551313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
406651313c39c84407dd6a323be99a8c322bf8d052a9John McCall    switch (BO->getOpcode()) {
406751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4068f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Boolean-valued operations are single-bit and positive.
40692de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_LAnd:
40702de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_LOr:
40712de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_LT:
40722de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_GT:
40732de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_LE:
40742de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_GE:
40752de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_EQ:
40762de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_NE:
4077f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return IntRange::forBoolType();
407851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4079862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    // The type of the assignments is the type of the LHS, so the RHS
4080862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    // is not necessarily the same type.
40812de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_MulAssign:
40822de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_DivAssign:
40832de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_RemAssign:
40842de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_AddAssign:
40852de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_SubAssign:
4086862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    case BO_XorAssign:
4087862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    case BO_OrAssign:
4088862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall      // TODO: bitfields?
40891844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      return IntRange::forValueOfType(C, E->getType());
4090c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall
4091862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    // Simple assignments just pass through the RHS, which will have
4092862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    // been coerced to the LHS type.
4093862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    case BO_Assign:
4094862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall      // TODO: bitfields?
4095862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall      return GetExprRange(C, BO->getRHS(), MaxWidth);
4096862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall
409751313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // Operations with opaque sources are black-listed.
40982de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_PtrMemD:
40992de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_PtrMemI:
41001844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      return IntRange::forValueOfType(C, E->getType());
410151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
410260fad45739b764886f707bd204eae9ecce6db1f2John McCall    // Bitwise-and uses the *infinum* of the two source ranges.
41032de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_And:
41042de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_AndAssign:
410560fad45739b764886f707bd204eae9ecce6db1f2John McCall      return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth),
410660fad45739b764886f707bd204eae9ecce6db1f2John McCall                            GetExprRange(C, BO->getRHS(), MaxWidth));
410760fad45739b764886f707bd204eae9ecce6db1f2John McCall
410851313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // Left shift gets black-listed based on a judgement call.
41092de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_Shl:
41103aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      // ...except that we want to treat '1 << (blah)' as logically
41113aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      // positive.  It's an important idiom.
41123aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      if (IntegerLiteral *I
41133aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall            = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) {
41143aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall        if (I->getValue() == 1) {
41151844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall          IntRange R = IntRange::forValueOfType(C, E->getType());
41163aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall          return IntRange(R.Width, /*NonNegative*/ true);
41173aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall        }
41183aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      }
41193aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      // fallthrough
41203aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall
41212de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_ShlAssign:
41221844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      return IntRange::forValueOfType(C, E->getType());
412351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
412460fad45739b764886f707bd204eae9ecce6db1f2John McCall    // Right shift by a constant can narrow its left argument.
41252de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_Shr:
41262de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_ShrAssign: {
412760fad45739b764886f707bd204eae9ecce6db1f2John McCall      IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
412860fad45739b764886f707bd204eae9ecce6db1f2John McCall
412960fad45739b764886f707bd204eae9ecce6db1f2John McCall      // If the shift amount is a positive constant, drop the width by
413060fad45739b764886f707bd204eae9ecce6db1f2John McCall      // that much.
413160fad45739b764886f707bd204eae9ecce6db1f2John McCall      llvm::APSInt shift;
413260fad45739b764886f707bd204eae9ecce6db1f2John McCall      if (BO->getRHS()->isIntegerConstantExpr(shift, C) &&
413360fad45739b764886f707bd204eae9ecce6db1f2John McCall          shift.isNonNegative()) {
413460fad45739b764886f707bd204eae9ecce6db1f2John McCall        unsigned zext = shift.getZExtValue();
413560fad45739b764886f707bd204eae9ecce6db1f2John McCall        if (zext >= L.Width)
413660fad45739b764886f707bd204eae9ecce6db1f2John McCall          L.Width = (L.NonNegative ? 0 : 1);
413760fad45739b764886f707bd204eae9ecce6db1f2John McCall        else
413860fad45739b764886f707bd204eae9ecce6db1f2John McCall          L.Width -= zext;
413960fad45739b764886f707bd204eae9ecce6db1f2John McCall      }
414060fad45739b764886f707bd204eae9ecce6db1f2John McCall
414160fad45739b764886f707bd204eae9ecce6db1f2John McCall      return L;
414260fad45739b764886f707bd204eae9ecce6db1f2John McCall    }
414360fad45739b764886f707bd204eae9ecce6db1f2John McCall
414460fad45739b764886f707bd204eae9ecce6db1f2John McCall    // Comma acts as its right operand.
41452de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_Comma:
4146f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return GetExprRange(C, BO->getRHS(), MaxWidth);
4147f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
414860fad45739b764886f707bd204eae9ecce6db1f2John McCall    // Black-list pointer subtractions.
41492de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_Sub:
415051313c39c84407dd6a323be99a8c322bf8d052a9John McCall      if (BO->getLHS()->getType()->isPointerType())
41511844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall        return IntRange::forValueOfType(C, E->getType());
415200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      break;
415300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
415400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // The width of a division result is mostly determined by the size
415500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // of the LHS.
415600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Div: {
415700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      // Don't 'pre-truncate' the operands.
415800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      unsigned opWidth = C.getIntWidth(E->getType());
415900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange L = GetExprRange(C, BO->getLHS(), opWidth);
416000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
416100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      // If the divisor is constant, use that.
416200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      llvm::APSInt divisor;
416300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) {
416400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall        unsigned log2 = divisor.logBase2(); // floor(log_2(divisor))
416500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall        if (log2 >= L.Width)
416600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall          L.Width = (L.NonNegative ? 0 : 1);
416700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall        else
416800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall          L.Width = std::min(L.Width - log2, MaxWidth);
416900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall        return L;
417000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      }
417100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
417200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      // Otherwise, just use the LHS's width.
417300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange R = GetExprRange(C, BO->getRHS(), opWidth);
417400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      return IntRange(L.Width, L.NonNegative && R.NonNegative);
417500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    }
417600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
417700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // The result of a remainder can't be larger than the result of
417800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // either side.
417900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Rem: {
418000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      // Don't 'pre-truncate' the operands.
418100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      unsigned opWidth = C.getIntWidth(E->getType());
418200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange L = GetExprRange(C, BO->getLHS(), opWidth);
418300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange R = GetExprRange(C, BO->getRHS(), opWidth);
418400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
418500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange meet = IntRange::meet(L, R);
418600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      meet.Width = std::min(meet.Width, MaxWidth);
418700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      return meet;
418800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    }
41894e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
419000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // The default behavior is okay for these.
419100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Mul:
419200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Add:
419300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Xor:
419400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Or:
4195f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      break;
419651313c39c84407dd6a323be99a8c322bf8d052a9John McCall    }
4197f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
419800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // The default case is to treat the operation as if it were closed
419900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // on the narrowest type that encompasses both operands.
4200f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
4201f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth);
4202f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange::join(L, R);
420351313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
420451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
420551313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
420651313c39c84407dd6a323be99a8c322bf8d052a9John McCall    switch (UO->getOpcode()) {
420751313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // Boolean-valued operations are white-listed.
42082de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case UO_LNot:
4209f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return IntRange::forBoolType();
421051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
421151313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // Operations with opaque sources are black-listed.
42122de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case UO_Deref:
42132de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case UO_AddrOf: // should be impossible
42141844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      return IntRange::forValueOfType(C, E->getType());
421551313c39c84407dd6a323be99a8c322bf8d052a9John McCall
421651313c39c84407dd6a323be99a8c322bf8d052a9John McCall    default:
4217f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return GetExprRange(C, UO->getSubExpr(), MaxWidth);
421851313c39c84407dd6a323be99a8c322bf8d052a9John McCall    }
421951313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
42208ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor
42218ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor  if (dyn_cast<OffsetOfExpr>(E)) {
42221844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    IntRange::forValueOfType(C, E->getType());
42238ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor  }
422451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4225a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith  if (FieldDecl *BitField = E->getBitField())
4226a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith    return IntRange(BitField->getBitWidthValue(C),
42275e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor                    BitField->getType()->isUnsignedIntegerOrEnumerationType());
4228f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
42291844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  return IntRange::forValueOfType(C, E->getType());
4230f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}
4231f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
42320692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E) {
4233323ed74658bc8375278eabf074b4777458376540John McCall  return GetExprRange(C, E, C.getIntWidth(E->getType()));
4234323ed74658bc8375278eabf074b4777458376540John McCall}
4235323ed74658bc8375278eabf074b4777458376540John McCall
4236f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given
4237f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the
4238f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics.
42390692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const llvm::APFloat &value,
42400692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                 const llvm::fltSemantics &Src,
42410692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                 const llvm::fltSemantics &Tgt) {
4242f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  llvm::APFloat truncated = value;
4243f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4244f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  bool ignored;
4245f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored);
4246f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored);
4247f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4248f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  return truncated.bitwiseIsEqual(value);
424951313c39c84407dd6a323be99a8c322bf8d052a9John McCall}
425051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4251f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given
4252f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the
4253f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics.
4254f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall///
4255f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number).
42560692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const APValue &value,
42570692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                 const llvm::fltSemantics &Src,
42580692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                 const llvm::fltSemantics &Tgt) {
4259f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (value.isFloat())
4260f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IsSameFloatAfterCast(value.getFloat(), Src, Tgt);
4261f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4262f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (value.isVector()) {
4263f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i)
4264f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt))
4265f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall        return false;
4266f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return true;
4267f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  }
4268f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4269f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  assert(value.isComplexFloat());
4270f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) &&
4271f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall          IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt));
4272f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}
4273f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
42740692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC);
4275323ed74658bc8375278eabf074b4777458376540John McCall
4276e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) {
4277e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek  // Suppress cases where we are comparing against an enum constant.
4278e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek  if (const DeclRefExpr *DR =
4279e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek      dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts()))
4280e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek    if (isa<EnumConstantDecl>(DR->getDecl()))
4281e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek      return false;
4282e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek
4283e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek  // Suppress cases where the '0' value is expanded from a macro.
4284e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek  if (E->getLocStart().isMacroID())
4285e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek    return false;
4286e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek
4287323ed74658bc8375278eabf074b4777458376540John McCall  llvm::APSInt Value;
4288323ed74658bc8375278eabf074b4777458376540John McCall  return E->isIntegerConstantExpr(Value, S.Context) && Value == 0;
4289323ed74658bc8375278eabf074b4777458376540John McCall}
4290323ed74658bc8375278eabf074b4777458376540John McCall
4291372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) {
4292372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall  // Strip off implicit integral promotions.
4293372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall  while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) {
429463b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis    if (ICE->getCastKind() != CK_IntegralCast &&
429563b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis        ICE->getCastKind() != CK_NoOp)
4296372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      break;
429763b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis    E = ICE->getSubExpr();
4298372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall  }
4299372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall
4300372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall  return E->getType()->isEnumeralType();
4301372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall}
4302372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall
43030692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) {
43042de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  BinaryOperatorKind op = E->getOpcode();
430514af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor  if (E->isValueDependent())
430614af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor    return;
430714af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor
43082de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  if (op == BO_LT && IsZero(S, E->getRHS())) {
4309323ed74658bc8375278eabf074b4777458376540John McCall    S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
4310372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      << "< 0" << "false" << HasEnumType(E->getLHS())
4311323ed74658bc8375278eabf074b4777458376540John McCall      << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
43122de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  } else if (op == BO_GE && IsZero(S, E->getRHS())) {
4313323ed74658bc8375278eabf074b4777458376540John McCall    S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
4314372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      << ">= 0" << "true" << HasEnumType(E->getLHS())
4315323ed74658bc8375278eabf074b4777458376540John McCall      << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
43162de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  } else if (op == BO_GT && IsZero(S, E->getLHS())) {
4317323ed74658bc8375278eabf074b4777458376540John McCall    S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
4318372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      << "0 >" << "false" << HasEnumType(E->getRHS())
4319323ed74658bc8375278eabf074b4777458376540John McCall      << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
43202de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  } else if (op == BO_LE && IsZero(S, E->getLHS())) {
4321323ed74658bc8375278eabf074b4777458376540John McCall    S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
4322372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      << "0 <=" << "true" << HasEnumType(E->getRHS())
4323323ed74658bc8375278eabf074b4777458376540John McCall      << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
4324323ed74658bc8375278eabf074b4777458376540John McCall  }
4325323ed74658bc8375278eabf074b4777458376540John McCall}
4326323ed74658bc8375278eabf074b4777458376540John McCall
432715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanianstatic void DiagnoseOutOfRangeComparison(Sema &S, BinaryOperator *E,
4328a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian                                         Expr *Constant, Expr *Other,
432915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian                                         llvm::APSInt Value,
4330a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian                                         bool RhsConstant) {
433115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  BinaryOperatorKind op = E->getOpcode();
4332a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  QualType OtherT = Other->getType();
4333a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  QualType ConstantT = Constant->getType();
4334a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  if (S.Context.hasSameUnqualifiedType(OtherT, ConstantT))
433515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    return;
4336a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  assert((OtherT->isIntegerType() && ConstantT->isIntegerType())
433715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian         && "comparison with non-integer type");
4338a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  // FIXME. handle cases for signedness to catch (signed char)N == 200
433915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  IntRange OtherRange = IntRange::forValueOfType(S.Context, OtherT);
4340a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  IntRange LitRange = GetValueRange(S.Context, Value, Value.getBitWidth());
434115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  if (OtherRange.Width >= LitRange.Width)
434215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    return;
434315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  bool IsTrue = true;
434415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  if (op == BO_EQ)
434515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    IsTrue = false;
434615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  else if (op == BO_NE)
434715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    IsTrue = true;
4348a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  else if (RhsConstant) {
434915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    if (op == BO_GT || op == BO_GE)
435015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian      IsTrue = !LitRange.NonNegative;
435115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    else // op == BO_LT || op == BO_LE
435215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian      IsTrue = LitRange.NonNegative;
4353a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  } else {
435415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    if (op == BO_LT || op == BO_LE)
435515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian      IsTrue = !LitRange.NonNegative;
435615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    else // op == BO_GT || op == BO_GE
435715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian      IsTrue = LitRange.NonNegative;
435815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  }
4359a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  SmallString<16> PrettySourceValue(Value.toString(10));
4360a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  S.Diag(E->getOperatorLoc(), diag::warn_out_of_range_compare)
4361a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  << PrettySourceValue << OtherT << IsTrue
436215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
436315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian}
436415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian
4365323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison.  Implements the
4366323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison.
43670692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) {
4368b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc());
4369b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc());
4370323ed74658bc8375278eabf074b4777458376540John McCall}
4371f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4372ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare.
4373ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall///
4374dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu/// \param E the binary operator to check for warnings
43750692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeComparison(Sema &S, BinaryOperator *E) {
4376323ed74658bc8375278eabf074b4777458376540John McCall  // The type the comparison is being performed in.
4377323ed74658bc8375278eabf074b4777458376540John McCall  QualType T = E->getLHS()->getType();
4378323ed74658bc8375278eabf074b4777458376540John McCall  assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType())
4379323ed74658bc8375278eabf074b4777458376540John McCall         && "comparison with mismatched types");
4380ab4702febef82409773f7c80ec02d53ddbb4d80eFariborz Jahanian  if (E->isValueDependent())
4381ab4702febef82409773f7c80ec02d53ddbb4d80eFariborz Jahanian    return AnalyzeImpConvsInComparison(S, E);
4382323ed74658bc8375278eabf074b4777458376540John McCall
438315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  Expr *LHS = E->getLHS()->IgnoreParenImpCasts();
438415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  Expr *RHS = E->getRHS()->IgnoreParenImpCasts();
438515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian
438615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  bool IsComparisonConstant = false;
438715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian
4388a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  // Check whether an integer constant comparison results in a value
438915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  // of 'true' or 'false'.
439015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  if (T->isIntegralType(S.Context)) {
439115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    llvm::APSInt RHSValue;
439215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    bool IsRHSIntegralLiteral =
439315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian      RHS->isIntegerConstantExpr(RHSValue, S.Context);
439415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    llvm::APSInt LHSValue;
439515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    bool IsLHSIntegralLiteral =
439615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian      LHS->isIntegerConstantExpr(LHSValue, S.Context);
439715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    if (IsRHSIntegralLiteral && !IsLHSIntegralLiteral)
439815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian        DiagnoseOutOfRangeComparison(S, E, RHS, LHS, RHSValue, true);
439915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    else if (!IsRHSIntegralLiteral && IsLHSIntegralLiteral)
440015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian      DiagnoseOutOfRangeComparison(S, E, LHS, RHS, LHSValue, false);
440115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian    else
440215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian      IsComparisonConstant =
440315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian        (IsRHSIntegralLiteral && IsLHSIntegralLiteral);
4404a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian  } else if (!T->hasUnsignedIntegerRepresentation())
4405a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian      IsComparisonConstant = E->isIntegerConstantExpr(S.Context);
440615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian
4407323ed74658bc8375278eabf074b4777458376540John McCall  // We don't do anything special if this isn't an unsigned integral
4408323ed74658bc8375278eabf074b4777458376540John McCall  // comparison:  we're only interested in integral comparisons, and
4409323ed74658bc8375278eabf074b4777458376540John McCall  // signed comparisons only happen in cases we don't care to warn about.
44103e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor  //
44113e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor  // We also don't care about value-dependent expressions or expressions
44123e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor  // whose result is a constant.
441315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian  if (!T->hasUnsignedIntegerRepresentation() || IsComparisonConstant)
4414323ed74658bc8375278eabf074b4777458376540John McCall    return AnalyzeImpConvsInComparison(S, E);
441515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian
4416323ed74658bc8375278eabf074b4777458376540John McCall  // Check to see if one of the (unmodified) operands is of different
4417323ed74658bc8375278eabf074b4777458376540John McCall  // signedness.
4418323ed74658bc8375278eabf074b4777458376540John McCall  Expr *signedOperand, *unsignedOperand;
4419dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  if (LHS->getType()->hasSignedIntegerRepresentation()) {
4420dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    assert(!RHS->getType()->hasSignedIntegerRepresentation() &&
4421323ed74658bc8375278eabf074b4777458376540John McCall           "unsigned comparison between two signed integer expressions?");
4422dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    signedOperand = LHS;
4423dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    unsignedOperand = RHS;
4424dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  } else if (RHS->getType()->hasSignedIntegerRepresentation()) {
4425dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    signedOperand = RHS;
4426dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    unsignedOperand = LHS;
4427ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  } else {
4428323ed74658bc8375278eabf074b4777458376540John McCall    CheckTrivialUnsignedComparison(S, E);
4429323ed74658bc8375278eabf074b4777458376540John McCall    return AnalyzeImpConvsInComparison(S, E);
4430ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  }
4431ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
4432323ed74658bc8375278eabf074b4777458376540John McCall  // Otherwise, calculate the effective range of the signed operand.
4433323ed74658bc8375278eabf074b4777458376540John McCall  IntRange signedRange = GetExprRange(S.Context, signedOperand);
4434f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4435323ed74658bc8375278eabf074b4777458376540John McCall  // Go ahead and analyze implicit conversions in the operands.  Note
4436323ed74658bc8375278eabf074b4777458376540John McCall  // that we skip the implicit conversions on both sides.
4437dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc());
4438dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc());
4439ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
4440323ed74658bc8375278eabf074b4777458376540John McCall  // If the signed range is non-negative, -Wsign-compare won't fire,
4441323ed74658bc8375278eabf074b4777458376540John McCall  // but we should still check for comparisons which are always true
4442323ed74658bc8375278eabf074b4777458376540John McCall  // or false.
4443323ed74658bc8375278eabf074b4777458376540John McCall  if (signedRange.NonNegative)
4444323ed74658bc8375278eabf074b4777458376540John McCall    return CheckTrivialUnsignedComparison(S, E);
4445ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
4446ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  // For (in)equality comparisons, if the unsigned operand is a
4447ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  // constant which cannot collide with a overflowed signed operand,
4448ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  // then reinterpreting the signed operand as unsigned will not
4449ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  // change the result of the comparison.
4450323ed74658bc8375278eabf074b4777458376540John McCall  if (E->isEqualityOp()) {
4451323ed74658bc8375278eabf074b4777458376540John McCall    unsigned comparisonWidth = S.Context.getIntWidth(T);
4452323ed74658bc8375278eabf074b4777458376540John McCall    IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand);
4453323ed74658bc8375278eabf074b4777458376540John McCall
4454323ed74658bc8375278eabf074b4777458376540John McCall    // We should never be unable to prove that the unsigned operand is
4455323ed74658bc8375278eabf074b4777458376540John McCall    // non-negative.
4456323ed74658bc8375278eabf074b4777458376540John McCall    assert(unsignedRange.NonNegative && "unsigned range includes negative?");
4457ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
4458323ed74658bc8375278eabf074b4777458376540John McCall    if (unsignedRange.Width < comparisonWidth)
4459323ed74658bc8375278eabf074b4777458376540John McCall      return;
4460323ed74658bc8375278eabf074b4777458376540John McCall  }
4461323ed74658bc8375278eabf074b4777458376540John McCall
44626d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor  S.DiagRuntimeBehavior(E->getOperatorLoc(), E,
44636d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor    S.PDiag(diag::warn_mixed_sign_comparison)
44646d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor      << LHS->getType() << RHS->getType()
44656d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor      << LHS->getSourceRange() << RHS->getSourceRange());
4466ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall}
4467ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
446815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield.
446915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall///
447015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt.
44710692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init,
44720692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                      SourceLocation InitLoc) {
447315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  assert(Bitfield->isBitField());
447415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  if (Bitfield->isInvalidDecl())
447515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    return false;
447615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
447791b6014876e9186f968f74a8975ab8fc08ef1b68John McCall  // White-list bool bitfields.
447891b6014876e9186f968f74a8975ab8fc08ef1b68John McCall  if (Bitfield->getType()->isBooleanType())
447991b6014876e9186f968f74a8975ab8fc08ef1b68John McCall    return false;
448091b6014876e9186f968f74a8975ab8fc08ef1b68John McCall
448146ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor  // Ignore value- or type-dependent expressions.
448246ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor  if (Bitfield->getBitWidth()->isValueDependent() ||
448346ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor      Bitfield->getBitWidth()->isTypeDependent() ||
448446ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor      Init->isValueDependent() ||
448546ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor      Init->isTypeDependent())
448646ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor    return false;
448746ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor
448815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  Expr *OriginalInit = Init->IgnoreParenImpCasts();
448915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
449080d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith  llvm::APSInt Value;
449180d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith  if (!OriginalInit->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects))
449215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    return false;
449315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
449415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  unsigned OriginalWidth = Value.getBitWidth();
4495a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith  unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context);
449615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
449715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  if (OriginalWidth <= FieldWidth)
449815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    return false;
449915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
45003a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  // Compute the value which the bitfield will contain.
45019f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad  llvm::APSInt TruncatedValue = Value.trunc(FieldWidth);
45023a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  TruncatedValue.setIsSigned(Bitfield->getType()->isSignedIntegerType());
450315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
45043a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  // Check whether the stored value is equal to the original value.
45053a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  TruncatedValue = TruncatedValue.extend(OriginalWidth);
4506e1ecdc168175719d74e112bcacd4aae5e12d4631Richard Trieu  if (llvm::APSInt::isSameValue(Value, TruncatedValue))
450715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    return false;
450815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
45093a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  // Special-case bitfields of width 1: booleans are naturally 0/1, and
451034ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman  // therefore don't strictly fit into a signed bitfield of width 1.
451134ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman  if (FieldWidth == 1 && Value == 1)
45123a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman    return false;
45133a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman
451415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  std::string PrettyValue = Value.toString(10);
451515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  std::string PrettyTrunc = TruncatedValue.toString(10);
451615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
451715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant)
451815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    << PrettyValue << PrettyTrunc << OriginalInit->getType()
451915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    << Init->getSourceRange();
452015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
452115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  return true;
452215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall}
452315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
4524beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy
4525beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations.
45260692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeAssignment(Sema &S, BinaryOperator *E) {
4527beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  // Just recurse on the LHS.
4528beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc());
4529beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall
4530beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  // We want to recurse on the RHS as normal unless we're assigning to
4531beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  // a bitfield.
4532beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  if (FieldDecl *Bitfield = E->getLHS()->getBitField()) {
453315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(),
453415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall                                  E->getOperatorLoc())) {
453515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall      // Recurse, ignoring any implicit conversions on the RHS.
453615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall      return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(),
453715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall                                        E->getOperatorLoc());
4538beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall    }
4539beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  }
4540beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall
4541beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc());
4542beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall}
4543beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall
454451313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast;  purely a helper for CheckImplicitConversion.
45450692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T,
4546c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            SourceLocation CContext, unsigned diag,
4547c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            bool pruneControlFlow = false) {
4548c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (pruneControlFlow) {
4549c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    S.DiagRuntimeBehavior(E->getExprLoc(), E,
4550c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                          S.PDiag(diag)
4551c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            << SourceType << T << E->getSourceRange()
4552c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            << SourceRange(CContext));
4553c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    return;
4554c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  }
45555a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  S.Diag(E->getExprLoc(), diag)
45565a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor    << SourceType << T << E->getSourceRange() << SourceRange(CContext);
45575a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor}
45585a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor
4559e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast;  purely a helper for CheckImplicitConversion.
45600692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType T,
4561c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            SourceLocation CContext, unsigned diag,
4562c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            bool pruneControlFlow = false) {
4563c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow);
4564e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth}
4565e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth
45669ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// Diagnose an implicit cast from a literal expression. Does not warn when the
45679ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// cast wouldn't lose information.
4568f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruthvoid DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T,
4569f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth                                    SourceLocation CContext) {
45709ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay  // Try to convert the literal exactly to an integer. If we can, don't warn.
4571f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth  bool isExact = false;
45729ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay  const llvm::APFloat &Value = FL->getValue();
45733e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin  llvm::APSInt IntegerValue(S.Context.getIntWidth(T),
45743e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin                            T->hasUnsignedIntegerRepresentation());
45753e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin  if (Value.convertToInteger(IntegerValue,
4576f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth                             llvm::APFloat::rmTowardZero, &isExact)
45779ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay      == llvm::APFloat::opOK && isExact)
4578f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth    return;
4579f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth
4580be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  SmallString<16> PrettySourceValue;
4581be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  Value.toString(PrettySourceValue);
4582de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie  SmallString<16> PrettyTargetValue;
4583be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  if (T->isSpecificBuiltinType(BuiltinType::Bool))
4584be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    PrettyTargetValue = IntegerValue == 0 ? "false" : "true";
4585be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  else
4586de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie    IntegerValue.toString(PrettyTargetValue);
4587be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie
45889ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay  S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer)
4589be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    << FL->getType() << T.getUnqualifiedType() << PrettySourceValue
4590be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    << PrettyTargetValue << FL->getSourceRange() << SourceRange(CContext);
4591f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth}
4592f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth
4593091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) {
4594091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall  if (!Range.Width) return "0";
4595091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall
4596091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall  llvm::APSInt ValueInRange = Value;
4597091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall  ValueInRange.setIsSigned(!Range.NonNegative);
45989f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad  ValueInRange = ValueInRange.trunc(Range.Width);
4599091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall  return ValueInRange.toString(10);
4600091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall}
4601091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall
460288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgstatic bool IsImplicitBoolFloatConversion(Sema &S, Expr *Ex, bool ToBool) {
460388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  if (!isa<ImplicitCastExpr>(Ex))
460488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    return false;
460588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
460688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  Expr *InnerE = Ex->IgnoreParenImpCasts();
460788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  const Type *Target = S.Context.getCanonicalType(Ex->getType()).getTypePtr();
460888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  const Type *Source =
460988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    S.Context.getCanonicalType(InnerE->getType()).getTypePtr();
461088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  if (Target->isDependentType())
461188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    return false;
461288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
461388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  const BuiltinType *FloatCandidateBT =
461488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    dyn_cast<BuiltinType>(ToBool ? Source : Target);
461588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  const Type *BoolCandidateType = ToBool ? Target : Source;
461688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
461788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  return (BoolCandidateType->isSpecificBuiltinType(BuiltinType::Bool) &&
461888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg          FloatCandidateBT && (FloatCandidateBT->isFloatingPoint()));
461988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg}
462088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
462188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgvoid CheckImplicitArgumentConversions(Sema &S, CallExpr *TheCall,
462288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg                                      SourceLocation CC) {
462388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  unsigned NumArgs = TheCall->getNumArgs();
462488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  for (unsigned i = 0; i < NumArgs; ++i) {
462588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    Expr *CurrA = TheCall->getArg(i);
462688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    if (!IsImplicitBoolFloatConversion(S, CurrA, true))
462788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      continue;
462888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
462988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    bool IsSwapped = ((i > 0) &&
463088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        IsImplicitBoolFloatConversion(S, TheCall->getArg(i - 1), false));
463188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    IsSwapped |= ((i < (NumArgs - 1)) &&
463288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        IsImplicitBoolFloatConversion(S, TheCall->getArg(i + 1), false));
463388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    if (IsSwapped) {
463488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      // Warn on this floating-point to bool conversion.
463588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      DiagnoseImpCast(S, CurrA->IgnoreParenImpCasts(),
463688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg                      CurrA->getType(), CC,
463788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg                      diag::warn_impcast_floating_point_to_bool);
463888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    }
463988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  }
464088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg}
464188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
4642323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T,
4643b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall                             SourceLocation CC, bool *ICContext = 0) {
4644323ed74658bc8375278eabf074b4777458376540John McCall  if (E->isTypeDependent() || E->isValueDependent()) return;
464551313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4646323ed74658bc8375278eabf074b4777458376540John McCall  const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr();
4647323ed74658bc8375278eabf074b4777458376540John McCall  const Type *Target = S.Context.getCanonicalType(T).getTypePtr();
4648323ed74658bc8375278eabf074b4777458376540John McCall  if (Source == Target) return;
4649323ed74658bc8375278eabf074b4777458376540John McCall  if (Target->isDependentType()) return;
465051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4651108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // If the conversion context location is invalid don't complain. We also
4652108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // don't want to emit a warning if the issue occurs from the expansion of
4653108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // a system macro. The problem is that 'getSpellingLoc()' is slow, so we
4654108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // delay this check as long as possible. Once we detect we are in that
4655108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // scenario, we just return.
4656ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek  if (CC.isInvalid())
4657b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return;
4658b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall
4659f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  // Diagnose implicit casts to bool.
4660f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  if (Target->isSpecificBuiltinType(BuiltinType::Bool)) {
4661f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu    if (isa<StringLiteral>(E))
4662f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      // Warn on string literal to bool.  Checks for string literals in logical
4663f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      // expressions, for instances, assert(0 && "error here"), is prevented
4664f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      // by a check in AnalyzeImplicitConversions().
4665f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      return DiagnoseImpCast(S, E, T, CC,
4666f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu                             diag::warn_impcast_string_literal_to_bool);
4667e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames    if (Source->isFunctionType()) {
4668e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      // Warn on function to bool. Checks free functions and static member
4669e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      // functions. Weakly imported functions are excluded from the check,
4670e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      // since it's common to test their value to check whether the linker
4671e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      // found a definition for them.
4672e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      ValueDecl *D = 0;
4673e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      if (DeclRefExpr* R = dyn_cast<DeclRefExpr>(E)) {
4674e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames        D = R->getDecl();
4675e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) {
4676e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames        D = M->getMemberDecl();
4677e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      }
4678e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames
4679e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      if (D && !D->isWeak()) {
468026b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu        if (FunctionDecl* F = dyn_cast<FunctionDecl>(D)) {
468126b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu          S.Diag(E->getExprLoc(), diag::warn_impcast_function_to_bool)
468226b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu            << F << E->getSourceRange() << SourceRange(CC);
46832def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          S.Diag(E->getExprLoc(), diag::note_function_to_bool_silence)
46842def77399ab3088106a2d61372344f5b7104e1a2David Blaikie            << FixItHint::CreateInsertion(E->getExprLoc(), "&");
46852def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          QualType ReturnType;
46862def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          UnresolvedSet<4> NonTemplateOverloads;
46872def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          S.isExprCallable(*E, ReturnType, NonTemplateOverloads);
46882def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          if (!ReturnType.isNull()
46892def77399ab3088106a2d61372344f5b7104e1a2David Blaikie              && ReturnType->isSpecificBuiltinType(BuiltinType::Bool))
46902def77399ab3088106a2d61372344f5b7104e1a2David Blaikie            S.Diag(E->getExprLoc(), diag::note_function_to_bool_call)
46912def77399ab3088106a2d61372344f5b7104e1a2David Blaikie              << FixItHint::CreateInsertion(
46922def77399ab3088106a2d61372344f5b7104e1a2David Blaikie                 S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()), "()");
469326b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu          return;
469426b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu        }
4695e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      }
4696e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames    }
4697f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  }
469851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
469951313c39c84407dd6a323be99a8c322bf8d052a9John McCall  // Strip vector types.
470051313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (isa<VectorType>(Source)) {
4701ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    if (!isa<VectorType>(Target)) {
4702d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay      if (S.SourceMgr.isInSystemMacro(CC))
4703ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek        return;
4704b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall      return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar);
4705ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    }
4706b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner
4707b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner    // If the vector cast is cast between two vectors of the same size, it is
4708b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner    // a bitcast, not a conversion.
4709b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner    if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target))
4710b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner      return;
471151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
471251313c39c84407dd6a323be99a8c322bf8d052a9John McCall    Source = cast<VectorType>(Source)->getElementType().getTypePtr();
471351313c39c84407dd6a323be99a8c322bf8d052a9John McCall    Target = cast<VectorType>(Target)->getElementType().getTypePtr();
471451313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
471551313c39c84407dd6a323be99a8c322bf8d052a9John McCall
471651313c39c84407dd6a323be99a8c322bf8d052a9John McCall  // Strip complex types.
471751313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (isa<ComplexType>(Source)) {
4718ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    if (!isa<ComplexType>(Target)) {
4719d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay      if (S.SourceMgr.isInSystemMacro(CC))
4720ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek        return;
4721ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4722b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall      return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar);
4723ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    }
472451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
472551313c39c84407dd6a323be99a8c322bf8d052a9John McCall    Source = cast<ComplexType>(Source)->getElementType().getTypePtr();
472651313c39c84407dd6a323be99a8c322bf8d052a9John McCall    Target = cast<ComplexType>(Target)->getElementType().getTypePtr();
472751313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
472851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
472951313c39c84407dd6a323be99a8c322bf8d052a9John McCall  const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source);
473051313c39c84407dd6a323be99a8c322bf8d052a9John McCall  const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target);
473151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
473251313c39c84407dd6a323be99a8c322bf8d052a9John McCall  // If the source is floating point...
473351313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (SourceBT && SourceBT->isFloatingPoint()) {
473451313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // ...and the target is floating point...
473551313c39c84407dd6a323be99a8c322bf8d052a9John McCall    if (TargetBT && TargetBT->isFloatingPoint()) {
473651313c39c84407dd6a323be99a8c322bf8d052a9John McCall      // ...then warn if we're dropping FP rank.
473751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
473851313c39c84407dd6a323be99a8c322bf8d052a9John McCall      // Builtin FP kinds are ordered by increasing FP rank.
473951313c39c84407dd6a323be99a8c322bf8d052a9John McCall      if (SourceBT->getKind() > TargetBT->getKind()) {
474051313c39c84407dd6a323be99a8c322bf8d052a9John McCall        // Don't warn about float constants that are precisely
474151313c39c84407dd6a323be99a8c322bf8d052a9John McCall        // representable in the target type.
474251313c39c84407dd6a323be99a8c322bf8d052a9John McCall        Expr::EvalResult result;
474351f4708c00110940ca3f337961915f2ca1668375Richard Smith        if (E->EvaluateAsRValue(result, S.Context)) {
474451313c39c84407dd6a323be99a8c322bf8d052a9John McCall          // Value might be a float, a float vector, or a float complex.
474551313c39c84407dd6a323be99a8c322bf8d052a9John McCall          if (IsSameFloatAfterCast(result.Val,
4746323ed74658bc8375278eabf074b4777458376540John McCall                   S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)),
4747323ed74658bc8375278eabf074b4777458376540John McCall                   S.Context.getFloatTypeSemantics(QualType(SourceBT, 0))))
474851313c39c84407dd6a323be99a8c322bf8d052a9John McCall            return;
474951313c39c84407dd6a323be99a8c322bf8d052a9John McCall        }
475051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4751d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay        if (S.SourceMgr.isInSystemMacro(CC))
4752ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek          return;
4753ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4754b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall        DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision);
475551313c39c84407dd6a323be99a8c322bf8d052a9John McCall      }
475651313c39c84407dd6a323be99a8c322bf8d052a9John McCall      return;
475751313c39c84407dd6a323be99a8c322bf8d052a9John McCall    }
475851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4759ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    // If the target is integral, always warn.
4760be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    if (TargetBT && TargetBT->isInteger()) {
4761d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay      if (S.SourceMgr.isInSystemMacro(CC))
4762ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek        return;
4763ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4764a5b9332418f25338f118358e27303cd510d54107Chandler Carruth      Expr *InnerE = E->IgnoreParenImpCasts();
4765634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay      // We also want to warn on, e.g., "int i = -1.234"
4766634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay      if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE))
4767634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay        if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus)
4768634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay          InnerE = UOp->getSubExpr()->IgnoreParenImpCasts();
4769634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay
4770f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth      if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) {
4771f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth        DiagnoseFloatingLiteralImpCast(S, FL, T, CC);
4772a5b9332418f25338f118358e27303cd510d54107Chandler Carruth      } else {
4773a5b9332418f25338f118358e27303cd510d54107Chandler Carruth        DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer);
4774a5b9332418f25338f118358e27303cd510d54107Chandler Carruth      }
4775a5b9332418f25338f118358e27303cd510d54107Chandler Carruth    }
477651313c39c84407dd6a323be99a8c322bf8d052a9John McCall
477788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    // If the target is bool, warn if expr is a function or method call.
477888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    if (Target->isSpecificBuiltinType(BuiltinType::Bool) &&
477988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        isa<CallExpr>(E)) {
478088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      // Check last argument of function call to see if it is an
478188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      // implicit cast from a type matching the type the result
478288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      // is being cast to.
478388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      CallExpr *CEx = cast<CallExpr>(E);
478488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      unsigned NumArgs = CEx->getNumArgs();
478588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      if (NumArgs > 0) {
478688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        Expr *LastA = CEx->getArg(NumArgs - 1);
478788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        Expr *InnerE = LastA->IgnoreParenImpCasts();
478888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        const Type *InnerType =
478988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg          S.Context.getCanonicalType(InnerE->getType()).getTypePtr();
479088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        if (isa<ImplicitCastExpr>(LastA) && (InnerType == Target)) {
479188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg          // Warn on this floating-point to bool conversion
479288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg          DiagnoseImpCast(S, E, T, CC,
479388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg                          diag::warn_impcast_floating_point_to_bool);
479488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg        }
479588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg      }
479688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    }
479751313c39c84407dd6a323be99a8c322bf8d052a9John McCall    return;
479851313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
479951313c39c84407dd6a323be99a8c322bf8d052a9John McCall
48001838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu  if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull)
4801b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie           == Expr::NPCK_GNUNull) && !Target->isAnyPointerType()
480228a5f0cdfcc927a94c1bda6a225200762df22411David Blaikie      && !Target->isBlockPointerType() && !Target->isMemberPointerType()) {
4803b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie    SourceLocation Loc = E->getSourceRange().getBegin();
4804b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie    if (Loc.isMacroID())
4805b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie      Loc = S.SourceMgr.getImmediateExpansionRange(Loc).first;
48069fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie    if (!Loc.isMacroID() || CC.isMacroID())
48079fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie      S.Diag(Loc, diag::warn_impcast_null_pointer_to_integer)
48089fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie          << T << clang::SourceRange(CC)
48099fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie          << FixItHint::CreateReplacement(Loc, S.getFixItZeroLiteralForType(T));
48101838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu  }
48111838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu
4812b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie  if (!Source->isIntegerType() || !Target->isIntegerType())
4813b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie    return;
4814b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie
4815be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  // TODO: remove this early return once the false positives for constant->bool
4816be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  // in templates, macros, etc, are reduced or removed.
4817be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  if (Target->isSpecificBuiltinType(BuiltinType::Bool))
4818be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    return;
4819be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie
4820323ed74658bc8375278eabf074b4777458376540John McCall  IntRange SourceRange = GetExprRange(S.Context, E);
48211844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target);
482251313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4823f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (SourceRange.Width > TargetRange.Width) {
4824091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    // If the source is a constant, use a default-on diagnostic.
4825091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    // TODO: this should happen for bitfield stores, too.
4826091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    llvm::APSInt Value(32);
4827091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    if (E->isIntegerConstantExpr(Value, S.Context)) {
4828d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay      if (S.SourceMgr.isInSystemMacro(CC))
4829ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek        return;
4830ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4831091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall      std::string PrettySourceValue = Value.toString(10);
4832091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall      std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange);
4833091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall
48345e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek      S.DiagRuntimeBehavior(E->getExprLoc(), E,
48355e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek        S.PDiag(diag::warn_impcast_integer_precision_constant)
48365e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek            << PrettySourceValue << PrettyTargetValue
48375e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek            << E->getType() << T << E->getSourceRange()
48385e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek            << clang::SourceRange(CC));
4839091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall      return;
4840091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    }
4841091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall
4842b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner    // People want to build with -Wshorten-64-to-32 and not -Wconversion.
4843d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay    if (S.SourceMgr.isInSystemMacro(CC))
4844ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek      return;
4845ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
484637050841d7b852497b85d5275d9ea92c07ddf059David Blaikie    if (TargetRange.Width == 32 && S.Context.getIntWidth(E->getType()) == 64)
4847c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32,
4848c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                             /* pruneControlFlow */ true);
4849b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision);
4850323ed74658bc8375278eabf074b4777458376540John McCall  }
4851323ed74658bc8375278eabf074b4777458376540John McCall
4852323ed74658bc8375278eabf074b4777458376540John McCall  if ((TargetRange.NonNegative && !SourceRange.NonNegative) ||
4853323ed74658bc8375278eabf074b4777458376540John McCall      (!TargetRange.NonNegative && SourceRange.NonNegative &&
4854323ed74658bc8375278eabf074b4777458376540John McCall       SourceRange.Width == TargetRange.Width)) {
4855ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4856d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay    if (S.SourceMgr.isInSystemMacro(CC))
4857ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek      return;
4858ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4859323ed74658bc8375278eabf074b4777458376540John McCall    unsigned DiagID = diag::warn_impcast_integer_sign;
4860323ed74658bc8375278eabf074b4777458376540John McCall
4861323ed74658bc8375278eabf074b4777458376540John McCall    // Traditionally, gcc has warned about this under -Wsign-compare.
4862323ed74658bc8375278eabf074b4777458376540John McCall    // We also want to warn about it in -Wconversion.
4863323ed74658bc8375278eabf074b4777458376540John McCall    // So if -Wconversion is off, use a completely identical diagnostic
4864323ed74658bc8375278eabf074b4777458376540John McCall    // in the sign-compare group.
4865323ed74658bc8375278eabf074b4777458376540John McCall    // The conditional-checking code will
4866323ed74658bc8375278eabf074b4777458376540John McCall    if (ICContext) {
4867323ed74658bc8375278eabf074b4777458376540John McCall      DiagID = diag::warn_impcast_integer_sign_conditional;
4868323ed74658bc8375278eabf074b4777458376540John McCall      *ICContext = true;
4869323ed74658bc8375278eabf074b4777458376540John McCall    }
4870323ed74658bc8375278eabf074b4777458376540John McCall
4871b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return DiagnoseImpCast(S, E, T, CC, DiagID);
487251313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
487351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4874284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor  // Diagnose conversions between different enumeration types.
48755a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  // In C, we pretend that the type of an EnumConstantDecl is its enumeration
48765a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  // type, to give us better diagnostics.
48775a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  QualType SourceType = E->getType();
48784e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie  if (!S.getLangOpts().CPlusPlus) {
48795a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor    if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E))
48805a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor      if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) {
48815a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor        EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext());
48825a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor        SourceType = S.Context.getTypeDeclType(Enum);
48835a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor        Source = S.Context.getCanonicalType(SourceType).getTypePtr();
48845a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor      }
48855a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  }
48865a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor
4887284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor  if (const EnumType *SourceEnum = Source->getAs<EnumType>())
4888284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor    if (const EnumType *TargetEnum = Target->getAs<EnumType>())
4889284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor      if ((SourceEnum->getDecl()->getIdentifier() ||
4890162e1c1b487352434552147967c3dd296ebee2f7Richard Smith           SourceEnum->getDecl()->getTypedefNameForAnonDecl()) &&
4891284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor          (TargetEnum->getDecl()->getIdentifier() ||
4892162e1c1b487352434552147967c3dd296ebee2f7Richard Smith           TargetEnum->getDecl()->getTypedefNameForAnonDecl()) &&
4893ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek          SourceEnum != TargetEnum) {
4894d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay        if (S.SourceMgr.isInSystemMacro(CC))
4895ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek          return;
4896ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
48975a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor        return DiagnoseImpCast(S, E, SourceType, T, CC,
4898284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor                               diag::warn_impcast_different_enum_types);
4899ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek      }
4900284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor
490151313c39c84407dd6a323be99a8c322bf8d052a9John McCall  return;
490251313c39c84407dd6a323be99a8c322bf8d052a9John McCall}
490351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
49049fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E,
49059fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie                              SourceLocation CC, QualType T);
4906323ed74658bc8375278eabf074b4777458376540John McCall
4907323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T,
4908b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall                             SourceLocation CC, bool &ICContext) {
4909323ed74658bc8375278eabf074b4777458376540John McCall  E = E->IgnoreParenImpCasts();
4910323ed74658bc8375278eabf074b4777458376540John McCall
4911323ed74658bc8375278eabf074b4777458376540John McCall  if (isa<ConditionalOperator>(E))
49129fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie    return CheckConditionalOperator(S, cast<ConditionalOperator>(E), CC, T);
4913323ed74658bc8375278eabf074b4777458376540John McCall
4914b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(S, E, CC);
4915323ed74658bc8375278eabf074b4777458376540John McCall  if (E->getType() != T)
4916b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return CheckImplicitConversion(S, E, T, CC, &ICContext);
4917323ed74658bc8375278eabf074b4777458376540John McCall  return;
4918323ed74658bc8375278eabf074b4777458376540John McCall}
4919323ed74658bc8375278eabf074b4777458376540John McCall
49209fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E,
49219fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie                              SourceLocation CC, QualType T) {
4922b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(S, E->getCond(), CC);
4923323ed74658bc8375278eabf074b4777458376540John McCall
4924323ed74658bc8375278eabf074b4777458376540John McCall  bool Suspicious = false;
4925b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious);
4926b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious);
4927323ed74658bc8375278eabf074b4777458376540John McCall
4928323ed74658bc8375278eabf074b4777458376540John McCall  // If -Wconversion would have warned about either of the candidates
4929323ed74658bc8375278eabf074b4777458376540John McCall  // for a signedness conversion to the context type...
4930323ed74658bc8375278eabf074b4777458376540John McCall  if (!Suspicious) return;
4931323ed74658bc8375278eabf074b4777458376540John McCall
4932323ed74658bc8375278eabf074b4777458376540John McCall  // ...but it's currently ignored...
49330827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis  if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional,
49340827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis                                 CC))
4935323ed74658bc8375278eabf074b4777458376540John McCall    return;
4936323ed74658bc8375278eabf074b4777458376540John McCall
4937323ed74658bc8375278eabf074b4777458376540John McCall  // ...then check whether it would have warned about either of the
4938323ed74658bc8375278eabf074b4777458376540John McCall  // candidates for a signedness conversion to the condition type.
49395254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu  if (E->getType() == T) return;
49405254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu
49415254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu  Suspicious = false;
49425254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu  CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(),
49435254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu                          E->getType(), CC, &Suspicious);
49445254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu  if (!Suspicious)
49455254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu    CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(),
4946b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall                            E->getType(), CC, &Suspicious);
4947323ed74658bc8375278eabf074b4777458376540John McCall}
4948323ed74658bc8375278eabf074b4777458376540John McCall
4949323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting
4950323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression.  There are a couple
4951323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare.
4952b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) {
4953323ed74658bc8375278eabf074b4777458376540John McCall  QualType T = OrigE->getType();
4954323ed74658bc8375278eabf074b4777458376540John McCall  Expr *E = OrigE->IgnoreParenImpCasts();
4955323ed74658bc8375278eabf074b4777458376540John McCall
4956f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor  if (E->isTypeDependent() || E->isValueDependent())
4957f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor    return;
4958f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor
4959323ed74658bc8375278eabf074b4777458376540John McCall  // For conditional operators, we analyze the arguments as if they
4960323ed74658bc8375278eabf074b4777458376540John McCall  // were being fed directly into the output.
4961323ed74658bc8375278eabf074b4777458376540John McCall  if (isa<ConditionalOperator>(E)) {
4962323ed74658bc8375278eabf074b4777458376540John McCall    ConditionalOperator *CO = cast<ConditionalOperator>(E);
49639fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie    CheckConditionalOperator(S, CO, CC, T);
4964323ed74658bc8375278eabf074b4777458376540John McCall    return;
4965323ed74658bc8375278eabf074b4777458376540John McCall  }
4966323ed74658bc8375278eabf074b4777458376540John McCall
496788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  // Check implicit argument conversions for function calls.
496888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg  if (CallExpr *Call = dyn_cast<CallExpr>(E))
496988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg    CheckImplicitArgumentConversions(S, Call, CC);
497088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg
4971323ed74658bc8375278eabf074b4777458376540John McCall  // Go ahead and check any implicit conversions we might have skipped.
4972323ed74658bc8375278eabf074b4777458376540John McCall  // The non-canonical typecheck is just an optimization;
4973323ed74658bc8375278eabf074b4777458376540John McCall  // CheckImplicitConversion will filter out dead implicit conversions.
4974323ed74658bc8375278eabf074b4777458376540John McCall  if (E->getType() != T)
4975b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    CheckImplicitConversion(S, E, T, CC);
4976323ed74658bc8375278eabf074b4777458376540John McCall
4977323ed74658bc8375278eabf074b4777458376540John McCall  // Now continue drilling into this expression.
4978323ed74658bc8375278eabf074b4777458376540John McCall
4979323ed74658bc8375278eabf074b4777458376540John McCall  // Skip past explicit casts.
4980323ed74658bc8375278eabf074b4777458376540John McCall  if (isa<ExplicitCastExpr>(E)) {
4981323ed74658bc8375278eabf074b4777458376540John McCall    E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts();
4982b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return AnalyzeImplicitConversions(S, E, CC);
4983323ed74658bc8375278eabf074b4777458376540John McCall  }
4984323ed74658bc8375278eabf074b4777458376540John McCall
4985beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
4986beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall    // Do a somewhat different check with comparison operators.
4987beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall    if (BO->isComparisonOp())
4988beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall      return AnalyzeComparison(S, BO);
4989beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall
49900fa063816818ac53a0015a5d2b0328812005b40eEli Friedman    // And with simple assignments.
49910fa063816818ac53a0015a5d2b0328812005b40eEli Friedman    if (BO->getOpcode() == BO_Assign)
4992beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall      return AnalyzeAssignment(S, BO);
4993beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  }
4994323ed74658bc8375278eabf074b4777458376540John McCall
4995323ed74658bc8375278eabf074b4777458376540John McCall  // These break the otherwise-useful invariant below.  Fortunately,
4996323ed74658bc8375278eabf074b4777458376540John McCall  // we don't really need to recurse into them, because any internal
4997323ed74658bc8375278eabf074b4777458376540John McCall  // expressions should have been analyzed already when they were
4998323ed74658bc8375278eabf074b4777458376540John McCall  // built into statements.
4999323ed74658bc8375278eabf074b4777458376540John McCall  if (isa<StmtExpr>(E)) return;
5000323ed74658bc8375278eabf074b4777458376540John McCall
5001323ed74658bc8375278eabf074b4777458376540John McCall  // Don't descend into unevaluated contexts.
5002f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne  if (isa<UnaryExprOrTypeTraitExpr>(E)) return;
5003323ed74658bc8375278eabf074b4777458376540John McCall
5004323ed74658bc8375278eabf074b4777458376540John McCall  // Now just recurse over the expression's children.
5005b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  CC = E->getExprLoc();
5006f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  BinaryOperator *BO = dyn_cast<BinaryOperator>(E);
5007f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  bool IsLogicalOperator = BO && BO->isLogicalOp();
5008f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  for (Stmt::child_range I = E->children(); I; ++I) {
500954042f1bd78f1f1ea86be7d4af541462e127d2edDouglas Gregor    Expr *ChildExpr = dyn_cast_or_null<Expr>(*I);
5010503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor    if (!ChildExpr)
5011503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor      continue;
5012503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor
5013f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu    if (IsLogicalOperator &&
5014f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu        isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts()))
5015f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      // Ignore checking string literals that are in logical operators.
5016f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      continue;
5017f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu    AnalyzeImplicitConversions(S, ChildExpr, CC);
5018f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  }
5019323ed74658bc8375278eabf074b4777458376540John McCall}
5020323ed74658bc8375278eabf074b4777458376540John McCall
5021323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace
5022323ed74658bc8375278eabf074b4777458376540John McCall
5023323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given
5024323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression).  Implements -Wconversion
5025323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare.
5026b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall///
5027b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e.
5028b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall///   the most location of the syntactic entity requiring the implicit
5029b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall///   conversion
5030b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) {
5031323ed74658bc8375278eabf074b4777458376540John McCall  // Don't diagnose in unevaluated contexts.
503271f55f771794674a410171dbf3cb5dbedf95d033David Blaikie  if (isUnevaluatedContext())
5033323ed74658bc8375278eabf074b4777458376540John McCall    return;
5034323ed74658bc8375278eabf074b4777458376540John McCall
5035323ed74658bc8375278eabf074b4777458376540John McCall  // Don't diagnose for value- or type-dependent expressions.
5036323ed74658bc8375278eabf074b4777458376540John McCall  if (E->isTypeDependent() || E->isValueDependent())
5037323ed74658bc8375278eabf074b4777458376540John McCall    return;
5038323ed74658bc8375278eabf074b4777458376540John McCall
5039d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  // Check for array bounds violations in cases where the check isn't triggered
5040d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  // elsewhere for other Expr types (like BinaryOperators), e.g. when an
5041d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  // ArraySubscriptExpr is on the RHS of a variable initialization.
5042d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  CheckArrayAccess(E);
5043d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
5044b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  // This is not the right CC for (e.g.) a variable initialization.
5045b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(*this, E, CC);
5046323ed74658bc8375278eabf074b4777458376540John McCall}
5047323ed74658bc8375278eabf074b4777458376540John McCall
504815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc,
504915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall                                       FieldDecl *BitField,
505015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall                                       Expr *Init) {
505115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc);
505215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall}
505315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
5054f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given
5055f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This
5056f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the
5057f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function
5058f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete.
505982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregorbool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd,
506082aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor                                    bool CheckParameterNames) {
5061f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump  bool HasInvalidParm = false;
506282aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor  for (; P != PEnd; ++P) {
506382aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor    ParmVarDecl *Param = *P;
506482aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor
5065f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // C99 6.7.5.3p4: the parameters in a parameter type list in a
5066f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // function declarator that is part of a function definition of
5067f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // that function shall not have incomplete type.
5068f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    //
5069f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // This is also C++ [dcl.fct]p6.
5070f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    if (!Param->isInvalidDecl() &&
5071f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump        RequireCompleteType(Param->getLocation(), Param->getType(),
5072d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor                            diag::err_typecheck_decl_incomplete_type)) {
5073f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump      Param->setInvalidDecl();
5074f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump      HasInvalidParm = true;
5075f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    }
5076f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump
5077f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // C99 6.9.1p5: If the declarator includes a parameter type list, the
5078f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // declaration of each parameter shall include an identifier.
507982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor    if (CheckParameterNames &&
508082aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor        Param->getIdentifier() == 0 &&
5081f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump        !Param->isImplicit() &&
50824e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie        !getLangOpts().CPlusPlus)
5083f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump      Diag(Param->getLocation(), diag::err_parameter_name_omitted);
5084d17e340e2d516139931768697bf080f60920ba9dSam Weinig
5085d17e340e2d516139931768697bf080f60920ba9dSam Weinig    // C99 6.7.5.3p12:
5086d17e340e2d516139931768697bf080f60920ba9dSam Weinig    //   If the function declarator is not part of a definition of that
5087d17e340e2d516139931768697bf080f60920ba9dSam Weinig    //   function, parameters may have incomplete type and may use the [*]
5088d17e340e2d516139931768697bf080f60920ba9dSam Weinig    //   notation in their sequences of declarator specifiers to specify
5089d17e340e2d516139931768697bf080f60920ba9dSam Weinig    //   variable length array types.
5090d17e340e2d516139931768697bf080f60920ba9dSam Weinig    QualType PType = Param->getOriginalType();
5091d17e340e2d516139931768697bf080f60920ba9dSam Weinig    if (const ArrayType *AT = Context.getAsArrayType(PType)) {
5092d17e340e2d516139931768697bf080f60920ba9dSam Weinig      if (AT->getSizeModifier() == ArrayType::Star) {
5093bed28ac1d1463adca3ecf24fca5c30646fa9dbb2Sylvestre Ledru        // FIXME: This diagnosic should point the '[*]' if source-location
5094d17e340e2d516139931768697bf080f60920ba9dSam Weinig        // information is added for it.
5095d17e340e2d516139931768697bf080f60920ba9dSam Weinig        Diag(Param->getLocation(), diag::err_array_star_in_function_definition);
5096d17e340e2d516139931768697bf080f60920ba9dSam Weinig      }
5097d17e340e2d516139931768697bf080f60920ba9dSam Weinig    }
5098f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump  }
5099f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump
5100f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump  return HasInvalidParm;
5101f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump}
5102b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5103b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a
5104b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements.
5105b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) {
5106b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // This is actually a lot of work to potentially be doing on every
5107b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // cast; don't do it if we're ignoring -Wcast_align (as is the default).
51080827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis  if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align,
51090827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis                                          TRange.getBegin())
5110d6471f7c1921c7802804ce3ff6fe9768310f72b9David Blaikie        == DiagnosticsEngine::Ignored)
5111b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    return;
5112b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5113b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Ignore dependent types.
5114b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (T->isDependentType() || Op->getType()->isDependentType())
5115b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    return;
5116b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5117b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Require that the destination be a pointer type.
5118b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  const PointerType *DestPtr = T->getAs<PointerType>();
5119b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (!DestPtr) return;
5120b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5121b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // If the destination has alignment 1, we're done.
5122b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  QualType DestPointee = DestPtr->getPointeeType();
5123b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (DestPointee->isIncompleteType()) return;
5124b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee);
5125b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (DestAlign.isOne()) return;
5126b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5127b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Require that the source be a pointer type.
5128b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  const PointerType *SrcPtr = Op->getType()->getAs<PointerType>();
5129b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (!SrcPtr) return;
5130b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  QualType SrcPointee = SrcPtr->getPointeeType();
5131b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5132b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Whitelist casts from cv void*.  We already implicitly
5133b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // whitelisted casts to cv void*, since they have alignment 1.
5134b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Also whitelist casts involving incomplete types, which implicitly
5135b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // includes 'void'.
5136b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (SrcPointee->isIncompleteType()) return;
5137b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5138b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee);
5139b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (SrcAlign >= DestAlign) return;
5140b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5141b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  Diag(TRange.getBegin(), diag::warn_cast_align)
5142b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    << Op->getType() << T
5143b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    << static_cast<unsigned>(SrcAlign.getQuantity())
5144b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    << static_cast<unsigned>(DestAlign.getQuantity())
5145b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    << TRange << Op->getSourceRange();
5146b7f4ffe073fa419613946461a2583ba2fcb72280John McCall}
5147b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
5148d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainstatic const Type* getElementType(const Expr *BaseExpr) {
5149d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  const Type* EltType = BaseExpr->getType().getTypePtr();
5150d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  if (EltType->isAnyPointerType())
5151d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    return EltType->getPointeeType().getTypePtr();
5152d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  else if (EltType->isArrayType())
5153d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    return EltType->getBaseElementTypeUnsafe();
5154d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  return EltType;
5155d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain}
5156d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
5157c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// \brief Check whether this array fits the idiom of a size-one tail padded
5158c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// array member of a struct.
5159c268434b332bbe57950d977633369bf5822d9554Chandler Carruth///
5160c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// We avoid emitting out-of-bounds access warnings for such arrays as they are
5161c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// commonly used to emulate flexible arrays in C89 code.
5162c268434b332bbe57950d977633369bf5822d9554Chandler Carruthstatic bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size,
5163c268434b332bbe57950d977633369bf5822d9554Chandler Carruth                                    const NamedDecl *ND) {
5164c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  if (Size != 1 || !ND) return false;
5165c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
5166c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  const FieldDecl *FD = dyn_cast<FieldDecl>(ND);
5167c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  if (!FD) return false;
5168c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
5169c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  // Don't consider sizes resulting from macro expansions or template argument
5170c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  // substitution to form C89 tail-padded arrays.
5171d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan
5172d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan  TypeSourceInfo *TInfo = FD->getTypeSourceInfo();
517300e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek  while (TInfo) {
517400e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    TypeLoc TL = TInfo->getTypeLoc();
517500e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    // Look through typedefs.
517600e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    const TypedefTypeLoc *TTL = dyn_cast<TypedefTypeLoc>(&TL);
517700e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    if (TTL) {
517800e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek      const TypedefNameDecl *TDL = TTL->getTypedefNameDecl();
517900e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek      TInfo = TDL->getTypeSourceInfo();
518000e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek      continue;
518100e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    }
518200e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    ConstantArrayTypeLoc CTL = cast<ConstantArrayTypeLoc>(TL);
518300e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    const Expr *SizeExpr = dyn_cast<IntegerLiteral>(CTL.getSizeExpr());
5184d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan    if (!SizeExpr || SizeExpr->getExprLoc().isMacroID())
5185d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan      return false;
518600e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    break;
5187d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan  }
5188c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
5189c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext());
5190381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay  if (!RD) return false;
5191381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay  if (RD->isUnion()) return false;
5192381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay  if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) {
5193381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay    if (!CRD->isStandardLayout()) return false;
5194381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay  }
5195c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
519622d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer  // See if this is the last field decl in the record.
519722d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer  const Decl *D = FD;
519822d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer  while ((D = D->getNextDeclInContext()))
519922d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer    if (isa<FieldDecl>(D))
520022d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer      return false;
520122d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer  return true;
5202c268434b332bbe57950d977633369bf5822d9554Chandler Carruth}
5203c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
5204d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainvoid Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr,
520580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay                            const ArraySubscriptExpr *ASE,
520625b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith                            bool AllowOnePastEnd, bool IndexNegated) {
520792b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman  IndexExpr = IndexExpr->IgnoreParenImpCasts();
520880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay  if (IndexExpr->isValueDependent())
520980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    return;
5210d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
521180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay  const Type *EffectiveType = getElementType(BaseExpr);
521280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay  BaseExpr = BaseExpr->IgnoreParenCasts();
52133406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth  const ConstantArrayType *ArrayTy =
5214d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    Context.getAsConstantArrayType(BaseExpr->getType());
52153406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth  if (!ArrayTy)
5216a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek    return;
521735001ca261f895817916b468379b696d6d45959dChandler Carruth
52183406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth  llvm::APSInt index;
521980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay  if (!IndexExpr->EvaluateAsInt(index, Context))
5220a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek    return;
522125b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith  if (IndexNegated)
522225b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith    index = -index;
52238fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek
5224ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth  const NamedDecl *ND = NULL;
5225ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth  if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr))
5226ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    ND = dyn_cast<NamedDecl>(DRE->getDecl());
5227c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr))
5228ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    ND = dyn_cast<NamedDecl>(ME->getMemberDecl());
5229ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth
52309e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek  if (index.isUnsigned() || !index.isNegative()) {
523125b3b849e3ad340b04442707038c86980035765bTed Kremenek    llvm::APInt size = ArrayTy->getSize();
523235001ca261f895817916b468379b696d6d45959dChandler Carruth    if (!size.isStrictlyPositive())
523335001ca261f895817916b468379b696d6d45959dChandler Carruth      return;
5234d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
5235d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    const Type* BaseType = getElementType(BaseExpr);
5236de5998f1d7dcecb777257ec932142d65de636eb8Nico Weber    if (BaseType != EffectiveType) {
5237d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      // Make sure we're comparing apples to apples when comparing index to size
5238d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType);
5239d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      uint64_t array_typesize = Context.getTypeSize(BaseType);
5240d10f4bc5a05ce0cdc1646dbb0f706bb9d3dfc0c5Kaelyn Uhrain      // Handle ptrarith_typesize being zero, such as when casting to void*
524118f169770d9d3f826bad8f1359c8c5770c5ab16fKaelyn Uhrain      if (!ptrarith_typesize) ptrarith_typesize = 1;
5242d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      if (ptrarith_typesize != array_typesize) {
5243d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        // There's a cast to a different size type involved
5244d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        uint64_t ratio = array_typesize / ptrarith_typesize;
5245d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        // TODO: Be smarter about handling cases where array_typesize is not a
5246d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        // multiple of ptrarith_typesize
5247d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        if (ptrarith_typesize * ratio == array_typesize)
5248d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain          size *= llvm::APInt(size.getBitWidth(), ratio);
5249d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      }
5250d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    }
5251d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
52523406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth    if (size.getBitWidth() > index.getBitWidth())
525392b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman      index = index.zext(size.getBitWidth());
525425b3b849e3ad340b04442707038c86980035765bTed Kremenek    else if (size.getBitWidth() < index.getBitWidth())
525592b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman      size = size.zext(index.getBitWidth());
525625b3b849e3ad340b04442707038c86980035765bTed Kremenek
5257d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    // For array subscripting the index must be less than size, but for pointer
5258d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    // arithmetic also allow the index (offset) to be equal to size since
5259d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    // computing the next address after the end of the array is legal and
5260d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    // commonly done e.g. in C++ iterators and range-based for loops.
526192b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman    if (AllowOnePastEnd ? index.ule(size) : index.ult(size))
5262ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth      return;
5263ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth
5264ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    // Also don't warn for arrays of size 1 which are members of some
5265ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    // structure. These are often used to approximate flexible arrays in C89
5266ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    // code.
5267d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    if (IsTailPaddedMemberArray(*this, size, ND))
52688fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek      return;
52693406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth
527080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    // Suppress the warning if the subscript expression (as identified by the
527180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    // ']' location) and the index expression are both from macro expansions
527280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    // within a system header.
527380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    if (ASE) {
527480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay      SourceLocation RBracketLoc = SourceMgr.getSpellingLoc(
527580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay          ASE->getRBracketLoc());
527680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay      if (SourceMgr.isInSystemHeader(RBracketLoc)) {
527780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay        SourceLocation IndexLoc = SourceMgr.getSpellingLoc(
527880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay            IndexExpr->getLocStart());
527980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay        if (SourceMgr.isFromSameFile(RBracketLoc, IndexLoc))
528080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay          return;
528180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay      }
528280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    }
528380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay
5284d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds;
528580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    if (ASE)
5286d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      DiagID = diag::warn_array_index_exceeds_bounds;
5287d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
5288d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr,
5289d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                        PDiag(DiagID) << index.toString(10, true)
5290d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << size.toString(10, true)
5291d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << (unsigned)size.getLimitedValue(~0U)
5292d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << IndexExpr->getSourceRange());
52933406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth  } else {
5294d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    unsigned DiagID = diag::warn_array_index_precedes_bounds;
529580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    if (!ASE) {
5296d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      DiagID = diag::warn_ptr_arith_precedes_bounds;
5297d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      if (index.isNegative()) index = -index;
5298d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    }
5299d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
5300d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr,
5301d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                        PDiag(DiagID) << index.toString(10, true)
5302d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << IndexExpr->getSourceRange());
5303a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek  }
530435001ca261f895817916b468379b696d6d45959dChandler Carruth
5305cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay  if (!ND) {
5306cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay    // Try harder to find a NamedDecl to point at in the note.
5307cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay    while (const ArraySubscriptExpr *ASE =
5308cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay           dyn_cast<ArraySubscriptExpr>(BaseExpr))
5309cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay      BaseExpr = ASE->getBase()->IgnoreParenCasts();
5310cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay    if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr))
5311cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay      ND = dyn_cast<NamedDecl>(DRE->getDecl());
5312cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay    if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr))
5313cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay      ND = dyn_cast<NamedDecl>(ME->getMemberDecl());
5314cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay  }
5315cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay
531635001ca261f895817916b468379b696d6d45959dChandler Carruth  if (ND)
5317d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    DiagRuntimeBehavior(ND->getLocStart(), BaseExpr,
5318d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                        PDiag(diag::note_array_index_out_of_bounds)
5319d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << ND->getDeclName());
53203aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek}
53213aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek
53223aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) {
5323d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  int AllowOnePastEnd = 0;
5324d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  while (expr) {
5325d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    expr = expr->IgnoreParenImpCasts();
53263aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek    switch (expr->getStmtClass()) {
5327d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      case Stmt::ArraySubscriptExprClass: {
5328d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr);
532980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay        CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE,
5330d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                         AllowOnePastEnd > 0);
53313aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        return;
5332d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      }
5333d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      case Stmt::UnaryOperatorClass: {
5334d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        // Only unwrap the * and & unary operators
5335d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        const UnaryOperator *UO = cast<UnaryOperator>(expr);
5336d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        expr = UO->getSubExpr();
5337d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        switch (UO->getOpcode()) {
5338d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain          case UO_AddrOf:
5339d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            AllowOnePastEnd++;
5340d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            break;
5341d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain          case UO_Deref:
5342d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            AllowOnePastEnd--;
5343d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            break;
5344d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain          default:
5345d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            return;
5346d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        }
5347d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        break;
5348d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      }
53493aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek      case Stmt::ConditionalOperatorClass: {
53503aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        const ConditionalOperator *cond = cast<ConditionalOperator>(expr);
53513aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        if (const Expr *lhs = cond->getLHS())
53523aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek          CheckArrayAccess(lhs);
53533aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        if (const Expr *rhs = cond->getRHS())
53543aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek          CheckArrayAccess(rhs);
53553aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        return;
53563aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek      }
53573aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek      default:
53583aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        return;
53593aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek    }
5360f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne  }
5361a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek}
5362f85e193739c953358c865005855253af4f68a497John McCall
5363f85e193739c953358c865005855253af4f68a497John McCall//===--- CHECK: Objective-C retain cycles ----------------------------------//
5364f85e193739c953358c865005855253af4f68a497John McCall
5365f85e193739c953358c865005855253af4f68a497John McCallnamespace {
5366f85e193739c953358c865005855253af4f68a497John McCall  struct RetainCycleOwner {
5367f85e193739c953358c865005855253af4f68a497John McCall    RetainCycleOwner() : Variable(0), Indirect(false) {}
5368f85e193739c953358c865005855253af4f68a497John McCall    VarDecl *Variable;
5369f85e193739c953358c865005855253af4f68a497John McCall    SourceRange Range;
5370f85e193739c953358c865005855253af4f68a497John McCall    SourceLocation Loc;
5371f85e193739c953358c865005855253af4f68a497John McCall    bool Indirect;
5372f85e193739c953358c865005855253af4f68a497John McCall
5373f85e193739c953358c865005855253af4f68a497John McCall    void setLocsFrom(Expr *e) {
5374f85e193739c953358c865005855253af4f68a497John McCall      Loc = e->getExprLoc();
5375f85e193739c953358c865005855253af4f68a497John McCall      Range = e->getSourceRange();
5376f85e193739c953358c865005855253af4f68a497John McCall    }
5377f85e193739c953358c865005855253af4f68a497John McCall  };
5378f85e193739c953358c865005855253af4f68a497John McCall}
5379f85e193739c953358c865005855253af4f68a497John McCall
5380f85e193739c953358c865005855253af4f68a497John McCall/// Consider whether capturing the given variable can possibly lead to
5381f85e193739c953358c865005855253af4f68a497John McCall/// a retain cycle.
5382f85e193739c953358c865005855253af4f68a497John McCallstatic bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) {
5383f3477c13eeaf11b32a41f181398fb5deffd0dd73Sylvestre Ledru  // In ARC, it's captured strongly iff the variable has __strong
5384f85e193739c953358c865005855253af4f68a497John McCall  // lifetime.  In MRR, it's captured strongly if the variable is
5385f85e193739c953358c865005855253af4f68a497John McCall  // __block and has an appropriate type.
5386f85e193739c953358c865005855253af4f68a497John McCall  if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong)
5387f85e193739c953358c865005855253af4f68a497John McCall    return false;
5388f85e193739c953358c865005855253af4f68a497John McCall
5389f85e193739c953358c865005855253af4f68a497John McCall  owner.Variable = var;
5390e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose  if (ref)
5391e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose    owner.setLocsFrom(ref);
5392f85e193739c953358c865005855253af4f68a497John McCall  return true;
5393f85e193739c953358c865005855253af4f68a497John McCall}
5394f85e193739c953358c865005855253af4f68a497John McCall
53956e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanianstatic bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) {
5396f85e193739c953358c865005855253af4f68a497John McCall  while (true) {
5397f85e193739c953358c865005855253af4f68a497John McCall    e = e->IgnoreParens();
5398f85e193739c953358c865005855253af4f68a497John McCall    if (CastExpr *cast = dyn_cast<CastExpr>(e)) {
5399f85e193739c953358c865005855253af4f68a497John McCall      switch (cast->getCastKind()) {
5400f85e193739c953358c865005855253af4f68a497John McCall      case CK_BitCast:
5401f85e193739c953358c865005855253af4f68a497John McCall      case CK_LValueBitCast:
5402f85e193739c953358c865005855253af4f68a497John McCall      case CK_LValueToRValue:
540333e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall      case CK_ARCReclaimReturnedObject:
5404f85e193739c953358c865005855253af4f68a497John McCall        e = cast->getSubExpr();
5405f85e193739c953358c865005855253af4f68a497John McCall        continue;
5406f85e193739c953358c865005855253af4f68a497John McCall
5407f85e193739c953358c865005855253af4f68a497John McCall      default:
5408f85e193739c953358c865005855253af4f68a497John McCall        return false;
5409f85e193739c953358c865005855253af4f68a497John McCall      }
5410f85e193739c953358c865005855253af4f68a497John McCall    }
5411f85e193739c953358c865005855253af4f68a497John McCall
5412f85e193739c953358c865005855253af4f68a497John McCall    if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) {
5413f85e193739c953358c865005855253af4f68a497John McCall      ObjCIvarDecl *ivar = ref->getDecl();
5414f85e193739c953358c865005855253af4f68a497John McCall      if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong)
5415f85e193739c953358c865005855253af4f68a497John McCall        return false;
5416f85e193739c953358c865005855253af4f68a497John McCall
5417f85e193739c953358c865005855253af4f68a497John McCall      // Try to find a retain cycle in the base.
54186e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian      if (!findRetainCycleOwner(S, ref->getBase(), owner))
5419f85e193739c953358c865005855253af4f68a497John McCall        return false;
5420f85e193739c953358c865005855253af4f68a497John McCall
5421f85e193739c953358c865005855253af4f68a497John McCall      if (ref->isFreeIvar()) owner.setLocsFrom(ref);
5422f85e193739c953358c865005855253af4f68a497John McCall      owner.Indirect = true;
5423f85e193739c953358c865005855253af4f68a497John McCall      return true;
5424f85e193739c953358c865005855253af4f68a497John McCall    }
5425f85e193739c953358c865005855253af4f68a497John McCall
5426f85e193739c953358c865005855253af4f68a497John McCall    if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) {
5427f85e193739c953358c865005855253af4f68a497John McCall      VarDecl *var = dyn_cast<VarDecl>(ref->getDecl());
5428f85e193739c953358c865005855253af4f68a497John McCall      if (!var) return false;
5429f85e193739c953358c865005855253af4f68a497John McCall      return considerVariable(var, ref, owner);
5430f85e193739c953358c865005855253af4f68a497John McCall    }
5431f85e193739c953358c865005855253af4f68a497John McCall
5432f85e193739c953358c865005855253af4f68a497John McCall    if (MemberExpr *member = dyn_cast<MemberExpr>(e)) {
5433f85e193739c953358c865005855253af4f68a497John McCall      if (member->isArrow()) return false;
5434f85e193739c953358c865005855253af4f68a497John McCall
5435f85e193739c953358c865005855253af4f68a497John McCall      // Don't count this as an indirect ownership.
5436f85e193739c953358c865005855253af4f68a497John McCall      e = member->getBase();
5437f85e193739c953358c865005855253af4f68a497John McCall      continue;
5438f85e193739c953358c865005855253af4f68a497John McCall    }
5439f85e193739c953358c865005855253af4f68a497John McCall
54404b9c2d235fb9449e249d74f48ecfec601650de93John McCall    if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) {
54414b9c2d235fb9449e249d74f48ecfec601650de93John McCall      // Only pay attention to pseudo-objects on property references.
54424b9c2d235fb9449e249d74f48ecfec601650de93John McCall      ObjCPropertyRefExpr *pre
54434b9c2d235fb9449e249d74f48ecfec601650de93John McCall        = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm()
54444b9c2d235fb9449e249d74f48ecfec601650de93John McCall                                              ->IgnoreParens());
54454b9c2d235fb9449e249d74f48ecfec601650de93John McCall      if (!pre) return false;
54464b9c2d235fb9449e249d74f48ecfec601650de93John McCall      if (pre->isImplicitProperty()) return false;
54474b9c2d235fb9449e249d74f48ecfec601650de93John McCall      ObjCPropertyDecl *property = pre->getExplicitProperty();
54484b9c2d235fb9449e249d74f48ecfec601650de93John McCall      if (!property->isRetaining() &&
54494b9c2d235fb9449e249d74f48ecfec601650de93John McCall          !(property->getPropertyIvarDecl() &&
54504b9c2d235fb9449e249d74f48ecfec601650de93John McCall            property->getPropertyIvarDecl()->getType()
54514b9c2d235fb9449e249d74f48ecfec601650de93John McCall              .getObjCLifetime() == Qualifiers::OCL_Strong))
54524b9c2d235fb9449e249d74f48ecfec601650de93John McCall          return false;
54534b9c2d235fb9449e249d74f48ecfec601650de93John McCall
54544b9c2d235fb9449e249d74f48ecfec601650de93John McCall      owner.Indirect = true;
54556e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian      if (pre->isSuperReceiver()) {
54566e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        owner.Variable = S.getCurMethodDecl()->getSelfDecl();
54576e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        if (!owner.Variable)
54586e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian          return false;
54596e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        owner.Loc = pre->getLocation();
54606e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        owner.Range = pre->getSourceRange();
54616e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        return true;
54626e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian      }
54634b9c2d235fb9449e249d74f48ecfec601650de93John McCall      e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase())
54644b9c2d235fb9449e249d74f48ecfec601650de93John McCall                              ->getSourceExpr());
54654b9c2d235fb9449e249d74f48ecfec601650de93John McCall      continue;
54664b9c2d235fb9449e249d74f48ecfec601650de93John McCall    }
54674b9c2d235fb9449e249d74f48ecfec601650de93John McCall
5468f85e193739c953358c865005855253af4f68a497John McCall    // Array ivars?
5469f85e193739c953358c865005855253af4f68a497John McCall
5470f85e193739c953358c865005855253af4f68a497John McCall    return false;
5471f85e193739c953358c865005855253af4f68a497John McCall  }
5472f85e193739c953358c865005855253af4f68a497John McCall}
5473f85e193739c953358c865005855253af4f68a497John McCall
5474f85e193739c953358c865005855253af4f68a497John McCallnamespace {
5475f85e193739c953358c865005855253af4f68a497John McCall  struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> {
5476f85e193739c953358c865005855253af4f68a497John McCall    FindCaptureVisitor(ASTContext &Context, VarDecl *variable)
5477f85e193739c953358c865005855253af4f68a497John McCall      : EvaluatedExprVisitor<FindCaptureVisitor>(Context),
5478f85e193739c953358c865005855253af4f68a497John McCall        Variable(variable), Capturer(0) {}
5479f85e193739c953358c865005855253af4f68a497John McCall
5480f85e193739c953358c865005855253af4f68a497John McCall    VarDecl *Variable;
5481f85e193739c953358c865005855253af4f68a497John McCall    Expr *Capturer;
5482f85e193739c953358c865005855253af4f68a497John McCall
5483f85e193739c953358c865005855253af4f68a497John McCall    void VisitDeclRefExpr(DeclRefExpr *ref) {
5484f85e193739c953358c865005855253af4f68a497John McCall      if (ref->getDecl() == Variable && !Capturer)
5485f85e193739c953358c865005855253af4f68a497John McCall        Capturer = ref;
5486f85e193739c953358c865005855253af4f68a497John McCall    }
5487f85e193739c953358c865005855253af4f68a497John McCall
5488f85e193739c953358c865005855253af4f68a497John McCall    void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) {
5489f85e193739c953358c865005855253af4f68a497John McCall      if (Capturer) return;
5490f85e193739c953358c865005855253af4f68a497John McCall      Visit(ref->getBase());
5491f85e193739c953358c865005855253af4f68a497John McCall      if (Capturer && ref->isFreeIvar())
5492f85e193739c953358c865005855253af4f68a497John McCall        Capturer = ref;
5493f85e193739c953358c865005855253af4f68a497John McCall    }
5494f85e193739c953358c865005855253af4f68a497John McCall
5495f85e193739c953358c865005855253af4f68a497John McCall    void VisitBlockExpr(BlockExpr *block) {
5496f85e193739c953358c865005855253af4f68a497John McCall      // Look inside nested blocks
5497f85e193739c953358c865005855253af4f68a497John McCall      if (block->getBlockDecl()->capturesVariable(Variable))
5498f85e193739c953358c865005855253af4f68a497John McCall        Visit(block->getBlockDecl()->getBody());
5499f85e193739c953358c865005855253af4f68a497John McCall    }
55007e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian
55017e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian    void VisitOpaqueValueExpr(OpaqueValueExpr *OVE) {
55027e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian      if (Capturer) return;
55037e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian      if (OVE->getSourceExpr())
55047e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian        Visit(OVE->getSourceExpr());
55057e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian    }
5506f85e193739c953358c865005855253af4f68a497John McCall  };
5507f85e193739c953358c865005855253af4f68a497John McCall}
5508f85e193739c953358c865005855253af4f68a497John McCall
5509f85e193739c953358c865005855253af4f68a497John McCall/// Check whether the given argument is a block which captures a
5510f85e193739c953358c865005855253af4f68a497John McCall/// variable.
5511f85e193739c953358c865005855253af4f68a497John McCallstatic Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) {
5512f85e193739c953358c865005855253af4f68a497John McCall  assert(owner.Variable && owner.Loc.isValid());
5513f85e193739c953358c865005855253af4f68a497John McCall
5514f85e193739c953358c865005855253af4f68a497John McCall  e = e->IgnoreParenCasts();
55151fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose
55161fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose  // Look through [^{...} copy] and Block_copy(^{...}).
55171fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose  if (ObjCMessageExpr *ME = dyn_cast<ObjCMessageExpr>(e)) {
55181fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose    Selector Cmd = ME->getSelector();
55191fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose    if (Cmd.isUnarySelector() && Cmd.getNameForSlot(0) == "copy") {
55201fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose      e = ME->getInstanceReceiver();
55211fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose      if (!e)
55221fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose        return 0;
55231fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose      e = e->IgnoreParenCasts();
55241fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose    }
55251fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose  } else if (CallExpr *CE = dyn_cast<CallExpr>(e)) {
55261fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose    if (CE->getNumArgs() == 1) {
55271fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose      FunctionDecl *Fn = dyn_cast_or_null<FunctionDecl>(CE->getCalleeDecl());
5528d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek      if (Fn) {
5529d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek        const IdentifierInfo *FnI = Fn->getIdentifier();
5530d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek        if (FnI && FnI->isStr("_Block_copy")) {
5531d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek          e = CE->getArg(0)->IgnoreParenCasts();
5532d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek        }
5533d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek      }
55341fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose    }
55351fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose  }
55361fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose
5537f85e193739c953358c865005855253af4f68a497John McCall  BlockExpr *block = dyn_cast<BlockExpr>(e);
5538f85e193739c953358c865005855253af4f68a497John McCall  if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable))
5539f85e193739c953358c865005855253af4f68a497John McCall    return 0;
5540f85e193739c953358c865005855253af4f68a497John McCall
5541f85e193739c953358c865005855253af4f68a497John McCall  FindCaptureVisitor visitor(S.Context, owner.Variable);
5542f85e193739c953358c865005855253af4f68a497John McCall  visitor.Visit(block->getBlockDecl()->getBody());
5543f85e193739c953358c865005855253af4f68a497John McCall  return visitor.Capturer;
5544f85e193739c953358c865005855253af4f68a497John McCall}
5545f85e193739c953358c865005855253af4f68a497John McCall
5546f85e193739c953358c865005855253af4f68a497John McCallstatic void diagnoseRetainCycle(Sema &S, Expr *capturer,
5547f85e193739c953358c865005855253af4f68a497John McCall                                RetainCycleOwner &owner) {
5548f85e193739c953358c865005855253af4f68a497John McCall  assert(capturer);
5549f85e193739c953358c865005855253af4f68a497John McCall  assert(owner.Variable && owner.Loc.isValid());
5550f85e193739c953358c865005855253af4f68a497John McCall
5551f85e193739c953358c865005855253af4f68a497John McCall  S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle)
5552f85e193739c953358c865005855253af4f68a497John McCall    << owner.Variable << capturer->getSourceRange();
5553f85e193739c953358c865005855253af4f68a497John McCall  S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner)
5554f85e193739c953358c865005855253af4f68a497John McCall    << owner.Indirect << owner.Range;
5555f85e193739c953358c865005855253af4f68a497John McCall}
5556f85e193739c953358c865005855253af4f68a497John McCall
5557f85e193739c953358c865005855253af4f68a497John McCall/// Check for a keyword selector that starts with the word 'add' or
5558f85e193739c953358c865005855253af4f68a497John McCall/// 'set'.
5559f85e193739c953358c865005855253af4f68a497John McCallstatic bool isSetterLikeSelector(Selector sel) {
5560f85e193739c953358c865005855253af4f68a497John McCall  if (sel.isUnarySelector()) return false;
5561f85e193739c953358c865005855253af4f68a497John McCall
55625f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner  StringRef str = sel.getNameForSlot(0);
5563f85e193739c953358c865005855253af4f68a497John McCall  while (!str.empty() && str.front() == '_') str = str.substr(1);
5564968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek  if (str.startswith("set"))
5565f85e193739c953358c865005855253af4f68a497John McCall    str = str.substr(3);
5566968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek  else if (str.startswith("add")) {
5567968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek    // Specially whitelist 'addOperationWithBlock:'.
5568968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek    if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock"))
5569968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek      return false;
5570968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek    str = str.substr(3);
5571968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek  }
5572f85e193739c953358c865005855253af4f68a497John McCall  else
5573f85e193739c953358c865005855253af4f68a497John McCall    return false;
5574f85e193739c953358c865005855253af4f68a497John McCall
5575f85e193739c953358c865005855253af4f68a497John McCall  if (str.empty()) return true;
5576f85e193739c953358c865005855253af4f68a497John McCall  return !islower(str.front());
5577f85e193739c953358c865005855253af4f68a497John McCall}
5578f85e193739c953358c865005855253af4f68a497John McCall
5579f85e193739c953358c865005855253af4f68a497John McCall/// Check a message send to see if it's likely to cause a retain cycle.
5580f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(ObjCMessageExpr *msg) {
5581f85e193739c953358c865005855253af4f68a497John McCall  // Only check instance methods whose selector looks like a setter.
5582f85e193739c953358c865005855253af4f68a497John McCall  if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector()))
5583f85e193739c953358c865005855253af4f68a497John McCall    return;
5584f85e193739c953358c865005855253af4f68a497John McCall
5585f85e193739c953358c865005855253af4f68a497John McCall  // Try to find a variable that the receiver is strongly owned by.
5586f85e193739c953358c865005855253af4f68a497John McCall  RetainCycleOwner owner;
5587f85e193739c953358c865005855253af4f68a497John McCall  if (msg->getReceiverKind() == ObjCMessageExpr::Instance) {
55886e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian    if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner))
5589f85e193739c953358c865005855253af4f68a497John McCall      return;
5590f85e193739c953358c865005855253af4f68a497John McCall  } else {
5591f85e193739c953358c865005855253af4f68a497John McCall    assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance);
5592f85e193739c953358c865005855253af4f68a497John McCall    owner.Variable = getCurMethodDecl()->getSelfDecl();
5593f85e193739c953358c865005855253af4f68a497John McCall    owner.Loc = msg->getSuperLoc();
5594f85e193739c953358c865005855253af4f68a497John McCall    owner.Range = msg->getSuperLoc();
5595f85e193739c953358c865005855253af4f68a497John McCall  }
5596f85e193739c953358c865005855253af4f68a497John McCall
5597f85e193739c953358c865005855253af4f68a497John McCall  // Check whether the receiver is captured by any of the arguments.
5598f85e193739c953358c865005855253af4f68a497John McCall  for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i)
5599f85e193739c953358c865005855253af4f68a497John McCall    if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner))
5600f85e193739c953358c865005855253af4f68a497John McCall      return diagnoseRetainCycle(*this, capturer, owner);
5601f85e193739c953358c865005855253af4f68a497John McCall}
5602f85e193739c953358c865005855253af4f68a497John McCall
5603f85e193739c953358c865005855253af4f68a497John McCall/// Check a property assign to see if it's likely to cause a retain cycle.
5604f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(Expr *receiver, Expr *argument) {
5605f85e193739c953358c865005855253af4f68a497John McCall  RetainCycleOwner owner;
56066e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian  if (!findRetainCycleOwner(*this, receiver, owner))
5607f85e193739c953358c865005855253af4f68a497John McCall    return;
5608f85e193739c953358c865005855253af4f68a497John McCall
5609f85e193739c953358c865005855253af4f68a497John McCall  if (Expr *capturer = findCapturingExpr(*this, argument, owner))
5610f85e193739c953358c865005855253af4f68a497John McCall    diagnoseRetainCycle(*this, capturer, owner);
5611f85e193739c953358c865005855253af4f68a497John McCall}
5612f85e193739c953358c865005855253af4f68a497John McCall
5613e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rosevoid Sema::checkRetainCycles(VarDecl *Var, Expr *Init) {
5614e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose  RetainCycleOwner Owner;
5615e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose  if (!considerVariable(Var, /*DeclRefExpr=*/0, Owner))
5616e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose    return;
5617e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose
5618e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose  // Because we don't have an expression for the variable, we have to set the
5619e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose  // location explicitly here.
5620e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose  Owner.Loc = Var->getLocation();
5621e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose  Owner.Range = Var->getSourceRange();
5622e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose
5623e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose  if (Expr *Capturer = findCapturingExpr(*this, Init, Owner))
5624e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose    diagnoseRetainCycle(*this, Capturer, Owner);
5625e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose}
5626e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose
5627921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianbool Sema::checkUnsafeAssigns(SourceLocation Loc,
5628f85e193739c953358c865005855253af4f68a497John McCall                              QualType LHS, Expr *RHS) {
5629f85e193739c953358c865005855253af4f68a497John McCall  Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime();
5630f85e193739c953358c865005855253af4f68a497John McCall  if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone)
5631921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    return false;
5632921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  // strip off any implicit cast added to get to the one arc-specific
5633921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
563433e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall    if (cast->getCastKind() == CK_ARCConsumeObject) {
5635f85e193739c953358c865005855253af4f68a497John McCall      Diag(Loc, diag::warn_arc_retained_assign)
5636bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian        << (LT == Qualifiers::OCL_ExplicitNone) << 1
5637f85e193739c953358c865005855253af4f68a497John McCall        << RHS->getSourceRange();
5638921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian      return true;
5639921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    }
5640921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    RHS = cast->getSubExpr();
5641921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  }
5642921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  return false;
5643f85e193739c953358c865005855253af4f68a497John McCall}
5644f85e193739c953358c865005855253af4f68a497John McCall
5645921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianvoid Sema::checkUnsafeExprAssigns(SourceLocation Loc,
5646921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian                              Expr *LHS, Expr *RHS) {
564787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  QualType LHSType;
564887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  // PropertyRef on LHS type need be directly obtained from
564987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  // its declaration as it has a PsuedoType.
565087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  ObjCPropertyRefExpr *PRE
565187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens());
565287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  if (PRE && !PRE->isImplicitProperty()) {
565387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    const ObjCPropertyDecl *PD = PRE->getExplicitProperty();
565487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    if (PD)
565587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      LHSType = PD->getType();
565687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  }
565787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian
565887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  if (LHSType.isNull())
565987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    LHSType = LHS->getType();
56607a2704800943fbb69207e125d28186278712af36Jordan Rose
56617a2704800943fbb69207e125d28186278712af36Jordan Rose  Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime();
56627a2704800943fbb69207e125d28186278712af36Jordan Rose
56637a2704800943fbb69207e125d28186278712af36Jordan Rose  if (LT == Qualifiers::OCL_Weak) {
56647a2704800943fbb69207e125d28186278712af36Jordan Rose    DiagnosticsEngine::Level Level =
56657a2704800943fbb69207e125d28186278712af36Jordan Rose      Diags.getDiagnosticLevel(diag::warn_arc_repeated_use_of_weak, Loc);
56667a2704800943fbb69207e125d28186278712af36Jordan Rose    if (Level != DiagnosticsEngine::Ignored)
56677a2704800943fbb69207e125d28186278712af36Jordan Rose      getCurFunction()->markSafeWeakUse(LHS);
56687a2704800943fbb69207e125d28186278712af36Jordan Rose  }
56697a2704800943fbb69207e125d28186278712af36Jordan Rose
5670921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  if (checkUnsafeAssigns(Loc, LHSType, RHS))
5671921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    return;
56727a2704800943fbb69207e125d28186278712af36Jordan Rose
5673921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  // FIXME. Check for other life times.
5674921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  if (LT != Qualifiers::OCL_None)
5675921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    return;
5676921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian
567787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  if (PRE) {
5678921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    if (PRE->isImplicitProperty())
5679921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian      return;
5680921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    const ObjCPropertyDecl *PD = PRE->getExplicitProperty();
5681921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    if (!PD)
5682921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian      return;
5683921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian
5684921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    unsigned Attributes = PD->getPropertyAttributes();
568587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) {
568687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      // when 'assign' attribute was not explicitly specified
568787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      // by user, ignore it and rely on property type itself
568887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      // for lifetime info.
568987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten();
569087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) &&
569187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian          LHSType->isObjCRetainableType())
569287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian        return;
569387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian
5694921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian      while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
569533e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall        if (cast->getCastKind() == CK_ARCConsumeObject) {
5696921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian          Diag(Loc, diag::warn_arc_retained_property_assign)
5697921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian          << RHS->getSourceRange();
5698921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian          return;
5699921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian        }
5700921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian        RHS = cast->getSubExpr();
5701921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian      }
570287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    }
5703bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian    else if (Attributes & ObjCPropertyDecl::OBJC_PR_weak) {
5704bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian      while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
5705bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian        if (cast->getCastKind() == CK_ARCConsumeObject) {
5706bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian          Diag(Loc, diag::warn_arc_retained_assign)
5707bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian          << 0 << 0<< RHS->getSourceRange();
5708bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian          return;
5709bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian        }
5710bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian        RHS = cast->getSubExpr();
5711bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian      }
5712bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian    }
5713921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  }
5714921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian}
5715625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5716625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko//===--- CHECK: Empty statement body (-Wempty-body) ---------------------===//
5717625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5718625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkonamespace {
5719625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkobool ShouldDiagnoseEmptyStmtBody(const SourceManager &SourceMgr,
5720625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 SourceLocation StmtLoc,
5721625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 const NullStmt *Body) {
5722625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Do not warn if the body is a macro that expands to nothing, e.g:
5723625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //
5724625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // #define CALL(x)
5725625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // if (condition)
5726625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //   CALL(0);
5727625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //
5728625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (Body->hasLeadingEmptyMacro())
5729625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return false;
5730625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5731625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Get line numbers of statement and body.
5732625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  bool StmtLineInvalid;
5733625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  unsigned StmtLine = SourceMgr.getSpellingLineNumber(StmtLoc,
5734625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                                      &StmtLineInvalid);
5735625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (StmtLineInvalid)
5736625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return false;
5737625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5738625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  bool BodyLineInvalid;
5739625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  unsigned BodyLine = SourceMgr.getSpellingLineNumber(Body->getSemiLoc(),
5740625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                                      &BodyLineInvalid);
5741625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (BodyLineInvalid)
5742625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return false;
5743625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5744625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Warn if null statement and body are on the same line.
5745625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (StmtLine != BodyLine)
5746625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return false;
5747625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5748625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  return true;
5749625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko}
5750625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} // Unnamed namespace
5751625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5752625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyStmtBody(SourceLocation StmtLoc,
5753625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 const Stmt *Body,
5754625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 unsigned DiagID) {
5755625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Since this is a syntactic check, don't emit diagnostic for template
5756625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // instantiations, this just adds noise.
5757625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (CurrentInstantiationScope)
5758625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
5759625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5760625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // The body should be a null statement.
5761625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  const NullStmt *NBody = dyn_cast<NullStmt>(Body);
5762625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!NBody)
5763625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
5764625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5765625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Do the usual checks.
5766625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody))
5767625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
5768625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5769625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  Diag(NBody->getSemiLoc(), DiagID);
5770625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line);
5771625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko}
5772625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5773625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyLoopBody(const Stmt *S,
5774625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 const Stmt *PossibleBody) {
5775625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  assert(!CurrentInstantiationScope); // Ensured by caller
5776625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5777625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  SourceLocation StmtLoc;
5778625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  const Stmt *Body;
5779625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  unsigned DiagID;
5780625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (const ForStmt *FS = dyn_cast<ForStmt>(S)) {
5781625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    StmtLoc = FS->getRParenLoc();
5782625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    Body = FS->getBody();
5783625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    DiagID = diag::warn_empty_for_body;
5784625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  } else if (const WhileStmt *WS = dyn_cast<WhileStmt>(S)) {
5785625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    StmtLoc = WS->getCond()->getSourceRange().getEnd();
5786625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    Body = WS->getBody();
5787625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    DiagID = diag::warn_empty_while_body;
5788625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  } else
5789625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return; // Neither `for' nor `while'.
5790625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5791625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // The body should be a null statement.
5792625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  const NullStmt *NBody = dyn_cast<NullStmt>(Body);
5793625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!NBody)
5794625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
5795625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5796625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Skip expensive checks if diagnostic is disabled.
5797625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (Diags.getDiagnosticLevel(DiagID, NBody->getSemiLoc()) ==
5798625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko          DiagnosticsEngine::Ignored)
5799625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
5800625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5801625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Do the usual checks.
5802625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody))
5803625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
5804625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5805625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // `for(...);' and `while(...);' are popular idioms, so in order to keep
5806625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // noise level low, emit diagnostics only if for/while is followed by a
5807625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // CompoundStmt, e.g.:
5808625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //    for (int i = 0; i < n; i++);
5809625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //    {
5810625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //      a(i);
5811625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //    }
5812625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // or if for/while is followed by a statement with more indentation
5813625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // than for/while itself:
5814625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //    for (int i = 0; i < n; i++);
5815625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //      a(i);
5816625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  bool ProbableTypo = isa<CompoundStmt>(PossibleBody);
5817625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!ProbableTypo) {
5818625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    bool BodyColInvalid;
5819625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    unsigned BodyCol = SourceMgr.getPresumedColumnNumber(
5820625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                             PossibleBody->getLocStart(),
5821625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                             &BodyColInvalid);
5822625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    if (BodyColInvalid)
5823625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko      return;
5824625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5825625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    bool StmtColInvalid;
5826625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    unsigned StmtCol = SourceMgr.getPresumedColumnNumber(
5827625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                             S->getLocStart(),
5828625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                             &StmtColInvalid);
5829625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    if (StmtColInvalid)
5830625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko      return;
5831625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5832625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    if (BodyCol > StmtCol)
5833625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko      ProbableTypo = true;
5834625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  }
5835625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5836625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (ProbableTypo) {
5837625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    Diag(NBody->getSemiLoc(), DiagID);
5838625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line);
5839625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  }
5840625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko}
58410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- Layout compatibility ----------------------------------------------//
58430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace {
58450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2);
58470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two enumeration types are layout-compatible.
58490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, EnumDecl *ED1, EnumDecl *ED2) {
58500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // C++11 [dcl.enum] p8:
58510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // Two enumeration types are layout-compatible if they have the same
58520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // underlying type.
58530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return ED1->isComplete() && ED2->isComplete() &&
58540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         C.hasSameType(ED1->getIntegerType(), ED2->getIntegerType());
58550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
58560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two fields are layout-compatible.
58580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, FieldDecl *Field1, FieldDecl *Field2) {
58590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!isLayoutCompatible(C, Field1->getType(), Field2->getType()))
58600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
58610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (Field1->isBitField() != Field2->isBitField())
58630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
58640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (Field1->isBitField()) {
58660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // Make sure that the bit-fields are the same length.
58670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    unsigned Bits1 = Field1->getBitWidthValue(C);
58680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    unsigned Bits2 = Field2->getBitWidthValue(C);
58690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (Bits1 != Bits2)
58710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
58720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
58730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return true;
58750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
58760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout structs are layout-compatible.
58780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p17)
58790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleStruct(ASTContext &C,
58800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                              RecordDecl *RD1,
58810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                              RecordDecl *RD2) {
58820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // If both records are C++ classes, check that base classes match.
58830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (const CXXRecordDecl *D1CXX = dyn_cast<CXXRecordDecl>(RD1)) {
58840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // If one of records is a CXXRecordDecl we are in C++ mode,
58850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // thus the other one is a CXXRecordDecl, too.
58860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    const CXXRecordDecl *D2CXX = cast<CXXRecordDecl>(RD2);
58870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // Check number of base classes.
58880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (D1CXX->getNumBases() != D2CXX->getNumBases())
58890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
58900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
58910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // Check the base classes.
58920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    for (CXXRecordDecl::base_class_const_iterator
58930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko               Base1 = D1CXX->bases_begin(),
58940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko           BaseEnd1 = D1CXX->bases_end(),
58950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko              Base2 = D2CXX->bases_begin();
58960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         Base1 != BaseEnd1;
58970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         ++Base1, ++Base2) {
58980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (!isLayoutCompatible(C, Base1->getType(), Base2->getType()))
58990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        return false;
59000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
59010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  } else if (const CXXRecordDecl *D2CXX = dyn_cast<CXXRecordDecl>(RD2)) {
59020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // If only RD2 is a C++ class, it should have zero base classes.
59030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (D2CXX->getNumBases() > 0)
59040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
59050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
59060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // Check the fields.
59080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  RecordDecl::field_iterator Field2 = RD2->field_begin(),
59090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                             Field2End = RD2->field_end(),
59100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                             Field1 = RD1->field_begin(),
59110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                             Field1End = RD1->field_end();
59120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  for ( ; Field1 != Field1End && Field2 != Field2End; ++Field1, ++Field2) {
59130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (!isLayoutCompatible(C, *Field1, *Field2))
59140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
59150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
59160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (Field1 != Field1End || Field2 != Field2End)
59170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
59180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return true;
59200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
59210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout unions are layout-compatible.
59230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p18)
59240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleUnion(ASTContext &C,
59250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                             RecordDecl *RD1,
59260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                             RecordDecl *RD2) {
59270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  llvm::SmallPtrSet<FieldDecl *, 8> UnmatchedFields;
59280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  for (RecordDecl::field_iterator Field2 = RD2->field_begin(),
59290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                  Field2End = RD2->field_end();
59300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko       Field2 != Field2End; ++Field2) {
59310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    UnmatchedFields.insert(*Field2);
59320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
59330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  for (RecordDecl::field_iterator Field1 = RD1->field_begin(),
59350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                  Field1End = RD1->field_end();
59360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko       Field1 != Field1End; ++Field1) {
59370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    llvm::SmallPtrSet<FieldDecl *, 8>::iterator
59380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        I = UnmatchedFields.begin(),
59390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        E = UnmatchedFields.end();
59400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    for ( ; I != E; ++I) {
59420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (isLayoutCompatible(C, *Field1, *I)) {
59430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        bool Result = UnmatchedFields.erase(*I);
59440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        (void) Result;
59450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        assert(Result);
59460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        break;
59470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      }
59480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
59490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (I == E)
59500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
59510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
59520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return UnmatchedFields.empty();
59540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
59550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, RecordDecl *RD1, RecordDecl *RD2) {
59570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (RD1->isUnion() != RD2->isUnion())
59580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
59590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (RD1->isUnion())
59610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return isLayoutCompatibleUnion(C, RD1, RD2);
59620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  else
59630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return isLayoutCompatibleStruct(C, RD1, RD2);
59640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
59650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two types are layout-compatible in C++11 sense.
59670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2) {
59680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (T1.isNull() || T2.isNull())
59690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
59700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // C++11 [basic.types] p11:
59720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // If two types T1 and T2 are the same type, then T1 and T2 are
59730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // layout-compatible types.
59740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (C.hasSameType(T1, T2))
59750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return true;
59760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  T1 = T1.getCanonicalType().getUnqualifiedType();
59780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  T2 = T2.getCanonicalType().getUnqualifiedType();
59790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const Type::TypeClass TC1 = T1->getTypeClass();
59810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const Type::TypeClass TC2 = T2->getTypeClass();
59820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (TC1 != TC2)
59840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
59850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (TC1 == Type::Enum) {
59870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return isLayoutCompatible(C,
59880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                              cast<EnumType>(T1)->getDecl(),
59890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                              cast<EnumType>(T2)->getDecl());
59900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  } else if (TC1 == Type::Record) {
59910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (!T1->isStandardLayoutType() || !T2->isStandardLayoutType())
59920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
59930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return isLayoutCompatible(C,
59950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                              cast<RecordType>(T1)->getDecl(),
59960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                              cast<RecordType>(T2)->getDecl());
59970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
59980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
59990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return false;
60000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
60010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
60020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- CHECK: pointer_with_type_tag attribute: datatypes should match ----//
60040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace {
60060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Given a type tag expression find the type tag itself.
60070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
60080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Type tag expression, as it appears in user's code.
60090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
60100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param VD Declaration of an identifier that appears in a type tag.
60110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
60120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValue Type tag magic value.
60130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool FindTypeTagExpr(const Expr *TypeExpr, const ASTContext &Ctx,
60140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                     const ValueDecl **VD, uint64_t *MagicValue) {
60150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  while(true) {
60160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (!TypeExpr)
60170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
60180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    TypeExpr = TypeExpr->IgnoreParenImpCasts()->IgnoreParenCasts();
60200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    switch (TypeExpr->getStmtClass()) {
60220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    case Stmt::UnaryOperatorClass: {
60230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      const UnaryOperator *UO = cast<UnaryOperator>(TypeExpr);
60240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (UO->getOpcode() == UO_AddrOf || UO->getOpcode() == UO_Deref) {
60250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        TypeExpr = UO->getSubExpr();
60260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        continue;
60270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      }
60280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
60290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
60300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    case Stmt::DeclRefExprClass: {
60320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      const DeclRefExpr *DRE = cast<DeclRefExpr>(TypeExpr);
60330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      *VD = DRE->getDecl();
60340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return true;
60350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
60360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    case Stmt::IntegerLiteralClass: {
60380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      const IntegerLiteral *IL = cast<IntegerLiteral>(TypeExpr);
60390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      llvm::APInt MagicValueAPInt = IL->getValue();
60400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (MagicValueAPInt.getActiveBits() <= 64) {
60410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        *MagicValue = MagicValueAPInt.getZExtValue();
60420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        return true;
60430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      } else
60440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        return false;
60450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
60460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    case Stmt::BinaryConditionalOperatorClass:
60480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    case Stmt::ConditionalOperatorClass: {
60490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      const AbstractConditionalOperator *ACO =
60500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          cast<AbstractConditionalOperator>(TypeExpr);
60510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      bool Result;
60520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (ACO->getCond()->EvaluateAsBooleanCondition(Result, Ctx)) {
60530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        if (Result)
60540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          TypeExpr = ACO->getTrueExpr();
60550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        else
60560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          TypeExpr = ACO->getFalseExpr();
60570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        continue;
60580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      }
60590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
60600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
60610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    case Stmt::BinaryOperatorClass: {
60630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      const BinaryOperator *BO = cast<BinaryOperator>(TypeExpr);
60640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (BO->getOpcode() == BO_Comma) {
60650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        TypeExpr = BO->getRHS();
60660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        continue;
60670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      }
60680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
60690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
60700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    default:
60720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return false;
60730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
60740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
60750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
60760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Retrieve the C type corresponding to type tag TypeExpr.
60780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
60790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Expression that specifies a type tag.
60800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
60810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValues Registered magic values.
60820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
60830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param FoundWrongKind Set to true if a type tag was found, but of a wrong
60840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///        kind.
60850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
60860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeInfo Information about the corresponding C type.
60870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko///
60880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \returns true if the corresponding C type was found.
60890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool GetMatchingCType(
60900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        const IdentifierInfo *ArgumentKind,
60910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        const Expr *TypeExpr, const ASTContext &Ctx,
60920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        const llvm::DenseMap<Sema::TypeTagMagicValue,
60930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                             Sema::TypeTagData> *MagicValues,
60940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        bool &FoundWrongKind,
60950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        Sema::TypeTagData &TypeInfo) {
60960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  FoundWrongKind = false;
60970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
60980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // Variable declaration that has type_tag_for_datatype attribute.
60990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const ValueDecl *VD = NULL;
61000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
61010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  uint64_t MagicValue;
61020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
61030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!FindTypeTagExpr(TypeExpr, Ctx, &VD, &MagicValue))
61040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
61050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
61060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (VD) {
61070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    for (specific_attr_iterator<TypeTagForDatatypeAttr>
61080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko             I = VD->specific_attr_begin<TypeTagForDatatypeAttr>(),
61090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko             E = VD->specific_attr_end<TypeTagForDatatypeAttr>();
61100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         I != E; ++I) {
61110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if (I->getArgumentKind() != ArgumentKind) {
61120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        FoundWrongKind = true;
61130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        return false;
61140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      }
61150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      TypeInfo.Type = I->getMatchingCType();
61160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      TypeInfo.LayoutCompatible = I->getLayoutCompatible();
61170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      TypeInfo.MustBeNull = I->getMustBeNull();
61180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      return true;
61190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
61200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
61210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
61220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
61230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!MagicValues)
61240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
61250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
61260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  llvm::DenseMap<Sema::TypeTagMagicValue,
61270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                 Sema::TypeTagData>::const_iterator I =
61280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      MagicValues->find(std::make_pair(ArgumentKind, MagicValue));
61290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (I == MagicValues->end())
61300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
61310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
61320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  TypeInfo = I->second;
61330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return true;
61340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
61350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace
61360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
61370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::RegisterTypeTagForDatatype(const IdentifierInfo *ArgumentKind,
61380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                      uint64_t MagicValue, QualType Type,
61390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                      bool LayoutCompatible,
61400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                      bool MustBeNull) {
61410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!TypeTagForDatatypeMagicValues)
61420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    TypeTagForDatatypeMagicValues.reset(
61430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        new llvm::DenseMap<TypeTagMagicValue, TypeTagData>);
61440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
61450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  TypeTagMagicValue Magic(ArgumentKind, MagicValue);
61460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  (*TypeTagForDatatypeMagicValues)[Magic] =
61470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      TypeTagData(Type, LayoutCompatible, MustBeNull);
61480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
61490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
61500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace {
61510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool IsSameCharType(QualType T1, QualType T2) {
61520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const BuiltinType *BT1 = T1->getAs<BuiltinType>();
61530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!BT1)
61540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
61550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
61560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const BuiltinType *BT2 = T2->getAs<BuiltinType>();
61570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!BT2)
61580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return false;
61590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
61600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  BuiltinType::Kind T1Kind = BT1->getKind();
61610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  BuiltinType::Kind T2Kind = BT2->getKind();
61620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
61630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  return (T1Kind == BuiltinType::SChar  && T2Kind == BuiltinType::Char_S) ||
61640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         (T1Kind == BuiltinType::UChar  && T2Kind == BuiltinType::Char_U) ||
61650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         (T1Kind == BuiltinType::Char_U && T2Kind == BuiltinType::UChar) ||
61660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko         (T1Kind == BuiltinType::Char_S && T2Kind == BuiltinType::SChar);
61670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
61680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace
61690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
61700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::CheckArgumentWithTypeTag(const ArgumentWithTypeTagAttr *Attr,
61710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                    const Expr * const *ExprArgs) {
61720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const IdentifierInfo *ArgumentKind = Attr->getArgumentKind();
61730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  bool IsPointerAttr = Attr->getIsPointer();
61740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
61750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const Expr *TypeTagExpr = ExprArgs[Attr->getTypeTagIdx()];
61760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  bool FoundWrongKind;
61770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  TypeTagData TypeInfo;
61780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!GetMatchingCType(ArgumentKind, TypeTagExpr, Context,
61790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                        TypeTagForDatatypeMagicValues.get(),
61800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                        FoundWrongKind, TypeInfo)) {
61810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (FoundWrongKind)
61820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      Diag(TypeTagExpr->getExprLoc(),
61830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko           diag::warn_type_tag_for_datatype_wrong_kind)
61840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        << TypeTagExpr->getSourceRange();
61850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return;
61860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
61870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
61880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  const Expr *ArgumentExpr = ExprArgs[Attr->getArgumentIdx()];
61890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (IsPointerAttr) {
61900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // Skip implicit cast of pointer to `void *' (as a function argument).
61910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(ArgumentExpr))
61925a24980d059cd9fbe8375a4c549313101ad20698Dmitri Gribenko      if (ICE->getType()->isVoidPointerType() &&
61935a24980d059cd9fbe8375a4c549313101ad20698Dmitri Gribenko          ICE->getCastKind() != CK_NullToPointer &&
61945a24980d059cd9fbe8375a4c549313101ad20698Dmitri Gribenko          ICE->getCastKind() != CK_NullToMemberPointer)
61950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        ArgumentExpr = ICE->getSubExpr();
61960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
61970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  QualType ArgumentType = ArgumentExpr->getType();
61980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
61990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  // Passing a `void*' pointer shouldn't trigger a warning.
62000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (IsPointerAttr && ArgumentType->isVoidPointerType())
62010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return;
62020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
62030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (TypeInfo.MustBeNull) {
62040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // Type tag with matching void type requires a null pointer.
62050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (!ArgumentExpr->isNullPointerConstant(Context,
62060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                             Expr::NPC_ValueDependentIsNotNull)) {
62070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      Diag(ArgumentExpr->getExprLoc(),
62080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko           diag::warn_type_safety_null_pointer_required)
62090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          << ArgumentKind->getName()
62100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          << ArgumentExpr->getSourceRange()
62110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          << TypeTagExpr->getSourceRange();
62120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    }
62130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    return;
62140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  }
62150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
62160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  QualType RequiredType = TypeInfo.Type;
62170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (IsPointerAttr)
62180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    RequiredType = Context.getPointerType(RequiredType);
62190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
62200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  bool mismatch = false;
62210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (!TypeInfo.LayoutCompatible) {
62220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    mismatch = !Context.hasSameType(ArgumentType, RequiredType);
62230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
62240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // C++11 [basic.fundamental] p1:
62250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // Plain char, signed char, and unsigned char are three distinct types.
62260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    //
62270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // But we treat plain `char' as equivalent to `signed char' or `unsigned
62280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    // char' depending on the current char signedness mode.
62290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (mismatch)
62300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      if ((IsPointerAttr && IsSameCharType(ArgumentType->getPointeeType(),
62310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                           RequiredType->getPointeeType())) ||
62320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko          (!IsPointerAttr && IsSameCharType(ArgumentType, RequiredType)))
62330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        mismatch = false;
62340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  } else
62350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    if (IsPointerAttr)
62360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      mismatch = !isLayoutCompatible(Context,
62370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                     ArgumentType->getPointeeType(),
62380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko                                     RequiredType->getPointeeType());
62390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    else
62400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko      mismatch = !isLayoutCompatible(Context, ArgumentType, RequiredType);
62410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko
62420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko  if (mismatch)
62430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko    Diag(ArgumentExpr->getExprLoc(), diag::warn_type_safety_type_mismatch)
62440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        << ArgumentType << ArgumentKind->getName()
62450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        << TypeInfo.LayoutCompatible << RequiredType
62460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        << ArgumentExpr->getSourceRange()
62470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko        << TypeTagExpr->getSourceRange();
62480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko}
6249