SemaChecking.cpp revision 5e9ebb3c0fb554d9285aa99c470abdf283272bd9
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// The LLVM Compiler Infrastructure 459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source 60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details. 759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump// This file implements extra semantic analysis beyond what is enforced 1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// by the C type system. 1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 15e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Sema.h" 162d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 17781472fe99a120098c631b0cbe33c89f8cef5e70John McCall#include "clang/Sema/ScopeInfo.h" 18826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek#include "clang/Analysis/Analyses/FormatString.h" 1959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h" 20199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h" 21384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 22c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h" 232324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h" 247ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h" 25f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/DeclObjC.h" 26f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h" 27f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h" 2859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h" 29f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h" 30f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h" 313bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h" 32691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher#include "clang/Basic/TargetBuiltins.h" 3326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman#include "clang/Basic/TargetInfo.h" 347da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian#include "clang/Basic/ConvertUTF.h" 35a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits> 3659907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang; 37781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema; 3859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 3960800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 4060800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned ByteNo) const { 4108f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner return SL->getLocationOfByte(ByteNo, PP.getSourceManager(), 4208f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner PP.getLangOptions(), PP.getTargetInfo()); 4360800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner} 4408f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner 4560800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 464403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// CheckablePrintfAttr - does a function call have a "printf" attribute 474403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// and arguments that merit checking? 484403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynnbool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) { 494403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf") return true; 504403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf0") { 514403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn // printf0 allows null "format" string; if so don't check format/args 524403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn unsigned format_idx = Format->getFormatIdx() - 1; 534a2614e94672c47395abcde60518776fbebec589Sebastian Redl // Does the index refer to the implicit object argument? 544a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 554a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (format_idx == 0) 564a2614e94672c47395abcde60518776fbebec589Sebastian Redl return false; 574a2614e94672c47395abcde60518776fbebec589Sebastian Redl --format_idx; 584a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 594403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (format_idx < TheCall->getNumArgs()) { 604403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts(); 61efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!Format->isNullPointerConstant(Context, 62efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek Expr::NPC_ValueDependentIsNull)) 634403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return true; 644403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 654403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 664403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return false; 674403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn} 6860800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 698e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number. 708e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking. Returns true on error. 718e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) { 728e10f3b9cc1db43645bbc2999eb163af8997d468John McCall unsigned argCount = call->getNumArgs(); 738e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount == desiredArgCount) return false; 748e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 758e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount < desiredArgCount) 768e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args) 778e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 788e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getSourceRange(); 798e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 808e10f3b9cc1db43645bbc2999eb163af8997d468John McCall // Highlight all the excess arguments. 818e10f3b9cc1db43645bbc2999eb163af8997d468John McCall SourceRange range(call->getArg(desiredArgCount)->getLocStart(), 828e10f3b9cc1db43645bbc2999eb163af8997d468John McCall call->getArg(argCount - 1)->getLocEnd()); 838e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 848e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args) 858e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 868e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getArg(1)->getSourceRange(); 878e10f3b9cc1db43645bbc2999eb163af8997d468John McCall} 888e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 8960d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 90d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 9160d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult TheCallResult(Owned(TheCall)); 922def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor 93946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Find out if any arguments are required to be integer constant expressions. 94946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner unsigned ICEArguments = 0; 95946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ASTContext::GetBuiltinTypeError Error; 96946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 97946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (Error != ASTContext::GE_None) 98946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments = 0; // Don't diagnose previously diagnosed errors. 99946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 100946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // If any arguments are required to be ICE's, check and diagnose. 101946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 102946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Skip arguments not required to be ICE's. 103946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if ((ICEArguments & (1 << ArgNo)) == 0) continue; 104946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 105946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner llvm::APSInt Result; 106946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 107946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner return true; 108946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments &= ~(1 << ArgNo); 109946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner } 110946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 111d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson switch (BuiltinID) { 11230ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin___CFStringMakeConstantString: 113925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner assert(TheCall->getNumArgs() == 1 && 1141b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner "Wrong # arguments to builtin CFStringMakeConstantString"); 115690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner if (CheckObjCString(TheCall->getArg(0))) 1160eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 117d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 11849ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek case Builtin::BI__builtin_stdarg_start: 11930ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin_va_start: 1200eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinVAStart(TheCall)) 1210eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 122d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1231b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreater: 1241b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreaterequal: 1251b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isless: 1261b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessequal: 1271b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessgreater: 1281b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isunordered: 1290eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinUnorderedCompare(TheCall)) 1300eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 131d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 132e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer case Builtin::BI__builtin_fpclassify: 133e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer if (SemaBuiltinFPClassification(TheCall, 6)) 134e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer return ExprError(); 135e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer break; 1369ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isfinite: 1379ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf: 1389ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf_sign: 1399ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnan: 1409ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnormal: 1413b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (SemaBuiltinFPClassification(TheCall, 1)) 1429ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return ExprError(); 1439ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman break; 144d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman case Builtin::BI__builtin_shufflevector: 1450eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return SemaBuiltinShuffleVector(TheCall); 1460eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // TheCall will be freed by the smart pointer here, but that's fine, since 1470eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // SemaBuiltinShuffleVector guts it, but then doesn't release it. 1484493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar case Builtin::BI__builtin_prefetch: 1490eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinPrefetch(TheCall)) 1500eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 151d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 152d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar case Builtin::BI__builtin_object_size: 1530eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinObjectSize(TheCall)) 1540eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 155d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 156d875fed28578835de89cd407e9db4be788596d7cEli Friedman case Builtin::BI__builtin_longjmp: 157d875fed28578835de89cd407e9db4be788596d7cEli Friedman if (SemaBuiltinLongjmp(TheCall)) 158d875fed28578835de89cd407e9db4be788596d7cEli Friedman return ExprError(); 159d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1608e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 1618e10f3b9cc1db43645bbc2999eb163af8997d468John McCall case Builtin::BI__builtin_classify_type: 1628e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1638e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 1648e10f3b9cc1db43645bbc2999eb163af8997d468John McCall break; 16575c29a012793292ff4578015a9113bf086156d7fChris Lattner case Builtin::BI__builtin_constant_p: 1668e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1678e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 16875c29a012793292ff4578015a9113bf086156d7fChris Lattner break; 1695caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: 1705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: 1715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: 1725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: 1735caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: 1745caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_add_and_fetch: 1755caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_sub_and_fetch: 1765caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_and_and_fetch: 1775caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_or_and_fetch: 1785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_xor_and_fetch: 1795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 1805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 1815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_test_and_set: 1825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 18323aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: 184d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return SemaBuiltinAtomicOverloaded(move(TheCallResult)); 18526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 18626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 18726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // Since the target specific builtins for each arch overlap, only check those 18826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // of the arch we are compiling for. 18926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (BuiltinID >= Builtin::FirstTSBuiltin) { 19026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman switch (Context.Target.getTriple().getArch()) { 19126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::arm: 19226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::thumb: 19326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 19426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return ExprError(); 19526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 19626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman default: 19726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 19826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 19926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 20026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 20126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return move(TheCallResult); 20226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman} 20326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 20461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code. 20561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) { 20661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman bool quad = t & 0x10; 20761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 20861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman switch (t & 0x7) { 20961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 0: // i8 210d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 7 : (8 << (int)quad) - 1; 21161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 1: // i16 212d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 15 : (4 << (int)quad) - 1; 21361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 2: // i32 214d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 31 : (2 << (int)quad) - 1; 21561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 3: // i64 216d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 63 : (1 << (int)quad) - 1; 21761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 4: // f32 21861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift float types!"); 219d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (2 << (int)quad) - 1; 22061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 5: // poly8 22142499f94069c73d7a9c82da98a4245ea9fe2c526Bob Wilson return shift ? 7 : (8 << (int)quad) - 1; 22261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 6: // poly16 22342499f94069c73d7a9c82da98a4245ea9fe2c526Bob Wilson return shift ? 15 : (4 << (int)quad) - 1; 22461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 7: // float16 22561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift float types!"); 226d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (4 << (int)quad) - 1; 22761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman } 22861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman return 0; 22961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman} 23061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 23126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 2321c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman llvm::APSInt Result; 2331c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2340d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned mask = 0; 23561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned TV = 0; 2361c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman switch (BuiltinID) { 237a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK 238a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 239a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK 2401c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman } 2411c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2420d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which are overloaded on vector element type, validate 2430d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // the immediate which specifies which variant to emit. 2440d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (mask) { 2450d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned ArgNo = TheCall->getNumArgs()-1; 2460d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 2470d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 2480d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 24961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman TV = Result.getLimitedValue(32); 25061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if ((TV > 31) || (mask & (1 << TV)) == 0) 2510d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 2520d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman << TheCall->getArg(ArgNo)->getSourceRange(); 2530d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman } 2541c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2550d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which take an immediate value as part of the 2560d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // instruction, range check them here. 25761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned i = 0, l = 0, u = 0; 2580d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman switch (BuiltinID) { 2590d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman default: return false; 260bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 261bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 26299c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_f: 26399c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 264a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK 265a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 266a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK 2670d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman }; 2680d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 26961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Check that the immediate argument is actually a constant. 2700d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, i, Result)) 2710d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 2720d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 27361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Range check against the upper/lower values for this isntruction. 2740d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned Val = Result.getZExtValue(); 27561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if (Val < l || Val > (u + l)) 2760d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 277476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer << l << u+l << TheCall->getArg(i)->getSourceRange(); 2780d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 27999c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman // FIXME: VFP Intrinsics should error if VFP not present. 28026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return false; 281d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson} 282d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 283d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// CheckFunctionCall - Check a direct function call for various correctness 284d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// and safety properties not strictly enforced by the C type system. 285d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) { 286d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // Get the IdentifierInfo* for the called function. 287d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson IdentifierInfo *FnInfo = FDecl->getIdentifier(); 288de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 289d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // None of the checks below are needed for functions that don't have 290d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // simple names (e.g., C++ conversion functions). 291d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson if (!FnInfo) 292d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 2931eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 294de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // FIXME: This mechanism should be abstracted to be less fragile and 295de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // more efficient. For example, just map function ids to custom 296de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // handlers. 297de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 298c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek // Printf and scanf checking. 299c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<FormatAttr> 300c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<FormatAttr>(), 301c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<FormatAttr>(); i != e ; ++i) { 302c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek 303c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek const FormatAttr *Format = *i; 304826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 305826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (b || CheckablePrintfAttr(Format, TheCall)) { 3063d692df4b9c58895f9843b03543ec57447c93679Ted Kremenek bool HasVAListArg = Format->getFirstArg() == 0; 307826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, 308826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Format->getFormatIdx() - 1, 309826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, 310826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek !b); 3113c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor } 31259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner } 3131eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 314c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<NonNullAttr> 315c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<NonNullAttr>(), 316c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<NonNullAttr>(); i != e; ++i) { 317909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky CheckNonNullArguments(*i, TheCall->getArgs(), 318909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky TheCall->getCallee()->getLocStart()); 319c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek } 3200eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 32106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor // Memset/memcpy/memmove handling 32206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor if (FDecl->getLinkage() == ExternalLinkage && 32306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor (!getLangOptions().CPlusPlus || FDecl->isExternC())) { 32406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor if (FnInfo->isStr("memset") || FnInfo->isStr("memcpy") || 32506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor FnInfo->isStr("memmove")) 32606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor CheckMemsetcpymoveArguments(TheCall, FnInfo); 32706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 3287ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 329d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 33071993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson} 33171993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 332d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) { 333725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian // Printf checking. 33440b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis const FormatAttr *Format = NDecl->getAttr<FormatAttr>(); 335725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Format) 336d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3371eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 338725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian const VarDecl *V = dyn_cast<VarDecl>(NDecl); 339725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!V) 340d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3411eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 342725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian QualType Ty = V->getType(); 343725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Ty->isBlockPointerType()) 344d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 346826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 347826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!b && !CheckablePrintfAttr(Format, TheCall)) 348d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3491eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 350d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson bool HasVAListArg = Format->getFirstArg() == 0; 351826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1, 352826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, !b); 353d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 354d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 355725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian} 356725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian 3575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like 3585caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer 3595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument. The main ActOnCallExpr routines have already 3605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as 3615caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...). 3625caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// 3635caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these 3645caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins, 36560d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 36660d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 367d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 3685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 3695caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 3705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 3715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Ensure that we have at least one argument to do type inference from. 372d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1) { 373d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 374d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1 << TheCall->getNumArgs() 375d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 376d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 377d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 3781eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Inspect the first argument of the atomic builtin. This should always be 3805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // a pointer type, whose element is an integral scalar or pointer type. 3815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Because it is a pointer type, we don't have to worry about any implicit 3825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // casts here. 383d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth // FIXME: We don't allow floating point scalars as input. 3845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *FirstArg = TheCall->getArg(0); 385d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (!FirstArg->getType()->isPointerType()) { 386d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 387d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 388d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 389d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 3901eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 391d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth QualType ValType = 392d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth FirstArg->getType()->getAs<PointerType>()->getPointeeType(); 393dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 394d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth !ValType->isBlockPointerType()) { 395d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 396d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 397d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 398d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 3995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 4008d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // The majority of builtins return a value, but a few have special return 4018d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // types, so allow them to override appropriately below. 4028d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth QualType ResultType = ValType; 4038d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth 4045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // We need to figure out which concrete builtin this maps onto. For example, 4055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add with a 2 byte object turns into 4065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add_2. 4075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \ 4085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 4095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Builtin::BI##x##_8, Builtin::BI##x##_16 } 4101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner static const unsigned BuiltinIndices[][5] = { 4125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_add), 4135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_sub), 4145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_or), 4155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_and), 4165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_xor), 4171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_add_and_fetch), 4195caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_sub_and_fetch), 4205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_and_and_fetch), 4215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_or_and_fetch), 4225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_xor_and_fetch), 4231eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_val_compare_and_swap), 4255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_bool_compare_and_swap), 4265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_test_and_set), 42723aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_lock_release), 42823aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_swap) 4295caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner }; 4301eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW 4311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Determine the index of the size. 4335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned SizeIndex; 434199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 4355caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 1: SizeIndex = 0; break; 4365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 2: SizeIndex = 1; break; 4375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 4: SizeIndex = 2; break; 4385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 8: SizeIndex = 3; break; 4395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 16: SizeIndex = 4; break; 4405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: 441d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 442d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 443d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 4445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 4451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Each of these builtins has one pointer argument, followed by some number of 4475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // values (0, 1 or 2) followed by a potentially empty varags list of stuff 4485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // that we ignore. Find out which row of BuiltinIndices to read from as well 4495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // as the number of fixed args. 4507814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor unsigned BuiltinID = FDecl->getBuiltinID(); 4515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned BuiltinIndex, NumFixed = 1; 4525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner switch (BuiltinID) { 4535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: assert(0 && "Unknown overloaded atomic builtin!"); 4545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break; 4555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break; 4565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break; 4575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break; 4585caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break; 4591eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4607eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break; 4617eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break; 4627eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break; 4637eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break; 4647eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break; 4651eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4665caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 4677eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 10; 4685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 4695caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 4705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 4717eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 11; 4725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 4738d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.BoolTy; 4745caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 4757eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break; 4765caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 4777eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 13; 4785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 0; 4798d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.VoidTy; 4805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 48123aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: BuiltinIndex = 14; break; 4825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 4831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Now that we know how many fixed arguments we expect, first check that we 4855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // have at least that many. 486d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1+NumFixed) { 487d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 488d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1+NumFixed << TheCall->getNumArgs() 489d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 490d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 491d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 4921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 493e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // Get the decl for the concrete builtin from this, we can tell what the 494e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // concrete integer type we should convert to is. 495e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 496e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 497e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName); 4981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump FunctionDecl *NewBuiltinDecl = 499e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID, 500e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner TUScope, false, DRE->getLocStart())); 501d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 502f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // The first argument --- the pointer --- has a fixed type; we 503f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // deduce the types of the rest of the arguments accordingly. Walk 504f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // the remaining arguments, converting them to the deduced value type. 5055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner for (unsigned i = 0; i != NumFixed; ++i) { 506429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult Arg = TheCall->getArg(i+1); 5071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // If the argument is an implicit cast, then there was a promotion due to 5095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // "...", just remove it now. 510429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg.get())) { 5115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Arg = ICE->getSubExpr(); 5125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner ICE->setSubExpr(0); 513429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(i+1, Arg.get()); 5145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 5151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // GCC does an implicit conversion to the pointer or integer ValType. This 5175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // can fail in some cases (1i -> int**), check for this error case now. 518daa8e4e888758d55a7a759dd4a91b83921cef222John McCall CastKind Kind = CK_Invalid; 519f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall ExprValueKind VK = VK_RValue; 520f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall CXXCastPath BasePath; 521429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley Arg = CheckCastTypes(Arg.get()->getSourceRange(), ValType, Arg.take(), Kind, VK, BasePath); 522429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (Arg.isInvalid()) 523d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 5241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Okay, we have something that *can* be converted to the right type. Check 5265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // to see if there is a potentially weird extension going on here. This can 5275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // happen when you do an atomic operation on something like an char* and 5285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // pass in 42. The 42 gets converted to char. This is even more strange 5295caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // for things like 45.123 -> char, etc. 5301eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // FIXME: Do this check. 531429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley Arg = ImpCastExprToType(Arg.take(), ValType, Kind, VK, &BasePath); 532429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(i+1, Arg.get()); 5335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 5341eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5355caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Switch the DeclRefExpr to refer to the new decl. 5365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DRE->setDecl(NewBuiltinDecl); 5375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DRE->setType(NewBuiltinDecl->getType()); 5381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Set the callee in the CallExpr. 5405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // FIXME: This leaks the original parens and implicit casts. 541429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult PromotedCall = UsualUnaryConversions(DRE); 542429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (PromotedCall.isInvalid()) 543429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return ExprError(); 544429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setCallee(PromotedCall.take()); 5451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 546db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // Change the result type of the call to match the original value type. This 547db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // is arbitrary, but the codegen for these builtins ins design to handle it 548db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // gracefully. 5498d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth TheCall->setType(ResultType); 550d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 551d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return move(TheCallResult); 5525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner} 5535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 5545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 555690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin 55671993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct 557fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would 558fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend). 559690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) { 56056f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner Arg = Arg->IgnoreParenCasts(); 56171993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 56271993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 56371993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson if (!Literal || Literal->isWide()) { 564fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 565fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << Arg->getSourceRange(); 5669cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return true; 56771993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson } 5681eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5697da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Literal->containsNonAsciiOrNull()) { 5707da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian llvm::StringRef String = Literal->getString(); 5717da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian unsigned NumBytes = String.size(); 5727da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian llvm::SmallVector<UTF16, 128> ToBuf(NumBytes); 5737da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian const UTF8 *FromPtr = (UTF8 *)String.data(); 5747da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian UTF16 *ToPtr = &ToBuf[0]; 5757da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 5767da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 5777da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian &ToPtr, ToPtr + NumBytes, 5787da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian strictConversion); 5797da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian // Check for conversion failure. 5807da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Result != conversionOK) 5817da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian Diag(Arg->getLocStart(), 5827da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian diag::warn_cfstring_truncated) << Arg->getSourceRange(); 5837da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian } 5849cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return false; 58559907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner} 58659907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 587c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 588c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success. 589925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 590925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *Fn = TheCall->getCallee(); 591925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) { 5922c21a073525cdfa68e4439b7af551385dc2796abChris Lattner Diag(TheCall->getArg(2)->getLocStart(), 593fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 594ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 595ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << Fn->getSourceRange() 5961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(2)->getLocStart(), 597fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 59830ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 59930ce344307f8a8b00054021307015571f83c7364Chris Lattner } 60056f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 60156f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman if (TheCall->getNumArgs() < 2) { 602d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher return Diag(TheCall->getLocEnd(), 603d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 604d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 60556f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman } 60656f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 607c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner // Determine whether the current function is variadic or not. 6089ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor BlockScopeInfo *CurBlock = getCurBlock(); 609c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner bool isVariadic; 610cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 611c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall isVariadic = CurBlock->TheDecl->isVariadic(); 6129498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else if (FunctionDecl *FD = getCurFunctionDecl()) 6139498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek isVariadic = FD->isVariadic(); 6149498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else 61553d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis isVariadic = getCurMethodDecl()->isVariadic(); 6161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 617c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner if (!isVariadic) { 61830ce344307f8a8b00054021307015571f83c7364Chris Lattner Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 61930ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 62030ce344307f8a8b00054021307015571f83c7364Chris Lattner } 6211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 62230ce344307f8a8b00054021307015571f83c7364Chris Lattner // Verify that the second argument to the builtin is the last argument of the 62330ce344307f8a8b00054021307015571f83c7364Chris Lattner // current function or method. 62430ce344307f8a8b00054021307015571f83c7364Chris Lattner bool SecondArgIsLastNamedArgument = false; 625e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 6261eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 62788cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 62888cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 62930ce344307f8a8b00054021307015571f83c7364Chris Lattner // FIXME: This isn't correct for methods (results in bogus warning). 63030ce344307f8a8b00054021307015571f83c7364Chris Lattner // Get the last formal in the current function. 63188cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson const ParmVarDecl *LastArg; 632cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 633cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff LastArg = *(CurBlock->TheDecl->param_end()-1); 634cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff else if (FunctionDecl *FD = getCurFunctionDecl()) 635371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner LastArg = *(FD->param_end()-1); 63630ce344307f8a8b00054021307015571f83c7364Chris Lattner else 63753d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis LastArg = *(getCurMethodDecl()->param_end()-1); 63830ce344307f8a8b00054021307015571f83c7364Chris Lattner SecondArgIsLastNamedArgument = PV == LastArg; 63930ce344307f8a8b00054021307015571f83c7364Chris Lattner } 64030ce344307f8a8b00054021307015571f83c7364Chris Lattner } 6411eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 64230ce344307f8a8b00054021307015571f83c7364Chris Lattner if (!SecondArgIsLastNamedArgument) 6431eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(1)->getLocStart(), 64430ce344307f8a8b00054021307015571f83c7364Chris Lattner diag::warn_second_parameter_of_va_start_not_last_named_argument); 64530ce344307f8a8b00054021307015571f83c7364Chris Lattner return false; 6466cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman} 64730ce344307f8a8b00054021307015571f83c7364Chris Lattner 6481b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 6491b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends. This is declared to take (...), so we have to check everything. 650925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 651925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() < 2) 6522c21a073525cdfa68e4439b7af551385dc2796abChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 653d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << 2 << TheCall->getNumArgs()/*function call*/; 654925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) 6551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(TheCall->getArg(2)->getLocStart(), 656fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 657ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 658fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(TheCall->getArg(2)->getLocStart(), 659fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 6601eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 661429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg0 = TheCall->getArg(0); 662429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg1 = TheCall->getArg(1); 663cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 6641b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // Do standard promotions between the two arguments, returning their common 6651b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // type. 666925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 667429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.isInvalid() || OrigArg1.isInvalid()) 668429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return true; 669403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar 670403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // Make sure any conversions are pushed back into the call; this is 671403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // type safe since unordered compare builtins are declared as "_Bool 672403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // foo(...)". 673429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(0, OrigArg0.get()); 674429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(1, OrigArg1.get()); 6751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 676429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent()) 677cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 678cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 6791b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // If the common type isn't a real floating type, then the arguments were 6801b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // invalid for this operation. 6811b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner if (!Res->isRealFloatingType()) 682429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return Diag(OrigArg0.get()->getLocStart(), 683fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_invalid_ordered_compare) 684429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << OrigArg0.get()->getType() << OrigArg1.get()->getType() 685429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd()); 6861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 6871b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner return false; 6881b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner} 6891b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner 690e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 691e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends. This is declared to take (...), so we have 6923b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point 6933b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value. 6943b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 6953b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() < NumArgs) 6969ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 697d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 6983b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() > NumArgs) 6993b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer return Diag(TheCall->getArg(NumArgs)->getLocStart(), 7009ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_too_many_args) 701ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 7023b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 7039ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman (*(TheCall->arg_end()-1))->getLocEnd()); 7049ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 7053b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer Expr *OrigArg = TheCall->getArg(NumArgs-1); 7061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7079ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (OrigArg->isTypeDependent()) 7089ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 7099ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 71081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // This operation requires a non-_Complex floating-point number. 7119ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (!OrigArg->getType()->isRealFloatingType()) 7121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg->getLocStart(), 7139ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_invalid_unary_fp) 7149ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman << OrigArg->getType() << OrigArg->getSourceRange(); 7151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 71681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // If this is an implicit conversion from float -> double, remove it. 71781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 71881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Expr *CastArg = Cast->getSubExpr(); 71981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 72081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 72181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner "promotion from float to double is the only expected cast here"); 72281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Cast->setSubExpr(0); 72381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner TheCall->setArg(NumArgs-1, CastArg); 72481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner OrigArg = CastArg; 72581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 72681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 72781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner 7289ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 7299ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman} 7309ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 731d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 732d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything. 73360d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 73437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() < 2) 7350eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocEnd(), 736d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 73737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << 0 /*function call*/ << 2 << TheCall->getNumArgs() 738d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << TheCall->getSourceRange()); 739d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 74037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Determine which of the following types of shufflevector we're checking: 74137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 1) unary, vector mask: (lhs, mask) 74237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 2) binary, vector mask: (lhs, rhs, mask) 74337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 74437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType resType = TheCall->getArg(0)->getType(); 74537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numElements = 0; 74637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 747cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (!TheCall->getArg(0)->isTypeDependent() && 748cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor !TheCall->getArg(1)->isTypeDependent()) { 74937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType LHSType = TheCall->getArg(0)->getType(); 75037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType RHSType = TheCall->getArg(1)->getType(); 75137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 75237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!LHSType->isVectorType() || !RHSType->isVectorType()) { 753cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) 7541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 755cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 756cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 757cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 75837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 75937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numElements = LHSType->getAs<VectorType>()->getNumElements(); 76037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numResElements = TheCall->getNumArgs() - 2; 76137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 76237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Check to see if we have a call with 2 vector arguments, the unary shuffle 76337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // with mask. If so, verify that RHS is an integer vector type with the 76437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // same number of elts as lhs. 76537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() == 2) { 766f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (!RHSType->hasIntegerRepresentation() || 76737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman RHSType->getAs<VectorType>()->getNumElements() != numElements) 76837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 76937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << SourceRange(TheCall->getArg(1)->getLocStart(), 77037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman TheCall->getArg(1)->getLocEnd()); 77137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numResElements = numElements; 77237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } 77337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 774cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 7751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 776cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 777cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 77837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } else if (numElements != numResElements) { 77937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 780788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner resType = Context.getVectorType(eltType, numResElements, 781e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson VectorType::GenericVector); 782cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 783d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 784d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 785d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 786cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 787cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(i)->isValueDependent()) 788cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor continue; 789cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 79037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman llvm::APSInt Result(32); 79137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 79237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman return ExprError(Diag(TheCall->getLocStart(), 79337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman diag::err_shufflevector_nonconstant_argument) 79437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << TheCall->getArg(i)->getSourceRange()); 7950eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 796d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 7970eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocStart(), 798fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_shufflevector_argument_too_large) 7990eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl << TheCall->getArg(i)->getSourceRange()); 800d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 801d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 802d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman llvm::SmallVector<Expr*, 32> exprs; 803d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 804d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 805d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman exprs.push_back(TheCall->getArg(i)); 806d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman TheCall->setArg(i, 0); 807d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 808d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 809a88dc3079bedf70a5cfc39791727e43a10383006Nate Begeman return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(), 81037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman exprs.size(), resType, 8118189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getCallee()->getLocStart(), 8128189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getRParenLoc())); 813d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman} 81430ce344307f8a8b00054021307015571f83c7364Chris Lattner 8154493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 8164493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two 8174493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args. 8184493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 819fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner unsigned NumArgs = TheCall->getNumArgs(); 8204493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 821fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (NumArgs > 3) 822ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher return Diag(TheCall->getLocEnd(), 823ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher diag::err_typecheck_call_too_many_args_at_most) 824ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 3 << NumArgs 825ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << TheCall->getSourceRange(); 8264493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 8274493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // Argument 0 is checked for us and the remaining arguments must be 8284493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // constant integers. 829fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner for (unsigned i = 1; i != NumArgs; ++i) { 8304493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar Expr *Arg = TheCall->getArg(i); 831691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 8329aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman llvm::APSInt Result; 833691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, i, Result)) 834691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 8351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8364493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // FIXME: gcc issues a warning and rewrites these to 0. These 8374493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // seems especially odd for the third argument since the default 8384493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // is 3. 839fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (i == 1) { 8409aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 1) 841fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 84221fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "1" << Arg->getSourceRange(); 8434493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } else { 8449aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 3) 845fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 84621fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "3" << Arg->getSourceRange(); 8474493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 8484493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 8494493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 850fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return false; 8514493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar} 8524493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 853691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 854691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression. 855691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 856691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt &Result) { 857691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(ArgNum); 858691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 859691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 860691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 861691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 862691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 863691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (!Arg->isIntegerConstantExpr(Result, Context)) 864691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 8655e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher << FDecl->getDeclName() << Arg->getSourceRange(); 866691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 86721fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner return false; 86821fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner} 86921fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner 870d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 871d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined 872d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3). 873fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner// For compatibility check 0-3, llvm only handles 0 and 2. 874d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 875691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 876691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 877691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // Check constant-ness first. 878691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 879691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 880d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 881691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(1); 882d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 883fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 884fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 885d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar } 886d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 887d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar return false; 888d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar} 889d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 890586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 891d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1. 892d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 893d875fed28578835de89cd407e9db4be788596d7cEli Friedman Expr *Arg = TheCall->getArg(1); 894691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 895cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 896691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // TODO: This is less than ideal. Overload this to take a value. 897691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 898691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 899691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 900691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Result != 1) 901d875fed28578835de89cd407e9db4be788596d7cEli Friedman return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 902d875fed28578835de89cd407e9db4be788596d7cEli Friedman << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 903d875fed28578835de89cd407e9db4be788596d7cEli Friedman 904d875fed28578835de89cd407e9db4be788596d7cEli Friedman return false; 905d875fed28578835de89cd407e9db4be788596d7cEli Friedman} 906d875fed28578835de89cd407e9db4be788596d7cEli Friedman 907b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek// Handle i > 1 ? "x" : "y", recursively. 908082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenekbool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall, 909082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool HasVAListArg, 910826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 911826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 9124fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain: 913cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 914cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 915d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 916f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 917f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 918d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek switch (E->getStmtClass()) { 91956ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::BinaryConditionalOperatorClass: 920d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ConditionalOperatorClass: { 92156ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall const AbstractConditionalOperator *C = cast<AbstractConditionalOperator>(E); 922826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return SemaCheckStringLiteral(C->getTrueExpr(), TheCall, HasVAListArg, 923826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf) 92456ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall && SemaCheckStringLiteral(C->getFalseExpr(), TheCall, HasVAListArg, 925826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf); 926d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 927d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 92895355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek case Stmt::IntegerLiteralClass: 92995355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // Technically -Wformat-nonliteral does not warn about this case. 93095355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // The behavior of printf and friends in this case is implementation 93195355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // dependent. Ideally if the format string cannot be null then 93295355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // it should have a 'nonnull' attribute in the function prototype. 93395355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek return true; 93495355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek 935d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ImplicitCastExprClass: { 9364fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ImplicitCastExpr>(E)->getSubExpr(); 9374fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 938d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 939d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 94056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::OpaqueValueExprClass: 94156ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) { 94256ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall E = src; 94356ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall goto tryAgain; 94456ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall } 94556ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall return false; 94656ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall 947b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek case Stmt::PredefinedExprClass: 948b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // While __func__, etc., are technically not string literals, they 949b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // cannot contain format specifiers and thus are not a security 950b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // liability. 951b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek return true; 952b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek 953082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::DeclRefExprClass: { 954082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const DeclRefExpr *DR = cast<DeclRefExpr>(E); 9551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 956082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // As an exception, do not flag errors for variables binding to 957082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // const string literals. 958082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 959082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool isConstant = false; 960082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek QualType T = DR->getType(); 961082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek 962082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ArrayType *AT = Context.getAsArrayType(T)) { 963082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek isConstant = AT->getElementType().isConstant(Context); 964ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (const PointerType *PT = T->getAs<PointerType>()) { 9651eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump isConstant = T.isConstant(Context) && 966082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek PT->getPointeeType().isConstant(Context); 967082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 9681eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 969082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (isConstant) { 97031310a21fb2a9f13950f864f681c86080b05d5b2Sebastian Redl if (const Expr *Init = VD->getAnyInitializer()) 971082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return SemaCheckStringLiteral(Init, TheCall, 972826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, format_idx, firstDataArg, 973826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isPrintf); 974082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 9751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 976d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // For vprintf* functions (i.e., HasVAListArg==true), we add a 977d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // special check to see if the format string is a function parameter 978d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // of the function calling the printf function. If the function 979d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // has an attribute indicating it is a printf-like function, then we 980d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // should suppress warnings concerning non-literals being used in a call 981d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // to a vprintf function. For example: 982d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 983d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // void 984d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 985d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_list ap; 986d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_start(ap, fmt); 987d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 988d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // ... 989d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 990d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 991d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // FIXME: We don't have full attribute support yet, so just check to see 992d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // if the argument is a DeclRefExpr that references a parameter. We'll 993d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // add proper support for checking the attribute later. 994d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (HasVAListArg) 995d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (isa<ParmVarDecl>(VD)) 996d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson return true; 997082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 9981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 999082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1000082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 1001d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 10028f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson case Stmt::CallExprClass: { 10038f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const CallExpr *CE = cast<CallExpr>(E); 10041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump if (const ImplicitCastExpr *ICE 10058f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson = dyn_cast<ImplicitCastExpr>(CE->getCallee())) { 10068f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) { 10078f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) { 100840b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) { 10098f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson unsigned ArgIndex = FA->getFormatIdx(); 10108f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const Expr *Arg = CE->getArg(ArgIndex - 1); 10111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg, 1013826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf); 10148f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 10158f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 10168f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 10178f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 10181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10198f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson return false; 10208f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 1021082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::ObjCStringLiteralClass: 1022082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::StringLiteralClass: { 1023082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const StringLiteral *StrE = NULL; 10241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1025082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 1026d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek StrE = ObjCFExpr->getString(); 1027d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek else 1028082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek StrE = cast<StringLiteral>(E); 10291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1030d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek if (StrE) { 1031826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatString(StrE, E, TheCall, HasVAListArg, format_idx, 1032826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek firstDataArg, isPrintf); 1033d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return true; 1034d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 10351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1036d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return false; 1037d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 10381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1039082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek default: 1040082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1041d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1042d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1043d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1044e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid 10451eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull, 1046909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr * const *ExprArgs, 1047909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky SourceLocation CallSiteLoc) { 1048cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt for (NonNullAttr::args_iterator i = NonNull->args_begin(), 1049cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt e = NonNull->args_end(); 1050e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian i != e; ++i) { 1051909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr *ArgExpr = ExprArgs[*i]; 10524e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (ArgExpr->isNullPointerConstant(Context, 1053ce94049b69f75b44c18584fe79cd238978b6b0d5Douglas Gregor Expr::NPC_ValueDependentIsNotNull)) 1054909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange(); 1055e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian } 1056e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian} 1057d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1058826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar 1059826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings. 106059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnervoid 1061826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSema::CheckPrintfScanfArguments(const CallExpr *TheCall, bool HasVAListArg, 1062826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1063826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 1064826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1065082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *Fn = TheCall->getCallee(); 1066925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner 10674a2614e94672c47395abcde60518776fbebec589Sebastian Redl // The way the format attribute works in GCC, the implicit this argument 10684a2614e94672c47395abcde60518776fbebec589Sebastian Redl // of member functions is counted. However, it doesn't appear in our own 10694a2614e94672c47395abcde60518776fbebec589Sebastian Redl // lists, so decrement format_idx in that case. 10704a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 10719263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth const CXXMethodDecl *method_decl = 10729263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth dyn_cast<CXXMethodDecl>(TheCall->getCalleeDecl()); 10739263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if (method_decl && method_decl->isInstance()) { 10749263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth // Catch a format attribute mistakenly referring to the object argument. 10759263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if (format_idx == 0) 10769263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth return; 10779263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth --format_idx; 10789263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if(firstDataArg != 0) 10799263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth --firstDataArg; 10809263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth } 10814a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 10824a2614e94672c47395abcde60518776fbebec589Sebastian Redl 1083826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // CHECK: printf/scanf-like function is called with no format string. 1084925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (format_idx >= TheCall->getNumArgs()) { 1085826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Diag(TheCall->getRParenLoc(), diag::warn_missing_format_string) 1086dcd5ef12488e4c7ea844327835896ca86b609a97Chris Lattner << Fn->getSourceRange(); 108771895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek return; 108871895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek } 10891eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1090082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts(); 10911eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 109259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner // CHECK: format string is not a string literal. 10931eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // 109471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // Dynamically generated format strings are difficult to 109571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // automatically vet at compile time. Requiring that format strings 109671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // are string literals: (1) permits the checking of format strings by 109771895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // the compiler and thereby (2) can practically remove the source of 109871895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // many format string exploits. 10997ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek 11001eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // Format string can be either ObjC string (e.g. @"%d") or 11017ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // C string (e.g. "%d") 11021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // ObjC string uses the same format specifiers as C string, so we can use 11037ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // the same format string checking logic for both ObjC and C strings. 11041cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx, 1105826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek firstDataArg, isPrintf)) 11061cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner return; // Literal format string found, check done! 11071cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner 1108655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // If there are no arguments specified, warn with -Wformat-security, otherwise 1109655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // warn only with -Wformat-nonliteral. 1110655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner if (TheCall->getNumArgs() == format_idx+1) 11111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1112826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral_noargs) 1113655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1114655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner else 11151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1116826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral) 1117655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1118d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1119d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1120e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace { 1121826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler { 1122826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1123e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Sema &S; 1124e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const StringLiteral *FExpr; 1125e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const Expr *OrigFormatExpr; 11266ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const unsigned FirstDataArg; 1127e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const unsigned NumDataArgs; 1128e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const bool IsObjCLiteral; 1129e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *Beg; // Start of format string. 11300d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const bool HasVAListArg; 11310d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const CallExpr *TheCall; 11320d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek unsigned FormatIdx; 11337f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek llvm::BitVector CoveredArgs; 1134efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool usesPositionalArgs; 1135efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool atFirstArg; 11364e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic: 1137826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 11386ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1139e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 11400d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const char *beg, bool hasVAListArg, 11410d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1142e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 11436ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek FirstDataArg(firstDataArg), 11447f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek NumDataArgs(numDataArgs), 11450d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek IsObjCLiteral(isObjCLiteral), Beg(beg), 11460d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek HasVAListArg(hasVAListArg), 1147efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek TheCall(theCall), FormatIdx(formatIdx), 1148efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek usesPositionalArgs(false), atFirstArg(true) { 11497f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.resize(numDataArgs); 11507f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.reset(); 11517f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 11524e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 115307d161f38e708a91486bf1c031d525faebbb249dTed Kremenek void DoneProcessing(); 11544e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1155826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIncompleteSpecifier(const char *startSpecifier, 1156826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1157826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1158efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleInvalidPosition(const char *startSpecifier, 1159efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned specifierLen, 1160826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p); 1161efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1162efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 1163efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1164e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek void HandleNullChar(const char *nullCharacter); 11654e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1166826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1167c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 1168c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1169c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1170c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, unsigned csLen); 1171c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1172f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek SourceRange getFormatStringRange(); 1173826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CharSourceRange getSpecifierRange(const char *startSpecifier, 1174826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1175e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek SourceLocation getLocationOfByte(const char *x); 11764e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 11770d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const Expr *getDataArg(unsigned i) const; 1178666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1179666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 1180666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1181666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, 1182666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek unsigned argIndex); 1183e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}; 1184e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1185e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1186826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() { 1187e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return OrigFormatExpr->getSourceRange(); 1188e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1189e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1190826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler:: 1191826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 119245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation Start = getLocationOfByte(startSpecifier); 119345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 119445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 119545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care // Advance the end SourceLocation by one due to half-open ranges. 119645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care End = End.getFileLocWithOffset(1); 119745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 119845f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care return CharSourceRange::getCharRange(Start, End); 1199f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek} 1200f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek 1201826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 12024e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 1203e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1204e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1205826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 1206826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen){ 1207808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek SourceLocation Loc = getLocationOfByte(startSpecifier); 1208808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek S.Diag(Loc, diag::warn_printf_incomplete_specifier) 1209826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1210808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek} 1211808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek 1212efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid 1213826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 1214826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p) { 1215efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek SourceLocation Loc = getLocationOfByte(startPos); 1216826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(Loc, diag::warn_format_invalid_positional_specifier) 1217826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << (unsigned) p << getSpecifierRange(startPos, posLen); 1218efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1219efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1220826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos, 1221efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned posLen) { 1222efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek SourceLocation Loc = getLocationOfByte(startPos); 1223826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(Loc, diag::warn_format_zero_positional_specifier) 1224826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startPos, posLen); 1225efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1226efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1227826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 12280c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek if (!IsObjCLiteral) { 12290c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek // The presence of a null character is likely an error. 12300c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek S.Diag(getLocationOfByte(nullCharacter), 12310c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek diag::warn_printf_format_string_contains_null_char) 12320c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek << getFormatStringRange(); 12330c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek } 1234826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1235826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1236826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const { 1237826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return TheCall->getArg(FirstDataArg + i); 1238826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 12394e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1240826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() { 1241826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Does the number of data arguments exceed the number of 1242826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // format conversions in the format string? 1243826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!HasVAListArg) { 1244826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Find any arguments that weren't covered. 1245826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.flip(); 1246826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek signed notCoveredArg = CoveredArgs.find_first(); 1247826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (notCoveredArg >= 0) { 1248826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek assert((unsigned)notCoveredArg < NumDataArgs); 1249826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(), 1250826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_printf_data_arg_not_used) 1251826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getFormatStringRange(); 1252826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1253826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1254826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1255826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1256c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool 1257c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 1258c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek SourceLocation Loc, 1259c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1260c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1261c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, 1262c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned csLen) { 1263c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1264c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool keepGoing = true; 1265c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek if (argIndex < NumDataArgs) { 1266c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // Consider the argument coverered, even though the specifier doesn't 1267c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // make sense. 1268c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CoveredArgs.set(argIndex); 1269c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1270c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek else { 1271c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // If argIndex exceeds the number of data arguments we 1272c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // don't issue a warning because that is just a cascade of warnings (and 1273c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // they may have intended '%%' anyway). We don't want to continue processing 1274c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // the format string after this point, however, as we will like just get 1275c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // gibberish when trying to match arguments. 1276c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek keepGoing = false; 1277c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1278c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1279c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek S.Diag(Loc, diag::warn_format_invalid_conversion) 1280c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek << llvm::StringRef(csStart, csLen) 1281c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek << getSpecifierRange(startSpec, specifierLen); 1282c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1283c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return keepGoing; 1284c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1285c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1286666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool 1287666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs( 1288666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::FormatSpecifier &FS, 1289666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1290666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 1291666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1292666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (argIndex >= NumDataArgs) { 1293666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (FS.usesPositionalArg()) { 1294666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1295666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek diag::warn_printf_positional_arg_exceeds_data_args) 1296666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << (argIndex+1) << NumDataArgs 1297666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1298666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1299666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek else { 1300666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1301666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek diag::warn_printf_insufficient_data_args) 1302666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1303666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1304666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1305666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return false; 1306666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1307666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return true; 1308666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek} 1309666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1310826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===// 1311826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1312826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 1313826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler { 1314826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 1315826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 1316826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1317826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 1318826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 1319826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1320826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1321826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 1322826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek theCall, formatIdx) {} 1323826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1324826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1325826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleInvalidPrintfConversionSpecifier( 1326826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1327826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1328826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1329826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1330826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 1331826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1332826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1333826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1334826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 1335826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1336826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 1337826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalAmount &Amt, 1338826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned type, 1339826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1340826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1341826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1342826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1343826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 1344826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &ignoredFlag, 1345826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1346826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1347826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 1348826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1349826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1350826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 1351826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1352826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1353826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 13546ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 1355c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 1356826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1357c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1358c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 1359c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 1360c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 136126ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek} 136226ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek 1363826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount( 1364826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_format_string::OptionalAmount &Amt, 1365826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned k, const char *startSpecifier, 1366826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 13670d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 13680d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (Amt.hasDataArgument()) { 13690d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (!HasVAListArg) { 13707f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = Amt.getArgIndex(); 13717f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (argIndex >= NumDataArgs) { 1372efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1373efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek diag::warn_printf_asterisk_missing_arg) 1374826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << k << getSpecifierRange(startSpecifier, specifierLen); 13750d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 13760d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 13770d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 13780d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 13794e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 13800d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Type check the data argument. It should be an 'int'. 138131f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // Although not in conformance with C99, we also allow the argument to be 138231f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // an 'unsigned int' as that is a reasonably safe case. GCC also 138331f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // doesn't emit a warning for that case. 13847f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.set(argIndex); 13857f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek const Expr *Arg = getDataArg(argIndex); 13860d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek QualType T = Arg->getType(); 13874e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 13884e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context); 13894e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek assert(ATR.isValid()); 13904e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 13914e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (!ATR.matchesType(S.Context, T)) { 1392efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1393efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek diag::warn_printf_asterisk_wrong_type) 1394efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek << k 13954e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek << ATR.getRepresentativeType(S.Context) << T 1396826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1397d635c5fcc45c952b75743dd2f4c86d6950e4954eTed Kremenek << Arg->getSourceRange(); 13980d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 13990d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 14000d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 14010d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 14020d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 14030d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 14040d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return true; 14050d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek} 14060d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1407e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount( 1408826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1409e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalAmount &Amt, 1410e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned type, 1411e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1412e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 14136ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 14146ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1415e4ee9663168dfb2b4122c768091e30217328c9faTom Care switch (Amt.getHowSpecified()) { 1416e4ee9663168dfb2b4122c768091e30217328c9faTom Care case analyze_printf::OptionalAmount::Constant: 1417e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(Amt.getStart()), 1418e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_optional_amount) 1419e4ee9663168dfb2b4122c768091e30217328c9faTom Care << type 1420e4ee9663168dfb2b4122c768091e30217328c9faTom Care << CS.toString() 1421826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1422826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 1423e4ee9663168dfb2b4122c768091e30217328c9faTom Care Amt.getConstantLength())); 1424e4ee9663168dfb2b4122c768091e30217328c9faTom Care break; 1425e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1426e4ee9663168dfb2b4122c768091e30217328c9faTom Care default: 1427e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(Amt.getStart()), 1428e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_optional_amount) 1429e4ee9663168dfb2b4122c768091e30217328c9faTom Care << type 1430e4ee9663168dfb2b4122c768091e30217328c9faTom Care << CS.toString() 1431826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1432e4ee9663168dfb2b4122c768091e30217328c9faTom Care break; 1433e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1434e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1435e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1436826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1437e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 1438e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1439e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 1440e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about pointless flag with a fixit removal. 14416ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 14426ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1443e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(flag.getPosition()), 1444e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_flag) 1445e4ee9663168dfb2b4122c768091e30217328c9faTom Care << flag.toString() << CS.toString() 1446826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1447826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(flag.getPosition(), 1)); 1448e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1449e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1450e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag( 1451826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1452e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &ignoredFlag, 1453e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 1454e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1455e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 1456e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about ignored flag with a fixit removal. 1457e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(ignoredFlag.getPosition()), 1458e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_ignored_flag) 1459e4ee9663168dfb2b4122c768091e30217328c9faTom Care << ignoredFlag.toString() << flag.toString() 1460826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1461826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange( 1462e4ee9663168dfb2b4122c768091e30217328c9faTom Care ignoredFlag.getPosition(), 1)); 1463e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1464e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1465e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool 1466826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 14675c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek &FS, 1468e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *startSpecifier, 1469e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned specifierLen) { 1470e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 14716ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek using namespace analyze_format_string; 1472efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek using namespace analyze_printf; 14736ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 1474e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1475baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 1476baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 1477baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 1478baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 1479baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1480baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 1481baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Cannot mix-and-match positional and non-positional arguments. 1482baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1483baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek diag::warn_format_mix_positional_nonpositional_args) 1484baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1485baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 1486baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1487efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek } 1488efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 14890d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // First check if the field width, precision, and conversion specifier 14900d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // have matching data arguments. 1491efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 1492efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 14930d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 14940d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 14954e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1496efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 1497efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 14980d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 14990d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 15000d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1501f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek if (!CS.consumesDataArgument()) { 1502f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // FIXME: Technically specifying a precision or field width here 1503f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // makes no sense. Worth issuing a warning at some point. 15040e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek return true; 1505f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek } 15064e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 15077f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Consume the argument. 15087f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = FS.getArgIndex(); 1509e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek if (argIndex < NumDataArgs) { 1510e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // The check to see if the argIndex is valid will come later. 1511e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // We set the bit here because we may exit early from this 1512e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // function if we encounter some other error. 1513e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek CoveredArgs.set(argIndex); 1514e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek } 15157f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek 15167f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Check for using an Objective-C specific conversion specifier 15177f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // in a non-ObjC literal. 15187f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (!IsObjCLiteral && CS.isObjCArg()) { 1519826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 1520826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek specifierLen); 15217f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 15224e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1523e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of field width 1524e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidFieldWidth()) { 152545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 1526e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1527e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1528e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1529e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of precision 1530e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPrecision()) { 1531e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 1532e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1533e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1534e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1535e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check each flag does not conflict with any other component. 153665197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek if (!FS.hasValidThousandsGroupingPrefix()) 153765197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen); 1538e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeadingZeros()) 1539e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 1540e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPlusPrefix()) 1541e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 154245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (!FS.hasValidSpacePrefix()) 154345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 1544e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidAlternativeForm()) 1545e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 1546e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeftJustified()) 1547e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 1548e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1549e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check that flags are not ignored by another flag 155045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 155145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 155245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care startSpecifier, specifierLen); 1553e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 1554e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 1555e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1556e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1557e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check the length modifier is valid with the given conversion specifier. 1558e4ee9663168dfb2b4122c768091e30217328c9faTom Care const LengthModifier &LM = FS.getLengthModifier(); 1559e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLengthModifier()) 1560e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(LM.getStart()), 1561649aecf55670682efb2a04a85810eef4d038c527Ted Kremenek diag::warn_format_nonsensical_length) 1562e4ee9663168dfb2b4122c768091e30217328c9faTom Care << LM.toString() << CS.toString() 1563826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1564826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 1565e4ee9663168dfb2b4122c768091e30217328c9faTom Care LM.getLength())); 1566e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1567e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Are we using '%n'? 156835d353b47bce29200b910371dd9b8ba7f3058ab8Ted Kremenek if (CS.getKind() == ConversionSpecifier::nArg) { 1569e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Issue a warning about this being a possible security issue. 1570e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back) 1571826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1572e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek // Continue checking the other format specifiers. 1573e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek return true; 1574e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek } 15755c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek 1576da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek // The remaining checks depend on the data arguments. 1577da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek if (HasVAListArg) 1578da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return true; 15794e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1580666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 1581da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return false; 15824e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 158396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Now type check the data expression that matches the 158496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // format specifier. 158596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const Expr *Ex = getDataArg(argIndex); 158696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context); 158796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) { 158896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Check if we didn't match because of an implicit cast from a 'char' 158996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // or 'short' to an 'int'. This is done because printf is a varargs 159096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // function. 159196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex)) 15924d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ICE->getType() == S.Context.IntTy) { 15934d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek // All further checking is done on the subexpression. 15944d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek Ex = ICE->getSubExpr(); 15954d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ATR.matchesType(S.Context, Ex->getType())) 159696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer return true; 15974d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek } 159896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 159996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // We may be able to offer a FixItHint if it is a supported type. 160096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer PrintfSpecifier fixedFS = FS; 160196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer bool success = fixedFS.fixType(Ex->getType()); 160296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 160396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (success) { 160496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Get the fix string from the fixed format specifier 160596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::SmallString<128> buf; 160696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::raw_svector_ostream os(buf); 160796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer fixedFS.toString(os); 160896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 16099325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // FIXME: getRepresentativeType() perhaps should return a string 16109325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // instead of a QualType to better handle when the representative 16119325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // type is 'wint_t' (which is defined in the system headers). 161296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer S.Diag(getLocationOfByte(CS.getStart()), 161396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer diag::warn_printf_conversion_argument_type_mismatch) 161496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << ATR.getRepresentativeType(S.Context) << Ex->getType() 161596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << getSpecifierRange(startSpecifier, specifierLen) 161696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << Ex->getSourceRange() 161796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << FixItHint::CreateReplacement( 161896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer getSpecifierRange(startSpecifier, specifierLen), 161996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer os.str()); 162096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 162196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer else { 162296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer S.Diag(getLocationOfByte(CS.getStart()), 162396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer diag::warn_printf_conversion_argument_type_mismatch) 162496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << ATR.getRepresentativeType(S.Context) << Ex->getType() 162596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << getSpecifierRange(startSpecifier, specifierLen) 162696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << Ex->getSourceRange(); 162796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 162896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 162996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 1630e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return true; 1631e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1632e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1633826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===// 1634826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1635826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 1636826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler { 1637826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 1638826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 1639826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1640826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 1641826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 1642826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1643826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1644826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 1645826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek theCall, formatIdx) {} 1646826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1647826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 1648826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1649826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1650c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1651c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidScanfConversionSpecifier( 1652c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1653c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 1654c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen); 1655b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 1656b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek void HandleIncompleteScanList(const char *start, const char *end); 1657826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 1658826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1659826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1660b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start, 1661b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek const char *end) { 1662b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek S.Diag(getLocationOfByte(end), diag::warn_scanf_scanlist_incomplete) 1663b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek << getSpecifierRange(start, end - start); 1664b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek} 1665b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 1666c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 1667c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1668c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 1669c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen) { 1670c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 16716ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_scanf::ScanfConversionSpecifier &CS = 1672c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 1673c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1674c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1675c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 1676c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 1677c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 1678c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1679c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1680826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier( 1681826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1682826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1683826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 1684826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1685826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_scanf; 1686826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_format_string; 1687826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 16886ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 1689826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1690baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Handle case where '%' and '*' don't consume an argument. These shouldn't 1691baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // be used to decide if we are using positional arguments consistently. 1692baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 1693baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 1694baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 1695baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 1696baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1697baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 1698baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Cannot mix-and-match positional and non-positional arguments. 1699baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1700baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek diag::warn_format_mix_positional_nonpositional_args) 1701baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1702baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 1703baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1704826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1705826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1706826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Check if the field with is non-zero. 1707826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const OptionalAmount &Amt = FS.getFieldWidth(); 1708826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getHowSpecified() == OptionalAmount::Constant) { 1709826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getConstantAmount() == 0) { 1710826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 1711826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Amt.getConstantLength()); 1712826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1713826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_scanf_nonzero_width) 1714826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << R << FixItHint::CreateRemoval(R); 17157f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 17167f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 1717826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1718826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!FS.consumesDataArgument()) { 1719826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Technically specifying a precision or field width here 1720826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // makes no sense. Worth issuing a warning at some point. 1721826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 1722826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1723826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1724826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Consume the argument. 1725826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned argIndex = FS.getArgIndex(); 1726826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (argIndex < NumDataArgs) { 1727826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The check to see if the argIndex is valid will come later. 1728826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // We set the bit here because we may exit early from this 1729826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // function if we encounter some other error. 1730826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.set(argIndex); 1731826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1732826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 17331e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek // Check the length modifier is valid with the given conversion specifier. 17341e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek const LengthModifier &LM = FS.getLengthModifier(); 17351e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek if (!FS.hasValidLengthModifier()) { 17361e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek S.Diag(getLocationOfByte(LM.getStart()), 17371e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek diag::warn_format_nonsensical_length) 17381e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << LM.toString() << CS.toString() 17391e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 17401e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 17411e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek LM.getLength())); 17421e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek } 17431e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek 1744826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The remaining checks depend on the data arguments. 1745826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (HasVAListArg) 1746826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 1747826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1748666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 1749826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return false; 1750826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1751826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Check that the argument type matches the format specifier. 1752826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1753826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 175407d161f38e708a91486bf1c031d525faebbb249dTed Kremenek} 1755e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1756826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr, 17570e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const Expr *OrigFormatExpr, 17580e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const CallExpr *TheCall, bool HasVAListArg, 1759826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1760826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 1761826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1762e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: is the format string a wide literal? 1763e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek if (FExpr->isWide()) { 1764e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Diag(FExpr->getLocStart(), 1765826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_string_is_wide_literal) 1766e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek << OrigFormatExpr->getSourceRange(); 1767e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 1768e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 1769826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1770e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // Str - The format string. NOTE: this is NOT null-terminated! 17712f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer llvm::StringRef StrRef = FExpr->getString(); 17722f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer const char *Str = StrRef.data(); 17732f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer unsigned StrLen = StrRef.size(); 1774826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1775e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: empty format string? 1776e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek if (StrLen == 0) { 1777826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Diag(FExpr->getLocStart(), diag::warn_empty_format_string) 1778e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek << OrigFormatExpr->getSourceRange(); 1779e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 1780e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 1781826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1782826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (isPrintf) { 1783826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 1784826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek TheCall->getNumArgs() - firstDataArg, 1785826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isa<ObjCStringLiteral>(OrigFormatExpr), Str, 1786826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, TheCall, format_idx); 1787826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1788826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen)) 1789826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 1790826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1791826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek else { 1792826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 1793826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek TheCall->getNumArgs() - firstDataArg, 1794826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isa<ObjCStringLiteral>(OrigFormatExpr), Str, 1795826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, TheCall, format_idx); 1796826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1797826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen)) 1798826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 1799826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1800ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek} 1801ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek 18027ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth//===--- CHECK: Standard memory functions ---------------------------------===// 18037ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 18042a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// \brief Determine whether the given type is a dynamic class type (e.g., 18052a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// whether it has a vtable). 18062a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregorstatic bool isDynamicClassType(QualType T) { 18072a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Record = T->getAsCXXRecordDecl()) 18082a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Definition = Record->getDefinition()) 18092a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (Definition->isDynamicClass()) 18102a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return true; 18112a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 18122a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return false; 18132a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor} 18142a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 18157ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \brief Check for dangerous or invalid arguments to memset(). 18167ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 18177ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// This issues warnings on known problematic or dangerous or unspecified 181806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor/// arguments to the standard 'memset', 'memcpy', and 'memmove' function calls. 18197ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 18207ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \param Call The call expression to diagnose. 182106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregorvoid Sema::CheckMemsetcpymoveArguments(const CallExpr *Call, 182206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor const IdentifierInfo *FnName) { 18231d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek // It is possible to have a non-standard definition of memset. Validate 18241d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek // we have the proper number of arguments, and if not, abort further 18251d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek // checking. 18261d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek if (Call->getNumArgs() != 3) 18271d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek return; 18281d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek 182906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor unsigned LastArg = FnName->isStr("memset")? 1 : 2; 183006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) { 183106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts(); 183206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 183306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType DestTy = Dest->getType(); 183406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) { 183506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType PointeeTy = DestPtrTy->getPointeeType(); 183606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor if (PointeeTy->isVoidType()) 183706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 183806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 183906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor unsigned DiagID = 0; 184006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor // Always complain about dynamic classes. 184106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor if (isDynamicClassType(PointeeTy)) 184206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor DiagID = diag::warn_dyn_class_memaccess; 184306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor // Check the C++11 POD definition regardless of language mode; it is more 184406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor // relaxed than earlier definitions and we don't want spurious warnings. 184506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor else if (!PointeeTy->isCXX11PODType()) 184606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor DiagID = diag::warn_non_pod_memaccess; 184706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor else 184806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 184906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 185006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor DiagRuntimeBehavior( 185106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor Dest->getExprLoc(), Dest, 185206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor PDiag(DiagID) 185306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor << ArgIdx << FnName << PointeeTy 185406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor << Call->getCallee()->getSourceRange()); 185506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 185606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor SourceRange ArgRange = Call->getArg(0)->getSourceRange(); 185706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor DiagRuntimeBehavior( 185806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor Dest->getExprLoc(), Dest, 185906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor PDiag(diag::note_non_pod_memaccess_silence) 186006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)")); 186106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor break; 186206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 18637ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth } 18647ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth} 18657ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 186606de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===// 186706de276fff91264437fa75111ed76de43097e089Ted Kremenek 186826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, llvm::SmallVectorImpl<DeclRefExpr *> &refVars); 186926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidisstatic Expr *EvalAddr(Expr* E, llvm::SmallVectorImpl<DeclRefExpr *> &refVars); 187006de276fff91264437fa75111ed76de43097e089Ted Kremenek 187106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address 187206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable. 187306de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid 187406de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 187506de276fff91264437fa75111ed76de43097e089Ted Kremenek SourceLocation ReturnLoc) { 18761eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 187726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Expr *stackE = 0; 187826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis llvm::SmallVector<DeclRefExpr *, 8> refVars; 18794e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 188026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Perform checking for returned stack addresses, local blocks, 188126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // label addresses or references to temporaries. 188226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (lhsType->isPointerType() || lhsType->isBlockPointerType()) { 188326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalAddr(RetValExp, refVars); 1884ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (lhsType->isReferenceType()) { 188526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalVal(RetValExp, refVars); 188626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 188726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 188826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (stackE == 0) 188926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return; // Nothing suspicious was found. 189026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 189126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceLocation diagLoc; 189226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange diagRange; 189326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (refVars.empty()) { 189426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = stackE->getLocStart(); 189526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = stackE->getSourceRange(); 189626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { 189726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // We followed through a reference variable. 'stackE' contains the 189826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // problematic expression but we will warn at the return statement pointing 189926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // at the reference variable. We will later display the "trail" of 190026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // reference variables using notes. 190126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = refVars[0]->getLocStart(); 190226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = refVars[0]->getSourceRange(); 190326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 190426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 190526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var. 190626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref 190726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_stack_addr) 190826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << DR->getDecl()->getDeclName() << diagRange; 190926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<BlockExpr>(stackE)) { // local block. 191026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::err_ret_local_block) << diagRange; 191126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 191226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 191326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { // local temporary. 191426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref 191526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_local_temp_addr) 191626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << diagRange; 191726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 191826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 191926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Display the "trail" of reference variables that we followed until we 192026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // found the problematic expression using notes. 192126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 192226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 192326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this var binds to another reference var, show the range of the next 192426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // var, otherwise the var binds to the problematic expression, in which case 192526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // show the range of the expression. 192626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange() 192726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : stackE->getSourceRange(); 192826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(VD->getLocation(), diag::note_ref_var_local_bind) 192926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << VD->getDeclName() << range; 193006de276fff91264437fa75111ed76de43097e089Ted Kremenek } 193106de276fff91264437fa75111ed76de43097e089Ted Kremenek} 193206de276fff91264437fa75111ed76de43097e089Ted Kremenek 193306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 193406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// check if the expression in a return statement evaluates to an address 193526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// to a location on the stack, a local block, an address of a label, or a 193626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// reference to local temporary. The recursion is used to traverse the 193706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// AST of the return expression, with recursion backtracking when we 193826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// encounter a subexpression that (1) clearly does not lead to one of the 193926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// above problematic expressions (2) is something we cannot determine leads to 194026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// a problematic expression based on such local checking. 194126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 194226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// Both EvalAddr and EvalVal follow through reference variables to evaluate 194326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// the expression that they point to. Such variables are added to the 194426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 'refVars' vector so that we know what the reference variable "trail" was. 194506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 1946e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// EvalAddr processes expressions that are pointers that are used as 1947e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// references (and not L-values). EvalVal handles all other values. 194826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// At the base case of the recursion is a check for the above problematic 194926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// expressions. 195006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 195106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// This implementation handles: 195206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 195306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer-to-pointer casts 195406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * implicit conversions from array references to pointers 195506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of fields 195606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * arbitrary interplay between "&" and "*" operators 195706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer arithmetic from an address of a stack variable 195806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of an array element where the array is on the stack 195926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidisstatic Expr *EvalAddr(Expr *E, llvm::SmallVectorImpl<DeclRefExpr *> &refVars) { 196026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (E->isTypeDependent()) 196126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 196226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 196306de276fff91264437fa75111ed76de43097e089Ted Kremenek // We should only be called for evaluating pointer expressions. 19640f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall assert((E->getType()->isAnyPointerType() || 1965dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff E->getType()->isBlockPointerType() || 1966a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek E->getType()->isObjCQualifiedIdType()) && 1967fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner "EvalAddr only works on pointers"); 19681eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1969f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 1970f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 197106de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 197206de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 197306de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 197406de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 197526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::DeclRefExprClass: { 197626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis DeclRefExpr *DR = cast<DeclRefExpr>(E); 197726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 197826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 197926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this is a reference variable, follow through to the expression that 198026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 198126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage() && 198226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis V->getType()->isReferenceType() && V->hasInit()) { 198326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 198426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 198526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(V->getInit(), refVars); 198626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 198726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 198826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 198926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 199006de276fff91264437fa75111ed76de43097e089Ted Kremenek 1991fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::UnaryOperatorClass: { 1992fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // The only unary operator that make sense to handle here 1993fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // is AddrOf. All others don't make sense as pointers. 1994fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner UnaryOperator *U = cast<UnaryOperator>(E); 19951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 19962de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_AddrOf) 199726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(U->getSubExpr(), refVars); 1998fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 1999fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 2000fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 20011eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2002fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::BinaryOperatorClass: { 2003fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle pointer arithmetic. All other binary operators are not valid 2004fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // in this context. 2005fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner BinaryOperator *B = cast<BinaryOperator>(E); 20062de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = B->getOpcode(); 20071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 20082de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op != BO_Add && op != BO_Sub) 2009fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 20101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2011fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner Expr *Base = B->getLHS(); 20123907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 2013fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Determine which argument is the real pointer base. It could be 2014fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // the RHS argument instead of the LHS. 2015fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner if (!Base->getType()->isPointerType()) Base = B->getRHS(); 20161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2017fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner assert (Base->getType()->isPointerType()); 201826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(Base, refVars); 2019fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 202061f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff 2021fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // For conditional operators we need to see if either the LHS or RHS are 2022fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // valid DeclRefExpr*s. If one of them is valid, we return it. 2023fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ConditionalOperatorClass: { 2024fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner ConditionalOperator *C = cast<ConditionalOperator>(E); 20251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2026fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle the GNU extension for missing LHS. 20279ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (Expr *lhsExpr = C->getLHS()) { 20289ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 20299ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (!lhsExpr->getType()->isVoidType()) 203026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr* LHS = EvalAddr(lhsExpr, refVars)) 20319ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return LHS; 20329ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor } 20339ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor 20349ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 20359ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (C->getRHS()->getType()->isVoidType()) 20369ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return NULL; 203706de276fff91264437fa75111ed76de43097e089Ted Kremenek 203826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(C->getRHS(), refVars); 2039fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 204026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 204126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::BlockExprClass: 2042469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures()) 204326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // local block. 204426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 204526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 204626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::AddrLabelExprClass: 204726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // address of label. 20481eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 204954b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // For casts, we need to handle conversions from arrays to 205054b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // pointer values, and pointer-to-pointer conversions. 205149badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::ImplicitCastExprClass: 20526eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor case Stmt::CStyleCastExprClass: 205349badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXFunctionalCastExprClass: { 20540835a3cdeefe714b4959d31127ea155e56393125Argyrios Kyrtzidis Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 205554b5274f2c190331438375ad114dad12ae098b57Ted Kremenek QualType T = SubExpr->getType(); 20561eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2057dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (SubExpr->getType()->isPointerType() || 2058dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isBlockPointerType() || 2059dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isObjCQualifiedIdType()) 206026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(SubExpr, refVars); 206154b5274f2c190331438375ad114dad12ae098b57Ted Kremenek else if (T->isArrayType()) 206226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(SubExpr, refVars); 2063fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 206454b5274f2c190331438375ad114dad12ae098b57Ted Kremenek return 0; 2065fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 20661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2067fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // C++ casts. For dynamic casts, static casts, and const casts, we 2068fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // are always converting from a pointer-to-pointer, so we just blow 206949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // through the cast. In the case the dynamic cast doesn't fail (and 207049badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // return NULL), we take the conservative route and report cases 2071fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // where we return the address of a stack variable. For Reinterpre 207249badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // FIXME: The comment about is wrong; we're not always converting 207349badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // from pointer to pointer. I'm guessing that this code should also 20741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // handle references to objects. 20751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXStaticCastExprClass: 20761eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXDynamicCastExprClass: 207749badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXConstCastExprClass: 207849badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXReinterpretCastExprClass: { 207949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr(); 2080dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (S->getType()->isPointerType() || S->getType()->isBlockPointerType()) 208126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(S, refVars); 208206de276fff91264437fa75111ed76de43097e089Ted Kremenek else 208306de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 2084fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 20851eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2086fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Everything else: we simply don't reason about them. 2087fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner default: 2088fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 208906de276fff91264437fa75111ed76de43097e089Ted Kremenek } 209006de276fff91264437fa75111ed76de43097e089Ted Kremenek} 20911eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 209206de276fff91264437fa75111ed76de43097e089Ted Kremenek 209306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalVal - This function is complements EvalAddr in the mutual recursion. 209406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// See the comments for EvalAddr for more details. 209526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, llvm::SmallVectorImpl<DeclRefExpr *> &refVars) { 209668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo { 2097e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // We should only be called for evaluating non-pointer expressions, or 2098e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // expressions with a pointer type that are not used as references but instead 2099e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // are l-values (e.g., DeclRefExpr with a pointer type). 21001eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 210106de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 210206de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 210306de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 2104f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 2105f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 210606de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 210768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ImplicitCastExprClass: { 210868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 21095baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall if (IE->getValueKind() == VK_LValue) { 211068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = IE->getSubExpr(); 211168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 211268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 211368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek return NULL; 211468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 211568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek 2116a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor case Stmt::DeclRefExprClass: { 211726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // When we hit a DeclRefExpr we are looking at code that refers to a 211826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // variable's name. If it's not a reference variable we check if it has 211926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // local storage within the function, and if so, return the expression. 212006de276fff91264437fa75111ed76de43097e089Ted Kremenek DeclRefExpr *DR = cast<DeclRefExpr>(E); 21211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 212206de276fff91264437fa75111ed76de43097e089Ted Kremenek if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 212326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage()) { 212426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!V->getType()->isReferenceType()) 212526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return DR; 212626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 212726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Reference variable, follow through to the expression that 212826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 212926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasInit()) { 213026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 213126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 213226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(V->getInit(), refVars); 213326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 213426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 21351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 213606de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 213706de276fff91264437fa75111ed76de43097e089Ted Kremenek } 21381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 213906de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::UnaryOperatorClass: { 214006de276fff91264437fa75111ed76de43097e089Ted Kremenek // The only unary operator that make sense to handle here 214106de276fff91264437fa75111ed76de43097e089Ted Kremenek // is Deref. All others don't resolve to a "name." This includes 214206de276fff91264437fa75111ed76de43097e089Ted Kremenek // handling all sorts of rvalues passed to a unary operator. 214306de276fff91264437fa75111ed76de43097e089Ted Kremenek UnaryOperator *U = cast<UnaryOperator>(E); 21441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 21452de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_Deref) 214626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(U->getSubExpr(), refVars); 214706de276fff91264437fa75111ed76de43097e089Ted Kremenek 214806de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 214906de276fff91264437fa75111ed76de43097e089Ted Kremenek } 21501eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 215106de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ArraySubscriptExprClass: { 215206de276fff91264437fa75111ed76de43097e089Ted Kremenek // Array subscripts are potential references to data on the stack. We 215306de276fff91264437fa75111ed76de43097e089Ted Kremenek // retrieve the DeclRefExpr* for the array variable if it indeed 215406de276fff91264437fa75111ed76de43097e089Ted Kremenek // has local storage. 215526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars); 215606de276fff91264437fa75111ed76de43097e089Ted Kremenek } 21571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 215806de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ConditionalOperatorClass: { 215906de276fff91264437fa75111ed76de43097e089Ted Kremenek // For conditional operators we need to see if either the LHS or RHS are 216026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // non-NULL Expr's. If one is non-NULL, we return it. 216106de276fff91264437fa75111ed76de43097e089Ted Kremenek ConditionalOperator *C = cast<ConditionalOperator>(E); 216206de276fff91264437fa75111ed76de43097e089Ted Kremenek 21633907323dd6665c0c4e383435cb145233f4533406Anders Carlsson // Handle the GNU extension for missing LHS. 21643907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (Expr *lhsExpr = C->getLHS()) 216526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr *LHS = EvalVal(lhsExpr, refVars)) 21663907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return LHS; 21673907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 216826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(C->getRHS(), refVars); 216906de276fff91264437fa75111ed76de43097e089Ted Kremenek } 21701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 217106de276fff91264437fa75111ed76de43097e089Ted Kremenek // Accesses to members are potential references to data on the stack. 217283f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor case Stmt::MemberExprClass: { 217306de276fff91264437fa75111ed76de43097e089Ted Kremenek MemberExpr *M = cast<MemberExpr>(E); 21741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 217506de276fff91264437fa75111ed76de43097e089Ted Kremenek // Check for indirect access. We only want direct field accesses. 2176a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->isArrow()) 2177a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return NULL; 2178a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 2179a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // Check whether the member type is itself a reference, in which case 2180a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // we're not going to refer to the member, but to what the member refers to. 2181a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->getMemberDecl()->getType()->isReferenceType()) 218206de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 2183a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 218426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(M->getBase(), refVars); 218506de276fff91264437fa75111ed76de43097e089Ted Kremenek } 21861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 218706de276fff91264437fa75111ed76de43097e089Ted Kremenek default: 218826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Check that we don't return or take the address of a reference to a 218926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // temporary. This is only useful in C++. 219026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!E->isTypeDependent() && E->isRValue()) 219126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; 219226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 219326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Everything else: we simply don't reason about them. 219406de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 219506de276fff91264437fa75111ed76de43097e089Ted Kremenek } 219668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true); 219706de276fff91264437fa75111ed76de43097e089Ted Kremenek} 2198588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2199588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 2200588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2201588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==. 2202588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely 2203588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended. 2204588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenekvoid Sema::CheckFloatComparison(SourceLocation loc, Expr* lex, Expr *rex) { 2205588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek bool EmitWarning = true; 22061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2207f6a1648197562e0b133440d612d9af297d0a86ccJohn McCall Expr* LeftExprSansParen = lex->IgnoreParenImpCasts(); 2208f6a1648197562e0b133440d612d9af297d0a86ccJohn McCall Expr* RightExprSansParen = rex->IgnoreParenImpCasts(); 2209588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2210588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Special case: check for x == x (which is OK). 2211588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Do not emit warnings for such cases. 2212588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 2213588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 2214588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DRL->getDecl() == DRR->getDecl()) 2215588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 22161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 22171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 22181b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // Special case: check for comparisons against literals that can be exactly 22191b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // represented by APFloat. In such cases, do not emit a warning. This 22201b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // is a heuristic: often comparison against such literals are used to 22211b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // detect if a value in a variable has not changed. This clearly can 22221b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // lead to false negatives. 22231b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (EmitWarning) { 22241b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 22251b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLL->isExact()) 22261b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 2227ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else 22281b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){ 22291b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLR->isExact()) 22301b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 22311b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 22321b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 22331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2234588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Check for comparisons with builtin types. 22350eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 2236588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 22373c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor if (CL->isBuiltinCall(Context)) 2238588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 22391eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 22400eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 2241588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 22423c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor if (CR->isBuiltinCall(Context)) 2243588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 22441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2245588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Emit the diagnostic. 2246588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (EmitWarning) 2247fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(loc, diag::warn_floatingpoint_eq) 2248fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << lex->getSourceRange() << rex->getSourceRange(); 2249588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek} 2250ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2251f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 2252f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 2253ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2254f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace { 2255ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2256f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued 2257f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression. 2258f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange { 2259f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// The number of bits active in the int. 2260f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned Width; 2261ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2262f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// True if the int is known not to have negative values. 2263f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool NonNegative; 226451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2265f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange(unsigned Width, bool NonNegative) 2266f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : Width(Width), NonNegative(NonNegative) 2267f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall {} 226851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 22691844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of the bool type. 2270f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall static IntRange forBoolType() { 2271f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(1, true); 2272f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 227351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 22741844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of the given integral type. 22751844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfType(ASTContext &C, QualType T) { 22761844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return forValueOfCanonicalType(C, 22771844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T->getCanonicalTypeInternal().getTypePtr()); 227851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 227951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 22801844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of a canonical integral type. 22811844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 2282f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(T->isCanonicalUnqualified()); 228351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2284f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 2285f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = VT->getElementType().getTypePtr(); 2286f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 2287f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = CT->getElementType().getTypePtr(); 2288323ed74658bc8375278eabf074b4777458376540John McCall 2289091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // For enum types, use the known bit width of the enumerators. 2290323ed74658bc8375278eabf074b4777458376540John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) { 2291323ed74658bc8375278eabf074b4777458376540John McCall EnumDecl *Enum = ET->getDecl(); 2292091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Enum->isDefinition()) 2293091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return IntRange(C.getIntWidth(QualType(T, 0)), false); 2294091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2295323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumPositive = Enum->getNumPositiveBits(); 2296323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumNegative = Enum->getNumNegativeBits(); 2297323ed74658bc8375278eabf074b4777458376540John McCall 2298323ed74658bc8375278eabf074b4777458376540John McCall return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0); 2299323ed74658bc8375278eabf074b4777458376540John McCall } 230051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2301f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const BuiltinType *BT = cast<BuiltinType>(T); 2302f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(BT->isInteger()); 230351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2304f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 230551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 230651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 23071844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the "target" range of a canonical integral type, i.e. 23081844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// the range of values expressible in the type. 23091844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// 23101844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// This matches forValueOfCanonicalType except that enums have the 23111844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// full range of their type, not the range of their enumerators. 23121844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 23131844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(T->isCanonicalUnqualified()); 23141844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 23151844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 23161844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = VT->getElementType().getTypePtr(); 23171844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 23181844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = CT->getElementType().getTypePtr(); 23191844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) 23201844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = ET->getDecl()->getIntegerType().getTypePtr(); 23211844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 23221844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall const BuiltinType *BT = cast<BuiltinType>(T); 23231844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(BT->isInteger()); 23241844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 23251844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 23261844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall } 23271844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 23281844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the supremum of two ranges: i.e. their conservative merge. 2329c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange join(IntRange L, IntRange R) { 2330f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(std::max(L.Width, R.Width), 233160fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative && R.NonNegative); 233260fad45739b764886f707bd204eae9ecce6db1f2John McCall } 233360fad45739b764886f707bd204eae9ecce6db1f2John McCall 23341844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the infinum of two ranges: i.e. their aggressive merge. 2335c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange meet(IntRange L, IntRange R) { 233660fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange(std::min(L.Width, R.Width), 233760fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative || R.NonNegative); 233851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 2339f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}; 234051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2341f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) { 2342f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isSigned() && value.isNegative()) 2343f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getMinSignedBits(), false); 234451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2345f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.getBitWidth() > MaxWidth) 23469f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad value = value.trunc(MaxWidth); 234751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2348f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // isNonNegative() just checks the sign bit without considering 2349f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // signedness. 2350f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getActiveBits(), true); 235151313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 235251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 23530acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCallIntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 2354f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned MaxWidth) { 2355f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isInt()) 2356f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetValueRange(C, result.getInt(), MaxWidth); 235751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2358f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isVector()) { 23590acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 23600acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 23610acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 23620acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall R = IntRange::join(R, El); 23630acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall } 2364f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return R; 236551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 236651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2367f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isComplexInt()) { 2368f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 2369f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 2370f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(R, I); 2371f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2372f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2373f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // This can happen with lossless casts to intptr_t of "based" lvalues. 2374f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume it might use arbitrary bits. 23750acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // FIXME: The only reason we need to pass the type in here is to get 23760acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // the sign right on this one case. It would be nice if APValue 23770acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // preserved this. 2378f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(result.isLValue()); 23795e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType()); 238051313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 238151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2382f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the 2383f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take. 2384f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 2385f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated 2386f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 238751313c39c84407dd6a323be99a8c322bf8d052a9John McCall E = E->IgnoreParens(); 238851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2389f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Try a full evaluation first. 2390f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall Expr::EvalResult result; 2391f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (E->Evaluate(result, C)) 23920acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall return GetValueRange(C, result.Val, E->getType(), MaxWidth); 239351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2394f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // I think we only want to look through implicit casts here; if the 2395f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // user has an explicit widening cast, we should treat the value as 2396f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // being of the new, wider type. 2397f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 23982de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (CE->getCastKind() == CK_NoOp) 2399f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CE->getSubExpr(), MaxWidth); 240051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 24011844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType()); 240251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 24032de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 240460fad45739b764886f707bd204eae9ecce6db1f2John McCall 2405f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume that non-integer casts can span the full range of the type. 240660fad45739b764886f707bd204eae9ecce6db1f2John McCall if (!isIntegerCast) 2407f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 240851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2409f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange SubRange 2410f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall = GetExprRange(C, CE->getSubExpr(), 2411f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall std::min(MaxWidth, OutputTypeRange.Width)); 241251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2413f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Bail out if the subexpr's range is as wide as the cast type. 2414f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SubRange.Width >= OutputTypeRange.Width) 2415f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 241651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2417f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, we take the smaller width, and we're non-negative if 2418f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // either the output type or the subexpr is. 2419f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(SubRange.Width, 2420f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall SubRange.NonNegative || OutputTypeRange.NonNegative); 2421f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2422f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2423f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 2424f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // If we can fold the condition, just take that operand. 2425f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool CondResult; 2426f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 2427f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CondResult ? CO->getTrueExpr() 2428f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : CO->getFalseExpr(), 2429f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall MaxWidth); 2430f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2431f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, conservatively merge. 2432f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 2433f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 2434f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 243551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 243651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 243751313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 243851313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (BO->getOpcode()) { 243951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2440f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Boolean-valued operations are single-bit and positive. 24412de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LAnd: 24422de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LOr: 24432de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LT: 24442de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GT: 24452de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LE: 24462de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GE: 24472de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_EQ: 24482de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_NE: 2449f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 245051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2451c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall // The type of these compound assignments is the type of the LHS, 2452c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall // so the RHS is not necessarily an integer. 24532de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_MulAssign: 24542de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_DivAssign: 24552de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_RemAssign: 24562de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AddAssign: 24572de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_SubAssign: 24581844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 2459c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall 246051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 24612de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemD: 24622de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemI: 24631844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 246451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 246560fad45739b764886f707bd204eae9ecce6db1f2John McCall // Bitwise-and uses the *infinum* of the two source ranges. 24662de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_And: 24672de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AndAssign: 246860fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 246960fad45739b764886f707bd204eae9ecce6db1f2John McCall GetExprRange(C, BO->getRHS(), MaxWidth)); 247060fad45739b764886f707bd204eae9ecce6db1f2John McCall 247151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Left shift gets black-listed based on a judgement call. 24722de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shl: 24733aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // ...except that we want to treat '1 << (blah)' as logically 24743aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // positive. It's an important idiom. 24753aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (IntegerLiteral *I 24763aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 24773aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (I->getValue() == 1) { 24781844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange R = IntRange::forValueOfType(C, E->getType()); 24793aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall return IntRange(R.Width, /*NonNegative*/ true); 24803aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 24813aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 24823aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // fallthrough 24833aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall 24842de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShlAssign: 24851844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 248651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 248760fad45739b764886f707bd204eae9ecce6db1f2John McCall // Right shift by a constant can narrow its left argument. 24882de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shr: 24892de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShrAssign: { 249060fad45739b764886f707bd204eae9ecce6db1f2John McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 249160fad45739b764886f707bd204eae9ecce6db1f2John McCall 249260fad45739b764886f707bd204eae9ecce6db1f2John McCall // If the shift amount is a positive constant, drop the width by 249360fad45739b764886f707bd204eae9ecce6db1f2John McCall // that much. 249460fad45739b764886f707bd204eae9ecce6db1f2John McCall llvm::APSInt shift; 249560fad45739b764886f707bd204eae9ecce6db1f2John McCall if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 249660fad45739b764886f707bd204eae9ecce6db1f2John McCall shift.isNonNegative()) { 249760fad45739b764886f707bd204eae9ecce6db1f2John McCall unsigned zext = shift.getZExtValue(); 249860fad45739b764886f707bd204eae9ecce6db1f2John McCall if (zext >= L.Width) 249960fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width = (L.NonNegative ? 0 : 1); 250060fad45739b764886f707bd204eae9ecce6db1f2John McCall else 250160fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width -= zext; 250260fad45739b764886f707bd204eae9ecce6db1f2John McCall } 250360fad45739b764886f707bd204eae9ecce6db1f2John McCall 250460fad45739b764886f707bd204eae9ecce6db1f2John McCall return L; 250560fad45739b764886f707bd204eae9ecce6db1f2John McCall } 250660fad45739b764886f707bd204eae9ecce6db1f2John McCall 250760fad45739b764886f707bd204eae9ecce6db1f2John McCall // Comma acts as its right operand. 25082de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Comma: 2509f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 2510f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 251160fad45739b764886f707bd204eae9ecce6db1f2John McCall // Black-list pointer subtractions. 25122de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Sub: 251351313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BO->getLHS()->getType()->isPointerType()) 25141844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 251551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // fallthrough 25164e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 251751313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 2518f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall break; 251951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 2520f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2521f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Treat every other operator as if it were closed on the 2522f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // narrowest type that encompasses both operands. 2523f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 2524f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 2525f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 252651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 252751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 252851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 252951313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (UO->getOpcode()) { 253051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Boolean-valued operations are white-listed. 25312de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_LNot: 2532f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 253351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 253451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 25352de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_Deref: 25362de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_AddrOf: // should be impossible 25371844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 253851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 253951313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 2540f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, UO->getSubExpr(), MaxWidth); 254151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 254251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 25438ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor 25448ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor if (dyn_cast<OffsetOfExpr>(E)) { 25451844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange::forValueOfType(C, E->getType()); 25468ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor } 254751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2548f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall FieldDecl *BitField = E->getBitField(); 2549f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (BitField) { 2550f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APSInt BitWidthAP = BitField->getBitWidth()->EvaluateAsInt(C); 2551f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned BitWidth = BitWidthAP.getZExtValue(); 255251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 25535e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor return IntRange(BitWidth, 25545e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor BitField->getType()->isUnsignedIntegerOrEnumerationType()); 2555f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2556f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 25571844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 2558f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 2559f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2560323ed74658bc8375278eabf074b4777458376540John McCallIntRange GetExprRange(ASTContext &C, Expr *E) { 2561323ed74658bc8375278eabf074b4777458376540John McCall return GetExprRange(C, E, C.getIntWidth(E->getType())); 2562323ed74658bc8375278eabf074b4777458376540John McCall} 2563323ed74658bc8375278eabf074b4777458376540John McCall 2564f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 2565f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 2566f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 2567f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const llvm::APFloat &value, 2568f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 2569f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 2570f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APFloat truncated = value; 2571f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2572f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool ignored; 2573f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 2574f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 2575f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2576f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return truncated.bitwiseIsEqual(value); 257751313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 257851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2579f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 2580f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 2581f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 2582f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 2583f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number). 2584f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const APValue &value, 2585f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 2586f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 2587f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isFloat()) 2588f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 2589f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2590f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isVector()) { 2591f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 2592f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 2593f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return false; 2594f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return true; 2595f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2596f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2597f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(value.isComplexFloat()); 2598f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 2599f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 2600f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 2601f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2602b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 2603323ed74658bc8375278eabf074b4777458376540John McCall 2604e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) { 2605e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where we are comparing against an enum constant. 2606e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (const DeclRefExpr *DR = 2607e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 2608e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (isa<EnumConstantDecl>(DR->getDecl())) 2609e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 2610e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 2611e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where the '0' value is expanded from a macro. 2612e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (E->getLocStart().isMacroID()) 2613e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 2614e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 2615323ed74658bc8375278eabf074b4777458376540John McCall llvm::APSInt Value; 2616323ed74658bc8375278eabf074b4777458376540John McCall return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 2617323ed74658bc8375278eabf074b4777458376540John McCall} 2618323ed74658bc8375278eabf074b4777458376540John McCall 2619372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) { 2620372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall // Strip off implicit integral promotions. 2621372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 262263b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis if (ICE->getCastKind() != CK_IntegralCast && 262363b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis ICE->getCastKind() != CK_NoOp) 2624372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall break; 262563b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis E = ICE->getSubExpr(); 2626372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall } 2627372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 2628372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall return E->getType()->isEnumeralType(); 2629372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall} 2630372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 2631323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 26322de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = E->getOpcode(); 263314af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor if (E->isValueDependent()) 263414af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor return; 263514af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor 26362de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op == BO_LT && IsZero(S, E->getRHS())) { 2637323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 2638372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "< 0" << "false" << HasEnumType(E->getLHS()) 2639323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 26402de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GE && IsZero(S, E->getRHS())) { 2641323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 2642372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << ">= 0" << "true" << HasEnumType(E->getLHS()) 2643323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 26442de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GT && IsZero(S, E->getLHS())) { 2645323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 2646372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 >" << "false" << HasEnumType(E->getRHS()) 2647323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 26482de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_LE && IsZero(S, E->getLHS())) { 2649323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 2650372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 <=" << "true" << HasEnumType(E->getRHS()) 2651323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 2652323ed74658bc8375278eabf074b4777458376540John McCall } 2653323ed74658bc8375278eabf074b4777458376540John McCall} 2654323ed74658bc8375278eabf074b4777458376540John McCall 2655323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison. Implements the 2656323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison. 2657323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 2658b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 2659b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 2660323ed74658bc8375278eabf074b4777458376540John McCall} 2661f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2662ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare. 2663ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// 2664ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \param lex the left-hand expression 2665ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \param rex the right-hand expression 2666ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \param OpLoc the location of the joining operator 2667d1b47bf17fde73fac67d8664bd65273742c00ecdJohn McCall/// \param BinOpc binary opcode or 0 2668323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeComparison(Sema &S, BinaryOperator *E) { 2669323ed74658bc8375278eabf074b4777458376540John McCall // The type the comparison is being performed in. 2670323ed74658bc8375278eabf074b4777458376540John McCall QualType T = E->getLHS()->getType(); 2671323ed74658bc8375278eabf074b4777458376540John McCall assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 2672323ed74658bc8375278eabf074b4777458376540John McCall && "comparison with mismatched types"); 2673323ed74658bc8375278eabf074b4777458376540John McCall 2674323ed74658bc8375278eabf074b4777458376540John McCall // We don't do anything special if this isn't an unsigned integral 2675323ed74658bc8375278eabf074b4777458376540John McCall // comparison: we're only interested in integral comparisons, and 2676323ed74658bc8375278eabf074b4777458376540John McCall // signed comparisons only happen in cases we don't care to warn about. 26773e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // 26783e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // We also don't care about value-dependent expressions or expressions 26793e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // whose result is a constant. 26803e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor if (!T->hasUnsignedIntegerRepresentation() 26813e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor || E->isValueDependent() || E->isIntegerConstantExpr(S.Context)) 2682323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 2683323ed74658bc8375278eabf074b4777458376540John McCall 2684323ed74658bc8375278eabf074b4777458376540John McCall Expr *lex = E->getLHS()->IgnoreParenImpCasts(); 2685323ed74658bc8375278eabf074b4777458376540John McCall Expr *rex = E->getRHS()->IgnoreParenImpCasts(); 2686323ed74658bc8375278eabf074b4777458376540John McCall 2687323ed74658bc8375278eabf074b4777458376540John McCall // Check to see if one of the (unmodified) operands is of different 2688323ed74658bc8375278eabf074b4777458376540John McCall // signedness. 2689323ed74658bc8375278eabf074b4777458376540John McCall Expr *signedOperand, *unsignedOperand; 2690f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (lex->getType()->hasSignedIntegerRepresentation()) { 2691f60946222721d9ba3c059563935c17b84703187aDouglas Gregor assert(!rex->getType()->hasSignedIntegerRepresentation() && 2692323ed74658bc8375278eabf074b4777458376540John McCall "unsigned comparison between two signed integer expressions?"); 2693323ed74658bc8375278eabf074b4777458376540John McCall signedOperand = lex; 2694323ed74658bc8375278eabf074b4777458376540John McCall unsignedOperand = rex; 2695f60946222721d9ba3c059563935c17b84703187aDouglas Gregor } else if (rex->getType()->hasSignedIntegerRepresentation()) { 2696323ed74658bc8375278eabf074b4777458376540John McCall signedOperand = rex; 2697323ed74658bc8375278eabf074b4777458376540John McCall unsignedOperand = lex; 2698ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } else { 2699323ed74658bc8375278eabf074b4777458376540John McCall CheckTrivialUnsignedComparison(S, E); 2700323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 2701ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } 2702ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2703323ed74658bc8375278eabf074b4777458376540John McCall // Otherwise, calculate the effective range of the signed operand. 2704323ed74658bc8375278eabf074b4777458376540John McCall IntRange signedRange = GetExprRange(S.Context, signedOperand); 2705f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2706323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and analyze implicit conversions in the operands. Note 2707323ed74658bc8375278eabf074b4777458376540John McCall // that we skip the implicit conversions on both sides. 2708b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, lex, E->getOperatorLoc()); 2709b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, rex, E->getOperatorLoc()); 2710ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2711323ed74658bc8375278eabf074b4777458376540John McCall // If the signed range is non-negative, -Wsign-compare won't fire, 2712323ed74658bc8375278eabf074b4777458376540John McCall // but we should still check for comparisons which are always true 2713323ed74658bc8375278eabf074b4777458376540John McCall // or false. 2714323ed74658bc8375278eabf074b4777458376540John McCall if (signedRange.NonNegative) 2715323ed74658bc8375278eabf074b4777458376540John McCall return CheckTrivialUnsignedComparison(S, E); 2716ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2717ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // For (in)equality comparisons, if the unsigned operand is a 2718ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // constant which cannot collide with a overflowed signed operand, 2719ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // then reinterpreting the signed operand as unsigned will not 2720ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // change the result of the comparison. 2721323ed74658bc8375278eabf074b4777458376540John McCall if (E->isEqualityOp()) { 2722323ed74658bc8375278eabf074b4777458376540John McCall unsigned comparisonWidth = S.Context.getIntWidth(T); 2723323ed74658bc8375278eabf074b4777458376540John McCall IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 2724323ed74658bc8375278eabf074b4777458376540John McCall 2725323ed74658bc8375278eabf074b4777458376540John McCall // We should never be unable to prove that the unsigned operand is 2726323ed74658bc8375278eabf074b4777458376540John McCall // non-negative. 2727323ed74658bc8375278eabf074b4777458376540John McCall assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 2728ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2729323ed74658bc8375278eabf074b4777458376540John McCall if (unsignedRange.Width < comparisonWidth) 2730323ed74658bc8375278eabf074b4777458376540John McCall return; 2731323ed74658bc8375278eabf074b4777458376540John McCall } 2732323ed74658bc8375278eabf074b4777458376540John McCall 2733323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison) 2734323ed74658bc8375278eabf074b4777458376540John McCall << lex->getType() << rex->getType() 2735323ed74658bc8375278eabf074b4777458376540John McCall << lex->getSourceRange() << rex->getSourceRange(); 2736ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall} 2737ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 273815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield. 273915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// 274015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt. 274115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallbool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 274215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall SourceLocation InitLoc) { 274315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall assert(Bitfield->isBitField()); 274415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Bitfield->isInvalidDecl()) 274515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 274615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 274791b6014876e9186f968f74a8975ab8fc08ef1b68John McCall // White-list bool bitfields. 274891b6014876e9186f968f74a8975ab8fc08ef1b68John McCall if (Bitfield->getType()->isBooleanType()) 274991b6014876e9186f968f74a8975ab8fc08ef1b68John McCall return false; 275091b6014876e9186f968f74a8975ab8fc08ef1b68John McCall 275146ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor // Ignore value- or type-dependent expressions. 275246ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor if (Bitfield->getBitWidth()->isValueDependent() || 275346ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Bitfield->getBitWidth()->isTypeDependent() || 275446ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isValueDependent() || 275546ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isTypeDependent()) 275646ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor return false; 275746ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor 275815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *OriginalInit = Init->IgnoreParenImpCasts(); 275915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 276015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall llvm::APSInt Width(32); 276115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr::EvalResult InitValue; 276215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (!Bitfield->getBitWidth()->isIntegerConstantExpr(Width, S.Context) || 276391b6014876e9186f968f74a8975ab8fc08ef1b68John McCall !OriginalInit->Evaluate(InitValue, S.Context) || 276415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall !InitValue.Val.isInt()) 276515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 276615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 276715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall const llvm::APSInt &Value = InitValue.Val.getInt(); 276815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned OriginalWidth = Value.getBitWidth(); 276915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned FieldWidth = Width.getZExtValue(); 277015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 277115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (OriginalWidth <= FieldWidth) 277215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 277315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 27749f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad llvm::APSInt TruncatedValue = Value.trunc(FieldWidth); 277515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 277615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // It's fairly common to write values into signed bitfields 277715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // that, if sign-extended, would end up becoming a different 277815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // value. We don't want to warn about that. 277915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value.isSigned() && Value.isNegative()) 27809f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad TruncatedValue = TruncatedValue.sext(OriginalWidth); 278115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall else 27829f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad TruncatedValue = TruncatedValue.zext(OriginalWidth); 278315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 278415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value == TruncatedValue) 278515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 278615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 278715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyValue = Value.toString(10); 278815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyTrunc = TruncatedValue.toString(10); 278915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 279015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 279115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << PrettyValue << PrettyTrunc << OriginalInit->getType() 279215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << Init->getSourceRange(); 279315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 279415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return true; 279515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 279615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 2797beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy 2798beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations. 2799beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCallvoid AnalyzeAssignment(Sema &S, BinaryOperator *E) { 2800beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Just recurse on the LHS. 2801beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 2802beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 2803beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // We want to recurse on the RHS as normal unless we're assigning to 2804beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // a bitfield. 2805beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (FieldDecl *Bitfield = E->getLHS()->getBitField()) { 280615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 280715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc())) { 280815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // Recurse, ignoring any implicit conversions on the RHS. 280915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 281015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc()); 2811beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 2812beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 2813beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 2814beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 2815beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall} 2816beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 281751313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 28185a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregorvoid DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T, 28195a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceLocation CContext, unsigned diag) { 28205a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor S.Diag(E->getExprLoc(), diag) 28215a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor << SourceType << T << E->getSourceRange() << SourceRange(CContext); 28225a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor} 28235a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 2824e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 2825e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruthvoid DiagnoseImpCast(Sema &S, Expr *E, QualType T, SourceLocation CContext, 2826e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth unsigned diag) { 2827e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth DiagnoseImpCast(S, E, E->getType(), T, CContext, diag); 2828e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth} 2829e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth 2830f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth/// Diagnose an implicit cast from a literal expression. Also attemps to supply 2831f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth/// fixit hints when the cast wouldn't lose information to simply write the 2832f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth/// expression with the expected type. 2833f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruthvoid DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T, 2834f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth SourceLocation CContext) { 2835f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth // Emit the primary warning first, then try to emit a fixit hint note if 2836f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth // reasonable. 2837f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer) 2838f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth << FL->getType() << T << FL->getSourceRange() << SourceRange(CContext); 2839f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 2840f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth const llvm::APFloat &Value = FL->getValue(); 2841f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 2842f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth // Don't attempt to fix PPC double double literals. 2843f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth if (&Value.getSemantics() == &llvm::APFloat::PPCDoubleDouble) 2844f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth return; 2845f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 2846f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth // Try to convert this exactly to an 64-bit integer. FIXME: It would be 2847f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth // nice to support arbitrarily large integers here. 2848f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth bool isExact = false; 2849f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth uint64_t IntegerPart; 2850f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth if (Value.convertToInteger(&IntegerPart, 64, /*isSigned=*/true, 2851f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth llvm::APFloat::rmTowardZero, &isExact) 2852f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth != llvm::APFloat::opOK || !isExact) 2853f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth return; 2854f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 2855f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth llvm::APInt IntegerValue(64, IntegerPart, /*isSigned=*/true); 2856f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 2857f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth std::string LiteralValue = IntegerValue.toString(10, /*isSigned=*/true); 2858f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth S.Diag(FL->getExprLoc(), diag::note_fix_integral_float_as_integer) 2859f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth << FixItHint::CreateReplacement(FL->getSourceRange(), LiteralValue); 2860f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth} 2861f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 2862091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 2863091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Range.Width) return "0"; 2864091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2865091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt ValueInRange = Value; 2866091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.setIsSigned(!Range.NonNegative); 28679f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad ValueInRange = ValueInRange.trunc(Range.Width); 2868091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return ValueInRange.toString(10); 2869091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall} 2870091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2871ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenekstatic bool isFromSystemMacro(Sema &S, SourceLocation loc) { 2872ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceManager &smgr = S.Context.getSourceManager(); 2873ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return loc.isMacroID() && smgr.isInSystemHeader(smgr.getSpellingLoc(loc)); 2874ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek} 2875f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 2876323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T, 2877b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool *ICContext = 0) { 2878323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) return; 287951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2880323ed74658bc8375278eabf074b4777458376540John McCall const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 2881323ed74658bc8375278eabf074b4777458376540John McCall const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 2882323ed74658bc8375278eabf074b4777458376540John McCall if (Source == Target) return; 2883323ed74658bc8375278eabf074b4777458376540John McCall if (Target->isDependentType()) return; 288451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2885ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // If the conversion context location is invalid don't complain. 2886ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // We also don't want to emit a warning if the issue occurs from the 2887ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // instantiation of a system macro. The problem is that 'getSpellingLoc()' 2888ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // is slow, so we delay this check as long as possible. Once we detect 2889ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // we are in that scenario, we just return. 2890ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (CC.isInvalid()) 2891b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return; 2892b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 289351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Never diagnose implicit casts to bool. 289451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (Target->isSpecificBuiltinType(BuiltinType::Bool)) 289551313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 289651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 289751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip vector types. 289851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<VectorType>(Source)) { 2899ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<VectorType>(Target)) { 2900ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 2901ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 2902b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 2903ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 290451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 290551313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 290651313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 290751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 290851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 290951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip complex types. 291051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<ComplexType>(Source)) { 2911ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<ComplexType>(Target)) { 2912ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 2913ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 2914ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 2915b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 2916ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 291751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 291851313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 291951313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 292051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 292151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 292251313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 292351313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 292451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 292551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the source is floating point... 292651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT && SourceBT->isFloatingPoint()) { 292751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...and the target is floating point... 292851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (TargetBT && TargetBT->isFloatingPoint()) { 292951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...then warn if we're dropping FP rank. 293051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 293151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Builtin FP kinds are ordered by increasing FP rank. 293251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT->getKind() > TargetBT->getKind()) { 293351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Don't warn about float constants that are precisely 293451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // representable in the target type. 293551313c39c84407dd6a323be99a8c322bf8d052a9John McCall Expr::EvalResult result; 2936323ed74658bc8375278eabf074b4777458376540John McCall if (E->Evaluate(result, S.Context)) { 293751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Value might be a float, a float vector, or a float complex. 293851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (IsSameFloatAfterCast(result.Val, 2939323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 2940323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 294151313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 294251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 294351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2944ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 2945ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 2946ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 2947b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 294851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 294951313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 295051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 295151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2952ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // If the target is integral, always warn. 2953a5b9332418f25338f118358e27303cd510d54107Chandler Carruth if ((TargetBT && TargetBT->isInteger())) { 2954ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 2955ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 2956ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 2957a5b9332418f25338f118358e27303cd510d54107Chandler Carruth Expr *InnerE = E->IgnoreParenImpCasts(); 2958f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) { 2959f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth DiagnoseFloatingLiteralImpCast(S, FL, T, CC); 2960a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } else { 2961a5b9332418f25338f118358e27303cd510d54107Chandler Carruth DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 2962a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 2963a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 296451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 296551313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 296651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 296751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2968f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!Source->isIntegerType() || !Target->isIntegerType()) 296951313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 297051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2971323ed74658bc8375278eabf074b4777458376540John McCall IntRange SourceRange = GetExprRange(S.Context, E); 29721844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 297351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2974f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width > TargetRange.Width) { 2975091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // If the source is a constant, use a default-on diagnostic. 2976091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // TODO: this should happen for bitfield stores, too. 2977091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt Value(32); 2978091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (E->isIntegerConstantExpr(Value, S.Context)) { 2979ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 2980ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 2981ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 2982091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettySourceValue = Value.toString(10); 2983091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 2984091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2985091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall S.Diag(E->getExprLoc(), diag::warn_impcast_integer_precision_constant) 2986091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall << PrettySourceValue << PrettyTargetValue 2987091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall << E->getType() << T << E->getSourceRange() << clang::SourceRange(CC); 2988091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return; 2989091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall } 2990091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 299151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // People want to build with -Wshorten-64-to-32 and not -Wconversion 299251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // and by god we'll let them. 2993ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 2994ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 2995ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 2996ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 2997f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width == 64 && TargetRange.Width == 32) 2998b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32); 2999b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 3000323ed74658bc8375278eabf074b4777458376540John McCall } 3001323ed74658bc8375278eabf074b4777458376540John McCall 3002323ed74658bc8375278eabf074b4777458376540John McCall if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 3003323ed74658bc8375278eabf074b4777458376540John McCall (!TargetRange.NonNegative && SourceRange.NonNegative && 3004323ed74658bc8375278eabf074b4777458376540John McCall SourceRange.Width == TargetRange.Width)) { 3005ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3006ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3007ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3008ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3009323ed74658bc8375278eabf074b4777458376540John McCall unsigned DiagID = diag::warn_impcast_integer_sign; 3010323ed74658bc8375278eabf074b4777458376540John McCall 3011323ed74658bc8375278eabf074b4777458376540John McCall // Traditionally, gcc has warned about this under -Wsign-compare. 3012323ed74658bc8375278eabf074b4777458376540John McCall // We also want to warn about it in -Wconversion. 3013323ed74658bc8375278eabf074b4777458376540John McCall // So if -Wconversion is off, use a completely identical diagnostic 3014323ed74658bc8375278eabf074b4777458376540John McCall // in the sign-compare group. 3015323ed74658bc8375278eabf074b4777458376540John McCall // The conditional-checking code will 3016323ed74658bc8375278eabf074b4777458376540John McCall if (ICContext) { 3017323ed74658bc8375278eabf074b4777458376540John McCall DiagID = diag::warn_impcast_integer_sign_conditional; 3018323ed74658bc8375278eabf074b4777458376540John McCall *ICContext = true; 3019323ed74658bc8375278eabf074b4777458376540John McCall } 3020323ed74658bc8375278eabf074b4777458376540John McCall 3021b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, DiagID); 302251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 302351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3024284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor // Diagnose conversions between different enumeration types. 30255a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // In C, we pretend that the type of an EnumConstantDecl is its enumeration 30265a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // type, to give us better diagnostics. 30275a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor QualType SourceType = E->getType(); 30285a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (!S.getLangOptions().CPlusPlus) { 30295a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 30305a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) { 30315a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext()); 30325a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceType = S.Context.getTypeDeclType(Enum); 30335a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor Source = S.Context.getCanonicalType(SourceType).getTypePtr(); 30345a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 30355a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 30365a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 3037284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *SourceEnum = Source->getAs<EnumType>()) 3038284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *TargetEnum = Target->getAs<EnumType>()) 3039284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if ((SourceEnum->getDecl()->getIdentifier() || 3040162e1c1b487352434552147967c3dd296ebee2f7Richard Smith SourceEnum->getDecl()->getTypedefNameForAnonDecl()) && 3041284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor (TargetEnum->getDecl()->getIdentifier() || 3042162e1c1b487352434552147967c3dd296ebee2f7Richard Smith TargetEnum->getDecl()->getTypedefNameForAnonDecl()) && 3043ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceEnum != TargetEnum) { 3044ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3045ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3046ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 30475a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor return DiagnoseImpCast(S, E, SourceType, T, CC, 3048284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor diag::warn_impcast_different_enum_types); 3049ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 3050284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor 305151313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 305251313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 305351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3054323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T); 3055323ed74658bc8375278eabf074b4777458376540John McCall 3056323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T, 3057b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool &ICContext) { 3058323ed74658bc8375278eabf074b4777458376540John McCall E = E->IgnoreParenImpCasts(); 3059323ed74658bc8375278eabf074b4777458376540John McCall 3060323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) 3061323ed74658bc8375278eabf074b4777458376540John McCall return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T); 3062323ed74658bc8375278eabf074b4777458376540John McCall 3063b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E, CC); 3064323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 3065b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return CheckImplicitConversion(S, E, T, CC, &ICContext); 3066323ed74658bc8375278eabf074b4777458376540John McCall return; 3067323ed74658bc8375278eabf074b4777458376540John McCall} 3068323ed74658bc8375278eabf074b4777458376540John McCall 3069323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) { 3070b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC = E->getQuestionLoc(); 3071b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 3072b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getCond(), CC); 3073323ed74658bc8375278eabf074b4777458376540John McCall 3074323ed74658bc8375278eabf074b4777458376540John McCall bool Suspicious = false; 3075b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 3076b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 3077323ed74658bc8375278eabf074b4777458376540John McCall 3078323ed74658bc8375278eabf074b4777458376540John McCall // If -Wconversion would have warned about either of the candidates 3079323ed74658bc8375278eabf074b4777458376540John McCall // for a signedness conversion to the context type... 3080323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) return; 3081323ed74658bc8375278eabf074b4777458376540John McCall 3082323ed74658bc8375278eabf074b4777458376540John McCall // ...but it's currently ignored... 30830827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional, 30840827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis CC)) 3085323ed74658bc8375278eabf074b4777458376540John McCall return; 3086323ed74658bc8375278eabf074b4777458376540John McCall 3087323ed74658bc8375278eabf074b4777458376540John McCall // ...and -Wsign-compare isn't... 30880827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (!S.Diags.getDiagnosticLevel(diag::warn_mixed_sign_conditional, CC)) 3089323ed74658bc8375278eabf074b4777458376540John McCall return; 3090323ed74658bc8375278eabf074b4777458376540John McCall 3091323ed74658bc8375278eabf074b4777458376540John McCall // ...then check whether it would have warned about either of the 3092323ed74658bc8375278eabf074b4777458376540John McCall // candidates for a signedness conversion to the condition type. 3093323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) { 3094323ed74658bc8375278eabf074b4777458376540John McCall Suspicious = false; 3095323ed74658bc8375278eabf074b4777458376540John McCall CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 3096b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 3097323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) 3098323ed74658bc8375278eabf074b4777458376540John McCall CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 3099b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 3100323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) 3101323ed74658bc8375278eabf074b4777458376540John McCall return; 3102323ed74658bc8375278eabf074b4777458376540John McCall } 3103323ed74658bc8375278eabf074b4777458376540John McCall 3104323ed74658bc8375278eabf074b4777458376540John McCall // If so, emit a diagnostic under -Wsign-compare. 3105323ed74658bc8375278eabf074b4777458376540John McCall Expr *lex = E->getTrueExpr()->IgnoreParenImpCasts(); 3106323ed74658bc8375278eabf074b4777458376540John McCall Expr *rex = E->getFalseExpr()->IgnoreParenImpCasts(); 3107323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getQuestionLoc(), diag::warn_mixed_sign_conditional) 3108323ed74658bc8375278eabf074b4777458376540John McCall << lex->getType() << rex->getType() 3109323ed74658bc8375278eabf074b4777458376540John McCall << lex->getSourceRange() << rex->getSourceRange(); 3110323ed74658bc8375278eabf074b4777458376540John McCall} 3111323ed74658bc8375278eabf074b4777458376540John McCall 3112323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting 3113323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression. There are a couple 3114323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare. 3115b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 3116323ed74658bc8375278eabf074b4777458376540John McCall QualType T = OrigE->getType(); 3117323ed74658bc8375278eabf074b4777458376540John McCall Expr *E = OrigE->IgnoreParenImpCasts(); 3118323ed74658bc8375278eabf074b4777458376540John McCall 3119323ed74658bc8375278eabf074b4777458376540John McCall // For conditional operators, we analyze the arguments as if they 3120323ed74658bc8375278eabf074b4777458376540John McCall // were being fed directly into the output. 3121323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) { 3122323ed74658bc8375278eabf074b4777458376540John McCall ConditionalOperator *CO = cast<ConditionalOperator>(E); 3123323ed74658bc8375278eabf074b4777458376540John McCall CheckConditionalOperator(S, CO, T); 3124323ed74658bc8375278eabf074b4777458376540John McCall return; 3125323ed74658bc8375278eabf074b4777458376540John McCall } 3126323ed74658bc8375278eabf074b4777458376540John McCall 3127323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and check any implicit conversions we might have skipped. 3128323ed74658bc8375278eabf074b4777458376540John McCall // The non-canonical typecheck is just an optimization; 3129323ed74658bc8375278eabf074b4777458376540John McCall // CheckImplicitConversion will filter out dead implicit conversions. 3130323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 3131b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckImplicitConversion(S, E, T, CC); 3132323ed74658bc8375278eabf074b4777458376540John McCall 3133323ed74658bc8375278eabf074b4777458376540John McCall // Now continue drilling into this expression. 3134323ed74658bc8375278eabf074b4777458376540John McCall 3135323ed74658bc8375278eabf074b4777458376540John McCall // Skip past explicit casts. 3136323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ExplicitCastExpr>(E)) { 3137323ed74658bc8375278eabf074b4777458376540John McCall E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 3138b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return AnalyzeImplicitConversions(S, E, CC); 3139323ed74658bc8375278eabf074b4777458376540John McCall } 3140323ed74658bc8375278eabf074b4777458376540John McCall 3141beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 3142beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Do a somewhat different check with comparison operators. 3143beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isComparisonOp()) 3144beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeComparison(S, BO); 3145beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 3146beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // And with assignments and compound assignments. 3147beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isAssignmentOp()) 3148beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeAssignment(S, BO); 3149beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 3150323ed74658bc8375278eabf074b4777458376540John McCall 3151323ed74658bc8375278eabf074b4777458376540John McCall // These break the otherwise-useful invariant below. Fortunately, 3152323ed74658bc8375278eabf074b4777458376540John McCall // we don't really need to recurse into them, because any internal 3153323ed74658bc8375278eabf074b4777458376540John McCall // expressions should have been analyzed already when they were 3154323ed74658bc8375278eabf074b4777458376540John McCall // built into statements. 3155323ed74658bc8375278eabf074b4777458376540John McCall if (isa<StmtExpr>(E)) return; 3156323ed74658bc8375278eabf074b4777458376540John McCall 3157323ed74658bc8375278eabf074b4777458376540John McCall // Don't descend into unevaluated contexts. 3158f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne if (isa<UnaryExprOrTypeTraitExpr>(E)) return; 3159323ed74658bc8375278eabf074b4777458376540John McCall 3160323ed74658bc8375278eabf074b4777458376540John McCall // Now just recurse over the expression's children. 3161b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CC = E->getExprLoc(); 31627502c1d3ce8bb97bcc4f7bebef507040bd93b26fJohn McCall for (Stmt::child_range I = E->children(); I; ++I) 3163b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, cast<Expr>(*I), CC); 3164323ed74658bc8375278eabf074b4777458376540John McCall} 3165323ed74658bc8375278eabf074b4777458376540John McCall 3166323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace 3167323ed74658bc8375278eabf074b4777458376540John McCall 3168323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given 3169323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression). Implements -Wconversion 3170323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare. 3171b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// 3172b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e. 3173b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// the most location of the syntactic entity requiring the implicit 3174b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// conversion 3175b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 3176323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose in unevaluated contexts. 3177323ed74658bc8375278eabf074b4777458376540John McCall if (ExprEvalContexts.back().Context == Sema::Unevaluated) 3178323ed74658bc8375278eabf074b4777458376540John McCall return; 3179323ed74658bc8375278eabf074b4777458376540John McCall 3180323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose for value- or type-dependent expressions. 3181323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) 3182323ed74658bc8375278eabf074b4777458376540John McCall return; 3183323ed74658bc8375278eabf074b4777458376540John McCall 3184b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // This is not the right CC for (e.g.) a variable initialization. 3185b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(*this, E, CC); 3186323ed74658bc8375278eabf074b4777458376540John McCall} 3187323ed74658bc8375278eabf074b4777458376540John McCall 318815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 318915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall FieldDecl *BitField, 319015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *Init) { 319115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 319215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 319315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 3194f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given 3195f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This 3196f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the 3197f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function 3198f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete. 319982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregorbool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd, 320082aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor bool CheckParameterNames) { 3201f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump bool HasInvalidParm = false; 320282aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor for (; P != PEnd; ++P) { 320382aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor ParmVarDecl *Param = *P; 320482aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor 3205f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.7.5.3p4: the parameters in a parameter type list in a 3206f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // function declarator that is part of a function definition of 3207f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // that function shall not have incomplete type. 3208f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // 3209f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // This is also C++ [dcl.fct]p6. 3210f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump if (!Param->isInvalidDecl() && 3211f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump RequireCompleteType(Param->getLocation(), Param->getType(), 3212f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump diag::err_typecheck_decl_incomplete_type)) { 3213f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Param->setInvalidDecl(); 3214f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump HasInvalidParm = true; 3215f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 3216f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 3217f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.9.1p5: If the declarator includes a parameter type list, the 3218f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // declaration of each parameter shall include an identifier. 321982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor if (CheckParameterNames && 322082aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor Param->getIdentifier() == 0 && 3221f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !Param->isImplicit() && 3222f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !getLangOptions().CPlusPlus) 3223f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Diag(Param->getLocation(), diag::err_parameter_name_omitted); 3224d17e340e2d516139931768697bf080f60920ba9dSam Weinig 3225d17e340e2d516139931768697bf080f60920ba9dSam Weinig // C99 6.7.5.3p12: 3226d17e340e2d516139931768697bf080f60920ba9dSam Weinig // If the function declarator is not part of a definition of that 3227d17e340e2d516139931768697bf080f60920ba9dSam Weinig // function, parameters may have incomplete type and may use the [*] 3228d17e340e2d516139931768697bf080f60920ba9dSam Weinig // notation in their sequences of declarator specifiers to specify 3229d17e340e2d516139931768697bf080f60920ba9dSam Weinig // variable length array types. 3230d17e340e2d516139931768697bf080f60920ba9dSam Weinig QualType PType = Param->getOriginalType(); 3231d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (const ArrayType *AT = Context.getAsArrayType(PType)) { 3232d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (AT->getSizeModifier() == ArrayType::Star) { 3233d17e340e2d516139931768697bf080f60920ba9dSam Weinig // FIXME: This diagnosic should point the the '[*]' if source-location 3234d17e340e2d516139931768697bf080f60920ba9dSam Weinig // information is added for it. 3235d17e340e2d516139931768697bf080f60920ba9dSam Weinig Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 3236d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 3237d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 3238f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 3239f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 3240f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump return HasInvalidParm; 3241f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump} 3242b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3243b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a 3244b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements. 3245b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 3246b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // This is actually a lot of work to potentially be doing on every 3247b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // cast; don't do it if we're ignoring -Wcast_align (as is the default). 32480827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align, 32490827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis TRange.getBegin()) 3250b7f4ffe073fa419613946461a2583ba2fcb72280John McCall == Diagnostic::Ignored) 3251b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 3252b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3253b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Ignore dependent types. 3254b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (T->isDependentType() || Op->getType()->isDependentType()) 3255b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 3256b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3257b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the destination be a pointer type. 3258b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *DestPtr = T->getAs<PointerType>(); 3259b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!DestPtr) return; 3260b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3261b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // If the destination has alignment 1, we're done. 3262b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType DestPointee = DestPtr->getPointeeType(); 3263b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestPointee->isIncompleteType()) return; 3264b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 3265b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestAlign.isOne()) return; 3266b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3267b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the source be a pointer type. 3268b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 3269b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!SrcPtr) return; 3270b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType SrcPointee = SrcPtr->getPointeeType(); 3271b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3272b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Whitelist casts from cv void*. We already implicitly 3273b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // whitelisted casts to cv void*, since they have alignment 1. 3274b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Also whitelist casts involving incomplete types, which implicitly 3275b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // includes 'void'. 3276b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcPointee->isIncompleteType()) return; 3277b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3278b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 3279b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcAlign >= DestAlign) return; 3280b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3281b7f4ffe073fa419613946461a2583ba2fcb72280John McCall Diag(TRange.getBegin(), diag::warn_cast_align) 3282b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << Op->getType() << T 3283b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(SrcAlign.getQuantity()) 3284b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(DestAlign.getQuantity()) 3285b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << TRange << Op->getSourceRange(); 3286b7f4ffe073fa419613946461a2583ba2fcb72280John McCall} 3287b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 32883aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekstatic void CheckArrayAccess_Check(Sema &S, 32893aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek const clang::ArraySubscriptExpr *E) { 329035001ca261f895817916b468379b696d6d45959dChandler Carruth const Expr *BaseExpr = E->getBase()->IgnoreParenImpCasts(); 32913406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const ConstantArrayType *ArrayTy = 32923aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek S.Context.getAsConstantArrayType(BaseExpr->getType()); 32933406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (!ArrayTy) 3294a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 329535001ca261f895817916b468379b696d6d45959dChandler Carruth 32963406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const Expr *IndexExpr = E->getIdx(); 32973406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (IndexExpr->isValueDependent()) 3298a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 32993406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth llvm::APSInt index; 33003aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (!IndexExpr->isIntegerConstantExpr(index, S.Context)) 3301a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 33028fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek 33039e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek if (index.isUnsigned() || !index.isNegative()) { 330425b3b849e3ad340b04442707038c86980035765bTed Kremenek llvm::APInt size = ArrayTy->getSize(); 330535001ca261f895817916b468379b696d6d45959dChandler Carruth if (!size.isStrictlyPositive()) 330635001ca261f895817916b468379b696d6d45959dChandler Carruth return; 33073406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (size.getBitWidth() > index.getBitWidth()) 33083406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth index = index.sext(size.getBitWidth()); 330925b3b849e3ad340b04442707038c86980035765bTed Kremenek else if (size.getBitWidth() < index.getBitWidth()) 331025b3b849e3ad340b04442707038c86980035765bTed Kremenek size = size.sext(index.getBitWidth()); 331125b3b849e3ad340b04442707038c86980035765bTed Kremenek 33123406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (index.slt(size)) 33138fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek return; 33143406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth 33153aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek S.DiagRuntimeBehavior(E->getBase()->getLocStart(), BaseExpr, 33163aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek S.PDiag(diag::warn_array_index_exceeds_bounds) 33173aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek << index.toString(10, true) 33183aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek << size.toString(10, true) 33193aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek << IndexExpr->getSourceRange()); 33203406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth } else { 33213aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek S.DiagRuntimeBehavior(E->getBase()->getLocStart(), BaseExpr, 33223aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek S.PDiag(diag::warn_array_index_precedes_bounds) 33233aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek << index.toString(10, true) 33243aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek << IndexExpr->getSourceRange()); 3325a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek } 332635001ca261f895817916b468379b696d6d45959dChandler Carruth 332735001ca261f895817916b468379b696d6d45959dChandler Carruth const NamedDecl *ND = NULL; 332835001ca261f895817916b468379b696d6d45959dChandler Carruth if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 332935001ca261f895817916b468379b696d6d45959dChandler Carruth ND = dyn_cast<NamedDecl>(DRE->getDecl()); 333035001ca261f895817916b468379b696d6d45959dChandler Carruth if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 333135001ca261f895817916b468379b696d6d45959dChandler Carruth ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 333235001ca261f895817916b468379b696d6d45959dChandler Carruth if (ND) 33333aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek S.DiagRuntimeBehavior(ND->getLocStart(), BaseExpr, 33343aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek S.PDiag(diag::note_array_index_out_of_bounds) 33353aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek << ND->getDeclName()); 33363aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek} 33373aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek 33383aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) { 3339f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne while (true) { 3340f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne expr = expr->IgnoreParens(); 33413aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek switch (expr->getStmtClass()) { 33423aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek case Stmt::ArraySubscriptExprClass: 33433aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess_Check(*this, cast<ArraySubscriptExpr>(expr)); 33443aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 33453aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek case Stmt::ConditionalOperatorClass: { 33463aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek const ConditionalOperator *cond = cast<ConditionalOperator>(expr); 33473aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *lhs = cond->getLHS()) 33483aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(lhs); 33493aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *rhs = cond->getRHS()) 33503aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(rhs); 33513aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 33523aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 33533aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek default: 33543aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 33553aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 3356f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne } 3357a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek} 3358