SemaChecking.cpp revision 6f2a9fa0f787d3023b643496e8c321bdb7a85fa0
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// The LLVM Compiler Infrastructure 459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source 60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details. 759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump// This file implements extra semantic analysis beyond what is enforced 1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// by the C type system. 1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 152d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 1659907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h" 17199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h" 18384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 19c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h" 2055fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/AST/EvaluatedExprVisitor.h" 21be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie#include "clang/AST/Expr.h" 222324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h" 237ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h" 24f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h" 25f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h" 2655fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Analysis/Analyses/FormatString.h" 273f6f51e28231f65de9c2dd150a2d757b2162cfa3Jordan Rose#include "clang/Basic/CharInfo.h" 2855fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Basic/TargetBuiltins.h" 2955fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Basic/TargetInfo.h" 3059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h" 3155fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Initialization.h" 3255fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Lookup.h" 3355fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/ScopeInfo.h" 3455fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "clang/Sema/Sema.h" 35f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h" 36f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h" 3755fc873017f10f6f566b182b70f6fc22aefa3464Chandler Carruth#include "llvm/ADT/SmallString.h" 38cb5620c9b213f4bd323912159fdddda35e258a14Dmitri Gribenko#include "llvm/Support/ConvertUTF.h" 393bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h" 40a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits> 4159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang; 42781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema; 4359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 4460800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 4560800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned ByteNo) const { 4608f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner return SL->getLocationOfByte(ByteNo, PP.getSourceManager(), 474e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie PP.getLangOpts(), PP.getTargetInfo()); 4860800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner} 4960800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 508e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number. 518e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking. Returns true on error. 528e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) { 538e10f3b9cc1db43645bbc2999eb163af8997d468John McCall unsigned argCount = call->getNumArgs(); 548e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount == desiredArgCount) return false; 558e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 568e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount < desiredArgCount) 578e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args) 588e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 598e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getSourceRange(); 608e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 618e10f3b9cc1db43645bbc2999eb163af8997d468John McCall // Highlight all the excess arguments. 628e10f3b9cc1db43645bbc2999eb163af8997d468John McCall SourceRange range(call->getArg(desiredArgCount)->getLocStart(), 638e10f3b9cc1db43645bbc2999eb163af8997d468John McCall call->getArg(argCount - 1)->getLocEnd()); 648e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 658e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args) 668e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 678e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getArg(1)->getSourceRange(); 688e10f3b9cc1db43645bbc2999eb163af8997d468John McCall} 698e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 70e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// Check that the first argument to __builtin_annotation is an integer 71e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// and the second argument is a non-wide string literal. 72e59392176c2369df2bdd11b7786cb38abac00198Julien Lerougestatic bool SemaBuiltinAnnotation(Sema &S, CallExpr *TheCall) { 73e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (checkArgCount(S, TheCall, 2)) 74e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge return true; 75e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 76e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge // First argument should be an integer. 77e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge Expr *ValArg = TheCall->getArg(0); 78e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge QualType Ty = ValArg->getType(); 79e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (!Ty->isIntegerType()) { 80e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge S.Diag(ValArg->getLocStart(), diag::err_builtin_annotation_first_arg) 81e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge << ValArg->getSourceRange(); 82e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge return true; 83e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge } 84e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 85e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge // Second argument should be a constant string. 86e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge Expr *StrArg = TheCall->getArg(1)->IgnoreParenCasts(); 87e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge StringLiteral *Literal = dyn_cast<StringLiteral>(StrArg); 8877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge if (!Literal || !Literal->isAscii()) { 89e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge S.Diag(StrArg->getLocStart(), diag::err_builtin_annotation_second_arg) 90e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge << StrArg->getSourceRange(); 9177f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return true; 9277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge } 93e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 94e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge TheCall->setType(Ty); 9577f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return false; 9677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge} 9777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge 9860d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 99d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 10060d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult TheCallResult(Owned(TheCall)); 1012def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor 102946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Find out if any arguments are required to be integer constant expressions. 103946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner unsigned ICEArguments = 0; 104946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ASTContext::GetBuiltinTypeError Error; 105946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 106946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (Error != ASTContext::GE_None) 107946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments = 0; // Don't diagnose previously diagnosed errors. 108946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 109946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // If any arguments are required to be ICE's, check and diagnose. 110946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 111946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Skip arguments not required to be ICE's. 112946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if ((ICEArguments & (1 << ArgNo)) == 0) continue; 113946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 114946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner llvm::APSInt Result; 115946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 116946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner return true; 117946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments &= ~(1 << ArgNo); 118946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner } 119946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 120d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson switch (BuiltinID) { 12130ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin___CFStringMakeConstantString: 122925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner assert(TheCall->getNumArgs() == 1 && 1231b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner "Wrong # arguments to builtin CFStringMakeConstantString"); 124690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner if (CheckObjCString(TheCall->getArg(0))) 1250eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 126d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 12749ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek case Builtin::BI__builtin_stdarg_start: 12830ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin_va_start: 1290eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinVAStart(TheCall)) 1300eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 131d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1321b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreater: 1331b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreaterequal: 1341b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isless: 1351b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessequal: 1361b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessgreater: 1371b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isunordered: 1380eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinUnorderedCompare(TheCall)) 1390eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 140d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 141e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer case Builtin::BI__builtin_fpclassify: 142e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer if (SemaBuiltinFPClassification(TheCall, 6)) 143e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer return ExprError(); 144e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer break; 1459ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isfinite: 1469ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf: 1479ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf_sign: 1489ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnan: 1499ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnormal: 1503b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (SemaBuiltinFPClassification(TheCall, 1)) 1519ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return ExprError(); 1529ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman break; 153d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman case Builtin::BI__builtin_shufflevector: 1540eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return SemaBuiltinShuffleVector(TheCall); 1550eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // TheCall will be freed by the smart pointer here, but that's fine, since 1560eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // SemaBuiltinShuffleVector guts it, but then doesn't release it. 1574493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar case Builtin::BI__builtin_prefetch: 1580eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinPrefetch(TheCall)) 1590eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 160d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 161d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar case Builtin::BI__builtin_object_size: 1620eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinObjectSize(TheCall)) 1630eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 164d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 165d875fed28578835de89cd407e9db4be788596d7cEli Friedman case Builtin::BI__builtin_longjmp: 166d875fed28578835de89cd407e9db4be788596d7cEli Friedman if (SemaBuiltinLongjmp(TheCall)) 167d875fed28578835de89cd407e9db4be788596d7cEli Friedman return ExprError(); 168d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1698e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 1708e10f3b9cc1db43645bbc2999eb163af8997d468John McCall case Builtin::BI__builtin_classify_type: 1718e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1728e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 1738e10f3b9cc1db43645bbc2999eb163af8997d468John McCall break; 17475c29a012793292ff4578015a9113bf086156d7fChris Lattner case Builtin::BI__builtin_constant_p: 1758e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1768e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 17775c29a012793292ff4578015a9113bf086156d7fChris Lattner break; 1785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: 179a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 180a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 181a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 182a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 183a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 1845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: 185a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 186a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 187a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 188a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 189a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 1905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: 191a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 192a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 193a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 194a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 195a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 1965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: 197a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 198a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 199a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 200a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 201a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 2025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: 203a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 204a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 205a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 206a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 207a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 2085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_add_and_fetch: 209a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 210a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 211a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 212a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 213a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 2145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_sub_and_fetch: 215a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 216a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 217a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 218a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 219a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 2205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_and_and_fetch: 221a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 222a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 223a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 224a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 225a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 2265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_or_and_fetch: 227a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 228a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 229a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 230a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 231a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 2325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_xor_and_fetch: 233a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 234a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 235a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 236a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 237a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 2385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 239a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 240a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 241a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 242a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 243a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 2445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 245a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 246a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 247a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 248a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 249a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 2505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_test_and_set: 251a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 252a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 253a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 254a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 255a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 2565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 257a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 258a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 259a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 260a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 261a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 26223aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: 263a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 264a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 265a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 266a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 267a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 2683fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return SemaBuiltinAtomicOverloaded(TheCallResult); 269ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define BUILTIN(ID, TYPE, ATTRS) 270ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define ATOMIC_BUILTIN(ID, TYPE, ATTRS) \ 271ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Builtin::BI##ID: \ 2723fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return SemaAtomicOpsOverloaded(TheCallResult, AtomicExpr::AO##ID); 273ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#include "clang/Basic/Builtins.def" 27477f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge case Builtin::BI__builtin_annotation: 275e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (SemaBuiltinAnnotation(*this, TheCall)) 27677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return ExprError(); 27777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge break; 27826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 27926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 28026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // Since the target specific builtins for each arch overlap, only check those 28126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // of the arch we are compiling for. 28226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (BuiltinID >= Builtin::FirstTSBuiltin) { 283bcfd1f55bfbb3e5944cd5e03d07b343e280838c4Douglas Gregor switch (Context.getTargetInfo().getTriple().getArch()) { 28426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::arm: 28526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::thumb: 28626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 28726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return ExprError(); 28826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 289fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips: 290fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mipsel: 291fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips64: 292fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips64el: 293fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (CheckMipsBuiltinFunctionCall(BuiltinID, TheCall)) 294fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return ExprError(); 295fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan break; 29626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman default: 29726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 29826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 29926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 30026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 3013fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return TheCallResult; 30226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman} 30326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 30461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code. 30561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) { 306da95f73b59f9af964e33725c515139d34c90c863Bob Wilson NeonTypeFlags Type(t); 307da95f73b59f9af964e33725c515139d34c90c863Bob Wilson int IsQuad = Type.isQuad(); 308da95f73b59f9af964e33725c515139d34c90c863Bob Wilson switch (Type.getEltType()) { 309da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int8: 310da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly8: 311da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 7 : (8 << IsQuad) - 1; 312da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int16: 313da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly16: 314da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 15 : (4 << IsQuad) - 1; 315da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int32: 316da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 31 : (2 << IsQuad) - 1; 317da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int64: 318da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 63 : (1 << IsQuad) - 1; 319da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float16: 320da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 321da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (4 << IsQuad) - 1; 322da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float32: 323da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 324da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (2 << IsQuad) - 1; 32561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman } 3267530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie llvm_unreachable("Invalid NeonTypeFlag!"); 32761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman} 32861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 3296f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// getNeonEltType - Return the QualType corresponding to the elements of 3306f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the vector type specified by the NeonTypeFlags. This is used to check 3316f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the pointer arguments for Neon load/store intrinsics. 3326f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilsonstatic QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context) { 3336f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson switch (Flags.getEltType()) { 3346f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int8: 3356f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy; 3366f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int16: 3376f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy; 3386f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int32: 3396f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy; 3406f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int64: 3416f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedLongLongTy : Context.LongLongTy; 3426f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly8: 3436f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.SignedCharTy; 3446f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly16: 3456f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.ShortTy; 3466f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float16: 3476f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.UnsignedShortTy; 3486f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float32: 3496f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.FloatTy; 3506f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 3517530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie llvm_unreachable("Invalid NeonTypeFlag!"); 3526f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson} 3536f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 35426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 3551c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman llvm::APSInt Result; 3561c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 357f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith uint64_t mask = 0; 35861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned TV = 0; 3594648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson int PtrArgNum = -1; 3606f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson bool HasConstPtr = false; 3611c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman switch (BuiltinID) { 362a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK 363a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 364a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK 3651c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman } 3661c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 3670d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which are overloaded on vector element type, validate 3680d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // the immediate which specifies which variant to emit. 3696f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson unsigned ImmArg = TheCall->getNumArgs()-1; 3700d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (mask) { 3716f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson if (SemaBuiltinConstantArg(TheCall, ImmArg, Result)) 3720d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 3730d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 374da95f73b59f9af964e33725c515139d34c90c863Bob Wilson TV = Result.getLimitedValue(64); 375f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith if ((TV > 63) || (mask & (1ULL << TV)) == 0) 3760d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 3776f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson << TheCall->getArg(ImmArg)->getSourceRange(); 3786f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 3796f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 3804648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (PtrArgNum >= 0) { 3816f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson // Check that pointer arguments have the specified type. 3824648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Expr *Arg = TheCall->getArg(PtrArgNum); 3834648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) 3844648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Arg = ICE->getSubExpr(); 3854648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg); 3864648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType RHSTy = RHS.get()->getType(); 3874648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context); 3884648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (HasConstPtr) 3894648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson EltTy = EltTy.withConst(); 3904648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType LHSTy = Context.getPointerType(EltTy); 3914648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson AssignConvertType ConvTy; 3924648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS); 3934648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (RHS.isInvalid()) 3944648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 3954648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy, 3964648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson RHS.get(), AA_Assigning)) 3974648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 3980d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman } 3991c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 4000d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which take an immediate value as part of the 4010d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // instruction, range check them here. 40261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned i = 0, l = 0, u = 0; 4030d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman switch (BuiltinID) { 4040d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman default: return false; 405bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 406bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 40799c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_f: 40899c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 409a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK 410a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 411a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK 4120d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman }; 4130d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 414592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 415592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 416592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor TheCall->getArg(i)->isValueDependent()) 417592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor return false; 418592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 41961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Check that the immediate argument is actually a constant. 4200d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, i, Result)) 4210d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 4220d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 42361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Range check against the upper/lower values for this isntruction. 4240d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned Val = Result.getZExtValue(); 42561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if (Val < l || Val > (u + l)) 4260d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 427476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer << l << u+l << TheCall->getArg(i)->getSourceRange(); 4280d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 42999c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman // FIXME: VFP Intrinsics should error if VFP not present. 43026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return false; 431d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson} 432d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 433fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyanbool Sema::CheckMipsBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 434fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan unsigned i = 0, l = 0, u = 0; 435fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan switch (BuiltinID) { 436fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan default: return false; 437fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case Mips::BI__builtin_mips_wrdsp: i = 1; l = 0; u = 63; break; 438fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case Mips::BI__builtin_mips_rddsp: i = 0; l = 0; u = 63; break; 439be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_append: i = 2; l = 0; u = 31; break; 440be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_balign: i = 2; l = 0; u = 3; break; 441be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_precr_sra_ph_w: i = 2; l = 0; u = 31; break; 442be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_precr_sra_r_ph_w: i = 2; l = 0; u = 31; break; 443be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_prepend: i = 2; l = 0; u = 31; break; 444fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan }; 445fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 446fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // We can't check the value of a dependent argument. 447fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (TheCall->getArg(i)->isTypeDependent() || 448fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan TheCall->getArg(i)->isValueDependent()) 449fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return false; 450fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 451fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // Check that the immediate argument is actually a constant. 452fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan llvm::APSInt Result; 453fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (SemaBuiltinConstantArg(TheCall, i, Result)) 454fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return true; 455fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 456fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // Range check against the upper/lower values for this instruction. 457fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan unsigned Val = Result.getZExtValue(); 458fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (Val < l || Val > u) 459fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 460fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan << l << u << TheCall->getArg(i)->getSourceRange(); 461fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 462fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return false; 463fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan} 464fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 465831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Given a FunctionDecl's FormatAttr, attempts to populate the FomatStringInfo 466831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// parameter with the FormatAttr's correct format_idx and firstDataArg. 467831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true when the format fits the function and the FormatStringInfo has 468831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// been populated. 469831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::getFormatStringInfo(const FormatAttr *Format, bool IsCXXMember, 470831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FormatStringInfo *FSI) { 471831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->HasVAListArg = Format->getFirstArg() == 0; 472831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->FormatIdx = Format->getFormatIdx() - 1; 473831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->FirstDataArg = FSI->HasVAListArg ? 0 : Format->getFirstArg() - 1; 474de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 475831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // The way the format attribute works in GCC, the implicit this argument 476831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // of member functions is counted. However, it doesn't appear in our own 477831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // lists, so decrement format_idx in that case. 478831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (IsCXXMember) { 479831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if(FSI->FormatIdx == 0) 480831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 481831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith --FSI->FormatIdx; 482831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (FSI->FirstDataArg != 0) 483831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith --FSI->FirstDataArg; 484831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 485831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return true; 486831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 4871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 488831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Handles the checks for format strings, non-POD arguments to vararg 489831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// functions, and NULL arguments passed to non-NULL parameters. 4901c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkovoid Sema::checkCall(NamedDecl *FDecl, 4911c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 492831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs, 493831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool IsMemberFunction, 494831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation Loc, 495831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceRange Range, 496831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType) { 49766360e224689dc23a0acd8a6705ba50bec13bc97Jordan Rose if (CurContext->isDependentContext()) 49866360e224689dc23a0acd8a6705ba50bec13bc97Jordan Rose return; 499de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 500c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek // Printf and scanf checking. 501831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool HandledFormatString = false; 502c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<FormatAttr> 503831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith I = FDecl->specific_attr_begin<FormatAttr>(), 504831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith E = FDecl->specific_attr_end<FormatAttr>(); I != E ; ++I) 5051c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko if (CheckFormatArguments(*I, Args, IsMemberFunction, CallType, Loc, Range)) 506831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HandledFormatString = true; 507831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 508831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // Refuse POD arguments that weren't caught by the format string 509831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // checks above. 510831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!HandledFormatString && CallType != VariadicDoesNotApply) 5111c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko for (unsigned ArgIdx = NumProtoArgs; ArgIdx < Args.size(); ++ArgIdx) { 5120234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek // Args[ArgIdx] can be null in malformed code. 5131c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko if (const Expr *Arg = Args[ArgIdx]) 5140234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek variadicArgumentPODCheck(Arg, CallType); 5150234bfa2b03470b8ce379a7485e60ffa35c1d550Ted Kremenek } 5161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 517c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<NonNullAttr> 518831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith I = FDecl->specific_attr_begin<NonNullAttr>(), 519831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith E = FDecl->specific_attr_end<NonNullAttr>(); I != E; ++I) 5201c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko CheckNonNullArguments(*I, Args.data(), Loc); 5210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 5220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Type safety checking. 5230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (specific_attr_iterator<ArgumentWithTypeTagAttr> 5240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko i = FDecl->specific_attr_begin<ArgumentWithTypeTagAttr>(), 5250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko e = FDecl->specific_attr_end<ArgumentWithTypeTagAttr>(); i != e; ++i) { 5261c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko CheckArgumentWithTypeTag(*i, Args.data()); 5270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 528831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 529831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 530831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckConstructorCall - Check a constructor call for correctness and safety 531831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// properties not enforced by the C type system. 5321c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkovoid Sema::CheckConstructorCall(FunctionDecl *FDecl, 5331c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 534831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const FunctionProtoType *Proto, 535831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation Loc) { 536831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = 537831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Proto->isVariadic() ? VariadicConstructor : VariadicDoesNotApply; 5381c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkCall(FDecl, Args, Proto->getNumArgs(), 539831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*IsMemberFunction=*/true, Loc, SourceRange(), CallType); 540831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 541831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 542831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckFunctionCall - Check a direct function call for various correctness 543831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// and safety properties not strictly enforced by the C type system. 544831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall, 545831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const FunctionProtoType *Proto) { 5462edcde8747a000113b434a5c88b4648beed4197bEli Friedman bool IsMemberOperatorCall = isa<CXXOperatorCallExpr>(TheCall) && 5472edcde8747a000113b434a5c88b4648beed4197bEli Friedman isa<CXXMethodDecl>(FDecl); 5482edcde8747a000113b434a5c88b4648beed4197bEli Friedman bool IsMemberFunction = isa<CXXMemberCallExpr>(TheCall) || 5492edcde8747a000113b434a5c88b4648beed4197bEli Friedman IsMemberOperatorCall; 550831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = getVariadicCallType(FDecl, Proto, 551831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()); 552831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0; 5532edcde8747a000113b434a5c88b4648beed4197bEli Friedman Expr** Args = TheCall->getArgs(); 5542edcde8747a000113b434a5c88b4648beed4197bEli Friedman unsigned NumArgs = TheCall->getNumArgs(); 555df75b0c74b277c6b46af2f9e90e13160fbc14d6fEli Friedman if (IsMemberOperatorCall) { 5562edcde8747a000113b434a5c88b4648beed4197bEli Friedman // If this is a call to a member operator, hide the first argument 5572edcde8747a000113b434a5c88b4648beed4197bEli Friedman // from checkCall. 5582edcde8747a000113b434a5c88b4648beed4197bEli Friedman // FIXME: Our choice of AST representation here is less than ideal. 5592edcde8747a000113b434a5c88b4648beed4197bEli Friedman ++Args; 5602edcde8747a000113b434a5c88b4648beed4197bEli Friedman --NumArgs; 5612edcde8747a000113b434a5c88b4648beed4197bEli Friedman } 5621c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkCall(FDecl, llvm::makeArrayRef<const Expr *>(Args, NumArgs), 5631c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko NumProtoArgs, 564831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith IsMemberFunction, TheCall->getRParenLoc(), 565831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()->getSourceRange(), CallType); 566831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 567831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith IdentifierInfo *FnInfo = FDecl->getIdentifier(); 568831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // None of the checks below are needed for functions that don't have 569831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // simple names (e.g., C++ conversion functions). 570831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!FnInfo) 571831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 5720eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 5730a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned CMId = FDecl->getMemoryFunctionKind(); 5740a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == 0) 575d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks return false; 576bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 577d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks // Handle memory setting and copying functions. 5780a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat) 579bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CheckStrlcpycatArguments(TheCall, FnInfo); 580c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (CMId == Builtin::BIstrncat) 581c36bedc90c687caa71748480c60707ea4608b092Anna Zaks CheckStrncatArguments(TheCall, FnInfo); 582d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks else 5830a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks CheckMemaccessArguments(TheCall, CMId, FnInfo); 5847ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 585d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 58671993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson} 58771993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 58829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupasbool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac, 589287f24d3991994b9a263af9e2a873f4feadfb8faDmitri Gribenko ArrayRef<const Expr *> Args) { 590831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = 591831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Method->isVariadic() ? VariadicMethod : VariadicDoesNotApply; 59229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 593287f24d3991994b9a263af9e2a873f4feadfb8faDmitri Gribenko checkCall(Method, Args, Method->param_size(), 594831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*IsMemberFunction=*/false, 595831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith lbrac, Method->getSourceRange(), CallType); 59629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 59729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return false; 59829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 59929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 600831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall, 601831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const FunctionProtoType *Proto) { 602725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian const VarDecl *V = dyn_cast<VarDecl>(NDecl); 603725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!V) 604d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 6051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 606725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian QualType Ty = V->getType(); 607725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Ty->isBlockPointerType()) 608d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 6091eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 610831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = 611831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Proto && Proto->isVariadic() ? VariadicBlock : VariadicDoesNotApply ; 612831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0; 613d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 6141c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkCall(NDecl, 6151c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko llvm::makeArrayRef<const Expr *>(TheCall->getArgs(), 6161c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko TheCall->getNumArgs()), 617831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith NumProtoArgs, /*IsMemberFunction=*/false, 618831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getRParenLoc(), 619831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()->getSourceRange(), CallType); 620831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 621d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 622725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian} 623725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian 624ff34d401ff385ef7173ca612432b4ea717fff690Richard SmithExprResult Sema::SemaAtomicOpsOverloaded(ExprResult TheCallResult, 625ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith AtomicExpr::AtomicOp Op) { 626276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman CallExpr *TheCall = cast<CallExpr>(TheCallResult.get()); 627276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 628276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 629ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // All these operations take one of the following forms: 630ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith enum { 631ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_init(A *, C) 632ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Init, 633ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_load(A *, int) 634ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Load, 635ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // void __atomic_load(A *, CP, int) 636ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Copy, 637ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_add(A *, M, int) 638ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Arithmetic, 639ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __atomic_exchange_n(A *, CP, int) 640ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Xchg, 641ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // void __atomic_exchange(A *, C *, CP, int) 642ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith GNUXchg, 643ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // bool __c11_atomic_compare_exchange_strong(A *, C *, CP, int, int) 644ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith C11CmpXchg, 645ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // bool __atomic_compare_exchange(A *, C *, CP, bool, int, int) 646ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith GNUCmpXchg 647ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } Form = Init; 648ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith const unsigned NumArgs[] = { 2, 2, 3, 3, 3, 4, 5, 6 }; 649ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith const unsigned NumVals[] = { 1, 0, 1, 1, 1, 2, 2, 3 }; 650ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // where: 651ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C is an appropriate type, 652ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // A is volatile _Atomic(C) for __c11 builtins and is C for GNU builtins, 653ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // CP is C for __c11 builtins and GNU _n builtins and is C * otherwise, 654ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // M is C if C is an integer, and ptrdiff_t if C is a pointer, and 655ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // the int parameters are for orderings. 656ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 657ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith assert(AtomicExpr::AO__c11_atomic_init == 0 && 658ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith AtomicExpr::AO__c11_atomic_fetch_xor + 1 == AtomicExpr::AO__atomic_load 659ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith && "need to update code for modified C11 atomics"); 660ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsC11 = Op >= AtomicExpr::AO__c11_atomic_init && 661ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op <= AtomicExpr::AO__c11_atomic_fetch_xor; 662ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsN = Op == AtomicExpr::AO__atomic_load_n || 663ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_store_n || 664ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_exchange_n || 665ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_compare_exchange_n; 666ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsAddSub = false; 667ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 668ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (Op) { 669ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_init: 670ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Init; 671ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 672ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 673ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_load: 674ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_load_n: 675ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Load; 676ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 677ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 678ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_store: 679ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_load: 680ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_store: 681ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_store_n: 682ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Copy; 683ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 684ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 685ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_add: 686ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_sub: 687ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_add: 688ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_sub: 689ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_add_fetch: 690ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_sub_fetch: 691ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith IsAddSub = true; 692ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Fall through. 693ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_and: 694ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_or: 695ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_xor: 696ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_and: 697ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_or: 698ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_xor: 69951b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith case AtomicExpr::AO__atomic_fetch_nand: 700ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_and_fetch: 701ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_or_fetch: 702ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_xor_fetch: 70351b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith case AtomicExpr::AO__atomic_nand_fetch: 704ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Arithmetic; 705ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 706ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 707ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_exchange: 708ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_exchange_n: 709ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Xchg; 710ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 711ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 712ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_exchange: 713ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = GNUXchg; 714ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 715ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 716ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_compare_exchange_strong: 717ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_compare_exchange_weak: 718ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = C11CmpXchg; 719ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 720ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 721ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_compare_exchange: 722ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_compare_exchange_n: 723ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = GNUCmpXchg; 724ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 725276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 726276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 727ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Check we have the right number of arguments. 728ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (TheCall->getNumArgs() < NumArgs[Form]) { 729276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 730ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << 0 << NumArgs[Form] << TheCall->getNumArgs() 731276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 732276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 733ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } else if (TheCall->getNumArgs() > NumArgs[Form]) { 734ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(TheCall->getArg(NumArgs[Form])->getLocStart(), 735276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman diag::err_typecheck_call_too_many_args) 736ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << 0 << NumArgs[Form] << TheCall->getNumArgs() 737276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 738276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 739276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 740276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 741ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Inspect the first argument of the atomic operation. 742dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman Expr *Ptr = TheCall->getArg(0); 743276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get(); 744276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman const PointerType *pointerType = Ptr->getType()->getAs<PointerType>(); 745276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!pointerType) { 746ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 747276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 748276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 749276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 750276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 751ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For a __c11 builtin, this should be a pointer to an _Atomic type. 752ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType AtomTy = pointerType->getPointeeType(); // 'A' 753ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType ValType = AtomTy; // 'C' 754ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (IsC11) { 755ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!AtomTy->isAtomicType()) { 756ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic) 757ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << Ptr->getType() << Ptr->getSourceRange(); 758ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 759ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 760bc57b108b2253e26b83768dba196c28564952f18Richard Smith if (AtomTy.isConstQualified()) { 761bc57b108b2253e26b83768dba196c28564952f18Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_non_const_atomic) 762bc57b108b2253e26b83768dba196c28564952f18Richard Smith << Ptr->getType() << Ptr->getSourceRange(); 763bc57b108b2253e26b83768dba196c28564952f18Richard Smith return ExprError(); 764bc57b108b2253e26b83768dba196c28564952f18Richard Smith } 765ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ValType = AtomTy->getAs<AtomicType>()->getValueType(); 766276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 767276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 768ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For an arithmetic operation, the implied arithmetic must be well-formed. 769ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Arithmetic) { 770ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // gcc does not enforce these rules for GNU atomics, but we do so for sanity. 771ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (IsAddSub && !ValType->isIntegerType() && !ValType->isPointerType()) { 772ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 773ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 774ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 775ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 776ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsAddSub && !ValType->isIntegerType()) { 777ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_bitwise_needs_atomic_int) 778ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 779ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 780ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 781ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } else if (IsN && !ValType->isIntegerType() && !ValType->isPointerType()) { 782ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For __atomic_*_n operations, the value type must be a scalar integral or 783ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // pointer type which is 1, 2, 4, 8 or 16 bytes in length. 784276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 785ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 786276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 787276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 788276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 789ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsC11 && !AtomTy.isTriviallyCopyableType(Context)) { 790ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For GNU atomics, require a trivially-copyable type. This is not part of 791ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // the GNU atomics specification, but we enforce it for sanity. 792ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_trivial_copy) 793276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 794276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 795276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 796276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 797ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // FIXME: For any builtin other than a load, the ValType must not be 798ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // const-qualified. 799ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 800276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman switch (ValType.getObjCLifetime()) { 801276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_None: 802276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_ExplicitNone: 803276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // okay 804276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman break; 805276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 806276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Weak: 807276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Strong: 808276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Autoreleasing: 809ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // FIXME: Can this happen? By this point, ValType should be known 810ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // to be trivially copyable. 811276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 812276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << ValType << Ptr->getSourceRange(); 813276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 814276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 815276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 816276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType ResultType = ValType; 817ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Copy || Form == GNUXchg || Form == Init) 818276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.VoidTy; 819ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == C11CmpXchg || Form == GNUCmpXchg) 820276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.BoolTy; 821276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 822ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The type of a parameter passed 'by value'. In the GNU atomics, such 823ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // arguments are actually passed as pointers. 824ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType ByValType = ValType; // 'CP' 825ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsC11 && !IsN) 826ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ByValType = Ptr->getType(); 827ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 828276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The first argument --- the pointer --- has a fixed type; we 829276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // deduce the types of the rest of the arguments accordingly. Walk 830276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // the remaining arguments, converting them to the deduced value type. 831ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith for (unsigned i = 1; i != NumArgs[Form]; ++i) { 832276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType Ty; 833ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (i < NumVals[Form] + 1) { 834ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (i) { 835ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 1: 836ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The second argument is the non-atomic operand. For arithmetic, this 837ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // is always passed by value, and for a compare_exchange it is always 838ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // passed by address. For the rest, GNU uses by-address and C11 uses 839ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // by-value. 840ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith assert(Form != Load); 841ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Init || (Form == Arithmetic && ValType->isIntegerType())) 842ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ValType; 843ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == Copy || Form == Xchg) 844ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ByValType; 845ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == Arithmetic) 846ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.getPointerDiffType(); 847ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else 848ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.getPointerType(ValType.getUnqualifiedType()); 849ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 850ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 2: 851ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The third argument to compare_exchange / GNU exchange is a 852ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // (pointer to a) desired value. 853ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ByValType; 854ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 855ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 3: 856ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The fourth argument to GNU compare_exchange is a 'weak' flag. 857ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.BoolTy; 858ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 859ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 860276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else { 861276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The order(s) are always converted to int. 862276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.IntTy; 863276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 864ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 865276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity Entity = 866276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity::InitializeParameter(Context, Ty, false); 867ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ExprResult Arg = TheCall->getArg(i); 868276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 869276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Arg.isInvalid()) 870276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return true; 871276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman TheCall->setArg(i, Arg.get()); 872276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 873276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 874ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Permute the arguments into a 'consistent' order. 875dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SmallVector<Expr*, 5> SubExprs; 876dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(Ptr); 877ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (Form) { 878ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Init: 879ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Note, AtomicExpr::getVal1() has a special case for this atomic. 8807a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall SubExprs.push_back(TheCall->getArg(1)); // Val1 881ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 882ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Load: 883ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Order 884ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 885ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Copy: 886ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Arithmetic: 887ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Xchg: 888dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(2)); // Order 889dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 890ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 891ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case GNUXchg: 892ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Note, AtomicExpr::getVal2() has a special case for this atomic. 893ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(3)); // Order 894ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Val1 895ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(2)); // Val2 896ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 897ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case C11CmpXchg: 898dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(3)); // Order 899dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 900dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(4)); // OrderFail 9012ebb98a78471f2039af4321bae657e7daacc2a62David Chisnall SubExprs.push_back(TheCall->getArg(2)); // Val2 902ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 903ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case GNUCmpXchg: 904ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(4)); // Order 905ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Val1 906ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(5)); // OrderFail 907ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(2)); // Val2 908ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(3)); // Weak 909ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 910276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 911dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman 912dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman return Owned(new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(), 9133b6bef9a213249c6ab6d67c07b1ac6380961be3eBenjamin Kramer SubExprs, ResultType, Op, 914dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman TheCall->getRParenLoc())); 915276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman} 916276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 917276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 9185f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// checkBuiltinArgument - Given a call to a builtin function, perform 9195f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// normal type-checking on the given argument, updating the call in 9205f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// place. This is useful when a builtin function requires custom 9215f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// type-checking for some of its arguments but not necessarily all of 9225f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// them. 9235f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// 9245f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// Returns true on error. 9255f8d604246976a93a73549b07bbc8ee0b2061b50John McCallstatic bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) { 9265f8d604246976a93a73549b07bbc8ee0b2061b50John McCall FunctionDecl *Fn = E->getDirectCallee(); 9275f8d604246976a93a73549b07bbc8ee0b2061b50John McCall assert(Fn && "builtin call without direct callee!"); 9285f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9295f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ParmVarDecl *Param = Fn->getParamDecl(ArgIndex); 9305f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity Entity = 9315f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity::InitializeParameter(S.Context, Param); 9325f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9335f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ExprResult Arg = E->getArg(0); 9345f8d604246976a93a73549b07bbc8ee0b2061b50John McCall Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg); 9355f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (Arg.isInvalid()) 9365f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 9375f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9385f8d604246976a93a73549b07bbc8ee0b2061b50John McCall E->setArg(ArgIndex, Arg.take()); 9395f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return false; 9405f8d604246976a93a73549b07bbc8ee0b2061b50John McCall} 9415f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like 9435caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer 9445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument. The main ActOnCallExpr routines have already 9455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as 9465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...). 9475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// 9485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these 9495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins, 95060d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 95160d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 952d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 9535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 9545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 9555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 9565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Ensure that we have at least one argument to do type inference from. 957d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1) { 958d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 959d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1 << TheCall->getNumArgs() 960d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 961d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 962d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 9631eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9645caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Inspect the first argument of the atomic builtin. This should always be 9655caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // a pointer type, whose element is an integral scalar or pointer type. 9665caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Because it is a pointer type, we don't have to worry about any implicit 9675caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // casts here. 968d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth // FIXME: We don't allow floating point scalars as input. 9695caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *FirstArg = TheCall->getArg(0); 9708c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg); 9718c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman if (FirstArgResult.isInvalid()) 9728c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman return ExprError(); 9738c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman FirstArg = FirstArgResult.take(); 9748c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman TheCall->setArg(0, FirstArg); 9758c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman 976f85e193739c953358c865005855253af4f68a497John McCall const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>(); 977f85e193739c953358c865005855253af4f68a497John McCall if (!pointerType) { 978d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 979d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 980d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 981d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 9821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 983f85e193739c953358c865005855253af4f68a497John McCall QualType ValType = pointerType->getPointeeType(); 984dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 985d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth !ValType->isBlockPointerType()) { 986d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 987d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 988d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 989d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 9905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 991f85e193739c953358c865005855253af4f68a497John McCall switch (ValType.getObjCLifetime()) { 992f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 993f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 994f85e193739c953358c865005855253af4f68a497John McCall // okay 995f85e193739c953358c865005855253af4f68a497John McCall break; 996f85e193739c953358c865005855253af4f68a497John McCall 997f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 998f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 999f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 1000b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 1001f85e193739c953358c865005855253af4f68a497John McCall << ValType << FirstArg->getSourceRange(); 1002f85e193739c953358c865005855253af4f68a497John McCall return ExprError(); 1003f85e193739c953358c865005855253af4f68a497John McCall } 1004f85e193739c953358c865005855253af4f68a497John McCall 1005b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Strip any qualifiers off ValType. 1006b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType = ValType.getUnqualifiedType(); 1007b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall 10088d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // The majority of builtins return a value, but a few have special return 10098d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // types, so allow them to override appropriately below. 10108d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth QualType ResultType = ValType; 10118d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth 10125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // We need to figure out which concrete builtin this maps onto. For example, 10135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add with a 2 byte object turns into 10145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add_2. 10155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \ 10165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 10175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Builtin::BI##x##_8, Builtin::BI##x##_16 } 10181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10195caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner static const unsigned BuiltinIndices[][5] = { 10205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_add), 10215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_sub), 10225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_or), 10235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_and), 10245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_xor), 10251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_add_and_fetch), 10275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_sub_and_fetch), 10285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_and_and_fetch), 10295caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_or_and_fetch), 10305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_xor_and_fetch), 10311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_val_compare_and_swap), 10335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_bool_compare_and_swap), 10345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_test_and_set), 103523aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_lock_release), 103623aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_swap) 10375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner }; 10381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW 10391eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Determine the index of the size. 10415caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned SizeIndex; 1042199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 10435caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 1: SizeIndex = 0; break; 10445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 2: SizeIndex = 1; break; 10455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 4: SizeIndex = 2; break; 10465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 8: SizeIndex = 3; break; 10475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 16: SizeIndex = 4; break; 10485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: 1049d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 1050d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 1051d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 10525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 10531eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Each of these builtins has one pointer argument, followed by some number of 10555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // values (0, 1 or 2) followed by a potentially empty varags list of stuff 10565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // that we ignore. Find out which row of BuiltinIndices to read from as well 10575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // as the number of fixed args. 10587814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor unsigned BuiltinID = FDecl->getBuiltinID(); 10595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned BuiltinIndex, NumFixed = 1; 10605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner switch (BuiltinID) { 1061b219cfc4d75f0a03630b7c4509ef791b7e97b2c8David Blaikie default: llvm_unreachable("Unknown overloaded atomic builtin!"); 1062a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add: 1063a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 1064a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 1065a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 1066a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 1067a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 1068a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 0; 1069a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1070a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1071a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub: 1072a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 1073a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 1074a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 1075a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 1076a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 1077a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 1; 1078a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1079a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1080a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or: 1081a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 1082a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 1083a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 1084a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 1085a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 1086a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 2; 1087a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1088a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1089a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and: 1090a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 1091a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 1092a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 1093a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 1094a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 1095a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 3; 1096a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1097a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1098a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor: 1099a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 1100a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 1101a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 1102a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 1103a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 1104a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 4; 1105a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1106a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1107a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch: 1108a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 1109a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 1110a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 1111a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 1112a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 1113a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 5; 1114a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1115a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1116a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch: 1117a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 1118a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 1119a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 1120a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 1121a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 1122a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 6; 1123a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1124a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1125a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch: 1126a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 1127a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 1128a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 1129a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 1130a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 1131a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 7; 1132a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1133a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1134a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch: 1135a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 1136a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 1137a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 1138a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 1139a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 1140a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 8; 1141a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1142a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1143a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch: 1144a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 1145a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 1146a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 1147a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 1148a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 1149a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 9; 1150a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 11511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 1153a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 1154a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 1155a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 1156a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 1157a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 11587eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 10; 11595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 11605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1161a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 11625caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 1163a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 1164a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 1165a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 1166a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 1167a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 11687eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 11; 11695caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 11708d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.BoolTy; 11715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1172a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1173a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set: 1174a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 1175a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 1176a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 1177a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 1178a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 1179a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 12; 1180a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1181a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 11825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 1183a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 1184a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 1185a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 1186a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 1187a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 11887eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 13; 11895caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 0; 11908d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.VoidTy; 11915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1192a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1193a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap: 1194a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 1195a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 1196a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 1197a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 1198a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 1199a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 14; 1200a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 12015caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 12021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Now that we know how many fixed arguments we expect, first check that we 12045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // have at least that many. 1205d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1+NumFixed) { 1206d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 1207d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1+NumFixed << TheCall->getNumArgs() 1208d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 1209d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 1210d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 12111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1212e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // Get the decl for the concrete builtin from this, we can tell what the 1213e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // concrete integer type we should convert to is. 1214e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 1215e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 12162ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara FunctionDecl *NewBuiltinDecl; 12172ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara if (NewBuiltinID == BuiltinID) 12182ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara NewBuiltinDecl = FDecl; 12192ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara else { 12202ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara // Perform builtin lookup to avoid redeclaring it. 12212ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara DeclarationName DN(&Context.Idents.get(NewBuiltinName)); 12222ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara LookupResult Res(*this, DN, DRE->getLocStart(), LookupOrdinaryName); 12232ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara LookupName(Res, TUScope, /*AllowBuiltinCreation=*/true); 12242ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara assert(Res.getFoundDecl()); 12252ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara NewBuiltinDecl = dyn_cast<FunctionDecl>(Res.getFoundDecl()); 12262ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara if (NewBuiltinDecl == 0) 12272ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara return ExprError(); 12282ad11cd666f8e80463b5fd155072633f8e1283a4Abramo Bagnara } 1229d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 1230f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // The first argument --- the pointer --- has a fixed type; we 1231f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // deduce the types of the rest of the arguments accordingly. Walk 1232f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // the remaining arguments, converting them to the deduced value type. 12335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner for (unsigned i = 0; i != NumFixed; ++i) { 1234429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult Arg = TheCall->getArg(i+1); 12351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // GCC does an implicit conversion to the pointer or integer ValType. This 12375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // can fail in some cases (1i -> int**), check for this error case now. 1238b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Initialize the argument. 1239b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall InitializedEntity Entity = InitializedEntity::InitializeParameter(Context, 1240b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType, /*consume*/ false); 1241b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 1242429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (Arg.isInvalid()) 1243d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 12441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Okay, we have something that *can* be converted to the right type. Check 12465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // to see if there is a potentially weird extension going on here. This can 12475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // happen when you do an atomic operation on something like an char* and 12485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // pass in 42. The 42 gets converted to char. This is even more strange 12495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // for things like 45.123 -> char, etc. 12501eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // FIXME: Do this check. 1251b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall TheCall->setArg(i+1, Arg.take()); 12525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 12531eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1254bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor ASTContext& Context = this->getASTContext(); 1255bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor 1256bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor // Create a new DeclRefExpr to refer to the new decl. 1257bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DeclRefExpr* NewDRE = DeclRefExpr::Create( 1258bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor Context, 1259bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getQualifierLoc(), 1260e4b92761b43ced611c417ae478568610f1ad7b1eAbramo Bagnara SourceLocation(), 1261bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor NewBuiltinDecl, 1262f4b88a45902af1802a1cb42ba48b1c474474f228John McCall /*enclosing*/ false, 1263bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getLocation(), 1264a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman Context.BuiltinFnTy, 1265bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getValueKind()); 12661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12675caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Set the callee in the CallExpr. 1268a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman // FIXME: This loses syntactic information. 1269a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman QualType CalleePtrTy = Context.getPointerType(NewBuiltinDecl->getType()); 1270a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman ExprResult PromotedCall = ImpCastExprToType(NewDRE, CalleePtrTy, 1271a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman CK_BuiltinFnToFnPtr); 1272429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setCallee(PromotedCall.take()); 12731eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1274db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // Change the result type of the call to match the original value type. This 1275db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // is arbitrary, but the codegen for these builtins ins design to handle it 1276db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // gracefully. 12778d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth TheCall->setType(ResultType); 1278d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 12793fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return TheCallResult; 12805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner} 12815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 1282690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin 128371993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct 1284fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would 1285fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend). 1286690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) { 128756f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner Arg = Arg->IgnoreParenCasts(); 128871993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 128971993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 12905cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!Literal || !Literal->isAscii()) { 1291fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 1292fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << Arg->getSourceRange(); 12939cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return true; 129471993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson } 12951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12967da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Literal->containsNonAsciiOrNull()) { 12975f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef String = Literal->getString(); 12987da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian unsigned NumBytes = String.size(); 12995f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<UTF16, 128> ToBuf(NumBytes); 130031ba6135375433b617a8587ea6cc836a014ebd86Roman Divacky const UTF8 *FromPtr = (const UTF8 *)String.data(); 13017da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian UTF16 *ToPtr = &ToBuf[0]; 13027da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 13037da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 13047da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian &ToPtr, ToPtr + NumBytes, 13057da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian strictConversion); 13067da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian // Check for conversion failure. 13077da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Result != conversionOK) 13087da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian Diag(Arg->getLocStart(), 13097da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian diag::warn_cfstring_truncated) << Arg->getSourceRange(); 13107da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian } 13119cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return false; 131259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner} 131359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 1314c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 1315c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success. 1316925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 1317925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *Fn = TheCall->getCallee(); 1318925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) { 13192c21a073525cdfa68e4439b7af551385dc2796abChris Lattner Diag(TheCall->getArg(2)->getLocStart(), 1320fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1321ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1322ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << Fn->getSourceRange() 13231eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(2)->getLocStart(), 1324fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 132530ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 132630ce344307f8a8b00054021307015571f83c7364Chris Lattner } 132756f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 132856f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman if (TheCall->getNumArgs() < 2) { 1329d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher return Diag(TheCall->getLocEnd(), 1330d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 1331d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 133256f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman } 133356f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 13345f8d604246976a93a73549b07bbc8ee0b2061b50John McCall // Type-check the first argument normally. 13355f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (checkBuiltinArgument(*this, TheCall, 0)) 13365f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 13375f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 1338c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner // Determine whether the current function is variadic or not. 13399ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor BlockScopeInfo *CurBlock = getCurBlock(); 1340c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner bool isVariadic; 1341cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1342c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall isVariadic = CurBlock->TheDecl->isVariadic(); 13439498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else if (FunctionDecl *FD = getCurFunctionDecl()) 13449498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek isVariadic = FD->isVariadic(); 13459498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else 134653d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis isVariadic = getCurMethodDecl()->isVariadic(); 13471eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1348c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner if (!isVariadic) { 134930ce344307f8a8b00054021307015571f83c7364Chris Lattner Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 135030ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 135130ce344307f8a8b00054021307015571f83c7364Chris Lattner } 13521eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 135330ce344307f8a8b00054021307015571f83c7364Chris Lattner // Verify that the second argument to the builtin is the last argument of the 135430ce344307f8a8b00054021307015571f83c7364Chris Lattner // current function or method. 135530ce344307f8a8b00054021307015571f83c7364Chris Lattner bool SecondArgIsLastNamedArgument = false; 1356e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 13571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 135888cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 135988cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 136030ce344307f8a8b00054021307015571f83c7364Chris Lattner // FIXME: This isn't correct for methods (results in bogus warning). 136130ce344307f8a8b00054021307015571f83c7364Chris Lattner // Get the last formal in the current function. 136288cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson const ParmVarDecl *LastArg; 1363cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1364cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff LastArg = *(CurBlock->TheDecl->param_end()-1); 1365cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff else if (FunctionDecl *FD = getCurFunctionDecl()) 1366371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner LastArg = *(FD->param_end()-1); 136730ce344307f8a8b00054021307015571f83c7364Chris Lattner else 136853d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis LastArg = *(getCurMethodDecl()->param_end()-1); 136930ce344307f8a8b00054021307015571f83c7364Chris Lattner SecondArgIsLastNamedArgument = PV == LastArg; 137030ce344307f8a8b00054021307015571f83c7364Chris Lattner } 137130ce344307f8a8b00054021307015571f83c7364Chris Lattner } 13721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 137330ce344307f8a8b00054021307015571f83c7364Chris Lattner if (!SecondArgIsLastNamedArgument) 13741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(1)->getLocStart(), 137530ce344307f8a8b00054021307015571f83c7364Chris Lattner diag::warn_second_parameter_of_va_start_not_last_named_argument); 137630ce344307f8a8b00054021307015571f83c7364Chris Lattner return false; 13776cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman} 137830ce344307f8a8b00054021307015571f83c7364Chris Lattner 13791b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 13801b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends. This is declared to take (...), so we have to check everything. 1381925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 1382925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() < 2) 13832c21a073525cdfa68e4439b7af551385dc2796abChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1384d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << 2 << TheCall->getNumArgs()/*function call*/; 1385925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) 13861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(TheCall->getArg(2)->getLocStart(), 1387fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1388ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1389fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(TheCall->getArg(2)->getLocStart(), 1390fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 13911eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1392429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg0 = TheCall->getArg(0); 1393429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg1 = TheCall->getArg(1); 1394cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 13951b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // Do standard promotions between the two arguments, returning their common 13961b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // type. 1397925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 1398429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.isInvalid() || OrigArg1.isInvalid()) 1399429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return true; 1400403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar 1401403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // Make sure any conversions are pushed back into the call; this is 1402403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // type safe since unordered compare builtins are declared as "_Bool 1403403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // foo(...)". 1404429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(0, OrigArg0.get()); 1405429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(1, OrigArg1.get()); 14061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1407429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent()) 1408cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 1409cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 14101b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // If the common type isn't a real floating type, then the arguments were 14111b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // invalid for this operation. 1412860a319e62b0e256817a458396d191aa91c0787aEli Friedman if (Res.isNull() || !Res->isRealFloatingType()) 1413429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return Diag(OrigArg0.get()->getLocStart(), 1414fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_invalid_ordered_compare) 1415429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << OrigArg0.get()->getType() << OrigArg1.get()->getType() 1416429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd()); 14171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 14181b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner return false; 14191b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner} 14201b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner 1421e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 1422e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends. This is declared to take (...), so we have 14233b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point 14243b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value. 14253b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 14263b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() < NumArgs) 14279ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1428d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 14293b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() > NumArgs) 14303b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer return Diag(TheCall->getArg(NumArgs)->getLocStart(), 14319ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_too_many_args) 1432ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 14333b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 14349ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman (*(TheCall->arg_end()-1))->getLocEnd()); 14359ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 14363b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer Expr *OrigArg = TheCall->getArg(NumArgs-1); 14371eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 14389ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (OrigArg->isTypeDependent()) 14399ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 14409ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 144181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // This operation requires a non-_Complex floating-point number. 14429ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (!OrigArg->getType()->isRealFloatingType()) 14431eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg->getLocStart(), 14449ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_invalid_unary_fp) 14459ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman << OrigArg->getType() << OrigArg->getSourceRange(); 14461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 144781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // If this is an implicit conversion from float -> double, remove it. 144881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 144981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Expr *CastArg = Cast->getSubExpr(); 145081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 145181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 145281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner "promotion from float to double is the only expected cast here"); 145381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Cast->setSubExpr(0); 145481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner TheCall->setArg(NumArgs-1, CastArg); 145581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 145681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 145781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner 14589ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 14599ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman} 14609ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 1461d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 1462d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything. 146360d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 146437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() < 2) 14650eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocEnd(), 1466d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 146737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1468d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << TheCall->getSourceRange()); 1469d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 147037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Determine which of the following types of shufflevector we're checking: 147137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 1) unary, vector mask: (lhs, mask) 147237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 2) binary, vector mask: (lhs, rhs, mask) 147337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 147437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType resType = TheCall->getArg(0)->getType(); 147537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numElements = 0; 147637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 1477cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (!TheCall->getArg(0)->isTypeDependent() && 1478cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor !TheCall->getArg(1)->isTypeDependent()) { 147937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType LHSType = TheCall->getArg(0)->getType(); 148037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType RHSType = TheCall->getArg(1)->getType(); 148137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 148237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!LHSType->isVectorType() || !RHSType->isVectorType()) { 1483cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) 14841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1485cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1486cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 1487cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 148837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 148937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numElements = LHSType->getAs<VectorType>()->getNumElements(); 149037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numResElements = TheCall->getNumArgs() - 2; 149137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 149237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Check to see if we have a call with 2 vector arguments, the unary shuffle 149337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // with mask. If so, verify that RHS is an integer vector type with the 149437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // same number of elts as lhs. 149537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() == 2) { 1496f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (!RHSType->hasIntegerRepresentation() || 149737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman RHSType->getAs<VectorType>()->getNumElements() != numElements) 149837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 149937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << SourceRange(TheCall->getArg(1)->getLocStart(), 150037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman TheCall->getArg(1)->getLocEnd()); 150137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numResElements = numElements; 150237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } 150337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 1504cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 15051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1506cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1507cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 150837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } else if (numElements != numResElements) { 150937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 1510788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner resType = Context.getVectorType(eltType, numResElements, 1511e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson VectorType::GenericVector); 1512cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 1513d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1514d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1515d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 1516cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 1517cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(i)->isValueDependent()) 1518cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor continue; 1519cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 152037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman llvm::APSInt Result(32); 152137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 152237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman return ExprError(Diag(TheCall->getLocStart(), 152337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman diag::err_shufflevector_nonconstant_argument) 152437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << TheCall->getArg(i)->getSourceRange()); 15250eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 1526d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 15270eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocStart(), 1528fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_shufflevector_argument_too_large) 15290eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl << TheCall->getArg(i)->getSourceRange()); 1530d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1531d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 15325f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<Expr*, 32> exprs; 1533d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1534d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 1535d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman exprs.push_back(TheCall->getArg(i)); 1536d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman TheCall->setArg(i, 0); 1537d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1538d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 15393b6bef9a213249c6ab6d67c07b1ac6380961be3eBenjamin Kramer return Owned(new (Context) ShuffleVectorExpr(Context, exprs, resType, 15408189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getCallee()->getLocStart(), 15418189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getRParenLoc())); 1542d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman} 154330ce344307f8a8b00054021307015571f83c7364Chris Lattner 15444493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 15454493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two 15464493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args. 15474493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 1548fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner unsigned NumArgs = TheCall->getNumArgs(); 15494493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1550fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (NumArgs > 3) 1551ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher return Diag(TheCall->getLocEnd(), 1552ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher diag::err_typecheck_call_too_many_args_at_most) 1553ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 3 << NumArgs 1554ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << TheCall->getSourceRange(); 15554493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 15564493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // Argument 0 is checked for us and the remaining arguments must be 15574493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // constant integers. 1558fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner for (unsigned i = 1; i != NumArgs; ++i) { 15594493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar Expr *Arg = TheCall->getArg(i); 1560592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1561592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 1562592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (Arg->isTypeDependent() || Arg->isValueDependent()) 1563592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor continue; 1564592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 15659aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman llvm::APSInt Result; 1566691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, i, Result)) 1567691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 15681eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 15694493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // FIXME: gcc issues a warning and rewrites these to 0. These 15704493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // seems especially odd for the third argument since the default 15714493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // is 3. 1572fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (i == 1) { 15739aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 1) 1574fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 157521fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "1" << Arg->getSourceRange(); 15764493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } else { 15779aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 3) 1578fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 157921fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "3" << Arg->getSourceRange(); 15804493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 15814493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 15824493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1583fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return false; 15844493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar} 15854493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1586691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 1587691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression. 1588691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 1589691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt &Result) { 1590691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(ArgNum); 1591691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 1592691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 1593691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1594691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 1595691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1596691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (!Arg->isIntegerConstantExpr(Result, Context)) 1597691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 15985e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher << FDecl->getDeclName() << Arg->getSourceRange(); 1599691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 160021fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner return false; 160121fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner} 160221fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner 1603d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 1604d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined 1605d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3). 1606fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner// For compatibility check 0-3, llvm only handles 0 and 2. 1607d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 1608691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1609592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1610592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 1611592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (TheCall->getArg(1)->isTypeDependent() || 1612592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor TheCall->getArg(1)->isValueDependent()) 1613592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor return false; 1614592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1615691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // Check constant-ness first. 1616691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1617691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1618d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1619691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(1); 1620d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 1621fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 1622fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1623d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar } 1624d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1625d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar return false; 1626d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar} 1627d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1628586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 1629d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1. 1630d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 1631d875fed28578835de89cd407e9db4be788596d7cEli Friedman Expr *Arg = TheCall->getArg(1); 1632691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1633cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 1634691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // TODO: This is less than ideal. Overload this to take a value. 1635691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1636691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1637691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1638691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Result != 1) 1639d875fed28578835de89cd407e9db4be788596d7cEli Friedman return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 1640d875fed28578835de89cd407e9db4be788596d7cEli Friedman << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1641d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1642d875fed28578835de89cd407e9db4be788596d7cEli Friedman return false; 1643d875fed28578835de89cd407e9db4be788596d7cEli Friedman} 1644d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1645831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determine if an expression is a string literal or constant string. 1646831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// If this function returns false on the arguments to a function expecting a 1647831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// format string, we will usually need to emit a warning. 1648831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// True string literals are then checked by CheckFormatString. 1649831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithSema::StringLiteralCheckType 16501c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri GribenkoSema::checkFormatStringExpr(const Expr *E, ArrayRef<const Expr *> Args, 16511c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko bool HasVAListArg, 1652831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned format_idx, unsigned firstDataArg, 1653ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose FormatStringType Type, VariadicCallType CallType, 1654ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose bool inFunctionCall) { 16554fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain: 1656cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 1657831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1658d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 165934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas E = E->IgnoreParenCasts(); 1660f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 1661a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie if (E->isNullPointerConstant(Context, Expr::NPC_ValueDependentIsNotNull)) 1662a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // Technically -Wformat-nonliteral does not warn about this case. 1663a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // The behavior of printf and friends in this case is implementation 1664a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // dependent. Ideally if the format string cannot be null then 1665a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // it should have a 'nonnull' attribute in the function prototype. 1666831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_CheckedLiteral; 1667a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie 1668d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek switch (E->getStmtClass()) { 166956ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::BinaryConditionalOperatorClass: 1670d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ConditionalOperatorClass: { 1671831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // The expression is a literal if both sub-expressions were, and it was 1672831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // completely checked only if both sub-expressions were checked. 1673831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const AbstractConditionalOperator *C = 1674831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith cast<AbstractConditionalOperator>(E); 1675831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType Left = 16761c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkFormatStringExpr(C->getTrueExpr(), Args, 1677831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1678ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 1679831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (Left == SLCT_NotALiteral) 1680831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1681831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType Right = 16821c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkFormatStringExpr(C->getFalseExpr(), Args, 1683831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1684ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 1685831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Left < Right ? Left : Right; 1686d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1687d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1688d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ImplicitCastExprClass: { 16894fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ImplicitCastExpr>(E)->getSubExpr(); 16904fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 1691d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1692d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 169356ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::OpaqueValueExprClass: 169456ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) { 169556ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall E = src; 169656ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall goto tryAgain; 169756ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall } 1698831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 169956ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall 1700b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek case Stmt::PredefinedExprClass: 1701b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // While __func__, etc., are technically not string literals, they 1702b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // cannot contain format specifiers and thus are not a security 1703b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // liability. 1704831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_UncheckedLiteral; 1705b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek 1706082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::DeclRefExprClass: { 1707082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const DeclRefExpr *DR = cast<DeclRefExpr>(E); 17081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1709082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // As an exception, do not flag errors for variables binding to 1710082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // const string literals. 1711082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 1712082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool isConstant = false; 1713082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek QualType T = DR->getType(); 1714082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek 1715082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ArrayType *AT = Context.getAsArrayType(T)) { 1716082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek isConstant = AT->getElementType().isConstant(Context); 1717ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (const PointerType *PT = T->getAs<PointerType>()) { 17181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump isConstant = T.isConstant(Context) && 1719082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek PT->getPointeeType().isConstant(Context); 1720e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas } else if (T->isObjCObjectPointerType()) { 1721e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas // In ObjC, there is usually no "const ObjectPointer" type, 1722e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas // so don't check if the pointee type is constant. 1723e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas isConstant = T.isConstant(Context); 1724082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 17251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1726082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (isConstant) { 1727e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (const Expr *Init = VD->getAnyInitializer()) { 1728e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay // Look through initializers like const char c[] = { "foo" } 1729e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (const InitListExpr *InitList = dyn_cast<InitListExpr>(Init)) { 1730e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (InitList->isStringLiteralInit()) 1731e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay Init = InitList->getInit(0)->IgnoreParenImpCasts(); 1732e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay } 17331c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return checkFormatStringExpr(Init, Args, 1734831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, 1735ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, CallType, 1736831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*inFunctionCall*/false); 1737e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay } 1738082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 17391eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1740d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // For vprintf* functions (i.e., HasVAListArg==true), we add a 1741d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // special check to see if the format string is a function parameter 1742d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // of the function calling the printf function. If the function 1743d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // has an attribute indicating it is a printf-like function, then we 1744d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // should suppress warnings concerning non-literals being used in a call 1745d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // to a vprintf function. For example: 1746d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1747d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // void 1748d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 1749d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_list ap; 1750d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_start(ap, fmt); 1751d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 1752d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // ... 1753d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1754f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (HasVAListArg) { 1755f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(VD)) { 1756f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const NamedDecl *ND = dyn_cast<NamedDecl>(PV->getDeclContext())) { 1757f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas int PVIndex = PV->getFunctionScopeIndex() + 1; 1758f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas for (specific_attr_iterator<FormatAttr> 1759f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas i = ND->specific_attr_begin<FormatAttr>(), 1760f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas e = ND->specific_attr_end<FormatAttr>(); i != e ; ++i) { 1761f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas FormatAttr *PVFormat = *i; 1762f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // adjust for implicit parameter 1763f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 1764f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (MD->isInstance()) 1765f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas ++PVIndex; 1766f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // We also check if the formats are compatible. 1767f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // We can't pass a 'scanf' string to a 'printf' function. 1768f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (PVIndex == PVFormat->getFormatIdx() && 1769f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas Type == GetFormatStringType(PVFormat)) 1770831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_UncheckedLiteral; 1771f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1772f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1773f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1774f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1775082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 17761eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1777831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1778082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 1779d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 178052aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas case Stmt::CallExprClass: 178152aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas case Stmt::CXXMemberCallExprClass: { 17828f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const CallExpr *CE = cast<CallExpr>(E); 178352aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const NamedDecl *ND = dyn_cast_or_null<NamedDecl>(CE->getCalleeDecl())) { 178452aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) { 178552aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas unsigned ArgIndex = FA->getFormatIdx(); 178652aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 178752aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (MD->isInstance()) 178852aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas --ArgIndex; 178952aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas const Expr *Arg = CE->getArg(ArgIndex - 1); 179052aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas 17911c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return checkFormatStringExpr(Arg, Args, 1792831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1793ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 179450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(ND)) { 179550687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned BuiltinID = FD->getBuiltinID(); 179650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (BuiltinID == Builtin::BI__builtin___CFStringMakeConstantString || 179750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose BuiltinID == Builtin::BI__builtin___NSStringMakeConstantString) { 179850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose const Expr *Arg = CE->getArg(0); 17991c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return checkFormatStringExpr(Arg, Args, 1800831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, 1801ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, CallType, 1802ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall); 180350687314f87b67073c202fe46d84d12fb55e25cfJordan Rose } 18048f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 18058f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 18061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1807831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 18088f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 1809082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::ObjCStringLiteralClass: 1810082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::StringLiteralClass: { 1811082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const StringLiteral *StrE = NULL; 18121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1813082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 1814d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek StrE = ObjCFExpr->getString(); 1815d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek else 1816082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek StrE = cast<StringLiteral>(E); 18171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1818d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek if (StrE) { 18191c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko CheckFormatString(StrE, E, Args, HasVAListArg, format_idx, 1820ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, inFunctionCall, CallType); 1821831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_CheckedLiteral; 1822d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 18231eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1824831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1825d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 18261eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1827082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek default: 1828831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1829d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1830d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1831d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1832e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid 18331eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull, 1834909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr * const *ExprArgs, 1835909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky SourceLocation CallSiteLoc) { 1836cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt for (NonNullAttr::args_iterator i = NonNull->args_begin(), 1837cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt e = NonNull->args_end(); 1838e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian i != e; ++i) { 1839909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr *ArgExpr = ExprArgs[*i]; 18403edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky 18413edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky // As a special case, transparent unions initialized with zero are 18423edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky // considered null for the purposes of the nonnull attribute. 18433edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (const RecordType *UT = ArgExpr->getType()->getAsUnionType()) { 18443edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (UT->getDecl()->hasAttr<TransparentUnionAttr>()) 18453edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (const CompoundLiteralExpr *CLE = 18463edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky dyn_cast<CompoundLiteralExpr>(ArgExpr)) 18473edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (const InitListExpr *ILE = 18483edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky dyn_cast<InitListExpr>(CLE->getInitializer())) 18493edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky ArgExpr = ILE->getInit(0); 18503edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky } 18513edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky 18523edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky bool Result; 18533edf387e4338ff98d9874b4c1b41d787e49d6c2bNick Lewycky if (ArgExpr->EvaluateAsBooleanCondition(Result, Context) && !Result) 1854909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange(); 1855e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian } 1856e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian} 1857d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 185834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel DupasSema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) { 185934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas return llvm::StringSwitch<FormatStringType>(Format->getType()) 186034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("scanf", FST_Scanf) 186134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("printf", "printf0", FST_Printf) 186234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("NSString", "CFString", FST_NSString) 186334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("strftime", FST_Strftime) 186434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("strfmon", FST_Strfmon) 186534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf) 186634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Default(FST_Unknown); 186734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas} 186834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas 1869ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose/// CheckFormatArguments - Check calls to printf and scanf (and similar 1870826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings. 1871831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true if a format string has been fully checked. 18721c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkobool Sema::CheckFormatArguments(const FormatAttr *Format, 18731c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 18741c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko bool IsCXXMember, 1875ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose VariadicCallType CallType, 187629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas SourceLocation Loc, SourceRange Range) { 1877831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FormatStringInfo FSI; 1878831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (getFormatStringInfo(Format, IsCXXMember, &FSI)) 18791c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko return CheckFormatArguments(Args, FSI.HasVAListArg, FSI.FormatIdx, 1880831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI.FirstDataArg, GetFormatStringType(Format), 1881ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose CallType, Loc, Range); 1882831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 188329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 18844a2614e94672c47395abcde60518776fbebec589Sebastian Redl 18851c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenkobool Sema::CheckFormatArguments(ArrayRef<const Expr *> Args, 188634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas bool HasVAListArg, unsigned format_idx, 188734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg, FormatStringType Type, 1888ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose VariadicCallType CallType, 188934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas SourceLocation Loc, SourceRange Range) { 1890826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // CHECK: printf/scanf-like function is called with no format string. 18911c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko if (format_idx >= Args.size()) { 189229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Loc, diag::warn_missing_format_string) << Range; 1893831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 189471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek } 18951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 189629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts(); 18971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 189859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner // CHECK: format string is not a string literal. 18991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // 190071895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // Dynamically generated format strings are difficult to 190171895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // automatically vet at compile time. Requiring that format strings 190271895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // are string literals: (1) permits the checking of format strings by 190371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // the compiler and thereby (2) can practically remove the source of 190471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // many format string exploits. 19057ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek 19061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // Format string can be either ObjC string (e.g. @"%d") or 19077ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // C string (e.g. "%d") 19081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // ObjC string uses the same format specifiers as C string, so we can use 19097ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // the same format string checking logic for both ObjC and C strings. 1910831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType CT = 19111c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko checkFormatStringExpr(OrigFormatExpr, Args, HasVAListArg, 1912ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose format_idx, firstDataArg, Type, CallType); 1913831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (CT != SLCT_NotALiteral) 1914831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // Literal format string found, check done! 1915831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return CT == SLCT_CheckedLiteral; 19161cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner 19172837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas // Strftime is particular as it always uses a single 'time' argument, 19182837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas // so it is safe to pass a non-literal string. 19192837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas if (Type == FST_Strftime) 1920831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 19212837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas 1922ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // Do not emit diag when the string param is a macro expansion and the 1923ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // format is either NSString or CFString. This is a hack to prevent 1924ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // diag when using the NSLocalizedString and CFCopyLocalizedString macros 1925ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // which are usually used in place of NS and CF string literals. 1926dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas if (Type == FST_NSString && 1927dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas SourceMgr.isInSystemMacro(Args[format_idx]->getLocStart())) 1928831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 1929ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas 1930655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // If there are no arguments specified, warn with -Wformat-security, otherwise 1931655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // warn only with -Wformat-nonliteral. 19321c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko if (Args.size() == format_idx+1) 193329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Args[format_idx]->getLocStart(), 1934826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral_noargs) 1935655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1936655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner else 193729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Args[format_idx]->getLocStart(), 1938826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral) 1939655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1940831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 1941d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1942d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1943e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace { 1944826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler { 1945826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1946e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Sema &S; 1947e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const StringLiteral *FExpr; 1948e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const Expr *OrigFormatExpr; 19496ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const unsigned FirstDataArg; 1950e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const unsigned NumDataArgs; 1951e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *Beg; // Start of format string. 19520d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const bool HasVAListArg; 19531c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args; 19540d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek unsigned FormatIdx; 19557f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek llvm::BitVector CoveredArgs; 1956efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool usesPositionalArgs; 1957efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool atFirstArg; 195855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool inFunctionCall; 1959ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType; 19604e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic: 1961826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 19626ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 196350687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, const char *beg, bool hasVAListArg, 19641c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 1965ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 1966ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType callType) 1967e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 196850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose FirstDataArg(firstDataArg), NumDataArgs(numDataArgs), 196950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose Beg(beg), HasVAListArg(hasVAListArg), 19701c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Args(Args), FormatIdx(formatIdx), 197155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu usesPositionalArgs(false), atFirstArg(true), 1972ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall(inFunctionCall), CallType(callType) { 19737f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.resize(numDataArgs); 19747f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.reset(); 19757f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 19764e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 197707d161f38e708a91486bf1c031d525faebbb249dTed Kremenek void DoneProcessing(); 19784e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1979826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIncompleteSpecifier(const char *startSpecifier, 1980826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 198176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 1982bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose void HandleInvalidLengthModifier( 1983bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::FormatSpecifier &FS, 1984bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::ConversionSpecifier &CS, 19858be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const char *startSpecifier, unsigned specifierLen, unsigned DiagID); 1986bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 198776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg void HandleNonStandardLengthModifier( 19888be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const analyze_format_string::FormatSpecifier &FS, 198976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen); 199076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 199176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg void HandleNonStandardConversionSpecifier( 199276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 199376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen); 199476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 1995f85626453123f9691bcef13cff963f556e209c27Hans Wennborg virtual void HandlePosition(const char *startPos, unsigned posLen); 1996f85626453123f9691bcef13cff963f556e209c27Hans Wennborg 1997efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleInvalidPosition(const char *startSpecifier, 1998efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned specifierLen, 1999826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p); 2000efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2001efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 2002efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2003e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek void HandleNullChar(const char *nullCharacter); 20044e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 200555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 200655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu static void EmitFormatDiagnostic(Sema &S, bool inFunctionCall, 200755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 200855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 200955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation StringLoc, 201055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 20115543169296beeb183b9c9392debc774fcf493eebDmitri Gribenko ArrayRef<FixItHint> Fixit = None); 201255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2013826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 2014c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 2015c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 2016c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 2017c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, unsigned csLen); 201855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 201955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void HandlePositionalNonpositionalArgs(SourceLocation Loc, 202055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 202155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen); 2022c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2023f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek SourceRange getFormatStringRange(); 2024826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CharSourceRange getSpecifierRange(const char *startSpecifier, 2025826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2026e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek SourceLocation getLocationOfByte(const char *x); 20274e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 20280d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const Expr *getDataArg(unsigned i) const; 2029666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 2030666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 2031666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 2032666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, 2033666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek unsigned argIndex); 203455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 203555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 203655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc, 203755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 20385543169296beeb183b9c9392debc774fcf493eebDmitri Gribenko ArrayRef<FixItHint> Fixit = None); 203955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 204055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void CheckPositionalAndNonpositionalArgs( 204155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const analyze_format_string::FormatSpecifier *FS); 2042e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}; 2043e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2044e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2045826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() { 2046e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return OrigFormatExpr->getSourceRange(); 2047e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2048e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2049826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler:: 2050826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 205145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation Start = getLocationOfByte(startSpecifier); 205245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 205345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 205445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care // Advance the end SourceLocation by one due to half-open ranges. 2055a64ccefdf0ea4e03ec88805d71b0af74950c7472Argyrios Kyrtzidis End = End.getLocWithOffset(1); 205645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 205745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care return CharSourceRange::getCharRange(Start, End); 2058f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek} 2059f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek 2060826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 20614e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 2062e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2063e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2064826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 2065826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen){ 206655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier), 206755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startSpecifier), 206855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 206955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 2070808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek} 2071808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek 2072bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rosevoid CheckFormatHandler::HandleInvalidLengthModifier( 2073bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::FormatSpecifier &FS, 2074bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::ConversionSpecifier &CS, 20758be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const char *startSpecifier, unsigned specifierLen, unsigned DiagID) { 2076bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose using namespace analyze_format_string; 2077bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2078bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const LengthModifier &LM = FS.getLengthModifier(); 2079bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength()); 2080bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2081bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose // See if we know how to fix this length modifier. 2082dc84cd5efdd3430efb22546b4ac656aa0540b210David Blaikie Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier(); 2083bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (FixedLM) { 20848be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(), 2085bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getLocationOfByte(LM.getStart()), 2086bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose /*IsStringLocation*/true, 2087bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 2088bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2089bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier) 2090bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose << FixedLM->toString() 2091bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose << FixItHint::CreateReplacement(LMRange, FixedLM->toString()); 2092bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2093bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose } else { 20948be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose FixItHint Hint; 20958be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose if (DiagID == diag::warn_format_nonsensical_length) 20968be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose Hint = FixItHint::CreateRemoval(LMRange); 20978be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 20988be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(), 2099bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getLocationOfByte(LM.getStart()), 2100bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose /*IsStringLocation*/true, 2101bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getSpecifierRange(startSpecifier, specifierLen), 21028be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose Hint); 2103bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose } 2104bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose} 2105bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 210676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardLengthModifier( 21078be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const analyze_format_string::FormatSpecifier &FS, 210876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen) { 21098be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose using namespace analyze_format_string; 21108be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 21118be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const LengthModifier &LM = FS.getLengthModifier(); 21128be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength()); 21138be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 21148be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose // See if we know how to fix this length modifier. 2115dc84cd5efdd3430efb22546b4ac656aa0540b210David Blaikie Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier(); 21168be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose if (FixedLM) { 21178be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 21188be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << LM.toString() << 0, 21198be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getLocationOfByte(LM.getStart()), 21208be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose /*IsStringLocation*/true, 21218be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 21228be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 21238be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier) 21248be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << FixedLM->toString() 21258be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << FixItHint::CreateReplacement(LMRange, FixedLM->toString()); 21268be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 21278be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose } else { 21288be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 21298be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << LM.toString() << 0, 21308be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getLocationOfByte(LM.getStart()), 21318be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose /*IsStringLocation*/true, 21328be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 21338be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose } 213476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg} 213576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 213676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardConversionSpecifier( 213776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 213876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen) { 2139670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose using namespace analyze_format_string; 2140670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose 2141670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose // See if we know how to fix this conversion specifier. 2142dc84cd5efdd3430efb22546b4ac656aa0540b210David Blaikie Optional<ConversionSpecifier> FixedCS = CS.getStandardSpecifier(); 2143670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose if (FixedCS) { 2144670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 2145670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << CS.toString() << /*conversion specifier*/1, 2146670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getLocationOfByte(CS.getStart()), 2147670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose /*IsStringLocation*/true, 2148670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 2149670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose 2150670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose CharSourceRange CSRange = getSpecifierRange(CS.getStart(), CS.getLength()); 2151670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose S.Diag(getLocationOfByte(CS.getStart()), diag::note_format_fix_specifier) 2152670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << FixedCS->toString() 2153670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << FixItHint::CreateReplacement(CSRange, FixedCS->toString()); 2154670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose } else { 2155670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 2156670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << CS.toString() << /*conversion specifier*/1, 2157670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getLocationOfByte(CS.getStart()), 2158670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose /*IsStringLocation*/true, 2159670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 2160670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose } 216176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg} 216276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 2163f85626453123f9691bcef13cff963f556e209c27Hans Wennborgvoid CheckFormatHandler::HandlePosition(const char *startPos, 2164f85626453123f9691bcef13cff963f556e209c27Hans Wennborg unsigned posLen) { 2165f85626453123f9691bcef13cff963f556e209c27Hans Wennborg EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_positional_arg), 2166f85626453123f9691bcef13cff963f556e209c27Hans Wennborg getLocationOfByte(startPos), 2167f85626453123f9691bcef13cff963f556e209c27Hans Wennborg /*IsStringLocation*/true, 2168f85626453123f9691bcef13cff963f556e209c27Hans Wennborg getSpecifierRange(startPos, posLen)); 2169f85626453123f9691bcef13cff963f556e209c27Hans Wennborg} 2170f85626453123f9691bcef13cff963f556e209c27Hans Wennborg 2171efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid 2172826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 2173826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p) { 217455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier) 217555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (unsigned) p, 217655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), /*IsStringLocation*/true, 217755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 2178efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 2179efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2180826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos, 2181efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned posLen) { 218255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier), 218355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), 218455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 218555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 2186efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 2187efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2188826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 218950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (!isa<ObjCStringLiteral>(OrigFormatExpr)) { 21900c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek // The presence of a null character is likely an error. 219155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 219255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_format_string_contains_null_char), 219355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(nullCharacter), /*IsStringLocation*/true, 219455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getFormatStringRange()); 21950c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek } 2196826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2197826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 219848716663e421472cbd590af160a372bc490205e8Jordan Rose// Note that this may return NULL if there was an error parsing or building 219948716663e421472cbd590af160a372bc490205e8Jordan Rose// one of the argument expressions. 2200826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const { 220129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return Args[FirstDataArg + i]; 2202826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 22034e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2204826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() { 2205826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Does the number of data arguments exceed the number of 2206826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // format conversions in the format string? 2207826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!HasVAListArg) { 2208826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Find any arguments that weren't covered. 2209826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.flip(); 2210826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek signed notCoveredArg = CoveredArgs.find_first(); 2211826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (notCoveredArg >= 0) { 2212826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek assert((unsigned)notCoveredArg < NumDataArgs); 221348716663e421472cbd590af160a372bc490205e8Jordan Rose if (const Expr *E = getDataArg((unsigned) notCoveredArg)) { 221448716663e421472cbd590af160a372bc490205e8Jordan Rose SourceLocation Loc = E->getLocStart(); 221548716663e421472cbd590af160a372bc490205e8Jordan Rose if (!S.getSourceManager().isInSystemMacro(Loc)) { 221648716663e421472cbd590af160a372bc490205e8Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_printf_data_arg_not_used), 221748716663e421472cbd590af160a372bc490205e8Jordan Rose Loc, /*IsStringLocation*/false, 221848716663e421472cbd590af160a372bc490205e8Jordan Rose getFormatStringRange()); 221948716663e421472cbd590af160a372bc490205e8Jordan Rose } 2220c03f2df2a2b097bf2686bf32411d5022323988b2Bob Wilson } 2221826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2222826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2223826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2224826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2225c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool 2226c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 2227c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek SourceLocation Loc, 2228c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 2229c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 2230c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, 2231c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned csLen) { 2232c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2233c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool keepGoing = true; 2234c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek if (argIndex < NumDataArgs) { 2235c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // Consider the argument coverered, even though the specifier doesn't 2236c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // make sense. 2237c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CoveredArgs.set(argIndex); 2238c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 2239c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek else { 2240c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // If argIndex exceeds the number of data arguments we 2241c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // don't issue a warning because that is just a cascade of warnings (and 2242c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // they may have intended '%%' anyway). We don't want to continue processing 2243c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // the format string after this point, however, as we will like just get 2244c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // gibberish when trying to match arguments. 2245c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek keepGoing = false; 2246c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 2247c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 224855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_conversion) 224955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << StringRef(csStart, csLen), 225055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*IsStringLocation*/true, 225155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpec, specifierLen)); 2252c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2253c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return keepGoing; 2254c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 2255c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 225655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid 225755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard TrieuCheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc, 225855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 225955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen) { 226055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 226155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_format_mix_positional_nonpositional_args), 226255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen)); 226355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 226455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2265666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool 2266666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs( 2267666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::FormatSpecifier &FS, 2268666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 2269666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 2270666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 2271666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (argIndex >= NumDataArgs) { 227255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag = FS.usesPositionalArg() 227355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args) 227455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (argIndex+1) << NumDataArgs) 227555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : S.PDiag(diag::warn_printf_insufficient_data_args); 227655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 227755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true, 227855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 2279666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return false; 2280666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 2281666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return true; 2282666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek} 2283666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 228455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 228555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag, 228655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 228755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 228855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 2289ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose ArrayRef<FixItHint> FixIt) { 229029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag, 229155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, IsStringLocation, StringRange, FixIt); 229255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 229355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 229455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \brief If the format string is not within the funcion call, emit a note 229555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// so that the function call and string are in diagnostic messages. 229655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 229770517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param InFunctionCall if true, the format string is within the function 229855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// call and only one diagnostic message will be produced. Otherwise, an 229955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// extra note will be emitted pointing to location of the format string. 230055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 230155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param ArgumentExpr the expression that is passed as the format string 230255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// argument in the function call. Used for getting locations when two 230355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostics are emitted. 230455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 230555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param PDiag the callee should already have provided any strings for the 230655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostic message. This function only adds locations and fixits 230755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// to diagnostics. 230855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 230955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param Loc primary location for diagnostic. If two diagnostics are 231055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// required, one will be at Loc and a new SourceLocation will be created for 231155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// the other one. 231255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 231355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param IsStringLocation if true, Loc points to the format string should be 231455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// used for the note. Otherwise, Loc points to the argument list and will 231555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// be used with PDiag. 231655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 231755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param StringRange some or all of the string to highlight. This is 231855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// templated so it can accept either a CharSourceRange or a SourceRange. 231955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 232070517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param FixIt optional fix it hint for the format string. 232155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 232255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(Sema &S, bool InFunctionCall, 232355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 232455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 232555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 232655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 232755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 2328ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose ArrayRef<FixItHint> FixIt) { 2329ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (InFunctionCall) { 2330ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Sema::SemaDiagnosticBuilder &D = S.Diag(Loc, PDiag); 2331ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose D << StringRange; 2332ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end(); 2333ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose I != E; ++I) { 2334ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose D << *I; 2335ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2336ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else { 233755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag) 233855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ArgumentExpr->getSourceRange(); 2339ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2340ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Sema::SemaDiagnosticBuilder &Note = 2341ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose S.Diag(IsStringLocation ? Loc : StringRange.getBegin(), 2342ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose diag::note_format_string_defined); 2343ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2344ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Note << StringRange; 2345ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end(); 2346ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose I != E; ++I) { 2347ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Note << *I; 2348ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 234955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu } 235055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 235155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2352826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===// 2353826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2354826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 2355826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler { 235650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose bool ObjCContext; 2357826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 2358826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 2359826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 236050687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, bool isObjC, 2361826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 23621c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 2363ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 2364ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType) 2365826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 23661c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko numDataArgs, beg, hasVAListArg, Args, 2367ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose formatIdx, inFunctionCall, CallType), ObjCContext(isObjC) 2368ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose {} 2369ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose 2370826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2371826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleInvalidPrintfConversionSpecifier( 2372826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2373826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2374826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2375826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2376826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 2377826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2378826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2379831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool checkFormatExpr(const analyze_printf::PrintfSpecifier &FS, 2380831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const char *StartSpecifier, 2381831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned SpecifierLen, 2382831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E); 2383831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2384826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 2385826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2386826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 2387826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalAmount &Amt, 2388826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned type, 2389826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2390826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 2391826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 2392826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2393826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 2394826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &ignoredFlag, 2395826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 2396826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2397f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg bool checkForCStrMembers(const analyze_printf::ArgType &AT, 2398831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E, const CharSourceRange &CSR); 2399831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2400826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 2401826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2402826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2403826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 2404826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2405826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2406826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 24076ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 2408c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 2409826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2410c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 2411c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 2412c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 2413c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 241426ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek} 241526ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek 2416826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount( 2417826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_format_string::OptionalAmount &Amt, 2418826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned k, const char *startSpecifier, 2419826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 24200d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 24210d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (Amt.hasDataArgument()) { 24220d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (!HasVAListArg) { 24237f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = Amt.getArgIndex(); 24247f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (argIndex >= NumDataArgs) { 242555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg) 242655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << k, 242755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 242855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 242955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 24300d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 24310d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 24320d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 24330d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 24344e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 24350d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Type check the data argument. It should be an 'int'. 243631f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // Although not in conformance with C99, we also allow the argument to be 243731f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // an 'unsigned int' as that is a reasonably safe case. GCC also 243831f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // doesn't emit a warning for that case. 24397f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.set(argIndex); 24407f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek const Expr *Arg = getDataArg(argIndex); 244148716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Arg) 244248716663e421472cbd590af160a372bc490205e8Jordan Rose return false; 244348716663e421472cbd590af160a372bc490205e8Jordan Rose 24440d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek QualType T = Arg->getType(); 24454e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2446f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT = Amt.getArgType(S.Context); 2447f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg assert(AT.isValid()); 24484e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2449f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg if (!AT.matchesType(S.Context, T)) { 245055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type) 2451f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg << k << AT.getRepresentativeTypeName(S.Context) 245255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << T << Arg->getSourceRange(), 245355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 245455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 245555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 24560d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 24570d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 24580d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 24590d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 24600d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 24610d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 24620d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return true; 24630d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek} 24640d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 2465e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount( 2466826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2467e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalAmount &Amt, 2468e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned type, 2469e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2470e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 24716ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 24726ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 2473e4ee9663168dfb2b4122c768091e30217328c9faTom Care 247455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint fixit = 247555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant 247655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 247755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getConstantLength())) 247855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : FixItHint(); 247955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 248055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount) 248155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << type << CS.toString(), 248255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 248355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 248455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 248555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu fixit); 2486e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2487e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2488826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 2489e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 2490e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2491e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 2492e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about pointless flag with a fixit removal. 24936ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 24946ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 249555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag) 249655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << flag.toString() << CS.toString(), 249755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(flag.getPosition()), 249855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 249955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 250055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 250155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(flag.getPosition(), 1))); 2502e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2503e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2504e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag( 2505826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2506e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &ignoredFlag, 2507e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 2508e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2509e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 2510e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about ignored flag with a fixit removal. 251155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag) 251255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ignoredFlag.toString() << flag.toString(), 251355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(ignoredFlag.getPosition()), 251455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 251555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 251655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 251755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(ignoredFlag.getPosition(), 1))); 2518e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2519e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2520831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determines if the specified is a C++ class or struct containing 2521831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// a member with the specified name and kind (e.g. a CXXMethodDecl named 2522831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// "c_str()"). 2523831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithtemplate<typename MemberKind> 2524831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithstatic llvm::SmallPtrSet<MemberKind*, 1> 2525831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCXXRecordMembersNamed(StringRef Name, Sema &S, QualType Ty) { 2526831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const RecordType *RT = Ty->getAs<RecordType>(); 2527831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith llvm::SmallPtrSet<MemberKind*, 1> Results; 2528831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2529831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!RT) 2530831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2531831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl()); 2532831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!RD) 2533831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2534831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2535831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith LookupResult R(S, &S.PP.getIdentifierTable().get(Name), SourceLocation(), 2536831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Sema::LookupMemberName); 2537831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2538831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // We just need to include all members of the right kind turned up by the 2539831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // filter, at this point. 2540831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (S.LookupQualifiedName(R, RT->getDecl())) 2541831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith for (LookupResult::iterator I = R.begin(), E = R.end(); I != E; ++I) { 2542831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith NamedDecl *decl = (*I)->getUnderlyingDecl(); 2543831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (MemberKind *FK = dyn_cast<MemberKind>(decl)) 2544831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Results.insert(FK); 2545831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2546831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2547831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2548831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2549831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Check if a (w)string was passed when a (w)char* was needed, and offer a 2550f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg// better diagnostic if so. AT is assumed to be valid. 2551831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Returns true when a c_str() conversion method is found. 2552831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool CheckPrintfHandler::checkForCStrMembers( 2553f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT, const Expr *E, 2554831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CharSourceRange &CSR) { 2555831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith typedef llvm::SmallPtrSet<CXXMethodDecl*, 1> MethodSet; 2556831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2557831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith MethodSet Results = 2558831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith CXXRecordMembersNamed<CXXMethodDecl>("c_str", S, E->getType()); 2559831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2560831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith for (MethodSet::iterator MI = Results.begin(), ME = Results.end(); 2561831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith MI != ME; ++MI) { 2562831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CXXMethodDecl *Method = *MI; 2563831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (Method->getNumParams() == 0 && 2564f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg AT.matchesType(S.Context, Method->getResultType())) { 2565831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // FIXME: Suggest parens if the expression needs them. 2566831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation EndLoc = 2567831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()); 2568831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith S.Diag(E->getLocStart(), diag::note_printf_c_str) 2569831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << "c_str()" 2570831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << FixItHint::CreateInsertion(EndLoc, ".c_str()"); 2571831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return true; 2572831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2573831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2574831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2575831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 2576831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2577831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2578e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool 2579826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 25805c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek &FS, 2581e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *startSpecifier, 2582e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned specifierLen) { 2583e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 25846ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek using namespace analyze_format_string; 2585efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek using namespace analyze_printf; 25866ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 2587e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2588baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 2589baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 2590baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 2591baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 2592baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2593baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 259455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 259555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 2596baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 2597baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2598efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek } 2599efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 26000d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // First check if the field width, precision, and conversion specifier 26010d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // have matching data arguments. 2602efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 2603efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 26040d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 26050d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 26064e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2607efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 2608efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 26090d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 26100d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 26110d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 2612f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek if (!CS.consumesDataArgument()) { 2613f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // FIXME: Technically specifying a precision or field width here 2614f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // makes no sense. Worth issuing a warning at some point. 26150e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek return true; 2616f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek } 26174e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 26187f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Consume the argument. 26197f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = FS.getArgIndex(); 2620e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek if (argIndex < NumDataArgs) { 2621e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // The check to see if the argIndex is valid will come later. 2622e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // We set the bit here because we may exit early from this 2623e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // function if we encounter some other error. 2624e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek CoveredArgs.set(argIndex); 2625e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek } 26267f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek 26277f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Check for using an Objective-C specific conversion specifier 26287f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // in a non-ObjC literal. 262950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (!ObjCContext && CS.isObjCArg()) { 2630826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 2631826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek specifierLen); 26327f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 26334e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2634e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of field width 2635e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidFieldWidth()) { 263645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 2637e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2638e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2639e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2640e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of precision 2641e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPrecision()) { 2642e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 2643e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2644e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2645e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2646e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check each flag does not conflict with any other component. 264765197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek if (!FS.hasValidThousandsGroupingPrefix()) 264865197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen); 2649e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeadingZeros()) 2650e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 2651e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPlusPrefix()) 2652e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 265345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (!FS.hasValidSpacePrefix()) 265445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 2655e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidAlternativeForm()) 2656e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 2657e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeftJustified()) 2658e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 2659e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2660e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check that flags are not ignored by another flag 266145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 266245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 266345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care startSpecifier, specifierLen); 2664e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 2665e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 2666e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2667e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2668e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check the length modifier is valid with the given conversion specifier. 2669bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo())) 26708be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 26718be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_nonsensical_length); 2672bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthModifier()) 26738be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen); 2674bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthConversionCombination()) 26758be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 26768be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_non_standard_conversion_spec); 2677e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2678bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 2679bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 2680bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2681da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek // The remaining checks depend on the data arguments. 2682da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek if (HasVAListArg) 2683da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return true; 26844e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2685666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 2686da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return false; 26874e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 268848716663e421472cbd590af160a372bc490205e8Jordan Rose const Expr *Arg = getDataArg(argIndex); 268948716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Arg) 269048716663e421472cbd590af160a372bc490205e8Jordan Rose return true; 269148716663e421472cbd590af160a372bc490205e8Jordan Rose 269248716663e421472cbd590af160a372bc490205e8Jordan Rose return checkFormatExpr(FS, startSpecifier, specifierLen, Arg); 2693831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2694831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2695ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rosestatic bool requiresParensToAddCast(const Expr *E) { 2696ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // FIXME: We should have a general way to reason about operator 2697ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // precedence and whether parens are actually needed here. 2698ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Take care of a few common cases where they aren't. 2699ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Expr *Inside = E->IgnoreImpCasts(); 2700ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (const PseudoObjectExpr *POE = dyn_cast<PseudoObjectExpr>(Inside)) 2701ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Inside = POE->getSyntacticForm()->IgnoreImpCasts(); 2702ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2703ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose switch (Inside->getStmtClass()) { 2704ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ArraySubscriptExprClass: 2705ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::CallExprClass: 270617ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::CharacterLiteralClass: 270717ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::CXXBoolLiteralExprClass: 2708ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::DeclRefExprClass: 270917ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::FloatingLiteralClass: 271017ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::IntegerLiteralClass: 2711ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::MemberExprClass: 271217ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCArrayLiteralClass: 271317ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCBoolLiteralExprClass: 271417ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCBoxedExprClass: 271517ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCDictionaryLiteralClass: 271617ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCEncodeExprClass: 2717ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCIvarRefExprClass: 2718ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCMessageExprClass: 2719ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCPropertyRefExprClass: 272017ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCStringLiteralClass: 272117ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::ObjCSubscriptRefExprClass: 2722ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ParenExprClass: 272317ddc54b8b94c58286dec6f99ae1f9e12e30d297Jordan Rose case Stmt::StringLiteralClass: 2724ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::UnaryOperatorClass: 2725ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose return false; 2726ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose default: 2727ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose return true; 2728ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2729ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose} 2730ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2731831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool 2732831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCheckPrintfHandler::checkFormatExpr(const analyze_printf::PrintfSpecifier &FS, 2733831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const char *StartSpecifier, 2734831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned SpecifierLen, 2735831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E) { 2736831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith using namespace analyze_format_string; 2737831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith using namespace analyze_printf; 273896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Now type check the data expression that matches the 273996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // format specifier. 2740f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT = FS.getArgType(S.Context, 2741f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg ObjCContext); 2742614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (!AT.isValid()) 2743614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 2744ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2745448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose QualType ExprTy = E->getType(); 274602be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek while (const TypeOfExprType *TET = dyn_cast<TypeOfExprType>(ExprTy)) { 274702be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek ExprTy = TET->getUnderlyingExpr()->getType(); 274802be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek } 274902be968a08184acd42aaefa6f9a7dc883a4d1937Ted Kremenek 2750448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (AT.matchesType(S.Context, ExprTy)) 2751614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 2752614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 2753614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Look through argument promotions for our error message's reported type. 2754614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // This includes the integral and floating promotions, but excludes array 2755614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // and function pointer decay; seeing that an argument intended to be a 2756614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // string has type 'char [6]' is probably more confusing than 'char *'. 2757614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 2758614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (ICE->getCastKind() == CK_IntegralCast || 2759614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose ICE->getCastKind() == CK_FloatingCast) { 2760614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E = ICE->getSubExpr(); 2761448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose ExprTy = E->getType(); 2762614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 2763614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Check if we didn't match because of an implicit cast from a 'char' 2764614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // or 'short' to an 'int'. This is done because printf is a varargs 2765614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // function. 2766614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (ICE->getType() == S.Context.IntTy || 2767614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose ICE->getType() == S.Context.UnsignedIntTy) { 2768614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // All further checking is done on the subexpression. 2769448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (AT.matchesType(S.Context, ExprTy)) 2770614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 27714d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek } 2772ee0259d308e72141982a85b40863e760a8447edfJordan Rose } 2773448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose } else if (const CharacterLiteral *CL = dyn_cast<CharacterLiteral>(E)) { 2774448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose // Special case for 'a', which has type 'int' in C. 2775448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose // Note, however, that we do /not/ want to treat multibyte constants like 2776448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose // 'MooV' as characters! This form is deprecated but still exists. 2777448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (ExprTy == S.Context.IntTy) 2778448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (llvm::isUIntN(S.Context.getCharWidth(), CL->getValue())) 2779448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose ExprTy = S.Context.CharTy; 2780614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } 2781614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 27822cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // %C in an Objective-C context prints a unichar, not a wchar_t. 27832cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // If the argument is an integer of some kind, believe the %C and suggest 27842cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // a cast instead of changing the conversion specifier. 2785448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose QualType IntendedTy = ExprTy; 27862cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (ObjCContext && 27872cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose FS.getConversionSpecifier().getKind() == ConversionSpecifier::CArg) { 27882cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (ExprTy->isIntegralOrUnscopedEnumerationType() && 27892cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose !ExprTy->isCharType()) { 27902cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // 'unichar' is defined as a typedef of unsigned short, but we should 27912cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // prefer using the typedef if it is visible. 27922cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose IntendedTy = S.Context.UnsignedShortTy; 27932cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 27942cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose LookupResult Result(S, &S.Context.Idents.get("unichar"), E->getLocStart(), 27952cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose Sema::LookupOrdinaryName); 27962cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (S.LookupName(Result, S.getCurScope())) { 27972cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose NamedDecl *ND = Result.getFoundDecl(); 27982cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (TypedefNameDecl *TD = dyn_cast<TypedefNameDecl>(ND)) 27992cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (TD->getUnderlyingType() == IntendedTy) 28002cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose IntendedTy = S.Context.getTypedefType(TD); 28012cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 28022cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 28032cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 28042cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 28052cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // Special-case some of Darwin's platform-independence types by suggesting 28062cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // casts to primitive types that are known to be large enough. 28072cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose bool ShouldNotPrintDirectly = false; 2808ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (S.Context.getTargetInfo().getTriple().isOSDarwin()) { 28096edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek // Use a 'while' to peel off layers of typedefs. 28106edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek QualType TyTy = IntendedTy; 28116edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek while (const TypedefType *UserTy = TyTy->getAs<TypedefType>()) { 2812ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose StringRef Name = UserTy->getDecl()->getName(); 28132cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose QualType CastTy = llvm::StringSwitch<QualType>(Name) 2814ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("NSInteger", S.Context.LongTy) 2815ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("NSUInteger", S.Context.UnsignedLongTy) 2816ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("SInt32", S.Context.IntTy) 2817ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("UInt32", S.Context.UnsignedIntTy) 28182cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose .Default(QualType()); 28192cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 28202cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (!CastTy.isNull()) { 28212cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose ShouldNotPrintDirectly = true; 28222cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose IntendedTy = CastTy; 28236edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek break; 28242cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 28256edb029026d290f12393ed8389a3e1de596c77ecTed Kremenek TyTy = UserTy->desugar(); 2826ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2827ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2828ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2829614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // We may be able to offer a FixItHint if it is a supported type. 2830614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose PrintfSpecifier fixedFS = FS; 2831ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose bool success = fixedFS.fixType(IntendedTy, S.getLangOpts(), 2832614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose S.Context, ObjCContext); 283396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2834614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (success) { 2835614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Get the fix string from the fixed format specifier 2836614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose SmallString<16> buf; 2837614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose llvm::raw_svector_ostream os(buf); 2838614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose fixedFS.toString(os); 2839614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 2840ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CharSourceRange SpecRange = getSpecifierRange(StartSpecifier, SpecifierLen); 2841ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 28422cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (IntendedTy == ExprTy) { 28432cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // In this case, the specifier is wrong and should be changed to match 28442cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // the argument. 28452cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose EmitFormatDiagnostic( 28462cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 28472cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << AT.getRepresentativeTypeName(S.Context) << IntendedTy 28482cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << E->getSourceRange(), 28492cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose E->getLocStart(), 28502cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose /*IsStringLocation*/false, 28512cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose SpecRange, 28522cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose FixItHint::CreateReplacement(SpecRange, os.str())); 28532cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 28542cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } else { 2855ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // The canonical type for formatting this value is different from the 2856ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // actual type of the expression. (This occurs, for example, with Darwin's 2857ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // NSInteger on 32-bit platforms, where it is typedef'd as 'int', but 2858ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // should be printed as 'long' for 64-bit compatibility.) 2859ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Rather than emitting a normal format/argument mismatch, we want to 2860ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // add a cast to the recommended type (and correct the format string 2861ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // if necessary). 2862ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SmallString<16> CastBuf; 2863ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose llvm::raw_svector_ostream CastFix(CastBuf); 2864ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << "("; 2865ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose IntendedTy.print(CastFix, S.Context.getPrintingPolicy()); 2866ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << ")"; 2867ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2868ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SmallVector<FixItHint,4> Hints; 2869ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (!AT.matchesType(S.Context, IntendedTy)) 2870ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateReplacement(SpecRange, os.str())); 2871ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2872ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (const CStyleCastExpr *CCast = dyn_cast<CStyleCastExpr>(E)) { 2873ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // If there's already a cast present, just replace it. 2874ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SourceRange CastRange(CCast->getLParenLoc(), CCast->getRParenLoc()); 2875ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateReplacement(CastRange, CastFix.str())); 2876ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2877ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else if (!requiresParensToAddCast(E)) { 2878ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // If the expression has high enough precedence, 2879ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // just write the C-style cast. 2880ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(), 2881ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix.str())); 2882ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else { 2883ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Otherwise, add parens around the expression as well as the cast. 2884ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << "("; 2885ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(), 2886ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix.str())); 2887ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2888ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SourceLocation After = S.PP.getLocForEndOfToken(E->getLocEnd()); 2889ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(After, ")")); 2890ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2891ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 28922cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose if (ShouldNotPrintDirectly) { 28932cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // The expression has a type that should not be printed directly. 28942cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // We extract the name from the typedef because we don't want to show 28952cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // the underlying type in the diagnostic. 28962cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose StringRef Name = cast<TypedefType>(ExprTy)->getDecl()->getName(); 28972cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose 28982cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_argument_needs_cast) 28992cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << Name << IntendedTy 29002cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << E->getSourceRange(), 29012cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose E->getLocStart(), /*IsStringLocation=*/false, 29022cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose SpecRange, Hints); 29032cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } else { 29042cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // In this case, the expression could be printed using a different 29052cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // specifier, but we've decided that the specifier is probably correct 29062cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose // and we should cast instead. Just use the normal warning message. 29072cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose EmitFormatDiagnostic( 29082cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 29092cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << AT.getRepresentativeTypeName(S.Context) << ExprTy 29102cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose << E->getSourceRange(), 29112cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose E->getLocStart(), /*IsStringLocation*/false, 29122cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose SpecRange, Hints); 29132cd3440369d9241173e994485ddf2589a50a7d80Jordan Rose } 2914ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2915614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } else { 2916614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose const CharSourceRange &CSR = getSpecifierRange(StartSpecifier, 2917614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose SpecifierLen); 2918614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Since the warning for passing non-POD types to variadic functions 2919614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // was deferred until now, we emit a warning for non-POD 2920614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // arguments here. 2921448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (S.isValidVarArgType(ExprTy) == Sema::VAK_Invalid) { 2922614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose unsigned DiagKind; 2923448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose if (ExprTy->isObjCObjectType()) 2924614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose DiagKind = diag::err_cannot_pass_objc_interface_to_vararg_format; 2925614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose else 2926614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose DiagKind = diag::warn_non_pod_vararg_with_format_string; 292796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2928614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose EmitFormatDiagnostic( 2929614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose S.PDiag(DiagKind) 293080ad52f327b532bded5c5b0ee38779d841c6cd35Richard Smith << S.getLangOpts().CPlusPlus11 2931448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose << ExprTy 2932614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CallType 2933614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << AT.getRepresentativeTypeName(S.Context) 2934614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CSR 2935614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << E->getSourceRange(), 2936614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E->getLocStart(), /*IsStringLocation*/false, CSR); 293796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2938614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose checkForCStrMembers(AT, E, CSR); 2939614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } else 294055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 294155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 2942448ac3e6d1f10264cea86c89cc14c266ba2da4a2Jordan Rose << AT.getRepresentativeTypeName(S.Context) << ExprTy 2943614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CSR 2944831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << E->getSourceRange(), 2945614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E->getLocStart(), /*IsStringLocation*/false, CSR); 294696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 294796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2948e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return true; 2949e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2950e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2951826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===// 2952826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2953826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 2954826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler { 2955826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 2956826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 2957826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 295850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, const char *beg, bool hasVAListArg, 29591c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 2960ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 2961ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType) 2962826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 296350687314f87b67073c202fe46d84d12fb55e25cfJordan Rose numDataArgs, beg, hasVAListArg, 29641c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Args, formatIdx, inFunctionCall, CallType) 2965ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose {} 2966826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2967826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 2968826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2969826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2970c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2971c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidScanfConversionSpecifier( 2972c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2973c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 2974c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen); 2975b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 2976b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek void HandleIncompleteScanList(const char *start, const char *end); 2977826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 2978826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2979826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2980b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start, 2981b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek const char *end) { 298255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete), 298355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(end), /*IsStringLocation*/true, 298455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(start, end - start)); 2985b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek} 2986b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 2987c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 2988c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2989c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 2990c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen) { 2991c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 29926ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_scanf::ScanfConversionSpecifier &CS = 2993c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 2994c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2995c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 2996c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 2997c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 2998c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 2999c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 3000c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 3001826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier( 3002826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 3003826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 3004826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 3005826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3006826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_scanf; 3007826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_format_string; 3008826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 30096ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 3010826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3011baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Handle case where '%' and '*' don't consume an argument. These shouldn't 3012baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // be used to decide if we are using positional arguments consistently. 3013baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 3014baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 3015baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 3016baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 3017baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 3018baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 301955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 302055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 3021baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 3022baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 3023826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 3024826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3025826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Check if the field with is non-zero. 3026826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const OptionalAmount &Amt = FS.getFieldWidth(); 3027826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getHowSpecified() == OptionalAmount::Constant) { 3028826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getConstantAmount() == 0) { 3029826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 3030826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Amt.getConstantLength()); 303155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width), 303255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 303355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, R, 303455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval(R)); 30357f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 30367f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 3037826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3038826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!FS.consumesDataArgument()) { 3039826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Technically specifying a precision or field width here 3040826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // makes no sense. Worth issuing a warning at some point. 3041826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 3042826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 3043826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3044826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Consume the argument. 3045826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned argIndex = FS.getArgIndex(); 3046826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (argIndex < NumDataArgs) { 3047826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The check to see if the argIndex is valid will come later. 3048826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // We set the bit here because we may exit early from this 3049826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // function if we encounter some other error. 3050826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.set(argIndex); 3051826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 3052826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 30531e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek // Check the length modifier is valid with the given conversion specifier. 3054bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo())) 30558be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 30568be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_nonsensical_length); 3057bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthModifier()) 30588be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen); 3059bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthConversionCombination()) 30608be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 30618be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_non_standard_conversion_spec); 306276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 3063bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 3064bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 3065bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 3066826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The remaining checks depend on the data arguments. 3067826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (HasVAListArg) 3068826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 3069826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3070666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 3071826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return false; 3072826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 30736fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Check that the argument type matches the format specifier. 30746fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg const Expr *Ex = getDataArg(argIndex); 307548716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Ex) 307648716663e421472cbd590af160a372bc490205e8Jordan Rose return true; 307748716663e421472cbd590af160a372bc490205e8Jordan Rose 307858e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg const analyze_format_string::ArgType &AT = FS.getArgType(S.Context); 307958e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg if (AT.isValid() && !AT.matchesType(S.Context, Ex->getType())) { 30806fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg ScanfSpecifier fixedFS = FS; 30814e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie bool success = fixedFS.fixType(Ex->getType(), S.getLangOpts(), 3082be6126a2a784e1446460b8d15c2b26f880c871fcHans Wennborg S.Context); 30836fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 30846fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg if (success) { 30856fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Get the fix string from the fixed format specifier. 3086f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> buf; 30876fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg llvm::raw_svector_ostream os(buf); 30886fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg fixedFS.toString(os); 30896fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 30906fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg EmitFormatDiagnostic( 30916fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 309258e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg << AT.getRepresentativeTypeName(S.Context) << Ex->getType() 30936fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg << Ex->getSourceRange(), 3094abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay Ex->getLocStart(), 3095abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay /*IsStringLocation*/false, 30966fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 30976fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg FixItHint::CreateReplacement( 30986fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 30996fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg os.str())); 31006fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } else { 3101220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas EmitFormatDiagnostic( 3102220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 310358e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg << AT.getRepresentativeTypeName(S.Context) << Ex->getType() 3104220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << Ex->getSourceRange(), 3105abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay Ex->getLocStart(), 3106abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay /*IsStringLocation*/false, 3107220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas getSpecifierRange(startSpecifier, specifierLen)); 31086fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 31096fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 31106fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 3111826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 311207d161f38e708a91486bf1c031d525faebbb249dTed Kremenek} 3113e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 3114826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr, 31150e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const Expr *OrigFormatExpr, 31161c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko ArrayRef<const Expr *> Args, 311729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas bool HasVAListArg, unsigned format_idx, 311834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg, FormatStringType Type, 3119ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose bool inFunctionCall, VariadicCallType CallType) { 3120826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3121e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: is the format string a wide literal? 3122df9ef1bc8c3780307ab2ed81bf5e31c23310b936Richard Smith if (!FExpr->isAscii() && !FExpr->isUTF8()) { 312355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 312429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas *this, inFunctionCall, Args[format_idx], 312555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(), 312655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 3127e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 3128e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 3129826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3130e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // Str - The format string. NOTE: this is NOT null-terminated! 31315f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef StrRef = FExpr->getString(); 31322f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer const char *Str = StrRef.data(); 31332f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer unsigned StrLen = StrRef.size(); 31341c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko const unsigned numDataArgs = Args.size() - firstDataArg; 3135826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3136e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: empty format string? 31374cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek if (StrLen == 0 && numDataArgs > 0) { 313855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 313929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas *this, inFunctionCall, Args[format_idx], 314055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_empty_format_string), FExpr->getLocStart(), 314155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 3142e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 3143e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 3144826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 314534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas if (Type == FST_Printf || Type == FST_NSString) { 3146826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 314750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose numDataArgs, (Type == FST_NSString), 31481c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Str, HasVAListArg, Args, format_idx, 3149ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall, CallType); 3150826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3151d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen, 3152275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose getLangOpts(), 3153275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose Context.getTargetInfo())) 3154826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 315534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } else if (Type == FST_Scanf) { 315650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, numDataArgs, 31571c030e9a3f290a1eea5de82fe1e63dfde2bd8f1eDmitri Gribenko Str, HasVAListArg, Args, format_idx, 3158ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall, CallType); 3159826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3160d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen, 3161275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose getLangOpts(), 3162275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose Context.getTargetInfo())) 3163826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 316434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } // TODO: handle other formats 3165ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek} 3166ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek 31677ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth//===--- CHECK: Standard memory functions ---------------------------------===// 31687ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 31692a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// \brief Determine whether the given type is a dynamic class type (e.g., 31702a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// whether it has a vtable). 31712a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregorstatic bool isDynamicClassType(QualType T) { 31722a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Record = T->getAsCXXRecordDecl()) 31732a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Definition = Record->getDefinition()) 31742a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (Definition->isDynamicClass()) 31752a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return true; 31762a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 31772a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return false; 31782a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor} 31792a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 3180a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument expression, 3181000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth/// otherwise returns NULL. 3182000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic const Expr *getSizeOfExprArg(const Expr* E) { 3183e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber if (const UnaryExprOrTypeTraitExpr *SizeOf = 3184000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 3185000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType()) 3186000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getArgumentExpr()->IgnoreParenImpCasts(); 3187e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 3188000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return 0; 3189000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth} 3190000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3191a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument type. 3192000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic QualType getSizeOfArgType(const Expr* E) { 3193000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryExprOrTypeTraitExpr *SizeOf = 3194000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 3195000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf) 3196000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getTypeOfArgument(); 3197000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3198000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return QualType(); 3199e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber} 3200e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 32017ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \brief Check for dangerous or invalid arguments to memset(). 32027ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 3203929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth/// This issues warnings on known problematic, dangerous or unspecified 3204cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp' 3205cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// function calls. 32067ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 32077ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \param Call The call expression to diagnose. 3208cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gayvoid Sema::CheckMemaccessArguments(const CallExpr *Call, 32090a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned BId, 3210cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay IdentifierInfo *FnName) { 32110a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks assert(BId != 0); 32120a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 32131d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek // It is possible to have a non-standard definition of memset. Validate 3214707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor // we have enough arguments, and if not, abort further checking. 32150a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned ExpectedNumArgs = (BId == Builtin::BIstrndup ? 2 : 3); 3216cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber if (Call->getNumArgs() < ExpectedNumArgs) 32171d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek return; 32181d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek 32190a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LastArg = (BId == Builtin::BImemset || 32200a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId == Builtin::BIstrndup ? 1 : 2); 32210a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LenArg = (BId == Builtin::BIstrndup ? 1 : 2); 3222cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts(); 3223000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3224000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We have special checking when the length is a sizeof expression. 3225000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth QualType SizeOfArgTy = getSizeOfArgType(LenExpr); 3226000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth const Expr *SizeOfArg = getSizeOfExprArg(LenExpr); 3227000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID SizeOfArgID; 3228000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 322906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) { 323006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts(); 3231e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange(); 323206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 323306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType DestTy = Dest->getType(); 323406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) { 323506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType PointeeTy = DestPtrTy->getPointeeType(); 3236f85e193739c953358c865005855253af4f68a497John McCall 3237000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Never warn about void type pointers. This can be used to suppress 3238000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // false positives. 3239000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isVoidType()) 324006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 324106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 3242000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by 3243000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // actually comparing the expressions for equality. Because computing the 3244000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // expression IDs can be expensive, we only do this if the diagnostic is 3245000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // enabled. 3246000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArg && 3247000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess, 3248000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->getExprLoc())) { 3249000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We only compute IDs for expressions if the warning is enabled, and 3250000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // cache the sizeof arg's ID. 3251000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgID == llvm::FoldingSetNodeID()) 3252000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->Profile(SizeOfArgID, Context, true); 3253000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID DestID; 3254000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Dest->Profile(DestID, Context, true); 3255000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (DestID == SizeOfArgID) { 3256cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // TODO: For strncpy() and friends, this could suggest sizeof(dst) 3257cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // over sizeof(src) as well. 3258000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth unsigned ActionIdx = 0; // Default is to suggest dereferencing. 32596fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks StringRef ReadableName = FnName->getName(); 32606fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 3261000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest)) 326290c78328e70cb376754edf87708505a84c044271Anna Zaks if (UnaryOp->getOpcode() == UO_AddrOf) 3263000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 1; // If its an address-of operator, just remove it. 32647adf4179f827b14b025135829dadeaa2442e1d42Fariborz Jahanian if (!PointeeTy->isIncompleteType() && 32657adf4179f827b14b025135829dadeaa2442e1d42Fariborz Jahanian (Context.getTypeSize(PointeeTy) == Context.getCharWidth())) 3266000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 2; // If the pointee's size is sizeof(char), 3267000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // suggest an explicit length. 32686fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 32696fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks // If the function is defined as a builtin macro, do not show macro 32706fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks // expansion. 32716fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceLocation SL = SizeOfArg->getExprLoc(); 32726fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceRange DSR = Dest->getSourceRange(); 32736fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceRange SSR = SizeOfArg->getSourceRange(); 32746fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceManager &SM = PP.getSourceManager(); 32756fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 32766fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks if (SM.isMacroArgExpansion(SL)) { 32776fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks ReadableName = Lexer::getImmediateMacroName(SL, SM, LangOpts); 32786fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SL = SM.getSpellingLoc(SL); 32796fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks DSR = SourceRange(SM.getSpellingLoc(DSR.getBegin()), 32806fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SM.getSpellingLoc(DSR.getEnd())); 32816fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SSR = SourceRange(SM.getSpellingLoc(SSR.getBegin()), 32826fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SM.getSpellingLoc(SSR.getEnd())); 32836fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks } 32846fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 328590c78328e70cb376754edf87708505a84c044271Anna Zaks DiagRuntimeBehavior(SL, SizeOfArg, 3286000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_expr_memaccess) 32876fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks << ReadableName 328890c78328e70cb376754edf87708505a84c044271Anna Zaks << PointeeTy 328990c78328e70cb376754edf87708505a84c044271Anna Zaks << DestTy 32906fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks << DSR 329190c78328e70cb376754edf87708505a84c044271Anna Zaks << SSR); 329290c78328e70cb376754edf87708505a84c044271Anna Zaks DiagRuntimeBehavior(SL, SizeOfArg, 329390c78328e70cb376754edf87708505a84c044271Anna Zaks PDiag(diag::warn_sizeof_pointer_expr_memaccess_note) 329490c78328e70cb376754edf87708505a84c044271Anna Zaks << ActionIdx 329590c78328e70cb376754edf87708505a84c044271Anna Zaks << SSR); 329690c78328e70cb376754edf87708505a84c044271Anna Zaks 3297000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 3298000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3299000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3300000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3301000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Also check for cases where the sizeof argument is the exact same 3302000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // type as the memory argument, and where it points to a user-defined 3303000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // record type. 3304000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgTy != QualType()) { 3305000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isRecordType() && 3306000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Context.typesAreCompatible(SizeOfArgTy, DestTy)) { 3307000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest, 3308000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_type_memaccess) 3309000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << FnName << SizeOfArgTy << ArgIdx 3310000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << PointeeTy << Dest->getSourceRange() 3311000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << LenExpr->getSourceRange()); 3312000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 3313000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3314e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber } 3315e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 331606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor // Always complain about dynamic classes. 33170a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (isDynamicClassType(PointeeTy)) { 33180a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 33190a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned OperationType = 0; 33200a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // "overwritten" if we're warning about the destination for any call 33210a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // but memcmp; otherwise a verb appropriate to the call. 33220a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (ArgIdx != 0 || BId == Builtin::BImemcmp) { 33230a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (BId == Builtin::BImemcpy) 33240a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 1; 33250a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if(BId == Builtin::BImemmove) 33260a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 2; 33270a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if (BId == Builtin::BImemcmp) 33280a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 3; 33290a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } 33300a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 33315c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 33325c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 33335c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_dyn_class_memaccess) 33340a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx) 3335d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks << FnName << PointeeTy 33360a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << OperationType 33375c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 33380a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } else if (PointeeTy.hasNonTrivialObjCLifetime() && 33390a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId != Builtin::BImemset) 33405c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 33415c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 33425c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_arc_object_memaccess) 33435c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << ArgIdx << FnName << PointeeTy 33445c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 3345f85e193739c953358c865005855253af4f68a497John McCall else 334606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 3347f85e193739c953358c865005855253af4f68a497John McCall 3348f85e193739c953358c865005855253af4f68a497John McCall DiagRuntimeBehavior( 3349f85e193739c953358c865005855253af4f68a497John McCall Dest->getExprLoc(), Dest, 3350929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth PDiag(diag::note_bad_memaccess_silence) 335106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)")); 335206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor break; 335306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 33547ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth } 33557ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth} 33567ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 3357bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// A little helper routine: ignore addition and subtraction of integer literals. 3358bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// This intentionally does not ignore all integer constant expressions because 3359bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// we don't want to remove sizeof(). 3360bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekstatic const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) { 3361bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = Ex->IgnoreParenCasts(); 3362bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3363bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek for (;;) { 3364bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex); 3365bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!BO || !BO->isAdditiveOp()) 3366bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 3367bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3368bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *RHS = BO->getRHS()->IgnoreParenCasts(); 3369bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *LHS = BO->getLHS()->IgnoreParenCasts(); 3370bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3371bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (isa<IntegerLiteral>(RHS)) 3372bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = LHS; 3373bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else if (isa<IntegerLiteral>(LHS)) 3374bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = RHS; 3375bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else 3376bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 3377bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3378bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3379bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return Ex; 3380bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 3381bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 33820f38acee92014cb15af980808f87144e5564031dAnna Zaksstatic bool isConstantSizeArrayWithMoreThanOneElement(QualType Ty, 33830f38acee92014cb15af980808f87144e5564031dAnna Zaks ASTContext &Context) { 33840f38acee92014cb15af980808f87144e5564031dAnna Zaks // Only handle constant-sized or VLAs, but not flexible members. 33850f38acee92014cb15af980808f87144e5564031dAnna Zaks if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(Ty)) { 33860f38acee92014cb15af980808f87144e5564031dAnna Zaks // Only issue the FIXIT for arrays of size > 1. 33870f38acee92014cb15af980808f87144e5564031dAnna Zaks if (CAT->getSize().getSExtValue() <= 1) 33880f38acee92014cb15af980808f87144e5564031dAnna Zaks return false; 33890f38acee92014cb15af980808f87144e5564031dAnna Zaks } else if (!Ty->isVariableArrayType()) { 33900f38acee92014cb15af980808f87144e5564031dAnna Zaks return false; 33910f38acee92014cb15af980808f87144e5564031dAnna Zaks } 33920f38acee92014cb15af980808f87144e5564031dAnna Zaks return true; 33930f38acee92014cb15af980808f87144e5564031dAnna Zaks} 33940f38acee92014cb15af980808f87144e5564031dAnna Zaks 3395bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// Warn if the user has made the 'size' argument to strlcpy or strlcat 3396bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// be the size of the source, instead of the destination. 3397bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekvoid Sema::CheckStrlcpycatArguments(const CallExpr *Call, 3398bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek IdentifierInfo *FnName) { 3399bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3400bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Don't crash if the user has the wrong number of arguments 3401bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (Call->getNumArgs() != 3) 3402bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3403bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3404bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context); 3405bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context); 3406bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *CompareWithSrc = NULL; 3407bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3408bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, sizeof(x))' 3409bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const Expr *Ex = getSizeOfExprArg(SizeArg)) 3410bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = Ex; 3411bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else { 3412bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, strlen(x))' 3413bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) { 3414180f47959a066795cc0f409433023af448bb0328Richard Smith if (SizeCall->isBuiltinCall() == Builtin::BIstrlen 3415bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek && SizeCall->getNumArgs() == 1) 3416bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context); 3417bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3418bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3419bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3420bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrc) 3421bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3422bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3423bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Determine if the argument to sizeof/strlen is equal to the source 3424bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // argument. In principle there's all kinds of things you could do 3425bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // here, for instance creating an == expression and evaluating it with 3426bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // EvaluateAsBooleanCondition, but this uses a more direct technique: 3427bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg); 3428bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!SrcArgDRE) 3429bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3430bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3431bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc); 3432bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrcDRE || 3433bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl()) 3434bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3435bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3436bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *OriginalSizeArg = Call->getArg(2); 3437bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size) 3438bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek << OriginalSizeArg->getSourceRange() << FnName; 3439bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3440bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Output a FIXIT hint if the destination is an array (rather than a 3441bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointer to an array). This could be enhanced to handle some 3442bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointers if we know the actual size, like if DstArg is 'array+2' 3443bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // we could say 'sizeof(array)-2'. 3444bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts(); 34450f38acee92014cb15af980808f87144e5564031dAnna Zaks if (!isConstantSizeArrayWithMoreThanOneElement(DstArg->getType(), Context)) 34468f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 34478f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 3448f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> sizeString; 34498f7462237ff542a4556775f98709ed300aa1731aTed Kremenek llvm::raw_svector_ostream OS(sizeString); 34508f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << "sizeof("; 3451d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 34528f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << ")"; 34538f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 34548f7462237ff542a4556775f98709ed300aa1731aTed Kremenek Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size) 34558f7462237ff542a4556775f98709ed300aa1731aTed Kremenek << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(), 34568f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS.str()); 3457bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 3458bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3459c36bedc90c687caa71748480c60707ea4608b092Anna Zaks/// Check if two expressions refer to the same declaration. 3460c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic bool referToTheSameDecl(const Expr *E1, const Expr *E2) { 3461c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const DeclRefExpr *D1 = dyn_cast_or_null<DeclRefExpr>(E1)) 3462c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const DeclRefExpr *D2 = dyn_cast_or_null<DeclRefExpr>(E2)) 3463c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return D1->getDecl() == D2->getDecl(); 3464c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return false; 3465c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3466c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3467c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic const Expr *getStrlenExprArg(const Expr *E) { 3468c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const CallExpr *CE = dyn_cast<CallExpr>(E)) { 3469c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const FunctionDecl *FD = CE->getDirectCallee(); 3470c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (!FD || FD->getMemoryFunctionKind() != Builtin::BIstrlen) 3471c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return 0; 3472c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return CE->getArg(0)->IgnoreParenCasts(); 3473c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3474c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return 0; 3475c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3476c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3477c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// Warn on anti-patterns as the 'size' argument to strncat. 3478c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// The correct size argument should look like following: 3479c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// strncat(dst, src, sizeof(dst) - strlen(dest) - 1); 3480c36bedc90c687caa71748480c60707ea4608b092Anna Zaksvoid Sema::CheckStrncatArguments(const CallExpr *CE, 3481c36bedc90c687caa71748480c60707ea4608b092Anna Zaks IdentifierInfo *FnName) { 3482c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Don't crash if the user has the wrong number of arguments. 3483c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (CE->getNumArgs() < 3) 3484c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 3485c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *DstArg = CE->getArg(0)->IgnoreParenCasts(); 3486c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *SrcArg = CE->getArg(1)->IgnoreParenCasts(); 3487c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *LenArg = CE->getArg(2)->IgnoreParenCasts(); 3488c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3489c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Identify common expressions, which are wrongly used as the size argument 3490c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // to strncat and may lead to buffer overflows. 3491c36bedc90c687caa71748480c60707ea4608b092Anna Zaks unsigned PatternType = 0; 3492c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const Expr *SizeOfArg = getSizeOfExprArg(LenArg)) { 3493c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(dst) 3494c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (referToTheSameDecl(SizeOfArg, DstArg)) 3495c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 1; 3496c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(src) 3497c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (referToTheSameDecl(SizeOfArg, SrcArg)) 3498c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 2; 3499c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } else if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(LenArg)) { 3500c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (BE->getOpcode() == BO_Sub) { 3501c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *L = BE->getLHS()->IgnoreParenCasts(); 3502c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *R = BE->getRHS()->IgnoreParenCasts(); 3503c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(dst) - strlen(dst) 3504c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (referToTheSameDecl(DstArg, getSizeOfExprArg(L)) && 3505c36bedc90c687caa71748480c60707ea4608b092Anna Zaks referToTheSameDecl(DstArg, getStrlenExprArg(R))) 3506c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 1; 3507c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(src) - (anything) 3508c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (referToTheSameDecl(SrcArg, getSizeOfExprArg(L))) 3509c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 2; 3510c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3511c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3512c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3513c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (PatternType == 0) 3514c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 3515c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3516afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks // Generate the diagnostic. 3517afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceLocation SL = LenArg->getLocStart(); 3518afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceRange SR = LenArg->getSourceRange(); 3519afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceManager &SM = PP.getSourceManager(); 3520afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks 3521afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks // If the function is defined as a builtin macro, do not show macro expansion. 3522afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks if (SM.isMacroArgExpansion(SL)) { 3523afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SL = SM.getSpellingLoc(SL); 3524afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SR = SourceRange(SM.getSpellingLoc(SR.getBegin()), 3525afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SM.getSpellingLoc(SR.getEnd())); 3526afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks } 3527afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks 35280f38acee92014cb15af980808f87144e5564031dAnna Zaks // Check if the destination is an array (rather than a pointer to an array). 35290f38acee92014cb15af980808f87144e5564031dAnna Zaks QualType DstTy = DstArg->getType(); 35300f38acee92014cb15af980808f87144e5564031dAnna Zaks bool isKnownSizeArray = isConstantSizeArrayWithMoreThanOneElement(DstTy, 35310f38acee92014cb15af980808f87144e5564031dAnna Zaks Context); 35320f38acee92014cb15af980808f87144e5564031dAnna Zaks if (!isKnownSizeArray) { 35330f38acee92014cb15af980808f87144e5564031dAnna Zaks if (PatternType == 1) 35340f38acee92014cb15af980808f87144e5564031dAnna Zaks Diag(SL, diag::warn_strncat_wrong_size) << SR; 35350f38acee92014cb15af980808f87144e5564031dAnna Zaks else 35360f38acee92014cb15af980808f87144e5564031dAnna Zaks Diag(SL, diag::warn_strncat_src_size) << SR; 35370f38acee92014cb15af980808f87144e5564031dAnna Zaks return; 35380f38acee92014cb15af980808f87144e5564031dAnna Zaks } 35390f38acee92014cb15af980808f87144e5564031dAnna Zaks 3540c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (PatternType == 1) 3541afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::warn_strncat_large_size) << SR; 3542c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else 3543afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::warn_strncat_src_size) << SR; 3544c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3545f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> sizeString; 3546c36bedc90c687caa71748480c60707ea4608b092Anna Zaks llvm::raw_svector_ostream OS(sizeString); 3547c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << "sizeof("; 3548d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 3549c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << ") - "; 3550c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << "strlen("; 3551d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 3552c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << ") - 1"; 3553c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3554afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::note_strncat_wrong_size) 3555afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks << FixItHint::CreateReplacement(SR, OS.str()); 3556c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3557c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 355806de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===// 355906de276fff91264437fa75111ed76de43097e089Ted Kremenek 3560e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3561e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl); 3562e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars, 3563e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl); 356406de276fff91264437fa75111ed76de43097e089Ted Kremenek 356506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address 356606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable. 356706de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid 356806de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 356906de276fff91264437fa75111ed76de43097e089Ted Kremenek SourceLocation ReturnLoc) { 35701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 357126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Expr *stackE = 0; 35725f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<DeclRefExpr *, 8> refVars; 35734e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 357426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Perform checking for returned stack addresses, local blocks, 357526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // label addresses or references to temporaries. 3576f85e193739c953358c865005855253af4f68a497John McCall if (lhsType->isPointerType() || 35774e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie (!getLangOpts().ObjCAutoRefCount && lhsType->isBlockPointerType())) { 3578e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/0); 3579ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (lhsType->isReferenceType()) { 3580e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis stackE = EvalVal(RetValExp, refVars, /*ParentDecl=*/0); 358126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 358226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 358326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (stackE == 0) 358426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return; // Nothing suspicious was found. 358526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 358626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceLocation diagLoc; 358726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange diagRange; 358826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (refVars.empty()) { 358926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = stackE->getLocStart(); 359026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = stackE->getSourceRange(); 359126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { 359226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // We followed through a reference variable. 'stackE' contains the 359326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // problematic expression but we will warn at the return statement pointing 359426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // at the reference variable. We will later display the "trail" of 359526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // reference variables using notes. 359626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = refVars[0]->getLocStart(); 359726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = refVars[0]->getSourceRange(); 359826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 359926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 360026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var. 360126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref 360226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_stack_addr) 360326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << DR->getDecl()->getDeclName() << diagRange; 360426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<BlockExpr>(stackE)) { // local block. 360526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::err_ret_local_block) << diagRange; 360626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 360726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 360826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { // local temporary. 360926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref 361026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_local_temp_addr) 361126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << diagRange; 361226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 361326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 361426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Display the "trail" of reference variables that we followed until we 361526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // found the problematic expression using notes. 361626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 361726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 361826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this var binds to another reference var, show the range of the next 361926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // var, otherwise the var binds to the problematic expression, in which case 362026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // show the range of the expression. 362126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange() 362226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : stackE->getSourceRange(); 362326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(VD->getLocation(), diag::note_ref_var_local_bind) 362426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << VD->getDeclName() << range; 362506de276fff91264437fa75111ed76de43097e089Ted Kremenek } 362606de276fff91264437fa75111ed76de43097e089Ted Kremenek} 362706de276fff91264437fa75111ed76de43097e089Ted Kremenek 362806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 362906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// check if the expression in a return statement evaluates to an address 363026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// to a location on the stack, a local block, an address of a label, or a 363126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// reference to local temporary. The recursion is used to traverse the 363206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// AST of the return expression, with recursion backtracking when we 363326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// encounter a subexpression that (1) clearly does not lead to one of the 363426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// above problematic expressions (2) is something we cannot determine leads to 363526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// a problematic expression based on such local checking. 363626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 363726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// Both EvalAddr and EvalVal follow through reference variables to evaluate 363826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// the expression that they point to. Such variables are added to the 363926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 'refVars' vector so that we know what the reference variable "trail" was. 364006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 3641e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// EvalAddr processes expressions that are pointers that are used as 3642e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// references (and not L-values). EvalVal handles all other values. 364326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// At the base case of the recursion is a check for the above problematic 364426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// expressions. 364506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 364606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// This implementation handles: 364706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 364806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer-to-pointer casts 364906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * implicit conversions from array references to pointers 365006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of fields 365106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * arbitrary interplay between "&" and "*" operators 365206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer arithmetic from an address of a stack variable 365306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of an array element where the array is on the stack 3654e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3655e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl) { 365626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (E->isTypeDependent()) 365726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 365826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 365906de276fff91264437fa75111ed76de43097e089Ted Kremenek // We should only be called for evaluating pointer expressions. 36600f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall assert((E->getType()->isAnyPointerType() || 3661dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff E->getType()->isBlockPointerType() || 3662a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek E->getType()->isObjCQualifiedIdType()) && 3663fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner "EvalAddr only works on pointers"); 36641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3665f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 3666f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 366706de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 366806de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 366906de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 367006de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 367126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::DeclRefExprClass: { 367226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis DeclRefExpr *DR = cast<DeclRefExpr>(E); 367326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 367426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 367526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this is a reference variable, follow through to the expression that 367626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 367726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage() && 367826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis V->getType()->isReferenceType() && V->hasInit()) { 367926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 368026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 3681e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(V->getInit(), refVars, ParentDecl); 368226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 368326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 368426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 368526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 368606de276fff91264437fa75111ed76de43097e089Ted Kremenek 3687fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::UnaryOperatorClass: { 3688fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // The only unary operator that make sense to handle here 3689fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // is AddrOf. All others don't make sense as pointers. 3690fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner UnaryOperator *U = cast<UnaryOperator>(E); 36911eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 36922de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_AddrOf) 3693e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(U->getSubExpr(), refVars, ParentDecl); 3694fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 3695fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 3696fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 36971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3698fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::BinaryOperatorClass: { 3699fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle pointer arithmetic. All other binary operators are not valid 3700fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // in this context. 3701fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner BinaryOperator *B = cast<BinaryOperator>(E); 37022de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = B->getOpcode(); 37031eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 37042de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op != BO_Add && op != BO_Sub) 3705fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 37061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3707fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner Expr *Base = B->getLHS(); 37083907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 3709fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Determine which argument is the real pointer base. It could be 3710fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // the RHS argument instead of the LHS. 3711fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner if (!Base->getType()->isPointerType()) Base = B->getRHS(); 37121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3713fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner assert (Base->getType()->isPointerType()); 3714e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(Base, refVars, ParentDecl); 3715fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 371661f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff 3717fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // For conditional operators we need to see if either the LHS or RHS are 3718fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // valid DeclRefExpr*s. If one of them is valid, we return it. 3719fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ConditionalOperatorClass: { 3720fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner ConditionalOperator *C = cast<ConditionalOperator>(E); 37211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3722fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle the GNU extension for missing LHS. 37239ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (Expr *lhsExpr = C->getLHS()) { 37249ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 37259ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (!lhsExpr->getType()->isVoidType()) 3726e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (Expr* LHS = EvalAddr(lhsExpr, refVars, ParentDecl)) 37279ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return LHS; 37289ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor } 37299ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor 37309ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 37319ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (C->getRHS()->getType()->isVoidType()) 37329ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return NULL; 373306de276fff91264437fa75111ed76de43097e089Ted Kremenek 3734e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(C->getRHS(), refVars, ParentDecl); 3735fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 373626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 373726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::BlockExprClass: 3738469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures()) 373926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // local block. 374026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 374126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 374226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::AddrLabelExprClass: 374326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // address of label. 37441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 374580ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 3746e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars, 3747e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis ParentDecl); 374880ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 374954b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // For casts, we need to handle conversions from arrays to 375054b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // pointer values, and pointer-to-pointer conversions. 375149badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::ImplicitCastExprClass: 37526eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor case Stmt::CStyleCastExprClass: 3753f85e193739c953358c865005855253af4f68a497John McCall case Stmt::CXXFunctionalCastExprClass: 37548b9414e868853fc052251455674bf7512261e14aEli Friedman case Stmt::ObjCBridgedCastExprClass: 37551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXStaticCastExprClass: 37561eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXDynamicCastExprClass: 375749badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXConstCastExprClass: 375849badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXReinterpretCastExprClass: { 37598b9414e868853fc052251455674bf7512261e14aEli Friedman Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 37608b9414e868853fc052251455674bf7512261e14aEli Friedman switch (cast<CastExpr>(E)->getCastKind()) { 37618b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BitCast: 37628b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_LValueToRValue: 37638b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_NoOp: 37648b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BaseToDerived: 37658b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_DerivedToBase: 37668b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_UncheckedDerivedToBase: 37678b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_Dynamic: 37688b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_CPointerToObjCPointerCast: 37698b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BlockPointerToObjCPointerCast: 37708b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_AnyPointerToBlockPointerCast: 3771e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(SubExpr, refVars, ParentDecl); 37728b9414e868853fc052251455674bf7512261e14aEli Friedman 37738b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_ArrayToPointerDecay: 3774e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(SubExpr, refVars, ParentDecl); 37758b9414e868853fc052251455674bf7512261e14aEli Friedman 37768b9414e868853fc052251455674bf7512261e14aEli Friedman default: 37778b9414e868853fc052251455674bf7512261e14aEli Friedman return 0; 37788b9414e868853fc052251455674bf7512261e14aEli Friedman } 3779fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 37801eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 378103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 378203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalAddr( 378303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 3784e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis refVars, ParentDecl)) 378503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 378603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 378703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 378803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 3789fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Everything else: we simply don't reason about them. 3790fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner default: 3791fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 379206de276fff91264437fa75111ed76de43097e089Ted Kremenek } 379306de276fff91264437fa75111ed76de43097e089Ted Kremenek} 37941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 379506de276fff91264437fa75111ed76de43097e089Ted Kremenek 379606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalVal - This function is complements EvalAddr in the mutual recursion. 379706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// See the comments for EvalAddr for more details. 3798e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3799e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl) { 380068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo { 3801e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // We should only be called for evaluating non-pointer expressions, or 3802e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // expressions with a pointer type that are not used as references but instead 3803e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // are l-values (e.g., DeclRefExpr with a pointer type). 38041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 380506de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 380606de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 380706de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 3808f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 3809f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 381006de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 381168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ImplicitCastExprClass: { 381268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 38135baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall if (IE->getValueKind() == VK_LValue) { 381468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = IE->getSubExpr(); 381568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 381668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 381768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek return NULL; 381868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 381968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek 382080ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 3821e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,ParentDecl); 382280ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 3823a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor case Stmt::DeclRefExprClass: { 382426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // When we hit a DeclRefExpr we are looking at code that refers to a 382526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // variable's name. If it's not a reference variable we check if it has 382626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // local storage within the function, and if so, return the expression. 382706de276fff91264437fa75111ed76de43097e089Ted Kremenek DeclRefExpr *DR = cast<DeclRefExpr>(E); 38281eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3829e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) { 3830e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis // Check if it refers to itself, e.g. "int& i = i;". 3831e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (V == ParentDecl) 3832e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return DR; 3833e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis 383426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage()) { 383526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!V->getType()->isReferenceType()) 383626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return DR; 383726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 383826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Reference variable, follow through to the expression that 383926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 384026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasInit()) { 384126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 384226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 3843e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(V->getInit(), refVars, V); 384426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 384526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 3846e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis } 38471eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 384806de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 384906de276fff91264437fa75111ed76de43097e089Ted Kremenek } 38501eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 385106de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::UnaryOperatorClass: { 385206de276fff91264437fa75111ed76de43097e089Ted Kremenek // The only unary operator that make sense to handle here 385306de276fff91264437fa75111ed76de43097e089Ted Kremenek // is Deref. All others don't resolve to a "name." This includes 385406de276fff91264437fa75111ed76de43097e089Ted Kremenek // handling all sorts of rvalues passed to a unary operator. 385506de276fff91264437fa75111ed76de43097e089Ted Kremenek UnaryOperator *U = cast<UnaryOperator>(E); 38561eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 38572de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_Deref) 3858e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(U->getSubExpr(), refVars, ParentDecl); 385906de276fff91264437fa75111ed76de43097e089Ted Kremenek 386006de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 386106de276fff91264437fa75111ed76de43097e089Ted Kremenek } 38621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 386306de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ArraySubscriptExprClass: { 386406de276fff91264437fa75111ed76de43097e089Ted Kremenek // Array subscripts are potential references to data on the stack. We 386506de276fff91264437fa75111ed76de43097e089Ted Kremenek // retrieve the DeclRefExpr* for the array variable if it indeed 386606de276fff91264437fa75111ed76de43097e089Ted Kremenek // has local storage. 3867e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars,ParentDecl); 386806de276fff91264437fa75111ed76de43097e089Ted Kremenek } 38691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 387006de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ConditionalOperatorClass: { 387106de276fff91264437fa75111ed76de43097e089Ted Kremenek // For conditional operators we need to see if either the LHS or RHS are 387226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // non-NULL Expr's. If one is non-NULL, we return it. 387306de276fff91264437fa75111ed76de43097e089Ted Kremenek ConditionalOperator *C = cast<ConditionalOperator>(E); 387406de276fff91264437fa75111ed76de43097e089Ted Kremenek 38753907323dd6665c0c4e383435cb145233f4533406Anders Carlsson // Handle the GNU extension for missing LHS. 38763907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (Expr *lhsExpr = C->getLHS()) 3877e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (Expr *LHS = EvalVal(lhsExpr, refVars, ParentDecl)) 38783907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return LHS; 38793907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 3880e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(C->getRHS(), refVars, ParentDecl); 388106de276fff91264437fa75111ed76de43097e089Ted Kremenek } 38821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 388306de276fff91264437fa75111ed76de43097e089Ted Kremenek // Accesses to members are potential references to data on the stack. 388483f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor case Stmt::MemberExprClass: { 388506de276fff91264437fa75111ed76de43097e089Ted Kremenek MemberExpr *M = cast<MemberExpr>(E); 38861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 388706de276fff91264437fa75111ed76de43097e089Ted Kremenek // Check for indirect access. We only want direct field accesses. 3888a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->isArrow()) 3889a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return NULL; 3890a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 3891a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // Check whether the member type is itself a reference, in which case 3892a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // we're not going to refer to the member, but to what the member refers to. 3893a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->getMemberDecl()->getType()->isReferenceType()) 389406de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 3895a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 3896e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(M->getBase(), refVars, ParentDecl); 389706de276fff91264437fa75111ed76de43097e089Ted Kremenek } 38981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 389903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 390003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalVal( 390103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 3902e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis refVars, ParentDecl)) 390303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 390403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 390503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 390603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 390706de276fff91264437fa75111ed76de43097e089Ted Kremenek default: 390826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Check that we don't return or take the address of a reference to a 390926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // temporary. This is only useful in C++. 391026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!E->isTypeDependent() && E->isRValue()) 391126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; 391226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 391326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Everything else: we simply don't reason about them. 391406de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 391506de276fff91264437fa75111ed76de43097e089Ted Kremenek } 391668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true); 391706de276fff91264437fa75111ed76de43097e089Ted Kremenek} 3918588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3919588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 3920588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3921588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==. 3922588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely 3923588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended. 3924dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieuvoid Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) { 3925dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts(); 3926dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* RightExprSansParen = RHS->IgnoreParenImpCasts(); 3927588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3928588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Special case: check for x == x (which is OK). 3929588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Do not emit warnings for such cases. 3930588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 3931588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 3932588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DRL->getDecl() == DRR->getDecl()) 3933980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 39341eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 39351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 39361b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // Special case: check for comparisons against literals that can be exactly 39371b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // represented by APFloat. In such cases, do not emit a warning. This 39381b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // is a heuristic: often comparison against such literals are used to 39391b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // detect if a value in a variable has not changed. This clearly can 39401b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // lead to false negatives. 3941980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 3942980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FLL->isExact()) 3943980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 3944980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie } else 3945980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)) 3946980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FLR->isExact()) 3947980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 39481eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3949588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Check for comparisons with builtin types. 3950980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 3951980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CL->isBuiltinCall()) 3952980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 39531eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3954980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 3955980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CR->isBuiltinCall()) 3956980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 39571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3958588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Emit the diagnostic. 3959980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie Diag(Loc, diag::warn_floatingpoint_eq) 3960980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie << LHS->getSourceRange() << RHS->getSourceRange(); 3961588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek} 3962ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3963f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 3964f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 3965ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3966f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace { 3967ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3968f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued 3969f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression. 3970f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange { 3971f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// The number of bits active in the int. 3972f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned Width; 3973ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3974f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// True if the int is known not to have negative values. 3975f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool NonNegative; 397651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3977f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange(unsigned Width, bool NonNegative) 3978f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : Width(Width), NonNegative(NonNegative) 3979f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall {} 398051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 39811844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of the bool type. 3982f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall static IntRange forBoolType() { 3983f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(1, true); 3984f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 398551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 39861844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of the given integral type. 39871844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfType(ASTContext &C, QualType T) { 39881844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return forValueOfCanonicalType(C, 39891844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T->getCanonicalTypeInternal().getTypePtr()); 399051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 399151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 39921844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of a canonical integral type. 39931844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 3994f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(T->isCanonicalUnqualified()); 399551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3996f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 3997f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = VT->getElementType().getTypePtr(); 3998f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 3999f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = CT->getElementType().getTypePtr(); 4000323ed74658bc8375278eabf074b4777458376540John McCall 4001091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // For enum types, use the known bit width of the enumerators. 4002323ed74658bc8375278eabf074b4777458376540John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) { 4003323ed74658bc8375278eabf074b4777458376540John McCall EnumDecl *Enum = ET->getDecl(); 40045e1cdac63c3d9c9b32fa41fa0b2d242a58a20d49John McCall if (!Enum->isCompleteDefinition()) 4005091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return IntRange(C.getIntWidth(QualType(T, 0)), false); 4006091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 4007323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumPositive = Enum->getNumPositiveBits(); 4008323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumNegative = Enum->getNumNegativeBits(); 4009323ed74658bc8375278eabf074b4777458376540John McCall 40108f50b24c8b17368f68c2e71240d487dde53f6da8Richard Trieu if (NumNegative == 0) 40118f50b24c8b17368f68c2e71240d487dde53f6da8Richard Trieu return IntRange(NumPositive, true/*NonNegative*/); 40128f50b24c8b17368f68c2e71240d487dde53f6da8Richard Trieu else 40138f50b24c8b17368f68c2e71240d487dde53f6da8Richard Trieu return IntRange(std::max(NumPositive + 1, NumNegative), 40148f50b24c8b17368f68c2e71240d487dde53f6da8Richard Trieu false/*NonNegative*/); 4015323ed74658bc8375278eabf074b4777458376540John McCall } 401651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4017f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const BuiltinType *BT = cast<BuiltinType>(T); 4018f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(BT->isInteger()); 401951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4020f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 402151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 402251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 40231844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the "target" range of a canonical integral type, i.e. 40241844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// the range of values expressible in the type. 40251844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// 40261844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// This matches forValueOfCanonicalType except that enums have the 40271844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// full range of their type, not the range of their enumerators. 40281844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 40291844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(T->isCanonicalUnqualified()); 40301844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 40311844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 40321844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = VT->getElementType().getTypePtr(); 40331844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 40341844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = CT->getElementType().getTypePtr(); 40351844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) 403669ff26bd1e7a2faffec0c3b9740cfb0c6bb354c5Douglas Gregor T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr(); 40371844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 40381844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall const BuiltinType *BT = cast<BuiltinType>(T); 40391844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(BT->isInteger()); 40401844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 40411844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 40421844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall } 40431844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 40441844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the supremum of two ranges: i.e. their conservative merge. 4045c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange join(IntRange L, IntRange R) { 4046f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(std::max(L.Width, R.Width), 404760fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative && R.NonNegative); 404860fad45739b764886f707bd204eae9ecce6db1f2John McCall } 404960fad45739b764886f707bd204eae9ecce6db1f2John McCall 40501844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the infinum of two ranges: i.e. their aggressive merge. 4051c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange meet(IntRange L, IntRange R) { 405260fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange(std::min(L.Width, R.Width), 405360fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative || R.NonNegative); 405451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 4055f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}; 405651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 40570692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, 40580692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek unsigned MaxWidth) { 4059f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isSigned() && value.isNegative()) 4060f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getMinSignedBits(), false); 406151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4062f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.getBitWidth() > MaxWidth) 40639f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad value = value.trunc(MaxWidth); 406451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4065f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // isNonNegative() just checks the sign bit without considering 4066f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // signedness. 4067f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getActiveBits(), true); 406851313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 406951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 40700692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 40710692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek unsigned MaxWidth) { 4072f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isInt()) 4073f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetValueRange(C, result.getInt(), MaxWidth); 407451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4075f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isVector()) { 40760acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 40770acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 40780acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 40790acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall R = IntRange::join(R, El); 40800acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall } 4081f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return R; 408251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 408351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4084f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isComplexInt()) { 4085f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 4086f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 4087f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(R, I); 4088f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 4089f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4090f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // This can happen with lossless casts to intptr_t of "based" lvalues. 4091f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume it might use arbitrary bits. 40920acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // FIXME: The only reason we need to pass the type in here is to get 40930acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // the sign right on this one case. It would be nice if APValue 40940acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // preserved this. 409565639284118d54ddf2e51a05d2ffccda567fe246Eli Friedman assert(result.isLValue() || result.isAddrLabelDiff()); 40965e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType()); 409751313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 409851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4099f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the 4100f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take. 4101f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 4102f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated 41030692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 410451313c39c84407dd6a323be99a8c322bf8d052a9John McCall E = E->IgnoreParens(); 410551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4106f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Try a full evaluation first. 4107f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall Expr::EvalResult result; 410851f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, C)) 41090acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall return GetValueRange(C, result.Val, E->getType(), MaxWidth); 411051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4111f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // I think we only want to look through implicit casts here; if the 4112f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // user has an explicit widening cast, we should treat the value as 4113f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // being of the new, wider type. 4114f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 4115b17ee5bff0d7986c14cdddb279e0131bd7f9678dEli Friedman if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue) 4116f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CE->getSubExpr(), MaxWidth); 411751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 41181844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType()); 411951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 41202de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 412160fad45739b764886f707bd204eae9ecce6db1f2John McCall 4122f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume that non-integer casts can span the full range of the type. 412360fad45739b764886f707bd204eae9ecce6db1f2John McCall if (!isIntegerCast) 4124f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 412551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4126f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange SubRange 4127f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall = GetExprRange(C, CE->getSubExpr(), 4128f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall std::min(MaxWidth, OutputTypeRange.Width)); 412951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4130f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Bail out if the subexpr's range is as wide as the cast type. 4131f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SubRange.Width >= OutputTypeRange.Width) 4132f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 413351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4134f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, we take the smaller width, and we're non-negative if 4135f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // either the output type or the subexpr is. 4136f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(SubRange.Width, 4137f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall SubRange.NonNegative || OutputTypeRange.NonNegative); 4138f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 4139f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4140f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 4141f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // If we can fold the condition, just take that operand. 4142f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool CondResult; 4143f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 4144f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CondResult ? CO->getTrueExpr() 4145f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : CO->getFalseExpr(), 4146f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall MaxWidth); 4147f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4148f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, conservatively merge. 4149f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 4150f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 4151f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 415251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 415351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 415451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 415551313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (BO->getOpcode()) { 415651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4157f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Boolean-valued operations are single-bit and positive. 41582de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LAnd: 41592de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LOr: 41602de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LT: 41612de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GT: 41622de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LE: 41632de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GE: 41642de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_EQ: 41652de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_NE: 4166f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 416751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4168862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // The type of the assignments is the type of the LHS, so the RHS 4169862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // is not necessarily the same type. 41702de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_MulAssign: 41712de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_DivAssign: 41722de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_RemAssign: 41732de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AddAssign: 41742de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_SubAssign: 4175862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_XorAssign: 4176862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_OrAssign: 4177862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 41781844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 4179c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall 4180862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // Simple assignments just pass through the RHS, which will have 4181862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // been coerced to the LHS type. 4182862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_Assign: 4183862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 4184862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 4185862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall 418651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 41872de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemD: 41882de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemI: 41891844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 419051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 419160fad45739b764886f707bd204eae9ecce6db1f2John McCall // Bitwise-and uses the *infinum* of the two source ranges. 41922de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_And: 41932de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AndAssign: 419460fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 419560fad45739b764886f707bd204eae9ecce6db1f2John McCall GetExprRange(C, BO->getRHS(), MaxWidth)); 419660fad45739b764886f707bd204eae9ecce6db1f2John McCall 419751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Left shift gets black-listed based on a judgement call. 41982de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shl: 41993aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // ...except that we want to treat '1 << (blah)' as logically 42003aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // positive. It's an important idiom. 42013aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (IntegerLiteral *I 42023aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 42033aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (I->getValue() == 1) { 42041844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange R = IntRange::forValueOfType(C, E->getType()); 42053aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall return IntRange(R.Width, /*NonNegative*/ true); 42063aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 42073aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 42083aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // fallthrough 42093aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall 42102de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShlAssign: 42111844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 421251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 421360fad45739b764886f707bd204eae9ecce6db1f2John McCall // Right shift by a constant can narrow its left argument. 42142de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shr: 42152de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShrAssign: { 421660fad45739b764886f707bd204eae9ecce6db1f2John McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 421760fad45739b764886f707bd204eae9ecce6db1f2John McCall 421860fad45739b764886f707bd204eae9ecce6db1f2John McCall // If the shift amount is a positive constant, drop the width by 421960fad45739b764886f707bd204eae9ecce6db1f2John McCall // that much. 422060fad45739b764886f707bd204eae9ecce6db1f2John McCall llvm::APSInt shift; 422160fad45739b764886f707bd204eae9ecce6db1f2John McCall if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 422260fad45739b764886f707bd204eae9ecce6db1f2John McCall shift.isNonNegative()) { 422360fad45739b764886f707bd204eae9ecce6db1f2John McCall unsigned zext = shift.getZExtValue(); 422460fad45739b764886f707bd204eae9ecce6db1f2John McCall if (zext >= L.Width) 422560fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width = (L.NonNegative ? 0 : 1); 422660fad45739b764886f707bd204eae9ecce6db1f2John McCall else 422760fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width -= zext; 422860fad45739b764886f707bd204eae9ecce6db1f2John McCall } 422960fad45739b764886f707bd204eae9ecce6db1f2John McCall 423060fad45739b764886f707bd204eae9ecce6db1f2John McCall return L; 423160fad45739b764886f707bd204eae9ecce6db1f2John McCall } 423260fad45739b764886f707bd204eae9ecce6db1f2John McCall 423360fad45739b764886f707bd204eae9ecce6db1f2John McCall // Comma acts as its right operand. 42342de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Comma: 4235f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 4236f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 423760fad45739b764886f707bd204eae9ecce6db1f2John McCall // Black-list pointer subtractions. 42382de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Sub: 423951313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BO->getLHS()->getType()->isPointerType()) 42401844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 424100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall break; 424200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 424300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The width of a division result is mostly determined by the size 424400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // of the LHS. 424500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Div: { 424600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 424700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 424800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 424900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 425000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // If the divisor is constant, use that. 425100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall llvm::APSInt divisor; 425200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) { 425300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned log2 = divisor.logBase2(); // floor(log_2(divisor)) 425400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (log2 >= L.Width) 425500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = (L.NonNegative ? 0 : 1); 425600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall else 425700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = std::min(L.Width - log2, MaxWidth); 425800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return L; 425900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 426000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 426100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Otherwise, just use the LHS's width. 426200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 426300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return IntRange(L.Width, L.NonNegative && R.NonNegative); 426400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 426500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 426600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The result of a remainder can't be larger than the result of 426700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // either side. 426800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Rem: { 426900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 427000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 427100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 427200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 427300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 427400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange meet = IntRange::meet(L, R); 427500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall meet.Width = std::min(meet.Width, MaxWidth); 427600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return meet; 427700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 42784e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 427900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default behavior is okay for these. 428000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Mul: 428100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Add: 428200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Xor: 428300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Or: 4284f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall break; 428551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 4286f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 428700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default case is to treat the operation as if it were closed 428800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // on the narrowest type that encompasses both operands. 4289f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 4290f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 4291f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 429251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 429351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 429451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 429551313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (UO->getOpcode()) { 429651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Boolean-valued operations are white-listed. 42972de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_LNot: 4298f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 429951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 430051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 43012de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_Deref: 43022de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_AddrOf: // should be impossible 43031844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 430451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 430551313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 4306f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, UO->getSubExpr(), MaxWidth); 430751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 430851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 43098ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor 43108ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor if (dyn_cast<OffsetOfExpr>(E)) { 43111844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange::forValueOfType(C, E->getType()); 43128ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor } 431351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4314993f43f24d7a45a5cd4678a3316b0852261fc5d4John McCall if (FieldDecl *BitField = E->getSourceBitField()) 4315a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith return IntRange(BitField->getBitWidthValue(C), 43165e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor BitField->getType()->isUnsignedIntegerOrEnumerationType()); 4317f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 43181844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 4319f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 4320f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 43210692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E) { 4322323ed74658bc8375278eabf074b4777458376540John McCall return GetExprRange(C, E, C.getIntWidth(E->getType())); 4323323ed74658bc8375278eabf074b4777458376540John McCall} 4324323ed74658bc8375278eabf074b4777458376540John McCall 4325f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 4326f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 4327f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 43280692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const llvm::APFloat &value, 43290692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Src, 43300692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Tgt) { 4331f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APFloat truncated = value; 4332f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4333f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool ignored; 4334f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 4335f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 4336f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4337f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return truncated.bitwiseIsEqual(value); 433851313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 433951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4340f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 4341f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 4342f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 4343f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 4344f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number). 43450692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const APValue &value, 43460692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Src, 43470692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Tgt) { 4348f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isFloat()) 4349f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 4350f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4351f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isVector()) { 4352f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 4353f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 4354f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return false; 4355f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return true; 4356f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 4357f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4358f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(value.isComplexFloat()); 4359f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 4360f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 4361f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 4362f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 43630692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 4364323ed74658bc8375278eabf074b4777458376540John McCall 4365e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) { 4366e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where we are comparing against an enum constant. 4367e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (const DeclRefExpr *DR = 4368e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 4369e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (isa<EnumConstantDecl>(DR->getDecl())) 4370e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 4371e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 4372e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where the '0' value is expanded from a macro. 4373e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (E->getLocStart().isMacroID()) 4374e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 4375e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 4376323ed74658bc8375278eabf074b4777458376540John McCall llvm::APSInt Value; 4377323ed74658bc8375278eabf074b4777458376540John McCall return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 4378323ed74658bc8375278eabf074b4777458376540John McCall} 4379323ed74658bc8375278eabf074b4777458376540John McCall 4380372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) { 4381372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall // Strip off implicit integral promotions. 4382372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 438363b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis if (ICE->getCastKind() != CK_IntegralCast && 438463b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis ICE->getCastKind() != CK_NoOp) 4385372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall break; 438663b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis E = ICE->getSubExpr(); 4387372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall } 4388372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 4389372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall return E->getType()->isEnumeralType(); 4390372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall} 4391372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 43920692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 43932de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = E->getOpcode(); 439414af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor if (E->isValueDependent()) 439514af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor return; 439614af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor 43972de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op == BO_LT && IsZero(S, E->getRHS())) { 4398323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 4399372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "< 0" << "false" << HasEnumType(E->getLHS()) 4400323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 44012de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GE && IsZero(S, E->getRHS())) { 4402323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 4403372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << ">= 0" << "true" << HasEnumType(E->getLHS()) 4404323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 44052de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GT && IsZero(S, E->getLHS())) { 4406323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 4407372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 >" << "false" << HasEnumType(E->getRHS()) 4408323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 44092de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_LE && IsZero(S, E->getLHS())) { 4410323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 4411372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 <=" << "true" << HasEnumType(E->getRHS()) 4412323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 4413323ed74658bc8375278eabf074b4777458376540John McCall } 4414323ed74658bc8375278eabf074b4777458376540John McCall} 4415323ed74658bc8375278eabf074b4777458376540John McCall 441615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanianstatic void DiagnoseOutOfRangeComparison(Sema &S, BinaryOperator *E, 4417a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian Expr *Constant, Expr *Other, 441815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian llvm::APSInt Value, 4419a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian bool RhsConstant) { 4420526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // 0 values are handled later by CheckTrivialUnsignedComparison(). 4421526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (Value == 0) 4422526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4423526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 442415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian BinaryOperatorKind op = E->getOpcode(); 4425a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian QualType OtherT = Other->getType(); 4426a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian QualType ConstantT = Constant->getType(); 4427526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu QualType CommonT = E->getLHS()->getType(); 4428a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian if (S.Context.hasSameUnqualifiedType(OtherT, ConstantT)) 442915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian return; 4430a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian assert((OtherT->isIntegerType() && ConstantT->isIntegerType()) 443115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian && "comparison with non-integer type"); 4432526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4433526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool ConstantSigned = ConstantT->isSignedIntegerType(); 4434526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool CommonSigned = CommonT->isSignedIntegerType(); 4435526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4436526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool EqualityOnly = false; 4437526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4438526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // TODO: Investigate using GetExprRange() to get tighter bounds on 4439526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // on the bit ranges. 444015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian IntRange OtherRange = IntRange::forValueOfType(S.Context, OtherT); 4441526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu unsigned OtherWidth = OtherRange.Width; 4442526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4443526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (CommonSigned) { 4444526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // The common type is signed, therefore no signed to unsigned conversion. 4445d87de7bdbc25dd84ae3dbefffda4539c443000d2Eli Friedman if (!OtherRange.NonNegative) { 4446526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check that the constant is representable in type OtherT. 4447526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (ConstantSigned) { 4448526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getMinSignedBits()) 4449526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4450526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !ConstantSigned 4451526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getActiveBits() + 1) 4452526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4453526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4454526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !OtherSigned 4455526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check that the constant is representable in type OtherT. 4456526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Negative values are out of range. 4457526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (ConstantSigned) { 4458526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (Value.isNonNegative() && OtherWidth >= Value.getActiveBits()) 4459526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4460526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !ConstantSigned 4461526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getActiveBits()) 4462526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4463526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4464526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4465526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // !CommonSigned 4466d87de7bdbc25dd84ae3dbefffda4539c443000d2Eli Friedman if (OtherRange.NonNegative) { 4467526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth >= Value.getActiveBits()) 4468526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4469d87de7bdbc25dd84ae3dbefffda4539c443000d2Eli Friedman } else if (!OtherRange.NonNegative && !ConstantSigned) { 4470526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check to see if the constant is representable in OtherT. 4471526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (OtherWidth > Value.getActiveBits()) 4472526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4473526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // Check to see if the constant is equivalent to a negative value 4474526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // cast to CommonT. 4475526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (S.Context.getIntWidth(ConstantT) == S.Context.getIntWidth(CommonT) && 44765d1cf4f292cb060b1973eb197607fc6d5716bd12Richard Trieu Value.isNegative() && Value.getMinSignedBits() <= OtherWidth) 4477526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4478526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // The constant value rests between values that OtherT can represent after 4479526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // conversion. Relational comparison still works, but equality 4480526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu // comparisons will be tautological. 4481526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu EqualityOnly = true; 4482526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else { // OtherSigned && ConstantSigned 4483526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu assert(0 && "Two signed types converted to unsigned types."); 4484526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4485526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } 4486526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 4487526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu bool PositiveConstant = !ConstantSigned || Value.isNonNegative(); 4488526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu 448915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsTrue = true; 4490526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu if (op == BO_EQ || op == BO_NE) { 4491526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = op == BO_NE; 4492526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else if (EqualityOnly) { 4493526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu return; 4494526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu } else if (RhsConstant) { 449515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (op == BO_GT || op == BO_GE) 4496526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = !PositiveConstant; 449715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else // op == BO_LT || op == BO_LE 4498526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = PositiveConstant; 4499a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian } else { 450015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (op == BO_LT || op == BO_LE) 4501526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = !PositiveConstant; 450215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else // op == BO_GT || op == BO_GE 4503526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu IsTrue = PositiveConstant; 450415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian } 45057adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek 45067adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek // If this is a comparison to an enum constant, include that 45077adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek // constant in the diagnostic. 45087adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek const EnumConstantDecl *ED = 0; 45097adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Constant)) 45107adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek ED = dyn_cast<EnumConstantDecl>(DR->getDecl()); 45117adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek 45127adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek SmallString<64> PrettySourceValue; 45137adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek llvm::raw_svector_ostream OS(PrettySourceValue); 45147adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek if (ED) 45159de50947ba381561a5236b3c878c83e4bb8c1088Ted Kremenek OS << '\'' << *ED << "' (" << Value << ")"; 45167adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek else 45177adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek OS << Value; 45187adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek 4519a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian S.Diag(E->getOperatorLoc(), diag::warn_out_of_range_compare) 45207adf3a9f84688f334a1cd977317bb42f9e06c9f4Ted Kremenek << OS.str() << OtherT << IsTrue 4521526e627d2bd7e8cbf630526d315c90864898d9ffRichard Trieu << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 452215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian} 452315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4524323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison. Implements the 4525323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison. 45260692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 4527b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 4528b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 4529323ed74658bc8375278eabf074b4777458376540John McCall} 4530f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4531ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare. 4532ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// 4533dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu/// \param E the binary operator to check for warnings 45340692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeComparison(Sema &S, BinaryOperator *E) { 4535323ed74658bc8375278eabf074b4777458376540John McCall // The type the comparison is being performed in. 4536323ed74658bc8375278eabf074b4777458376540John McCall QualType T = E->getLHS()->getType(); 4537323ed74658bc8375278eabf074b4777458376540John McCall assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 4538323ed74658bc8375278eabf074b4777458376540John McCall && "comparison with mismatched types"); 4539ab4702febef82409773f7c80ec02d53ddbb4d80eFariborz Jahanian if (E->isValueDependent()) 4540ab4702febef82409773f7c80ec02d53ddbb4d80eFariborz Jahanian return AnalyzeImpConvsInComparison(S, E); 4541323ed74658bc8375278eabf074b4777458376540John McCall 454215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian Expr *LHS = E->getLHS()->IgnoreParenImpCasts(); 454315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian Expr *RHS = E->getRHS()->IgnoreParenImpCasts(); 454415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 454515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsComparisonConstant = false; 454615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4547a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian // Check whether an integer constant comparison results in a value 454815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian // of 'true' or 'false'. 454915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (T->isIntegralType(S.Context)) { 455015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian llvm::APSInt RHSValue; 455115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsRHSIntegralLiteral = 455215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian RHS->isIntegerConstantExpr(RHSValue, S.Context); 455315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian llvm::APSInt LHSValue; 455415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsLHSIntegralLiteral = 455515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian LHS->isIntegerConstantExpr(LHSValue, S.Context); 455615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (IsRHSIntegralLiteral && !IsLHSIntegralLiteral) 455715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian DiagnoseOutOfRangeComparison(S, E, RHS, LHS, RHSValue, true); 455815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else if (!IsRHSIntegralLiteral && IsLHSIntegralLiteral) 455915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian DiagnoseOutOfRangeComparison(S, E, LHS, RHS, LHSValue, false); 456015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else 456115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian IsComparisonConstant = 456215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian (IsRHSIntegralLiteral && IsLHSIntegralLiteral); 4563a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian } else if (!T->hasUnsignedIntegerRepresentation()) 4564a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian IsComparisonConstant = E->isIntegerConstantExpr(S.Context); 456515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4566323ed74658bc8375278eabf074b4777458376540John McCall // We don't do anything special if this isn't an unsigned integral 4567323ed74658bc8375278eabf074b4777458376540John McCall // comparison: we're only interested in integral comparisons, and 4568323ed74658bc8375278eabf074b4777458376540John McCall // signed comparisons only happen in cases we don't care to warn about. 45693e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // 45703e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // We also don't care about value-dependent expressions or expressions 45713e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // whose result is a constant. 457215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (!T->hasUnsignedIntegerRepresentation() || IsComparisonConstant) 4573323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 457415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4575323ed74658bc8375278eabf074b4777458376540John McCall // Check to see if one of the (unmodified) operands is of different 4576323ed74658bc8375278eabf074b4777458376540John McCall // signedness. 4577323ed74658bc8375278eabf074b4777458376540John McCall Expr *signedOperand, *unsignedOperand; 4578dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu if (LHS->getType()->hasSignedIntegerRepresentation()) { 4579dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu assert(!RHS->getType()->hasSignedIntegerRepresentation() && 4580323ed74658bc8375278eabf074b4777458376540John McCall "unsigned comparison between two signed integer expressions?"); 4581dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = LHS; 4582dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = RHS; 4583dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu } else if (RHS->getType()->hasSignedIntegerRepresentation()) { 4584dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = RHS; 4585dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = LHS; 4586ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } else { 4587323ed74658bc8375278eabf074b4777458376540John McCall CheckTrivialUnsignedComparison(S, E); 4588323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 4589ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } 4590ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4591323ed74658bc8375278eabf074b4777458376540John McCall // Otherwise, calculate the effective range of the signed operand. 4592323ed74658bc8375278eabf074b4777458376540John McCall IntRange signedRange = GetExprRange(S.Context, signedOperand); 4593f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4594323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and analyze implicit conversions in the operands. Note 4595323ed74658bc8375278eabf074b4777458376540John McCall // that we skip the implicit conversions on both sides. 4596dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc()); 4597dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc()); 4598ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4599323ed74658bc8375278eabf074b4777458376540John McCall // If the signed range is non-negative, -Wsign-compare won't fire, 4600323ed74658bc8375278eabf074b4777458376540John McCall // but we should still check for comparisons which are always true 4601323ed74658bc8375278eabf074b4777458376540John McCall // or false. 4602323ed74658bc8375278eabf074b4777458376540John McCall if (signedRange.NonNegative) 4603323ed74658bc8375278eabf074b4777458376540John McCall return CheckTrivialUnsignedComparison(S, E); 4604ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4605ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // For (in)equality comparisons, if the unsigned operand is a 4606ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // constant which cannot collide with a overflowed signed operand, 4607ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // then reinterpreting the signed operand as unsigned will not 4608ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // change the result of the comparison. 4609323ed74658bc8375278eabf074b4777458376540John McCall if (E->isEqualityOp()) { 4610323ed74658bc8375278eabf074b4777458376540John McCall unsigned comparisonWidth = S.Context.getIntWidth(T); 4611323ed74658bc8375278eabf074b4777458376540John McCall IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 4612323ed74658bc8375278eabf074b4777458376540John McCall 4613323ed74658bc8375278eabf074b4777458376540John McCall // We should never be unable to prove that the unsigned operand is 4614323ed74658bc8375278eabf074b4777458376540John McCall // non-negative. 4615323ed74658bc8375278eabf074b4777458376540John McCall assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 4616ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4617323ed74658bc8375278eabf074b4777458376540John McCall if (unsignedRange.Width < comparisonWidth) 4618323ed74658bc8375278eabf074b4777458376540John McCall return; 4619323ed74658bc8375278eabf074b4777458376540John McCall } 4620323ed74658bc8375278eabf074b4777458376540John McCall 46216d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor S.DiagRuntimeBehavior(E->getOperatorLoc(), E, 46226d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor S.PDiag(diag::warn_mixed_sign_comparison) 46236d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor << LHS->getType() << RHS->getType() 46246d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor << LHS->getSourceRange() << RHS->getSourceRange()); 4625ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall} 4626ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 462715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield. 462815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// 462915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt. 46300692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 46310692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek SourceLocation InitLoc) { 463215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall assert(Bitfield->isBitField()); 463315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Bitfield->isInvalidDecl()) 463415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 463515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 463691b6014876e9186f968f74a8975ab8fc08ef1b68John McCall // White-list bool bitfields. 463791b6014876e9186f968f74a8975ab8fc08ef1b68John McCall if (Bitfield->getType()->isBooleanType()) 463891b6014876e9186f968f74a8975ab8fc08ef1b68John McCall return false; 463991b6014876e9186f968f74a8975ab8fc08ef1b68John McCall 464046ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor // Ignore value- or type-dependent expressions. 464146ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor if (Bitfield->getBitWidth()->isValueDependent() || 464246ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Bitfield->getBitWidth()->isTypeDependent() || 464346ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isValueDependent() || 464446ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isTypeDependent()) 464546ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor return false; 464646ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor 464715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *OriginalInit = Init->IgnoreParenImpCasts(); 464815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 464980d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith llvm::APSInt Value; 465080d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith if (!OriginalInit->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects)) 465115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 465215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 465315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned OriginalWidth = Value.getBitWidth(); 4654a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context); 465515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 465615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (OriginalWidth <= FieldWidth) 465715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 465815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 46593a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Compute the value which the bitfield will contain. 46609f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad llvm::APSInt TruncatedValue = Value.trunc(FieldWidth); 46613a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman TruncatedValue.setIsSigned(Bitfield->getType()->isSignedIntegerType()); 466215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 46633a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Check whether the stored value is equal to the original value. 46643a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman TruncatedValue = TruncatedValue.extend(OriginalWidth); 4665e1ecdc168175719d74e112bcacd4aae5e12d4631Richard Trieu if (llvm::APSInt::isSameValue(Value, TruncatedValue)) 466615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 466715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 46683a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Special-case bitfields of width 1: booleans are naturally 0/1, and 466934ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman // therefore don't strictly fit into a signed bitfield of width 1. 467034ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman if (FieldWidth == 1 && Value == 1) 46713a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman return false; 46723a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman 467315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyValue = Value.toString(10); 467415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyTrunc = TruncatedValue.toString(10); 467515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 467615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 467715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << PrettyValue << PrettyTrunc << OriginalInit->getType() 467815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << Init->getSourceRange(); 467915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 468015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return true; 468115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 468215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 4683beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy 4684beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations. 46850692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeAssignment(Sema &S, BinaryOperator *E) { 4686beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Just recurse on the LHS. 4687beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 4688beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 4689beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // We want to recurse on the RHS as normal unless we're assigning to 4690beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // a bitfield. 4691993f43f24d7a45a5cd4678a3316b0852261fc5d4John McCall if (FieldDecl *Bitfield = E->getLHS()->getSourceBitField()) { 4692dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 469315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc())) { 469415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // Recurse, ignoring any implicit conversions on the RHS. 469515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 469615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc()); 4697beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4698beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4699beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 4700beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 4701beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall} 4702beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 470351313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 47040692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T, 4705c36bedc90c687caa71748480c60707ea4608b092Anna Zaks SourceLocation CContext, unsigned diag, 4706c36bedc90c687caa71748480c60707ea4608b092Anna Zaks bool pruneControlFlow = false) { 4707c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (pruneControlFlow) { 4708c36bedc90c687caa71748480c60707ea4608b092Anna Zaks S.DiagRuntimeBehavior(E->getExprLoc(), E, 4709c36bedc90c687caa71748480c60707ea4608b092Anna Zaks S.PDiag(diag) 4710c36bedc90c687caa71748480c60707ea4608b092Anna Zaks << SourceType << T << E->getSourceRange() 4711c36bedc90c687caa71748480c60707ea4608b092Anna Zaks << SourceRange(CContext)); 4712c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 4713c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 47145a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor S.Diag(E->getExprLoc(), diag) 47155a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor << SourceType << T << E->getSourceRange() << SourceRange(CContext); 47165a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor} 47175a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 4718e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 47190692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType T, 4720c36bedc90c687caa71748480c60707ea4608b092Anna Zaks SourceLocation CContext, unsigned diag, 4721c36bedc90c687caa71748480c60707ea4608b092Anna Zaks bool pruneControlFlow = false) { 4722c36bedc90c687caa71748480c60707ea4608b092Anna Zaks DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow); 4723e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth} 4724e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth 47259ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// Diagnose an implicit cast from a literal expression. Does not warn when the 47269ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// cast wouldn't lose information. 4727f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruthvoid DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T, 4728f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth SourceLocation CContext) { 47299ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay // Try to convert the literal exactly to an integer. If we can, don't warn. 4730f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth bool isExact = false; 47319ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay const llvm::APFloat &Value = FL->getValue(); 47323e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin llvm::APSInt IntegerValue(S.Context.getIntWidth(T), 47333e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin T->hasUnsignedIntegerRepresentation()); 47343e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin if (Value.convertToInteger(IntegerValue, 4735f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth llvm::APFloat::rmTowardZero, &isExact) 47369ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay == llvm::APFloat::opOK && isExact) 4737f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth return; 4738f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 4739be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie SmallString<16> PrettySourceValue; 4740be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie Value.toString(PrettySourceValue); 4741de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie SmallString<16> PrettyTargetValue; 4742be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (T->isSpecificBuiltinType(BuiltinType::Bool)) 4743be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie PrettyTargetValue = IntegerValue == 0 ? "false" : "true"; 4744be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie else 4745de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie IntegerValue.toString(PrettyTargetValue); 4746be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie 47479ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer) 4748be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie << FL->getType() << T.getUnqualifiedType() << PrettySourceValue 4749be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie << PrettyTargetValue << FL->getSourceRange() << SourceRange(CContext); 4750f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth} 4751f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 4752091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 4753091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Range.Width) return "0"; 4754091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 4755091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt ValueInRange = Value; 4756091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.setIsSigned(!Range.NonNegative); 47579f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad ValueInRange = ValueInRange.trunc(Range.Width); 4758091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return ValueInRange.toString(10); 4759091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall} 4760091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 476188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgstatic bool IsImplicitBoolFloatConversion(Sema &S, Expr *Ex, bool ToBool) { 476288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (!isa<ImplicitCastExpr>(Ex)) 476388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return false; 476488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 476588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *InnerE = Ex->IgnoreParenImpCasts(); 476688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *Target = S.Context.getCanonicalType(Ex->getType()).getTypePtr(); 476788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *Source = 476888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg S.Context.getCanonicalType(InnerE->getType()).getTypePtr(); 476988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (Target->isDependentType()) 477088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return false; 477188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 477288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const BuiltinType *FloatCandidateBT = 477388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg dyn_cast<BuiltinType>(ToBool ? Source : Target); 477488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *BoolCandidateType = ToBool ? Target : Source; 477588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 477688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return (BoolCandidateType->isSpecificBuiltinType(BuiltinType::Bool) && 477788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg FloatCandidateBT && (FloatCandidateBT->isFloatingPoint())); 477888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg} 477988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 478088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgvoid CheckImplicitArgumentConversions(Sema &S, CallExpr *TheCall, 478188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg SourceLocation CC) { 478288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg unsigned NumArgs = TheCall->getNumArgs(); 478388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg for (unsigned i = 0; i < NumArgs; ++i) { 478488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *CurrA = TheCall->getArg(i); 478588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (!IsImplicitBoolFloatConversion(S, CurrA, true)) 478688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg continue; 478788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 478888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg bool IsSwapped = ((i > 0) && 478988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsImplicitBoolFloatConversion(S, TheCall->getArg(i - 1), false)); 479088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsSwapped |= ((i < (NumArgs - 1)) && 479188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsImplicitBoolFloatConversion(S, TheCall->getArg(i + 1), false)); 479288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (IsSwapped) { 479388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Warn on this floating-point to bool conversion. 479488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg DiagnoseImpCast(S, CurrA->IgnoreParenImpCasts(), 479588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CurrA->getType(), CC, 479688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg diag::warn_impcast_floating_point_to_bool); 479788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 479888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 479988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg} 480088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 4801323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T, 4802dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov SourceLocation CC, bool *ICContext = 0) { 4803323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) return; 480451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4805323ed74658bc8375278eabf074b4777458376540John McCall const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 4806323ed74658bc8375278eabf074b4777458376540John McCall const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 4807323ed74658bc8375278eabf074b4777458376540John McCall if (Source == Target) return; 4808323ed74658bc8375278eabf074b4777458376540John McCall if (Target->isDependentType()) return; 480951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4810108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // If the conversion context location is invalid don't complain. We also 4811108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // don't want to emit a warning if the issue occurs from the expansion of 4812108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // a system macro. The problem is that 'getSpellingLoc()' is slow, so we 4813108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // delay this check as long as possible. Once we detect we are in that 4814108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // scenario, we just return. 4815ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (CC.isInvalid()) 4816b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return; 4817b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 4818f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Diagnose implicit casts to bool. 4819f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (Target->isSpecificBuiltinType(BuiltinType::Bool)) { 4820f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (isa<StringLiteral>(E)) 4821f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Warn on string literal to bool. Checks for string literals in logical 4822f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // expressions, for instances, assert(0 && "error here"), is prevented 4823f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // by a check in AnalyzeImplicitConversions(). 4824f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu return DiagnoseImpCast(S, E, T, CC, 4825f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu diag::warn_impcast_string_literal_to_bool); 4826e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (Source->isFunctionType()) { 4827e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // Warn on function to bool. Checks free functions and static member 4828e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // functions. Weakly imported functions are excluded from the check, 4829e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // since it's common to test their value to check whether the linker 4830e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // found a definition for them. 4831e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames ValueDecl *D = 0; 4832e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (DeclRefExpr* R = dyn_cast<DeclRefExpr>(E)) { 4833e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = R->getDecl(); 4834e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) { 4835e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = M->getMemberDecl(); 4836e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 4837e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames 4838e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (D && !D->isWeak()) { 483926b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu if (FunctionDecl* F = dyn_cast<FunctionDecl>(D)) { 484026b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu S.Diag(E->getExprLoc(), diag::warn_impcast_function_to_bool) 484126b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu << F << E->getSourceRange() << SourceRange(CC); 48422def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_silence) 48432def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion(E->getExprLoc(), "&"); 48442def77399ab3088106a2d61372344f5b7104e1a2David Blaikie QualType ReturnType; 48452def77399ab3088106a2d61372344f5b7104e1a2David Blaikie UnresolvedSet<4> NonTemplateOverloads; 48462def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.isExprCallable(*E, ReturnType, NonTemplateOverloads); 48472def77399ab3088106a2d61372344f5b7104e1a2David Blaikie if (!ReturnType.isNull() 48482def77399ab3088106a2d61372344f5b7104e1a2David Blaikie && ReturnType->isSpecificBuiltinType(BuiltinType::Bool)) 48492def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_call) 48502def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion( 48512def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()), "()"); 485226b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu return; 485326b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu } 4854e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 4855e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 4856f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 485751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 485851313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip vector types. 485951313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<VectorType>(Source)) { 4860ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<VectorType>(Target)) { 4861d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4862ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4863b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 4864ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 4865b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner 4866b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // If the vector cast is cast between two vectors of the same size, it is 4867b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // a bitcast, not a conversion. 4868b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target)) 4869b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner return; 487051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 487151313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 487251313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 487351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 487451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 487551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip complex types. 487651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<ComplexType>(Source)) { 4877ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<ComplexType>(Target)) { 4878d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4879ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4880ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4881b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 4882ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 488351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 488451313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 488551313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 488651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 488751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 488851313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 488951313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 489051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 489151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the source is floating point... 489251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT && SourceBT->isFloatingPoint()) { 489351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...and the target is floating point... 489451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (TargetBT && TargetBT->isFloatingPoint()) { 489551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...then warn if we're dropping FP rank. 489651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 489751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Builtin FP kinds are ordered by increasing FP rank. 489851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT->getKind() > TargetBT->getKind()) { 489951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Don't warn about float constants that are precisely 490051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // representable in the target type. 490151313c39c84407dd6a323be99a8c322bf8d052a9John McCall Expr::EvalResult result; 490251f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, S.Context)) { 490351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Value might be a float, a float vector, or a float complex. 490451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (IsSameFloatAfterCast(result.Val, 4905323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 4906323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 490751313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 490851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 490951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4910d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4911ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4912ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4913b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 491451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 491551313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 491651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 491751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4918ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // If the target is integral, always warn. 4919be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (TargetBT && TargetBT->isInteger()) { 4920d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4921ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4922ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4923a5b9332418f25338f118358e27303cd510d54107Chandler Carruth Expr *InnerE = E->IgnoreParenImpCasts(); 4924634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay // We also want to warn on, e.g., "int i = -1.234" 4925634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE)) 4926634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus) 4927634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay InnerE = UOp->getSubExpr()->IgnoreParenImpCasts(); 4928634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay 4929f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) { 4930f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth DiagnoseFloatingLiteralImpCast(S, FL, T, CC); 4931a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } else { 4932a5b9332418f25338f118358e27303cd510d54107Chandler Carruth DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 4933a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 4934a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 493551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 493688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // If the target is bool, warn if expr is a function or method call. 493788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (Target->isSpecificBuiltinType(BuiltinType::Bool) && 493888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg isa<CallExpr>(E)) { 493988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Check last argument of function call to see if it is an 494088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // implicit cast from a type matching the type the result 494188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // is being cast to. 494288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CallExpr *CEx = cast<CallExpr>(E); 494388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg unsigned NumArgs = CEx->getNumArgs(); 494488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (NumArgs > 0) { 494588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *LastA = CEx->getArg(NumArgs - 1); 494688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *InnerE = LastA->IgnoreParenImpCasts(); 494788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *InnerType = 494888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg S.Context.getCanonicalType(InnerE->getType()).getTypePtr(); 494988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (isa<ImplicitCastExpr>(LastA) && (InnerType == Target)) { 495088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Warn on this floating-point to bool conversion 495188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg DiagnoseImpCast(S, E, T, CC, 495288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg diag::warn_impcast_floating_point_to_bool); 495388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 495488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 495588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 495651313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 495751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 495851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 49591838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull) 4960b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie == Expr::NPCK_GNUNull) && !Target->isAnyPointerType() 4961e81b43bc306d361fcf4d411aeb14b43f8464bf4aDavid Blaikie && !Target->isBlockPointerType() && !Target->isMemberPointerType() 4962896c7dd62801c0aacf14b05183c3c471c1fe9f7aDavid Blaikie && Target->isScalarType() && !Target->isNullPtrType()) { 4963b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie SourceLocation Loc = E->getSourceRange().getBegin(); 4964b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie if (Loc.isMacroID()) 4965b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie Loc = S.SourceMgr.getImmediateExpansionRange(Loc).first; 49669fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie if (!Loc.isMacroID() || CC.isMacroID()) 49679fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie S.Diag(Loc, diag::warn_impcast_null_pointer_to_integer) 49689fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie << T << clang::SourceRange(CC) 49699fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie << FixItHint::CreateReplacement(Loc, S.getFixItZeroLiteralForType(T)); 49701838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu } 49711838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu 4972b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie if (!Source->isIntegerType() || !Target->isIntegerType()) 4973b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie return; 4974b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie 4975be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie // TODO: remove this early return once the false positives for constant->bool 4976be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie // in templates, macros, etc, are reduced or removed. 4977be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (Target->isSpecificBuiltinType(BuiltinType::Bool)) 4978be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie return; 4979be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie 4980323ed74658bc8375278eabf074b4777458376540John McCall IntRange SourceRange = GetExprRange(S.Context, E); 49811844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 498251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4983dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (SourceRange.Width > TargetRange.Width) { 498425ffbef84450f0c666957a2d00cdf928c61b44d7Sam Panzer // If the source is a constant, use a default-on diagnostic. 4985dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov // TODO: this should happen for bitfield stores, too. 4986dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov llvm::APSInt Value(32); 4987dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (E->isIntegerConstantExpr(Value, S.Context)) { 4988dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (S.SourceMgr.isInSystemMacro(CC)) 4989dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov return; 4990dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov 4991091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettySourceValue = Value.toString(10); 4992091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 4993dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov 49945e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.DiagRuntimeBehavior(E->getExprLoc(), E, 49955e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.PDiag(diag::warn_impcast_integer_precision_constant) 49965e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << PrettySourceValue << PrettyTargetValue 49975e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << E->getType() << T << E->getSourceRange() 49985e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << clang::SourceRange(CC)); 4999091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return; 5000091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall } 5001091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 5002dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov // People want to build with -Wshorten-64-to-32 and not -Wconversion. 5003dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (S.SourceMgr.isInSystemMacro(CC)) 5004dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov return; 5005dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov 500637050841d7b852497b85d5275d9ea92c07ddf059David Blaikie if (TargetRange.Width == 32 && S.Context.getIntWidth(E->getType()) == 64) 5007c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32, 5008c36bedc90c687caa71748480c60707ea4608b092Anna Zaks /* pruneControlFlow */ true); 5009b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 5010323ed74658bc8375278eabf074b4777458376540John McCall } 5011323ed74658bc8375278eabf074b4777458376540John McCall 5012323ed74658bc8375278eabf074b4777458376540John McCall if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 5013323ed74658bc8375278eabf074b4777458376540John McCall (!TargetRange.NonNegative && SourceRange.NonNegative && 5014323ed74658bc8375278eabf074b4777458376540John McCall SourceRange.Width == TargetRange.Width)) { 5015ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 5016d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 5017ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 5018ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 5019323ed74658bc8375278eabf074b4777458376540John McCall unsigned DiagID = diag::warn_impcast_integer_sign; 5020323ed74658bc8375278eabf074b4777458376540John McCall 5021323ed74658bc8375278eabf074b4777458376540John McCall // Traditionally, gcc has warned about this under -Wsign-compare. 5022323ed74658bc8375278eabf074b4777458376540John McCall // We also want to warn about it in -Wconversion. 5023323ed74658bc8375278eabf074b4777458376540John McCall // So if -Wconversion is off, use a completely identical diagnostic 5024323ed74658bc8375278eabf074b4777458376540John McCall // in the sign-compare group. 5025323ed74658bc8375278eabf074b4777458376540John McCall // The conditional-checking code will 5026323ed74658bc8375278eabf074b4777458376540John McCall if (ICContext) { 5027323ed74658bc8375278eabf074b4777458376540John McCall DiagID = diag::warn_impcast_integer_sign_conditional; 5028323ed74658bc8375278eabf074b4777458376540John McCall *ICContext = true; 5029323ed74658bc8375278eabf074b4777458376540John McCall } 5030323ed74658bc8375278eabf074b4777458376540John McCall 5031b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, DiagID); 503251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 503351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 5034284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor // Diagnose conversions between different enumeration types. 50355a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // In C, we pretend that the type of an EnumConstantDecl is its enumeration 50365a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // type, to give us better diagnostics. 50375a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor QualType SourceType = E->getType(); 50384e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (!S.getLangOpts().CPlusPlus) { 50395a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 50405a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) { 50415a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext()); 50425a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceType = S.Context.getTypeDeclType(Enum); 50435a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor Source = S.Context.getCanonicalType(SourceType).getTypePtr(); 50445a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 50455a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 50465a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 5047284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *SourceEnum = Source->getAs<EnumType>()) 5048284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *TargetEnum = Target->getAs<EnumType>()) 504983972f128e9218c051692bf96361327a701aeb79John McCall if (SourceEnum->getDecl()->hasNameForLinkage() && 505083972f128e9218c051692bf96361327a701aeb79John McCall TargetEnum->getDecl()->hasNameForLinkage() && 5051ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceEnum != TargetEnum) { 5052d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 5053ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 5054ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 50555a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor return DiagnoseImpCast(S, E, SourceType, T, CC, 5056284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor diag::warn_impcast_different_enum_types); 5057ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 5058284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor 505951313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 506051313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 506151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 50629fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, 50639fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie SourceLocation CC, QualType T); 5064323ed74658bc8375278eabf074b4777458376540John McCall 5065323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T, 5066b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool &ICContext) { 5067323ed74658bc8375278eabf074b4777458376540John McCall E = E->IgnoreParenImpCasts(); 5068323ed74658bc8375278eabf074b4777458376540John McCall 5069323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) 50709fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie return CheckConditionalOperator(S, cast<ConditionalOperator>(E), CC, T); 5071323ed74658bc8375278eabf074b4777458376540John McCall 5072b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E, CC); 5073323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 5074b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return CheckImplicitConversion(S, E, T, CC, &ICContext); 5075323ed74658bc8375278eabf074b4777458376540John McCall return; 5076323ed74658bc8375278eabf074b4777458376540John McCall} 5077323ed74658bc8375278eabf074b4777458376540John McCall 50789fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, 50799fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie SourceLocation CC, QualType T) { 5080b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getCond(), CC); 5081323ed74658bc8375278eabf074b4777458376540John McCall 5082323ed74658bc8375278eabf074b4777458376540John McCall bool Suspicious = false; 5083b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 5084b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 5085323ed74658bc8375278eabf074b4777458376540John McCall 5086323ed74658bc8375278eabf074b4777458376540John McCall // If -Wconversion would have warned about either of the candidates 5087323ed74658bc8375278eabf074b4777458376540John McCall // for a signedness conversion to the context type... 5088323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) return; 5089323ed74658bc8375278eabf074b4777458376540John McCall 5090323ed74658bc8375278eabf074b4777458376540John McCall // ...but it's currently ignored... 50910827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional, 50920827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis CC)) 5093323ed74658bc8375278eabf074b4777458376540John McCall return; 5094323ed74658bc8375278eabf074b4777458376540John McCall 5095323ed74658bc8375278eabf074b4777458376540John McCall // ...then check whether it would have warned about either of the 5096323ed74658bc8375278eabf074b4777458376540John McCall // candidates for a signedness conversion to the condition type. 50975254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (E->getType() == T) return; 50985254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu 50995254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu Suspicious = false; 51005254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 51015254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu E->getType(), CC, &Suspicious); 51025254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (!Suspicious) 51035254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 5104b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 5105323ed74658bc8375278eabf074b4777458376540John McCall} 5106323ed74658bc8375278eabf074b4777458376540John McCall 5107323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting 5108323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression. There are a couple 5109323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare. 5110b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 5111323ed74658bc8375278eabf074b4777458376540John McCall QualType T = OrigE->getType(); 5112323ed74658bc8375278eabf074b4777458376540John McCall Expr *E = OrigE->IgnoreParenImpCasts(); 5113323ed74658bc8375278eabf074b4777458376540John McCall 5114f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 5115f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor return; 5116f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor 5117323ed74658bc8375278eabf074b4777458376540John McCall // For conditional operators, we analyze the arguments as if they 5118323ed74658bc8375278eabf074b4777458376540John McCall // were being fed directly into the output. 5119323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) { 5120323ed74658bc8375278eabf074b4777458376540John McCall ConditionalOperator *CO = cast<ConditionalOperator>(E); 51219fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie CheckConditionalOperator(S, CO, CC, T); 5122323ed74658bc8375278eabf074b4777458376540John McCall return; 5123323ed74658bc8375278eabf074b4777458376540John McCall } 5124323ed74658bc8375278eabf074b4777458376540John McCall 512588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Check implicit argument conversions for function calls. 512688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (CallExpr *Call = dyn_cast<CallExpr>(E)) 512788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CheckImplicitArgumentConversions(S, Call, CC); 512888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 5129323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and check any implicit conversions we might have skipped. 5130323ed74658bc8375278eabf074b4777458376540John McCall // The non-canonical typecheck is just an optimization; 5131323ed74658bc8375278eabf074b4777458376540John McCall // CheckImplicitConversion will filter out dead implicit conversions. 5132323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 5133b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckImplicitConversion(S, E, T, CC); 5134323ed74658bc8375278eabf074b4777458376540John McCall 5135323ed74658bc8375278eabf074b4777458376540John McCall // Now continue drilling into this expression. 51366f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian 51376f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian if (PseudoObjectExpr * POE = dyn_cast<PseudoObjectExpr>(E)) { 51386f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian Expr *Result = POE->getResultExpr(); 51396f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian if (const OpaqueValueExpr *OVE = dyn_cast_or_null<OpaqueValueExpr>(Result)) 51406f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian return AnalyzeImplicitConversions(S, OVE->getSourceExpr(), CC); 51416f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian } 51426f2a9fa0f787d3023b643496e8c321bdb7a85fa0Fariborz Jahanian 5143323ed74658bc8375278eabf074b4777458376540John McCall // Skip past explicit casts. 5144323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ExplicitCastExpr>(E)) { 5145323ed74658bc8375278eabf074b4777458376540John McCall E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 5146b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return AnalyzeImplicitConversions(S, E, CC); 5147323ed74658bc8375278eabf074b4777458376540John McCall } 5148323ed74658bc8375278eabf074b4777458376540John McCall 5149beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 5150beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Do a somewhat different check with comparison operators. 5151beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isComparisonOp()) 5152beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeComparison(S, BO); 5153beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 5154dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov // And with simple assignments. 5155dff2be8ba441f5c61af8444479f7133b22dcfcf4Timur Iskhodzhanov if (BO->getOpcode() == BO_Assign) 5156beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeAssignment(S, BO); 5157beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 5158323ed74658bc8375278eabf074b4777458376540John McCall 5159323ed74658bc8375278eabf074b4777458376540John McCall // These break the otherwise-useful invariant below. Fortunately, 5160323ed74658bc8375278eabf074b4777458376540John McCall // we don't really need to recurse into them, because any internal 5161323ed74658bc8375278eabf074b4777458376540John McCall // expressions should have been analyzed already when they were 5162323ed74658bc8375278eabf074b4777458376540John McCall // built into statements. 5163323ed74658bc8375278eabf074b4777458376540John McCall if (isa<StmtExpr>(E)) return; 5164323ed74658bc8375278eabf074b4777458376540John McCall 5165323ed74658bc8375278eabf074b4777458376540John McCall // Don't descend into unevaluated contexts. 5166f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne if (isa<UnaryExprOrTypeTraitExpr>(E)) return; 5167323ed74658bc8375278eabf074b4777458376540John McCall 5168323ed74658bc8375278eabf074b4777458376540John McCall // Now just recurse over the expression's children. 5169b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CC = E->getExprLoc(); 5170f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu BinaryOperator *BO = dyn_cast<BinaryOperator>(E); 5171f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu bool IsLogicalOperator = BO && BO->isLogicalOp(); 5172f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu for (Stmt::child_range I = E->children(); I; ++I) { 517354042f1bd78f1f1ea86be7d4af541462e127d2edDouglas Gregor Expr *ChildExpr = dyn_cast_or_null<Expr>(*I); 5174503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor if (!ChildExpr) 5175503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor continue; 5176503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor 5177f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (IsLogicalOperator && 5178f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts())) 5179f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Ignore checking string literals that are in logical operators. 5180f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu continue; 5181f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu AnalyzeImplicitConversions(S, ChildExpr, CC); 5182f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 5183323ed74658bc8375278eabf074b4777458376540John McCall} 5184323ed74658bc8375278eabf074b4777458376540John McCall 5185323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace 5186323ed74658bc8375278eabf074b4777458376540John McCall 5187323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given 5188323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression). Implements -Wconversion 5189323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare. 5190b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// 5191b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e. 5192b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// the most location of the syntactic entity requiring the implicit 5193b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// conversion 5194b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 5195323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose in unevaluated contexts. 519671f55f771794674a410171dbf3cb5dbedf95d033David Blaikie if (isUnevaluatedContext()) 5197323ed74658bc8375278eabf074b4777458376540John McCall return; 5198323ed74658bc8375278eabf074b4777458376540John McCall 5199323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose for value- or type-dependent expressions. 5200323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) 5201323ed74658bc8375278eabf074b4777458376540John McCall return; 5202323ed74658bc8375278eabf074b4777458376540John McCall 5203d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Check for array bounds violations in cases where the check isn't triggered 5204d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // elsewhere for other Expr types (like BinaryOperators), e.g. when an 5205d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // ArraySubscriptExpr is on the RHS of a variable initialization. 5206d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain CheckArrayAccess(E); 5207d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5208b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // This is not the right CC for (e.g.) a variable initialization. 5209b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(*this, E, CC); 5210323ed74658bc8375278eabf074b4777458376540John McCall} 5211323ed74658bc8375278eabf074b4777458376540John McCall 5212ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian/// Diagnose when expression is an integer constant expression and its evaluation 5213ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian/// results in integer overflow 5214ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanianvoid Sema::CheckForIntOverflow (Expr *E) { 52151fd8d46d222fab7f17b91846e2c50bef640a60a0Fariborz Jahanian if (isa<BinaryOperator>(E->IgnoreParens())) { 5216ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian llvm::SmallVector<PartialDiagnosticAt, 4> Diags; 5217ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian E->EvaluateForOverflow(Context, &Diags); 5218ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian } 5219ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian} 5220ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian 52216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithnamespace { 52226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith/// \brief Visitor for expressions which looks for unsequenced operations on the 52236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith/// same object. 52246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithclass SequenceChecker : public EvaluatedExprVisitor<SequenceChecker> { 52256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief A tree of sequenced regions within an expression. Two regions are 52266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// unsequenced if one is an ancestor or a descendent of the other. When we 52276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// finish processing an expression with sequencing, such as a comma 52286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// expression, we fold its tree nodes into its parent, since they are 52296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// unsequenced with respect to nodes we will visit later. 52306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith class SequenceTree { 52316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct Value { 52326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith explicit Value(unsigned Parent) : Parent(Parent), Merged(false) {} 52336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned Parent : 31; 52346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Merged : 1; 52356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 52366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<Value, 8> Values; 52376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 52386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith public: 52396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief A region within an expression which may be sequenced with respect 52406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// to some other region. 52416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith class Seq { 52426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith explicit Seq(unsigned N) : Index(N) {} 52436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned Index; 52446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith friend class SequenceTree; 52456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith public: 52466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Seq() : Index(0) {} 52476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 52486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 52496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree() { Values.push_back(Value(0)); } 52506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Seq root() const { return Seq(0); } 52516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 52526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Create a new sequence of operations, which is an unsequenced 52536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// subset of \p Parent. This sequence of operations is sequenced with 52546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// respect to other children of \p Parent. 52556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Seq allocate(Seq Parent) { 52566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Values.push_back(Value(Parent.Index)); 52576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return Seq(Values.size() - 1); 52586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 52596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 52606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Merge a sequence of operations into its parent. 52616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void merge(Seq S) { 52626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Values[S.Index].Merged = true; 52636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 52646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 52656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Determine whether two operations are unsequenced. This operation 52666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// is asymmetric: \p Cur should be the more recent sequence, and \p Old 52676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// should have been merged into its parent as appropriate. 52686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool isUnsequenced(Seq Cur, Seq Old) { 52696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned C = representative(Cur.Index); 52706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned Target = representative(Old.Index); 52716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith while (C >= Target) { 52726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (C == Target) 52736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return true; 52746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith C = Values[C].Parent; 52756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 52766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return false; 52776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 52786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 52796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith private: 52806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Pick a representative for a sequence. 52816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith unsigned representative(unsigned K) { 52826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (Values[K].Merged) 52836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Perform path compression as we go. 52846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return Values[K].Parent = representative(Values[K].Parent); 52856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return K; 52866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 52876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 52886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 52896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// An object for which we can track unsequenced uses. 52906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith typedef NamedDecl *Object; 52916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 52926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Different flavors of object usage which we track. We only track the 52936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// least-sequenced usage of each kind. 52946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith enum UsageKind { 52956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// A read of an object. Multiple unsequenced reads are OK. 52966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_Use, 52976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// A modification of an object which is sequenced before the value 52986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// computation of the expression, such as ++n. 52996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_ModAsValue, 53006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// A modification of an object which is not sequenced before the value 53016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// computation of the expression, such as n++. 53026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_ModAsSideEffect, 53036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UK_Count = UK_ModAsSideEffect + 1 53056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 53066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct Usage { 53086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Usage() : Use(0), Seq() {} 53096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *Use; 53106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Seq; 53116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 53126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct UsageInfo { 53146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo() : Diagnosed(false) {} 53156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Usage Uses[UK_Count]; 53166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Have we issued a diagnostic for this variable already? 53176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Diagnosed; 53186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 53196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith typedef llvm::SmallDenseMap<Object, UsageInfo, 16> UsageInfoMap; 53206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Sema &SemaRef; 53226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Sequenced regions within the expression. 53236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree Tree; 53246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Declaration modifications and references which we have seen. 53256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfoMap UsageMap; 53266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// The region we are currently within. 53276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Region; 53286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Filled in with declarations which were modified as a side-effect 53296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// (that is, post-increment operations). 53306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVectorImpl<std::pair<Object, Usage> > *ModAsSideEffect; 53311a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith /// Expressions to check later. We defer checking these to reduce 53321a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith /// stack usage. 53331a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith llvm::SmallVectorImpl<Expr*> &WorkList; 53346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// RAII object wrapping the visitation of a sequenced subexpression of an 53366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// expression. At the end of this process, the side-effects of the evaluation 53376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// become sequenced with respect to the value computation of the result, so 53386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// we downgrade any UK_ModAsSideEffect within the evaluation to 53396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// UK_ModAsValue. 53406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith struct SequencedSubexpression { 53416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression(SequenceChecker &Self) 53426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith : Self(Self), OldModAsSideEffect(Self.ModAsSideEffect) { 53436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Self.ModAsSideEffect = &ModAsSideEffect; 53446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 53456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith ~SequencedSubexpression() { 53466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0, E = ModAsSideEffect.size(); I != E; ++I) { 53476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = Self.UsageMap[ModAsSideEffect[I].first]; 53486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith U.Uses[UK_ModAsSideEffect] = ModAsSideEffect[I].second; 53496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Self.addUsage(U, ModAsSideEffect[I].first, 53506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith ModAsSideEffect[I].second.Use, UK_ModAsValue); 53516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 53526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Self.ModAsSideEffect = OldModAsSideEffect; 53536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 53546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceChecker &Self; 53566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<std::pair<Object, Usage>, 4> ModAsSideEffect; 53576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVectorImpl<std::pair<Object, Usage> > *OldModAsSideEffect; 53586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith }; 53596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Find the object which is produced by the specified expression, 53616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// if any. 53626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object getObject(Expr *E, bool Mod) const { 53636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith E = E->IgnoreParenCasts(); 53646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 53656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (Mod && (UO->getOpcode() == UO_PreInc || UO->getOpcode() == UO_PreDec)) 53666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return getObject(UO->getSubExpr(), Mod); 53676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 53686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (BO->getOpcode() == BO_Comma) 53696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return getObject(BO->getRHS(), Mod); 53706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (Mod && BO->isAssignmentOp()) 53716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return getObject(BO->getLHS(), Mod); 53726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } else if (MemberExpr *ME = dyn_cast<MemberExpr>(E)) { 53736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // FIXME: Check for more interesting cases, like "x.n = ++x.n". 53746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (isa<CXXThisExpr>(ME->getBase()->IgnoreParenCasts())) 53756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return ME->getMemberDecl(); 53766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } else if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 53776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // FIXME: If this is a reference, map through to its value. 53786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return DRE->getDecl(); 53796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return 0; 53806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 53816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Note that an object was modified or used by an expression. 53836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void addUsage(UsageInfo &UI, Object O, Expr *Ref, UsageKind UK) { 53846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Usage &U = UI.Uses[UK]; 53856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!U.Use || !Tree.isUnsequenced(Region, U.Seq)) { 53866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (UK == UK_ModAsSideEffect && ModAsSideEffect) 53876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith ModAsSideEffect->push_back(std::make_pair(O, U)); 53886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith U.Use = Ref; 53896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith U.Seq = Region; 53906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 53916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 53926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// \brief Check whether a modification or use conflicts with a prior usage. 53936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void checkUsage(Object O, UsageInfo &UI, Expr *Ref, UsageKind OtherKind, 53946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool IsModMod) { 53956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (UI.Diagnosed) 53966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return; 53976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 53986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith const Usage &U = UI.Uses[OtherKind]; 53996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!U.Use || !Tree.isUnsequenced(Region, U.Seq)) 54006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return; 54016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *Mod = U.Use; 54036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *ModOrUse = Ref; 54046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (OtherKind == UK_Use) 54056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith std::swap(Mod, ModOrUse); 54066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SemaRef.Diag(Mod->getExprLoc(), 54086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith IsModMod ? diag::warn_unsequenced_mod_mod 54096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith : diag::warn_unsequenced_mod_use) 54106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith << O << SourceRange(ModOrUse->getExprLoc()); 54116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UI.Diagnosed = true; 54126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePreUse(Object O, Expr *Use) { 54156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 54166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Uses conflict with other modifications. 54176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Use, UK_ModAsValue, false); 54186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePostUse(Object O, Expr *Use) { 54206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 54216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Use, UK_ModAsSideEffect, false); 54226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith addUsage(U, O, Use, UK_Use); 54236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePreMod(Object O, Expr *Mod) { 54266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 54276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Modifications conflict with other modifications and with uses. 54286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Mod, UK_ModAsValue, true); 54296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Mod, UK_Use, false); 54306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void notePostMod(Object O, Expr *Use, UsageKind UK) { 54326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith UsageInfo &U = UsageMap[O]; 54336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith checkUsage(O, U, Use, UK_ModAsSideEffect, true); 54346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith addUsage(U, O, Use, UK); 54356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithpublic: 54381a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith SequenceChecker(Sema &S, Expr *E, 54391a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith llvm::SmallVectorImpl<Expr*> &WorkList) 5440e5096c8f2f2e64d5ac98531ff9aa952bbe60d5fcRichard Smith : EvaluatedExprVisitor<SequenceChecker>(S.Context), SemaRef(S), 54411a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith Region(Tree.root()), ModAsSideEffect(0), WorkList(WorkList) { 54426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(E); 54436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitStmt(Stmt *S) { 54466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Skip all statements which aren't expressions for now. 54476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitExpr(Expr *E) { 54506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // By default, just recurse to evaluated subexpressions. 5451e5096c8f2f2e64d5ac98531ff9aa952bbe60d5fcRichard Smith EvaluatedExprVisitor<SequenceChecker>::VisitStmt(E); 54526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitCastExpr(CastExpr *E) { 54556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = Object(); 54566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (E->getCastKind() == CK_LValueToRValue) 54576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith O = getObject(E->getSubExpr(), false); 54586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (O) 54606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreUse(O, E); 54616c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith VisitExpr(E); 54626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (O) 54636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePostUse(O, E); 54646c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54656c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinComma(BinaryOperator *BO) { 54676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // C++11 [expr.comma]p1: 54686c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Every value computation and side effect associated with the left 54696c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // expression is sequenced before every value computation and side 54706c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // effect associated with the right expression. 54716c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq LHS = Tree.allocate(Region); 54726c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq RHS = Tree.allocate(Region); 54736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq OldRegion = Region; 54746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith { 54766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression SeqLHS(*this); 54776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = LHS; 54786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 54796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = RHS; 54826c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getRHS()); 54836c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54846c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = OldRegion; 54856c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54866c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Forget that LHS and RHS are sequenced. They are both unsequenced 54876c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // with respect to other stuff. 54886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(LHS); 54896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(RHS); 54906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 54916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 54926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinAssign(BinaryOperator *BO) { 54936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // The modification is sequenced after the value computation of the LHS 54946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // and RHS, so check it before inspecting the operands and update the 54956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // map afterwards. 54966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = getObject(BO->getLHS(), true); 54976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!O) 54986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(BO); 54996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55006c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreMod(O, BO); 55016c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55026c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // C++11 [expr.ass]p7: 55036c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // E1 op= E2 is equivalent to E1 = E1 op E2, except that E1 is evaluated 55046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // only once. 55056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // 55066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Therefore, for a compound assignment operator, O is considered used 55076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // everywhere except within the evaluation of E1 itself. 55086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (isa<CompoundAssignOperator>(BO)) 55096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreUse(O, BO); 55106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 55126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (isa<CompoundAssignOperator>(BO)) 55146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePostUse(O, BO); 55156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getRHS()); 55176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePostMod(O, BO, UK_ModAsValue); 55196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitCompoundAssignOperator(CompoundAssignOperator *CAO) { 55216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith VisitBinAssign(CAO); 55226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPreInc(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); } 55256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPreDec(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); } 55266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPreIncDec(UnaryOperator *UO) { 55276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = getObject(UO->getSubExpr(), true); 55286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!O) 55296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(UO); 55306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreMod(O, UO); 55326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(UO->getSubExpr()); 55336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePostMod(O, UO, UK_ModAsValue); 55346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPostInc(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); } 55376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPostDec(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); } 55386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitUnaryPostIncDec(UnaryOperator *UO) { 55396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Object O = getObject(UO->getSubExpr(), true); 55406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!O) 55416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(UO); 55426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePreMod(O, UO); 55446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(UO->getSubExpr()); 55456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith notePostMod(O, UO, UK_ModAsSideEffect); 55466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith /// Don't visit the RHS of '&&' or '||' if it might not be evaluated. 55496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinLOr(BinaryOperator *BO) { 55506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // The side-effects of the LHS of an '&&' are sequenced before the 55516c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // value computation of the RHS, and hence before the value computation 55526c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // of the '&&' itself, unless the LHS evaluates to zero. We treat them 55536c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // as if they were unconditionally sequenced. 55546c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith { 55556c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression Sequenced(*this); 55566c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 55576c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Result; 55606c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!BO->getLHS()->isValueDependent() && 5561995e4a7530d705147c875b63608532c483c011a8Richard Smith BO->getLHS()->EvaluateAsBooleanCondition(Result, SemaRef.Context)) { 5562995e4a7530d705147c875b63608532c483c011a8Richard Smith if (!Result) 5563995e4a7530d705147c875b63608532c483c011a8Richard Smith Visit(BO->getRHS()); 5564995e4a7530d705147c875b63608532c483c011a8Richard Smith } else { 5565995e4a7530d705147c875b63608532c483c011a8Richard Smith // Check for unsequenced operations in the RHS, treating it as an 5566995e4a7530d705147c875b63608532c483c011a8Richard Smith // entirely separate evaluation. 5567995e4a7530d705147c875b63608532c483c011a8Richard Smith // 5568995e4a7530d705147c875b63608532c483c011a8Richard Smith // FIXME: If there are operations in the RHS which are unsequenced 5569995e4a7530d705147c875b63608532c483c011a8Richard Smith // with respect to operations outside the RHS, and those operations 5570995e4a7530d705147c875b63608532c483c011a8Richard Smith // are unconditionally evaluated, diagnose them. 55711a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(BO->getRHS()); 5572995e4a7530d705147c875b63608532c483c011a8Richard Smith } 55736c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55746c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitBinLAnd(BinaryOperator *BO) { 55756c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith { 55766c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression Sequenced(*this); 55776c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(BO->getLHS()); 55786c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55796c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55806c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Result; 55816c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!BO->getLHS()->isValueDependent() && 5582995e4a7530d705147c875b63608532c483c011a8Richard Smith BO->getLHS()->EvaluateAsBooleanCondition(Result, SemaRef.Context)) { 5583995e4a7530d705147c875b63608532c483c011a8Richard Smith if (Result) 5584995e4a7530d705147c875b63608532c483c011a8Richard Smith Visit(BO->getRHS()); 5585995e4a7530d705147c875b63608532c483c011a8Richard Smith } else { 55861a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(BO->getRHS()); 5587995e4a7530d705147c875b63608532c483c011a8Richard Smith } 55886c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 55896c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55906c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Only visit the condition, unless we can be sure which subexpression will 55916c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // be chosen. 55926c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitAbstractConditionalOperator(AbstractConditionalOperator *CO) { 55936c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequencedSubexpression Sequenced(*this); 55946c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(CO->getCond()); 55956c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 55966c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith bool Result; 55976c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!CO->getCond()->isValueDependent() && 55986c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith CO->getCond()->EvaluateAsBooleanCondition(Result, SemaRef.Context)) 55996c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(Result ? CO->getTrueExpr() : CO->getFalseExpr()); 5600995e4a7530d705147c875b63608532c483c011a8Richard Smith else { 56011a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(CO->getTrueExpr()); 56021a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(CO->getFalseExpr()); 5603995e4a7530d705147c875b63608532c483c011a8Richard Smith } 56046c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56056c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56066c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitCXXConstructExpr(CXXConstructExpr *CCE) { 56076c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!CCE->isListInitialization()) 56086c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(CCE); 56096c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56106c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // In C++11, list initializations are sequenced. 56116c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<SequenceTree::Seq, 32> Elts; 56126c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Parent = Region; 56136c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (CXXConstructExpr::arg_iterator I = CCE->arg_begin(), 56146c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith E = CCE->arg_end(); 56156c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith I != E; ++I) { 56166c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Tree.allocate(Parent); 56176c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Elts.push_back(Region); 56186c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(*I); 56196c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56206c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56216c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Forget that the initializers are sequenced. 56226c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Parent; 56236c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0; I < Elts.size(); ++I) 56246c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(Elts[I]); 56256c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56266c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56276c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith void VisitInitListExpr(InitListExpr *ILE) { 56286c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!SemaRef.getLangOpts().CPlusPlus11) 56296c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith return VisitExpr(ILE); 56306c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56316c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // In C++11, list initializations are sequenced. 56326c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith llvm::SmallVector<SequenceTree::Seq, 32> Elts; 56336c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith SequenceTree::Seq Parent = Region; 56346c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0; I < ILE->getNumInits(); ++I) { 56356c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Expr *E = ILE->getInit(I); 56366c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith if (!E) continue; 56376c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Tree.allocate(Parent); 56386c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Elts.push_back(Region); 56396c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Visit(E); 56406c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56416c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56426c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith // Forget that the initializers are sequenced. 56436c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Region = Parent; 56446c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith for (unsigned I = 0; I < Elts.size(); ++I) 56456c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith Tree.merge(Elts[I]); 56466c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith } 56476c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith}; 56486c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith} 56496c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 56506c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smithvoid Sema::CheckUnsequencedOperations(Expr *E) { 56511a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith llvm::SmallVector<Expr*, 8> WorkList; 56521a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.push_back(E); 56531a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith while (!WorkList.empty()) { 56541a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith Expr *Item = WorkList.back(); 56551a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith WorkList.pop_back(); 56561a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith SequenceChecker(*this, Item, WorkList); 56571a2dcd55a1924b46c919474390a3f0cdf2cebeb0Richard Smith } 56586c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith} 56596c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 5660ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanianvoid Sema::CheckCompletedExpr(Expr *E, SourceLocation CheckLoc, 5661ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian bool IsConstexpr) { 56626c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith CheckImplicitConversions(E, CheckLoc); 56636c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith CheckUnsequencedOperations(E); 5664ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian if (!IsConstexpr && !E->isValueDependent()) 5665ad48a500596d7d678b99c7f94326cfa856c3b49fFariborz Jahanian CheckForIntOverflow(E); 56666c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith} 56676c3af3d0e3e65bcbca57bfd458d684941f6d0531Richard Smith 566815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 566915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall FieldDecl *BitField, 567015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *Init) { 567115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 567215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 567315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 5674f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given 5675f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This 5676f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the 5677f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function 5678f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete. 567982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregorbool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd, 568082aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor bool CheckParameterNames) { 5681f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump bool HasInvalidParm = false; 568282aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor for (; P != PEnd; ++P) { 568382aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor ParmVarDecl *Param = *P; 568482aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor 5685f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.7.5.3p4: the parameters in a parameter type list in a 5686f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // function declarator that is part of a function definition of 5687f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // that function shall not have incomplete type. 5688f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // 5689f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // This is also C++ [dcl.fct]p6. 5690f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump if (!Param->isInvalidDecl() && 5691f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump RequireCompleteType(Param->getLocation(), Param->getType(), 5692d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor diag::err_typecheck_decl_incomplete_type)) { 5693f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Param->setInvalidDecl(); 5694f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump HasInvalidParm = true; 5695f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 5696f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 5697f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.9.1p5: If the declarator includes a parameter type list, the 5698f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // declaration of each parameter shall include an identifier. 569982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor if (CheckParameterNames && 570082aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor Param->getIdentifier() == 0 && 5701f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !Param->isImplicit() && 57024e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie !getLangOpts().CPlusPlus) 5703f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Diag(Param->getLocation(), diag::err_parameter_name_omitted); 5704d17e340e2d516139931768697bf080f60920ba9dSam Weinig 5705d17e340e2d516139931768697bf080f60920ba9dSam Weinig // C99 6.7.5.3p12: 5706d17e340e2d516139931768697bf080f60920ba9dSam Weinig // If the function declarator is not part of a definition of that 5707d17e340e2d516139931768697bf080f60920ba9dSam Weinig // function, parameters may have incomplete type and may use the [*] 5708d17e340e2d516139931768697bf080f60920ba9dSam Weinig // notation in their sequences of declarator specifiers to specify 5709d17e340e2d516139931768697bf080f60920ba9dSam Weinig // variable length array types. 5710d17e340e2d516139931768697bf080f60920ba9dSam Weinig QualType PType = Param->getOriginalType(); 5711d237d2e6b85a74f31c986dc585fa6c39733b74a2Fariborz Jahanian while (const ArrayType *AT = Context.getAsArrayType(PType)) { 5712d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (AT->getSizeModifier() == ArrayType::Star) { 5713fc09336a5965040736f9bc63a70416003972364eStefanus Du Toit // FIXME: This diagnostic should point the '[*]' if source-location 5714d17e340e2d516139931768697bf080f60920ba9dSam Weinig // information is added for it. 5715d17e340e2d516139931768697bf080f60920ba9dSam Weinig Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 5716d237d2e6b85a74f31c986dc585fa6c39733b74a2Fariborz Jahanian break; 5717d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 5718d237d2e6b85a74f31c986dc585fa6c39733b74a2Fariborz Jahanian PType= AT->getElementType(); 5719d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 5720f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 5721f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 5722f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump return HasInvalidParm; 5723f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump} 5724b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5725b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a 5726b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements. 5727b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 5728b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // This is actually a lot of work to potentially be doing on every 5729b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // cast; don't do it if we're ignoring -Wcast_align (as is the default). 57300827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align, 57310827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis TRange.getBegin()) 5732d6471f7c1921c7802804ce3ff6fe9768310f72b9David Blaikie == DiagnosticsEngine::Ignored) 5733b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 5734b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5735b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Ignore dependent types. 5736b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (T->isDependentType() || Op->getType()->isDependentType()) 5737b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 5738b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5739b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the destination be a pointer type. 5740b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *DestPtr = T->getAs<PointerType>(); 5741b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!DestPtr) return; 5742b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5743b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // If the destination has alignment 1, we're done. 5744b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType DestPointee = DestPtr->getPointeeType(); 5745b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestPointee->isIncompleteType()) return; 5746b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 5747b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestAlign.isOne()) return; 5748b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5749b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the source be a pointer type. 5750b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 5751b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!SrcPtr) return; 5752b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType SrcPointee = SrcPtr->getPointeeType(); 5753b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5754b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Whitelist casts from cv void*. We already implicitly 5755b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // whitelisted casts to cv void*, since they have alignment 1. 5756b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Also whitelist casts involving incomplete types, which implicitly 5757b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // includes 'void'. 5758b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcPointee->isIncompleteType()) return; 5759b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5760b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 5761b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcAlign >= DestAlign) return; 5762b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5763b7f4ffe073fa419613946461a2583ba2fcb72280John McCall Diag(TRange.getBegin(), diag::warn_cast_align) 5764b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << Op->getType() << T 5765b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(SrcAlign.getQuantity()) 5766b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(DestAlign.getQuantity()) 5767b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << TRange << Op->getSourceRange(); 5768b7f4ffe073fa419613946461a2583ba2fcb72280John McCall} 5769b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5770d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainstatic const Type* getElementType(const Expr *BaseExpr) { 5771d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* EltType = BaseExpr->getType().getTypePtr(); 5772d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (EltType->isAnyPointerType()) 5773d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getPointeeType().getTypePtr(); 5774d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain else if (EltType->isArrayType()) 5775d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getBaseElementTypeUnsafe(); 5776d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType; 5777d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain} 5778d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5779c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// \brief Check whether this array fits the idiom of a size-one tail padded 5780c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// array member of a struct. 5781c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// 5782c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// We avoid emitting out-of-bounds access warnings for such arrays as they are 5783c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// commonly used to emulate flexible arrays in C89 code. 5784c268434b332bbe57950d977633369bf5822d9554Chandler Carruthstatic bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size, 5785c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const NamedDecl *ND) { 5786c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (Size != 1 || !ND) return false; 5787c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5788c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const FieldDecl *FD = dyn_cast<FieldDecl>(ND); 5789c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!FD) return false; 5790c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5791c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // Don't consider sizes resulting from macro expansions or template argument 5792c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // substitution to form C89 tail-padded arrays. 5793d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan 5794d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan TypeSourceInfo *TInfo = FD->getTypeSourceInfo(); 579500e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek while (TInfo) { 579600e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek TypeLoc TL = TInfo->getTypeLoc(); 579700e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek // Look through typedefs. 579839e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie if (TypedefTypeLoc TTL = TL.getAs<TypedefTypeLoc>()) { 579939e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie const TypedefNameDecl *TDL = TTL.getTypedefNameDecl(); 580000e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek TInfo = TDL->getTypeSourceInfo(); 580100e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek continue; 580200e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek } 580339e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie if (ConstantArrayTypeLoc CTL = TL.getAs<ConstantArrayTypeLoc>()) { 580439e6ab4be93d9c5e729a578ddd9d415cd2d49872David Blaikie const Expr *SizeExpr = dyn_cast<IntegerLiteral>(CTL.getSizeExpr()); 58055e25301c24c92a9b7018cee20e524c4eb7192bf0Chad Rosier if (!SizeExpr || SizeExpr->getExprLoc().isMacroID()) 58065e25301c24c92a9b7018cee20e524c4eb7192bf0Chad Rosier return false; 58075e25301c24c92a9b7018cee20e524c4eb7192bf0Chad Rosier } 580800e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek break; 5809d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan } 5810c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5811c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext()); 5812381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!RD) return false; 5813381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (RD->isUnion()) return false; 5814381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) { 5815381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!CRD->isStandardLayout()) return false; 5816381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay } 5817c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 581822d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer // See if this is the last field decl in the record. 581922d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer const Decl *D = FD; 582022d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer while ((D = D->getNextDeclInContext())) 582122d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer if (isa<FieldDecl>(D)) 582222d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return false; 582322d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return true; 5824c268434b332bbe57950d977633369bf5822d9554Chandler Carruth} 5825c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5826d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainvoid Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr, 582780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const ArraySubscriptExpr *ASE, 582825b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith bool AllowOnePastEnd, bool IndexNegated) { 582992b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman IndexExpr = IndexExpr->IgnoreParenImpCasts(); 583080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (IndexExpr->isValueDependent()) 583180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 5832d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 583380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const Type *EffectiveType = getElementType(BaseExpr); 583480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay BaseExpr = BaseExpr->IgnoreParenCasts(); 58353406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const ConstantArrayType *ArrayTy = 5836d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain Context.getAsConstantArrayType(BaseExpr->getType()); 58373406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (!ArrayTy) 5838a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 583935001ca261f895817916b468379b696d6d45959dChandler Carruth 58403406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth llvm::APSInt index; 584180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!IndexExpr->EvaluateAsInt(index, Context)) 5842a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 584325b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith if (IndexNegated) 584425b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith index = -index; 58458fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek 5846ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth const NamedDecl *ND = NULL; 5847ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 5848ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(DRE->getDecl()); 5849c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 5850ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 5851ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 58529e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek if (index.isUnsigned() || !index.isNegative()) { 585325b3b849e3ad340b04442707038c86980035765bTed Kremenek llvm::APInt size = ArrayTy->getSize(); 585435001ca261f895817916b468379b696d6d45959dChandler Carruth if (!size.isStrictlyPositive()) 585535001ca261f895817916b468379b696d6d45959dChandler Carruth return; 5856d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5857d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* BaseType = getElementType(BaseExpr); 5858de5998f1d7dcecb777257ec932142d65de636eb8Nico Weber if (BaseType != EffectiveType) { 5859d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Make sure we're comparing apples to apples when comparing index to size 5860d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType); 5861d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t array_typesize = Context.getTypeSize(BaseType); 5862d10f4bc5a05ce0cdc1646dbb0f706bb9d3dfc0c5Kaelyn Uhrain // Handle ptrarith_typesize being zero, such as when casting to void* 586318f169770d9d3f826bad8f1359c8c5770c5ab16fKaelyn Uhrain if (!ptrarith_typesize) ptrarith_typesize = 1; 5864d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize != array_typesize) { 5865d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // There's a cast to a different size type involved 5866d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ratio = array_typesize / ptrarith_typesize; 5867d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // TODO: Be smarter about handling cases where array_typesize is not a 5868d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // multiple of ptrarith_typesize 5869d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize * ratio == array_typesize) 5870d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain size *= llvm::APInt(size.getBitWidth(), ratio); 5871d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 5872d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 5873d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 58743406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (size.getBitWidth() > index.getBitWidth()) 587592b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman index = index.zext(size.getBitWidth()); 587625b3b849e3ad340b04442707038c86980035765bTed Kremenek else if (size.getBitWidth() < index.getBitWidth()) 587792b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman size = size.zext(index.getBitWidth()); 587825b3b849e3ad340b04442707038c86980035765bTed Kremenek 5879d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // For array subscripting the index must be less than size, but for pointer 5880d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // arithmetic also allow the index (offset) to be equal to size since 5881d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // computing the next address after the end of the array is legal and 5882d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // commonly done e.g. in C++ iterators and range-based for loops. 588392b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman if (AllowOnePastEnd ? index.ule(size) : index.ult(size)) 5884ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth return; 5885ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 5886ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // Also don't warn for arrays of size 1 which are members of some 5887ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // structure. These are often used to approximate flexible arrays in C89 5888ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // code. 5889d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (IsTailPaddedMemberArray(*this, size, ND)) 58908fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek return; 58913406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth 589280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // Suppress the warning if the subscript expression (as identified by the 589380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // ']' location) and the index expression are both from macro expansions 589480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // within a system header. 589580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) { 589680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation RBracketLoc = SourceMgr.getSpellingLoc( 589780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay ASE->getRBracketLoc()); 589880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isInSystemHeader(RBracketLoc)) { 589980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation IndexLoc = SourceMgr.getSpellingLoc( 590080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay IndexExpr->getLocStart()); 590180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isFromSameFile(RBracketLoc, IndexLoc)) 590280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 590380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 590480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 590580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay 5906d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds; 590780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) 5908d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_array_index_exceeds_bounds; 5909d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5910d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 5911d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 5912d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << size.toString(10, true) 5913d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << (unsigned)size.getLimitedValue(~0U) 5914d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 59153406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth } else { 5916d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_array_index_precedes_bounds; 591780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!ASE) { 5918d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_ptr_arith_precedes_bounds; 5919d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (index.isNegative()) index = -index; 5920d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 5921d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5922d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 5923d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 5924d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 5925a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek } 592635001ca261f895817916b468379b696d6d45959dChandler Carruth 5927cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (!ND) { 5928cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay // Try harder to find a NamedDecl to point at in the note. 5929cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay while (const ArraySubscriptExpr *ASE = 5930cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay dyn_cast<ArraySubscriptExpr>(BaseExpr)) 5931cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay BaseExpr = ASE->getBase()->IgnoreParenCasts(); 5932cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 5933cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(DRE->getDecl()); 5934cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 5935cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 5936cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay } 5937cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay 593835001ca261f895817916b468379b696d6d45959dChandler Carruth if (ND) 5939d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(ND->getLocStart(), BaseExpr, 5940d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(diag::note_array_index_out_of_bounds) 5941d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << ND->getDeclName()); 59423aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek} 59433aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek 59443aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) { 5945d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain int AllowOnePastEnd = 0; 5946d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain while (expr) { 5947d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = expr->IgnoreParenImpCasts(); 59483aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek switch (expr->getStmtClass()) { 5949d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::ArraySubscriptExprClass: { 5950d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr); 595180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE, 5952d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd > 0); 59533aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 5954d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 5955d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::UnaryOperatorClass: { 5956d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Only unwrap the * and & unary operators 5957d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const UnaryOperator *UO = cast<UnaryOperator>(expr); 5958d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = UO->getSubExpr(); 5959d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain switch (UO->getOpcode()) { 5960d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_AddrOf: 5961d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd++; 5962d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 5963d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_Deref: 5964d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd--; 5965d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 5966d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain default: 5967d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return; 5968d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 5969d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 5970d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 59713aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek case Stmt::ConditionalOperatorClass: { 59723aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek const ConditionalOperator *cond = cast<ConditionalOperator>(expr); 59733aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *lhs = cond->getLHS()) 59743aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(lhs); 59753aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *rhs = cond->getRHS()) 59763aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(rhs); 59773aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 59783aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 59793aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek default: 59803aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 59813aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 5982f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne } 5983a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek} 5984f85e193739c953358c865005855253af4f68a497John McCall 5985f85e193739c953358c865005855253af4f68a497John McCall//===--- CHECK: Objective-C retain cycles ----------------------------------// 5986f85e193739c953358c865005855253af4f68a497John McCall 5987f85e193739c953358c865005855253af4f68a497John McCallnamespace { 5988f85e193739c953358c865005855253af4f68a497John McCall struct RetainCycleOwner { 5989f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner() : Variable(0), Indirect(false) {} 5990f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 5991f85e193739c953358c865005855253af4f68a497John McCall SourceRange Range; 5992f85e193739c953358c865005855253af4f68a497John McCall SourceLocation Loc; 5993f85e193739c953358c865005855253af4f68a497John McCall bool Indirect; 5994f85e193739c953358c865005855253af4f68a497John McCall 5995f85e193739c953358c865005855253af4f68a497John McCall void setLocsFrom(Expr *e) { 5996f85e193739c953358c865005855253af4f68a497John McCall Loc = e->getExprLoc(); 5997f85e193739c953358c865005855253af4f68a497John McCall Range = e->getSourceRange(); 5998f85e193739c953358c865005855253af4f68a497John McCall } 5999f85e193739c953358c865005855253af4f68a497John McCall }; 6000f85e193739c953358c865005855253af4f68a497John McCall} 6001f85e193739c953358c865005855253af4f68a497John McCall 6002f85e193739c953358c865005855253af4f68a497John McCall/// Consider whether capturing the given variable can possibly lead to 6003f85e193739c953358c865005855253af4f68a497John McCall/// a retain cycle. 6004f85e193739c953358c865005855253af4f68a497John McCallstatic bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) { 6005f3477c13eeaf11b32a41f181398fb5deffd0dd73Sylvestre Ledru // In ARC, it's captured strongly iff the variable has __strong 6006f85e193739c953358c865005855253af4f68a497John McCall // lifetime. In MRR, it's captured strongly if the variable is 6007f85e193739c953358c865005855253af4f68a497John McCall // __block and has an appropriate type. 6008f85e193739c953358c865005855253af4f68a497John McCall if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 6009f85e193739c953358c865005855253af4f68a497John McCall return false; 6010f85e193739c953358c865005855253af4f68a497John McCall 6011f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = var; 6012e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose if (ref) 6013e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose owner.setLocsFrom(ref); 6014f85e193739c953358c865005855253af4f68a497John McCall return true; 6015f85e193739c953358c865005855253af4f68a497John McCall} 6016f85e193739c953358c865005855253af4f68a497John McCall 60176e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanianstatic bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) { 6018f85e193739c953358c865005855253af4f68a497John McCall while (true) { 6019f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParens(); 6020f85e193739c953358c865005855253af4f68a497John McCall if (CastExpr *cast = dyn_cast<CastExpr>(e)) { 6021f85e193739c953358c865005855253af4f68a497John McCall switch (cast->getCastKind()) { 6022f85e193739c953358c865005855253af4f68a497John McCall case CK_BitCast: 6023f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueBitCast: 6024f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueToRValue: 602533e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall case CK_ARCReclaimReturnedObject: 6026f85e193739c953358c865005855253af4f68a497John McCall e = cast->getSubExpr(); 6027f85e193739c953358c865005855253af4f68a497John McCall continue; 6028f85e193739c953358c865005855253af4f68a497John McCall 6029f85e193739c953358c865005855253af4f68a497John McCall default: 6030f85e193739c953358c865005855253af4f68a497John McCall return false; 6031f85e193739c953358c865005855253af4f68a497John McCall } 6032f85e193739c953358c865005855253af4f68a497John McCall } 6033f85e193739c953358c865005855253af4f68a497John McCall 6034f85e193739c953358c865005855253af4f68a497John McCall if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) { 6035f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar = ref->getDecl(); 6036f85e193739c953358c865005855253af4f68a497John McCall if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 6037f85e193739c953358c865005855253af4f68a497John McCall return false; 6038f85e193739c953358c865005855253af4f68a497John McCall 6039f85e193739c953358c865005855253af4f68a497John McCall // Try to find a retain cycle in the base. 60406e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(S, ref->getBase(), owner)) 6041f85e193739c953358c865005855253af4f68a497John McCall return false; 6042f85e193739c953358c865005855253af4f68a497John McCall 6043f85e193739c953358c865005855253af4f68a497John McCall if (ref->isFreeIvar()) owner.setLocsFrom(ref); 6044f85e193739c953358c865005855253af4f68a497John McCall owner.Indirect = true; 6045f85e193739c953358c865005855253af4f68a497John McCall return true; 6046f85e193739c953358c865005855253af4f68a497John McCall } 6047f85e193739c953358c865005855253af4f68a497John McCall 6048f85e193739c953358c865005855253af4f68a497John McCall if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) { 6049f85e193739c953358c865005855253af4f68a497John McCall VarDecl *var = dyn_cast<VarDecl>(ref->getDecl()); 6050f85e193739c953358c865005855253af4f68a497John McCall if (!var) return false; 6051f85e193739c953358c865005855253af4f68a497John McCall return considerVariable(var, ref, owner); 6052f85e193739c953358c865005855253af4f68a497John McCall } 6053f85e193739c953358c865005855253af4f68a497John McCall 6054f85e193739c953358c865005855253af4f68a497John McCall if (MemberExpr *member = dyn_cast<MemberExpr>(e)) { 6055f85e193739c953358c865005855253af4f68a497John McCall if (member->isArrow()) return false; 6056f85e193739c953358c865005855253af4f68a497John McCall 6057f85e193739c953358c865005855253af4f68a497John McCall // Don't count this as an indirect ownership. 6058f85e193739c953358c865005855253af4f68a497John McCall e = member->getBase(); 6059f85e193739c953358c865005855253af4f68a497John McCall continue; 6060f85e193739c953358c865005855253af4f68a497John McCall } 6061f85e193739c953358c865005855253af4f68a497John McCall 60624b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) { 60634b9c2d235fb9449e249d74f48ecfec601650de93John McCall // Only pay attention to pseudo-objects on property references. 60644b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyRefExpr *pre 60654b9c2d235fb9449e249d74f48ecfec601650de93John McCall = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm() 60664b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->IgnoreParens()); 60674b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!pre) return false; 60684b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (pre->isImplicitProperty()) return false; 60694b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyDecl *property = pre->getExplicitProperty(); 60704b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!property->isRetaining() && 60714b9c2d235fb9449e249d74f48ecfec601650de93John McCall !(property->getPropertyIvarDecl() && 60724b9c2d235fb9449e249d74f48ecfec601650de93John McCall property->getPropertyIvarDecl()->getType() 60734b9c2d235fb9449e249d74f48ecfec601650de93John McCall .getObjCLifetime() == Qualifiers::OCL_Strong)) 60744b9c2d235fb9449e249d74f48ecfec601650de93John McCall return false; 60754b9c2d235fb9449e249d74f48ecfec601650de93John McCall 60764b9c2d235fb9449e249d74f48ecfec601650de93John McCall owner.Indirect = true; 60776e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (pre->isSuperReceiver()) { 60786e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Variable = S.getCurMethodDecl()->getSelfDecl(); 60796e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!owner.Variable) 60806e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return false; 60816e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Loc = pre->getLocation(); 60826e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Range = pre->getSourceRange(); 60836e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return true; 60846e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian } 60854b9c2d235fb9449e249d74f48ecfec601650de93John McCall e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase()) 60864b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->getSourceExpr()); 60874b9c2d235fb9449e249d74f48ecfec601650de93John McCall continue; 60884b9c2d235fb9449e249d74f48ecfec601650de93John McCall } 60894b9c2d235fb9449e249d74f48ecfec601650de93John McCall 6090f85e193739c953358c865005855253af4f68a497John McCall // Array ivars? 6091f85e193739c953358c865005855253af4f68a497John McCall 6092f85e193739c953358c865005855253af4f68a497John McCall return false; 6093f85e193739c953358c865005855253af4f68a497John McCall } 6094f85e193739c953358c865005855253af4f68a497John McCall} 6095f85e193739c953358c865005855253af4f68a497John McCall 6096f85e193739c953358c865005855253af4f68a497John McCallnamespace { 6097f85e193739c953358c865005855253af4f68a497John McCall struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> { 6098f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor(ASTContext &Context, VarDecl *variable) 6099f85e193739c953358c865005855253af4f68a497John McCall : EvaluatedExprVisitor<FindCaptureVisitor>(Context), 6100f85e193739c953358c865005855253af4f68a497John McCall Variable(variable), Capturer(0) {} 6101f85e193739c953358c865005855253af4f68a497John McCall 6102f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 6103f85e193739c953358c865005855253af4f68a497John McCall Expr *Capturer; 6104f85e193739c953358c865005855253af4f68a497John McCall 6105f85e193739c953358c865005855253af4f68a497John McCall void VisitDeclRefExpr(DeclRefExpr *ref) { 6106f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 6107f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 6108f85e193739c953358c865005855253af4f68a497John McCall } 6109f85e193739c953358c865005855253af4f68a497John McCall 6110f85e193739c953358c865005855253af4f68a497John McCall void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) { 6111f85e193739c953358c865005855253af4f68a497John McCall if (Capturer) return; 6112f85e193739c953358c865005855253af4f68a497John McCall Visit(ref->getBase()); 6113f85e193739c953358c865005855253af4f68a497John McCall if (Capturer && ref->isFreeIvar()) 6114f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 6115f85e193739c953358c865005855253af4f68a497John McCall } 6116f85e193739c953358c865005855253af4f68a497John McCall 6117f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockExpr(BlockExpr *block) { 6118f85e193739c953358c865005855253af4f68a497John McCall // Look inside nested blocks 6119f85e193739c953358c865005855253af4f68a497John McCall if (block->getBlockDecl()->capturesVariable(Variable)) 6120f85e193739c953358c865005855253af4f68a497John McCall Visit(block->getBlockDecl()->getBody()); 6121f85e193739c953358c865005855253af4f68a497John McCall } 61227e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian 61237e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian void VisitOpaqueValueExpr(OpaqueValueExpr *OVE) { 61247e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian if (Capturer) return; 61257e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian if (OVE->getSourceExpr()) 61267e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian Visit(OVE->getSourceExpr()); 61277e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian } 6128f85e193739c953358c865005855253af4f68a497John McCall }; 6129f85e193739c953358c865005855253af4f68a497John McCall} 6130f85e193739c953358c865005855253af4f68a497John McCall 6131f85e193739c953358c865005855253af4f68a497John McCall/// Check whether the given argument is a block which captures a 6132f85e193739c953358c865005855253af4f68a497John McCall/// variable. 6133f85e193739c953358c865005855253af4f68a497John McCallstatic Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) { 6134f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 6135f85e193739c953358c865005855253af4f68a497John McCall 6136f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParenCasts(); 61371fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose 61381fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose // Look through [^{...} copy] and Block_copy(^{...}). 61391fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (ObjCMessageExpr *ME = dyn_cast<ObjCMessageExpr>(e)) { 61401fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose Selector Cmd = ME->getSelector(); 61411fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (Cmd.isUnarySelector() && Cmd.getNameForSlot(0) == "copy") { 61421fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose e = ME->getInstanceReceiver(); 61431fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (!e) 61441fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose return 0; 61451fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose e = e->IgnoreParenCasts(); 61461fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } 61471fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } else if (CallExpr *CE = dyn_cast<CallExpr>(e)) { 61481fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (CE->getNumArgs() == 1) { 61491fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose FunctionDecl *Fn = dyn_cast_or_null<FunctionDecl>(CE->getCalleeDecl()); 6150d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek if (Fn) { 6151d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek const IdentifierInfo *FnI = Fn->getIdentifier(); 6152d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek if (FnI && FnI->isStr("_Block_copy")) { 6153d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek e = CE->getArg(0)->IgnoreParenCasts(); 6154d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek } 6155d13eff6f77216a6fb25e18f600b492db4f0492e8Ted Kremenek } 61561fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } 61571fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } 61581fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose 6159f85e193739c953358c865005855253af4f68a497John McCall BlockExpr *block = dyn_cast<BlockExpr>(e); 6160f85e193739c953358c865005855253af4f68a497John McCall if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable)) 6161f85e193739c953358c865005855253af4f68a497John McCall return 0; 6162f85e193739c953358c865005855253af4f68a497John McCall 6163f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor visitor(S.Context, owner.Variable); 6164f85e193739c953358c865005855253af4f68a497John McCall visitor.Visit(block->getBlockDecl()->getBody()); 6165f85e193739c953358c865005855253af4f68a497John McCall return visitor.Capturer; 6166f85e193739c953358c865005855253af4f68a497John McCall} 6167f85e193739c953358c865005855253af4f68a497John McCall 6168f85e193739c953358c865005855253af4f68a497John McCallstatic void diagnoseRetainCycle(Sema &S, Expr *capturer, 6169f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner &owner) { 6170f85e193739c953358c865005855253af4f68a497John McCall assert(capturer); 6171f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 6172f85e193739c953358c865005855253af4f68a497John McCall 6173f85e193739c953358c865005855253af4f68a497John McCall S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle) 6174f85e193739c953358c865005855253af4f68a497John McCall << owner.Variable << capturer->getSourceRange(); 6175f85e193739c953358c865005855253af4f68a497John McCall S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner) 6176f85e193739c953358c865005855253af4f68a497John McCall << owner.Indirect << owner.Range; 6177f85e193739c953358c865005855253af4f68a497John McCall} 6178f85e193739c953358c865005855253af4f68a497John McCall 6179f85e193739c953358c865005855253af4f68a497John McCall/// Check for a keyword selector that starts with the word 'add' or 6180f85e193739c953358c865005855253af4f68a497John McCall/// 'set'. 6181f85e193739c953358c865005855253af4f68a497John McCallstatic bool isSetterLikeSelector(Selector sel) { 6182f85e193739c953358c865005855253af4f68a497John McCall if (sel.isUnarySelector()) return false; 6183f85e193739c953358c865005855253af4f68a497John McCall 61845f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef str = sel.getNameForSlot(0); 6185f85e193739c953358c865005855253af4f68a497John McCall while (!str.empty() && str.front() == '_') str = str.substr(1); 6186968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (str.startswith("set")) 6187f85e193739c953358c865005855253af4f68a497John McCall str = str.substr(3); 6188968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek else if (str.startswith("add")) { 6189968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek // Specially whitelist 'addOperationWithBlock:'. 6190968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock")) 6191968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek return false; 6192968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek str = str.substr(3); 6193968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek } 6194f85e193739c953358c865005855253af4f68a497John McCall else 6195f85e193739c953358c865005855253af4f68a497John McCall return false; 6196f85e193739c953358c865005855253af4f68a497John McCall 6197f85e193739c953358c865005855253af4f68a497John McCall if (str.empty()) return true; 61983f6f51e28231f65de9c2dd150a2d757b2162cfa3Jordan Rose return !isLowercase(str.front()); 6199f85e193739c953358c865005855253af4f68a497John McCall} 6200f85e193739c953358c865005855253af4f68a497John McCall 6201f85e193739c953358c865005855253af4f68a497John McCall/// Check a message send to see if it's likely to cause a retain cycle. 6202f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(ObjCMessageExpr *msg) { 6203f85e193739c953358c865005855253af4f68a497John McCall // Only check instance methods whose selector looks like a setter. 6204f85e193739c953358c865005855253af4f68a497John McCall if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector())) 6205f85e193739c953358c865005855253af4f68a497John McCall return; 6206f85e193739c953358c865005855253af4f68a497John McCall 6207f85e193739c953358c865005855253af4f68a497John McCall // Try to find a variable that the receiver is strongly owned by. 6208f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 6209f85e193739c953358c865005855253af4f68a497John McCall if (msg->getReceiverKind() == ObjCMessageExpr::Instance) { 62106e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner)) 6211f85e193739c953358c865005855253af4f68a497John McCall return; 6212f85e193739c953358c865005855253af4f68a497John McCall } else { 6213f85e193739c953358c865005855253af4f68a497John McCall assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance); 6214f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = getCurMethodDecl()->getSelfDecl(); 6215f85e193739c953358c865005855253af4f68a497John McCall owner.Loc = msg->getSuperLoc(); 6216f85e193739c953358c865005855253af4f68a497John McCall owner.Range = msg->getSuperLoc(); 6217f85e193739c953358c865005855253af4f68a497John McCall } 6218f85e193739c953358c865005855253af4f68a497John McCall 6219f85e193739c953358c865005855253af4f68a497John McCall // Check whether the receiver is captured by any of the arguments. 6220f85e193739c953358c865005855253af4f68a497John McCall for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i) 6221f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner)) 6222f85e193739c953358c865005855253af4f68a497John McCall return diagnoseRetainCycle(*this, capturer, owner); 6223f85e193739c953358c865005855253af4f68a497John McCall} 6224f85e193739c953358c865005855253af4f68a497John McCall 6225f85e193739c953358c865005855253af4f68a497John McCall/// Check a property assign to see if it's likely to cause a retain cycle. 6226f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(Expr *receiver, Expr *argument) { 6227f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 62286e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, receiver, owner)) 6229f85e193739c953358c865005855253af4f68a497John McCall return; 6230f85e193739c953358c865005855253af4f68a497John McCall 6231f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, argument, owner)) 6232f85e193739c953358c865005855253af4f68a497John McCall diagnoseRetainCycle(*this, capturer, owner); 6233f85e193739c953358c865005855253af4f68a497John McCall} 6234f85e193739c953358c865005855253af4f68a497John McCall 6235e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rosevoid Sema::checkRetainCycles(VarDecl *Var, Expr *Init) { 6236e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose RetainCycleOwner Owner; 6237e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose if (!considerVariable(Var, /*DeclRefExpr=*/0, Owner)) 6238e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose return; 6239e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose 6240e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose // Because we don't have an expression for the variable, we have to set the 6241e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose // location explicitly here. 6242e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose Owner.Loc = Var->getLocation(); 6243e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose Owner.Range = Var->getSourceRange(); 6244e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose 6245e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose if (Expr *Capturer = findCapturingExpr(*this, Init, Owner)) 6246e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose diagnoseRetainCycle(*this, Capturer, Owner); 6247e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose} 6248e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose 62499d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenekstatic bool checkUnsafeAssignLiteral(Sema &S, SourceLocation Loc, 62509d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek Expr *RHS, bool isProperty) { 62519d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek // Check if RHS is an Objective-C object literal, which also can get 62529d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek // immediately zapped in a weak reference. Note that we explicitly 62539d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek // allow ObjCStringLiterals, since those are designed to never really die. 62549d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek RHS = RHS->IgnoreParenImpCasts(); 6255f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek 6256d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek // This enum needs to match with the 'select' in 6257d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek // warn_objc_arc_literal_assign (off-by-1). 6258d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek Sema::ObjCLiteralKind Kind = S.CheckLiteralKind(RHS); 6259d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek if (Kind == Sema::LK_String || Kind == Sema::LK_None) 6260d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek return false; 6261f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek 6262f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek S.Diag(Loc, diag::warn_arc_literal_assign) 6263d3292c88ad6360823818b78d67875eceb3caedfbTed Kremenek << (unsigned) Kind 62649d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek << (isProperty ? 0 : 1) 62659d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek << RHS->getSourceRange(); 6266f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek 6267f530ff76de3b270f2287d3555d93b5d270643eebTed Kremenek return true; 62689d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek} 62699d0840141a0922e2d8b1d322f21ef51803ede23dTed Kremenek 6270b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenekstatic bool checkUnsafeAssignObject(Sema &S, SourceLocation Loc, 6271b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek Qualifiers::ObjCLifetime LT, 6272b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek Expr *RHS, bool isProperty) { 6273b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek // Strip off any implicit cast added to get to the one ARC-specific. 6274b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 6275b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek if (cast->getCastKind() == CK_ARCConsumeObject) { 6276b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek S.Diag(Loc, diag::warn_arc_retained_assign) 6277b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek << (LT == Qualifiers::OCL_ExplicitNone) 6278b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek << (isProperty ? 0 : 1) 6279b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek << RHS->getSourceRange(); 6280b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek return true; 6281b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek } 6282b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek RHS = cast->getSubExpr(); 6283b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek } 6284b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek 6285b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek if (LT == Qualifiers::OCL_Weak && 6286b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek checkUnsafeAssignLiteral(S, Loc, RHS, isProperty)) 6287b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek return true; 6288b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek 6289b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek return false; 6290b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek} 6291b29b30f9631937916786dc2e06c2842acf9c1500Ted Kremenek 6292b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenekbool Sema::checkUnsafeAssigns(SourceLocation Loc, 6293b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek QualType LHS, Expr *RHS) { 6294b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime(); 6295b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6296b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone) 6297b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return false; 6298b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6299b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek if (checkUnsafeAssignObject(*this, Loc, LT, RHS, false)) 6300b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return true; 6301b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6302b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return false; 6303b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek} 6304b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek 6305921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianvoid Sema::checkUnsafeExprAssigns(SourceLocation Loc, 6306921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Expr *LHS, Expr *RHS) { 630787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian QualType LHSType; 630887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // PropertyRef on LHS type need be directly obtained from 630987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // its declaration as it has a PsuedoType. 631087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian ObjCPropertyRefExpr *PRE 631187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens()); 631287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PRE && !PRE->isImplicitProperty()) { 631387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 631487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PD) 631587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType = PD->getType(); 631687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian } 631787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian 631887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (LHSType.isNull()) 631987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType = LHS->getType(); 63207a2704800943fbb69207e125d28186278712af36Jordan Rose 63217a2704800943fbb69207e125d28186278712af36Jordan Rose Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime(); 63227a2704800943fbb69207e125d28186278712af36Jordan Rose 63237a2704800943fbb69207e125d28186278712af36Jordan Rose if (LT == Qualifiers::OCL_Weak) { 63247a2704800943fbb69207e125d28186278712af36Jordan Rose DiagnosticsEngine::Level Level = 63257a2704800943fbb69207e125d28186278712af36Jordan Rose Diags.getDiagnosticLevel(diag::warn_arc_repeated_use_of_weak, Loc); 63267a2704800943fbb69207e125d28186278712af36Jordan Rose if (Level != DiagnosticsEngine::Ignored) 63277a2704800943fbb69207e125d28186278712af36Jordan Rose getCurFunction()->markSafeWeakUse(LHS); 63287a2704800943fbb69207e125d28186278712af36Jordan Rose } 63297a2704800943fbb69207e125d28186278712af36Jordan Rose 6330921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (checkUnsafeAssigns(Loc, LHSType, RHS)) 6331921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 63327a2704800943fbb69207e125d28186278712af36Jordan Rose 6333921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // FIXME. Check for other life times. 6334921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (LT != Qualifiers::OCL_None) 6335921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6336921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 633787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PRE) { 6338921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (PRE->isImplicitProperty()) 6339921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6340921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 6341921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (!PD) 6342921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6343921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 6344ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling unsigned Attributes = PD->getPropertyAttributes(); 6345ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) { 634687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // when 'assign' attribute was not explicitly specified 634787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // by user, ignore it and rely on property type itself 634887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // for lifetime info. 634987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten(); 635087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) && 635187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType->isObjCRetainableType()) 635287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian return; 635387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian 6354921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 635533e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 6356921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Diag(Loc, diag::warn_arc_retained_property_assign) 6357921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian << RHS->getSourceRange(); 6358921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 6359921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 6360921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 6361921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 636287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian } 6363ad017fa7a4df7389d245d02a49b3c79ed70bedb9Bill Wendling else if (Attributes & ObjCPropertyDecl::OBJC_PR_weak) { 6364b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek if (checkUnsafeAssignObject(*this, Loc, Qualifiers::OCL_Weak, RHS, true)) 6365b1ea510de0ef4ebfbbe8fa7668ab1635410fc080Ted Kremenek return; 6366bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian } 6367921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 6368921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian} 6369625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6370625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko//===--- CHECK: Empty statement body (-Wempty-body) ---------------------===// 6371625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6372625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkonamespace { 6373625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkobool ShouldDiagnoseEmptyStmtBody(const SourceManager &SourceMgr, 6374625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko SourceLocation StmtLoc, 6375625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *Body) { 6376625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do not warn if the body is a macro that expands to nothing, e.g: 6377625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // 6378625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // #define CALL(x) 6379625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // if (condition) 6380625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // CALL(0); 6381625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // 6382625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (Body->hasLeadingEmptyMacro()) 6383625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6384625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6385625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Get line numbers of statement and body. 6386625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool StmtLineInvalid; 6387625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned StmtLine = SourceMgr.getSpellingLineNumber(StmtLoc, 6388625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &StmtLineInvalid); 6389625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtLineInvalid) 6390625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6391625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6392625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool BodyLineInvalid; 6393625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned BodyLine = SourceMgr.getSpellingLineNumber(Body->getSemiLoc(), 6394625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &BodyLineInvalid); 6395625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyLineInvalid) 6396625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6397625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6398625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Warn if null statement and body are on the same line. 6399625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtLine != BodyLine) 6400625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 6401625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6402625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return true; 6403625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 6404625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} // Unnamed namespace 6405625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6406625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyStmtBody(SourceLocation StmtLoc, 6407625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *Body, 6408625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned DiagID) { 6409625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Since this is a syntactic check, don't emit diagnostic for template 6410625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // instantiations, this just adds noise. 6411625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (CurrentInstantiationScope) 6412625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6413625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6414625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // The body should be a null statement. 6415625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *NBody = dyn_cast<NullStmt>(Body); 6416625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!NBody) 6417625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6418625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6419625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do the usual checks. 6420625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 6421625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6422625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6423625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), DiagID); 6424625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 6425625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 6426625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6427625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyLoopBody(const Stmt *S, 6428625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *PossibleBody) { 6429625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko assert(!CurrentInstantiationScope); // Ensured by caller 6430625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6431625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko SourceLocation StmtLoc; 6432625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *Body; 6433625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned DiagID; 6434625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (const ForStmt *FS = dyn_cast<ForStmt>(S)) { 6435625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko StmtLoc = FS->getRParenLoc(); 6436625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Body = FS->getBody(); 6437625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagID = diag::warn_empty_for_body; 6438625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } else if (const WhileStmt *WS = dyn_cast<WhileStmt>(S)) { 6439625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko StmtLoc = WS->getCond()->getSourceRange().getEnd(); 6440625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Body = WS->getBody(); 6441625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagID = diag::warn_empty_while_body; 6442625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } else 6443625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; // Neither `for' nor `while'. 6444625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6445625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // The body should be a null statement. 6446625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *NBody = dyn_cast<NullStmt>(Body); 6447625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!NBody) 6448625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6449625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6450625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Skip expensive checks if diagnostic is disabled. 6451625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (Diags.getDiagnosticLevel(DiagID, NBody->getSemiLoc()) == 6452625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagnosticsEngine::Ignored) 6453625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6454625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6455625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do the usual checks. 6456625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 6457625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6458625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6459625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // `for(...);' and `while(...);' are popular idioms, so in order to keep 6460625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // noise level low, emit diagnostics only if for/while is followed by a 6461625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // CompoundStmt, e.g.: 6462625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // for (int i = 0; i < n; i++); 6463625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // { 6464625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // a(i); 6465625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // } 6466625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // or if for/while is followed by a statement with more indentation 6467625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // than for/while itself: 6468625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // for (int i = 0; i < n; i++); 6469625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // a(i); 6470625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool ProbableTypo = isa<CompoundStmt>(PossibleBody); 6471625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ProbableTypo) { 6472625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool BodyColInvalid; 6473625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned BodyCol = SourceMgr.getPresumedColumnNumber( 6474625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko PossibleBody->getLocStart(), 6475625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &BodyColInvalid); 6476625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyColInvalid) 6477625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6478625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6479625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool StmtColInvalid; 6480625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned StmtCol = SourceMgr.getPresumedColumnNumber( 6481625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko S->getLocStart(), 6482625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &StmtColInvalid); 6483625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtColInvalid) 6484625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 6485625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6486625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyCol > StmtCol) 6487625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko ProbableTypo = true; 6488625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } 6489625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 6490625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (ProbableTypo) { 6491625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), DiagID); 6492625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 6493625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } 6494625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 64950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 64960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- Layout compatibility ----------------------------------------------// 64970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 64980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 64990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 65000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2); 65010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 65020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two enumeration types are layout-compatible. 65030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, EnumDecl *ED1, EnumDecl *ED2) { 65040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [dcl.enum] p8: 65050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Two enumeration types are layout-compatible if they have the same 65060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // underlying type. 65070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return ED1->isComplete() && ED2->isComplete() && 65080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko C.hasSameType(ED1->getIntegerType(), ED2->getIntegerType()); 65090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 65100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 65110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two fields are layout-compatible. 65120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, FieldDecl *Field1, FieldDecl *Field2) { 65130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, Field1->getType(), Field2->getType())) 65140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 65150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 65160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1->isBitField() != Field2->isBitField()) 65170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 65180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 65190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1->isBitField()) { 65200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Make sure that the bit-fields are the same length. 65210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko unsigned Bits1 = Field1->getBitWidthValue(C); 65220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko unsigned Bits2 = Field2->getBitWidthValue(C); 65230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 65240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Bits1 != Bits2) 65250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 65260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 65270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 65280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 65290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 65300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 65310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout structs are layout-compatible. 65320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p17) 65330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleStruct(ASTContext &C, 65340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD1, 65350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD2) { 65360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If both records are C++ classes, check that base classes match. 65370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (const CXXRecordDecl *D1CXX = dyn_cast<CXXRecordDecl>(RD1)) { 65380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If one of records is a CXXRecordDecl we are in C++ mode, 65390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // thus the other one is a CXXRecordDecl, too. 65400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const CXXRecordDecl *D2CXX = cast<CXXRecordDecl>(RD2); 65410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check number of base classes. 65420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (D1CXX->getNumBases() != D2CXX->getNumBases()) 65430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 65440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 65450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check the base classes. 65460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (CXXRecordDecl::base_class_const_iterator 65470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base1 = D1CXX->bases_begin(), 65480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BaseEnd1 = D1CXX->bases_end(), 65490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base2 = D2CXX->bases_begin(); 65500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base1 != BaseEnd1; 65510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ++Base1, ++Base2) { 65520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, Base1->getType(), Base2->getType())) 65530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 65540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 65550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else if (const CXXRecordDecl *D2CXX = dyn_cast<CXXRecordDecl>(RD2)) { 65560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If only RD2 is a C++ class, it should have zero base classes. 65570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (D2CXX->getNumBases() > 0) 65580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 65590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 65600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 65610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check the fields. 65620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl::field_iterator Field2 = RD2->field_begin(), 65630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2End = RD2->field_end(), 65640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1 = RD1->field_begin(), 65650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1End = RD1->field_end(); 65660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for ( ; Field1 != Field1End && Field2 != Field2End; ++Field1, ++Field2) { 65670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, *Field1, *Field2)) 65680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 65690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 65700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1 != Field1End || Field2 != Field2End) 65710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 65720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 65730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 65740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 65750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 65760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout unions are layout-compatible. 65770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p18) 65780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleUnion(ASTContext &C, 65790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD1, 65800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD2) { 65810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::SmallPtrSet<FieldDecl *, 8> UnmatchedFields; 65820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (RecordDecl::field_iterator Field2 = RD2->field_begin(), 65830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2End = RD2->field_end(); 65840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2 != Field2End; ++Field2) { 65850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko UnmatchedFields.insert(*Field2); 65860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 65870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 65880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (RecordDecl::field_iterator Field1 = RD1->field_begin(), 65890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1End = RD1->field_end(); 65900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1 != Field1End; ++Field1) { 65910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::SmallPtrSet<FieldDecl *, 8>::iterator 65920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I = UnmatchedFields.begin(), 65930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko E = UnmatchedFields.end(); 65940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 65950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for ( ; I != E; ++I) { 65960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (isLayoutCompatible(C, *Field1, *I)) { 65970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool Result = UnmatchedFields.erase(*I); 65980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (void) Result; 65990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko assert(Result); 66000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko break; 66010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 66020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 66030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I == E) 66040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 66060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return UnmatchedFields.empty(); 66080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 66090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, RecordDecl *RD1, RecordDecl *RD2) { 66110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (RD1->isUnion() != RD2->isUnion()) 66120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (RD1->isUnion()) 66150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatibleUnion(C, RD1, RD2); 66160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 66170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatibleStruct(C, RD1, RD2); 66180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 66190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two types are layout-compatible in C++11 sense. 66210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2) { 66220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (T1.isNull() || T2.isNull()) 66230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [basic.types] p11: 66260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If two types T1 and T2 are the same type, then T1 and T2 are 66270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // layout-compatible types. 66280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (C.hasSameType(T1, T2)) 66290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 66300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko T1 = T1.getCanonicalType().getUnqualifiedType(); 66320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko T2 = T2.getCanonicalType().getUnqualifiedType(); 66330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Type::TypeClass TC1 = T1->getTypeClass(); 66350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Type::TypeClass TC2 = T2->getTypeClass(); 66360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TC1 != TC2) 66380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TC1 == Type::Enum) { 66410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatible(C, 66420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<EnumType>(T1)->getDecl(), 66430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<EnumType>(T2)->getDecl()); 66440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else if (TC1 == Type::Record) { 66450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!T1->isStandardLayoutType() || !T2->isStandardLayoutType()) 66460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatible(C, 66490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<RecordType>(T1)->getDecl(), 66500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<RecordType>(T2)->getDecl()); 66510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 66520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 66550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 66560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- CHECK: pointer_with_type_tag attribute: datatypes should match ----// 66580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 66600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Given a type tag expression find the type tag itself. 66610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 66620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Type tag expression, as it appears in user's code. 66630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 66640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param VD Declaration of an identifier that appears in a type tag. 66650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 66660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValue Type tag magic value. 66670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool FindTypeTagExpr(const Expr *TypeExpr, const ASTContext &Ctx, 66680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const ValueDecl **VD, uint64_t *MagicValue) { 66690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko while(true) { 66700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeExpr) 66710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = TypeExpr->IgnoreParenImpCasts()->IgnoreParenCasts(); 66740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko switch (TypeExpr->getStmtClass()) { 66760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::UnaryOperatorClass: { 66770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const UnaryOperator *UO = cast<UnaryOperator>(TypeExpr); 66780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (UO->getOpcode() == UO_AddrOf || UO->getOpcode() == UO_Deref) { 66790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = UO->getSubExpr(); 66800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 66810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 66820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 66840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::DeclRefExprClass: { 66860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const DeclRefExpr *DRE = cast<DeclRefExpr>(TypeExpr); 66870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko *VD = DRE->getDecl(); 66880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 66890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 66900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 66910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::IntegerLiteralClass: { 66920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IntegerLiteral *IL = cast<IntegerLiteral>(TypeExpr); 66930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::APInt MagicValueAPInt = IL->getValue(); 66940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (MagicValueAPInt.getActiveBits() <= 64) { 66950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko *MagicValue = MagicValueAPInt.getZExtValue(); 66960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 66970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else 66980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 66990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::BinaryConditionalOperatorClass: 67020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::ConditionalOperatorClass: { 67030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const AbstractConditionalOperator *ACO = 67040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<AbstractConditionalOperator>(TypeExpr); 67050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool Result; 67060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (ACO->getCond()->EvaluateAsBooleanCondition(Result, Ctx)) { 67070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Result) 67080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = ACO->getTrueExpr(); 67090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 67100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = ACO->getFalseExpr(); 67110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 67120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::BinaryOperatorClass: { 67170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BinaryOperator *BO = cast<BinaryOperator>(TypeExpr); 67180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (BO->getOpcode() == BO_Comma) { 67190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = BO->getRHS(); 67200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 67210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko default: 67260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 67300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Retrieve the C type corresponding to type tag TypeExpr. 67320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 67330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Expression that specifies a type tag. 67340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 67350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValues Registered magic values. 67360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 67370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param FoundWrongKind Set to true if a type tag was found, but of a wrong 67380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// kind. 67390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 67400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeInfo Information about the corresponding C type. 67410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 67420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \returns true if the corresponding C type was found. 67430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool GetMatchingCType( 67440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IdentifierInfo *ArgumentKind, 67450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *TypeExpr, const ASTContext &Ctx, 67460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const llvm::DenseMap<Sema::TypeTagMagicValue, 67470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData> *MagicValues, 67480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool &FoundWrongKind, 67490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData &TypeInfo) { 67500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind = false; 67510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Variable declaration that has type_tag_for_datatype attribute. 67530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const ValueDecl *VD = NULL; 67540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko uint64_t MagicValue; 67560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!FindTypeTagExpr(TypeExpr, Ctx, &VD, &MagicValue)) 67580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (VD) { 67610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (specific_attr_iterator<TypeTagForDatatypeAttr> 67620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I = VD->specific_attr_begin<TypeTagForDatatypeAttr>(), 67630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko E = VD->specific_attr_end<TypeTagForDatatypeAttr>(); 67640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I != E; ++I) { 67650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I->getArgumentKind() != ArgumentKind) { 67660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind = true; 67670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.Type = I->getMatchingCType(); 67700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.LayoutCompatible = I->getLayoutCompatible(); 67710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.MustBeNull = I->getMustBeNull(); 67720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 67730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 67760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!MagicValues) 67780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::DenseMap<Sema::TypeTagMagicValue, 67810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData>::const_iterator I = 67820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko MagicValues->find(std::make_pair(ArgumentKind, MagicValue)); 67830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I == MagicValues->end()) 67840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 67850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo = I->second; 67870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 67880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 67890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace 67900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::RegisterTypeTagForDatatype(const IdentifierInfo *ArgumentKind, 67920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko uint64_t MagicValue, QualType Type, 67930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool LayoutCompatible, 67940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool MustBeNull) { 67950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeTagForDatatypeMagicValues) 67960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagForDatatypeMagicValues.reset( 67970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko new llvm::DenseMap<TypeTagMagicValue, TypeTagData>); 67980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 67990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagMagicValue Magic(ArgumentKind, MagicValue); 68000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (*TypeTagForDatatypeMagicValues)[Magic] = 68010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagData(Type, LayoutCompatible, MustBeNull); 68020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 68030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 68050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool IsSameCharType(QualType T1, QualType T2) { 68060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BuiltinType *BT1 = T1->getAs<BuiltinType>(); 68070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!BT1) 68080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BuiltinType *BT2 = T2->getAs<BuiltinType>(); 68110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!BT2) 68120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 68130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BuiltinType::Kind T1Kind = BT1->getKind(); 68150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BuiltinType::Kind T2Kind = BT2->getKind(); 68160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return (T1Kind == BuiltinType::SChar && T2Kind == BuiltinType::Char_S) || 68180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::UChar && T2Kind == BuiltinType::Char_U) || 68190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::Char_U && T2Kind == BuiltinType::UChar) || 68200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::Char_S && T2Kind == BuiltinType::SChar); 68210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 68220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace 68230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::CheckArgumentWithTypeTag(const ArgumentWithTypeTagAttr *Attr, 68250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr * const *ExprArgs) { 68260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IdentifierInfo *ArgumentKind = Attr->getArgumentKind(); 68270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool IsPointerAttr = Attr->getIsPointer(); 68280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *TypeTagExpr = ExprArgs[Attr->getTypeTagIdx()]; 68300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool FoundWrongKind; 68310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagData TypeInfo; 68320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!GetMatchingCType(ArgumentKind, TypeTagExpr, Context, 68330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagForDatatypeMagicValues.get(), 68340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind, TypeInfo)) { 68350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (FoundWrongKind) 68360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(TypeTagExpr->getExprLoc(), 68370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko diag::warn_type_tag_for_datatype_wrong_kind) 68380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 68390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 68400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *ArgumentExpr = ExprArgs[Attr->getArgumentIdx()]; 68430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) { 68440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Skip implicit cast of pointer to `void *' (as a function argument). 68450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(ArgumentExpr)) 68465a24980d059cd9fbe8375a4c549313101ad20698Dmitri Gribenko if (ICE->getType()->isVoidPointerType() && 6847b57ce4e8918656f5f4070f59d74354fcefbbb6f8Dmitri Gribenko ICE->getCastKind() == CK_BitCast) 68480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ArgumentExpr = ICE->getSubExpr(); 68490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko QualType ArgumentType = ArgumentExpr->getType(); 68510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Passing a `void*' pointer shouldn't trigger a warning. 68530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr && ArgumentType->isVoidPointerType()) 68540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 68550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TypeInfo.MustBeNull) { 68570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Type tag with matching void type requires a null pointer. 68580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!ArgumentExpr->isNullPointerConstant(Context, 68590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Expr::NPC_ValueDependentIsNotNull)) { 68600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(ArgumentExpr->getExprLoc(), 68610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko diag::warn_type_safety_null_pointer_required) 68620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentKind->getName() 68630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentExpr->getSourceRange() 68640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 68650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 68670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 68680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko QualType RequiredType = TypeInfo.Type; 68700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) 68710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType = Context.getPointerType(RequiredType); 68720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool mismatch = false; 68740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeInfo.LayoutCompatible) { 68750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !Context.hasSameType(ArgumentType, RequiredType); 68760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [basic.fundamental] p1: 68780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Plain char, signed char, and unsigned char are three distinct types. 68790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // 68800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // But we treat plain `char' as equivalent to `signed char' or `unsigned 68810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // char' depending on the current char signedness mode. 68820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (mismatch) 68830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if ((IsPointerAttr && IsSameCharType(ArgumentType->getPointeeType(), 68840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType->getPointeeType())) || 68850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (!IsPointerAttr && IsSameCharType(ArgumentType, RequiredType))) 68860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = false; 68870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else 68880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) 68890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !isLayoutCompatible(Context, 68900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ArgumentType->getPointeeType(), 68910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType->getPointeeType()); 68920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 68930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !isLayoutCompatible(Context, ArgumentType, RequiredType); 68940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 68950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (mismatch) 68960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(ArgumentExpr->getExprLoc(), diag::warn_type_safety_type_mismatch) 68970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentType << ArgumentKind->getName() 68980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeInfo.LayoutCompatible << RequiredType 68990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentExpr->getSourceRange() 69000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 69010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 6902