SemaChecking.cpp revision 8f7462237ff542a4556775f98709ed300aa1731a
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// The LLVM Compiler Infrastructure 459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source 60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details. 759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump// This file implements extra semantic analysis beyond what is enforced 1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// by the C type system. 1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 15e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Sema.h" 162d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 17781472fe99a120098c631b0cbe33c89f8cef5e70John McCall#include "clang/Sema/ScopeInfo.h" 18826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek#include "clang/Analysis/Analyses/FormatString.h" 1959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h" 20199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h" 21384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 22c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h" 232324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h" 247ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h" 25f85e193739c953358c865005855253af4f68a497John McCall#include "clang/AST/EvaluatedExprVisitor.h" 26f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/DeclObjC.h" 27f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h" 28f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h" 2959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h" 30f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h" 31f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h" 323bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h" 33691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher#include "clang/Basic/TargetBuiltins.h" 3426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman#include "clang/Basic/TargetInfo.h" 357da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian#include "clang/Basic/ConvertUTF.h" 36a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits> 3759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang; 38781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema; 3959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 4060800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 4160800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned ByteNo) const { 4208f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner return SL->getLocationOfByte(ByteNo, PP.getSourceManager(), 4308f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner PP.getLangOptions(), PP.getTargetInfo()); 4460800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner} 4508f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner 4660800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 474403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// CheckablePrintfAttr - does a function call have a "printf" attribute 484403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// and arguments that merit checking? 494403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynnbool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) { 504403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf") return true; 514403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf0") { 524403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn // printf0 allows null "format" string; if so don't check format/args 534403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn unsigned format_idx = Format->getFormatIdx() - 1; 544a2614e94672c47395abcde60518776fbebec589Sebastian Redl // Does the index refer to the implicit object argument? 554a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 564a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (format_idx == 0) 574a2614e94672c47395abcde60518776fbebec589Sebastian Redl return false; 584a2614e94672c47395abcde60518776fbebec589Sebastian Redl --format_idx; 594a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 604403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (format_idx < TheCall->getNumArgs()) { 614403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts(); 62efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!Format->isNullPointerConstant(Context, 63efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek Expr::NPC_ValueDependentIsNull)) 644403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return true; 654403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 664403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 674403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return false; 684403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn} 6960800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 708e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number. 718e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking. Returns true on error. 728e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) { 738e10f3b9cc1db43645bbc2999eb163af8997d468John McCall unsigned argCount = call->getNumArgs(); 748e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount == desiredArgCount) return false; 758e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 768e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount < desiredArgCount) 778e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args) 788e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 798e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getSourceRange(); 808e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 818e10f3b9cc1db43645bbc2999eb163af8997d468John McCall // Highlight all the excess arguments. 828e10f3b9cc1db43645bbc2999eb163af8997d468John McCall SourceRange range(call->getArg(desiredArgCount)->getLocStart(), 838e10f3b9cc1db43645bbc2999eb163af8997d468John McCall call->getArg(argCount - 1)->getLocEnd()); 848e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 858e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args) 868e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 878e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getArg(1)->getSourceRange(); 888e10f3b9cc1db43645bbc2999eb163af8997d468John McCall} 898e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 9060d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 91d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 9260d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult TheCallResult(Owned(TheCall)); 932def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor 94946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Find out if any arguments are required to be integer constant expressions. 95946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner unsigned ICEArguments = 0; 96946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ASTContext::GetBuiltinTypeError Error; 97946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 98946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (Error != ASTContext::GE_None) 99946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments = 0; // Don't diagnose previously diagnosed errors. 100946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 101946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // If any arguments are required to be ICE's, check and diagnose. 102946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 103946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Skip arguments not required to be ICE's. 104946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if ((ICEArguments & (1 << ArgNo)) == 0) continue; 105946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 106946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner llvm::APSInt Result; 107946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 108946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner return true; 109946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments &= ~(1 << ArgNo); 110946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner } 111946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 112d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson switch (BuiltinID) { 11330ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin___CFStringMakeConstantString: 114925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner assert(TheCall->getNumArgs() == 1 && 1151b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner "Wrong # arguments to builtin CFStringMakeConstantString"); 116690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner if (CheckObjCString(TheCall->getArg(0))) 1170eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 118d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 11949ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek case Builtin::BI__builtin_stdarg_start: 12030ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin_va_start: 1210eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinVAStart(TheCall)) 1220eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 123d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1241b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreater: 1251b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreaterequal: 1261b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isless: 1271b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessequal: 1281b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessgreater: 1291b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isunordered: 1300eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinUnorderedCompare(TheCall)) 1310eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 132d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 133e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer case Builtin::BI__builtin_fpclassify: 134e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer if (SemaBuiltinFPClassification(TheCall, 6)) 135e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer return ExprError(); 136e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer break; 1379ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isfinite: 1389ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf: 1399ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf_sign: 1409ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnan: 1419ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnormal: 1423b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (SemaBuiltinFPClassification(TheCall, 1)) 1439ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return ExprError(); 1449ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman break; 145d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman case Builtin::BI__builtin_shufflevector: 1460eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return SemaBuiltinShuffleVector(TheCall); 1470eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // TheCall will be freed by the smart pointer here, but that's fine, since 1480eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // SemaBuiltinShuffleVector guts it, but then doesn't release it. 1494493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar case Builtin::BI__builtin_prefetch: 1500eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinPrefetch(TheCall)) 1510eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 152d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 153d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar case Builtin::BI__builtin_object_size: 1540eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinObjectSize(TheCall)) 1550eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 156d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 157d875fed28578835de89cd407e9db4be788596d7cEli Friedman case Builtin::BI__builtin_longjmp: 158d875fed28578835de89cd407e9db4be788596d7cEli Friedman if (SemaBuiltinLongjmp(TheCall)) 159d875fed28578835de89cd407e9db4be788596d7cEli Friedman return ExprError(); 160d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1618e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 1628e10f3b9cc1db43645bbc2999eb163af8997d468John McCall case Builtin::BI__builtin_classify_type: 1638e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1648e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 1658e10f3b9cc1db43645bbc2999eb163af8997d468John McCall break; 16675c29a012793292ff4578015a9113bf086156d7fChris Lattner case Builtin::BI__builtin_constant_p: 1678e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1688e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 16975c29a012793292ff4578015a9113bf086156d7fChris Lattner break; 1705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: 1715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: 1725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: 1735caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: 1745caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: 1755caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_add_and_fetch: 1765caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_sub_and_fetch: 1775caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_and_and_fetch: 1785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_or_and_fetch: 1795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_xor_and_fetch: 1805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 1815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 1825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_test_and_set: 1835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 18423aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: 185d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return SemaBuiltinAtomicOverloaded(move(TheCallResult)); 18626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 18726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 18826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // Since the target specific builtins for each arch overlap, only check those 18926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // of the arch we are compiling for. 19026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (BuiltinID >= Builtin::FirstTSBuiltin) { 19126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman switch (Context.Target.getTriple().getArch()) { 19226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::arm: 19326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::thumb: 19426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 19526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return ExprError(); 19626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 19726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman default: 19826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 19926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 20026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 20126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 20226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return move(TheCallResult); 20326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman} 20426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 20561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code. 20661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) { 20761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman bool quad = t & 0x10; 20861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 20961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman switch (t & 0x7) { 21061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 0: // i8 211d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 7 : (8 << (int)quad) - 1; 21261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 1: // i16 213d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 15 : (4 << (int)quad) - 1; 21461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 2: // i32 215d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 31 : (2 << (int)quad) - 1; 21661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 3: // i64 217d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 63 : (1 << (int)quad) - 1; 21861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 4: // f32 21961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift float types!"); 220d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (2 << (int)quad) - 1; 22161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 5: // poly8 22242499f94069c73d7a9c82da98a4245ea9fe2c526Bob Wilson return shift ? 7 : (8 << (int)quad) - 1; 22361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 6: // poly16 22442499f94069c73d7a9c82da98a4245ea9fe2c526Bob Wilson return shift ? 15 : (4 << (int)quad) - 1; 22561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 7: // float16 22661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift float types!"); 227d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (4 << (int)quad) - 1; 22861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman } 22961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman return 0; 23061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman} 23161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 23226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 2331c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman llvm::APSInt Result; 2341c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2350d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned mask = 0; 23661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned TV = 0; 2371c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman switch (BuiltinID) { 238a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK 239a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 240a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK 2411c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman } 2421c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2430d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which are overloaded on vector element type, validate 2440d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // the immediate which specifies which variant to emit. 2450d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (mask) { 2460d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned ArgNo = TheCall->getNumArgs()-1; 2470d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 2480d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 2490d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 25061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman TV = Result.getLimitedValue(32); 25161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if ((TV > 31) || (mask & (1 << TV)) == 0) 2520d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 2530d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman << TheCall->getArg(ArgNo)->getSourceRange(); 2540d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman } 2551c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2560d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which take an immediate value as part of the 2570d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // instruction, range check them here. 25861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned i = 0, l = 0, u = 0; 2590d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman switch (BuiltinID) { 2600d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman default: return false; 261bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 262bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 26399c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_f: 26499c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 265a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK 266a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 267a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK 2680d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman }; 2690d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 27061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Check that the immediate argument is actually a constant. 2710d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, i, Result)) 2720d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 2730d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 27461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Range check against the upper/lower values for this isntruction. 2750d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned Val = Result.getZExtValue(); 27661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if (Val < l || Val > (u + l)) 2770d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 278476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer << l << u+l << TheCall->getArg(i)->getSourceRange(); 2790d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 28099c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman // FIXME: VFP Intrinsics should error if VFP not present. 28126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return false; 282d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson} 283d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 284d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// CheckFunctionCall - Check a direct function call for various correctness 285d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// and safety properties not strictly enforced by the C type system. 286d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) { 287d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // Get the IdentifierInfo* for the called function. 288d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson IdentifierInfo *FnInfo = FDecl->getIdentifier(); 289de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 290d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // None of the checks below are needed for functions that don't have 291d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // simple names (e.g., C++ conversion functions). 292d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson if (!FnInfo) 293d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 2941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 295de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // FIXME: This mechanism should be abstracted to be less fragile and 296de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // more efficient. For example, just map function ids to custom 297de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // handlers. 298de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 299c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek // Printf and scanf checking. 300c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<FormatAttr> 301c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<FormatAttr>(), 302c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<FormatAttr>(); i != e ; ++i) { 303c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek 304c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek const FormatAttr *Format = *i; 305826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 306826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (b || CheckablePrintfAttr(Format, TheCall)) { 3073d692df4b9c58895f9843b03543ec57447c93679Ted Kremenek bool HasVAListArg = Format->getFirstArg() == 0; 308826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, 309826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Format->getFormatIdx() - 1, 310826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, 311826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek !b); 3123c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor } 31359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner } 3141eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 315c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<NonNullAttr> 316c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<NonNullAttr>(), 317c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<NonNullAttr>(); i != e; ++i) { 318909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky CheckNonNullArguments(*i, TheCall->getArgs(), 319909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky TheCall->getCallee()->getLocStart()); 320c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek } 3210eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 322bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Builtin handling 323707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor int CMF = -1; 324707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor switch (FDecl->getBuiltinID()) { 325707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin_memset: 326707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin___memset_chk: 327707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BImemset: 328707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memset; 329707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor break; 330707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor 331707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin_memcpy: 332707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin___memcpy_chk: 333707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BImemcpy: 334707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memcpy; 335707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor break; 336707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor 337707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin_memmove: 338707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin___memmove_chk: 339707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BImemmove: 340707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memmove; 341707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor break; 342bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 343bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek case Builtin::BIstrlcpy: 344bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek case Builtin::BIstrlcat: 345bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CheckStrlcpycatArguments(TheCall, FnInfo); 346bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 347707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor 348cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay case Builtin::BI__builtin_memcmp: 349cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay CMF = CMF_Memcmp; 350cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay break; 351cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay 352707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor default: 353707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor if (FDecl->getLinkage() == ExternalLinkage && 354707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor (!getLangOptions().CPlusPlus || FDecl->isExternC())) { 355707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor if (FnInfo->isStr("memset")) 356707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memset; 357707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor else if (FnInfo->isStr("memcpy")) 358707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memcpy; 359707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor else if (FnInfo->isStr("memmove")) 360707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memmove; 361cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay else if (FnInfo->isStr("memcmp")) 362cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay CMF = CMF_Memcmp; 363707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor } 364707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor break; 36506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 366707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor 367bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Memset/memcpy/memmove handling 368707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor if (CMF != -1) 369cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay CheckMemaccessArguments(TheCall, CheckedMemoryFunction(CMF), FnInfo); 3707ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 371d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 37271993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson} 37371993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 374d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) { 375725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian // Printf checking. 37640b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis const FormatAttr *Format = NDecl->getAttr<FormatAttr>(); 377725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Format) 378d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 380725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian const VarDecl *V = dyn_cast<VarDecl>(NDecl); 381725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!V) 382d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 384725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian QualType Ty = V->getType(); 385725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Ty->isBlockPointerType()) 386d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 388826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 389826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!b && !CheckablePrintfAttr(Format, TheCall)) 390d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3911eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 392d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson bool HasVAListArg = Format->getFirstArg() == 0; 393826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1, 394826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, !b); 395d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 396d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 397725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian} 398725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian 3995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like 4005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer 4015caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument. The main ActOnCallExpr routines have already 4025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as 4035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...). 4045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// 4055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these 4065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins, 40760d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 40860d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 409d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 4105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 4115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 4125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 4135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Ensure that we have at least one argument to do type inference from. 414d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1) { 415d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 416d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1 << TheCall->getNumArgs() 417d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 418d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 419d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 4201eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Inspect the first argument of the atomic builtin. This should always be 4225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // a pointer type, whose element is an integral scalar or pointer type. 4235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Because it is a pointer type, we don't have to worry about any implicit 4245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // casts here. 425d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth // FIXME: We don't allow floating point scalars as input. 4265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *FirstArg = TheCall->getArg(0); 427f85e193739c953358c865005855253af4f68a497John McCall const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>(); 428f85e193739c953358c865005855253af4f68a497John McCall if (!pointerType) { 429d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 430d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 431d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 432d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 4331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 434f85e193739c953358c865005855253af4f68a497John McCall QualType ValType = pointerType->getPointeeType(); 435dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 436d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth !ValType->isBlockPointerType()) { 437d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 438d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 439d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 440d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 4415caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 442f85e193739c953358c865005855253af4f68a497John McCall switch (ValType.getObjCLifetime()) { 443f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 444f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 445f85e193739c953358c865005855253af4f68a497John McCall // okay 446f85e193739c953358c865005855253af4f68a497John McCall break; 447f85e193739c953358c865005855253af4f68a497John McCall 448f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 449f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 450f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 451b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 452f85e193739c953358c865005855253af4f68a497John McCall << ValType << FirstArg->getSourceRange(); 453f85e193739c953358c865005855253af4f68a497John McCall return ExprError(); 454f85e193739c953358c865005855253af4f68a497John McCall } 455f85e193739c953358c865005855253af4f68a497John McCall 4568d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // The majority of builtins return a value, but a few have special return 4578d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // types, so allow them to override appropriately below. 4588d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth QualType ResultType = ValType; 4598d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth 4605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // We need to figure out which concrete builtin this maps onto. For example, 4615caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add with a 2 byte object turns into 4625caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add_2. 4635caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \ 4645caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 4655caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Builtin::BI##x##_8, Builtin::BI##x##_16 } 4661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4675caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner static const unsigned BuiltinIndices[][5] = { 4685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_add), 4695caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_sub), 4705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_or), 4715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_and), 4725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_xor), 4731eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4745caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_add_and_fetch), 4755caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_sub_and_fetch), 4765caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_and_and_fetch), 4775caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_or_and_fetch), 4785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_xor_and_fetch), 4791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_val_compare_and_swap), 4815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_bool_compare_and_swap), 4825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_test_and_set), 48323aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_lock_release), 48423aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_swap) 4855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner }; 4861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW 4871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Determine the index of the size. 4895caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned SizeIndex; 490199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 4915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 1: SizeIndex = 0; break; 4925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 2: SizeIndex = 1; break; 4935caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 4: SizeIndex = 2; break; 4945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 8: SizeIndex = 3; break; 4955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 16: SizeIndex = 4; break; 4965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: 497d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 498d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 499d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 5005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 5011eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Each of these builtins has one pointer argument, followed by some number of 5035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // values (0, 1 or 2) followed by a potentially empty varags list of stuff 5045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // that we ignore. Find out which row of BuiltinIndices to read from as well 5055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // as the number of fixed args. 5067814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor unsigned BuiltinID = FDecl->getBuiltinID(); 5075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned BuiltinIndex, NumFixed = 1; 5085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner switch (BuiltinID) { 5095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: assert(0 && "Unknown overloaded atomic builtin!"); 5105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break; 5115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break; 5125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break; 5135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break; 5145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break; 5151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5167eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break; 5177eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break; 5187eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break; 5197eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break; 5207eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break; 5211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 5237eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 10; 5245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 5255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 5265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 5277eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 11; 5285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 5298d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.BoolTy; 5305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 5317eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break; 5325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 5337eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 13; 5345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 0; 5358d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.VoidTy; 5365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 53723aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: BuiltinIndex = 14; break; 5385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 5391eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Now that we know how many fixed arguments we expect, first check that we 5415caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // have at least that many. 542d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1+NumFixed) { 543d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 544d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1+NumFixed << TheCall->getNumArgs() 545d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 546d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 547d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 5481eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 549e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // Get the decl for the concrete builtin from this, we can tell what the 550e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // concrete integer type we should convert to is. 551e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 552e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 553e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName); 5541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump FunctionDecl *NewBuiltinDecl = 555e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID, 556e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner TUScope, false, DRE->getLocStart())); 557d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 558f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // The first argument --- the pointer --- has a fixed type; we 559f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // deduce the types of the rest of the arguments accordingly. Walk 560f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // the remaining arguments, converting them to the deduced value type. 5615caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner for (unsigned i = 0; i != NumFixed; ++i) { 562429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult Arg = TheCall->getArg(i+1); 5631eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5645caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // If the argument is an implicit cast, then there was a promotion due to 5655caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // "...", just remove it now. 566429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg.get())) { 5675caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Arg = ICE->getSubExpr(); 5685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner ICE->setSubExpr(0); 569429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(i+1, Arg.get()); 5705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 5711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // GCC does an implicit conversion to the pointer or integer ValType. This 5735caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // can fail in some cases (1i -> int**), check for this error case now. 574daa8e4e888758d55a7a759dd4a91b83921cef222John McCall CastKind Kind = CK_Invalid; 575f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall ExprValueKind VK = VK_RValue; 576f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall CXXCastPath BasePath; 577f85e193739c953358c865005855253af4f68a497John McCall Arg = CheckCastTypes(Arg.get()->getLocStart(), Arg.get()->getSourceRange(), 578f85e193739c953358c865005855253af4f68a497John McCall ValType, Arg.take(), Kind, VK, BasePath); 579429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (Arg.isInvalid()) 580d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 5811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Okay, we have something that *can* be converted to the right type. Check 5835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // to see if there is a potentially weird extension going on here. This can 5845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // happen when you do an atomic operation on something like an char* and 5855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // pass in 42. The 42 gets converted to char. This is even more strange 5865caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // for things like 45.123 -> char, etc. 5871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // FIXME: Do this check. 588429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley Arg = ImpCastExprToType(Arg.take(), ValType, Kind, VK, &BasePath); 589429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(i+1, Arg.get()); 5905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 5911eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Switch the DeclRefExpr to refer to the new decl. 5935caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DRE->setDecl(NewBuiltinDecl); 5945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DRE->setType(NewBuiltinDecl->getType()); 5951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Set the callee in the CallExpr. 5975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // FIXME: This leaks the original parens and implicit casts. 598429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult PromotedCall = UsualUnaryConversions(DRE); 599429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (PromotedCall.isInvalid()) 600429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return ExprError(); 601429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setCallee(PromotedCall.take()); 6021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 603db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // Change the result type of the call to match the original value type. This 604db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // is arbitrary, but the codegen for these builtins ins design to handle it 605db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // gracefully. 6068d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth TheCall->setType(ResultType); 607d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 608d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return move(TheCallResult); 6095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner} 6105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 6115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 612690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin 61371993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct 614fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would 615fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend). 616690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) { 61756f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner Arg = Arg->IgnoreParenCasts(); 61871993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 61971993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 6205cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!Literal || !Literal->isAscii()) { 621fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 622fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << Arg->getSourceRange(); 6239cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return true; 62471993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson } 6251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 6267da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Literal->containsNonAsciiOrNull()) { 6275f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef String = Literal->getString(); 6287da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian unsigned NumBytes = String.size(); 6295f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<UTF16, 128> ToBuf(NumBytes); 6307da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian const UTF8 *FromPtr = (UTF8 *)String.data(); 6317da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian UTF16 *ToPtr = &ToBuf[0]; 6327da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 6337da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 6347da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian &ToPtr, ToPtr + NumBytes, 6357da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian strictConversion); 6367da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian // Check for conversion failure. 6377da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Result != conversionOK) 6387da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian Diag(Arg->getLocStart(), 6397da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian diag::warn_cfstring_truncated) << Arg->getSourceRange(); 6407da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian } 6419cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return false; 64259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner} 64359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 644c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 645c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success. 646925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 647925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *Fn = TheCall->getCallee(); 648925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) { 6492c21a073525cdfa68e4439b7af551385dc2796abChris Lattner Diag(TheCall->getArg(2)->getLocStart(), 650fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 651ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 652ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << Fn->getSourceRange() 6531eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(2)->getLocStart(), 654fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 65530ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 65630ce344307f8a8b00054021307015571f83c7364Chris Lattner } 65756f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 65856f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman if (TheCall->getNumArgs() < 2) { 659d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher return Diag(TheCall->getLocEnd(), 660d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 661d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 66256f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman } 66356f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 664c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner // Determine whether the current function is variadic or not. 6659ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor BlockScopeInfo *CurBlock = getCurBlock(); 666c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner bool isVariadic; 667cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 668c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall isVariadic = CurBlock->TheDecl->isVariadic(); 6699498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else if (FunctionDecl *FD = getCurFunctionDecl()) 6709498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek isVariadic = FD->isVariadic(); 6719498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else 67253d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis isVariadic = getCurMethodDecl()->isVariadic(); 6731eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 674c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner if (!isVariadic) { 67530ce344307f8a8b00054021307015571f83c7364Chris Lattner Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 67630ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 67730ce344307f8a8b00054021307015571f83c7364Chris Lattner } 6781eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 67930ce344307f8a8b00054021307015571f83c7364Chris Lattner // Verify that the second argument to the builtin is the last argument of the 68030ce344307f8a8b00054021307015571f83c7364Chris Lattner // current function or method. 68130ce344307f8a8b00054021307015571f83c7364Chris Lattner bool SecondArgIsLastNamedArgument = false; 682e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 6831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 68488cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 68588cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 68630ce344307f8a8b00054021307015571f83c7364Chris Lattner // FIXME: This isn't correct for methods (results in bogus warning). 68730ce344307f8a8b00054021307015571f83c7364Chris Lattner // Get the last formal in the current function. 68888cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson const ParmVarDecl *LastArg; 689cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 690cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff LastArg = *(CurBlock->TheDecl->param_end()-1); 691cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff else if (FunctionDecl *FD = getCurFunctionDecl()) 692371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner LastArg = *(FD->param_end()-1); 69330ce344307f8a8b00054021307015571f83c7364Chris Lattner else 69453d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis LastArg = *(getCurMethodDecl()->param_end()-1); 69530ce344307f8a8b00054021307015571f83c7364Chris Lattner SecondArgIsLastNamedArgument = PV == LastArg; 69630ce344307f8a8b00054021307015571f83c7364Chris Lattner } 69730ce344307f8a8b00054021307015571f83c7364Chris Lattner } 6981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 69930ce344307f8a8b00054021307015571f83c7364Chris Lattner if (!SecondArgIsLastNamedArgument) 7001eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(1)->getLocStart(), 70130ce344307f8a8b00054021307015571f83c7364Chris Lattner diag::warn_second_parameter_of_va_start_not_last_named_argument); 70230ce344307f8a8b00054021307015571f83c7364Chris Lattner return false; 7036cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman} 70430ce344307f8a8b00054021307015571f83c7364Chris Lattner 7051b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 7061b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends. This is declared to take (...), so we have to check everything. 707925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 708925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() < 2) 7092c21a073525cdfa68e4439b7af551385dc2796abChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 710d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << 2 << TheCall->getNumArgs()/*function call*/; 711925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) 7121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(TheCall->getArg(2)->getLocStart(), 713fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 714ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 715fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(TheCall->getArg(2)->getLocStart(), 716fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 7171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 718429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg0 = TheCall->getArg(0); 719429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg1 = TheCall->getArg(1); 720cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 7211b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // Do standard promotions between the two arguments, returning their common 7221b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // type. 723925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 724429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.isInvalid() || OrigArg1.isInvalid()) 725429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return true; 726403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar 727403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // Make sure any conversions are pushed back into the call; this is 728403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // type safe since unordered compare builtins are declared as "_Bool 729403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // foo(...)". 730429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(0, OrigArg0.get()); 731429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(1, OrigArg1.get()); 7321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 733429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent()) 734cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 735cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 7361b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // If the common type isn't a real floating type, then the arguments were 7371b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // invalid for this operation. 7381b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner if (!Res->isRealFloatingType()) 739429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return Diag(OrigArg0.get()->getLocStart(), 740fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_invalid_ordered_compare) 741429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << OrigArg0.get()->getType() << OrigArg1.get()->getType() 742429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd()); 7431eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7441b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner return false; 7451b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner} 7461b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner 747e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 748e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends. This is declared to take (...), so we have 7493b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point 7503b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value. 7513b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 7523b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() < NumArgs) 7539ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 754d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 7553b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() > NumArgs) 7563b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer return Diag(TheCall->getArg(NumArgs)->getLocStart(), 7579ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_too_many_args) 758ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 7593b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 7609ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman (*(TheCall->arg_end()-1))->getLocEnd()); 7619ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 7623b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer Expr *OrigArg = TheCall->getArg(NumArgs-1); 7631eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7649ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (OrigArg->isTypeDependent()) 7659ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 7669ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 76781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // This operation requires a non-_Complex floating-point number. 7689ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (!OrigArg->getType()->isRealFloatingType()) 7691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg->getLocStart(), 7709ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_invalid_unary_fp) 7719ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman << OrigArg->getType() << OrigArg->getSourceRange(); 7721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 77381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // If this is an implicit conversion from float -> double, remove it. 77481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 77581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Expr *CastArg = Cast->getSubExpr(); 77681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 77781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 77881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner "promotion from float to double is the only expected cast here"); 77981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Cast->setSubExpr(0); 78081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner TheCall->setArg(NumArgs-1, CastArg); 78181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner OrigArg = CastArg; 78281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 78381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 78481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner 7859ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 7869ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman} 7879ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 788d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 789d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything. 79060d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 79137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() < 2) 7920eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocEnd(), 793d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 79437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << 0 /*function call*/ << 2 << TheCall->getNumArgs() 795d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << TheCall->getSourceRange()); 796d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 79737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Determine which of the following types of shufflevector we're checking: 79837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 1) unary, vector mask: (lhs, mask) 79937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 2) binary, vector mask: (lhs, rhs, mask) 80037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 80137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType resType = TheCall->getArg(0)->getType(); 80237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numElements = 0; 80337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 804cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (!TheCall->getArg(0)->isTypeDependent() && 805cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor !TheCall->getArg(1)->isTypeDependent()) { 80637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType LHSType = TheCall->getArg(0)->getType(); 80737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType RHSType = TheCall->getArg(1)->getType(); 80837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 80937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!LHSType->isVectorType() || !RHSType->isVectorType()) { 810cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) 8111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 812cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 813cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 814cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 81537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 81637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numElements = LHSType->getAs<VectorType>()->getNumElements(); 81737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numResElements = TheCall->getNumArgs() - 2; 81837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 81937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Check to see if we have a call with 2 vector arguments, the unary shuffle 82037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // with mask. If so, verify that RHS is an integer vector type with the 82137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // same number of elts as lhs. 82237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() == 2) { 823f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (!RHSType->hasIntegerRepresentation() || 82437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman RHSType->getAs<VectorType>()->getNumElements() != numElements) 82537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 82637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << SourceRange(TheCall->getArg(1)->getLocStart(), 82737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman TheCall->getArg(1)->getLocEnd()); 82837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numResElements = numElements; 82937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } 83037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 831cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 8321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 833cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 834cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 83537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } else if (numElements != numResElements) { 83637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 837788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner resType = Context.getVectorType(eltType, numResElements, 838e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson VectorType::GenericVector); 839cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 840d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 841d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 842d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 843cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 844cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(i)->isValueDependent()) 845cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor continue; 846cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 84737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman llvm::APSInt Result(32); 84837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 84937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman return ExprError(Diag(TheCall->getLocStart(), 85037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman diag::err_shufflevector_nonconstant_argument) 85137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << TheCall->getArg(i)->getSourceRange()); 8520eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 853d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 8540eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocStart(), 855fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_shufflevector_argument_too_large) 8560eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl << TheCall->getArg(i)->getSourceRange()); 857d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 858d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 8595f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<Expr*, 32> exprs; 860d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 861d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 862d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman exprs.push_back(TheCall->getArg(i)); 863d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman TheCall->setArg(i, 0); 864d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 865d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 866a88dc3079bedf70a5cfc39791727e43a10383006Nate Begeman return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(), 86737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman exprs.size(), resType, 8688189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getCallee()->getLocStart(), 8698189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getRParenLoc())); 870d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman} 87130ce344307f8a8b00054021307015571f83c7364Chris Lattner 8724493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 8734493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two 8744493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args. 8754493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 876fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner unsigned NumArgs = TheCall->getNumArgs(); 8774493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 878fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (NumArgs > 3) 879ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher return Diag(TheCall->getLocEnd(), 880ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher diag::err_typecheck_call_too_many_args_at_most) 881ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 3 << NumArgs 882ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << TheCall->getSourceRange(); 8834493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 8844493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // Argument 0 is checked for us and the remaining arguments must be 8854493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // constant integers. 886fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner for (unsigned i = 1; i != NumArgs; ++i) { 8874493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar Expr *Arg = TheCall->getArg(i); 888691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 8899aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman llvm::APSInt Result; 890691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, i, Result)) 891691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 8921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8934493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // FIXME: gcc issues a warning and rewrites these to 0. These 8944493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // seems especially odd for the third argument since the default 8954493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // is 3. 896fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (i == 1) { 8979aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 1) 898fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 89921fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "1" << Arg->getSourceRange(); 9004493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } else { 9019aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 3) 902fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 90321fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "3" << Arg->getSourceRange(); 9044493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 9054493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 9064493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 907fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return false; 9084493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar} 9094493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 910691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 911691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression. 912691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 913691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt &Result) { 914691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(ArgNum); 915691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 916691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 917691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 918691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 919691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 920691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (!Arg->isIntegerConstantExpr(Result, Context)) 921691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 9225e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher << FDecl->getDeclName() << Arg->getSourceRange(); 923691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 92421fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner return false; 92521fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner} 92621fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner 927d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 928d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined 929d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3). 930fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner// For compatibility check 0-3, llvm only handles 0 and 2. 931d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 932691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 933691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 934691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // Check constant-ness first. 935691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 936691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 937d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 938691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(1); 939d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 940fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 941fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 942d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar } 943d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 944d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar return false; 945d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar} 946d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 947586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 948d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1. 949d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 950d875fed28578835de89cd407e9db4be788596d7cEli Friedman Expr *Arg = TheCall->getArg(1); 951691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 952cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 953691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // TODO: This is less than ideal. Overload this to take a value. 954691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 955691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 956691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 957691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Result != 1) 958d875fed28578835de89cd407e9db4be788596d7cEli Friedman return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 959d875fed28578835de89cd407e9db4be788596d7cEli Friedman << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 960d875fed28578835de89cd407e9db4be788596d7cEli Friedman 961d875fed28578835de89cd407e9db4be788596d7cEli Friedman return false; 962d875fed28578835de89cd407e9db4be788596d7cEli Friedman} 963d875fed28578835de89cd407e9db4be788596d7cEli Friedman 964b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek// Handle i > 1 ? "x" : "y", recursively. 965082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenekbool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall, 966082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool HasVAListArg, 967826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 968826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 9694fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain: 970cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 971cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 972d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 973f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 974f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 975d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek switch (E->getStmtClass()) { 97656ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::BinaryConditionalOperatorClass: 977d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ConditionalOperatorClass: { 97856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall const AbstractConditionalOperator *C = cast<AbstractConditionalOperator>(E); 979826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return SemaCheckStringLiteral(C->getTrueExpr(), TheCall, HasVAListArg, 980826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf) 98156ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall && SemaCheckStringLiteral(C->getFalseExpr(), TheCall, HasVAListArg, 982826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf); 983d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 984d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 98595355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek case Stmt::IntegerLiteralClass: 98695355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // Technically -Wformat-nonliteral does not warn about this case. 98795355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // The behavior of printf and friends in this case is implementation 98895355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // dependent. Ideally if the format string cannot be null then 98995355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // it should have a 'nonnull' attribute in the function prototype. 99095355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek return true; 99195355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek 992d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ImplicitCastExprClass: { 9934fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ImplicitCastExpr>(E)->getSubExpr(); 9944fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 995d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 996d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 99756ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::OpaqueValueExprClass: 99856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) { 99956ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall E = src; 100056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall goto tryAgain; 100156ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall } 100256ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall return false; 100356ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall 1004b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek case Stmt::PredefinedExprClass: 1005b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // While __func__, etc., are technically not string literals, they 1006b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // cannot contain format specifiers and thus are not a security 1007b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // liability. 1008b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek return true; 1009b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek 1010082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::DeclRefExprClass: { 1011082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const DeclRefExpr *DR = cast<DeclRefExpr>(E); 10121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1013082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // As an exception, do not flag errors for variables binding to 1014082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // const string literals. 1015082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 1016082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool isConstant = false; 1017082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek QualType T = DR->getType(); 1018082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek 1019082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ArrayType *AT = Context.getAsArrayType(T)) { 1020082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek isConstant = AT->getElementType().isConstant(Context); 1021ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (const PointerType *PT = T->getAs<PointerType>()) { 10221eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump isConstant = T.isConstant(Context) && 1023082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek PT->getPointeeType().isConstant(Context); 1024082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 10251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1026082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (isConstant) { 102731310a21fb2a9f13950f864f681c86080b05d5b2Sebastian Redl if (const Expr *Init = VD->getAnyInitializer()) 1028082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return SemaCheckStringLiteral(Init, TheCall, 1029826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, format_idx, firstDataArg, 1030826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isPrintf); 1031082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 10321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1033d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // For vprintf* functions (i.e., HasVAListArg==true), we add a 1034d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // special check to see if the format string is a function parameter 1035d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // of the function calling the printf function. If the function 1036d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // has an attribute indicating it is a printf-like function, then we 1037d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // should suppress warnings concerning non-literals being used in a call 1038d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // to a vprintf function. For example: 1039d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1040d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // void 1041d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 1042d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_list ap; 1043d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_start(ap, fmt); 1044d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 1045d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // ... 1046d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1047d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1048d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // FIXME: We don't have full attribute support yet, so just check to see 1049d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // if the argument is a DeclRefExpr that references a parameter. We'll 1050d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // add proper support for checking the attribute later. 1051d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (HasVAListArg) 1052d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (isa<ParmVarDecl>(VD)) 1053d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson return true; 1054082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 10551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1056082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1057082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 1058d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 10598f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson case Stmt::CallExprClass: { 10608f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const CallExpr *CE = cast<CallExpr>(E); 10611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump if (const ImplicitCastExpr *ICE 10628f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson = dyn_cast<ImplicitCastExpr>(CE->getCallee())) { 10638f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) { 10648f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) { 106540b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) { 10668f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson unsigned ArgIndex = FA->getFormatIdx(); 10678f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const Expr *Arg = CE->getArg(ArgIndex - 1); 10681eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg, 1070826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf); 10718f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 10728f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 10738f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 10748f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 10751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10768f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson return false; 10778f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 1078082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::ObjCStringLiteralClass: 1079082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::StringLiteralClass: { 1080082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const StringLiteral *StrE = NULL; 10811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1082082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 1083d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek StrE = ObjCFExpr->getString(); 1084d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek else 1085082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek StrE = cast<StringLiteral>(E); 10861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1087d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek if (StrE) { 1088826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatString(StrE, E, TheCall, HasVAListArg, format_idx, 1089826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek firstDataArg, isPrintf); 1090d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return true; 1091d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 10921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1093d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return false; 1094d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 10951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1096082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek default: 1097082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1098d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1099d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1100d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1101e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid 11021eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull, 1103909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr * const *ExprArgs, 1104909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky SourceLocation CallSiteLoc) { 1105cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt for (NonNullAttr::args_iterator i = NonNull->args_begin(), 1106cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt e = NonNull->args_end(); 1107e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian i != e; ++i) { 1108909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr *ArgExpr = ExprArgs[*i]; 11094e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (ArgExpr->isNullPointerConstant(Context, 1110ce94049b69f75b44c18584fe79cd238978b6b0d5Douglas Gregor Expr::NPC_ValueDependentIsNotNull)) 1111909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange(); 1112e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian } 1113e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian} 1114d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1115826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar 1116826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings. 111759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnervoid 1118826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSema::CheckPrintfScanfArguments(const CallExpr *TheCall, bool HasVAListArg, 1119826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1120826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 1121826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1122082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *Fn = TheCall->getCallee(); 1123925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner 11244a2614e94672c47395abcde60518776fbebec589Sebastian Redl // The way the format attribute works in GCC, the implicit this argument 11254a2614e94672c47395abcde60518776fbebec589Sebastian Redl // of member functions is counted. However, it doesn't appear in our own 11264a2614e94672c47395abcde60518776fbebec589Sebastian Redl // lists, so decrement format_idx in that case. 11274a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 11289263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth const CXXMethodDecl *method_decl = 11299263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth dyn_cast<CXXMethodDecl>(TheCall->getCalleeDecl()); 11309263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if (method_decl && method_decl->isInstance()) { 11319263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth // Catch a format attribute mistakenly referring to the object argument. 11329263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if (format_idx == 0) 11339263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth return; 11349263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth --format_idx; 11359263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if(firstDataArg != 0) 11369263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth --firstDataArg; 11379263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth } 11384a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 11394a2614e94672c47395abcde60518776fbebec589Sebastian Redl 1140826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // CHECK: printf/scanf-like function is called with no format string. 1141925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (format_idx >= TheCall->getNumArgs()) { 1142826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Diag(TheCall->getRParenLoc(), diag::warn_missing_format_string) 1143dcd5ef12488e4c7ea844327835896ca86b609a97Chris Lattner << Fn->getSourceRange(); 114471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek return; 114571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek } 11461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1147082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts(); 11481eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 114959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner // CHECK: format string is not a string literal. 11501eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // 115171895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // Dynamically generated format strings are difficult to 115271895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // automatically vet at compile time. Requiring that format strings 115371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // are string literals: (1) permits the checking of format strings by 115471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // the compiler and thereby (2) can practically remove the source of 115571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // many format string exploits. 11567ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek 11571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // Format string can be either ObjC string (e.g. @"%d") or 11587ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // C string (e.g. "%d") 11591eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // ObjC string uses the same format specifiers as C string, so we can use 11607ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // the same format string checking logic for both ObjC and C strings. 11611cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx, 1162826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek firstDataArg, isPrintf)) 11631cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner return; // Literal format string found, check done! 11641cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner 1165655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // If there are no arguments specified, warn with -Wformat-security, otherwise 1166655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // warn only with -Wformat-nonliteral. 1167655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner if (TheCall->getNumArgs() == format_idx+1) 11681eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1169826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral_noargs) 1170655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1171655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner else 11721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1173826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral) 1174655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1175d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1176d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1177e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace { 1178826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler { 1179826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1180e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Sema &S; 1181e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const StringLiteral *FExpr; 1182e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const Expr *OrigFormatExpr; 11836ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const unsigned FirstDataArg; 1184e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const unsigned NumDataArgs; 1185e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const bool IsObjCLiteral; 1186e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *Beg; // Start of format string. 11870d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const bool HasVAListArg; 11880d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const CallExpr *TheCall; 11890d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek unsigned FormatIdx; 11907f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek llvm::BitVector CoveredArgs; 1191efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool usesPositionalArgs; 1192efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool atFirstArg; 11934e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic: 1194826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 11956ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1196e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 11970d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const char *beg, bool hasVAListArg, 11980d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1199e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 12006ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek FirstDataArg(firstDataArg), 12017f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek NumDataArgs(numDataArgs), 12020d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek IsObjCLiteral(isObjCLiteral), Beg(beg), 12030d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek HasVAListArg(hasVAListArg), 1204efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek TheCall(theCall), FormatIdx(formatIdx), 1205efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek usesPositionalArgs(false), atFirstArg(true) { 12067f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.resize(numDataArgs); 12077f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.reset(); 12087f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 12094e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 121007d161f38e708a91486bf1c031d525faebbb249dTed Kremenek void DoneProcessing(); 12114e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1212826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIncompleteSpecifier(const char *startSpecifier, 1213826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1214826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1215efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleInvalidPosition(const char *startSpecifier, 1216efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned specifierLen, 1217826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p); 1218efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1219efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 1220efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1221e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek void HandleNullChar(const char *nullCharacter); 12224e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1223826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1224c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 1225c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1226c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1227c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, unsigned csLen); 1228c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1229f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek SourceRange getFormatStringRange(); 1230826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CharSourceRange getSpecifierRange(const char *startSpecifier, 1231826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1232e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek SourceLocation getLocationOfByte(const char *x); 12334e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 12340d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const Expr *getDataArg(unsigned i) const; 1235666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1236666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 1237666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1238666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, 1239666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek unsigned argIndex); 1240e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}; 1241e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1242e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1243826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() { 1244e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return OrigFormatExpr->getSourceRange(); 1245e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1246e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1247826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler:: 1248826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 124945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation Start = getLocationOfByte(startSpecifier); 125045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 125145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 125245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care // Advance the end SourceLocation by one due to half-open ranges. 125345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care End = End.getFileLocWithOffset(1); 125445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 125545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care return CharSourceRange::getCharRange(Start, End); 1256f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek} 1257f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek 1258826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 12594e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 1260e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1261e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1262826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 1263826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen){ 1264808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek SourceLocation Loc = getLocationOfByte(startSpecifier); 1265808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek S.Diag(Loc, diag::warn_printf_incomplete_specifier) 1266826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1267808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek} 1268808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek 1269efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid 1270826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 1271826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p) { 1272efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek SourceLocation Loc = getLocationOfByte(startPos); 1273826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(Loc, diag::warn_format_invalid_positional_specifier) 1274826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << (unsigned) p << getSpecifierRange(startPos, posLen); 1275efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1276efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1277826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos, 1278efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned posLen) { 1279efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek SourceLocation Loc = getLocationOfByte(startPos); 1280826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(Loc, diag::warn_format_zero_positional_specifier) 1281826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startPos, posLen); 1282efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1283efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1284826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 12850c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek if (!IsObjCLiteral) { 12860c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek // The presence of a null character is likely an error. 12870c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek S.Diag(getLocationOfByte(nullCharacter), 12880c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek diag::warn_printf_format_string_contains_null_char) 12890c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek << getFormatStringRange(); 12900c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek } 1291826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1292826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1293826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const { 1294826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return TheCall->getArg(FirstDataArg + i); 1295826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 12964e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1297826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() { 1298826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Does the number of data arguments exceed the number of 1299826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // format conversions in the format string? 1300826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!HasVAListArg) { 1301826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Find any arguments that weren't covered. 1302826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.flip(); 1303826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek signed notCoveredArg = CoveredArgs.find_first(); 1304826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (notCoveredArg >= 0) { 1305826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek assert((unsigned)notCoveredArg < NumDataArgs); 1306826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(), 1307826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_printf_data_arg_not_used) 1308826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getFormatStringRange(); 1309826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1310826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1311826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1312826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1313c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool 1314c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 1315c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek SourceLocation Loc, 1316c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1317c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1318c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, 1319c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned csLen) { 1320c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1321c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool keepGoing = true; 1322c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek if (argIndex < NumDataArgs) { 1323c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // Consider the argument coverered, even though the specifier doesn't 1324c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // make sense. 1325c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CoveredArgs.set(argIndex); 1326c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1327c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek else { 1328c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // If argIndex exceeds the number of data arguments we 1329c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // don't issue a warning because that is just a cascade of warnings (and 1330c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // they may have intended '%%' anyway). We don't want to continue processing 1331c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // the format string after this point, however, as we will like just get 1332c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // gibberish when trying to match arguments. 1333c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek keepGoing = false; 1334c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1335c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1336c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek S.Diag(Loc, diag::warn_format_invalid_conversion) 13375f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner << StringRef(csStart, csLen) 1338c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek << getSpecifierRange(startSpec, specifierLen); 1339c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1340c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return keepGoing; 1341c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1342c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1343666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool 1344666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs( 1345666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::FormatSpecifier &FS, 1346666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1347666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 1348666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1349666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (argIndex >= NumDataArgs) { 1350666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (FS.usesPositionalArg()) { 1351666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1352666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek diag::warn_printf_positional_arg_exceeds_data_args) 1353666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << (argIndex+1) << NumDataArgs 1354666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1355666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1356666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek else { 1357666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1358666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek diag::warn_printf_insufficient_data_args) 1359666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1360666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1361666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1362666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return false; 1363666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1364666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return true; 1365666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek} 1366666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1367826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===// 1368826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1369826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 1370826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler { 1371826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 1372826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 1373826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1374826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 1375826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 1376826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1377826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1378826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 1379826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek theCall, formatIdx) {} 1380826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1381826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1382826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleInvalidPrintfConversionSpecifier( 1383826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1384826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1385826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1386826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1387826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 1388826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1389826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1390826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1391826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 1392826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1393826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 1394826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalAmount &Amt, 1395826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned type, 1396826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1397826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1398826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1399826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1400826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 1401826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &ignoredFlag, 1402826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1403826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1404826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 1405826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1406826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1407826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 1408826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1409826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1410826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 14116ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 1412c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 1413826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1414c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1415c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 1416c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 1417c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 141826ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek} 141926ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek 1420826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount( 1421826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_format_string::OptionalAmount &Amt, 1422826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned k, const char *startSpecifier, 1423826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 14240d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 14250d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (Amt.hasDataArgument()) { 14260d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (!HasVAListArg) { 14277f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = Amt.getArgIndex(); 14287f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (argIndex >= NumDataArgs) { 1429efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1430efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek diag::warn_printf_asterisk_missing_arg) 1431826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << k << getSpecifierRange(startSpecifier, specifierLen); 14320d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 14330d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 14340d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 14350d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 14364e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 14370d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Type check the data argument. It should be an 'int'. 143831f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // Although not in conformance with C99, we also allow the argument to be 143931f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // an 'unsigned int' as that is a reasonably safe case. GCC also 144031f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // doesn't emit a warning for that case. 14417f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.set(argIndex); 14427f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek const Expr *Arg = getDataArg(argIndex); 14430d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek QualType T = Arg->getType(); 14444e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 14454e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context); 14464e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek assert(ATR.isValid()); 14474e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 14484e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (!ATR.matchesType(S.Context, T)) { 1449efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1450efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek diag::warn_printf_asterisk_wrong_type) 1451efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek << k 14524e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek << ATR.getRepresentativeType(S.Context) << T 1453826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1454d635c5fcc45c952b75743dd2f4c86d6950e4954eTed Kremenek << Arg->getSourceRange(); 14550d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 14560d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 14570d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 14580d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 14590d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 14600d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 14610d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return true; 14620d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek} 14630d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1464e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount( 1465826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1466e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalAmount &Amt, 1467e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned type, 1468e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1469e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 14706ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 14716ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1472e4ee9663168dfb2b4122c768091e30217328c9faTom Care switch (Amt.getHowSpecified()) { 1473e4ee9663168dfb2b4122c768091e30217328c9faTom Care case analyze_printf::OptionalAmount::Constant: 1474e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(Amt.getStart()), 1475e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_optional_amount) 1476e4ee9663168dfb2b4122c768091e30217328c9faTom Care << type 1477e4ee9663168dfb2b4122c768091e30217328c9faTom Care << CS.toString() 1478826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1479826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 1480e4ee9663168dfb2b4122c768091e30217328c9faTom Care Amt.getConstantLength())); 1481e4ee9663168dfb2b4122c768091e30217328c9faTom Care break; 1482e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1483e4ee9663168dfb2b4122c768091e30217328c9faTom Care default: 1484e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(Amt.getStart()), 1485e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_optional_amount) 1486e4ee9663168dfb2b4122c768091e30217328c9faTom Care << type 1487e4ee9663168dfb2b4122c768091e30217328c9faTom Care << CS.toString() 1488826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1489e4ee9663168dfb2b4122c768091e30217328c9faTom Care break; 1490e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1491e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1492e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1493826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1494e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 1495e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1496e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 1497e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about pointless flag with a fixit removal. 14986ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 14996ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1500e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(flag.getPosition()), 1501e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_flag) 1502e4ee9663168dfb2b4122c768091e30217328c9faTom Care << flag.toString() << CS.toString() 1503826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1504826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(flag.getPosition(), 1)); 1505e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1506e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1507e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag( 1508826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1509e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &ignoredFlag, 1510e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 1511e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1512e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 1513e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about ignored flag with a fixit removal. 1514e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(ignoredFlag.getPosition()), 1515e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_ignored_flag) 1516e4ee9663168dfb2b4122c768091e30217328c9faTom Care << ignoredFlag.toString() << flag.toString() 1517826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1518826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange( 1519e4ee9663168dfb2b4122c768091e30217328c9faTom Care ignoredFlag.getPosition(), 1)); 1520e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1521e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1522e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool 1523826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 15245c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek &FS, 1525e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *startSpecifier, 1526e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned specifierLen) { 1527e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 15286ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek using namespace analyze_format_string; 1529efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek using namespace analyze_printf; 15306ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 1531e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1532baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 1533baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 1534baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 1535baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 1536baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1537baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 1538baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Cannot mix-and-match positional and non-positional arguments. 1539baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1540baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek diag::warn_format_mix_positional_nonpositional_args) 1541baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1542baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 1543baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1544efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek } 1545efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 15460d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // First check if the field width, precision, and conversion specifier 15470d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // have matching data arguments. 1548efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 1549efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 15500d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 15510d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 15524e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1553efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 1554efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 15550d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 15560d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 15570d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1558f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek if (!CS.consumesDataArgument()) { 1559f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // FIXME: Technically specifying a precision or field width here 1560f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // makes no sense. Worth issuing a warning at some point. 15610e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek return true; 1562f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek } 15634e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 15647f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Consume the argument. 15657f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = FS.getArgIndex(); 1566e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek if (argIndex < NumDataArgs) { 1567e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // The check to see if the argIndex is valid will come later. 1568e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // We set the bit here because we may exit early from this 1569e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // function if we encounter some other error. 1570e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek CoveredArgs.set(argIndex); 1571e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek } 15727f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek 15737f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Check for using an Objective-C specific conversion specifier 15747f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // in a non-ObjC literal. 15757f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (!IsObjCLiteral && CS.isObjCArg()) { 1576826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 1577826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek specifierLen); 15787f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 15794e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1580e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of field width 1581e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidFieldWidth()) { 158245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 1583e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1584e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1585e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1586e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of precision 1587e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPrecision()) { 1588e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 1589e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1590e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1591e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1592e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check each flag does not conflict with any other component. 159365197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek if (!FS.hasValidThousandsGroupingPrefix()) 159465197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen); 1595e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeadingZeros()) 1596e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 1597e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPlusPrefix()) 1598e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 159945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (!FS.hasValidSpacePrefix()) 160045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 1601e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidAlternativeForm()) 1602e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 1603e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeftJustified()) 1604e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 1605e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1606e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check that flags are not ignored by another flag 160745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 160845f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 160945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care startSpecifier, specifierLen); 1610e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 1611e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 1612e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1613e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1614e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check the length modifier is valid with the given conversion specifier. 1615e4ee9663168dfb2b4122c768091e30217328c9faTom Care const LengthModifier &LM = FS.getLengthModifier(); 1616e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLengthModifier()) 1617e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(LM.getStart()), 1618649aecf55670682efb2a04a85810eef4d038c527Ted Kremenek diag::warn_format_nonsensical_length) 1619e4ee9663168dfb2b4122c768091e30217328c9faTom Care << LM.toString() << CS.toString() 1620826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1621826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 1622e4ee9663168dfb2b4122c768091e30217328c9faTom Care LM.getLength())); 1623e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1624e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Are we using '%n'? 162535d353b47bce29200b910371dd9b8ba7f3058ab8Ted Kremenek if (CS.getKind() == ConversionSpecifier::nArg) { 1626e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Issue a warning about this being a possible security issue. 1627e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back) 1628826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1629e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek // Continue checking the other format specifiers. 1630e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek return true; 1631e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek } 16325c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek 1633da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek // The remaining checks depend on the data arguments. 1634da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek if (HasVAListArg) 1635da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return true; 16364e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1637666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 1638da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return false; 16394e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 164096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Now type check the data expression that matches the 164196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // format specifier. 164296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const Expr *Ex = getDataArg(argIndex); 164396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context); 164496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) { 164596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Check if we didn't match because of an implicit cast from a 'char' 164696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // or 'short' to an 'int'. This is done because printf is a varargs 164796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // function. 164896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex)) 16494d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ICE->getType() == S.Context.IntTy) { 16504d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek // All further checking is done on the subexpression. 16514d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek Ex = ICE->getSubExpr(); 16524d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ATR.matchesType(S.Context, Ex->getType())) 165396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer return true; 16544d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek } 165596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 165696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // We may be able to offer a FixItHint if it is a supported type. 165796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer PrintfSpecifier fixedFS = FS; 165896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer bool success = fixedFS.fixType(Ex->getType()); 165996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 166096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (success) { 166196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Get the fix string from the fixed format specifier 166296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::SmallString<128> buf; 166396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::raw_svector_ostream os(buf); 166496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer fixedFS.toString(os); 166596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 16669325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // FIXME: getRepresentativeType() perhaps should return a string 16679325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // instead of a QualType to better handle when the representative 16689325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // type is 'wint_t' (which is defined in the system headers). 166996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer S.Diag(getLocationOfByte(CS.getStart()), 167096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer diag::warn_printf_conversion_argument_type_mismatch) 167196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << ATR.getRepresentativeType(S.Context) << Ex->getType() 167296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << getSpecifierRange(startSpecifier, specifierLen) 167396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << Ex->getSourceRange() 167496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << FixItHint::CreateReplacement( 167596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer getSpecifierRange(startSpecifier, specifierLen), 167696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer os.str()); 167796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 167896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer else { 167996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer S.Diag(getLocationOfByte(CS.getStart()), 168096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer diag::warn_printf_conversion_argument_type_mismatch) 168196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << ATR.getRepresentativeType(S.Context) << Ex->getType() 168296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << getSpecifierRange(startSpecifier, specifierLen) 168396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << Ex->getSourceRange(); 168496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 168596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 168696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 1687e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return true; 1688e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1689e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1690826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===// 1691826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1692826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 1693826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler { 1694826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 1695826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 1696826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1697826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 1698826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 1699826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1700826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1701826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 1702826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek theCall, formatIdx) {} 1703826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1704826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 1705826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1706826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1707c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1708c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidScanfConversionSpecifier( 1709c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1710c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 1711c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen); 1712b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 1713b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek void HandleIncompleteScanList(const char *start, const char *end); 1714826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 1715826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1716826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1717b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start, 1718b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek const char *end) { 1719b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek S.Diag(getLocationOfByte(end), diag::warn_scanf_scanlist_incomplete) 1720b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek << getSpecifierRange(start, end - start); 1721b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek} 1722b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 1723c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 1724c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1725c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 1726c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen) { 1727c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 17286ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_scanf::ScanfConversionSpecifier &CS = 1729c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 1730c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1731c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1732c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 1733c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 1734c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 1735c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1736c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1737826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier( 1738826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1739826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1740826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 1741826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1742826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_scanf; 1743826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_format_string; 1744826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 17456ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 1746826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1747baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Handle case where '%' and '*' don't consume an argument. These shouldn't 1748baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // be used to decide if we are using positional arguments consistently. 1749baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 1750baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 1751baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 1752baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 1753baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1754baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 1755baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Cannot mix-and-match positional and non-positional arguments. 1756baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1757baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek diag::warn_format_mix_positional_nonpositional_args) 1758baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1759baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 1760baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1761826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1762826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1763826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Check if the field with is non-zero. 1764826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const OptionalAmount &Amt = FS.getFieldWidth(); 1765826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getHowSpecified() == OptionalAmount::Constant) { 1766826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getConstantAmount() == 0) { 1767826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 1768826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Amt.getConstantLength()); 1769826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1770826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_scanf_nonzero_width) 1771826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << R << FixItHint::CreateRemoval(R); 17727f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 17737f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 1774826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1775826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!FS.consumesDataArgument()) { 1776826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Technically specifying a precision or field width here 1777826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // makes no sense. Worth issuing a warning at some point. 1778826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 1779826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1780826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1781826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Consume the argument. 1782826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned argIndex = FS.getArgIndex(); 1783826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (argIndex < NumDataArgs) { 1784826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The check to see if the argIndex is valid will come later. 1785826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // We set the bit here because we may exit early from this 1786826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // function if we encounter some other error. 1787826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.set(argIndex); 1788826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1789826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 17901e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek // Check the length modifier is valid with the given conversion specifier. 17911e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek const LengthModifier &LM = FS.getLengthModifier(); 17921e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek if (!FS.hasValidLengthModifier()) { 17931e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek S.Diag(getLocationOfByte(LM.getStart()), 17941e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek diag::warn_format_nonsensical_length) 17951e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << LM.toString() << CS.toString() 17961e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 17971e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 17981e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek LM.getLength())); 17991e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek } 18001e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek 1801826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The remaining checks depend on the data arguments. 1802826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (HasVAListArg) 1803826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 1804826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1805666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 1806826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return false; 1807826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1808826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Check that the argument type matches the format specifier. 1809826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1810826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 181107d161f38e708a91486bf1c031d525faebbb249dTed Kremenek} 1812e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1813826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr, 18140e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const Expr *OrigFormatExpr, 18150e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const CallExpr *TheCall, bool HasVAListArg, 1816826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1817826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 1818826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1819e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: is the format string a wide literal? 18205cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!FExpr->isAscii()) { 1821e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Diag(FExpr->getLocStart(), 1822826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_string_is_wide_literal) 1823e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek << OrigFormatExpr->getSourceRange(); 1824e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 1825e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 1826826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1827e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // Str - The format string. NOTE: this is NOT null-terminated! 18285f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef StrRef = FExpr->getString(); 18292f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer const char *Str = StrRef.data(); 18302f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer unsigned StrLen = StrRef.size(); 1831826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1832e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: empty format string? 1833e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek if (StrLen == 0) { 1834826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Diag(FExpr->getLocStart(), diag::warn_empty_format_string) 1835e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek << OrigFormatExpr->getSourceRange(); 1836e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 1837e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 1838826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1839826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (isPrintf) { 1840826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 1841826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek TheCall->getNumArgs() - firstDataArg, 1842826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isa<ObjCStringLiteral>(OrigFormatExpr), Str, 1843826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, TheCall, format_idx); 1844826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1845826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen)) 1846826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 1847826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1848826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek else { 1849826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 1850826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek TheCall->getNumArgs() - firstDataArg, 1851826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isa<ObjCStringLiteral>(OrigFormatExpr), Str, 1852826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, TheCall, format_idx); 1853826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1854826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen)) 1855826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 1856826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1857ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek} 1858ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek 18597ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth//===--- CHECK: Standard memory functions ---------------------------------===// 18607ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 18612a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// \brief Determine whether the given type is a dynamic class type (e.g., 18622a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// whether it has a vtable). 18632a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregorstatic bool isDynamicClassType(QualType T) { 18642a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Record = T->getAsCXXRecordDecl()) 18652a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Definition = Record->getDefinition()) 18662a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (Definition->isDynamicClass()) 18672a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return true; 18682a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 18692a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return false; 18702a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor} 18712a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 1872a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument expression, 1873000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth/// otherwise returns NULL. 1874000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic const Expr *getSizeOfExprArg(const Expr* E) { 1875e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber if (const UnaryExprOrTypeTraitExpr *SizeOf = 1876000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 1877000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType()) 1878000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getArgumentExpr()->IgnoreParenImpCasts(); 1879e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 1880000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return 0; 1881000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth} 1882000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 1883a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument type. 1884000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic QualType getSizeOfArgType(const Expr* E) { 1885000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryExprOrTypeTraitExpr *SizeOf = 1886000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 1887000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf) 1888000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getTypeOfArgument(); 1889000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 1890000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return QualType(); 1891e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber} 1892e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 18937ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \brief Check for dangerous or invalid arguments to memset(). 18947ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 1895929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth/// This issues warnings on known problematic, dangerous or unspecified 1896cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp' 1897cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// function calls. 18987ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 18997ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \param Call The call expression to diagnose. 1900cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gayvoid Sema::CheckMemaccessArguments(const CallExpr *Call, 1901cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay CheckedMemoryFunction CMF, 1902cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay IdentifierInfo *FnName) { 19031d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek // It is possible to have a non-standard definition of memset. Validate 1904707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor // we have enough arguments, and if not, abort further checking. 1905707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor if (Call->getNumArgs() < 3) 19061d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek return; 19071d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek 1908707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor unsigned LastArg = (CMF == CMF_Memset? 1 : 2); 1909e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber const Expr *LenExpr = Call->getArg(2)->IgnoreParenImpCasts(); 1910000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 1911000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We have special checking when the length is a sizeof expression. 1912000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth QualType SizeOfArgTy = getSizeOfArgType(LenExpr); 1913000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth const Expr *SizeOfArg = getSizeOfExprArg(LenExpr); 1914000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID SizeOfArgID; 1915000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 191606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) { 191706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts(); 1918e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange(); 191906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 192006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType DestTy = Dest->getType(); 192106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) { 192206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType PointeeTy = DestPtrTy->getPointeeType(); 1923f85e193739c953358c865005855253af4f68a497John McCall 1924000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Never warn about void type pointers. This can be used to suppress 1925000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // false positives. 1926000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isVoidType()) 192706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 192806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 1929000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by 1930000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // actually comparing the expressions for equality. Because computing the 1931000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // expression IDs can be expensive, we only do this if the diagnostic is 1932000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // enabled. 1933000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArg && 1934000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess, 1935000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->getExprLoc())) { 1936000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We only compute IDs for expressions if the warning is enabled, and 1937000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // cache the sizeof arg's ID. 1938000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgID == llvm::FoldingSetNodeID()) 1939000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->Profile(SizeOfArgID, Context, true); 1940000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID DestID; 1941000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Dest->Profile(DestID, Context, true); 1942000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (DestID == SizeOfArgID) { 1943000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth unsigned ActionIdx = 0; // Default is to suggest dereferencing. 1944000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest)) 1945000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (UnaryOp->getOpcode() == UO_AddrOf) 1946000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 1; // If its an address-of operator, just remove it. 1947000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (Context.getTypeSize(PointeeTy) == Context.getCharWidth()) 1948000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 2; // If the pointee's size is sizeof(char), 1949000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // suggest an explicit length. 1950000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(SizeOfArg->getExprLoc(), Dest, 1951000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_expr_memaccess) 1952000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << FnName << ArgIdx << ActionIdx 1953000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << Dest->getSourceRange() 1954000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << SizeOfArg->getSourceRange()); 1955000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 1956000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 1957000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 1958000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 1959000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Also check for cases where the sizeof argument is the exact same 1960000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // type as the memory argument, and where it points to a user-defined 1961000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // record type. 1962000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgTy != QualType()) { 1963000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isRecordType() && 1964000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Context.typesAreCompatible(SizeOfArgTy, DestTy)) { 1965000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest, 1966000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_type_memaccess) 1967000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << FnName << SizeOfArgTy << ArgIdx 1968000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << PointeeTy << Dest->getSourceRange() 1969000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << LenExpr->getSourceRange()); 1970000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 1971000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 1972e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber } 1973e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 1974f85e193739c953358c865005855253af4f68a497John McCall unsigned DiagID; 1975f85e193739c953358c865005855253af4f68a497John McCall 197606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor // Always complain about dynamic classes. 1977f85e193739c953358c865005855253af4f68a497John McCall if (isDynamicClassType(PointeeTy)) 1978f85e193739c953358c865005855253af4f68a497John McCall DiagID = diag::warn_dyn_class_memaccess; 1979707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor else if (PointeeTy.hasNonTrivialObjCLifetime() && CMF != CMF_Memset) 1980f85e193739c953358c865005855253af4f68a497John McCall DiagID = diag::warn_arc_object_memaccess; 1981f85e193739c953358c865005855253af4f68a497John McCall else 198206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 1983f85e193739c953358c865005855253af4f68a497John McCall 1984f85e193739c953358c865005855253af4f68a497John McCall DiagRuntimeBehavior( 1985f85e193739c953358c865005855253af4f68a497John McCall Dest->getExprLoc(), Dest, 1986f85e193739c953358c865005855253af4f68a497John McCall PDiag(DiagID) 1987f85e193739c953358c865005855253af4f68a497John McCall << ArgIdx << FnName << PointeeTy 1988f85e193739c953358c865005855253af4f68a497John McCall << Call->getCallee()->getSourceRange()); 198906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 199006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor DiagRuntimeBehavior( 199106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor Dest->getExprLoc(), Dest, 1992929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth PDiag(diag::note_bad_memaccess_silence) 199306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)")); 199406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor break; 199506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 19967ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth } 19977ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth} 19987ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 1999bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// A little helper routine: ignore addition and subtraction of integer literals. 2000bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// This intentionally does not ignore all integer constant expressions because 2001bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// we don't want to remove sizeof(). 2002bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekstatic const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) { 2003bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = Ex->IgnoreParenCasts(); 2004bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2005bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek for (;;) { 2006bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex); 2007bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!BO || !BO->isAdditiveOp()) 2008bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 2009bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2010bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *RHS = BO->getRHS()->IgnoreParenCasts(); 2011bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *LHS = BO->getLHS()->IgnoreParenCasts(); 2012bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2013bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (isa<IntegerLiteral>(RHS)) 2014bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = LHS; 2015bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else if (isa<IntegerLiteral>(LHS)) 2016bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = RHS; 2017bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else 2018bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 2019bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2020bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2021bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return Ex; 2022bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 2023bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2024bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// Warn if the user has made the 'size' argument to strlcpy or strlcat 2025bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// be the size of the source, instead of the destination. 2026bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekvoid Sema::CheckStrlcpycatArguments(const CallExpr *Call, 2027bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek IdentifierInfo *FnName) { 2028bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2029bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Don't crash if the user has the wrong number of arguments 2030bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (Call->getNumArgs() != 3) 2031bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2032bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2033bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context); 2034bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context); 2035bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *CompareWithSrc = NULL; 2036bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2037bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, sizeof(x))' 2038bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const Expr *Ex = getSizeOfExprArg(SizeArg)) 2039bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = Ex; 2040bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else { 2041bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, strlen(x))' 2042bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) { 2043bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (SizeCall->isBuiltinCall(Context) == Builtin::BIstrlen 2044bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek && SizeCall->getNumArgs() == 1) 2045bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context); 2046bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2047bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2048bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2049bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrc) 2050bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2051bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2052bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Determine if the argument to sizeof/strlen is equal to the source 2053bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // argument. In principle there's all kinds of things you could do 2054bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // here, for instance creating an == expression and evaluating it with 2055bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // EvaluateAsBooleanCondition, but this uses a more direct technique: 2056bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg); 2057bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!SrcArgDRE) 2058bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2059bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2060bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc); 2061bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrcDRE || 2062bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl()) 2063bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2064bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2065bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *OriginalSizeArg = Call->getArg(2); 2066bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size) 2067bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek << OriginalSizeArg->getSourceRange() << FnName; 2068bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2069bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Output a FIXIT hint if the destination is an array (rather than a 2070bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointer to an array). This could be enhanced to handle some 2071bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointers if we know the actual size, like if DstArg is 'array+2' 2072bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // we could say 'sizeof(array)-2'. 2073bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts(); 20748f7462237ff542a4556775f98709ed300aa1731aTed Kremenek QualType DstArgTy = DstArg->getType(); 2075bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 20768f7462237ff542a4556775f98709ed300aa1731aTed Kremenek // Only handle constant-sized or VLAs, but not flexible members. 20778f7462237ff542a4556775f98709ed300aa1731aTed Kremenek if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(DstArgTy)) { 20788f7462237ff542a4556775f98709ed300aa1731aTed Kremenek // Only issue the FIXIT for arrays of size > 1. 20798f7462237ff542a4556775f98709ed300aa1731aTed Kremenek if (CAT->getSize().getSExtValue() <= 1) 20808f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 20818f7462237ff542a4556775f98709ed300aa1731aTed Kremenek } else if (!DstArgTy->isVariableArrayType()) { 20828f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 2083bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 20848f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 20858f7462237ff542a4556775f98709ed300aa1731aTed Kremenek llvm::SmallString<128> sizeString; 20868f7462237ff542a4556775f98709ed300aa1731aTed Kremenek llvm::raw_svector_ostream OS(sizeString); 20878f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << "sizeof("; 20888f7462237ff542a4556775f98709ed300aa1731aTed Kremenek DstArg->printPretty(OS, Context, 0, Context.PrintingPolicy); 20898f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << ")"; 20908f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 20918f7462237ff542a4556775f98709ed300aa1731aTed Kremenek Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size) 20928f7462237ff542a4556775f98709ed300aa1731aTed Kremenek << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(), 20938f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS.str()); 2094bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 2095bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 209606de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===// 209706de276fff91264437fa75111ed76de43097e089Ted Kremenek 20985f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars); 20995f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars); 210006de276fff91264437fa75111ed76de43097e089Ted Kremenek 210106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address 210206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable. 210306de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid 210406de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 210506de276fff91264437fa75111ed76de43097e089Ted Kremenek SourceLocation ReturnLoc) { 21061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 210726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Expr *stackE = 0; 21085f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<DeclRefExpr *, 8> refVars; 21094e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 211026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Perform checking for returned stack addresses, local blocks, 211126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // label addresses or references to temporaries. 2112f85e193739c953358c865005855253af4f68a497John McCall if (lhsType->isPointerType() || 2113f85e193739c953358c865005855253af4f68a497John McCall (!getLangOptions().ObjCAutoRefCount && lhsType->isBlockPointerType())) { 211426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalAddr(RetValExp, refVars); 2115ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (lhsType->isReferenceType()) { 211626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalVal(RetValExp, refVars); 211726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 211826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 211926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (stackE == 0) 212026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return; // Nothing suspicious was found. 212126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 212226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceLocation diagLoc; 212326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange diagRange; 212426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (refVars.empty()) { 212526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = stackE->getLocStart(); 212626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = stackE->getSourceRange(); 212726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { 212826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // We followed through a reference variable. 'stackE' contains the 212926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // problematic expression but we will warn at the return statement pointing 213026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // at the reference variable. We will later display the "trail" of 213126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // reference variables using notes. 213226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = refVars[0]->getLocStart(); 213326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = refVars[0]->getSourceRange(); 213426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 213526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 213626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var. 213726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref 213826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_stack_addr) 213926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << DR->getDecl()->getDeclName() << diagRange; 214026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<BlockExpr>(stackE)) { // local block. 214126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::err_ret_local_block) << diagRange; 214226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 214326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 214426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { // local temporary. 214526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref 214626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_local_temp_addr) 214726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << diagRange; 214826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 214926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 215026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Display the "trail" of reference variables that we followed until we 215126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // found the problematic expression using notes. 215226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 215326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 215426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this var binds to another reference var, show the range of the next 215526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // var, otherwise the var binds to the problematic expression, in which case 215626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // show the range of the expression. 215726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange() 215826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : stackE->getSourceRange(); 215926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(VD->getLocation(), diag::note_ref_var_local_bind) 216026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << VD->getDeclName() << range; 216106de276fff91264437fa75111ed76de43097e089Ted Kremenek } 216206de276fff91264437fa75111ed76de43097e089Ted Kremenek} 216306de276fff91264437fa75111ed76de43097e089Ted Kremenek 216406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 216506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// check if the expression in a return statement evaluates to an address 216626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// to a location on the stack, a local block, an address of a label, or a 216726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// reference to local temporary. The recursion is used to traverse the 216806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// AST of the return expression, with recursion backtracking when we 216926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// encounter a subexpression that (1) clearly does not lead to one of the 217026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// above problematic expressions (2) is something we cannot determine leads to 217126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// a problematic expression based on such local checking. 217226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 217326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// Both EvalAddr and EvalVal follow through reference variables to evaluate 217426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// the expression that they point to. Such variables are added to the 217526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 'refVars' vector so that we know what the reference variable "trail" was. 217606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 2177e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// EvalAddr processes expressions that are pointers that are used as 2178e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// references (and not L-values). EvalVal handles all other values. 217926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// At the base case of the recursion is a check for the above problematic 218026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// expressions. 218106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 218206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// This implementation handles: 218306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 218406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer-to-pointer casts 218506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * implicit conversions from array references to pointers 218606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of fields 218706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * arbitrary interplay between "&" and "*" operators 218806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer arithmetic from an address of a stack variable 218906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of an array element where the array is on the stack 21905f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars) { 219126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (E->isTypeDependent()) 219226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 219326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 219406de276fff91264437fa75111ed76de43097e089Ted Kremenek // We should only be called for evaluating pointer expressions. 21950f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall assert((E->getType()->isAnyPointerType() || 2196dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff E->getType()->isBlockPointerType() || 2197a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek E->getType()->isObjCQualifiedIdType()) && 2198fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner "EvalAddr only works on pointers"); 21991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2200f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 2201f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 220206de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 220306de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 220406de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 220506de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 220626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::DeclRefExprClass: { 220726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis DeclRefExpr *DR = cast<DeclRefExpr>(E); 220826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 220926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 221026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this is a reference variable, follow through to the expression that 221126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 221226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage() && 221326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis V->getType()->isReferenceType() && V->hasInit()) { 221426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 221526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 221626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(V->getInit(), refVars); 221726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 221826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 221926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 222026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 222106de276fff91264437fa75111ed76de43097e089Ted Kremenek 2222fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::UnaryOperatorClass: { 2223fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // The only unary operator that make sense to handle here 2224fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // is AddrOf. All others don't make sense as pointers. 2225fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner UnaryOperator *U = cast<UnaryOperator>(E); 22261eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 22272de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_AddrOf) 222826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(U->getSubExpr(), refVars); 2229fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 2230fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 2231fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 22321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2233fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::BinaryOperatorClass: { 2234fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle pointer arithmetic. All other binary operators are not valid 2235fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // in this context. 2236fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner BinaryOperator *B = cast<BinaryOperator>(E); 22372de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = B->getOpcode(); 22381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 22392de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op != BO_Add && op != BO_Sub) 2240fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 22411eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2242fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner Expr *Base = B->getLHS(); 22433907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 2244fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Determine which argument is the real pointer base. It could be 2245fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // the RHS argument instead of the LHS. 2246fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner if (!Base->getType()->isPointerType()) Base = B->getRHS(); 22471eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2248fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner assert (Base->getType()->isPointerType()); 224926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(Base, refVars); 2250fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 225161f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff 2252fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // For conditional operators we need to see if either the LHS or RHS are 2253fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // valid DeclRefExpr*s. If one of them is valid, we return it. 2254fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ConditionalOperatorClass: { 2255fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner ConditionalOperator *C = cast<ConditionalOperator>(E); 22561eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2257fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle the GNU extension for missing LHS. 22589ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (Expr *lhsExpr = C->getLHS()) { 22599ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 22609ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (!lhsExpr->getType()->isVoidType()) 226126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr* LHS = EvalAddr(lhsExpr, refVars)) 22629ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return LHS; 22639ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor } 22649ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor 22659ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 22669ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (C->getRHS()->getType()->isVoidType()) 22679ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return NULL; 226806de276fff91264437fa75111ed76de43097e089Ted Kremenek 226926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(C->getRHS(), refVars); 2270fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 227126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 227226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::BlockExprClass: 2273469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures()) 227426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // local block. 227526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 227626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 227726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::AddrLabelExprClass: 227826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // address of label. 22791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 228054b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // For casts, we need to handle conversions from arrays to 228154b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // pointer values, and pointer-to-pointer conversions. 228249badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::ImplicitCastExprClass: 22836eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor case Stmt::CStyleCastExprClass: 2284f85e193739c953358c865005855253af4f68a497John McCall case Stmt::CXXFunctionalCastExprClass: 2285f85e193739c953358c865005855253af4f68a497John McCall case Stmt::ObjCBridgedCastExprClass: { 22860835a3cdeefe714b4959d31127ea155e56393125Argyrios Kyrtzidis Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 228754b5274f2c190331438375ad114dad12ae098b57Ted Kremenek QualType T = SubExpr->getType(); 22881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2289dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (SubExpr->getType()->isPointerType() || 2290dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isBlockPointerType() || 2291dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isObjCQualifiedIdType()) 229226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(SubExpr, refVars); 229354b5274f2c190331438375ad114dad12ae098b57Ted Kremenek else if (T->isArrayType()) 229426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(SubExpr, refVars); 2295fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 229654b5274f2c190331438375ad114dad12ae098b57Ted Kremenek return 0; 2297fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 22981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2299fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // C++ casts. For dynamic casts, static casts, and const casts, we 2300fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // are always converting from a pointer-to-pointer, so we just blow 230149badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // through the cast. In the case the dynamic cast doesn't fail (and 230249badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // return NULL), we take the conservative route and report cases 2303fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // where we return the address of a stack variable. For Reinterpre 230449badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // FIXME: The comment about is wrong; we're not always converting 230549badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // from pointer to pointer. I'm guessing that this code should also 23061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // handle references to objects. 23071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXStaticCastExprClass: 23081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXDynamicCastExprClass: 230949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXConstCastExprClass: 231049badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXReinterpretCastExprClass: { 231149badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr(); 2312dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (S->getType()->isPointerType() || S->getType()->isBlockPointerType()) 231326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(S, refVars); 231406de276fff91264437fa75111ed76de43097e089Ted Kremenek else 231506de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 2316fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 23171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 231803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 231903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalAddr( 232003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 232103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor refVars)) 232203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 232303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 232403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 232503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 2326fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Everything else: we simply don't reason about them. 2327fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner default: 2328fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 232906de276fff91264437fa75111ed76de43097e089Ted Kremenek } 233006de276fff91264437fa75111ed76de43097e089Ted Kremenek} 23311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 233206de276fff91264437fa75111ed76de43097e089Ted Kremenek 233306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalVal - This function is complements EvalAddr in the mutual recursion. 233406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// See the comments for EvalAddr for more details. 23355f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars) { 233668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo { 2337e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // We should only be called for evaluating non-pointer expressions, or 2338e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // expressions with a pointer type that are not used as references but instead 2339e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // are l-values (e.g., DeclRefExpr with a pointer type). 23401eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 234106de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 234206de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 234306de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 2344f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 2345f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 234606de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 234768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ImplicitCastExprClass: { 234868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 23495baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall if (IE->getValueKind() == VK_LValue) { 235068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = IE->getSubExpr(); 235168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 235268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 235368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek return NULL; 235468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 235568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek 2356a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor case Stmt::DeclRefExprClass: { 235726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // When we hit a DeclRefExpr we are looking at code that refers to a 235826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // variable's name. If it's not a reference variable we check if it has 235926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // local storage within the function, and if so, return the expression. 236006de276fff91264437fa75111ed76de43097e089Ted Kremenek DeclRefExpr *DR = cast<DeclRefExpr>(E); 23611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 236206de276fff91264437fa75111ed76de43097e089Ted Kremenek if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 236326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage()) { 236426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!V->getType()->isReferenceType()) 236526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return DR; 236626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 236726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Reference variable, follow through to the expression that 236826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 236926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasInit()) { 237026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 237126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 237226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(V->getInit(), refVars); 237326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 237426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 23751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 237606de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 237706de276fff91264437fa75111ed76de43097e089Ted Kremenek } 23781eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 237906de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::UnaryOperatorClass: { 238006de276fff91264437fa75111ed76de43097e089Ted Kremenek // The only unary operator that make sense to handle here 238106de276fff91264437fa75111ed76de43097e089Ted Kremenek // is Deref. All others don't resolve to a "name." This includes 238206de276fff91264437fa75111ed76de43097e089Ted Kremenek // handling all sorts of rvalues passed to a unary operator. 238306de276fff91264437fa75111ed76de43097e089Ted Kremenek UnaryOperator *U = cast<UnaryOperator>(E); 23841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 23852de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_Deref) 238626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(U->getSubExpr(), refVars); 238706de276fff91264437fa75111ed76de43097e089Ted Kremenek 238806de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 238906de276fff91264437fa75111ed76de43097e089Ted Kremenek } 23901eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 239106de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ArraySubscriptExprClass: { 239206de276fff91264437fa75111ed76de43097e089Ted Kremenek // Array subscripts are potential references to data on the stack. We 239306de276fff91264437fa75111ed76de43097e089Ted Kremenek // retrieve the DeclRefExpr* for the array variable if it indeed 239406de276fff91264437fa75111ed76de43097e089Ted Kremenek // has local storage. 239526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars); 239606de276fff91264437fa75111ed76de43097e089Ted Kremenek } 23971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 239806de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ConditionalOperatorClass: { 239906de276fff91264437fa75111ed76de43097e089Ted Kremenek // For conditional operators we need to see if either the LHS or RHS are 240026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // non-NULL Expr's. If one is non-NULL, we return it. 240106de276fff91264437fa75111ed76de43097e089Ted Kremenek ConditionalOperator *C = cast<ConditionalOperator>(E); 240206de276fff91264437fa75111ed76de43097e089Ted Kremenek 24033907323dd6665c0c4e383435cb145233f4533406Anders Carlsson // Handle the GNU extension for missing LHS. 24043907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (Expr *lhsExpr = C->getLHS()) 240526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr *LHS = EvalVal(lhsExpr, refVars)) 24063907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return LHS; 24073907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 240826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(C->getRHS(), refVars); 240906de276fff91264437fa75111ed76de43097e089Ted Kremenek } 24101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 241106de276fff91264437fa75111ed76de43097e089Ted Kremenek // Accesses to members are potential references to data on the stack. 241283f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor case Stmt::MemberExprClass: { 241306de276fff91264437fa75111ed76de43097e089Ted Kremenek MemberExpr *M = cast<MemberExpr>(E); 24141eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 241506de276fff91264437fa75111ed76de43097e089Ted Kremenek // Check for indirect access. We only want direct field accesses. 2416a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->isArrow()) 2417a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return NULL; 2418a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 2419a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // Check whether the member type is itself a reference, in which case 2420a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // we're not going to refer to the member, but to what the member refers to. 2421a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->getMemberDecl()->getType()->isReferenceType()) 242206de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 2423a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 242426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(M->getBase(), refVars); 242506de276fff91264437fa75111ed76de43097e089Ted Kremenek } 24261eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 242703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 242803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalVal( 242903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 243003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor refVars)) 243103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 243203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 243303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 243403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 243506de276fff91264437fa75111ed76de43097e089Ted Kremenek default: 243626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Check that we don't return or take the address of a reference to a 243726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // temporary. This is only useful in C++. 243826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!E->isTypeDependent() && E->isRValue()) 243926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; 244026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 244126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Everything else: we simply don't reason about them. 244206de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 244306de276fff91264437fa75111ed76de43097e089Ted Kremenek } 244468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true); 244506de276fff91264437fa75111ed76de43097e089Ted Kremenek} 2446588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2447588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 2448588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2449588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==. 2450588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely 2451588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended. 2452588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenekvoid Sema::CheckFloatComparison(SourceLocation loc, Expr* lex, Expr *rex) { 2453588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek bool EmitWarning = true; 24541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2455f6a1648197562e0b133440d612d9af297d0a86ccJohn McCall Expr* LeftExprSansParen = lex->IgnoreParenImpCasts(); 2456f6a1648197562e0b133440d612d9af297d0a86ccJohn McCall Expr* RightExprSansParen = rex->IgnoreParenImpCasts(); 2457588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2458588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Special case: check for x == x (which is OK). 2459588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Do not emit warnings for such cases. 2460588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 2461588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 2462588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DRL->getDecl() == DRR->getDecl()) 2463588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 24641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 24651eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 24661b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // Special case: check for comparisons against literals that can be exactly 24671b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // represented by APFloat. In such cases, do not emit a warning. This 24681b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // is a heuristic: often comparison against such literals are used to 24691b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // detect if a value in a variable has not changed. This clearly can 24701b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // lead to false negatives. 24711b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (EmitWarning) { 24721b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 24731b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLL->isExact()) 24741b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 2475ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else 24761b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){ 24771b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLR->isExact()) 24781b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 24791b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 24801b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 24811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2482588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Check for comparisons with builtin types. 24830eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 2484588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 24853c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor if (CL->isBuiltinCall(Context)) 2486588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 24871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 24880eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 2489588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 24903c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor if (CR->isBuiltinCall(Context)) 2491588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 24921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2493588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Emit the diagnostic. 2494588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (EmitWarning) 2495fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(loc, diag::warn_floatingpoint_eq) 2496fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << lex->getSourceRange() << rex->getSourceRange(); 2497588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek} 2498ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2499f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 2500f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 2501ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2502f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace { 2503ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2504f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued 2505f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression. 2506f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange { 2507f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// The number of bits active in the int. 2508f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned Width; 2509ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2510f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// True if the int is known not to have negative values. 2511f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool NonNegative; 251251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2513f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange(unsigned Width, bool NonNegative) 2514f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : Width(Width), NonNegative(NonNegative) 2515f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall {} 251651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 25171844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of the bool type. 2518f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall static IntRange forBoolType() { 2519f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(1, true); 2520f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 252151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 25221844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of the given integral type. 25231844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfType(ASTContext &C, QualType T) { 25241844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return forValueOfCanonicalType(C, 25251844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T->getCanonicalTypeInternal().getTypePtr()); 252651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 252751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 25281844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of a canonical integral type. 25291844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 2530f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(T->isCanonicalUnqualified()); 253151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2532f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 2533f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = VT->getElementType().getTypePtr(); 2534f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 2535f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = CT->getElementType().getTypePtr(); 2536323ed74658bc8375278eabf074b4777458376540John McCall 2537091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // For enum types, use the known bit width of the enumerators. 2538323ed74658bc8375278eabf074b4777458376540John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) { 2539323ed74658bc8375278eabf074b4777458376540John McCall EnumDecl *Enum = ET->getDecl(); 2540091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Enum->isDefinition()) 2541091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return IntRange(C.getIntWidth(QualType(T, 0)), false); 2542091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2543323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumPositive = Enum->getNumPositiveBits(); 2544323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumNegative = Enum->getNumNegativeBits(); 2545323ed74658bc8375278eabf074b4777458376540John McCall 2546323ed74658bc8375278eabf074b4777458376540John McCall return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0); 2547323ed74658bc8375278eabf074b4777458376540John McCall } 254851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2549f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const BuiltinType *BT = cast<BuiltinType>(T); 2550f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(BT->isInteger()); 255151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2552f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 255351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 255451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 25551844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the "target" range of a canonical integral type, i.e. 25561844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// the range of values expressible in the type. 25571844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// 25581844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// This matches forValueOfCanonicalType except that enums have the 25591844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// full range of their type, not the range of their enumerators. 25601844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 25611844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(T->isCanonicalUnqualified()); 25621844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 25631844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 25641844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = VT->getElementType().getTypePtr(); 25651844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 25661844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = CT->getElementType().getTypePtr(); 25671844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) 25681844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = ET->getDecl()->getIntegerType().getTypePtr(); 25691844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 25701844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall const BuiltinType *BT = cast<BuiltinType>(T); 25711844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(BT->isInteger()); 25721844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 25731844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 25741844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall } 25751844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 25761844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the supremum of two ranges: i.e. their conservative merge. 2577c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange join(IntRange L, IntRange R) { 2578f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(std::max(L.Width, R.Width), 257960fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative && R.NonNegative); 258060fad45739b764886f707bd204eae9ecce6db1f2John McCall } 258160fad45739b764886f707bd204eae9ecce6db1f2John McCall 25821844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the infinum of two ranges: i.e. their aggressive merge. 2583c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange meet(IntRange L, IntRange R) { 258460fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange(std::min(L.Width, R.Width), 258560fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative || R.NonNegative); 258651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 2587f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}; 258851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2589f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) { 2590f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isSigned() && value.isNegative()) 2591f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getMinSignedBits(), false); 259251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2593f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.getBitWidth() > MaxWidth) 25949f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad value = value.trunc(MaxWidth); 259551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2596f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // isNonNegative() just checks the sign bit without considering 2597f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // signedness. 2598f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getActiveBits(), true); 259951313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 260051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 26010acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCallIntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 2602f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned MaxWidth) { 2603f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isInt()) 2604f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetValueRange(C, result.getInt(), MaxWidth); 260551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2606f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isVector()) { 26070acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 26080acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 26090acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 26100acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall R = IntRange::join(R, El); 26110acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall } 2612f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return R; 261351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 261451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2615f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isComplexInt()) { 2616f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 2617f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 2618f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(R, I); 2619f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2620f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2621f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // This can happen with lossless casts to intptr_t of "based" lvalues. 2622f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume it might use arbitrary bits. 26230acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // FIXME: The only reason we need to pass the type in here is to get 26240acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // the sign right on this one case. It would be nice if APValue 26250acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // preserved this. 2626f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(result.isLValue()); 26275e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType()); 262851313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 262951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2630f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the 2631f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take. 2632f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 2633f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated 2634f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 263551313c39c84407dd6a323be99a8c322bf8d052a9John McCall E = E->IgnoreParens(); 263651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2637f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Try a full evaluation first. 2638f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall Expr::EvalResult result; 2639f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (E->Evaluate(result, C)) 26400acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall return GetValueRange(C, result.Val, E->getType(), MaxWidth); 264151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2642f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // I think we only want to look through implicit casts here; if the 2643f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // user has an explicit widening cast, we should treat the value as 2644f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // being of the new, wider type. 2645f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 26462de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (CE->getCastKind() == CK_NoOp) 2647f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CE->getSubExpr(), MaxWidth); 264851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 26491844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType()); 265051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 26512de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 265260fad45739b764886f707bd204eae9ecce6db1f2John McCall 2653f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume that non-integer casts can span the full range of the type. 265460fad45739b764886f707bd204eae9ecce6db1f2John McCall if (!isIntegerCast) 2655f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 265651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2657f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange SubRange 2658f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall = GetExprRange(C, CE->getSubExpr(), 2659f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall std::min(MaxWidth, OutputTypeRange.Width)); 266051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2661f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Bail out if the subexpr's range is as wide as the cast type. 2662f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SubRange.Width >= OutputTypeRange.Width) 2663f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 266451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2665f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, we take the smaller width, and we're non-negative if 2666f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // either the output type or the subexpr is. 2667f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(SubRange.Width, 2668f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall SubRange.NonNegative || OutputTypeRange.NonNegative); 2669f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2670f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2671f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 2672f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // If we can fold the condition, just take that operand. 2673f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool CondResult; 2674f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 2675f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CondResult ? CO->getTrueExpr() 2676f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : CO->getFalseExpr(), 2677f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall MaxWidth); 2678f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2679f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, conservatively merge. 2680f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 2681f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 2682f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 268351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 268451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 268551313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 268651313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (BO->getOpcode()) { 268751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2688f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Boolean-valued operations are single-bit and positive. 26892de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LAnd: 26902de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LOr: 26912de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LT: 26922de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GT: 26932de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LE: 26942de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GE: 26952de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_EQ: 26962de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_NE: 2697f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 269851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2699862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // The type of the assignments is the type of the LHS, so the RHS 2700862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // is not necessarily the same type. 27012de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_MulAssign: 27022de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_DivAssign: 27032de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_RemAssign: 27042de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AddAssign: 27052de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_SubAssign: 2706862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_XorAssign: 2707862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_OrAssign: 2708862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 27091844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 2710c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall 2711862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // Simple assignments just pass through the RHS, which will have 2712862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // been coerced to the LHS type. 2713862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_Assign: 2714862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 2715862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 2716862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall 271751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 27182de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemD: 27192de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemI: 27201844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 272151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 272260fad45739b764886f707bd204eae9ecce6db1f2John McCall // Bitwise-and uses the *infinum* of the two source ranges. 27232de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_And: 27242de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AndAssign: 272560fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 272660fad45739b764886f707bd204eae9ecce6db1f2John McCall GetExprRange(C, BO->getRHS(), MaxWidth)); 272760fad45739b764886f707bd204eae9ecce6db1f2John McCall 272851313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Left shift gets black-listed based on a judgement call. 27292de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shl: 27303aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // ...except that we want to treat '1 << (blah)' as logically 27313aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // positive. It's an important idiom. 27323aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (IntegerLiteral *I 27333aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 27343aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (I->getValue() == 1) { 27351844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange R = IntRange::forValueOfType(C, E->getType()); 27363aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall return IntRange(R.Width, /*NonNegative*/ true); 27373aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 27383aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 27393aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // fallthrough 27403aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall 27412de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShlAssign: 27421844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 274351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 274460fad45739b764886f707bd204eae9ecce6db1f2John McCall // Right shift by a constant can narrow its left argument. 27452de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shr: 27462de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShrAssign: { 274760fad45739b764886f707bd204eae9ecce6db1f2John McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 274860fad45739b764886f707bd204eae9ecce6db1f2John McCall 274960fad45739b764886f707bd204eae9ecce6db1f2John McCall // If the shift amount is a positive constant, drop the width by 275060fad45739b764886f707bd204eae9ecce6db1f2John McCall // that much. 275160fad45739b764886f707bd204eae9ecce6db1f2John McCall llvm::APSInt shift; 275260fad45739b764886f707bd204eae9ecce6db1f2John McCall if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 275360fad45739b764886f707bd204eae9ecce6db1f2John McCall shift.isNonNegative()) { 275460fad45739b764886f707bd204eae9ecce6db1f2John McCall unsigned zext = shift.getZExtValue(); 275560fad45739b764886f707bd204eae9ecce6db1f2John McCall if (zext >= L.Width) 275660fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width = (L.NonNegative ? 0 : 1); 275760fad45739b764886f707bd204eae9ecce6db1f2John McCall else 275860fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width -= zext; 275960fad45739b764886f707bd204eae9ecce6db1f2John McCall } 276060fad45739b764886f707bd204eae9ecce6db1f2John McCall 276160fad45739b764886f707bd204eae9ecce6db1f2John McCall return L; 276260fad45739b764886f707bd204eae9ecce6db1f2John McCall } 276360fad45739b764886f707bd204eae9ecce6db1f2John McCall 276460fad45739b764886f707bd204eae9ecce6db1f2John McCall // Comma acts as its right operand. 27652de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Comma: 2766f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 2767f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 276860fad45739b764886f707bd204eae9ecce6db1f2John McCall // Black-list pointer subtractions. 27692de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Sub: 277051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BO->getLHS()->getType()->isPointerType()) 27711844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 277200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall break; 277300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 277400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The width of a division result is mostly determined by the size 277500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // of the LHS. 277600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Div: { 277700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 277800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 277900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 278000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 278100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // If the divisor is constant, use that. 278200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall llvm::APSInt divisor; 278300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) { 278400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned log2 = divisor.logBase2(); // floor(log_2(divisor)) 278500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (log2 >= L.Width) 278600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = (L.NonNegative ? 0 : 1); 278700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall else 278800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = std::min(L.Width - log2, MaxWidth); 278900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return L; 279000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 279100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 279200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Otherwise, just use the LHS's width. 279300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 279400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return IntRange(L.Width, L.NonNegative && R.NonNegative); 279500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 279600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 279700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The result of a remainder can't be larger than the result of 279800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // either side. 279900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Rem: { 280000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 280100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 280200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 280300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 280400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 280500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange meet = IntRange::meet(L, R); 280600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall meet.Width = std::min(meet.Width, MaxWidth); 280700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return meet; 280800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 28094e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 281000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default behavior is okay for these. 281100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Mul: 281200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Add: 281300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Xor: 281400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Or: 2815f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall break; 281651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 2817f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 281800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default case is to treat the operation as if it were closed 281900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // on the narrowest type that encompasses both operands. 2820f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 2821f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 2822f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 282351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 282451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 282551313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 282651313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (UO->getOpcode()) { 282751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Boolean-valued operations are white-listed. 28282de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_LNot: 2829f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 283051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 283151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 28322de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_Deref: 28332de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_AddrOf: // should be impossible 28341844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 283551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 283651313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 2837f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, UO->getSubExpr(), MaxWidth); 283851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 283951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 28408ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor 28418ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor if (dyn_cast<OffsetOfExpr>(E)) { 28421844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange::forValueOfType(C, E->getType()); 28438ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor } 284451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2845f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall FieldDecl *BitField = E->getBitField(); 2846f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (BitField) { 2847f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APSInt BitWidthAP = BitField->getBitWidth()->EvaluateAsInt(C); 2848f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned BitWidth = BitWidthAP.getZExtValue(); 284951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 28505e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor return IntRange(BitWidth, 28515e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor BitField->getType()->isUnsignedIntegerOrEnumerationType()); 2852f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2853f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 28541844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 2855f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 2856f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2857323ed74658bc8375278eabf074b4777458376540John McCallIntRange GetExprRange(ASTContext &C, Expr *E) { 2858323ed74658bc8375278eabf074b4777458376540John McCall return GetExprRange(C, E, C.getIntWidth(E->getType())); 2859323ed74658bc8375278eabf074b4777458376540John McCall} 2860323ed74658bc8375278eabf074b4777458376540John McCall 2861f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 2862f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 2863f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 2864f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const llvm::APFloat &value, 2865f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 2866f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 2867f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APFloat truncated = value; 2868f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2869f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool ignored; 2870f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 2871f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 2872f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2873f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return truncated.bitwiseIsEqual(value); 287451313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 287551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2876f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 2877f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 2878f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 2879f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 2880f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number). 2881f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const APValue &value, 2882f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 2883f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 2884f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isFloat()) 2885f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 2886f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2887f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isVector()) { 2888f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 2889f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 2890f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return false; 2891f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return true; 2892f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2893f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2894f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(value.isComplexFloat()); 2895f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 2896f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 2897f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 2898f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2899b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 2900323ed74658bc8375278eabf074b4777458376540John McCall 2901e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) { 2902e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where we are comparing against an enum constant. 2903e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (const DeclRefExpr *DR = 2904e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 2905e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (isa<EnumConstantDecl>(DR->getDecl())) 2906e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 2907e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 2908e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where the '0' value is expanded from a macro. 2909e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (E->getLocStart().isMacroID()) 2910e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 2911e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 2912323ed74658bc8375278eabf074b4777458376540John McCall llvm::APSInt Value; 2913323ed74658bc8375278eabf074b4777458376540John McCall return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 2914323ed74658bc8375278eabf074b4777458376540John McCall} 2915323ed74658bc8375278eabf074b4777458376540John McCall 2916372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) { 2917372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall // Strip off implicit integral promotions. 2918372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 291963b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis if (ICE->getCastKind() != CK_IntegralCast && 292063b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis ICE->getCastKind() != CK_NoOp) 2921372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall break; 292263b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis E = ICE->getSubExpr(); 2923372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall } 2924372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 2925372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall return E->getType()->isEnumeralType(); 2926372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall} 2927372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 2928323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 29292de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = E->getOpcode(); 293014af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor if (E->isValueDependent()) 293114af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor return; 293214af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor 29332de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op == BO_LT && IsZero(S, E->getRHS())) { 2934323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 2935372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "< 0" << "false" << HasEnumType(E->getLHS()) 2936323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 29372de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GE && IsZero(S, E->getRHS())) { 2938323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 2939372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << ">= 0" << "true" << HasEnumType(E->getLHS()) 2940323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 29412de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GT && IsZero(S, E->getLHS())) { 2942323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 2943372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 >" << "false" << HasEnumType(E->getRHS()) 2944323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 29452de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_LE && IsZero(S, E->getLHS())) { 2946323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 2947372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 <=" << "true" << HasEnumType(E->getRHS()) 2948323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 2949323ed74658bc8375278eabf074b4777458376540John McCall } 2950323ed74658bc8375278eabf074b4777458376540John McCall} 2951323ed74658bc8375278eabf074b4777458376540John McCall 2952323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison. Implements the 2953323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison. 2954323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 2955b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 2956b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 2957323ed74658bc8375278eabf074b4777458376540John McCall} 2958f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2959ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare. 2960ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// 2961ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \param lex the left-hand expression 2962ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \param rex the right-hand expression 2963ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \param OpLoc the location of the joining operator 2964d1b47bf17fde73fac67d8664bd65273742c00ecdJohn McCall/// \param BinOpc binary opcode or 0 2965323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeComparison(Sema &S, BinaryOperator *E) { 2966323ed74658bc8375278eabf074b4777458376540John McCall // The type the comparison is being performed in. 2967323ed74658bc8375278eabf074b4777458376540John McCall QualType T = E->getLHS()->getType(); 2968323ed74658bc8375278eabf074b4777458376540John McCall assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 2969323ed74658bc8375278eabf074b4777458376540John McCall && "comparison with mismatched types"); 2970323ed74658bc8375278eabf074b4777458376540John McCall 2971323ed74658bc8375278eabf074b4777458376540John McCall // We don't do anything special if this isn't an unsigned integral 2972323ed74658bc8375278eabf074b4777458376540John McCall // comparison: we're only interested in integral comparisons, and 2973323ed74658bc8375278eabf074b4777458376540John McCall // signed comparisons only happen in cases we don't care to warn about. 29743e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // 29753e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // We also don't care about value-dependent expressions or expressions 29763e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // whose result is a constant. 29773e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor if (!T->hasUnsignedIntegerRepresentation() 29783e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor || E->isValueDependent() || E->isIntegerConstantExpr(S.Context)) 2979323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 2980323ed74658bc8375278eabf074b4777458376540John McCall 2981323ed74658bc8375278eabf074b4777458376540John McCall Expr *lex = E->getLHS()->IgnoreParenImpCasts(); 2982323ed74658bc8375278eabf074b4777458376540John McCall Expr *rex = E->getRHS()->IgnoreParenImpCasts(); 2983323ed74658bc8375278eabf074b4777458376540John McCall 2984323ed74658bc8375278eabf074b4777458376540John McCall // Check to see if one of the (unmodified) operands is of different 2985323ed74658bc8375278eabf074b4777458376540John McCall // signedness. 2986323ed74658bc8375278eabf074b4777458376540John McCall Expr *signedOperand, *unsignedOperand; 2987f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (lex->getType()->hasSignedIntegerRepresentation()) { 2988f60946222721d9ba3c059563935c17b84703187aDouglas Gregor assert(!rex->getType()->hasSignedIntegerRepresentation() && 2989323ed74658bc8375278eabf074b4777458376540John McCall "unsigned comparison between two signed integer expressions?"); 2990323ed74658bc8375278eabf074b4777458376540John McCall signedOperand = lex; 2991323ed74658bc8375278eabf074b4777458376540John McCall unsignedOperand = rex; 2992f60946222721d9ba3c059563935c17b84703187aDouglas Gregor } else if (rex->getType()->hasSignedIntegerRepresentation()) { 2993323ed74658bc8375278eabf074b4777458376540John McCall signedOperand = rex; 2994323ed74658bc8375278eabf074b4777458376540John McCall unsignedOperand = lex; 2995ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } else { 2996323ed74658bc8375278eabf074b4777458376540John McCall CheckTrivialUnsignedComparison(S, E); 2997323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 2998ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } 2999ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3000323ed74658bc8375278eabf074b4777458376540John McCall // Otherwise, calculate the effective range of the signed operand. 3001323ed74658bc8375278eabf074b4777458376540John McCall IntRange signedRange = GetExprRange(S.Context, signedOperand); 3002f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3003323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and analyze implicit conversions in the operands. Note 3004323ed74658bc8375278eabf074b4777458376540John McCall // that we skip the implicit conversions on both sides. 3005b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, lex, E->getOperatorLoc()); 3006b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, rex, E->getOperatorLoc()); 3007ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3008323ed74658bc8375278eabf074b4777458376540John McCall // If the signed range is non-negative, -Wsign-compare won't fire, 3009323ed74658bc8375278eabf074b4777458376540John McCall // but we should still check for comparisons which are always true 3010323ed74658bc8375278eabf074b4777458376540John McCall // or false. 3011323ed74658bc8375278eabf074b4777458376540John McCall if (signedRange.NonNegative) 3012323ed74658bc8375278eabf074b4777458376540John McCall return CheckTrivialUnsignedComparison(S, E); 3013ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3014ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // For (in)equality comparisons, if the unsigned operand is a 3015ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // constant which cannot collide with a overflowed signed operand, 3016ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // then reinterpreting the signed operand as unsigned will not 3017ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // change the result of the comparison. 3018323ed74658bc8375278eabf074b4777458376540John McCall if (E->isEqualityOp()) { 3019323ed74658bc8375278eabf074b4777458376540John McCall unsigned comparisonWidth = S.Context.getIntWidth(T); 3020323ed74658bc8375278eabf074b4777458376540John McCall IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 3021323ed74658bc8375278eabf074b4777458376540John McCall 3022323ed74658bc8375278eabf074b4777458376540John McCall // We should never be unable to prove that the unsigned operand is 3023323ed74658bc8375278eabf074b4777458376540John McCall // non-negative. 3024323ed74658bc8375278eabf074b4777458376540John McCall assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 3025ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3026323ed74658bc8375278eabf074b4777458376540John McCall if (unsignedRange.Width < comparisonWidth) 3027323ed74658bc8375278eabf074b4777458376540John McCall return; 3028323ed74658bc8375278eabf074b4777458376540John McCall } 3029323ed74658bc8375278eabf074b4777458376540John McCall 3030323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison) 3031323ed74658bc8375278eabf074b4777458376540John McCall << lex->getType() << rex->getType() 3032323ed74658bc8375278eabf074b4777458376540John McCall << lex->getSourceRange() << rex->getSourceRange(); 3033ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall} 3034ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 303515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield. 303615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// 303715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt. 303815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallbool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 303915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall SourceLocation InitLoc) { 304015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall assert(Bitfield->isBitField()); 304115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Bitfield->isInvalidDecl()) 304215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 304315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 304491b6014876e9186f968f74a8975ab8fc08ef1b68John McCall // White-list bool bitfields. 304591b6014876e9186f968f74a8975ab8fc08ef1b68John McCall if (Bitfield->getType()->isBooleanType()) 304691b6014876e9186f968f74a8975ab8fc08ef1b68John McCall return false; 304791b6014876e9186f968f74a8975ab8fc08ef1b68John McCall 304846ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor // Ignore value- or type-dependent expressions. 304946ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor if (Bitfield->getBitWidth()->isValueDependent() || 305046ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Bitfield->getBitWidth()->isTypeDependent() || 305146ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isValueDependent() || 305246ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isTypeDependent()) 305346ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor return false; 305446ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor 305515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *OriginalInit = Init->IgnoreParenImpCasts(); 305615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 305715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall llvm::APSInt Width(32); 305815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr::EvalResult InitValue; 305915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (!Bitfield->getBitWidth()->isIntegerConstantExpr(Width, S.Context) || 306091b6014876e9186f968f74a8975ab8fc08ef1b68John McCall !OriginalInit->Evaluate(InitValue, S.Context) || 306115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall !InitValue.Val.isInt()) 306215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 306315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 306415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall const llvm::APSInt &Value = InitValue.Val.getInt(); 306515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned OriginalWidth = Value.getBitWidth(); 306615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned FieldWidth = Width.getZExtValue(); 306715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 306815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (OriginalWidth <= FieldWidth) 306915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 307015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 30719f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad llvm::APSInt TruncatedValue = Value.trunc(FieldWidth); 307215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 307315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // It's fairly common to write values into signed bitfields 307415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // that, if sign-extended, would end up becoming a different 307515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // value. We don't want to warn about that. 307615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value.isSigned() && Value.isNegative()) 30779f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad TruncatedValue = TruncatedValue.sext(OriginalWidth); 307815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall else 30799f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad TruncatedValue = TruncatedValue.zext(OriginalWidth); 308015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 308115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value == TruncatedValue) 308215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 308315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 308415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyValue = Value.toString(10); 308515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyTrunc = TruncatedValue.toString(10); 308615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 308715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 308815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << PrettyValue << PrettyTrunc << OriginalInit->getType() 308915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << Init->getSourceRange(); 309015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 309115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return true; 309215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 309315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 3094beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy 3095beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations. 3096beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCallvoid AnalyzeAssignment(Sema &S, BinaryOperator *E) { 3097beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Just recurse on the LHS. 3098beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 3099beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 3100beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // We want to recurse on the RHS as normal unless we're assigning to 3101beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // a bitfield. 3102beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (FieldDecl *Bitfield = E->getLHS()->getBitField()) { 310315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 310415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc())) { 310515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // Recurse, ignoring any implicit conversions on the RHS. 310615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 310715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc()); 3108beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 3109beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 3110beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 3111beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 3112beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall} 3113beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 311451313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 31155a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregorvoid DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T, 31165a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceLocation CContext, unsigned diag) { 31175a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor S.Diag(E->getExprLoc(), diag) 31185a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor << SourceType << T << E->getSourceRange() << SourceRange(CContext); 31195a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor} 31205a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 3121e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 3122e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruthvoid DiagnoseImpCast(Sema &S, Expr *E, QualType T, SourceLocation CContext, 3123e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth unsigned diag) { 3124e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth DiagnoseImpCast(S, E, E->getType(), T, CContext, diag); 3125e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth} 3126e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth 3127f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth/// Diagnose an implicit cast from a literal expression. Also attemps to supply 3128f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth/// fixit hints when the cast wouldn't lose information to simply write the 3129f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth/// expression with the expected type. 3130f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruthvoid DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T, 3131f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth SourceLocation CContext) { 3132f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth // Emit the primary warning first, then try to emit a fixit hint note if 3133f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth // reasonable. 3134f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer) 3135f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth << FL->getType() << T << FL->getSourceRange() << SourceRange(CContext); 3136f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 3137f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth const llvm::APFloat &Value = FL->getValue(); 3138f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 3139f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth // Don't attempt to fix PPC double double literals. 3140f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth if (&Value.getSemantics() == &llvm::APFloat::PPCDoubleDouble) 3141f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth return; 3142f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 31433e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin // Try to convert this exactly to an integer. 3144f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth bool isExact = false; 31453e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin llvm::APSInt IntegerValue(S.Context.getIntWidth(T), 31463e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin T->hasUnsignedIntegerRepresentation()); 31473e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin if (Value.convertToInteger(IntegerValue, 3148f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth llvm::APFloat::rmTowardZero, &isExact) 3149f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth != llvm::APFloat::opOK || !isExact) 3150f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth return; 3151f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 31523e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin std::string LiteralValue = IntegerValue.toString(10); 3153f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth S.Diag(FL->getExprLoc(), diag::note_fix_integral_float_as_integer) 3154f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth << FixItHint::CreateReplacement(FL->getSourceRange(), LiteralValue); 3155f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth} 3156f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 3157091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 3158091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Range.Width) return "0"; 3159091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3160091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt ValueInRange = Value; 3161091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.setIsSigned(!Range.NonNegative); 31629f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad ValueInRange = ValueInRange.trunc(Range.Width); 3163091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return ValueInRange.toString(10); 3164091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall} 3165091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3166ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenekstatic bool isFromSystemMacro(Sema &S, SourceLocation loc) { 3167ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceManager &smgr = S.Context.getSourceManager(); 3168ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return loc.isMacroID() && smgr.isInSystemHeader(smgr.getSpellingLoc(loc)); 3169ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek} 3170f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 3171323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T, 3172b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool *ICContext = 0) { 3173323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) return; 317451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3175323ed74658bc8375278eabf074b4777458376540John McCall const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 3176323ed74658bc8375278eabf074b4777458376540John McCall const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 3177323ed74658bc8375278eabf074b4777458376540John McCall if (Source == Target) return; 3178323ed74658bc8375278eabf074b4777458376540John McCall if (Target->isDependentType()) return; 317951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3180108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // If the conversion context location is invalid don't complain. We also 3181108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // don't want to emit a warning if the issue occurs from the expansion of 3182108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // a system macro. The problem is that 'getSpellingLoc()' is slow, so we 3183108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // delay this check as long as possible. Once we detect we are in that 3184108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // scenario, we just return. 3185ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (CC.isInvalid()) 3186b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return; 3187b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 318851313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Never diagnose implicit casts to bool. 318951313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (Target->isSpecificBuiltinType(BuiltinType::Bool)) 319051313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 319151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 319251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip vector types. 319351313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<VectorType>(Source)) { 3194ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<VectorType>(Target)) { 3195ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3196ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3197b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 3198ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 3199b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner 3200b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // If the vector cast is cast between two vectors of the same size, it is 3201b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // a bitcast, not a conversion. 3202b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target)) 3203b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner return; 320451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 320551313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 320651313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 320751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 320851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 320951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip complex types. 321051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<ComplexType>(Source)) { 3211ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<ComplexType>(Target)) { 3212ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3213ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3214ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3215b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 3216ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 321751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 321851313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 321951313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 322051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 322151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 322251313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 322351313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 322451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 322551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the source is floating point... 322651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT && SourceBT->isFloatingPoint()) { 322751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...and the target is floating point... 322851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (TargetBT && TargetBT->isFloatingPoint()) { 322951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...then warn if we're dropping FP rank. 323051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 323151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Builtin FP kinds are ordered by increasing FP rank. 323251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT->getKind() > TargetBT->getKind()) { 323351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Don't warn about float constants that are precisely 323451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // representable in the target type. 323551313c39c84407dd6a323be99a8c322bf8d052a9John McCall Expr::EvalResult result; 3236323ed74658bc8375278eabf074b4777458376540John McCall if (E->Evaluate(result, S.Context)) { 323751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Value might be a float, a float vector, or a float complex. 323851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (IsSameFloatAfterCast(result.Val, 3239323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 3240323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 324151313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 324251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 324351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3244ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3245ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3246ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3247b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 324851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 324951313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 325051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 325151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3252ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // If the target is integral, always warn. 3253a5b9332418f25338f118358e27303cd510d54107Chandler Carruth if ((TargetBT && TargetBT->isInteger())) { 3254ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3255ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3256ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3257a5b9332418f25338f118358e27303cd510d54107Chandler Carruth Expr *InnerE = E->IgnoreParenImpCasts(); 3258f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) { 3259f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth DiagnoseFloatingLiteralImpCast(S, FL, T, CC); 3260a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } else { 3261a5b9332418f25338f118358e27303cd510d54107Chandler Carruth DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 3262a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 3263a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 326451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 326551313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 326651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 326751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3268f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!Source->isIntegerType() || !Target->isIntegerType()) 326951313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 327051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 32711838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull) 32721838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu == Expr::NPCK_GNUNull) && Target->isIntegerType()) { 32731838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu S.Diag(E->getExprLoc(), diag::warn_impcast_null_pointer_to_integer) 32741838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu << E->getSourceRange() << clang::SourceRange(CC); 32751838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu return; 32761838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu } 32771838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu 3278323ed74658bc8375278eabf074b4777458376540John McCall IntRange SourceRange = GetExprRange(S.Context, E); 32791844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 328051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3281f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width > TargetRange.Width) { 3282091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // If the source is a constant, use a default-on diagnostic. 3283091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // TODO: this should happen for bitfield stores, too. 3284091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt Value(32); 3285091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (E->isIntegerConstantExpr(Value, S.Context)) { 3286ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3287ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3288ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3289091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettySourceValue = Value.toString(10); 3290091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 3291091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3292091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall S.Diag(E->getExprLoc(), diag::warn_impcast_integer_precision_constant) 3293091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall << PrettySourceValue << PrettyTargetValue 3294091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall << E->getType() << T << E->getSourceRange() << clang::SourceRange(CC); 3295091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return; 3296091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall } 3297091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3298b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // People want to build with -Wshorten-64-to-32 and not -Wconversion. 3299ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3300ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3301ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3302f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width == 64 && TargetRange.Width == 32) 3303b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32); 3304b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 3305323ed74658bc8375278eabf074b4777458376540John McCall } 3306323ed74658bc8375278eabf074b4777458376540John McCall 3307323ed74658bc8375278eabf074b4777458376540John McCall if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 3308323ed74658bc8375278eabf074b4777458376540John McCall (!TargetRange.NonNegative && SourceRange.NonNegative && 3309323ed74658bc8375278eabf074b4777458376540John McCall SourceRange.Width == TargetRange.Width)) { 3310ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3311ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3312ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3313ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3314323ed74658bc8375278eabf074b4777458376540John McCall unsigned DiagID = diag::warn_impcast_integer_sign; 3315323ed74658bc8375278eabf074b4777458376540John McCall 3316323ed74658bc8375278eabf074b4777458376540John McCall // Traditionally, gcc has warned about this under -Wsign-compare. 3317323ed74658bc8375278eabf074b4777458376540John McCall // We also want to warn about it in -Wconversion. 3318323ed74658bc8375278eabf074b4777458376540John McCall // So if -Wconversion is off, use a completely identical diagnostic 3319323ed74658bc8375278eabf074b4777458376540John McCall // in the sign-compare group. 3320323ed74658bc8375278eabf074b4777458376540John McCall // The conditional-checking code will 3321323ed74658bc8375278eabf074b4777458376540John McCall if (ICContext) { 3322323ed74658bc8375278eabf074b4777458376540John McCall DiagID = diag::warn_impcast_integer_sign_conditional; 3323323ed74658bc8375278eabf074b4777458376540John McCall *ICContext = true; 3324323ed74658bc8375278eabf074b4777458376540John McCall } 3325323ed74658bc8375278eabf074b4777458376540John McCall 3326b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, DiagID); 332751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 332851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3329284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor // Diagnose conversions between different enumeration types. 33305a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // In C, we pretend that the type of an EnumConstantDecl is its enumeration 33315a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // type, to give us better diagnostics. 33325a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor QualType SourceType = E->getType(); 33335a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (!S.getLangOptions().CPlusPlus) { 33345a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 33355a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) { 33365a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext()); 33375a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceType = S.Context.getTypeDeclType(Enum); 33385a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor Source = S.Context.getCanonicalType(SourceType).getTypePtr(); 33395a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 33405a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 33415a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 3342284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *SourceEnum = Source->getAs<EnumType>()) 3343284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *TargetEnum = Target->getAs<EnumType>()) 3344284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if ((SourceEnum->getDecl()->getIdentifier() || 3345162e1c1b487352434552147967c3dd296ebee2f7Richard Smith SourceEnum->getDecl()->getTypedefNameForAnonDecl()) && 3346284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor (TargetEnum->getDecl()->getIdentifier() || 3347162e1c1b487352434552147967c3dd296ebee2f7Richard Smith TargetEnum->getDecl()->getTypedefNameForAnonDecl()) && 3348ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceEnum != TargetEnum) { 3349ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3350ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3351ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 33525a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor return DiagnoseImpCast(S, E, SourceType, T, CC, 3353284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor diag::warn_impcast_different_enum_types); 3354ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 3355284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor 335651313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 335751313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 335851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3359323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T); 3360323ed74658bc8375278eabf074b4777458376540John McCall 3361323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T, 3362b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool &ICContext) { 3363323ed74658bc8375278eabf074b4777458376540John McCall E = E->IgnoreParenImpCasts(); 3364323ed74658bc8375278eabf074b4777458376540John McCall 3365323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) 3366323ed74658bc8375278eabf074b4777458376540John McCall return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T); 3367323ed74658bc8375278eabf074b4777458376540John McCall 3368b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E, CC); 3369323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 3370b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return CheckImplicitConversion(S, E, T, CC, &ICContext); 3371323ed74658bc8375278eabf074b4777458376540John McCall return; 3372323ed74658bc8375278eabf074b4777458376540John McCall} 3373323ed74658bc8375278eabf074b4777458376540John McCall 3374323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) { 3375b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC = E->getQuestionLoc(); 3376b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 3377b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getCond(), CC); 3378323ed74658bc8375278eabf074b4777458376540John McCall 3379323ed74658bc8375278eabf074b4777458376540John McCall bool Suspicious = false; 3380b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 3381b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 3382323ed74658bc8375278eabf074b4777458376540John McCall 3383323ed74658bc8375278eabf074b4777458376540John McCall // If -Wconversion would have warned about either of the candidates 3384323ed74658bc8375278eabf074b4777458376540John McCall // for a signedness conversion to the context type... 3385323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) return; 3386323ed74658bc8375278eabf074b4777458376540John McCall 3387323ed74658bc8375278eabf074b4777458376540John McCall // ...but it's currently ignored... 33880827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional, 33890827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis CC)) 3390323ed74658bc8375278eabf074b4777458376540John McCall return; 3391323ed74658bc8375278eabf074b4777458376540John McCall 3392323ed74658bc8375278eabf074b4777458376540John McCall // ...then check whether it would have warned about either of the 3393323ed74658bc8375278eabf074b4777458376540John McCall // candidates for a signedness conversion to the condition type. 33945254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (E->getType() == T) return; 33955254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu 33965254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu Suspicious = false; 33975254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 33985254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu E->getType(), CC, &Suspicious); 33995254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (!Suspicious) 34005254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 3401b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 3402323ed74658bc8375278eabf074b4777458376540John McCall} 3403323ed74658bc8375278eabf074b4777458376540John McCall 3404323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting 3405323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression. There are a couple 3406323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare. 3407b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 3408323ed74658bc8375278eabf074b4777458376540John McCall QualType T = OrigE->getType(); 3409323ed74658bc8375278eabf074b4777458376540John McCall Expr *E = OrigE->IgnoreParenImpCasts(); 3410323ed74658bc8375278eabf074b4777458376540John McCall 3411323ed74658bc8375278eabf074b4777458376540John McCall // For conditional operators, we analyze the arguments as if they 3412323ed74658bc8375278eabf074b4777458376540John McCall // were being fed directly into the output. 3413323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) { 3414323ed74658bc8375278eabf074b4777458376540John McCall ConditionalOperator *CO = cast<ConditionalOperator>(E); 3415323ed74658bc8375278eabf074b4777458376540John McCall CheckConditionalOperator(S, CO, T); 3416323ed74658bc8375278eabf074b4777458376540John McCall return; 3417323ed74658bc8375278eabf074b4777458376540John McCall } 3418323ed74658bc8375278eabf074b4777458376540John McCall 3419323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and check any implicit conversions we might have skipped. 3420323ed74658bc8375278eabf074b4777458376540John McCall // The non-canonical typecheck is just an optimization; 3421323ed74658bc8375278eabf074b4777458376540John McCall // CheckImplicitConversion will filter out dead implicit conversions. 3422323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 3423b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckImplicitConversion(S, E, T, CC); 3424323ed74658bc8375278eabf074b4777458376540John McCall 3425323ed74658bc8375278eabf074b4777458376540John McCall // Now continue drilling into this expression. 3426323ed74658bc8375278eabf074b4777458376540John McCall 3427323ed74658bc8375278eabf074b4777458376540John McCall // Skip past explicit casts. 3428323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ExplicitCastExpr>(E)) { 3429323ed74658bc8375278eabf074b4777458376540John McCall E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 3430b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return AnalyzeImplicitConversions(S, E, CC); 3431323ed74658bc8375278eabf074b4777458376540John McCall } 3432323ed74658bc8375278eabf074b4777458376540John McCall 3433beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 3434beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Do a somewhat different check with comparison operators. 3435beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isComparisonOp()) 3436beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeComparison(S, BO); 3437beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 3438beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // And with assignments and compound assignments. 3439beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isAssignmentOp()) 3440beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeAssignment(S, BO); 3441beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 3442323ed74658bc8375278eabf074b4777458376540John McCall 3443323ed74658bc8375278eabf074b4777458376540John McCall // These break the otherwise-useful invariant below. Fortunately, 3444323ed74658bc8375278eabf074b4777458376540John McCall // we don't really need to recurse into them, because any internal 3445323ed74658bc8375278eabf074b4777458376540John McCall // expressions should have been analyzed already when they were 3446323ed74658bc8375278eabf074b4777458376540John McCall // built into statements. 3447323ed74658bc8375278eabf074b4777458376540John McCall if (isa<StmtExpr>(E)) return; 3448323ed74658bc8375278eabf074b4777458376540John McCall 3449323ed74658bc8375278eabf074b4777458376540John McCall // Don't descend into unevaluated contexts. 3450f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne if (isa<UnaryExprOrTypeTraitExpr>(E)) return; 3451323ed74658bc8375278eabf074b4777458376540John McCall 3452323ed74658bc8375278eabf074b4777458376540John McCall // Now just recurse over the expression's children. 3453b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CC = E->getExprLoc(); 34547502c1d3ce8bb97bcc4f7bebef507040bd93b26fJohn McCall for (Stmt::child_range I = E->children(); I; ++I) 3455b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, cast<Expr>(*I), CC); 3456323ed74658bc8375278eabf074b4777458376540John McCall} 3457323ed74658bc8375278eabf074b4777458376540John McCall 3458323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace 3459323ed74658bc8375278eabf074b4777458376540John McCall 3460323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given 3461323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression). Implements -Wconversion 3462323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare. 3463b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// 3464b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e. 3465b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// the most location of the syntactic entity requiring the implicit 3466b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// conversion 3467b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 3468323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose in unevaluated contexts. 3469323ed74658bc8375278eabf074b4777458376540John McCall if (ExprEvalContexts.back().Context == Sema::Unevaluated) 3470323ed74658bc8375278eabf074b4777458376540John McCall return; 3471323ed74658bc8375278eabf074b4777458376540John McCall 3472323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose for value- or type-dependent expressions. 3473323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) 3474323ed74658bc8375278eabf074b4777458376540John McCall return; 3475323ed74658bc8375278eabf074b4777458376540John McCall 3476d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Check for array bounds violations in cases where the check isn't triggered 3477d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // elsewhere for other Expr types (like BinaryOperators), e.g. when an 3478d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // ArraySubscriptExpr is on the RHS of a variable initialization. 3479d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain CheckArrayAccess(E); 3480d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 3481b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // This is not the right CC for (e.g.) a variable initialization. 3482b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(*this, E, CC); 3483323ed74658bc8375278eabf074b4777458376540John McCall} 3484323ed74658bc8375278eabf074b4777458376540John McCall 348515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 348615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall FieldDecl *BitField, 348715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *Init) { 348815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 348915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 349015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 3491f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given 3492f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This 3493f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the 3494f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function 3495f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete. 349682aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregorbool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd, 349782aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor bool CheckParameterNames) { 3498f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump bool HasInvalidParm = false; 349982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor for (; P != PEnd; ++P) { 350082aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor ParmVarDecl *Param = *P; 350182aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor 3502f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.7.5.3p4: the parameters in a parameter type list in a 3503f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // function declarator that is part of a function definition of 3504f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // that function shall not have incomplete type. 3505f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // 3506f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // This is also C++ [dcl.fct]p6. 3507f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump if (!Param->isInvalidDecl() && 3508f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump RequireCompleteType(Param->getLocation(), Param->getType(), 3509f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump diag::err_typecheck_decl_incomplete_type)) { 3510f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Param->setInvalidDecl(); 3511f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump HasInvalidParm = true; 3512f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 3513f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 3514f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.9.1p5: If the declarator includes a parameter type list, the 3515f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // declaration of each parameter shall include an identifier. 351682aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor if (CheckParameterNames && 351782aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor Param->getIdentifier() == 0 && 3518f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !Param->isImplicit() && 3519f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !getLangOptions().CPlusPlus) 3520f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Diag(Param->getLocation(), diag::err_parameter_name_omitted); 3521d17e340e2d516139931768697bf080f60920ba9dSam Weinig 3522d17e340e2d516139931768697bf080f60920ba9dSam Weinig // C99 6.7.5.3p12: 3523d17e340e2d516139931768697bf080f60920ba9dSam Weinig // If the function declarator is not part of a definition of that 3524d17e340e2d516139931768697bf080f60920ba9dSam Weinig // function, parameters may have incomplete type and may use the [*] 3525d17e340e2d516139931768697bf080f60920ba9dSam Weinig // notation in their sequences of declarator specifiers to specify 3526d17e340e2d516139931768697bf080f60920ba9dSam Weinig // variable length array types. 3527d17e340e2d516139931768697bf080f60920ba9dSam Weinig QualType PType = Param->getOriginalType(); 3528d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (const ArrayType *AT = Context.getAsArrayType(PType)) { 3529d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (AT->getSizeModifier() == ArrayType::Star) { 3530d17e340e2d516139931768697bf080f60920ba9dSam Weinig // FIXME: This diagnosic should point the the '[*]' if source-location 3531d17e340e2d516139931768697bf080f60920ba9dSam Weinig // information is added for it. 3532d17e340e2d516139931768697bf080f60920ba9dSam Weinig Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 3533d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 3534d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 3535f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 3536f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 3537f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump return HasInvalidParm; 3538f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump} 3539b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3540b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a 3541b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements. 3542b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 3543b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // This is actually a lot of work to potentially be doing on every 3544b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // cast; don't do it if we're ignoring -Wcast_align (as is the default). 35450827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align, 35460827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis TRange.getBegin()) 3547b7f4ffe073fa419613946461a2583ba2fcb72280John McCall == Diagnostic::Ignored) 3548b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 3549b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3550b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Ignore dependent types. 3551b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (T->isDependentType() || Op->getType()->isDependentType()) 3552b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 3553b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3554b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the destination be a pointer type. 3555b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *DestPtr = T->getAs<PointerType>(); 3556b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!DestPtr) return; 3557b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3558b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // If the destination has alignment 1, we're done. 3559b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType DestPointee = DestPtr->getPointeeType(); 3560b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestPointee->isIncompleteType()) return; 3561b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 3562b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestAlign.isOne()) return; 3563b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3564b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the source be a pointer type. 3565b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 3566b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!SrcPtr) return; 3567b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType SrcPointee = SrcPtr->getPointeeType(); 3568b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3569b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Whitelist casts from cv void*. We already implicitly 3570b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // whitelisted casts to cv void*, since they have alignment 1. 3571b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Also whitelist casts involving incomplete types, which implicitly 3572b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // includes 'void'. 3573b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcPointee->isIncompleteType()) return; 3574b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3575b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 3576b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcAlign >= DestAlign) return; 3577b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3578b7f4ffe073fa419613946461a2583ba2fcb72280John McCall Diag(TRange.getBegin(), diag::warn_cast_align) 3579b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << Op->getType() << T 3580b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(SrcAlign.getQuantity()) 3581b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(DestAlign.getQuantity()) 3582b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << TRange << Op->getSourceRange(); 3583b7f4ffe073fa419613946461a2583ba2fcb72280John McCall} 3584b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3585d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainstatic const Type* getElementType(const Expr *BaseExpr) { 3586d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* EltType = BaseExpr->getType().getTypePtr(); 3587d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (EltType->isAnyPointerType()) 3588d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getPointeeType().getTypePtr(); 3589d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain else if (EltType->isArrayType()) 3590d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getBaseElementTypeUnsafe(); 3591d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType; 3592d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain} 3593d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 3594c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// \brief Check whether this array fits the idiom of a size-one tail padded 3595c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// array member of a struct. 3596c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// 3597c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// We avoid emitting out-of-bounds access warnings for such arrays as they are 3598c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// commonly used to emulate flexible arrays in C89 code. 3599c268434b332bbe57950d977633369bf5822d9554Chandler Carruthstatic bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size, 3600c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const NamedDecl *ND) { 3601c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (Size != 1 || !ND) return false; 3602c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 3603c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const FieldDecl *FD = dyn_cast<FieldDecl>(ND); 3604c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!FD) return false; 3605c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 3606c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // Don't consider sizes resulting from macro expansions or template argument 3607c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // substitution to form C89 tail-padded arrays. 3608c268434b332bbe57950d977633369bf5822d9554Chandler Carruth ConstantArrayTypeLoc TL = 3609c268434b332bbe57950d977633369bf5822d9554Chandler Carruth cast<ConstantArrayTypeLoc>(FD->getTypeSourceInfo()->getTypeLoc()); 3610c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const Expr *SizeExpr = dyn_cast<IntegerLiteral>(TL.getSizeExpr()); 3611c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!SizeExpr || SizeExpr->getExprLoc().isMacroID()) 3612c268434b332bbe57950d977633369bf5822d9554Chandler Carruth return false; 3613c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 3614c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext()); 3615c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!RD || !RD->isStruct()) 3616c268434b332bbe57950d977633369bf5822d9554Chandler Carruth return false; 3617c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 361822d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer // See if this is the last field decl in the record. 361922d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer const Decl *D = FD; 362022d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer while ((D = D->getNextDeclInContext())) 362122d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer if (isa<FieldDecl>(D)) 362222d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return false; 362322d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return true; 3624c268434b332bbe57950d977633369bf5822d9554Chandler Carruth} 3625c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 3626d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainvoid Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr, 3627d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain bool isSubscript, bool AllowOnePastEnd) { 3628d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* EffectiveType = getElementType(BaseExpr); 3629d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain BaseExpr = BaseExpr->IgnoreParenCasts(); 3630d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain IndexExpr = IndexExpr->IgnoreParenCasts(); 3631d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 36323406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const ConstantArrayType *ArrayTy = 3633d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain Context.getAsConstantArrayType(BaseExpr->getType()); 36343406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (!ArrayTy) 3635a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 363635001ca261f895817916b468379b696d6d45959dChandler Carruth 36373406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (IndexExpr->isValueDependent()) 3638a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 36393406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth llvm::APSInt index; 3640d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (!IndexExpr->isIntegerConstantExpr(index, Context)) 3641a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 36428fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek 3643ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth const NamedDecl *ND = NULL; 3644ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 3645ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(DRE->getDecl()); 3646c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 3647ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 3648ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 36499e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek if (index.isUnsigned() || !index.isNegative()) { 365025b3b849e3ad340b04442707038c86980035765bTed Kremenek llvm::APInt size = ArrayTy->getSize(); 365135001ca261f895817916b468379b696d6d45959dChandler Carruth if (!size.isStrictlyPositive()) 365235001ca261f895817916b468379b696d6d45959dChandler Carruth return; 3653d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 3654d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* BaseType = getElementType(BaseExpr); 3655d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (!isSubscript && BaseType != EffectiveType) { 3656d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Make sure we're comparing apples to apples when comparing index to size 3657d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType); 3658d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t array_typesize = Context.getTypeSize(BaseType); 3659d10f4bc5a05ce0cdc1646dbb0f706bb9d3dfc0c5Kaelyn Uhrain // Handle ptrarith_typesize being zero, such as when casting to void* 366018f169770d9d3f826bad8f1359c8c5770c5ab16fKaelyn Uhrain if (!ptrarith_typesize) ptrarith_typesize = 1; 3661d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize != array_typesize) { 3662d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // There's a cast to a different size type involved 3663d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ratio = array_typesize / ptrarith_typesize; 3664d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // TODO: Be smarter about handling cases where array_typesize is not a 3665d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // multiple of ptrarith_typesize 3666d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize * ratio == array_typesize) 3667d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain size *= llvm::APInt(size.getBitWidth(), ratio); 3668d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 3669d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 3670d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 36713406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (size.getBitWidth() > index.getBitWidth()) 36723406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth index = index.sext(size.getBitWidth()); 367325b3b849e3ad340b04442707038c86980035765bTed Kremenek else if (size.getBitWidth() < index.getBitWidth()) 367425b3b849e3ad340b04442707038c86980035765bTed Kremenek size = size.sext(index.getBitWidth()); 367525b3b849e3ad340b04442707038c86980035765bTed Kremenek 3676d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // For array subscripting the index must be less than size, but for pointer 3677d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // arithmetic also allow the index (offset) to be equal to size since 3678d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // computing the next address after the end of the array is legal and 3679d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // commonly done e.g. in C++ iterators and range-based for loops. 3680d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (AllowOnePastEnd ? index.sle(size) : index.slt(size)) 3681ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth return; 3682ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 3683ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // Also don't warn for arrays of size 1 which are members of some 3684ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // structure. These are often used to approximate flexible arrays in C89 3685ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // code. 3686d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (IsTailPaddedMemberArray(*this, size, ND)) 36878fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek return; 36883406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth 3689d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds; 3690d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (isSubscript) 3691d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_array_index_exceeds_bounds; 3692d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 3693d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 3694d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 3695d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << size.toString(10, true) 3696d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << (unsigned)size.getLimitedValue(~0U) 3697d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 36983406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth } else { 3699d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_array_index_precedes_bounds; 3700d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (!isSubscript) { 3701d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_ptr_arith_precedes_bounds; 3702d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (index.isNegative()) index = -index; 3703d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 3704d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 3705d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 3706d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 3707d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 3708a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek } 370935001ca261f895817916b468379b696d6d45959dChandler Carruth 371035001ca261f895817916b468379b696d6d45959dChandler Carruth if (ND) 3711d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(ND->getLocStart(), BaseExpr, 3712d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(diag::note_array_index_out_of_bounds) 3713d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << ND->getDeclName()); 37143aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek} 37153aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek 37163aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) { 3717d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain int AllowOnePastEnd = 0; 3718d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain while (expr) { 3719d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = expr->IgnoreParenImpCasts(); 37203aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek switch (expr->getStmtClass()) { 3721d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::ArraySubscriptExprClass: { 3722d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr); 3723d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain CheckArrayAccess(ASE->getBase(), ASE->getIdx(), true, 3724d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd > 0); 37253aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 3726d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 3727d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::UnaryOperatorClass: { 3728d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Only unwrap the * and & unary operators 3729d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const UnaryOperator *UO = cast<UnaryOperator>(expr); 3730d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = UO->getSubExpr(); 3731d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain switch (UO->getOpcode()) { 3732d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_AddrOf: 3733d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd++; 3734d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 3735d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_Deref: 3736d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd--; 3737d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 3738d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain default: 3739d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return; 3740d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 3741d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 3742d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 37433aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek case Stmt::ConditionalOperatorClass: { 37443aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek const ConditionalOperator *cond = cast<ConditionalOperator>(expr); 37453aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *lhs = cond->getLHS()) 37463aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(lhs); 37473aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *rhs = cond->getRHS()) 37483aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(rhs); 37493aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 37503aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 37513aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek default: 37523aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 37533aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 3754f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne } 3755a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek} 3756f85e193739c953358c865005855253af4f68a497John McCall 3757f85e193739c953358c865005855253af4f68a497John McCall//===--- CHECK: Objective-C retain cycles ----------------------------------// 3758f85e193739c953358c865005855253af4f68a497John McCall 3759f85e193739c953358c865005855253af4f68a497John McCallnamespace { 3760f85e193739c953358c865005855253af4f68a497John McCall struct RetainCycleOwner { 3761f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner() : Variable(0), Indirect(false) {} 3762f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 3763f85e193739c953358c865005855253af4f68a497John McCall SourceRange Range; 3764f85e193739c953358c865005855253af4f68a497John McCall SourceLocation Loc; 3765f85e193739c953358c865005855253af4f68a497John McCall bool Indirect; 3766f85e193739c953358c865005855253af4f68a497John McCall 3767f85e193739c953358c865005855253af4f68a497John McCall void setLocsFrom(Expr *e) { 3768f85e193739c953358c865005855253af4f68a497John McCall Loc = e->getExprLoc(); 3769f85e193739c953358c865005855253af4f68a497John McCall Range = e->getSourceRange(); 3770f85e193739c953358c865005855253af4f68a497John McCall } 3771f85e193739c953358c865005855253af4f68a497John McCall }; 3772f85e193739c953358c865005855253af4f68a497John McCall} 3773f85e193739c953358c865005855253af4f68a497John McCall 3774f85e193739c953358c865005855253af4f68a497John McCall/// Consider whether capturing the given variable can possibly lead to 3775f85e193739c953358c865005855253af4f68a497John McCall/// a retain cycle. 3776f85e193739c953358c865005855253af4f68a497John McCallstatic bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) { 3777f85e193739c953358c865005855253af4f68a497John McCall // In ARC, it's captured strongly iff the variable has __strong 3778f85e193739c953358c865005855253af4f68a497John McCall // lifetime. In MRR, it's captured strongly if the variable is 3779f85e193739c953358c865005855253af4f68a497John McCall // __block and has an appropriate type. 3780f85e193739c953358c865005855253af4f68a497John McCall if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 3781f85e193739c953358c865005855253af4f68a497John McCall return false; 3782f85e193739c953358c865005855253af4f68a497John McCall 3783f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = var; 3784f85e193739c953358c865005855253af4f68a497John McCall owner.setLocsFrom(ref); 3785f85e193739c953358c865005855253af4f68a497John McCall return true; 3786f85e193739c953358c865005855253af4f68a497John McCall} 3787f85e193739c953358c865005855253af4f68a497John McCall 3788f85e193739c953358c865005855253af4f68a497John McCallstatic bool findRetainCycleOwner(Expr *e, RetainCycleOwner &owner) { 3789f85e193739c953358c865005855253af4f68a497John McCall while (true) { 3790f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParens(); 3791f85e193739c953358c865005855253af4f68a497John McCall if (CastExpr *cast = dyn_cast<CastExpr>(e)) { 3792f85e193739c953358c865005855253af4f68a497John McCall switch (cast->getCastKind()) { 3793f85e193739c953358c865005855253af4f68a497John McCall case CK_BitCast: 3794f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueBitCast: 3795f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueToRValue: 37967e5e5f4cc36fe50f46ad76dca7a266434c94f475John McCall case CK_ObjCReclaimReturnedObject: 3797f85e193739c953358c865005855253af4f68a497John McCall e = cast->getSubExpr(); 3798f85e193739c953358c865005855253af4f68a497John McCall continue; 3799f85e193739c953358c865005855253af4f68a497John McCall 3800f85e193739c953358c865005855253af4f68a497John McCall case CK_GetObjCProperty: { 3801f85e193739c953358c865005855253af4f68a497John McCall // Bail out if this isn't a strong explicit property. 3802f85e193739c953358c865005855253af4f68a497John McCall const ObjCPropertyRefExpr *pre = cast->getSubExpr()->getObjCProperty(); 3803f85e193739c953358c865005855253af4f68a497John McCall if (pre->isImplicitProperty()) return false; 3804f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *property = pre->getExplicitProperty(); 3805f85e193739c953358c865005855253af4f68a497John McCall if (!(property->getPropertyAttributes() & 3806f85e193739c953358c865005855253af4f68a497John McCall (ObjCPropertyDecl::OBJC_PR_retain | 3807f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_copy | 3808f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl::OBJC_PR_strong)) && 3809f85e193739c953358c865005855253af4f68a497John McCall !(property->getPropertyIvarDecl() && 3810f85e193739c953358c865005855253af4f68a497John McCall property->getPropertyIvarDecl()->getType() 3811f85e193739c953358c865005855253af4f68a497John McCall .getObjCLifetime() == Qualifiers::OCL_Strong)) 3812f85e193739c953358c865005855253af4f68a497John McCall return false; 3813f85e193739c953358c865005855253af4f68a497John McCall 3814f85e193739c953358c865005855253af4f68a497John McCall owner.Indirect = true; 3815f85e193739c953358c865005855253af4f68a497John McCall e = const_cast<Expr*>(pre->getBase()); 3816f85e193739c953358c865005855253af4f68a497John McCall continue; 3817f85e193739c953358c865005855253af4f68a497John McCall } 3818f85e193739c953358c865005855253af4f68a497John McCall 3819f85e193739c953358c865005855253af4f68a497John McCall default: 3820f85e193739c953358c865005855253af4f68a497John McCall return false; 3821f85e193739c953358c865005855253af4f68a497John McCall } 3822f85e193739c953358c865005855253af4f68a497John McCall } 3823f85e193739c953358c865005855253af4f68a497John McCall 3824f85e193739c953358c865005855253af4f68a497John McCall if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) { 3825f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar = ref->getDecl(); 3826f85e193739c953358c865005855253af4f68a497John McCall if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 3827f85e193739c953358c865005855253af4f68a497John McCall return false; 3828f85e193739c953358c865005855253af4f68a497John McCall 3829f85e193739c953358c865005855253af4f68a497John McCall // Try to find a retain cycle in the base. 3830f85e193739c953358c865005855253af4f68a497John McCall if (!findRetainCycleOwner(ref->getBase(), owner)) 3831f85e193739c953358c865005855253af4f68a497John McCall return false; 3832f85e193739c953358c865005855253af4f68a497John McCall 3833f85e193739c953358c865005855253af4f68a497John McCall if (ref->isFreeIvar()) owner.setLocsFrom(ref); 3834f85e193739c953358c865005855253af4f68a497John McCall owner.Indirect = true; 3835f85e193739c953358c865005855253af4f68a497John McCall return true; 3836f85e193739c953358c865005855253af4f68a497John McCall } 3837f85e193739c953358c865005855253af4f68a497John McCall 3838f85e193739c953358c865005855253af4f68a497John McCall if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) { 3839f85e193739c953358c865005855253af4f68a497John McCall VarDecl *var = dyn_cast<VarDecl>(ref->getDecl()); 3840f85e193739c953358c865005855253af4f68a497John McCall if (!var) return false; 3841f85e193739c953358c865005855253af4f68a497John McCall return considerVariable(var, ref, owner); 3842f85e193739c953358c865005855253af4f68a497John McCall } 3843f85e193739c953358c865005855253af4f68a497John McCall 3844f85e193739c953358c865005855253af4f68a497John McCall if (BlockDeclRefExpr *ref = dyn_cast<BlockDeclRefExpr>(e)) { 3845f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = ref->getDecl(); 3846f85e193739c953358c865005855253af4f68a497John McCall owner.setLocsFrom(ref); 3847f85e193739c953358c865005855253af4f68a497John McCall return true; 3848f85e193739c953358c865005855253af4f68a497John McCall } 3849f85e193739c953358c865005855253af4f68a497John McCall 3850f85e193739c953358c865005855253af4f68a497John McCall if (MemberExpr *member = dyn_cast<MemberExpr>(e)) { 3851f85e193739c953358c865005855253af4f68a497John McCall if (member->isArrow()) return false; 3852f85e193739c953358c865005855253af4f68a497John McCall 3853f85e193739c953358c865005855253af4f68a497John McCall // Don't count this as an indirect ownership. 3854f85e193739c953358c865005855253af4f68a497John McCall e = member->getBase(); 3855f85e193739c953358c865005855253af4f68a497John McCall continue; 3856f85e193739c953358c865005855253af4f68a497John McCall } 3857f85e193739c953358c865005855253af4f68a497John McCall 3858f85e193739c953358c865005855253af4f68a497John McCall // Array ivars? 3859f85e193739c953358c865005855253af4f68a497John McCall 3860f85e193739c953358c865005855253af4f68a497John McCall return false; 3861f85e193739c953358c865005855253af4f68a497John McCall } 3862f85e193739c953358c865005855253af4f68a497John McCall} 3863f85e193739c953358c865005855253af4f68a497John McCall 3864f85e193739c953358c865005855253af4f68a497John McCallnamespace { 3865f85e193739c953358c865005855253af4f68a497John McCall struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> { 3866f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor(ASTContext &Context, VarDecl *variable) 3867f85e193739c953358c865005855253af4f68a497John McCall : EvaluatedExprVisitor<FindCaptureVisitor>(Context), 3868f85e193739c953358c865005855253af4f68a497John McCall Variable(variable), Capturer(0) {} 3869f85e193739c953358c865005855253af4f68a497John McCall 3870f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 3871f85e193739c953358c865005855253af4f68a497John McCall Expr *Capturer; 3872f85e193739c953358c865005855253af4f68a497John McCall 3873f85e193739c953358c865005855253af4f68a497John McCall void VisitDeclRefExpr(DeclRefExpr *ref) { 3874f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 3875f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 3876f85e193739c953358c865005855253af4f68a497John McCall } 3877f85e193739c953358c865005855253af4f68a497John McCall 3878f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockDeclRefExpr(BlockDeclRefExpr *ref) { 3879f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 3880f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 3881f85e193739c953358c865005855253af4f68a497John McCall } 3882f85e193739c953358c865005855253af4f68a497John McCall 3883f85e193739c953358c865005855253af4f68a497John McCall void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) { 3884f85e193739c953358c865005855253af4f68a497John McCall if (Capturer) return; 3885f85e193739c953358c865005855253af4f68a497John McCall Visit(ref->getBase()); 3886f85e193739c953358c865005855253af4f68a497John McCall if (Capturer && ref->isFreeIvar()) 3887f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 3888f85e193739c953358c865005855253af4f68a497John McCall } 3889f85e193739c953358c865005855253af4f68a497John McCall 3890f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockExpr(BlockExpr *block) { 3891f85e193739c953358c865005855253af4f68a497John McCall // Look inside nested blocks 3892f85e193739c953358c865005855253af4f68a497John McCall if (block->getBlockDecl()->capturesVariable(Variable)) 3893f85e193739c953358c865005855253af4f68a497John McCall Visit(block->getBlockDecl()->getBody()); 3894f85e193739c953358c865005855253af4f68a497John McCall } 3895f85e193739c953358c865005855253af4f68a497John McCall }; 3896f85e193739c953358c865005855253af4f68a497John McCall} 3897f85e193739c953358c865005855253af4f68a497John McCall 3898f85e193739c953358c865005855253af4f68a497John McCall/// Check whether the given argument is a block which captures a 3899f85e193739c953358c865005855253af4f68a497John McCall/// variable. 3900f85e193739c953358c865005855253af4f68a497John McCallstatic Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) { 3901f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 3902f85e193739c953358c865005855253af4f68a497John McCall 3903f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParenCasts(); 3904f85e193739c953358c865005855253af4f68a497John McCall BlockExpr *block = dyn_cast<BlockExpr>(e); 3905f85e193739c953358c865005855253af4f68a497John McCall if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable)) 3906f85e193739c953358c865005855253af4f68a497John McCall return 0; 3907f85e193739c953358c865005855253af4f68a497John McCall 3908f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor visitor(S.Context, owner.Variable); 3909f85e193739c953358c865005855253af4f68a497John McCall visitor.Visit(block->getBlockDecl()->getBody()); 3910f85e193739c953358c865005855253af4f68a497John McCall return visitor.Capturer; 3911f85e193739c953358c865005855253af4f68a497John McCall} 3912f85e193739c953358c865005855253af4f68a497John McCall 3913f85e193739c953358c865005855253af4f68a497John McCallstatic void diagnoseRetainCycle(Sema &S, Expr *capturer, 3914f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner &owner) { 3915f85e193739c953358c865005855253af4f68a497John McCall assert(capturer); 3916f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 3917f85e193739c953358c865005855253af4f68a497John McCall 3918f85e193739c953358c865005855253af4f68a497John McCall S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle) 3919f85e193739c953358c865005855253af4f68a497John McCall << owner.Variable << capturer->getSourceRange(); 3920f85e193739c953358c865005855253af4f68a497John McCall S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner) 3921f85e193739c953358c865005855253af4f68a497John McCall << owner.Indirect << owner.Range; 3922f85e193739c953358c865005855253af4f68a497John McCall} 3923f85e193739c953358c865005855253af4f68a497John McCall 3924f85e193739c953358c865005855253af4f68a497John McCall/// Check for a keyword selector that starts with the word 'add' or 3925f85e193739c953358c865005855253af4f68a497John McCall/// 'set'. 3926f85e193739c953358c865005855253af4f68a497John McCallstatic bool isSetterLikeSelector(Selector sel) { 3927f85e193739c953358c865005855253af4f68a497John McCall if (sel.isUnarySelector()) return false; 3928f85e193739c953358c865005855253af4f68a497John McCall 39295f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef str = sel.getNameForSlot(0); 3930f85e193739c953358c865005855253af4f68a497John McCall while (!str.empty() && str.front() == '_') str = str.substr(1); 3931f85e193739c953358c865005855253af4f68a497John McCall if (str.startswith("set") || str.startswith("add")) 3932f85e193739c953358c865005855253af4f68a497John McCall str = str.substr(3); 3933f85e193739c953358c865005855253af4f68a497John McCall else 3934f85e193739c953358c865005855253af4f68a497John McCall return false; 3935f85e193739c953358c865005855253af4f68a497John McCall 3936f85e193739c953358c865005855253af4f68a497John McCall if (str.empty()) return true; 3937f85e193739c953358c865005855253af4f68a497John McCall return !islower(str.front()); 3938f85e193739c953358c865005855253af4f68a497John McCall} 3939f85e193739c953358c865005855253af4f68a497John McCall 3940f85e193739c953358c865005855253af4f68a497John McCall/// Check a message send to see if it's likely to cause a retain cycle. 3941f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(ObjCMessageExpr *msg) { 3942f85e193739c953358c865005855253af4f68a497John McCall // Only check instance methods whose selector looks like a setter. 3943f85e193739c953358c865005855253af4f68a497John McCall if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector())) 3944f85e193739c953358c865005855253af4f68a497John McCall return; 3945f85e193739c953358c865005855253af4f68a497John McCall 3946f85e193739c953358c865005855253af4f68a497John McCall // Try to find a variable that the receiver is strongly owned by. 3947f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 3948f85e193739c953358c865005855253af4f68a497John McCall if (msg->getReceiverKind() == ObjCMessageExpr::Instance) { 3949f85e193739c953358c865005855253af4f68a497John McCall if (!findRetainCycleOwner(msg->getInstanceReceiver(), owner)) 3950f85e193739c953358c865005855253af4f68a497John McCall return; 3951f85e193739c953358c865005855253af4f68a497John McCall } else { 3952f85e193739c953358c865005855253af4f68a497John McCall assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance); 3953f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = getCurMethodDecl()->getSelfDecl(); 3954f85e193739c953358c865005855253af4f68a497John McCall owner.Loc = msg->getSuperLoc(); 3955f85e193739c953358c865005855253af4f68a497John McCall owner.Range = msg->getSuperLoc(); 3956f85e193739c953358c865005855253af4f68a497John McCall } 3957f85e193739c953358c865005855253af4f68a497John McCall 3958f85e193739c953358c865005855253af4f68a497John McCall // Check whether the receiver is captured by any of the arguments. 3959f85e193739c953358c865005855253af4f68a497John McCall for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i) 3960f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner)) 3961f85e193739c953358c865005855253af4f68a497John McCall return diagnoseRetainCycle(*this, capturer, owner); 3962f85e193739c953358c865005855253af4f68a497John McCall} 3963f85e193739c953358c865005855253af4f68a497John McCall 3964f85e193739c953358c865005855253af4f68a497John McCall/// Check a property assign to see if it's likely to cause a retain cycle. 3965f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(Expr *receiver, Expr *argument) { 3966f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 3967f85e193739c953358c865005855253af4f68a497John McCall if (!findRetainCycleOwner(receiver, owner)) 3968f85e193739c953358c865005855253af4f68a497John McCall return; 3969f85e193739c953358c865005855253af4f68a497John McCall 3970f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, argument, owner)) 3971f85e193739c953358c865005855253af4f68a497John McCall diagnoseRetainCycle(*this, capturer, owner); 3972f85e193739c953358c865005855253af4f68a497John McCall} 3973f85e193739c953358c865005855253af4f68a497John McCall 3974921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianbool Sema::checkUnsafeAssigns(SourceLocation Loc, 3975f85e193739c953358c865005855253af4f68a497John McCall QualType LHS, Expr *RHS) { 3976f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime(); 3977f85e193739c953358c865005855253af4f68a497John McCall if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone) 3978921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return false; 3979921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // strip off any implicit cast added to get to the one arc-specific 3980921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 3981921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (cast->getCastKind() == CK_ObjCConsumeObject) { 3982f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::warn_arc_retained_assign) 3983f85e193739c953358c865005855253af4f68a497John McCall << (LT == Qualifiers::OCL_ExplicitNone) 3984f85e193739c953358c865005855253af4f68a497John McCall << RHS->getSourceRange(); 3985921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return true; 3986921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 3987921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 3988921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 3989921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return false; 3990f85e193739c953358c865005855253af4f68a497John McCall} 3991f85e193739c953358c865005855253af4f68a497John McCall 3992921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianvoid Sema::checkUnsafeExprAssigns(SourceLocation Loc, 3993921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Expr *LHS, Expr *RHS) { 3994921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian QualType LHSType = LHS->getType(); 3995921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (checkUnsafeAssigns(Loc, LHSType, RHS)) 3996921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 3997921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime(); 3998921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // FIXME. Check for other life times. 3999921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (LT != Qualifiers::OCL_None) 4000921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4001921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 4002921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (ObjCPropertyRefExpr *PRE = dyn_cast<ObjCPropertyRefExpr>(LHS)) { 4003921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (PRE->isImplicitProperty()) 4004921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4005921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 4006921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (!PD) 4007921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4008921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 4009921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian unsigned Attributes = PD->getPropertyAttributes(); 4010921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) 4011921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 4012921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (cast->getCastKind() == CK_ObjCConsumeObject) { 4013921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Diag(Loc, diag::warn_arc_retained_property_assign) 4014921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian << RHS->getSourceRange(); 4015921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4016921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4017921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 4018921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4019921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4020921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian} 4021