SemaChecking.cpp revision 980343b9a1d0e85f960fa289c2c9a727004964f2
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===//
259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//                     The LLVM Compiler Infrastructure
459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source
60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details.
759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===//
959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump//  This file implements extra semantic analysis beyond what is enforced
1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//  by the C type system.
1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//
1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===//
1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner
155f8d604246976a93a73549b07bbc8ee0b2061b50John McCall#include "clang/Sema/Initialization.h"
16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Sema.h"
172d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h"
18276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman#include "clang/Sema/Initialization.h"
19831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith#include "clang/Sema/Lookup.h"
20781472fe99a120098c631b0cbe33c89f8cef5e70John McCall#include "clang/Sema/ScopeInfo.h"
21826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek#include "clang/Analysis/Analyses/FormatString.h"
2259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h"
23199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h"
24384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h"
25c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h"
26be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie#include "clang/AST/Expr.h"
272324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h"
287ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h"
29f85e193739c953358c865005855253af4f68a497John McCall#include "clang/AST/EvaluatedExprVisitor.h"
30f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/DeclObjC.h"
31f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h"
32f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h"
3359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h"
34f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h"
358fe83e1df954d72c0f4ffc15d20a5222ec151c21Benjamin Kramer#include "llvm/ADT/SmallString.h"
36f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h"
373bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h"
38691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher#include "clang/Basic/TargetBuiltins.h"
3926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman#include "clang/Basic/TargetInfo.h"
407da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian#include "clang/Basic/ConvertUTF.h"
41a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits>
4259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang;
43781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema;
4459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner
4560800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL,
4660800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner                                                    unsigned ByteNo) const {
4708f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner  return SL->getLocationOfByte(ByteNo, PP.getSourceManager(),
484e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie                               PP.getLangOpts(), PP.getTargetInfo());
4960800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner}
5060800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner
518e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number.
528e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking.  Returns true on error.
538e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) {
548e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  unsigned argCount = call->getNumArgs();
558e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  if (argCount == desiredArgCount) return false;
568e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
578e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  if (argCount < desiredArgCount)
588e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args)
598e10f3b9cc1db43645bbc2999eb163af8997d468John McCall        << 0 /*function call*/ << desiredArgCount << argCount
608e10f3b9cc1db43645bbc2999eb163af8997d468John McCall        << call->getSourceRange();
618e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
628e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  // Highlight all the excess arguments.
638e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  SourceRange range(call->getArg(desiredArgCount)->getLocStart(),
648e10f3b9cc1db43645bbc2999eb163af8997d468John McCall                    call->getArg(argCount - 1)->getLocEnd());
658e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
668e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args)
678e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    << 0 /*function call*/ << desiredArgCount << argCount
688e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    << call->getArg(1)->getSourceRange();
698e10f3b9cc1db43645bbc2999eb163af8997d468John McCall}
708e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
71e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// Check that the first argument to __builtin_annotation is an integer
72e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// and the second argument is a non-wide string literal.
73e59392176c2369df2bdd11b7786cb38abac00198Julien Lerougestatic bool SemaBuiltinAnnotation(Sema &S, CallExpr *TheCall) {
74e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  if (checkArgCount(S, TheCall, 2))
75e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    return true;
76e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge
77e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  // First argument should be an integer.
78e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  Expr *ValArg = TheCall->getArg(0);
79e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  QualType Ty = ValArg->getType();
80e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  if (!Ty->isIntegerType()) {
81e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    S.Diag(ValArg->getLocStart(), diag::err_builtin_annotation_first_arg)
82e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge      << ValArg->getSourceRange();
83e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    return true;
84e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  }
85e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge
86e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  // Second argument should be a constant string.
87e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  Expr *StrArg = TheCall->getArg(1)->IgnoreParenCasts();
88e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  StringLiteral *Literal = dyn_cast<StringLiteral>(StrArg);
8977f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge  if (!Literal || !Literal->isAscii()) {
90e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    S.Diag(StrArg->getLocStart(), diag::err_builtin_annotation_second_arg)
91e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge      << StrArg->getSourceRange();
9277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge    return true;
9377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge  }
94e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge
95e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge  TheCall->setType(Ty);
9677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge  return false;
9777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge}
9877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge
9960d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult
100d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
10160d7b3a319d84d688752be3870615ac0f111fb16John McCall  ExprResult TheCallResult(Owned(TheCall));
1022def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor
103946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  // Find out if any arguments are required to be integer constant expressions.
104946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  unsigned ICEArguments = 0;
105946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  ASTContext::GetBuiltinTypeError Error;
106946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  Context.GetBuiltinType(BuiltinID, Error, &ICEArguments);
107946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  if (Error != ASTContext::GE_None)
108946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    ICEArguments = 0;  // Don't diagnose previously diagnosed errors.
109946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner
110946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  // If any arguments are required to be ICE's, check and diagnose.
111946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) {
112946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    // Skip arguments not required to be ICE's.
113946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    if ((ICEArguments & (1 << ArgNo)) == 0) continue;
114946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner
115946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    llvm::APSInt Result;
116946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    if (SemaBuiltinConstantArg(TheCall, ArgNo, Result))
117946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner      return true;
118946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner    ICEArguments &= ~(1 << ArgNo);
119946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner  }
120946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner
121d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson  switch (BuiltinID) {
12230ce344307f8a8b00054021307015571f83c7364Chris Lattner  case Builtin::BI__builtin___CFStringMakeConstantString:
123925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner    assert(TheCall->getNumArgs() == 1 &&
1241b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner           "Wrong # arguments to builtin CFStringMakeConstantString");
125690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner    if (CheckObjCString(TheCall->getArg(0)))
1260eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
127d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
12849ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek  case Builtin::BI__builtin_stdarg_start:
12930ce344307f8a8b00054021307015571f83c7364Chris Lattner  case Builtin::BI__builtin_va_start:
1300eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    if (SemaBuiltinVAStart(TheCall))
1310eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
132d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
1331b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_isgreater:
1341b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_isgreaterequal:
1351b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_isless:
1361b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_islessequal:
1371b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_islessgreater:
1381b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  case Builtin::BI__builtin_isunordered:
1390eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    if (SemaBuiltinUnorderedCompare(TheCall))
1400eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
141d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
142e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer  case Builtin::BI__builtin_fpclassify:
143e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer    if (SemaBuiltinFPClassification(TheCall, 6))
144e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer      return ExprError();
145e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer    break;
1469ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isfinite:
1479ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isinf:
1489ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isinf_sign:
1499ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isnan:
1509ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  case Builtin::BI__builtin_isnormal:
1513b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer    if (SemaBuiltinFPClassification(TheCall, 1))
1529ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman      return ExprError();
1539ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman    break;
154d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  case Builtin::BI__builtin_shufflevector:
1550eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    return SemaBuiltinShuffleVector(TheCall);
1560eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    // TheCall will be freed by the smart pointer here, but that's fine, since
1570eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    // SemaBuiltinShuffleVector guts it, but then doesn't release it.
1584493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar  case Builtin::BI__builtin_prefetch:
1590eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    if (SemaBuiltinPrefetch(TheCall))
1600eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
161d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
162d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar  case Builtin::BI__builtin_object_size:
1630eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    if (SemaBuiltinObjectSize(TheCall))
1640eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError();
165d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
166d875fed28578835de89cd407e9db4be788596d7cEli Friedman  case Builtin::BI__builtin_longjmp:
167d875fed28578835de89cd407e9db4be788596d7cEli Friedman    if (SemaBuiltinLongjmp(TheCall))
168d875fed28578835de89cd407e9db4be788596d7cEli Friedman      return ExprError();
169d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    break;
1708e10f3b9cc1db43645bbc2999eb163af8997d468John McCall
1718e10f3b9cc1db43645bbc2999eb163af8997d468John McCall  case Builtin::BI__builtin_classify_type:
1728e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    if (checkArgCount(*this, TheCall, 1)) return true;
1738e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    TheCall->setType(Context.IntTy);
1748e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    break;
17575c29a012793292ff4578015a9113bf086156d7fChris Lattner  case Builtin::BI__builtin_constant_p:
1768e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    if (checkArgCount(*this, TheCall, 1)) return true;
1778e10f3b9cc1db43645bbc2999eb163af8997d468John McCall    TheCall->setType(Context.IntTy);
17875c29a012793292ff4578015a9113bf086156d7fChris Lattner    break;
1795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_add:
180a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_1:
181a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_2:
182a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_4:
183a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_8:
184a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_16:
1855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_sub:
186a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_1:
187a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_2:
188a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_4:
189a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_8:
190a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_16:
1915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_or:
192a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_1:
193a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_2:
194a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_4:
195a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_8:
196a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_16:
1975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_and:
198a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_1:
199a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_2:
200a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_4:
201a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_8:
202a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_16:
2035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_fetch_and_xor:
204a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_1:
205a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_2:
206a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_4:
207a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_8:
208a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_16:
2095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_add_and_fetch:
210a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_1:
211a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_2:
212a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_4:
213a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_8:
214a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_16:
2155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_sub_and_fetch:
216a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_1:
217a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_2:
218a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_4:
219a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_8:
220a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_16:
2215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_and_and_fetch:
222a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_1:
223a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_2:
224a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_4:
225a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_8:
226a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_16:
2275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_or_and_fetch:
228a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_1:
229a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_2:
230a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_4:
231a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_8:
232a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_16:
2335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_xor_and_fetch:
234a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_1:
235a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_2:
236a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_4:
237a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_8:
238a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_16:
2395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_val_compare_and_swap:
240a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_1:
241a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_2:
242a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_4:
243a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_8:
244a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_16:
2455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_bool_compare_and_swap:
246a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_1:
247a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_2:
248a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_4:
249a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_8:
250a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_16:
2515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_lock_test_and_set:
252a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_1:
253a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_2:
254a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_4:
255a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_8:
256a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_16:
2575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_lock_release:
258a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_1:
259a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_2:
260a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_4:
261a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_8:
262a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_16:
26323aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner  case Builtin::BI__sync_swap:
264a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_1:
265a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_2:
266a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_4:
267a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_8:
268a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_16:
269d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return SemaBuiltinAtomicOverloaded(move(TheCallResult));
270ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define BUILTIN(ID, TYPE, ATTRS)
271ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define ATOMIC_BUILTIN(ID, TYPE, ATTRS) \
272ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Builtin::BI##ID: \
273ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::AO##ID);
274ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#include "clang/Basic/Builtins.def"
27577f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge  case Builtin::BI__builtin_annotation:
276e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge    if (SemaBuiltinAnnotation(*this, TheCall))
27777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge      return ExprError();
27877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge    break;
27926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  }
28026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman
28126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  // Since the target specific builtins for each arch overlap, only check those
28226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  // of the arch we are compiling for.
28326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  if (BuiltinID >= Builtin::FirstTSBuiltin) {
284bcfd1f55bfbb3e5944cd5e03d07b343e280838c4Douglas Gregor    switch (Context.getTargetInfo().getTriple().getArch()) {
28526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman      case llvm::Triple::arm:
28626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman      case llvm::Triple::thumb:
28726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman        if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall))
28826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman          return ExprError();
28926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman        break;
290fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      case llvm::Triple::mips:
291fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      case llvm::Triple::mipsel:
292fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      case llvm::Triple::mips64:
293fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      case llvm::Triple::mips64el:
294fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan        if (CheckMipsBuiltinFunctionCall(BuiltinID, TheCall))
295fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan          return ExprError();
296fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan        break;
29726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman      default:
29826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman        break;
29926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman    }
30026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  }
30126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman
30226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  return move(TheCallResult);
30326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman}
30426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman
30561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code.
30661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) {
307da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  NeonTypeFlags Type(t);
308da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  int IsQuad = Type.isQuad();
309da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  switch (Type.getEltType()) {
310da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Int8:
311da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Poly8:
312da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return shift ? 7 : (8 << IsQuad) - 1;
313da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Int16:
314da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Poly16:
315da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return shift ? 15 : (4 << IsQuad) - 1;
316da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Int32:
317da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return shift ? 31 : (2 << IsQuad) - 1;
318da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Int64:
319da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return shift ? 63 : (1 << IsQuad) - 1;
320da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Float16:
321da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    assert(!shift && "cannot shift float types!");
322da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return (4 << IsQuad) - 1;
323da95f73b59f9af964e33725c515139d34c90c863Bob Wilson  case NeonTypeFlags::Float32:
324da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    assert(!shift && "cannot shift float types!");
325da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    return (2 << IsQuad) - 1;
32661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  }
3277530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie  llvm_unreachable("Invalid NeonTypeFlag!");
32861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman}
32961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman
3306f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// getNeonEltType - Return the QualType corresponding to the elements of
3316f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the vector type specified by the NeonTypeFlags.  This is used to check
3326f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the pointer arguments for Neon load/store intrinsics.
3336f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilsonstatic QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context) {
3346f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  switch (Flags.getEltType()) {
3356f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Int8:
3366f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy;
3376f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Int16:
3386f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy;
3396f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Int32:
3406f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy;
3416f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Int64:
3426f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Flags.isUnsigned() ? Context.UnsignedLongLongTy : Context.LongLongTy;
3436f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Poly8:
3446f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Context.SignedCharTy;
3456f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Poly16:
3466f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Context.ShortTy;
3476f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Float16:
3486f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Context.UnsignedShortTy;
3496f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  case NeonTypeFlags::Float32:
3506f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    return Context.FloatTy;
3516f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  }
3527530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie  llvm_unreachable("Invalid NeonTypeFlag!");
3536f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson}
3546f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson
35526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
3561c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman  llvm::APSInt Result;
3571c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman
3580d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  unsigned mask = 0;
35961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  unsigned TV = 0;
3604648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson  int PtrArgNum = -1;
3616f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  bool HasConstPtr = false;
3621c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman  switch (BuiltinID) {
363a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK
364a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc"
365a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK
3661c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman  }
3671c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman
3680d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  // For NEON intrinsics which are overloaded on vector element type, validate
3690d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  // the immediate which specifies which variant to emit.
3706f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  unsigned ImmArg = TheCall->getNumArgs()-1;
3710d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  if (mask) {
3726f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    if (SemaBuiltinConstantArg(TheCall, ImmArg, Result))
3730d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman      return true;
3740d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman
375da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    TV = Result.getLimitedValue(64);
376da95f73b59f9af964e33725c515139d34c90c863Bob Wilson    if ((TV > 63) || (mask & (1 << TV)) == 0)
3770d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman      return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code)
3786f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson        << TheCall->getArg(ImmArg)->getSourceRange();
3796f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson  }
3806f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson
3814648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson  if (PtrArgNum >= 0) {
3826f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson    // Check that pointer arguments have the specified type.
3834648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    Expr *Arg = TheCall->getArg(PtrArgNum);
3844648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg))
3854648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson      Arg = ICE->getSubExpr();
3864648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg);
3874648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    QualType RHSTy = RHS.get()->getType();
3884648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context);
3894648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    if (HasConstPtr)
3904648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson      EltTy = EltTy.withConst();
3914648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    QualType LHSTy = Context.getPointerType(EltTy);
3924648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    AssignConvertType ConvTy;
3934648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS);
3944648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    if (RHS.isInvalid())
3954648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson      return true;
3964648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson    if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy,
3974648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson                                 RHS.get(), AA_Assigning))
3984648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson      return true;
3990d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  }
4001c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman
4010d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  // For NEON intrinsics which take an immediate value as part of the
4020d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  // instruction, range check them here.
40361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  unsigned i = 0, l = 0, u = 0;
4040d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  switch (BuiltinID) {
4050d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  default: return false;
406bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman  case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break;
407bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman  case ARM::BI__builtin_arm_usat: i = 1; u = 31; break;
40899c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman  case ARM::BI__builtin_arm_vcvtr_f:
40999c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman  case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break;
410a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK
411a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc"
412a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK
4130d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  };
4140d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman
415592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor  // We can't check the value of a dependent argument.
416592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor  if (TheCall->getArg(i)->isTypeDependent() ||
417592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor      TheCall->getArg(i)->isValueDependent())
418592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor    return false;
419592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
42061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  // Check that the immediate argument is actually a constant.
4210d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  if (SemaBuiltinConstantArg(TheCall, i, Result))
4220d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman    return true;
4230d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman
42461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  // Range check against the upper/lower values for this isntruction.
4250d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman  unsigned Val = Result.getZExtValue();
42661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman  if (Val < l || Val > (u + l))
4270d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman    return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
428476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer      << l << u+l << TheCall->getArg(i)->getSourceRange();
4290d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman
43099c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman  // FIXME: VFP Intrinsics should error if VFP not present.
43126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman  return false;
432d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson}
433d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson
434fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyanbool Sema::CheckMipsBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
435fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  unsigned i = 0, l = 0, u = 0;
436fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  switch (BuiltinID) {
437fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  default: return false;
438fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  case Mips::BI__builtin_mips_wrdsp: i = 1; l = 0; u = 63; break;
439fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  case Mips::BI__builtin_mips_rddsp: i = 0; l = 0; u = 63; break;
440fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  };
441fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
442fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  // We can't check the value of a dependent argument.
443fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  if (TheCall->getArg(i)->isTypeDependent() ||
444fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      TheCall->getArg(i)->isValueDependent())
445fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan    return false;
446fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
447fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  // Check that the immediate argument is actually a constant.
448fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  llvm::APSInt Result;
449fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  if (SemaBuiltinConstantArg(TheCall, i, Result))
450fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan    return true;
451fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
452fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  // Range check against the upper/lower values for this instruction.
453fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  unsigned Val = Result.getZExtValue();
454fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  if (Val < l || Val > u)
455fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan    return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
456fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan      << l << u << TheCall->getArg(i)->getSourceRange();
457fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
458fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan  return false;
459fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan}
460fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan
461831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Given a FunctionDecl's FormatAttr, attempts to populate the FomatStringInfo
462831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// parameter with the FormatAttr's correct format_idx and firstDataArg.
463831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true when the format fits the function and the FormatStringInfo has
464831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// been populated.
465831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::getFormatStringInfo(const FormatAttr *Format, bool IsCXXMember,
466831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                               FormatStringInfo *FSI) {
467831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  FSI->HasVAListArg = Format->getFirstArg() == 0;
468831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  FSI->FormatIdx = Format->getFormatIdx() - 1;
469831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  FSI->FirstDataArg = FSI->HasVAListArg ? 0 : Format->getFirstArg() - 1;
470de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar
471831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // The way the format attribute works in GCC, the implicit this argument
472831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // of member functions is counted. However, it doesn't appear in our own
473831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // lists, so decrement format_idx in that case.
474831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (IsCXXMember) {
475831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    if(FSI->FormatIdx == 0)
476831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      return false;
477831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    --FSI->FormatIdx;
478831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    if (FSI->FirstDataArg != 0)
479831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      --FSI->FirstDataArg;
480831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  }
481831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return true;
482831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
4831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
484831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Handles the checks for format strings, non-POD arguments to vararg
485831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// functions, and NULL arguments passed to non-NULL parameters.
486831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithvoid Sema::checkCall(NamedDecl *FDecl, Expr **Args,
487831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     unsigned NumArgs,
488831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     unsigned NumProtoArgs,
489831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     bool IsMemberFunction,
490831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     SourceLocation Loc,
491831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     SourceRange Range,
492831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                     VariadicCallType CallType) {
493de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar  // FIXME: This mechanism should be abstracted to be less fragile and
494de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar  // more efficient. For example, just map function ids to custom
495de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar  // handlers.
496de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar
497c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek  // Printf and scanf checking.
498831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  bool HandledFormatString = false;
499c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek  for (specific_attr_iterator<FormatAttr>
500831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith         I = FDecl->specific_attr_begin<FormatAttr>(),
501831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith         E = FDecl->specific_attr_end<FormatAttr>(); I != E ; ++I)
502831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    if (CheckFormatArguments(*I, Args, NumArgs, IsMemberFunction, Loc, Range))
503831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        HandledFormatString = true;
504831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
505831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // Refuse POD arguments that weren't caught by the format string
506831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // checks above.
507831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (!HandledFormatString && CallType != VariadicDoesNotApply)
508831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    for (unsigned ArgIdx = NumProtoArgs; ArgIdx < NumArgs; ++ArgIdx)
509831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      variadicArgumentPODCheck(Args[ArgIdx], CallType);
5101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
511c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek  for (specific_attr_iterator<NonNullAttr>
512831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith         I = FDecl->specific_attr_begin<NonNullAttr>(),
513831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith         E = FDecl->specific_attr_end<NonNullAttr>(); I != E; ++I)
514831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    CheckNonNullArguments(*I, Args, Loc);
515831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
516831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
517831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckConstructorCall - Check a constructor call for correctness and safety
518831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// properties not enforced by the C type system.
519831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithvoid Sema::CheckConstructorCall(FunctionDecl *FDecl, Expr **Args,
520831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                unsigned NumArgs,
521831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                const FunctionProtoType *Proto,
522831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                SourceLocation Loc) {
523831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  VariadicCallType CallType =
524831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    Proto->isVariadic() ? VariadicConstructor : VariadicDoesNotApply;
525831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  checkCall(FDecl, Args, NumArgs, Proto->getNumArgs(),
526831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            /*IsMemberFunction=*/true, Loc, SourceRange(), CallType);
527831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
528831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
529831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckFunctionCall - Check a direct function call for various correctness
530831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// and safety properties not strictly enforced by the C type system.
531831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall,
532831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                             const FunctionProtoType *Proto) {
533831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  bool IsMemberFunction = isa<CXXMemberCallExpr>(TheCall);
534831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  VariadicCallType CallType = getVariadicCallType(FDecl, Proto,
535831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                                  TheCall->getCallee());
536831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0;
537831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  checkCall(FDecl, TheCall->getArgs(), TheCall->getNumArgs(), NumProtoArgs,
538831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            IsMemberFunction, TheCall->getRParenLoc(),
539831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            TheCall->getCallee()->getSourceRange(), CallType);
540831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
541831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  IdentifierInfo *FnInfo = FDecl->getIdentifier();
542831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // None of the checks below are needed for functions that don't have
543831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // simple names (e.g., C++ conversion functions).
544831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (!FnInfo)
545831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return false;
5460eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl
5470a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  unsigned CMId = FDecl->getMemoryFunctionKind();
5480a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  if (CMId == 0)
549d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks    return false;
550bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
551d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks  // Handle memory setting and copying functions.
5520a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat)
553bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    CheckStrlcpycatArguments(TheCall, FnInfo);
554c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  else if (CMId == Builtin::BIstrncat)
555c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    CheckStrncatArguments(TheCall, FnInfo);
556d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks  else
5570a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks    CheckMemaccessArguments(TheCall, CMId, FnInfo);
5587ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth
559d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson  return false;
56071993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson}
56171993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson
56229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupasbool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac,
56329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                               Expr **Args, unsigned NumArgs) {
564831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  VariadicCallType CallType =
565831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      Method->isVariadic() ? VariadicMethod : VariadicDoesNotApply;
56629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas
567831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  checkCall(Method, Args, NumArgs, Method->param_size(),
568831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            /*IsMemberFunction=*/false,
569831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            lbrac, Method->getSourceRange(), CallType);
57029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas
57129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  return false;
57229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas}
57329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas
574831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall,
575831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                          const FunctionProtoType *Proto) {
576725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian  const VarDecl *V = dyn_cast<VarDecl>(NDecl);
577725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian  if (!V)
578d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    return false;
5791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
580725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian  QualType Ty = V->getType();
581725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian  if (!Ty->isBlockPointerType())
582d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson    return false;
5831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
584831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  VariadicCallType CallType =
585831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      Proto && Proto->isVariadic() ? VariadicBlock : VariadicDoesNotApply ;
586831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0;
587d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson
588831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  checkCall(NDecl, TheCall->getArgs(), TheCall->getNumArgs(),
589831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            NumProtoArgs, /*IsMemberFunction=*/false,
590831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            TheCall->getRParenLoc(),
591831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            TheCall->getCallee()->getSourceRange(), CallType);
592831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
593d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson  return false;
594725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian}
595725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian
596ff34d401ff385ef7173ca612432b4ea717fff690Richard SmithExprResult Sema::SemaAtomicOpsOverloaded(ExprResult TheCallResult,
597ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith                                         AtomicExpr::AtomicOp Op) {
598276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  CallExpr *TheCall = cast<CallExpr>(TheCallResult.get());
599276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
600276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
601ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // All these operations take one of the following forms:
602ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  enum {
603ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // C    __c11_atomic_init(A *, C)
604ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Init,
605ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // C    __c11_atomic_load(A *, int)
606ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Load,
607ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // void __atomic_load(A *, CP, int)
608ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Copy,
609ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // C    __c11_atomic_add(A *, M, int)
610ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Arithmetic,
611ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // C    __atomic_exchange_n(A *, CP, int)
612ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Xchg,
613ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // void __atomic_exchange(A *, C *, CP, int)
614ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    GNUXchg,
615ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // bool __c11_atomic_compare_exchange_strong(A *, C *, CP, int, int)
616ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    C11CmpXchg,
617ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // bool __atomic_compare_exchange(A *, C *, CP, bool, int, int)
618ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    GNUCmpXchg
619ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  } Form = Init;
620ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  const unsigned NumArgs[] = { 2, 2, 3, 3, 3, 4, 5, 6 };
621ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  const unsigned NumVals[] = { 1, 0, 1, 1, 1, 2, 2, 3 };
622ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // where:
623ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   C is an appropriate type,
624ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   A is volatile _Atomic(C) for __c11 builtins and is C for GNU builtins,
625ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   CP is C for __c11 builtins and GNU _n builtins and is C * otherwise,
626ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   M is C if C is an integer, and ptrdiff_t if C is a pointer, and
627ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  //   the int parameters are for orderings.
628ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
629ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  assert(AtomicExpr::AO__c11_atomic_init == 0 &&
630ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith         AtomicExpr::AO__c11_atomic_fetch_xor + 1 == AtomicExpr::AO__atomic_load
631ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith         && "need to update code for modified C11 atomics");
632ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  bool IsC11 = Op >= AtomicExpr::AO__c11_atomic_init &&
633ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith               Op <= AtomicExpr::AO__c11_atomic_fetch_xor;
634ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  bool IsN = Op == AtomicExpr::AO__atomic_load_n ||
635ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith             Op == AtomicExpr::AO__atomic_store_n ||
636ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith             Op == AtomicExpr::AO__atomic_exchange_n ||
637ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith             Op == AtomicExpr::AO__atomic_compare_exchange_n;
638ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  bool IsAddSub = false;
639ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
640ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  switch (Op) {
641ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_init:
642ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Init;
643ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
644ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
645ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_load:
646ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_load_n:
647ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Load;
648ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
649ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
650ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_store:
651ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_load:
652ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_store:
653ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_store_n:
654ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Copy;
655ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
656ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
657ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_add:
658ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_sub:
659ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_add:
660ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_sub:
661ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_add_fetch:
662ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_sub_fetch:
663ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    IsAddSub = true;
664ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // Fall through.
665ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_and:
666ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_or:
667ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_fetch_xor:
668ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_and:
669ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_or:
670ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_fetch_xor:
67151b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith  case AtomicExpr::AO__atomic_fetch_nand:
672ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_and_fetch:
673ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_or_fetch:
674ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_xor_fetch:
67551b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith  case AtomicExpr::AO__atomic_nand_fetch:
676ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Arithmetic;
677ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
678ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
679ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_exchange:
680ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_exchange_n:
681ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = Xchg;
682ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
683ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
684ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_exchange:
685ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = GNUXchg;
686ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
687ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
688ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_compare_exchange_strong:
689ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__c11_atomic_compare_exchange_weak:
690ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = C11CmpXchg;
691ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
692ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
693ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_compare_exchange:
694ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case AtomicExpr::AO__atomic_compare_exchange_n:
695ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Form = GNUCmpXchg;
696ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
697276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
698276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
699ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // Check we have the right number of arguments.
700ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (TheCall->getNumArgs() < NumArgs[Form]) {
701276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
702ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      << 0 << NumArgs[Form] << TheCall->getNumArgs()
703276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << TheCall->getCallee()->getSourceRange();
704276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
705ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  } else if (TheCall->getNumArgs() > NumArgs[Form]) {
706ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Diag(TheCall->getArg(NumArgs[Form])->getLocStart(),
707276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman         diag::err_typecheck_call_too_many_args)
708ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      << 0 << NumArgs[Form] << TheCall->getNumArgs()
709276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << TheCall->getCallee()->getSourceRange();
710276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
711276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
712276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
713ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // Inspect the first argument of the atomic operation.
714dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman  Expr *Ptr = TheCall->getArg(0);
715276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get();
716276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  const PointerType *pointerType = Ptr->getType()->getAs<PointerType>();
717276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  if (!pointerType) {
718ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
719276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << Ptr->getType() << Ptr->getSourceRange();
720276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
721276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
722276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
723ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // For a __c11 builtin, this should be a pointer to an _Atomic type.
724ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  QualType AtomTy = pointerType->getPointeeType(); // 'A'
725ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  QualType ValType = AtomTy; // 'C'
726ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (IsC11) {
727ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    if (!AtomTy->isAtomicType()) {
728ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic)
729ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        << Ptr->getType() << Ptr->getSourceRange();
730ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      return ExprError();
731ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    }
732ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    ValType = AtomTy->getAs<AtomicType>()->getValueType();
733276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
734276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
735ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // For an arithmetic operation, the implied arithmetic must be well-formed.
736ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (Form == Arithmetic) {
737ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // gcc does not enforce these rules for GNU atomics, but we do so for sanity.
738ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    if (IsAddSub && !ValType->isIntegerType() && !ValType->isPointerType()) {
739ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr)
740ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        << IsC11 << Ptr->getType() << Ptr->getSourceRange();
741ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      return ExprError();
742ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    }
743ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    if (!IsAddSub && !ValType->isIntegerType()) {
744ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      Diag(DRE->getLocStart(), diag::err_atomic_op_bitwise_needs_atomic_int)
745ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        << IsC11 << Ptr->getType() << Ptr->getSourceRange();
746ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      return ExprError();
747ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    }
748ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  } else if (IsN && !ValType->isIntegerType() && !ValType->isPointerType()) {
749ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // For __atomic_*_n operations, the value type must be a scalar integral or
750ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // pointer type which is 1, 2, 4, 8 or 16 bytes in length.
751276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr)
752ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      << IsC11 << Ptr->getType() << Ptr->getSourceRange();
753276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
754276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
755276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
756ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (!IsC11 && !AtomTy.isTriviallyCopyableType(Context)) {
757ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // For GNU atomics, require a trivially-copyable type. This is not part of
758ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // the GNU atomics specification, but we enforce it for sanity.
759ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    Diag(DRE->getLocStart(), diag::err_atomic_op_needs_trivial_copy)
760276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << Ptr->getType() << Ptr->getSourceRange();
761276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
762276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
763276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
764ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // FIXME: For any builtin other than a load, the ValType must not be
765ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // const-qualified.
766ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
767276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  switch (ValType.getObjCLifetime()) {
768276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_None:
769276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_ExplicitNone:
770276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    // okay
771276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    break;
772276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
773276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_Weak:
774276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_Strong:
775276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  case Qualifiers::OCL_Autoreleasing:
776ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // FIXME: Can this happen? By this point, ValType should be known
777ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // to be trivially copyable.
778276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
779276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      << ValType << Ptr->getSourceRange();
780276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    return ExprError();
781276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
782276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
783276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  QualType ResultType = ValType;
784ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (Form == Copy || Form == GNUXchg || Form == Init)
785276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    ResultType = Context.VoidTy;
786ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  else if (Form == C11CmpXchg || Form == GNUCmpXchg)
787276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    ResultType = Context.BoolTy;
788276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
789ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // The type of a parameter passed 'by value'. In the GNU atomics, such
790ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // arguments are actually passed as pointers.
791ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  QualType ByValType = ValType; // 'CP'
792ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  if (!IsC11 && !IsN)
793ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    ByValType = Ptr->getType();
794ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
795276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  // The first argument --- the pointer --- has a fixed type; we
796276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  // deduce the types of the rest of the arguments accordingly.  Walk
797276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  // the remaining arguments, converting them to the deduced value type.
798ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  for (unsigned i = 1; i != NumArgs[Form]; ++i) {
799276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    QualType Ty;
800ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    if (i < NumVals[Form] + 1) {
801ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      switch (i) {
802ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      case 1:
803ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // The second argument is the non-atomic operand. For arithmetic, this
804ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // is always passed by value, and for a compare_exchange it is always
805ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // passed by address. For the rest, GNU uses by-address and C11 uses
806ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // by-value.
807ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        assert(Form != Load);
808ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        if (Form == Init || (Form == Arithmetic && ValType->isIntegerType()))
809ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith          Ty = ValType;
810ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        else if (Form == Copy || Form == Xchg)
811ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith          Ty = ByValType;
812ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        else if (Form == Arithmetic)
813ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith          Ty = Context.getPointerDiffType();
814ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        else
815ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith          Ty = Context.getPointerType(ValType.getUnqualifiedType());
816ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        break;
817ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      case 2:
818ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // The third argument to compare_exchange / GNU exchange is a
819ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // (pointer to a) desired value.
820ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        Ty = ByValType;
821ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        break;
822ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      case 3:
823ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        // The fourth argument to GNU compare_exchange is a 'weak' flag.
824ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        Ty = Context.BoolTy;
825ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith        break;
826ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith      }
827276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    } else {
828276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      // The order(s) are always converted to int.
829276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      Ty = Context.IntTy;
830276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    }
831ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith
832276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    InitializedEntity Entity =
833276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman        InitializedEntity::InitializeParameter(Context, Ty, false);
834ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    ExprResult Arg = TheCall->getArg(i);
835276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
836276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    if (Arg.isInvalid())
837276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman      return true;
838276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman    TheCall->setArg(i, Arg.get());
839276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
840276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
841ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  // Permute the arguments into a 'consistent' order.
842dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman  SmallVector<Expr*, 5> SubExprs;
843dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman  SubExprs.push_back(Ptr);
844ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  switch (Form) {
845ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Init:
846ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // Note, AtomicExpr::getVal1() has a special case for this atomic.
8477a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall    SubExprs.push_back(TheCall->getArg(1)); // Val1
848ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
849ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Load:
850ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(1)); // Order
851ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
852ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Copy:
853ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Arithmetic:
854ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case Xchg:
855dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(2)); // Order
856dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(1)); // Val1
857ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
858ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case GNUXchg:
859ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    // Note, AtomicExpr::getVal2() has a special case for this atomic.
860ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(3)); // Order
861ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(1)); // Val1
862ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(2)); // Val2
863ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
864ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case C11CmpXchg:
865dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(3)); // Order
866dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(1)); // Val1
867dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman    SubExprs.push_back(TheCall->getArg(4)); // OrderFail
8682ebb98a78471f2039af4321bae657e7daacc2a62David Chisnall    SubExprs.push_back(TheCall->getArg(2)); // Val2
869ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
870ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith  case GNUCmpXchg:
871ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(4)); // Order
872ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(1)); // Val1
873ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(5)); // OrderFail
874ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(2)); // Val2
875ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    SubExprs.push_back(TheCall->getArg(3)); // Weak
876ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith    break;
877276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman  }
878dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman
879dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman  return Owned(new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(),
880dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman                                        SubExprs.data(), SubExprs.size(),
881dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman                                        ResultType, Op,
882dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman                                        TheCall->getRParenLoc()));
883276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman}
884276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
885276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman
8865f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// checkBuiltinArgument - Given a call to a builtin function, perform
8875f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// normal type-checking on the given argument, updating the call in
8885f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// place.  This is useful when a builtin function requires custom
8895f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// type-checking for some of its arguments but not necessarily all of
8905f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// them.
8915f8d604246976a93a73549b07bbc8ee0b2061b50John McCall///
8925f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// Returns true on error.
8935f8d604246976a93a73549b07bbc8ee0b2061b50John McCallstatic bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) {
8945f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  FunctionDecl *Fn = E->getDirectCallee();
8955f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  assert(Fn && "builtin call without direct callee!");
8965f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
8975f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  ParmVarDecl *Param = Fn->getParamDecl(ArgIndex);
8985f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  InitializedEntity Entity =
8995f8d604246976a93a73549b07bbc8ee0b2061b50John McCall    InitializedEntity::InitializeParameter(S.Context, Param);
9005f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
9015f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  ExprResult Arg = E->getArg(0);
9025f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
9035f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  if (Arg.isInvalid())
9045f8d604246976a93a73549b07bbc8ee0b2061b50John McCall    return true;
9055f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
9065f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  E->setArg(ArgIndex, Arg.take());
9075f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  return false;
9085f8d604246976a93a73549b07bbc8ee0b2061b50John McCall}
9095f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
9105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like
9115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer
9125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument.  The main ActOnCallExpr routines have already
9135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as
9145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...).
9155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner///
9165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these
9175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins,
91860d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult
91960d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) {
920d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  CallExpr *TheCall = (CallExpr *)TheCallResult.get();
9215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
9225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
9235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner
9245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Ensure that we have at least one argument to do type inference from.
925d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  if (TheCall->getNumArgs() < 1) {
926d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
927d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << 0 << 1 << TheCall->getNumArgs()
928d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << TheCall->getCallee()->getSourceRange();
929d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
930d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  }
9311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
9325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Inspect the first argument of the atomic builtin.  This should always be
9335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // a pointer type, whose element is an integral scalar or pointer type.
9345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Because it is a pointer type, we don't have to worry about any implicit
9355caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // casts here.
936d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  // FIXME: We don't allow floating point scalars as input.
9375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  Expr *FirstArg = TheCall->getArg(0);
9388c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman  ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg);
9398c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman  if (FirstArgResult.isInvalid())
9408c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman    return ExprError();
9418c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman  FirstArg = FirstArgResult.take();
9428c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman  TheCall->setArg(0, FirstArg);
9438c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman
944f85e193739c953358c865005855253af4f68a497John McCall  const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>();
945f85e193739c953358c865005855253af4f68a497John McCall  if (!pointerType) {
946d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
947d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << FirstArg->getType() << FirstArg->getSourceRange();
948d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
949d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  }
9501eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
951f85e193739c953358c865005855253af4f68a497John McCall  QualType ValType = pointerType->getPointeeType();
952dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner  if (!ValType->isIntegerType() && !ValType->isAnyPointerType() &&
953d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      !ValType->isBlockPointerType()) {
954d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr)
955d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << FirstArg->getType() << FirstArg->getSourceRange();
956d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
957d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  }
9585caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner
959f85e193739c953358c865005855253af4f68a497John McCall  switch (ValType.getObjCLifetime()) {
960f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_None:
961f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_ExplicitNone:
962f85e193739c953358c865005855253af4f68a497John McCall    // okay
963f85e193739c953358c865005855253af4f68a497John McCall    break;
964f85e193739c953358c865005855253af4f68a497John McCall
965f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_Weak:
966f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_Strong:
967f85e193739c953358c865005855253af4f68a497John McCall  case Qualifiers::OCL_Autoreleasing:
968b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis    Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
969f85e193739c953358c865005855253af4f68a497John McCall      << ValType << FirstArg->getSourceRange();
970f85e193739c953358c865005855253af4f68a497John McCall    return ExprError();
971f85e193739c953358c865005855253af4f68a497John McCall  }
972f85e193739c953358c865005855253af4f68a497John McCall
973b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall  // Strip any qualifiers off ValType.
974b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall  ValType = ValType.getUnqualifiedType();
975b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall
9768d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth  // The majority of builtins return a value, but a few have special return
9778d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth  // types, so allow them to override appropriately below.
9788d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth  QualType ResultType = ValType;
9798d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth
9805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // We need to figure out which concrete builtin this maps onto.  For example,
9815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // __sync_fetch_and_add with a 2 byte object turns into
9825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // __sync_fetch_and_add_2.
9835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \
9845caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \
9855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    Builtin::BI##x##_8, Builtin::BI##x##_16 }
9861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
9875caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  static const unsigned BuiltinIndices[][5] = {
9885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_add),
9895caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_sub),
9905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_or),
9915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_and),
9925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_fetch_and_xor),
9931eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
9945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_add_and_fetch),
9955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_sub_and_fetch),
9965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_and_and_fetch),
9975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_or_and_fetch),
9985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_xor_and_fetch),
9991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
10005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_val_compare_and_swap),
10015caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_bool_compare_and_swap),
10025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    BUILTIN_ROW(__sync_lock_test_and_set),
100323aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner    BUILTIN_ROW(__sync_lock_release),
100423aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner    BUILTIN_ROW(__sync_swap)
10055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  };
10061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW
10071eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
10085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Determine the index of the size.
10095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  unsigned SizeIndex;
1010199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck  switch (Context.getTypeSizeInChars(ValType).getQuantity()) {
10115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 1: SizeIndex = 0; break;
10125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 2: SizeIndex = 1; break;
10135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 4: SizeIndex = 2; break;
10145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 8: SizeIndex = 3; break;
10155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case 16: SizeIndex = 4; break;
10165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  default:
1017d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size)
1018d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << FirstArg->getType() << FirstArg->getSourceRange();
1019d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
10205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  }
10211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
10225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Each of these builtins has one pointer argument, followed by some number of
10235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // values (0, 1 or 2) followed by a potentially empty varags list of stuff
10245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // that we ignore.  Find out which row of BuiltinIndices to read from as well
10255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // as the number of fixed args.
10267814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor  unsigned BuiltinID = FDecl->getBuiltinID();
10275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  unsigned BuiltinIndex, NumFixed = 1;
10285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  switch (BuiltinID) {
1029b219cfc4d75f0a03630b7c4509ef791b7e97b2c8David Blaikie  default: llvm_unreachable("Unknown overloaded atomic builtin!");
1030a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add:
1031a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_1:
1032a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_2:
1033a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_4:
1034a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_8:
1035a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_add_16:
1036a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 0;
1037a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1038a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1039a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub:
1040a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_1:
1041a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_2:
1042a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_4:
1043a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_8:
1044a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_sub_16:
1045a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 1;
1046a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1047a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1048a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or:
1049a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_1:
1050a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_2:
1051a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_4:
1052a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_8:
1053a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_or_16:
1054a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 2;
1055a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1056a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1057a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and:
1058a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_1:
1059a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_2:
1060a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_4:
1061a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_8:
1062a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_and_16:
1063a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 3;
1064a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1065a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1066a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor:
1067a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_1:
1068a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_2:
1069a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_4:
1070a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_8:
1071a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_fetch_and_xor_16:
1072a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 4;
1073a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1074a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1075a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch:
1076a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_1:
1077a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_2:
1078a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_4:
1079a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_8:
1080a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_add_and_fetch_16:
1081a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 5;
1082a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1083a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1084a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch:
1085a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_1:
1086a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_2:
1087a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_4:
1088a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_8:
1089a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_sub_and_fetch_16:
1090a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 6;
1091a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1092a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1093a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch:
1094a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_1:
1095a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_2:
1096a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_4:
1097a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_8:
1098a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_and_and_fetch_16:
1099a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 7;
1100a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1101a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1102a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch:
1103a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_1:
1104a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_2:
1105a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_4:
1106a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_8:
1107a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_or_and_fetch_16:
1108a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 8;
1109a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1110a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1111a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch:
1112a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_1:
1113a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_2:
1114a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_4:
1115a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_8:
1116a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_xor_and_fetch_16:
1117a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 9;
1118a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
11191eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
11205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_val_compare_and_swap:
1121a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_1:
1122a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_2:
1123a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_4:
1124a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_8:
1125a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_val_compare_and_swap_16:
11267eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar    BuiltinIndex = 10;
11275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    NumFixed = 2;
11285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    break;
1129a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
11305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_bool_compare_and_swap:
1131a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_1:
1132a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_2:
1133a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_4:
1134a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_8:
1135a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_bool_compare_and_swap_16:
11367eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar    BuiltinIndex = 11;
11375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    NumFixed = 2;
11388d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth    ResultType = Context.BoolTy;
11395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    break;
1140a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1141a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set:
1142a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_1:
1143a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_2:
1144a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_4:
1145a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_8:
1146a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_test_and_set_16:
1147a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 12;
1148a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
1149a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
11505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  case Builtin::BI__sync_lock_release:
1151a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_1:
1152a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_2:
1153a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_4:
1154a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_8:
1155a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_lock_release_16:
11567eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar    BuiltinIndex = 13;
11575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    NumFixed = 0;
11588d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth    ResultType = Context.VoidTy;
11595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    break;
1160a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor
1161a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap:
1162a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_1:
1163a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_2:
1164a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_4:
1165a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_8:
1166a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor  case Builtin::BI__sync_swap_16:
1167a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    BuiltinIndex = 14;
1168a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor    break;
11695caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  }
11701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
11715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Now that we know how many fixed arguments we expect, first check that we
11725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // have at least that many.
1173d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  if (TheCall->getNumArgs() < 1+NumFixed) {
1174d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
1175d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << 0 << 1+NumFixed << TheCall->getNumArgs()
1176d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      << TheCall->getCallee()->getSourceRange();
1177d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth    return ExprError();
1178d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  }
11791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1180e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner  // Get the decl for the concrete builtin from this, we can tell what the
1181e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner  // concrete integer type we should convert to is.
1182e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner  unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex];
1183e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner  const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID);
1184e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner  IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName);
11851eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  FunctionDecl *NewBuiltinDecl =
1186e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner    cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID,
1187e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner                                           TUScope, false, DRE->getLocStart()));
1188d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth
1189f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall  // The first argument --- the pointer --- has a fixed type; we
1190f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall  // deduce the types of the rest of the arguments accordingly.  Walk
1191f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall  // the remaining arguments, converting them to the deduced value type.
11925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  for (unsigned i = 0; i != NumFixed; ++i) {
1193429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley    ExprResult Arg = TheCall->getArg(i+1);
11941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
11955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // GCC does an implicit conversion to the pointer or integer ValType.  This
11965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // can fail in some cases (1i -> int**), check for this error case now.
1197b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall    // Initialize the argument.
1198b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall    InitializedEntity Entity = InitializedEntity::InitializeParameter(Context,
1199b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall                                                   ValType, /*consume*/ false);
1200b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall    Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
1201429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley    if (Arg.isInvalid())
1202d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth      return ExprError();
12031eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
12045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // Okay, we have something that *can* be converted to the right type.  Check
12055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // to see if there is a potentially weird extension going on here.  This can
12065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // happen when you do an atomic operation on something like an char* and
12075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // pass in 42.  The 42 gets converted to char.  This is even more strange
12085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner    // for things like 45.123 -> char, etc.
12091eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump    // FIXME: Do this check.
1210b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall    TheCall->setArg(i+1, Arg.take());
12115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  }
12121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1213bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor  ASTContext& Context = this->getASTContext();
1214bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor
1215bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor  // Create a new DeclRefExpr to refer to the new decl.
1216bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor  DeclRefExpr* NewDRE = DeclRefExpr::Create(
1217bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      Context,
1218bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      DRE->getQualifierLoc(),
1219e4b92761b43ced611c417ae478568610f1ad7b1eAbramo Bagnara      SourceLocation(),
1220bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      NewBuiltinDecl,
1221f4b88a45902af1802a1cb42ba48b1c474474f228John McCall      /*enclosing*/ false,
1222bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      DRE->getLocation(),
1223bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      NewBuiltinDecl->getType(),
1224bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor      DRE->getValueKind());
12251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
12265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // Set the callee in the CallExpr.
12275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner  // FIXME: This leaks the original parens and implicit casts.
1228bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor  ExprResult PromotedCall = UsualUnaryConversions(NewDRE);
1229429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  if (PromotedCall.isInvalid())
1230429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley    return ExprError();
1231429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  TheCall->setCallee(PromotedCall.take());
12321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1233db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth  // Change the result type of the call to match the original value type. This
1234db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth  // is arbitrary, but the codegen for these builtins ins design to handle it
1235db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth  // gracefully.
12368d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth  TheCall->setType(ResultType);
1237d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth
1238d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth  return move(TheCallResult);
12395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner}
12405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner
1241690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin
124271993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct
1243fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would
1244fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend).
1245690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) {
124656f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner  Arg = Arg->IgnoreParenCasts();
124771993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson  StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
124871993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson
12495cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor  if (!Literal || !Literal->isAscii()) {
1250fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner    Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant)
1251fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner      << Arg->getSourceRange();
12529cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson    return true;
125371993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson  }
12541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
12557da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian  if (Literal->containsNonAsciiOrNull()) {
12565f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner    StringRef String = Literal->getString();
12577da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    unsigned NumBytes = String.size();
12585f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner    SmallVector<UTF16, 128> ToBuf(NumBytes);
12597da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    const UTF8 *FromPtr = (UTF8 *)String.data();
12607da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    UTF16 *ToPtr = &ToBuf[0];
12617da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian
12627da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes,
12637da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian                                                 &ToPtr, ToPtr + NumBytes,
12647da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian                                                 strictConversion);
12657da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    // Check for conversion failure.
12667da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian    if (Result != conversionOK)
12677da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian      Diag(Arg->getLocStart(),
12687da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian           diag::warn_cfstring_truncated) << Arg->getSourceRange();
12697da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian  }
12709cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson  return false;
127159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner}
127259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner
1273c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity.
1274c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success.
1275925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) {
1276925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  Expr *Fn = TheCall->getCallee();
1277925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  if (TheCall->getNumArgs() > 2) {
12782c21a073525cdfa68e4439b7af551385dc2796abChris Lattner    Diag(TheCall->getArg(2)->getLocStart(),
1279fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner         diag::err_typecheck_call_too_many_args)
1280ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher      << 0 /*function call*/ << 2 << TheCall->getNumArgs()
1281ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher      << Fn->getSourceRange()
12821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump      << SourceRange(TheCall->getArg(2)->getLocStart(),
1283fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                     (*(TheCall->arg_end()-1))->getLocEnd());
128430ce344307f8a8b00054021307015571f83c7364Chris Lattner    return true;
128530ce344307f8a8b00054021307015571f83c7364Chris Lattner  }
128656f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman
128756f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman  if (TheCall->getNumArgs() < 2) {
1288d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher    return Diag(TheCall->getLocEnd(),
1289d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      diag::err_typecheck_call_too_few_args_at_least)
1290d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      << 0 /*function call*/ << 2 << TheCall->getNumArgs();
129156f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman  }
129256f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman
12935f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  // Type-check the first argument normally.
12945f8d604246976a93a73549b07bbc8ee0b2061b50John McCall  if (checkBuiltinArgument(*this, TheCall, 0))
12955f8d604246976a93a73549b07bbc8ee0b2061b50John McCall    return true;
12965f8d604246976a93a73549b07bbc8ee0b2061b50John McCall
1297c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner  // Determine whether the current function is variadic or not.
12989ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor  BlockScopeInfo *CurBlock = getCurBlock();
1299c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner  bool isVariadic;
1300cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff  if (CurBlock)
1301c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall    isVariadic = CurBlock->TheDecl->isVariadic();
13029498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek  else if (FunctionDecl *FD = getCurFunctionDecl())
13039498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek    isVariadic = FD->isVariadic();
13049498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek  else
130553d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis    isVariadic = getCurMethodDecl()->isVariadic();
13061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1307c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner  if (!isVariadic) {
130830ce344307f8a8b00054021307015571f83c7364Chris Lattner    Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
130930ce344307f8a8b00054021307015571f83c7364Chris Lattner    return true;
131030ce344307f8a8b00054021307015571f83c7364Chris Lattner  }
13111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
131230ce344307f8a8b00054021307015571f83c7364Chris Lattner  // Verify that the second argument to the builtin is the last argument of the
131330ce344307f8a8b00054021307015571f83c7364Chris Lattner  // current function or method.
131430ce344307f8a8b00054021307015571f83c7364Chris Lattner  bool SecondArgIsLastNamedArgument = false;
1315e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson  const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts();
13161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
131788cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson  if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
131888cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson    if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
131930ce344307f8a8b00054021307015571f83c7364Chris Lattner      // FIXME: This isn't correct for methods (results in bogus warning).
132030ce344307f8a8b00054021307015571f83c7364Chris Lattner      // Get the last formal in the current function.
132188cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson      const ParmVarDecl *LastArg;
1322cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff      if (CurBlock)
1323cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff        LastArg = *(CurBlock->TheDecl->param_end()-1);
1324cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff      else if (FunctionDecl *FD = getCurFunctionDecl())
1325371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner        LastArg = *(FD->param_end()-1);
132630ce344307f8a8b00054021307015571f83c7364Chris Lattner      else
132753d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis        LastArg = *(getCurMethodDecl()->param_end()-1);
132830ce344307f8a8b00054021307015571f83c7364Chris Lattner      SecondArgIsLastNamedArgument = PV == LastArg;
132930ce344307f8a8b00054021307015571f83c7364Chris Lattner    }
133030ce344307f8a8b00054021307015571f83c7364Chris Lattner  }
13311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
133230ce344307f8a8b00054021307015571f83c7364Chris Lattner  if (!SecondArgIsLastNamedArgument)
13331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump    Diag(TheCall->getArg(1)->getLocStart(),
133430ce344307f8a8b00054021307015571f83c7364Chris Lattner         diag::warn_second_parameter_of_va_start_not_last_named_argument);
133530ce344307f8a8b00054021307015571f83c7364Chris Lattner  return false;
13366cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman}
133730ce344307f8a8b00054021307015571f83c7364Chris Lattner
13381b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and
13391b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends.  This is declared to take (...), so we have to check everything.
1340925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) {
1341925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  if (TheCall->getNumArgs() < 2)
13422c21a073525cdfa68e4439b7af551385dc2796abChris Lattner    return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
1343d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      << 0 << 2 << TheCall->getNumArgs()/*function call*/;
1344925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  if (TheCall->getNumArgs() > 2)
13451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump    return Diag(TheCall->getArg(2)->getLocStart(),
1346fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                diag::err_typecheck_call_too_many_args)
1347ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher      << 0 /*function call*/ << 2 << TheCall->getNumArgs()
1348fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner      << SourceRange(TheCall->getArg(2)->getLocStart(),
1349fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                     (*(TheCall->arg_end()-1))->getLocEnd());
13501eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1351429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  ExprResult OrigArg0 = TheCall->getArg(0);
1352429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  ExprResult OrigArg1 = TheCall->getArg(1);
1353cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor
13541b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  // Do standard promotions between the two arguments, returning their common
13551b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  // type.
1356925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner  QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false);
1357429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  if (OrigArg0.isInvalid() || OrigArg1.isInvalid())
1358429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley    return true;
1359403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar
1360403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar  // Make sure any conversions are pushed back into the call; this is
1361403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar  // type safe since unordered compare builtins are declared as "_Bool
1362403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar  // foo(...)".
1363429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  TheCall->setArg(0, OrigArg0.get());
1364429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  TheCall->setArg(1, OrigArg1.get());
13651eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1366429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley  if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent())
1367cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor    return false;
1368cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor
13691b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  // If the common type isn't a real floating type, then the arguments were
13701b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  // invalid for this operation.
1371860a319e62b0e256817a458396d191aa91c0787aEli Friedman  if (Res.isNull() || !Res->isRealFloatingType())
1372429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley    return Diag(OrigArg0.get()->getLocStart(),
1373fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                diag::err_typecheck_call_invalid_ordered_compare)
1374429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley      << OrigArg0.get()->getType() << OrigArg1.get()->getType()
1375429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley      << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd());
13761eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
13771b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner  return false;
13781b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner}
13791b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner
1380e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like
1381e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends.  This is declared to take (...), so we have
13823b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point
13833b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value.
13843b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) {
13853b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer  if (TheCall->getNumArgs() < NumArgs)
13869ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman    return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
1387d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      << 0 << NumArgs << TheCall->getNumArgs()/*function call*/;
13883b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer  if (TheCall->getNumArgs() > NumArgs)
13893b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer    return Diag(TheCall->getArg(NumArgs)->getLocStart(),
13909ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman                diag::err_typecheck_call_too_many_args)
1391ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher      << 0 /*function call*/ << NumArgs << TheCall->getNumArgs()
13923b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer      << SourceRange(TheCall->getArg(NumArgs)->getLocStart(),
13939ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman                     (*(TheCall->arg_end()-1))->getLocEnd());
13949ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman
13953b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer  Expr *OrigArg = TheCall->getArg(NumArgs-1);
13961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
13979ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  if (OrigArg->isTypeDependent())
13989ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman    return false;
13999ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman
140081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner  // This operation requires a non-_Complex floating-point number.
14019ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  if (!OrigArg->getType()->isRealFloatingType())
14021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump    return Diag(OrigArg->getLocStart(),
14039ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman                diag::err_typecheck_call_invalid_unary_fp)
14049ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman      << OrigArg->getType() << OrigArg->getSourceRange();
14051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
140681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner  // If this is an implicit conversion from float -> double, remove it.
140781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner  if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) {
140881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner    Expr *CastArg = Cast->getSubExpr();
140981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner    if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) {
141081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner      assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) &&
141181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner             "promotion from float to double is the only expected cast here");
141281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner      Cast->setSubExpr(0);
141381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner      TheCall->setArg(NumArgs-1, CastArg);
141481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner    }
141581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner  }
141681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner
14179ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman  return false;
14189ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman}
14199ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman
1420d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector.
1421d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything.
142260d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) {
142337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  if (TheCall->getNumArgs() < 2)
14240eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl    return ExprError(Diag(TheCall->getLocEnd(),
1425d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher                          diag::err_typecheck_call_too_few_args_at_least)
142637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman      << 0 /*function call*/ << 2 << TheCall->getNumArgs()
1427d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher      << TheCall->getSourceRange());
1428d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
142937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  // Determine which of the following types of shufflevector we're checking:
143037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  // 1) unary, vector mask: (lhs, mask)
143137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  // 2) binary, vector mask: (lhs, rhs, mask)
143237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  // 3) binary, scalar mask: (lhs, rhs, index, ..., index)
143337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  QualType resType = TheCall->getArg(0)->getType();
143437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman  unsigned numElements = 0;
143537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman
1436cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor  if (!TheCall->getArg(0)->isTypeDependent() &&
1437cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      !TheCall->getArg(1)->isTypeDependent()) {
143837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    QualType LHSType = TheCall->getArg(0)->getType();
143937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    QualType RHSType = TheCall->getArg(1)->getType();
144037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman
144137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    if (!LHSType->isVectorType() || !RHSType->isVectorType()) {
1442cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector)
14431eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump        << SourceRange(TheCall->getArg(0)->getLocStart(),
1444cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor                       TheCall->getArg(1)->getLocEnd());
1445cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      return ExprError();
1446cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor    }
144737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman
144837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    numElements = LHSType->getAs<VectorType>()->getNumElements();
144937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    unsigned numResElements = TheCall->getNumArgs() - 2;
145037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman
145137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    // Check to see if we have a call with 2 vector arguments, the unary shuffle
145237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    // with mask.  If so, verify that RHS is an integer vector type with the
145337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    // same number of elts as lhs.
145437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    if (TheCall->getNumArgs() == 2) {
1455f60946222721d9ba3c059563935c17b84703187aDouglas Gregor      if (!RHSType->hasIntegerRepresentation() ||
145637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman          RHSType->getAs<VectorType>()->getNumElements() != numElements)
145737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman        Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
145837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman          << SourceRange(TheCall->getArg(1)->getLocStart(),
145937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman                         TheCall->getArg(1)->getLocEnd());
146037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman      numResElements = numElements;
146137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    }
146237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) {
1463cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector)
14641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump        << SourceRange(TheCall->getArg(0)->getLocStart(),
1465cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor                       TheCall->getArg(1)->getLocEnd());
1466cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      return ExprError();
146737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    } else if (numElements != numResElements) {
146837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman      QualType eltType = LHSType->getAs<VectorType>()->getElementType();
1469788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner      resType = Context.getVectorType(eltType, numResElements,
1470e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson                                      VectorType::GenericVector);
1471cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor    }
1472d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  }
1473d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
1474d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  for (unsigned i = 2; i < TheCall->getNumArgs(); i++) {
1475cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor    if (TheCall->getArg(i)->isTypeDependent() ||
1476cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor        TheCall->getArg(i)->isValueDependent())
1477cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor      continue;
1478cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor
147937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    llvm::APSInt Result(32);
148037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman    if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context))
148137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman      return ExprError(Diag(TheCall->getLocStart(),
148237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman                  diag::err_shufflevector_nonconstant_argument)
148337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman                << TheCall->getArg(i)->getSourceRange());
14840eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl
1485d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner    if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2)
14860eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl      return ExprError(Diag(TheCall->getLocStart(),
1487fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner                  diag::err_shufflevector_argument_too_large)
14880eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl               << TheCall->getArg(i)->getSourceRange());
1489d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  }
1490d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
14915f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner  SmallVector<Expr*, 32> exprs;
1492d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
1493d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner  for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) {
1494d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman    exprs.push_back(TheCall->getArg(i));
1495d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman    TheCall->setArg(i, 0);
1496d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman  }
1497d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman
1498a88dc3079bedf70a5cfc39791727e43a10383006Nate Begeman  return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(),
149937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman                                            exprs.size(), resType,
15008189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek                                            TheCall->getCallee()->getLocStart(),
15018189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek                                            TheCall->getRParenLoc()));
1502d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman}
150330ce344307f8a8b00054021307015571f83c7364Chris Lattner
15044493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch.
15054493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two
15064493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args.
15074493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) {
1508fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner  unsigned NumArgs = TheCall->getNumArgs();
15094493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar
1510fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner  if (NumArgs > 3)
1511ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher    return Diag(TheCall->getLocEnd(),
1512ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher             diag::err_typecheck_call_too_many_args_at_most)
1513ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher             << 0 /*function call*/ << 3 << NumArgs
1514ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher             << TheCall->getSourceRange();
15154493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar
15164493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar  // Argument 0 is checked for us and the remaining arguments must be
15174493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar  // constant integers.
1518fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner  for (unsigned i = 1; i != NumArgs; ++i) {
15194493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    Expr *Arg = TheCall->getArg(i);
1520592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
1521592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor    // We can't check the value of a dependent argument.
1522592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor    if (Arg->isTypeDependent() || Arg->isValueDependent())
1523592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor      continue;
1524592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
15259aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman    llvm::APSInt Result;
1526691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher    if (SemaBuiltinConstantArg(TheCall, i, Result))
1527691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher      return true;
15281eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
15294493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    // FIXME: gcc issues a warning and rewrites these to 0. These
15304493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    // seems especially odd for the third argument since the default
15314493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    // is 3.
1532fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner    if (i == 1) {
15339aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman      if (Result.getLimitedValue() > 1)
1534fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner        return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
153521fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner             << "0" << "1" << Arg->getSourceRange();
15364493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    } else {
15379aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman      if (Result.getLimitedValue() > 3)
1538fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner        return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
153921fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner            << "0" << "3" << Arg->getSourceRange();
15404493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar    }
15414493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar  }
15424493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar
1543fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner  return false;
15444493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar}
15454493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar
1546691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr
1547691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression.
1548691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum,
1549691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher                                  llvm::APSInt &Result) {
1550691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  Expr *Arg = TheCall->getArg(ArgNum);
1551691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
1552691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
1553691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher
1554691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (Arg->isTypeDependent() || Arg->isValueDependent()) return false;
1555691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher
1556691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (!Arg->isIntegerConstantExpr(Result, Context))
1557691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher    return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type)
15585e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher                << FDecl->getDeclName() <<  Arg->getSourceRange();
1559691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher
156021fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner  return false;
156121fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner}
156221fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner
1563d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr,
1564d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined
1565d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3).
1566fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner// For compatibility check 0-3, llvm only handles 0 and 2.
1567d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) {
1568691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  llvm::APSInt Result;
1569592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
1570592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor  // We can't check the value of a dependent argument.
1571592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor  if (TheCall->getArg(1)->isTypeDependent() ||
1572592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor      TheCall->getArg(1)->isValueDependent())
1573592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor    return false;
1574592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor
1575691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  // Check constant-ness first.
1576691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (SemaBuiltinConstantArg(TheCall, 1, Result))
1577691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher    return true;
1578d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar
1579691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  Expr *Arg = TheCall->getArg(1);
1580d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar  if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) {
1581fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner    return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
1582fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner             << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
1583d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar  }
1584d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar
1585d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar  return false;
1586d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar}
1587d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar
1588586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val).
1589d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1.
1590d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) {
1591d875fed28578835de89cd407e9db4be788596d7cEli Friedman  Expr *Arg = TheCall->getArg(1);
1592691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  llvm::APSInt Result;
1593cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor
1594691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  // TODO: This is less than ideal. Overload this to take a value.
1595691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (SemaBuiltinConstantArg(TheCall, 1, Result))
1596691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher    return true;
1597691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher
1598691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher  if (Result != 1)
1599d875fed28578835de89cd407e9db4be788596d7cEli Friedman    return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val)
1600d875fed28578835de89cd407e9db4be788596d7cEli Friedman             << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
1601d875fed28578835de89cd407e9db4be788596d7cEli Friedman
1602d875fed28578835de89cd407e9db4be788596d7cEli Friedman  return false;
1603d875fed28578835de89cd407e9db4be788596d7cEli Friedman}
1604d875fed28578835de89cd407e9db4be788596d7cEli Friedman
1605831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determine if an expression is a string literal or constant string.
1606831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// If this function returns false on the arguments to a function expecting a
1607831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// format string, we will usually need to emit a warning.
1608831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// True string literals are then checked by CheckFormatString.
1609831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithSema::StringLiteralCheckType
1610831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithSema::checkFormatStringExpr(const Expr *E, Expr **Args,
1611831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                            unsigned NumArgs, bool HasVAListArg,
1612831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                            unsigned format_idx, unsigned firstDataArg,
1613831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                            FormatStringType Type, bool inFunctionCall) {
16144fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain:
1615cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor  if (E->isTypeDependent() || E->isValueDependent())
1616831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
1617d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
161834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  E = E->IgnoreParenCasts();
1619f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne
1620a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie  if (E->isNullPointerConstant(Context, Expr::NPC_ValueDependentIsNotNull))
1621a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie    // Technically -Wformat-nonliteral does not warn about this case.
1622a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie    // The behavior of printf and friends in this case is implementation
1623a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie    // dependent.  Ideally if the format string cannot be null then
1624a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie    // it should have a 'nonnull' attribute in the function prototype.
1625831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_CheckedLiteral;
1626a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie
1627d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  switch (E->getStmtClass()) {
162856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall  case Stmt::BinaryConditionalOperatorClass:
1629d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  case Stmt::ConditionalOperatorClass: {
1630831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    // The expression is a literal if both sub-expressions were, and it was
1631831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    // completely checked only if both sub-expressions were checked.
1632831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    const AbstractConditionalOperator *C =
1633831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        cast<AbstractConditionalOperator>(E);
1634831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    StringLiteralCheckType Left =
1635831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        checkFormatStringExpr(C->getTrueExpr(), Args, NumArgs,
1636831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                              HasVAListArg, format_idx, firstDataArg,
1637831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                              Type, inFunctionCall);
1638831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    if (Left == SLCT_NotALiteral)
1639831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      return SLCT_NotALiteral;
1640831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    StringLiteralCheckType Right =
1641831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        checkFormatStringExpr(C->getFalseExpr(), Args, NumArgs,
1642831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                              HasVAListArg, format_idx, firstDataArg,
1643831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                              Type, inFunctionCall);
1644831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return Left < Right ? Left : Right;
1645d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  }
1646d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
1647d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  case Stmt::ImplicitCastExprClass: {
16484fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek    E = cast<ImplicitCastExpr>(E)->getSubExpr();
16494fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek    goto tryAgain;
1650d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  }
1651d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
165256ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall  case Stmt::OpaqueValueExprClass:
165356ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall    if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) {
165456ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall      E = src;
165556ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall      goto tryAgain;
165656ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall    }
1657831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
165856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall
1659b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek  case Stmt::PredefinedExprClass:
1660b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek    // While __func__, etc., are technically not string literals, they
1661b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek    // cannot contain format specifiers and thus are not a security
1662b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek    // liability.
1663831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_UncheckedLiteral;
1664b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek
1665082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  case Stmt::DeclRefExprClass: {
1666082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    const DeclRefExpr *DR = cast<DeclRefExpr>(E);
16671eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1668082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    // As an exception, do not flag errors for variables binding to
1669082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    // const string literals.
1670082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
1671082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      bool isConstant = false;
1672082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      QualType T = DR->getType();
1673082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek
1674082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      if (const ArrayType *AT = Context.getAsArrayType(T)) {
1675082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek        isConstant = AT->getElementType().isConstant(Context);
1676ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump      } else if (const PointerType *PT = T->getAs<PointerType>()) {
16771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump        isConstant = T.isConstant(Context) &&
1678082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek                     PT->getPointeeType().isConstant(Context);
1679e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas      } else if (T->isObjCObjectPointerType()) {
1680e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas        // In ObjC, there is usually no "const ObjectPointer" type,
1681e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas        // so don't check if the pointee type is constant.
1682e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas        isConstant = T.isConstant(Context);
1683082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      }
16841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1685082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      if (isConstant) {
1686e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay        if (const Expr *Init = VD->getAnyInitializer()) {
1687e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay          // Look through initializers like const char c[] = { "foo" }
1688e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay          if (const InitListExpr *InitList = dyn_cast<InitListExpr>(Init)) {
1689e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay            if (InitList->isStringLiteralInit())
1690e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay              Init = InitList->getInit(0)->IgnoreParenImpCasts();
1691e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay          }
1692831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          return checkFormatStringExpr(Init, Args, NumArgs,
1693831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                       HasVAListArg, format_idx,
1694831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                       firstDataArg, Type,
1695831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                       /*inFunctionCall*/false);
1696e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay        }
1697082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      }
16981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1699d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // For vprintf* functions (i.e., HasVAListArg==true), we add a
1700d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // special check to see if the format string is a function parameter
1701d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // of the function calling the printf function.  If the function
1702d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // has an attribute indicating it is a printf-like function, then we
1703d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // should suppress warnings concerning non-literals being used in a call
1704d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // to a vprintf function.  For example:
1705d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //
1706d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // void
1707d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){
1708d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //      va_list ap;
1709d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //      va_start(ap, fmt);
1710d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //      vprintf(fmt, ap);  // Do NOT emit a warning about "fmt".
1711d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //      ...
1712d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson      //
1713f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas      if (HasVAListArg) {
1714f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas        if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(VD)) {
1715f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas          if (const NamedDecl *ND = dyn_cast<NamedDecl>(PV->getDeclContext())) {
1716f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas            int PVIndex = PV->getFunctionScopeIndex() + 1;
1717f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas            for (specific_attr_iterator<FormatAttr>
1718f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                 i = ND->specific_attr_begin<FormatAttr>(),
1719f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                 e = ND->specific_attr_end<FormatAttr>(); i != e ; ++i) {
1720f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              FormatAttr *PVFormat = *i;
1721f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              // adjust for implicit parameter
1722f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND))
1723f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                if (MD->isInstance())
1724f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                  ++PVIndex;
1725f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              // We also check if the formats are compatible.
1726f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              // We can't pass a 'scanf' string to a 'printf' function.
1727f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas              if (PVIndex == PVFormat->getFormatIdx() &&
1728f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas                  Type == GetFormatStringType(PVFormat))
1729831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                return SLCT_UncheckedLiteral;
1730f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas            }
1731f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas          }
1732f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas        }
1733f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas      }
1734082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    }
17351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1736831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
1737082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  }
1738d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
173952aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas  case Stmt::CallExprClass:
174052aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas  case Stmt::CXXMemberCallExprClass: {
17418f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson    const CallExpr *CE = cast<CallExpr>(E);
174252aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas    if (const NamedDecl *ND = dyn_cast_or_null<NamedDecl>(CE->getCalleeDecl())) {
174352aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas      if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) {
174452aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas        unsigned ArgIndex = FA->getFormatIdx();
174552aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas        if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND))
174652aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas          if (MD->isInstance())
174752aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas            --ArgIndex;
174852aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas        const Expr *Arg = CE->getArg(ArgIndex - 1);
174952aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas
1750831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        return checkFormatStringExpr(Arg, Args, NumArgs,
1751831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                     HasVAListArg, format_idx, firstDataArg,
1752831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                     Type, inFunctionCall);
175350687314f87b67073c202fe46d84d12fb55e25cfJordan Rose      } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(ND)) {
175450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose        unsigned BuiltinID = FD->getBuiltinID();
175550687314f87b67073c202fe46d84d12fb55e25cfJordan Rose        if (BuiltinID == Builtin::BI__builtin___CFStringMakeConstantString ||
175650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose            BuiltinID == Builtin::BI__builtin___NSStringMakeConstantString) {
175750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose          const Expr *Arg = CE->getArg(0);
1758831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          return checkFormatStringExpr(Arg, Args, NumArgs,
1759831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                       HasVAListArg, format_idx,
1760831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                       firstDataArg, Type, inFunctionCall);
176150687314f87b67073c202fe46d84d12fb55e25cfJordan Rose        }
17628f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson      }
17638f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson    }
17641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1765831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
17668f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson  }
1767082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  case Stmt::ObjCStringLiteralClass:
1768082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  case Stmt::StringLiteralClass: {
1769082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    const StringLiteral *StrE = NULL;
17701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1771082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek    if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E))
1772d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek      StrE = ObjCFExpr->getString();
1773d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek    else
1774082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek      StrE = cast<StringLiteral>(E);
17751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1776d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek    if (StrE) {
177729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas      CheckFormatString(StrE, E, Args, NumArgs, HasVAListArg, format_idx,
177834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas                        firstDataArg, Type, inFunctionCall);
1779831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      return SLCT_CheckedLiteral;
1780d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek    }
17811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1782831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
1783d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  }
17841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
1785082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek  default:
1786831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return SLCT_NotALiteral;
1787d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek  }
1788d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek}
1789d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
1790e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid
17911eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull,
1792909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky                            const Expr * const *ExprArgs,
1793909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky                            SourceLocation CallSiteLoc) {
1794cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt  for (NonNullAttr::args_iterator i = NonNull->args_begin(),
1795cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt                                  e = NonNull->args_end();
1796e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian       i != e; ++i) {
1797909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky    const Expr *ArgExpr = ExprArgs[*i];
17984e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek    if (ArgExpr->isNullPointerConstant(Context,
1799ce94049b69f75b44c18584fe79cd238978b6b0d5Douglas Gregor                                       Expr::NPC_ValueDependentIsNotNull))
1800909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky      Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange();
1801e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian  }
1802e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian}
1803d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
180434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel DupasSema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) {
180534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  return llvm::StringSwitch<FormatStringType>(Format->getType())
180634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Case("scanf", FST_Scanf)
180734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Cases("printf", "printf0", FST_Printf)
180834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Cases("NSString", "CFString", FST_NSString)
180934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Case("strftime", FST_Strftime)
181034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Case("strfmon", FST_Strfmon)
181134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf)
181234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  .Default(FST_Unknown);
181334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas}
181434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas
1815826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar
1816826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings.
1817831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true if a format string has been fully checked.
1818831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFormatArguments(const FormatAttr *Format, CallExpr *TheCall) {
1819831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  bool IsCXXMember = isa<CXXMemberCallExpr>(TheCall);
1820831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return CheckFormatArguments(Format, TheCall->getArgs(),
1821831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                              TheCall->getNumArgs(),
1822831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                              IsCXXMember, TheCall->getRParenLoc(),
1823831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                              TheCall->getCallee()->getSourceRange());
182429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas}
182529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas
1826831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFormatArguments(const FormatAttr *Format, Expr **Args,
182729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                                unsigned NumArgs, bool IsCXXMember,
182829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                                SourceLocation Loc, SourceRange Range) {
1829831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  FormatStringInfo FSI;
1830831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (getFormatStringInfo(Format, IsCXXMember, &FSI))
1831831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return CheckFormatArguments(Args, NumArgs, FSI.HasVAListArg, FSI.FormatIdx,
1832831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                FSI.FirstDataArg, GetFormatStringType(Format),
1833831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                Loc, Range);
1834831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return false;
183529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas}
18364a2614e94672c47395abcde60518776fbebec589Sebastian Redl
1837831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFormatArguments(Expr **Args, unsigned NumArgs,
183834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas                                bool HasVAListArg, unsigned format_idx,
183934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas                                unsigned firstDataArg, FormatStringType Type,
184034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas                                SourceLocation Loc, SourceRange Range) {
1841826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  // CHECK: printf/scanf-like function is called with no format string.
184229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  if (format_idx >= NumArgs) {
184329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas    Diag(Loc, diag::warn_missing_format_string) << Range;
1844831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return false;
184571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  }
18461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
184729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts();
18481eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
184959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner  // CHECK: format string is not a string literal.
18501eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  //
185171895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // Dynamically generated format strings are difficult to
185271895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // automatically vet at compile time.  Requiring that format strings
185371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // are string literals: (1) permits the checking of format strings by
185471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // the compiler and thereby (2) can practically remove the source of
185571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek  // many format string exploits.
18567ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek
18571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  // Format string can be either ObjC string (e.g. @"%d") or
18587ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek  // C string (e.g. "%d")
18591eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  // ObjC string uses the same format specifiers as C string, so we can use
18607ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek  // the same format string checking logic for both ObjC and C strings.
1861831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  StringLiteralCheckType CT =
1862831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      checkFormatStringExpr(OrigFormatExpr, Args, NumArgs, HasVAListArg,
1863831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                            format_idx, firstDataArg, Type);
1864831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (CT != SLCT_NotALiteral)
1865831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    // Literal format string found, check done!
1866831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return CT == SLCT_CheckedLiteral;
18671cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner
18682837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas  // Strftime is particular as it always uses a single 'time' argument,
18692837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas  // so it is safe to pass a non-literal string.
18702837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas  if (Type == FST_Strftime)
1871831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return false;
18722837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas
1873ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas  // Do not emit diag when the string param is a macro expansion and the
1874ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas  // format is either NSString or CFString. This is a hack to prevent
1875ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas  // diag when using the NSLocalizedString and CFCopyLocalizedString macros
1876ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas  // which are usually used in place of NS and CF string literals.
1877dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas  if (Type == FST_NSString &&
1878dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas      SourceMgr.isInSystemMacro(Args[format_idx]->getLocStart()))
1879831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return false;
1880ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas
1881655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner  // If there are no arguments specified, warn with -Wformat-security, otherwise
1882655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner  // warn only with -Wformat-nonliteral.
188329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  if (NumArgs == format_idx+1)
188429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas    Diag(Args[format_idx]->getLocStart(),
1885826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek         diag::warn_format_nonliteral_noargs)
1886655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner      << OrigFormatExpr->getSourceRange();
1887655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner  else
188829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas    Diag(Args[format_idx]->getLocStart(),
1889826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek         diag::warn_format_nonliteral)
1890655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner           << OrigFormatExpr->getSourceRange();
1891831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return false;
1892d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek}
1893d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek
1894e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace {
1895826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler {
1896826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected:
1897e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  Sema &S;
1898e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  const StringLiteral *FExpr;
1899e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  const Expr *OrigFormatExpr;
19006ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek  const unsigned FirstDataArg;
1901e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  const unsigned NumDataArgs;
1902e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  const char *Beg; // Start of format string.
19030d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  const bool HasVAListArg;
190429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  const Expr * const *Args;
190529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  const unsigned NumArgs;
19060d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  unsigned FormatIdx;
19077f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  llvm::BitVector CoveredArgs;
1908efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  bool usesPositionalArgs;
1909efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  bool atFirstArg;
191055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  bool inFunctionCall;
19114e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic:
1912826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  CheckFormatHandler(Sema &s, const StringLiteral *fexpr,
19136ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek                     const Expr *origFormatExpr, unsigned firstDataArg,
191450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                     unsigned numDataArgs, const char *beg, bool hasVAListArg,
191529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                     Expr **args, unsigned numArgs,
191629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                     unsigned formatIdx, bool inFunctionCall)
1917e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek    : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr),
191850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose      FirstDataArg(firstDataArg), NumDataArgs(numDataArgs),
191950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose      Beg(beg), HasVAListArg(hasVAListArg),
192029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas      Args(args), NumArgs(numArgs), FormatIdx(formatIdx),
192155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      usesPositionalArgs(false), atFirstArg(true),
192255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      inFunctionCall(inFunctionCall) {
19237f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek        CoveredArgs.resize(numDataArgs);
19247f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek        CoveredArgs.reset();
19257f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      }
19264e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
192707d161f38e708a91486bf1c031d525faebbb249dTed Kremenek  void DoneProcessing();
19284e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
1929826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  void HandleIncompleteSpecifier(const char *startSpecifier,
1930826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                 unsigned specifierLen);
193176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
193276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg  void HandleNonStandardLengthModifier(
193376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg      const analyze_format_string::LengthModifier &LM,
193476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg      const char *startSpecifier, unsigned specifierLen);
193576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
193676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg  void HandleNonStandardConversionSpecifier(
193776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg      const analyze_format_string::ConversionSpecifier &CS,
193876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg      const char *startSpecifier, unsigned specifierLen);
193976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
194076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg  void HandleNonStandardConversionSpecification(
194176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg      const analyze_format_string::LengthModifier &LM,
194276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg      const analyze_format_string::ConversionSpecifier &CS,
194376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg      const char *startSpecifier, unsigned specifierLen);
194476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
1945f85626453123f9691bcef13cff963f556e209c27Hans Wennborg  virtual void HandlePosition(const char *startPos, unsigned posLen);
1946f85626453123f9691bcef13cff963f556e209c27Hans Wennborg
1947efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  virtual void HandleInvalidPosition(const char *startSpecifier,
1948efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek                                     unsigned specifierLen,
1949826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                     analyze_format_string::PositionContext p);
1950efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
1951efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  virtual void HandleZeroPosition(const char *startPos, unsigned posLen);
1952efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
1953e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  void HandleNullChar(const char *nullCharacter);
19544e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
195555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  template <typename Range>
195655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  static void EmitFormatDiagnostic(Sema &S, bool inFunctionCall,
195755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                   const Expr *ArgumentExpr,
195855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                   PartialDiagnostic PDiag,
195955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                   SourceLocation StringLoc,
196055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                   bool IsStringLocation, Range StringRange,
196155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                   FixItHint Fixit = FixItHint());
196255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
1963826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected:
1964c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc,
1965c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        const char *startSpec,
1966c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        unsigned specifierLen,
1967c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        const char *csStart, unsigned csLen);
196855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
196955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  void HandlePositionalNonpositionalArgs(SourceLocation Loc,
197055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                         const char *startSpec,
197155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                         unsigned specifierLen);
1972c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
1973f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek  SourceRange getFormatStringRange();
1974826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  CharSourceRange getSpecifierRange(const char *startSpecifier,
1975826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                    unsigned specifierLen);
1976e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  SourceLocation getLocationOfByte(const char *x);
19774e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
19780d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  const Expr *getDataArg(unsigned i) const;
1979666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek
1980666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS,
1981666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek                    const analyze_format_string::ConversionSpecifier &CS,
1982666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek                    const char *startSpecifier, unsigned specifierLen,
1983666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek                    unsigned argIndex);
198455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
198555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  template <typename Range>
198655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc,
198755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                            bool IsStringLocation, Range StringRange,
198855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                            FixItHint Fixit = FixItHint());
198955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
199055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  void CheckPositionalAndNonpositionalArgs(
199155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      const analyze_format_string::FormatSpecifier *FS);
1992e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek};
1993e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}
1994e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
1995826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() {
1996e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  return OrigFormatExpr->getSourceRange();
1997e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}
1998e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
1999826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler::
2000826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) {
200145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  SourceLocation Start = getLocationOfByte(startSpecifier);
200245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  SourceLocation End   = getLocationOfByte(startSpecifier + specifierLen - 1);
200345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care
200445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  // Advance the end SourceLocation by one due to half-open ranges.
2005a64ccefdf0ea4e03ec88805d71b0af74950c7472Argyrios Kyrtzidis  End = End.getLocWithOffset(1);
200645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care
200745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  return CharSourceRange::getCharRange(Start, End);
2008f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek}
2009f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek
2010826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) {
20114e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek  return S.getLocationOfStringLiteralByte(FExpr, x - Beg);
2012e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}
2013e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2014826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier,
2015826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                                   unsigned specifierLen){
201655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier),
201755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(startSpecifier),
201855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       /*IsStringLocation*/true,
201955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpecifier, specifierLen));
2020808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek}
2021808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek
202276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardLengthModifier(
202376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    const analyze_format_string::LengthModifier &LM,
202476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    const char *startSpecifier, unsigned specifierLen) {
202576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg  EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) << LM.toString()
2026f85626453123f9691bcef13cff963f556e209c27Hans Wennborg                       << 0,
202776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg                       getLocationOfByte(LM.getStart()),
202876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg                       /*IsStringLocation*/true,
202976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg                       getSpecifierRange(startSpecifier, specifierLen));
203076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg}
203176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
203276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardConversionSpecifier(
203376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    const analyze_format_string::ConversionSpecifier &CS,
203476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    const char *startSpecifier, unsigned specifierLen) {
203576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg  EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) << CS.toString()
2036f85626453123f9691bcef13cff963f556e209c27Hans Wennborg                       << 1,
203776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg                       getLocationOfByte(CS.getStart()),
203876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg                       /*IsStringLocation*/true,
203976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg                       getSpecifierRange(startSpecifier, specifierLen));
204076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg}
204176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
204276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardConversionSpecification(
204376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    const analyze_format_string::LengthModifier &LM,
204476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    const analyze_format_string::ConversionSpecifier &CS,
204576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    const char *startSpecifier, unsigned specifierLen) {
204676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg  EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_conversion_spec)
204776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg                       << LM.toString() << CS.toString(),
204876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg                       getLocationOfByte(LM.getStart()),
204976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg                       /*IsStringLocation*/true,
205076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg                       getSpecifierRange(startSpecifier, specifierLen));
205176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg}
205276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
2053f85626453123f9691bcef13cff963f556e209c27Hans Wennborgvoid CheckFormatHandler::HandlePosition(const char *startPos,
2054f85626453123f9691bcef13cff963f556e209c27Hans Wennborg                                        unsigned posLen) {
2055f85626453123f9691bcef13cff963f556e209c27Hans Wennborg  EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_positional_arg),
2056f85626453123f9691bcef13cff963f556e209c27Hans Wennborg                               getLocationOfByte(startPos),
2057f85626453123f9691bcef13cff963f556e209c27Hans Wennborg                               /*IsStringLocation*/true,
2058f85626453123f9691bcef13cff963f556e209c27Hans Wennborg                               getSpecifierRange(startPos, posLen));
2059f85626453123f9691bcef13cff963f556e209c27Hans Wennborg}
2060f85626453123f9691bcef13cff963f556e209c27Hans Wennborg
2061efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid
2062826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen,
2063826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                     analyze_format_string::PositionContext p) {
206455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier)
206555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << (unsigned) p,
206655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(startPos), /*IsStringLocation*/true,
206755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startPos, posLen));
2068efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek}
2069efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
2070826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos,
2071efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek                                            unsigned posLen) {
207255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier),
207355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               getLocationOfByte(startPos),
207455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               /*IsStringLocation*/true,
207555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               getSpecifierRange(startPos, posLen));
2076efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek}
2077efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
2078826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) {
207950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose  if (!isa<ObjCStringLiteral>(OrigFormatExpr)) {
20800c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek    // The presence of a null character is likely an error.
208155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    EmitFormatDiagnostic(
208255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      S.PDiag(diag::warn_printf_format_string_contains_null_char),
208355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      getLocationOfByte(nullCharacter), /*IsStringLocation*/true,
208455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      getFormatStringRange());
20850c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek  }
2086826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
2087826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2088826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const {
208929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  return Args[FirstDataArg + i];
2090826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
20914e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2092826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() {
2093826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    // Does the number of data arguments exceed the number of
2094826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    // format conversions in the format string?
2095826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (!HasVAListArg) {
2096826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      // Find any arguments that weren't covered.
2097826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    CoveredArgs.flip();
2098826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    signed notCoveredArg = CoveredArgs.find_first();
2099826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    if (notCoveredArg >= 0) {
2100826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      assert((unsigned)notCoveredArg < NumDataArgs);
2101c03f2df2a2b097bf2686bf32411d5022323988b2Bob Wilson      SourceLocation Loc = getDataArg((unsigned) notCoveredArg)->getLocStart();
2102c03f2df2a2b097bf2686bf32411d5022323988b2Bob Wilson      if (!S.getSourceManager().isInSystemMacro(Loc)) {
2103c03f2df2a2b097bf2686bf32411d5022323988b2Bob Wilson        EmitFormatDiagnostic(S.PDiag(diag::warn_printf_data_arg_not_used),
2104c03f2df2a2b097bf2686bf32411d5022323988b2Bob Wilson                             Loc,
2105c03f2df2a2b097bf2686bf32411d5022323988b2Bob Wilson                             /*IsStringLocation*/false, getFormatStringRange());
2106c03f2df2a2b097bf2686bf32411d5022323988b2Bob Wilson      }
2107826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    }
2108826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  }
2109826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
2110826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2111c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool
2112c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex,
2113c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     SourceLocation Loc,
2114c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     const char *startSpec,
2115c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     unsigned specifierLen,
2116c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     const char *csStart,
2117c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                                     unsigned csLen) {
2118c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2119c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  bool keepGoing = true;
2120c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  if (argIndex < NumDataArgs) {
2121c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // Consider the argument coverered, even though the specifier doesn't
2122c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // make sense.
2123c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    CoveredArgs.set(argIndex);
2124c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  }
2125c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  else {
2126c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // If argIndex exceeds the number of data arguments we
2127c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // don't issue a warning because that is just a cascade of warnings (and
2128c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // they may have intended '%%' anyway). We don't want to continue processing
2129c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // the format string after this point, however, as we will like just get
2130c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    // gibberish when trying to match arguments.
2131c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    keepGoing = false;
2132c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  }
2133c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
213455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_conversion)
213555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << StringRef(csStart, csLen),
213655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       Loc, /*IsStringLocation*/true,
213755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpec, specifierLen));
2138c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2139c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  return keepGoing;
2140c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek}
2141c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
214255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid
214355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard TrieuCheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc,
214455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                                      const char *startSpec,
214555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                                      unsigned specifierLen) {
214655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(
214755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    S.PDiag(diag::warn_format_mix_positional_nonpositional_args),
214855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen));
214955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu}
215055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
2151666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool
2152666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs(
2153666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  const analyze_format_string::FormatSpecifier &FS,
2154666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  const analyze_format_string::ConversionSpecifier &CS,
2155666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  const char *startSpecifier, unsigned specifierLen, unsigned argIndex) {
2156666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek
2157666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  if (argIndex >= NumDataArgs) {
215855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    PartialDiagnostic PDiag = FS.usesPositionalArg()
215955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args)
216055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu           << (argIndex+1) << NumDataArgs)
216155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      : S.PDiag(diag::warn_printf_insufficient_data_args);
216255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    EmitFormatDiagnostic(
216355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true,
216455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      getSpecifierRange(startSpecifier, specifierLen));
2165666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek    return false;
2166666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  }
2167666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  return true;
2168666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek}
2169666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek
217055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range>
217155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag,
217255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              SourceLocation Loc,
217355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              bool IsStringLocation,
217455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              Range StringRange,
217555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              FixItHint FixIt) {
217629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag,
217755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       Loc, IsStringLocation, StringRange, FixIt);
217855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu}
217955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
218055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \brief If the format string is not within the funcion call, emit a note
218155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// so that the function call and string are in diagnostic messages.
218255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
218355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param inFunctionCall if true, the format string is within the function
218455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// call and only one diagnostic message will be produced.  Otherwise, an
218555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// extra note will be emitted pointing to location of the format string.
218655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
218755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param ArgumentExpr the expression that is passed as the format string
218855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// argument in the function call.  Used for getting locations when two
218955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostics are emitted.
219055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
219155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param PDiag the callee should already have provided any strings for the
219255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostic message.  This function only adds locations and fixits
219355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// to diagnostics.
219455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
219555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param Loc primary location for diagnostic.  If two diagnostics are
219655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// required, one will be at Loc and a new SourceLocation will be created for
219755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// the other one.
219855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
219955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param IsStringLocation if true, Loc points to the format string should be
220055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// used for the note.  Otherwise, Loc points to the argument list and will
220155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// be used with PDiag.
220255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
220355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param StringRange some or all of the string to highlight.  This is
220455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// templated so it can accept either a CharSourceRange or a SourceRange.
220555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu///
220655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param Fixit optional fix it hint for the format string.
220755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range>
220855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(Sema &S, bool InFunctionCall,
220955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              const Expr *ArgumentExpr,
221055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              PartialDiagnostic PDiag,
221155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              SourceLocation Loc,
221255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              bool IsStringLocation,
221355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              Range StringRange,
221455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                              FixItHint FixIt) {
221555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  if (InFunctionCall)
221655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    S.Diag(Loc, PDiag) << StringRange << FixIt;
221755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  else {
221855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag)
221955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      << ArgumentExpr->getSourceRange();
222055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    S.Diag(IsStringLocation ? Loc : StringRange.getBegin(),
222155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu           diag::note_format_string_defined)
222255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      << StringRange << FixIt;
222355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  }
222455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu}
222555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
2226826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===//
2227826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2228826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace {
2229826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler {
223050687314f87b67073c202fe46d84d12fb55e25cfJordan Rose  bool ObjCContext;
2231826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic:
2232826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  CheckPrintfHandler(Sema &s, const StringLiteral *fexpr,
2233826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                     const Expr *origFormatExpr, unsigned firstDataArg,
223450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                     unsigned numDataArgs, bool isObjC,
2235826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                     const char *beg, bool hasVAListArg,
223629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                     Expr **Args, unsigned NumArgs,
223729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                     unsigned formatIdx, bool inFunctionCall)
2238826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
223950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                       numDataArgs, beg, hasVAListArg, Args, NumArgs,
224050687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                       formatIdx, inFunctionCall), ObjCContext(isObjC) {}
2241826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2242826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2243826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  bool HandleInvalidPrintfConversionSpecifier(
2244826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const analyze_printf::PrintfSpecifier &FS,
2245826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const char *startSpecifier,
2246826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      unsigned specifierLen);
2247826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2248826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS,
2249826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                             const char *startSpecifier,
2250826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                             unsigned specifierLen);
2251831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  bool checkFormatExpr(const analyze_printf::PrintfSpecifier &FS,
2252831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                       const char *StartSpecifier,
2253831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                       unsigned SpecifierLen,
2254831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                       const Expr *E);
2255831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2256826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k,
2257826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                    const char *startSpecifier, unsigned specifierLen);
2258826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS,
2259826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                           const analyze_printf::OptionalAmount &Amt,
2260826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                           unsigned type,
2261826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                           const char *startSpecifier, unsigned specifierLen);
2262826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  void HandleFlag(const analyze_printf::PrintfSpecifier &FS,
2263826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                  const analyze_printf::OptionalFlag &flag,
2264826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                  const char *startSpecifier, unsigned specifierLen);
2265826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS,
2266826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                         const analyze_printf::OptionalFlag &ignoredFlag,
2267826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                         const analyze_printf::OptionalFlag &flag,
2268826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                         const char *startSpecifier, unsigned specifierLen);
2269831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  bool checkForCStrMembers(const analyze_printf::ArgTypeResult &ATR,
2270831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                           const Expr *E, const CharSourceRange &CSR);
2271831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2272826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek};
2273826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
2274826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2275826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier(
2276826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const analyze_printf::PrintfSpecifier &FS,
2277826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const char *startSpecifier,
2278826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      unsigned specifierLen) {
22796ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const analyze_printf::PrintfConversionSpecifier &CS =
2280c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    FS.getConversionSpecifier();
2281826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2282c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  return HandleInvalidConversionSpecifier(FS.getArgIndex(),
2283c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          getLocationOfByte(CS.getStart()),
2284c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          startSpecifier, specifierLen,
2285c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          CS.getStart(), CS.getLength());
228626ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek}
228726ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek
2288826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount(
2289826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                               const analyze_format_string::OptionalAmount &Amt,
2290826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                               unsigned k, const char *startSpecifier,
2291826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                               unsigned specifierLen) {
22920d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek
22930d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  if (Amt.hasDataArgument()) {
22940d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek    if (!HasVAListArg) {
22957f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      unsigned argIndex = Amt.getArgIndex();
22967f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      if (argIndex >= NumDataArgs) {
229755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu        EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg)
229855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               << k,
229955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             getLocationOfByte(Amt.getStart()),
230055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             /*IsStringLocation*/true,
230155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             getSpecifierRange(startSpecifier, specifierLen));
23020d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        // Don't do any more checking.  We will just emit
23030d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        // spurious errors.
23040d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        return false;
23050d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek      }
23064e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
23070d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek      // Type check the data argument.  It should be an 'int'.
230831f8e32788adb299acad455363eb7fd244642c82Ted Kremenek      // Although not in conformance with C99, we also allow the argument to be
230931f8e32788adb299acad455363eb7fd244642c82Ted Kremenek      // an 'unsigned int' as that is a reasonably safe case.  GCC also
231031f8e32788adb299acad455363eb7fd244642c82Ted Kremenek      // doesn't emit a warning for that case.
23117f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      CoveredArgs.set(argIndex);
23127f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek      const Expr *Arg = getDataArg(argIndex);
23130d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek      QualType T = Arg->getType();
23144e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
23154e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek      const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context);
23164e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek      assert(ATR.isValid());
23174e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
23184e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek      if (!ATR.matchesType(S.Context, T)) {
231955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu        EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type)
2320a792aff1c7de253b89c473fdb7eef4a5bba83aecHans Wennborg                               << k << ATR.getRepresentativeTypeName(S.Context)
232155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                               << T << Arg->getSourceRange(),
232255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             getLocationOfByte(Amt.getStart()),
232355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             /*IsStringLocation*/true,
232455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                             getSpecifierRange(startSpecifier, specifierLen));
23250d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        // Don't do any more checking.  We will just emit
23260d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        // spurious errors.
23270d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek        return false;
23280d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek      }
23290d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek    }
23300d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  }
23310d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  return true;
23320d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek}
23330d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek
2334e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount(
2335826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                      const analyze_printf::PrintfSpecifier &FS,
2336e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                      const analyze_printf::OptionalAmount &Amt,
2337e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                      unsigned type,
2338e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                      const char *startSpecifier,
2339e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                      unsigned specifierLen) {
23406ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const analyze_printf::PrintfConversionSpecifier &CS =
23416ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek    FS.getConversionSpecifier();
2342e4ee9663168dfb2b4122c768091e30217328c9faTom Care
234355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  FixItHint fixit =
234455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant
234555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(),
234655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                 Amt.getConstantLength()))
234755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      : FixItHint();
234855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu
234955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount)
235055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << type << CS.toString(),
235155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(Amt.getStart()),
235255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       /*IsStringLocation*/true,
235355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpecifier, specifierLen),
235455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       fixit);
2355e4ee9663168dfb2b4122c768091e30217328c9faTom Care}
2356e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2357826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS,
2358e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                    const analyze_printf::OptionalFlag &flag,
2359e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                    const char *startSpecifier,
2360e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                    unsigned specifierLen) {
2361e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Warn about pointless flag with a fixit removal.
23626ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const analyze_printf::PrintfConversionSpecifier &CS =
23636ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek    FS.getConversionSpecifier();
236455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag)
236555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << flag.toString() << CS.toString(),
236655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(flag.getPosition()),
236755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       /*IsStringLocation*/true,
236855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpecifier, specifierLen),
236955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       FixItHint::CreateRemoval(
237055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         getSpecifierRange(flag.getPosition(), 1)));
2371e4ee9663168dfb2b4122c768091e30217328c9faTom Care}
2372e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2373e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag(
2374826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                const analyze_printf::PrintfSpecifier &FS,
2375e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                const analyze_printf::OptionalFlag &ignoredFlag,
2376e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                const analyze_printf::OptionalFlag &flag,
2377e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                const char *startSpecifier,
2378e4ee9663168dfb2b4122c768091e30217328c9faTom Care                                unsigned specifierLen) {
2379e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Warn about ignored flag with a fixit removal.
238055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag)
238155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         << ignoredFlag.toString() << flag.toString(),
238255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(ignoredFlag.getPosition()),
238355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       /*IsStringLocation*/true,
238455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(startSpecifier, specifierLen),
238555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       FixItHint::CreateRemoval(
238655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         getSpecifierRange(ignoredFlag.getPosition(), 1)));
2387e4ee9663168dfb2b4122c768091e30217328c9faTom Care}
2388e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2389831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determines if the specified is a C++ class or struct containing
2390831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// a member with the specified name and kind (e.g. a CXXMethodDecl named
2391831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// "c_str()").
2392831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithtemplate<typename MemberKind>
2393831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithstatic llvm::SmallPtrSet<MemberKind*, 1>
2394831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCXXRecordMembersNamed(StringRef Name, Sema &S, QualType Ty) {
2395831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  const RecordType *RT = Ty->getAs<RecordType>();
2396831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  llvm::SmallPtrSet<MemberKind*, 1> Results;
2397831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2398831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (!RT)
2399831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return Results;
2400831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl());
2401831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (!RD)
2402831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    return Results;
2403831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2404831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  LookupResult R(S, &S.PP.getIdentifierTable().get(Name), SourceLocation(),
2405831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                 Sema::LookupMemberName);
2406831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2407831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // We just need to include all members of the right kind turned up by the
2408831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  // filter, at this point.
2409831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (S.LookupQualifiedName(R, RT->getDecl()))
2410831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    for (LookupResult::iterator I = R.begin(), E = R.end(); I != E; ++I) {
2411831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      NamedDecl *decl = (*I)->getUnderlyingDecl();
2412831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      if (MemberKind *FK = dyn_cast<MemberKind>(decl))
2413831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        Results.insert(FK);
2414831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    }
2415831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return Results;
2416831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
2417831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2418831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Check if a (w)string was passed when a (w)char* was needed, and offer a
2419831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// better diagnostic if so. ATR is assumed to be valid.
2420831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Returns true when a c_str() conversion method is found.
2421831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool CheckPrintfHandler::checkForCStrMembers(
2422831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    const analyze_printf::ArgTypeResult &ATR, const Expr *E,
2423831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    const CharSourceRange &CSR) {
2424831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  typedef llvm::SmallPtrSet<CXXMethodDecl*, 1> MethodSet;
2425831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2426831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  MethodSet Results =
2427831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      CXXRecordMembersNamed<CXXMethodDecl>("c_str", S, E->getType());
2428831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2429831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  for (MethodSet::iterator MI = Results.begin(), ME = Results.end();
2430831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith       MI != ME; ++MI) {
2431831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    const CXXMethodDecl *Method = *MI;
2432831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    if (Method->getNumParams() == 0 &&
2433831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          ATR.matchesType(S.Context, Method->getResultType())) {
2434831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      // FIXME: Suggest parens if the expression needs them.
2435831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      SourceLocation EndLoc =
2436831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          S.getPreprocessor().getLocForEndOfToken(E->getLocEnd());
2437831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      S.Diag(E->getLocStart(), diag::note_printf_c_str)
2438831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          << "c_str()"
2439831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          << FixItHint::CreateInsertion(EndLoc, ".c_str()");
2440831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      return true;
2441831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    }
2442831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  }
2443831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2444831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return false;
2445831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
2446831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2447e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool
2448826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier
24495c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek                                            &FS,
2450e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek                                          const char *startSpecifier,
2451e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek                                          unsigned specifierLen) {
2452e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
24536ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  using namespace analyze_format_string;
2454efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  using namespace analyze_printf;
24556ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const PrintfConversionSpecifier &CS = FS.getConversionSpecifier();
2456e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2457baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek  if (FS.consumesDataArgument()) {
2458baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    if (atFirstArg) {
2459baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek        atFirstArg = false;
2460baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek        usesPositionalArgs = FS.usesPositionalArg();
2461baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    }
2462baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    else if (usesPositionalArgs != FS.usesPositionalArg()) {
246355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()),
246455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                        startSpecifier, specifierLen);
2465baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek      return false;
2466baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    }
2467efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  }
2468efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek
24690d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  // First check if the field width, precision, and conversion specifier
24700d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  // have matching data arguments.
2471efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0,
2472efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek                    startSpecifier, specifierLen)) {
24730d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek    return false;
24740d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  }
24754e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2476efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek  if (!HandleAmount(FS.getPrecision(), /* precision */ 1,
2477efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek                    startSpecifier, specifierLen)) {
24780d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek    return false;
24790d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek  }
24800d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek
2481f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek  if (!CS.consumesDataArgument()) {
2482f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek    // FIXME: Technically specifying a precision or field width here
2483f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek    // makes no sense.  Worth issuing a warning at some point.
24840e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek    return true;
2485f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek  }
24864e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
24877f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  // Consume the argument.
24887f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  unsigned argIndex = FS.getArgIndex();
2489e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek  if (argIndex < NumDataArgs) {
2490e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek    // The check to see if the argIndex is valid will come later.
2491e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek    // We set the bit here because we may exit early from this
2492e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek    // function if we encounter some other error.
2493e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek    CoveredArgs.set(argIndex);
2494e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek  }
24957f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek
24967f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  // Check for using an Objective-C specific conversion specifier
24977f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  // in a non-ObjC literal.
249850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose  if (!ObjCContext && CS.isObjCArg()) {
2499826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier,
2500826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                                  specifierLen);
25017f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  }
25024e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2503e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check for invalid use of field width
2504e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidFieldWidth()) {
250545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care    HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0,
2506e4ee9663168dfb2b4122c768091e30217328c9faTom Care        startSpecifier, specifierLen);
2507e4ee9663168dfb2b4122c768091e30217328c9faTom Care  }
2508e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2509e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check for invalid use of precision
2510e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidPrecision()) {
2511e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1,
2512e4ee9663168dfb2b4122c768091e30217328c9faTom Care        startSpecifier, specifierLen);
2513e4ee9663168dfb2b4122c768091e30217328c9faTom Care  }
2514e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2515e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check each flag does not conflict with any other component.
251665197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek  if (!FS.hasValidThousandsGroupingPrefix())
251765197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek    HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen);
2518e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidLeadingZeros())
2519e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen);
2520e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidPlusPrefix())
2521e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen);
252245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  if (!FS.hasValidSpacePrefix())
252345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care    HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen);
2524e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidAlternativeForm())
2525e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen);
2526e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidLeftJustified())
2527e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen);
2528e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2529e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check that flags are not ignored by another flag
253045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care  if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+'
253145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care    HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(),
253245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care        startSpecifier, specifierLen);
2533e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-'
2534e4ee9663168dfb2b4122c768091e30217328c9faTom Care    HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(),
2535e4ee9663168dfb2b4122c768091e30217328c9faTom Care            startSpecifier, specifierLen);
2536e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2537e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Check the length modifier is valid with the given conversion specifier.
2538e4ee9663168dfb2b4122c768091e30217328c9faTom Care  const LengthModifier &LM = FS.getLengthModifier();
2539e4ee9663168dfb2b4122c768091e30217328c9faTom Care  if (!FS.hasValidLengthModifier())
254055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    EmitFormatDiagnostic(S.PDiag(diag::warn_format_nonsensical_length)
254155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                           << LM.toString() << CS.toString(),
254255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         getLocationOfByte(LM.getStart()),
254355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         /*IsStringLocation*/true,
254455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         getSpecifierRange(startSpecifier, specifierLen),
254555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         FixItHint::CreateRemoval(
254655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                           getSpecifierRange(LM.getStart(),
254755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                             LM.getLength())));
254876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg  if (!FS.hasStandardLengthModifier())
254976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    HandleNonStandardLengthModifier(LM, startSpecifier, specifierLen);
25504e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie  if (!FS.hasStandardConversionSpecifier(S.getLangOpts()))
255176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen);
255276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg  if (!FS.hasStandardLengthConversionCombination())
255376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    HandleNonStandardConversionSpecification(LM, CS, startSpecifier,
255476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg                                             specifierLen);
2555e4ee9663168dfb2b4122c768091e30217328c9faTom Care
2556e4ee9663168dfb2b4122c768091e30217328c9faTom Care  // Are we using '%n'?
255735d353b47bce29200b910371dd9b8ba7f3058ab8Ted Kremenek  if (CS.getKind() == ConversionSpecifier::nArg) {
2558e4ee9663168dfb2b4122c768091e30217328c9faTom Care    // Issue a warning about this being a possible security issue.
255955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    EmitFormatDiagnostic(S.PDiag(diag::warn_printf_write_back),
256055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         getLocationOfByte(CS.getStart()),
256155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         /*IsStringLocation*/true,
256255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         getSpecifierRange(startSpecifier, specifierLen));
2563e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek    // Continue checking the other format specifiers.
2564e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek    return true;
2565e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek  }
25665c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek
2567da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek  // The remaining checks depend on the data arguments.
2568da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek  if (HasVAListArg)
2569da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek    return true;
25704e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2571666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
2572da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek    return false;
25734e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
2574831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  return checkFormatExpr(FS, startSpecifier, specifierLen,
2575831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                         getDataArg(argIndex));
2576831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith}
2577831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2578831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool
2579831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCheckPrintfHandler::checkFormatExpr(const analyze_printf::PrintfSpecifier &FS,
2580831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                    const char *StartSpecifier,
2581831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                    unsigned SpecifierLen,
2582831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                    const Expr *E) {
2583831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  using namespace analyze_format_string;
2584831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  using namespace analyze_printf;
258596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer  // Now type check the data expression that matches the
258696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer  // format specifier.
2587339b9072e26a2a0fe796dc69c4d28d964d0ec86dNico Weber  const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context,
258850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                                                           ObjCContext);
2589831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith  if (ATR.isValid() && !ATR.matchesType(S.Context, E->getType())) {
2590ee0259d308e72141982a85b40863e760a8447edfJordan Rose    // Look through argument promotions for our error message's reported type.
2591ee0259d308e72141982a85b40863e760a8447edfJordan Rose    // This includes the integral and floating promotions, but excludes array
2592ee0259d308e72141982a85b40863e760a8447edfJordan Rose    // and function pointer decay; seeing that an argument intended to be a
2593ee0259d308e72141982a85b40863e760a8447edfJordan Rose    // string has type 'char [6]' is probably more confusing than 'char *'.
2594831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) {
2595ee0259d308e72141982a85b40863e760a8447edfJordan Rose      if (ICE->getCastKind() == CK_IntegralCast ||
2596ee0259d308e72141982a85b40863e760a8447edfJordan Rose          ICE->getCastKind() == CK_FloatingCast) {
2597831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        E = ICE->getSubExpr();
2598ee0259d308e72141982a85b40863e760a8447edfJordan Rose
2599ee0259d308e72141982a85b40863e760a8447edfJordan Rose        // Check if we didn't match because of an implicit cast from a 'char'
2600ee0259d308e72141982a85b40863e760a8447edfJordan Rose        // or 'short' to an 'int'.  This is done because printf is a varargs
2601ee0259d308e72141982a85b40863e760a8447edfJordan Rose        // function.
2602ee0259d308e72141982a85b40863e760a8447edfJordan Rose        if (ICE->getType() == S.Context.IntTy ||
2603ee0259d308e72141982a85b40863e760a8447edfJordan Rose            ICE->getType() == S.Context.UnsignedIntTy) {
2604ee0259d308e72141982a85b40863e760a8447edfJordan Rose          // All further checking is done on the subexpression.
2605831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          if (ATR.matchesType(S.Context, E->getType()))
2606ee0259d308e72141982a85b40863e760a8447edfJordan Rose            return true;
2607ee0259d308e72141982a85b40863e760a8447edfJordan Rose        }
26084d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek      }
2609ee0259d308e72141982a85b40863e760a8447edfJordan Rose    }
261096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer
261196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer    // We may be able to offer a FixItHint if it is a supported type.
261296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer    PrintfSpecifier fixedFS = FS;
2613831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    bool success = fixedFS.fixType(E->getType(), S.getLangOpts(),
261450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                                   S.Context, ObjCContext);
261596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer
261696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer    if (success) {
261796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer      // Get the fix string from the fixed format specifier
2618ee0259d308e72141982a85b40863e760a8447edfJordan Rose      SmallString<16> buf;
261996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer      llvm::raw_svector_ostream os(buf);
262096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer      fixedFS.toString(os);
262196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer
262255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      EmitFormatDiagnostic(
262355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu        S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
2624831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          << ATR.getRepresentativeTypeName(S.Context) << E->getType()
2625831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          << E->getSourceRange(),
2626831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        E->getLocStart(),
2627abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay        /*IsStringLocation*/false,
2628831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        getSpecifierRange(StartSpecifier, SpecifierLen),
262955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu        FixItHint::CreateReplacement(
2630831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          getSpecifierRange(StartSpecifier, SpecifierLen),
263155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu          os.str()));
2632831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith    } else {
2633831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      const CharSourceRange &CSR = getSpecifierRange(StartSpecifier,
2634831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith                                                     SpecifierLen);
2635831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      // Since the warning for passing non-POD types to variadic functions
2636831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      // was deferred until now, we emit a warning for non-POD
2637831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      // arguments here.
2638831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      if (S.isValidVarArgType(E->getType()) == Sema::VAK_Invalid) {
2639831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        EmitFormatDiagnostic(
2640831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          S.PDiag(diag::warn_non_pod_vararg_with_format_string)
2641831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            << S.getLangOpts().CPlusPlus0x
2642831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            << E->getType()
2643831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            << ATR.getRepresentativeTypeName(S.Context)
2644831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            << CSR
2645831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            << E->getSourceRange(),
2646831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          E->getLocStart(), /*IsStringLocation*/false, CSR);
2647831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith
2648831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        checkForCStrMembers(ATR, E, CSR);
2649831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith      } else
2650831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith        EmitFormatDiagnostic(
2651831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
2652831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            << ATR.getRepresentativeTypeName(S.Context) << E->getType()
2653831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            << CSR
2654831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith            << E->getSourceRange(),
2655831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith          E->getLocStart(), /*IsStringLocation*/false, CSR);
265696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer    }
265796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer  }
265896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer
2659e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  return true;
2660e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}
2661e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2662826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===//
2663826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2664826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace {
2665826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler {
2666826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic:
2667826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  CheckScanfHandler(Sema &s, const StringLiteral *fexpr,
2668826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                    const Expr *origFormatExpr, unsigned firstDataArg,
266950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                    unsigned numDataArgs, const char *beg, bool hasVAListArg,
267029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                    Expr **Args, unsigned NumArgs,
267129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                    unsigned formatIdx, bool inFunctionCall)
2672826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
267350687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                       numDataArgs, beg, hasVAListArg,
267429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                       Args, NumArgs, formatIdx, inFunctionCall) {}
2675826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2676826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS,
2677826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                            const char *startSpecifier,
2678826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                            unsigned specifierLen);
2679c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2680c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  bool HandleInvalidScanfConversionSpecifier(
2681c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek          const analyze_scanf::ScanfSpecifier &FS,
2682c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek          const char *startSpecifier,
2683c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek          unsigned specifierLen);
2684b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek
2685b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek  void HandleIncompleteScanList(const char *start, const char *end);
2686826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek};
2687826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}
2688826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2689b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start,
2690b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek                                                 const char *end) {
269155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu  EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete),
269255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getLocationOfByte(end), /*IsStringLocation*/true,
269355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                       getSpecifierRange(start, end - start));
2694b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek}
2695b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek
2696c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier(
2697c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        const analyze_scanf::ScanfSpecifier &FS,
2698c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        const char *startSpecifier,
2699c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                        unsigned specifierLen) {
2700c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
27016ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const analyze_scanf::ScanfConversionSpecifier &CS =
2702c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek    FS.getConversionSpecifier();
2703c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2704c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek  return HandleInvalidConversionSpecifier(FS.getArgIndex(),
2705c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          getLocationOfByte(CS.getStart()),
2706c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          startSpecifier, specifierLen,
2707c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek                                          CS.getStart(), CS.getLength());
2708c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek}
2709c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek
2710826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier(
2711826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                       const analyze_scanf::ScanfSpecifier &FS,
2712826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                       const char *startSpecifier,
2713826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                       unsigned specifierLen) {
2714826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2715826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  using namespace analyze_scanf;
2716826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  using namespace analyze_format_string;
2717826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
27186ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek  const ScanfConversionSpecifier &CS = FS.getConversionSpecifier();
2719826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2720baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek  // Handle case where '%' and '*' don't consume an argument.  These shouldn't
2721baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek  // be used to decide if we are using positional arguments consistently.
2722baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek  if (FS.consumesDataArgument()) {
2723baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    if (atFirstArg) {
2724baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek      atFirstArg = false;
2725baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek      usesPositionalArgs = FS.usesPositionalArg();
2726baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    }
2727baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    else if (usesPositionalArgs != FS.usesPositionalArg()) {
272855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()),
272955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                                        startSpecifier, specifierLen);
2730baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek      return false;
2731baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek    }
2732826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  }
2733826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2734826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  // Check if the field with is non-zero.
2735826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  const OptionalAmount &Amt = FS.getFieldWidth();
2736826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (Amt.getHowSpecified() == OptionalAmount::Constant) {
2737826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    if (Amt.getConstantAmount() == 0) {
2738826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      const CharSourceRange &R = getSpecifierRange(Amt.getStart(),
2739826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek                                                   Amt.getConstantLength());
274055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width),
274155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                           getLocationOfByte(Amt.getStart()),
274255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                           /*IsStringLocation*/true, R,
274355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                           FixItHint::CreateRemoval(R));
27447f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek    }
27457f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek  }
2746826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2747826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (!FS.consumesDataArgument()) {
2748826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    // FIXME: Technically specifying a precision or field width here
2749826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    // makes no sense.  Worth issuing a warning at some point.
2750826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    return true;
2751826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  }
2752826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2753826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  // Consume the argument.
2754826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  unsigned argIndex = FS.getArgIndex();
2755826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (argIndex < NumDataArgs) {
2756826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      // The check to see if the argIndex is valid will come later.
2757826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      // We set the bit here because we may exit early from this
2758826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      // function if we encounter some other error.
2759826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    CoveredArgs.set(argIndex);
2760826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  }
2761826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
27621e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek  // Check the length modifier is valid with the given conversion specifier.
27631e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek  const LengthModifier &LM = FS.getLengthModifier();
27641e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek  if (!FS.hasValidLengthModifier()) {
2765220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas    const CharSourceRange &R = getSpecifierRange(LM.getStart(), LM.getLength());
2766220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas    EmitFormatDiagnostic(S.PDiag(diag::warn_format_nonsensical_length)
2767220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas                         << LM.toString() << CS.toString()
2768220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas                         << getSpecifierRange(startSpecifier, specifierLen),
2769220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas                         getLocationOfByte(LM.getStart()),
2770220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas                         /*IsStringLocation*/true, R,
2771220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas                         FixItHint::CreateRemoval(R));
27721e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek  }
27731e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek
277476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg  if (!FS.hasStandardLengthModifier())
277576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    HandleNonStandardLengthModifier(LM, startSpecifier, specifierLen);
27764e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie  if (!FS.hasStandardConversionSpecifier(S.getLangOpts()))
277776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen);
277876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg  if (!FS.hasStandardLengthConversionCombination())
277976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg    HandleNonStandardConversionSpecification(LM, CS, startSpecifier,
278076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg                                             specifierLen);
278176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg
2782826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  // The remaining checks depend on the data arguments.
2783826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  if (HasVAListArg)
2784826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    return true;
2785826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2786666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek  if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
2787826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    return false;
2788826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
27896fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg  // Check that the argument type matches the format specifier.
27906fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg  const Expr *Ex = getDataArg(argIndex);
27916fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg  const analyze_scanf::ScanfArgTypeResult &ATR = FS.getArgType(S.Context);
27926fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg  if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) {
27936fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg    ScanfSpecifier fixedFS = FS;
27944e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie    bool success = fixedFS.fixType(Ex->getType(), S.getLangOpts(),
2795be6126a2a784e1446460b8d15c2b26f880c871fcHans Wennborg                                   S.Context);
27966fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg
27976fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg    if (success) {
27986fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg      // Get the fix string from the fixed format specifier.
2799f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith      SmallString<128> buf;
28006fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg      llvm::raw_svector_ostream os(buf);
28016fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg      fixedFS.toString(os);
28026fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg
28036fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg      EmitFormatDiagnostic(
28046fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg        S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
28056fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg          << ATR.getRepresentativeTypeName(S.Context) << Ex->getType()
28066fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg          << Ex->getSourceRange(),
2807abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay        Ex->getLocStart(),
2808abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay        /*IsStringLocation*/false,
28096fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg        getSpecifierRange(startSpecifier, specifierLen),
28106fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg        FixItHint::CreateReplacement(
28116fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg          getSpecifierRange(startSpecifier, specifierLen),
28126fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg          os.str()));
28136fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg    } else {
2814220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas      EmitFormatDiagnostic(
2815220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas        S.PDiag(diag::warn_printf_conversion_argument_type_mismatch)
28166fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg          << ATR.getRepresentativeTypeName(S.Context) << Ex->getType()
2817220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas          << Ex->getSourceRange(),
2818abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay        Ex->getLocStart(),
2819abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay        /*IsStringLocation*/false,
2820220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas        getSpecifierRange(startSpecifier, specifierLen));
28216fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg    }
28226fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg  }
28236fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg
2824826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek  return true;
282507d161f38e708a91486bf1c031d525faebbb249dTed Kremenek}
2826e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek
2827826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr,
28280e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek                             const Expr *OrigFormatExpr,
282929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                             Expr **Args, unsigned NumArgs,
283029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                             bool HasVAListArg, unsigned format_idx,
283134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas                             unsigned firstDataArg, FormatStringType Type,
283229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                             bool inFunctionCall) {
2833826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2834e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  // CHECK: is the format string a wide literal?
2835df9ef1bc8c3780307ab2ed81bf5e31c23310b936Richard Smith  if (!FExpr->isAscii() && !FExpr->isUTF8()) {
283655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    CheckFormatHandler::EmitFormatDiagnostic(
283729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas      *this, inFunctionCall, Args[format_idx],
283855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(),
283955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      /*IsStringLocation*/true, OrigFormatExpr->getSourceRange());
2840e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek    return;
2841e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  }
2842826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2843e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  // Str - The format string.  NOTE: this is NOT null-terminated!
28445f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner  StringRef StrRef = FExpr->getString();
28452f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer  const char *Str = StrRef.data();
28462f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer  unsigned StrLen = StrRef.size();
284729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas  const unsigned numDataArgs = NumArgs - firstDataArg;
2848826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2849e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  // CHECK: empty format string?
28504cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek  if (StrLen == 0 && numDataArgs > 0) {
285155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu    CheckFormatHandler::EmitFormatDiagnostic(
285229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas      *this, inFunctionCall, Args[format_idx],
285355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      PDiag(diag::warn_empty_format_string), FExpr->getLocStart(),
285455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu      /*IsStringLocation*/true, OrigFormatExpr->getSourceRange());
2855e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek    return;
2856e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek  }
2857826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
285834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  if (Type == FST_Printf || Type == FST_NSString) {
2859826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek    CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
286050687314f87b67073c202fe46d84d12fb55e25cfJordan Rose                         numDataArgs, (Type == FST_NSString),
286129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                         Str, HasVAListArg, Args, NumArgs, format_idx,
286255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                         inFunctionCall);
2863826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2864d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg    if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen,
28654e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie                                                  getLangOpts()))
2866826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      H.DoneProcessing();
286734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  } else if (Type == FST_Scanf) {
286850687314f87b67073c202fe46d84d12fb55e25cfJordan Rose    CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, numDataArgs,
286929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas                        Str, HasVAListArg, Args, NumArgs, format_idx,
287055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu                        inFunctionCall);
2871826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek
2872d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg    if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen,
28734e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie                                                 getLangOpts()))
2874826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek      H.DoneProcessing();
287534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas  } // TODO: handle other formats
2876ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek}
2877ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek
28787ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth//===--- CHECK: Standard memory functions ---------------------------------===//
28797ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth
28802a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// \brief Determine whether the given type is a dynamic class type (e.g.,
28812a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// whether it has a vtable).
28822a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregorstatic bool isDynamicClassType(QualType T) {
28832a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor  if (CXXRecordDecl *Record = T->getAsCXXRecordDecl())
28842a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor    if (CXXRecordDecl *Definition = Record->getDefinition())
28852a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor      if (Definition->isDynamicClass())
28862a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor        return true;
28872a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor
28882a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor  return false;
28892a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor}
28902a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor
2891a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument expression,
2892000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth/// otherwise returns NULL.
2893000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic const Expr *getSizeOfExprArg(const Expr* E) {
2894e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber  if (const UnaryExprOrTypeTraitExpr *SizeOf =
2895000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      dyn_cast<UnaryExprOrTypeTraitExpr>(E))
2896000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth    if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType())
2897000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      return SizeOf->getArgumentExpr()->IgnoreParenImpCasts();
2898e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber
2899000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  return 0;
2900000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth}
2901000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
2902a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument type.
2903000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic QualType getSizeOfArgType(const Expr* E) {
2904000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  if (const UnaryExprOrTypeTraitExpr *SizeOf =
2905000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      dyn_cast<UnaryExprOrTypeTraitExpr>(E))
2906000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth    if (SizeOf->getKind() == clang::UETT_SizeOf)
2907000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      return SizeOf->getTypeOfArgument();
2908000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
2909000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  return QualType();
2910e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber}
2911e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber
29127ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \brief Check for dangerous or invalid arguments to memset().
29137ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth///
2914929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth/// This issues warnings on known problematic, dangerous or unspecified
2915cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp'
2916cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// function calls.
29177ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth///
29187ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \param Call The call expression to diagnose.
2919cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gayvoid Sema::CheckMemaccessArguments(const CallExpr *Call,
29200a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks                                   unsigned BId,
2921cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay                                   IdentifierInfo *FnName) {
29220a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  assert(BId != 0);
29230a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks
29241d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek  // It is possible to have a non-standard definition of memset.  Validate
2925707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor  // we have enough arguments, and if not, abort further checking.
29260a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  unsigned ExpectedNumArgs = (BId == Builtin::BIstrndup ? 2 : 3);
2927cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber  if (Call->getNumArgs() < ExpectedNumArgs)
29281d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek    return;
29291d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek
29300a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  unsigned LastArg = (BId == Builtin::BImemset ||
29310a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks                      BId == Builtin::BIstrndup ? 1 : 2);
29320a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks  unsigned LenArg = (BId == Builtin::BIstrndup ? 1 : 2);
2933cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber  const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts();
2934000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
2935000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  // We have special checking when the length is a sizeof expression.
2936000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  QualType SizeOfArgTy = getSizeOfArgType(LenExpr);
2937000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  const Expr *SizeOfArg = getSizeOfExprArg(LenExpr);
2938000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth  llvm::FoldingSetNodeID SizeOfArgID;
2939000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
294006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor  for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) {
294106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor    const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts();
2942e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber    SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange();
294306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor
294406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor    QualType DestTy = Dest->getType();
294506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor    if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) {
294606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor      QualType PointeeTy = DestPtrTy->getPointeeType();
2947f85e193739c953358c865005855253af4f68a497John McCall
2948000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // Never warn about void type pointers. This can be used to suppress
2949000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // false positives.
2950000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      if (PointeeTy->isVoidType())
295106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor        continue;
295206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor
2953000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by
2954000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // actually comparing the expressions for equality. Because computing the
2955000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // expression IDs can be expensive, we only do this if the diagnostic is
2956000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // enabled.
2957000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      if (SizeOfArg &&
2958000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess,
2959000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                                   SizeOfArg->getExprLoc())) {
2960000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        // We only compute IDs for expressions if the warning is enabled, and
2961000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        // cache the sizeof arg's ID.
2962000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        if (SizeOfArgID == llvm::FoldingSetNodeID())
2963000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          SizeOfArg->Profile(SizeOfArgID, Context, true);
2964000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        llvm::FoldingSetNodeID DestID;
2965000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        Dest->Profile(DestID, Context, true);
2966000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        if (DestID == SizeOfArgID) {
2967cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber          // TODO: For strncpy() and friends, this could suggest sizeof(dst)
2968cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber          //       over sizeof(src) as well.
2969000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          unsigned ActionIdx = 0; // Default is to suggest dereferencing.
29706fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          StringRef ReadableName = FnName->getName();
29716fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks
2972000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest))
297390c78328e70cb376754edf87708505a84c044271Anna Zaks            if (UnaryOp->getOpcode() == UO_AddrOf)
2974000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth              ActionIdx = 1; // If its an address-of operator, just remove it.
2975000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          if (Context.getTypeSize(PointeeTy) == Context.getCharWidth())
2976000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth            ActionIdx = 2; // If the pointee's size is sizeof(char),
2977000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                           // suggest an explicit length.
29786fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks
29796fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          // If the function is defined as a builtin macro, do not show macro
29806fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          // expansion.
29816fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          SourceLocation SL = SizeOfArg->getExprLoc();
29826fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          SourceRange DSR = Dest->getSourceRange();
29836fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          SourceRange SSR = SizeOfArg->getSourceRange();
29846fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          SourceManager &SM  = PP.getSourceManager();
29856fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks
29866fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          if (SM.isMacroArgExpansion(SL)) {
29876fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks            ReadableName = Lexer::getImmediateMacroName(SL, SM, LangOpts);
29886fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks            SL = SM.getSpellingLoc(SL);
29896fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks            DSR = SourceRange(SM.getSpellingLoc(DSR.getBegin()),
29906fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks                             SM.getSpellingLoc(DSR.getEnd()));
29916fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks            SSR = SourceRange(SM.getSpellingLoc(SSR.getBegin()),
29926fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks                             SM.getSpellingLoc(SSR.getEnd()));
29936fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks          }
29946fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks
299590c78328e70cb376754edf87708505a84c044271Anna Zaks          DiagRuntimeBehavior(SL, SizeOfArg,
2996000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                              PDiag(diag::warn_sizeof_pointer_expr_memaccess)
29976fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks                                << ReadableName
299890c78328e70cb376754edf87708505a84c044271Anna Zaks                                << PointeeTy
299990c78328e70cb376754edf87708505a84c044271Anna Zaks                                << DestTy
30006fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks                                << DSR
300190c78328e70cb376754edf87708505a84c044271Anna Zaks                                << SSR);
300290c78328e70cb376754edf87708505a84c044271Anna Zaks          DiagRuntimeBehavior(SL, SizeOfArg,
300390c78328e70cb376754edf87708505a84c044271Anna Zaks                         PDiag(diag::warn_sizeof_pointer_expr_memaccess_note)
300490c78328e70cb376754edf87708505a84c044271Anna Zaks                                << ActionIdx
300590c78328e70cb376754edf87708505a84c044271Anna Zaks                                << SSR);
300690c78328e70cb376754edf87708505a84c044271Anna Zaks
3007000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          break;
3008000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        }
3009000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      }
3010000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth
3011000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // Also check for cases where the sizeof argument is the exact same
3012000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // type as the memory argument, and where it points to a user-defined
3013000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      // record type.
3014000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth      if (SizeOfArgTy != QualType()) {
3015000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        if (PointeeTy->isRecordType() &&
3016000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth            Context.typesAreCompatible(SizeOfArgTy, DestTy)) {
3017000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest,
3018000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                              PDiag(diag::warn_sizeof_pointer_type_memaccess)
3019000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                                << FnName << SizeOfArgTy << ArgIdx
3020000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                                << PointeeTy << Dest->getSourceRange()
3021000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth                                << LenExpr->getSourceRange());
3022000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth          break;
3023000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth        }
3024e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber      }
3025e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber
302606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor      // Always complain about dynamic classes.
30270a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks      if (isDynamicClassType(PointeeTy)) {
30280a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks
30290a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        unsigned OperationType = 0;
30300a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        // "overwritten" if we're warning about the destination for any call
30310a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        // but memcmp; otherwise a verb appropriate to the call.
30320a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        if (ArgIdx != 0 || BId == Builtin::BImemcmp) {
30330a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks          if (BId == Builtin::BImemcpy)
30340a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            OperationType = 1;
30350a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks          else if(BId == Builtin::BImemmove)
30360a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            OperationType = 2;
30370a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks          else if (BId == Builtin::BImemcmp)
30380a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            OperationType = 3;
30390a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks        }
30400a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks
30415c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay        DiagRuntimeBehavior(
30425c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay          Dest->getExprLoc(), Dest,
30435c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay          PDiag(diag::warn_dyn_class_memaccess)
30440a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx)
3045d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks            << FnName << PointeeTy
30460a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks            << OperationType
30475c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay            << Call->getCallee()->getSourceRange());
30480a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks      } else if (PointeeTy.hasNonTrivialObjCLifetime() &&
30490a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks               BId != Builtin::BImemset)
30505c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay        DiagRuntimeBehavior(
30515c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay          Dest->getExprLoc(), Dest,
30525c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay          PDiag(diag::warn_arc_object_memaccess)
30535c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay            << ArgIdx << FnName << PointeeTy
30545c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay            << Call->getCallee()->getSourceRange());
3055f85e193739c953358c865005855253af4f68a497John McCall      else
305606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor        continue;
3057f85e193739c953358c865005855253af4f68a497John McCall
3058f85e193739c953358c865005855253af4f68a497John McCall      DiagRuntimeBehavior(
3059f85e193739c953358c865005855253af4f68a497John McCall        Dest->getExprLoc(), Dest,
3060929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth        PDiag(diag::note_bad_memaccess_silence)
306106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor          << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)"));
306206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor      break;
306306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor    }
30647ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth  }
30657ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth}
30667ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth
3067bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// A little helper routine: ignore addition and subtraction of integer literals.
3068bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// This intentionally does not ignore all integer constant expressions because
3069bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// we don't want to remove sizeof().
3070bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekstatic const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) {
3071bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  Ex = Ex->IgnoreParenCasts();
3072bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3073bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  for (;;) {
3074bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex);
3075bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    if (!BO || !BO->isAdditiveOp())
3076bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      break;
3077bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3078bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    const Expr *RHS = BO->getRHS()->IgnoreParenCasts();
3079bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    const Expr *LHS = BO->getLHS()->IgnoreParenCasts();
3080bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3081bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    if (isa<IntegerLiteral>(RHS))
3082bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      Ex = LHS;
3083bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    else if (isa<IntegerLiteral>(LHS))
3084bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      Ex = RHS;
3085bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    else
3086bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      break;
3087bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  }
3088bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3089bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  return Ex;
3090bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek}
3091bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3092bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// Warn if the user has made the 'size' argument to strlcpy or strlcat
3093bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// be the size of the source, instead of the destination.
3094bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekvoid Sema::CheckStrlcpycatArguments(const CallExpr *Call,
3095bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek                                    IdentifierInfo *FnName) {
3096bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3097bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // Don't crash if the user has the wrong number of arguments
3098bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (Call->getNumArgs() != 3)
3099bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    return;
3100bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3101bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context);
3102bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context);
3103bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *CompareWithSrc = NULL;
3104bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3105bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // Look for 'strlcpy(dst, x, sizeof(x))'
3106bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (const Expr *Ex = getSizeOfExprArg(SizeArg))
3107bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    CompareWithSrc = Ex;
3108bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  else {
3109bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    // Look for 'strlcpy(dst, x, strlen(x))'
3110bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) {
3111180f47959a066795cc0f409433023af448bb0328Richard Smith      if (SizeCall->isBuiltinCall() == Builtin::BIstrlen
3112bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek          && SizeCall->getNumArgs() == 1)
3113bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek        CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context);
3114bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    }
3115bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  }
3116bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3117bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (!CompareWithSrc)
3118bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    return;
3119bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3120bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // Determine if the argument to sizeof/strlen is equal to the source
3121bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // argument.  In principle there's all kinds of things you could do
3122bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // here, for instance creating an == expression and evaluating it with
3123bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // EvaluateAsBooleanCondition, but this uses a more direct technique:
3124bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg);
3125bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (!SrcArgDRE)
3126bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    return;
3127bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3128bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc);
3129bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  if (!CompareWithSrcDRE ||
3130bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek      SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl())
3131bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    return;
3132bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3133bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *OriginalSizeArg = Call->getArg(2);
3134bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size)
3135bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek    << OriginalSizeArg->getSourceRange() << FnName;
3136bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3137bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // Output a FIXIT hint if the destination is an array (rather than a
3138bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // pointer to an array).  This could be enhanced to handle some
3139bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // pointers if we know the actual size, like if DstArg is 'array+2'
3140bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  // we could say 'sizeof(array)-2'.
3141bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts();
31428f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  QualType DstArgTy = DstArg->getType();
3143bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
31448f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  // Only handle constant-sized or VLAs, but not flexible members.
31458f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(DstArgTy)) {
31468f7462237ff542a4556775f98709ed300aa1731aTed Kremenek    // Only issue the FIXIT for arrays of size > 1.
31478f7462237ff542a4556775f98709ed300aa1731aTed Kremenek    if (CAT->getSize().getSExtValue() <= 1)
31488f7462237ff542a4556775f98709ed300aa1731aTed Kremenek      return;
31498f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  } else if (!DstArgTy->isVariableArrayType()) {
31508f7462237ff542a4556775f98709ed300aa1731aTed Kremenek    return;
3151bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek  }
31528f7462237ff542a4556775f98709ed300aa1731aTed Kremenek
3153f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith  SmallString<128> sizeString;
31548f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  llvm::raw_svector_ostream OS(sizeString);
31558f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  OS << "sizeof(";
31568987b2385d9ba63ada66e1344ace79b04d5cb5c3Douglas Gregor  DstArg->printPretty(OS, Context, 0, getPrintingPolicy());
31578f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  OS << ")";
31588f7462237ff542a4556775f98709ed300aa1731aTed Kremenek
31598f7462237ff542a4556775f98709ed300aa1731aTed Kremenek  Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size)
31608f7462237ff542a4556775f98709ed300aa1731aTed Kremenek    << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(),
31618f7462237ff542a4556775f98709ed300aa1731aTed Kremenek                                    OS.str());
3162bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek}
3163bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek
3164c36bedc90c687caa71748480c60707ea4608b092Anna Zaks/// Check if two expressions refer to the same declaration.
3165c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic bool referToTheSameDecl(const Expr *E1, const Expr *E2) {
3166c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (const DeclRefExpr *D1 = dyn_cast_or_null<DeclRefExpr>(E1))
3167c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    if (const DeclRefExpr *D2 = dyn_cast_or_null<DeclRefExpr>(E2))
3168c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      return D1->getDecl() == D2->getDecl();
3169c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  return false;
3170c36bedc90c687caa71748480c60707ea4608b092Anna Zaks}
3171c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3172c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic const Expr *getStrlenExprArg(const Expr *E) {
3173c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (const CallExpr *CE = dyn_cast<CallExpr>(E)) {
3174c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    const FunctionDecl *FD = CE->getDirectCallee();
3175c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    if (!FD || FD->getMemoryFunctionKind() != Builtin::BIstrlen)
3176c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      return 0;
3177c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    return CE->getArg(0)->IgnoreParenCasts();
3178c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  }
3179c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  return 0;
3180c36bedc90c687caa71748480c60707ea4608b092Anna Zaks}
3181c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3182c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// Warn on anti-patterns as the 'size' argument to strncat.
3183c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// The correct size argument should look like following:
3184c36bedc90c687caa71748480c60707ea4608b092Anna Zaks//   strncat(dst, src, sizeof(dst) - strlen(dest) - 1);
3185c36bedc90c687caa71748480c60707ea4608b092Anna Zaksvoid Sema::CheckStrncatArguments(const CallExpr *CE,
3186c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                                 IdentifierInfo *FnName) {
3187c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  // Don't crash if the user has the wrong number of arguments.
3188c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (CE->getNumArgs() < 3)
3189c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    return;
3190c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  const Expr *DstArg = CE->getArg(0)->IgnoreParenCasts();
3191c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  const Expr *SrcArg = CE->getArg(1)->IgnoreParenCasts();
3192c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  const Expr *LenArg = CE->getArg(2)->IgnoreParenCasts();
3193c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3194c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  // Identify common expressions, which are wrongly used as the size argument
3195c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  // to strncat and may lead to buffer overflows.
3196c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  unsigned PatternType = 0;
3197c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (const Expr *SizeOfArg = getSizeOfExprArg(LenArg)) {
3198c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    // - sizeof(dst)
3199c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    if (referToTheSameDecl(SizeOfArg, DstArg))
3200c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      PatternType = 1;
3201c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    // - sizeof(src)
3202c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    else if (referToTheSameDecl(SizeOfArg, SrcArg))
3203c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      PatternType = 2;
3204c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  } else if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(LenArg)) {
3205c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    if (BE->getOpcode() == BO_Sub) {
3206c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      const Expr *L = BE->getLHS()->IgnoreParenCasts();
3207c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      const Expr *R = BE->getRHS()->IgnoreParenCasts();
3208c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      // - sizeof(dst) - strlen(dst)
3209c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      if (referToTheSameDecl(DstArg, getSizeOfExprArg(L)) &&
3210c36bedc90c687caa71748480c60707ea4608b092Anna Zaks          referToTheSameDecl(DstArg, getStrlenExprArg(R)))
3211c36bedc90c687caa71748480c60707ea4608b092Anna Zaks        PatternType = 1;
3212c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      // - sizeof(src) - (anything)
3213c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      else if (referToTheSameDecl(SrcArg, getSizeOfExprArg(L)))
3214c36bedc90c687caa71748480c60707ea4608b092Anna Zaks        PatternType = 2;
3215c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    }
3216c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  }
3217c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3218c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (PatternType == 0)
3219c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    return;
3220c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3221afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  // Generate the diagnostic.
3222afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  SourceLocation SL = LenArg->getLocStart();
3223afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  SourceRange SR = LenArg->getSourceRange();
3224afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  SourceManager &SM  = PP.getSourceManager();
3225afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks
3226afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  // If the function is defined as a builtin macro, do not show macro expansion.
3227afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  if (SM.isMacroArgExpansion(SL)) {
3228afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    SL = SM.getSpellingLoc(SL);
3229afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    SR = SourceRange(SM.getSpellingLoc(SR.getBegin()),
3230afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks                     SM.getSpellingLoc(SR.getEnd()));
3231afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  }
3232afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks
3233c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (PatternType == 1)
3234afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    Diag(SL, diag::warn_strncat_large_size) << SR;
3235c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  else
3236afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    Diag(SL, diag::warn_strncat_src_size) << SR;
3237c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3238c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  // Output a FIXIT hint if the destination is an array (rather than a
3239c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  // pointer to an array).  This could be enhanced to handle some
3240c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  // pointers if we know the actual size, like if DstArg is 'array+2'
3241c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  // we could say 'sizeof(array)-2'.
3242c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  QualType DstArgTy = DstArg->getType();
3243c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3244c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  // Only handle constant-sized or VLAs, but not flexible members.
3245c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(DstArgTy)) {
3246c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    // Only issue the FIXIT for arrays of size > 1.
3247c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    if (CAT->getSize().getSExtValue() <= 1)
3248c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      return;
3249c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  } else if (!DstArgTy->isVariableArrayType()) {
3250c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    return;
3251c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  }
3252c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3253f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith  SmallString<128> sizeString;
3254c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  llvm::raw_svector_ostream OS(sizeString);
3255c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  OS << "sizeof(";
3256c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  DstArg->printPretty(OS, Context, 0, getPrintingPolicy());
3257c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  OS << ") - ";
3258c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  OS << "strlen(";
3259c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  DstArg->printPretty(OS, Context, 0, getPrintingPolicy());
3260c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  OS << ") - 1";
3261c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
3262afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks  Diag(SL, diag::note_strncat_wrong_size)
3263afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks    << FixItHint::CreateReplacement(SR, OS.str());
3264c36bedc90c687caa71748480c60707ea4608b092Anna Zaks}
3265c36bedc90c687caa71748480c60707ea4608b092Anna Zaks
326606de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===//
326706de276fff91264437fa75111ed76de43097e089Ted Kremenek
3268e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
3269e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                     Decl *ParentDecl);
3270e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars,
3271e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                      Decl *ParentDecl);
327206de276fff91264437fa75111ed76de43097e089Ted Kremenek
327306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address
327406de276fff91264437fa75111ed76de43097e089Ted Kremenek///   of a stack variable.
327506de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid
327606de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType,
327706de276fff91264437fa75111ed76de43097e089Ted Kremenek                           SourceLocation ReturnLoc) {
32781eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
327926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  Expr *stackE = 0;
32805f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner  SmallVector<DeclRefExpr *, 8> refVars;
32814e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
328226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  // Perform checking for returned stack addresses, local blocks,
328326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  // label addresses or references to temporaries.
3284f85e193739c953358c865005855253af4f68a497John McCall  if (lhsType->isPointerType() ||
32854e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie      (!getLangOpts().ObjCAutoRefCount && lhsType->isBlockPointerType())) {
3286e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/0);
3287ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump  } else if (lhsType->isReferenceType()) {
3288e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    stackE = EvalVal(RetValExp, refVars, /*ParentDecl=*/0);
328926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  }
329026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
329126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  if (stackE == 0)
329226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    return; // Nothing suspicious was found.
329326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
329426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  SourceLocation diagLoc;
329526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  SourceRange diagRange;
329626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  if (refVars.empty()) {
329726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    diagLoc = stackE->getLocStart();
329826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    diagRange = stackE->getSourceRange();
329926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  } else {
330026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // We followed through a reference variable. 'stackE' contains the
330126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // problematic expression but we will warn at the return statement pointing
330226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // at the reference variable. We will later display the "trail" of
330326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // reference variables using notes.
330426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    diagLoc = refVars[0]->getLocStart();
330526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    diagRange = refVars[0]->getSourceRange();
330626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  }
330726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
330826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var.
330926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref
331026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis                                             : diag::warn_ret_stack_addr)
331126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis     << DR->getDecl()->getDeclName() << diagRange;
331226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  } else if (isa<BlockExpr>(stackE)) { // local block.
331326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(diagLoc, diag::err_ret_local_block) << diagRange;
331426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  } else if (isa<AddrLabelExpr>(stackE)) { // address of label.
331526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(diagLoc, diag::warn_ret_addr_label) << diagRange;
331626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  } else { // local temporary.
331726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref
331826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis                                             : diag::warn_ret_local_temp_addr)
331926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis     << diagRange;
332026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  }
332126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
332226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  // Display the "trail" of reference variables that we followed until we
332326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  // found the problematic expression using notes.
332426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  for (unsigned i = 0, e = refVars.size(); i != e; ++i) {
332526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl());
332626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // If this var binds to another reference var, show the range of the next
332726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // var, otherwise the var binds to the problematic expression, in which case
332826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // show the range of the expression.
332926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange()
333026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis                                  : stackE->getSourceRange();
333126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    Diag(VD->getLocation(), diag::note_ref_var_local_bind)
333226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      << VD->getDeclName() << range;
333306de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
333406de276fff91264437fa75111ed76de43097e089Ted Kremenek}
333506de276fff91264437fa75111ed76de43097e089Ted Kremenek
333606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that
333706de276fff91264437fa75111ed76de43097e089Ted Kremenek///  check if the expression in a return statement evaluates to an address
333826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  to a location on the stack, a local block, an address of a label, or a
333926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  reference to local temporary. The recursion is used to traverse the
334006de276fff91264437fa75111ed76de43097e089Ted Kremenek///  AST of the return expression, with recursion backtracking when we
334126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  encounter a subexpression that (1) clearly does not lead to one of the
334226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  above problematic expressions (2) is something we cannot determine leads to
334326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  a problematic expression based on such local checking.
334426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///
334526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  Both EvalAddr and EvalVal follow through reference variables to evaluate
334626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  the expression that they point to. Such variables are added to the
334726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  'refVars' vector so that we know what the reference variable "trail" was.
334806de276fff91264437fa75111ed76de43097e089Ted Kremenek///
3349e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek///  EvalAddr processes expressions that are pointers that are used as
3350e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek///  references (and not L-values).  EvalVal handles all other values.
335126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  At the base case of the recursion is a check for the above problematic
335226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis///  expressions.
335306de276fff91264437fa75111ed76de43097e089Ted Kremenek///
335406de276fff91264437fa75111ed76de43097e089Ted Kremenek///  This implementation handles:
335506de276fff91264437fa75111ed76de43097e089Ted Kremenek///
335606de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * pointer-to-pointer casts
335706de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * implicit conversions from array references to pointers
335806de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * taking the address of fields
335906de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * arbitrary interplay between "&" and "*" operators
336006de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * pointer arithmetic from an address of a stack variable
336106de276fff91264437fa75111ed76de43097e089Ted Kremenek///   * taking the address of an array element where the array is on the stack
3362e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
3363e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                      Decl *ParentDecl) {
336426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  if (E->isTypeDependent())
336526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      return NULL;
336626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
336706de276fff91264437fa75111ed76de43097e089Ted Kremenek  // We should only be called for evaluating pointer expressions.
33680f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall  assert((E->getType()->isAnyPointerType() ||
3369dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff          E->getType()->isBlockPointerType() ||
3370a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek          E->getType()->isObjCQualifiedIdType()) &&
3371fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner         "EvalAddr only works on pointers");
33721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3373f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne  E = E->IgnoreParens();
3374f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne
337506de276fff91264437fa75111ed76de43097e089Ted Kremenek  // Our "symbolic interpreter" is just a dispatch off the currently
337606de276fff91264437fa75111ed76de43097e089Ted Kremenek  // viewed AST node.  We then recursively traverse the AST by calling
337706de276fff91264437fa75111ed76de43097e089Ted Kremenek  // EvalAddr and EvalVal appropriately.
337806de276fff91264437fa75111ed76de43097e089Ted Kremenek  switch (E->getStmtClass()) {
337926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  case Stmt::DeclRefExprClass: {
338026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    DeclRefExpr *DR = cast<DeclRefExpr>(E);
338126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
338226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
338326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      // If this is a reference variable, follow through to the expression that
338426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      // it points to.
338526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      if (V->hasLocalStorage() &&
338626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis          V->getType()->isReferenceType() && V->hasInit()) {
338726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        // Add the reference variable to the "trail".
338826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        refVars.push_back(DR);
3389e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis        return EvalAddr(V->getInit(), refVars, ParentDecl);
339026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      }
339126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
339226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    return NULL;
339326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  }
339406de276fff91264437fa75111ed76de43097e089Ted Kremenek
3395fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  case Stmt::UnaryOperatorClass: {
3396fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // The only unary operator that make sense to handle here
3397fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // is AddrOf.  All others don't make sense as pointers.
3398fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    UnaryOperator *U = cast<UnaryOperator>(E);
33991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
34002de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    if (U->getOpcode() == UO_AddrOf)
3401e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      return EvalVal(U->getSubExpr(), refVars, ParentDecl);
3402fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    else
3403fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner      return NULL;
3404fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  }
34051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3406fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  case Stmt::BinaryOperatorClass: {
3407fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // Handle pointer arithmetic.  All other binary operators are not valid
3408fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // in this context.
3409fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    BinaryOperator *B = cast<BinaryOperator>(E);
34102de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    BinaryOperatorKind op = B->getOpcode();
34111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
34122de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    if (op != BO_Add && op != BO_Sub)
3413fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner      return NULL;
34141eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3415fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    Expr *Base = B->getLHS();
34163907323dd6665c0c4e383435cb145233f4533406Anders Carlsson
3417fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // Determine which argument is the real pointer base.  It could be
3418fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // the RHS argument instead of the LHS.
3419fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    if (!Base->getType()->isPointerType()) Base = B->getRHS();
34201eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3421fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    assert (Base->getType()->isPointerType());
3422e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalAddr(Base, refVars, ParentDecl);
3423fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  }
342461f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff
3425fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  // For conditional operators we need to see if either the LHS or RHS are
3426fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  // valid DeclRefExpr*s.  If one of them is valid, we return it.
3427fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  case Stmt::ConditionalOperatorClass: {
3428fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    ConditionalOperator *C = cast<ConditionalOperator>(E);
34291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3430fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    // Handle the GNU extension for missing LHS.
34319ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    if (Expr *lhsExpr = C->getLHS()) {
34329ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    // In C++, we can have a throw-expression, which has 'void' type.
34339ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor      if (!lhsExpr->getType()->isVoidType())
3434e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis        if (Expr* LHS = EvalAddr(lhsExpr, refVars, ParentDecl))
34359ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor          return LHS;
34369ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    }
34379ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor
34389ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    // In C++, we can have a throw-expression, which has 'void' type.
34399ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor    if (C->getRHS()->getType()->isVoidType())
34409ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor      return NULL;
344106de276fff91264437fa75111ed76de43097e089Ted Kremenek
3442e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalAddr(C->getRHS(), refVars, ParentDecl);
3443fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  }
344426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
344526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  case Stmt::BlockExprClass:
3446469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall    if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures())
344726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      return E; // local block.
344826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    return NULL;
344926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
345026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis  case Stmt::AddrLabelExprClass:
345126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    return E; // address of label.
34521eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
345380ee6e878a169e6255d4686a91bb696151ff229fJohn McCall  case Stmt::ExprWithCleanupsClass:
3454e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,
3455e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                    ParentDecl);
345680ee6e878a169e6255d4686a91bb696151ff229fJohn McCall
345754b5274f2c190331438375ad114dad12ae098b57Ted Kremenek  // For casts, we need to handle conversions from arrays to
345854b5274f2c190331438375ad114dad12ae098b57Ted Kremenek  // pointer values, and pointer-to-pointer conversions.
345949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor  case Stmt::ImplicitCastExprClass:
34606eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor  case Stmt::CStyleCastExprClass:
3461f85e193739c953358c865005855253af4f68a497John McCall  case Stmt::CXXFunctionalCastExprClass:
34628b9414e868853fc052251455674bf7512261e14aEli Friedman  case Stmt::ObjCBridgedCastExprClass:
34631eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  case Stmt::CXXStaticCastExprClass:
34641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump  case Stmt::CXXDynamicCastExprClass:
346549badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor  case Stmt::CXXConstCastExprClass:
346649badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor  case Stmt::CXXReinterpretCastExprClass: {
34678b9414e868853fc052251455674bf7512261e14aEli Friedman    Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
34688b9414e868853fc052251455674bf7512261e14aEli Friedman    switch (cast<CastExpr>(E)->getCastKind()) {
34698b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_BitCast:
34708b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_LValueToRValue:
34718b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_NoOp:
34728b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_BaseToDerived:
34738b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_DerivedToBase:
34748b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_UncheckedDerivedToBase:
34758b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_Dynamic:
34768b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_CPointerToObjCPointerCast:
34778b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_BlockPointerToObjCPointerCast:
34788b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_AnyPointerToBlockPointerCast:
3479e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      return EvalAddr(SubExpr, refVars, ParentDecl);
34808b9414e868853fc052251455674bf7512261e14aEli Friedman
34818b9414e868853fc052251455674bf7512261e14aEli Friedman    case CK_ArrayToPointerDecay:
3482e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      return EvalVal(SubExpr, refVars, ParentDecl);
34838b9414e868853fc052251455674bf7512261e14aEli Friedman
34848b9414e868853fc052251455674bf7512261e14aEli Friedman    default:
34858b9414e868853fc052251455674bf7512261e14aEli Friedman      return 0;
34868b9414e868853fc052251455674bf7512261e14aEli Friedman    }
3487fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  }
34881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
348903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor  case Stmt::MaterializeTemporaryExprClass:
349003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor    if (Expr *Result = EvalAddr(
349103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor                         cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(),
3492e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                                refVars, ParentDecl))
349303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor      return Result;
349403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor
349503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor    return E;
349603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor
3497fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  // Everything else: we simply don't reason about them.
3498fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner  default:
3499fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner    return NULL;
350006de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
350106de276fff91264437fa75111ed76de43097e089Ted Kremenek}
35021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
350306de276fff91264437fa75111ed76de43097e089Ted Kremenek
350406de276fff91264437fa75111ed76de43097e089Ted Kremenek///  EvalVal - This function is complements EvalAddr in the mutual recursion.
350506de276fff91264437fa75111ed76de43097e089Ted Kremenek///   See the comments for EvalAddr for more details.
3506e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
3507e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                     Decl *ParentDecl) {
350868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo {
3509e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek  // We should only be called for evaluating non-pointer expressions, or
3510e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek  // expressions with a pointer type that are not used as references but instead
3511e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek  // are l-values (e.g., DeclRefExpr with a pointer type).
35121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
351306de276fff91264437fa75111ed76de43097e089Ted Kremenek  // Our "symbolic interpreter" is just a dispatch off the currently
351406de276fff91264437fa75111ed76de43097e089Ted Kremenek  // viewed AST node.  We then recursively traverse the AST by calling
351506de276fff91264437fa75111ed76de43097e089Ted Kremenek  // EvalAddr and EvalVal appropriately.
3516f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne
3517f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne  E = E->IgnoreParens();
351806de276fff91264437fa75111ed76de43097e089Ted Kremenek  switch (E->getStmtClass()) {
351968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek  case Stmt::ImplicitCastExprClass: {
352068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek    ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E);
35215baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall    if (IE->getValueKind() == VK_LValue) {
352268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek      E = IE->getSubExpr();
352368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek      continue;
352468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek    }
352568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek    return NULL;
352668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek  }
352768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek
352880ee6e878a169e6255d4686a91bb696151ff229fJohn McCall  case Stmt::ExprWithCleanupsClass:
3529e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,ParentDecl);
353080ee6e878a169e6255d4686a91bb696151ff229fJohn McCall
3531a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor  case Stmt::DeclRefExprClass: {
353226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // When we hit a DeclRefExpr we are looking at code that refers to a
353326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // variable's name. If it's not a reference variable we check if it has
353426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // local storage within the function, and if so, return the expression.
353506de276fff91264437fa75111ed76de43097e089Ted Kremenek    DeclRefExpr *DR = cast<DeclRefExpr>(E);
35361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3537e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) {
3538e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      // Check if it refers to itself, e.g. "int& i = i;".
3539e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      if (V == ParentDecl)
3540e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis        return DR;
3541e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis
354226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      if (V->hasLocalStorage()) {
354326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        if (!V->getType()->isReferenceType())
354426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis          return DR;
354526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
354626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        // Reference variable, follow through to the expression that
354726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        // it points to.
354826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        if (V->hasInit()) {
354926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis          // Add the reference variable to the "trail".
355026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis          refVars.push_back(DR);
3551e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis          return EvalVal(V->getInit(), refVars, V);
355226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis        }
355326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      }
3554e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    }
35551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
355606de276fff91264437fa75111ed76de43097e089Ted Kremenek    return NULL;
355706de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
35581eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
355906de276fff91264437fa75111ed76de43097e089Ted Kremenek  case Stmt::UnaryOperatorClass: {
356006de276fff91264437fa75111ed76de43097e089Ted Kremenek    // The only unary operator that make sense to handle here
356106de276fff91264437fa75111ed76de43097e089Ted Kremenek    // is Deref.  All others don't resolve to a "name."  This includes
356206de276fff91264437fa75111ed76de43097e089Ted Kremenek    // handling all sorts of rvalues passed to a unary operator.
356306de276fff91264437fa75111ed76de43097e089Ted Kremenek    UnaryOperator *U = cast<UnaryOperator>(E);
35641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
35652de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    if (U->getOpcode() == UO_Deref)
3566e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      return EvalAddr(U->getSubExpr(), refVars, ParentDecl);
356706de276fff91264437fa75111ed76de43097e089Ted Kremenek
356806de276fff91264437fa75111ed76de43097e089Ted Kremenek    return NULL;
356906de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
35701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
357106de276fff91264437fa75111ed76de43097e089Ted Kremenek  case Stmt::ArraySubscriptExprClass: {
357206de276fff91264437fa75111ed76de43097e089Ted Kremenek    // Array subscripts are potential references to data on the stack.  We
357306de276fff91264437fa75111ed76de43097e089Ted Kremenek    // retrieve the DeclRefExpr* for the array variable if it indeed
357406de276fff91264437fa75111ed76de43097e089Ted Kremenek    // has local storage.
3575e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars,ParentDecl);
357606de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
35771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
357806de276fff91264437fa75111ed76de43097e089Ted Kremenek  case Stmt::ConditionalOperatorClass: {
357906de276fff91264437fa75111ed76de43097e089Ted Kremenek    // For conditional operators we need to see if either the LHS or RHS are
358026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // non-NULL Expr's.  If one is non-NULL, we return it.
358106de276fff91264437fa75111ed76de43097e089Ted Kremenek    ConditionalOperator *C = cast<ConditionalOperator>(E);
358206de276fff91264437fa75111ed76de43097e089Ted Kremenek
35833907323dd6665c0c4e383435cb145233f4533406Anders Carlsson    // Handle the GNU extension for missing LHS.
35843907323dd6665c0c4e383435cb145233f4533406Anders Carlsson    if (Expr *lhsExpr = C->getLHS())
3585e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis      if (Expr *LHS = EvalVal(lhsExpr, refVars, ParentDecl))
35863907323dd6665c0c4e383435cb145233f4533406Anders Carlsson        return LHS;
35873907323dd6665c0c4e383435cb145233f4533406Anders Carlsson
3588e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalVal(C->getRHS(), refVars, ParentDecl);
358906de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
35901eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
359106de276fff91264437fa75111ed76de43097e089Ted Kremenek  // Accesses to members are potential references to data on the stack.
359283f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor  case Stmt::MemberExprClass: {
359306de276fff91264437fa75111ed76de43097e089Ted Kremenek    MemberExpr *M = cast<MemberExpr>(E);
35941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
359506de276fff91264437fa75111ed76de43097e089Ted Kremenek    // Check for indirect access.  We only want direct field accesses.
3596a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek    if (M->isArrow())
3597a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek      return NULL;
3598a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek
3599a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek    // Check whether the member type is itself a reference, in which case
3600a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek    // we're not going to refer to the member, but to what the member refers to.
3601a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek    if (M->getMemberDecl()->getType()->isReferenceType())
360206de276fff91264437fa75111ed76de43097e089Ted Kremenek      return NULL;
3603a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek
3604e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis    return EvalVal(M->getBase(), refVars, ParentDecl);
360506de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
36061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
360703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor  case Stmt::MaterializeTemporaryExprClass:
360803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor    if (Expr *Result = EvalVal(
360903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor                          cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(),
3610e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis                               refVars, ParentDecl))
361103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor      return Result;
361203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor
361303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor    return E;
361403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor
361506de276fff91264437fa75111ed76de43097e089Ted Kremenek  default:
361626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // Check that we don't return or take the address of a reference to a
361726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // temporary. This is only useful in C++.
361826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    if (!E->isTypeDependent() && E->isRValue())
361926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis      return E;
362026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis
362126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis    // Everything else: we simply don't reason about them.
362206de276fff91264437fa75111ed76de43097e089Ted Kremenek    return NULL;
362306de276fff91264437fa75111ed76de43097e089Ted Kremenek  }
362468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true);
362506de276fff91264437fa75111ed76de43097e089Ted Kremenek}
3626588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek
3627588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===//
3628588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek
3629588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==.
3630588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely
3631588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended.
3632dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieuvoid Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) {
3633dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts();
3634dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  Expr* RightExprSansParen = RHS->IgnoreParenImpCasts();
3635588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek
3636588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  // Special case: check for x == x (which is OK).
3637588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  // Do not emit warnings for such cases.
3638588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen))
3639588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek    if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen))
3640588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek      if (DRL->getDecl() == DRR->getDecl())
3641980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie        return;
36421eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
36431eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
36441b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  // Special case: check for comparisons against literals that can be exactly
36451b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  //  represented by APFloat.  In such cases, do not emit a warning.  This
36461b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  //  is a heuristic: often comparison against such literals are used to
36471b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  //  detect if a value in a variable has not changed.  This clearly can
36481b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek  //  lead to false negatives.
3649980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) {
3650980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    if (FLL->isExact())
3651980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie      return;
3652980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  } else
3653980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen))
3654980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie      if (FLR->isExact())
3655980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie        return;
36561eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3657588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  // Check for comparisons with builtin types.
3658980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen))
3659980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    if (CL->isBuiltinCall())
3660980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie      return;
36611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3662980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen))
3663980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    if (CR->isBuiltinCall())
3664980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie      return;
36651eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump
3666588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek  // Emit the diagnostic.
3667980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie  Diag(Loc, diag::warn_floatingpoint_eq)
3668980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie    << LHS->getSourceRange() << RHS->getSourceRange();
3669588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek}
3670ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
3671f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===//
3672f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===//
3673ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
3674f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace {
3675ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
3676f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued
3677f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression.
3678f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange {
3679f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  /// The number of bits active in the int.
3680f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  unsigned Width;
3681ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
3682f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  /// True if the int is known not to have negative values.
3683f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  bool NonNegative;
368451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3685f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  IntRange(unsigned Width, bool NonNegative)
3686f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    : Width(Width), NonNegative(NonNegative)
3687f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  {}
368851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
36891844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the range of the bool type.
3690f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  static IntRange forBoolType() {
3691f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(1, true);
3692f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  }
369351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
36941844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the range of an opaque value of the given integral type.
36951844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  static IntRange forValueOfType(ASTContext &C, QualType T) {
36961844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    return forValueOfCanonicalType(C,
36971844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall                          T->getCanonicalTypeInternal().getTypePtr());
369851313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
369951313c39c84407dd6a323be99a8c322bf8d052a9John McCall
37001844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the range of an opaque value of a canonical integral type.
37011844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) {
3702f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    assert(T->isCanonicalUnqualified());
370351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3704f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    if (const VectorType *VT = dyn_cast<VectorType>(T))
3705f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      T = VT->getElementType().getTypePtr();
3706f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    if (const ComplexType *CT = dyn_cast<ComplexType>(T))
3707f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      T = CT->getElementType().getTypePtr();
3708323ed74658bc8375278eabf074b4777458376540John McCall
3709091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    // For enum types, use the known bit width of the enumerators.
3710323ed74658bc8375278eabf074b4777458376540John McCall    if (const EnumType *ET = dyn_cast<EnumType>(T)) {
3711323ed74658bc8375278eabf074b4777458376540John McCall      EnumDecl *Enum = ET->getDecl();
37125e1cdac63c3d9c9b32fa41fa0b2d242a58a20d49John McCall      if (!Enum->isCompleteDefinition())
3713091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall        return IntRange(C.getIntWidth(QualType(T, 0)), false);
3714091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall
3715323ed74658bc8375278eabf074b4777458376540John McCall      unsigned NumPositive = Enum->getNumPositiveBits();
3716323ed74658bc8375278eabf074b4777458376540John McCall      unsigned NumNegative = Enum->getNumNegativeBits();
3717323ed74658bc8375278eabf074b4777458376540John McCall
3718323ed74658bc8375278eabf074b4777458376540John McCall      return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0);
3719323ed74658bc8375278eabf074b4777458376540John McCall    }
372051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3721f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    const BuiltinType *BT = cast<BuiltinType>(T);
3722f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    assert(BT->isInteger());
372351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3724f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
372551313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
372651313c39c84407dd6a323be99a8c322bf8d052a9John McCall
37271844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the "target" range of a canonical integral type, i.e.
37281844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// the range of values expressible in the type.
37291844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  ///
37301844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// This matches forValueOfCanonicalType except that enums have the
37311844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// full range of their type, not the range of their enumerators.
37321844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) {
37331844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    assert(T->isCanonicalUnqualified());
37341844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall
37351844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    if (const VectorType *VT = dyn_cast<VectorType>(T))
37361844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      T = VT->getElementType().getTypePtr();
37371844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    if (const ComplexType *CT = dyn_cast<ComplexType>(T))
37381844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      T = CT->getElementType().getTypePtr();
37391844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    if (const EnumType *ET = dyn_cast<EnumType>(T))
374069ff26bd1e7a2faffec0c3b9740cfb0c6bb354c5Douglas Gregor      T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr();
37411844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall
37421844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    const BuiltinType *BT = cast<BuiltinType>(T);
37431844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    assert(BT->isInteger());
37441844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall
37451844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
37461844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  }
37471844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall
37481844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the supremum of two ranges: i.e. their conservative merge.
3749c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall  static IntRange join(IntRange L, IntRange R) {
3750f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(std::max(L.Width, R.Width),
375160fad45739b764886f707bd204eae9ecce6db1f2John McCall                    L.NonNegative && R.NonNegative);
375260fad45739b764886f707bd204eae9ecce6db1f2John McCall  }
375360fad45739b764886f707bd204eae9ecce6db1f2John McCall
37541844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  /// Returns the infinum of two ranges: i.e. their aggressive merge.
3755c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall  static IntRange meet(IntRange L, IntRange R) {
375660fad45739b764886f707bd204eae9ecce6db1f2John McCall    return IntRange(std::min(L.Width, R.Width),
375760fad45739b764886f707bd204eae9ecce6db1f2John McCall                    L.NonNegative || R.NonNegative);
375851313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
3759f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall};
376051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
37610692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, llvm::APSInt &value,
37620692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                              unsigned MaxWidth) {
3763f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (value.isSigned() && value.isNegative())
3764f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(value.getMinSignedBits(), false);
376551313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3766f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (value.getBitWidth() > MaxWidth)
37679f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad    value = value.trunc(MaxWidth);
376851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3769f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // isNonNegative() just checks the sign bit without considering
3770f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // signedness.
3771f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  return IntRange(value.getActiveBits(), true);
377251313c39c84407dd6a323be99a8c322bf8d052a9John McCall}
377351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
37740692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty,
37750692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                              unsigned MaxWidth) {
3776f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (result.isInt())
3777f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return GetValueRange(C, result.getInt(), MaxWidth);
377851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3779f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (result.isVector()) {
37800acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall    IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth);
37810acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall    for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) {
37820acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall      IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth);
37830acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall      R = IntRange::join(R, El);
37840acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall    }
3785f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return R;
378651313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
378751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3788f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (result.isComplexInt()) {
3789f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth);
3790f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth);
3791f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange::join(R, I);
3792f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  }
3793f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
3794f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // This can happen with lossless casts to intptr_t of "based" lvalues.
3795f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // Assume it might use arbitrary bits.
37960acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall  // FIXME: The only reason we need to pass the type in here is to get
37970acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall  // the sign right on this one case.  It would be nice if APValue
37980acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall  // preserved this.
379965639284118d54ddf2e51a05d2ffccda567fe246Eli Friedman  assert(result.isLValue() || result.isAddrLabelDiff());
38005e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor  return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType());
380151313c39c84407dd6a323be99a8c322bf8d052a9John McCall}
380251313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3803f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the
3804f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take.
3805f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall///
3806f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated
38070692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) {
380851313c39c84407dd6a323be99a8c322bf8d052a9John McCall  E = E->IgnoreParens();
380951313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3810f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // Try a full evaluation first.
3811f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  Expr::EvalResult result;
381251f4708c00110940ca3f337961915f2ca1668375Richard Smith  if (E->EvaluateAsRValue(result, C))
38130acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall    return GetValueRange(C, result.Val, E->getType(), MaxWidth);
381451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3815f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // I think we only want to look through implicit casts here; if the
3816f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // user has an explicit widening cast, we should treat the value as
3817f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  // being of the new, wider type.
3818f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) {
3819b17ee5bff0d7986c14cdddb279e0131bd7f9678dEli Friedman    if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue)
3820f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return GetExprRange(C, CE->getSubExpr(), MaxWidth);
382151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
38221844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType());
382351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
38242de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast);
382560fad45739b764886f707bd204eae9ecce6db1f2John McCall
3826f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Assume that non-integer casts can span the full range of the type.
382760fad45739b764886f707bd204eae9ecce6db1f2John McCall    if (!isIntegerCast)
3828f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return OutputTypeRange;
382951313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3830f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange SubRange
3831f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      = GetExprRange(C, CE->getSubExpr(),
3832f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall                     std::min(MaxWidth, OutputTypeRange.Width));
383351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3834f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Bail out if the subexpr's range is as wide as the cast type.
3835f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    if (SubRange.Width >= OutputTypeRange.Width)
3836f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return OutputTypeRange;
383751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3838f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Otherwise, we take the smaller width, and we're non-negative if
3839f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // either the output type or the subexpr is.
3840f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange(SubRange.Width,
3841f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall                    SubRange.NonNegative || OutputTypeRange.NonNegative);
3842f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  }
3843f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
3844f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
3845f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // If we can fold the condition, just take that operand.
3846f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    bool CondResult;
3847f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C))
3848f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return GetExprRange(C, CondResult ? CO->getTrueExpr()
3849f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall                                        : CO->getFalseExpr(),
3850f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall                          MaxWidth);
3851f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
3852f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Otherwise, conservatively merge.
3853f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth);
3854f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth);
3855f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange::join(L, R);
385651313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
385751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
385851313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
385951313c39c84407dd6a323be99a8c322bf8d052a9John McCall    switch (BO->getOpcode()) {
386051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3861f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    // Boolean-valued operations are single-bit and positive.
38622de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_LAnd:
38632de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_LOr:
38642de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_LT:
38652de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_GT:
38662de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_LE:
38672de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_GE:
38682de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_EQ:
38692de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_NE:
3870f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return IntRange::forBoolType();
387151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
3872862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    // The type of the assignments is the type of the LHS, so the RHS
3873862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    // is not necessarily the same type.
38742de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_MulAssign:
38752de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_DivAssign:
38762de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_RemAssign:
38772de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_AddAssign:
38782de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_SubAssign:
3879862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    case BO_XorAssign:
3880862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    case BO_OrAssign:
3881862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall      // TODO: bitfields?
38821844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      return IntRange::forValueOfType(C, E->getType());
3883c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall
3884862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    // Simple assignments just pass through the RHS, which will have
3885862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    // been coerced to the LHS type.
3886862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall    case BO_Assign:
3887862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall      // TODO: bitfields?
3888862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall      return GetExprRange(C, BO->getRHS(), MaxWidth);
3889862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall
389051313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // Operations with opaque sources are black-listed.
38912de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_PtrMemD:
38922de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_PtrMemI:
38931844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      return IntRange::forValueOfType(C, E->getType());
389451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
389560fad45739b764886f707bd204eae9ecce6db1f2John McCall    // Bitwise-and uses the *infinum* of the two source ranges.
38962de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_And:
38972de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_AndAssign:
389860fad45739b764886f707bd204eae9ecce6db1f2John McCall      return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth),
389960fad45739b764886f707bd204eae9ecce6db1f2John McCall                            GetExprRange(C, BO->getRHS(), MaxWidth));
390060fad45739b764886f707bd204eae9ecce6db1f2John McCall
390151313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // Left shift gets black-listed based on a judgement call.
39022de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_Shl:
39033aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      // ...except that we want to treat '1 << (blah)' as logically
39043aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      // positive.  It's an important idiom.
39053aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      if (IntegerLiteral *I
39063aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall            = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) {
39073aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall        if (I->getValue() == 1) {
39081844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall          IntRange R = IntRange::forValueOfType(C, E->getType());
39093aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall          return IntRange(R.Width, /*NonNegative*/ true);
39103aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall        }
39113aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      }
39123aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall      // fallthrough
39133aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall
39142de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_ShlAssign:
39151844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      return IntRange::forValueOfType(C, E->getType());
391651313c39c84407dd6a323be99a8c322bf8d052a9John McCall
391760fad45739b764886f707bd204eae9ecce6db1f2John McCall    // Right shift by a constant can narrow its left argument.
39182de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_Shr:
39192de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_ShrAssign: {
392060fad45739b764886f707bd204eae9ecce6db1f2John McCall      IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
392160fad45739b764886f707bd204eae9ecce6db1f2John McCall
392260fad45739b764886f707bd204eae9ecce6db1f2John McCall      // If the shift amount is a positive constant, drop the width by
392360fad45739b764886f707bd204eae9ecce6db1f2John McCall      // that much.
392460fad45739b764886f707bd204eae9ecce6db1f2John McCall      llvm::APSInt shift;
392560fad45739b764886f707bd204eae9ecce6db1f2John McCall      if (BO->getRHS()->isIntegerConstantExpr(shift, C) &&
392660fad45739b764886f707bd204eae9ecce6db1f2John McCall          shift.isNonNegative()) {
392760fad45739b764886f707bd204eae9ecce6db1f2John McCall        unsigned zext = shift.getZExtValue();
392860fad45739b764886f707bd204eae9ecce6db1f2John McCall        if (zext >= L.Width)
392960fad45739b764886f707bd204eae9ecce6db1f2John McCall          L.Width = (L.NonNegative ? 0 : 1);
393060fad45739b764886f707bd204eae9ecce6db1f2John McCall        else
393160fad45739b764886f707bd204eae9ecce6db1f2John McCall          L.Width -= zext;
393260fad45739b764886f707bd204eae9ecce6db1f2John McCall      }
393360fad45739b764886f707bd204eae9ecce6db1f2John McCall
393460fad45739b764886f707bd204eae9ecce6db1f2John McCall      return L;
393560fad45739b764886f707bd204eae9ecce6db1f2John McCall    }
393660fad45739b764886f707bd204eae9ecce6db1f2John McCall
393760fad45739b764886f707bd204eae9ecce6db1f2John McCall    // Comma acts as its right operand.
39382de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_Comma:
3939f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return GetExprRange(C, BO->getRHS(), MaxWidth);
3940f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
394160fad45739b764886f707bd204eae9ecce6db1f2John McCall    // Black-list pointer subtractions.
39422de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case BO_Sub:
394351313c39c84407dd6a323be99a8c322bf8d052a9John McCall      if (BO->getLHS()->getType()->isPointerType())
39441844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall        return IntRange::forValueOfType(C, E->getType());
394500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      break;
394600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
394700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // The width of a division result is mostly determined by the size
394800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // of the LHS.
394900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Div: {
395000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      // Don't 'pre-truncate' the operands.
395100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      unsigned opWidth = C.getIntWidth(E->getType());
395200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange L = GetExprRange(C, BO->getLHS(), opWidth);
395300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
395400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      // If the divisor is constant, use that.
395500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      llvm::APSInt divisor;
395600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) {
395700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall        unsigned log2 = divisor.logBase2(); // floor(log_2(divisor))
395800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall        if (log2 >= L.Width)
395900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall          L.Width = (L.NonNegative ? 0 : 1);
396000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall        else
396100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall          L.Width = std::min(L.Width - log2, MaxWidth);
396200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall        return L;
396300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      }
396400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
396500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      // Otherwise, just use the LHS's width.
396600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange R = GetExprRange(C, BO->getRHS(), opWidth);
396700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      return IntRange(L.Width, L.NonNegative && R.NonNegative);
396800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    }
396900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
397000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // The result of a remainder can't be larger than the result of
397100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // either side.
397200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Rem: {
397300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      // Don't 'pre-truncate' the operands.
397400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      unsigned opWidth = C.getIntWidth(E->getType());
397500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange L = GetExprRange(C, BO->getLHS(), opWidth);
397600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange R = GetExprRange(C, BO->getRHS(), opWidth);
397700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall
397800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      IntRange meet = IntRange::meet(L, R);
397900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      meet.Width = std::min(meet.Width, MaxWidth);
398000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall      return meet;
398100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    }
39824e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek
398300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // The default behavior is okay for these.
398400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Mul:
398500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Add:
398600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Xor:
398700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    case BO_Or:
3988f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      break;
398951313c39c84407dd6a323be99a8c322bf8d052a9John McCall    }
3990f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
399100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // The default case is to treat the operation as if it were closed
399200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall    // on the narrowest type that encompasses both operands.
3993f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
3994f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth);
3995f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IntRange::join(L, R);
399651313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
399751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
399851313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
399951313c39c84407dd6a323be99a8c322bf8d052a9John McCall    switch (UO->getOpcode()) {
400051313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // Boolean-valued operations are white-listed.
40012de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case UO_LNot:
4002f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return IntRange::forBoolType();
400351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
400451313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // Operations with opaque sources are black-listed.
40052de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case UO_Deref:
40062de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall    case UO_AddrOf: // should be impossible
40071844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall      return IntRange::forValueOfType(C, E->getType());
400851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
400951313c39c84407dd6a323be99a8c322bf8d052a9John McCall    default:
4010f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      return GetExprRange(C, UO->getSubExpr(), MaxWidth);
401151313c39c84407dd6a323be99a8c322bf8d052a9John McCall    }
401251313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
40138ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor
40148ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor  if (dyn_cast<OffsetOfExpr>(E)) {
40151844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall    IntRange::forValueOfType(C, E->getType());
40168ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor  }
401751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4018a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith  if (FieldDecl *BitField = E->getBitField())
4019a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith    return IntRange(BitField->getBitWidthValue(C),
40205e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor                    BitField->getType()->isUnsignedIntegerOrEnumerationType());
4021f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
40221844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  return IntRange::forValueOfType(C, E->getType());
4023f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}
4024f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
40250692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E) {
4026323ed74658bc8375278eabf074b4777458376540John McCall  return GetExprRange(C, E, C.getIntWidth(E->getType()));
4027323ed74658bc8375278eabf074b4777458376540John McCall}
4028323ed74658bc8375278eabf074b4777458376540John McCall
4029f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given
4030f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the
4031f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics.
40320692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const llvm::APFloat &value,
40330692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                 const llvm::fltSemantics &Src,
40340692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                 const llvm::fltSemantics &Tgt) {
4035f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  llvm::APFloat truncated = value;
4036f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4037f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  bool ignored;
4038f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored);
4039f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored);
4040f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4041f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  return truncated.bitwiseIsEqual(value);
404251313c39c84407dd6a323be99a8c322bf8d052a9John McCall}
404351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4044f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given
4045f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the
4046f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics.
4047f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall///
4048f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number).
40490692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const APValue &value,
40500692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                 const llvm::fltSemantics &Src,
40510692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                 const llvm::fltSemantics &Tgt) {
4052f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (value.isFloat())
4053f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return IsSameFloatAfterCast(value.getFloat(), Src, Tgt);
4054f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4055f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (value.isVector()) {
4056f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i)
4057f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall      if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt))
4058f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall        return false;
4059f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall    return true;
4060f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  }
4061f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4062f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  assert(value.isComplexFloat());
4063f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) &&
4064f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall          IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt));
4065f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}
4066f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
40670692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC);
4068323ed74658bc8375278eabf074b4777458376540John McCall
4069e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) {
4070e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek  // Suppress cases where we are comparing against an enum constant.
4071e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek  if (const DeclRefExpr *DR =
4072e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek      dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts()))
4073e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek    if (isa<EnumConstantDecl>(DR->getDecl()))
4074e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek      return false;
4075e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek
4076e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek  // Suppress cases where the '0' value is expanded from a macro.
4077e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek  if (E->getLocStart().isMacroID())
4078e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek    return false;
4079e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek
4080323ed74658bc8375278eabf074b4777458376540John McCall  llvm::APSInt Value;
4081323ed74658bc8375278eabf074b4777458376540John McCall  return E->isIntegerConstantExpr(Value, S.Context) && Value == 0;
4082323ed74658bc8375278eabf074b4777458376540John McCall}
4083323ed74658bc8375278eabf074b4777458376540John McCall
4084372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) {
4085372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall  // Strip off implicit integral promotions.
4086372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall  while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) {
408763b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis    if (ICE->getCastKind() != CK_IntegralCast &&
408863b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis        ICE->getCastKind() != CK_NoOp)
4089372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      break;
409063b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis    E = ICE->getSubExpr();
4091372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall  }
4092372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall
4093372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall  return E->getType()->isEnumeralType();
4094372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall}
4095372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall
40960692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) {
40972de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  BinaryOperatorKind op = E->getOpcode();
409814af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor  if (E->isValueDependent())
409914af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor    return;
410014af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor
41012de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  if (op == BO_LT && IsZero(S, E->getRHS())) {
4102323ed74658bc8375278eabf074b4777458376540John McCall    S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
4103372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      << "< 0" << "false" << HasEnumType(E->getLHS())
4104323ed74658bc8375278eabf074b4777458376540John McCall      << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
41052de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  } else if (op == BO_GE && IsZero(S, E->getRHS())) {
4106323ed74658bc8375278eabf074b4777458376540John McCall    S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
4107372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      << ">= 0" << "true" << HasEnumType(E->getLHS())
4108323ed74658bc8375278eabf074b4777458376540John McCall      << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
41092de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  } else if (op == BO_GT && IsZero(S, E->getLHS())) {
4110323ed74658bc8375278eabf074b4777458376540John McCall    S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
4111372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      << "0 >" << "false" << HasEnumType(E->getRHS())
4112323ed74658bc8375278eabf074b4777458376540John McCall      << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
41132de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall  } else if (op == BO_LE && IsZero(S, E->getLHS())) {
4114323ed74658bc8375278eabf074b4777458376540John McCall    S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
4115372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall      << "0 <=" << "true" << HasEnumType(E->getRHS())
4116323ed74658bc8375278eabf074b4777458376540John McCall      << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
4117323ed74658bc8375278eabf074b4777458376540John McCall  }
4118323ed74658bc8375278eabf074b4777458376540John McCall}
4119323ed74658bc8375278eabf074b4777458376540John McCall
4120323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison.  Implements the
4121323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison.
41220692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) {
4123b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc());
4124b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc());
4125323ed74658bc8375278eabf074b4777458376540John McCall}
4126f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4127ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare.
4128ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall///
4129dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu/// \param E the binary operator to check for warnings
41300692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeComparison(Sema &S, BinaryOperator *E) {
4131323ed74658bc8375278eabf074b4777458376540John McCall  // The type the comparison is being performed in.
4132323ed74658bc8375278eabf074b4777458376540John McCall  QualType T = E->getLHS()->getType();
4133323ed74658bc8375278eabf074b4777458376540John McCall  assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType())
4134323ed74658bc8375278eabf074b4777458376540John McCall         && "comparison with mismatched types");
4135323ed74658bc8375278eabf074b4777458376540John McCall
4136323ed74658bc8375278eabf074b4777458376540John McCall  // We don't do anything special if this isn't an unsigned integral
4137323ed74658bc8375278eabf074b4777458376540John McCall  // comparison:  we're only interested in integral comparisons, and
4138323ed74658bc8375278eabf074b4777458376540John McCall  // signed comparisons only happen in cases we don't care to warn about.
41393e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor  //
41403e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor  // We also don't care about value-dependent expressions or expressions
41413e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor  // whose result is a constant.
41423e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor  if (!T->hasUnsignedIntegerRepresentation()
41433e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor      || E->isValueDependent() || E->isIntegerConstantExpr(S.Context))
4144323ed74658bc8375278eabf074b4777458376540John McCall    return AnalyzeImpConvsInComparison(S, E);
4145323ed74658bc8375278eabf074b4777458376540John McCall
4146dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  Expr *LHS = E->getLHS()->IgnoreParenImpCasts();
4147dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  Expr *RHS = E->getRHS()->IgnoreParenImpCasts();
4148323ed74658bc8375278eabf074b4777458376540John McCall
4149323ed74658bc8375278eabf074b4777458376540John McCall  // Check to see if one of the (unmodified) operands is of different
4150323ed74658bc8375278eabf074b4777458376540John McCall  // signedness.
4151323ed74658bc8375278eabf074b4777458376540John McCall  Expr *signedOperand, *unsignedOperand;
4152dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  if (LHS->getType()->hasSignedIntegerRepresentation()) {
4153dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    assert(!RHS->getType()->hasSignedIntegerRepresentation() &&
4154323ed74658bc8375278eabf074b4777458376540John McCall           "unsigned comparison between two signed integer expressions?");
4155dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    signedOperand = LHS;
4156dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    unsignedOperand = RHS;
4157dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  } else if (RHS->getType()->hasSignedIntegerRepresentation()) {
4158dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    signedOperand = RHS;
4159dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu    unsignedOperand = LHS;
4160ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  } else {
4161323ed74658bc8375278eabf074b4777458376540John McCall    CheckTrivialUnsignedComparison(S, E);
4162323ed74658bc8375278eabf074b4777458376540John McCall    return AnalyzeImpConvsInComparison(S, E);
4163ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  }
4164ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
4165323ed74658bc8375278eabf074b4777458376540John McCall  // Otherwise, calculate the effective range of the signed operand.
4166323ed74658bc8375278eabf074b4777458376540John McCall  IntRange signedRange = GetExprRange(S.Context, signedOperand);
4167f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall
4168323ed74658bc8375278eabf074b4777458376540John McCall  // Go ahead and analyze implicit conversions in the operands.  Note
4169323ed74658bc8375278eabf074b4777458376540John McCall  // that we skip the implicit conversions on both sides.
4170dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc());
4171dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu  AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc());
4172ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
4173323ed74658bc8375278eabf074b4777458376540John McCall  // If the signed range is non-negative, -Wsign-compare won't fire,
4174323ed74658bc8375278eabf074b4777458376540John McCall  // but we should still check for comparisons which are always true
4175323ed74658bc8375278eabf074b4777458376540John McCall  // or false.
4176323ed74658bc8375278eabf074b4777458376540John McCall  if (signedRange.NonNegative)
4177323ed74658bc8375278eabf074b4777458376540John McCall    return CheckTrivialUnsignedComparison(S, E);
4178ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
4179ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  // For (in)equality comparisons, if the unsigned operand is a
4180ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  // constant which cannot collide with a overflowed signed operand,
4181ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  // then reinterpreting the signed operand as unsigned will not
4182ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall  // change the result of the comparison.
4183323ed74658bc8375278eabf074b4777458376540John McCall  if (E->isEqualityOp()) {
4184323ed74658bc8375278eabf074b4777458376540John McCall    unsigned comparisonWidth = S.Context.getIntWidth(T);
4185323ed74658bc8375278eabf074b4777458376540John McCall    IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand);
4186323ed74658bc8375278eabf074b4777458376540John McCall
4187323ed74658bc8375278eabf074b4777458376540John McCall    // We should never be unable to prove that the unsigned operand is
4188323ed74658bc8375278eabf074b4777458376540John McCall    // non-negative.
4189323ed74658bc8375278eabf074b4777458376540John McCall    assert(unsignedRange.NonNegative && "unsigned range includes negative?");
4190ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
4191323ed74658bc8375278eabf074b4777458376540John McCall    if (unsignedRange.Width < comparisonWidth)
4192323ed74658bc8375278eabf074b4777458376540John McCall      return;
4193323ed74658bc8375278eabf074b4777458376540John McCall  }
4194323ed74658bc8375278eabf074b4777458376540John McCall
41956d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor  S.DiagRuntimeBehavior(E->getOperatorLoc(), E,
41966d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor    S.PDiag(diag::warn_mixed_sign_comparison)
41976d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor      << LHS->getType() << RHS->getType()
41986d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor      << LHS->getSourceRange() << RHS->getSourceRange());
4199ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall}
4200ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall
420115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield.
420215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall///
420315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt.
42040692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init,
42050692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek                                      SourceLocation InitLoc) {
420615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  assert(Bitfield->isBitField());
420715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  if (Bitfield->isInvalidDecl())
420815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    return false;
420915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
421091b6014876e9186f968f74a8975ab8fc08ef1b68John McCall  // White-list bool bitfields.
421191b6014876e9186f968f74a8975ab8fc08ef1b68John McCall  if (Bitfield->getType()->isBooleanType())
421291b6014876e9186f968f74a8975ab8fc08ef1b68John McCall    return false;
421391b6014876e9186f968f74a8975ab8fc08ef1b68John McCall
421446ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor  // Ignore value- or type-dependent expressions.
421546ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor  if (Bitfield->getBitWidth()->isValueDependent() ||
421646ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor      Bitfield->getBitWidth()->isTypeDependent() ||
421746ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor      Init->isValueDependent() ||
421846ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor      Init->isTypeDependent())
421946ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor    return false;
422046ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor
422115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  Expr *OriginalInit = Init->IgnoreParenImpCasts();
422215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
422380d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith  llvm::APSInt Value;
422480d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith  if (!OriginalInit->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects))
422515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    return false;
422615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
422715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  unsigned OriginalWidth = Value.getBitWidth();
4228a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith  unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context);
422915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
423015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  if (OriginalWidth <= FieldWidth)
423115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    return false;
423215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
42333a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  // Compute the value which the bitfield will contain.
42349f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad  llvm::APSInt TruncatedValue = Value.trunc(FieldWidth);
42353a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  TruncatedValue.setIsSigned(Bitfield->getType()->isSignedIntegerType());
423615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
42373a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  // Check whether the stored value is equal to the original value.
42383a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  TruncatedValue = TruncatedValue.extend(OriginalWidth);
423915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  if (Value == TruncatedValue)
424015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    return false;
424115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
42423a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman  // Special-case bitfields of width 1: booleans are naturally 0/1, and
424334ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman  // therefore don't strictly fit into a signed bitfield of width 1.
424434ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman  if (FieldWidth == 1 && Value == 1)
42453a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman    return false;
42463a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman
424715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  std::string PrettyValue = Value.toString(10);
424815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  std::string PrettyTrunc = TruncatedValue.toString(10);
424915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
425015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant)
425115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    << PrettyValue << PrettyTrunc << OriginalInit->getType()
425215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    << Init->getSourceRange();
425315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
425415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  return true;
425515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall}
425615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
4257beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy
4258beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations.
42590692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeAssignment(Sema &S, BinaryOperator *E) {
4260beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  // Just recurse on the LHS.
4261beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc());
4262beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall
4263beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  // We want to recurse on the RHS as normal unless we're assigning to
4264beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  // a bitfield.
4265beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  if (FieldDecl *Bitfield = E->getLHS()->getBitField()) {
426615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall    if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(),
426715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall                                  E->getOperatorLoc())) {
426815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall      // Recurse, ignoring any implicit conversions on the RHS.
426915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall      return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(),
427015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall                                        E->getOperatorLoc());
4271beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall    }
4272beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  }
4273beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall
4274beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc());
4275beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall}
4276beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall
427751313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast;  purely a helper for CheckImplicitConversion.
42780692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T,
4279c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            SourceLocation CContext, unsigned diag,
4280c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            bool pruneControlFlow = false) {
4281c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  if (pruneControlFlow) {
4282c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    S.DiagRuntimeBehavior(E->getExprLoc(), E,
4283c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                          S.PDiag(diag)
4284c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            << SourceType << T << E->getSourceRange()
4285c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            << SourceRange(CContext));
4286c36bedc90c687caa71748480c60707ea4608b092Anna Zaks    return;
4287c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  }
42885a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  S.Diag(E->getExprLoc(), diag)
42895a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor    << SourceType << T << E->getSourceRange() << SourceRange(CContext);
42905a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor}
42915a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor
4292e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast;  purely a helper for CheckImplicitConversion.
42930692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType T,
4294c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            SourceLocation CContext, unsigned diag,
4295c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                            bool pruneControlFlow = false) {
4296c36bedc90c687caa71748480c60707ea4608b092Anna Zaks  DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow);
4297e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth}
4298e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth
42999ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// Diagnose an implicit cast from a literal expression. Does not warn when the
43009ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// cast wouldn't lose information.
4301f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruthvoid DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T,
4302f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth                                    SourceLocation CContext) {
43039ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay  // Try to convert the literal exactly to an integer. If we can, don't warn.
4304f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth  bool isExact = false;
43059ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay  const llvm::APFloat &Value = FL->getValue();
43063e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin  llvm::APSInt IntegerValue(S.Context.getIntWidth(T),
43073e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin                            T->hasUnsignedIntegerRepresentation());
43083e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin  if (Value.convertToInteger(IntegerValue,
4309f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth                             llvm::APFloat::rmTowardZero, &isExact)
43109ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay      == llvm::APFloat::opOK && isExact)
4311f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth    return;
4312f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth
4313be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  SmallString<16> PrettySourceValue;
4314be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  Value.toString(PrettySourceValue);
4315de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie  SmallString<16> PrettyTargetValue;
4316be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  if (T->isSpecificBuiltinType(BuiltinType::Bool))
4317be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    PrettyTargetValue = IntegerValue == 0 ? "false" : "true";
4318be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  else
4319de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie    IntegerValue.toString(PrettyTargetValue);
4320be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie
43219ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay  S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer)
4322be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    << FL->getType() << T.getUnqualifiedType() << PrettySourceValue
4323be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    << PrettyTargetValue << FL->getSourceRange() << SourceRange(CContext);
4324f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth}
4325f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth
4326091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) {
4327091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall  if (!Range.Width) return "0";
4328091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall
4329091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall  llvm::APSInt ValueInRange = Value;
4330091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall  ValueInRange.setIsSigned(!Range.NonNegative);
43319f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad  ValueInRange = ValueInRange.trunc(Range.Width);
4332091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall  return ValueInRange.toString(10);
4333091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall}
4334091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall
4335323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T,
4336b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall                             SourceLocation CC, bool *ICContext = 0) {
4337323ed74658bc8375278eabf074b4777458376540John McCall  if (E->isTypeDependent() || E->isValueDependent()) return;
433851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4339323ed74658bc8375278eabf074b4777458376540John McCall  const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr();
4340323ed74658bc8375278eabf074b4777458376540John McCall  const Type *Target = S.Context.getCanonicalType(T).getTypePtr();
4341323ed74658bc8375278eabf074b4777458376540John McCall  if (Source == Target) return;
4342323ed74658bc8375278eabf074b4777458376540John McCall  if (Target->isDependentType()) return;
434351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4344108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // If the conversion context location is invalid don't complain. We also
4345108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // don't want to emit a warning if the issue occurs from the expansion of
4346108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // a system macro. The problem is that 'getSpellingLoc()' is slow, so we
4347108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // delay this check as long as possible. Once we detect we are in that
4348108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth  // scenario, we just return.
4349ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek  if (CC.isInvalid())
4350b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return;
4351b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall
4352f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  // Diagnose implicit casts to bool.
4353f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  if (Target->isSpecificBuiltinType(BuiltinType::Bool)) {
4354f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu    if (isa<StringLiteral>(E))
4355f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      // Warn on string literal to bool.  Checks for string literals in logical
4356f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      // expressions, for instances, assert(0 && "error here"), is prevented
4357f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      // by a check in AnalyzeImplicitConversions().
4358f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      return DiagnoseImpCast(S, E, T, CC,
4359f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu                             diag::warn_impcast_string_literal_to_bool);
4360e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames    if (Source->isFunctionType()) {
4361e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      // Warn on function to bool. Checks free functions and static member
4362e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      // functions. Weakly imported functions are excluded from the check,
4363e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      // since it's common to test their value to check whether the linker
4364e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      // found a definition for them.
4365e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      ValueDecl *D = 0;
4366e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      if (DeclRefExpr* R = dyn_cast<DeclRefExpr>(E)) {
4367e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames        D = R->getDecl();
4368e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) {
4369e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames        D = M->getMemberDecl();
4370e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      }
4371e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames
4372e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      if (D && !D->isWeak()) {
437326b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu        if (FunctionDecl* F = dyn_cast<FunctionDecl>(D)) {
437426b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu          S.Diag(E->getExprLoc(), diag::warn_impcast_function_to_bool)
437526b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu            << F << E->getSourceRange() << SourceRange(CC);
43762def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          S.Diag(E->getExprLoc(), diag::note_function_to_bool_silence)
43772def77399ab3088106a2d61372344f5b7104e1a2David Blaikie            << FixItHint::CreateInsertion(E->getExprLoc(), "&");
43782def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          QualType ReturnType;
43792def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          UnresolvedSet<4> NonTemplateOverloads;
43802def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          S.isExprCallable(*E, ReturnType, NonTemplateOverloads);
43812def77399ab3088106a2d61372344f5b7104e1a2David Blaikie          if (!ReturnType.isNull()
43822def77399ab3088106a2d61372344f5b7104e1a2David Blaikie              && ReturnType->isSpecificBuiltinType(BuiltinType::Bool))
43832def77399ab3088106a2d61372344f5b7104e1a2David Blaikie            S.Diag(E->getExprLoc(), diag::note_function_to_bool_call)
43842def77399ab3088106a2d61372344f5b7104e1a2David Blaikie              << FixItHint::CreateInsertion(
43852def77399ab3088106a2d61372344f5b7104e1a2David Blaikie                 S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()), "()");
438626b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu          return;
438726b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu        }
4388e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames      }
4389e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames    }
4390f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  }
439151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
439251313c39c84407dd6a323be99a8c322bf8d052a9John McCall  // Strip vector types.
439351313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (isa<VectorType>(Source)) {
4394ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    if (!isa<VectorType>(Target)) {
4395d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay      if (S.SourceMgr.isInSystemMacro(CC))
4396ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek        return;
4397b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall      return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar);
4398ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    }
4399b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner
4400b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner    // If the vector cast is cast between two vectors of the same size, it is
4401b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner    // a bitcast, not a conversion.
4402b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner    if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target))
4403b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner      return;
440451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
440551313c39c84407dd6a323be99a8c322bf8d052a9John McCall    Source = cast<VectorType>(Source)->getElementType().getTypePtr();
440651313c39c84407dd6a323be99a8c322bf8d052a9John McCall    Target = cast<VectorType>(Target)->getElementType().getTypePtr();
440751313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
440851313c39c84407dd6a323be99a8c322bf8d052a9John McCall
440951313c39c84407dd6a323be99a8c322bf8d052a9John McCall  // Strip complex types.
441051313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (isa<ComplexType>(Source)) {
4411ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    if (!isa<ComplexType>(Target)) {
4412d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay      if (S.SourceMgr.isInSystemMacro(CC))
4413ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek        return;
4414ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4415b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall      return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar);
4416ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    }
441751313c39c84407dd6a323be99a8c322bf8d052a9John McCall
441851313c39c84407dd6a323be99a8c322bf8d052a9John McCall    Source = cast<ComplexType>(Source)->getElementType().getTypePtr();
441951313c39c84407dd6a323be99a8c322bf8d052a9John McCall    Target = cast<ComplexType>(Target)->getElementType().getTypePtr();
442051313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
442151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
442251313c39c84407dd6a323be99a8c322bf8d052a9John McCall  const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source);
442351313c39c84407dd6a323be99a8c322bf8d052a9John McCall  const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target);
442451313c39c84407dd6a323be99a8c322bf8d052a9John McCall
442551313c39c84407dd6a323be99a8c322bf8d052a9John McCall  // If the source is floating point...
442651313c39c84407dd6a323be99a8c322bf8d052a9John McCall  if (SourceBT && SourceBT->isFloatingPoint()) {
442751313c39c84407dd6a323be99a8c322bf8d052a9John McCall    // ...and the target is floating point...
442851313c39c84407dd6a323be99a8c322bf8d052a9John McCall    if (TargetBT && TargetBT->isFloatingPoint()) {
442951313c39c84407dd6a323be99a8c322bf8d052a9John McCall      // ...then warn if we're dropping FP rank.
443051313c39c84407dd6a323be99a8c322bf8d052a9John McCall
443151313c39c84407dd6a323be99a8c322bf8d052a9John McCall      // Builtin FP kinds are ordered by increasing FP rank.
443251313c39c84407dd6a323be99a8c322bf8d052a9John McCall      if (SourceBT->getKind() > TargetBT->getKind()) {
443351313c39c84407dd6a323be99a8c322bf8d052a9John McCall        // Don't warn about float constants that are precisely
443451313c39c84407dd6a323be99a8c322bf8d052a9John McCall        // representable in the target type.
443551313c39c84407dd6a323be99a8c322bf8d052a9John McCall        Expr::EvalResult result;
443651f4708c00110940ca3f337961915f2ca1668375Richard Smith        if (E->EvaluateAsRValue(result, S.Context)) {
443751313c39c84407dd6a323be99a8c322bf8d052a9John McCall          // Value might be a float, a float vector, or a float complex.
443851313c39c84407dd6a323be99a8c322bf8d052a9John McCall          if (IsSameFloatAfterCast(result.Val,
4439323ed74658bc8375278eabf074b4777458376540John McCall                   S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)),
4440323ed74658bc8375278eabf074b4777458376540John McCall                   S.Context.getFloatTypeSemantics(QualType(SourceBT, 0))))
444151313c39c84407dd6a323be99a8c322bf8d052a9John McCall            return;
444251313c39c84407dd6a323be99a8c322bf8d052a9John McCall        }
444351313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4444d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay        if (S.SourceMgr.isInSystemMacro(CC))
4445ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek          return;
4446ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4447b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall        DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision);
444851313c39c84407dd6a323be99a8c322bf8d052a9John McCall      }
444951313c39c84407dd6a323be99a8c322bf8d052a9John McCall      return;
445051313c39c84407dd6a323be99a8c322bf8d052a9John McCall    }
445151313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4452ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek    // If the target is integral, always warn.
4453be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    if (TargetBT && TargetBT->isInteger()) {
4454d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay      if (S.SourceMgr.isInSystemMacro(CC))
4455ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek        return;
4456ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4457a5b9332418f25338f118358e27303cd510d54107Chandler Carruth      Expr *InnerE = E->IgnoreParenImpCasts();
4458634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay      // We also want to warn on, e.g., "int i = -1.234"
4459634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay      if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE))
4460634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay        if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus)
4461634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay          InnerE = UOp->getSubExpr()->IgnoreParenImpCasts();
4462634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay
4463f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth      if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) {
4464f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth        DiagnoseFloatingLiteralImpCast(S, FL, T, CC);
4465a5b9332418f25338f118358e27303cd510d54107Chandler Carruth      } else {
4466a5b9332418f25338f118358e27303cd510d54107Chandler Carruth        DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer);
4467a5b9332418f25338f118358e27303cd510d54107Chandler Carruth      }
4468a5b9332418f25338f118358e27303cd510d54107Chandler Carruth    }
446951313c39c84407dd6a323be99a8c322bf8d052a9John McCall
447051313c39c84407dd6a323be99a8c322bf8d052a9John McCall    return;
447151313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
447251313c39c84407dd6a323be99a8c322bf8d052a9John McCall
44731838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu  if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull)
4474b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie           == Expr::NPCK_GNUNull) && !Target->isAnyPointerType()
447528a5f0cdfcc927a94c1bda6a225200762df22411David Blaikie      && !Target->isBlockPointerType() && !Target->isMemberPointerType()) {
4476b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie    SourceLocation Loc = E->getSourceRange().getBegin();
4477b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie    if (Loc.isMacroID())
4478b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie      Loc = S.SourceMgr.getImmediateExpansionRange(Loc).first;
44799fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie    if (!Loc.isMacroID() || CC.isMacroID())
44809fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie      S.Diag(Loc, diag::warn_impcast_null_pointer_to_integer)
44819fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie          << T << clang::SourceRange(CC)
44829fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie          << FixItHint::CreateReplacement(Loc, S.getFixItZeroLiteralForType(T));
44831838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu  }
44841838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu
4485b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie  if (!Source->isIntegerType() || !Target->isIntegerType())
4486b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie    return;
4487b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie
4488be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  // TODO: remove this early return once the false positives for constant->bool
4489be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  // in templates, macros, etc, are reduced or removed.
4490be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie  if (Target->isSpecificBuiltinType(BuiltinType::Bool))
4491be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie    return;
4492be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie
4493323ed74658bc8375278eabf074b4777458376540John McCall  IntRange SourceRange = GetExprRange(S.Context, E);
44941844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall  IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target);
449551313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4496f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall  if (SourceRange.Width > TargetRange.Width) {
4497091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    // If the source is a constant, use a default-on diagnostic.
4498091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    // TODO: this should happen for bitfield stores, too.
4499091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    llvm::APSInt Value(32);
4500091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    if (E->isIntegerConstantExpr(Value, S.Context)) {
4501d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay      if (S.SourceMgr.isInSystemMacro(CC))
4502ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek        return;
4503ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4504091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall      std::string PrettySourceValue = Value.toString(10);
4505091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall      std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange);
4506091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall
45075e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek      S.DiagRuntimeBehavior(E->getExprLoc(), E,
45085e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek        S.PDiag(diag::warn_impcast_integer_precision_constant)
45095e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek            << PrettySourceValue << PrettyTargetValue
45105e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek            << E->getType() << T << E->getSourceRange()
45115e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek            << clang::SourceRange(CC));
4512091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall      return;
4513091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall    }
4514091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall
4515b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner    // People want to build with -Wshorten-64-to-32 and not -Wconversion.
4516d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay    if (S.SourceMgr.isInSystemMacro(CC))
4517ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek      return;
4518ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
451937050841d7b852497b85d5275d9ea92c07ddf059David Blaikie    if (TargetRange.Width == 32 && S.Context.getIntWidth(E->getType()) == 64)
4520c36bedc90c687caa71748480c60707ea4608b092Anna Zaks      return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32,
4521c36bedc90c687caa71748480c60707ea4608b092Anna Zaks                             /* pruneControlFlow */ true);
4522b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision);
4523323ed74658bc8375278eabf074b4777458376540John McCall  }
4524323ed74658bc8375278eabf074b4777458376540John McCall
4525323ed74658bc8375278eabf074b4777458376540John McCall  if ((TargetRange.NonNegative && !SourceRange.NonNegative) ||
4526323ed74658bc8375278eabf074b4777458376540John McCall      (!TargetRange.NonNegative && SourceRange.NonNegative &&
4527323ed74658bc8375278eabf074b4777458376540John McCall       SourceRange.Width == TargetRange.Width)) {
4528ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4529d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay    if (S.SourceMgr.isInSystemMacro(CC))
4530ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek      return;
4531ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
4532323ed74658bc8375278eabf074b4777458376540John McCall    unsigned DiagID = diag::warn_impcast_integer_sign;
4533323ed74658bc8375278eabf074b4777458376540John McCall
4534323ed74658bc8375278eabf074b4777458376540John McCall    // Traditionally, gcc has warned about this under -Wsign-compare.
4535323ed74658bc8375278eabf074b4777458376540John McCall    // We also want to warn about it in -Wconversion.
4536323ed74658bc8375278eabf074b4777458376540John McCall    // So if -Wconversion is off, use a completely identical diagnostic
4537323ed74658bc8375278eabf074b4777458376540John McCall    // in the sign-compare group.
4538323ed74658bc8375278eabf074b4777458376540John McCall    // The conditional-checking code will
4539323ed74658bc8375278eabf074b4777458376540John McCall    if (ICContext) {
4540323ed74658bc8375278eabf074b4777458376540John McCall      DiagID = diag::warn_impcast_integer_sign_conditional;
4541323ed74658bc8375278eabf074b4777458376540John McCall      *ICContext = true;
4542323ed74658bc8375278eabf074b4777458376540John McCall    }
4543323ed74658bc8375278eabf074b4777458376540John McCall
4544b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return DiagnoseImpCast(S, E, T, CC, DiagID);
454551313c39c84407dd6a323be99a8c322bf8d052a9John McCall  }
454651313c39c84407dd6a323be99a8c322bf8d052a9John McCall
4547284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor  // Diagnose conversions between different enumeration types.
45485a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  // In C, we pretend that the type of an EnumConstantDecl is its enumeration
45495a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  // type, to give us better diagnostics.
45505a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  QualType SourceType = E->getType();
45514e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie  if (!S.getLangOpts().CPlusPlus) {
45525a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor    if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E))
45535a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor      if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) {
45545a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor        EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext());
45555a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor        SourceType = S.Context.getTypeDeclType(Enum);
45565a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor        Source = S.Context.getCanonicalType(SourceType).getTypePtr();
45575a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor      }
45585a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor  }
45595a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor
4560284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor  if (const EnumType *SourceEnum = Source->getAs<EnumType>())
4561284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor    if (const EnumType *TargetEnum = Target->getAs<EnumType>())
4562284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor      if ((SourceEnum->getDecl()->getIdentifier() ||
4563162e1c1b487352434552147967c3dd296ebee2f7Richard Smith           SourceEnum->getDecl()->getTypedefNameForAnonDecl()) &&
4564284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor          (TargetEnum->getDecl()->getIdentifier() ||
4565162e1c1b487352434552147967c3dd296ebee2f7Richard Smith           TargetEnum->getDecl()->getTypedefNameForAnonDecl()) &&
4566ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek          SourceEnum != TargetEnum) {
4567d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay        if (S.SourceMgr.isInSystemMacro(CC))
4568ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek          return;
4569ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek
45705a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor        return DiagnoseImpCast(S, E, SourceType, T, CC,
4571284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor                               diag::warn_impcast_different_enum_types);
4572ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek      }
4573284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor
457451313c39c84407dd6a323be99a8c322bf8d052a9John McCall  return;
457551313c39c84407dd6a323be99a8c322bf8d052a9John McCall}
457651313c39c84407dd6a323be99a8c322bf8d052a9John McCall
45779fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E,
45789fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie                              SourceLocation CC, QualType T);
4579323ed74658bc8375278eabf074b4777458376540John McCall
4580323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T,
4581b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall                             SourceLocation CC, bool &ICContext) {
4582323ed74658bc8375278eabf074b4777458376540John McCall  E = E->IgnoreParenImpCasts();
4583323ed74658bc8375278eabf074b4777458376540John McCall
4584323ed74658bc8375278eabf074b4777458376540John McCall  if (isa<ConditionalOperator>(E))
45859fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie    return CheckConditionalOperator(S, cast<ConditionalOperator>(E), CC, T);
4586323ed74658bc8375278eabf074b4777458376540John McCall
4587b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(S, E, CC);
4588323ed74658bc8375278eabf074b4777458376540John McCall  if (E->getType() != T)
4589b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return CheckImplicitConversion(S, E, T, CC, &ICContext);
4590323ed74658bc8375278eabf074b4777458376540John McCall  return;
4591323ed74658bc8375278eabf074b4777458376540John McCall}
4592323ed74658bc8375278eabf074b4777458376540John McCall
45939fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E,
45949fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie                              SourceLocation CC, QualType T) {
4595b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(S, E->getCond(), CC);
4596323ed74658bc8375278eabf074b4777458376540John McCall
4597323ed74658bc8375278eabf074b4777458376540John McCall  bool Suspicious = false;
4598b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious);
4599b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious);
4600323ed74658bc8375278eabf074b4777458376540John McCall
4601323ed74658bc8375278eabf074b4777458376540John McCall  // If -Wconversion would have warned about either of the candidates
4602323ed74658bc8375278eabf074b4777458376540John McCall  // for a signedness conversion to the context type...
4603323ed74658bc8375278eabf074b4777458376540John McCall  if (!Suspicious) return;
4604323ed74658bc8375278eabf074b4777458376540John McCall
4605323ed74658bc8375278eabf074b4777458376540John McCall  // ...but it's currently ignored...
46060827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis  if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional,
46070827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis                                 CC))
4608323ed74658bc8375278eabf074b4777458376540John McCall    return;
4609323ed74658bc8375278eabf074b4777458376540John McCall
4610323ed74658bc8375278eabf074b4777458376540John McCall  // ...then check whether it would have warned about either of the
4611323ed74658bc8375278eabf074b4777458376540John McCall  // candidates for a signedness conversion to the condition type.
46125254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu  if (E->getType() == T) return;
46135254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu
46145254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu  Suspicious = false;
46155254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu  CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(),
46165254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu                          E->getType(), CC, &Suspicious);
46175254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu  if (!Suspicious)
46185254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu    CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(),
4619b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall                            E->getType(), CC, &Suspicious);
4620323ed74658bc8375278eabf074b4777458376540John McCall}
4621323ed74658bc8375278eabf074b4777458376540John McCall
4622323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting
4623323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression.  There are a couple
4624323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare.
4625b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) {
4626323ed74658bc8375278eabf074b4777458376540John McCall  QualType T = OrigE->getType();
4627323ed74658bc8375278eabf074b4777458376540John McCall  Expr *E = OrigE->IgnoreParenImpCasts();
4628323ed74658bc8375278eabf074b4777458376540John McCall
4629f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor  if (E->isTypeDependent() || E->isValueDependent())
4630f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor    return;
4631f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor
4632323ed74658bc8375278eabf074b4777458376540John McCall  // For conditional operators, we analyze the arguments as if they
4633323ed74658bc8375278eabf074b4777458376540John McCall  // were being fed directly into the output.
4634323ed74658bc8375278eabf074b4777458376540John McCall  if (isa<ConditionalOperator>(E)) {
4635323ed74658bc8375278eabf074b4777458376540John McCall    ConditionalOperator *CO = cast<ConditionalOperator>(E);
46369fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie    CheckConditionalOperator(S, CO, CC, T);
4637323ed74658bc8375278eabf074b4777458376540John McCall    return;
4638323ed74658bc8375278eabf074b4777458376540John McCall  }
4639323ed74658bc8375278eabf074b4777458376540John McCall
4640323ed74658bc8375278eabf074b4777458376540John McCall  // Go ahead and check any implicit conversions we might have skipped.
4641323ed74658bc8375278eabf074b4777458376540John McCall  // The non-canonical typecheck is just an optimization;
4642323ed74658bc8375278eabf074b4777458376540John McCall  // CheckImplicitConversion will filter out dead implicit conversions.
4643323ed74658bc8375278eabf074b4777458376540John McCall  if (E->getType() != T)
4644b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    CheckImplicitConversion(S, E, T, CC);
4645323ed74658bc8375278eabf074b4777458376540John McCall
4646323ed74658bc8375278eabf074b4777458376540John McCall  // Now continue drilling into this expression.
4647323ed74658bc8375278eabf074b4777458376540John McCall
4648323ed74658bc8375278eabf074b4777458376540John McCall  // Skip past explicit casts.
4649323ed74658bc8375278eabf074b4777458376540John McCall  if (isa<ExplicitCastExpr>(E)) {
4650323ed74658bc8375278eabf074b4777458376540John McCall    E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts();
4651b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall    return AnalyzeImplicitConversions(S, E, CC);
4652323ed74658bc8375278eabf074b4777458376540John McCall  }
4653323ed74658bc8375278eabf074b4777458376540John McCall
4654beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
4655beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall    // Do a somewhat different check with comparison operators.
4656beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall    if (BO->isComparisonOp())
4657beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall      return AnalyzeComparison(S, BO);
4658beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall
46590fa063816818ac53a0015a5d2b0328812005b40eEli Friedman    // And with simple assignments.
46600fa063816818ac53a0015a5d2b0328812005b40eEli Friedman    if (BO->getOpcode() == BO_Assign)
4661beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall      return AnalyzeAssignment(S, BO);
4662beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall  }
4663323ed74658bc8375278eabf074b4777458376540John McCall
4664323ed74658bc8375278eabf074b4777458376540John McCall  // These break the otherwise-useful invariant below.  Fortunately,
4665323ed74658bc8375278eabf074b4777458376540John McCall  // we don't really need to recurse into them, because any internal
4666323ed74658bc8375278eabf074b4777458376540John McCall  // expressions should have been analyzed already when they were
4667323ed74658bc8375278eabf074b4777458376540John McCall  // built into statements.
4668323ed74658bc8375278eabf074b4777458376540John McCall  if (isa<StmtExpr>(E)) return;
4669323ed74658bc8375278eabf074b4777458376540John McCall
4670323ed74658bc8375278eabf074b4777458376540John McCall  // Don't descend into unevaluated contexts.
4671f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne  if (isa<UnaryExprOrTypeTraitExpr>(E)) return;
4672323ed74658bc8375278eabf074b4777458376540John McCall
4673323ed74658bc8375278eabf074b4777458376540John McCall  // Now just recurse over the expression's children.
4674b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  CC = E->getExprLoc();
4675f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  BinaryOperator *BO = dyn_cast<BinaryOperator>(E);
4676f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  bool IsLogicalOperator = BO && BO->isLogicalOp();
4677f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  for (Stmt::child_range I = E->children(); I; ++I) {
467854042f1bd78f1f1ea86be7d4af541462e127d2edDouglas Gregor    Expr *ChildExpr = dyn_cast_or_null<Expr>(*I);
4679503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor    if (!ChildExpr)
4680503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor      continue;
4681503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor
4682f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu    if (IsLogicalOperator &&
4683f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu        isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts()))
4684f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      // Ignore checking string literals that are in logical operators.
4685f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu      continue;
4686f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu    AnalyzeImplicitConversions(S, ChildExpr, CC);
4687f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu  }
4688323ed74658bc8375278eabf074b4777458376540John McCall}
4689323ed74658bc8375278eabf074b4777458376540John McCall
4690323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace
4691323ed74658bc8375278eabf074b4777458376540John McCall
4692323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given
4693323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression).  Implements -Wconversion
4694323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare.
4695b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall///
4696b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e.
4697b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall///   the most location of the syntactic entity requiring the implicit
4698b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall///   conversion
4699b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) {
4700323ed74658bc8375278eabf074b4777458376540John McCall  // Don't diagnose in unevaluated contexts.
4701323ed74658bc8375278eabf074b4777458376540John McCall  if (ExprEvalContexts.back().Context == Sema::Unevaluated)
4702323ed74658bc8375278eabf074b4777458376540John McCall    return;
4703323ed74658bc8375278eabf074b4777458376540John McCall
4704323ed74658bc8375278eabf074b4777458376540John McCall  // Don't diagnose for value- or type-dependent expressions.
4705323ed74658bc8375278eabf074b4777458376540John McCall  if (E->isTypeDependent() || E->isValueDependent())
4706323ed74658bc8375278eabf074b4777458376540John McCall    return;
4707323ed74658bc8375278eabf074b4777458376540John McCall
4708d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  // Check for array bounds violations in cases where the check isn't triggered
4709d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  // elsewhere for other Expr types (like BinaryOperators), e.g. when an
4710d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  // ArraySubscriptExpr is on the RHS of a variable initialization.
4711d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  CheckArrayAccess(E);
4712d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
4713b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  // This is not the right CC for (e.g.) a variable initialization.
4714b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall  AnalyzeImplicitConversions(*this, E, CC);
4715323ed74658bc8375278eabf074b4777458376540John McCall}
4716323ed74658bc8375278eabf074b4777458376540John McCall
471715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc,
471815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall                                       FieldDecl *BitField,
471915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall                                       Expr *Init) {
472015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall  (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc);
472115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall}
472215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall
4723f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given
4724f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This
4725f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the
4726f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function
4727f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete.
472882aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregorbool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd,
472982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor                                    bool CheckParameterNames) {
4730f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump  bool HasInvalidParm = false;
473182aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor  for (; P != PEnd; ++P) {
473282aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor    ParmVarDecl *Param = *P;
473382aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor
4734f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // C99 6.7.5.3p4: the parameters in a parameter type list in a
4735f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // function declarator that is part of a function definition of
4736f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // that function shall not have incomplete type.
4737f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    //
4738f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // This is also C++ [dcl.fct]p6.
4739f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    if (!Param->isInvalidDecl() &&
4740f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump        RequireCompleteType(Param->getLocation(), Param->getType(),
4741d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor                            diag::err_typecheck_decl_incomplete_type)) {
4742f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump      Param->setInvalidDecl();
4743f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump      HasInvalidParm = true;
4744f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    }
4745f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump
4746f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // C99 6.9.1p5: If the declarator includes a parameter type list, the
4747f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump    // declaration of each parameter shall include an identifier.
474882aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor    if (CheckParameterNames &&
474982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor        Param->getIdentifier() == 0 &&
4750f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump        !Param->isImplicit() &&
47514e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie        !getLangOpts().CPlusPlus)
4752f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump      Diag(Param->getLocation(), diag::err_parameter_name_omitted);
4753d17e340e2d516139931768697bf080f60920ba9dSam Weinig
4754d17e340e2d516139931768697bf080f60920ba9dSam Weinig    // C99 6.7.5.3p12:
4755d17e340e2d516139931768697bf080f60920ba9dSam Weinig    //   If the function declarator is not part of a definition of that
4756d17e340e2d516139931768697bf080f60920ba9dSam Weinig    //   function, parameters may have incomplete type and may use the [*]
4757d17e340e2d516139931768697bf080f60920ba9dSam Weinig    //   notation in their sequences of declarator specifiers to specify
4758d17e340e2d516139931768697bf080f60920ba9dSam Weinig    //   variable length array types.
4759d17e340e2d516139931768697bf080f60920ba9dSam Weinig    QualType PType = Param->getOriginalType();
4760d17e340e2d516139931768697bf080f60920ba9dSam Weinig    if (const ArrayType *AT = Context.getAsArrayType(PType)) {
4761d17e340e2d516139931768697bf080f60920ba9dSam Weinig      if (AT->getSizeModifier() == ArrayType::Star) {
4762d17e340e2d516139931768697bf080f60920ba9dSam Weinig        // FIXME: This diagnosic should point the the '[*]' if source-location
4763d17e340e2d516139931768697bf080f60920ba9dSam Weinig        // information is added for it.
4764d17e340e2d516139931768697bf080f60920ba9dSam Weinig        Diag(Param->getLocation(), diag::err_array_star_in_function_definition);
4765d17e340e2d516139931768697bf080f60920ba9dSam Weinig      }
4766d17e340e2d516139931768697bf080f60920ba9dSam Weinig    }
4767f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump  }
4768f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump
4769f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump  return HasInvalidParm;
4770f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump}
4771b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
4772b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a
4773b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements.
4774b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) {
4775b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // This is actually a lot of work to potentially be doing on every
4776b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // cast; don't do it if we're ignoring -Wcast_align (as is the default).
47770827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis  if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align,
47780827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis                                          TRange.getBegin())
4779d6471f7c1921c7802804ce3ff6fe9768310f72b9David Blaikie        == DiagnosticsEngine::Ignored)
4780b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    return;
4781b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
4782b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Ignore dependent types.
4783b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (T->isDependentType() || Op->getType()->isDependentType())
4784b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    return;
4785b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
4786b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Require that the destination be a pointer type.
4787b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  const PointerType *DestPtr = T->getAs<PointerType>();
4788b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (!DestPtr) return;
4789b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
4790b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // If the destination has alignment 1, we're done.
4791b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  QualType DestPointee = DestPtr->getPointeeType();
4792b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (DestPointee->isIncompleteType()) return;
4793b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee);
4794b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (DestAlign.isOne()) return;
4795b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
4796b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Require that the source be a pointer type.
4797b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  const PointerType *SrcPtr = Op->getType()->getAs<PointerType>();
4798b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (!SrcPtr) return;
4799b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  QualType SrcPointee = SrcPtr->getPointeeType();
4800b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
4801b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Whitelist casts from cv void*.  We already implicitly
4802b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // whitelisted casts to cv void*, since they have alignment 1.
4803b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // Also whitelist casts involving incomplete types, which implicitly
4804b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  // includes 'void'.
4805b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (SrcPointee->isIncompleteType()) return;
4806b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
4807b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee);
4808b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  if (SrcAlign >= DestAlign) return;
4809b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
4810b7f4ffe073fa419613946461a2583ba2fcb72280John McCall  Diag(TRange.getBegin(), diag::warn_cast_align)
4811b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    << Op->getType() << T
4812b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    << static_cast<unsigned>(SrcAlign.getQuantity())
4813b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    << static_cast<unsigned>(DestAlign.getQuantity())
4814b7f4ffe073fa419613946461a2583ba2fcb72280John McCall    << TRange << Op->getSourceRange();
4815b7f4ffe073fa419613946461a2583ba2fcb72280John McCall}
4816b7f4ffe073fa419613946461a2583ba2fcb72280John McCall
4817d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainstatic const Type* getElementType(const Expr *BaseExpr) {
4818d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  const Type* EltType = BaseExpr->getType().getTypePtr();
4819d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  if (EltType->isAnyPointerType())
4820d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    return EltType->getPointeeType().getTypePtr();
4821d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  else if (EltType->isArrayType())
4822d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    return EltType->getBaseElementTypeUnsafe();
4823d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  return EltType;
4824d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain}
4825d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
4826c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// \brief Check whether this array fits the idiom of a size-one tail padded
4827c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// array member of a struct.
4828c268434b332bbe57950d977633369bf5822d9554Chandler Carruth///
4829c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// We avoid emitting out-of-bounds access warnings for such arrays as they are
4830c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// commonly used to emulate flexible arrays in C89 code.
4831c268434b332bbe57950d977633369bf5822d9554Chandler Carruthstatic bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size,
4832c268434b332bbe57950d977633369bf5822d9554Chandler Carruth                                    const NamedDecl *ND) {
4833c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  if (Size != 1 || !ND) return false;
4834c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
4835c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  const FieldDecl *FD = dyn_cast<FieldDecl>(ND);
4836c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  if (!FD) return false;
4837c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
4838c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  // Don't consider sizes resulting from macro expansions or template argument
4839c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  // substitution to form C89 tail-padded arrays.
4840d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan
4841d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan  TypeSourceInfo *TInfo = FD->getTypeSourceInfo();
484200e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek  while (TInfo) {
484300e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    TypeLoc TL = TInfo->getTypeLoc();
484400e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    // Look through typedefs.
484500e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    const TypedefTypeLoc *TTL = dyn_cast<TypedefTypeLoc>(&TL);
484600e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    if (TTL) {
484700e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek      const TypedefNameDecl *TDL = TTL->getTypedefNameDecl();
484800e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek      TInfo = TDL->getTypeSourceInfo();
484900e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek      continue;
485000e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    }
485100e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    ConstantArrayTypeLoc CTL = cast<ConstantArrayTypeLoc>(TL);
485200e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    const Expr *SizeExpr = dyn_cast<IntegerLiteral>(CTL.getSizeExpr());
4853d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan    if (!SizeExpr || SizeExpr->getExprLoc().isMacroID())
4854d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan      return false;
485500e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek    break;
4856d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan  }
4857c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
4858c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext());
4859381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay  if (!RD) return false;
4860381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay  if (RD->isUnion()) return false;
4861381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay  if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) {
4862381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay    if (!CRD->isStandardLayout()) return false;
4863381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay  }
4864c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
486522d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer  // See if this is the last field decl in the record.
486622d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer  const Decl *D = FD;
486722d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer  while ((D = D->getNextDeclInContext()))
486822d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer    if (isa<FieldDecl>(D))
486922d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer      return false;
487022d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer  return true;
4871c268434b332bbe57950d977633369bf5822d9554Chandler Carruth}
4872c268434b332bbe57950d977633369bf5822d9554Chandler Carruth
4873d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainvoid Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr,
487480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay                            const ArraySubscriptExpr *ASE,
487525b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith                            bool AllowOnePastEnd, bool IndexNegated) {
487692b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman  IndexExpr = IndexExpr->IgnoreParenImpCasts();
487780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay  if (IndexExpr->isValueDependent())
487880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    return;
4879d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
488080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay  const Type *EffectiveType = getElementType(BaseExpr);
488180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay  BaseExpr = BaseExpr->IgnoreParenCasts();
48823406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth  const ConstantArrayType *ArrayTy =
4883d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    Context.getAsConstantArrayType(BaseExpr->getType());
48843406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth  if (!ArrayTy)
4885a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek    return;
488635001ca261f895817916b468379b696d6d45959dChandler Carruth
48873406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth  llvm::APSInt index;
488880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay  if (!IndexExpr->EvaluateAsInt(index, Context))
4889a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek    return;
489025b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith  if (IndexNegated)
489125b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith    index = -index;
48928fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek
4893ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth  const NamedDecl *ND = NULL;
4894ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth  if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr))
4895ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    ND = dyn_cast<NamedDecl>(DRE->getDecl());
4896c268434b332bbe57950d977633369bf5822d9554Chandler Carruth  if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr))
4897ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    ND = dyn_cast<NamedDecl>(ME->getMemberDecl());
4898ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth
48999e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek  if (index.isUnsigned() || !index.isNegative()) {
490025b3b849e3ad340b04442707038c86980035765bTed Kremenek    llvm::APInt size = ArrayTy->getSize();
490135001ca261f895817916b468379b696d6d45959dChandler Carruth    if (!size.isStrictlyPositive())
490235001ca261f895817916b468379b696d6d45959dChandler Carruth      return;
4903d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
4904d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    const Type* BaseType = getElementType(BaseExpr);
4905de5998f1d7dcecb777257ec932142d65de636eb8Nico Weber    if (BaseType != EffectiveType) {
4906d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      // Make sure we're comparing apples to apples when comparing index to size
4907d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType);
4908d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      uint64_t array_typesize = Context.getTypeSize(BaseType);
4909d10f4bc5a05ce0cdc1646dbb0f706bb9d3dfc0c5Kaelyn Uhrain      // Handle ptrarith_typesize being zero, such as when casting to void*
491018f169770d9d3f826bad8f1359c8c5770c5ab16fKaelyn Uhrain      if (!ptrarith_typesize) ptrarith_typesize = 1;
4911d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      if (ptrarith_typesize != array_typesize) {
4912d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        // There's a cast to a different size type involved
4913d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        uint64_t ratio = array_typesize / ptrarith_typesize;
4914d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        // TODO: Be smarter about handling cases where array_typesize is not a
4915d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        // multiple of ptrarith_typesize
4916d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        if (ptrarith_typesize * ratio == array_typesize)
4917d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain          size *= llvm::APInt(size.getBitWidth(), ratio);
4918d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      }
4919d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    }
4920d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
49213406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth    if (size.getBitWidth() > index.getBitWidth())
492292b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman      index = index.zext(size.getBitWidth());
492325b3b849e3ad340b04442707038c86980035765bTed Kremenek    else if (size.getBitWidth() < index.getBitWidth())
492492b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman      size = size.zext(index.getBitWidth());
492525b3b849e3ad340b04442707038c86980035765bTed Kremenek
4926d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    // For array subscripting the index must be less than size, but for pointer
4927d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    // arithmetic also allow the index (offset) to be equal to size since
4928d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    // computing the next address after the end of the array is legal and
4929d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    // commonly done e.g. in C++ iterators and range-based for loops.
493092b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman    if (AllowOnePastEnd ? index.ule(size) : index.ult(size))
4931ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth      return;
4932ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth
4933ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    // Also don't warn for arrays of size 1 which are members of some
4934ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    // structure. These are often used to approximate flexible arrays in C89
4935ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth    // code.
4936d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    if (IsTailPaddedMemberArray(*this, size, ND))
49378fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek      return;
49383406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth
493980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    // Suppress the warning if the subscript expression (as identified by the
494080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    // ']' location) and the index expression are both from macro expansions
494180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    // within a system header.
494280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    if (ASE) {
494380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay      SourceLocation RBracketLoc = SourceMgr.getSpellingLoc(
494480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay          ASE->getRBracketLoc());
494580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay      if (SourceMgr.isInSystemHeader(RBracketLoc)) {
494680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay        SourceLocation IndexLoc = SourceMgr.getSpellingLoc(
494780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay            IndexExpr->getLocStart());
494880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay        if (SourceMgr.isFromSameFile(RBracketLoc, IndexLoc))
494980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay          return;
495080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay      }
495180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    }
495280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay
4953d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds;
495480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    if (ASE)
4955d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      DiagID = diag::warn_array_index_exceeds_bounds;
4956d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
4957d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr,
4958d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                        PDiag(DiagID) << index.toString(10, true)
4959d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << size.toString(10, true)
4960d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << (unsigned)size.getLimitedValue(~0U)
4961d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << IndexExpr->getSourceRange());
49623406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth  } else {
4963d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    unsigned DiagID = diag::warn_array_index_precedes_bounds;
496480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay    if (!ASE) {
4965d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      DiagID = diag::warn_ptr_arith_precedes_bounds;
4966d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      if (index.isNegative()) index = -index;
4967d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    }
4968d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain
4969d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr,
4970d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                        PDiag(DiagID) << index.toString(10, true)
4971d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << IndexExpr->getSourceRange());
4972a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek  }
497335001ca261f895817916b468379b696d6d45959dChandler Carruth
4974cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay  if (!ND) {
4975cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay    // Try harder to find a NamedDecl to point at in the note.
4976cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay    while (const ArraySubscriptExpr *ASE =
4977cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay           dyn_cast<ArraySubscriptExpr>(BaseExpr))
4978cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay      BaseExpr = ASE->getBase()->IgnoreParenCasts();
4979cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay    if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr))
4980cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay      ND = dyn_cast<NamedDecl>(DRE->getDecl());
4981cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay    if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr))
4982cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay      ND = dyn_cast<NamedDecl>(ME->getMemberDecl());
4983cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay  }
4984cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay
498535001ca261f895817916b468379b696d6d45959dChandler Carruth  if (ND)
4986d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    DiagRuntimeBehavior(ND->getLocStart(), BaseExpr,
4987d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                        PDiag(diag::note_array_index_out_of_bounds)
4988d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                          << ND->getDeclName());
49893aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek}
49903aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek
49913aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) {
4992d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  int AllowOnePastEnd = 0;
4993d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain  while (expr) {
4994d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain    expr = expr->IgnoreParenImpCasts();
49953aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek    switch (expr->getStmtClass()) {
4996d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      case Stmt::ArraySubscriptExprClass: {
4997d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr);
499880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay        CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE,
4999d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain                         AllowOnePastEnd > 0);
50003aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        return;
5001d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      }
5002d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      case Stmt::UnaryOperatorClass: {
5003d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        // Only unwrap the * and & unary operators
5004d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        const UnaryOperator *UO = cast<UnaryOperator>(expr);
5005d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        expr = UO->getSubExpr();
5006d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        switch (UO->getOpcode()) {
5007d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain          case UO_AddrOf:
5008d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            AllowOnePastEnd++;
5009d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            break;
5010d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain          case UO_Deref:
5011d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            AllowOnePastEnd--;
5012d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            break;
5013d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain          default:
5014d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain            return;
5015d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        }
5016d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain        break;
5017d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain      }
50183aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek      case Stmt::ConditionalOperatorClass: {
50193aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        const ConditionalOperator *cond = cast<ConditionalOperator>(expr);
50203aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        if (const Expr *lhs = cond->getLHS())
50213aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek          CheckArrayAccess(lhs);
50223aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        if (const Expr *rhs = cond->getRHS())
50233aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek          CheckArrayAccess(rhs);
50243aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        return;
50253aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek      }
50263aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek      default:
50273aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek        return;
50283aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek    }
5029f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne  }
5030a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek}
5031f85e193739c953358c865005855253af4f68a497John McCall
5032f85e193739c953358c865005855253af4f68a497John McCall//===--- CHECK: Objective-C retain cycles ----------------------------------//
5033f85e193739c953358c865005855253af4f68a497John McCall
5034f85e193739c953358c865005855253af4f68a497John McCallnamespace {
5035f85e193739c953358c865005855253af4f68a497John McCall  struct RetainCycleOwner {
5036f85e193739c953358c865005855253af4f68a497John McCall    RetainCycleOwner() : Variable(0), Indirect(false) {}
5037f85e193739c953358c865005855253af4f68a497John McCall    VarDecl *Variable;
5038f85e193739c953358c865005855253af4f68a497John McCall    SourceRange Range;
5039f85e193739c953358c865005855253af4f68a497John McCall    SourceLocation Loc;
5040f85e193739c953358c865005855253af4f68a497John McCall    bool Indirect;
5041f85e193739c953358c865005855253af4f68a497John McCall
5042f85e193739c953358c865005855253af4f68a497John McCall    void setLocsFrom(Expr *e) {
5043f85e193739c953358c865005855253af4f68a497John McCall      Loc = e->getExprLoc();
5044f85e193739c953358c865005855253af4f68a497John McCall      Range = e->getSourceRange();
5045f85e193739c953358c865005855253af4f68a497John McCall    }
5046f85e193739c953358c865005855253af4f68a497John McCall  };
5047f85e193739c953358c865005855253af4f68a497John McCall}
5048f85e193739c953358c865005855253af4f68a497John McCall
5049f85e193739c953358c865005855253af4f68a497John McCall/// Consider whether capturing the given variable can possibly lead to
5050f85e193739c953358c865005855253af4f68a497John McCall/// a retain cycle.
5051f85e193739c953358c865005855253af4f68a497John McCallstatic bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) {
5052f85e193739c953358c865005855253af4f68a497John McCall  // In ARC, it's captured strongly iff the variable has __strong
5053f85e193739c953358c865005855253af4f68a497John McCall  // lifetime.  In MRR, it's captured strongly if the variable is
5054f85e193739c953358c865005855253af4f68a497John McCall  // __block and has an appropriate type.
5055f85e193739c953358c865005855253af4f68a497John McCall  if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong)
5056f85e193739c953358c865005855253af4f68a497John McCall    return false;
5057f85e193739c953358c865005855253af4f68a497John McCall
5058f85e193739c953358c865005855253af4f68a497John McCall  owner.Variable = var;
5059f85e193739c953358c865005855253af4f68a497John McCall  owner.setLocsFrom(ref);
5060f85e193739c953358c865005855253af4f68a497John McCall  return true;
5061f85e193739c953358c865005855253af4f68a497John McCall}
5062f85e193739c953358c865005855253af4f68a497John McCall
50636e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanianstatic bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) {
5064f85e193739c953358c865005855253af4f68a497John McCall  while (true) {
5065f85e193739c953358c865005855253af4f68a497John McCall    e = e->IgnoreParens();
5066f85e193739c953358c865005855253af4f68a497John McCall    if (CastExpr *cast = dyn_cast<CastExpr>(e)) {
5067f85e193739c953358c865005855253af4f68a497John McCall      switch (cast->getCastKind()) {
5068f85e193739c953358c865005855253af4f68a497John McCall      case CK_BitCast:
5069f85e193739c953358c865005855253af4f68a497John McCall      case CK_LValueBitCast:
5070f85e193739c953358c865005855253af4f68a497John McCall      case CK_LValueToRValue:
507133e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall      case CK_ARCReclaimReturnedObject:
5072f85e193739c953358c865005855253af4f68a497John McCall        e = cast->getSubExpr();
5073f85e193739c953358c865005855253af4f68a497John McCall        continue;
5074f85e193739c953358c865005855253af4f68a497John McCall
5075f85e193739c953358c865005855253af4f68a497John McCall      default:
5076f85e193739c953358c865005855253af4f68a497John McCall        return false;
5077f85e193739c953358c865005855253af4f68a497John McCall      }
5078f85e193739c953358c865005855253af4f68a497John McCall    }
5079f85e193739c953358c865005855253af4f68a497John McCall
5080f85e193739c953358c865005855253af4f68a497John McCall    if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) {
5081f85e193739c953358c865005855253af4f68a497John McCall      ObjCIvarDecl *ivar = ref->getDecl();
5082f85e193739c953358c865005855253af4f68a497John McCall      if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong)
5083f85e193739c953358c865005855253af4f68a497John McCall        return false;
5084f85e193739c953358c865005855253af4f68a497John McCall
5085f85e193739c953358c865005855253af4f68a497John McCall      // Try to find a retain cycle in the base.
50866e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian      if (!findRetainCycleOwner(S, ref->getBase(), owner))
5087f85e193739c953358c865005855253af4f68a497John McCall        return false;
5088f85e193739c953358c865005855253af4f68a497John McCall
5089f85e193739c953358c865005855253af4f68a497John McCall      if (ref->isFreeIvar()) owner.setLocsFrom(ref);
5090f85e193739c953358c865005855253af4f68a497John McCall      owner.Indirect = true;
5091f85e193739c953358c865005855253af4f68a497John McCall      return true;
5092f85e193739c953358c865005855253af4f68a497John McCall    }
5093f85e193739c953358c865005855253af4f68a497John McCall
5094f85e193739c953358c865005855253af4f68a497John McCall    if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) {
5095f85e193739c953358c865005855253af4f68a497John McCall      VarDecl *var = dyn_cast<VarDecl>(ref->getDecl());
5096f85e193739c953358c865005855253af4f68a497John McCall      if (!var) return false;
5097f85e193739c953358c865005855253af4f68a497John McCall      return considerVariable(var, ref, owner);
5098f85e193739c953358c865005855253af4f68a497John McCall    }
5099f85e193739c953358c865005855253af4f68a497John McCall
5100f85e193739c953358c865005855253af4f68a497John McCall    if (MemberExpr *member = dyn_cast<MemberExpr>(e)) {
5101f85e193739c953358c865005855253af4f68a497John McCall      if (member->isArrow()) return false;
5102f85e193739c953358c865005855253af4f68a497John McCall
5103f85e193739c953358c865005855253af4f68a497John McCall      // Don't count this as an indirect ownership.
5104f85e193739c953358c865005855253af4f68a497John McCall      e = member->getBase();
5105f85e193739c953358c865005855253af4f68a497John McCall      continue;
5106f85e193739c953358c865005855253af4f68a497John McCall    }
5107f85e193739c953358c865005855253af4f68a497John McCall
51084b9c2d235fb9449e249d74f48ecfec601650de93John McCall    if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) {
51094b9c2d235fb9449e249d74f48ecfec601650de93John McCall      // Only pay attention to pseudo-objects on property references.
51104b9c2d235fb9449e249d74f48ecfec601650de93John McCall      ObjCPropertyRefExpr *pre
51114b9c2d235fb9449e249d74f48ecfec601650de93John McCall        = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm()
51124b9c2d235fb9449e249d74f48ecfec601650de93John McCall                                              ->IgnoreParens());
51134b9c2d235fb9449e249d74f48ecfec601650de93John McCall      if (!pre) return false;
51144b9c2d235fb9449e249d74f48ecfec601650de93John McCall      if (pre->isImplicitProperty()) return false;
51154b9c2d235fb9449e249d74f48ecfec601650de93John McCall      ObjCPropertyDecl *property = pre->getExplicitProperty();
51164b9c2d235fb9449e249d74f48ecfec601650de93John McCall      if (!property->isRetaining() &&
51174b9c2d235fb9449e249d74f48ecfec601650de93John McCall          !(property->getPropertyIvarDecl() &&
51184b9c2d235fb9449e249d74f48ecfec601650de93John McCall            property->getPropertyIvarDecl()->getType()
51194b9c2d235fb9449e249d74f48ecfec601650de93John McCall              .getObjCLifetime() == Qualifiers::OCL_Strong))
51204b9c2d235fb9449e249d74f48ecfec601650de93John McCall          return false;
51214b9c2d235fb9449e249d74f48ecfec601650de93John McCall
51224b9c2d235fb9449e249d74f48ecfec601650de93John McCall      owner.Indirect = true;
51236e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian      if (pre->isSuperReceiver()) {
51246e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        owner.Variable = S.getCurMethodDecl()->getSelfDecl();
51256e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        if (!owner.Variable)
51266e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian          return false;
51276e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        owner.Loc = pre->getLocation();
51286e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        owner.Range = pre->getSourceRange();
51296e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian        return true;
51306e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian      }
51314b9c2d235fb9449e249d74f48ecfec601650de93John McCall      e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase())
51324b9c2d235fb9449e249d74f48ecfec601650de93John McCall                              ->getSourceExpr());
51334b9c2d235fb9449e249d74f48ecfec601650de93John McCall      continue;
51344b9c2d235fb9449e249d74f48ecfec601650de93John McCall    }
51354b9c2d235fb9449e249d74f48ecfec601650de93John McCall
5136f85e193739c953358c865005855253af4f68a497John McCall    // Array ivars?
5137f85e193739c953358c865005855253af4f68a497John McCall
5138f85e193739c953358c865005855253af4f68a497John McCall    return false;
5139f85e193739c953358c865005855253af4f68a497John McCall  }
5140f85e193739c953358c865005855253af4f68a497John McCall}
5141f85e193739c953358c865005855253af4f68a497John McCall
5142f85e193739c953358c865005855253af4f68a497John McCallnamespace {
5143f85e193739c953358c865005855253af4f68a497John McCall  struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> {
5144f85e193739c953358c865005855253af4f68a497John McCall    FindCaptureVisitor(ASTContext &Context, VarDecl *variable)
5145f85e193739c953358c865005855253af4f68a497John McCall      : EvaluatedExprVisitor<FindCaptureVisitor>(Context),
5146f85e193739c953358c865005855253af4f68a497John McCall        Variable(variable), Capturer(0) {}
5147f85e193739c953358c865005855253af4f68a497John McCall
5148f85e193739c953358c865005855253af4f68a497John McCall    VarDecl *Variable;
5149f85e193739c953358c865005855253af4f68a497John McCall    Expr *Capturer;
5150f85e193739c953358c865005855253af4f68a497John McCall
5151f85e193739c953358c865005855253af4f68a497John McCall    void VisitDeclRefExpr(DeclRefExpr *ref) {
5152f85e193739c953358c865005855253af4f68a497John McCall      if (ref->getDecl() == Variable && !Capturer)
5153f85e193739c953358c865005855253af4f68a497John McCall        Capturer = ref;
5154f85e193739c953358c865005855253af4f68a497John McCall    }
5155f85e193739c953358c865005855253af4f68a497John McCall
5156f85e193739c953358c865005855253af4f68a497John McCall    void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) {
5157f85e193739c953358c865005855253af4f68a497John McCall      if (Capturer) return;
5158f85e193739c953358c865005855253af4f68a497John McCall      Visit(ref->getBase());
5159f85e193739c953358c865005855253af4f68a497John McCall      if (Capturer && ref->isFreeIvar())
5160f85e193739c953358c865005855253af4f68a497John McCall        Capturer = ref;
5161f85e193739c953358c865005855253af4f68a497John McCall    }
5162f85e193739c953358c865005855253af4f68a497John McCall
5163f85e193739c953358c865005855253af4f68a497John McCall    void VisitBlockExpr(BlockExpr *block) {
5164f85e193739c953358c865005855253af4f68a497John McCall      // Look inside nested blocks
5165f85e193739c953358c865005855253af4f68a497John McCall      if (block->getBlockDecl()->capturesVariable(Variable))
5166f85e193739c953358c865005855253af4f68a497John McCall        Visit(block->getBlockDecl()->getBody());
5167f85e193739c953358c865005855253af4f68a497John McCall    }
5168f85e193739c953358c865005855253af4f68a497John McCall  };
5169f85e193739c953358c865005855253af4f68a497John McCall}
5170f85e193739c953358c865005855253af4f68a497John McCall
5171f85e193739c953358c865005855253af4f68a497John McCall/// Check whether the given argument is a block which captures a
5172f85e193739c953358c865005855253af4f68a497John McCall/// variable.
5173f85e193739c953358c865005855253af4f68a497John McCallstatic Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) {
5174f85e193739c953358c865005855253af4f68a497John McCall  assert(owner.Variable && owner.Loc.isValid());
5175f85e193739c953358c865005855253af4f68a497John McCall
5176f85e193739c953358c865005855253af4f68a497John McCall  e = e->IgnoreParenCasts();
5177f85e193739c953358c865005855253af4f68a497John McCall  BlockExpr *block = dyn_cast<BlockExpr>(e);
5178f85e193739c953358c865005855253af4f68a497John McCall  if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable))
5179f85e193739c953358c865005855253af4f68a497John McCall    return 0;
5180f85e193739c953358c865005855253af4f68a497John McCall
5181f85e193739c953358c865005855253af4f68a497John McCall  FindCaptureVisitor visitor(S.Context, owner.Variable);
5182f85e193739c953358c865005855253af4f68a497John McCall  visitor.Visit(block->getBlockDecl()->getBody());
5183f85e193739c953358c865005855253af4f68a497John McCall  return visitor.Capturer;
5184f85e193739c953358c865005855253af4f68a497John McCall}
5185f85e193739c953358c865005855253af4f68a497John McCall
5186f85e193739c953358c865005855253af4f68a497John McCallstatic void diagnoseRetainCycle(Sema &S, Expr *capturer,
5187f85e193739c953358c865005855253af4f68a497John McCall                                RetainCycleOwner &owner) {
5188f85e193739c953358c865005855253af4f68a497John McCall  assert(capturer);
5189f85e193739c953358c865005855253af4f68a497John McCall  assert(owner.Variable && owner.Loc.isValid());
5190f85e193739c953358c865005855253af4f68a497John McCall
5191f85e193739c953358c865005855253af4f68a497John McCall  S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle)
5192f85e193739c953358c865005855253af4f68a497John McCall    << owner.Variable << capturer->getSourceRange();
5193f85e193739c953358c865005855253af4f68a497John McCall  S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner)
5194f85e193739c953358c865005855253af4f68a497John McCall    << owner.Indirect << owner.Range;
5195f85e193739c953358c865005855253af4f68a497John McCall}
5196f85e193739c953358c865005855253af4f68a497John McCall
5197f85e193739c953358c865005855253af4f68a497John McCall/// Check for a keyword selector that starts with the word 'add' or
5198f85e193739c953358c865005855253af4f68a497John McCall/// 'set'.
5199f85e193739c953358c865005855253af4f68a497John McCallstatic bool isSetterLikeSelector(Selector sel) {
5200f85e193739c953358c865005855253af4f68a497John McCall  if (sel.isUnarySelector()) return false;
5201f85e193739c953358c865005855253af4f68a497John McCall
52025f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner  StringRef str = sel.getNameForSlot(0);
5203f85e193739c953358c865005855253af4f68a497John McCall  while (!str.empty() && str.front() == '_') str = str.substr(1);
5204968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek  if (str.startswith("set"))
5205f85e193739c953358c865005855253af4f68a497John McCall    str = str.substr(3);
5206968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek  else if (str.startswith("add")) {
5207968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek    // Specially whitelist 'addOperationWithBlock:'.
5208968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek    if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock"))
5209968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek      return false;
5210968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek    str = str.substr(3);
5211968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek  }
5212f85e193739c953358c865005855253af4f68a497John McCall  else
5213f85e193739c953358c865005855253af4f68a497John McCall    return false;
5214f85e193739c953358c865005855253af4f68a497John McCall
5215f85e193739c953358c865005855253af4f68a497John McCall  if (str.empty()) return true;
5216f85e193739c953358c865005855253af4f68a497John McCall  return !islower(str.front());
5217f85e193739c953358c865005855253af4f68a497John McCall}
5218f85e193739c953358c865005855253af4f68a497John McCall
5219f85e193739c953358c865005855253af4f68a497John McCall/// Check a message send to see if it's likely to cause a retain cycle.
5220f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(ObjCMessageExpr *msg) {
5221f85e193739c953358c865005855253af4f68a497John McCall  // Only check instance methods whose selector looks like a setter.
5222f85e193739c953358c865005855253af4f68a497John McCall  if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector()))
5223f85e193739c953358c865005855253af4f68a497John McCall    return;
5224f85e193739c953358c865005855253af4f68a497John McCall
5225f85e193739c953358c865005855253af4f68a497John McCall  // Try to find a variable that the receiver is strongly owned by.
5226f85e193739c953358c865005855253af4f68a497John McCall  RetainCycleOwner owner;
5227f85e193739c953358c865005855253af4f68a497John McCall  if (msg->getReceiverKind() == ObjCMessageExpr::Instance) {
52286e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian    if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner))
5229f85e193739c953358c865005855253af4f68a497John McCall      return;
5230f85e193739c953358c865005855253af4f68a497John McCall  } else {
5231f85e193739c953358c865005855253af4f68a497John McCall    assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance);
5232f85e193739c953358c865005855253af4f68a497John McCall    owner.Variable = getCurMethodDecl()->getSelfDecl();
5233f85e193739c953358c865005855253af4f68a497John McCall    owner.Loc = msg->getSuperLoc();
5234f85e193739c953358c865005855253af4f68a497John McCall    owner.Range = msg->getSuperLoc();
5235f85e193739c953358c865005855253af4f68a497John McCall  }
5236f85e193739c953358c865005855253af4f68a497John McCall
5237f85e193739c953358c865005855253af4f68a497John McCall  // Check whether the receiver is captured by any of the arguments.
5238f85e193739c953358c865005855253af4f68a497John McCall  for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i)
5239f85e193739c953358c865005855253af4f68a497John McCall    if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner))
5240f85e193739c953358c865005855253af4f68a497John McCall      return diagnoseRetainCycle(*this, capturer, owner);
5241f85e193739c953358c865005855253af4f68a497John McCall}
5242f85e193739c953358c865005855253af4f68a497John McCall
5243f85e193739c953358c865005855253af4f68a497John McCall/// Check a property assign to see if it's likely to cause a retain cycle.
5244f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(Expr *receiver, Expr *argument) {
5245f85e193739c953358c865005855253af4f68a497John McCall  RetainCycleOwner owner;
52466e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian  if (!findRetainCycleOwner(*this, receiver, owner))
5247f85e193739c953358c865005855253af4f68a497John McCall    return;
5248f85e193739c953358c865005855253af4f68a497John McCall
5249f85e193739c953358c865005855253af4f68a497John McCall  if (Expr *capturer = findCapturingExpr(*this, argument, owner))
5250f85e193739c953358c865005855253af4f68a497John McCall    diagnoseRetainCycle(*this, capturer, owner);
5251f85e193739c953358c865005855253af4f68a497John McCall}
5252f85e193739c953358c865005855253af4f68a497John McCall
5253921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianbool Sema::checkUnsafeAssigns(SourceLocation Loc,
5254f85e193739c953358c865005855253af4f68a497John McCall                              QualType LHS, Expr *RHS) {
5255f85e193739c953358c865005855253af4f68a497John McCall  Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime();
5256f85e193739c953358c865005855253af4f68a497John McCall  if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone)
5257921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    return false;
5258921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  // strip off any implicit cast added to get to the one arc-specific
5259921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
526033e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall    if (cast->getCastKind() == CK_ARCConsumeObject) {
5261f85e193739c953358c865005855253af4f68a497John McCall      Diag(Loc, diag::warn_arc_retained_assign)
5262bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian        << (LT == Qualifiers::OCL_ExplicitNone) << 1
5263f85e193739c953358c865005855253af4f68a497John McCall        << RHS->getSourceRange();
5264921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian      return true;
5265921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    }
5266921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    RHS = cast->getSubExpr();
5267921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  }
5268921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  return false;
5269f85e193739c953358c865005855253af4f68a497John McCall}
5270f85e193739c953358c865005855253af4f68a497John McCall
5271921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianvoid Sema::checkUnsafeExprAssigns(SourceLocation Loc,
5272921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian                              Expr *LHS, Expr *RHS) {
527387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  QualType LHSType;
527487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  // PropertyRef on LHS type need be directly obtained from
527587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  // its declaration as it has a PsuedoType.
527687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  ObjCPropertyRefExpr *PRE
527787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens());
527887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  if (PRE && !PRE->isImplicitProperty()) {
527987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    const ObjCPropertyDecl *PD = PRE->getExplicitProperty();
528087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    if (PD)
528187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      LHSType = PD->getType();
528287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  }
528387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian
528487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  if (LHSType.isNull())
528587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    LHSType = LHS->getType();
5286921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  if (checkUnsafeAssigns(Loc, LHSType, RHS))
5287921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    return;
5288921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime();
5289921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  // FIXME. Check for other life times.
5290921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  if (LT != Qualifiers::OCL_None)
5291921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    return;
5292921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian
529387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian  if (PRE) {
5294921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    if (PRE->isImplicitProperty())
5295921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian      return;
5296921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    const ObjCPropertyDecl *PD = PRE->getExplicitProperty();
5297921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    if (!PD)
5298921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian      return;
5299921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian
5300921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian    unsigned Attributes = PD->getPropertyAttributes();
530187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) {
530287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      // when 'assign' attribute was not explicitly specified
530387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      // by user, ignore it and rely on property type itself
530487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      // for lifetime info.
530587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten();
530687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian      if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) &&
530787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian          LHSType->isObjCRetainableType())
530887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian        return;
530987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian
5310921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian      while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
531133e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall        if (cast->getCastKind() == CK_ARCConsumeObject) {
5312921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian          Diag(Loc, diag::warn_arc_retained_property_assign)
5313921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian          << RHS->getSourceRange();
5314921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian          return;
5315921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian        }
5316921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian        RHS = cast->getSubExpr();
5317921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian      }
531887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian    }
5319bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian    else if (Attributes & ObjCPropertyDecl::OBJC_PR_weak) {
5320bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian      while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
5321bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian        if (cast->getCastKind() == CK_ARCConsumeObject) {
5322bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian          Diag(Loc, diag::warn_arc_retained_assign)
5323bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian          << 0 << 0<< RHS->getSourceRange();
5324bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian          return;
5325bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian        }
5326bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian        RHS = cast->getSubExpr();
5327bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian      }
5328bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian    }
5329921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian  }
5330921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian}
5331625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5332625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko//===--- CHECK: Empty statement body (-Wempty-body) ---------------------===//
5333625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5334625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkonamespace {
5335625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkobool ShouldDiagnoseEmptyStmtBody(const SourceManager &SourceMgr,
5336625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 SourceLocation StmtLoc,
5337625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 const NullStmt *Body) {
5338625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Do not warn if the body is a macro that expands to nothing, e.g:
5339625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //
5340625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // #define CALL(x)
5341625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // if (condition)
5342625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //   CALL(0);
5343625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //
5344625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (Body->hasLeadingEmptyMacro())
5345625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return false;
5346625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5347625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Get line numbers of statement and body.
5348625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  bool StmtLineInvalid;
5349625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  unsigned StmtLine = SourceMgr.getSpellingLineNumber(StmtLoc,
5350625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                                      &StmtLineInvalid);
5351625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (StmtLineInvalid)
5352625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return false;
5353625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5354625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  bool BodyLineInvalid;
5355625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  unsigned BodyLine = SourceMgr.getSpellingLineNumber(Body->getSemiLoc(),
5356625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                                      &BodyLineInvalid);
5357625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (BodyLineInvalid)
5358625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return false;
5359625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5360625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Warn if null statement and body are on the same line.
5361625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (StmtLine != BodyLine)
5362625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return false;
5363625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5364625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  return true;
5365625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko}
5366625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} // Unnamed namespace
5367625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5368625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyStmtBody(SourceLocation StmtLoc,
5369625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 const Stmt *Body,
5370625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 unsigned DiagID) {
5371625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Since this is a syntactic check, don't emit diagnostic for template
5372625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // instantiations, this just adds noise.
5373625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (CurrentInstantiationScope)
5374625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
5375625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5376625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // The body should be a null statement.
5377625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  const NullStmt *NBody = dyn_cast<NullStmt>(Body);
5378625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!NBody)
5379625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
5380625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5381625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Do the usual checks.
5382625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody))
5383625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
5384625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5385625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  Diag(NBody->getSemiLoc(), DiagID);
5386625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line);
5387625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko}
5388625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5389625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyLoopBody(const Stmt *S,
5390625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                                 const Stmt *PossibleBody) {
5391625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  assert(!CurrentInstantiationScope); // Ensured by caller
5392625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5393625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  SourceLocation StmtLoc;
5394625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  const Stmt *Body;
5395625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  unsigned DiagID;
5396625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (const ForStmt *FS = dyn_cast<ForStmt>(S)) {
5397625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    StmtLoc = FS->getRParenLoc();
5398625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    Body = FS->getBody();
5399625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    DiagID = diag::warn_empty_for_body;
5400625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  } else if (const WhileStmt *WS = dyn_cast<WhileStmt>(S)) {
5401625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    StmtLoc = WS->getCond()->getSourceRange().getEnd();
5402625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    Body = WS->getBody();
5403625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    DiagID = diag::warn_empty_while_body;
5404625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  } else
5405625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return; // Neither `for' nor `while'.
5406625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5407625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // The body should be a null statement.
5408625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  const NullStmt *NBody = dyn_cast<NullStmt>(Body);
5409625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!NBody)
5410625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
5411625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5412625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Skip expensive checks if diagnostic is disabled.
5413625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (Diags.getDiagnosticLevel(DiagID, NBody->getSemiLoc()) ==
5414625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko          DiagnosticsEngine::Ignored)
5415625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
5416625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5417625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // Do the usual checks.
5418625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody))
5419625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    return;
5420625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5421625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // `for(...);' and `while(...);' are popular idioms, so in order to keep
5422625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // noise level low, emit diagnostics only if for/while is followed by a
5423625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // CompoundStmt, e.g.:
5424625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //    for (int i = 0; i < n; i++);
5425625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //    {
5426625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //      a(i);
5427625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //    }
5428625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // or if for/while is followed by a statement with more indentation
5429625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  // than for/while itself:
5430625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //    for (int i = 0; i < n; i++);
5431625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  //      a(i);
5432625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  bool ProbableTypo = isa<CompoundStmt>(PossibleBody);
5433625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (!ProbableTypo) {
5434625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    bool BodyColInvalid;
5435625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    unsigned BodyCol = SourceMgr.getPresumedColumnNumber(
5436625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                             PossibleBody->getLocStart(),
5437625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                             &BodyColInvalid);
5438625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    if (BodyColInvalid)
5439625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko      return;
5440625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5441625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    bool StmtColInvalid;
5442625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    unsigned StmtCol = SourceMgr.getPresumedColumnNumber(
5443625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                             S->getLocStart(),
5444625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko                             &StmtColInvalid);
5445625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    if (StmtColInvalid)
5446625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko      return;
5447625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5448625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    if (BodyCol > StmtCol)
5449625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko      ProbableTypo = true;
5450625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  }
5451625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko
5452625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  if (ProbableTypo) {
5453625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    Diag(NBody->getSemiLoc(), DiagID);
5454625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko    Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line);
5455625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko  }
5456625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko}
5457