SemaChecking.cpp revision a193f20916f0e0e5a3b0f76ca69e2b3870c1a325
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// The LLVM Compiler Infrastructure 459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source 60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details. 759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump// This file implements extra semantic analysis beyond what is enforced 1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// by the C type system. 1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 155f8d604246976a93a73549b07bbc8ee0b2061b50John McCall#include "clang/Sema/Initialization.h" 16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Sema.h" 172d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 18276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman#include "clang/Sema/Initialization.h" 19831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith#include "clang/Sema/Lookup.h" 20781472fe99a120098c631b0cbe33c89f8cef5e70John McCall#include "clang/Sema/ScopeInfo.h" 21826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek#include "clang/Analysis/Analyses/FormatString.h" 2259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h" 23199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h" 24384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 25c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h" 26be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie#include "clang/AST/Expr.h" 272324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h" 287ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h" 29f85e193739c953358c865005855253af4f68a497John McCall#include "clang/AST/EvaluatedExprVisitor.h" 30f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/DeclObjC.h" 31f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h" 32f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h" 3359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h" 34f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h" 358fe83e1df954d72c0f4ffc15d20a5222ec151c21Benjamin Kramer#include "llvm/ADT/SmallString.h" 36f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h" 373bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h" 38691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher#include "clang/Basic/TargetBuiltins.h" 3926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman#include "clang/Basic/TargetInfo.h" 407da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian#include "clang/Basic/ConvertUTF.h" 41a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits> 4259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang; 43781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema; 4459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 4560800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 4660800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned ByteNo) const { 4708f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner return SL->getLocationOfByte(ByteNo, PP.getSourceManager(), 484e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie PP.getLangOpts(), PP.getTargetInfo()); 4960800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner} 5060800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 518e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number. 528e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking. Returns true on error. 538e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) { 548e10f3b9cc1db43645bbc2999eb163af8997d468John McCall unsigned argCount = call->getNumArgs(); 558e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount == desiredArgCount) return false; 568e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 578e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount < desiredArgCount) 588e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args) 598e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 608e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getSourceRange(); 618e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 628e10f3b9cc1db43645bbc2999eb163af8997d468John McCall // Highlight all the excess arguments. 638e10f3b9cc1db43645bbc2999eb163af8997d468John McCall SourceRange range(call->getArg(desiredArgCount)->getLocStart(), 648e10f3b9cc1db43645bbc2999eb163af8997d468John McCall call->getArg(argCount - 1)->getLocEnd()); 658e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 668e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args) 678e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 688e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getArg(1)->getSourceRange(); 698e10f3b9cc1db43645bbc2999eb163af8997d468John McCall} 708e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 71e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// Check that the first argument to __builtin_annotation is an integer 72e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge/// and the second argument is a non-wide string literal. 73e59392176c2369df2bdd11b7786cb38abac00198Julien Lerougestatic bool SemaBuiltinAnnotation(Sema &S, CallExpr *TheCall) { 74e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (checkArgCount(S, TheCall, 2)) 75e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge return true; 76e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 77e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge // First argument should be an integer. 78e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge Expr *ValArg = TheCall->getArg(0); 79e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge QualType Ty = ValArg->getType(); 80e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (!Ty->isIntegerType()) { 81e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge S.Diag(ValArg->getLocStart(), diag::err_builtin_annotation_first_arg) 82e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge << ValArg->getSourceRange(); 83e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge return true; 84e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge } 85e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 86e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge // Second argument should be a constant string. 87e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge Expr *StrArg = TheCall->getArg(1)->IgnoreParenCasts(); 88e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge StringLiteral *Literal = dyn_cast<StringLiteral>(StrArg); 8977f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge if (!Literal || !Literal->isAscii()) { 90e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge S.Diag(StrArg->getLocStart(), diag::err_builtin_annotation_second_arg) 91e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge << StrArg->getSourceRange(); 9277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return true; 9377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge } 94e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge 95e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge TheCall->setType(Ty); 9677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return false; 9777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge} 9877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge 9960d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 100d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 10160d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult TheCallResult(Owned(TheCall)); 1022def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor 103946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Find out if any arguments are required to be integer constant expressions. 104946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner unsigned ICEArguments = 0; 105946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ASTContext::GetBuiltinTypeError Error; 106946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 107946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (Error != ASTContext::GE_None) 108946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments = 0; // Don't diagnose previously diagnosed errors. 109946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 110946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // If any arguments are required to be ICE's, check and diagnose. 111946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 112946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Skip arguments not required to be ICE's. 113946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if ((ICEArguments & (1 << ArgNo)) == 0) continue; 114946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 115946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner llvm::APSInt Result; 116946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 117946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner return true; 118946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments &= ~(1 << ArgNo); 119946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner } 120946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 121d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson switch (BuiltinID) { 12230ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin___CFStringMakeConstantString: 123925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner assert(TheCall->getNumArgs() == 1 && 1241b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner "Wrong # arguments to builtin CFStringMakeConstantString"); 125690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner if (CheckObjCString(TheCall->getArg(0))) 1260eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 127d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 12849ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek case Builtin::BI__builtin_stdarg_start: 12930ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin_va_start: 1300eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinVAStart(TheCall)) 1310eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 132d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1331b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreater: 1341b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreaterequal: 1351b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isless: 1361b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessequal: 1371b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessgreater: 1381b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isunordered: 1390eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinUnorderedCompare(TheCall)) 1400eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 141d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 142e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer case Builtin::BI__builtin_fpclassify: 143e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer if (SemaBuiltinFPClassification(TheCall, 6)) 144e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer return ExprError(); 145e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer break; 1469ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isfinite: 1479ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf: 1489ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf_sign: 1499ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnan: 1509ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnormal: 1513b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (SemaBuiltinFPClassification(TheCall, 1)) 1529ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return ExprError(); 1539ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman break; 154d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman case Builtin::BI__builtin_shufflevector: 1550eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return SemaBuiltinShuffleVector(TheCall); 1560eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // TheCall will be freed by the smart pointer here, but that's fine, since 1570eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // SemaBuiltinShuffleVector guts it, but then doesn't release it. 1584493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar case Builtin::BI__builtin_prefetch: 1590eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinPrefetch(TheCall)) 1600eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 161d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 162d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar case Builtin::BI__builtin_object_size: 1630eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinObjectSize(TheCall)) 1640eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 165d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 166d875fed28578835de89cd407e9db4be788596d7cEli Friedman case Builtin::BI__builtin_longjmp: 167d875fed28578835de89cd407e9db4be788596d7cEli Friedman if (SemaBuiltinLongjmp(TheCall)) 168d875fed28578835de89cd407e9db4be788596d7cEli Friedman return ExprError(); 169d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1708e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 1718e10f3b9cc1db43645bbc2999eb163af8997d468John McCall case Builtin::BI__builtin_classify_type: 1728e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1738e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 1748e10f3b9cc1db43645bbc2999eb163af8997d468John McCall break; 17575c29a012793292ff4578015a9113bf086156d7fChris Lattner case Builtin::BI__builtin_constant_p: 1768e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1778e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 17875c29a012793292ff4578015a9113bf086156d7fChris Lattner break; 1795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: 180a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 181a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 182a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 183a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 184a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 1855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: 186a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 187a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 188a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 189a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 190a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 1915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: 192a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 193a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 194a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 195a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 196a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 1975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: 198a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 199a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 200a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 201a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 202a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 2035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: 204a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 205a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 206a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 207a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 208a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 2095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_add_and_fetch: 210a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 211a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 212a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 213a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 214a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 2155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_sub_and_fetch: 216a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 217a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 218a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 219a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 220a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 2215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_and_and_fetch: 222a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 223a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 224a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 225a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 226a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 2275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_or_and_fetch: 228a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 229a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 230a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 231a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 232a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 2335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_xor_and_fetch: 234a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 235a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 236a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 237a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 238a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 2395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 240a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 241a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 242a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 243a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 244a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 2455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 246a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 247a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 248a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 249a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 250a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 2515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_test_and_set: 252a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 253a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 254a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 255a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 256a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 2575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 258a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 259a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 260a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 261a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 262a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 26323aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: 264a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 265a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 266a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 267a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 268a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 2693fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return SemaBuiltinAtomicOverloaded(TheCallResult); 270ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define BUILTIN(ID, TYPE, ATTRS) 271ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#define ATOMIC_BUILTIN(ID, TYPE, ATTRS) \ 272ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Builtin::BI##ID: \ 2733fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return SemaAtomicOpsOverloaded(TheCallResult, AtomicExpr::AO##ID); 274ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith#include "clang/Basic/Builtins.def" 27577f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge case Builtin::BI__builtin_annotation: 276e59392176c2369df2bdd11b7786cb38abac00198Julien Lerouge if (SemaBuiltinAnnotation(*this, TheCall)) 27777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return ExprError(); 27877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge break; 27926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 28026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 28126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // Since the target specific builtins for each arch overlap, only check those 28226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // of the arch we are compiling for. 28326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (BuiltinID >= Builtin::FirstTSBuiltin) { 284bcfd1f55bfbb3e5944cd5e03d07b343e280838c4Douglas Gregor switch (Context.getTargetInfo().getTriple().getArch()) { 28526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::arm: 28626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::thumb: 28726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 28826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return ExprError(); 28926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 290fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips: 291fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mipsel: 292fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips64: 293fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case llvm::Triple::mips64el: 294fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (CheckMipsBuiltinFunctionCall(BuiltinID, TheCall)) 295fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return ExprError(); 296fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan break; 29726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman default: 29826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 29926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 30026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 30126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 3023fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return TheCallResult; 30326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman} 30426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 30561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code. 30661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) { 307da95f73b59f9af964e33725c515139d34c90c863Bob Wilson NeonTypeFlags Type(t); 308da95f73b59f9af964e33725c515139d34c90c863Bob Wilson int IsQuad = Type.isQuad(); 309da95f73b59f9af964e33725c515139d34c90c863Bob Wilson switch (Type.getEltType()) { 310da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int8: 311da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly8: 312da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 7 : (8 << IsQuad) - 1; 313da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int16: 314da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly16: 315da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 15 : (4 << IsQuad) - 1; 316da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int32: 317da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 31 : (2 << IsQuad) - 1; 318da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int64: 319da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 63 : (1 << IsQuad) - 1; 320da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float16: 321da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 322da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (4 << IsQuad) - 1; 323da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float32: 324da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 325da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (2 << IsQuad) - 1; 32661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman } 3277530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie llvm_unreachable("Invalid NeonTypeFlag!"); 32861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman} 32961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 3306f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// getNeonEltType - Return the QualType corresponding to the elements of 3316f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the vector type specified by the NeonTypeFlags. This is used to check 3326f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the pointer arguments for Neon load/store intrinsics. 3336f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilsonstatic QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context) { 3346f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson switch (Flags.getEltType()) { 3356f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int8: 3366f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy; 3376f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int16: 3386f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy; 3396f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int32: 3406f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy; 3416f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int64: 3426f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedLongLongTy : Context.LongLongTy; 3436f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly8: 3446f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.SignedCharTy; 3456f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly16: 3466f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.ShortTy; 3476f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float16: 3486f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.UnsignedShortTy; 3496f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float32: 3506f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.FloatTy; 3516f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 3527530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie llvm_unreachable("Invalid NeonTypeFlag!"); 3536f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson} 3546f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 35526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 3561c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman llvm::APSInt Result; 3571c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 358f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith uint64_t mask = 0; 35961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned TV = 0; 3604648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson int PtrArgNum = -1; 3616f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson bool HasConstPtr = false; 3621c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman switch (BuiltinID) { 363a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK 364a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 365a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK 3661c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman } 3671c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 3680d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which are overloaded on vector element type, validate 3690d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // the immediate which specifies which variant to emit. 3706f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson unsigned ImmArg = TheCall->getNumArgs()-1; 3710d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (mask) { 3726f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson if (SemaBuiltinConstantArg(TheCall, ImmArg, Result)) 3730d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 3740d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 375da95f73b59f9af964e33725c515139d34c90c863Bob Wilson TV = Result.getLimitedValue(64); 376f8ee6bc1ef0eec8e22b413dfc2baa3cfa4f19f91Richard Smith if ((TV > 63) || (mask & (1ULL << TV)) == 0) 3770d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 3786f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson << TheCall->getArg(ImmArg)->getSourceRange(); 3796f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 3806f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 3814648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (PtrArgNum >= 0) { 3826f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson // Check that pointer arguments have the specified type. 3834648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Expr *Arg = TheCall->getArg(PtrArgNum); 3844648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) 3854648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Arg = ICE->getSubExpr(); 3864648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg); 3874648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType RHSTy = RHS.get()->getType(); 3884648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context); 3894648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (HasConstPtr) 3904648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson EltTy = EltTy.withConst(); 3914648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType LHSTy = Context.getPointerType(EltTy); 3924648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson AssignConvertType ConvTy; 3934648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS); 3944648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (RHS.isInvalid()) 3954648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 3964648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy, 3974648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson RHS.get(), AA_Assigning)) 3984648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 3990d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman } 4001c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 4010d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which take an immediate value as part of the 4020d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // instruction, range check them here. 40361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned i = 0, l = 0, u = 0; 4040d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman switch (BuiltinID) { 4050d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman default: return false; 406bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 407bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 40899c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_f: 40999c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 410a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK 411a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 412a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK 4130d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman }; 4140d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 415592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 416592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 417592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor TheCall->getArg(i)->isValueDependent()) 418592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor return false; 419592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 42061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Check that the immediate argument is actually a constant. 4210d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, i, Result)) 4220d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 4230d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 42461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Range check against the upper/lower values for this isntruction. 4250d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned Val = Result.getZExtValue(); 42661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if (Val < l || Val > (u + l)) 4270d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 428476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer << l << u+l << TheCall->getArg(i)->getSourceRange(); 4290d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 43099c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman // FIXME: VFP Intrinsics should error if VFP not present. 43126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return false; 432d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson} 433d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 434fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyanbool Sema::CheckMipsBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 435fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan unsigned i = 0, l = 0, u = 0; 436fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan switch (BuiltinID) { 437fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan default: return false; 438fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case Mips::BI__builtin_mips_wrdsp: i = 1; l = 0; u = 63; break; 439fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan case Mips::BI__builtin_mips_rddsp: i = 0; l = 0; u = 63; break; 440be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_append: i = 2; l = 0; u = 31; break; 441be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_balign: i = 2; l = 0; u = 3; break; 442be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_precr_sra_ph_w: i = 2; l = 0; u = 31; break; 443be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_precr_sra_r_ph_w: i = 2; l = 0; u = 31; break; 444be22cb84f32cfa6cf0b6bdaf523288b747bb0f18Simon Atanasyan case Mips::BI__builtin_mips_prepend: i = 2; l = 0; u = 31; break; 445fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan }; 446fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 447fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // We can't check the value of a dependent argument. 448fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (TheCall->getArg(i)->isTypeDependent() || 449fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan TheCall->getArg(i)->isValueDependent()) 450fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return false; 451fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 452fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // Check that the immediate argument is actually a constant. 453fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan llvm::APSInt Result; 454fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (SemaBuiltinConstantArg(TheCall, i, Result)) 455fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return true; 456fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 457fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan // Range check against the upper/lower values for this instruction. 458fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan unsigned Val = Result.getZExtValue(); 459fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan if (Val < l || Val > u) 460fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 461fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan << l << u << TheCall->getArg(i)->getSourceRange(); 462fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 463fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan return false; 464fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan} 465fad0a32da8ea34a58aa0a0dd3fd67cd30959b080Simon Atanasyan 466831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Given a FunctionDecl's FormatAttr, attempts to populate the FomatStringInfo 467831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// parameter with the FormatAttr's correct format_idx and firstDataArg. 468831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true when the format fits the function and the FormatStringInfo has 469831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// been populated. 470831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::getFormatStringInfo(const FormatAttr *Format, bool IsCXXMember, 471831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FormatStringInfo *FSI) { 472831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->HasVAListArg = Format->getFirstArg() == 0; 473831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->FormatIdx = Format->getFormatIdx() - 1; 474831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI->FirstDataArg = FSI->HasVAListArg ? 0 : Format->getFirstArg() - 1; 475de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 476831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // The way the format attribute works in GCC, the implicit this argument 477831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // of member functions is counted. However, it doesn't appear in our own 478831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // lists, so decrement format_idx in that case. 479831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (IsCXXMember) { 480831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if(FSI->FormatIdx == 0) 481831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 482831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith --FSI->FormatIdx; 483831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (FSI->FirstDataArg != 0) 484831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith --FSI->FirstDataArg; 485831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 486831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return true; 487831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 4881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 489831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Handles the checks for format strings, non-POD arguments to vararg 490831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// functions, and NULL arguments passed to non-NULL parameters. 491831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithvoid Sema::checkCall(NamedDecl *FDecl, Expr **Args, 492831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumArgs, 493831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs, 494831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool IsMemberFunction, 495831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation Loc, 496831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceRange Range, 497831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType) { 498de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // FIXME: This mechanism should be abstracted to be less fragile and 499de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // more efficient. For example, just map function ids to custom 500de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // handlers. 501de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 502c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek // Printf and scanf checking. 503831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool HandledFormatString = false; 504c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<FormatAttr> 505831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith I = FDecl->specific_attr_begin<FormatAttr>(), 506831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith E = FDecl->specific_attr_end<FormatAttr>(); I != E ; ++I) 507ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose if (CheckFormatArguments(*I, Args, NumArgs, IsMemberFunction, CallType, 508ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Loc, Range)) 509831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HandledFormatString = true; 510831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 511831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // Refuse POD arguments that weren't caught by the format string 512831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // checks above. 513831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!HandledFormatString && CallType != VariadicDoesNotApply) 514831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith for (unsigned ArgIdx = NumProtoArgs; ArgIdx < NumArgs; ++ArgIdx) 515831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith variadicArgumentPODCheck(Args[ArgIdx], CallType); 5161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 517c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<NonNullAttr> 518831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith I = FDecl->specific_attr_begin<NonNullAttr>(), 519831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith E = FDecl->specific_attr_end<NonNullAttr>(); I != E; ++I) 520831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith CheckNonNullArguments(*I, Args, Loc); 5210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 5220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Type safety checking. 5230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (specific_attr_iterator<ArgumentWithTypeTagAttr> 5240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko i = FDecl->specific_attr_begin<ArgumentWithTypeTagAttr>(), 5250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko e = FDecl->specific_attr_end<ArgumentWithTypeTagAttr>(); i != e; ++i) { 5260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko CheckArgumentWithTypeTag(*i, Args); 5270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 528831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 529831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 530831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckConstructorCall - Check a constructor call for correctness and safety 531831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// properties not enforced by the C type system. 532831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithvoid Sema::CheckConstructorCall(FunctionDecl *FDecl, Expr **Args, 533831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumArgs, 534831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const FunctionProtoType *Proto, 535831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation Loc) { 536831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = 537831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Proto->isVariadic() ? VariadicConstructor : VariadicDoesNotApply; 538831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith checkCall(FDecl, Args, NumArgs, Proto->getNumArgs(), 539831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*IsMemberFunction=*/true, Loc, SourceRange(), CallType); 540831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 541831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 542831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// CheckFunctionCall - Check a direct function call for various correctness 543831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// and safety properties not strictly enforced by the C type system. 544831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall, 545831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const FunctionProtoType *Proto) { 546831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool IsMemberFunction = isa<CXXMemberCallExpr>(TheCall); 547831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = getVariadicCallType(FDecl, Proto, 548831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()); 549831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0; 550831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith checkCall(FDecl, TheCall->getArgs(), TheCall->getNumArgs(), NumProtoArgs, 551831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith IsMemberFunction, TheCall->getRParenLoc(), 552831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()->getSourceRange(), CallType); 553831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 554831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith IdentifierInfo *FnInfo = FDecl->getIdentifier(); 555831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // None of the checks below are needed for functions that don't have 556831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // simple names (e.g., C++ conversion functions). 557831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!FnInfo) 558831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 5590eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 5600a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned CMId = FDecl->getMemoryFunctionKind(); 5610a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == 0) 562d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks return false; 563bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 564d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks // Handle memory setting and copying functions. 5650a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat) 566bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CheckStrlcpycatArguments(TheCall, FnInfo); 567c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (CMId == Builtin::BIstrncat) 568c36bedc90c687caa71748480c60707ea4608b092Anna Zaks CheckStrncatArguments(TheCall, FnInfo); 569d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks else 5700a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks CheckMemaccessArguments(TheCall, CMId, FnInfo); 5717ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 572d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 57371993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson} 57471993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 57529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupasbool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac, 57629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **Args, unsigned NumArgs) { 577831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = 578831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Method->isVariadic() ? VariadicMethod : VariadicDoesNotApply; 57929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 580831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith checkCall(Method, Args, NumArgs, Method->param_size(), 581831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*IsMemberFunction=*/false, 582831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith lbrac, Method->getSourceRange(), CallType); 58329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 58429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return false; 58529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 58629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 587831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall, 588831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const FunctionProtoType *Proto) { 589725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian const VarDecl *V = dyn_cast<VarDecl>(NDecl); 590725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!V) 591d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 5921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 593725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian QualType Ty = V->getType(); 594725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Ty->isBlockPointerType()) 595d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 5961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 597831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith VariadicCallType CallType = 598831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Proto && Proto->isVariadic() ? VariadicBlock : VariadicDoesNotApply ; 599831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0; 600d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 601831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith checkCall(NDecl, TheCall->getArgs(), TheCall->getNumArgs(), 602831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith NumProtoArgs, /*IsMemberFunction=*/false, 603831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getRParenLoc(), 604831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith TheCall->getCallee()->getSourceRange(), CallType); 605831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 606d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 607725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian} 608725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian 609ff34d401ff385ef7173ca612432b4ea717fff690Richard SmithExprResult Sema::SemaAtomicOpsOverloaded(ExprResult TheCallResult, 610ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith AtomicExpr::AtomicOp Op) { 611276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman CallExpr *TheCall = cast<CallExpr>(TheCallResult.get()); 612276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 613276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 614ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // All these operations take one of the following forms: 615ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith enum { 616ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_init(A *, C) 617ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Init, 618ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_load(A *, int) 619ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Load, 620ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // void __atomic_load(A *, CP, int) 621ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Copy, 622ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __c11_atomic_add(A *, M, int) 623ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Arithmetic, 624ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C __atomic_exchange_n(A *, CP, int) 625ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Xchg, 626ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // void __atomic_exchange(A *, C *, CP, int) 627ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith GNUXchg, 628ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // bool __c11_atomic_compare_exchange_strong(A *, C *, CP, int, int) 629ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith C11CmpXchg, 630ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // bool __atomic_compare_exchange(A *, C *, CP, bool, int, int) 631ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith GNUCmpXchg 632ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } Form = Init; 633ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith const unsigned NumArgs[] = { 2, 2, 3, 3, 3, 4, 5, 6 }; 634ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith const unsigned NumVals[] = { 1, 0, 1, 1, 1, 2, 2, 3 }; 635ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // where: 636ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // C is an appropriate type, 637ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // A is volatile _Atomic(C) for __c11 builtins and is C for GNU builtins, 638ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // CP is C for __c11 builtins and GNU _n builtins and is C * otherwise, 639ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // M is C if C is an integer, and ptrdiff_t if C is a pointer, and 640ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // the int parameters are for orderings. 641ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 642ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith assert(AtomicExpr::AO__c11_atomic_init == 0 && 643ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith AtomicExpr::AO__c11_atomic_fetch_xor + 1 == AtomicExpr::AO__atomic_load 644ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith && "need to update code for modified C11 atomics"); 645ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsC11 = Op >= AtomicExpr::AO__c11_atomic_init && 646ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op <= AtomicExpr::AO__c11_atomic_fetch_xor; 647ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsN = Op == AtomicExpr::AO__atomic_load_n || 648ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_store_n || 649ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_exchange_n || 650ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Op == AtomicExpr::AO__atomic_compare_exchange_n; 651ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith bool IsAddSub = false; 652ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 653ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (Op) { 654ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_init: 655ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Init; 656ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 657ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 658ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_load: 659ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_load_n: 660ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Load; 661ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 662ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 663ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_store: 664ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_load: 665ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_store: 666ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_store_n: 667ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Copy; 668ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 669ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 670ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_add: 671ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_sub: 672ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_add: 673ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_sub: 674ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_add_fetch: 675ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_sub_fetch: 676ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith IsAddSub = true; 677ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Fall through. 678ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_and: 679ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_or: 680ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_fetch_xor: 681ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_and: 682ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_or: 683ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_fetch_xor: 68451b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith case AtomicExpr::AO__atomic_fetch_nand: 685ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_and_fetch: 686ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_or_fetch: 687ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_xor_fetch: 68851b92401c9f95023a2ef27064fd5a60fd99175f5Richard Smith case AtomicExpr::AO__atomic_nand_fetch: 689ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Arithmetic; 690ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 691ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 692ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_exchange: 693ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_exchange_n: 694ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = Xchg; 695ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 696ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 697ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_exchange: 698ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = GNUXchg; 699ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 700ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 701ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_compare_exchange_strong: 702ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__c11_atomic_compare_exchange_weak: 703ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = C11CmpXchg; 704ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 705ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 706ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_compare_exchange: 707ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case AtomicExpr::AO__atomic_compare_exchange_n: 708ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Form = GNUCmpXchg; 709ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 710276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 711276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 712ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Check we have the right number of arguments. 713ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (TheCall->getNumArgs() < NumArgs[Form]) { 714276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 715ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << 0 << NumArgs[Form] << TheCall->getNumArgs() 716276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 717276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 718ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } else if (TheCall->getNumArgs() > NumArgs[Form]) { 719ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(TheCall->getArg(NumArgs[Form])->getLocStart(), 720276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman diag::err_typecheck_call_too_many_args) 721ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << 0 << NumArgs[Form] << TheCall->getNumArgs() 722276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 723276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 724276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 725276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 726ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Inspect the first argument of the atomic operation. 727dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman Expr *Ptr = TheCall->getArg(0); 728276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get(); 729276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman const PointerType *pointerType = Ptr->getType()->getAs<PointerType>(); 730276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!pointerType) { 731ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 732276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 733276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 734276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 735276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 736ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For a __c11 builtin, this should be a pointer to an _Atomic type. 737ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType AtomTy = pointerType->getPointeeType(); // 'A' 738ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType ValType = AtomTy; // 'C' 739ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (IsC11) { 740ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!AtomTy->isAtomicType()) { 741ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic) 742ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << Ptr->getType() << Ptr->getSourceRange(); 743ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 744ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 745bc57b108b2253e26b83768dba196c28564952f18Richard Smith if (AtomTy.isConstQualified()) { 746bc57b108b2253e26b83768dba196c28564952f18Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_non_const_atomic) 747bc57b108b2253e26b83768dba196c28564952f18Richard Smith << Ptr->getType() << Ptr->getSourceRange(); 748bc57b108b2253e26b83768dba196c28564952f18Richard Smith return ExprError(); 749bc57b108b2253e26b83768dba196c28564952f18Richard Smith } 750ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ValType = AtomTy->getAs<AtomicType>()->getValueType(); 751276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 752276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 753ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For an arithmetic operation, the implied arithmetic must be well-formed. 754ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Arithmetic) { 755ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // gcc does not enforce these rules for GNU atomics, but we do so for sanity. 756ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (IsAddSub && !ValType->isIntegerType() && !ValType->isPointerType()) { 757ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 758ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 759ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 760ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 761ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsAddSub && !ValType->isIntegerType()) { 762ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_bitwise_needs_atomic_int) 763ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 764ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith return ExprError(); 765ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 766ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } else if (IsN && !ValType->isIntegerType() && !ValType->isPointerType()) { 767ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For __atomic_*_n operations, the value type must be a scalar integral or 768ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // pointer type which is 1, 2, 4, 8 or 16 bytes in length. 769276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 770ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith << IsC11 << Ptr->getType() << Ptr->getSourceRange(); 771276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 772276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 773276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 774ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsC11 && !AtomTy.isTriviallyCopyableType(Context)) { 775ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // For GNU atomics, require a trivially-copyable type. This is not part of 776ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // the GNU atomics specification, but we enforce it for sanity. 777ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Diag(DRE->getLocStart(), diag::err_atomic_op_needs_trivial_copy) 778276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 779276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 780276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 781276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 782ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // FIXME: For any builtin other than a load, the ValType must not be 783ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // const-qualified. 784ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 785276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman switch (ValType.getObjCLifetime()) { 786276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_None: 787276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_ExplicitNone: 788276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // okay 789276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman break; 790276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 791276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Weak: 792276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Strong: 793276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Autoreleasing: 794ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // FIXME: Can this happen? By this point, ValType should be known 795ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // to be trivially copyable. 796276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 797276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << ValType << Ptr->getSourceRange(); 798276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 799276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 800276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 801276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType ResultType = ValType; 802ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Copy || Form == GNUXchg || Form == Init) 803276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.VoidTy; 804ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == C11CmpXchg || Form == GNUCmpXchg) 805276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.BoolTy; 806276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 807ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The type of a parameter passed 'by value'. In the GNU atomics, such 808ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // arguments are actually passed as pointers. 809ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith QualType ByValType = ValType; // 'CP' 810ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (!IsC11 && !IsN) 811ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ByValType = Ptr->getType(); 812ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 813276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The first argument --- the pointer --- has a fixed type; we 814276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // deduce the types of the rest of the arguments accordingly. Walk 815276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // the remaining arguments, converting them to the deduced value type. 816ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith for (unsigned i = 1; i != NumArgs[Form]; ++i) { 817276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType Ty; 818ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (i < NumVals[Form] + 1) { 819ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (i) { 820ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 1: 821ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The second argument is the non-atomic operand. For arithmetic, this 822ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // is always passed by value, and for a compare_exchange it is always 823ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // passed by address. For the rest, GNU uses by-address and C11 uses 824ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // by-value. 825ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith assert(Form != Load); 826ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith if (Form == Init || (Form == Arithmetic && ValType->isIntegerType())) 827ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ValType; 828ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == Copy || Form == Xchg) 829ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ByValType; 830ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else if (Form == Arithmetic) 831ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.getPointerDiffType(); 832ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith else 833ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.getPointerType(ValType.getUnqualifiedType()); 834ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 835ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 2: 836ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The third argument to compare_exchange / GNU exchange is a 837ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // (pointer to a) desired value. 838ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = ByValType; 839ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 840ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case 3: 841ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // The fourth argument to GNU compare_exchange is a 'weak' flag. 842ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith Ty = Context.BoolTy; 843ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 844ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith } 845276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else { 846276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The order(s) are always converted to int. 847276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.IntTy; 848276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 849ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith 850276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity Entity = 851276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity::InitializeParameter(Context, Ty, false); 852ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith ExprResult Arg = TheCall->getArg(i); 853276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 854276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Arg.isInvalid()) 855276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return true; 856276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman TheCall->setArg(i, Arg.get()); 857276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 858276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 859ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Permute the arguments into a 'consistent' order. 860dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SmallVector<Expr*, 5> SubExprs; 861dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(Ptr); 862ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith switch (Form) { 863ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Init: 864ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Note, AtomicExpr::getVal1() has a special case for this atomic. 8657a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall SubExprs.push_back(TheCall->getArg(1)); // Val1 866ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 867ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Load: 868ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Order 869ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 870ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Copy: 871ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Arithmetic: 872ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case Xchg: 873dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(2)); // Order 874dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 875ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 876ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case GNUXchg: 877ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith // Note, AtomicExpr::getVal2() has a special case for this atomic. 878ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(3)); // Order 879ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Val1 880ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(2)); // Val2 881ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 882ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case C11CmpXchg: 883dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(3)); // Order 884dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 885dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(4)); // OrderFail 8862ebb98a78471f2039af4321bae657e7daacc2a62David Chisnall SubExprs.push_back(TheCall->getArg(2)); // Val2 887ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 888ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith case GNUCmpXchg: 889ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(4)); // Order 890ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(1)); // Val1 891ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(5)); // OrderFail 892ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(2)); // Val2 893ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith SubExprs.push_back(TheCall->getArg(3)); // Weak 894ff34d401ff385ef7173ca612432b4ea717fff690Richard Smith break; 895276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 896dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman 897dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman return Owned(new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(), 8983b6bef9a213249c6ab6d67c07b1ac6380961be3eBenjamin Kramer SubExprs, ResultType, Op, 899dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman TheCall->getRParenLoc())); 900276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman} 901276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 902276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 9035f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// checkBuiltinArgument - Given a call to a builtin function, perform 9045f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// normal type-checking on the given argument, updating the call in 9055f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// place. This is useful when a builtin function requires custom 9065f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// type-checking for some of its arguments but not necessarily all of 9075f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// them. 9085f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// 9095f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// Returns true on error. 9105f8d604246976a93a73549b07bbc8ee0b2061b50John McCallstatic bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) { 9115f8d604246976a93a73549b07bbc8ee0b2061b50John McCall FunctionDecl *Fn = E->getDirectCallee(); 9125f8d604246976a93a73549b07bbc8ee0b2061b50John McCall assert(Fn && "builtin call without direct callee!"); 9135f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9145f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ParmVarDecl *Param = Fn->getParamDecl(ArgIndex); 9155f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity Entity = 9165f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity::InitializeParameter(S.Context, Param); 9175f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9185f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ExprResult Arg = E->getArg(0); 9195f8d604246976a93a73549b07bbc8ee0b2061b50John McCall Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg); 9205f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (Arg.isInvalid()) 9215f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 9225f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9235f8d604246976a93a73549b07bbc8ee0b2061b50John McCall E->setArg(ArgIndex, Arg.take()); 9245f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return false; 9255f8d604246976a93a73549b07bbc8ee0b2061b50John McCall} 9265f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 9275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like 9285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer 9295caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument. The main ActOnCallExpr routines have already 9305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as 9315caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...). 9325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// 9335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these 9345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins, 93560d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 93660d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 937d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 9385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 9395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 9405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 9415caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Ensure that we have at least one argument to do type inference from. 942d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1) { 943d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 944d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1 << TheCall->getNumArgs() 945d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 946d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 947d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 9481eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Inspect the first argument of the atomic builtin. This should always be 9505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // a pointer type, whose element is an integral scalar or pointer type. 9515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Because it is a pointer type, we don't have to worry about any implicit 9525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // casts here. 953d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth // FIXME: We don't allow floating point scalars as input. 9545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *FirstArg = TheCall->getArg(0); 9558c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg); 9568c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman if (FirstArgResult.isInvalid()) 9578c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman return ExprError(); 9588c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman FirstArg = FirstArgResult.take(); 9598c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman TheCall->setArg(0, FirstArg); 9608c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman 961f85e193739c953358c865005855253af4f68a497John McCall const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>(); 962f85e193739c953358c865005855253af4f68a497John McCall if (!pointerType) { 963d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 964d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 965d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 966d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 9671eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 968f85e193739c953358c865005855253af4f68a497John McCall QualType ValType = pointerType->getPointeeType(); 969dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 970d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth !ValType->isBlockPointerType()) { 971d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 972d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 973d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 974d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 9755caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 976f85e193739c953358c865005855253af4f68a497John McCall switch (ValType.getObjCLifetime()) { 977f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 978f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 979f85e193739c953358c865005855253af4f68a497John McCall // okay 980f85e193739c953358c865005855253af4f68a497John McCall break; 981f85e193739c953358c865005855253af4f68a497John McCall 982f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 983f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 984f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 985b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 986f85e193739c953358c865005855253af4f68a497John McCall << ValType << FirstArg->getSourceRange(); 987f85e193739c953358c865005855253af4f68a497John McCall return ExprError(); 988f85e193739c953358c865005855253af4f68a497John McCall } 989f85e193739c953358c865005855253af4f68a497John McCall 990b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Strip any qualifiers off ValType. 991b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType = ValType.getUnqualifiedType(); 992b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall 9938d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // The majority of builtins return a value, but a few have special return 9948d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // types, so allow them to override appropriately below. 9958d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth QualType ResultType = ValType; 9968d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth 9975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // We need to figure out which concrete builtin this maps onto. For example, 9985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add with a 2 byte object turns into 9995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add_2. 10005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \ 10015caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 10025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Builtin::BI##x##_8, Builtin::BI##x##_16 } 10031eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner static const unsigned BuiltinIndices[][5] = { 10055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_add), 10065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_sub), 10075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_or), 10085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_and), 10095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_xor), 10101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_add_and_fetch), 10125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_sub_and_fetch), 10135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_and_and_fetch), 10145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_or_and_fetch), 10155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_xor_and_fetch), 10161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_val_compare_and_swap), 10185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_bool_compare_and_swap), 10195caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_test_and_set), 102023aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_lock_release), 102123aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_swap) 10225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner }; 10231eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW 10241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Determine the index of the size. 10265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned SizeIndex; 1027199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 10285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 1: SizeIndex = 0; break; 10295caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 2: SizeIndex = 1; break; 10305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 4: SizeIndex = 2; break; 10315caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 8: SizeIndex = 3; break; 10325caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 16: SizeIndex = 4; break; 10335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: 1034d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 1035d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 1036d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 10375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 10381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Each of these builtins has one pointer argument, followed by some number of 10405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // values (0, 1 or 2) followed by a potentially empty varags list of stuff 10415caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // that we ignore. Find out which row of BuiltinIndices to read from as well 10425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // as the number of fixed args. 10437814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor unsigned BuiltinID = FDecl->getBuiltinID(); 10445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned BuiltinIndex, NumFixed = 1; 10455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner switch (BuiltinID) { 1046b219cfc4d75f0a03630b7c4509ef791b7e97b2c8David Blaikie default: llvm_unreachable("Unknown overloaded atomic builtin!"); 1047a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add: 1048a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 1049a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 1050a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 1051a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 1052a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 1053a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 0; 1054a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1055a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1056a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub: 1057a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 1058a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 1059a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 1060a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 1061a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 1062a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 1; 1063a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1064a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1065a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or: 1066a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 1067a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 1068a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 1069a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 1070a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 1071a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 2; 1072a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1073a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1074a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and: 1075a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 1076a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 1077a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 1078a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 1079a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 1080a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 3; 1081a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1082a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1083a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor: 1084a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 1085a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 1086a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 1087a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 1088a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 1089a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 4; 1090a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1091a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1092a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch: 1093a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 1094a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 1095a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 1096a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 1097a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 1098a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 5; 1099a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1100a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1101a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch: 1102a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 1103a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 1104a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 1105a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 1106a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 1107a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 6; 1108a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1109a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1110a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch: 1111a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 1112a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 1113a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 1114a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 1115a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 1116a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 7; 1117a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1118a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1119a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch: 1120a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 1121a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 1122a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 1123a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 1124a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 1125a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 8; 1126a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1127a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1128a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch: 1129a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 1130a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 1131a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 1132a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 1133a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 1134a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 9; 1135a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 11361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 1138a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 1139a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 1140a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 1141a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 1142a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 11437eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 10; 11445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 11455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1146a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 11475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 1148a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 1149a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 1150a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 1151a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 1152a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 11537eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 11; 11545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 11558d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.BoolTy; 11565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1157a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1158a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set: 1159a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 1160a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 1161a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 1162a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 1163a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 1164a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 12; 1165a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 1166a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 11675caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 1168a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 1169a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 1170a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 1171a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 1172a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 11737eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 13; 11745caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 0; 11758d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.VoidTy; 11765caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 1177a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 1178a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap: 1179a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 1180a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 1181a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 1182a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 1183a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 1184a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 14; 1185a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 11865caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 11871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Now that we know how many fixed arguments we expect, first check that we 11895caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // have at least that many. 1190d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1+NumFixed) { 1191d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 1192d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1+NumFixed << TheCall->getNumArgs() 1193d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 1194d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 1195d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 11961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1197e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // Get the decl for the concrete builtin from this, we can tell what the 1198e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // concrete integer type we should convert to is. 1199e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 1200e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 1201e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName); 12021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump FunctionDecl *NewBuiltinDecl = 1203e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID, 1204e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner TUScope, false, DRE->getLocStart())); 1205d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 1206f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // The first argument --- the pointer --- has a fixed type; we 1207f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // deduce the types of the rest of the arguments accordingly. Walk 1208f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // the remaining arguments, converting them to the deduced value type. 12095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner for (unsigned i = 0; i != NumFixed; ++i) { 1210429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult Arg = TheCall->getArg(i+1); 12111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // GCC does an implicit conversion to the pointer or integer ValType. This 12135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // can fail in some cases (1i -> int**), check for this error case now. 1214b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Initialize the argument. 1215b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall InitializedEntity Entity = InitializedEntity::InitializeParameter(Context, 1216b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType, /*consume*/ false); 1217b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 1218429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (Arg.isInvalid()) 1219d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 12201eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Okay, we have something that *can* be converted to the right type. Check 12225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // to see if there is a potentially weird extension going on here. This can 12235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // happen when you do an atomic operation on something like an char* and 12245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // pass in 42. The 42 gets converted to char. This is even more strange 12255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // for things like 45.123 -> char, etc. 12261eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // FIXME: Do this check. 1227b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall TheCall->setArg(i+1, Arg.take()); 12285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 12291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1230bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor ASTContext& Context = this->getASTContext(); 1231bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor 1232bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor // Create a new DeclRefExpr to refer to the new decl. 1233bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DeclRefExpr* NewDRE = DeclRefExpr::Create( 1234bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor Context, 1235bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getQualifierLoc(), 1236e4b92761b43ced611c417ae478568610f1ad7b1eAbramo Bagnara SourceLocation(), 1237bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor NewBuiltinDecl, 1238f4b88a45902af1802a1cb42ba48b1c474474f228John McCall /*enclosing*/ false, 1239bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getLocation(), 1240a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman Context.BuiltinFnTy, 1241bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getValueKind()); 12421eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12435caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Set the callee in the CallExpr. 1244a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman // FIXME: This loses syntactic information. 1245a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman QualType CalleePtrTy = Context.getPointerType(NewBuiltinDecl->getType()); 1246a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman ExprResult PromotedCall = ImpCastExprToType(NewDRE, CalleePtrTy, 1247a6c66cedc022c9e5d45a937d6b8cff491a6bf81bEli Friedman CK_BuiltinFnToFnPtr); 1248429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setCallee(PromotedCall.take()); 12491eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1250db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // Change the result type of the call to match the original value type. This 1251db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // is arbitrary, but the codegen for these builtins ins design to handle it 1252db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // gracefully. 12538d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth TheCall->setType(ResultType); 1254d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 12553fe198bf0d6118c7b080c17c3bb28d7c84e458b9Benjamin Kramer return TheCallResult; 12565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner} 12575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 1258690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin 125971993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct 1260fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would 1261fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend). 1262690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) { 126356f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner Arg = Arg->IgnoreParenCasts(); 126471993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 126571993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 12665cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!Literal || !Literal->isAscii()) { 1267fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 1268fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << Arg->getSourceRange(); 12699cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return true; 127071993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson } 12711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12727da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Literal->containsNonAsciiOrNull()) { 12735f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef String = Literal->getString(); 12747da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian unsigned NumBytes = String.size(); 12755f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<UTF16, 128> ToBuf(NumBytes); 127631ba6135375433b617a8587ea6cc836a014ebd86Roman Divacky const UTF8 *FromPtr = (const UTF8 *)String.data(); 12777da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian UTF16 *ToPtr = &ToBuf[0]; 12787da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 12797da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 12807da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian &ToPtr, ToPtr + NumBytes, 12817da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian strictConversion); 12827da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian // Check for conversion failure. 12837da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Result != conversionOK) 12847da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian Diag(Arg->getLocStart(), 12857da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian diag::warn_cfstring_truncated) << Arg->getSourceRange(); 12867da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian } 12879cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return false; 128859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner} 128959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 1290c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 1291c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success. 1292925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 1293925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *Fn = TheCall->getCallee(); 1294925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) { 12952c21a073525cdfa68e4439b7af551385dc2796abChris Lattner Diag(TheCall->getArg(2)->getLocStart(), 1296fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1297ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1298ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << Fn->getSourceRange() 12991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(2)->getLocStart(), 1300fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 130130ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 130230ce344307f8a8b00054021307015571f83c7364Chris Lattner } 130356f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 130456f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman if (TheCall->getNumArgs() < 2) { 1305d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher return Diag(TheCall->getLocEnd(), 1306d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 1307d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 130856f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman } 130956f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 13105f8d604246976a93a73549b07bbc8ee0b2061b50John McCall // Type-check the first argument normally. 13115f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (checkBuiltinArgument(*this, TheCall, 0)) 13125f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 13135f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 1314c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner // Determine whether the current function is variadic or not. 13159ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor BlockScopeInfo *CurBlock = getCurBlock(); 1316c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner bool isVariadic; 1317cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1318c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall isVariadic = CurBlock->TheDecl->isVariadic(); 13199498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else if (FunctionDecl *FD = getCurFunctionDecl()) 13209498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek isVariadic = FD->isVariadic(); 13219498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else 132253d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis isVariadic = getCurMethodDecl()->isVariadic(); 13231eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1324c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner if (!isVariadic) { 132530ce344307f8a8b00054021307015571f83c7364Chris Lattner Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 132630ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 132730ce344307f8a8b00054021307015571f83c7364Chris Lattner } 13281eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 132930ce344307f8a8b00054021307015571f83c7364Chris Lattner // Verify that the second argument to the builtin is the last argument of the 133030ce344307f8a8b00054021307015571f83c7364Chris Lattner // current function or method. 133130ce344307f8a8b00054021307015571f83c7364Chris Lattner bool SecondArgIsLastNamedArgument = false; 1332e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 13331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 133488cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 133588cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 133630ce344307f8a8b00054021307015571f83c7364Chris Lattner // FIXME: This isn't correct for methods (results in bogus warning). 133730ce344307f8a8b00054021307015571f83c7364Chris Lattner // Get the last formal in the current function. 133888cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson const ParmVarDecl *LastArg; 1339cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1340cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff LastArg = *(CurBlock->TheDecl->param_end()-1); 1341cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff else if (FunctionDecl *FD = getCurFunctionDecl()) 1342371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner LastArg = *(FD->param_end()-1); 134330ce344307f8a8b00054021307015571f83c7364Chris Lattner else 134453d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis LastArg = *(getCurMethodDecl()->param_end()-1); 134530ce344307f8a8b00054021307015571f83c7364Chris Lattner SecondArgIsLastNamedArgument = PV == LastArg; 134630ce344307f8a8b00054021307015571f83c7364Chris Lattner } 134730ce344307f8a8b00054021307015571f83c7364Chris Lattner } 13481eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 134930ce344307f8a8b00054021307015571f83c7364Chris Lattner if (!SecondArgIsLastNamedArgument) 13501eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(1)->getLocStart(), 135130ce344307f8a8b00054021307015571f83c7364Chris Lattner diag::warn_second_parameter_of_va_start_not_last_named_argument); 135230ce344307f8a8b00054021307015571f83c7364Chris Lattner return false; 13536cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman} 135430ce344307f8a8b00054021307015571f83c7364Chris Lattner 13551b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 13561b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends. This is declared to take (...), so we have to check everything. 1357925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 1358925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() < 2) 13592c21a073525cdfa68e4439b7af551385dc2796abChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1360d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << 2 << TheCall->getNumArgs()/*function call*/; 1361925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) 13621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(TheCall->getArg(2)->getLocStart(), 1363fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1364ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1365fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(TheCall->getArg(2)->getLocStart(), 1366fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 13671eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1368429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg0 = TheCall->getArg(0); 1369429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg1 = TheCall->getArg(1); 1370cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 13711b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // Do standard promotions between the two arguments, returning their common 13721b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // type. 1373925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 1374429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.isInvalid() || OrigArg1.isInvalid()) 1375429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return true; 1376403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar 1377403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // Make sure any conversions are pushed back into the call; this is 1378403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // type safe since unordered compare builtins are declared as "_Bool 1379403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // foo(...)". 1380429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(0, OrigArg0.get()); 1381429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(1, OrigArg1.get()); 13821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1383429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent()) 1384cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 1385cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 13861b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // If the common type isn't a real floating type, then the arguments were 13871b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // invalid for this operation. 1388860a319e62b0e256817a458396d191aa91c0787aEli Friedman if (Res.isNull() || !Res->isRealFloatingType()) 1389429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return Diag(OrigArg0.get()->getLocStart(), 1390fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_invalid_ordered_compare) 1391429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << OrigArg0.get()->getType() << OrigArg1.get()->getType() 1392429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd()); 13931eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 13941b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner return false; 13951b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner} 13961b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner 1397e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 1398e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends. This is declared to take (...), so we have 13993b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point 14003b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value. 14013b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 14023b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() < NumArgs) 14039ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1404d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 14053b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() > NumArgs) 14063b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer return Diag(TheCall->getArg(NumArgs)->getLocStart(), 14079ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_too_many_args) 1408ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 14093b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 14109ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman (*(TheCall->arg_end()-1))->getLocEnd()); 14119ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 14123b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer Expr *OrigArg = TheCall->getArg(NumArgs-1); 14131eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 14149ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (OrigArg->isTypeDependent()) 14159ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 14169ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 141781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // This operation requires a non-_Complex floating-point number. 14189ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (!OrigArg->getType()->isRealFloatingType()) 14191eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg->getLocStart(), 14209ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_invalid_unary_fp) 14219ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman << OrigArg->getType() << OrigArg->getSourceRange(); 14221eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 142381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // If this is an implicit conversion from float -> double, remove it. 142481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 142581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Expr *CastArg = Cast->getSubExpr(); 142681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 142781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 142881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner "promotion from float to double is the only expected cast here"); 142981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Cast->setSubExpr(0); 143081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner TheCall->setArg(NumArgs-1, CastArg); 143181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 143281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 143381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner 14349ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 14359ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman} 14369ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 1437d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 1438d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything. 143960d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 144037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() < 2) 14410eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocEnd(), 1442d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 144337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1444d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << TheCall->getSourceRange()); 1445d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 144637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Determine which of the following types of shufflevector we're checking: 144737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 1) unary, vector mask: (lhs, mask) 144837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 2) binary, vector mask: (lhs, rhs, mask) 144937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 145037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType resType = TheCall->getArg(0)->getType(); 145137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numElements = 0; 145237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 1453cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (!TheCall->getArg(0)->isTypeDependent() && 1454cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor !TheCall->getArg(1)->isTypeDependent()) { 145537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType LHSType = TheCall->getArg(0)->getType(); 145637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType RHSType = TheCall->getArg(1)->getType(); 145737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 145837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!LHSType->isVectorType() || !RHSType->isVectorType()) { 1459cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) 14601eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1461cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1462cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 1463cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 146437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 146537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numElements = LHSType->getAs<VectorType>()->getNumElements(); 146637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numResElements = TheCall->getNumArgs() - 2; 146737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 146837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Check to see if we have a call with 2 vector arguments, the unary shuffle 146937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // with mask. If so, verify that RHS is an integer vector type with the 147037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // same number of elts as lhs. 147137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() == 2) { 1472f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (!RHSType->hasIntegerRepresentation() || 147337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman RHSType->getAs<VectorType>()->getNumElements() != numElements) 147437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 147537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << SourceRange(TheCall->getArg(1)->getLocStart(), 147637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman TheCall->getArg(1)->getLocEnd()); 147737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numResElements = numElements; 147837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } 147937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 1480cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 14811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1482cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1483cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 148437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } else if (numElements != numResElements) { 148537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 1486788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner resType = Context.getVectorType(eltType, numResElements, 1487e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson VectorType::GenericVector); 1488cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 1489d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1490d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1491d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 1492cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 1493cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(i)->isValueDependent()) 1494cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor continue; 1495cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 149637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman llvm::APSInt Result(32); 149737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 149837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman return ExprError(Diag(TheCall->getLocStart(), 149937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman diag::err_shufflevector_nonconstant_argument) 150037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << TheCall->getArg(i)->getSourceRange()); 15010eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 1502d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 15030eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocStart(), 1504fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_shufflevector_argument_too_large) 15050eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl << TheCall->getArg(i)->getSourceRange()); 1506d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1507d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 15085f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<Expr*, 32> exprs; 1509d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1510d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 1511d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman exprs.push_back(TheCall->getArg(i)); 1512d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman TheCall->setArg(i, 0); 1513d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1514d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 15153b6bef9a213249c6ab6d67c07b1ac6380961be3eBenjamin Kramer return Owned(new (Context) ShuffleVectorExpr(Context, exprs, resType, 15168189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getCallee()->getLocStart(), 15178189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getRParenLoc())); 1518d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman} 151930ce344307f8a8b00054021307015571f83c7364Chris Lattner 15204493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 15214493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two 15224493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args. 15234493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 1524fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner unsigned NumArgs = TheCall->getNumArgs(); 15254493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1526fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (NumArgs > 3) 1527ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher return Diag(TheCall->getLocEnd(), 1528ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher diag::err_typecheck_call_too_many_args_at_most) 1529ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 3 << NumArgs 1530ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << TheCall->getSourceRange(); 15314493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 15324493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // Argument 0 is checked for us and the remaining arguments must be 15334493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // constant integers. 1534fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner for (unsigned i = 1; i != NumArgs; ++i) { 15354493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar Expr *Arg = TheCall->getArg(i); 1536592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1537592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 1538592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (Arg->isTypeDependent() || Arg->isValueDependent()) 1539592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor continue; 1540592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 15419aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman llvm::APSInt Result; 1542691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, i, Result)) 1543691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 15441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 15454493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // FIXME: gcc issues a warning and rewrites these to 0. These 15464493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // seems especially odd for the third argument since the default 15474493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // is 3. 1548fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (i == 1) { 15499aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 1) 1550fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 155121fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "1" << Arg->getSourceRange(); 15524493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } else { 15539aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 3) 1554fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 155521fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "3" << Arg->getSourceRange(); 15564493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 15574493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 15584493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1559fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return false; 15604493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar} 15614493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1562691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 1563691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression. 1564691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 1565691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt &Result) { 1566691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(ArgNum); 1567691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 1568691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 1569691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1570691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 1571691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1572691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (!Arg->isIntegerConstantExpr(Result, Context)) 1573691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 15745e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher << FDecl->getDeclName() << Arg->getSourceRange(); 1575691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 157621fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner return false; 157721fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner} 157821fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner 1579d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 1580d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined 1581d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3). 1582fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner// For compatibility check 0-3, llvm only handles 0 and 2. 1583d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 1584691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1585592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1586592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor // We can't check the value of a dependent argument. 1587592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor if (TheCall->getArg(1)->isTypeDependent() || 1588592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor TheCall->getArg(1)->isValueDependent()) 1589592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor return false; 1590592a4230c6e91fead00d605f6155080544cdf8c9Douglas Gregor 1591691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // Check constant-ness first. 1592691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1593691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1594d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1595691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(1); 1596d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 1597fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 1598fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1599d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar } 1600d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1601d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar return false; 1602d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar} 1603d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1604586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 1605d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1. 1606d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 1607d875fed28578835de89cd407e9db4be788596d7cEli Friedman Expr *Arg = TheCall->getArg(1); 1608691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1609cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 1610691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // TODO: This is less than ideal. Overload this to take a value. 1611691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1612691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1613691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1614691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Result != 1) 1615d875fed28578835de89cd407e9db4be788596d7cEli Friedman return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 1616d875fed28578835de89cd407e9db4be788596d7cEli Friedman << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1617d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1618d875fed28578835de89cd407e9db4be788596d7cEli Friedman return false; 1619d875fed28578835de89cd407e9db4be788596d7cEli Friedman} 1620d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1621831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determine if an expression is a string literal or constant string. 1622831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// If this function returns false on the arguments to a function expecting a 1623831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// format string, we will usually need to emit a warning. 1624831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// True string literals are then checked by CheckFormatString. 1625831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithSema::StringLiteralCheckType 1626831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithSema::checkFormatStringExpr(const Expr *E, Expr **Args, 1627831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned NumArgs, bool HasVAListArg, 1628831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned format_idx, unsigned firstDataArg, 1629ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose FormatStringType Type, VariadicCallType CallType, 1630ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose bool inFunctionCall) { 16314fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain: 1632cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 1633831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1634d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 163534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas E = E->IgnoreParenCasts(); 1636f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 1637a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie if (E->isNullPointerConstant(Context, Expr::NPC_ValueDependentIsNotNull)) 1638a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // Technically -Wformat-nonliteral does not warn about this case. 1639a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // The behavior of printf and friends in this case is implementation 1640a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // dependent. Ideally if the format string cannot be null then 1641a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // it should have a 'nonnull' attribute in the function prototype. 1642831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_CheckedLiteral; 1643a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie 1644d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek switch (E->getStmtClass()) { 164556ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::BinaryConditionalOperatorClass: 1646d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ConditionalOperatorClass: { 1647831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // The expression is a literal if both sub-expressions were, and it was 1648831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // completely checked only if both sub-expressions were checked. 1649831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const AbstractConditionalOperator *C = 1650831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith cast<AbstractConditionalOperator>(E); 1651831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType Left = 1652831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith checkFormatStringExpr(C->getTrueExpr(), Args, NumArgs, 1653831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1654ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 1655831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (Left == SLCT_NotALiteral) 1656831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1657831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType Right = 1658831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith checkFormatStringExpr(C->getFalseExpr(), Args, NumArgs, 1659831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1660ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 1661831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Left < Right ? Left : Right; 1662d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1663d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1664d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ImplicitCastExprClass: { 16654fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ImplicitCastExpr>(E)->getSubExpr(); 16664fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 1667d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1668d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 166956ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::OpaqueValueExprClass: 167056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) { 167156ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall E = src; 167256ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall goto tryAgain; 167356ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall } 1674831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 167556ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall 1676b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek case Stmt::PredefinedExprClass: 1677b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // While __func__, etc., are technically not string literals, they 1678b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // cannot contain format specifiers and thus are not a security 1679b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // liability. 1680831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_UncheckedLiteral; 1681b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek 1682082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::DeclRefExprClass: { 1683082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const DeclRefExpr *DR = cast<DeclRefExpr>(E); 16841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1685082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // As an exception, do not flag errors for variables binding to 1686082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // const string literals. 1687082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 1688082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool isConstant = false; 1689082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek QualType T = DR->getType(); 1690082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek 1691082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ArrayType *AT = Context.getAsArrayType(T)) { 1692082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek isConstant = AT->getElementType().isConstant(Context); 1693ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (const PointerType *PT = T->getAs<PointerType>()) { 16941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump isConstant = T.isConstant(Context) && 1695082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek PT->getPointeeType().isConstant(Context); 1696e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas } else if (T->isObjCObjectPointerType()) { 1697e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas // In ObjC, there is usually no "const ObjectPointer" type, 1698e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas // so don't check if the pointee type is constant. 1699e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas isConstant = T.isConstant(Context); 1700082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 17011eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1702082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (isConstant) { 1703e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (const Expr *Init = VD->getAnyInitializer()) { 1704e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay // Look through initializers like const char c[] = { "foo" } 1705e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (const InitListExpr *InitList = dyn_cast<InitListExpr>(Init)) { 1706e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay if (InitList->isStringLiteralInit()) 1707e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay Init = InitList->getInit(0)->IgnoreParenImpCasts(); 1708e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay } 1709831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return checkFormatStringExpr(Init, Args, NumArgs, 1710831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, 1711ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, CallType, 1712831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith /*inFunctionCall*/false); 1713e2c60667d1bc29b7e148f9c9828dcbdbfc5b82b0Matt Beaumont-Gay } 1714082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 17151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1716d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // For vprintf* functions (i.e., HasVAListArg==true), we add a 1717d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // special check to see if the format string is a function parameter 1718d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // of the function calling the printf function. If the function 1719d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // has an attribute indicating it is a printf-like function, then we 1720d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // should suppress warnings concerning non-literals being used in a call 1721d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // to a vprintf function. For example: 1722d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1723d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // void 1724d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 1725d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_list ap; 1726d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_start(ap, fmt); 1727d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 1728d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // ... 1729d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1730f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (HasVAListArg) { 1731f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(VD)) { 1732f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const NamedDecl *ND = dyn_cast<NamedDecl>(PV->getDeclContext())) { 1733f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas int PVIndex = PV->getFunctionScopeIndex() + 1; 1734f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas for (specific_attr_iterator<FormatAttr> 1735f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas i = ND->specific_attr_begin<FormatAttr>(), 1736f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas e = ND->specific_attr_end<FormatAttr>(); i != e ; ++i) { 1737f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas FormatAttr *PVFormat = *i; 1738f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // adjust for implicit parameter 1739f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 1740f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (MD->isInstance()) 1741f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas ++PVIndex; 1742f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // We also check if the formats are compatible. 1743f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas // We can't pass a 'scanf' string to a 'printf' function. 1744f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas if (PVIndex == PVFormat->getFormatIdx() && 1745f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas Type == GetFormatStringType(PVFormat)) 1746831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_UncheckedLiteral; 1747f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1748f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1749f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1750f57c413e444b441fa75ae8911d183c19b53bdd56Jean-Daniel Dupas } 1751082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 17521eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1753831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1754082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 1755d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 175652aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas case Stmt::CallExprClass: 175752aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas case Stmt::CXXMemberCallExprClass: { 17588f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const CallExpr *CE = cast<CallExpr>(E); 175952aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const NamedDecl *ND = dyn_cast_or_null<NamedDecl>(CE->getCalleeDecl())) { 176052aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) { 176152aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas unsigned ArgIndex = FA->getFormatIdx(); 176252aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 176352aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (MD->isInstance()) 176452aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas --ArgIndex; 176552aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas const Expr *Arg = CE->getArg(ArgIndex - 1); 176652aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas 1767831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return checkFormatStringExpr(Arg, Args, NumArgs, 1768831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, firstDataArg, 1769ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Type, CallType, inFunctionCall); 177050687314f87b67073c202fe46d84d12fb55e25cfJordan Rose } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(ND)) { 177150687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned BuiltinID = FD->getBuiltinID(); 177250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (BuiltinID == Builtin::BI__builtin___CFStringMakeConstantString || 177350687314f87b67073c202fe46d84d12fb55e25cfJordan Rose BuiltinID == Builtin::BI__builtin___NSStringMakeConstantString) { 177450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose const Expr *Arg = CE->getArg(0); 1775831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return checkFormatStringExpr(Arg, Args, NumArgs, 1776831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith HasVAListArg, format_idx, 1777ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, CallType, 1778ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall); 177950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose } 17808f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 17818f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 17821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1783831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 17848f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 1785082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::ObjCStringLiteralClass: 1786082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::StringLiteralClass: { 1787082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const StringLiteral *StrE = NULL; 17881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1789082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 1790d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek StrE = ObjCFExpr->getString(); 1791d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek else 1792082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek StrE = cast<StringLiteral>(E); 17931eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1794d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek if (StrE) { 179529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas CheckFormatString(StrE, E, Args, NumArgs, HasVAListArg, format_idx, 1796ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose firstDataArg, Type, inFunctionCall, CallType); 1797831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_CheckedLiteral; 1798d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 17991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1800831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1801d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 18021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1803082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek default: 1804831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return SLCT_NotALiteral; 1805d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1806d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1807d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1808e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid 18091eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull, 1810909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr * const *ExprArgs, 1811909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky SourceLocation CallSiteLoc) { 1812cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt for (NonNullAttr::args_iterator i = NonNull->args_begin(), 1813cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt e = NonNull->args_end(); 1814e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian i != e; ++i) { 1815909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr *ArgExpr = ExprArgs[*i]; 18164e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (ArgExpr->isNullPointerConstant(Context, 1817ce94049b69f75b44c18584fe79cd238978b6b0d5Douglas Gregor Expr::NPC_ValueDependentIsNotNull)) 1818909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange(); 1819e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian } 1820e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian} 1821d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 182234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel DupasSema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) { 182334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas return llvm::StringSwitch<FormatStringType>(Format->getType()) 182434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("scanf", FST_Scanf) 182534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("printf", "printf0", FST_Printf) 182634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("NSString", "CFString", FST_NSString) 182734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("strftime", FST_Strftime) 182834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("strfmon", FST_Strfmon) 182934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf) 183034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Default(FST_Unknown); 183134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas} 183234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas 1833ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose/// CheckFormatArguments - Check calls to printf and scanf (and similar 1834826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings. 1835831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith/// Returns true if a format string has been fully checked. 1836831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFormatArguments(const FormatAttr *Format, Expr **Args, 183729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas unsigned NumArgs, bool IsCXXMember, 1838ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose VariadicCallType CallType, 183929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas SourceLocation Loc, SourceRange Range) { 1840831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FormatStringInfo FSI; 1841831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (getFormatStringInfo(Format, IsCXXMember, &FSI)) 1842831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return CheckFormatArguments(Args, NumArgs, FSI.HasVAListArg, FSI.FormatIdx, 1843831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith FSI.FirstDataArg, GetFormatStringType(Format), 1844ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose CallType, Loc, Range); 1845831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 184629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 18474a2614e94672c47395abcde60518776fbebec589Sebastian Redl 1848831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool Sema::CheckFormatArguments(Expr **Args, unsigned NumArgs, 184934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas bool HasVAListArg, unsigned format_idx, 185034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg, FormatStringType Type, 1851ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose VariadicCallType CallType, 185234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas SourceLocation Loc, SourceRange Range) { 1853826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // CHECK: printf/scanf-like function is called with no format string. 185429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas if (format_idx >= NumArgs) { 185529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Loc, diag::warn_missing_format_string) << Range; 1856831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 185771895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek } 18581eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 185929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts(); 18601eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 186159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner // CHECK: format string is not a string literal. 18621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // 186371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // Dynamically generated format strings are difficult to 186471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // automatically vet at compile time. Requiring that format strings 186571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // are string literals: (1) permits the checking of format strings by 186671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // the compiler and thereby (2) can practically remove the source of 186771895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // many format string exploits. 18687ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek 18691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // Format string can be either ObjC string (e.g. @"%d") or 18707ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // C string (e.g. "%d") 18711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // ObjC string uses the same format specifiers as C string, so we can use 18727ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // the same format string checking logic for both ObjC and C strings. 1873831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith StringLiteralCheckType CT = 1874831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith checkFormatStringExpr(OrigFormatExpr, Args, NumArgs, HasVAListArg, 1875ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose format_idx, firstDataArg, Type, CallType); 1876831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (CT != SLCT_NotALiteral) 1877831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // Literal format string found, check done! 1878831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return CT == SLCT_CheckedLiteral; 18791cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner 18802837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas // Strftime is particular as it always uses a single 'time' argument, 18812837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas // so it is safe to pass a non-literal string. 18822837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas if (Type == FST_Strftime) 1883831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 18842837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas 1885ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // Do not emit diag when the string param is a macro expansion and the 1886ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // format is either NSString or CFString. This is a hack to prevent 1887ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // diag when using the NSLocalizedString and CFCopyLocalizedString macros 1888ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // which are usually used in place of NS and CF string literals. 1889dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas if (Type == FST_NSString && 1890dc1702001964c3314f7090e6a4af889b5771d884Jean-Daniel Dupas SourceMgr.isInSystemMacro(Args[format_idx]->getLocStart())) 1891831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 1892ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas 1893655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // If there are no arguments specified, warn with -Wformat-security, otherwise 1894655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // warn only with -Wformat-nonliteral. 189529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas if (NumArgs == format_idx+1) 189629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Args[format_idx]->getLocStart(), 1897826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral_noargs) 1898655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1899655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner else 190029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Args[format_idx]->getLocStart(), 1901826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral) 1902655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1903831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 1904d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1905d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1906e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace { 1907826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler { 1908826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1909e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Sema &S; 1910e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const StringLiteral *FExpr; 1911e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const Expr *OrigFormatExpr; 19126ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const unsigned FirstDataArg; 1913e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const unsigned NumDataArgs; 1914e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *Beg; // Start of format string. 19150d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const bool HasVAListArg; 191629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const Expr * const *Args; 191729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const unsigned NumArgs; 19180d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek unsigned FormatIdx; 19197f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek llvm::BitVector CoveredArgs; 1920efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool usesPositionalArgs; 1921efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool atFirstArg; 192255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool inFunctionCall; 1923ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType; 19244e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic: 1925826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 19266ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 192750687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, const char *beg, bool hasVAListArg, 192829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **args, unsigned numArgs, 1929ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 1930ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType callType) 1931e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 193250687314f87b67073c202fe46d84d12fb55e25cfJordan Rose FirstDataArg(firstDataArg), NumDataArgs(numDataArgs), 193350687314f87b67073c202fe46d84d12fb55e25cfJordan Rose Beg(beg), HasVAListArg(hasVAListArg), 193429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Args(args), NumArgs(numArgs), FormatIdx(formatIdx), 193555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu usesPositionalArgs(false), atFirstArg(true), 1936ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall(inFunctionCall), CallType(callType) { 19377f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.resize(numDataArgs); 19387f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.reset(); 19397f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 19404e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 194107d161f38e708a91486bf1c031d525faebbb249dTed Kremenek void DoneProcessing(); 19424e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1943826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIncompleteSpecifier(const char *startSpecifier, 1944826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 194576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 1946bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose void HandleInvalidLengthModifier( 1947bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::FormatSpecifier &FS, 1948bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::ConversionSpecifier &CS, 19498be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const char *startSpecifier, unsigned specifierLen, unsigned DiagID); 1950bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 195176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg void HandleNonStandardLengthModifier( 19528be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const analyze_format_string::FormatSpecifier &FS, 195376517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen); 195476517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 195576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg void HandleNonStandardConversionSpecifier( 195676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 195776517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen); 195876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 1959f85626453123f9691bcef13cff963f556e209c27Hans Wennborg virtual void HandlePosition(const char *startPos, unsigned posLen); 1960f85626453123f9691bcef13cff963f556e209c27Hans Wennborg 1961efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleInvalidPosition(const char *startSpecifier, 1962efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned specifierLen, 1963826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p); 1964efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1965efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 1966efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1967e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek void HandleNullChar(const char *nullCharacter); 19684e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 196955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 197055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu static void EmitFormatDiagnostic(Sema &S, bool inFunctionCall, 197155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 197255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 197355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation StringLoc, 197455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 1975ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose ArrayRef<FixItHint> Fixit = ArrayRef<FixItHint>()); 197655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 1977826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1978c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 1979c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1980c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1981c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, unsigned csLen); 198255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 198355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void HandlePositionalNonpositionalArgs(SourceLocation Loc, 198455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 198555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen); 1986c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1987f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek SourceRange getFormatStringRange(); 1988826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CharSourceRange getSpecifierRange(const char *startSpecifier, 1989826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1990e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek SourceLocation getLocationOfByte(const char *x); 19914e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 19920d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const Expr *getDataArg(unsigned i) const; 1993666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1994666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 1995666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1996666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, 1997666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek unsigned argIndex); 199855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 199955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 200055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc, 200155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 2002ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose ArrayRef<FixItHint> Fixit = ArrayRef<FixItHint>()); 200355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 200455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void CheckPositionalAndNonpositionalArgs( 200555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const analyze_format_string::FormatSpecifier *FS); 2006e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}; 2007e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2008e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2009826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() { 2010e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return OrigFormatExpr->getSourceRange(); 2011e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2012e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2013826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler:: 2014826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 201545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation Start = getLocationOfByte(startSpecifier); 201645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 201745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 201845f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care // Advance the end SourceLocation by one due to half-open ranges. 2019a64ccefdf0ea4e03ec88805d71b0af74950c7472Argyrios Kyrtzidis End = End.getLocWithOffset(1); 202045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 202145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care return CharSourceRange::getCharRange(Start, End); 2022f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek} 2023f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek 2024826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 20254e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 2026e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2027e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2028826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 2029826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen){ 203055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier), 203155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startSpecifier), 203255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 203355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 2034808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek} 2035808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek 2036bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rosevoid CheckFormatHandler::HandleInvalidLengthModifier( 2037bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::FormatSpecifier &FS, 2038bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const analyze_format_string::ConversionSpecifier &CS, 20398be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const char *startSpecifier, unsigned specifierLen, unsigned DiagID) { 2040bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose using namespace analyze_format_string; 2041bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2042bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose const LengthModifier &LM = FS.getLengthModifier(); 2043bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength()); 2044bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2045bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose // See if we know how to fix this length modifier. 2046bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose llvm::Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier(); 2047bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (FixedLM) { 20488be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(), 2049bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getLocationOfByte(LM.getStart()), 2050bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose /*IsStringLocation*/true, 2051bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 2052bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2053bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier) 2054bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose << FixedLM->toString() 2055bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose << FixItHint::CreateReplacement(LMRange, FixedLM->toString()); 2056bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2057bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose } else { 20588be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose FixItHint Hint; 20598be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose if (DiagID == diag::warn_format_nonsensical_length) 20608be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose Hint = FixItHint::CreateRemoval(LMRange); 20618be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 20628be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(), 2063bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getLocationOfByte(LM.getStart()), 2064bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose /*IsStringLocation*/true, 2065bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose getSpecifierRange(startSpecifier, specifierLen), 20668be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose Hint); 2067bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose } 2068bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose} 2069bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 207076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardLengthModifier( 20718be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const analyze_format_string::FormatSpecifier &FS, 207276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen) { 20738be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose using namespace analyze_format_string; 20748be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 20758be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose const LengthModifier &LM = FS.getLengthModifier(); 20768be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength()); 20778be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 20788be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose // See if we know how to fix this length modifier. 20798be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose llvm::Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier(); 20808be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose if (FixedLM) { 20818be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 20828be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << LM.toString() << 0, 20838be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getLocationOfByte(LM.getStart()), 20848be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose /*IsStringLocation*/true, 20858be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 20868be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 20878be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier) 20888be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << FixedLM->toString() 20898be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << FixItHint::CreateReplacement(LMRange, FixedLM->toString()); 20908be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose 20918be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose } else { 20928be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 20938be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose << LM.toString() << 0, 20948be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getLocationOfByte(LM.getStart()), 20958be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose /*IsStringLocation*/true, 20968be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 20978be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose } 209876517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg} 209976517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 210076517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborgvoid CheckFormatHandler::HandleNonStandardConversionSpecifier( 210176517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const analyze_format_string::ConversionSpecifier &CS, 210276517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg const char *startSpecifier, unsigned specifierLen) { 2103670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose using namespace analyze_format_string; 2104670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose 2105670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose // See if we know how to fix this conversion specifier. 2106670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose llvm::Optional<ConversionSpecifier> FixedCS = CS.getStandardSpecifier(); 2107670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose if (FixedCS) { 2108670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 2109670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << CS.toString() << /*conversion specifier*/1, 2110670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getLocationOfByte(CS.getStart()), 2111670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose /*IsStringLocation*/true, 2112670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 2113670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose 2114670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose CharSourceRange CSRange = getSpecifierRange(CS.getStart(), CS.getLength()); 2115670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose S.Diag(getLocationOfByte(CS.getStart()), diag::note_format_fix_specifier) 2116670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << FixedCS->toString() 2117670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << FixItHint::CreateReplacement(CSRange, FixedCS->toString()); 2118670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose } else { 2119670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard) 2120670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose << CS.toString() << /*conversion specifier*/1, 2121670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getLocationOfByte(CS.getStart()), 2122670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose /*IsStringLocation*/true, 2123670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose getSpecifierRange(startSpecifier, specifierLen)); 2124670941c28c0683ecc251dafdf093a71629625dc9Jordan Rose } 212576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg} 212676517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 2127f85626453123f9691bcef13cff963f556e209c27Hans Wennborgvoid CheckFormatHandler::HandlePosition(const char *startPos, 2128f85626453123f9691bcef13cff963f556e209c27Hans Wennborg unsigned posLen) { 2129f85626453123f9691bcef13cff963f556e209c27Hans Wennborg EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_positional_arg), 2130f85626453123f9691bcef13cff963f556e209c27Hans Wennborg getLocationOfByte(startPos), 2131f85626453123f9691bcef13cff963f556e209c27Hans Wennborg /*IsStringLocation*/true, 2132f85626453123f9691bcef13cff963f556e209c27Hans Wennborg getSpecifierRange(startPos, posLen)); 2133f85626453123f9691bcef13cff963f556e209c27Hans Wennborg} 2134f85626453123f9691bcef13cff963f556e209c27Hans Wennborg 2135efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid 2136826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 2137826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p) { 213855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier) 213955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (unsigned) p, 214055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), /*IsStringLocation*/true, 214155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 2142efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 2143efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2144826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos, 2145efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned posLen) { 214655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier), 214755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), 214855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 214955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 2150efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 2151efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 2152826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 215350687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (!isa<ObjCStringLiteral>(OrigFormatExpr)) { 21540c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek // The presence of a null character is likely an error. 215555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 215655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_format_string_contains_null_char), 215755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(nullCharacter), /*IsStringLocation*/true, 215855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getFormatStringRange()); 21590c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek } 2160826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2161826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 216248716663e421472cbd590af160a372bc490205e8Jordan Rose// Note that this may return NULL if there was an error parsing or building 216348716663e421472cbd590af160a372bc490205e8Jordan Rose// one of the argument expressions. 2164826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const { 216529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return Args[FirstDataArg + i]; 2166826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 21674e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2168826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() { 2169826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Does the number of data arguments exceed the number of 2170826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // format conversions in the format string? 2171826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!HasVAListArg) { 2172826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Find any arguments that weren't covered. 2173826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.flip(); 2174826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek signed notCoveredArg = CoveredArgs.find_first(); 2175826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (notCoveredArg >= 0) { 2176826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek assert((unsigned)notCoveredArg < NumDataArgs); 217748716663e421472cbd590af160a372bc490205e8Jordan Rose if (const Expr *E = getDataArg((unsigned) notCoveredArg)) { 217848716663e421472cbd590af160a372bc490205e8Jordan Rose SourceLocation Loc = E->getLocStart(); 217948716663e421472cbd590af160a372bc490205e8Jordan Rose if (!S.getSourceManager().isInSystemMacro(Loc)) { 218048716663e421472cbd590af160a372bc490205e8Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_printf_data_arg_not_used), 218148716663e421472cbd590af160a372bc490205e8Jordan Rose Loc, /*IsStringLocation*/false, 218248716663e421472cbd590af160a372bc490205e8Jordan Rose getFormatStringRange()); 218348716663e421472cbd590af160a372bc490205e8Jordan Rose } 2184c03f2df2a2b097bf2686bf32411d5022323988b2Bob Wilson } 2185826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2186826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2187826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2188826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2189c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool 2190c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 2191c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek SourceLocation Loc, 2192c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 2193c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 2194c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, 2195c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned csLen) { 2196c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2197c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool keepGoing = true; 2198c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek if (argIndex < NumDataArgs) { 2199c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // Consider the argument coverered, even though the specifier doesn't 2200c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // make sense. 2201c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CoveredArgs.set(argIndex); 2202c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 2203c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek else { 2204c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // If argIndex exceeds the number of data arguments we 2205c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // don't issue a warning because that is just a cascade of warnings (and 2206c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // they may have intended '%%' anyway). We don't want to continue processing 2207c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // the format string after this point, however, as we will like just get 2208c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // gibberish when trying to match arguments. 2209c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek keepGoing = false; 2210c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 2211c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 221255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_conversion) 221355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << StringRef(csStart, csLen), 221455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*IsStringLocation*/true, 221555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpec, specifierLen)); 2216c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2217c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return keepGoing; 2218c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 2219c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 222055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid 222155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard TrieuCheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc, 222255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 222355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen) { 222455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 222555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_format_mix_positional_nonpositional_args), 222655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen)); 222755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 222855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2229666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool 2230666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs( 2231666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::FormatSpecifier &FS, 2232666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 2233666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 2234666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 2235666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (argIndex >= NumDataArgs) { 223655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag = FS.usesPositionalArg() 223755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args) 223855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (argIndex+1) << NumDataArgs) 223955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : S.PDiag(diag::warn_printf_insufficient_data_args); 224055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 224155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true, 224255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 2243666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return false; 2244666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 2245666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return true; 2246666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek} 2247666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 224855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 224955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag, 225055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 225155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 225255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 2253ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose ArrayRef<FixItHint> FixIt) { 225429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag, 225555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, IsStringLocation, StringRange, FixIt); 225655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 225755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 225855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \brief If the format string is not within the funcion call, emit a note 225955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// so that the function call and string are in diagnostic messages. 226055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 226170517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param InFunctionCall if true, the format string is within the function 226255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// call and only one diagnostic message will be produced. Otherwise, an 226355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// extra note will be emitted pointing to location of the format string. 226455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 226555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param ArgumentExpr the expression that is passed as the format string 226655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// argument in the function call. Used for getting locations when two 226755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostics are emitted. 226855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 226955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param PDiag the callee should already have provided any strings for the 227055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostic message. This function only adds locations and fixits 227155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// to diagnostics. 227255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 227355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param Loc primary location for diagnostic. If two diagnostics are 227455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// required, one will be at Loc and a new SourceLocation will be created for 227555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// the other one. 227655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 227755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param IsStringLocation if true, Loc points to the format string should be 227855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// used for the note. Otherwise, Loc points to the argument list and will 227955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// be used with PDiag. 228055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 228155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param StringRange some or all of the string to highlight. This is 228255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// templated so it can accept either a CharSourceRange or a SourceRange. 228355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 228470517ca5c07c4b41ff8662b94ee22047b0299f8cDmitri Gribenko/// \param FixIt optional fix it hint for the format string. 228555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 228655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(Sema &S, bool InFunctionCall, 228755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 228855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 228955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 229055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 229155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 2292ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose ArrayRef<FixItHint> FixIt) { 2293ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (InFunctionCall) { 2294ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Sema::SemaDiagnosticBuilder &D = S.Diag(Loc, PDiag); 2295ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose D << StringRange; 2296ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end(); 2297ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose I != E; ++I) { 2298ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose D << *I; 2299ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2300ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else { 230155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag) 230255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ArgumentExpr->getSourceRange(); 2303ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2304ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Sema::SemaDiagnosticBuilder &Note = 2305ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose S.Diag(IsStringLocation ? Loc : StringRange.getBegin(), 2306ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose diag::note_format_string_defined); 2307ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2308ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Note << StringRange; 2309ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose for (ArrayRef<FixItHint>::iterator I = FixIt.begin(), E = FixIt.end(); 2310ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose I != E; ++I) { 2311ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Note << *I; 2312ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 231355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu } 231455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 231555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 2316826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===// 2317826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2318826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 2319826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler { 232050687314f87b67073c202fe46d84d12fb55e25cfJordan Rose bool ObjCContext; 2321826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 2322826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 2323826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 232450687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, bool isObjC, 2325826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 232629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **Args, unsigned NumArgs, 2327ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 2328ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType) 2329826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 233050687314f87b67073c202fe46d84d12fb55e25cfJordan Rose numDataArgs, beg, hasVAListArg, Args, NumArgs, 2331ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose formatIdx, inFunctionCall, CallType), ObjCContext(isObjC) 2332ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose {} 2333ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose 2334826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2335826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleInvalidPrintfConversionSpecifier( 2336826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2337826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2338826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2339826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2340826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 2341826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2342826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2343831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith bool checkFormatExpr(const analyze_printf::PrintfSpecifier &FS, 2344831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const char *StartSpecifier, 2345831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned SpecifierLen, 2346831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E); 2347831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2348826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 2349826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2350826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 2351826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalAmount &Amt, 2352826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned type, 2353826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2354826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 2355826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 2356826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2357826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 2358826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &ignoredFlag, 2359826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 2360826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 2361f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg bool checkForCStrMembers(const analyze_printf::ArgType &AT, 2362831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E, const CharSourceRange &CSR); 2363831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2364826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 2365826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2366826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2367826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 2368826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2369826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2370826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 23716ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 2372c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 2373826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2374c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 2375c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 2376c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 2377c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 237826ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek} 237926ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek 2380826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount( 2381826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_format_string::OptionalAmount &Amt, 2382826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned k, const char *startSpecifier, 2383826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 23840d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 23850d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (Amt.hasDataArgument()) { 23860d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (!HasVAListArg) { 23877f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = Amt.getArgIndex(); 23887f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (argIndex >= NumDataArgs) { 238955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg) 239055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << k, 239155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 239255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 239355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 23940d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 23950d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 23960d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 23970d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 23984e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 23990d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Type check the data argument. It should be an 'int'. 240031f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // Although not in conformance with C99, we also allow the argument to be 240131f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // an 'unsigned int' as that is a reasonably safe case. GCC also 240231f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // doesn't emit a warning for that case. 24037f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.set(argIndex); 24047f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek const Expr *Arg = getDataArg(argIndex); 240548716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Arg) 240648716663e421472cbd590af160a372bc490205e8Jordan Rose return false; 240748716663e421472cbd590af160a372bc490205e8Jordan Rose 24080d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek QualType T = Arg->getType(); 24094e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2410f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT = Amt.getArgType(S.Context); 2411f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg assert(AT.isValid()); 24124e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2413f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg if (!AT.matchesType(S.Context, T)) { 241455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type) 2415f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg << k << AT.getRepresentativeTypeName(S.Context) 241655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << T << Arg->getSourceRange(), 241755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 241855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 241955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 24200d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 24210d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 24220d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 24230d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 24240d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 24250d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 24260d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return true; 24270d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek} 24280d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 2429e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount( 2430826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2431e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalAmount &Amt, 2432e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned type, 2433e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2434e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 24356ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 24366ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 2437e4ee9663168dfb2b4122c768091e30217328c9faTom Care 243855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint fixit = 243955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant 244055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 244155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getConstantLength())) 244255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : FixItHint(); 244355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 244455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount) 244555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << type << CS.toString(), 244655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 244755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 244855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 244955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu fixit); 2450e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2451e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2452826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 2453e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 2454e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2455e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 2456e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about pointless flag with a fixit removal. 24576ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 24586ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 245955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag) 246055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << flag.toString() << CS.toString(), 246155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(flag.getPosition()), 246255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 246355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 246455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 246555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(flag.getPosition(), 1))); 2466e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2467e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2468e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag( 2469826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2470e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &ignoredFlag, 2471e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 2472e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2473e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 2474e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about ignored flag with a fixit removal. 247555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag) 247655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ignoredFlag.toString() << flag.toString(), 247755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(ignoredFlag.getPosition()), 247855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 247955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 248055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 248155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(ignoredFlag.getPosition(), 1))); 2482e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2483e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2484831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Determines if the specified is a C++ class or struct containing 2485831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// a member with the specified name and kind (e.g. a CXXMethodDecl named 2486831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// "c_str()"). 2487831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithtemplate<typename MemberKind> 2488831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithstatic llvm::SmallPtrSet<MemberKind*, 1> 2489831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCXXRecordMembersNamed(StringRef Name, Sema &S, QualType Ty) { 2490831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const RecordType *RT = Ty->getAs<RecordType>(); 2491831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith llvm::SmallPtrSet<MemberKind*, 1> Results; 2492831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2493831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!RT) 2494831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2495831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl()); 2496831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (!RD) 2497831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2498831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2499831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith LookupResult R(S, &S.PP.getIdentifierTable().get(Name), SourceLocation(), 2500831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Sema::LookupMemberName); 2501831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2502831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // We just need to include all members of the right kind turned up by the 2503831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // filter, at this point. 2504831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (S.LookupQualifiedName(R, RT->getDecl())) 2505831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith for (LookupResult::iterator I = R.begin(), E = R.end(); I != E; ++I) { 2506831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith NamedDecl *decl = (*I)->getUnderlyingDecl(); 2507831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (MemberKind *FK = dyn_cast<MemberKind>(decl)) 2508831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith Results.insert(FK); 2509831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2510831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return Results; 2511831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2512831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2513831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Check if a (w)string was passed when a (w)char* was needed, and offer a 2514f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg// better diagnostic if so. AT is assumed to be valid. 2515831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith// Returns true when a c_str() conversion method is found. 2516831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool CheckPrintfHandler::checkForCStrMembers( 2517f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT, const Expr *E, 2518831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CharSourceRange &CSR) { 2519831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith typedef llvm::SmallPtrSet<CXXMethodDecl*, 1> MethodSet; 2520831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2521831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith MethodSet Results = 2522831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith CXXRecordMembersNamed<CXXMethodDecl>("c_str", S, E->getType()); 2523831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2524831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith for (MethodSet::iterator MI = Results.begin(), ME = Results.end(); 2525831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith MI != ME; ++MI) { 2526831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const CXXMethodDecl *Method = *MI; 2527831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith if (Method->getNumParams() == 0 && 2528f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg AT.matchesType(S.Context, Method->getResultType())) { 2529831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith // FIXME: Suggest parens if the expression needs them. 2530831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith SourceLocation EndLoc = 2531831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()); 2532831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith S.Diag(E->getLocStart(), diag::note_printf_c_str) 2533831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << "c_str()" 2534831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << FixItHint::CreateInsertion(EndLoc, ".c_str()"); 2535831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return true; 2536831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2537831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith } 2538831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2539831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith return false; 2540831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2541831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2542e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool 2543826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 25445c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek &FS, 2545e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *startSpecifier, 2546e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned specifierLen) { 2547e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 25486ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek using namespace analyze_format_string; 2549efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek using namespace analyze_printf; 25506ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 2551e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2552baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 2553baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 2554baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 2555baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 2556baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2557baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 255855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 255955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 2560baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 2561baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2562efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek } 2563efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 25640d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // First check if the field width, precision, and conversion specifier 25650d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // have matching data arguments. 2566efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 2567efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 25680d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 25690d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 25704e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2571efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 2572efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 25730d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 25740d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 25750d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 2576f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek if (!CS.consumesDataArgument()) { 2577f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // FIXME: Technically specifying a precision or field width here 2578f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // makes no sense. Worth issuing a warning at some point. 25790e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek return true; 2580f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek } 25814e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 25827f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Consume the argument. 25837f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = FS.getArgIndex(); 2584e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek if (argIndex < NumDataArgs) { 2585e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // The check to see if the argIndex is valid will come later. 2586e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // We set the bit here because we may exit early from this 2587e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // function if we encounter some other error. 2588e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek CoveredArgs.set(argIndex); 2589e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek } 25907f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek 25917f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Check for using an Objective-C specific conversion specifier 25927f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // in a non-ObjC literal. 259350687314f87b67073c202fe46d84d12fb55e25cfJordan Rose if (!ObjCContext && CS.isObjCArg()) { 2594826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 2595826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek specifierLen); 25967f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 25974e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2598e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of field width 2599e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidFieldWidth()) { 260045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 2601e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2602e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2603e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2604e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of precision 2605e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPrecision()) { 2606e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 2607e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2608e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2609e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2610e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check each flag does not conflict with any other component. 261165197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek if (!FS.hasValidThousandsGroupingPrefix()) 261265197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen); 2613e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeadingZeros()) 2614e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 2615e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPlusPrefix()) 2616e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 261745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (!FS.hasValidSpacePrefix()) 261845f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 2619e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidAlternativeForm()) 2620e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 2621e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeftJustified()) 2622e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 2623e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2624e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check that flags are not ignored by another flag 262545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 262645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 262745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care startSpecifier, specifierLen); 2628e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 2629e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 2630e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2631e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2632e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check the length modifier is valid with the given conversion specifier. 2633bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo())) 26348be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 26358be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_nonsensical_length); 2636bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthModifier()) 26378be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen); 2638bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthConversionCombination()) 26398be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 26408be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_non_standard_conversion_spec); 2641e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2642bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 2643bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 2644bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2645da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek // The remaining checks depend on the data arguments. 2646da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek if (HasVAListArg) 2647da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return true; 26484e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2649666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 2650da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return false; 26514e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 265248716663e421472cbd590af160a372bc490205e8Jordan Rose const Expr *Arg = getDataArg(argIndex); 265348716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Arg) 265448716663e421472cbd590af160a372bc490205e8Jordan Rose return true; 265548716663e421472cbd590af160a372bc490205e8Jordan Rose 265648716663e421472cbd590af160a372bc490205e8Jordan Rose return checkFormatExpr(FS, startSpecifier, specifierLen, Arg); 2657831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith} 2658831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith 2659ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rosestatic bool requiresParensToAddCast(const Expr *E) { 2660ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // FIXME: We should have a general way to reason about operator 2661ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // precedence and whether parens are actually needed here. 2662ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Take care of a few common cases where they aren't. 2663ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const Expr *Inside = E->IgnoreImpCasts(); 2664ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (const PseudoObjectExpr *POE = dyn_cast<PseudoObjectExpr>(Inside)) 2665ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Inside = POE->getSyntacticForm()->IgnoreImpCasts(); 2666ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2667ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose switch (Inside->getStmtClass()) { 2668ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ArraySubscriptExprClass: 2669ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::CallExprClass: 2670ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::DeclRefExprClass: 2671ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::MemberExprClass: 2672ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCIvarRefExprClass: 2673ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCMessageExprClass: 2674ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ObjCPropertyRefExprClass: 2675ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::ParenExprClass: 2676ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose case Stmt::UnaryOperatorClass: 2677ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose return false; 2678ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose default: 2679ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose return true; 2680ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2681ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose} 2682ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2683831421f24057b93ea28bc92d8bd6290631a43cafRichard Smithbool 2684831421f24057b93ea28bc92d8bd6290631a43cafRichard SmithCheckPrintfHandler::checkFormatExpr(const analyze_printf::PrintfSpecifier &FS, 2685831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const char *StartSpecifier, 2686831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith unsigned SpecifierLen, 2687831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith const Expr *E) { 2688831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith using namespace analyze_format_string; 2689831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith using namespace analyze_printf; 269096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Now type check the data expression that matches the 269196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // format specifier. 2692f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg const analyze_printf::ArgType &AT = FS.getArgType(S.Context, 2693f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg ObjCContext); 2694614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (!AT.isValid()) 2695614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 2696ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2697ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose QualType IntendedTy = E->getType(); 2698ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (AT.matchesType(S.Context, IntendedTy)) 2699614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 2700614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 2701614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Look through argument promotions for our error message's reported type. 2702614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // This includes the integral and floating promotions, but excludes array 2703614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // and function pointer decay; seeing that an argument intended to be a 2704614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // string has type 'char [6]' is probably more confusing than 'char *'. 2705614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 2706614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (ICE->getCastKind() == CK_IntegralCast || 2707614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose ICE->getCastKind() == CK_FloatingCast) { 2708614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E = ICE->getSubExpr(); 2709ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose IntendedTy = E->getType(); 2710614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 2711614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Check if we didn't match because of an implicit cast from a 'char' 2712614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // or 'short' to an 'int'. This is done because printf is a varargs 2713614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // function. 2714614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (ICE->getType() == S.Context.IntTy || 2715614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose ICE->getType() == S.Context.UnsignedIntTy) { 2716614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // All further checking is done on the subexpression. 2717ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (AT.matchesType(S.Context, IntendedTy)) 2718614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose return true; 27194d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek } 2720ee0259d308e72141982a85b40863e760a8447edfJordan Rose } 2721614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } 2722614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 2723ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (S.Context.getTargetInfo().getTriple().isOSDarwin()) { 2724ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Special-case some of Darwin's platform-independence types. 2725ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (const TypedefType *UserTy = IntendedTy->getAs<TypedefType>()) { 2726ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose StringRef Name = UserTy->getDecl()->getName(); 2727ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose IntendedTy = llvm::StringSwitch<QualType>(Name) 2728ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("NSInteger", S.Context.LongTy) 2729ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("NSUInteger", S.Context.UnsignedLongTy) 2730ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("SInt32", S.Context.IntTy) 2731ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Case("UInt32", S.Context.UnsignedIntTy) 2732ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose .Default(IntendedTy); 2733ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2734ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2735ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2736614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // We may be able to offer a FixItHint if it is a supported type. 2737614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose PrintfSpecifier fixedFS = FS; 2738ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose bool success = fixedFS.fixType(IntendedTy, S.getLangOpts(), 2739614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose S.Context, ObjCContext); 274096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2741614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (success) { 2742614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Get the fix string from the fixed format specifier 2743614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose SmallString<16> buf; 2744614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose llvm::raw_svector_ostream os(buf); 2745614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose fixedFS.toString(os); 2746614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose 2747ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CharSourceRange SpecRange = getSpecifierRange(StartSpecifier, SpecifierLen); 2748ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2749ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (IntendedTy != E->getType()) { 2750ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // The canonical type for formatting this value is different from the 2751ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // actual type of the expression. (This occurs, for example, with Darwin's 2752ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // NSInteger on 32-bit platforms, where it is typedef'd as 'int', but 2753ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // should be printed as 'long' for 64-bit compatibility.) 2754ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Rather than emitting a normal format/argument mismatch, we want to 2755ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // add a cast to the recommended type (and correct the format string 2756ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // if necessary). 2757ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SmallString<16> CastBuf; 2758ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose llvm::raw_svector_ostream CastFix(CastBuf); 2759ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << "("; 2760ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose IntendedTy.print(CastFix, S.Context.getPrintingPolicy()); 2761ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << ")"; 2762ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2763ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SmallVector<FixItHint,4> Hints; 2764ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (!AT.matchesType(S.Context, IntendedTy)) 2765ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateReplacement(SpecRange, os.str())); 2766ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2767ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose if (const CStyleCastExpr *CCast = dyn_cast<CStyleCastExpr>(E)) { 2768ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // If there's already a cast present, just replace it. 2769ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SourceRange CastRange(CCast->getLParenLoc(), CCast->getRParenLoc()); 2770ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateReplacement(CastRange, CastFix.str())); 2771ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2772ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else if (!requiresParensToAddCast(E)) { 2773ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // If the expression has high enough precedence, 2774ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // just write the C-style cast. 2775ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(), 2776ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix.str())); 2777ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else { 2778ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Otherwise, add parens around the expression as well as the cast. 2779ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix << "("; 2780ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(), 2781ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose CastFix.str())); 2782ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2783ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SourceLocation After = S.PP.getLocForEndOfToken(E->getLocEnd()); 2784ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose Hints.push_back(FixItHint::CreateInsertion(After, ")")); 2785ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2786ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2787ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // We extract the name from the typedef because we don't want to show 2788ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // the underlying type in the diagnostic. 2789ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose const TypedefType *UserTy = cast<TypedefType>(E->getType()); 2790ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose StringRef Name = UserTy->getDecl()->getName(); 2791ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose 2792ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose // Finally, emit the diagnostic. 2793ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose EmitFormatDiagnostic(S.PDiag(diag::warn_format_argument_needs_cast) 2794ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose << Name << IntendedTy 2795ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose << E->getSourceRange(), 2796ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose E->getLocStart(), /*IsStringLocation=*/false, 2797ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SpecRange, Hints); 2798ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } else { 2799ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose EmitFormatDiagnostic( 2800ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 2801ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose << AT.getRepresentativeTypeName(S.Context) << IntendedTy 2802ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose << E->getSourceRange(), 2803ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose E->getLocStart(), 2804ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose /*IsStringLocation*/false, 2805ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose SpecRange, 2806ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose FixItHint::CreateReplacement(SpecRange, os.str())); 2807ec08735e1b6a51c11533311b774bf6336c0a5d63Jordan Rose } 2808614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } else { 2809614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose const CharSourceRange &CSR = getSpecifierRange(StartSpecifier, 2810614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose SpecifierLen); 2811614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // Since the warning for passing non-POD types to variadic functions 2812614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // was deferred until now, we emit a warning for non-POD 2813614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose // arguments here. 2814614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (S.isValidVarArgType(E->getType()) == Sema::VAK_Invalid) { 2815614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose unsigned DiagKind; 2816614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose if (E->getType()->isObjCObjectType()) 2817614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose DiagKind = diag::err_cannot_pass_objc_interface_to_vararg_format; 2818614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose else 2819614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose DiagKind = diag::warn_non_pod_vararg_with_format_string; 282096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2821614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose EmitFormatDiagnostic( 2822614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose S.PDiag(DiagKind) 2823614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << S.getLangOpts().CPlusPlus0x 2824614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << E->getType() 2825614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CallType 2826614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << AT.getRepresentativeTypeName(S.Context) 2827614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CSR 2828614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << E->getSourceRange(), 2829614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E->getLocStart(), /*IsStringLocation*/false, CSR); 283096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2831614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose checkForCStrMembers(AT, E, CSR); 2832614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose } else 283355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 283455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 2835f3749f4168c5cee59627a681ca4ca6e4116d0761Hans Wennborg << AT.getRepresentativeTypeName(S.Context) << E->getType() 2836614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose << CSR 2837831421f24057b93ea28bc92d8bd6290631a43cafRichard Smith << E->getSourceRange(), 2838614a8656279b6549750e83143635cec63ac0e8b7Jordan Rose E->getLocStart(), /*IsStringLocation*/false, CSR); 283996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 284096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2841e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return true; 2842e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2843e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2844826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===// 2845826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2846826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 2847826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler { 2848826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 2849826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 2850826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 285150687314f87b67073c202fe46d84d12fb55e25cfJordan Rose unsigned numDataArgs, const char *beg, bool hasVAListArg, 285229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **Args, unsigned NumArgs, 2853ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose unsigned formatIdx, bool inFunctionCall, 2854ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Sema::VariadicCallType CallType) 2855826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 285650687314f87b67073c202fe46d84d12fb55e25cfJordan Rose numDataArgs, beg, hasVAListArg, 2857ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose Args, NumArgs, formatIdx, inFunctionCall, CallType) 2858ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose {} 2859826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2860826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 2861826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2862826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2863c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2864c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidScanfConversionSpecifier( 2865c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2866c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 2867c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen); 2868b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 2869b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek void HandleIncompleteScanList(const char *start, const char *end); 2870826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 2871826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2872826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2873b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start, 2874b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek const char *end) { 287555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete), 287655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(end), /*IsStringLocation*/true, 287755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(start, end - start)); 2878b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek} 2879b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 2880c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 2881c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2882c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 2883c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen) { 2884c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 28856ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_scanf::ScanfConversionSpecifier &CS = 2886c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 2887c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2888c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 2889c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 2890c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 2891c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 2892c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 2893c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2894826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier( 2895826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2896826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2897826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 2898826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2899826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_scanf; 2900826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_format_string; 2901826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 29026ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 2903826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2904baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Handle case where '%' and '*' don't consume an argument. These shouldn't 2905baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // be used to decide if we are using positional arguments consistently. 2906baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 2907baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 2908baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 2909baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 2910baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2911baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 291255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 291355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 2914baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 2915baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2916826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2917826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2918826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Check if the field with is non-zero. 2919826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const OptionalAmount &Amt = FS.getFieldWidth(); 2920826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getHowSpecified() == OptionalAmount::Constant) { 2921826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getConstantAmount() == 0) { 2922826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 2923826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Amt.getConstantLength()); 292455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width), 292555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 292655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, R, 292755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval(R)); 29287f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 29297f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 2930826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2931826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!FS.consumesDataArgument()) { 2932826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Technically specifying a precision or field width here 2933826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // makes no sense. Worth issuing a warning at some point. 2934826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 2935826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2936826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2937826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Consume the argument. 2938826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned argIndex = FS.getArgIndex(); 2939826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (argIndex < NumDataArgs) { 2940826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The check to see if the argIndex is valid will come later. 2941826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // We set the bit here because we may exit early from this 2942826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // function if we encounter some other error. 2943826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.set(argIndex); 2944826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2945826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 29461e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek // Check the length modifier is valid with the given conversion specifier. 2947bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo())) 29488be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 29498be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_nonsensical_length); 2950bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthModifier()) 29518be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen); 2952bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose else if (!FS.hasStandardLengthConversionCombination()) 29538be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen, 29548be066e6733364cd34f25c4f7b7344f72aa23369Jordan Rose diag::warn_format_non_standard_conversion_spec); 295576517426dc8bf7734c07eefc35171a6bfdba1a2bHans Wennborg 2956bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose if (!FS.hasStandardConversionSpecifier(S.getLangOpts())) 2957bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen); 2958bbb6bb4952b77e57b842b4d3096848123ae690e7Jordan Rose 2959826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The remaining checks depend on the data arguments. 2960826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (HasVAListArg) 2961826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 2962826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2963666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 2964826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return false; 2965826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 29666fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Check that the argument type matches the format specifier. 29676fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg const Expr *Ex = getDataArg(argIndex); 296848716663e421472cbd590af160a372bc490205e8Jordan Rose if (!Ex) 296948716663e421472cbd590af160a372bc490205e8Jordan Rose return true; 297048716663e421472cbd590af160a372bc490205e8Jordan Rose 297158e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg const analyze_format_string::ArgType &AT = FS.getArgType(S.Context); 297258e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg if (AT.isValid() && !AT.matchesType(S.Context, Ex->getType())) { 29736fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg ScanfSpecifier fixedFS = FS; 29744e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie bool success = fixedFS.fixType(Ex->getType(), S.getLangOpts(), 2975be6126a2a784e1446460b8d15c2b26f880c871fcHans Wennborg S.Context); 29766fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 29776fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg if (success) { 29786fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Get the fix string from the fixed format specifier. 2979f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> buf; 29806fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg llvm::raw_svector_ostream os(buf); 29816fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg fixedFS.toString(os); 29826fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 29836fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg EmitFormatDiagnostic( 29846fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 298558e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg << AT.getRepresentativeTypeName(S.Context) << Ex->getType() 29866fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg << Ex->getSourceRange(), 2987abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay Ex->getLocStart(), 2988abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay /*IsStringLocation*/false, 29896fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 29906fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg FixItHint::CreateReplacement( 29916fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 29926fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg os.str())); 29936fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } else { 2994220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas EmitFormatDiagnostic( 2995220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 299658e1e54476d610d6c33ef483f216ed8a1282d35cHans Wennborg << AT.getRepresentativeTypeName(S.Context) << Ex->getType() 2997220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << Ex->getSourceRange(), 2998abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay Ex->getLocStart(), 2999abf145ab57fc56bfb9c48333fcc65b49a564dc60Matt Beaumont-Gay /*IsStringLocation*/false, 3000220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas getSpecifierRange(startSpecifier, specifierLen)); 30016fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 30026fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 30036fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 3004826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 300507d161f38e708a91486bf1c031d525faebbb249dTed Kremenek} 3006e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 3007826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr, 30080e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const Expr *OrigFormatExpr, 300929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **Args, unsigned NumArgs, 301029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas bool HasVAListArg, unsigned format_idx, 301134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg, FormatStringType Type, 3012ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose bool inFunctionCall, VariadicCallType CallType) { 3013826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3014e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: is the format string a wide literal? 3015df9ef1bc8c3780307ab2ed81bf5e31c23310b936Richard Smith if (!FExpr->isAscii() && !FExpr->isUTF8()) { 301655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 301729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas *this, inFunctionCall, Args[format_idx], 301855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(), 301955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 3020e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 3021e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 3022826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3023e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // Str - The format string. NOTE: this is NOT null-terminated! 30245f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef StrRef = FExpr->getString(); 30252f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer const char *Str = StrRef.data(); 30262f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer unsigned StrLen = StrRef.size(); 302729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const unsigned numDataArgs = NumArgs - firstDataArg; 3028826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3029e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: empty format string? 30304cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek if (StrLen == 0 && numDataArgs > 0) { 303155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 303229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas *this, inFunctionCall, Args[format_idx], 303355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_empty_format_string), FExpr->getLocStart(), 303455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 3035e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 3036e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 3037826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 303834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas if (Type == FST_Printf || Type == FST_NSString) { 3039826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 304050687314f87b67073c202fe46d84d12fb55e25cfJordan Rose numDataArgs, (Type == FST_NSString), 304129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Str, HasVAListArg, Args, NumArgs, format_idx, 3042ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall, CallType); 3043826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3044d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen, 3045275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose getLangOpts(), 3046275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose Context.getTargetInfo())) 3047826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 304834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } else if (Type == FST_Scanf) { 304950687314f87b67073c202fe46d84d12fb55e25cfJordan Rose CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, numDataArgs, 305029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Str, HasVAListArg, Args, NumArgs, format_idx, 3051ddcfbc9ad1817f545610999d655ac6c28d4c0c12Jordan Rose inFunctionCall, CallType); 3052826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 3053d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen, 3054275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose getLangOpts(), 3055275b6f52c7bcafc1f3cf291813b5c60ee776965aJordan Rose Context.getTargetInfo())) 3056826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 305734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } // TODO: handle other formats 3058ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek} 3059ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek 30607ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth//===--- CHECK: Standard memory functions ---------------------------------===// 30617ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 30622a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// \brief Determine whether the given type is a dynamic class type (e.g., 30632a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// whether it has a vtable). 30642a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregorstatic bool isDynamicClassType(QualType T) { 30652a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Record = T->getAsCXXRecordDecl()) 30662a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Definition = Record->getDefinition()) 30672a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (Definition->isDynamicClass()) 30682a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return true; 30692a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 30702a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return false; 30712a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor} 30722a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 3073a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument expression, 3074000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth/// otherwise returns NULL. 3075000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic const Expr *getSizeOfExprArg(const Expr* E) { 3076e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber if (const UnaryExprOrTypeTraitExpr *SizeOf = 3077000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 3078000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType()) 3079000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getArgumentExpr()->IgnoreParenImpCasts(); 3080e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 3081000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return 0; 3082000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth} 3083000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3084a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument type. 3085000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic QualType getSizeOfArgType(const Expr* E) { 3086000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryExprOrTypeTraitExpr *SizeOf = 3087000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 3088000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf) 3089000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getTypeOfArgument(); 3090000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3091000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return QualType(); 3092e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber} 3093e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 30947ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \brief Check for dangerous or invalid arguments to memset(). 30957ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 3096929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth/// This issues warnings on known problematic, dangerous or unspecified 3097cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp' 3098cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// function calls. 30997ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 31007ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \param Call The call expression to diagnose. 3101cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gayvoid Sema::CheckMemaccessArguments(const CallExpr *Call, 31020a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned BId, 3103cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay IdentifierInfo *FnName) { 31040a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks assert(BId != 0); 31050a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 31061d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek // It is possible to have a non-standard definition of memset. Validate 3107707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor // we have enough arguments, and if not, abort further checking. 31080a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned ExpectedNumArgs = (BId == Builtin::BIstrndup ? 2 : 3); 3109cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber if (Call->getNumArgs() < ExpectedNumArgs) 31101d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek return; 31111d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek 31120a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LastArg = (BId == Builtin::BImemset || 31130a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId == Builtin::BIstrndup ? 1 : 2); 31140a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LenArg = (BId == Builtin::BIstrndup ? 1 : 2); 3115cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts(); 3116000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3117000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We have special checking when the length is a sizeof expression. 3118000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth QualType SizeOfArgTy = getSizeOfArgType(LenExpr); 3119000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth const Expr *SizeOfArg = getSizeOfExprArg(LenExpr); 3120000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID SizeOfArgID; 3121000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 312206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) { 312306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts(); 3124e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange(); 312506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 312606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType DestTy = Dest->getType(); 312706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) { 312806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType PointeeTy = DestPtrTy->getPointeeType(); 3129f85e193739c953358c865005855253af4f68a497John McCall 3130000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Never warn about void type pointers. This can be used to suppress 3131000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // false positives. 3132000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isVoidType()) 313306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 313406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 3135000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by 3136000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // actually comparing the expressions for equality. Because computing the 3137000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // expression IDs can be expensive, we only do this if the diagnostic is 3138000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // enabled. 3139000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArg && 3140000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess, 3141000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->getExprLoc())) { 3142000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We only compute IDs for expressions if the warning is enabled, and 3143000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // cache the sizeof arg's ID. 3144000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgID == llvm::FoldingSetNodeID()) 3145000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->Profile(SizeOfArgID, Context, true); 3146000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID DestID; 3147000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Dest->Profile(DestID, Context, true); 3148000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (DestID == SizeOfArgID) { 3149cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // TODO: For strncpy() and friends, this could suggest sizeof(dst) 3150cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // over sizeof(src) as well. 3151000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth unsigned ActionIdx = 0; // Default is to suggest dereferencing. 31526fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks StringRef ReadableName = FnName->getName(); 31536fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 3154000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest)) 315590c78328e70cb376754edf87708505a84c044271Anna Zaks if (UnaryOp->getOpcode() == UO_AddrOf) 3156000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 1; // If its an address-of operator, just remove it. 3157000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (Context.getTypeSize(PointeeTy) == Context.getCharWidth()) 3158000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 2; // If the pointee's size is sizeof(char), 3159000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // suggest an explicit length. 31606fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 31616fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks // If the function is defined as a builtin macro, do not show macro 31626fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks // expansion. 31636fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceLocation SL = SizeOfArg->getExprLoc(); 31646fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceRange DSR = Dest->getSourceRange(); 31656fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceRange SSR = SizeOfArg->getSourceRange(); 31666fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SourceManager &SM = PP.getSourceManager(); 31676fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 31686fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks if (SM.isMacroArgExpansion(SL)) { 31696fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks ReadableName = Lexer::getImmediateMacroName(SL, SM, LangOpts); 31706fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SL = SM.getSpellingLoc(SL); 31716fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks DSR = SourceRange(SM.getSpellingLoc(DSR.getBegin()), 31726fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SM.getSpellingLoc(DSR.getEnd())); 31736fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SSR = SourceRange(SM.getSpellingLoc(SSR.getBegin()), 31746fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks SM.getSpellingLoc(SSR.getEnd())); 31756fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks } 31766fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks 317790c78328e70cb376754edf87708505a84c044271Anna Zaks DiagRuntimeBehavior(SL, SizeOfArg, 3178000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_expr_memaccess) 31796fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks << ReadableName 318090c78328e70cb376754edf87708505a84c044271Anna Zaks << PointeeTy 318190c78328e70cb376754edf87708505a84c044271Anna Zaks << DestTy 31826fcb3727e31280ba816dc86d024586b8c5933c13Anna Zaks << DSR 318390c78328e70cb376754edf87708505a84c044271Anna Zaks << SSR); 318490c78328e70cb376754edf87708505a84c044271Anna Zaks DiagRuntimeBehavior(SL, SizeOfArg, 318590c78328e70cb376754edf87708505a84c044271Anna Zaks PDiag(diag::warn_sizeof_pointer_expr_memaccess_note) 318690c78328e70cb376754edf87708505a84c044271Anna Zaks << ActionIdx 318790c78328e70cb376754edf87708505a84c044271Anna Zaks << SSR); 318890c78328e70cb376754edf87708505a84c044271Anna Zaks 3189000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 3190000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3191000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3192000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 3193000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Also check for cases where the sizeof argument is the exact same 3194000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // type as the memory argument, and where it points to a user-defined 3195000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // record type. 3196000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgTy != QualType()) { 3197000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isRecordType() && 3198000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Context.typesAreCompatible(SizeOfArgTy, DestTy)) { 3199000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest, 3200000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_type_memaccess) 3201000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << FnName << SizeOfArgTy << ArgIdx 3202000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << PointeeTy << Dest->getSourceRange() 3203000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << LenExpr->getSourceRange()); 3204000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 3205000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 3206e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber } 3207e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 320806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor // Always complain about dynamic classes. 32090a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (isDynamicClassType(PointeeTy)) { 32100a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 32110a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned OperationType = 0; 32120a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // "overwritten" if we're warning about the destination for any call 32130a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // but memcmp; otherwise a verb appropriate to the call. 32140a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (ArgIdx != 0 || BId == Builtin::BImemcmp) { 32150a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (BId == Builtin::BImemcpy) 32160a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 1; 32170a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if(BId == Builtin::BImemmove) 32180a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 2; 32190a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if (BId == Builtin::BImemcmp) 32200a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 3; 32210a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } 32220a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 32235c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 32245c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 32255c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_dyn_class_memaccess) 32260a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx) 3227d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks << FnName << PointeeTy 32280a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << OperationType 32295c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 32300a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } else if (PointeeTy.hasNonTrivialObjCLifetime() && 32310a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId != Builtin::BImemset) 32325c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 32335c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 32345c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_arc_object_memaccess) 32355c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << ArgIdx << FnName << PointeeTy 32365c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 3237f85e193739c953358c865005855253af4f68a497John McCall else 323806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 3239f85e193739c953358c865005855253af4f68a497John McCall 3240f85e193739c953358c865005855253af4f68a497John McCall DiagRuntimeBehavior( 3241f85e193739c953358c865005855253af4f68a497John McCall Dest->getExprLoc(), Dest, 3242929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth PDiag(diag::note_bad_memaccess_silence) 324306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)")); 324406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor break; 324506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 32467ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth } 32477ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth} 32487ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 3249bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// A little helper routine: ignore addition and subtraction of integer literals. 3250bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// This intentionally does not ignore all integer constant expressions because 3251bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// we don't want to remove sizeof(). 3252bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekstatic const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) { 3253bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = Ex->IgnoreParenCasts(); 3254bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3255bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek for (;;) { 3256bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex); 3257bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!BO || !BO->isAdditiveOp()) 3258bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 3259bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3260bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *RHS = BO->getRHS()->IgnoreParenCasts(); 3261bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *LHS = BO->getLHS()->IgnoreParenCasts(); 3262bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3263bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (isa<IntegerLiteral>(RHS)) 3264bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = LHS; 3265bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else if (isa<IntegerLiteral>(LHS)) 3266bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = RHS; 3267bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else 3268bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 3269bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3270bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3271bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return Ex; 3272bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 3273bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 32740f38acee92014cb15af980808f87144e5564031dAnna Zaksstatic bool isConstantSizeArrayWithMoreThanOneElement(QualType Ty, 32750f38acee92014cb15af980808f87144e5564031dAnna Zaks ASTContext &Context) { 32760f38acee92014cb15af980808f87144e5564031dAnna Zaks // Only handle constant-sized or VLAs, but not flexible members. 32770f38acee92014cb15af980808f87144e5564031dAnna Zaks if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(Ty)) { 32780f38acee92014cb15af980808f87144e5564031dAnna Zaks // Only issue the FIXIT for arrays of size > 1. 32790f38acee92014cb15af980808f87144e5564031dAnna Zaks if (CAT->getSize().getSExtValue() <= 1) 32800f38acee92014cb15af980808f87144e5564031dAnna Zaks return false; 32810f38acee92014cb15af980808f87144e5564031dAnna Zaks } else if (!Ty->isVariableArrayType()) { 32820f38acee92014cb15af980808f87144e5564031dAnna Zaks return false; 32830f38acee92014cb15af980808f87144e5564031dAnna Zaks } 32840f38acee92014cb15af980808f87144e5564031dAnna Zaks return true; 32850f38acee92014cb15af980808f87144e5564031dAnna Zaks} 32860f38acee92014cb15af980808f87144e5564031dAnna Zaks 3287bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// Warn if the user has made the 'size' argument to strlcpy or strlcat 3288bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// be the size of the source, instead of the destination. 3289bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekvoid Sema::CheckStrlcpycatArguments(const CallExpr *Call, 3290bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek IdentifierInfo *FnName) { 3291bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3292bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Don't crash if the user has the wrong number of arguments 3293bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (Call->getNumArgs() != 3) 3294bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3295bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3296bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context); 3297bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context); 3298bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *CompareWithSrc = NULL; 3299bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3300bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, sizeof(x))' 3301bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const Expr *Ex = getSizeOfExprArg(SizeArg)) 3302bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = Ex; 3303bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else { 3304bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, strlen(x))' 3305bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) { 3306180f47959a066795cc0f409433023af448bb0328Richard Smith if (SizeCall->isBuiltinCall() == Builtin::BIstrlen 3307bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek && SizeCall->getNumArgs() == 1) 3308bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context); 3309bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3310bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 3311bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3312bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrc) 3313bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3314bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3315bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Determine if the argument to sizeof/strlen is equal to the source 3316bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // argument. In principle there's all kinds of things you could do 3317bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // here, for instance creating an == expression and evaluating it with 3318bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // EvaluateAsBooleanCondition, but this uses a more direct technique: 3319bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg); 3320bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!SrcArgDRE) 3321bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3322bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3323bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc); 3324bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrcDRE || 3325bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl()) 3326bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 3327bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3328bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *OriginalSizeArg = Call->getArg(2); 3329bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size) 3330bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek << OriginalSizeArg->getSourceRange() << FnName; 3331bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3332bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Output a FIXIT hint if the destination is an array (rather than a 3333bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointer to an array). This could be enhanced to handle some 3334bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointers if we know the actual size, like if DstArg is 'array+2' 3335bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // we could say 'sizeof(array)-2'. 3336bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts(); 33370f38acee92014cb15af980808f87144e5564031dAnna Zaks if (!isConstantSizeArrayWithMoreThanOneElement(DstArg->getType(), Context)) 33388f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 33398f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 3340f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> sizeString; 33418f7462237ff542a4556775f98709ed300aa1731aTed Kremenek llvm::raw_svector_ostream OS(sizeString); 33428f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << "sizeof("; 3343d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 33448f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << ")"; 33458f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 33468f7462237ff542a4556775f98709ed300aa1731aTed Kremenek Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size) 33478f7462237ff542a4556775f98709ed300aa1731aTed Kremenek << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(), 33488f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS.str()); 3349bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 3350bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 3351c36bedc90c687caa71748480c60707ea4608b092Anna Zaks/// Check if two expressions refer to the same declaration. 3352c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic bool referToTheSameDecl(const Expr *E1, const Expr *E2) { 3353c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const DeclRefExpr *D1 = dyn_cast_or_null<DeclRefExpr>(E1)) 3354c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const DeclRefExpr *D2 = dyn_cast_or_null<DeclRefExpr>(E2)) 3355c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return D1->getDecl() == D2->getDecl(); 3356c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return false; 3357c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3358c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3359c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic const Expr *getStrlenExprArg(const Expr *E) { 3360c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const CallExpr *CE = dyn_cast<CallExpr>(E)) { 3361c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const FunctionDecl *FD = CE->getDirectCallee(); 3362c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (!FD || FD->getMemoryFunctionKind() != Builtin::BIstrlen) 3363c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return 0; 3364c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return CE->getArg(0)->IgnoreParenCasts(); 3365c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3366c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return 0; 3367c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3368c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3369c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// Warn on anti-patterns as the 'size' argument to strncat. 3370c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// The correct size argument should look like following: 3371c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// strncat(dst, src, sizeof(dst) - strlen(dest) - 1); 3372c36bedc90c687caa71748480c60707ea4608b092Anna Zaksvoid Sema::CheckStrncatArguments(const CallExpr *CE, 3373c36bedc90c687caa71748480c60707ea4608b092Anna Zaks IdentifierInfo *FnName) { 3374c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Don't crash if the user has the wrong number of arguments. 3375c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (CE->getNumArgs() < 3) 3376c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 3377c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *DstArg = CE->getArg(0)->IgnoreParenCasts(); 3378c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *SrcArg = CE->getArg(1)->IgnoreParenCasts(); 3379c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *LenArg = CE->getArg(2)->IgnoreParenCasts(); 3380c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3381c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Identify common expressions, which are wrongly used as the size argument 3382c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // to strncat and may lead to buffer overflows. 3383c36bedc90c687caa71748480c60707ea4608b092Anna Zaks unsigned PatternType = 0; 3384c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const Expr *SizeOfArg = getSizeOfExprArg(LenArg)) { 3385c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(dst) 3386c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (referToTheSameDecl(SizeOfArg, DstArg)) 3387c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 1; 3388c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(src) 3389c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (referToTheSameDecl(SizeOfArg, SrcArg)) 3390c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 2; 3391c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } else if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(LenArg)) { 3392c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (BE->getOpcode() == BO_Sub) { 3393c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *L = BE->getLHS()->IgnoreParenCasts(); 3394c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *R = BE->getRHS()->IgnoreParenCasts(); 3395c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(dst) - strlen(dst) 3396c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (referToTheSameDecl(DstArg, getSizeOfExprArg(L)) && 3397c36bedc90c687caa71748480c60707ea4608b092Anna Zaks referToTheSameDecl(DstArg, getStrlenExprArg(R))) 3398c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 1; 3399c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(src) - (anything) 3400c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (referToTheSameDecl(SrcArg, getSizeOfExprArg(L))) 3401c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 2; 3402c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3403c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 3404c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3405c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (PatternType == 0) 3406c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 3407c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3408afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks // Generate the diagnostic. 3409afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceLocation SL = LenArg->getLocStart(); 3410afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceRange SR = LenArg->getSourceRange(); 3411afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceManager &SM = PP.getSourceManager(); 3412afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks 3413afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks // If the function is defined as a builtin macro, do not show macro expansion. 3414afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks if (SM.isMacroArgExpansion(SL)) { 3415afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SL = SM.getSpellingLoc(SL); 3416afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SR = SourceRange(SM.getSpellingLoc(SR.getBegin()), 3417afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SM.getSpellingLoc(SR.getEnd())); 3418afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks } 3419afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks 34200f38acee92014cb15af980808f87144e5564031dAnna Zaks // Check if the destination is an array (rather than a pointer to an array). 34210f38acee92014cb15af980808f87144e5564031dAnna Zaks QualType DstTy = DstArg->getType(); 34220f38acee92014cb15af980808f87144e5564031dAnna Zaks bool isKnownSizeArray = isConstantSizeArrayWithMoreThanOneElement(DstTy, 34230f38acee92014cb15af980808f87144e5564031dAnna Zaks Context); 34240f38acee92014cb15af980808f87144e5564031dAnna Zaks if (!isKnownSizeArray) { 34250f38acee92014cb15af980808f87144e5564031dAnna Zaks if (PatternType == 1) 34260f38acee92014cb15af980808f87144e5564031dAnna Zaks Diag(SL, diag::warn_strncat_wrong_size) << SR; 34270f38acee92014cb15af980808f87144e5564031dAnna Zaks else 34280f38acee92014cb15af980808f87144e5564031dAnna Zaks Diag(SL, diag::warn_strncat_src_size) << SR; 34290f38acee92014cb15af980808f87144e5564031dAnna Zaks return; 34300f38acee92014cb15af980808f87144e5564031dAnna Zaks } 34310f38acee92014cb15af980808f87144e5564031dAnna Zaks 3432c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (PatternType == 1) 3433afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::warn_strncat_large_size) << SR; 3434c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else 3435afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::warn_strncat_src_size) << SR; 3436c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3437f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> sizeString; 3438c36bedc90c687caa71748480c60707ea4608b092Anna Zaks llvm::raw_svector_ostream OS(sizeString); 3439c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << "sizeof("; 3440d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 3441c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << ") - "; 3442c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << "strlen("; 3443d1420c6fa788669e49f21e184927c7833881e399Richard Smith DstArg->printPretty(OS, 0, getPrintingPolicy()); 3444c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << ") - 1"; 3445c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 3446afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::note_strncat_wrong_size) 3447afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks << FixItHint::CreateReplacement(SR, OS.str()); 3448c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 3449c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 345006de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===// 345106de276fff91264437fa75111ed76de43097e089Ted Kremenek 3452e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3453e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl); 3454e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars, 3455e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl); 345606de276fff91264437fa75111ed76de43097e089Ted Kremenek 345706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address 345806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable. 345906de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid 346006de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 346106de276fff91264437fa75111ed76de43097e089Ted Kremenek SourceLocation ReturnLoc) { 34621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 346326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Expr *stackE = 0; 34645f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<DeclRefExpr *, 8> refVars; 34654e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 346626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Perform checking for returned stack addresses, local blocks, 346726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // label addresses or references to temporaries. 3468f85e193739c953358c865005855253af4f68a497John McCall if (lhsType->isPointerType() || 34694e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie (!getLangOpts().ObjCAutoRefCount && lhsType->isBlockPointerType())) { 3470e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/0); 3471ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (lhsType->isReferenceType()) { 3472e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis stackE = EvalVal(RetValExp, refVars, /*ParentDecl=*/0); 347326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 347426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 347526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (stackE == 0) 347626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return; // Nothing suspicious was found. 347726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 347826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceLocation diagLoc; 347926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange diagRange; 348026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (refVars.empty()) { 348126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = stackE->getLocStart(); 348226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = stackE->getSourceRange(); 348326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { 348426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // We followed through a reference variable. 'stackE' contains the 348526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // problematic expression but we will warn at the return statement pointing 348626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // at the reference variable. We will later display the "trail" of 348726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // reference variables using notes. 348826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = refVars[0]->getLocStart(); 348926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = refVars[0]->getSourceRange(); 349026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 349126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 349226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var. 349326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref 349426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_stack_addr) 349526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << DR->getDecl()->getDeclName() << diagRange; 349626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<BlockExpr>(stackE)) { // local block. 349726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::err_ret_local_block) << diagRange; 349826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 349926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 350026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { // local temporary. 350126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref 350226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_local_temp_addr) 350326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << diagRange; 350426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 350526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 350626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Display the "trail" of reference variables that we followed until we 350726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // found the problematic expression using notes. 350826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 350926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 351026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this var binds to another reference var, show the range of the next 351126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // var, otherwise the var binds to the problematic expression, in which case 351226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // show the range of the expression. 351326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange() 351426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : stackE->getSourceRange(); 351526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(VD->getLocation(), diag::note_ref_var_local_bind) 351626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << VD->getDeclName() << range; 351706de276fff91264437fa75111ed76de43097e089Ted Kremenek } 351806de276fff91264437fa75111ed76de43097e089Ted Kremenek} 351906de276fff91264437fa75111ed76de43097e089Ted Kremenek 352006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 352106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// check if the expression in a return statement evaluates to an address 352226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// to a location on the stack, a local block, an address of a label, or a 352326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// reference to local temporary. The recursion is used to traverse the 352406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// AST of the return expression, with recursion backtracking when we 352526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// encounter a subexpression that (1) clearly does not lead to one of the 352626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// above problematic expressions (2) is something we cannot determine leads to 352726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// a problematic expression based on such local checking. 352826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 352926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// Both EvalAddr and EvalVal follow through reference variables to evaluate 353026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// the expression that they point to. Such variables are added to the 353126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 'refVars' vector so that we know what the reference variable "trail" was. 353206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 3533e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// EvalAddr processes expressions that are pointers that are used as 3534e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// references (and not L-values). EvalVal handles all other values. 353526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// At the base case of the recursion is a check for the above problematic 353626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// expressions. 353706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 353806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// This implementation handles: 353906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 354006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer-to-pointer casts 354106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * implicit conversions from array references to pointers 354206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of fields 354306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * arbitrary interplay between "&" and "*" operators 354406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer arithmetic from an address of a stack variable 354506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of an array element where the array is on the stack 3546e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3547e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl) { 354826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (E->isTypeDependent()) 354926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 355026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 355106de276fff91264437fa75111ed76de43097e089Ted Kremenek // We should only be called for evaluating pointer expressions. 35520f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall assert((E->getType()->isAnyPointerType() || 3553dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff E->getType()->isBlockPointerType() || 3554a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek E->getType()->isObjCQualifiedIdType()) && 3555fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner "EvalAddr only works on pointers"); 35561eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3557f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 3558f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 355906de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 356006de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 356106de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 356206de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 356326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::DeclRefExprClass: { 356426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis DeclRefExpr *DR = cast<DeclRefExpr>(E); 356526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 356626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 356726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this is a reference variable, follow through to the expression that 356826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 356926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage() && 357026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis V->getType()->isReferenceType() && V->hasInit()) { 357126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 357226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 3573e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(V->getInit(), refVars, ParentDecl); 357426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 357526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 357626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 357726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 357806de276fff91264437fa75111ed76de43097e089Ted Kremenek 3579fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::UnaryOperatorClass: { 3580fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // The only unary operator that make sense to handle here 3581fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // is AddrOf. All others don't make sense as pointers. 3582fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner UnaryOperator *U = cast<UnaryOperator>(E); 35831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 35842de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_AddrOf) 3585e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(U->getSubExpr(), refVars, ParentDecl); 3586fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 3587fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 3588fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 35891eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3590fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::BinaryOperatorClass: { 3591fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle pointer arithmetic. All other binary operators are not valid 3592fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // in this context. 3593fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner BinaryOperator *B = cast<BinaryOperator>(E); 35942de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = B->getOpcode(); 35951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 35962de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op != BO_Add && op != BO_Sub) 3597fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 35981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3599fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner Expr *Base = B->getLHS(); 36003907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 3601fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Determine which argument is the real pointer base. It could be 3602fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // the RHS argument instead of the LHS. 3603fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner if (!Base->getType()->isPointerType()) Base = B->getRHS(); 36041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3605fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner assert (Base->getType()->isPointerType()); 3606e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(Base, refVars, ParentDecl); 3607fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 360861f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff 3609fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // For conditional operators we need to see if either the LHS or RHS are 3610fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // valid DeclRefExpr*s. If one of them is valid, we return it. 3611fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ConditionalOperatorClass: { 3612fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner ConditionalOperator *C = cast<ConditionalOperator>(E); 36131eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3614fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle the GNU extension for missing LHS. 36159ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (Expr *lhsExpr = C->getLHS()) { 36169ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 36179ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (!lhsExpr->getType()->isVoidType()) 3618e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (Expr* LHS = EvalAddr(lhsExpr, refVars, ParentDecl)) 36199ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return LHS; 36209ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor } 36219ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor 36229ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 36239ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (C->getRHS()->getType()->isVoidType()) 36249ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return NULL; 362506de276fff91264437fa75111ed76de43097e089Ted Kremenek 3626e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(C->getRHS(), refVars, ParentDecl); 3627fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 362826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 362926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::BlockExprClass: 3630469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures()) 363126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // local block. 363226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 363326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 363426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::AddrLabelExprClass: 363526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // address of label. 36361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 363780ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 3638e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars, 3639e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis ParentDecl); 364080ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 364154b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // For casts, we need to handle conversions from arrays to 364254b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // pointer values, and pointer-to-pointer conversions. 364349badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::ImplicitCastExprClass: 36446eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor case Stmt::CStyleCastExprClass: 3645f85e193739c953358c865005855253af4f68a497John McCall case Stmt::CXXFunctionalCastExprClass: 36468b9414e868853fc052251455674bf7512261e14aEli Friedman case Stmt::ObjCBridgedCastExprClass: 36471eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXStaticCastExprClass: 36481eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXDynamicCastExprClass: 364949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXConstCastExprClass: 365049badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXReinterpretCastExprClass: { 36518b9414e868853fc052251455674bf7512261e14aEli Friedman Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 36528b9414e868853fc052251455674bf7512261e14aEli Friedman switch (cast<CastExpr>(E)->getCastKind()) { 36538b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BitCast: 36548b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_LValueToRValue: 36558b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_NoOp: 36568b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BaseToDerived: 36578b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_DerivedToBase: 36588b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_UncheckedDerivedToBase: 36598b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_Dynamic: 36608b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_CPointerToObjCPointerCast: 36618b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_BlockPointerToObjCPointerCast: 36628b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_AnyPointerToBlockPointerCast: 3663e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(SubExpr, refVars, ParentDecl); 36648b9414e868853fc052251455674bf7512261e14aEli Friedman 36658b9414e868853fc052251455674bf7512261e14aEli Friedman case CK_ArrayToPointerDecay: 3666e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(SubExpr, refVars, ParentDecl); 36678b9414e868853fc052251455674bf7512261e14aEli Friedman 36688b9414e868853fc052251455674bf7512261e14aEli Friedman default: 36698b9414e868853fc052251455674bf7512261e14aEli Friedman return 0; 36708b9414e868853fc052251455674bf7512261e14aEli Friedman } 3671fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 36721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 367303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 367403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalAddr( 367503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 3676e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis refVars, ParentDecl)) 367703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 367803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 367903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 368003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 3681fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Everything else: we simply don't reason about them. 3682fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner default: 3683fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 368406de276fff91264437fa75111ed76de43097e089Ted Kremenek } 368506de276fff91264437fa75111ed76de43097e089Ted Kremenek} 36861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 368706de276fff91264437fa75111ed76de43097e089Ted Kremenek 368806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalVal - This function is complements EvalAddr in the mutual recursion. 368906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// See the comments for EvalAddr for more details. 3690e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars, 3691e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis Decl *ParentDecl) { 369268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo { 3693e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // We should only be called for evaluating non-pointer expressions, or 3694e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // expressions with a pointer type that are not used as references but instead 3695e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // are l-values (e.g., DeclRefExpr with a pointer type). 36961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 369706de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 369806de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 369906de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 3700f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 3701f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 370206de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 370368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ImplicitCastExprClass: { 370468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 37055baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall if (IE->getValueKind() == VK_LValue) { 370668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = IE->getSubExpr(); 370768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 370868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 370968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek return NULL; 371068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 371168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek 371280ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 3713e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,ParentDecl); 371480ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 3715a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor case Stmt::DeclRefExprClass: { 371626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // When we hit a DeclRefExpr we are looking at code that refers to a 371726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // variable's name. If it's not a reference variable we check if it has 371826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // local storage within the function, and if so, return the expression. 371906de276fff91264437fa75111ed76de43097e089Ted Kremenek DeclRefExpr *DR = cast<DeclRefExpr>(E); 37201eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3721e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) { 3722e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis // Check if it refers to itself, e.g. "int& i = i;". 3723e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (V == ParentDecl) 3724e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return DR; 3725e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis 372626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage()) { 372726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!V->getType()->isReferenceType()) 372826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return DR; 372926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 373026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Reference variable, follow through to the expression that 373126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 373226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasInit()) { 373326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 373426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 3735e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(V->getInit(), refVars, V); 373626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 373726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 3738e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis } 37391eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 374006de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 374106de276fff91264437fa75111ed76de43097e089Ted Kremenek } 37421eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 374306de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::UnaryOperatorClass: { 374406de276fff91264437fa75111ed76de43097e089Ted Kremenek // The only unary operator that make sense to handle here 374506de276fff91264437fa75111ed76de43097e089Ted Kremenek // is Deref. All others don't resolve to a "name." This includes 374606de276fff91264437fa75111ed76de43097e089Ted Kremenek // handling all sorts of rvalues passed to a unary operator. 374706de276fff91264437fa75111ed76de43097e089Ted Kremenek UnaryOperator *U = cast<UnaryOperator>(E); 37481eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 37492de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_Deref) 3750e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(U->getSubExpr(), refVars, ParentDecl); 375106de276fff91264437fa75111ed76de43097e089Ted Kremenek 375206de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 375306de276fff91264437fa75111ed76de43097e089Ted Kremenek } 37541eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 375506de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ArraySubscriptExprClass: { 375606de276fff91264437fa75111ed76de43097e089Ted Kremenek // Array subscripts are potential references to data on the stack. We 375706de276fff91264437fa75111ed76de43097e089Ted Kremenek // retrieve the DeclRefExpr* for the array variable if it indeed 375806de276fff91264437fa75111ed76de43097e089Ted Kremenek // has local storage. 3759e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars,ParentDecl); 376006de276fff91264437fa75111ed76de43097e089Ted Kremenek } 37611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 376206de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ConditionalOperatorClass: { 376306de276fff91264437fa75111ed76de43097e089Ted Kremenek // For conditional operators we need to see if either the LHS or RHS are 376426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // non-NULL Expr's. If one is non-NULL, we return it. 376506de276fff91264437fa75111ed76de43097e089Ted Kremenek ConditionalOperator *C = cast<ConditionalOperator>(E); 376606de276fff91264437fa75111ed76de43097e089Ted Kremenek 37673907323dd6665c0c4e383435cb145233f4533406Anders Carlsson // Handle the GNU extension for missing LHS. 37683907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (Expr *lhsExpr = C->getLHS()) 3769e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis if (Expr *LHS = EvalVal(lhsExpr, refVars, ParentDecl)) 37703907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return LHS; 37713907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 3772e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(C->getRHS(), refVars, ParentDecl); 377306de276fff91264437fa75111ed76de43097e089Ted Kremenek } 37741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 377506de276fff91264437fa75111ed76de43097e089Ted Kremenek // Accesses to members are potential references to data on the stack. 377683f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor case Stmt::MemberExprClass: { 377706de276fff91264437fa75111ed76de43097e089Ted Kremenek MemberExpr *M = cast<MemberExpr>(E); 37781eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 377906de276fff91264437fa75111ed76de43097e089Ted Kremenek // Check for indirect access. We only want direct field accesses. 3780a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->isArrow()) 3781a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return NULL; 3782a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 3783a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // Check whether the member type is itself a reference, in which case 3784a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // we're not going to refer to the member, but to what the member refers to. 3785a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->getMemberDecl()->getType()->isReferenceType()) 378606de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 3787a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 3788e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis return EvalVal(M->getBase(), refVars, ParentDecl); 378906de276fff91264437fa75111ed76de43097e089Ted Kremenek } 37901eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 379103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 379203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalVal( 379303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 3794e720ce7a3b1c1bfa5f7482183caa6e31fca9a3fbArgyrios Kyrtzidis refVars, ParentDecl)) 379503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 379603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 379703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 379803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 379906de276fff91264437fa75111ed76de43097e089Ted Kremenek default: 380026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Check that we don't return or take the address of a reference to a 380126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // temporary. This is only useful in C++. 380226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!E->isTypeDependent() && E->isRValue()) 380326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; 380426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 380526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Everything else: we simply don't reason about them. 380606de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 380706de276fff91264437fa75111ed76de43097e089Ted Kremenek } 380868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true); 380906de276fff91264437fa75111ed76de43097e089Ted Kremenek} 3810588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3811588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 3812588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3813588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==. 3814588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely 3815588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended. 3816dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieuvoid Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) { 3817dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts(); 3818dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* RightExprSansParen = RHS->IgnoreParenImpCasts(); 3819588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3820588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Special case: check for x == x (which is OK). 3821588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Do not emit warnings for such cases. 3822588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 3823588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 3824588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DRL->getDecl() == DRR->getDecl()) 3825980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 38261eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 38271eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 38281b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // Special case: check for comparisons against literals that can be exactly 38291b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // represented by APFloat. In such cases, do not emit a warning. This 38301b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // is a heuristic: often comparison against such literals are used to 38311b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // detect if a value in a variable has not changed. This clearly can 38321b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // lead to false negatives. 3833980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 3834980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FLL->isExact()) 3835980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 3836980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie } else 3837980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)) 3838980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (FLR->isExact()) 3839980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 38401eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3841588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Check for comparisons with builtin types. 3842980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 3843980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CL->isBuiltinCall()) 3844980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 38451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3846980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 3847980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie if (CR->isBuiltinCall()) 3848980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie return; 38491eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3850588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Emit the diagnostic. 3851980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie Diag(Loc, diag::warn_floatingpoint_eq) 3852980343b9a1d0e85f960fa289c2c9a727004964f2David Blaikie << LHS->getSourceRange() << RHS->getSourceRange(); 3853588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek} 3854ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3855f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 3856f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 3857ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3858f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace { 3859ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3860f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued 3861f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression. 3862f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange { 3863f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// The number of bits active in the int. 3864f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned Width; 3865ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3866f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// True if the int is known not to have negative values. 3867f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool NonNegative; 386851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3869f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange(unsigned Width, bool NonNegative) 3870f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : Width(Width), NonNegative(NonNegative) 3871f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall {} 387251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 38731844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of the bool type. 3874f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall static IntRange forBoolType() { 3875f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(1, true); 3876f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 387751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 38781844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of the given integral type. 38791844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfType(ASTContext &C, QualType T) { 38801844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return forValueOfCanonicalType(C, 38811844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T->getCanonicalTypeInternal().getTypePtr()); 388251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 388351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 38841844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of a canonical integral type. 38851844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 3886f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(T->isCanonicalUnqualified()); 388751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3888f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 3889f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = VT->getElementType().getTypePtr(); 3890f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 3891f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = CT->getElementType().getTypePtr(); 3892323ed74658bc8375278eabf074b4777458376540John McCall 3893091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // For enum types, use the known bit width of the enumerators. 3894323ed74658bc8375278eabf074b4777458376540John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) { 3895323ed74658bc8375278eabf074b4777458376540John McCall EnumDecl *Enum = ET->getDecl(); 38965e1cdac63c3d9c9b32fa41fa0b2d242a58a20d49John McCall if (!Enum->isCompleteDefinition()) 3897091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return IntRange(C.getIntWidth(QualType(T, 0)), false); 3898091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3899323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumPositive = Enum->getNumPositiveBits(); 3900323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumNegative = Enum->getNumNegativeBits(); 3901323ed74658bc8375278eabf074b4777458376540John McCall 3902323ed74658bc8375278eabf074b4777458376540John McCall return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0); 3903323ed74658bc8375278eabf074b4777458376540John McCall } 390451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3905f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const BuiltinType *BT = cast<BuiltinType>(T); 3906f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(BT->isInteger()); 390751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3908f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 390951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 391051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 39111844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the "target" range of a canonical integral type, i.e. 39121844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// the range of values expressible in the type. 39131844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// 39141844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// This matches forValueOfCanonicalType except that enums have the 39151844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// full range of their type, not the range of their enumerators. 39161844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 39171844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(T->isCanonicalUnqualified()); 39181844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 39191844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 39201844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = VT->getElementType().getTypePtr(); 39211844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 39221844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = CT->getElementType().getTypePtr(); 39231844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) 392469ff26bd1e7a2faffec0c3b9740cfb0c6bb354c5Douglas Gregor T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr(); 39251844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 39261844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall const BuiltinType *BT = cast<BuiltinType>(T); 39271844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(BT->isInteger()); 39281844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 39291844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 39301844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall } 39311844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 39321844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the supremum of two ranges: i.e. their conservative merge. 3933c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange join(IntRange L, IntRange R) { 3934f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(std::max(L.Width, R.Width), 393560fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative && R.NonNegative); 393660fad45739b764886f707bd204eae9ecce6db1f2John McCall } 393760fad45739b764886f707bd204eae9ecce6db1f2John McCall 39381844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the infinum of two ranges: i.e. their aggressive merge. 3939c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange meet(IntRange L, IntRange R) { 394060fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange(std::min(L.Width, R.Width), 394160fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative || R.NonNegative); 394251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 3943f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}; 394451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 39450692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, 39460692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek unsigned MaxWidth) { 3947f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isSigned() && value.isNegative()) 3948f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getMinSignedBits(), false); 394951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3950f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.getBitWidth() > MaxWidth) 39519f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad value = value.trunc(MaxWidth); 395251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3953f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // isNonNegative() just checks the sign bit without considering 3954f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // signedness. 3955f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getActiveBits(), true); 395651313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 395751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 39580692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 39590692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek unsigned MaxWidth) { 3960f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isInt()) 3961f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetValueRange(C, result.getInt(), MaxWidth); 396251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3963f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isVector()) { 39640acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 39650acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 39660acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 39670acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall R = IntRange::join(R, El); 39680acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall } 3969f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return R; 397051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 397151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3972f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isComplexInt()) { 3973f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 3974f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 3975f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(R, I); 3976f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 3977f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3978f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // This can happen with lossless casts to intptr_t of "based" lvalues. 3979f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume it might use arbitrary bits. 39800acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // FIXME: The only reason we need to pass the type in here is to get 39810acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // the sign right on this one case. It would be nice if APValue 39820acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // preserved this. 398365639284118d54ddf2e51a05d2ffccda567fe246Eli Friedman assert(result.isLValue() || result.isAddrLabelDiff()); 39845e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType()); 398551313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 398651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3987f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the 3988f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take. 3989f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 3990f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated 39910692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 399251313c39c84407dd6a323be99a8c322bf8d052a9John McCall E = E->IgnoreParens(); 399351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3994f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Try a full evaluation first. 3995f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall Expr::EvalResult result; 399651f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, C)) 39970acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall return GetValueRange(C, result.Val, E->getType(), MaxWidth); 399851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3999f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // I think we only want to look through implicit casts here; if the 4000f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // user has an explicit widening cast, we should treat the value as 4001f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // being of the new, wider type. 4002f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 4003b17ee5bff0d7986c14cdddb279e0131bd7f9678dEli Friedman if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue) 4004f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CE->getSubExpr(), MaxWidth); 400551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 40061844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType()); 400751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 40082de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 400960fad45739b764886f707bd204eae9ecce6db1f2John McCall 4010f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume that non-integer casts can span the full range of the type. 401160fad45739b764886f707bd204eae9ecce6db1f2John McCall if (!isIntegerCast) 4012f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 401351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4014f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange SubRange 4015f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall = GetExprRange(C, CE->getSubExpr(), 4016f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall std::min(MaxWidth, OutputTypeRange.Width)); 401751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4018f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Bail out if the subexpr's range is as wide as the cast type. 4019f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SubRange.Width >= OutputTypeRange.Width) 4020f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 402151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4022f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, we take the smaller width, and we're non-negative if 4023f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // either the output type or the subexpr is. 4024f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(SubRange.Width, 4025f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall SubRange.NonNegative || OutputTypeRange.NonNegative); 4026f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 4027f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4028f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 4029f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // If we can fold the condition, just take that operand. 4030f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool CondResult; 4031f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 4032f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CondResult ? CO->getTrueExpr() 4033f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : CO->getFalseExpr(), 4034f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall MaxWidth); 4035f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4036f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, conservatively merge. 4037f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 4038f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 4039f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 404051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 404151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 404251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 404351313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (BO->getOpcode()) { 404451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4045f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Boolean-valued operations are single-bit and positive. 40462de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LAnd: 40472de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LOr: 40482de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LT: 40492de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GT: 40502de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LE: 40512de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GE: 40522de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_EQ: 40532de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_NE: 4054f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 405551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4056862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // The type of the assignments is the type of the LHS, so the RHS 4057862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // is not necessarily the same type. 40582de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_MulAssign: 40592de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_DivAssign: 40602de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_RemAssign: 40612de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AddAssign: 40622de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_SubAssign: 4063862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_XorAssign: 4064862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_OrAssign: 4065862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 40661844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 4067c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall 4068862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // Simple assignments just pass through the RHS, which will have 4069862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // been coerced to the LHS type. 4070862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_Assign: 4071862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 4072862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 4073862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall 407451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 40752de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemD: 40762de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemI: 40771844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 407851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 407960fad45739b764886f707bd204eae9ecce6db1f2John McCall // Bitwise-and uses the *infinum* of the two source ranges. 40802de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_And: 40812de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AndAssign: 408260fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 408360fad45739b764886f707bd204eae9ecce6db1f2John McCall GetExprRange(C, BO->getRHS(), MaxWidth)); 408460fad45739b764886f707bd204eae9ecce6db1f2John McCall 408551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Left shift gets black-listed based on a judgement call. 40862de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shl: 40873aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // ...except that we want to treat '1 << (blah)' as logically 40883aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // positive. It's an important idiom. 40893aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (IntegerLiteral *I 40903aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 40913aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (I->getValue() == 1) { 40921844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange R = IntRange::forValueOfType(C, E->getType()); 40933aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall return IntRange(R.Width, /*NonNegative*/ true); 40943aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 40953aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 40963aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // fallthrough 40973aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall 40982de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShlAssign: 40991844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 410051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 410160fad45739b764886f707bd204eae9ecce6db1f2John McCall // Right shift by a constant can narrow its left argument. 41022de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shr: 41032de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShrAssign: { 410460fad45739b764886f707bd204eae9ecce6db1f2John McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 410560fad45739b764886f707bd204eae9ecce6db1f2John McCall 410660fad45739b764886f707bd204eae9ecce6db1f2John McCall // If the shift amount is a positive constant, drop the width by 410760fad45739b764886f707bd204eae9ecce6db1f2John McCall // that much. 410860fad45739b764886f707bd204eae9ecce6db1f2John McCall llvm::APSInt shift; 410960fad45739b764886f707bd204eae9ecce6db1f2John McCall if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 411060fad45739b764886f707bd204eae9ecce6db1f2John McCall shift.isNonNegative()) { 411160fad45739b764886f707bd204eae9ecce6db1f2John McCall unsigned zext = shift.getZExtValue(); 411260fad45739b764886f707bd204eae9ecce6db1f2John McCall if (zext >= L.Width) 411360fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width = (L.NonNegative ? 0 : 1); 411460fad45739b764886f707bd204eae9ecce6db1f2John McCall else 411560fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width -= zext; 411660fad45739b764886f707bd204eae9ecce6db1f2John McCall } 411760fad45739b764886f707bd204eae9ecce6db1f2John McCall 411860fad45739b764886f707bd204eae9ecce6db1f2John McCall return L; 411960fad45739b764886f707bd204eae9ecce6db1f2John McCall } 412060fad45739b764886f707bd204eae9ecce6db1f2John McCall 412160fad45739b764886f707bd204eae9ecce6db1f2John McCall // Comma acts as its right operand. 41222de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Comma: 4123f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 4124f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 412560fad45739b764886f707bd204eae9ecce6db1f2John McCall // Black-list pointer subtractions. 41262de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Sub: 412751313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BO->getLHS()->getType()->isPointerType()) 41281844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 412900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall break; 413000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 413100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The width of a division result is mostly determined by the size 413200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // of the LHS. 413300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Div: { 413400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 413500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 413600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 413700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 413800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // If the divisor is constant, use that. 413900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall llvm::APSInt divisor; 414000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) { 414100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned log2 = divisor.logBase2(); // floor(log_2(divisor)) 414200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (log2 >= L.Width) 414300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = (L.NonNegative ? 0 : 1); 414400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall else 414500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = std::min(L.Width - log2, MaxWidth); 414600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return L; 414700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 414800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 414900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Otherwise, just use the LHS's width. 415000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 415100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return IntRange(L.Width, L.NonNegative && R.NonNegative); 415200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 415300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 415400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The result of a remainder can't be larger than the result of 415500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // either side. 415600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Rem: { 415700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 415800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 415900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 416000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 416100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 416200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange meet = IntRange::meet(L, R); 416300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall meet.Width = std::min(meet.Width, MaxWidth); 416400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return meet; 416500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 41664e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 416700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default behavior is okay for these. 416800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Mul: 416900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Add: 417000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Xor: 417100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Or: 4172f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall break; 417351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 4174f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 417500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default case is to treat the operation as if it were closed 417600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // on the narrowest type that encompasses both operands. 4177f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 4178f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 4179f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 418051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 418151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 418251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 418351313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (UO->getOpcode()) { 418451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Boolean-valued operations are white-listed. 41852de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_LNot: 4186f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 418751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 418851313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 41892de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_Deref: 41902de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_AddrOf: // should be impossible 41911844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 419251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 419351313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 4194f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, UO->getSubExpr(), MaxWidth); 419551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 419651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 41978ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor 41988ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor if (dyn_cast<OffsetOfExpr>(E)) { 41991844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange::forValueOfType(C, E->getType()); 42008ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor } 420151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4202a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith if (FieldDecl *BitField = E->getBitField()) 4203a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith return IntRange(BitField->getBitWidthValue(C), 42045e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor BitField->getType()->isUnsignedIntegerOrEnumerationType()); 4205f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 42061844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 4207f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 4208f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 42090692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E) { 4210323ed74658bc8375278eabf074b4777458376540John McCall return GetExprRange(C, E, C.getIntWidth(E->getType())); 4211323ed74658bc8375278eabf074b4777458376540John McCall} 4212323ed74658bc8375278eabf074b4777458376540John McCall 4213f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 4214f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 4215f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 42160692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const llvm::APFloat &value, 42170692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Src, 42180692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Tgt) { 4219f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APFloat truncated = value; 4220f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4221f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool ignored; 4222f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 4223f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 4224f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4225f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return truncated.bitwiseIsEqual(value); 422651313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 422751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4228f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 4229f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 4230f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 4231f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 4232f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number). 42330692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const APValue &value, 42340692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Src, 42350692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Tgt) { 4236f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isFloat()) 4237f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 4238f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4239f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isVector()) { 4240f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 4241f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 4242f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return false; 4243f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return true; 4244f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 4245f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4246f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(value.isComplexFloat()); 4247f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 4248f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 4249f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 4250f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 42510692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 4252323ed74658bc8375278eabf074b4777458376540John McCall 4253e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) { 4254e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where we are comparing against an enum constant. 4255e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (const DeclRefExpr *DR = 4256e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 4257e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (isa<EnumConstantDecl>(DR->getDecl())) 4258e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 4259e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 4260e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where the '0' value is expanded from a macro. 4261e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (E->getLocStart().isMacroID()) 4262e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 4263e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 4264323ed74658bc8375278eabf074b4777458376540John McCall llvm::APSInt Value; 4265323ed74658bc8375278eabf074b4777458376540John McCall return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 4266323ed74658bc8375278eabf074b4777458376540John McCall} 4267323ed74658bc8375278eabf074b4777458376540John McCall 4268372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) { 4269372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall // Strip off implicit integral promotions. 4270372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 427163b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis if (ICE->getCastKind() != CK_IntegralCast && 427263b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis ICE->getCastKind() != CK_NoOp) 4273372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall break; 427463b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis E = ICE->getSubExpr(); 4275372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall } 4276372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 4277372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall return E->getType()->isEnumeralType(); 4278372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall} 4279372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 42800692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 42812de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = E->getOpcode(); 428214af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor if (E->isValueDependent()) 428314af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor return; 428414af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor 42852de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op == BO_LT && IsZero(S, E->getRHS())) { 4286323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 4287372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "< 0" << "false" << HasEnumType(E->getLHS()) 4288323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 42892de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GE && IsZero(S, E->getRHS())) { 4290323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 4291372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << ">= 0" << "true" << HasEnumType(E->getLHS()) 4292323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 42932de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GT && IsZero(S, E->getLHS())) { 4294323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 4295372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 >" << "false" << HasEnumType(E->getRHS()) 4296323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 42972de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_LE && IsZero(S, E->getLHS())) { 4298323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 4299372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 <=" << "true" << HasEnumType(E->getRHS()) 4300323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 4301323ed74658bc8375278eabf074b4777458376540John McCall } 4302323ed74658bc8375278eabf074b4777458376540John McCall} 4303323ed74658bc8375278eabf074b4777458376540John McCall 430415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanianstatic void DiagnoseOutOfRangeComparison(Sema &S, BinaryOperator *E, 4305a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian Expr *Constant, Expr *Other, 430615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian llvm::APSInt Value, 4307a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian bool RhsConstant) { 430815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian BinaryOperatorKind op = E->getOpcode(); 4309a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian QualType OtherT = Other->getType(); 4310a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian QualType ConstantT = Constant->getType(); 4311a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian if (S.Context.hasSameUnqualifiedType(OtherT, ConstantT)) 431215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian return; 4313a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian assert((OtherT->isIntegerType() && ConstantT->isIntegerType()) 431415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian && "comparison with non-integer type"); 4315a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian // FIXME. handle cases for signedness to catch (signed char)N == 200 431615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian IntRange OtherRange = IntRange::forValueOfType(S.Context, OtherT); 4317a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian IntRange LitRange = GetValueRange(S.Context, Value, Value.getBitWidth()); 431815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (OtherRange.Width >= LitRange.Width) 431915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian return; 432015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsTrue = true; 432115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (op == BO_EQ) 432215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian IsTrue = false; 432315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else if (op == BO_NE) 432415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian IsTrue = true; 4325a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian else if (RhsConstant) { 432615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (op == BO_GT || op == BO_GE) 432715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian IsTrue = !LitRange.NonNegative; 432815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else // op == BO_LT || op == BO_LE 432915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian IsTrue = LitRange.NonNegative; 4330a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian } else { 433115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (op == BO_LT || op == BO_LE) 433215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian IsTrue = !LitRange.NonNegative; 433315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else // op == BO_GT || op == BO_GE 433415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian IsTrue = LitRange.NonNegative; 433515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian } 4336a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian SmallString<16> PrettySourceValue(Value.toString(10)); 4337a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian S.Diag(E->getOperatorLoc(), diag::warn_out_of_range_compare) 4338a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian << PrettySourceValue << OtherT << IsTrue 433915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 434015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian} 434115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4342323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison. Implements the 4343323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison. 43440692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 4345b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 4346b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 4347323ed74658bc8375278eabf074b4777458376540John McCall} 4348f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4349ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare. 4350ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// 4351dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu/// \param E the binary operator to check for warnings 43520692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeComparison(Sema &S, BinaryOperator *E) { 4353323ed74658bc8375278eabf074b4777458376540John McCall // The type the comparison is being performed in. 4354323ed74658bc8375278eabf074b4777458376540John McCall QualType T = E->getLHS()->getType(); 4355323ed74658bc8375278eabf074b4777458376540John McCall assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 4356323ed74658bc8375278eabf074b4777458376540John McCall && "comparison with mismatched types"); 4357ab4702febef82409773f7c80ec02d53ddbb4d80eFariborz Jahanian if (E->isValueDependent()) 4358ab4702febef82409773f7c80ec02d53ddbb4d80eFariborz Jahanian return AnalyzeImpConvsInComparison(S, E); 4359323ed74658bc8375278eabf074b4777458376540John McCall 436015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian Expr *LHS = E->getLHS()->IgnoreParenImpCasts(); 436115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian Expr *RHS = E->getRHS()->IgnoreParenImpCasts(); 436215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 436315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsComparisonConstant = false; 436415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4365a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian // Check whether an integer constant comparison results in a value 436615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian // of 'true' or 'false'. 436715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (T->isIntegralType(S.Context)) { 436815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian llvm::APSInt RHSValue; 436915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsRHSIntegralLiteral = 437015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian RHS->isIntegerConstantExpr(RHSValue, S.Context); 437115a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian llvm::APSInt LHSValue; 437215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian bool IsLHSIntegralLiteral = 437315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian LHS->isIntegerConstantExpr(LHSValue, S.Context); 437415a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (IsRHSIntegralLiteral && !IsLHSIntegralLiteral) 437515a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian DiagnoseOutOfRangeComparison(S, E, RHS, LHS, RHSValue, true); 437615a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else if (!IsRHSIntegralLiteral && IsLHSIntegralLiteral) 437715a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian DiagnoseOutOfRangeComparison(S, E, LHS, RHS, LHSValue, false); 437815a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian else 437915a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian IsComparisonConstant = 438015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian (IsRHSIntegralLiteral && IsLHSIntegralLiteral); 4381a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian } else if (!T->hasUnsignedIntegerRepresentation()) 4382a193f20916f0e0e5a3b0f76ca69e2b3870c1a325Fariborz Jahanian IsComparisonConstant = E->isIntegerConstantExpr(S.Context); 438315a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4384323ed74658bc8375278eabf074b4777458376540John McCall // We don't do anything special if this isn't an unsigned integral 4385323ed74658bc8375278eabf074b4777458376540John McCall // comparison: we're only interested in integral comparisons, and 4386323ed74658bc8375278eabf074b4777458376540John McCall // signed comparisons only happen in cases we don't care to warn about. 43873e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // 43883e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // We also don't care about value-dependent expressions or expressions 43893e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // whose result is a constant. 439015a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian if (!T->hasUnsignedIntegerRepresentation() || IsComparisonConstant) 4391323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 439215a9356464f0809e1cb24aa3a7cc2577914ff5bbFariborz Jahanian 4393323ed74658bc8375278eabf074b4777458376540John McCall // Check to see if one of the (unmodified) operands is of different 4394323ed74658bc8375278eabf074b4777458376540John McCall // signedness. 4395323ed74658bc8375278eabf074b4777458376540John McCall Expr *signedOperand, *unsignedOperand; 4396dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu if (LHS->getType()->hasSignedIntegerRepresentation()) { 4397dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu assert(!RHS->getType()->hasSignedIntegerRepresentation() && 4398323ed74658bc8375278eabf074b4777458376540John McCall "unsigned comparison between two signed integer expressions?"); 4399dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = LHS; 4400dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = RHS; 4401dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu } else if (RHS->getType()->hasSignedIntegerRepresentation()) { 4402dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = RHS; 4403dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = LHS; 4404ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } else { 4405323ed74658bc8375278eabf074b4777458376540John McCall CheckTrivialUnsignedComparison(S, E); 4406323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 4407ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } 4408ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4409323ed74658bc8375278eabf074b4777458376540John McCall // Otherwise, calculate the effective range of the signed operand. 4410323ed74658bc8375278eabf074b4777458376540John McCall IntRange signedRange = GetExprRange(S.Context, signedOperand); 4411f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 4412323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and analyze implicit conversions in the operands. Note 4413323ed74658bc8375278eabf074b4777458376540John McCall // that we skip the implicit conversions on both sides. 4414dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc()); 4415dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc()); 4416ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4417323ed74658bc8375278eabf074b4777458376540John McCall // If the signed range is non-negative, -Wsign-compare won't fire, 4418323ed74658bc8375278eabf074b4777458376540John McCall // but we should still check for comparisons which are always true 4419323ed74658bc8375278eabf074b4777458376540John McCall // or false. 4420323ed74658bc8375278eabf074b4777458376540John McCall if (signedRange.NonNegative) 4421323ed74658bc8375278eabf074b4777458376540John McCall return CheckTrivialUnsignedComparison(S, E); 4422ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4423ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // For (in)equality comparisons, if the unsigned operand is a 4424ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // constant which cannot collide with a overflowed signed operand, 4425ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // then reinterpreting the signed operand as unsigned will not 4426ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // change the result of the comparison. 4427323ed74658bc8375278eabf074b4777458376540John McCall if (E->isEqualityOp()) { 4428323ed74658bc8375278eabf074b4777458376540John McCall unsigned comparisonWidth = S.Context.getIntWidth(T); 4429323ed74658bc8375278eabf074b4777458376540John McCall IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 4430323ed74658bc8375278eabf074b4777458376540John McCall 4431323ed74658bc8375278eabf074b4777458376540John McCall // We should never be unable to prove that the unsigned operand is 4432323ed74658bc8375278eabf074b4777458376540John McCall // non-negative. 4433323ed74658bc8375278eabf074b4777458376540John McCall assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 4434ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 4435323ed74658bc8375278eabf074b4777458376540John McCall if (unsignedRange.Width < comparisonWidth) 4436323ed74658bc8375278eabf074b4777458376540John McCall return; 4437323ed74658bc8375278eabf074b4777458376540John McCall } 4438323ed74658bc8375278eabf074b4777458376540John McCall 44396d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor S.DiagRuntimeBehavior(E->getOperatorLoc(), E, 44406d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor S.PDiag(diag::warn_mixed_sign_comparison) 44416d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor << LHS->getType() << RHS->getType() 44426d3b93d631640125f912339df19b0d2a15af5c9bDouglas Gregor << LHS->getSourceRange() << RHS->getSourceRange()); 4443ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall} 4444ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 444515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield. 444615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// 444715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt. 44480692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 44490692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek SourceLocation InitLoc) { 445015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall assert(Bitfield->isBitField()); 445115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Bitfield->isInvalidDecl()) 445215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 445315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 445491b6014876e9186f968f74a8975ab8fc08ef1b68John McCall // White-list bool bitfields. 445591b6014876e9186f968f74a8975ab8fc08ef1b68John McCall if (Bitfield->getType()->isBooleanType()) 445691b6014876e9186f968f74a8975ab8fc08ef1b68John McCall return false; 445791b6014876e9186f968f74a8975ab8fc08ef1b68John McCall 445846ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor // Ignore value- or type-dependent expressions. 445946ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor if (Bitfield->getBitWidth()->isValueDependent() || 446046ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Bitfield->getBitWidth()->isTypeDependent() || 446146ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isValueDependent() || 446246ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isTypeDependent()) 446346ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor return false; 446446ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor 446515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *OriginalInit = Init->IgnoreParenImpCasts(); 446615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 446780d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith llvm::APSInt Value; 446880d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith if (!OriginalInit->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects)) 446915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 447015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 447115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned OriginalWidth = Value.getBitWidth(); 4472a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context); 447315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 447415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (OriginalWidth <= FieldWidth) 447515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 447615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 44773a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Compute the value which the bitfield will contain. 44789f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad llvm::APSInt TruncatedValue = Value.trunc(FieldWidth); 44793a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman TruncatedValue.setIsSigned(Bitfield->getType()->isSignedIntegerType()); 448015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 44813a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Check whether the stored value is equal to the original value. 44823a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman TruncatedValue = TruncatedValue.extend(OriginalWidth); 4483e1ecdc168175719d74e112bcacd4aae5e12d4631Richard Trieu if (llvm::APSInt::isSameValue(Value, TruncatedValue)) 448415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 448515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 44863a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Special-case bitfields of width 1: booleans are naturally 0/1, and 448734ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman // therefore don't strictly fit into a signed bitfield of width 1. 448834ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman if (FieldWidth == 1 && Value == 1) 44893a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman return false; 44903a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman 449115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyValue = Value.toString(10); 449215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyTrunc = TruncatedValue.toString(10); 449315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 449415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 449515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << PrettyValue << PrettyTrunc << OriginalInit->getType() 449615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << Init->getSourceRange(); 449715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 449815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return true; 449915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 450015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 4501beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy 4502beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations. 45030692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeAssignment(Sema &S, BinaryOperator *E) { 4504beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Just recurse on the LHS. 4505beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 4506beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 4507beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // We want to recurse on the RHS as normal unless we're assigning to 4508beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // a bitfield. 4509beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (FieldDecl *Bitfield = E->getLHS()->getBitField()) { 451015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 451115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc())) { 451215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // Recurse, ignoring any implicit conversions on the RHS. 451315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 451415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc()); 4515beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4516beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4517beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 4518beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 4519beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall} 4520beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 452151313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 45220692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T, 4523c36bedc90c687caa71748480c60707ea4608b092Anna Zaks SourceLocation CContext, unsigned diag, 4524c36bedc90c687caa71748480c60707ea4608b092Anna Zaks bool pruneControlFlow = false) { 4525c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (pruneControlFlow) { 4526c36bedc90c687caa71748480c60707ea4608b092Anna Zaks S.DiagRuntimeBehavior(E->getExprLoc(), E, 4527c36bedc90c687caa71748480c60707ea4608b092Anna Zaks S.PDiag(diag) 4528c36bedc90c687caa71748480c60707ea4608b092Anna Zaks << SourceType << T << E->getSourceRange() 4529c36bedc90c687caa71748480c60707ea4608b092Anna Zaks << SourceRange(CContext)); 4530c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 4531c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 45325a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor S.Diag(E->getExprLoc(), diag) 45335a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor << SourceType << T << E->getSourceRange() << SourceRange(CContext); 45345a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor} 45355a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 4536e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 45370692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType T, 4538c36bedc90c687caa71748480c60707ea4608b092Anna Zaks SourceLocation CContext, unsigned diag, 4539c36bedc90c687caa71748480c60707ea4608b092Anna Zaks bool pruneControlFlow = false) { 4540c36bedc90c687caa71748480c60707ea4608b092Anna Zaks DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow); 4541e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth} 4542e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth 45439ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// Diagnose an implicit cast from a literal expression. Does not warn when the 45449ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// cast wouldn't lose information. 4545f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruthvoid DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T, 4546f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth SourceLocation CContext) { 45479ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay // Try to convert the literal exactly to an integer. If we can, don't warn. 4548f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth bool isExact = false; 45499ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay const llvm::APFloat &Value = FL->getValue(); 45503e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin llvm::APSInt IntegerValue(S.Context.getIntWidth(T), 45513e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin T->hasUnsignedIntegerRepresentation()); 45523e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin if (Value.convertToInteger(IntegerValue, 4553f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth llvm::APFloat::rmTowardZero, &isExact) 45549ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay == llvm::APFloat::opOK && isExact) 4555f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth return; 4556f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 4557be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie SmallString<16> PrettySourceValue; 4558be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie Value.toString(PrettySourceValue); 4559de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie SmallString<16> PrettyTargetValue; 4560be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (T->isSpecificBuiltinType(BuiltinType::Bool)) 4561be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie PrettyTargetValue = IntegerValue == 0 ? "false" : "true"; 4562be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie else 4563de7e7b857c8c6f9dc7fecb18fcb947b003748d16David Blaikie IntegerValue.toString(PrettyTargetValue); 4564be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie 45659ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer) 4566be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie << FL->getType() << T.getUnqualifiedType() << PrettySourceValue 4567be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie << PrettyTargetValue << FL->getSourceRange() << SourceRange(CContext); 4568f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth} 4569f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 4570091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 4571091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Range.Width) return "0"; 4572091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 4573091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt ValueInRange = Value; 4574091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.setIsSigned(!Range.NonNegative); 45759f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad ValueInRange = ValueInRange.trunc(Range.Width); 4576091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return ValueInRange.toString(10); 4577091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall} 4578091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 457988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgstatic bool IsImplicitBoolFloatConversion(Sema &S, Expr *Ex, bool ToBool) { 458088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (!isa<ImplicitCastExpr>(Ex)) 458188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return false; 458288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 458388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *InnerE = Ex->IgnoreParenImpCasts(); 458488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *Target = S.Context.getCanonicalType(Ex->getType()).getTypePtr(); 458588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *Source = 458688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg S.Context.getCanonicalType(InnerE->getType()).getTypePtr(); 458788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (Target->isDependentType()) 458888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return false; 458988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 459088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const BuiltinType *FloatCandidateBT = 459188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg dyn_cast<BuiltinType>(ToBool ? Source : Target); 459288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *BoolCandidateType = ToBool ? Target : Source; 459388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 459488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg return (BoolCandidateType->isSpecificBuiltinType(BuiltinType::Bool) && 459588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg FloatCandidateBT && (FloatCandidateBT->isFloatingPoint())); 459688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg} 459788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 459888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborgvoid CheckImplicitArgumentConversions(Sema &S, CallExpr *TheCall, 459988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg SourceLocation CC) { 460088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg unsigned NumArgs = TheCall->getNumArgs(); 460188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg for (unsigned i = 0; i < NumArgs; ++i) { 460288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *CurrA = TheCall->getArg(i); 460388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (!IsImplicitBoolFloatConversion(S, CurrA, true)) 460488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg continue; 460588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 460688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg bool IsSwapped = ((i > 0) && 460788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsImplicitBoolFloatConversion(S, TheCall->getArg(i - 1), false)); 460888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsSwapped |= ((i < (NumArgs - 1)) && 460988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg IsImplicitBoolFloatConversion(S, TheCall->getArg(i + 1), false)); 461088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (IsSwapped) { 461188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Warn on this floating-point to bool conversion. 461288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg DiagnoseImpCast(S, CurrA->IgnoreParenImpCasts(), 461388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CurrA->getType(), CC, 461488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg diag::warn_impcast_floating_point_to_bool); 461588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 461688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 461788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg} 461888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 4619323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T, 4620b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool *ICContext = 0) { 4621323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) return; 462251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4623323ed74658bc8375278eabf074b4777458376540John McCall const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 4624323ed74658bc8375278eabf074b4777458376540John McCall const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 4625323ed74658bc8375278eabf074b4777458376540John McCall if (Source == Target) return; 4626323ed74658bc8375278eabf074b4777458376540John McCall if (Target->isDependentType()) return; 462751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4628108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // If the conversion context location is invalid don't complain. We also 4629108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // don't want to emit a warning if the issue occurs from the expansion of 4630108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // a system macro. The problem is that 'getSpellingLoc()' is slow, so we 4631108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // delay this check as long as possible. Once we detect we are in that 4632108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // scenario, we just return. 4633ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (CC.isInvalid()) 4634b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return; 4635b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 4636f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Diagnose implicit casts to bool. 4637f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (Target->isSpecificBuiltinType(BuiltinType::Bool)) { 4638f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (isa<StringLiteral>(E)) 4639f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Warn on string literal to bool. Checks for string literals in logical 4640f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // expressions, for instances, assert(0 && "error here"), is prevented 4641f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // by a check in AnalyzeImplicitConversions(). 4642f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu return DiagnoseImpCast(S, E, T, CC, 4643f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu diag::warn_impcast_string_literal_to_bool); 4644e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (Source->isFunctionType()) { 4645e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // Warn on function to bool. Checks free functions and static member 4646e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // functions. Weakly imported functions are excluded from the check, 4647e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // since it's common to test their value to check whether the linker 4648e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // found a definition for them. 4649e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames ValueDecl *D = 0; 4650e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (DeclRefExpr* R = dyn_cast<DeclRefExpr>(E)) { 4651e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = R->getDecl(); 4652e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) { 4653e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = M->getMemberDecl(); 4654e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 4655e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames 4656e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (D && !D->isWeak()) { 465726b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu if (FunctionDecl* F = dyn_cast<FunctionDecl>(D)) { 465826b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu S.Diag(E->getExprLoc(), diag::warn_impcast_function_to_bool) 465926b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu << F << E->getSourceRange() << SourceRange(CC); 46602def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_silence) 46612def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion(E->getExprLoc(), "&"); 46622def77399ab3088106a2d61372344f5b7104e1a2David Blaikie QualType ReturnType; 46632def77399ab3088106a2d61372344f5b7104e1a2David Blaikie UnresolvedSet<4> NonTemplateOverloads; 46642def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.isExprCallable(*E, ReturnType, NonTemplateOverloads); 46652def77399ab3088106a2d61372344f5b7104e1a2David Blaikie if (!ReturnType.isNull() 46662def77399ab3088106a2d61372344f5b7104e1a2David Blaikie && ReturnType->isSpecificBuiltinType(BuiltinType::Bool)) 46672def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_call) 46682def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion( 46692def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()), "()"); 467026b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu return; 467126b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu } 4672e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 4673e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 4674f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 467551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 467651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip vector types. 467751313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<VectorType>(Source)) { 4678ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<VectorType>(Target)) { 4679d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4680ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4681b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 4682ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 4683b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner 4684b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // If the vector cast is cast between two vectors of the same size, it is 4685b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // a bitcast, not a conversion. 4686b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target)) 4687b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner return; 468851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 468951313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 469051313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 469151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 469251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 469351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip complex types. 469451313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<ComplexType>(Source)) { 4695ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<ComplexType>(Target)) { 4696d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4697ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4698ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4699b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 4700ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 470151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 470251313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 470351313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 470451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 470551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 470651313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 470751313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 470851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 470951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the source is floating point... 471051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT && SourceBT->isFloatingPoint()) { 471151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...and the target is floating point... 471251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (TargetBT && TargetBT->isFloatingPoint()) { 471351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...then warn if we're dropping FP rank. 471451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 471551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Builtin FP kinds are ordered by increasing FP rank. 471651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT->getKind() > TargetBT->getKind()) { 471751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Don't warn about float constants that are precisely 471851313c39c84407dd6a323be99a8c322bf8d052a9John McCall // representable in the target type. 471951313c39c84407dd6a323be99a8c322bf8d052a9John McCall Expr::EvalResult result; 472051f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, S.Context)) { 472151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Value might be a float, a float vector, or a float complex. 472251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (IsSameFloatAfterCast(result.Val, 4723323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 4724323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 472551313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 472651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 472751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4728d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4729ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4730ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4731b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 473251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 473351313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 473451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 473551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4736ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // If the target is integral, always warn. 4737be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (TargetBT && TargetBT->isInteger()) { 4738d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4739ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4740ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4741a5b9332418f25338f118358e27303cd510d54107Chandler Carruth Expr *InnerE = E->IgnoreParenImpCasts(); 4742634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay // We also want to warn on, e.g., "int i = -1.234" 4743634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE)) 4744634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus) 4745634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay InnerE = UOp->getSubExpr()->IgnoreParenImpCasts(); 4746634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay 4747f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) { 4748f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth DiagnoseFloatingLiteralImpCast(S, FL, T, CC); 4749a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } else { 4750a5b9332418f25338f118358e27303cd510d54107Chandler Carruth DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 4751a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 4752a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 475351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 475488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // If the target is bool, warn if expr is a function or method call. 475588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (Target->isSpecificBuiltinType(BuiltinType::Bool) && 475688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg isa<CallExpr>(E)) { 475788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Check last argument of function call to see if it is an 475888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // implicit cast from a type matching the type the result 475988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // is being cast to. 476088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CallExpr *CEx = cast<CallExpr>(E); 476188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg unsigned NumArgs = CEx->getNumArgs(); 476288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (NumArgs > 0) { 476388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *LastA = CEx->getArg(NumArgs - 1); 476488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg Expr *InnerE = LastA->IgnoreParenImpCasts(); 476588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg const Type *InnerType = 476688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg S.Context.getCanonicalType(InnerE->getType()).getTypePtr(); 476788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (isa<ImplicitCastExpr>(LastA) && (InnerType == Target)) { 476888617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Warn on this floating-point to bool conversion 476988617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg DiagnoseImpCast(S, E, T, CC, 477088617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg diag::warn_impcast_floating_point_to_bool); 477188617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 477288617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 477388617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg } 477451313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 477551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 477651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 47771838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull) 4778b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie == Expr::NPCK_GNUNull) && !Target->isAnyPointerType() 477928a5f0cdfcc927a94c1bda6a225200762df22411David Blaikie && !Target->isBlockPointerType() && !Target->isMemberPointerType()) { 4780b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie SourceLocation Loc = E->getSourceRange().getBegin(); 4781b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie if (Loc.isMacroID()) 4782b1360498b0c0794fd7925f4bdac68ae91ff7493bDavid Blaikie Loc = S.SourceMgr.getImmediateExpansionRange(Loc).first; 47839fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie if (!Loc.isMacroID() || CC.isMacroID()) 47849fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie S.Diag(Loc, diag::warn_impcast_null_pointer_to_integer) 47859fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie << T << clang::SourceRange(CC) 47869fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie << FixItHint::CreateReplacement(Loc, S.getFixItZeroLiteralForType(T)); 47871838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu } 47881838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu 4789b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie if (!Source->isIntegerType() || !Target->isIntegerType()) 4790b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie return; 4791b26331b4ff419b22861b0823daf83bc8f22a6803David Blaikie 4792be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie // TODO: remove this early return once the false positives for constant->bool 4793be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie // in templates, macros, etc, are reduced or removed. 4794be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie if (Target->isSpecificBuiltinType(BuiltinType::Bool)) 4795be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie return; 4796be0ee875d8a91c031a085cbbd73ad9e8dc1aa8ffDavid Blaikie 4797323ed74658bc8375278eabf074b4777458376540John McCall IntRange SourceRange = GetExprRange(S.Context, E); 47981844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 479951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4800f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width > TargetRange.Width) { 4801091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // If the source is a constant, use a default-on diagnostic. 4802091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // TODO: this should happen for bitfield stores, too. 4803091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt Value(32); 4804091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (E->isIntegerConstantExpr(Value, S.Context)) { 4805d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4806ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4807ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4808091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettySourceValue = Value.toString(10); 4809091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 4810091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 48115e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.DiagRuntimeBehavior(E->getExprLoc(), E, 48125e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.PDiag(diag::warn_impcast_integer_precision_constant) 48135e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << PrettySourceValue << PrettyTargetValue 48145e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << E->getType() << T << E->getSourceRange() 48155e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << clang::SourceRange(CC)); 4816091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return; 4817091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall } 4818091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 4819b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // People want to build with -Wshorten-64-to-32 and not -Wconversion. 4820d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4821ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4822ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 482337050841d7b852497b85d5275d9ea92c07ddf059David Blaikie if (TargetRange.Width == 32 && S.Context.getIntWidth(E->getType()) == 64) 4824c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32, 4825c36bedc90c687caa71748480c60707ea4608b092Anna Zaks /* pruneControlFlow */ true); 4826b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 4827323ed74658bc8375278eabf074b4777458376540John McCall } 4828323ed74658bc8375278eabf074b4777458376540John McCall 4829323ed74658bc8375278eabf074b4777458376540John McCall if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 4830323ed74658bc8375278eabf074b4777458376540John McCall (!TargetRange.NonNegative && SourceRange.NonNegative && 4831323ed74658bc8375278eabf074b4777458376540John McCall SourceRange.Width == TargetRange.Width)) { 4832ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4833d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4834ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4835ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4836323ed74658bc8375278eabf074b4777458376540John McCall unsigned DiagID = diag::warn_impcast_integer_sign; 4837323ed74658bc8375278eabf074b4777458376540John McCall 4838323ed74658bc8375278eabf074b4777458376540John McCall // Traditionally, gcc has warned about this under -Wsign-compare. 4839323ed74658bc8375278eabf074b4777458376540John McCall // We also want to warn about it in -Wconversion. 4840323ed74658bc8375278eabf074b4777458376540John McCall // So if -Wconversion is off, use a completely identical diagnostic 4841323ed74658bc8375278eabf074b4777458376540John McCall // in the sign-compare group. 4842323ed74658bc8375278eabf074b4777458376540John McCall // The conditional-checking code will 4843323ed74658bc8375278eabf074b4777458376540John McCall if (ICContext) { 4844323ed74658bc8375278eabf074b4777458376540John McCall DiagID = diag::warn_impcast_integer_sign_conditional; 4845323ed74658bc8375278eabf074b4777458376540John McCall *ICContext = true; 4846323ed74658bc8375278eabf074b4777458376540John McCall } 4847323ed74658bc8375278eabf074b4777458376540John McCall 4848b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, DiagID); 484951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 485051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4851284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor // Diagnose conversions between different enumeration types. 48525a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // In C, we pretend that the type of an EnumConstantDecl is its enumeration 48535a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // type, to give us better diagnostics. 48545a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor QualType SourceType = E->getType(); 48554e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie if (!S.getLangOpts().CPlusPlus) { 48565a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 48575a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) { 48585a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext()); 48595a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceType = S.Context.getTypeDeclType(Enum); 48605a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor Source = S.Context.getCanonicalType(SourceType).getTypePtr(); 48615a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 48625a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 48635a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 4864284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *SourceEnum = Source->getAs<EnumType>()) 4865284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *TargetEnum = Target->getAs<EnumType>()) 4866284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if ((SourceEnum->getDecl()->getIdentifier() || 4867162e1c1b487352434552147967c3dd296ebee2f7Richard Smith SourceEnum->getDecl()->getTypedefNameForAnonDecl()) && 4868284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor (TargetEnum->getDecl()->getIdentifier() || 4869162e1c1b487352434552147967c3dd296ebee2f7Richard Smith TargetEnum->getDecl()->getTypedefNameForAnonDecl()) && 4870ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceEnum != TargetEnum) { 4871d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4872ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4873ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 48745a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor return DiagnoseImpCast(S, E, SourceType, T, CC, 4875284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor diag::warn_impcast_different_enum_types); 4876ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 4877284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor 487851313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 487951313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 488051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 48819fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, 48829fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie SourceLocation CC, QualType T); 4883323ed74658bc8375278eabf074b4777458376540John McCall 4884323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T, 4885b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool &ICContext) { 4886323ed74658bc8375278eabf074b4777458376540John McCall E = E->IgnoreParenImpCasts(); 4887323ed74658bc8375278eabf074b4777458376540John McCall 4888323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) 48899fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie return CheckConditionalOperator(S, cast<ConditionalOperator>(E), CC, T); 4890323ed74658bc8375278eabf074b4777458376540John McCall 4891b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E, CC); 4892323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 4893b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return CheckImplicitConversion(S, E, T, CC, &ICContext); 4894323ed74658bc8375278eabf074b4777458376540John McCall return; 4895323ed74658bc8375278eabf074b4777458376540John McCall} 4896323ed74658bc8375278eabf074b4777458376540John McCall 48979fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikievoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, 48989fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie SourceLocation CC, QualType T) { 4899b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getCond(), CC); 4900323ed74658bc8375278eabf074b4777458376540John McCall 4901323ed74658bc8375278eabf074b4777458376540John McCall bool Suspicious = false; 4902b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 4903b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 4904323ed74658bc8375278eabf074b4777458376540John McCall 4905323ed74658bc8375278eabf074b4777458376540John McCall // If -Wconversion would have warned about either of the candidates 4906323ed74658bc8375278eabf074b4777458376540John McCall // for a signedness conversion to the context type... 4907323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) return; 4908323ed74658bc8375278eabf074b4777458376540John McCall 4909323ed74658bc8375278eabf074b4777458376540John McCall // ...but it's currently ignored... 49100827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional, 49110827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis CC)) 4912323ed74658bc8375278eabf074b4777458376540John McCall return; 4913323ed74658bc8375278eabf074b4777458376540John McCall 4914323ed74658bc8375278eabf074b4777458376540John McCall // ...then check whether it would have warned about either of the 4915323ed74658bc8375278eabf074b4777458376540John McCall // candidates for a signedness conversion to the condition type. 49165254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (E->getType() == T) return; 49175254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu 49185254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu Suspicious = false; 49195254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 49205254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu E->getType(), CC, &Suspicious); 49215254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (!Suspicious) 49225254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 4923b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 4924323ed74658bc8375278eabf074b4777458376540John McCall} 4925323ed74658bc8375278eabf074b4777458376540John McCall 4926323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting 4927323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression. There are a couple 4928323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare. 4929b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 4930323ed74658bc8375278eabf074b4777458376540John McCall QualType T = OrigE->getType(); 4931323ed74658bc8375278eabf074b4777458376540John McCall Expr *E = OrigE->IgnoreParenImpCasts(); 4932323ed74658bc8375278eabf074b4777458376540John McCall 4933f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 4934f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor return; 4935f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor 4936323ed74658bc8375278eabf074b4777458376540John McCall // For conditional operators, we analyze the arguments as if they 4937323ed74658bc8375278eabf074b4777458376540John McCall // were being fed directly into the output. 4938323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) { 4939323ed74658bc8375278eabf074b4777458376540John McCall ConditionalOperator *CO = cast<ConditionalOperator>(E); 49409fb1ac520d1806ba2b069f6087f40fc9c704b067David Blaikie CheckConditionalOperator(S, CO, CC, T); 4941323ed74658bc8375278eabf074b4777458376540John McCall return; 4942323ed74658bc8375278eabf074b4777458376540John McCall } 4943323ed74658bc8375278eabf074b4777458376540John McCall 494488617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg // Check implicit argument conversions for function calls. 494588617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg if (CallExpr *Call = dyn_cast<CallExpr>(E)) 494688617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg CheckImplicitArgumentConversions(S, Call, CC); 494788617a24adafed42e33d196972f97c72d9a5e0a0Hans Wennborg 4948323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and check any implicit conversions we might have skipped. 4949323ed74658bc8375278eabf074b4777458376540John McCall // The non-canonical typecheck is just an optimization; 4950323ed74658bc8375278eabf074b4777458376540John McCall // CheckImplicitConversion will filter out dead implicit conversions. 4951323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 4952b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckImplicitConversion(S, E, T, CC); 4953323ed74658bc8375278eabf074b4777458376540John McCall 4954323ed74658bc8375278eabf074b4777458376540John McCall // Now continue drilling into this expression. 4955323ed74658bc8375278eabf074b4777458376540John McCall 4956323ed74658bc8375278eabf074b4777458376540John McCall // Skip past explicit casts. 4957323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ExplicitCastExpr>(E)) { 4958323ed74658bc8375278eabf074b4777458376540John McCall E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 4959b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return AnalyzeImplicitConversions(S, E, CC); 4960323ed74658bc8375278eabf074b4777458376540John McCall } 4961323ed74658bc8375278eabf074b4777458376540John McCall 4962beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 4963beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Do a somewhat different check with comparison operators. 4964beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isComparisonOp()) 4965beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeComparison(S, BO); 4966beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 49670fa063816818ac53a0015a5d2b0328812005b40eEli Friedman // And with simple assignments. 49680fa063816818ac53a0015a5d2b0328812005b40eEli Friedman if (BO->getOpcode() == BO_Assign) 4969beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeAssignment(S, BO); 4970beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4971323ed74658bc8375278eabf074b4777458376540John McCall 4972323ed74658bc8375278eabf074b4777458376540John McCall // These break the otherwise-useful invariant below. Fortunately, 4973323ed74658bc8375278eabf074b4777458376540John McCall // we don't really need to recurse into them, because any internal 4974323ed74658bc8375278eabf074b4777458376540John McCall // expressions should have been analyzed already when they were 4975323ed74658bc8375278eabf074b4777458376540John McCall // built into statements. 4976323ed74658bc8375278eabf074b4777458376540John McCall if (isa<StmtExpr>(E)) return; 4977323ed74658bc8375278eabf074b4777458376540John McCall 4978323ed74658bc8375278eabf074b4777458376540John McCall // Don't descend into unevaluated contexts. 4979f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne if (isa<UnaryExprOrTypeTraitExpr>(E)) return; 4980323ed74658bc8375278eabf074b4777458376540John McCall 4981323ed74658bc8375278eabf074b4777458376540John McCall // Now just recurse over the expression's children. 4982b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CC = E->getExprLoc(); 4983f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu BinaryOperator *BO = dyn_cast<BinaryOperator>(E); 4984f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu bool IsLogicalOperator = BO && BO->isLogicalOp(); 4985f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu for (Stmt::child_range I = E->children(); I; ++I) { 498654042f1bd78f1f1ea86be7d4af541462e127d2edDouglas Gregor Expr *ChildExpr = dyn_cast_or_null<Expr>(*I); 4987503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor if (!ChildExpr) 4988503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor continue; 4989503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor 4990f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (IsLogicalOperator && 4991f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts())) 4992f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Ignore checking string literals that are in logical operators. 4993f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu continue; 4994f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu AnalyzeImplicitConversions(S, ChildExpr, CC); 4995f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 4996323ed74658bc8375278eabf074b4777458376540John McCall} 4997323ed74658bc8375278eabf074b4777458376540John McCall 4998323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace 4999323ed74658bc8375278eabf074b4777458376540John McCall 5000323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given 5001323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression). Implements -Wconversion 5002323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare. 5003b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// 5004b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e. 5005b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// the most location of the syntactic entity requiring the implicit 5006b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// conversion 5007b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 5008323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose in unevaluated contexts. 500971f55f771794674a410171dbf3cb5dbedf95d033David Blaikie if (isUnevaluatedContext()) 5010323ed74658bc8375278eabf074b4777458376540John McCall return; 5011323ed74658bc8375278eabf074b4777458376540John McCall 5012323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose for value- or type-dependent expressions. 5013323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) 5014323ed74658bc8375278eabf074b4777458376540John McCall return; 5015323ed74658bc8375278eabf074b4777458376540John McCall 5016d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Check for array bounds violations in cases where the check isn't triggered 5017d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // elsewhere for other Expr types (like BinaryOperators), e.g. when an 5018d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // ArraySubscriptExpr is on the RHS of a variable initialization. 5019d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain CheckArrayAccess(E); 5020d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5021b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // This is not the right CC for (e.g.) a variable initialization. 5022b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(*this, E, CC); 5023323ed74658bc8375278eabf074b4777458376540John McCall} 5024323ed74658bc8375278eabf074b4777458376540John McCall 502515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 502615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall FieldDecl *BitField, 502715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *Init) { 502815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 502915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 503015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 5031f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given 5032f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This 5033f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the 5034f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function 5035f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete. 503682aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregorbool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd, 503782aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor bool CheckParameterNames) { 5038f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump bool HasInvalidParm = false; 503982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor for (; P != PEnd; ++P) { 504082aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor ParmVarDecl *Param = *P; 504182aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor 5042f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.7.5.3p4: the parameters in a parameter type list in a 5043f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // function declarator that is part of a function definition of 5044f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // that function shall not have incomplete type. 5045f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // 5046f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // This is also C++ [dcl.fct]p6. 5047f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump if (!Param->isInvalidDecl() && 5048f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump RequireCompleteType(Param->getLocation(), Param->getType(), 5049d10099e5c8238fa0327f03921cf2e3c8975c881eDouglas Gregor diag::err_typecheck_decl_incomplete_type)) { 5050f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Param->setInvalidDecl(); 5051f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump HasInvalidParm = true; 5052f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 5053f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 5054f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.9.1p5: If the declarator includes a parameter type list, the 5055f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // declaration of each parameter shall include an identifier. 505682aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor if (CheckParameterNames && 505782aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor Param->getIdentifier() == 0 && 5058f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !Param->isImplicit() && 50594e4d08403ca5cfd4d558fa2936215d3a4e5a528dDavid Blaikie !getLangOpts().CPlusPlus) 5060f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Diag(Param->getLocation(), diag::err_parameter_name_omitted); 5061d17e340e2d516139931768697bf080f60920ba9dSam Weinig 5062d17e340e2d516139931768697bf080f60920ba9dSam Weinig // C99 6.7.5.3p12: 5063d17e340e2d516139931768697bf080f60920ba9dSam Weinig // If the function declarator is not part of a definition of that 5064d17e340e2d516139931768697bf080f60920ba9dSam Weinig // function, parameters may have incomplete type and may use the [*] 5065d17e340e2d516139931768697bf080f60920ba9dSam Weinig // notation in their sequences of declarator specifiers to specify 5066d17e340e2d516139931768697bf080f60920ba9dSam Weinig // variable length array types. 5067d17e340e2d516139931768697bf080f60920ba9dSam Weinig QualType PType = Param->getOriginalType(); 5068d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (const ArrayType *AT = Context.getAsArrayType(PType)) { 5069d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (AT->getSizeModifier() == ArrayType::Star) { 5070bed28ac1d1463adca3ecf24fca5c30646fa9dbb2Sylvestre Ledru // FIXME: This diagnosic should point the '[*]' if source-location 5071d17e340e2d516139931768697bf080f60920ba9dSam Weinig // information is added for it. 5072d17e340e2d516139931768697bf080f60920ba9dSam Weinig Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 5073d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 5074d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 5075f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 5076f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 5077f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump return HasInvalidParm; 5078f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump} 5079b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5080b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a 5081b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements. 5082b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 5083b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // This is actually a lot of work to potentially be doing on every 5084b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // cast; don't do it if we're ignoring -Wcast_align (as is the default). 50850827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align, 50860827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis TRange.getBegin()) 5087d6471f7c1921c7802804ce3ff6fe9768310f72b9David Blaikie == DiagnosticsEngine::Ignored) 5088b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 5089b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5090b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Ignore dependent types. 5091b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (T->isDependentType() || Op->getType()->isDependentType()) 5092b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 5093b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5094b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the destination be a pointer type. 5095b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *DestPtr = T->getAs<PointerType>(); 5096b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!DestPtr) return; 5097b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5098b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // If the destination has alignment 1, we're done. 5099b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType DestPointee = DestPtr->getPointeeType(); 5100b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestPointee->isIncompleteType()) return; 5101b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 5102b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestAlign.isOne()) return; 5103b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5104b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the source be a pointer type. 5105b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 5106b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!SrcPtr) return; 5107b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType SrcPointee = SrcPtr->getPointeeType(); 5108b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5109b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Whitelist casts from cv void*. We already implicitly 5110b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // whitelisted casts to cv void*, since they have alignment 1. 5111b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Also whitelist casts involving incomplete types, which implicitly 5112b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // includes 'void'. 5113b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcPointee->isIncompleteType()) return; 5114b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5115b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 5116b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcAlign >= DestAlign) return; 5117b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5118b7f4ffe073fa419613946461a2583ba2fcb72280John McCall Diag(TRange.getBegin(), diag::warn_cast_align) 5119b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << Op->getType() << T 5120b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(SrcAlign.getQuantity()) 5121b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(DestAlign.getQuantity()) 5122b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << TRange << Op->getSourceRange(); 5123b7f4ffe073fa419613946461a2583ba2fcb72280John McCall} 5124b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 5125d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainstatic const Type* getElementType(const Expr *BaseExpr) { 5126d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* EltType = BaseExpr->getType().getTypePtr(); 5127d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (EltType->isAnyPointerType()) 5128d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getPointeeType().getTypePtr(); 5129d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain else if (EltType->isArrayType()) 5130d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getBaseElementTypeUnsafe(); 5131d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType; 5132d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain} 5133d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5134c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// \brief Check whether this array fits the idiom of a size-one tail padded 5135c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// array member of a struct. 5136c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// 5137c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// We avoid emitting out-of-bounds access warnings for such arrays as they are 5138c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// commonly used to emulate flexible arrays in C89 code. 5139c268434b332bbe57950d977633369bf5822d9554Chandler Carruthstatic bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size, 5140c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const NamedDecl *ND) { 5141c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (Size != 1 || !ND) return false; 5142c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5143c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const FieldDecl *FD = dyn_cast<FieldDecl>(ND); 5144c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!FD) return false; 5145c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5146c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // Don't consider sizes resulting from macro expansions or template argument 5147c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // substitution to form C89 tail-padded arrays. 5148d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan 5149d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan TypeSourceInfo *TInfo = FD->getTypeSourceInfo(); 515000e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek while (TInfo) { 515100e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek TypeLoc TL = TInfo->getTypeLoc(); 515200e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek // Look through typedefs. 515300e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek const TypedefTypeLoc *TTL = dyn_cast<TypedefTypeLoc>(&TL); 515400e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek if (TTL) { 515500e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek const TypedefNameDecl *TDL = TTL->getTypedefNameDecl(); 515600e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek TInfo = TDL->getTypeSourceInfo(); 515700e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek continue; 515800e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek } 515900e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek ConstantArrayTypeLoc CTL = cast<ConstantArrayTypeLoc>(TL); 516000e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek const Expr *SizeExpr = dyn_cast<IntegerLiteral>(CTL.getSizeExpr()); 5161d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan if (!SizeExpr || SizeExpr->getExprLoc().isMacroID()) 5162d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan return false; 516300e1f6f5fed4f33f67181578be0232accd342282Ted Kremenek break; 5164d2cf348f0df76bf1745f131db2ceeb59f23a7305Sean Callanan } 5165c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5166c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext()); 5167381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!RD) return false; 5168381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (RD->isUnion()) return false; 5169381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) { 5170381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!CRD->isStandardLayout()) return false; 5171381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay } 5172c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 517322d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer // See if this is the last field decl in the record. 517422d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer const Decl *D = FD; 517522d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer while ((D = D->getNextDeclInContext())) 517622d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer if (isa<FieldDecl>(D)) 517722d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return false; 517822d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return true; 5179c268434b332bbe57950d977633369bf5822d9554Chandler Carruth} 5180c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 5181d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainvoid Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr, 518280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const ArraySubscriptExpr *ASE, 518325b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith bool AllowOnePastEnd, bool IndexNegated) { 518492b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman IndexExpr = IndexExpr->IgnoreParenImpCasts(); 518580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (IndexExpr->isValueDependent()) 518680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 5187d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 518880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const Type *EffectiveType = getElementType(BaseExpr); 518980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay BaseExpr = BaseExpr->IgnoreParenCasts(); 51903406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const ConstantArrayType *ArrayTy = 5191d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain Context.getAsConstantArrayType(BaseExpr->getType()); 51923406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (!ArrayTy) 5193a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 519435001ca261f895817916b468379b696d6d45959dChandler Carruth 51953406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth llvm::APSInt index; 519680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!IndexExpr->EvaluateAsInt(index, Context)) 5197a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 519825b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith if (IndexNegated) 519925b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith index = -index; 52008fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek 5201ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth const NamedDecl *ND = NULL; 5202ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 5203ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(DRE->getDecl()); 5204c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 5205ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 5206ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 52079e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek if (index.isUnsigned() || !index.isNegative()) { 520825b3b849e3ad340b04442707038c86980035765bTed Kremenek llvm::APInt size = ArrayTy->getSize(); 520935001ca261f895817916b468379b696d6d45959dChandler Carruth if (!size.isStrictlyPositive()) 521035001ca261f895817916b468379b696d6d45959dChandler Carruth return; 5211d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5212d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* BaseType = getElementType(BaseExpr); 5213de5998f1d7dcecb777257ec932142d65de636eb8Nico Weber if (BaseType != EffectiveType) { 5214d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Make sure we're comparing apples to apples when comparing index to size 5215d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType); 5216d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t array_typesize = Context.getTypeSize(BaseType); 5217d10f4bc5a05ce0cdc1646dbb0f706bb9d3dfc0c5Kaelyn Uhrain // Handle ptrarith_typesize being zero, such as when casting to void* 521818f169770d9d3f826bad8f1359c8c5770c5ab16fKaelyn Uhrain if (!ptrarith_typesize) ptrarith_typesize = 1; 5219d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize != array_typesize) { 5220d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // There's a cast to a different size type involved 5221d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ratio = array_typesize / ptrarith_typesize; 5222d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // TODO: Be smarter about handling cases where array_typesize is not a 5223d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // multiple of ptrarith_typesize 5224d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize * ratio == array_typesize) 5225d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain size *= llvm::APInt(size.getBitWidth(), ratio); 5226d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 5227d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 5228d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 52293406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (size.getBitWidth() > index.getBitWidth()) 523092b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman index = index.zext(size.getBitWidth()); 523125b3b849e3ad340b04442707038c86980035765bTed Kremenek else if (size.getBitWidth() < index.getBitWidth()) 523292b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman size = size.zext(index.getBitWidth()); 523325b3b849e3ad340b04442707038c86980035765bTed Kremenek 5234d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // For array subscripting the index must be less than size, but for pointer 5235d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // arithmetic also allow the index (offset) to be equal to size since 5236d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // computing the next address after the end of the array is legal and 5237d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // commonly done e.g. in C++ iterators and range-based for loops. 523892b670e1ee0b11d7e558ec659795ddf452e583edEli Friedman if (AllowOnePastEnd ? index.ule(size) : index.ult(size)) 5239ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth return; 5240ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 5241ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // Also don't warn for arrays of size 1 which are members of some 5242ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // structure. These are often used to approximate flexible arrays in C89 5243ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // code. 5244d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (IsTailPaddedMemberArray(*this, size, ND)) 52458fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek return; 52463406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth 524780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // Suppress the warning if the subscript expression (as identified by the 524880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // ']' location) and the index expression are both from macro expansions 524980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // within a system header. 525080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) { 525180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation RBracketLoc = SourceMgr.getSpellingLoc( 525280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay ASE->getRBracketLoc()); 525380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isInSystemHeader(RBracketLoc)) { 525480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation IndexLoc = SourceMgr.getSpellingLoc( 525580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay IndexExpr->getLocStart()); 525680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isFromSameFile(RBracketLoc, IndexLoc)) 525780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 525880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 525980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 526080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay 5261d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds; 526280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) 5263d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_array_index_exceeds_bounds; 5264d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5265d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 5266d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 5267d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << size.toString(10, true) 5268d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << (unsigned)size.getLimitedValue(~0U) 5269d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 52703406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth } else { 5271d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_array_index_precedes_bounds; 527280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!ASE) { 5273d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_ptr_arith_precedes_bounds; 5274d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (index.isNegative()) index = -index; 5275d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 5276d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 5277d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 5278d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 5279d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 5280a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek } 528135001ca261f895817916b468379b696d6d45959dChandler Carruth 5282cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (!ND) { 5283cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay // Try harder to find a NamedDecl to point at in the note. 5284cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay while (const ArraySubscriptExpr *ASE = 5285cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay dyn_cast<ArraySubscriptExpr>(BaseExpr)) 5286cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay BaseExpr = ASE->getBase()->IgnoreParenCasts(); 5287cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 5288cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(DRE->getDecl()); 5289cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 5290cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 5291cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay } 5292cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay 529335001ca261f895817916b468379b696d6d45959dChandler Carruth if (ND) 5294d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(ND->getLocStart(), BaseExpr, 5295d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(diag::note_array_index_out_of_bounds) 5296d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << ND->getDeclName()); 52973aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek} 52983aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek 52993aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) { 5300d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain int AllowOnePastEnd = 0; 5301d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain while (expr) { 5302d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = expr->IgnoreParenImpCasts(); 53033aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek switch (expr->getStmtClass()) { 5304d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::ArraySubscriptExprClass: { 5305d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr); 530680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE, 5307d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd > 0); 53083aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 5309d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 5310d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::UnaryOperatorClass: { 5311d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Only unwrap the * and & unary operators 5312d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const UnaryOperator *UO = cast<UnaryOperator>(expr); 5313d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = UO->getSubExpr(); 5314d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain switch (UO->getOpcode()) { 5315d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_AddrOf: 5316d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd++; 5317d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 5318d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_Deref: 5319d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd--; 5320d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 5321d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain default: 5322d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return; 5323d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 5324d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 5325d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 53263aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek case Stmt::ConditionalOperatorClass: { 53273aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek const ConditionalOperator *cond = cast<ConditionalOperator>(expr); 53283aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *lhs = cond->getLHS()) 53293aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(lhs); 53303aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *rhs = cond->getRHS()) 53313aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(rhs); 53323aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 53333aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 53343aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek default: 53353aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 53363aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 5337f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne } 5338a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek} 5339f85e193739c953358c865005855253af4f68a497John McCall 5340f85e193739c953358c865005855253af4f68a497John McCall//===--- CHECK: Objective-C retain cycles ----------------------------------// 5341f85e193739c953358c865005855253af4f68a497John McCall 5342f85e193739c953358c865005855253af4f68a497John McCallnamespace { 5343f85e193739c953358c865005855253af4f68a497John McCall struct RetainCycleOwner { 5344f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner() : Variable(0), Indirect(false) {} 5345f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 5346f85e193739c953358c865005855253af4f68a497John McCall SourceRange Range; 5347f85e193739c953358c865005855253af4f68a497John McCall SourceLocation Loc; 5348f85e193739c953358c865005855253af4f68a497John McCall bool Indirect; 5349f85e193739c953358c865005855253af4f68a497John McCall 5350f85e193739c953358c865005855253af4f68a497John McCall void setLocsFrom(Expr *e) { 5351f85e193739c953358c865005855253af4f68a497John McCall Loc = e->getExprLoc(); 5352f85e193739c953358c865005855253af4f68a497John McCall Range = e->getSourceRange(); 5353f85e193739c953358c865005855253af4f68a497John McCall } 5354f85e193739c953358c865005855253af4f68a497John McCall }; 5355f85e193739c953358c865005855253af4f68a497John McCall} 5356f85e193739c953358c865005855253af4f68a497John McCall 5357f85e193739c953358c865005855253af4f68a497John McCall/// Consider whether capturing the given variable can possibly lead to 5358f85e193739c953358c865005855253af4f68a497John McCall/// a retain cycle. 5359f85e193739c953358c865005855253af4f68a497John McCallstatic bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) { 5360f85e193739c953358c865005855253af4f68a497John McCall // In ARC, it's captured strongly iff the variable has __strong 5361f85e193739c953358c865005855253af4f68a497John McCall // lifetime. In MRR, it's captured strongly if the variable is 5362f85e193739c953358c865005855253af4f68a497John McCall // __block and has an appropriate type. 5363f85e193739c953358c865005855253af4f68a497John McCall if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 5364f85e193739c953358c865005855253af4f68a497John McCall return false; 5365f85e193739c953358c865005855253af4f68a497John McCall 5366f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = var; 5367e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose if (ref) 5368e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose owner.setLocsFrom(ref); 5369f85e193739c953358c865005855253af4f68a497John McCall return true; 5370f85e193739c953358c865005855253af4f68a497John McCall} 5371f85e193739c953358c865005855253af4f68a497John McCall 53726e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanianstatic bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) { 5373f85e193739c953358c865005855253af4f68a497John McCall while (true) { 5374f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParens(); 5375f85e193739c953358c865005855253af4f68a497John McCall if (CastExpr *cast = dyn_cast<CastExpr>(e)) { 5376f85e193739c953358c865005855253af4f68a497John McCall switch (cast->getCastKind()) { 5377f85e193739c953358c865005855253af4f68a497John McCall case CK_BitCast: 5378f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueBitCast: 5379f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueToRValue: 538033e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall case CK_ARCReclaimReturnedObject: 5381f85e193739c953358c865005855253af4f68a497John McCall e = cast->getSubExpr(); 5382f85e193739c953358c865005855253af4f68a497John McCall continue; 5383f85e193739c953358c865005855253af4f68a497John McCall 5384f85e193739c953358c865005855253af4f68a497John McCall default: 5385f85e193739c953358c865005855253af4f68a497John McCall return false; 5386f85e193739c953358c865005855253af4f68a497John McCall } 5387f85e193739c953358c865005855253af4f68a497John McCall } 5388f85e193739c953358c865005855253af4f68a497John McCall 5389f85e193739c953358c865005855253af4f68a497John McCall if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) { 5390f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar = ref->getDecl(); 5391f85e193739c953358c865005855253af4f68a497John McCall if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 5392f85e193739c953358c865005855253af4f68a497John McCall return false; 5393f85e193739c953358c865005855253af4f68a497John McCall 5394f85e193739c953358c865005855253af4f68a497John McCall // Try to find a retain cycle in the base. 53956e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(S, ref->getBase(), owner)) 5396f85e193739c953358c865005855253af4f68a497John McCall return false; 5397f85e193739c953358c865005855253af4f68a497John McCall 5398f85e193739c953358c865005855253af4f68a497John McCall if (ref->isFreeIvar()) owner.setLocsFrom(ref); 5399f85e193739c953358c865005855253af4f68a497John McCall owner.Indirect = true; 5400f85e193739c953358c865005855253af4f68a497John McCall return true; 5401f85e193739c953358c865005855253af4f68a497John McCall } 5402f85e193739c953358c865005855253af4f68a497John McCall 5403f85e193739c953358c865005855253af4f68a497John McCall if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) { 5404f85e193739c953358c865005855253af4f68a497John McCall VarDecl *var = dyn_cast<VarDecl>(ref->getDecl()); 5405f85e193739c953358c865005855253af4f68a497John McCall if (!var) return false; 5406f85e193739c953358c865005855253af4f68a497John McCall return considerVariable(var, ref, owner); 5407f85e193739c953358c865005855253af4f68a497John McCall } 5408f85e193739c953358c865005855253af4f68a497John McCall 5409f85e193739c953358c865005855253af4f68a497John McCall if (MemberExpr *member = dyn_cast<MemberExpr>(e)) { 5410f85e193739c953358c865005855253af4f68a497John McCall if (member->isArrow()) return false; 5411f85e193739c953358c865005855253af4f68a497John McCall 5412f85e193739c953358c865005855253af4f68a497John McCall // Don't count this as an indirect ownership. 5413f85e193739c953358c865005855253af4f68a497John McCall e = member->getBase(); 5414f85e193739c953358c865005855253af4f68a497John McCall continue; 5415f85e193739c953358c865005855253af4f68a497John McCall } 5416f85e193739c953358c865005855253af4f68a497John McCall 54174b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) { 54184b9c2d235fb9449e249d74f48ecfec601650de93John McCall // Only pay attention to pseudo-objects on property references. 54194b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyRefExpr *pre 54204b9c2d235fb9449e249d74f48ecfec601650de93John McCall = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm() 54214b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->IgnoreParens()); 54224b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!pre) return false; 54234b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (pre->isImplicitProperty()) return false; 54244b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyDecl *property = pre->getExplicitProperty(); 54254b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!property->isRetaining() && 54264b9c2d235fb9449e249d74f48ecfec601650de93John McCall !(property->getPropertyIvarDecl() && 54274b9c2d235fb9449e249d74f48ecfec601650de93John McCall property->getPropertyIvarDecl()->getType() 54284b9c2d235fb9449e249d74f48ecfec601650de93John McCall .getObjCLifetime() == Qualifiers::OCL_Strong)) 54294b9c2d235fb9449e249d74f48ecfec601650de93John McCall return false; 54304b9c2d235fb9449e249d74f48ecfec601650de93John McCall 54314b9c2d235fb9449e249d74f48ecfec601650de93John McCall owner.Indirect = true; 54326e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (pre->isSuperReceiver()) { 54336e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Variable = S.getCurMethodDecl()->getSelfDecl(); 54346e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!owner.Variable) 54356e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return false; 54366e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Loc = pre->getLocation(); 54376e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Range = pre->getSourceRange(); 54386e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return true; 54396e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian } 54404b9c2d235fb9449e249d74f48ecfec601650de93John McCall e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase()) 54414b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->getSourceExpr()); 54424b9c2d235fb9449e249d74f48ecfec601650de93John McCall continue; 54434b9c2d235fb9449e249d74f48ecfec601650de93John McCall } 54444b9c2d235fb9449e249d74f48ecfec601650de93John McCall 5445f85e193739c953358c865005855253af4f68a497John McCall // Array ivars? 5446f85e193739c953358c865005855253af4f68a497John McCall 5447f85e193739c953358c865005855253af4f68a497John McCall return false; 5448f85e193739c953358c865005855253af4f68a497John McCall } 5449f85e193739c953358c865005855253af4f68a497John McCall} 5450f85e193739c953358c865005855253af4f68a497John McCall 5451f85e193739c953358c865005855253af4f68a497John McCallnamespace { 5452f85e193739c953358c865005855253af4f68a497John McCall struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> { 5453f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor(ASTContext &Context, VarDecl *variable) 5454f85e193739c953358c865005855253af4f68a497John McCall : EvaluatedExprVisitor<FindCaptureVisitor>(Context), 5455f85e193739c953358c865005855253af4f68a497John McCall Variable(variable), Capturer(0) {} 5456f85e193739c953358c865005855253af4f68a497John McCall 5457f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 5458f85e193739c953358c865005855253af4f68a497John McCall Expr *Capturer; 5459f85e193739c953358c865005855253af4f68a497John McCall 5460f85e193739c953358c865005855253af4f68a497John McCall void VisitDeclRefExpr(DeclRefExpr *ref) { 5461f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 5462f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 5463f85e193739c953358c865005855253af4f68a497John McCall } 5464f85e193739c953358c865005855253af4f68a497John McCall 5465f85e193739c953358c865005855253af4f68a497John McCall void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) { 5466f85e193739c953358c865005855253af4f68a497John McCall if (Capturer) return; 5467f85e193739c953358c865005855253af4f68a497John McCall Visit(ref->getBase()); 5468f85e193739c953358c865005855253af4f68a497John McCall if (Capturer && ref->isFreeIvar()) 5469f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 5470f85e193739c953358c865005855253af4f68a497John McCall } 5471f85e193739c953358c865005855253af4f68a497John McCall 5472f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockExpr(BlockExpr *block) { 5473f85e193739c953358c865005855253af4f68a497John McCall // Look inside nested blocks 5474f85e193739c953358c865005855253af4f68a497John McCall if (block->getBlockDecl()->capturesVariable(Variable)) 5475f85e193739c953358c865005855253af4f68a497John McCall Visit(block->getBlockDecl()->getBody()); 5476f85e193739c953358c865005855253af4f68a497John McCall } 54777e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian 54787e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian void VisitOpaqueValueExpr(OpaqueValueExpr *OVE) { 54797e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian if (Capturer) return; 54807e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian if (OVE->getSourceExpr()) 54817e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian Visit(OVE->getSourceExpr()); 54827e2e4c33cdd347d0f3faac3e391245d06fa42811Fariborz Jahanian } 5483f85e193739c953358c865005855253af4f68a497John McCall }; 5484f85e193739c953358c865005855253af4f68a497John McCall} 5485f85e193739c953358c865005855253af4f68a497John McCall 5486f85e193739c953358c865005855253af4f68a497John McCall/// Check whether the given argument is a block which captures a 5487f85e193739c953358c865005855253af4f68a497John McCall/// variable. 5488f85e193739c953358c865005855253af4f68a497John McCallstatic Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) { 5489f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 5490f85e193739c953358c865005855253af4f68a497John McCall 5491f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParenCasts(); 54921fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose 54931fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose // Look through [^{...} copy] and Block_copy(^{...}). 54941fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (ObjCMessageExpr *ME = dyn_cast<ObjCMessageExpr>(e)) { 54951fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose Selector Cmd = ME->getSelector(); 54961fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (Cmd.isUnarySelector() && Cmd.getNameForSlot(0) == "copy") { 54971fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose e = ME->getInstanceReceiver(); 54981fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (!e) 54991fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose return 0; 55001fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose e = e->IgnoreParenCasts(); 55011fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } 55021fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } else if (CallExpr *CE = dyn_cast<CallExpr>(e)) { 55031fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (CE->getNumArgs() == 1) { 55041fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose FunctionDecl *Fn = dyn_cast_or_null<FunctionDecl>(CE->getCalleeDecl()); 55051fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose if (Fn && Fn->getIdentifier()->isStr("_Block_copy")) 55061fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose e = CE->getArg(0)->IgnoreParenCasts(); 55071fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } 55081fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose } 55091fac58a2ff3c56a18765b2c7395ed91ac7b80544Jordan Rose 5510f85e193739c953358c865005855253af4f68a497John McCall BlockExpr *block = dyn_cast<BlockExpr>(e); 5511f85e193739c953358c865005855253af4f68a497John McCall if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable)) 5512f85e193739c953358c865005855253af4f68a497John McCall return 0; 5513f85e193739c953358c865005855253af4f68a497John McCall 5514f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor visitor(S.Context, owner.Variable); 5515f85e193739c953358c865005855253af4f68a497John McCall visitor.Visit(block->getBlockDecl()->getBody()); 5516f85e193739c953358c865005855253af4f68a497John McCall return visitor.Capturer; 5517f85e193739c953358c865005855253af4f68a497John McCall} 5518f85e193739c953358c865005855253af4f68a497John McCall 5519f85e193739c953358c865005855253af4f68a497John McCallstatic void diagnoseRetainCycle(Sema &S, Expr *capturer, 5520f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner &owner) { 5521f85e193739c953358c865005855253af4f68a497John McCall assert(capturer); 5522f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 5523f85e193739c953358c865005855253af4f68a497John McCall 5524f85e193739c953358c865005855253af4f68a497John McCall S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle) 5525f85e193739c953358c865005855253af4f68a497John McCall << owner.Variable << capturer->getSourceRange(); 5526f85e193739c953358c865005855253af4f68a497John McCall S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner) 5527f85e193739c953358c865005855253af4f68a497John McCall << owner.Indirect << owner.Range; 5528f85e193739c953358c865005855253af4f68a497John McCall} 5529f85e193739c953358c865005855253af4f68a497John McCall 5530f85e193739c953358c865005855253af4f68a497John McCall/// Check for a keyword selector that starts with the word 'add' or 5531f85e193739c953358c865005855253af4f68a497John McCall/// 'set'. 5532f85e193739c953358c865005855253af4f68a497John McCallstatic bool isSetterLikeSelector(Selector sel) { 5533f85e193739c953358c865005855253af4f68a497John McCall if (sel.isUnarySelector()) return false; 5534f85e193739c953358c865005855253af4f68a497John McCall 55355f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef str = sel.getNameForSlot(0); 5536f85e193739c953358c865005855253af4f68a497John McCall while (!str.empty() && str.front() == '_') str = str.substr(1); 5537968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (str.startswith("set")) 5538f85e193739c953358c865005855253af4f68a497John McCall str = str.substr(3); 5539968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek else if (str.startswith("add")) { 5540968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek // Specially whitelist 'addOperationWithBlock:'. 5541968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock")) 5542968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek return false; 5543968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek str = str.substr(3); 5544968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek } 5545f85e193739c953358c865005855253af4f68a497John McCall else 5546f85e193739c953358c865005855253af4f68a497John McCall return false; 5547f85e193739c953358c865005855253af4f68a497John McCall 5548f85e193739c953358c865005855253af4f68a497John McCall if (str.empty()) return true; 5549f85e193739c953358c865005855253af4f68a497John McCall return !islower(str.front()); 5550f85e193739c953358c865005855253af4f68a497John McCall} 5551f85e193739c953358c865005855253af4f68a497John McCall 5552f85e193739c953358c865005855253af4f68a497John McCall/// Check a message send to see if it's likely to cause a retain cycle. 5553f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(ObjCMessageExpr *msg) { 5554f85e193739c953358c865005855253af4f68a497John McCall // Only check instance methods whose selector looks like a setter. 5555f85e193739c953358c865005855253af4f68a497John McCall if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector())) 5556f85e193739c953358c865005855253af4f68a497John McCall return; 5557f85e193739c953358c865005855253af4f68a497John McCall 5558f85e193739c953358c865005855253af4f68a497John McCall // Try to find a variable that the receiver is strongly owned by. 5559f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 5560f85e193739c953358c865005855253af4f68a497John McCall if (msg->getReceiverKind() == ObjCMessageExpr::Instance) { 55616e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner)) 5562f85e193739c953358c865005855253af4f68a497John McCall return; 5563f85e193739c953358c865005855253af4f68a497John McCall } else { 5564f85e193739c953358c865005855253af4f68a497John McCall assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance); 5565f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = getCurMethodDecl()->getSelfDecl(); 5566f85e193739c953358c865005855253af4f68a497John McCall owner.Loc = msg->getSuperLoc(); 5567f85e193739c953358c865005855253af4f68a497John McCall owner.Range = msg->getSuperLoc(); 5568f85e193739c953358c865005855253af4f68a497John McCall } 5569f85e193739c953358c865005855253af4f68a497John McCall 5570f85e193739c953358c865005855253af4f68a497John McCall // Check whether the receiver is captured by any of the arguments. 5571f85e193739c953358c865005855253af4f68a497John McCall for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i) 5572f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner)) 5573f85e193739c953358c865005855253af4f68a497John McCall return diagnoseRetainCycle(*this, capturer, owner); 5574f85e193739c953358c865005855253af4f68a497John McCall} 5575f85e193739c953358c865005855253af4f68a497John McCall 5576f85e193739c953358c865005855253af4f68a497John McCall/// Check a property assign to see if it's likely to cause a retain cycle. 5577f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(Expr *receiver, Expr *argument) { 5578f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 55796e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, receiver, owner)) 5580f85e193739c953358c865005855253af4f68a497John McCall return; 5581f85e193739c953358c865005855253af4f68a497John McCall 5582f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, argument, owner)) 5583f85e193739c953358c865005855253af4f68a497John McCall diagnoseRetainCycle(*this, capturer, owner); 5584f85e193739c953358c865005855253af4f68a497John McCall} 5585f85e193739c953358c865005855253af4f68a497John McCall 5586e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rosevoid Sema::checkRetainCycles(VarDecl *Var, Expr *Init) { 5587e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose RetainCycleOwner Owner; 5588e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose if (!considerVariable(Var, /*DeclRefExpr=*/0, Owner)) 5589e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose return; 5590e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose 5591e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose // Because we don't have an expression for the variable, we have to set the 5592e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose // location explicitly here. 5593e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose Owner.Loc = Var->getLocation(); 5594e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose Owner.Range = Var->getSourceRange(); 5595e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose 5596e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose if (Expr *Capturer = findCapturingExpr(*this, Init, Owner)) 5597e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose diagnoseRetainCycle(*this, Capturer, Owner); 5598e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose} 5599e10f4d384f5ae113d72a5193a1332c1930635cccJordan Rose 5600921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianbool Sema::checkUnsafeAssigns(SourceLocation Loc, 5601f85e193739c953358c865005855253af4f68a497John McCall QualType LHS, Expr *RHS) { 5602f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime(); 5603f85e193739c953358c865005855253af4f68a497John McCall if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone) 5604921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return false; 5605921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // strip off any implicit cast added to get to the one arc-specific 5606921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 560733e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 5608f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::warn_arc_retained_assign) 5609bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian << (LT == Qualifiers::OCL_ExplicitNone) << 1 5610f85e193739c953358c865005855253af4f68a497John McCall << RHS->getSourceRange(); 5611921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return true; 5612921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 5613921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 5614921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 5615921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return false; 5616f85e193739c953358c865005855253af4f68a497John McCall} 5617f85e193739c953358c865005855253af4f68a497John McCall 5618921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianvoid Sema::checkUnsafeExprAssigns(SourceLocation Loc, 5619921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Expr *LHS, Expr *RHS) { 562087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian QualType LHSType; 562187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // PropertyRef on LHS type need be directly obtained from 562287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // its declaration as it has a PsuedoType. 562387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian ObjCPropertyRefExpr *PRE 562487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens()); 562587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PRE && !PRE->isImplicitProperty()) { 562687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 562787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PD) 562887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType = PD->getType(); 562987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian } 563087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian 563187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (LHSType.isNull()) 563287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType = LHS->getType(); 5633921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (checkUnsafeAssigns(Loc, LHSType, RHS)) 5634921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 5635921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime(); 5636921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // FIXME. Check for other life times. 5637921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (LT != Qualifiers::OCL_None) 5638921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 5639921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 564087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PRE) { 5641921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (PRE->isImplicitProperty()) 5642921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 5643921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 5644921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (!PD) 5645921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 5646921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 5647921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian unsigned Attributes = PD->getPropertyAttributes(); 564887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) { 564987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // when 'assign' attribute was not explicitly specified 565087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // by user, ignore it and rely on property type itself 565187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // for lifetime info. 565287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten(); 565387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) && 565487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType->isObjCRetainableType()) 565587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian return; 565687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian 5657921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 565833e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 5659921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Diag(Loc, diag::warn_arc_retained_property_assign) 5660921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian << RHS->getSourceRange(); 5661921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 5662921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 5663921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 5664921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 566587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian } 5666bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian else if (Attributes & ObjCPropertyDecl::OBJC_PR_weak) { 5667bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 5668bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian if (cast->getCastKind() == CK_ARCConsumeObject) { 5669bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian Diag(Loc, diag::warn_arc_retained_assign) 5670bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian << 0 << 0<< RHS->getSourceRange(); 5671bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian return; 5672bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian } 5673bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian RHS = cast->getSubExpr(); 5674bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian } 5675bd2e27e8484c1d378c9c9d089f61ff496627f391Fariborz Jahanian } 5676921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 5677921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian} 5678625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5679625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko//===--- CHECK: Empty statement body (-Wempty-body) ---------------------===// 5680625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5681625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkonamespace { 5682625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkobool ShouldDiagnoseEmptyStmtBody(const SourceManager &SourceMgr, 5683625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko SourceLocation StmtLoc, 5684625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *Body) { 5685625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do not warn if the body is a macro that expands to nothing, e.g: 5686625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // 5687625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // #define CALL(x) 5688625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // if (condition) 5689625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // CALL(0); 5690625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // 5691625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (Body->hasLeadingEmptyMacro()) 5692625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 5693625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5694625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Get line numbers of statement and body. 5695625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool StmtLineInvalid; 5696625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned StmtLine = SourceMgr.getSpellingLineNumber(StmtLoc, 5697625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &StmtLineInvalid); 5698625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtLineInvalid) 5699625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 5700625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5701625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool BodyLineInvalid; 5702625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned BodyLine = SourceMgr.getSpellingLineNumber(Body->getSemiLoc(), 5703625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &BodyLineInvalid); 5704625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyLineInvalid) 5705625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 5706625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5707625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Warn if null statement and body are on the same line. 5708625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtLine != BodyLine) 5709625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return false; 5710625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5711625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return true; 5712625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 5713625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} // Unnamed namespace 5714625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5715625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyStmtBody(SourceLocation StmtLoc, 5716625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *Body, 5717625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned DiagID) { 5718625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Since this is a syntactic check, don't emit diagnostic for template 5719625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // instantiations, this just adds noise. 5720625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (CurrentInstantiationScope) 5721625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5722625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5723625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // The body should be a null statement. 5724625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *NBody = dyn_cast<NullStmt>(Body); 5725625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!NBody) 5726625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5727625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5728625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do the usual checks. 5729625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 5730625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5731625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5732625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), DiagID); 5733625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 5734625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 5735625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5736625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenkovoid Sema::DiagnoseEmptyLoopBody(const Stmt *S, 5737625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *PossibleBody) { 5738625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko assert(!CurrentInstantiationScope); // Ensured by caller 5739625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5740625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko SourceLocation StmtLoc; 5741625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const Stmt *Body; 5742625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned DiagID; 5743625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (const ForStmt *FS = dyn_cast<ForStmt>(S)) { 5744625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko StmtLoc = FS->getRParenLoc(); 5745625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Body = FS->getBody(); 5746625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagID = diag::warn_empty_for_body; 5747625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } else if (const WhileStmt *WS = dyn_cast<WhileStmt>(S)) { 5748625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko StmtLoc = WS->getCond()->getSourceRange().getEnd(); 5749625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Body = WS->getBody(); 5750625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagID = diag::warn_empty_while_body; 5751625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } else 5752625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; // Neither `for' nor `while'. 5753625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5754625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // The body should be a null statement. 5755625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko const NullStmt *NBody = dyn_cast<NullStmt>(Body); 5756625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!NBody) 5757625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5758625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5759625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Skip expensive checks if diagnostic is disabled. 5760625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (Diags.getDiagnosticLevel(DiagID, NBody->getSemiLoc()) == 5761625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko DiagnosticsEngine::Ignored) 5762625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5763625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5764625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // Do the usual checks. 5765625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody)) 5766625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5767625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5768625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // `for(...);' and `while(...);' are popular idioms, so in order to keep 5769625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // noise level low, emit diagnostics only if for/while is followed by a 5770625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // CompoundStmt, e.g.: 5771625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // for (int i = 0; i < n; i++); 5772625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // { 5773625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // a(i); 5774625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // } 5775625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // or if for/while is followed by a statement with more indentation 5776625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // than for/while itself: 5777625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // for (int i = 0; i < n; i++); 5778625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko // a(i); 5779625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool ProbableTypo = isa<CompoundStmt>(PossibleBody); 5780625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (!ProbableTypo) { 5781625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool BodyColInvalid; 5782625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned BodyCol = SourceMgr.getPresumedColumnNumber( 5783625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko PossibleBody->getLocStart(), 5784625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &BodyColInvalid); 5785625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyColInvalid) 5786625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5787625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5788625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko bool StmtColInvalid; 5789625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko unsigned StmtCol = SourceMgr.getPresumedColumnNumber( 5790625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko S->getLocStart(), 5791625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko &StmtColInvalid); 5792625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (StmtColInvalid) 5793625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko return; 5794625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5795625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (BodyCol > StmtCol) 5796625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko ProbableTypo = true; 5797625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } 5798625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko 5799625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko if (ProbableTypo) { 5800625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), DiagID); 5801625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line); 5802625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko } 5803625bb569df0c34feec0d52c0ec5215f21ef2e054Dmitri Gribenko} 58040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- Layout compatibility ----------------------------------------------// 58060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 58080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2); 58100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two enumeration types are layout-compatible. 58120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, EnumDecl *ED1, EnumDecl *ED2) { 58130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [dcl.enum] p8: 58140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Two enumeration types are layout-compatible if they have the same 58150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // underlying type. 58160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return ED1->isComplete() && ED2->isComplete() && 58170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko C.hasSameType(ED1->getIntegerType(), ED2->getIntegerType()); 58180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 58190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two fields are layout-compatible. 58210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, FieldDecl *Field1, FieldDecl *Field2) { 58220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, Field1->getType(), Field2->getType())) 58230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 58240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1->isBitField() != Field2->isBitField()) 58260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 58270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1->isBitField()) { 58290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Make sure that the bit-fields are the same length. 58300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko unsigned Bits1 = Field1->getBitWidthValue(C); 58310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko unsigned Bits2 = Field2->getBitWidthValue(C); 58320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Bits1 != Bits2) 58340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 58350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 58360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 58380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 58390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout structs are layout-compatible. 58410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p17) 58420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleStruct(ASTContext &C, 58430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD1, 58440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD2) { 58450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If both records are C++ classes, check that base classes match. 58460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (const CXXRecordDecl *D1CXX = dyn_cast<CXXRecordDecl>(RD1)) { 58470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If one of records is a CXXRecordDecl we are in C++ mode, 58480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // thus the other one is a CXXRecordDecl, too. 58490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const CXXRecordDecl *D2CXX = cast<CXXRecordDecl>(RD2); 58500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check number of base classes. 58510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (D1CXX->getNumBases() != D2CXX->getNumBases()) 58520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 58530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check the base classes. 58550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (CXXRecordDecl::base_class_const_iterator 58560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base1 = D1CXX->bases_begin(), 58570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BaseEnd1 = D1CXX->bases_end(), 58580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base2 = D2CXX->bases_begin(); 58590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Base1 != BaseEnd1; 58600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ++Base1, ++Base2) { 58610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, Base1->getType(), Base2->getType())) 58620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 58630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 58640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else if (const CXXRecordDecl *D2CXX = dyn_cast<CXXRecordDecl>(RD2)) { 58650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If only RD2 is a C++ class, it should have zero base classes. 58660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (D2CXX->getNumBases() > 0) 58670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 58680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 58690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Check the fields. 58710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl::field_iterator Field2 = RD2->field_begin(), 58720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2End = RD2->field_end(), 58730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1 = RD1->field_begin(), 58740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1End = RD1->field_end(); 58750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for ( ; Field1 != Field1End && Field2 != Field2End; ++Field1, ++Field2) { 58760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!isLayoutCompatible(C, *Field1, *Field2)) 58770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 58780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 58790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Field1 != Field1End || Field2 != Field2End) 58800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 58810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 58830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 58840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two standard-layout unions are layout-compatible. 58860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// (C++11 [class.mem] p18) 58870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatibleUnion(ASTContext &C, 58880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD1, 58890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RecordDecl *RD2) { 58900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::SmallPtrSet<FieldDecl *, 8> UnmatchedFields; 58910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (RecordDecl::field_iterator Field2 = RD2->field_begin(), 58920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2End = RD2->field_end(); 58930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field2 != Field2End; ++Field2) { 58940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko UnmatchedFields.insert(*Field2); 58950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 58960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 58970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (RecordDecl::field_iterator Field1 = RD1->field_begin(), 58980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1End = RD1->field_end(); 58990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Field1 != Field1End; ++Field1) { 59000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::SmallPtrSet<FieldDecl *, 8>::iterator 59010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I = UnmatchedFields.begin(), 59020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko E = UnmatchedFields.end(); 59030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for ( ; I != E; ++I) { 59050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (isLayoutCompatible(C, *Field1, *I)) { 59060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool Result = UnmatchedFields.erase(*I); 59070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (void) Result; 59080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko assert(Result); 59090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko break; 59100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 59110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 59120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I == E) 59130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 59140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 59150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return UnmatchedFields.empty(); 59170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 59180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, RecordDecl *RD1, RecordDecl *RD2) { 59200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (RD1->isUnion() != RD2->isUnion()) 59210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 59220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (RD1->isUnion()) 59240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatibleUnion(C, RD1, RD2); 59250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 59260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatibleStruct(C, RD1, RD2); 59270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 59280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Check if two types are layout-compatible in C++11 sense. 59300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2) { 59310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (T1.isNull() || T2.isNull()) 59320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 59330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [basic.types] p11: 59350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // If two types T1 and T2 are the same type, then T1 and T2 are 59360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // layout-compatible types. 59370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (C.hasSameType(T1, T2)) 59380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 59390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko T1 = T1.getCanonicalType().getUnqualifiedType(); 59410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko T2 = T2.getCanonicalType().getUnqualifiedType(); 59420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Type::TypeClass TC1 = T1->getTypeClass(); 59440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Type::TypeClass TC2 = T2->getTypeClass(); 59450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TC1 != TC2) 59470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 59480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TC1 == Type::Enum) { 59500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatible(C, 59510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<EnumType>(T1)->getDecl(), 59520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<EnumType>(T2)->getDecl()); 59530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else if (TC1 == Type::Record) { 59540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!T1->isStandardLayoutType() || !T2->isStandardLayoutType()) 59550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 59560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return isLayoutCompatible(C, 59580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<RecordType>(T1)->getDecl(), 59590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<RecordType>(T2)->getDecl()); 59600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 59610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 59630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 59640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 59650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko//===--- CHECK: pointer_with_type_tag attribute: datatypes should match ----// 59670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 59690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Given a type tag expression find the type tag itself. 59700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 59710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Type tag expression, as it appears in user's code. 59720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 59730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param VD Declaration of an identifier that appears in a type tag. 59740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 59750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValue Type tag magic value. 59760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool FindTypeTagExpr(const Expr *TypeExpr, const ASTContext &Ctx, 59770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const ValueDecl **VD, uint64_t *MagicValue) { 59780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko while(true) { 59790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeExpr) 59800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 59810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = TypeExpr->IgnoreParenImpCasts()->IgnoreParenCasts(); 59830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko switch (TypeExpr->getStmtClass()) { 59850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::UnaryOperatorClass: { 59860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const UnaryOperator *UO = cast<UnaryOperator>(TypeExpr); 59870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (UO->getOpcode() == UO_AddrOf || UO->getOpcode() == UO_Deref) { 59880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = UO->getSubExpr(); 59890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 59900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 59910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 59920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 59930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 59940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::DeclRefExprClass: { 59950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const DeclRefExpr *DRE = cast<DeclRefExpr>(TypeExpr); 59960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko *VD = DRE->getDecl(); 59970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 59980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 59990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 60000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::IntegerLiteralClass: { 60010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IntegerLiteral *IL = cast<IntegerLiteral>(TypeExpr); 60020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::APInt MagicValueAPInt = IL->getValue(); 60030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (MagicValueAPInt.getActiveBits() <= 64) { 60040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko *MagicValue = MagicValueAPInt.getZExtValue(); 60050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 60060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else 60070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 60080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 60090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 60100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::BinaryConditionalOperatorClass: 60110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::ConditionalOperatorClass: { 60120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const AbstractConditionalOperator *ACO = 60130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko cast<AbstractConditionalOperator>(TypeExpr); 60140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool Result; 60150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (ACO->getCond()->EvaluateAsBooleanCondition(Result, Ctx)) { 60160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (Result) 60170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = ACO->getTrueExpr(); 60180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 60190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = ACO->getFalseExpr(); 60200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 60210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 60220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 60230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 60240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 60250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko case Stmt::BinaryOperatorClass: { 60260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BinaryOperator *BO = cast<BinaryOperator>(TypeExpr); 60270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (BO->getOpcode() == BO_Comma) { 60280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeExpr = BO->getRHS(); 60290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko continue; 60300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 60310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 60320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 60330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 60340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko default: 60350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 60360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 60370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 60380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 60390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 60400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \brief Retrieve the C type corresponding to type tag TypeExpr. 60410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 60420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeExpr Expression that specifies a type tag. 60430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 60440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param MagicValues Registered magic values. 60450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 60460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param FoundWrongKind Set to true if a type tag was found, but of a wrong 60470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// kind. 60480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 60490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \param TypeInfo Information about the corresponding C type. 60500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// 60510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko/// \returns true if the corresponding C type was found. 60520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool GetMatchingCType( 60530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IdentifierInfo *ArgumentKind, 60540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *TypeExpr, const ASTContext &Ctx, 60550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const llvm::DenseMap<Sema::TypeTagMagicValue, 60560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData> *MagicValues, 60570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool &FoundWrongKind, 60580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData &TypeInfo) { 60590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind = false; 60600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 60610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Variable declaration that has type_tag_for_datatype attribute. 60620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const ValueDecl *VD = NULL; 60630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 60640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko uint64_t MagicValue; 60650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 60660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!FindTypeTagExpr(TypeExpr, Ctx, &VD, &MagicValue)) 60670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 60680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 60690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (VD) { 60700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko for (specific_attr_iterator<TypeTagForDatatypeAttr> 60710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I = VD->specific_attr_begin<TypeTagForDatatypeAttr>(), 60720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko E = VD->specific_attr_end<TypeTagForDatatypeAttr>(); 60730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko I != E; ++I) { 60740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I->getArgumentKind() != ArgumentKind) { 60750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind = true; 60760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 60770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 60780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.Type = I->getMatchingCType(); 60790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.LayoutCompatible = I->getLayoutCompatible(); 60800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo.MustBeNull = I->getMustBeNull(); 60810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 60820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 60830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 60840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 60850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 60860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!MagicValues) 60870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 60880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 60890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko llvm::DenseMap<Sema::TypeTagMagicValue, 60900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Sema::TypeTagData>::const_iterator I = 60910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko MagicValues->find(std::make_pair(ArgumentKind, MagicValue)); 60920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (I == MagicValues->end()) 60930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 60940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 60950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeInfo = I->second; 60960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return true; 60970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 60980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace 60990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 61000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::RegisterTypeTagForDatatype(const IdentifierInfo *ArgumentKind, 61010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko uint64_t MagicValue, QualType Type, 61020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool LayoutCompatible, 61030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool MustBeNull) { 61040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeTagForDatatypeMagicValues) 61050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagForDatatypeMagicValues.reset( 61060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko new llvm::DenseMap<TypeTagMagicValue, TypeTagData>); 61070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 61080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagMagicValue Magic(ArgumentKind, MagicValue); 61090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (*TypeTagForDatatypeMagicValues)[Magic] = 61100d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagData(Type, LayoutCompatible, MustBeNull); 61110d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 61120d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 61130d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkonamespace { 61140d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkobool IsSameCharType(QualType T1, QualType T2) { 61150d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BuiltinType *BT1 = T1->getAs<BuiltinType>(); 61160d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!BT1) 61170d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 61180d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 61190d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const BuiltinType *BT2 = T2->getAs<BuiltinType>(); 61200d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!BT2) 61210d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return false; 61220d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 61230d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BuiltinType::Kind T1Kind = BT1->getKind(); 61240d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko BuiltinType::Kind T2Kind = BT2->getKind(); 61250d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 61260d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return (T1Kind == BuiltinType::SChar && T2Kind == BuiltinType::Char_S) || 61270d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::UChar && T2Kind == BuiltinType::Char_U) || 61280d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::Char_U && T2Kind == BuiltinType::UChar) || 61290d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (T1Kind == BuiltinType::Char_S && T2Kind == BuiltinType::SChar); 61300d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 61310d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} // unnamed namespace 61320d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 61330d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenkovoid Sema::CheckArgumentWithTypeTag(const ArgumentWithTypeTagAttr *Attr, 61340d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr * const *ExprArgs) { 61350d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const IdentifierInfo *ArgumentKind = Attr->getArgumentKind(); 61360d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool IsPointerAttr = Attr->getIsPointer(); 61370d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 61380d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *TypeTagExpr = ExprArgs[Attr->getTypeTagIdx()]; 61390d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool FoundWrongKind; 61400d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagData TypeInfo; 61410d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!GetMatchingCType(ArgumentKind, TypeTagExpr, Context, 61420d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko TypeTagForDatatypeMagicValues.get(), 61430d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko FoundWrongKind, TypeInfo)) { 61440d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (FoundWrongKind) 61450d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(TypeTagExpr->getExprLoc(), 61460d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko diag::warn_type_tag_for_datatype_wrong_kind) 61470d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 61480d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 61490d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 61500d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 61510d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko const Expr *ArgumentExpr = ExprArgs[Attr->getArgumentIdx()]; 61520d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) { 61530d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Skip implicit cast of pointer to `void *' (as a function argument). 61540d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(ArgumentExpr)) 61550d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (ICE->getType()->isVoidPointerType()) 61560d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ArgumentExpr = ICE->getSubExpr(); 61570d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 61580d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko QualType ArgumentType = ArgumentExpr->getType(); 61590d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 61600d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Passing a `void*' pointer shouldn't trigger a warning. 61610d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr && ArgumentType->isVoidPointerType()) 61620d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 61630d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 61640d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (TypeInfo.MustBeNull) { 61650d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Type tag with matching void type requires a null pointer. 61660d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!ArgumentExpr->isNullPointerConstant(Context, 61670d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Expr::NPC_ValueDependentIsNotNull)) { 61680d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(ArgumentExpr->getExprLoc(), 61690d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko diag::warn_type_safety_null_pointer_required) 61700d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentKind->getName() 61710d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentExpr->getSourceRange() 61720d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 61730d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 61740d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko return; 61750d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } 61760d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 61770d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko QualType RequiredType = TypeInfo.Type; 61780d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) 61790d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType = Context.getPointerType(RequiredType); 61800d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 61810d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko bool mismatch = false; 61820d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (!TypeInfo.LayoutCompatible) { 61830d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !Context.hasSameType(ArgumentType, RequiredType); 61840d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 61850d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // C++11 [basic.fundamental] p1: 61860d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // Plain char, signed char, and unsigned char are three distinct types. 61870d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // 61880d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // But we treat plain `char' as equivalent to `signed char' or `unsigned 61890d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko // char' depending on the current char signedness mode. 61900d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (mismatch) 61910d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if ((IsPointerAttr && IsSameCharType(ArgumentType->getPointeeType(), 61920d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType->getPointeeType())) || 61930d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko (!IsPointerAttr && IsSameCharType(ArgumentType, RequiredType))) 61940d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = false; 61950d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko } else 61960d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (IsPointerAttr) 61970d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !isLayoutCompatible(Context, 61980d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko ArgumentType->getPointeeType(), 61990d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko RequiredType->getPointeeType()); 62000d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko else 62010d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko mismatch = !isLayoutCompatible(Context, ArgumentType, RequiredType); 62020d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko 62030d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko if (mismatch) 62040d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko Diag(ArgumentExpr->getExprLoc(), diag::warn_type_safety_type_mismatch) 62050d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentType << ArgumentKind->getName() 62060d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeInfo.LayoutCompatible << RequiredType 62070d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << ArgumentExpr->getSourceRange() 62080d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko << TypeTagExpr->getSourceRange(); 62090d5a069f66df09b3308ccfdce84a88170034c657Dmitri Gribenko} 6210