SemaChecking.cpp revision a73cdcbc1dc1ed98c54556c6adcd2b12301759cc
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// The LLVM Compiler Infrastructure 459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source 60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details. 759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump// This file implements extra semantic analysis beyond what is enforced 1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// by the C type system. 1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 155f8d604246976a93a73549b07bbc8ee0b2061b50John McCall#include "clang/Sema/Initialization.h" 16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Sema.h" 172d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 18276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman#include "clang/Sema/Initialization.h" 19781472fe99a120098c631b0cbe33c89f8cef5e70John McCall#include "clang/Sema/ScopeInfo.h" 20826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek#include "clang/Analysis/Analyses/FormatString.h" 2159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h" 22199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h" 23384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 24c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h" 252324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h" 267ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h" 27f85e193739c953358c865005855253af4f68a497John McCall#include "clang/AST/EvaluatedExprVisitor.h" 28f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/DeclObjC.h" 29f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h" 30f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h" 3159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h" 32f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h" 338fe83e1df954d72c0f4ffc15d20a5222ec151c21Benjamin Kramer#include "llvm/ADT/SmallString.h" 34f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h" 353bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h" 36691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher#include "clang/Basic/TargetBuiltins.h" 3726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman#include "clang/Basic/TargetInfo.h" 387da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian#include "clang/Basic/ConvertUTF.h" 39a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits> 4059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang; 41781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema; 4259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 4360800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 4460800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned ByteNo) const { 4508f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner return SL->getLocationOfByte(ByteNo, PP.getSourceManager(), 4608f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner PP.getLangOptions(), PP.getTargetInfo()); 4760800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner} 4860800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 498e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number. 508e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking. Returns true on error. 518e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) { 528e10f3b9cc1db43645bbc2999eb163af8997d468John McCall unsigned argCount = call->getNumArgs(); 538e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount == desiredArgCount) return false; 548e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 558e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount < desiredArgCount) 568e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args) 578e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 588e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getSourceRange(); 598e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 608e10f3b9cc1db43645bbc2999eb163af8997d468John McCall // Highlight all the excess arguments. 618e10f3b9cc1db43645bbc2999eb163af8997d468John McCall SourceRange range(call->getArg(desiredArgCount)->getLocStart(), 628e10f3b9cc1db43645bbc2999eb163af8997d468John McCall call->getArg(argCount - 1)->getLocEnd()); 638e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 648e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args) 658e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 668e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getArg(1)->getSourceRange(); 678e10f3b9cc1db43645bbc2999eb163af8997d468John McCall} 688e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 6977f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge/// CheckBuiltinAnnotationString - Checks that string argument to the builtin 7077f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge/// annotation is a non wide string literal. 7177f68bb90af93b95045fb994e7cd68137adcc132Julien Lerougestatic bool CheckBuiltinAnnotationString(Sema &S, Expr *Arg) { 7277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge Arg = Arg->IgnoreParenCasts(); 7377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 7477f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge if (!Literal || !Literal->isAscii()) { 7577f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge S.Diag(Arg->getLocStart(), diag::err_builtin_annotation_not_string_constant) 7677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge << Arg->getSourceRange(); 7777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return true; 7877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge } 7977f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return false; 8077f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge} 8177f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge 8260d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 83d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 8460d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult TheCallResult(Owned(TheCall)); 852def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor 86946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Find out if any arguments are required to be integer constant expressions. 87946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner unsigned ICEArguments = 0; 88946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ASTContext::GetBuiltinTypeError Error; 89946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 90946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (Error != ASTContext::GE_None) 91946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments = 0; // Don't diagnose previously diagnosed errors. 92946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 93946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // If any arguments are required to be ICE's, check and diagnose. 94946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 95946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Skip arguments not required to be ICE's. 96946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if ((ICEArguments & (1 << ArgNo)) == 0) continue; 97946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 98946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner llvm::APSInt Result; 99946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 100946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner return true; 101946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments &= ~(1 << ArgNo); 102946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner } 103946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 104d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson switch (BuiltinID) { 10530ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin___CFStringMakeConstantString: 106925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner assert(TheCall->getNumArgs() == 1 && 1071b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner "Wrong # arguments to builtin CFStringMakeConstantString"); 108690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner if (CheckObjCString(TheCall->getArg(0))) 1090eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 110d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 11149ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek case Builtin::BI__builtin_stdarg_start: 11230ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin_va_start: 1130eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinVAStart(TheCall)) 1140eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 115d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1161b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreater: 1171b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreaterequal: 1181b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isless: 1191b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessequal: 1201b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessgreater: 1211b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isunordered: 1220eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinUnorderedCompare(TheCall)) 1230eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 124d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 125e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer case Builtin::BI__builtin_fpclassify: 126e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer if (SemaBuiltinFPClassification(TheCall, 6)) 127e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer return ExprError(); 128e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer break; 1299ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isfinite: 1309ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf: 1319ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf_sign: 1329ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnan: 1339ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnormal: 1343b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (SemaBuiltinFPClassification(TheCall, 1)) 1359ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return ExprError(); 1369ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman break; 137d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman case Builtin::BI__builtin_shufflevector: 1380eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return SemaBuiltinShuffleVector(TheCall); 1390eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // TheCall will be freed by the smart pointer here, but that's fine, since 1400eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // SemaBuiltinShuffleVector guts it, but then doesn't release it. 1414493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar case Builtin::BI__builtin_prefetch: 1420eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinPrefetch(TheCall)) 1430eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 144d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 145d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar case Builtin::BI__builtin_object_size: 1460eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinObjectSize(TheCall)) 1470eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 148d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 149d875fed28578835de89cd407e9db4be788596d7cEli Friedman case Builtin::BI__builtin_longjmp: 150d875fed28578835de89cd407e9db4be788596d7cEli Friedman if (SemaBuiltinLongjmp(TheCall)) 151d875fed28578835de89cd407e9db4be788596d7cEli Friedman return ExprError(); 152d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1538e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 1548e10f3b9cc1db43645bbc2999eb163af8997d468John McCall case Builtin::BI__builtin_classify_type: 1558e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1568e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 1578e10f3b9cc1db43645bbc2999eb163af8997d468John McCall break; 15875c29a012793292ff4578015a9113bf086156d7fChris Lattner case Builtin::BI__builtin_constant_p: 1598e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1608e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 16175c29a012793292ff4578015a9113bf086156d7fChris Lattner break; 1625caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: 163a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 164a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 165a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 166a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 167a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 1685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: 169a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 170a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 171a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 172a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 173a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 1745caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: 175a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 176a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 177a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 178a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 179a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 1805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: 181a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 182a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 183a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 184a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 185a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 1865caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: 187a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 188a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 189a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 190a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 191a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 1925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_add_and_fetch: 193a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 194a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 195a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 196a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 197a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 1985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_sub_and_fetch: 199a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 200a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 201a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 202a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 203a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 2045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_and_and_fetch: 205a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 206a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 207a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 208a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 209a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 2105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_or_and_fetch: 211a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 212a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 213a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 214a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 215a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 2165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_xor_and_fetch: 217a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 218a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 219a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 220a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 221a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 2225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 223a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 224a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 225a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 226a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 227a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 2285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 229a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 230a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 231a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 232a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 233a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 2345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_test_and_set: 235a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 236a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 237a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 238a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 239a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 2405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 241a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 242a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 243a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 244a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 245a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 24623aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: 247a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 248a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 249a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 250a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 251a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 252d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return SemaBuiltinAtomicOverloaded(move(TheCallResult)); 253276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_load: 254276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Load); 255276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_store: 256276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Store); 2577a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall case Builtin::BI__atomic_init: 2587a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Init); 259276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_exchange: 260276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Xchg); 261276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_compare_exchange_strong: 262276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), 263276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman AtomicExpr::CmpXchgStrong); 264276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_compare_exchange_weak: 265276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), 266276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman AtomicExpr::CmpXchgWeak); 267276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_add: 268276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Add); 269276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_sub: 270276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Sub); 271276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_and: 272276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::And); 273276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_or: 274276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Or); 275276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_xor: 276276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Xor); 27777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge case Builtin::BI__builtin_annotation: 27877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge if (CheckBuiltinAnnotationString(*this, TheCall->getArg(1))) 27977f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return ExprError(); 28077f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge break; 28126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 28226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 28326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // Since the target specific builtins for each arch overlap, only check those 28426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // of the arch we are compiling for. 28526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (BuiltinID >= Builtin::FirstTSBuiltin) { 286bcfd1f55bfbb3e5944cd5e03d07b343e280838c4Douglas Gregor switch (Context.getTargetInfo().getTriple().getArch()) { 28726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::arm: 28826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::thumb: 28926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 29026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return ExprError(); 29126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 29226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman default: 29326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 29426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 29526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 29626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 29726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return move(TheCallResult); 29826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman} 29926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 30061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code. 30161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) { 302da95f73b59f9af964e33725c515139d34c90c863Bob Wilson NeonTypeFlags Type(t); 303da95f73b59f9af964e33725c515139d34c90c863Bob Wilson int IsQuad = Type.isQuad(); 304da95f73b59f9af964e33725c515139d34c90c863Bob Wilson switch (Type.getEltType()) { 305da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int8: 306da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly8: 307da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 7 : (8 << IsQuad) - 1; 308da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int16: 309da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Poly16: 310da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 15 : (4 << IsQuad) - 1; 311da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int32: 312da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 31 : (2 << IsQuad) - 1; 313da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Int64: 314da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return shift ? 63 : (1 << IsQuad) - 1; 315da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float16: 316da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 317da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (4 << IsQuad) - 1; 318da95f73b59f9af964e33725c515139d34c90c863Bob Wilson case NeonTypeFlags::Float32: 319da95f73b59f9af964e33725c515139d34c90c863Bob Wilson assert(!shift && "cannot shift float types!"); 320da95f73b59f9af964e33725c515139d34c90c863Bob Wilson return (2 << IsQuad) - 1; 32161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman } 3227530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie llvm_unreachable("Invalid NeonTypeFlag!"); 32361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman} 32461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 3256f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// getNeonEltType - Return the QualType corresponding to the elements of 3266f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the vector type specified by the NeonTypeFlags. This is used to check 3276f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson/// the pointer arguments for Neon load/store intrinsics. 3286f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilsonstatic QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context) { 3296f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson switch (Flags.getEltType()) { 3306f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int8: 3316f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy; 3326f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int16: 3336f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy; 3346f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int32: 3356f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy; 3366f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Int64: 3376f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Flags.isUnsigned() ? Context.UnsignedLongLongTy : Context.LongLongTy; 3386f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly8: 3396f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.SignedCharTy; 3406f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Poly16: 3416f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.ShortTy; 3426f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float16: 3436f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.UnsignedShortTy; 3446f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson case NeonTypeFlags::Float32: 3456f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson return Context.FloatTy; 3466f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 3477530c034c0c71a64c5a9173206d9742ae847af8bDavid Blaikie llvm_unreachable("Invalid NeonTypeFlag!"); 3486f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson} 3496f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 35026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 3511c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman llvm::APSInt Result; 3521c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 3530d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned mask = 0; 35461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned TV = 0; 3554648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson int PtrArgNum = -1; 3566f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson bool HasConstPtr = false; 3571c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman switch (BuiltinID) { 358a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK 359a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 360a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK 3611c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman } 3621c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 3630d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which are overloaded on vector element type, validate 3640d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // the immediate which specifies which variant to emit. 3656f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson unsigned ImmArg = TheCall->getNumArgs()-1; 3660d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (mask) { 3676f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson if (SemaBuiltinConstantArg(TheCall, ImmArg, Result)) 3680d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 3690d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 370da95f73b59f9af964e33725c515139d34c90c863Bob Wilson TV = Result.getLimitedValue(64); 371da95f73b59f9af964e33725c515139d34c90c863Bob Wilson if ((TV > 63) || (mask & (1 << TV)) == 0) 3720d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 3736f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson << TheCall->getArg(ImmArg)->getSourceRange(); 3746f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson } 3756f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson 3764648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (PtrArgNum >= 0) { 3776f9f03ef370ad48ece0c5d10edda28f39ccadb5dBob Wilson // Check that pointer arguments have the specified type. 3784648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Expr *Arg = TheCall->getArg(PtrArgNum); 3794648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) 3804648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson Arg = ICE->getSubExpr(); 3814648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg); 3824648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType RHSTy = RHS.get()->getType(); 3834648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType EltTy = getNeonEltType(NeonTypeFlags(TV), Context); 3844648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (HasConstPtr) 3854648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson EltTy = EltTy.withConst(); 3864648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson QualType LHSTy = Context.getPointerType(EltTy); 3874648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson AssignConvertType ConvTy; 3884648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS); 3894648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (RHS.isInvalid()) 3904648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 3914648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy, 3924648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson RHS.get(), AA_Assigning)) 3934648255cebd2fc7c18293c1f93afd6e9add9ccccBob Wilson return true; 3940d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman } 3951c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 3960d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which take an immediate value as part of the 3970d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // instruction, range check them here. 39861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned i = 0, l = 0, u = 0; 3990d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman switch (BuiltinID) { 4000d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman default: return false; 401bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 402bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 40399c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_f: 40499c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 405a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK 406a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 407a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK 4080d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman }; 4090d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 41061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Check that the immediate argument is actually a constant. 4110d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, i, Result)) 4120d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 4130d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 41461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Range check against the upper/lower values for this isntruction. 4150d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned Val = Result.getZExtValue(); 41661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if (Val < l || Val > (u + l)) 4170d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 418476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer << l << u+l << TheCall->getArg(i)->getSourceRange(); 4190d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 42099c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman // FIXME: VFP Intrinsics should error if VFP not present. 42126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return false; 422d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson} 423d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 424d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// CheckFunctionCall - Check a direct function call for various correctness 425d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// and safety properties not strictly enforced by the C type system. 426d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) { 427d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // Get the IdentifierInfo* for the called function. 428d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson IdentifierInfo *FnInfo = FDecl->getIdentifier(); 429de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 430d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // None of the checks below are needed for functions that don't have 431d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // simple names (e.g., C++ conversion functions). 432d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson if (!FnInfo) 433d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 4341eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 435de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // FIXME: This mechanism should be abstracted to be less fragile and 436de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // more efficient. For example, just map function ids to custom 437de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // handlers. 438de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 439c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek // Printf and scanf checking. 440c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<FormatAttr> 441c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<FormatAttr>(), 442c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<FormatAttr>(); i != e ; ++i) { 44329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas CheckFormatArguments(*i, TheCall); 44459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner } 4451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 446c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<NonNullAttr> 447c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<NonNullAttr>(), 448c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<NonNullAttr>(); i != e; ++i) { 449909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky CheckNonNullArguments(*i, TheCall->getArgs(), 450909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky TheCall->getCallee()->getLocStart()); 451c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek } 4520eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 4530a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned CMId = FDecl->getMemoryFunctionKind(); 4540a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == 0) 455d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks return false; 456bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 457d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks // Handle memory setting and copying functions. 4580a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat) 459bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CheckStrlcpycatArguments(TheCall, FnInfo); 460c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (CMId == Builtin::BIstrncat) 461c36bedc90c687caa71748480c60707ea4608b092Anna Zaks CheckStrncatArguments(TheCall, FnInfo); 462d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks else 4630a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks CheckMemaccessArguments(TheCall, CMId, FnInfo); 4647ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 465d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 46671993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson} 46771993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 46829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupasbool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac, 46929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **Args, unsigned NumArgs) { 47029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas for (specific_attr_iterator<FormatAttr> 47129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas i = Method->specific_attr_begin<FormatAttr>(), 47229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas e = Method->specific_attr_end<FormatAttr>(); i != e ; ++i) { 47329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 47429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas CheckFormatArguments(*i, Args, NumArgs, false, lbrac, 47529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Method->getSourceRange()); 47629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas } 47729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 47829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas // diagnose nonnull arguments. 47929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas for (specific_attr_iterator<NonNullAttr> 48029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas i = Method->specific_attr_begin<NonNullAttr>(), 48129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas e = Method->specific_attr_end<NonNullAttr>(); i != e; ++i) { 48229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas CheckNonNullArguments(*i, Args, lbrac); 48329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas } 48429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 48529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return false; 48629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 48729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 488d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) { 489725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian const VarDecl *V = dyn_cast<VarDecl>(NDecl); 490725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!V) 491d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 4921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 493725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian QualType Ty = V->getType(); 494725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Ty->isBlockPointerType()) 495d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 4961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 49743d1251a471d19ce83aa8ce91c0104addada5addJean-Daniel Dupas // format string checking. 49843d1251a471d19ce83aa8ce91c0104addada5addJean-Daniel Dupas for (specific_attr_iterator<FormatAttr> 49943d1251a471d19ce83aa8ce91c0104addada5addJean-Daniel Dupas i = NDecl->specific_attr_begin<FormatAttr>(), 50043d1251a471d19ce83aa8ce91c0104addada5addJean-Daniel Dupas e = NDecl->specific_attr_end<FormatAttr>(); i != e ; ++i) { 50143d1251a471d19ce83aa8ce91c0104addada5addJean-Daniel Dupas CheckFormatArguments(*i, TheCall); 50243d1251a471d19ce83aa8ce91c0104addada5addJean-Daniel Dupas } 503d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 504d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 505725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian} 506725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian 507276b061970939293f1abaf694bd3ef05b2cbda79Eli FriedmanExprResult 508276b061970939293f1abaf694bd3ef05b2cbda79Eli FriedmanSema::SemaAtomicOpsOverloaded(ExprResult TheCallResult, AtomicExpr::AtomicOp Op) { 509276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman CallExpr *TheCall = cast<CallExpr>(TheCallResult.get()); 510276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 511276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 512276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // All these operations take one of the following four forms: 513276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // T __atomic_load(_Atomic(T)*, int) (loads) 514276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // T* __atomic_add(_Atomic(T*)*, ptrdiff_t, int) (pointer add/sub) 515276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // int __atomic_compare_exchange_strong(_Atomic(T)*, T*, T, int, int) 516276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // (cmpxchg) 517276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // T __atomic_exchange(_Atomic(T)*, T, int) (everything else) 518276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // where T is an appropriate type, and the int paremeterss are for orderings. 519276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman unsigned NumVals = 1; 520276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman unsigned NumOrders = 1; 521276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Op == AtomicExpr::Load) { 522276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman NumVals = 0; 523276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else if (Op == AtomicExpr::CmpXchgWeak || Op == AtomicExpr::CmpXchgStrong) { 524276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman NumVals = 2; 525276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman NumOrders = 2; 526276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 5277a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall if (Op == AtomicExpr::Init) 5287a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall NumOrders = 0; 529276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 530276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (TheCall->getNumArgs() < NumVals+NumOrders+1) { 531276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 532276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << 0 << NumVals+NumOrders+1 << TheCall->getNumArgs() 533276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 534276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 535276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else if (TheCall->getNumArgs() > NumVals+NumOrders+1) { 536276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(TheCall->getArg(NumVals+NumOrders+1)->getLocStart(), 537276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman diag::err_typecheck_call_too_many_args) 538276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << 0 << NumVals+NumOrders+1 << TheCall->getNumArgs() 539276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 540276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 541276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 542276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 543276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // Inspect the first argument of the atomic operation. This should always be 544276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // a pointer to an _Atomic type. 545dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman Expr *Ptr = TheCall->getArg(0); 546276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get(); 547276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman const PointerType *pointerType = Ptr->getType()->getAs<PointerType>(); 548276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!pointerType) { 549276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic) 550276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 551276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 552276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 553276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 554276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType AtomTy = pointerType->getPointeeType(); 555276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!AtomTy->isAtomicType()) { 556276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic) 557276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 558276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 559276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 560276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType ValType = AtomTy->getAs<AtomicType>()->getValueType(); 561276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 562276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if ((Op == AtomicExpr::Add || Op == AtomicExpr::Sub) && 563276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman !ValType->isIntegerType() && !ValType->isPointerType()) { 564276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 565276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 566276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 567276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 568276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 569276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!ValType->isIntegerType() && 570276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman (Op == AtomicExpr::And || Op == AtomicExpr::Or || Op == AtomicExpr::Xor)){ 571276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_logical_needs_atomic_int) 572276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 573276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 574276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 575276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 576276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman switch (ValType.getObjCLifetime()) { 577276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_None: 578276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_ExplicitNone: 579276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // okay 580276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman break; 581276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 582276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Weak: 583276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Strong: 584276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Autoreleasing: 585276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 586276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << ValType << Ptr->getSourceRange(); 587276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 588276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 589276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 590276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType ResultType = ValType; 5917a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall if (Op == AtomicExpr::Store || Op == AtomicExpr::Init) 592276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.VoidTy; 593276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman else if (Op == AtomicExpr::CmpXchgWeak || Op == AtomicExpr::CmpXchgStrong) 594276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.BoolTy; 595276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 596276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The first argument --- the pointer --- has a fixed type; we 597276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // deduce the types of the rest of the arguments accordingly. Walk 598276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // the remaining arguments, converting them to the deduced value type. 599276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman for (unsigned i = 1; i != NumVals+NumOrders+1; ++i) { 600276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ExprResult Arg = TheCall->getArg(i); 601276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType Ty; 602276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (i < NumVals+1) { 603276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The second argument to a cmpxchg is a pointer to the data which will 604276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // be exchanged. The second argument to a pointer add/subtract is the 605276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // amount to add/subtract, which must be a ptrdiff_t. The third 606276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // argument to a cmpxchg and the second argument in all other cases 607276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // is the type of the value. 608276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (i == 1 && (Op == AtomicExpr::CmpXchgWeak || 609276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Op == AtomicExpr::CmpXchgStrong)) 610276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.getPointerType(ValType.getUnqualifiedType()); 611276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman else if (!ValType->isIntegerType() && 612276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman (Op == AtomicExpr::Add || Op == AtomicExpr::Sub)) 613276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.getPointerDiffType(); 614276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman else 615276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = ValType; 616276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else { 617276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The order(s) are always converted to int. 618276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.IntTy; 619276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 620276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity Entity = 621276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity::InitializeParameter(Context, Ty, false); 622276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 623276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Arg.isInvalid()) 624276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return true; 625276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman TheCall->setArg(i, Arg.get()); 626276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 627276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 628dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SmallVector<Expr*, 5> SubExprs; 629dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(Ptr); 630276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Op == AtomicExpr::Load) { 631dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Order 6327a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall } else if (Op == AtomicExpr::Init) { 6337a7ee3033e44b45630981355460ef89efa0bdcc4David Chisnall SubExprs.push_back(TheCall->getArg(1)); // Val1 634276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else if (Op != AtomicExpr::CmpXchgWeak && Op != AtomicExpr::CmpXchgStrong) { 635dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(2)); // Order 636dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 637276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else { 638dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(3)); // Order 639dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 640dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(2)); // Val2 641dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(4)); // OrderFail 642276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 643dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman 644dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman return Owned(new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(), 645dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.data(), SubExprs.size(), 646dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman ResultType, Op, 647dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman TheCall->getRParenLoc())); 648276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman} 649276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 650276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 6515f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// checkBuiltinArgument - Given a call to a builtin function, perform 6525f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// normal type-checking on the given argument, updating the call in 6535f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// place. This is useful when a builtin function requires custom 6545f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// type-checking for some of its arguments but not necessarily all of 6555f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// them. 6565f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// 6575f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// Returns true on error. 6585f8d604246976a93a73549b07bbc8ee0b2061b50John McCallstatic bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) { 6595f8d604246976a93a73549b07bbc8ee0b2061b50John McCall FunctionDecl *Fn = E->getDirectCallee(); 6605f8d604246976a93a73549b07bbc8ee0b2061b50John McCall assert(Fn && "builtin call without direct callee!"); 6615f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 6625f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ParmVarDecl *Param = Fn->getParamDecl(ArgIndex); 6635f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity Entity = 6645f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity::InitializeParameter(S.Context, Param); 6655f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 6665f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ExprResult Arg = E->getArg(0); 6675f8d604246976a93a73549b07bbc8ee0b2061b50John McCall Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg); 6685f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (Arg.isInvalid()) 6695f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 6705f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 6715f8d604246976a93a73549b07bbc8ee0b2061b50John McCall E->setArg(ArgIndex, Arg.take()); 6725f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return false; 6735f8d604246976a93a73549b07bbc8ee0b2061b50John McCall} 6745f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 6755caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like 6765caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer 6775caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument. The main ActOnCallExpr routines have already 6785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as 6795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...). 6805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// 6815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these 6825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins, 68360d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 68460d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 685d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 6865caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 6875caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 6885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 6895caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Ensure that we have at least one argument to do type inference from. 690d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1) { 691d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 692d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1 << TheCall->getNumArgs() 693d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 694d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 695d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 6961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 6975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Inspect the first argument of the atomic builtin. This should always be 6985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // a pointer type, whose element is an integral scalar or pointer type. 6995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Because it is a pointer type, we don't have to worry about any implicit 7005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // casts here. 701d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth // FIXME: We don't allow floating point scalars as input. 7025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *FirstArg = TheCall->getArg(0); 7038c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg); 7048c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman if (FirstArgResult.isInvalid()) 7058c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman return ExprError(); 7068c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman FirstArg = FirstArgResult.take(); 7078c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman TheCall->setArg(0, FirstArg); 7088c382060c9e6668a94f1485dd16f012cda526c5fEli Friedman 709f85e193739c953358c865005855253af4f68a497John McCall const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>(); 710f85e193739c953358c865005855253af4f68a497John McCall if (!pointerType) { 711d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 712d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 713d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 714d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 7151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 716f85e193739c953358c865005855253af4f68a497John McCall QualType ValType = pointerType->getPointeeType(); 717dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 718d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth !ValType->isBlockPointerType()) { 719d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 720d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 721d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 722d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 7235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 724f85e193739c953358c865005855253af4f68a497John McCall switch (ValType.getObjCLifetime()) { 725f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 726f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 727f85e193739c953358c865005855253af4f68a497John McCall // okay 728f85e193739c953358c865005855253af4f68a497John McCall break; 729f85e193739c953358c865005855253af4f68a497John McCall 730f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 731f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 732f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 733b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 734f85e193739c953358c865005855253af4f68a497John McCall << ValType << FirstArg->getSourceRange(); 735f85e193739c953358c865005855253af4f68a497John McCall return ExprError(); 736f85e193739c953358c865005855253af4f68a497John McCall } 737f85e193739c953358c865005855253af4f68a497John McCall 738b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Strip any qualifiers off ValType. 739b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType = ValType.getUnqualifiedType(); 740b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall 7418d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // The majority of builtins return a value, but a few have special return 7428d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // types, so allow them to override appropriately below. 7438d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth QualType ResultType = ValType; 7448d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth 7455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // We need to figure out which concrete builtin this maps onto. For example, 7465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add with a 2 byte object turns into 7475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add_2. 7485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \ 7495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 7505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Builtin::BI##x##_8, Builtin::BI##x##_16 } 7511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner static const unsigned BuiltinIndices[][5] = { 7535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_add), 7545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_sub), 7555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_or), 7565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_and), 7575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_xor), 7581eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_add_and_fetch), 7605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_sub_and_fetch), 7615caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_and_and_fetch), 7625caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_or_and_fetch), 7635caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_xor_and_fetch), 7641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7655caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_val_compare_and_swap), 7665caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_bool_compare_and_swap), 7675caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_test_and_set), 76823aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_lock_release), 76923aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_swap) 7705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner }; 7711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW 7721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7735caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Determine the index of the size. 7745caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned SizeIndex; 775199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 7765caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 1: SizeIndex = 0; break; 7775caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 2: SizeIndex = 1; break; 7785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 4: SizeIndex = 2; break; 7795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 8: SizeIndex = 3; break; 7805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 16: SizeIndex = 4; break; 7815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: 782d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 783d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 784d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 7855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 7861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7875caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Each of these builtins has one pointer argument, followed by some number of 7885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // values (0, 1 or 2) followed by a potentially empty varags list of stuff 7895caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // that we ignore. Find out which row of BuiltinIndices to read from as well 7905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // as the number of fixed args. 7917814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor unsigned BuiltinID = FDecl->getBuiltinID(); 7925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned BuiltinIndex, NumFixed = 1; 7935caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner switch (BuiltinID) { 794b219cfc4d75f0a03630b7c4509ef791b7e97b2c8David Blaikie default: llvm_unreachable("Unknown overloaded atomic builtin!"); 795a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add: 796a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_1: 797a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_2: 798a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_4: 799a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_8: 800a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_add_16: 801a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 0; 802a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 803a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 804a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub: 805a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_1: 806a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_2: 807a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_4: 808a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_8: 809a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_sub_16: 810a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 1; 811a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 812a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 813a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or: 814a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_1: 815a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_2: 816a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_4: 817a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_8: 818a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_or_16: 819a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 2; 820a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 821a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 822a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and: 823a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_1: 824a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_2: 825a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_4: 826a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_8: 827a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_and_16: 828a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 3; 829a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 830a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 831a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor: 832a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_1: 833a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_2: 834a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_4: 835a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_8: 836a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_fetch_and_xor_16: 837a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 4; 838a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 839a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 840a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch: 841a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_1: 842a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_2: 843a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_4: 844a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_8: 845a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_add_and_fetch_16: 846a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 5; 847a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 848a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 849a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch: 850a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_1: 851a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_2: 852a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_4: 853a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_8: 854a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_sub_and_fetch_16: 855a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 6; 856a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 857a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 858a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch: 859a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_1: 860a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_2: 861a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_4: 862a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_8: 863a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_and_and_fetch_16: 864a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 7; 865a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 866a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 867a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch: 868a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_1: 869a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_2: 870a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_4: 871a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_8: 872a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_or_and_fetch_16: 873a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 8; 874a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 875a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 876a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch: 877a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_1: 878a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_2: 879a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_4: 880a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_8: 881a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_xor_and_fetch_16: 882a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 9; 883a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 8841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 886a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_1: 887a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_2: 888a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_4: 889a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_8: 890a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_val_compare_and_swap_16: 8917eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 10; 8925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 8935caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 894a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 8955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 896a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_1: 897a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_2: 898a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_4: 899a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_8: 900a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_bool_compare_and_swap_16: 9017eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 11; 9025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 9038d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.BoolTy; 9045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 905a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 906a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set: 907a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_1: 908a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_2: 909a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_4: 910a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_8: 911a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_test_and_set_16: 912a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 12; 913a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 914a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 9155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 916a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_1: 917a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_2: 918a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_4: 919a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_8: 920a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_lock_release_16: 9217eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 13; 9225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 0; 9238d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.VoidTy; 9245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 925a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor 926a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap: 927a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_1: 928a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_2: 929a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_4: 930a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_8: 931a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor case Builtin::BI__sync_swap_16: 932a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor BuiltinIndex = 14; 933a9766411aaaa1446a5da96dc5042de8da05d89bdDouglas Gregor break; 9345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 9351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Now that we know how many fixed arguments we expect, first check that we 9375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // have at least that many. 938d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1+NumFixed) { 939d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 940d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1+NumFixed << TheCall->getNumArgs() 941d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 942d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 943d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 9441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 945e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // Get the decl for the concrete builtin from this, we can tell what the 946e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // concrete integer type we should convert to is. 947e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 948e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 949e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName); 9501eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump FunctionDecl *NewBuiltinDecl = 951e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID, 952e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner TUScope, false, DRE->getLocStart())); 953d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 954f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // The first argument --- the pointer --- has a fixed type; we 955f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // deduce the types of the rest of the arguments accordingly. Walk 956f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // the remaining arguments, converting them to the deduced value type. 9575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner for (unsigned i = 0; i != NumFixed; ++i) { 958429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult Arg = TheCall->getArg(i+1); 9591eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // GCC does an implicit conversion to the pointer or integer ValType. This 9615caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // can fail in some cases (1i -> int**), check for this error case now. 962b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Initialize the argument. 963b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall InitializedEntity Entity = InitializedEntity::InitializeParameter(Context, 964b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType, /*consume*/ false); 965b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 966429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (Arg.isInvalid()) 967d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 9681eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9695caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Okay, we have something that *can* be converted to the right type. Check 9705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // to see if there is a potentially weird extension going on here. This can 9715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // happen when you do an atomic operation on something like an char* and 9725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // pass in 42. The 42 gets converted to char. This is even more strange 9735caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // for things like 45.123 -> char, etc. 9741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // FIXME: Do this check. 975b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall TheCall->setArg(i+1, Arg.take()); 9765caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 9771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 978bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor ASTContext& Context = this->getASTContext(); 979bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor 980bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor // Create a new DeclRefExpr to refer to the new decl. 981bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DeclRefExpr* NewDRE = DeclRefExpr::Create( 982bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor Context, 983bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getQualifierLoc(), 984e4b92761b43ced611c417ae478568610f1ad7b1eAbramo Bagnara SourceLocation(), 985bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor NewBuiltinDecl, 986bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getLocation(), 987bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor NewBuiltinDecl->getType(), 988bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getValueKind()); 9891eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Set the callee in the CallExpr. 9915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // FIXME: This leaks the original parens and implicit casts. 992bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor ExprResult PromotedCall = UsualUnaryConversions(NewDRE); 993429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (PromotedCall.isInvalid()) 994429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return ExprError(); 995429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setCallee(PromotedCall.take()); 9961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 997db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // Change the result type of the call to match the original value type. This 998db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // is arbitrary, but the codegen for these builtins ins design to handle it 999db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // gracefully. 10008d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth TheCall->setType(ResultType); 1001d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 1002d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return move(TheCallResult); 10035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner} 10045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 1005690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin 100671993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct 1007fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would 1008fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend). 1009690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) { 101056f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner Arg = Arg->IgnoreParenCasts(); 101171993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 101271993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 10135cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!Literal || !Literal->isAscii()) { 1014fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 1015fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << Arg->getSourceRange(); 10169cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return true; 101771993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson } 10181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10197da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Literal->containsNonAsciiOrNull()) { 10205f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef String = Literal->getString(); 10217da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian unsigned NumBytes = String.size(); 10225f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<UTF16, 128> ToBuf(NumBytes); 10237da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian const UTF8 *FromPtr = (UTF8 *)String.data(); 10247da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian UTF16 *ToPtr = &ToBuf[0]; 10257da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 10267da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 10277da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian &ToPtr, ToPtr + NumBytes, 10287da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian strictConversion); 10297da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian // Check for conversion failure. 10307da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Result != conversionOK) 10317da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian Diag(Arg->getLocStart(), 10327da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian diag::warn_cfstring_truncated) << Arg->getSourceRange(); 10337da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian } 10349cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return false; 103559907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner} 103659907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 1037c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 1038c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success. 1039925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 1040925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *Fn = TheCall->getCallee(); 1041925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) { 10422c21a073525cdfa68e4439b7af551385dc2796abChris Lattner Diag(TheCall->getArg(2)->getLocStart(), 1043fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1044ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1045ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << Fn->getSourceRange() 10461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(2)->getLocStart(), 1047fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 104830ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 104930ce344307f8a8b00054021307015571f83c7364Chris Lattner } 105056f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 105156f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman if (TheCall->getNumArgs() < 2) { 1052d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher return Diag(TheCall->getLocEnd(), 1053d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 1054d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 105556f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman } 105656f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 10575f8d604246976a93a73549b07bbc8ee0b2061b50John McCall // Type-check the first argument normally. 10585f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (checkBuiltinArgument(*this, TheCall, 0)) 10595f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 10605f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 1061c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner // Determine whether the current function is variadic or not. 10629ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor BlockScopeInfo *CurBlock = getCurBlock(); 1063c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner bool isVariadic; 1064cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1065c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall isVariadic = CurBlock->TheDecl->isVariadic(); 10669498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else if (FunctionDecl *FD = getCurFunctionDecl()) 10679498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek isVariadic = FD->isVariadic(); 10689498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else 106953d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis isVariadic = getCurMethodDecl()->isVariadic(); 10701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1071c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner if (!isVariadic) { 107230ce344307f8a8b00054021307015571f83c7364Chris Lattner Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 107330ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 107430ce344307f8a8b00054021307015571f83c7364Chris Lattner } 10751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 107630ce344307f8a8b00054021307015571f83c7364Chris Lattner // Verify that the second argument to the builtin is the last argument of the 107730ce344307f8a8b00054021307015571f83c7364Chris Lattner // current function or method. 107830ce344307f8a8b00054021307015571f83c7364Chris Lattner bool SecondArgIsLastNamedArgument = false; 1079e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 10801eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 108188cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 108288cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 108330ce344307f8a8b00054021307015571f83c7364Chris Lattner // FIXME: This isn't correct for methods (results in bogus warning). 108430ce344307f8a8b00054021307015571f83c7364Chris Lattner // Get the last formal in the current function. 108588cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson const ParmVarDecl *LastArg; 1086cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 1087cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff LastArg = *(CurBlock->TheDecl->param_end()-1); 1088cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff else if (FunctionDecl *FD = getCurFunctionDecl()) 1089371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner LastArg = *(FD->param_end()-1); 109030ce344307f8a8b00054021307015571f83c7364Chris Lattner else 109153d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis LastArg = *(getCurMethodDecl()->param_end()-1); 109230ce344307f8a8b00054021307015571f83c7364Chris Lattner SecondArgIsLastNamedArgument = PV == LastArg; 109330ce344307f8a8b00054021307015571f83c7364Chris Lattner } 109430ce344307f8a8b00054021307015571f83c7364Chris Lattner } 10951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 109630ce344307f8a8b00054021307015571f83c7364Chris Lattner if (!SecondArgIsLastNamedArgument) 10971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(1)->getLocStart(), 109830ce344307f8a8b00054021307015571f83c7364Chris Lattner diag::warn_second_parameter_of_va_start_not_last_named_argument); 109930ce344307f8a8b00054021307015571f83c7364Chris Lattner return false; 11006cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman} 110130ce344307f8a8b00054021307015571f83c7364Chris Lattner 11021b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 11031b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends. This is declared to take (...), so we have to check everything. 1104925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 1105925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() < 2) 11062c21a073525cdfa68e4439b7af551385dc2796abChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1107d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << 2 << TheCall->getNumArgs()/*function call*/; 1108925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) 11091eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(TheCall->getArg(2)->getLocStart(), 1110fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 1111ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1112fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(TheCall->getArg(2)->getLocStart(), 1113fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 11141eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1115429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg0 = TheCall->getArg(0); 1116429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg1 = TheCall->getArg(1); 1117cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 11181b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // Do standard promotions between the two arguments, returning their common 11191b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // type. 1120925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 1121429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.isInvalid() || OrigArg1.isInvalid()) 1122429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return true; 1123403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar 1124403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // Make sure any conversions are pushed back into the call; this is 1125403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // type safe since unordered compare builtins are declared as "_Bool 1126403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // foo(...)". 1127429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(0, OrigArg0.get()); 1128429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(1, OrigArg1.get()); 11291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1130429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent()) 1131cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 1132cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 11331b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // If the common type isn't a real floating type, then the arguments were 11341b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // invalid for this operation. 11351b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner if (!Res->isRealFloatingType()) 1136429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return Diag(OrigArg0.get()->getLocStart(), 1137fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_invalid_ordered_compare) 1138429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << OrigArg0.get()->getType() << OrigArg1.get()->getType() 1139429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd()); 11401eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11411b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner return false; 11421b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner} 11431b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner 1144e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 1145e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends. This is declared to take (...), so we have 11463b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point 11473b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value. 11483b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 11493b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() < NumArgs) 11509ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1151d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 11523b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() > NumArgs) 11533b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer return Diag(TheCall->getArg(NumArgs)->getLocStart(), 11549ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_too_many_args) 1155ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 11563b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 11579ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman (*(TheCall->arg_end()-1))->getLocEnd()); 11589ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 11593b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer Expr *OrigArg = TheCall->getArg(NumArgs-1); 11601eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11619ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (OrigArg->isTypeDependent()) 11629ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 11639ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 116481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // This operation requires a non-_Complex floating-point number. 11659ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (!OrigArg->getType()->isRealFloatingType()) 11661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg->getLocStart(), 11679ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_invalid_unary_fp) 11689ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman << OrigArg->getType() << OrigArg->getSourceRange(); 11691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 117081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // If this is an implicit conversion from float -> double, remove it. 117181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 117281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Expr *CastArg = Cast->getSubExpr(); 117381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 117481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 117581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner "promotion from float to double is the only expected cast here"); 117681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Cast->setSubExpr(0); 117781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner TheCall->setArg(NumArgs-1, CastArg); 117881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner OrigArg = CastArg; 117981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 118081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 118181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner 11829ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 11839ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman} 11849ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 1185d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 1186d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything. 118760d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 118837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() < 2) 11890eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocEnd(), 1190d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 119137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1192d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << TheCall->getSourceRange()); 1193d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 119437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Determine which of the following types of shufflevector we're checking: 119537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 1) unary, vector mask: (lhs, mask) 119637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 2) binary, vector mask: (lhs, rhs, mask) 119737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 119837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType resType = TheCall->getArg(0)->getType(); 119937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numElements = 0; 120037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 1201cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (!TheCall->getArg(0)->isTypeDependent() && 1202cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor !TheCall->getArg(1)->isTypeDependent()) { 120337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType LHSType = TheCall->getArg(0)->getType(); 120437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType RHSType = TheCall->getArg(1)->getType(); 120537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 120637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!LHSType->isVectorType() || !RHSType->isVectorType()) { 1207cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) 12081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1209cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1210cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 1211cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 121237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 121337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numElements = LHSType->getAs<VectorType>()->getNumElements(); 121437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numResElements = TheCall->getNumArgs() - 2; 121537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 121637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Check to see if we have a call with 2 vector arguments, the unary shuffle 121737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // with mask. If so, verify that RHS is an integer vector type with the 121837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // same number of elts as lhs. 121937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() == 2) { 1220f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (!RHSType->hasIntegerRepresentation() || 122137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman RHSType->getAs<VectorType>()->getNumElements() != numElements) 122237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 122337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << SourceRange(TheCall->getArg(1)->getLocStart(), 122437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman TheCall->getArg(1)->getLocEnd()); 122537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numResElements = numElements; 122637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } 122737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 1228cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 12291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1230cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1231cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 123237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } else if (numElements != numResElements) { 123337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 1234788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner resType = Context.getVectorType(eltType, numResElements, 1235e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson VectorType::GenericVector); 1236cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 1237d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1238d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1239d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 1240cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 1241cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(i)->isValueDependent()) 1242cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor continue; 1243cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 124437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman llvm::APSInt Result(32); 124537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 124637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman return ExprError(Diag(TheCall->getLocStart(), 124737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman diag::err_shufflevector_nonconstant_argument) 124837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << TheCall->getArg(i)->getSourceRange()); 12490eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 1250d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 12510eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocStart(), 1252fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_shufflevector_argument_too_large) 12530eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl << TheCall->getArg(i)->getSourceRange()); 1254d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1255d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 12565f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<Expr*, 32> exprs; 1257d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1258d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 1259d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman exprs.push_back(TheCall->getArg(i)); 1260d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman TheCall->setArg(i, 0); 1261d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1262d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1263a88dc3079bedf70a5cfc39791727e43a10383006Nate Begeman return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(), 126437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman exprs.size(), resType, 12658189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getCallee()->getLocStart(), 12668189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getRParenLoc())); 1267d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman} 126830ce344307f8a8b00054021307015571f83c7364Chris Lattner 12694493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 12704493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two 12714493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args. 12724493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 1273fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner unsigned NumArgs = TheCall->getNumArgs(); 12744493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1275fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (NumArgs > 3) 1276ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher return Diag(TheCall->getLocEnd(), 1277ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher diag::err_typecheck_call_too_many_args_at_most) 1278ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 3 << NumArgs 1279ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << TheCall->getSourceRange(); 12804493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 12814493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // Argument 0 is checked for us and the remaining arguments must be 12824493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // constant integers. 1283fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner for (unsigned i = 1; i != NumArgs; ++i) { 12844493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar Expr *Arg = TheCall->getArg(i); 1285691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 12869aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman llvm::APSInt Result; 1287691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, i, Result)) 1288691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 12891eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 12904493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // FIXME: gcc issues a warning and rewrites these to 0. These 12914493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // seems especially odd for the third argument since the default 12924493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // is 3. 1293fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (i == 1) { 12949aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 1) 1295fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 129621fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "1" << Arg->getSourceRange(); 12974493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } else { 12989aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 3) 1299fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 130021fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "3" << Arg->getSourceRange(); 13014493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 13024493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 13034493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1304fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return false; 13054493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar} 13064493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1307691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 1308691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression. 1309691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 1310691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt &Result) { 1311691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(ArgNum); 1312691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 1313691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 1314691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1315691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 1316691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1317691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (!Arg->isIntegerConstantExpr(Result, Context)) 1318691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 13195e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher << FDecl->getDeclName() << Arg->getSourceRange(); 1320691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 132121fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner return false; 132221fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner} 132321fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner 1324d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 1325d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined 1326d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3). 1327fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner// For compatibility check 0-3, llvm only handles 0 and 2. 1328d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 1329691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1330691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1331691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // Check constant-ness first. 1332691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1333691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1334d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1335691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(1); 1336d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 1337fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 1338fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1339d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar } 1340d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1341d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar return false; 1342d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar} 1343d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1344586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 1345d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1. 1346d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 1347d875fed28578835de89cd407e9db4be788596d7cEli Friedman Expr *Arg = TheCall->getArg(1); 1348691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1349cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 1350691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // TODO: This is less than ideal. Overload this to take a value. 1351691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1352691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1353691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1354691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Result != 1) 1355d875fed28578835de89cd407e9db4be788596d7cEli Friedman return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 1356d875fed28578835de89cd407e9db4be788596d7cEli Friedman << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1357d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1358d875fed28578835de89cd407e9db4be788596d7cEli Friedman return false; 1359d875fed28578835de89cd407e9db4be788596d7cEli Friedman} 1360d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1361b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek// Handle i > 1 ? "x" : "y", recursively. 136229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupasbool Sema::SemaCheckStringLiteral(const Expr *E, Expr **Args, 136329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas unsigned NumArgs, bool HasVAListArg, 1364826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 136534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas FormatStringType Type, bool inFunctionCall) { 13664fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain: 1367cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 1368cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 1369d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 137034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas E = E->IgnoreParenCasts(); 1371f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 1372a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie if (E->isNullPointerConstant(Context, Expr::NPC_ValueDependentIsNotNull)) 1373a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // Technically -Wformat-nonliteral does not warn about this case. 1374a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // The behavior of printf and friends in this case is implementation 1375a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // dependent. Ideally if the format string cannot be null then 1376a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie // it should have a 'nonnull' attribute in the function prototype. 1377a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie return true; 1378a73cdcbc1dc1ed98c54556c6adcd2b12301759ccDavid Blaikie 1379d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek switch (E->getStmtClass()) { 138056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::BinaryConditionalOperatorClass: 1381d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ConditionalOperatorClass: { 138256ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall const AbstractConditionalOperator *C = cast<AbstractConditionalOperator>(E); 138329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return SemaCheckStringLiteral(C->getTrueExpr(), Args, NumArgs, HasVAListArg, 138434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas format_idx, firstDataArg, Type, 138555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu inFunctionCall) 138634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas && SemaCheckStringLiteral(C->getFalseExpr(), Args, NumArgs, HasVAListArg, 138734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas format_idx, firstDataArg, Type, 138834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas inFunctionCall); 1389d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1390d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1391d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ImplicitCastExprClass: { 13924fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ImplicitCastExpr>(E)->getSubExpr(); 13934fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 1394d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1395d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 139656ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::OpaqueValueExprClass: 139756ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) { 139856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall E = src; 139956ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall goto tryAgain; 140056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall } 140156ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall return false; 140256ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall 1403b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek case Stmt::PredefinedExprClass: 1404b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // While __func__, etc., are technically not string literals, they 1405b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // cannot contain format specifiers and thus are not a security 1406b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // liability. 1407b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek return true; 1408b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek 1409082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::DeclRefExprClass: { 1410082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const DeclRefExpr *DR = cast<DeclRefExpr>(E); 14111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1412082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // As an exception, do not flag errors for variables binding to 1413082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // const string literals. 1414082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 1415082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool isConstant = false; 1416082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek QualType T = DR->getType(); 1417082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek 1418082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ArrayType *AT = Context.getAsArrayType(T)) { 1419082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek isConstant = AT->getElementType().isConstant(Context); 1420ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (const PointerType *PT = T->getAs<PointerType>()) { 14211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump isConstant = T.isConstant(Context) && 1422082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek PT->getPointeeType().isConstant(Context); 1423e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas } else if (T->isObjCObjectPointerType()) { 1424e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas // In ObjC, there is usually no "const ObjectPointer" type, 1425e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas // so don't check if the pointee type is constant. 1426e98e5b54543f8a9e35626fb44dc0c649e71917d9Jean-Daniel Dupas isConstant = T.isConstant(Context); 1427082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 14281eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1429082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (isConstant) { 143031310a21fb2a9f13950f864f681c86080b05d5b2Sebastian Redl if (const Expr *Init = VD->getAnyInitializer()) 143129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return SemaCheckStringLiteral(Init, Args, NumArgs, 1432826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, format_idx, firstDataArg, 143334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas Type, /*inFunctionCall*/false); 1434082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 14351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1436d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // For vprintf* functions (i.e., HasVAListArg==true), we add a 1437d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // special check to see if the format string is a function parameter 1438d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // of the function calling the printf function. If the function 1439d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // has an attribute indicating it is a printf-like function, then we 1440d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // should suppress warnings concerning non-literals being used in a call 1441d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // to a vprintf function. For example: 1442d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1443d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // void 1444d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 1445d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_list ap; 1446d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_start(ap, fmt); 1447d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 1448d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // ... 1449d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1450d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1451d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // FIXME: We don't have full attribute support yet, so just check to see 1452d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // if the argument is a DeclRefExpr that references a parameter. We'll 1453d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // add proper support for checking the attribute later. 1454d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (HasVAListArg) 1455d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (isa<ParmVarDecl>(VD)) 1456d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson return true; 1457082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 14581eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1459082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1460082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 1461d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 146252aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas case Stmt::CallExprClass: 146352aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas case Stmt::CXXMemberCallExprClass: { 14648f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const CallExpr *CE = cast<CallExpr>(E); 146552aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const NamedDecl *ND = dyn_cast_or_null<NamedDecl>(CE->getCalleeDecl())) { 146652aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) { 146752aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas unsigned ArgIndex = FA->getFormatIdx(); 146852aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND)) 146952aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas if (MD->isInstance()) 147052aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas --ArgIndex; 147152aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas const Expr *Arg = CE->getArg(ArgIndex - 1); 147252aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas 147352aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas return SemaCheckStringLiteral(Arg, Args, NumArgs, HasVAListArg, 147452aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas format_idx, firstDataArg, Type, 147552aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas inFunctionCall); 14768f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 14778f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 14781eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 14798f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson return false; 14808f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 1481082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::ObjCStringLiteralClass: 1482082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::StringLiteralClass: { 1483082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const StringLiteral *StrE = NULL; 14841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1485082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 1486d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek StrE = ObjCFExpr->getString(); 1487d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek else 1488082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek StrE = cast<StringLiteral>(E); 14891eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1490d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek if (StrE) { 149129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas CheckFormatString(StrE, E, Args, NumArgs, HasVAListArg, format_idx, 149234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas firstDataArg, Type, inFunctionCall); 1493d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return true; 1494d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 14951eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1496d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return false; 1497d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 14981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1499082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek default: 1500082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1501d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1502d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1503d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1504e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid 15051eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull, 1506909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr * const *ExprArgs, 1507909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky SourceLocation CallSiteLoc) { 1508cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt for (NonNullAttr::args_iterator i = NonNull->args_begin(), 1509cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt e = NonNull->args_end(); 1510e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian i != e; ++i) { 1511909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr *ArgExpr = ExprArgs[*i]; 15124e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (ArgExpr->isNullPointerConstant(Context, 1513ce94049b69f75b44c18584fe79cd238978b6b0d5Douglas Gregor Expr::NPC_ValueDependentIsNotNull)) 1514909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange(); 1515e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian } 1516e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian} 1517d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 151834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel DupasSema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) { 151934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas return llvm::StringSwitch<FormatStringType>(Format->getType()) 152034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("scanf", FST_Scanf) 152134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("printf", "printf0", FST_Printf) 152234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("NSString", "CFString", FST_NSString) 152334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("strftime", FST_Strftime) 152434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Case("strfmon", FST_Strfmon) 152534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf) 152634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas .Default(FST_Unknown); 152734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas} 152834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas 1529826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar 1530826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings. 153129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupasvoid Sema::CheckFormatArguments(const FormatAttr *Format, CallExpr *TheCall) { 153229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas bool IsCXXMember = false; 15334a2614e94672c47395abcde60518776fbebec589Sebastian Redl // The way the format attribute works in GCC, the implicit this argument 15344a2614e94672c47395abcde60518776fbebec589Sebastian Redl // of member functions is counted. However, it doesn't appear in our own 15354a2614e94672c47395abcde60518776fbebec589Sebastian Redl // lists, so decrement format_idx in that case. 153652aabafeee9e8634eceb46b1a3fdbd3cd22b1cf7Jean-Daniel Dupas IsCXXMember = isa<CXXMemberCallExpr>(TheCall); 153729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas CheckFormatArguments(Format, TheCall->getArgs(), TheCall->getNumArgs(), 153829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas IsCXXMember, TheCall->getRParenLoc(), 153929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas TheCall->getCallee()->getSourceRange()); 154029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 154129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas 154229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupasvoid Sema::CheckFormatArguments(const FormatAttr *Format, Expr **Args, 154329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas unsigned NumArgs, bool IsCXXMember, 154429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas SourceLocation Loc, SourceRange Range) { 154534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas bool HasVAListArg = Format->getFirstArg() == 0; 154634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned format_idx = Format->getFormatIdx() - 1; 154734269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg = HasVAListArg ? 0 : Format->getFirstArg() - 1; 154834269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas if (IsCXXMember) { 154934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas if (format_idx == 0) 155034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas return; 155134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas --format_idx; 155234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas if(firstDataArg != 0) 155334269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas --firstDataArg; 155434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } 155534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas CheckFormatArguments(Args, NumArgs, HasVAListArg, format_idx, 155634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas firstDataArg, GetFormatStringType(Format), Loc, Range); 155729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas} 15584a2614e94672c47395abcde60518776fbebec589Sebastian Redl 155934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupasvoid Sema::CheckFormatArguments(Expr **Args, unsigned NumArgs, 156034269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas bool HasVAListArg, unsigned format_idx, 156134269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg, FormatStringType Type, 156234269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas SourceLocation Loc, SourceRange Range) { 1563826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // CHECK: printf/scanf-like function is called with no format string. 156429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas if (format_idx >= NumArgs) { 156529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Loc, diag::warn_missing_format_string) << Range; 156671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek return; 156771895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek } 15681eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 156929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts(); 15701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 157159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner // CHECK: format string is not a string literal. 15721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // 157371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // Dynamically generated format strings are difficult to 157471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // automatically vet at compile time. Requiring that format strings 157571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // are string literals: (1) permits the checking of format strings by 157671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // the compiler and thereby (2) can practically remove the source of 157771895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // many format string exploits. 15787ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek 15791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // Format string can be either ObjC string (e.g. @"%d") or 15807ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // C string (e.g. "%d") 15811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // ObjC string uses the same format specifiers as C string, so we can use 15827ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // the same format string checking logic for both ObjC and C strings. 158329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas if (SemaCheckStringLiteral(OrigFormatExpr, Args, NumArgs, HasVAListArg, 158434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas format_idx, firstDataArg, Type)) 15851cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner return; // Literal format string found, check done! 15861cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner 15872837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas // Strftime is particular as it always uses a single 'time' argument, 15882837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas // so it is safe to pass a non-literal string. 15892837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas if (Type == FST_Strftime) 15902837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas return; 15912837a2f02195e624b14b419b2d3e6682a6bc5a0fJean-Daniel Dupas 1592ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // Do not emit diag when the string param is a macro expansion and the 1593ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // format is either NSString or CFString. This is a hack to prevent 1594ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // diag when using the NSLocalizedString and CFCopyLocalizedString macros 1595ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas // which are usually used in place of NS and CF string literals. 1596ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas if (Type == FST_NSString && Args[format_idx]->getLocStart().isMacroID()) 1597ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas return; 1598ce3aa395240207fd1cfa11342fd4b9fd46d6b025Jean-Daniel Dupas 1599655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // If there are no arguments specified, warn with -Wformat-security, otherwise 1600655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // warn only with -Wformat-nonliteral. 160129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas if (NumArgs == format_idx+1) 160229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Args[format_idx]->getLocStart(), 1603826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral_noargs) 1604655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1605655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner else 160629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Diag(Args[format_idx]->getLocStart(), 1607826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral) 1608655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1609d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1610d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1611e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace { 1612826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler { 1613826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1614e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Sema &S; 1615e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const StringLiteral *FExpr; 1616e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const Expr *OrigFormatExpr; 16176ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const unsigned FirstDataArg; 1618e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const unsigned NumDataArgs; 1619e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const bool IsObjCLiteral; 1620e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *Beg; // Start of format string. 16210d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const bool HasVAListArg; 162229c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const Expr * const *Args; 162329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const unsigned NumArgs; 16240d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek unsigned FormatIdx; 16257f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek llvm::BitVector CoveredArgs; 1626efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool usesPositionalArgs; 1627efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool atFirstArg; 162855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool inFunctionCall; 16294e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic: 1630826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 16316ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1632e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 16330d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const char *beg, bool hasVAListArg, 163429c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **args, unsigned numArgs, 163529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas unsigned formatIdx, bool inFunctionCall) 1636e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 16376ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek FirstDataArg(firstDataArg), 16387f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek NumDataArgs(numDataArgs), 16390d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek IsObjCLiteral(isObjCLiteral), Beg(beg), 16400d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek HasVAListArg(hasVAListArg), 164129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Args(args), NumArgs(numArgs), FormatIdx(formatIdx), 164255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu usesPositionalArgs(false), atFirstArg(true), 164355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu inFunctionCall(inFunctionCall) { 16447f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.resize(numDataArgs); 16457f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.reset(); 16467f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 16474e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 164807d161f38e708a91486bf1c031d525faebbb249dTed Kremenek void DoneProcessing(); 16494e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1650826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIncompleteSpecifier(const char *startSpecifier, 1651826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1652826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1653efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleInvalidPosition(const char *startSpecifier, 1654efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned specifierLen, 1655826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p); 1656efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1657efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 1658efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1659e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek void HandleNullChar(const char *nullCharacter); 16604e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 166155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 166255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu static void EmitFormatDiagnostic(Sema &S, bool inFunctionCall, 166355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 166455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 166555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation StringLoc, 166655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 166755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint Fixit = FixItHint()); 166855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 1669826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1670c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 1671c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1672c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1673c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, unsigned csLen); 167455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 167555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void HandlePositionalNonpositionalArgs(SourceLocation Loc, 167655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 167755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen); 1678c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1679f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek SourceRange getFormatStringRange(); 1680826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CharSourceRange getSpecifierRange(const char *startSpecifier, 1681826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1682e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek SourceLocation getLocationOfByte(const char *x); 16834e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 16840d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const Expr *getDataArg(unsigned i) const; 1685666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1686666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 1687666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1688666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, 1689666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek unsigned argIndex); 169055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 169155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu template <typename Range> 169255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc, 169355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, Range StringRange, 169455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint Fixit = FixItHint()); 169555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 169655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu void CheckPositionalAndNonpositionalArgs( 169755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const analyze_format_string::FormatSpecifier *FS); 1698e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}; 1699e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1700e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1701826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() { 1702e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return OrigFormatExpr->getSourceRange(); 1703e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1704e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1705826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler:: 1706826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 170745f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation Start = getLocationOfByte(startSpecifier); 170845f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 170945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 171045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care // Advance the end SourceLocation by one due to half-open ranges. 1711a64ccefdf0ea4e03ec88805d71b0af74950c7472Argyrios Kyrtzidis End = End.getLocWithOffset(1); 171245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 171345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care return CharSourceRange::getCharRange(Start, End); 1714f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek} 1715f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek 1716826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 17174e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 1718e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1719e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1720826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 1721826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen){ 172255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier), 172355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startSpecifier), 172455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 172555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 1726808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek} 1727808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek 1728efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid 1729826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 1730826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p) { 173155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier) 173255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (unsigned) p, 173355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), /*IsStringLocation*/true, 173455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 1735efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1736efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1737826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos, 1738efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned posLen) { 173955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier), 174055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(startPos), 174155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 174255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startPos, posLen)); 1743efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1744efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1745826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 17460c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek if (!IsObjCLiteral) { 17470c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek // The presence of a null character is likely an error. 174855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 174955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_format_string_contains_null_char), 175055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(nullCharacter), /*IsStringLocation*/true, 175155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getFormatStringRange()); 17520c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek } 1753826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1754826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1755826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const { 175629c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas return Args[FirstDataArg + i]; 1757826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 17584e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1759826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() { 1760826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Does the number of data arguments exceed the number of 1761826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // format conversions in the format string? 1762826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!HasVAListArg) { 1763826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Find any arguments that weren't covered. 1764826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.flip(); 1765826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek signed notCoveredArg = CoveredArgs.find_first(); 1766826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (notCoveredArg >= 0) { 1767826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek assert((unsigned)notCoveredArg < NumDataArgs); 176855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_data_arg_not_used), 176955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getDataArg((unsigned) notCoveredArg)->getLocStart(), 177055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/false, getFormatStringRange()); 1771826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1772826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1773826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1774826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1775c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool 1776c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 1777c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek SourceLocation Loc, 1778c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1779c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1780c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, 1781c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned csLen) { 1782c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1783c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool keepGoing = true; 1784c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek if (argIndex < NumDataArgs) { 1785c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // Consider the argument coverered, even though the specifier doesn't 1786c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // make sense. 1787c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CoveredArgs.set(argIndex); 1788c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1789c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek else { 1790c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // If argIndex exceeds the number of data arguments we 1791c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // don't issue a warning because that is just a cascade of warnings (and 1792c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // they may have intended '%%' anyway). We don't want to continue processing 1793c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // the format string after this point, however, as we will like just get 1794c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // gibberish when trying to match arguments. 1795c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek keepGoing = false; 1796c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1797c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 179855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_conversion) 179955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << StringRef(csStart, csLen), 180055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*IsStringLocation*/true, 180155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpec, specifierLen)); 1802c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1803c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return keepGoing; 1804c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1805c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 180655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid 180755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard TrieuCheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc, 180855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const char *startSpec, 180955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu unsigned specifierLen) { 181055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 181155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_format_mix_positional_nonpositional_args), 181255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen)); 181355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 181455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 1815666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool 1816666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs( 1817666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::FormatSpecifier &FS, 1818666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1819666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 1820666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1821666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (argIndex >= NumDataArgs) { 182255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag = FS.usesPositionalArg() 182355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args) 182455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << (argIndex+1) << NumDataArgs) 182555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : S.PDiag(diag::warn_printf_insufficient_data_args); 182655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 182755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true, 182855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 1829666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return false; 1830666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1831666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return true; 1832666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek} 1833666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 183455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 183555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag, 183655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 183755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 183855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 183955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint FixIt) { 184029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag, 184155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Loc, IsStringLocation, StringRange, FixIt); 184255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 184355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 184455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \brief If the format string is not within the funcion call, emit a note 184555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// so that the function call and string are in diagnostic messages. 184655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 184755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param inFunctionCall if true, the format string is within the function 184855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// call and only one diagnostic message will be produced. Otherwise, an 184955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// extra note will be emitted pointing to location of the format string. 185055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 185155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param ArgumentExpr the expression that is passed as the format string 185255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// argument in the function call. Used for getting locations when two 185355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostics are emitted. 185455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 185555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param PDiag the callee should already have provided any strings for the 185655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// diagnostic message. This function only adds locations and fixits 185755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// to diagnostics. 185855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 185955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param Loc primary location for diagnostic. If two diagnostics are 186055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// required, one will be at Loc and a new SourceLocation will be created for 186155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// the other one. 186255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 186355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param IsStringLocation if true, Loc points to the format string should be 186455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// used for the note. Otherwise, Loc points to the argument list and will 186555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// be used with PDiag. 186655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 186755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param StringRange some or all of the string to highlight. This is 186855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// templated so it can accept either a CharSourceRange or a SourceRange. 186955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// 187055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu/// \param Fixit optional fix it hint for the format string. 187155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieutemplate<typename Range> 187255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieuvoid CheckFormatHandler::EmitFormatDiagnostic(Sema &S, bool InFunctionCall, 187355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu const Expr *ArgumentExpr, 187455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PartialDiagnostic PDiag, 187555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu SourceLocation Loc, 187655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu bool IsStringLocation, 187755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Range StringRange, 187855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint FixIt) { 187955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu if (InFunctionCall) 188055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.Diag(Loc, PDiag) << StringRange << FixIt; 188155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu else { 188255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag) 188355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ArgumentExpr->getSourceRange(); 188455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.Diag(IsStringLocation ? Loc : StringRange.getBegin(), 188555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu diag::note_format_string_defined) 188655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << StringRange << FixIt; 188755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu } 188855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu} 188955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 1890826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===// 1891826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1892826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 1893826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler { 1894826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 1895826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 1896826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1897826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 1898826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 189929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **Args, unsigned NumArgs, 190029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas unsigned formatIdx, bool inFunctionCall) 1901826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1902826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 190329c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Args, NumArgs, formatIdx, inFunctionCall) {} 1904826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1905826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1906826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleInvalidPrintfConversionSpecifier( 1907826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1908826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1909826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1910826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1911826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 1912826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1913826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1914826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1915826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 1916826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1917826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 1918826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalAmount &Amt, 1919826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned type, 1920826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1921826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1922826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1923826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1924826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 1925826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &ignoredFlag, 1926826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1927826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1928826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 1929826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1930826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1931826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 1932826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1933826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1934826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 19356ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 1936c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 1937826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1938c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1939c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 1940c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 1941c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 194226ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek} 194326ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek 1944826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount( 1945826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_format_string::OptionalAmount &Amt, 1946826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned k, const char *startSpecifier, 1947826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 19480d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 19490d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (Amt.hasDataArgument()) { 19500d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (!HasVAListArg) { 19517f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = Amt.getArgIndex(); 19527f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (argIndex >= NumDataArgs) { 195355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg) 195455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << k, 195555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 195655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 195755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 19580d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 19590d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 19600d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 19610d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 19624e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 19630d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Type check the data argument. It should be an 'int'. 196431f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // Although not in conformance with C99, we also allow the argument to be 196531f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // an 'unsigned int' as that is a reasonably safe case. GCC also 196631f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // doesn't emit a warning for that case. 19677f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.set(argIndex); 19687f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek const Expr *Arg = getDataArg(argIndex); 19690d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek QualType T = Arg->getType(); 19704e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 19714e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context); 19724e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek assert(ATR.isValid()); 19734e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 19744e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (!ATR.matchesType(S.Context, T)) { 197555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type) 1976a792aff1c7de253b89c473fdb7eef4a5bba83aecHans Wennborg << k << ATR.getRepresentativeTypeName(S.Context) 197755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << T << Arg->getSourceRange(), 197855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 197955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 198055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 19810d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 19820d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 19830d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 19840d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 19850d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 19860d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 19870d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return true; 19880d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek} 19890d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1990e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount( 1991826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1992e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalAmount &Amt, 1993e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned type, 1994e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1995e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 19966ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 19976ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1998e4ee9663168dfb2b4122c768091e30217328c9faTom Care 199955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint fixit = 200055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant 200155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 200255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu Amt.getConstantLength())) 200355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu : FixItHint(); 200455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu 200555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount) 200655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << type << CS.toString(), 200755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 200855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 200955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 201055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu fixit); 2011e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2012e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2013826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 2014e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 2015e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2016e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 2017e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about pointless flag with a fixit removal. 20186ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 20196ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 202055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag) 202155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << flag.toString() << CS.toString(), 202255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(flag.getPosition()), 202355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 202455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 202555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 202655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(flag.getPosition(), 1))); 2027e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2028e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2029e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag( 2030826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 2031e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &ignoredFlag, 2032e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 2033e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 2034e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 2035e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about ignored flag with a fixit removal. 203655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag) 203755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << ignoredFlag.toString() << flag.toString(), 203855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(ignoredFlag.getPosition()), 203955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 204055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 204155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 204255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(ignoredFlag.getPosition(), 1))); 2043e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 2044e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2045e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool 2046826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 20475c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek &FS, 2048e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *startSpecifier, 2049e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned specifierLen) { 2050e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 20516ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek using namespace analyze_format_string; 2052efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek using namespace analyze_printf; 20536ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 2054e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2055baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 2056baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 2057baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 2058baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 2059baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2060baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 206155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 206255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 2063baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 2064baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2065efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek } 2066efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 20670d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // First check if the field width, precision, and conversion specifier 20680d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // have matching data arguments. 2069efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 2070efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 20710d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 20720d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 20734e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2074efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 2075efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 20760d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 20770d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 20780d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 2079f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek if (!CS.consumesDataArgument()) { 2080f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // FIXME: Technically specifying a precision or field width here 2081f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // makes no sense. Worth issuing a warning at some point. 20820e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek return true; 2083f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek } 20844e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 20857f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Consume the argument. 20867f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = FS.getArgIndex(); 2087e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek if (argIndex < NumDataArgs) { 2088e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // The check to see if the argIndex is valid will come later. 2089e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // We set the bit here because we may exit early from this 2090e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // function if we encounter some other error. 2091e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek CoveredArgs.set(argIndex); 2092e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek } 20937f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek 20947f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Check for using an Objective-C specific conversion specifier 20957f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // in a non-ObjC literal. 20967f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (!IsObjCLiteral && CS.isObjCArg()) { 2097826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 2098826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek specifierLen); 20997f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 21004e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2101e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of field width 2102e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidFieldWidth()) { 210345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 2104e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2105e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2106e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2107e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of precision 2108e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPrecision()) { 2109e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 2110e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2111e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 2112e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2113e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check each flag does not conflict with any other component. 211465197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek if (!FS.hasValidThousandsGroupingPrefix()) 211565197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen); 2116e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeadingZeros()) 2117e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 2118e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPlusPrefix()) 2119e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 212045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (!FS.hasValidSpacePrefix()) 212145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 2122e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidAlternativeForm()) 2123e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 2124e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeftJustified()) 2125e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 2126e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2127e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check that flags are not ignored by another flag 212845f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 212945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 213045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care startSpecifier, specifierLen); 2131e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 2132e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 2133e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 2134e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2135e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check the length modifier is valid with the given conversion specifier. 2136e4ee9663168dfb2b4122c768091e30217328c9faTom Care const LengthModifier &LM = FS.getLengthModifier(); 2137e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLengthModifier()) 213855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_format_nonsensical_length) 213955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << LM.toString() << CS.toString(), 214055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(LM.getStart()), 214155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 214255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 214355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval( 214455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(LM.getStart(), 214555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu LM.getLength()))); 2146e4ee9663168dfb2b4122c768091e30217328c9faTom Care 2147e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Are we using '%n'? 214835d353b47bce29200b910371dd9b8ba7f3058ab8Ted Kremenek if (CS.getKind() == ConversionSpecifier::nArg) { 2149e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Issue a warning about this being a possible security issue. 215055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_printf_write_back), 215155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(CS.getStart()), 215255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 215355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen)); 2154e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek // Continue checking the other format specifiers. 2155e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek return true; 2156e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek } 21575c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek 2158da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek // The remaining checks depend on the data arguments. 2159da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek if (HasVAListArg) 2160da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return true; 21614e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 2162666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 2163da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return false; 21644e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 216596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Now type check the data expression that matches the 216696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // format specifier. 216796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const Expr *Ex = getDataArg(argIndex); 2168339b9072e26a2a0fe796dc69c4d28d964d0ec86dNico Weber const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context, 2169339b9072e26a2a0fe796dc69c4d28d964d0ec86dNico Weber IsObjCLiteral); 217096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) { 217196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Check if we didn't match because of an implicit cast from a 'char' 217296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // or 'short' to an 'int'. This is done because printf is a varargs 217396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // function. 217496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex)) 21754d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ICE->getType() == S.Context.IntTy) { 21764d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek // All further checking is done on the subexpression. 21774d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek Ex = ICE->getSubExpr(); 21784d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ATR.matchesType(S.Context, Ex->getType())) 217996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer return true; 21804d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek } 218196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 218296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // We may be able to offer a FixItHint if it is a supported type. 218396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer PrintfSpecifier fixedFS = FS; 2184a7da2155167676a6a5d9fca4de947a9cab2a4908Hans Wennborg bool success = fixedFS.fixType(Ex->getType(), S.getLangOptions()); 218596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 218696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (success) { 218796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Get the fix string from the fixed format specifier 2188f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> buf; 218996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::raw_svector_ostream os(buf); 219096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer fixedFS.toString(os); 219196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 219255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic( 219355733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 2194a792aff1c7de253b89c473fdb7eef4a5bba83aecHans Wennborg << ATR.getRepresentativeTypeName(S.Context) << Ex->getType() 219555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu << Ex->getSourceRange(), 219655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(CS.getStart()), 219755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, 219855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 219955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateReplacement( 220055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(startSpecifier, specifierLen), 220155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu os.str())); 220296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 220396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer else { 2204220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas EmitFormatDiagnostic( 2205220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 2206220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << ATR.getRepresentativeTypeName(S.Context) << Ex->getType() 2207220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << getSpecifierRange(startSpecifier, specifierLen) 2208220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << Ex->getSourceRange(), 2209220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas getLocationOfByte(CS.getStart()), 2210220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas true, 2211220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas getSpecifierRange(startSpecifier, specifierLen)); 221296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 221396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 221496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 2215e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return true; 2216e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2217e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2218826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===// 2219826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2220826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 2221826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler { 2222826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 2223826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 2224826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 2225826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 2226826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 222729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **Args, unsigned NumArgs, 222829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas unsigned formatIdx, bool inFunctionCall) 2229826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 2230826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 223129c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Args, NumArgs, formatIdx, inFunctionCall) {} 2232826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2233826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 2234826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2235826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2236c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2237c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidScanfConversionSpecifier( 2238c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2239c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 2240c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen); 2241b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 2242b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek void HandleIncompleteScanList(const char *start, const char *end); 2243826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 2244826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2245826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2246b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start, 2247b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek const char *end) { 224855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete), 224955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(end), /*IsStringLocation*/true, 225055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getSpecifierRange(start, end - start)); 2251b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek} 2252b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 2253c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 2254c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2255c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 2256c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen) { 2257c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 22586ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_scanf::ScanfConversionSpecifier &CS = 2259c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 2260c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2261c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 2262c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 2263c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 2264c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 2265c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 2266c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2267826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier( 2268826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2269826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2270826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 2271826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2272826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_scanf; 2273826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_format_string; 2274826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 22756ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 2276826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2277baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Handle case where '%' and '*' don't consume an argument. These shouldn't 2278baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // be used to decide if we are using positional arguments consistently. 2279baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 2280baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 2281baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 2282baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 2283baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2284baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 228555733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()), 228655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu startSpecifier, specifierLen); 2287baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 2288baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2289826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2290826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2291826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Check if the field with is non-zero. 2292826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const OptionalAmount &Amt = FS.getFieldWidth(); 2293826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getHowSpecified() == OptionalAmount::Constant) { 2294826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getConstantAmount() == 0) { 2295826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 2296826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Amt.getConstantLength()); 229755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width), 229855733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu getLocationOfByte(Amt.getStart()), 229955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, R, 230055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu FixItHint::CreateRemoval(R)); 23017f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 23027f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 2303826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2304826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!FS.consumesDataArgument()) { 2305826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Technically specifying a precision or field width here 2306826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // makes no sense. Worth issuing a warning at some point. 2307826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 2308826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2309826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2310826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Consume the argument. 2311826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned argIndex = FS.getArgIndex(); 2312826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (argIndex < NumDataArgs) { 2313826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The check to see if the argIndex is valid will come later. 2314826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // We set the bit here because we may exit early from this 2315826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // function if we encounter some other error. 2316826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.set(argIndex); 2317826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2318826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 23191e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek // Check the length modifier is valid with the given conversion specifier. 23201e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek const LengthModifier &LM = FS.getLengthModifier(); 23211e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek if (!FS.hasValidLengthModifier()) { 2322220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas const CharSourceRange &R = getSpecifierRange(LM.getStart(), LM.getLength()); 2323220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas EmitFormatDiagnostic(S.PDiag(diag::warn_format_nonsensical_length) 2324220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << LM.toString() << CS.toString() 2325220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << getSpecifierRange(startSpecifier, specifierLen), 2326220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas getLocationOfByte(LM.getStart()), 2327220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas /*IsStringLocation*/true, R, 2328220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas FixItHint::CreateRemoval(R)); 23291e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek } 23301e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek 2331826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The remaining checks depend on the data arguments. 2332826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (HasVAListArg) 2333826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 2334826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2335666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 2336826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return false; 2337826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 23386fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Check that the argument type matches the format specifier. 23396fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg const Expr *Ex = getDataArg(argIndex); 23406fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg const analyze_scanf::ScanfArgTypeResult &ATR = FS.getArgType(S.Context); 23416fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) { 23426fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg ScanfSpecifier fixedFS = FS; 23436fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg bool success = fixedFS.fixType(Ex->getType(), S.getLangOptions()); 23446fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 23456fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg if (success) { 23466fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg // Get the fix string from the fixed format specifier. 2347f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> buf; 23486fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg llvm::raw_svector_ostream os(buf); 23496fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg fixedFS.toString(os); 23506fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 23516fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg EmitFormatDiagnostic( 23526fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 23536fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg << ATR.getRepresentativeTypeName(S.Context) << Ex->getType() 23546fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg << Ex->getSourceRange(), 23556fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getLocationOfByte(CS.getStart()), 23566fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg /*IsStringLocation*/true, 23576fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 23586fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg FixItHint::CreateReplacement( 23596fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg getSpecifierRange(startSpecifier, specifierLen), 23606fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg os.str())); 23616fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } else { 2362220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas EmitFormatDiagnostic( 2363220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas S.PDiag(diag::warn_printf_conversion_argument_type_mismatch) 23646fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg << ATR.getRepresentativeTypeName(S.Context) << Ex->getType() 2365220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas << Ex->getSourceRange(), 2366220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas getLocationOfByte(CS.getStart()), 2367220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas /*IsStringLocation*/true, 2368220947bd5a66b0f25f5e74d6029769dfb34f07b4Jean-Daniel Dupas getSpecifierRange(startSpecifier, specifierLen)); 23696fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 23706fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg } 23716fcd932dfd6835f70cc00d6f7c6789793f6d7b66Hans Wennborg 2372826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 237307d161f38e708a91486bf1c031d525faebbb249dTed Kremenek} 2374e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2375826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr, 23760e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const Expr *OrigFormatExpr, 237729c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Expr **Args, unsigned NumArgs, 237829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas bool HasVAListArg, unsigned format_idx, 237934269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas unsigned firstDataArg, FormatStringType Type, 238029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas bool inFunctionCall) { 2381826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2382e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: is the format string a wide literal? 23835cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!FExpr->isAscii()) { 238455733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 238529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas *this, inFunctionCall, Args[format_idx], 238655733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(), 238755733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 2388e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 2389e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 2390826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2391e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // Str - The format string. NOTE: this is NOT null-terminated! 23925f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef StrRef = FExpr->getString(); 23932f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer const char *Str = StrRef.data(); 23942f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer unsigned StrLen = StrRef.size(); 239529c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas const unsigned numDataArgs = NumArgs - firstDataArg; 2396826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2397e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: empty format string? 23984cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek if (StrLen == 0 && numDataArgs > 0) { 239955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu CheckFormatHandler::EmitFormatDiagnostic( 240029c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas *this, inFunctionCall, Args[format_idx], 240155733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu PDiag(diag::warn_empty_format_string), FExpr->getLocStart(), 240255733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu /*IsStringLocation*/true, OrigFormatExpr->getSourceRange()); 2403e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 2404e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 2405826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 240634269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas if (Type == FST_Printf || Type == FST_NSString) { 2407826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 24084cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek numDataArgs, isa<ObjCStringLiteral>(OrigFormatExpr), 240929c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Str, HasVAListArg, Args, NumArgs, format_idx, 241055733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu inFunctionCall); 2411826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2412d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen, 2413d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg getLangOptions())) 2414826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 241534269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } else if (Type == FST_Scanf) { 2416826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 24174cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek numDataArgs, isa<ObjCStringLiteral>(OrigFormatExpr), 241829c3f814b64808c6dac4597b61a50ceecdf141fcJean-Daniel Dupas Str, HasVAListArg, Args, NumArgs, format_idx, 241955733de16f492dadbf5f4d2809d6c610ba6d86aeRichard Trieu inFunctionCall); 2420826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2421d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen, 2422d02deebce5f1b283101e035a7f5d5bab0d2068ecHans Wennborg getLangOptions())) 2423826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 242434269df5db40b7c4b4f52aed579d9b3108ff79e4Jean-Daniel Dupas } // TODO: handle other formats 2425ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek} 2426ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek 24277ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth//===--- CHECK: Standard memory functions ---------------------------------===// 24287ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 24292a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// \brief Determine whether the given type is a dynamic class type (e.g., 24302a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// whether it has a vtable). 24312a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregorstatic bool isDynamicClassType(QualType T) { 24322a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Record = T->getAsCXXRecordDecl()) 24332a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Definition = Record->getDefinition()) 24342a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (Definition->isDynamicClass()) 24352a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return true; 24362a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 24372a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return false; 24382a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor} 24392a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 2440a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument expression, 2441000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth/// otherwise returns NULL. 2442000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic const Expr *getSizeOfExprArg(const Expr* E) { 2443e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber if (const UnaryExprOrTypeTraitExpr *SizeOf = 2444000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 2445000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType()) 2446000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getArgumentExpr()->IgnoreParenImpCasts(); 2447e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 2448000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return 0; 2449000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth} 2450000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2451a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument type. 2452000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic QualType getSizeOfArgType(const Expr* E) { 2453000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryExprOrTypeTraitExpr *SizeOf = 2454000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 2455000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf) 2456000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getTypeOfArgument(); 2457000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2458000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return QualType(); 2459e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber} 2460e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 24617ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \brief Check for dangerous or invalid arguments to memset(). 24627ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 2463929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth/// This issues warnings on known problematic, dangerous or unspecified 2464cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp' 2465cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// function calls. 24667ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 24677ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \param Call The call expression to diagnose. 2468cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gayvoid Sema::CheckMemaccessArguments(const CallExpr *Call, 24690a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned BId, 2470cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay IdentifierInfo *FnName) { 24710a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks assert(BId != 0); 24720a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 24731d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek // It is possible to have a non-standard definition of memset. Validate 2474707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor // we have enough arguments, and if not, abort further checking. 24750a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned ExpectedNumArgs = (BId == Builtin::BIstrndup ? 2 : 3); 2476cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber if (Call->getNumArgs() < ExpectedNumArgs) 24771d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek return; 24781d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek 24790a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LastArg = (BId == Builtin::BImemset || 24800a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId == Builtin::BIstrndup ? 1 : 2); 24810a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned LenArg = (BId == Builtin::BIstrndup ? 1 : 2); 2482cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts(); 2483000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2484000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We have special checking when the length is a sizeof expression. 2485000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth QualType SizeOfArgTy = getSizeOfArgType(LenExpr); 2486000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth const Expr *SizeOfArg = getSizeOfExprArg(LenExpr); 2487000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID SizeOfArgID; 2488000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 248906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) { 249006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts(); 2491e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange(); 249206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 249306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType DestTy = Dest->getType(); 249406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) { 249506bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType PointeeTy = DestPtrTy->getPointeeType(); 2496f85e193739c953358c865005855253af4f68a497John McCall 2497000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Never warn about void type pointers. This can be used to suppress 2498000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // false positives. 2499000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isVoidType()) 250006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 250106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 2502000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by 2503000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // actually comparing the expressions for equality. Because computing the 2504000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // expression IDs can be expensive, we only do this if the diagnostic is 2505000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // enabled. 2506000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArg && 2507000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess, 2508000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->getExprLoc())) { 2509000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We only compute IDs for expressions if the warning is enabled, and 2510000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // cache the sizeof arg's ID. 2511000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgID == llvm::FoldingSetNodeID()) 2512000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->Profile(SizeOfArgID, Context, true); 2513000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID DestID; 2514000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Dest->Profile(DestID, Context, true); 2515000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (DestID == SizeOfArgID) { 2516cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // TODO: For strncpy() and friends, this could suggest sizeof(dst) 2517cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // over sizeof(src) as well. 2518000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth unsigned ActionIdx = 0; // Default is to suggest dereferencing. 2519000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest)) 2520000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (UnaryOp->getOpcode() == UO_AddrOf) 2521000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 1; // If its an address-of operator, just remove it. 2522000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (Context.getTypeSize(PointeeTy) == Context.getCharWidth()) 2523000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 2; // If the pointee's size is sizeof(char), 2524000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // suggest an explicit length. 2525d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks unsigned DestSrcSelect = 25260a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks (BId == Builtin::BIstrndup ? 1 : ArgIdx); 2527000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(SizeOfArg->getExprLoc(), Dest, 2528000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_expr_memaccess) 2529cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber << FnName << DestSrcSelect << ActionIdx 2530000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << Dest->getSourceRange() 2531000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << SizeOfArg->getSourceRange()); 2532000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 2533000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 2534000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 2535000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2536000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Also check for cases where the sizeof argument is the exact same 2537000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // type as the memory argument, and where it points to a user-defined 2538000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // record type. 2539000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgTy != QualType()) { 2540000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isRecordType() && 2541000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Context.typesAreCompatible(SizeOfArgTy, DestTy)) { 2542000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest, 2543000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_type_memaccess) 2544000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << FnName << SizeOfArgTy << ArgIdx 2545000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << PointeeTy << Dest->getSourceRange() 2546000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << LenExpr->getSourceRange()); 2547000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 2548000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 2549e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber } 2550e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 255106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor // Always complain about dynamic classes. 25520a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (isDynamicClassType(PointeeTy)) { 25530a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 25540a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks unsigned OperationType = 0; 25550a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // "overwritten" if we're warning about the destination for any call 25560a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks // but memcmp; otherwise a verb appropriate to the call. 25570a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (ArgIdx != 0 || BId == Builtin::BImemcmp) { 25580a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks if (BId == Builtin::BImemcpy) 25590a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 1; 25600a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if(BId == Builtin::BImemmove) 25610a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 2; 25620a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks else if (BId == Builtin::BImemcmp) 25630a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks OperationType = 3; 25640a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } 25650a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks 25665c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 25675c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 25685c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_dyn_class_memaccess) 25690a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx) 2570d9b859a74ecaede23a78d37f364498102ef418c9Anna Zaks << FnName << PointeeTy 25710a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks << OperationType 25725c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 25730a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks } else if (PointeeTy.hasNonTrivialObjCLifetime() && 25740a151a137a68bb656acbcce7ff2407613bb80cfcAnna Zaks BId != Builtin::BImemset) 25755c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 25765c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 25775c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_arc_object_memaccess) 25785c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << ArgIdx << FnName << PointeeTy 25795c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 2580f85e193739c953358c865005855253af4f68a497John McCall else 258106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 2582f85e193739c953358c865005855253af4f68a497John McCall 2583f85e193739c953358c865005855253af4f68a497John McCall DiagRuntimeBehavior( 2584f85e193739c953358c865005855253af4f68a497John McCall Dest->getExprLoc(), Dest, 2585929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth PDiag(diag::note_bad_memaccess_silence) 258606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)")); 258706bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor break; 258806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 25897ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth } 25907ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth} 25917ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 2592bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// A little helper routine: ignore addition and subtraction of integer literals. 2593bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// This intentionally does not ignore all integer constant expressions because 2594bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// we don't want to remove sizeof(). 2595bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekstatic const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) { 2596bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = Ex->IgnoreParenCasts(); 2597bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2598bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek for (;;) { 2599bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex); 2600bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!BO || !BO->isAdditiveOp()) 2601bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 2602bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2603bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *RHS = BO->getRHS()->IgnoreParenCasts(); 2604bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *LHS = BO->getLHS()->IgnoreParenCasts(); 2605bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2606bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (isa<IntegerLiteral>(RHS)) 2607bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = LHS; 2608bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else if (isa<IntegerLiteral>(LHS)) 2609bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = RHS; 2610bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else 2611bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 2612bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2613bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2614bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return Ex; 2615bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 2616bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2617bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// Warn if the user has made the 'size' argument to strlcpy or strlcat 2618bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// be the size of the source, instead of the destination. 2619bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekvoid Sema::CheckStrlcpycatArguments(const CallExpr *Call, 2620bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek IdentifierInfo *FnName) { 2621bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2622bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Don't crash if the user has the wrong number of arguments 2623bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (Call->getNumArgs() != 3) 2624bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2625bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2626bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context); 2627bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context); 2628bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *CompareWithSrc = NULL; 2629bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2630bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, sizeof(x))' 2631bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const Expr *Ex = getSizeOfExprArg(SizeArg)) 2632bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = Ex; 2633bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else { 2634bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, strlen(x))' 2635bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) { 2636180f47959a066795cc0f409433023af448bb0328Richard Smith if (SizeCall->isBuiltinCall() == Builtin::BIstrlen 2637bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek && SizeCall->getNumArgs() == 1) 2638bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context); 2639bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2640bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2641bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2642bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrc) 2643bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2644bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2645bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Determine if the argument to sizeof/strlen is equal to the source 2646bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // argument. In principle there's all kinds of things you could do 2647bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // here, for instance creating an == expression and evaluating it with 2648bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // EvaluateAsBooleanCondition, but this uses a more direct technique: 2649bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg); 2650bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!SrcArgDRE) 2651bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2652bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2653bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc); 2654bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrcDRE || 2655bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl()) 2656bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2657bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2658bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *OriginalSizeArg = Call->getArg(2); 2659bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size) 2660bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek << OriginalSizeArg->getSourceRange() << FnName; 2661bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2662bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Output a FIXIT hint if the destination is an array (rather than a 2663bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointer to an array). This could be enhanced to handle some 2664bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointers if we know the actual size, like if DstArg is 'array+2' 2665bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // we could say 'sizeof(array)-2'. 2666bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts(); 26678f7462237ff542a4556775f98709ed300aa1731aTed Kremenek QualType DstArgTy = DstArg->getType(); 2668bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 26698f7462237ff542a4556775f98709ed300aa1731aTed Kremenek // Only handle constant-sized or VLAs, but not flexible members. 26708f7462237ff542a4556775f98709ed300aa1731aTed Kremenek if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(DstArgTy)) { 26718f7462237ff542a4556775f98709ed300aa1731aTed Kremenek // Only issue the FIXIT for arrays of size > 1. 26728f7462237ff542a4556775f98709ed300aa1731aTed Kremenek if (CAT->getSize().getSExtValue() <= 1) 26738f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 26748f7462237ff542a4556775f98709ed300aa1731aTed Kremenek } else if (!DstArgTy->isVariableArrayType()) { 26758f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 2676bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 26778f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 2678f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> sizeString; 26798f7462237ff542a4556775f98709ed300aa1731aTed Kremenek llvm::raw_svector_ostream OS(sizeString); 26808f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << "sizeof("; 26818987b2385d9ba63ada66e1344ace79b04d5cb5c3Douglas Gregor DstArg->printPretty(OS, Context, 0, getPrintingPolicy()); 26828f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << ")"; 26838f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 26848f7462237ff542a4556775f98709ed300aa1731aTed Kremenek Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size) 26858f7462237ff542a4556775f98709ed300aa1731aTed Kremenek << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(), 26868f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS.str()); 2687bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 2688bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2689c36bedc90c687caa71748480c60707ea4608b092Anna Zaks/// Check if two expressions refer to the same declaration. 2690c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic bool referToTheSameDecl(const Expr *E1, const Expr *E2) { 2691c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const DeclRefExpr *D1 = dyn_cast_or_null<DeclRefExpr>(E1)) 2692c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const DeclRefExpr *D2 = dyn_cast_or_null<DeclRefExpr>(E2)) 2693c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return D1->getDecl() == D2->getDecl(); 2694c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return false; 2695c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 2696c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 2697c36bedc90c687caa71748480c60707ea4608b092Anna Zaksstatic const Expr *getStrlenExprArg(const Expr *E) { 2698c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const CallExpr *CE = dyn_cast<CallExpr>(E)) { 2699c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const FunctionDecl *FD = CE->getDirectCallee(); 2700c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (!FD || FD->getMemoryFunctionKind() != Builtin::BIstrlen) 2701c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return 0; 2702c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return CE->getArg(0)->IgnoreParenCasts(); 2703c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 2704c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return 0; 2705c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 2706c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 2707c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// Warn on anti-patterns as the 'size' argument to strncat. 2708c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// The correct size argument should look like following: 2709c36bedc90c687caa71748480c60707ea4608b092Anna Zaks// strncat(dst, src, sizeof(dst) - strlen(dest) - 1); 2710c36bedc90c687caa71748480c60707ea4608b092Anna Zaksvoid Sema::CheckStrncatArguments(const CallExpr *CE, 2711c36bedc90c687caa71748480c60707ea4608b092Anna Zaks IdentifierInfo *FnName) { 2712c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Don't crash if the user has the wrong number of arguments. 2713c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (CE->getNumArgs() < 3) 2714c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 2715c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *DstArg = CE->getArg(0)->IgnoreParenCasts(); 2716c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *SrcArg = CE->getArg(1)->IgnoreParenCasts(); 2717c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *LenArg = CE->getArg(2)->IgnoreParenCasts(); 2718c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 2719c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Identify common expressions, which are wrongly used as the size argument 2720c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // to strncat and may lead to buffer overflows. 2721c36bedc90c687caa71748480c60707ea4608b092Anna Zaks unsigned PatternType = 0; 2722c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const Expr *SizeOfArg = getSizeOfExprArg(LenArg)) { 2723c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(dst) 2724c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (referToTheSameDecl(SizeOfArg, DstArg)) 2725c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 1; 2726c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(src) 2727c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (referToTheSameDecl(SizeOfArg, SrcArg)) 2728c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 2; 2729c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } else if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(LenArg)) { 2730c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (BE->getOpcode() == BO_Sub) { 2731c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *L = BE->getLHS()->IgnoreParenCasts(); 2732c36bedc90c687caa71748480c60707ea4608b092Anna Zaks const Expr *R = BE->getRHS()->IgnoreParenCasts(); 2733c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(dst) - strlen(dst) 2734c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (referToTheSameDecl(DstArg, getSizeOfExprArg(L)) && 2735c36bedc90c687caa71748480c60707ea4608b092Anna Zaks referToTheSameDecl(DstArg, getStrlenExprArg(R))) 2736c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 1; 2737c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // - sizeof(src) - (anything) 2738c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else if (referToTheSameDecl(SrcArg, getSizeOfExprArg(L))) 2739c36bedc90c687caa71748480c60707ea4608b092Anna Zaks PatternType = 2; 2740c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 2741c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 2742c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 2743c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (PatternType == 0) 2744c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 2745c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 2746afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks // Generate the diagnostic. 2747afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceLocation SL = LenArg->getLocStart(); 2748afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceRange SR = LenArg->getSourceRange(); 2749afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SourceManager &SM = PP.getSourceManager(); 2750afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks 2751afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks // If the function is defined as a builtin macro, do not show macro expansion. 2752afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks if (SM.isMacroArgExpansion(SL)) { 2753afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SL = SM.getSpellingLoc(SL); 2754afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SR = SourceRange(SM.getSpellingLoc(SR.getBegin()), 2755afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks SM.getSpellingLoc(SR.getEnd())); 2756afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks } 2757afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks 2758c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (PatternType == 1) 2759afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::warn_strncat_large_size) << SR; 2760c36bedc90c687caa71748480c60707ea4608b092Anna Zaks else 2761afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::warn_strncat_src_size) << SR; 2762c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 2763c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Output a FIXIT hint if the destination is an array (rather than a 2764c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // pointer to an array). This could be enhanced to handle some 2765c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // pointers if we know the actual size, like if DstArg is 'array+2' 2766c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // we could say 'sizeof(array)-2'. 2767c36bedc90c687caa71748480c60707ea4608b092Anna Zaks QualType DstArgTy = DstArg->getType(); 2768c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 2769c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Only handle constant-sized or VLAs, but not flexible members. 2770c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(DstArgTy)) { 2771c36bedc90c687caa71748480c60707ea4608b092Anna Zaks // Only issue the FIXIT for arrays of size > 1. 2772c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (CAT->getSize().getSExtValue() <= 1) 2773c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 2774c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } else if (!DstArgTy->isVariableArrayType()) { 2775c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 2776c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 2777c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 2778f7ccbad5d9949e7ddd1cbef43d482553b811e026Dylan Noblesmith SmallString<128> sizeString; 2779c36bedc90c687caa71748480c60707ea4608b092Anna Zaks llvm::raw_svector_ostream OS(sizeString); 2780c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << "sizeof("; 2781c36bedc90c687caa71748480c60707ea4608b092Anna Zaks DstArg->printPretty(OS, Context, 0, getPrintingPolicy()); 2782c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << ") - "; 2783c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << "strlen("; 2784c36bedc90c687caa71748480c60707ea4608b092Anna Zaks DstArg->printPretty(OS, Context, 0, getPrintingPolicy()); 2785c36bedc90c687caa71748480c60707ea4608b092Anna Zaks OS << ") - 1"; 2786c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 2787afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks Diag(SL, diag::note_strncat_wrong_size) 2788afdb041308bca3e875b23e7a22d879e9039bff03Anna Zaks << FixItHint::CreateReplacement(SR, OS.str()); 2789c36bedc90c687caa71748480c60707ea4608b092Anna Zaks} 2790c36bedc90c687caa71748480c60707ea4608b092Anna Zaks 279106de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===// 279206de276fff91264437fa75111ed76de43097e089Ted Kremenek 27935f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars); 27945f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars); 279506de276fff91264437fa75111ed76de43097e089Ted Kremenek 279606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address 279706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable. 279806de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid 279906de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 280006de276fff91264437fa75111ed76de43097e089Ted Kremenek SourceLocation ReturnLoc) { 28011eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 280226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Expr *stackE = 0; 28035f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<DeclRefExpr *, 8> refVars; 28044e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 280526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Perform checking for returned stack addresses, local blocks, 280626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // label addresses or references to temporaries. 2807f85e193739c953358c865005855253af4f68a497John McCall if (lhsType->isPointerType() || 2808f85e193739c953358c865005855253af4f68a497John McCall (!getLangOptions().ObjCAutoRefCount && lhsType->isBlockPointerType())) { 280926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalAddr(RetValExp, refVars); 2810ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (lhsType->isReferenceType()) { 281126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalVal(RetValExp, refVars); 281226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 281326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 281426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (stackE == 0) 281526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return; // Nothing suspicious was found. 281626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 281726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceLocation diagLoc; 281826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange diagRange; 281926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (refVars.empty()) { 282026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = stackE->getLocStart(); 282126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = stackE->getSourceRange(); 282226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { 282326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // We followed through a reference variable. 'stackE' contains the 282426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // problematic expression but we will warn at the return statement pointing 282526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // at the reference variable. We will later display the "trail" of 282626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // reference variables using notes. 282726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = refVars[0]->getLocStart(); 282826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = refVars[0]->getSourceRange(); 282926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 283026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 283126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var. 283226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref 283326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_stack_addr) 283426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << DR->getDecl()->getDeclName() << diagRange; 283526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<BlockExpr>(stackE)) { // local block. 283626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::err_ret_local_block) << diagRange; 283726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 283826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 283926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { // local temporary. 284026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref 284126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_local_temp_addr) 284226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << diagRange; 284326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 284426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 284526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Display the "trail" of reference variables that we followed until we 284626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // found the problematic expression using notes. 284726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 284826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 284926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this var binds to another reference var, show the range of the next 285026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // var, otherwise the var binds to the problematic expression, in which case 285126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // show the range of the expression. 285226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange() 285326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : stackE->getSourceRange(); 285426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(VD->getLocation(), diag::note_ref_var_local_bind) 285526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << VD->getDeclName() << range; 285606de276fff91264437fa75111ed76de43097e089Ted Kremenek } 285706de276fff91264437fa75111ed76de43097e089Ted Kremenek} 285806de276fff91264437fa75111ed76de43097e089Ted Kremenek 285906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 286006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// check if the expression in a return statement evaluates to an address 286126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// to a location on the stack, a local block, an address of a label, or a 286226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// reference to local temporary. The recursion is used to traverse the 286306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// AST of the return expression, with recursion backtracking when we 286426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// encounter a subexpression that (1) clearly does not lead to one of the 286526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// above problematic expressions (2) is something we cannot determine leads to 286626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// a problematic expression based on such local checking. 286726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 286826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// Both EvalAddr and EvalVal follow through reference variables to evaluate 286926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// the expression that they point to. Such variables are added to the 287026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 'refVars' vector so that we know what the reference variable "trail" was. 287106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 2872e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// EvalAddr processes expressions that are pointers that are used as 2873e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// references (and not L-values). EvalVal handles all other values. 287426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// At the base case of the recursion is a check for the above problematic 287526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// expressions. 287606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 287706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// This implementation handles: 287806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 287906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer-to-pointer casts 288006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * implicit conversions from array references to pointers 288106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of fields 288206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * arbitrary interplay between "&" and "*" operators 288306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer arithmetic from an address of a stack variable 288406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of an array element where the array is on the stack 28855f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars) { 288626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (E->isTypeDependent()) 288726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 288826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 288906de276fff91264437fa75111ed76de43097e089Ted Kremenek // We should only be called for evaluating pointer expressions. 28900f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall assert((E->getType()->isAnyPointerType() || 2891dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff E->getType()->isBlockPointerType() || 2892a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek E->getType()->isObjCQualifiedIdType()) && 2893fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner "EvalAddr only works on pointers"); 28941eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2895f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 2896f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 289706de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 289806de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 289906de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 290006de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 290126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::DeclRefExprClass: { 290226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis DeclRefExpr *DR = cast<DeclRefExpr>(E); 290326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 290426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 290526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this is a reference variable, follow through to the expression that 290626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 290726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage() && 290826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis V->getType()->isReferenceType() && V->hasInit()) { 290926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 291026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 291126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(V->getInit(), refVars); 291226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 291326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 291426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 291526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 291606de276fff91264437fa75111ed76de43097e089Ted Kremenek 2917fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::UnaryOperatorClass: { 2918fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // The only unary operator that make sense to handle here 2919fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // is AddrOf. All others don't make sense as pointers. 2920fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner UnaryOperator *U = cast<UnaryOperator>(E); 29211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 29222de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_AddrOf) 292326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(U->getSubExpr(), refVars); 2924fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 2925fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 2926fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 29271eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2928fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::BinaryOperatorClass: { 2929fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle pointer arithmetic. All other binary operators are not valid 2930fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // in this context. 2931fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner BinaryOperator *B = cast<BinaryOperator>(E); 29322de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = B->getOpcode(); 29331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 29342de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op != BO_Add && op != BO_Sub) 2935fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 29361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2937fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner Expr *Base = B->getLHS(); 29383907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 2939fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Determine which argument is the real pointer base. It could be 2940fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // the RHS argument instead of the LHS. 2941fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner if (!Base->getType()->isPointerType()) Base = B->getRHS(); 29421eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2943fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner assert (Base->getType()->isPointerType()); 294426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(Base, refVars); 2945fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 294661f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff 2947fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // For conditional operators we need to see if either the LHS or RHS are 2948fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // valid DeclRefExpr*s. If one of them is valid, we return it. 2949fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ConditionalOperatorClass: { 2950fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner ConditionalOperator *C = cast<ConditionalOperator>(E); 29511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2952fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle the GNU extension for missing LHS. 29539ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (Expr *lhsExpr = C->getLHS()) { 29549ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 29559ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (!lhsExpr->getType()->isVoidType()) 295626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr* LHS = EvalAddr(lhsExpr, refVars)) 29579ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return LHS; 29589ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor } 29599ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor 29609ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 29619ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (C->getRHS()->getType()->isVoidType()) 29629ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return NULL; 296306de276fff91264437fa75111ed76de43097e089Ted Kremenek 296426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(C->getRHS(), refVars); 2965fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 296626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 296726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::BlockExprClass: 2968469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures()) 296926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // local block. 297026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 297126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 297226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::AddrLabelExprClass: 297326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // address of label. 29741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 297580ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 297680ee6e878a169e6255d4686a91bb696151ff229fJohn McCall return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars); 297780ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 297854b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // For casts, we need to handle conversions from arrays to 297954b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // pointer values, and pointer-to-pointer conversions. 298049badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::ImplicitCastExprClass: 29816eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor case Stmt::CStyleCastExprClass: 2982f85e193739c953358c865005855253af4f68a497John McCall case Stmt::CXXFunctionalCastExprClass: 2983f85e193739c953358c865005855253af4f68a497John McCall case Stmt::ObjCBridgedCastExprClass: { 29840835a3cdeefe714b4959d31127ea155e56393125Argyrios Kyrtzidis Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 298554b5274f2c190331438375ad114dad12ae098b57Ted Kremenek QualType T = SubExpr->getType(); 29861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2987dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (SubExpr->getType()->isPointerType() || 2988dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isBlockPointerType() || 2989dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isObjCQualifiedIdType()) 299026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(SubExpr, refVars); 299154b5274f2c190331438375ad114dad12ae098b57Ted Kremenek else if (T->isArrayType()) 299226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(SubExpr, refVars); 2993fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 299454b5274f2c190331438375ad114dad12ae098b57Ted Kremenek return 0; 2995fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 29961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2997fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // C++ casts. For dynamic casts, static casts, and const casts, we 2998fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // are always converting from a pointer-to-pointer, so we just blow 299949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // through the cast. In the case the dynamic cast doesn't fail (and 300049badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // return NULL), we take the conservative route and report cases 3001fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // where we return the address of a stack variable. For Reinterpre 300249badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // FIXME: The comment about is wrong; we're not always converting 300349badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // from pointer to pointer. I'm guessing that this code should also 30041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // handle references to objects. 30051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXStaticCastExprClass: 30061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXDynamicCastExprClass: 300749badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXConstCastExprClass: 300849badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXReinterpretCastExprClass: { 300949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr(); 3010dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (S->getType()->isPointerType() || S->getType()->isBlockPointerType()) 301126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(S, refVars); 301206de276fff91264437fa75111ed76de43097e089Ted Kremenek else 301306de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 3014fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 30151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 301603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 301703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalAddr( 301803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 301903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor refVars)) 302003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 302103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 302203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 302303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 3024fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Everything else: we simply don't reason about them. 3025fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner default: 3026fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 302706de276fff91264437fa75111ed76de43097e089Ted Kremenek } 302806de276fff91264437fa75111ed76de43097e089Ted Kremenek} 30291eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 303006de276fff91264437fa75111ed76de43097e089Ted Kremenek 303106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalVal - This function is complements EvalAddr in the mutual recursion. 303206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// See the comments for EvalAddr for more details. 30335f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars) { 303468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo { 3035e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // We should only be called for evaluating non-pointer expressions, or 3036e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // expressions with a pointer type that are not used as references but instead 3037e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // are l-values (e.g., DeclRefExpr with a pointer type). 30381eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 303906de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 304006de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 304106de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 3042f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 3043f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 304406de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 304568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ImplicitCastExprClass: { 304668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 30475baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall if (IE->getValueKind() == VK_LValue) { 304868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = IE->getSubExpr(); 304968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 305068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 305168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek return NULL; 305268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 305368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek 305480ee6e878a169e6255d4686a91bb696151ff229fJohn McCall case Stmt::ExprWithCleanupsClass: 305580ee6e878a169e6255d4686a91bb696151ff229fJohn McCall return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars); 305680ee6e878a169e6255d4686a91bb696151ff229fJohn McCall 3057a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor case Stmt::DeclRefExprClass: { 305826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // When we hit a DeclRefExpr we are looking at code that refers to a 305926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // variable's name. If it's not a reference variable we check if it has 306026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // local storage within the function, and if so, return the expression. 306106de276fff91264437fa75111ed76de43097e089Ted Kremenek DeclRefExpr *DR = cast<DeclRefExpr>(E); 30621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 306306de276fff91264437fa75111ed76de43097e089Ted Kremenek if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 306426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage()) { 306526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!V->getType()->isReferenceType()) 306626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return DR; 306726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 306826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Reference variable, follow through to the expression that 306926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 307026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasInit()) { 307126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 307226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 307326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(V->getInit(), refVars); 307426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 307526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 30761eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 307706de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 307806de276fff91264437fa75111ed76de43097e089Ted Kremenek } 30791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 308006de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::UnaryOperatorClass: { 308106de276fff91264437fa75111ed76de43097e089Ted Kremenek // The only unary operator that make sense to handle here 308206de276fff91264437fa75111ed76de43097e089Ted Kremenek // is Deref. All others don't resolve to a "name." This includes 308306de276fff91264437fa75111ed76de43097e089Ted Kremenek // handling all sorts of rvalues passed to a unary operator. 308406de276fff91264437fa75111ed76de43097e089Ted Kremenek UnaryOperator *U = cast<UnaryOperator>(E); 30851eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 30862de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_Deref) 308726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(U->getSubExpr(), refVars); 308806de276fff91264437fa75111ed76de43097e089Ted Kremenek 308906de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 309006de276fff91264437fa75111ed76de43097e089Ted Kremenek } 30911eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 309206de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ArraySubscriptExprClass: { 309306de276fff91264437fa75111ed76de43097e089Ted Kremenek // Array subscripts are potential references to data on the stack. We 309406de276fff91264437fa75111ed76de43097e089Ted Kremenek // retrieve the DeclRefExpr* for the array variable if it indeed 309506de276fff91264437fa75111ed76de43097e089Ted Kremenek // has local storage. 309626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars); 309706de276fff91264437fa75111ed76de43097e089Ted Kremenek } 30981eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 309906de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ConditionalOperatorClass: { 310006de276fff91264437fa75111ed76de43097e089Ted Kremenek // For conditional operators we need to see if either the LHS or RHS are 310126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // non-NULL Expr's. If one is non-NULL, we return it. 310206de276fff91264437fa75111ed76de43097e089Ted Kremenek ConditionalOperator *C = cast<ConditionalOperator>(E); 310306de276fff91264437fa75111ed76de43097e089Ted Kremenek 31043907323dd6665c0c4e383435cb145233f4533406Anders Carlsson // Handle the GNU extension for missing LHS. 31053907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (Expr *lhsExpr = C->getLHS()) 310626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr *LHS = EvalVal(lhsExpr, refVars)) 31073907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return LHS; 31083907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 310926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(C->getRHS(), refVars); 311006de276fff91264437fa75111ed76de43097e089Ted Kremenek } 31111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 311206de276fff91264437fa75111ed76de43097e089Ted Kremenek // Accesses to members are potential references to data on the stack. 311383f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor case Stmt::MemberExprClass: { 311406de276fff91264437fa75111ed76de43097e089Ted Kremenek MemberExpr *M = cast<MemberExpr>(E); 31151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 311606de276fff91264437fa75111ed76de43097e089Ted Kremenek // Check for indirect access. We only want direct field accesses. 3117a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->isArrow()) 3118a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return NULL; 3119a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 3120a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // Check whether the member type is itself a reference, in which case 3121a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // we're not going to refer to the member, but to what the member refers to. 3122a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->getMemberDecl()->getType()->isReferenceType()) 312306de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 3124a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 312526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(M->getBase(), refVars); 312606de276fff91264437fa75111ed76de43097e089Ted Kremenek } 31271eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 312803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 312903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalVal( 313003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 313103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor refVars)) 313203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 313303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 313403e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 313503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 313606de276fff91264437fa75111ed76de43097e089Ted Kremenek default: 313726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Check that we don't return or take the address of a reference to a 313826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // temporary. This is only useful in C++. 313926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!E->isTypeDependent() && E->isRValue()) 314026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; 314126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 314226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Everything else: we simply don't reason about them. 314306de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 314406de276fff91264437fa75111ed76de43097e089Ted Kremenek } 314568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true); 314606de276fff91264437fa75111ed76de43097e089Ted Kremenek} 3147588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3148588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 3149588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3150588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==. 3151588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely 3152588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended. 3153dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieuvoid Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) { 3154588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek bool EmitWarning = true; 31551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3156dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts(); 3157dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* RightExprSansParen = RHS->IgnoreParenImpCasts(); 3158588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 3159588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Special case: check for x == x (which is OK). 3160588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Do not emit warnings for such cases. 3161588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 3162588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 3163588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DRL->getDecl() == DRR->getDecl()) 3164588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 31651eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 31661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 31671b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // Special case: check for comparisons against literals that can be exactly 31681b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // represented by APFloat. In such cases, do not emit a warning. This 31691b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // is a heuristic: often comparison against such literals are used to 31701b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // detect if a value in a variable has not changed. This clearly can 31711b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // lead to false negatives. 31721b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (EmitWarning) { 31731b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 31741b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLL->isExact()) 31751b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 3176ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else 31771b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){ 31781b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLR->isExact()) 31791b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 31801b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 31811b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 31821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3183588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Check for comparisons with builtin types. 31840eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 3185588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 3186180f47959a066795cc0f409433023af448bb0328Richard Smith if (CL->isBuiltinCall()) 3187588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 31881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 31890eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 3190588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 3191180f47959a066795cc0f409433023af448bb0328Richard Smith if (CR->isBuiltinCall()) 3192588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 31931eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3194588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Emit the diagnostic. 3195588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (EmitWarning) 3196dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Diag(Loc, diag::warn_floatingpoint_eq) 3197dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu << LHS->getSourceRange() << RHS->getSourceRange(); 3198588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek} 3199ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3200f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 3201f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 3202ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3203f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace { 3204ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3205f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued 3206f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression. 3207f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange { 3208f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// The number of bits active in the int. 3209f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned Width; 3210ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3211f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// True if the int is known not to have negative values. 3212f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool NonNegative; 321351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3214f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange(unsigned Width, bool NonNegative) 3215f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : Width(Width), NonNegative(NonNegative) 3216f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall {} 321751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 32181844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of the bool type. 3219f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall static IntRange forBoolType() { 3220f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(1, true); 3221f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 322251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 32231844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of the given integral type. 32241844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfType(ASTContext &C, QualType T) { 32251844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return forValueOfCanonicalType(C, 32261844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T->getCanonicalTypeInternal().getTypePtr()); 322751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 322851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 32291844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of a canonical integral type. 32301844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 3231f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(T->isCanonicalUnqualified()); 323251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3233f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 3234f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = VT->getElementType().getTypePtr(); 3235f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 3236f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = CT->getElementType().getTypePtr(); 3237323ed74658bc8375278eabf074b4777458376540John McCall 3238091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // For enum types, use the known bit width of the enumerators. 3239323ed74658bc8375278eabf074b4777458376540John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) { 3240323ed74658bc8375278eabf074b4777458376540John McCall EnumDecl *Enum = ET->getDecl(); 32415e1cdac63c3d9c9b32fa41fa0b2d242a58a20d49John McCall if (!Enum->isCompleteDefinition()) 3242091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return IntRange(C.getIntWidth(QualType(T, 0)), false); 3243091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3244323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumPositive = Enum->getNumPositiveBits(); 3245323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumNegative = Enum->getNumNegativeBits(); 3246323ed74658bc8375278eabf074b4777458376540John McCall 3247323ed74658bc8375278eabf074b4777458376540John McCall return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0); 3248323ed74658bc8375278eabf074b4777458376540John McCall } 324951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3250f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const BuiltinType *BT = cast<BuiltinType>(T); 3251f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(BT->isInteger()); 325251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3253f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 325451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 325551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 32561844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the "target" range of a canonical integral type, i.e. 32571844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// the range of values expressible in the type. 32581844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// 32591844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// This matches forValueOfCanonicalType except that enums have the 32601844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// full range of their type, not the range of their enumerators. 32611844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 32621844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(T->isCanonicalUnqualified()); 32631844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 32641844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 32651844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = VT->getElementType().getTypePtr(); 32661844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 32671844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = CT->getElementType().getTypePtr(); 32681844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) 326969ff26bd1e7a2faffec0c3b9740cfb0c6bb354c5Douglas Gregor T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr(); 32701844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 32711844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall const BuiltinType *BT = cast<BuiltinType>(T); 32721844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(BT->isInteger()); 32731844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 32741844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 32751844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall } 32761844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 32771844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the supremum of two ranges: i.e. their conservative merge. 3278c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange join(IntRange L, IntRange R) { 3279f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(std::max(L.Width, R.Width), 328060fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative && R.NonNegative); 328160fad45739b764886f707bd204eae9ecce6db1f2John McCall } 328260fad45739b764886f707bd204eae9ecce6db1f2John McCall 32831844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the infinum of two ranges: i.e. their aggressive merge. 3284c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange meet(IntRange L, IntRange R) { 328560fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange(std::min(L.Width, R.Width), 328660fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative || R.NonNegative); 328751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 3288f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}; 328951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 32900692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, llvm::APSInt &value, 32910692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek unsigned MaxWidth) { 3292f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isSigned() && value.isNegative()) 3293f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getMinSignedBits(), false); 329451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3295f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.getBitWidth() > MaxWidth) 32969f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad value = value.trunc(MaxWidth); 329751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3298f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // isNonNegative() just checks the sign bit without considering 3299f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // signedness. 3300f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getActiveBits(), true); 330151313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 330251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 33030692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 33040692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek unsigned MaxWidth) { 3305f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isInt()) 3306f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetValueRange(C, result.getInt(), MaxWidth); 330751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3308f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isVector()) { 33090acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 33100acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 33110acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 33120acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall R = IntRange::join(R, El); 33130acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall } 3314f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return R; 331551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 331651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3317f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isComplexInt()) { 3318f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 3319f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 3320f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(R, I); 3321f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 3322f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3323f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // This can happen with lossless casts to intptr_t of "based" lvalues. 3324f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume it might use arbitrary bits. 33250acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // FIXME: The only reason we need to pass the type in here is to get 33260acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // the sign right on this one case. It would be nice if APValue 33270acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // preserved this. 332865639284118d54ddf2e51a05d2ffccda567fe246Eli Friedman assert(result.isLValue() || result.isAddrLabelDiff()); 33295e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType()); 333051313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 333151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3332f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the 3333f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take. 3334f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 3335f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated 33360692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 333751313c39c84407dd6a323be99a8c322bf8d052a9John McCall E = E->IgnoreParens(); 333851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3339f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Try a full evaluation first. 3340f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall Expr::EvalResult result; 334151f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, C)) 33420acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall return GetValueRange(C, result.Val, E->getType(), MaxWidth); 334351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3344f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // I think we only want to look through implicit casts here; if the 3345f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // user has an explicit widening cast, we should treat the value as 3346f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // being of the new, wider type. 3347f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 3348b17ee5bff0d7986c14cdddb279e0131bd7f9678dEli Friedman if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue) 3349f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CE->getSubExpr(), MaxWidth); 335051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 33511844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType()); 335251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 33532de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 335460fad45739b764886f707bd204eae9ecce6db1f2John McCall 3355f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume that non-integer casts can span the full range of the type. 335660fad45739b764886f707bd204eae9ecce6db1f2John McCall if (!isIntegerCast) 3357f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 335851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3359f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange SubRange 3360f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall = GetExprRange(C, CE->getSubExpr(), 3361f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall std::min(MaxWidth, OutputTypeRange.Width)); 336251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3363f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Bail out if the subexpr's range is as wide as the cast type. 3364f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SubRange.Width >= OutputTypeRange.Width) 3365f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 336651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3367f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, we take the smaller width, and we're non-negative if 3368f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // either the output type or the subexpr is. 3369f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(SubRange.Width, 3370f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall SubRange.NonNegative || OutputTypeRange.NonNegative); 3371f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 3372f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3373f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 3374f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // If we can fold the condition, just take that operand. 3375f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool CondResult; 3376f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 3377f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CondResult ? CO->getTrueExpr() 3378f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : CO->getFalseExpr(), 3379f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall MaxWidth); 3380f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3381f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, conservatively merge. 3382f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 3383f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 3384f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 338551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 338651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 338751313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 338851313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (BO->getOpcode()) { 338951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3390f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Boolean-valued operations are single-bit and positive. 33912de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LAnd: 33922de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LOr: 33932de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LT: 33942de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GT: 33952de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LE: 33962de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GE: 33972de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_EQ: 33982de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_NE: 3399f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 340051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3401862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // The type of the assignments is the type of the LHS, so the RHS 3402862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // is not necessarily the same type. 34032de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_MulAssign: 34042de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_DivAssign: 34052de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_RemAssign: 34062de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AddAssign: 34072de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_SubAssign: 3408862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_XorAssign: 3409862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_OrAssign: 3410862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 34111844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 3412c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall 3413862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // Simple assignments just pass through the RHS, which will have 3414862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // been coerced to the LHS type. 3415862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_Assign: 3416862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 3417862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 3418862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall 341951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 34202de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemD: 34212de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemI: 34221844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 342351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 342460fad45739b764886f707bd204eae9ecce6db1f2John McCall // Bitwise-and uses the *infinum* of the two source ranges. 34252de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_And: 34262de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AndAssign: 342760fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 342860fad45739b764886f707bd204eae9ecce6db1f2John McCall GetExprRange(C, BO->getRHS(), MaxWidth)); 342960fad45739b764886f707bd204eae9ecce6db1f2John McCall 343051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Left shift gets black-listed based on a judgement call. 34312de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shl: 34323aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // ...except that we want to treat '1 << (blah)' as logically 34333aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // positive. It's an important idiom. 34343aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (IntegerLiteral *I 34353aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 34363aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (I->getValue() == 1) { 34371844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange R = IntRange::forValueOfType(C, E->getType()); 34383aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall return IntRange(R.Width, /*NonNegative*/ true); 34393aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 34403aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 34413aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // fallthrough 34423aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall 34432de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShlAssign: 34441844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 344551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 344660fad45739b764886f707bd204eae9ecce6db1f2John McCall // Right shift by a constant can narrow its left argument. 34472de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shr: 34482de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShrAssign: { 344960fad45739b764886f707bd204eae9ecce6db1f2John McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 345060fad45739b764886f707bd204eae9ecce6db1f2John McCall 345160fad45739b764886f707bd204eae9ecce6db1f2John McCall // If the shift amount is a positive constant, drop the width by 345260fad45739b764886f707bd204eae9ecce6db1f2John McCall // that much. 345360fad45739b764886f707bd204eae9ecce6db1f2John McCall llvm::APSInt shift; 345460fad45739b764886f707bd204eae9ecce6db1f2John McCall if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 345560fad45739b764886f707bd204eae9ecce6db1f2John McCall shift.isNonNegative()) { 345660fad45739b764886f707bd204eae9ecce6db1f2John McCall unsigned zext = shift.getZExtValue(); 345760fad45739b764886f707bd204eae9ecce6db1f2John McCall if (zext >= L.Width) 345860fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width = (L.NonNegative ? 0 : 1); 345960fad45739b764886f707bd204eae9ecce6db1f2John McCall else 346060fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width -= zext; 346160fad45739b764886f707bd204eae9ecce6db1f2John McCall } 346260fad45739b764886f707bd204eae9ecce6db1f2John McCall 346360fad45739b764886f707bd204eae9ecce6db1f2John McCall return L; 346460fad45739b764886f707bd204eae9ecce6db1f2John McCall } 346560fad45739b764886f707bd204eae9ecce6db1f2John McCall 346660fad45739b764886f707bd204eae9ecce6db1f2John McCall // Comma acts as its right operand. 34672de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Comma: 3468f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 3469f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 347060fad45739b764886f707bd204eae9ecce6db1f2John McCall // Black-list pointer subtractions. 34712de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Sub: 347251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BO->getLHS()->getType()->isPointerType()) 34731844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 347400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall break; 347500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 347600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The width of a division result is mostly determined by the size 347700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // of the LHS. 347800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Div: { 347900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 348000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 348100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 348200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 348300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // If the divisor is constant, use that. 348400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall llvm::APSInt divisor; 348500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) { 348600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned log2 = divisor.logBase2(); // floor(log_2(divisor)) 348700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (log2 >= L.Width) 348800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = (L.NonNegative ? 0 : 1); 348900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall else 349000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = std::min(L.Width - log2, MaxWidth); 349100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return L; 349200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 349300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 349400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Otherwise, just use the LHS's width. 349500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 349600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return IntRange(L.Width, L.NonNegative && R.NonNegative); 349700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 349800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 349900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The result of a remainder can't be larger than the result of 350000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // either side. 350100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Rem: { 350200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 350300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 350400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 350500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 350600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 350700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange meet = IntRange::meet(L, R); 350800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall meet.Width = std::min(meet.Width, MaxWidth); 350900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return meet; 351000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 35114e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 351200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default behavior is okay for these. 351300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Mul: 351400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Add: 351500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Xor: 351600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Or: 3517f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall break; 351851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 3519f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 352000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default case is to treat the operation as if it were closed 352100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // on the narrowest type that encompasses both operands. 3522f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 3523f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 3524f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 352551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 352651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 352751313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 352851313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (UO->getOpcode()) { 352951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Boolean-valued operations are white-listed. 35302de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_LNot: 3531f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 353251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 353351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 35342de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_Deref: 35352de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_AddrOf: // should be impossible 35361844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 353751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 353851313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 3539f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, UO->getSubExpr(), MaxWidth); 354051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 354151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 35428ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor 35438ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor if (dyn_cast<OffsetOfExpr>(E)) { 35441844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange::forValueOfType(C, E->getType()); 35458ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor } 354651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3547a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith if (FieldDecl *BitField = E->getBitField()) 3548a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith return IntRange(BitField->getBitWidthValue(C), 35495e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor BitField->getType()->isUnsignedIntegerOrEnumerationType()); 3550f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 35511844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 3552f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 3553f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 35540692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic IntRange GetExprRange(ASTContext &C, Expr *E) { 3555323ed74658bc8375278eabf074b4777458376540John McCall return GetExprRange(C, E, C.getIntWidth(E->getType())); 3556323ed74658bc8375278eabf074b4777458376540John McCall} 3557323ed74658bc8375278eabf074b4777458376540John McCall 3558f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 3559f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 3560f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 35610692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const llvm::APFloat &value, 35620692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Src, 35630692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Tgt) { 3564f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APFloat truncated = value; 3565f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3566f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool ignored; 3567f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 3568f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 3569f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3570f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return truncated.bitwiseIsEqual(value); 357151313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 357251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3573f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 3574f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 3575f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 3576f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 3577f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number). 35780692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool IsSameFloatAfterCast(const APValue &value, 35790692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Src, 35800692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek const llvm::fltSemantics &Tgt) { 3581f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isFloat()) 3582f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 3583f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3584f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isVector()) { 3585f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 3586f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 3587f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return false; 3588f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return true; 3589f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 3590f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3591f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(value.isComplexFloat()); 3592f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 3593f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 3594f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 3595f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 35960692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 3597323ed74658bc8375278eabf074b4777458376540John McCall 3598e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) { 3599e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where we are comparing against an enum constant. 3600e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (const DeclRefExpr *DR = 3601e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 3602e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (isa<EnumConstantDecl>(DR->getDecl())) 3603e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 3604e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 3605e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where the '0' value is expanded from a macro. 3606e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (E->getLocStart().isMacroID()) 3607e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 3608e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 3609323ed74658bc8375278eabf074b4777458376540John McCall llvm::APSInt Value; 3610323ed74658bc8375278eabf074b4777458376540John McCall return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 3611323ed74658bc8375278eabf074b4777458376540John McCall} 3612323ed74658bc8375278eabf074b4777458376540John McCall 3613372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) { 3614372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall // Strip off implicit integral promotions. 3615372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 361663b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis if (ICE->getCastKind() != CK_IntegralCast && 361763b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis ICE->getCastKind() != CK_NoOp) 3618372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall break; 361963b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis E = ICE->getSubExpr(); 3620372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall } 3621372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 3622372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall return E->getType()->isEnumeralType(); 3623372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall} 3624372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 36250692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 36262de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = E->getOpcode(); 362714af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor if (E->isValueDependent()) 362814af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor return; 362914af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor 36302de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op == BO_LT && IsZero(S, E->getRHS())) { 3631323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 3632372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "< 0" << "false" << HasEnumType(E->getLHS()) 3633323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 36342de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GE && IsZero(S, E->getRHS())) { 3635323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 3636372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << ">= 0" << "true" << HasEnumType(E->getLHS()) 3637323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 36382de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GT && IsZero(S, E->getLHS())) { 3639323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 3640372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 >" << "false" << HasEnumType(E->getRHS()) 3641323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 36422de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_LE && IsZero(S, E->getLHS())) { 3643323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 3644372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 <=" << "true" << HasEnumType(E->getRHS()) 3645323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 3646323ed74658bc8375278eabf074b4777458376540John McCall } 3647323ed74658bc8375278eabf074b4777458376540John McCall} 3648323ed74658bc8375278eabf074b4777458376540John McCall 3649323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison. Implements the 3650323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison. 36510692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 3652b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 3653b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 3654323ed74658bc8375278eabf074b4777458376540John McCall} 3655f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3656ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare. 3657ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// 3658dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu/// \param E the binary operator to check for warnings 36590692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeComparison(Sema &S, BinaryOperator *E) { 3660323ed74658bc8375278eabf074b4777458376540John McCall // The type the comparison is being performed in. 3661323ed74658bc8375278eabf074b4777458376540John McCall QualType T = E->getLHS()->getType(); 3662323ed74658bc8375278eabf074b4777458376540John McCall assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 3663323ed74658bc8375278eabf074b4777458376540John McCall && "comparison with mismatched types"); 3664323ed74658bc8375278eabf074b4777458376540John McCall 3665323ed74658bc8375278eabf074b4777458376540John McCall // We don't do anything special if this isn't an unsigned integral 3666323ed74658bc8375278eabf074b4777458376540John McCall // comparison: we're only interested in integral comparisons, and 3667323ed74658bc8375278eabf074b4777458376540John McCall // signed comparisons only happen in cases we don't care to warn about. 36683e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // 36693e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // We also don't care about value-dependent expressions or expressions 36703e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // whose result is a constant. 36713e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor if (!T->hasUnsignedIntegerRepresentation() 36723e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor || E->isValueDependent() || E->isIntegerConstantExpr(S.Context)) 3673323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 3674323ed74658bc8375278eabf074b4777458376540John McCall 3675dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr *LHS = E->getLHS()->IgnoreParenImpCasts(); 3676dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr *RHS = E->getRHS()->IgnoreParenImpCasts(); 3677323ed74658bc8375278eabf074b4777458376540John McCall 3678323ed74658bc8375278eabf074b4777458376540John McCall // Check to see if one of the (unmodified) operands is of different 3679323ed74658bc8375278eabf074b4777458376540John McCall // signedness. 3680323ed74658bc8375278eabf074b4777458376540John McCall Expr *signedOperand, *unsignedOperand; 3681dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu if (LHS->getType()->hasSignedIntegerRepresentation()) { 3682dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu assert(!RHS->getType()->hasSignedIntegerRepresentation() && 3683323ed74658bc8375278eabf074b4777458376540John McCall "unsigned comparison between two signed integer expressions?"); 3684dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = LHS; 3685dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = RHS; 3686dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu } else if (RHS->getType()->hasSignedIntegerRepresentation()) { 3687dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = RHS; 3688dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = LHS; 3689ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } else { 3690323ed74658bc8375278eabf074b4777458376540John McCall CheckTrivialUnsignedComparison(S, E); 3691323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 3692ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } 3693ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3694323ed74658bc8375278eabf074b4777458376540John McCall // Otherwise, calculate the effective range of the signed operand. 3695323ed74658bc8375278eabf074b4777458376540John McCall IntRange signedRange = GetExprRange(S.Context, signedOperand); 3696f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3697323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and analyze implicit conversions in the operands. Note 3698323ed74658bc8375278eabf074b4777458376540John McCall // that we skip the implicit conversions on both sides. 3699dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc()); 3700dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc()); 3701ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3702323ed74658bc8375278eabf074b4777458376540John McCall // If the signed range is non-negative, -Wsign-compare won't fire, 3703323ed74658bc8375278eabf074b4777458376540John McCall // but we should still check for comparisons which are always true 3704323ed74658bc8375278eabf074b4777458376540John McCall // or false. 3705323ed74658bc8375278eabf074b4777458376540John McCall if (signedRange.NonNegative) 3706323ed74658bc8375278eabf074b4777458376540John McCall return CheckTrivialUnsignedComparison(S, E); 3707ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3708ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // For (in)equality comparisons, if the unsigned operand is a 3709ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // constant which cannot collide with a overflowed signed operand, 3710ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // then reinterpreting the signed operand as unsigned will not 3711ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // change the result of the comparison. 3712323ed74658bc8375278eabf074b4777458376540John McCall if (E->isEqualityOp()) { 3713323ed74658bc8375278eabf074b4777458376540John McCall unsigned comparisonWidth = S.Context.getIntWidth(T); 3714323ed74658bc8375278eabf074b4777458376540John McCall IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 3715323ed74658bc8375278eabf074b4777458376540John McCall 3716323ed74658bc8375278eabf074b4777458376540John McCall // We should never be unable to prove that the unsigned operand is 3717323ed74658bc8375278eabf074b4777458376540John McCall // non-negative. 3718323ed74658bc8375278eabf074b4777458376540John McCall assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 3719ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3720323ed74658bc8375278eabf074b4777458376540John McCall if (unsignedRange.Width < comparisonWidth) 3721323ed74658bc8375278eabf074b4777458376540John McCall return; 3722323ed74658bc8375278eabf074b4777458376540John McCall } 3723323ed74658bc8375278eabf074b4777458376540John McCall 3724323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison) 3725dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu << LHS->getType() << RHS->getType() 3726dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu << LHS->getSourceRange() << RHS->getSourceRange(); 3727ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall} 3728ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 372915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield. 373015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// 373115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt. 37320692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 37330692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenek SourceLocation InitLoc) { 373415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall assert(Bitfield->isBitField()); 373515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Bitfield->isInvalidDecl()) 373615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 373715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 373891b6014876e9186f968f74a8975ab8fc08ef1b68John McCall // White-list bool bitfields. 373991b6014876e9186f968f74a8975ab8fc08ef1b68John McCall if (Bitfield->getType()->isBooleanType()) 374091b6014876e9186f968f74a8975ab8fc08ef1b68John McCall return false; 374191b6014876e9186f968f74a8975ab8fc08ef1b68John McCall 374246ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor // Ignore value- or type-dependent expressions. 374346ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor if (Bitfield->getBitWidth()->isValueDependent() || 374446ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Bitfield->getBitWidth()->isTypeDependent() || 374546ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isValueDependent() || 374646ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isTypeDependent()) 374746ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor return false; 374846ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor 374915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *OriginalInit = Init->IgnoreParenImpCasts(); 375015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 375180d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith llvm::APSInt Value; 375280d4b55db94db2172a04617d1a80feca6bbcea5cRichard Smith if (!OriginalInit->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects)) 375315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 375415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 375515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned OriginalWidth = Value.getBitWidth(); 3756a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context); 375715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 375815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (OriginalWidth <= FieldWidth) 375915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 376015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 37613a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Compute the value which the bitfield will contain. 37629f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad llvm::APSInt TruncatedValue = Value.trunc(FieldWidth); 37633a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman TruncatedValue.setIsSigned(Bitfield->getType()->isSignedIntegerType()); 376415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 37653a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Check whether the stored value is equal to the original value. 37663a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman TruncatedValue = TruncatedValue.extend(OriginalWidth); 376715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value == TruncatedValue) 376815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 376915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 37703a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman // Special-case bitfields of width 1: booleans are naturally 0/1, and 377134ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman // therefore don't strictly fit into a signed bitfield of width 1. 377234ff062936ac78142a2c0dc8d1ae6a40df456819Eli Friedman if (FieldWidth == 1 && Value == 1) 37733a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman return false; 37743a643afa402d51b5fc4faccb4329e9c4392d4551Eli Friedman 377515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyValue = Value.toString(10); 377615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyTrunc = TruncatedValue.toString(10); 377715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 377815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 377915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << PrettyValue << PrettyTrunc << OriginalInit->getType() 378015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << Init->getSourceRange(); 378115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 378215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return true; 378315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 378415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 3785beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy 3786beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations. 37870692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void AnalyzeAssignment(Sema &S, BinaryOperator *E) { 3788beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Just recurse on the LHS. 3789beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 3790beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 3791beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // We want to recurse on the RHS as normal unless we're assigning to 3792beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // a bitfield. 3793beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (FieldDecl *Bitfield = E->getLHS()->getBitField()) { 379415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 379515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc())) { 379615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // Recurse, ignoring any implicit conversions on the RHS. 379715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 379815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc()); 3799beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 3800beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 3801beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 3802beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 3803beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall} 3804beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 380551313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 38060692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T, 3807c36bedc90c687caa71748480c60707ea4608b092Anna Zaks SourceLocation CContext, unsigned diag, 3808c36bedc90c687caa71748480c60707ea4608b092Anna Zaks bool pruneControlFlow = false) { 3809c36bedc90c687caa71748480c60707ea4608b092Anna Zaks if (pruneControlFlow) { 3810c36bedc90c687caa71748480c60707ea4608b092Anna Zaks S.DiagRuntimeBehavior(E->getExprLoc(), E, 3811c36bedc90c687caa71748480c60707ea4608b092Anna Zaks S.PDiag(diag) 3812c36bedc90c687caa71748480c60707ea4608b092Anna Zaks << SourceType << T << E->getSourceRange() 3813c36bedc90c687caa71748480c60707ea4608b092Anna Zaks << SourceRange(CContext)); 3814c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return; 3815c36bedc90c687caa71748480c60707ea4608b092Anna Zaks } 38165a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor S.Diag(E->getExprLoc(), diag) 38175a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor << SourceType << T << E->getSourceRange() << SourceRange(CContext); 38185a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor} 38195a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 3820e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 38210692a1991bdb8b3112887fce90d75f2103a0080bTed Kremenekstatic void DiagnoseImpCast(Sema &S, Expr *E, QualType T, 3822c36bedc90c687caa71748480c60707ea4608b092Anna Zaks SourceLocation CContext, unsigned diag, 3823c36bedc90c687caa71748480c60707ea4608b092Anna Zaks bool pruneControlFlow = false) { 3824c36bedc90c687caa71748480c60707ea4608b092Anna Zaks DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow); 3825e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth} 3826e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth 38279ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// Diagnose an implicit cast from a literal expression. Does not warn when the 38289ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// cast wouldn't lose information. 3829f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruthvoid DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T, 3830f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth SourceLocation CContext) { 38319ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay // Try to convert the literal exactly to an integer. If we can, don't warn. 3832f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth bool isExact = false; 38339ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay const llvm::APFloat &Value = FL->getValue(); 38343e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin llvm::APSInt IntegerValue(S.Context.getIntWidth(T), 38353e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin T->hasUnsignedIntegerRepresentation()); 38363e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin if (Value.convertToInteger(IntegerValue, 3837f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth llvm::APFloat::rmTowardZero, &isExact) 38389ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay == llvm::APFloat::opOK && isExact) 3839f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth return; 3840f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 38419ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer) 38429ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay << FL->getType() << T << FL->getSourceRange() << SourceRange(CContext); 3843f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth} 3844f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 3845091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 3846091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Range.Width) return "0"; 3847091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3848091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt ValueInRange = Value; 3849091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.setIsSigned(!Range.NonNegative); 38509f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad ValueInRange = ValueInRange.trunc(Range.Width); 3851091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return ValueInRange.toString(10); 3852091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall} 3853091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3854323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T, 3855b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool *ICContext = 0) { 3856323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) return; 385751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3858323ed74658bc8375278eabf074b4777458376540John McCall const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 3859323ed74658bc8375278eabf074b4777458376540John McCall const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 3860323ed74658bc8375278eabf074b4777458376540John McCall if (Source == Target) return; 3861323ed74658bc8375278eabf074b4777458376540John McCall if (Target->isDependentType()) return; 386251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3863108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // If the conversion context location is invalid don't complain. We also 3864108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // don't want to emit a warning if the issue occurs from the expansion of 3865108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // a system macro. The problem is that 'getSpellingLoc()' is slow, so we 3866108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // delay this check as long as possible. Once we detect we are in that 3867108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // scenario, we just return. 3868ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (CC.isInvalid()) 3869b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return; 3870b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 3871f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Diagnose implicit casts to bool. 3872f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (Target->isSpecificBuiltinType(BuiltinType::Bool)) { 3873f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (isa<StringLiteral>(E)) 3874f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Warn on string literal to bool. Checks for string literals in logical 3875f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // expressions, for instances, assert(0 && "error here"), is prevented 3876f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // by a check in AnalyzeImplicitConversions(). 3877f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu return DiagnoseImpCast(S, E, T, CC, 3878f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu diag::warn_impcast_string_literal_to_bool); 3879e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (Source->isFunctionType()) { 3880e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // Warn on function to bool. Checks free functions and static member 3881e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // functions. Weakly imported functions are excluded from the check, 3882e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // since it's common to test their value to check whether the linker 3883e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames // found a definition for them. 3884e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames ValueDecl *D = 0; 3885e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (DeclRefExpr* R = dyn_cast<DeclRefExpr>(E)) { 3886e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = R->getDecl(); 3887e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) { 3888e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames D = M->getMemberDecl(); 3889e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 3890e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames 3891e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames if (D && !D->isWeak()) { 389226b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu if (FunctionDecl* F = dyn_cast<FunctionDecl>(D)) { 389326b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu S.Diag(E->getExprLoc(), diag::warn_impcast_function_to_bool) 389426b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu << F << E->getSourceRange() << SourceRange(CC); 38952def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_silence) 38962def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion(E->getExprLoc(), "&"); 38972def77399ab3088106a2d61372344f5b7104e1a2David Blaikie QualType ReturnType; 38982def77399ab3088106a2d61372344f5b7104e1a2David Blaikie UnresolvedSet<4> NonTemplateOverloads; 38992def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.isExprCallable(*E, ReturnType, NonTemplateOverloads); 39002def77399ab3088106a2d61372344f5b7104e1a2David Blaikie if (!ReturnType.isNull() 39012def77399ab3088106a2d61372344f5b7104e1a2David Blaikie && ReturnType->isSpecificBuiltinType(BuiltinType::Bool)) 39022def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.Diag(E->getExprLoc(), diag::note_function_to_bool_call) 39032def77399ab3088106a2d61372344f5b7104e1a2David Blaikie << FixItHint::CreateInsertion( 39042def77399ab3088106a2d61372344f5b7104e1a2David Blaikie S.getPreprocessor().getLocForEndOfToken(E->getLocEnd()), "()"); 390526b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu return; 390626b45d86085a125af036dbcf85dad3087b664ab2Richard Trieu } 3907e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 3908e14ca9f509dc22d8fcc5d21d70d28a5848983b42Lang Hames } 3909e37cdc42bf7298a974dfdfa9c03ef11398e7c889David Blaikie return; // Other casts to bool are not checked. 3910f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 391151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 391251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip vector types. 391351313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<VectorType>(Source)) { 3914ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<VectorType>(Target)) { 3915d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 3916ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3917b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 3918ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 3919b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner 3920b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // If the vector cast is cast between two vectors of the same size, it is 3921b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // a bitcast, not a conversion. 3922b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target)) 3923b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner return; 392451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 392551313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 392651313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 392751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 392851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 392951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip complex types. 393051313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<ComplexType>(Source)) { 3931ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<ComplexType>(Target)) { 3932d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 3933ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3934ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3935b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 3936ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 393751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 393851313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 393951313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 394051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 394151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 394251313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 394351313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 394451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 394551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the source is floating point... 394651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT && SourceBT->isFloatingPoint()) { 394751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...and the target is floating point... 394851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (TargetBT && TargetBT->isFloatingPoint()) { 394951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...then warn if we're dropping FP rank. 395051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 395151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Builtin FP kinds are ordered by increasing FP rank. 395251313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT->getKind() > TargetBT->getKind()) { 395351313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Don't warn about float constants that are precisely 395451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // representable in the target type. 395551313c39c84407dd6a323be99a8c322bf8d052a9John McCall Expr::EvalResult result; 395651f4708c00110940ca3f337961915f2ca1668375Richard Smith if (E->EvaluateAsRValue(result, S.Context)) { 395751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Value might be a float, a float vector, or a float complex. 395851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (IsSameFloatAfterCast(result.Val, 3959323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 3960323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 396151313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 396251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 396351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3964d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 3965ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3966ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3967b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 396851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 396951313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 397051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 397151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3972ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // If the target is integral, always warn. 3973a5b9332418f25338f118358e27303cd510d54107Chandler Carruth if ((TargetBT && TargetBT->isInteger())) { 3974d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 3975ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3976ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3977a5b9332418f25338f118358e27303cd510d54107Chandler Carruth Expr *InnerE = E->IgnoreParenImpCasts(); 3978634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay // We also want to warn on, e.g., "int i = -1.234" 3979634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE)) 3980634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus) 3981634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay InnerE = UOp->getSubExpr()->IgnoreParenImpCasts(); 3982634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay 3983f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) { 3984f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth DiagnoseFloatingLiteralImpCast(S, FL, T, CC); 3985a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } else { 3986a5b9332418f25338f118358e27303cd510d54107Chandler Carruth DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 3987a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 3988a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 398951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 399051313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 399151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 399251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3993f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!Source->isIntegerType() || !Target->isIntegerType()) 399451313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 399551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 39961838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull) 39971838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu == Expr::NPCK_GNUNull) && Target->isIntegerType()) { 39981838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu S.Diag(E->getExprLoc(), diag::warn_impcast_null_pointer_to_integer) 39991838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu << E->getSourceRange() << clang::SourceRange(CC); 40001838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu return; 40011838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu } 40021838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu 4003323ed74658bc8375278eabf074b4777458376540John McCall IntRange SourceRange = GetExprRange(S.Context, E); 40041844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 400551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4006f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width > TargetRange.Width) { 4007091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // If the source is a constant, use a default-on diagnostic. 4008091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // TODO: this should happen for bitfield stores, too. 4009091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt Value(32); 4010091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (E->isIntegerConstantExpr(Value, S.Context)) { 4011d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4012ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4013ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4014091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettySourceValue = Value.toString(10); 4015091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 4016091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 40175e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.DiagRuntimeBehavior(E->getExprLoc(), E, 40185e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek S.PDiag(diag::warn_impcast_integer_precision_constant) 40195e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << PrettySourceValue << PrettyTargetValue 40205e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << E->getType() << T << E->getSourceRange() 40215e745da03df27ac620b0a5cc280d0d1757cfbac1Ted Kremenek << clang::SourceRange(CC)); 4022091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return; 4023091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall } 4024091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 4025b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // People want to build with -Wshorten-64-to-32 and not -Wconversion. 4026d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4027ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4028ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4029f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width == 64 && TargetRange.Width == 32) 4030c36bedc90c687caa71748480c60707ea4608b092Anna Zaks return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32, 4031c36bedc90c687caa71748480c60707ea4608b092Anna Zaks /* pruneControlFlow */ true); 4032b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 4033323ed74658bc8375278eabf074b4777458376540John McCall } 4034323ed74658bc8375278eabf074b4777458376540John McCall 4035323ed74658bc8375278eabf074b4777458376540John McCall if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 4036323ed74658bc8375278eabf074b4777458376540John McCall (!TargetRange.NonNegative && SourceRange.NonNegative && 4037323ed74658bc8375278eabf074b4777458376540John McCall SourceRange.Width == TargetRange.Width)) { 4038ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4039d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4040ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4041ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 4042323ed74658bc8375278eabf074b4777458376540John McCall unsigned DiagID = diag::warn_impcast_integer_sign; 4043323ed74658bc8375278eabf074b4777458376540John McCall 4044323ed74658bc8375278eabf074b4777458376540John McCall // Traditionally, gcc has warned about this under -Wsign-compare. 4045323ed74658bc8375278eabf074b4777458376540John McCall // We also want to warn about it in -Wconversion. 4046323ed74658bc8375278eabf074b4777458376540John McCall // So if -Wconversion is off, use a completely identical diagnostic 4047323ed74658bc8375278eabf074b4777458376540John McCall // in the sign-compare group. 4048323ed74658bc8375278eabf074b4777458376540John McCall // The conditional-checking code will 4049323ed74658bc8375278eabf074b4777458376540John McCall if (ICContext) { 4050323ed74658bc8375278eabf074b4777458376540John McCall DiagID = diag::warn_impcast_integer_sign_conditional; 4051323ed74658bc8375278eabf074b4777458376540John McCall *ICContext = true; 4052323ed74658bc8375278eabf074b4777458376540John McCall } 4053323ed74658bc8375278eabf074b4777458376540John McCall 4054b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, DiagID); 405551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 405651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4057284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor // Diagnose conversions between different enumeration types. 40585a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // In C, we pretend that the type of an EnumConstantDecl is its enumeration 40595a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // type, to give us better diagnostics. 40605a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor QualType SourceType = E->getType(); 40615a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (!S.getLangOptions().CPlusPlus) { 40625a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 40635a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) { 40645a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext()); 40655a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceType = S.Context.getTypeDeclType(Enum); 40665a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor Source = S.Context.getCanonicalType(SourceType).getTypePtr(); 40675a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 40685a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 40695a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 4070284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *SourceEnum = Source->getAs<EnumType>()) 4071284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *TargetEnum = Target->getAs<EnumType>()) 4072284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if ((SourceEnum->getDecl()->getIdentifier() || 4073162e1c1b487352434552147967c3dd296ebee2f7Richard Smith SourceEnum->getDecl()->getTypedefNameForAnonDecl()) && 4074284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor (TargetEnum->getDecl()->getIdentifier() || 4075162e1c1b487352434552147967c3dd296ebee2f7Richard Smith TargetEnum->getDecl()->getTypedefNameForAnonDecl()) && 4076ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceEnum != TargetEnum) { 4077d87a0cd2b3e1c9e9f01212875f4cbe5b7bb7ab57Matt Beaumont-Gay if (S.SourceMgr.isInSystemMacro(CC)) 4078ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 4079ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 40805a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor return DiagnoseImpCast(S, E, SourceType, T, CC, 4081284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor diag::warn_impcast_different_enum_types); 4082ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 4083284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor 408451313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 408551313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 408651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 4087323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T); 4088323ed74658bc8375278eabf074b4777458376540John McCall 4089323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T, 4090b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool &ICContext) { 4091323ed74658bc8375278eabf074b4777458376540John McCall E = E->IgnoreParenImpCasts(); 4092323ed74658bc8375278eabf074b4777458376540John McCall 4093323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) 4094323ed74658bc8375278eabf074b4777458376540John McCall return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T); 4095323ed74658bc8375278eabf074b4777458376540John McCall 4096b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E, CC); 4097323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 4098b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return CheckImplicitConversion(S, E, T, CC, &ICContext); 4099323ed74658bc8375278eabf074b4777458376540John McCall return; 4100323ed74658bc8375278eabf074b4777458376540John McCall} 4101323ed74658bc8375278eabf074b4777458376540John McCall 4102323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) { 4103b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC = E->getQuestionLoc(); 4104b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 4105b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getCond(), CC); 4106323ed74658bc8375278eabf074b4777458376540John McCall 4107323ed74658bc8375278eabf074b4777458376540John McCall bool Suspicious = false; 4108b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 4109b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 4110323ed74658bc8375278eabf074b4777458376540John McCall 4111323ed74658bc8375278eabf074b4777458376540John McCall // If -Wconversion would have warned about either of the candidates 4112323ed74658bc8375278eabf074b4777458376540John McCall // for a signedness conversion to the context type... 4113323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) return; 4114323ed74658bc8375278eabf074b4777458376540John McCall 4115323ed74658bc8375278eabf074b4777458376540John McCall // ...but it's currently ignored... 41160827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional, 41170827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis CC)) 4118323ed74658bc8375278eabf074b4777458376540John McCall return; 4119323ed74658bc8375278eabf074b4777458376540John McCall 4120323ed74658bc8375278eabf074b4777458376540John McCall // ...then check whether it would have warned about either of the 4121323ed74658bc8375278eabf074b4777458376540John McCall // candidates for a signedness conversion to the condition type. 41225254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (E->getType() == T) return; 41235254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu 41245254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu Suspicious = false; 41255254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 41265254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu E->getType(), CC, &Suspicious); 41275254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (!Suspicious) 41285254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 4129b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 4130323ed74658bc8375278eabf074b4777458376540John McCall} 4131323ed74658bc8375278eabf074b4777458376540John McCall 4132323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting 4133323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression. There are a couple 4134323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare. 4135b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 4136323ed74658bc8375278eabf074b4777458376540John McCall QualType T = OrigE->getType(); 4137323ed74658bc8375278eabf074b4777458376540John McCall Expr *E = OrigE->IgnoreParenImpCasts(); 4138323ed74658bc8375278eabf074b4777458376540John McCall 4139f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 4140f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor return; 4141f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor 4142323ed74658bc8375278eabf074b4777458376540John McCall // For conditional operators, we analyze the arguments as if they 4143323ed74658bc8375278eabf074b4777458376540John McCall // were being fed directly into the output. 4144323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) { 4145323ed74658bc8375278eabf074b4777458376540John McCall ConditionalOperator *CO = cast<ConditionalOperator>(E); 4146323ed74658bc8375278eabf074b4777458376540John McCall CheckConditionalOperator(S, CO, T); 4147323ed74658bc8375278eabf074b4777458376540John McCall return; 4148323ed74658bc8375278eabf074b4777458376540John McCall } 4149323ed74658bc8375278eabf074b4777458376540John McCall 4150323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and check any implicit conversions we might have skipped. 4151323ed74658bc8375278eabf074b4777458376540John McCall // The non-canonical typecheck is just an optimization; 4152323ed74658bc8375278eabf074b4777458376540John McCall // CheckImplicitConversion will filter out dead implicit conversions. 4153323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 4154b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckImplicitConversion(S, E, T, CC); 4155323ed74658bc8375278eabf074b4777458376540John McCall 4156323ed74658bc8375278eabf074b4777458376540John McCall // Now continue drilling into this expression. 4157323ed74658bc8375278eabf074b4777458376540John McCall 4158323ed74658bc8375278eabf074b4777458376540John McCall // Skip past explicit casts. 4159323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ExplicitCastExpr>(E)) { 4160323ed74658bc8375278eabf074b4777458376540John McCall E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 4161b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return AnalyzeImplicitConversions(S, E, CC); 4162323ed74658bc8375278eabf074b4777458376540John McCall } 4163323ed74658bc8375278eabf074b4777458376540John McCall 4164beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 4165beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Do a somewhat different check with comparison operators. 4166beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isComparisonOp()) 4167beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeComparison(S, BO); 4168beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 41690fa063816818ac53a0015a5d2b0328812005b40eEli Friedman // And with simple assignments. 41700fa063816818ac53a0015a5d2b0328812005b40eEli Friedman if (BO->getOpcode() == BO_Assign) 4171beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeAssignment(S, BO); 4172beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 4173323ed74658bc8375278eabf074b4777458376540John McCall 4174323ed74658bc8375278eabf074b4777458376540John McCall // These break the otherwise-useful invariant below. Fortunately, 4175323ed74658bc8375278eabf074b4777458376540John McCall // we don't really need to recurse into them, because any internal 4176323ed74658bc8375278eabf074b4777458376540John McCall // expressions should have been analyzed already when they were 4177323ed74658bc8375278eabf074b4777458376540John McCall // built into statements. 4178323ed74658bc8375278eabf074b4777458376540John McCall if (isa<StmtExpr>(E)) return; 4179323ed74658bc8375278eabf074b4777458376540John McCall 4180323ed74658bc8375278eabf074b4777458376540John McCall // Don't descend into unevaluated contexts. 4181f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne if (isa<UnaryExprOrTypeTraitExpr>(E)) return; 4182323ed74658bc8375278eabf074b4777458376540John McCall 4183323ed74658bc8375278eabf074b4777458376540John McCall // Now just recurse over the expression's children. 4184b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CC = E->getExprLoc(); 4185f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu BinaryOperator *BO = dyn_cast<BinaryOperator>(E); 4186f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu bool IsLogicalOperator = BO && BO->isLogicalOp(); 4187f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu for (Stmt::child_range I = E->children(); I; ++I) { 418854042f1bd78f1f1ea86be7d4af541462e127d2edDouglas Gregor Expr *ChildExpr = dyn_cast_or_null<Expr>(*I); 4189503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor if (!ChildExpr) 4190503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor continue; 4191503384f731b5abcbf870b0a5224eb920e631db0aDouglas Gregor 4192f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (IsLogicalOperator && 4193f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts())) 4194f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Ignore checking string literals that are in logical operators. 4195f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu continue; 4196f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu AnalyzeImplicitConversions(S, ChildExpr, CC); 4197f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 4198323ed74658bc8375278eabf074b4777458376540John McCall} 4199323ed74658bc8375278eabf074b4777458376540John McCall 4200323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace 4201323ed74658bc8375278eabf074b4777458376540John McCall 4202323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given 4203323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression). Implements -Wconversion 4204323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare. 4205b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// 4206b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e. 4207b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// the most location of the syntactic entity requiring the implicit 4208b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// conversion 4209b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 4210323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose in unevaluated contexts. 4211323ed74658bc8375278eabf074b4777458376540John McCall if (ExprEvalContexts.back().Context == Sema::Unevaluated) 4212323ed74658bc8375278eabf074b4777458376540John McCall return; 4213323ed74658bc8375278eabf074b4777458376540John McCall 4214323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose for value- or type-dependent expressions. 4215323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) 4216323ed74658bc8375278eabf074b4777458376540John McCall return; 4217323ed74658bc8375278eabf074b4777458376540John McCall 4218d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Check for array bounds violations in cases where the check isn't triggered 4219d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // elsewhere for other Expr types (like BinaryOperators), e.g. when an 4220d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // ArraySubscriptExpr is on the RHS of a variable initialization. 4221d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain CheckArrayAccess(E); 4222d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 4223b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // This is not the right CC for (e.g.) a variable initialization. 4224b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(*this, E, CC); 4225323ed74658bc8375278eabf074b4777458376540John McCall} 4226323ed74658bc8375278eabf074b4777458376540John McCall 422715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 422815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall FieldDecl *BitField, 422915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *Init) { 423015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 423115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 423215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 4233f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given 4234f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This 4235f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the 4236f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function 4237f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete. 423882aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregorbool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd, 423982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor bool CheckParameterNames) { 4240f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump bool HasInvalidParm = false; 424182aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor for (; P != PEnd; ++P) { 424282aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor ParmVarDecl *Param = *P; 424382aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor 4244f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.7.5.3p4: the parameters in a parameter type list in a 4245f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // function declarator that is part of a function definition of 4246f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // that function shall not have incomplete type. 4247f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // 4248f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // This is also C++ [dcl.fct]p6. 4249f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump if (!Param->isInvalidDecl() && 4250f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump RequireCompleteType(Param->getLocation(), Param->getType(), 4251f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump diag::err_typecheck_decl_incomplete_type)) { 4252f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Param->setInvalidDecl(); 4253f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump HasInvalidParm = true; 4254f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 4255f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 4256f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.9.1p5: If the declarator includes a parameter type list, the 4257f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // declaration of each parameter shall include an identifier. 425882aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor if (CheckParameterNames && 425982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor Param->getIdentifier() == 0 && 4260f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !Param->isImplicit() && 4261f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !getLangOptions().CPlusPlus) 4262f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Diag(Param->getLocation(), diag::err_parameter_name_omitted); 4263d17e340e2d516139931768697bf080f60920ba9dSam Weinig 4264d17e340e2d516139931768697bf080f60920ba9dSam Weinig // C99 6.7.5.3p12: 4265d17e340e2d516139931768697bf080f60920ba9dSam Weinig // If the function declarator is not part of a definition of that 4266d17e340e2d516139931768697bf080f60920ba9dSam Weinig // function, parameters may have incomplete type and may use the [*] 4267d17e340e2d516139931768697bf080f60920ba9dSam Weinig // notation in their sequences of declarator specifiers to specify 4268d17e340e2d516139931768697bf080f60920ba9dSam Weinig // variable length array types. 4269d17e340e2d516139931768697bf080f60920ba9dSam Weinig QualType PType = Param->getOriginalType(); 4270d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (const ArrayType *AT = Context.getAsArrayType(PType)) { 4271d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (AT->getSizeModifier() == ArrayType::Star) { 4272d17e340e2d516139931768697bf080f60920ba9dSam Weinig // FIXME: This diagnosic should point the the '[*]' if source-location 4273d17e340e2d516139931768697bf080f60920ba9dSam Weinig // information is added for it. 4274d17e340e2d516139931768697bf080f60920ba9dSam Weinig Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 4275d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 4276d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 4277f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 4278f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 4279f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump return HasInvalidParm; 4280f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump} 4281b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4282b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a 4283b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements. 4284b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 4285b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // This is actually a lot of work to potentially be doing on every 4286b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // cast; don't do it if we're ignoring -Wcast_align (as is the default). 42870827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align, 42880827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis TRange.getBegin()) 4289d6471f7c1921c7802804ce3ff6fe9768310f72b9David Blaikie == DiagnosticsEngine::Ignored) 4290b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 4291b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4292b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Ignore dependent types. 4293b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (T->isDependentType() || Op->getType()->isDependentType()) 4294b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 4295b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4296b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the destination be a pointer type. 4297b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *DestPtr = T->getAs<PointerType>(); 4298b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!DestPtr) return; 4299b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4300b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // If the destination has alignment 1, we're done. 4301b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType DestPointee = DestPtr->getPointeeType(); 4302b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestPointee->isIncompleteType()) return; 4303b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 4304b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestAlign.isOne()) return; 4305b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4306b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the source be a pointer type. 4307b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 4308b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!SrcPtr) return; 4309b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType SrcPointee = SrcPtr->getPointeeType(); 4310b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4311b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Whitelist casts from cv void*. We already implicitly 4312b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // whitelisted casts to cv void*, since they have alignment 1. 4313b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Also whitelist casts involving incomplete types, which implicitly 4314b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // includes 'void'. 4315b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcPointee->isIncompleteType()) return; 4316b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4317b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 4318b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcAlign >= DestAlign) return; 4319b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4320b7f4ffe073fa419613946461a2583ba2fcb72280John McCall Diag(TRange.getBegin(), diag::warn_cast_align) 4321b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << Op->getType() << T 4322b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(SrcAlign.getQuantity()) 4323b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(DestAlign.getQuantity()) 4324b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << TRange << Op->getSourceRange(); 4325b7f4ffe073fa419613946461a2583ba2fcb72280John McCall} 4326b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 4327d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainstatic const Type* getElementType(const Expr *BaseExpr) { 4328d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* EltType = BaseExpr->getType().getTypePtr(); 4329d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (EltType->isAnyPointerType()) 4330d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getPointeeType().getTypePtr(); 4331d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain else if (EltType->isArrayType()) 4332d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getBaseElementTypeUnsafe(); 4333d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType; 4334d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain} 4335d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 4336c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// \brief Check whether this array fits the idiom of a size-one tail padded 4337c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// array member of a struct. 4338c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// 4339c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// We avoid emitting out-of-bounds access warnings for such arrays as they are 4340c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// commonly used to emulate flexible arrays in C89 code. 4341c268434b332bbe57950d977633369bf5822d9554Chandler Carruthstatic bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size, 4342c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const NamedDecl *ND) { 4343c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (Size != 1 || !ND) return false; 4344c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 4345c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const FieldDecl *FD = dyn_cast<FieldDecl>(ND); 4346c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!FD) return false; 4347c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 4348c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // Don't consider sizes resulting from macro expansions or template argument 4349c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // substitution to form C89 tail-padded arrays. 4350c268434b332bbe57950d977633369bf5822d9554Chandler Carruth ConstantArrayTypeLoc TL = 4351c268434b332bbe57950d977633369bf5822d9554Chandler Carruth cast<ConstantArrayTypeLoc>(FD->getTypeSourceInfo()->getTypeLoc()); 4352c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const Expr *SizeExpr = dyn_cast<IntegerLiteral>(TL.getSizeExpr()); 4353c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!SizeExpr || SizeExpr->getExprLoc().isMacroID()) 4354c268434b332bbe57950d977633369bf5822d9554Chandler Carruth return false; 4355c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 4356c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext()); 4357381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!RD) return false; 4358381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (RD->isUnion()) return false; 4359381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) { 4360381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay if (!CRD->isStandardLayout()) return false; 4361381711c6e7911d762f81a65e9ef4339a6a3d6524Matt Beaumont-Gay } 4362c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 436322d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer // See if this is the last field decl in the record. 436422d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer const Decl *D = FD; 436522d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer while ((D = D->getNextDeclInContext())) 436622d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer if (isa<FieldDecl>(D)) 436722d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return false; 436822d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return true; 4369c268434b332bbe57950d977633369bf5822d9554Chandler Carruth} 4370c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 4371d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainvoid Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr, 437280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const ArraySubscriptExpr *ASE, 437325b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith bool AllowOnePastEnd, bool IndexNegated) { 4374d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain IndexExpr = IndexExpr->IgnoreParenCasts(); 437580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (IndexExpr->isValueDependent()) 437680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 4377d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 437880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay const Type *EffectiveType = getElementType(BaseExpr); 437980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay BaseExpr = BaseExpr->IgnoreParenCasts(); 43803406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const ConstantArrayType *ArrayTy = 4381d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain Context.getAsConstantArrayType(BaseExpr->getType()); 43823406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (!ArrayTy) 4383a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 438435001ca261f895817916b468379b696d6d45959dChandler Carruth 43853406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth llvm::APSInt index; 438680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!IndexExpr->EvaluateAsInt(index, Context)) 4387a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 438825b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith if (IndexNegated) 438925b009a9d2a79929112d3c28c7dd1730bf5246c8Richard Smith index = -index; 43908fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek 4391ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth const NamedDecl *ND = NULL; 4392ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 4393ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(DRE->getDecl()); 4394c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 4395ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 4396ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 43979e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek if (index.isUnsigned() || !index.isNegative()) { 439825b3b849e3ad340b04442707038c86980035765bTed Kremenek llvm::APInt size = ArrayTy->getSize(); 439935001ca261f895817916b468379b696d6d45959dChandler Carruth if (!size.isStrictlyPositive()) 440035001ca261f895817916b468379b696d6d45959dChandler Carruth return; 4401d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 4402d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* BaseType = getElementType(BaseExpr); 4403de5998f1d7dcecb777257ec932142d65de636eb8Nico Weber if (BaseType != EffectiveType) { 4404d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Make sure we're comparing apples to apples when comparing index to size 4405d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType); 4406d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t array_typesize = Context.getTypeSize(BaseType); 4407d10f4bc5a05ce0cdc1646dbb0f706bb9d3dfc0c5Kaelyn Uhrain // Handle ptrarith_typesize being zero, such as when casting to void* 440818f169770d9d3f826bad8f1359c8c5770c5ab16fKaelyn Uhrain if (!ptrarith_typesize) ptrarith_typesize = 1; 4409d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize != array_typesize) { 4410d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // There's a cast to a different size type involved 4411d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ratio = array_typesize / ptrarith_typesize; 4412d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // TODO: Be smarter about handling cases where array_typesize is not a 4413d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // multiple of ptrarith_typesize 4414d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize * ratio == array_typesize) 4415d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain size *= llvm::APInt(size.getBitWidth(), ratio); 4416d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 4417d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 4418d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 44193406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (size.getBitWidth() > index.getBitWidth()) 44203406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth index = index.sext(size.getBitWidth()); 442125b3b849e3ad340b04442707038c86980035765bTed Kremenek else if (size.getBitWidth() < index.getBitWidth()) 442225b3b849e3ad340b04442707038c86980035765bTed Kremenek size = size.sext(index.getBitWidth()); 442325b3b849e3ad340b04442707038c86980035765bTed Kremenek 4424d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // For array subscripting the index must be less than size, but for pointer 4425d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // arithmetic also allow the index (offset) to be equal to size since 4426d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // computing the next address after the end of the array is legal and 4427d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // commonly done e.g. in C++ iterators and range-based for loops. 4428d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (AllowOnePastEnd ? index.sle(size) : index.slt(size)) 4429ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth return; 4430ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 4431ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // Also don't warn for arrays of size 1 which are members of some 4432ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // structure. These are often used to approximate flexible arrays in C89 4433ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // code. 4434d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (IsTailPaddedMemberArray(*this, size, ND)) 44358fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek return; 44363406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth 443780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // Suppress the warning if the subscript expression (as identified by the 443880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // ']' location) and the index expression are both from macro expansions 443980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay // within a system header. 444080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) { 444180fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation RBracketLoc = SourceMgr.getSpellingLoc( 444280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay ASE->getRBracketLoc()); 444380fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isInSystemHeader(RBracketLoc)) { 444480fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay SourceLocation IndexLoc = SourceMgr.getSpellingLoc( 444580fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay IndexExpr->getLocStart()); 444680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (SourceMgr.isFromSameFile(RBracketLoc, IndexLoc)) 444780fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay return; 444880fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 444980fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay } 445080fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay 4451d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds; 445280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (ASE) 4453d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_array_index_exceeds_bounds; 4454d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 4455d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 4456d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 4457d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << size.toString(10, true) 4458d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << (unsigned)size.getLimitedValue(~0U) 4459d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 44603406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth } else { 4461d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_array_index_precedes_bounds; 446280fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay if (!ASE) { 4463d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_ptr_arith_precedes_bounds; 4464d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (index.isNegative()) index = -index; 4465d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 4466d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 4467d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 4468d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 4469d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 4470a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek } 447135001ca261f895817916b468379b696d6d45959dChandler Carruth 4472cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (!ND) { 4473cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay // Try harder to find a NamedDecl to point at in the note. 4474cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay while (const ArraySubscriptExpr *ASE = 4475cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay dyn_cast<ArraySubscriptExpr>(BaseExpr)) 4476cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay BaseExpr = ASE->getBase()->IgnoreParenCasts(); 4477cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 4478cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(DRE->getDecl()); 4479cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 4480cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 4481cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay } 4482cfbc5b5660f49fae63acc1f5ef05df87070a2a3cMatt Beaumont-Gay 448335001ca261f895817916b468379b696d6d45959dChandler Carruth if (ND) 4484d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(ND->getLocStart(), BaseExpr, 4485d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(diag::note_array_index_out_of_bounds) 4486d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << ND->getDeclName()); 44873aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek} 44883aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek 44893aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) { 4490d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain int AllowOnePastEnd = 0; 4491d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain while (expr) { 4492d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = expr->IgnoreParenImpCasts(); 44933aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek switch (expr->getStmtClass()) { 4494d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::ArraySubscriptExprClass: { 4495d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr); 449680fb7dd8e0c56632dc68f5864f70abb2fde0e1dfMatt Beaumont-Gay CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE, 4497d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd > 0); 44983aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 4499d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 4500d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::UnaryOperatorClass: { 4501d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Only unwrap the * and & unary operators 4502d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const UnaryOperator *UO = cast<UnaryOperator>(expr); 4503d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = UO->getSubExpr(); 4504d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain switch (UO->getOpcode()) { 4505d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_AddrOf: 4506d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd++; 4507d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 4508d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_Deref: 4509d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd--; 4510d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 4511d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain default: 4512d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return; 4513d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 4514d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 4515d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 45163aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek case Stmt::ConditionalOperatorClass: { 45173aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek const ConditionalOperator *cond = cast<ConditionalOperator>(expr); 45183aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *lhs = cond->getLHS()) 45193aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(lhs); 45203aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *rhs = cond->getRHS()) 45213aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(rhs); 45223aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 45233aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 45243aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek default: 45253aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 45263aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 4527f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne } 4528a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek} 4529f85e193739c953358c865005855253af4f68a497John McCall 4530f85e193739c953358c865005855253af4f68a497John McCall//===--- CHECK: Objective-C retain cycles ----------------------------------// 4531f85e193739c953358c865005855253af4f68a497John McCall 4532f85e193739c953358c865005855253af4f68a497John McCallnamespace { 4533f85e193739c953358c865005855253af4f68a497John McCall struct RetainCycleOwner { 4534f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner() : Variable(0), Indirect(false) {} 4535f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 4536f85e193739c953358c865005855253af4f68a497John McCall SourceRange Range; 4537f85e193739c953358c865005855253af4f68a497John McCall SourceLocation Loc; 4538f85e193739c953358c865005855253af4f68a497John McCall bool Indirect; 4539f85e193739c953358c865005855253af4f68a497John McCall 4540f85e193739c953358c865005855253af4f68a497John McCall void setLocsFrom(Expr *e) { 4541f85e193739c953358c865005855253af4f68a497John McCall Loc = e->getExprLoc(); 4542f85e193739c953358c865005855253af4f68a497John McCall Range = e->getSourceRange(); 4543f85e193739c953358c865005855253af4f68a497John McCall } 4544f85e193739c953358c865005855253af4f68a497John McCall }; 4545f85e193739c953358c865005855253af4f68a497John McCall} 4546f85e193739c953358c865005855253af4f68a497John McCall 4547f85e193739c953358c865005855253af4f68a497John McCall/// Consider whether capturing the given variable can possibly lead to 4548f85e193739c953358c865005855253af4f68a497John McCall/// a retain cycle. 4549f85e193739c953358c865005855253af4f68a497John McCallstatic bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) { 4550f85e193739c953358c865005855253af4f68a497John McCall // In ARC, it's captured strongly iff the variable has __strong 4551f85e193739c953358c865005855253af4f68a497John McCall // lifetime. In MRR, it's captured strongly if the variable is 4552f85e193739c953358c865005855253af4f68a497John McCall // __block and has an appropriate type. 4553f85e193739c953358c865005855253af4f68a497John McCall if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 4554f85e193739c953358c865005855253af4f68a497John McCall return false; 4555f85e193739c953358c865005855253af4f68a497John McCall 4556f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = var; 4557f85e193739c953358c865005855253af4f68a497John McCall owner.setLocsFrom(ref); 4558f85e193739c953358c865005855253af4f68a497John McCall return true; 4559f85e193739c953358c865005855253af4f68a497John McCall} 4560f85e193739c953358c865005855253af4f68a497John McCall 45616e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanianstatic bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) { 4562f85e193739c953358c865005855253af4f68a497John McCall while (true) { 4563f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParens(); 4564f85e193739c953358c865005855253af4f68a497John McCall if (CastExpr *cast = dyn_cast<CastExpr>(e)) { 4565f85e193739c953358c865005855253af4f68a497John McCall switch (cast->getCastKind()) { 4566f85e193739c953358c865005855253af4f68a497John McCall case CK_BitCast: 4567f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueBitCast: 4568f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueToRValue: 456933e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall case CK_ARCReclaimReturnedObject: 4570f85e193739c953358c865005855253af4f68a497John McCall e = cast->getSubExpr(); 4571f85e193739c953358c865005855253af4f68a497John McCall continue; 4572f85e193739c953358c865005855253af4f68a497John McCall 4573f85e193739c953358c865005855253af4f68a497John McCall default: 4574f85e193739c953358c865005855253af4f68a497John McCall return false; 4575f85e193739c953358c865005855253af4f68a497John McCall } 4576f85e193739c953358c865005855253af4f68a497John McCall } 4577f85e193739c953358c865005855253af4f68a497John McCall 4578f85e193739c953358c865005855253af4f68a497John McCall if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) { 4579f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar = ref->getDecl(); 4580f85e193739c953358c865005855253af4f68a497John McCall if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 4581f85e193739c953358c865005855253af4f68a497John McCall return false; 4582f85e193739c953358c865005855253af4f68a497John McCall 4583f85e193739c953358c865005855253af4f68a497John McCall // Try to find a retain cycle in the base. 45846e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(S, ref->getBase(), owner)) 4585f85e193739c953358c865005855253af4f68a497John McCall return false; 4586f85e193739c953358c865005855253af4f68a497John McCall 4587f85e193739c953358c865005855253af4f68a497John McCall if (ref->isFreeIvar()) owner.setLocsFrom(ref); 4588f85e193739c953358c865005855253af4f68a497John McCall owner.Indirect = true; 4589f85e193739c953358c865005855253af4f68a497John McCall return true; 4590f85e193739c953358c865005855253af4f68a497John McCall } 4591f85e193739c953358c865005855253af4f68a497John McCall 4592f85e193739c953358c865005855253af4f68a497John McCall if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) { 4593f85e193739c953358c865005855253af4f68a497John McCall VarDecl *var = dyn_cast<VarDecl>(ref->getDecl()); 4594f85e193739c953358c865005855253af4f68a497John McCall if (!var) return false; 4595f85e193739c953358c865005855253af4f68a497John McCall return considerVariable(var, ref, owner); 4596f85e193739c953358c865005855253af4f68a497John McCall } 4597f85e193739c953358c865005855253af4f68a497John McCall 4598f85e193739c953358c865005855253af4f68a497John McCall if (BlockDeclRefExpr *ref = dyn_cast<BlockDeclRefExpr>(e)) { 4599f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = ref->getDecl(); 4600f85e193739c953358c865005855253af4f68a497John McCall owner.setLocsFrom(ref); 4601f85e193739c953358c865005855253af4f68a497John McCall return true; 4602f85e193739c953358c865005855253af4f68a497John McCall } 4603f85e193739c953358c865005855253af4f68a497John McCall 4604f85e193739c953358c865005855253af4f68a497John McCall if (MemberExpr *member = dyn_cast<MemberExpr>(e)) { 4605f85e193739c953358c865005855253af4f68a497John McCall if (member->isArrow()) return false; 4606f85e193739c953358c865005855253af4f68a497John McCall 4607f85e193739c953358c865005855253af4f68a497John McCall // Don't count this as an indirect ownership. 4608f85e193739c953358c865005855253af4f68a497John McCall e = member->getBase(); 4609f85e193739c953358c865005855253af4f68a497John McCall continue; 4610f85e193739c953358c865005855253af4f68a497John McCall } 4611f85e193739c953358c865005855253af4f68a497John McCall 46124b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) { 46134b9c2d235fb9449e249d74f48ecfec601650de93John McCall // Only pay attention to pseudo-objects on property references. 46144b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyRefExpr *pre 46154b9c2d235fb9449e249d74f48ecfec601650de93John McCall = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm() 46164b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->IgnoreParens()); 46174b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!pre) return false; 46184b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (pre->isImplicitProperty()) return false; 46194b9c2d235fb9449e249d74f48ecfec601650de93John McCall ObjCPropertyDecl *property = pre->getExplicitProperty(); 46204b9c2d235fb9449e249d74f48ecfec601650de93John McCall if (!property->isRetaining() && 46214b9c2d235fb9449e249d74f48ecfec601650de93John McCall !(property->getPropertyIvarDecl() && 46224b9c2d235fb9449e249d74f48ecfec601650de93John McCall property->getPropertyIvarDecl()->getType() 46234b9c2d235fb9449e249d74f48ecfec601650de93John McCall .getObjCLifetime() == Qualifiers::OCL_Strong)) 46244b9c2d235fb9449e249d74f48ecfec601650de93John McCall return false; 46254b9c2d235fb9449e249d74f48ecfec601650de93John McCall 46264b9c2d235fb9449e249d74f48ecfec601650de93John McCall owner.Indirect = true; 46276e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (pre->isSuperReceiver()) { 46286e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Variable = S.getCurMethodDecl()->getSelfDecl(); 46296e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!owner.Variable) 46306e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return false; 46316e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Loc = pre->getLocation(); 46326e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian owner.Range = pre->getSourceRange(); 46336e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian return true; 46346e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian } 46354b9c2d235fb9449e249d74f48ecfec601650de93John McCall e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase()) 46364b9c2d235fb9449e249d74f48ecfec601650de93John McCall ->getSourceExpr()); 46374b9c2d235fb9449e249d74f48ecfec601650de93John McCall continue; 46384b9c2d235fb9449e249d74f48ecfec601650de93John McCall } 46394b9c2d235fb9449e249d74f48ecfec601650de93John McCall 4640f85e193739c953358c865005855253af4f68a497John McCall // Array ivars? 4641f85e193739c953358c865005855253af4f68a497John McCall 4642f85e193739c953358c865005855253af4f68a497John McCall return false; 4643f85e193739c953358c865005855253af4f68a497John McCall } 4644f85e193739c953358c865005855253af4f68a497John McCall} 4645f85e193739c953358c865005855253af4f68a497John McCall 4646f85e193739c953358c865005855253af4f68a497John McCallnamespace { 4647f85e193739c953358c865005855253af4f68a497John McCall struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> { 4648f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor(ASTContext &Context, VarDecl *variable) 4649f85e193739c953358c865005855253af4f68a497John McCall : EvaluatedExprVisitor<FindCaptureVisitor>(Context), 4650f85e193739c953358c865005855253af4f68a497John McCall Variable(variable), Capturer(0) {} 4651f85e193739c953358c865005855253af4f68a497John McCall 4652f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 4653f85e193739c953358c865005855253af4f68a497John McCall Expr *Capturer; 4654f85e193739c953358c865005855253af4f68a497John McCall 4655f85e193739c953358c865005855253af4f68a497John McCall void VisitDeclRefExpr(DeclRefExpr *ref) { 4656f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 4657f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 4658f85e193739c953358c865005855253af4f68a497John McCall } 4659f85e193739c953358c865005855253af4f68a497John McCall 4660f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockDeclRefExpr(BlockDeclRefExpr *ref) { 4661f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 4662f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 4663f85e193739c953358c865005855253af4f68a497John McCall } 4664f85e193739c953358c865005855253af4f68a497John McCall 4665f85e193739c953358c865005855253af4f68a497John McCall void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) { 4666f85e193739c953358c865005855253af4f68a497John McCall if (Capturer) return; 4667f85e193739c953358c865005855253af4f68a497John McCall Visit(ref->getBase()); 4668f85e193739c953358c865005855253af4f68a497John McCall if (Capturer && ref->isFreeIvar()) 4669f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 4670f85e193739c953358c865005855253af4f68a497John McCall } 4671f85e193739c953358c865005855253af4f68a497John McCall 4672f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockExpr(BlockExpr *block) { 4673f85e193739c953358c865005855253af4f68a497John McCall // Look inside nested blocks 4674f85e193739c953358c865005855253af4f68a497John McCall if (block->getBlockDecl()->capturesVariable(Variable)) 4675f85e193739c953358c865005855253af4f68a497John McCall Visit(block->getBlockDecl()->getBody()); 4676f85e193739c953358c865005855253af4f68a497John McCall } 4677f85e193739c953358c865005855253af4f68a497John McCall }; 4678f85e193739c953358c865005855253af4f68a497John McCall} 4679f85e193739c953358c865005855253af4f68a497John McCall 4680f85e193739c953358c865005855253af4f68a497John McCall/// Check whether the given argument is a block which captures a 4681f85e193739c953358c865005855253af4f68a497John McCall/// variable. 4682f85e193739c953358c865005855253af4f68a497John McCallstatic Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) { 4683f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 4684f85e193739c953358c865005855253af4f68a497John McCall 4685f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParenCasts(); 4686f85e193739c953358c865005855253af4f68a497John McCall BlockExpr *block = dyn_cast<BlockExpr>(e); 4687f85e193739c953358c865005855253af4f68a497John McCall if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable)) 4688f85e193739c953358c865005855253af4f68a497John McCall return 0; 4689f85e193739c953358c865005855253af4f68a497John McCall 4690f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor visitor(S.Context, owner.Variable); 4691f85e193739c953358c865005855253af4f68a497John McCall visitor.Visit(block->getBlockDecl()->getBody()); 4692f85e193739c953358c865005855253af4f68a497John McCall return visitor.Capturer; 4693f85e193739c953358c865005855253af4f68a497John McCall} 4694f85e193739c953358c865005855253af4f68a497John McCall 4695f85e193739c953358c865005855253af4f68a497John McCallstatic void diagnoseRetainCycle(Sema &S, Expr *capturer, 4696f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner &owner) { 4697f85e193739c953358c865005855253af4f68a497John McCall assert(capturer); 4698f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 4699f85e193739c953358c865005855253af4f68a497John McCall 4700f85e193739c953358c865005855253af4f68a497John McCall S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle) 4701f85e193739c953358c865005855253af4f68a497John McCall << owner.Variable << capturer->getSourceRange(); 4702f85e193739c953358c865005855253af4f68a497John McCall S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner) 4703f85e193739c953358c865005855253af4f68a497John McCall << owner.Indirect << owner.Range; 4704f85e193739c953358c865005855253af4f68a497John McCall} 4705f85e193739c953358c865005855253af4f68a497John McCall 4706f85e193739c953358c865005855253af4f68a497John McCall/// Check for a keyword selector that starts with the word 'add' or 4707f85e193739c953358c865005855253af4f68a497John McCall/// 'set'. 4708f85e193739c953358c865005855253af4f68a497John McCallstatic bool isSetterLikeSelector(Selector sel) { 4709f85e193739c953358c865005855253af4f68a497John McCall if (sel.isUnarySelector()) return false; 4710f85e193739c953358c865005855253af4f68a497John McCall 47115f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef str = sel.getNameForSlot(0); 4712f85e193739c953358c865005855253af4f68a497John McCall while (!str.empty() && str.front() == '_') str = str.substr(1); 4713968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (str.startswith("set")) 4714f85e193739c953358c865005855253af4f68a497John McCall str = str.substr(3); 4715968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek else if (str.startswith("add")) { 4716968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek // Specially whitelist 'addOperationWithBlock:'. 4717968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock")) 4718968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek return false; 4719968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek str = str.substr(3); 4720968a0ee9d98549308e3e70e787e4fd669d2a829dTed Kremenek } 4721f85e193739c953358c865005855253af4f68a497John McCall else 4722f85e193739c953358c865005855253af4f68a497John McCall return false; 4723f85e193739c953358c865005855253af4f68a497John McCall 4724f85e193739c953358c865005855253af4f68a497John McCall if (str.empty()) return true; 4725f85e193739c953358c865005855253af4f68a497John McCall return !islower(str.front()); 4726f85e193739c953358c865005855253af4f68a497John McCall} 4727f85e193739c953358c865005855253af4f68a497John McCall 4728f85e193739c953358c865005855253af4f68a497John McCall/// Check a message send to see if it's likely to cause a retain cycle. 4729f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(ObjCMessageExpr *msg) { 4730f85e193739c953358c865005855253af4f68a497John McCall // Only check instance methods whose selector looks like a setter. 4731f85e193739c953358c865005855253af4f68a497John McCall if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector())) 4732f85e193739c953358c865005855253af4f68a497John McCall return; 4733f85e193739c953358c865005855253af4f68a497John McCall 4734f85e193739c953358c865005855253af4f68a497John McCall // Try to find a variable that the receiver is strongly owned by. 4735f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 4736f85e193739c953358c865005855253af4f68a497John McCall if (msg->getReceiverKind() == ObjCMessageExpr::Instance) { 47376e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner)) 4738f85e193739c953358c865005855253af4f68a497John McCall return; 4739f85e193739c953358c865005855253af4f68a497John McCall } else { 4740f85e193739c953358c865005855253af4f68a497John McCall assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance); 4741f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = getCurMethodDecl()->getSelfDecl(); 4742f85e193739c953358c865005855253af4f68a497John McCall owner.Loc = msg->getSuperLoc(); 4743f85e193739c953358c865005855253af4f68a497John McCall owner.Range = msg->getSuperLoc(); 4744f85e193739c953358c865005855253af4f68a497John McCall } 4745f85e193739c953358c865005855253af4f68a497John McCall 4746f85e193739c953358c865005855253af4f68a497John McCall // Check whether the receiver is captured by any of the arguments. 4747f85e193739c953358c865005855253af4f68a497John McCall for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i) 4748f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner)) 4749f85e193739c953358c865005855253af4f68a497John McCall return diagnoseRetainCycle(*this, capturer, owner); 4750f85e193739c953358c865005855253af4f68a497John McCall} 4751f85e193739c953358c865005855253af4f68a497John McCall 4752f85e193739c953358c865005855253af4f68a497John McCall/// Check a property assign to see if it's likely to cause a retain cycle. 4753f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(Expr *receiver, Expr *argument) { 4754f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 47556e6f93a1f16d9804db79390382e9d1f6322cdbfdFariborz Jahanian if (!findRetainCycleOwner(*this, receiver, owner)) 4756f85e193739c953358c865005855253af4f68a497John McCall return; 4757f85e193739c953358c865005855253af4f68a497John McCall 4758f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, argument, owner)) 4759f85e193739c953358c865005855253af4f68a497John McCall diagnoseRetainCycle(*this, capturer, owner); 4760f85e193739c953358c865005855253af4f68a497John McCall} 4761f85e193739c953358c865005855253af4f68a497John McCall 4762921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianbool Sema::checkUnsafeAssigns(SourceLocation Loc, 4763f85e193739c953358c865005855253af4f68a497John McCall QualType LHS, Expr *RHS) { 4764f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime(); 4765f85e193739c953358c865005855253af4f68a497John McCall if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone) 4766921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return false; 4767921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // strip off any implicit cast added to get to the one arc-specific 4768921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 476933e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 4770f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::warn_arc_retained_assign) 4771f85e193739c953358c865005855253af4f68a497John McCall << (LT == Qualifiers::OCL_ExplicitNone) 4772f85e193739c953358c865005855253af4f68a497John McCall << RHS->getSourceRange(); 4773921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return true; 4774921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4775921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 4776921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4777921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return false; 4778f85e193739c953358c865005855253af4f68a497John McCall} 4779f85e193739c953358c865005855253af4f68a497John McCall 4780921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianvoid Sema::checkUnsafeExprAssigns(SourceLocation Loc, 4781921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Expr *LHS, Expr *RHS) { 478287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian QualType LHSType; 478387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // PropertyRef on LHS type need be directly obtained from 478487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // its declaration as it has a PsuedoType. 478587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian ObjCPropertyRefExpr *PRE 478687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens()); 478787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PRE && !PRE->isImplicitProperty()) { 478887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 478987eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PD) 479087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType = PD->getType(); 479187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian } 479287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian 479387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (LHSType.isNull()) 479487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType = LHS->getType(); 4795921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (checkUnsafeAssigns(Loc, LHSType, RHS)) 4796921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4797921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime(); 4798921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // FIXME. Check for other life times. 4799921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (LT != Qualifiers::OCL_None) 4800921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4801921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 480287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (PRE) { 4803921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (PRE->isImplicitProperty()) 4804921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4805921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 4806921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (!PD) 4807921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4808921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 4809921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian unsigned Attributes = PD->getPropertyAttributes(); 481087eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) { 481187eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // when 'assign' attribute was not explicitly specified 481287eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // by user, ignore it and rely on property type itself 481387eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian // for lifetime info. 481487eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten(); 481587eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) && 481687eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian LHSType->isObjCRetainableType()) 481787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian return; 481887eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian 4819921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 482033e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 4821921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Diag(Loc, diag::warn_arc_retained_property_assign) 4822921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian << RHS->getSourceRange(); 4823921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4824921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4825921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 4826921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 482787eaf726528124a1ad49f38402e9b619685fe30bFariborz Jahanian } 4828921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4829921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian} 4830