SemaChecking.cpp revision a7da2155167676a6a5d9fca4de947a9cab2a4908
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// The LLVM Compiler Infrastructure 459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source 60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details. 759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump// This file implements extra semantic analysis beyond what is enforced 1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// by the C type system. 1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 155f8d604246976a93a73549b07bbc8ee0b2061b50John McCall#include "clang/Sema/Initialization.h" 16e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Sema.h" 172d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 18276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman#include "clang/Sema/Initialization.h" 19781472fe99a120098c631b0cbe33c89f8cef5e70John McCall#include "clang/Sema/ScopeInfo.h" 20826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek#include "clang/Analysis/Analyses/FormatString.h" 2159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h" 22199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h" 23384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 24c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h" 252324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h" 267ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h" 27f85e193739c953358c865005855253af4f68a497John McCall#include "clang/AST/EvaluatedExprVisitor.h" 28f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/DeclObjC.h" 29f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h" 30f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h" 3159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h" 32f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h" 33f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h" 343bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h" 35691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher#include "clang/Basic/TargetBuiltins.h" 3626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman#include "clang/Basic/TargetInfo.h" 377da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian#include "clang/Basic/ConvertUTF.h" 38a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits> 3959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang; 40781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema; 4159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 4260800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 4360800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned ByteNo) const { 4408f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner return SL->getLocationOfByte(ByteNo, PP.getSourceManager(), 4508f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner PP.getLangOptions(), PP.getTargetInfo()); 4660800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner} 4708f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner 4860800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 494403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// CheckablePrintfAttr - does a function call have a "printf" attribute 504403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// and arguments that merit checking? 514403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynnbool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) { 524403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf") return true; 534403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf0") { 544403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn // printf0 allows null "format" string; if so don't check format/args 554403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn unsigned format_idx = Format->getFormatIdx() - 1; 564a2614e94672c47395abcde60518776fbebec589Sebastian Redl // Does the index refer to the implicit object argument? 574a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 584a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (format_idx == 0) 594a2614e94672c47395abcde60518776fbebec589Sebastian Redl return false; 604a2614e94672c47395abcde60518776fbebec589Sebastian Redl --format_idx; 614a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 624403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (format_idx < TheCall->getNumArgs()) { 634403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts(); 64efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!Format->isNullPointerConstant(Context, 65efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek Expr::NPC_ValueDependentIsNull)) 664403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return true; 674403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 684403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 694403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return false; 704403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn} 7160800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 728e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number. 738e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking. Returns true on error. 748e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) { 758e10f3b9cc1db43645bbc2999eb163af8997d468John McCall unsigned argCount = call->getNumArgs(); 768e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount == desiredArgCount) return false; 778e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 788e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount < desiredArgCount) 798e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args) 808e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 818e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getSourceRange(); 828e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 838e10f3b9cc1db43645bbc2999eb163af8997d468John McCall // Highlight all the excess arguments. 848e10f3b9cc1db43645bbc2999eb163af8997d468John McCall SourceRange range(call->getArg(desiredArgCount)->getLocStart(), 858e10f3b9cc1db43645bbc2999eb163af8997d468John McCall call->getArg(argCount - 1)->getLocEnd()); 868e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 878e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args) 888e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 898e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getArg(1)->getSourceRange(); 908e10f3b9cc1db43645bbc2999eb163af8997d468John McCall} 918e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 9277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge/// CheckBuiltinAnnotationString - Checks that string argument to the builtin 9377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge/// annotation is a non wide string literal. 9477f68bb90af93b95045fb994e7cd68137adcc132Julien Lerougestatic bool CheckBuiltinAnnotationString(Sema &S, Expr *Arg) { 9577f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge Arg = Arg->IgnoreParenCasts(); 9677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 9777f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge if (!Literal || !Literal->isAscii()) { 9877f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge S.Diag(Arg->getLocStart(), diag::err_builtin_annotation_not_string_constant) 9977f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge << Arg->getSourceRange(); 10077f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return true; 10177f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge } 10277f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return false; 10377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge} 10477f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge 10560d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 106d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 10760d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult TheCallResult(Owned(TheCall)); 1082def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor 109946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Find out if any arguments are required to be integer constant expressions. 110946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner unsigned ICEArguments = 0; 111946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ASTContext::GetBuiltinTypeError Error; 112946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 113946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (Error != ASTContext::GE_None) 114946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments = 0; // Don't diagnose previously diagnosed errors. 115946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 116946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // If any arguments are required to be ICE's, check and diagnose. 117946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 118946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Skip arguments not required to be ICE's. 119946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if ((ICEArguments & (1 << ArgNo)) == 0) continue; 120946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 121946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner llvm::APSInt Result; 122946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 123946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner return true; 124946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments &= ~(1 << ArgNo); 125946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner } 126946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 127d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson switch (BuiltinID) { 12830ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin___CFStringMakeConstantString: 129925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner assert(TheCall->getNumArgs() == 1 && 1301b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner "Wrong # arguments to builtin CFStringMakeConstantString"); 131690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner if (CheckObjCString(TheCall->getArg(0))) 1320eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 133d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 13449ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek case Builtin::BI__builtin_stdarg_start: 13530ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin_va_start: 1360eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinVAStart(TheCall)) 1370eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 138d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1391b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreater: 1401b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreaterequal: 1411b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isless: 1421b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessequal: 1431b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessgreater: 1441b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isunordered: 1450eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinUnorderedCompare(TheCall)) 1460eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 147d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 148e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer case Builtin::BI__builtin_fpclassify: 149e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer if (SemaBuiltinFPClassification(TheCall, 6)) 150e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer return ExprError(); 151e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer break; 1529ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isfinite: 1539ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf: 1549ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf_sign: 1559ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnan: 1569ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnormal: 1573b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (SemaBuiltinFPClassification(TheCall, 1)) 1589ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return ExprError(); 1599ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman break; 160d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman case Builtin::BI__builtin_shufflevector: 1610eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return SemaBuiltinShuffleVector(TheCall); 1620eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // TheCall will be freed by the smart pointer here, but that's fine, since 1630eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // SemaBuiltinShuffleVector guts it, but then doesn't release it. 1644493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar case Builtin::BI__builtin_prefetch: 1650eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinPrefetch(TheCall)) 1660eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 167d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 168d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar case Builtin::BI__builtin_object_size: 1690eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinObjectSize(TheCall)) 1700eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 171d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 172d875fed28578835de89cd407e9db4be788596d7cEli Friedman case Builtin::BI__builtin_longjmp: 173d875fed28578835de89cd407e9db4be788596d7cEli Friedman if (SemaBuiltinLongjmp(TheCall)) 174d875fed28578835de89cd407e9db4be788596d7cEli Friedman return ExprError(); 175d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1768e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 1778e10f3b9cc1db43645bbc2999eb163af8997d468John McCall case Builtin::BI__builtin_classify_type: 1788e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1798e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 1808e10f3b9cc1db43645bbc2999eb163af8997d468John McCall break; 18175c29a012793292ff4578015a9113bf086156d7fChris Lattner case Builtin::BI__builtin_constant_p: 1828e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1838e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 18475c29a012793292ff4578015a9113bf086156d7fChris Lattner break; 1855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: 1865caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: 1875caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: 1885caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: 1895caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: 1905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_add_and_fetch: 1915caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_sub_and_fetch: 1925caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_and_and_fetch: 1935caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_or_and_fetch: 1945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_xor_and_fetch: 1955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 1965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 1975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_test_and_set: 1985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 19923aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: 200d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return SemaBuiltinAtomicOverloaded(move(TheCallResult)); 201276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_load: 202276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Load); 203276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_store: 204276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Store); 205276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_exchange: 206276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Xchg); 207276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_compare_exchange_strong: 208276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), 209276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman AtomicExpr::CmpXchgStrong); 210276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_compare_exchange_weak: 211276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), 212276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman AtomicExpr::CmpXchgWeak); 213276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_add: 214276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Add); 215276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_sub: 216276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Sub); 217276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_and: 218276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::And); 219276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_or: 220276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Or); 221276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Builtin::BI__atomic_fetch_xor: 222276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return SemaAtomicOpsOverloaded(move(TheCallResult), AtomicExpr::Xor); 22377f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge case Builtin::BI__builtin_annotation: 22477f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge if (CheckBuiltinAnnotationString(*this, TheCall->getArg(1))) 22577f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge return ExprError(); 22677f68bb90af93b95045fb994e7cd68137adcc132Julien Lerouge break; 22726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 22826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 22926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // Since the target specific builtins for each arch overlap, only check those 23026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // of the arch we are compiling for. 23126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (BuiltinID >= Builtin::FirstTSBuiltin) { 232bcfd1f55bfbb3e5944cd5e03d07b343e280838c4Douglas Gregor switch (Context.getTargetInfo().getTriple().getArch()) { 23326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::arm: 23426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::thumb: 23526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 23626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return ExprError(); 23726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 23826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman default: 23926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 24026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 24126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 24226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 24326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return move(TheCallResult); 24426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman} 24526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 24661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code. 24761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) { 24861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman bool quad = t & 0x10; 24961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 25061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman switch (t & 0x7) { 25161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 0: // i8 252d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 7 : (8 << (int)quad) - 1; 25361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 1: // i16 254d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 15 : (4 << (int)quad) - 1; 25561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 2: // i32 256d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 31 : (2 << (int)quad) - 1; 25761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 3: // i64 258d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 63 : (1 << (int)quad) - 1; 25961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 4: // f32 26061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift float types!"); 261d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (2 << (int)quad) - 1; 26261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 5: // poly8 26342499f94069c73d7a9c82da98a4245ea9fe2c526Bob Wilson return shift ? 7 : (8 << (int)quad) - 1; 26461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 6: // poly16 26542499f94069c73d7a9c82da98a4245ea9fe2c526Bob Wilson return shift ? 15 : (4 << (int)quad) - 1; 26661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 7: // float16 26761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift float types!"); 268d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (4 << (int)quad) - 1; 26961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman } 27061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman return 0; 27161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman} 27261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 27326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 2741c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman llvm::APSInt Result; 2751c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2760d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned mask = 0; 27761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned TV = 0; 2781c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman switch (BuiltinID) { 279a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK 280a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 281a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK 2821c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman } 2831c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2840d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which are overloaded on vector element type, validate 2850d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // the immediate which specifies which variant to emit. 2860d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (mask) { 2870d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned ArgNo = TheCall->getNumArgs()-1; 2880d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 2890d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 2900d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 29161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman TV = Result.getLimitedValue(32); 29261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if ((TV > 31) || (mask & (1 << TV)) == 0) 2930d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 2940d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman << TheCall->getArg(ArgNo)->getSourceRange(); 2950d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman } 2961c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2970d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which take an immediate value as part of the 2980d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // instruction, range check them here. 29961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned i = 0, l = 0, u = 0; 3000d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman switch (BuiltinID) { 3010d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman default: return false; 302bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 303bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 30499c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_f: 30599c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 306a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK 307a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 308a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK 3090d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman }; 3100d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 31161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Check that the immediate argument is actually a constant. 3120d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, i, Result)) 3130d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 3140d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 31561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Range check against the upper/lower values for this isntruction. 3160d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned Val = Result.getZExtValue(); 31761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if (Val < l || Val > (u + l)) 3180d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 319476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer << l << u+l << TheCall->getArg(i)->getSourceRange(); 3200d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 32199c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman // FIXME: VFP Intrinsics should error if VFP not present. 32226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return false; 323d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson} 324d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 325d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// CheckFunctionCall - Check a direct function call for various correctness 326d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// and safety properties not strictly enforced by the C type system. 327d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) { 328d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // Get the IdentifierInfo* for the called function. 329d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson IdentifierInfo *FnInfo = FDecl->getIdentifier(); 330de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 331d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // None of the checks below are needed for functions that don't have 332d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // simple names (e.g., C++ conversion functions). 333d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson if (!FnInfo) 334d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 336de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // FIXME: This mechanism should be abstracted to be less fragile and 337de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // more efficient. For example, just map function ids to custom 338de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // handlers. 339de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 340c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek // Printf and scanf checking. 341c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<FormatAttr> 342c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<FormatAttr>(), 343c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<FormatAttr>(); i != e ; ++i) { 344c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek 345c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek const FormatAttr *Format = *i; 346826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 347826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (b || CheckablePrintfAttr(Format, TheCall)) { 3483d692df4b9c58895f9843b03543ec57447c93679Ted Kremenek bool HasVAListArg = Format->getFirstArg() == 0; 349826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, 350826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Format->getFormatIdx() - 1, 351826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, 352826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek !b); 3533c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor } 35459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner } 3551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 356c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<NonNullAttr> 357c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<NonNullAttr>(), 358c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<NonNullAttr>(); i != e; ++i) { 359909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky CheckNonNullArguments(*i, TheCall->getArgs(), 360909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky TheCall->getCallee()->getLocStart()); 361c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek } 3620eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 36320cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne CheckStaticArrayArguments(FDecl, TheCall->getArgs(), 36420cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne TheCall->getCallee()->getLocStart()); 36520cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne 366bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Builtin handling 367707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor int CMF = -1; 368707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor switch (FDecl->getBuiltinID()) { 369707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin_memset: 370707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin___memset_chk: 371707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BImemset: 372707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memset; 373707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor break; 374707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor 375707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin_memcpy: 376707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin___memcpy_chk: 377707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BImemcpy: 378707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memcpy; 379707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor break; 380707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor 381707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin_memmove: 382707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BI__builtin___memmove_chk: 383707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor case Builtin::BImemmove: 384707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memmove; 385707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor break; 386bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 387bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek case Builtin::BIstrlcpy: 388bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek case Builtin::BIstrlcat: 389bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CheckStrlcpycatArguments(TheCall, FnInfo); 390bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 391707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor 392cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay case Builtin::BI__builtin_memcmp: 393cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay CMF = CMF_Memcmp; 394cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay break; 395cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay 396cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber case Builtin::BI__builtin_strncpy: 397cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber case Builtin::BI__builtin___strncpy_chk: 398cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber case Builtin::BIstrncpy: 399cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strncpy; 400cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber break; 401cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber 402cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber case Builtin::BI__builtin_strncmp: 403cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strncmp; 404cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber break; 405cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber 406cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber case Builtin::BI__builtin_strncasecmp: 407cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strncasecmp; 408cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber break; 409cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber 410cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber case Builtin::BI__builtin_strncat: 411cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber case Builtin::BIstrncat: 412cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strncat; 413cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber break; 414cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber 415cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber case Builtin::BI__builtin_strndup: 416cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber case Builtin::BIstrndup: 417cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strndup; 418cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber break; 419cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber 420707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor default: 421707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor if (FDecl->getLinkage() == ExternalLinkage && 422707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor (!getLangOptions().CPlusPlus || FDecl->isExternC())) { 423707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor if (FnInfo->isStr("memset")) 424707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memset; 425707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor else if (FnInfo->isStr("memcpy")) 426707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memcpy; 427707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor else if (FnInfo->isStr("memmove")) 428707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor CMF = CMF_Memmove; 429cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay else if (FnInfo->isStr("memcmp")) 430cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay CMF = CMF_Memcmp; 431cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber else if (FnInfo->isStr("strncpy")) 432cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strncpy; 433cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber else if (FnInfo->isStr("strncmp")) 434cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strncmp; 435cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber else if (FnInfo->isStr("strncasecmp")) 436cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strncasecmp; 437cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber else if (FnInfo->isStr("strncat")) 438cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strncat; 439cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber else if (FnInfo->isStr("strndup")) 440cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber CMF = CMF_Strndup; 441707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor } 442707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor break; 44306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 444707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor 445bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Memset/memcpy/memmove handling 446707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor if (CMF != -1) 447cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay CheckMemaccessArguments(TheCall, CheckedMemoryFunction(CMF), FnInfo); 4487ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 449d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 45071993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson} 45171993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 452d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) { 453725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian // Printf checking. 45440b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis const FormatAttr *Format = NDecl->getAttr<FormatAttr>(); 455725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Format) 456d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 4571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 458725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian const VarDecl *V = dyn_cast<VarDecl>(NDecl); 459725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!V) 460d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 4611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 462725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian QualType Ty = V->getType(); 463725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Ty->isBlockPointerType()) 464d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 4651eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 466826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 467826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!b && !CheckablePrintfAttr(Format, TheCall)) 468d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 4691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 470d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson bool HasVAListArg = Format->getFirstArg() == 0; 471826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1, 472826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, !b); 473d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 474d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 475725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian} 476725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian 477276b061970939293f1abaf694bd3ef05b2cbda79Eli FriedmanExprResult 478276b061970939293f1abaf694bd3ef05b2cbda79Eli FriedmanSema::SemaAtomicOpsOverloaded(ExprResult TheCallResult, AtomicExpr::AtomicOp Op) { 479276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman CallExpr *TheCall = cast<CallExpr>(TheCallResult.get()); 480276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 481276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 482276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // All these operations take one of the following four forms: 483276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // T __atomic_load(_Atomic(T)*, int) (loads) 484276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // T* __atomic_add(_Atomic(T*)*, ptrdiff_t, int) (pointer add/sub) 485276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // int __atomic_compare_exchange_strong(_Atomic(T)*, T*, T, int, int) 486276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // (cmpxchg) 487276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // T __atomic_exchange(_Atomic(T)*, T, int) (everything else) 488276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // where T is an appropriate type, and the int paremeterss are for orderings. 489276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman unsigned NumVals = 1; 490276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman unsigned NumOrders = 1; 491276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Op == AtomicExpr::Load) { 492276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman NumVals = 0; 493276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else if (Op == AtomicExpr::CmpXchgWeak || Op == AtomicExpr::CmpXchgStrong) { 494276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman NumVals = 2; 495276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman NumOrders = 2; 496276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 497276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 498276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (TheCall->getNumArgs() < NumVals+NumOrders+1) { 499276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 500276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << 0 << NumVals+NumOrders+1 << TheCall->getNumArgs() 501276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 502276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 503276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else if (TheCall->getNumArgs() > NumVals+NumOrders+1) { 504276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(TheCall->getArg(NumVals+NumOrders+1)->getLocStart(), 505276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman diag::err_typecheck_call_too_many_args) 506276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << 0 << NumVals+NumOrders+1 << TheCall->getNumArgs() 507276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << TheCall->getCallee()->getSourceRange(); 508276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 509276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 510276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 511276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // Inspect the first argument of the atomic operation. This should always be 512276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // a pointer to an _Atomic type. 513dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman Expr *Ptr = TheCall->getArg(0); 514276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get(); 515276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman const PointerType *pointerType = Ptr->getType()->getAs<PointerType>(); 516276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!pointerType) { 517276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic) 518276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 519276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 520276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 521276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 522276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType AtomTy = pointerType->getPointeeType(); 523276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!AtomTy->isAtomicType()) { 524276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic) 525276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 526276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 527276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 528276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType ValType = AtomTy->getAs<AtomicType>()->getValueType(); 529276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 530276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if ((Op == AtomicExpr::Add || Op == AtomicExpr::Sub) && 531276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman !ValType->isIntegerType() && !ValType->isPointerType()) { 532276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr) 533276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 534276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 535276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 536276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 537276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (!ValType->isIntegerType() && 538276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman (Op == AtomicExpr::And || Op == AtomicExpr::Or || Op == AtomicExpr::Xor)){ 539276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_atomic_op_logical_needs_atomic_int) 540276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << Ptr->getType() << Ptr->getSourceRange(); 541276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 542276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 543276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 544276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman switch (ValType.getObjCLifetime()) { 545276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_None: 546276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_ExplicitNone: 547276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // okay 548276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman break; 549276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 550276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Weak: 551276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Strong: 552276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman case Qualifiers::OCL_Autoreleasing: 553276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 554276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman << ValType << Ptr->getSourceRange(); 555276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return ExprError(); 556276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 557276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 558276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType ResultType = ValType; 559276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Op == AtomicExpr::Store) 560276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.VoidTy; 561276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman else if (Op == AtomicExpr::CmpXchgWeak || Op == AtomicExpr::CmpXchgStrong) 562276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ResultType = Context.BoolTy; 563276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 564276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The first argument --- the pointer --- has a fixed type; we 565276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // deduce the types of the rest of the arguments accordingly. Walk 566276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // the remaining arguments, converting them to the deduced value type. 567276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman for (unsigned i = 1; i != NumVals+NumOrders+1; ++i) { 568276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman ExprResult Arg = TheCall->getArg(i); 569276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman QualType Ty; 570276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (i < NumVals+1) { 571276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The second argument to a cmpxchg is a pointer to the data which will 572276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // be exchanged. The second argument to a pointer add/subtract is the 573276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // amount to add/subtract, which must be a ptrdiff_t. The third 574276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // argument to a cmpxchg and the second argument in all other cases 575276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // is the type of the value. 576276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (i == 1 && (Op == AtomicExpr::CmpXchgWeak || 577276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Op == AtomicExpr::CmpXchgStrong)) 578276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.getPointerType(ValType.getUnqualifiedType()); 579276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman else if (!ValType->isIntegerType() && 580276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman (Op == AtomicExpr::Add || Op == AtomicExpr::Sub)) 581276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.getPointerDiffType(); 582276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman else 583276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = ValType; 584276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else { 585276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman // The order(s) are always converted to int. 586276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Ty = Context.IntTy; 587276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 588276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity Entity = 589276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman InitializedEntity::InitializeParameter(Context, Ty, false); 590276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 591276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Arg.isInvalid()) 592276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman return true; 593276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman TheCall->setArg(i, Arg.get()); 594276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 595276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 596dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SmallVector<Expr*, 5> SubExprs; 597dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(Ptr); 598276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman if (Op == AtomicExpr::Load) { 599dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Order 600276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else if (Op != AtomicExpr::CmpXchgWeak && Op != AtomicExpr::CmpXchgStrong) { 601dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(2)); // Order 602dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 603276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } else { 604dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(3)); // Order 605dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(1)); // Val1 606dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(2)); // Val2 607dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.push_back(TheCall->getArg(4)); // OrderFail 608276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman } 609dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman 610dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman return Owned(new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(), 611dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman SubExprs.data(), SubExprs.size(), 612dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman ResultType, Op, 613dfa64ba45922e1c28e36341bdf34785fea74659bEli Friedman TheCall->getRParenLoc())); 614276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman} 615276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 616276b061970939293f1abaf694bd3ef05b2cbda79Eli Friedman 6175f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// checkBuiltinArgument - Given a call to a builtin function, perform 6185f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// normal type-checking on the given argument, updating the call in 6195f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// place. This is useful when a builtin function requires custom 6205f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// type-checking for some of its arguments but not necessarily all of 6215f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// them. 6225f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// 6235f8d604246976a93a73549b07bbc8ee0b2061b50John McCall/// Returns true on error. 6245f8d604246976a93a73549b07bbc8ee0b2061b50John McCallstatic bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) { 6255f8d604246976a93a73549b07bbc8ee0b2061b50John McCall FunctionDecl *Fn = E->getDirectCallee(); 6265f8d604246976a93a73549b07bbc8ee0b2061b50John McCall assert(Fn && "builtin call without direct callee!"); 6275f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 6285f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ParmVarDecl *Param = Fn->getParamDecl(ArgIndex); 6295f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity Entity = 6305f8d604246976a93a73549b07bbc8ee0b2061b50John McCall InitializedEntity::InitializeParameter(S.Context, Param); 6315f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 6325f8d604246976a93a73549b07bbc8ee0b2061b50John McCall ExprResult Arg = E->getArg(0); 6335f8d604246976a93a73549b07bbc8ee0b2061b50John McCall Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg); 6345f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (Arg.isInvalid()) 6355f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 6365f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 6375f8d604246976a93a73549b07bbc8ee0b2061b50John McCall E->setArg(ArgIndex, Arg.take()); 6385f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return false; 6395f8d604246976a93a73549b07bbc8ee0b2061b50John McCall} 6405f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 6415caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like 6425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer 6435caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument. The main ActOnCallExpr routines have already 6445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as 6455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...). 6465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// 6475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these 6485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins, 64960d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 65060d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 651d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 6525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 6535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 6545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 6555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Ensure that we have at least one argument to do type inference from. 656d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1) { 657d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 658d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1 << TheCall->getNumArgs() 659d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 660d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 661d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 6621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 6635caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Inspect the first argument of the atomic builtin. This should always be 6645caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // a pointer type, whose element is an integral scalar or pointer type. 6655caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Because it is a pointer type, we don't have to worry about any implicit 6665caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // casts here. 667d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth // FIXME: We don't allow floating point scalars as input. 6685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *FirstArg = TheCall->getArg(0); 669f85e193739c953358c865005855253af4f68a497John McCall const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>(); 670f85e193739c953358c865005855253af4f68a497John McCall if (!pointerType) { 671d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 672d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 673d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 674d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 6751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 676f85e193739c953358c865005855253af4f68a497John McCall QualType ValType = pointerType->getPointeeType(); 677dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 678d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth !ValType->isBlockPointerType()) { 679d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 680d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 681d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 682d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 6835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 684f85e193739c953358c865005855253af4f68a497John McCall switch (ValType.getObjCLifetime()) { 685f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_None: 686f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_ExplicitNone: 687f85e193739c953358c865005855253af4f68a497John McCall // okay 688f85e193739c953358c865005855253af4f68a497John McCall break; 689f85e193739c953358c865005855253af4f68a497John McCall 690f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Weak: 691f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Strong: 692f85e193739c953358c865005855253af4f68a497John McCall case Qualifiers::OCL_Autoreleasing: 693b8b0313e84700b5c6d597b3be4de41c97b7550f1Argyrios Kyrtzidis Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership) 694f85e193739c953358c865005855253af4f68a497John McCall << ValType << FirstArg->getSourceRange(); 695f85e193739c953358c865005855253af4f68a497John McCall return ExprError(); 696f85e193739c953358c865005855253af4f68a497John McCall } 697f85e193739c953358c865005855253af4f68a497John McCall 698b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Strip any qualifiers off ValType. 699b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType = ValType.getUnqualifiedType(); 700b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall 7018d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // The majority of builtins return a value, but a few have special return 7028d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // types, so allow them to override appropriately below. 7038d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth QualType ResultType = ValType; 7048d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth 7055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // We need to figure out which concrete builtin this maps onto. For example, 7065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add with a 2 byte object turns into 7075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add_2. 7085caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \ 7095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 7105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Builtin::BI##x##_8, Builtin::BI##x##_16 } 7111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner static const unsigned BuiltinIndices[][5] = { 7135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_add), 7145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_sub), 7155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_or), 7165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_and), 7175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_xor), 7181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7195caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_add_and_fetch), 7205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_sub_and_fetch), 7215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_and_and_fetch), 7225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_or_and_fetch), 7235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_xor_and_fetch), 7241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_val_compare_and_swap), 7265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_bool_compare_and_swap), 7275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_test_and_set), 72823aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_lock_release), 72923aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner BUILTIN_ROW(__sync_swap) 7305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner }; 7311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW 7321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Determine the index of the size. 7345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned SizeIndex; 735199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 7365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 1: SizeIndex = 0; break; 7375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 2: SizeIndex = 1; break; 7385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 4: SizeIndex = 2; break; 7395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 8: SizeIndex = 3; break; 7405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 16: SizeIndex = 4; break; 7415caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: 742d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 743d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 744d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 7455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 7461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Each of these builtins has one pointer argument, followed by some number of 7485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // values (0, 1 or 2) followed by a potentially empty varags list of stuff 7495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // that we ignore. Find out which row of BuiltinIndices to read from as well 7505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // as the number of fixed args. 7517814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor unsigned BuiltinID = FDecl->getBuiltinID(); 7525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned BuiltinIndex, NumFixed = 1; 7535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner switch (BuiltinID) { 754b219cfc4d75f0a03630b7c4509ef791b7e97b2c8David Blaikie default: llvm_unreachable("Unknown overloaded atomic builtin!"); 7555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break; 7565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break; 7575caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break; 7585caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break; 7595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break; 7601eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7617eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break; 7627eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break; 7637eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break; 7647eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break; 7657eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break; 7661eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7675caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 7687eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 10; 7695caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 7705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 7715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 7727eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 11; 7735caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 7748d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.BoolTy; 7755caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 7767eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break; 7775caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 7787eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 13; 7795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 0; 7808d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.VoidTy; 7815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 78223aa9c8ca0bc441aab2a38a4c9fc7a1c9e9ac16aChris Lattner case Builtin::BI__sync_swap: BuiltinIndex = 14; break; 7835caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 7841eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 7855caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Now that we know how many fixed arguments we expect, first check that we 7865caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // have at least that many. 787d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1+NumFixed) { 788d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 789d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1+NumFixed << TheCall->getNumArgs() 790d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 791d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 792d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 7931eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 794e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // Get the decl for the concrete builtin from this, we can tell what the 795e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // concrete integer type we should convert to is. 796e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 797e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 798e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName); 7991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump FunctionDecl *NewBuiltinDecl = 800e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID, 801e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner TUScope, false, DRE->getLocStart())); 802d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 803f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // The first argument --- the pointer --- has a fixed type; we 804f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // deduce the types of the rest of the arguments accordingly. Walk 805f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // the remaining arguments, converting them to the deduced value type. 8065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner for (unsigned i = 0; i != NumFixed; ++i) { 807429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult Arg = TheCall->getArg(i+1); 8081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // If the argument is an implicit cast, then there was a promotion due to 8105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // "...", just remove it now. 811429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg.get())) { 8125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Arg = ICE->getSubExpr(); 8135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner ICE->setSubExpr(0); 814429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(i+1, Arg.get()); 8155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 8161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // GCC does an implicit conversion to the pointer or integer ValType. This 8185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // can fail in some cases (1i -> int**), check for this error case now. 819b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall // Initialize the argument. 820b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall InitializedEntity Entity = InitializedEntity::InitializeParameter(Context, 821b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall ValType, /*consume*/ false); 822b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg); 823429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (Arg.isInvalid()) 824d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 8251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Okay, we have something that *can* be converted to the right type. Check 8275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // to see if there is a potentially weird extension going on here. This can 8285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // happen when you do an atomic operation on something like an char* and 8295caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // pass in 42. The 42 gets converted to char. This is even more strange 8305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // for things like 45.123 -> char, etc. 8311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // FIXME: Do this check. 832b45ae256cfd5ef3ab22b4d715159f978d8120d45John McCall TheCall->setArg(i+1, Arg.take()); 8335caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 8341eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 835bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor ASTContext& Context = this->getASTContext(); 836bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor 837bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor // Create a new DeclRefExpr to refer to the new decl. 838bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DeclRefExpr* NewDRE = DeclRefExpr::Create( 839bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor Context, 840bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getQualifierLoc(), 841bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor NewBuiltinDecl, 842bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getLocation(), 843bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor NewBuiltinDecl->getType(), 844bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor DRE->getValueKind()); 8451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Set the callee in the CallExpr. 8475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // FIXME: This leaks the original parens and implicit casts. 848bbcb7ea8a062a8f1d5cb504e4518a5d4fbab873aDouglas Gregor ExprResult PromotedCall = UsualUnaryConversions(NewDRE); 849429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (PromotedCall.isInvalid()) 850429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return ExprError(); 851429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setCallee(PromotedCall.take()); 8521eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 853db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // Change the result type of the call to match the original value type. This 854db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // is arbitrary, but the codegen for these builtins ins design to handle it 855db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // gracefully. 8568d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth TheCall->setType(ResultType); 857d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 858d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return move(TheCallResult); 8595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner} 8605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 861690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin 86271993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct 863fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would 864fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend). 865690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) { 86656f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner Arg = Arg->IgnoreParenCasts(); 86771993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 86871993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 8695cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!Literal || !Literal->isAscii()) { 870fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 871fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << Arg->getSourceRange(); 8729cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return true; 87371993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson } 8741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8757da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Literal->containsNonAsciiOrNull()) { 8765f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef String = Literal->getString(); 8777da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian unsigned NumBytes = String.size(); 8785f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<UTF16, 128> ToBuf(NumBytes); 8797da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian const UTF8 *FromPtr = (UTF8 *)String.data(); 8807da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian UTF16 *ToPtr = &ToBuf[0]; 8817da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 8827da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 8837da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian &ToPtr, ToPtr + NumBytes, 8847da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian strictConversion); 8857da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian // Check for conversion failure. 8867da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Result != conversionOK) 8877da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian Diag(Arg->getLocStart(), 8887da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian diag::warn_cfstring_truncated) << Arg->getSourceRange(); 8897da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian } 8909cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return false; 89159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner} 89259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 893c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 894c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success. 895925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 896925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *Fn = TheCall->getCallee(); 897925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) { 8982c21a073525cdfa68e4439b7af551385dc2796abChris Lattner Diag(TheCall->getArg(2)->getLocStart(), 899fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 900ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 901ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << Fn->getSourceRange() 9021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(2)->getLocStart(), 903fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 90430ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 90530ce344307f8a8b00054021307015571f83c7364Chris Lattner } 90656f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 90756f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman if (TheCall->getNumArgs() < 2) { 908d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher return Diag(TheCall->getLocEnd(), 909d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 910d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 91156f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman } 91256f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 9135f8d604246976a93a73549b07bbc8ee0b2061b50John McCall // Type-check the first argument normally. 9145f8d604246976a93a73549b07bbc8ee0b2061b50John McCall if (checkBuiltinArgument(*this, TheCall, 0)) 9155f8d604246976a93a73549b07bbc8ee0b2061b50John McCall return true; 9165f8d604246976a93a73549b07bbc8ee0b2061b50John McCall 917c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner // Determine whether the current function is variadic or not. 9189ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor BlockScopeInfo *CurBlock = getCurBlock(); 919c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner bool isVariadic; 920cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 921c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall isVariadic = CurBlock->TheDecl->isVariadic(); 9229498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else if (FunctionDecl *FD = getCurFunctionDecl()) 9239498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek isVariadic = FD->isVariadic(); 9249498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else 92553d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis isVariadic = getCurMethodDecl()->isVariadic(); 9261eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 927c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner if (!isVariadic) { 92830ce344307f8a8b00054021307015571f83c7364Chris Lattner Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 92930ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 93030ce344307f8a8b00054021307015571f83c7364Chris Lattner } 9311eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 93230ce344307f8a8b00054021307015571f83c7364Chris Lattner // Verify that the second argument to the builtin is the last argument of the 93330ce344307f8a8b00054021307015571f83c7364Chris Lattner // current function or method. 93430ce344307f8a8b00054021307015571f83c7364Chris Lattner bool SecondArgIsLastNamedArgument = false; 935e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 9361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 93788cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 93888cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 93930ce344307f8a8b00054021307015571f83c7364Chris Lattner // FIXME: This isn't correct for methods (results in bogus warning). 94030ce344307f8a8b00054021307015571f83c7364Chris Lattner // Get the last formal in the current function. 94188cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson const ParmVarDecl *LastArg; 942cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 943cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff LastArg = *(CurBlock->TheDecl->param_end()-1); 944cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff else if (FunctionDecl *FD = getCurFunctionDecl()) 945371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner LastArg = *(FD->param_end()-1); 94630ce344307f8a8b00054021307015571f83c7364Chris Lattner else 94753d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis LastArg = *(getCurMethodDecl()->param_end()-1); 94830ce344307f8a8b00054021307015571f83c7364Chris Lattner SecondArgIsLastNamedArgument = PV == LastArg; 94930ce344307f8a8b00054021307015571f83c7364Chris Lattner } 95030ce344307f8a8b00054021307015571f83c7364Chris Lattner } 9511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 95230ce344307f8a8b00054021307015571f83c7364Chris Lattner if (!SecondArgIsLastNamedArgument) 9531eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(1)->getLocStart(), 95430ce344307f8a8b00054021307015571f83c7364Chris Lattner diag::warn_second_parameter_of_va_start_not_last_named_argument); 95530ce344307f8a8b00054021307015571f83c7364Chris Lattner return false; 9566cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman} 95730ce344307f8a8b00054021307015571f83c7364Chris Lattner 9581b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 9591b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends. This is declared to take (...), so we have to check everything. 960925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 961925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() < 2) 9622c21a073525cdfa68e4439b7af551385dc2796abChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 963d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << 2 << TheCall->getNumArgs()/*function call*/; 964925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) 9651eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(TheCall->getArg(2)->getLocStart(), 966fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 967ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 968fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(TheCall->getArg(2)->getLocStart(), 969fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 9701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 971429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg0 = TheCall->getArg(0); 972429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley ExprResult OrigArg1 = TheCall->getArg(1); 973cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 9741b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // Do standard promotions between the two arguments, returning their common 9751b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // type. 976925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 977429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.isInvalid() || OrigArg1.isInvalid()) 978429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return true; 979403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar 980403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // Make sure any conversions are pushed back into the call; this is 981403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // type safe since unordered compare builtins are declared as "_Bool 982403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // foo(...)". 983429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(0, OrigArg0.get()); 984429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley TheCall->setArg(1, OrigArg1.get()); 9851eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 986429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent()) 987cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 988cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 9891b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // If the common type isn't a real floating type, then the arguments were 9901b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // invalid for this operation. 9911b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner if (!Res->isRealFloatingType()) 992429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley return Diag(OrigArg0.get()->getLocStart(), 993fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_invalid_ordered_compare) 994429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << OrigArg0.get()->getType() << OrigArg1.get()->getType() 995429bb276991ff2dbc7c5b438828b9b7737cb15ebJohn Wiegley << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd()); 9961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 9971b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner return false; 9981b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner} 9991b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner 1000e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 1001e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends. This is declared to take (...), so we have 10023b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point 10033b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value. 10043b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 10053b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() < NumArgs) 10069ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 1007d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 10083b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() > NumArgs) 10093b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer return Diag(TheCall->getArg(NumArgs)->getLocStart(), 10109ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_too_many_args) 1011ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 10123b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 10139ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman (*(TheCall->arg_end()-1))->getLocEnd()); 10149ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 10153b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer Expr *OrigArg = TheCall->getArg(NumArgs-1); 10161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10179ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (OrigArg->isTypeDependent()) 10189ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 10199ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 102081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // This operation requires a non-_Complex floating-point number. 10219ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (!OrigArg->getType()->isRealFloatingType()) 10221eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg->getLocStart(), 10239ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_invalid_unary_fp) 10249ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman << OrigArg->getType() << OrigArg->getSourceRange(); 10251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 102681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // If this is an implicit conversion from float -> double, remove it. 102781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 102881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Expr *CastArg = Cast->getSubExpr(); 102981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 103081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 103181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner "promotion from float to double is the only expected cast here"); 103281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Cast->setSubExpr(0); 103381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner TheCall->setArg(NumArgs-1, CastArg); 103481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner OrigArg = CastArg; 103581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 103681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 103781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner 10389ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 10399ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman} 10409ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 1041d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 1042d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything. 104360d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 104437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() < 2) 10450eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocEnd(), 1046d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 104737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << 0 /*function call*/ << 2 << TheCall->getNumArgs() 1048d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << TheCall->getSourceRange()); 1049d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 105037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Determine which of the following types of shufflevector we're checking: 105137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 1) unary, vector mask: (lhs, mask) 105237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 2) binary, vector mask: (lhs, rhs, mask) 105337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 105437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType resType = TheCall->getArg(0)->getType(); 105537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numElements = 0; 105637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 1057cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (!TheCall->getArg(0)->isTypeDependent() && 1058cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor !TheCall->getArg(1)->isTypeDependent()) { 105937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType LHSType = TheCall->getArg(0)->getType(); 106037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType RHSType = TheCall->getArg(1)->getType(); 106137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 106237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!LHSType->isVectorType() || !RHSType->isVectorType()) { 1063cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) 10641eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1065cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1066cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 1067cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 106837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 106937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numElements = LHSType->getAs<VectorType>()->getNumElements(); 107037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numResElements = TheCall->getNumArgs() - 2; 107137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 107237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Check to see if we have a call with 2 vector arguments, the unary shuffle 107337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // with mask. If so, verify that RHS is an integer vector type with the 107437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // same number of elts as lhs. 107537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() == 2) { 1076f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (!RHSType->hasIntegerRepresentation() || 107737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman RHSType->getAs<VectorType>()->getNumElements() != numElements) 107837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 107937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << SourceRange(TheCall->getArg(1)->getLocStart(), 108037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman TheCall->getArg(1)->getLocEnd()); 108137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numResElements = numElements; 108237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } 108337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 1084cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 10851eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 1086cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 1087cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 108837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } else if (numElements != numResElements) { 108937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 1090788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner resType = Context.getVectorType(eltType, numResElements, 1091e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson VectorType::GenericVector); 1092cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 1093d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1094d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1095d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 1096cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 1097cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(i)->isValueDependent()) 1098cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor continue; 1099cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 110037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman llvm::APSInt Result(32); 110137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 110237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman return ExprError(Diag(TheCall->getLocStart(), 110337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman diag::err_shufflevector_nonconstant_argument) 110437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << TheCall->getArg(i)->getSourceRange()); 11050eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 1106d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 11070eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocStart(), 1108fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_shufflevector_argument_too_large) 11090eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl << TheCall->getArg(i)->getSourceRange()); 1110d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1111d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 11125f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<Expr*, 32> exprs; 1113d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1114d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 1115d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman exprs.push_back(TheCall->getArg(i)); 1116d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman TheCall->setArg(i, 0); 1117d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 1118d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 1119a88dc3079bedf70a5cfc39791727e43a10383006Nate Begeman return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(), 112037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman exprs.size(), resType, 11218189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getCallee()->getLocStart(), 11228189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getRParenLoc())); 1123d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman} 112430ce344307f8a8b00054021307015571f83c7364Chris Lattner 11254493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 11264493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two 11274493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args. 11284493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 1129fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner unsigned NumArgs = TheCall->getNumArgs(); 11304493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1131fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (NumArgs > 3) 1132ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher return Diag(TheCall->getLocEnd(), 1133ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher diag::err_typecheck_call_too_many_args_at_most) 1134ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 3 << NumArgs 1135ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << TheCall->getSourceRange(); 11364493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 11374493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // Argument 0 is checked for us and the remaining arguments must be 11384493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // constant integers. 1139fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner for (unsigned i = 1; i != NumArgs; ++i) { 11404493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar Expr *Arg = TheCall->getArg(i); 1141691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 11429aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman llvm::APSInt Result; 1143691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, i, Result)) 1144691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 11451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 11464493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // FIXME: gcc issues a warning and rewrites these to 0. These 11474493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // seems especially odd for the third argument since the default 11484493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // is 3. 1149fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (i == 1) { 11509aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 1) 1151fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 115221fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "1" << Arg->getSourceRange(); 11534493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } else { 11549aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 3) 1155fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 115621fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "3" << Arg->getSourceRange(); 11574493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 11584493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 11594493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1160fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return false; 11614493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar} 11624493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 1163691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 1164691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression. 1165691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 1166691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt &Result) { 1167691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(ArgNum); 1168691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 1169691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 1170691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1171691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 1172691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1173691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (!Arg->isIntegerConstantExpr(Result, Context)) 1174691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 11755e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher << FDecl->getDeclName() << Arg->getSourceRange(); 1176691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 117721fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner return false; 117821fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner} 117921fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner 1180d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 1181d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined 1182d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3). 1183fc8f0e14ad142ed811e90fbd9a30e419e301c717Chris Lattner// For compatibility check 0-3, llvm only handles 0 and 2. 1184d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 1185691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1186691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1187691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // Check constant-ness first. 1188691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1189691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1190d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1191691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(1); 1192d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 1193fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 1194fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1195d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar } 1196d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1197d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar return false; 1198d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar} 1199d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 1200586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 1201d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1. 1202d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 1203d875fed28578835de89cd407e9db4be788596d7cEli Friedman Expr *Arg = TheCall->getArg(1); 1204691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 1205cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 1206691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // TODO: This is less than ideal. Overload this to take a value. 1207691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 1208691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 1209691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 1210691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Result != 1) 1211d875fed28578835de89cd407e9db4be788596d7cEli Friedman return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 1212d875fed28578835de89cd407e9db4be788596d7cEli Friedman << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 1213d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1214d875fed28578835de89cd407e9db4be788596d7cEli Friedman return false; 1215d875fed28578835de89cd407e9db4be788596d7cEli Friedman} 1216d875fed28578835de89cd407e9db4be788596d7cEli Friedman 1217b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek// Handle i > 1 ? "x" : "y", recursively. 1218082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenekbool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall, 1219082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool HasVAListArg, 1220826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1221826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 12224fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain: 1223cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 1224cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 1225d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1226f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 1227f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 1228d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek switch (E->getStmtClass()) { 122956ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::BinaryConditionalOperatorClass: 1230d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ConditionalOperatorClass: { 123156ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall const AbstractConditionalOperator *C = cast<AbstractConditionalOperator>(E); 1232826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return SemaCheckStringLiteral(C->getTrueExpr(), TheCall, HasVAListArg, 1233826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf) 123456ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall && SemaCheckStringLiteral(C->getFalseExpr(), TheCall, HasVAListArg, 1235826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf); 1236d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1237d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 123895355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek case Stmt::IntegerLiteralClass: 123995355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // Technically -Wformat-nonliteral does not warn about this case. 124095355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // The behavior of printf and friends in this case is implementation 124195355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // dependent. Ideally if the format string cannot be null then 124295355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // it should have a 'nonnull' attribute in the function prototype. 124395355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek return true; 124495355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek 1245d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ImplicitCastExprClass: { 12464fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ImplicitCastExpr>(E)->getSubExpr(); 12474fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 1248d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1249d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 125056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::OpaqueValueExprClass: 125156ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) { 125256ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall E = src; 125356ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall goto tryAgain; 125456ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall } 125556ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall return false; 125656ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall 1257b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek case Stmt::PredefinedExprClass: 1258b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // While __func__, etc., are technically not string literals, they 1259b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // cannot contain format specifiers and thus are not a security 1260b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // liability. 1261b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek return true; 1262b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek 1263082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::DeclRefExprClass: { 1264082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const DeclRefExpr *DR = cast<DeclRefExpr>(E); 12651eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1266082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // As an exception, do not flag errors for variables binding to 1267082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // const string literals. 1268082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 1269082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool isConstant = false; 1270082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek QualType T = DR->getType(); 1271082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek 1272082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ArrayType *AT = Context.getAsArrayType(T)) { 1273082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek isConstant = AT->getElementType().isConstant(Context); 1274ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (const PointerType *PT = T->getAs<PointerType>()) { 12751eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump isConstant = T.isConstant(Context) && 1276082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek PT->getPointeeType().isConstant(Context); 1277082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 12781eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1279082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (isConstant) { 128031310a21fb2a9f13950f864f681c86080b05d5b2Sebastian Redl if (const Expr *Init = VD->getAnyInitializer()) 1281082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return SemaCheckStringLiteral(Init, TheCall, 1282826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, format_idx, firstDataArg, 1283826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isPrintf); 1284082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 12851eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1286d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // For vprintf* functions (i.e., HasVAListArg==true), we add a 1287d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // special check to see if the format string is a function parameter 1288d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // of the function calling the printf function. If the function 1289d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // has an attribute indicating it is a printf-like function, then we 1290d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // should suppress warnings concerning non-literals being used in a call 1291d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // to a vprintf function. For example: 1292d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1293d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // void 1294d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 1295d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_list ap; 1296d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_start(ap, fmt); 1297d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 1298d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // ... 1299d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1300d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 1301d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // FIXME: We don't have full attribute support yet, so just check to see 1302d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // if the argument is a DeclRefExpr that references a parameter. We'll 1303d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // add proper support for checking the attribute later. 1304d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (HasVAListArg) 1305d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (isa<ParmVarDecl>(VD)) 1306d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson return true; 1307082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 13081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1309082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1310082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 1311d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 13128f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson case Stmt::CallExprClass: { 13138f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const CallExpr *CE = cast<CallExpr>(E); 13141eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump if (const ImplicitCastExpr *ICE 13158f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson = dyn_cast<ImplicitCastExpr>(CE->getCallee())) { 13168f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) { 13178f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) { 131840b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) { 13198f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson unsigned ArgIndex = FA->getFormatIdx(); 13208f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const Expr *Arg = CE->getArg(ArgIndex - 1); 13211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 13221eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg, 1323826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf); 13248f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 13258f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 13268f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 13278f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 13281eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 13298f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson return false; 13308f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 1331082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::ObjCStringLiteralClass: 1332082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::StringLiteralClass: { 1333082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const StringLiteral *StrE = NULL; 13341eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1335082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 1336d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek StrE = ObjCFExpr->getString(); 1337d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek else 1338082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek StrE = cast<StringLiteral>(E); 13391eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1340d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek if (StrE) { 1341826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatString(StrE, E, TheCall, HasVAListArg, format_idx, 1342826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek firstDataArg, isPrintf); 1343d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return true; 1344d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 13451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1346d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return false; 1347d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 13481eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1349082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek default: 1350082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1351d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1352d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1353d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1354e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid 13551eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull, 1356909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr * const *ExprArgs, 1357909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky SourceLocation CallSiteLoc) { 1358cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt for (NonNullAttr::args_iterator i = NonNull->args_begin(), 1359cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt e = NonNull->args_end(); 1360e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian i != e; ++i) { 1361909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr *ArgExpr = ExprArgs[*i]; 13624e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (ArgExpr->isNullPointerConstant(Context, 1363ce94049b69f75b44c18584fe79cd238978b6b0d5Douglas Gregor Expr::NPC_ValueDependentIsNotNull)) 1364909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange(); 1365e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian } 1366e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian} 1367d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 136820cdbeb8f36576f469db195b4140c293c7281718Peter Collingbournestatic void DiagnoseCalleeStaticArrayParam(Sema &S, ParmVarDecl *PVD) { 136920cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne TypeLoc TL = PVD->getTypeSourceInfo()->getTypeLoc(); 137020cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne if (ArrayTypeLoc *ATL = dyn_cast<ArrayTypeLoc>(&TL)) 137120cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne S.Diag(PVD->getLocation(), diag::note_callee_static_array) 137220cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne << ATL->getLocalSourceRange(); 137320cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne} 137420cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne 137520cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne/// CheckStaticArrayArguments - Check that each argument corresponding to a 137620cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne/// static array parameter is non-null, and that if it is formed by 137720cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne/// array-to-pointer decay, the underlying array is sufficiently large. 137820cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne/// 137920cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne/// C99 6.7.5.3p7: If the keyword static also appears within the [ and ] of the 138020cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne/// array type derivation, then for each call to the function, the value of the 138120cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne/// corresponding actual argument shall provide access to the first element of 138220cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne/// an array with at least as many elements as specified by the size expression. 138320cdbeb8f36576f469db195b4140c293c7281718Peter Collingbournevoid 138420cdbeb8f36576f469db195b4140c293c7281718Peter CollingbourneSema::CheckStaticArrayArguments(const FunctionDecl *FDecl, 138520cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne const Expr * const *ExprArgs, 138620cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne SourceLocation CallSiteLoc) { 138720cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne // Static array parameters are not supported in C++. 138820cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne if (getLangOptions().CPlusPlus) 138920cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne return; 139020cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne 139120cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne for (FunctionDecl::param_const_iterator i = FDecl->param_begin(), 139220cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne e = FDecl->param_end(); i != e; ++i, ++ExprArgs) { 139320cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne const Expr *ArgExpr = *ExprArgs; 139420cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne QualType OrigTy = (*i)->getOriginalType(); 139520cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne 139620cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne const ArrayType *AT = Context.getAsArrayType(OrigTy); 139720cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne if (!AT || AT->getSizeModifier() != ArrayType::Static) 139820cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne continue; 139920cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne 140020cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne if (ArgExpr->isNullPointerConstant(Context, 140120cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne Expr::NPC_NeverValueDependent)) { 140220cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange(); 140320cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne DiagnoseCalleeStaticArrayParam(*this, *i); 140420cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne continue; 140520cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne } 140620cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne 140720cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne const ConstantArrayType *CAT = dyn_cast<ConstantArrayType>(AT); 140820cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne if (!CAT) 140920cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne continue; 141020cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne 141120cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne const ConstantArrayType *ArgCAT = 141220cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne Context.getAsConstantArrayType(ArgExpr->IgnoreParenImpCasts()->getType()); 141320cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne if (!ArgCAT) 141420cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne continue; 141520cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne 141620cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne if (ArgCAT->getSize().ult(CAT->getSize())) { 141720cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne Diag(CallSiteLoc, diag::warn_static_array_too_small) 141820cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne << ArgExpr->getSourceRange() 141920cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne << (unsigned) ArgCAT->getSize().getZExtValue() 142020cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne << (unsigned) CAT->getSize().getZExtValue(); 142120cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne DiagnoseCalleeStaticArrayParam(*this, *i); 142220cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne } 142320cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne } 142420cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne} 142520cdbeb8f36576f469db195b4140c293c7281718Peter Collingbourne 1426826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar 1427826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings. 142859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnervoid 1429826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSema::CheckPrintfScanfArguments(const CallExpr *TheCall, bool HasVAListArg, 1430826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1431826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 1432826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1433082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *Fn = TheCall->getCallee(); 1434925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner 14354a2614e94672c47395abcde60518776fbebec589Sebastian Redl // The way the format attribute works in GCC, the implicit this argument 14364a2614e94672c47395abcde60518776fbebec589Sebastian Redl // of member functions is counted. However, it doesn't appear in our own 14374a2614e94672c47395abcde60518776fbebec589Sebastian Redl // lists, so decrement format_idx in that case. 14384a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 14399263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth const CXXMethodDecl *method_decl = 14409263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth dyn_cast<CXXMethodDecl>(TheCall->getCalleeDecl()); 14419263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if (method_decl && method_decl->isInstance()) { 14429263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth // Catch a format attribute mistakenly referring to the object argument. 14439263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if (format_idx == 0) 14449263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth return; 14459263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth --format_idx; 14469263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if(firstDataArg != 0) 14479263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth --firstDataArg; 14489263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth } 14494a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 14504a2614e94672c47395abcde60518776fbebec589Sebastian Redl 1451826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // CHECK: printf/scanf-like function is called with no format string. 1452925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (format_idx >= TheCall->getNumArgs()) { 1453826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Diag(TheCall->getRParenLoc(), diag::warn_missing_format_string) 1454dcd5ef12488e4c7ea844327835896ca86b609a97Chris Lattner << Fn->getSourceRange(); 145571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek return; 145671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek } 14571eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1458082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts(); 14591eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 146059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner // CHECK: format string is not a string literal. 14611eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // 146271895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // Dynamically generated format strings are difficult to 146371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // automatically vet at compile time. Requiring that format strings 146471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // are string literals: (1) permits the checking of format strings by 146571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // the compiler and thereby (2) can practically remove the source of 146671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // many format string exploits. 14677ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek 14681eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // Format string can be either ObjC string (e.g. @"%d") or 14697ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // C string (e.g. "%d") 14701eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // ObjC string uses the same format specifiers as C string, so we can use 14717ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // the same format string checking logic for both ObjC and C strings. 14721cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx, 1473826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek firstDataArg, isPrintf)) 14741cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner return; // Literal format string found, check done! 14751cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner 1476655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // If there are no arguments specified, warn with -Wformat-security, otherwise 1477655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // warn only with -Wformat-nonliteral. 1478655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner if (TheCall->getNumArgs() == format_idx+1) 14791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1480826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral_noargs) 1481655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1482655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner else 14831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1484826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral) 1485655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1486d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1487d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1488e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace { 1489826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler { 1490826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1491e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Sema &S; 1492e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const StringLiteral *FExpr; 1493e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const Expr *OrigFormatExpr; 14946ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const unsigned FirstDataArg; 1495e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const unsigned NumDataArgs; 1496e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const bool IsObjCLiteral; 1497e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *Beg; // Start of format string. 14980d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const bool HasVAListArg; 14990d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const CallExpr *TheCall; 15000d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek unsigned FormatIdx; 15017f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek llvm::BitVector CoveredArgs; 1502efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool usesPositionalArgs; 1503efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool atFirstArg; 15044e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic: 1505826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 15066ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1507e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 15080d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const char *beg, bool hasVAListArg, 15090d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1510e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 15116ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek FirstDataArg(firstDataArg), 15127f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek NumDataArgs(numDataArgs), 15130d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek IsObjCLiteral(isObjCLiteral), Beg(beg), 15140d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek HasVAListArg(hasVAListArg), 1515efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek TheCall(theCall), FormatIdx(formatIdx), 1516efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek usesPositionalArgs(false), atFirstArg(true) { 15177f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.resize(numDataArgs); 15187f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.reset(); 15197f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 15204e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 152107d161f38e708a91486bf1c031d525faebbb249dTed Kremenek void DoneProcessing(); 15224e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1523826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIncompleteSpecifier(const char *startSpecifier, 1524826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1525826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1526efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleInvalidPosition(const char *startSpecifier, 1527efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned specifierLen, 1528826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p); 1529efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1530efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 1531efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1532e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek void HandleNullChar(const char *nullCharacter); 15334e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1534826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1535c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 1536c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1537c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1538c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, unsigned csLen); 1539c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1540f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek SourceRange getFormatStringRange(); 1541826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CharSourceRange getSpecifierRange(const char *startSpecifier, 1542826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1543e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek SourceLocation getLocationOfByte(const char *x); 15444e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 15450d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const Expr *getDataArg(unsigned i) const; 1546666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1547666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 1548666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1549666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, 1550666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek unsigned argIndex); 1551e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}; 1552e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1553e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1554826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() { 1555e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return OrigFormatExpr->getSourceRange(); 1556e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1557e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1558826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler:: 1559826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 156045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation Start = getLocationOfByte(startSpecifier); 156145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 156245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 156345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care // Advance the end SourceLocation by one due to half-open ranges. 1564a64ccefdf0ea4e03ec88805d71b0af74950c7472Argyrios Kyrtzidis End = End.getLocWithOffset(1); 156545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 156645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care return CharSourceRange::getCharRange(Start, End); 1567f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek} 1568f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek 1569826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 15704e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 1571e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1572e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1573826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 1574826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen){ 1575808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek SourceLocation Loc = getLocationOfByte(startSpecifier); 1576808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek S.Diag(Loc, diag::warn_printf_incomplete_specifier) 1577826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1578808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek} 1579808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek 1580efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid 1581826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 1582826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p) { 1583efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek SourceLocation Loc = getLocationOfByte(startPos); 1584826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(Loc, diag::warn_format_invalid_positional_specifier) 1585826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << (unsigned) p << getSpecifierRange(startPos, posLen); 1586efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1587efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1588826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos, 1589efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned posLen) { 1590efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek SourceLocation Loc = getLocationOfByte(startPos); 1591826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(Loc, diag::warn_format_zero_positional_specifier) 1592826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startPos, posLen); 1593efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1594efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1595826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 15960c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek if (!IsObjCLiteral) { 15970c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek // The presence of a null character is likely an error. 15980c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek S.Diag(getLocationOfByte(nullCharacter), 15990c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek diag::warn_printf_format_string_contains_null_char) 16000c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek << getFormatStringRange(); 16010c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek } 1602826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1603826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1604826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const { 1605826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return TheCall->getArg(FirstDataArg + i); 1606826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 16074e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1608826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() { 1609826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Does the number of data arguments exceed the number of 1610826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // format conversions in the format string? 1611826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!HasVAListArg) { 1612826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Find any arguments that weren't covered. 1613826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.flip(); 1614826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek signed notCoveredArg = CoveredArgs.find_first(); 1615826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (notCoveredArg >= 0) { 1616826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek assert((unsigned)notCoveredArg < NumDataArgs); 1617826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(), 1618826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_printf_data_arg_not_used) 1619826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getFormatStringRange(); 1620826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1621826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1622826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1623826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1624c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool 1625c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 1626c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek SourceLocation Loc, 1627c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1628c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1629c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, 1630c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned csLen) { 1631c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1632c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool keepGoing = true; 1633c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek if (argIndex < NumDataArgs) { 1634c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // Consider the argument coverered, even though the specifier doesn't 1635c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // make sense. 1636c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CoveredArgs.set(argIndex); 1637c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1638c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek else { 1639c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // If argIndex exceeds the number of data arguments we 1640c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // don't issue a warning because that is just a cascade of warnings (and 1641c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // they may have intended '%%' anyway). We don't want to continue processing 1642c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // the format string after this point, however, as we will like just get 1643c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // gibberish when trying to match arguments. 1644c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek keepGoing = false; 1645c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1646c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1647c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek S.Diag(Loc, diag::warn_format_invalid_conversion) 16485f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner << StringRef(csStart, csLen) 1649c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek << getSpecifierRange(startSpec, specifierLen); 1650c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1651c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return keepGoing; 1652c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1653c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1654666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool 1655666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs( 1656666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::FormatSpecifier &FS, 1657666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1658666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 1659666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1660666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (argIndex >= NumDataArgs) { 1661666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (FS.usesPositionalArg()) { 1662666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1663666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek diag::warn_printf_positional_arg_exceeds_data_args) 1664666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << (argIndex+1) << NumDataArgs 1665666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1666666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1667666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek else { 1668666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1669666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek diag::warn_printf_insufficient_data_args) 1670666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1671666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1672666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1673666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return false; 1674666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1675666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return true; 1676666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek} 1677666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1678826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===// 1679826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1680826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 1681826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler { 1682826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 1683826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 1684826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1685826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 1686826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 1687826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1688826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1689826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 1690826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek theCall, formatIdx) {} 1691826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1692826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1693826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleInvalidPrintfConversionSpecifier( 1694826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1695826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1696826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1697826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1698826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 1699826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1700826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1701826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1702826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 1703826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1704826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 1705826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalAmount &Amt, 1706826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned type, 1707826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1708826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1709826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1710826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1711826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 1712826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &ignoredFlag, 1713826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1714826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1715826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 1716826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1717826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1718826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 1719826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1720826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1721826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 17226ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 1723c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 1724826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1725c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1726c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 1727c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 1728c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 172926ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek} 173026ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek 1731826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount( 1732826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_format_string::OptionalAmount &Amt, 1733826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned k, const char *startSpecifier, 1734826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 17350d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 17360d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (Amt.hasDataArgument()) { 17370d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (!HasVAListArg) { 17387f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = Amt.getArgIndex(); 17397f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (argIndex >= NumDataArgs) { 1740efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1741efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek diag::warn_printf_asterisk_missing_arg) 1742826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << k << getSpecifierRange(startSpecifier, specifierLen); 17430d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 17440d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 17450d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 17460d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 17474e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 17480d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Type check the data argument. It should be an 'int'. 174931f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // Although not in conformance with C99, we also allow the argument to be 175031f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // an 'unsigned int' as that is a reasonably safe case. GCC also 175131f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // doesn't emit a warning for that case. 17527f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.set(argIndex); 17537f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek const Expr *Arg = getDataArg(argIndex); 17540d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek QualType T = Arg->getType(); 17554e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 17564e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context); 17574e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek assert(ATR.isValid()); 17584e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 17594e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (!ATR.matchesType(S.Context, T)) { 1760efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1761efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek diag::warn_printf_asterisk_wrong_type) 1762efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek << k 17634e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek << ATR.getRepresentativeType(S.Context) << T 1764826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1765d635c5fcc45c952b75743dd2f4c86d6950e4954eTed Kremenek << Arg->getSourceRange(); 17660d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 17670d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 17680d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 17690d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 17700d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 17710d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 17720d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return true; 17730d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek} 17740d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1775e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount( 1776826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1777e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalAmount &Amt, 1778e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned type, 1779e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1780e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 17816ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 17826ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1783e4ee9663168dfb2b4122c768091e30217328c9faTom Care switch (Amt.getHowSpecified()) { 1784e4ee9663168dfb2b4122c768091e30217328c9faTom Care case analyze_printf::OptionalAmount::Constant: 1785e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(Amt.getStart()), 1786e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_optional_amount) 1787e4ee9663168dfb2b4122c768091e30217328c9faTom Care << type 1788e4ee9663168dfb2b4122c768091e30217328c9faTom Care << CS.toString() 1789826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1790826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 1791e4ee9663168dfb2b4122c768091e30217328c9faTom Care Amt.getConstantLength())); 1792e4ee9663168dfb2b4122c768091e30217328c9faTom Care break; 1793e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1794e4ee9663168dfb2b4122c768091e30217328c9faTom Care default: 1795e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(Amt.getStart()), 1796e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_optional_amount) 1797e4ee9663168dfb2b4122c768091e30217328c9faTom Care << type 1798e4ee9663168dfb2b4122c768091e30217328c9faTom Care << CS.toString() 1799826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1800e4ee9663168dfb2b4122c768091e30217328c9faTom Care break; 1801e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1802e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1803e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1804826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1805e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 1806e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1807e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 1808e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about pointless flag with a fixit removal. 18096ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 18106ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1811e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(flag.getPosition()), 1812e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_flag) 1813e4ee9663168dfb2b4122c768091e30217328c9faTom Care << flag.toString() << CS.toString() 1814826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1815826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(flag.getPosition(), 1)); 1816e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1817e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1818e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag( 1819826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1820e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &ignoredFlag, 1821e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 1822e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1823e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 1824e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about ignored flag with a fixit removal. 1825e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(ignoredFlag.getPosition()), 1826e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_ignored_flag) 1827e4ee9663168dfb2b4122c768091e30217328c9faTom Care << ignoredFlag.toString() << flag.toString() 1828826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1829826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange( 1830e4ee9663168dfb2b4122c768091e30217328c9faTom Care ignoredFlag.getPosition(), 1)); 1831e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1832e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1833e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool 1834826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 18355c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek &FS, 1836e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *startSpecifier, 1837e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned specifierLen) { 1838e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 18396ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek using namespace analyze_format_string; 1840efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek using namespace analyze_printf; 18416ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 1842e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1843baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 1844baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 1845baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 1846baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 1847baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1848baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 1849baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Cannot mix-and-match positional and non-positional arguments. 1850baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1851baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek diag::warn_format_mix_positional_nonpositional_args) 1852baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1853baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 1854baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1855efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek } 1856efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 18570d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // First check if the field width, precision, and conversion specifier 18580d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // have matching data arguments. 1859efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 1860efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 18610d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 18620d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 18634e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1864efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 1865efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 18660d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 18670d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 18680d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1869f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek if (!CS.consumesDataArgument()) { 1870f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // FIXME: Technically specifying a precision or field width here 1871f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // makes no sense. Worth issuing a warning at some point. 18720e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek return true; 1873f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek } 18744e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 18757f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Consume the argument. 18767f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = FS.getArgIndex(); 1877e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek if (argIndex < NumDataArgs) { 1878e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // The check to see if the argIndex is valid will come later. 1879e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // We set the bit here because we may exit early from this 1880e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // function if we encounter some other error. 1881e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek CoveredArgs.set(argIndex); 1882e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek } 18837f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek 18847f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Check for using an Objective-C specific conversion specifier 18857f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // in a non-ObjC literal. 18867f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (!IsObjCLiteral && CS.isObjCArg()) { 1887826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 1888826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek specifierLen); 18897f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 18904e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1891e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of field width 1892e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidFieldWidth()) { 189345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 1894e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1895e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1896e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1897e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of precision 1898e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPrecision()) { 1899e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 1900e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1901e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1902e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1903e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check each flag does not conflict with any other component. 190465197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek if (!FS.hasValidThousandsGroupingPrefix()) 190565197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen); 1906e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeadingZeros()) 1907e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 1908e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPlusPrefix()) 1909e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 191045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (!FS.hasValidSpacePrefix()) 191145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 1912e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidAlternativeForm()) 1913e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 1914e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeftJustified()) 1915e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 1916e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1917e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check that flags are not ignored by another flag 191845f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 191945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 192045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care startSpecifier, specifierLen); 1921e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 1922e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 1923e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1924e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1925e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check the length modifier is valid with the given conversion specifier. 1926e4ee9663168dfb2b4122c768091e30217328c9faTom Care const LengthModifier &LM = FS.getLengthModifier(); 1927e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLengthModifier()) 1928e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(LM.getStart()), 1929649aecf55670682efb2a04a85810eef4d038c527Ted Kremenek diag::warn_format_nonsensical_length) 1930e4ee9663168dfb2b4122c768091e30217328c9faTom Care << LM.toString() << CS.toString() 1931826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1932826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 1933e4ee9663168dfb2b4122c768091e30217328c9faTom Care LM.getLength())); 1934e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1935e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Are we using '%n'? 193635d353b47bce29200b910371dd9b8ba7f3058ab8Ted Kremenek if (CS.getKind() == ConversionSpecifier::nArg) { 1937e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Issue a warning about this being a possible security issue. 1938e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back) 1939826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1940e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek // Continue checking the other format specifiers. 1941e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek return true; 1942e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek } 19435c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek 1944da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek // The remaining checks depend on the data arguments. 1945da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek if (HasVAListArg) 1946da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return true; 19474e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1948666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 1949da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return false; 19504e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 195196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Now type check the data expression that matches the 195296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // format specifier. 195396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const Expr *Ex = getDataArg(argIndex); 195496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context); 195596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) { 195696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Check if we didn't match because of an implicit cast from a 'char' 195796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // or 'short' to an 'int'. This is done because printf is a varargs 195896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // function. 195996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex)) 19604d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ICE->getType() == S.Context.IntTy) { 19614d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek // All further checking is done on the subexpression. 19624d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek Ex = ICE->getSubExpr(); 19634d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ATR.matchesType(S.Context, Ex->getType())) 196496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer return true; 19654d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek } 196696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 196796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // We may be able to offer a FixItHint if it is a supported type. 196896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer PrintfSpecifier fixedFS = FS; 1969a7da2155167676a6a5d9fca4de947a9cab2a4908Hans Wennborg bool success = fixedFS.fixType(Ex->getType(), S.getLangOptions()); 197096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 197196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (success) { 197296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Get the fix string from the fixed format specifier 197396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::SmallString<128> buf; 197496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::raw_svector_ostream os(buf); 197596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer fixedFS.toString(os); 197696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 19779325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // FIXME: getRepresentativeType() perhaps should return a string 19789325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // instead of a QualType to better handle when the representative 19799325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // type is 'wint_t' (which is defined in the system headers). 198096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer S.Diag(getLocationOfByte(CS.getStart()), 198196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer diag::warn_printf_conversion_argument_type_mismatch) 198296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << ATR.getRepresentativeType(S.Context) << Ex->getType() 198396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << getSpecifierRange(startSpecifier, specifierLen) 198496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << Ex->getSourceRange() 198596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << FixItHint::CreateReplacement( 198696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer getSpecifierRange(startSpecifier, specifierLen), 198796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer os.str()); 198896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 198996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer else { 199096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer S.Diag(getLocationOfByte(CS.getStart()), 199196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer diag::warn_printf_conversion_argument_type_mismatch) 199296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << ATR.getRepresentativeType(S.Context) << Ex->getType() 199396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << getSpecifierRange(startSpecifier, specifierLen) 199496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << Ex->getSourceRange(); 199596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 199696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 199796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 1998e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return true; 1999e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 2000e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2001826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===// 2002826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2003826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 2004826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler { 2005826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 2006826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 2007826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 2008826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 2009826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 2010826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 2011826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 2012826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 2013826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek theCall, formatIdx) {} 2014826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2015826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 2016826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2017826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 2018c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2019c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidScanfConversionSpecifier( 2020c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2021c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 2022c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen); 2023b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 2024b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek void HandleIncompleteScanList(const char *start, const char *end); 2025826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 2026826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 2027826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2028b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start, 2029b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek const char *end) { 2030b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek S.Diag(getLocationOfByte(end), diag::warn_scanf_scanlist_incomplete) 2031b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek << getSpecifierRange(start, end - start); 2032b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek} 2033b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 2034c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 2035c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2036c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 2037c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen) { 2038c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 20396ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_scanf::ScanfConversionSpecifier &CS = 2040c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 2041c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2042c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 2043c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 2044c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 2045c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 2046c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 2047c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 2048826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier( 2049826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 2050826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 2051826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 2052826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2053826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_scanf; 2054826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_format_string; 2055826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 20566ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 2057826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2058baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Handle case where '%' and '*' don't consume an argument. These shouldn't 2059baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // be used to decide if we are using positional arguments consistently. 2060baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 2061baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 2062baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 2063baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 2064baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2065baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 2066baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Cannot mix-and-match positional and non-positional arguments. 2067baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 2068baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek diag::warn_format_mix_positional_nonpositional_args) 2069baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 2070baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 2071baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 2072826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2073826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2074826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Check if the field with is non-zero. 2075826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const OptionalAmount &Amt = FS.getFieldWidth(); 2076826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getHowSpecified() == OptionalAmount::Constant) { 2077826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getConstantAmount() == 0) { 2078826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 2079826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Amt.getConstantLength()); 2080826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 2081826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_scanf_nonzero_width) 2082826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << R << FixItHint::CreateRemoval(R); 20837f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 20847f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 2085826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2086826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!FS.consumesDataArgument()) { 2087826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Technically specifying a precision or field width here 2088826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // makes no sense. Worth issuing a warning at some point. 2089826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 2090826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2091826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2092826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Consume the argument. 2093826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned argIndex = FS.getArgIndex(); 2094826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (argIndex < NumDataArgs) { 2095826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The check to see if the argIndex is valid will come later. 2096826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // We set the bit here because we may exit early from this 2097826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // function if we encounter some other error. 2098826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.set(argIndex); 2099826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2100826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 21011e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek // Check the length modifier is valid with the given conversion specifier. 21021e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek const LengthModifier &LM = FS.getLengthModifier(); 21031e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek if (!FS.hasValidLengthModifier()) { 21041e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek S.Diag(getLocationOfByte(LM.getStart()), 21051e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek diag::warn_format_nonsensical_length) 21061e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << LM.toString() << CS.toString() 21071e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 21081e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 21091e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek LM.getLength())); 21101e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek } 21111e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek 2112826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The remaining checks depend on the data arguments. 2113826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (HasVAListArg) 2114826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 2115826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2116666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 2117826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return false; 2118826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2119826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Check that the argument type matches the format specifier. 2120826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2121826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 212207d161f38e708a91486bf1c031d525faebbb249dTed Kremenek} 2123e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 2124826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr, 21250e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const Expr *OrigFormatExpr, 21260e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const CallExpr *TheCall, bool HasVAListArg, 2127826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 2128826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 2129826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2130e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: is the format string a wide literal? 21315cee1195584fa8672253139c86e922daeda69b9eDouglas Gregor if (!FExpr->isAscii()) { 2132e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Diag(FExpr->getLocStart(), 2133826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_string_is_wide_literal) 2134e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek << OrigFormatExpr->getSourceRange(); 2135e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 2136e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 2137826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2138e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // Str - The format string. NOTE: this is NOT null-terminated! 21395f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef StrRef = FExpr->getString(); 21402f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer const char *Str = StrRef.data(); 21412f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer unsigned StrLen = StrRef.size(); 21424cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek const unsigned numDataArgs = TheCall->getNumArgs() - firstDataArg; 2143826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2144e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: empty format string? 21454cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek if (StrLen == 0 && numDataArgs > 0) { 2146826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Diag(FExpr->getLocStart(), diag::warn_empty_format_string) 2147e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek << OrigFormatExpr->getSourceRange(); 2148e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 2149e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 2150826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2151826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (isPrintf) { 2152826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 21534cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek numDataArgs, isa<ObjCStringLiteral>(OrigFormatExpr), 21544cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek Str, HasVAListArg, TheCall, format_idx); 2155826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2156826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen)) 2157826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 2158826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2159826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek else { 2160826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 21614cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek numDataArgs, isa<ObjCStringLiteral>(OrigFormatExpr), 21624cd5791f4aa6deb572979bb38c1deedbc155efe0Ted Kremenek Str, HasVAListArg, TheCall, format_idx); 2163826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 2164826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen)) 2165826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 2166826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 2167ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek} 2168ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek 21697ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth//===--- CHECK: Standard memory functions ---------------------------------===// 21707ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 21712a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// \brief Determine whether the given type is a dynamic class type (e.g., 21722a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor/// whether it has a vtable). 21732a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregorstatic bool isDynamicClassType(QualType T) { 21742a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Record = T->getAsCXXRecordDecl()) 21752a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (CXXRecordDecl *Definition = Record->getDefinition()) 21762a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor if (Definition->isDynamicClass()) 21772a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return true; 21782a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 21792a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor return false; 21802a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor} 21812a053a33707eba9e642adedb557b1a6aace103b5Douglas Gregor 2182a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument expression, 2183000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth/// otherwise returns NULL. 2184000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic const Expr *getSizeOfExprArg(const Expr* E) { 2185e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber if (const UnaryExprOrTypeTraitExpr *SizeOf = 2186000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 2187000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType()) 2188000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getArgumentExpr()->IgnoreParenImpCasts(); 2189e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 2190000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return 0; 2191000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth} 2192000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2193a72a12f3baed07f2663e48c5fc3b670c68dffe0cChandler Carruth/// \brief If E is a sizeof expression, returns its argument type. 2194000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruthstatic QualType getSizeOfArgType(const Expr* E) { 2195000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryExprOrTypeTraitExpr *SizeOf = 2196000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth dyn_cast<UnaryExprOrTypeTraitExpr>(E)) 2197000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOf->getKind() == clang::UETT_SizeOf) 2198000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return SizeOf->getTypeOfArgument(); 2199000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2200000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth return QualType(); 2201e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber} 2202e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 22037ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \brief Check for dangerous or invalid arguments to memset(). 22047ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 2205929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth/// This issues warnings on known problematic, dangerous or unspecified 2206cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp' 2207cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay/// function calls. 22087ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// 22097ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth/// \param Call The call expression to diagnose. 2210cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gayvoid Sema::CheckMemaccessArguments(const CallExpr *Call, 2211cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay CheckedMemoryFunction CMF, 2212cc2f30c4ed7770b6005bd55b529a55c1fcc250fcMatt Beaumont-Gay IdentifierInfo *FnName) { 22131d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek // It is possible to have a non-standard definition of memset. Validate 2214707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor // we have enough arguments, and if not, abort further checking. 2215cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber unsigned ExpectedNumArgs = (CMF == CMF_Strndup ? 2 : 3); 2216cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber if (Call->getNumArgs() < ExpectedNumArgs) 22171d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek return; 22181d59f7f8fb39fa44ddbb6e2abd321af863b1f55bTed Kremenek 2219cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber unsigned LastArg = (CMF == CMF_Memset || CMF == CMF_Strndup ? 1 : 2); 2220cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber unsigned LenArg = (CMF == CMF_Strndup ? 1 : 2); 2221cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts(); 2222000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2223000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We have special checking when the length is a sizeof expression. 2224000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth QualType SizeOfArgTy = getSizeOfArgType(LenExpr); 2225000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth const Expr *SizeOfArg = getSizeOfExprArg(LenExpr); 2226000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID SizeOfArgID; 2227000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 222806bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) { 222906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts(); 2230e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange(); 223106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 223206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType DestTy = Dest->getType(); 223306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) { 223406bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor QualType PointeeTy = DestPtrTy->getPointeeType(); 2235f85e193739c953358c865005855253af4f68a497John McCall 2236000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Never warn about void type pointers. This can be used to suppress 2237000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // false positives. 2238000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isVoidType()) 223906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 224006bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor 2241000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by 2242000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // actually comparing the expressions for equality. Because computing the 2243000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // expression IDs can be expensive, we only do this if the diagnostic is 2244000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // enabled. 2245000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArg && 2246000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Diags.getDiagnosticLevel(diag::warn_sizeof_pointer_expr_memaccess, 2247000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->getExprLoc())) { 2248000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // We only compute IDs for expressions if the warning is enabled, and 2249000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // cache the sizeof arg's ID. 2250000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgID == llvm::FoldingSetNodeID()) 2251000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth SizeOfArg->Profile(SizeOfArgID, Context, true); 2252000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth llvm::FoldingSetNodeID DestID; 2253000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Dest->Profile(DestID, Context, true); 2254000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (DestID == SizeOfArgID) { 2255cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // TODO: For strncpy() and friends, this could suggest sizeof(dst) 2256cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber // over sizeof(src) as well. 2257000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth unsigned ActionIdx = 0; // Default is to suggest dereferencing. 2258000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest)) 2259000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (UnaryOp->getOpcode() == UO_AddrOf) 2260000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 1; // If its an address-of operator, just remove it. 2261000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (Context.getTypeSize(PointeeTy) == Context.getCharWidth()) 2262000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth ActionIdx = 2; // If the pointee's size is sizeof(char), 2263000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // suggest an explicit length. 2264cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber unsigned DestSrcSelect = (CMF == CMF_Strndup ? 1 : ArgIdx); 2265000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(SizeOfArg->getExprLoc(), Dest, 2266000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_expr_memaccess) 2267cda57822327499aeb6fe606f9cf5903cffca3444Nico Weber << FnName << DestSrcSelect << ActionIdx 2268000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << Dest->getSourceRange() 2269000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << SizeOfArg->getSourceRange()); 2270000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 2271000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 2272000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 2273000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth 2274000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // Also check for cases where the sizeof argument is the exact same 2275000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // type as the memory argument, and where it points to a user-defined 2276000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth // record type. 2277000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (SizeOfArgTy != QualType()) { 2278000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth if (PointeeTy->isRecordType() && 2279000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth Context.typesAreCompatible(SizeOfArgTy, DestTy)) { 2280000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest, 2281000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth PDiag(diag::warn_sizeof_pointer_type_memaccess) 2282000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << FnName << SizeOfArgTy << ArgIdx 2283000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << PointeeTy << Dest->getSourceRange() 2284000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth << LenExpr->getSourceRange()); 2285000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth break; 2286000d428347f352979e0f6dffcf0a64e73af0a2b5Chandler Carruth } 2287e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber } 2288e4a1c64700304459ac436fe29cb498f2da3b6194Nico Weber 228906bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor // Always complain about dynamic classes. 2290f85e193739c953358c865005855253af4f68a497John McCall if (isDynamicClassType(PointeeTy)) 22915c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 22925c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 22935c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_dyn_class_memaccess) 22945c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << (CMF == CMF_Memcmp ? ArgIdx + 2 : ArgIdx) << FnName << PointeeTy 22955c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay // "overwritten" if we're warning about the destination for any call 22965c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay // but memcmp; otherwise a verb appropriate to the call. 22975c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << (ArgIdx == 0 && CMF != CMF_Memcmp ? 0 : (unsigned)CMF) 22985c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 2299707a23e8b87410332b55bb4534fa1c799edef38aDouglas Gregor else if (PointeeTy.hasNonTrivialObjCLifetime() && CMF != CMF_Memset) 23005c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay DiagRuntimeBehavior( 23015c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay Dest->getExprLoc(), Dest, 23025c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay PDiag(diag::warn_arc_object_memaccess) 23035c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << ArgIdx << FnName << PointeeTy 23045c5218e188b39b2e93b541156a69ef061e11aab8Matt Beaumont-Gay << Call->getCallee()->getSourceRange()); 2305f85e193739c953358c865005855253af4f68a497John McCall else 230606bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor continue; 2307f85e193739c953358c865005855253af4f68a497John McCall 2308f85e193739c953358c865005855253af4f68a497John McCall DiagRuntimeBehavior( 2309f85e193739c953358c865005855253af4f68a497John McCall Dest->getExprLoc(), Dest, 2310929f0135ab60166202f52e0dd19835c0490d792aChandler Carruth PDiag(diag::note_bad_memaccess_silence) 231106bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)")); 231206bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor break; 231306bc9eb9908e42696775b395b290827bde468c8bDouglas Gregor } 23147ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth } 23157ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth} 23167ccc95bceebb2d1c8fbe277c9e33bde7dc1ccbb1Chandler Carruth 2317bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// A little helper routine: ignore addition and subtraction of integer literals. 2318bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// This intentionally does not ignore all integer constant expressions because 2319bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// we don't want to remove sizeof(). 2320bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekstatic const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) { 2321bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = Ex->IgnoreParenCasts(); 2322bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2323bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek for (;;) { 2324bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex); 2325bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!BO || !BO->isAdditiveOp()) 2326bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 2327bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2328bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *RHS = BO->getRHS()->IgnoreParenCasts(); 2329bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *LHS = BO->getLHS()->IgnoreParenCasts(); 2330bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2331bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (isa<IntegerLiteral>(RHS)) 2332bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = LHS; 2333bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else if (isa<IntegerLiteral>(LHS)) 2334bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Ex = RHS; 2335bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else 2336bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek break; 2337bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2338bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2339bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return Ex; 2340bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 2341bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2342bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// Warn if the user has made the 'size' argument to strlcpy or strlcat 2343bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek// be the size of the source, instead of the destination. 2344bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenekvoid Sema::CheckStrlcpycatArguments(const CallExpr *Call, 2345bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek IdentifierInfo *FnName) { 2346bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2347bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Don't crash if the user has the wrong number of arguments 2348bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (Call->getNumArgs() != 3) 2349bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2350bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2351bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context); 2352bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context); 2353bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *CompareWithSrc = NULL; 2354bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2355bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, sizeof(x))' 2356bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const Expr *Ex = getSizeOfExprArg(SizeArg)) 2357bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = Ex; 2358bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek else { 2359bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Look for 'strlcpy(dst, x, strlen(x))' 2360bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) { 2361bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (SizeCall->isBuiltinCall(Context) == Builtin::BIstrlen 2362bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek && SizeCall->getNumArgs() == 1) 2363bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context); 2364bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2365bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 2366bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2367bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrc) 2368bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2369bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2370bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Determine if the argument to sizeof/strlen is equal to the source 2371bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // argument. In principle there's all kinds of things you could do 2372bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // here, for instance creating an == expression and evaluating it with 2373bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // EvaluateAsBooleanCondition, but this uses a more direct technique: 2374bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg); 2375bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!SrcArgDRE) 2376bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2377bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2378bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc); 2379bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek if (!CompareWithSrcDRE || 2380bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl()) 2381bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek return; 2382bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2383bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *OriginalSizeArg = Call->getArg(2); 2384bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size) 2385bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek << OriginalSizeArg->getSourceRange() << FnName; 2386bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 2387bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // Output a FIXIT hint if the destination is an array (rather than a 2388bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointer to an array). This could be enhanced to handle some 2389bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // pointers if we know the actual size, like if DstArg is 'array+2' 2390bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek // we could say 'sizeof(array)-2'. 2391bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts(); 23928f7462237ff542a4556775f98709ed300aa1731aTed Kremenek QualType DstArgTy = DstArg->getType(); 2393bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 23948f7462237ff542a4556775f98709ed300aa1731aTed Kremenek // Only handle constant-sized or VLAs, but not flexible members. 23958f7462237ff542a4556775f98709ed300aa1731aTed Kremenek if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(DstArgTy)) { 23968f7462237ff542a4556775f98709ed300aa1731aTed Kremenek // Only issue the FIXIT for arrays of size > 1. 23978f7462237ff542a4556775f98709ed300aa1731aTed Kremenek if (CAT->getSize().getSExtValue() <= 1) 23988f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 23998f7462237ff542a4556775f98709ed300aa1731aTed Kremenek } else if (!DstArgTy->isVariableArrayType()) { 24008f7462237ff542a4556775f98709ed300aa1731aTed Kremenek return; 2401bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek } 24028f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 24038f7462237ff542a4556775f98709ed300aa1731aTed Kremenek llvm::SmallString<128> sizeString; 24048f7462237ff542a4556775f98709ed300aa1731aTed Kremenek llvm::raw_svector_ostream OS(sizeString); 24058f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << "sizeof("; 24068987b2385d9ba63ada66e1344ace79b04d5cb5c3Douglas Gregor DstArg->printPretty(OS, Context, 0, getPrintingPolicy()); 24078f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS << ")"; 24088f7462237ff542a4556775f98709ed300aa1731aTed Kremenek 24098f7462237ff542a4556775f98709ed300aa1731aTed Kremenek Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size) 24108f7462237ff542a4556775f98709ed300aa1731aTed Kremenek << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(), 24118f7462237ff542a4556775f98709ed300aa1731aTed Kremenek OS.str()); 2412bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek} 2413bd5da9d1a711e90b3bc265b4798954085c0b48d9Ted Kremenek 241406de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===// 241506de276fff91264437fa75111ed76de43097e089Ted Kremenek 24165f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars); 24175f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars); 241806de276fff91264437fa75111ed76de43097e089Ted Kremenek 241906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address 242006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable. 242106de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid 242206de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 242306de276fff91264437fa75111ed76de43097e089Ted Kremenek SourceLocation ReturnLoc) { 24241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 242526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Expr *stackE = 0; 24265f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner SmallVector<DeclRefExpr *, 8> refVars; 24274e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 242826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Perform checking for returned stack addresses, local blocks, 242926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // label addresses or references to temporaries. 2430f85e193739c953358c865005855253af4f68a497John McCall if (lhsType->isPointerType() || 2431f85e193739c953358c865005855253af4f68a497John McCall (!getLangOptions().ObjCAutoRefCount && lhsType->isBlockPointerType())) { 243226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalAddr(RetValExp, refVars); 2433ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (lhsType->isReferenceType()) { 243426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalVal(RetValExp, refVars); 243526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 243626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 243726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (stackE == 0) 243826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return; // Nothing suspicious was found. 243926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 244026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceLocation diagLoc; 244126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange diagRange; 244226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (refVars.empty()) { 244326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = stackE->getLocStart(); 244426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = stackE->getSourceRange(); 244526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { 244626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // We followed through a reference variable. 'stackE' contains the 244726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // problematic expression but we will warn at the return statement pointing 244826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // at the reference variable. We will later display the "trail" of 244926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // reference variables using notes. 245026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = refVars[0]->getLocStart(); 245126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = refVars[0]->getSourceRange(); 245226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 245326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 245426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var. 245526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref 245626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_stack_addr) 245726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << DR->getDecl()->getDeclName() << diagRange; 245826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<BlockExpr>(stackE)) { // local block. 245926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::err_ret_local_block) << diagRange; 246026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 246126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 246226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { // local temporary. 246326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref 246426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_local_temp_addr) 246526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << diagRange; 246626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 246726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 246826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Display the "trail" of reference variables that we followed until we 246926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // found the problematic expression using notes. 247026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 247126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 247226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this var binds to another reference var, show the range of the next 247326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // var, otherwise the var binds to the problematic expression, in which case 247426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // show the range of the expression. 247526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange() 247626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : stackE->getSourceRange(); 247726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(VD->getLocation(), diag::note_ref_var_local_bind) 247826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << VD->getDeclName() << range; 247906de276fff91264437fa75111ed76de43097e089Ted Kremenek } 248006de276fff91264437fa75111ed76de43097e089Ted Kremenek} 248106de276fff91264437fa75111ed76de43097e089Ted Kremenek 248206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 248306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// check if the expression in a return statement evaluates to an address 248426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// to a location on the stack, a local block, an address of a label, or a 248526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// reference to local temporary. The recursion is used to traverse the 248606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// AST of the return expression, with recursion backtracking when we 248726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// encounter a subexpression that (1) clearly does not lead to one of the 248826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// above problematic expressions (2) is something we cannot determine leads to 248926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// a problematic expression based on such local checking. 249026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 249126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// Both EvalAddr and EvalVal follow through reference variables to evaluate 249226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// the expression that they point to. Such variables are added to the 249326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 'refVars' vector so that we know what the reference variable "trail" was. 249406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 2495e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// EvalAddr processes expressions that are pointers that are used as 2496e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// references (and not L-values). EvalVal handles all other values. 249726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// At the base case of the recursion is a check for the above problematic 249826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// expressions. 249906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 250006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// This implementation handles: 250106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 250206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer-to-pointer casts 250306de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * implicit conversions from array references to pointers 250406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of fields 250506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * arbitrary interplay between "&" and "*" operators 250606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer arithmetic from an address of a stack variable 250706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of an array element where the array is on the stack 25085f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars) { 250926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (E->isTypeDependent()) 251026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 251126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 251206de276fff91264437fa75111ed76de43097e089Ted Kremenek // We should only be called for evaluating pointer expressions. 25130f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall assert((E->getType()->isAnyPointerType() || 2514dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff E->getType()->isBlockPointerType() || 2515a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek E->getType()->isObjCQualifiedIdType()) && 2516fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner "EvalAddr only works on pointers"); 25171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2518f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 2519f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 252006de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 252106de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 252206de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 252306de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 252426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::DeclRefExprClass: { 252526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis DeclRefExpr *DR = cast<DeclRefExpr>(E); 252626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 252726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 252826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this is a reference variable, follow through to the expression that 252926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 253026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage() && 253126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis V->getType()->isReferenceType() && V->hasInit()) { 253226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 253326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 253426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(V->getInit(), refVars); 253526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 253626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 253726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 253826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 253906de276fff91264437fa75111ed76de43097e089Ted Kremenek 2540fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::UnaryOperatorClass: { 2541fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // The only unary operator that make sense to handle here 2542fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // is AddrOf. All others don't make sense as pointers. 2543fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner UnaryOperator *U = cast<UnaryOperator>(E); 25441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 25452de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_AddrOf) 254626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(U->getSubExpr(), refVars); 2547fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 2548fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 2549fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 25501eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2551fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::BinaryOperatorClass: { 2552fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle pointer arithmetic. All other binary operators are not valid 2553fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // in this context. 2554fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner BinaryOperator *B = cast<BinaryOperator>(E); 25552de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = B->getOpcode(); 25561eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 25572de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op != BO_Add && op != BO_Sub) 2558fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 25591eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2560fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner Expr *Base = B->getLHS(); 25613907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 2562fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Determine which argument is the real pointer base. It could be 2563fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // the RHS argument instead of the LHS. 2564fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner if (!Base->getType()->isPointerType()) Base = B->getRHS(); 25651eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2566fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner assert (Base->getType()->isPointerType()); 256726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(Base, refVars); 2568fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 256961f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff 2570fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // For conditional operators we need to see if either the LHS or RHS are 2571fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // valid DeclRefExpr*s. If one of them is valid, we return it. 2572fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ConditionalOperatorClass: { 2573fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner ConditionalOperator *C = cast<ConditionalOperator>(E); 25741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2575fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle the GNU extension for missing LHS. 25769ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (Expr *lhsExpr = C->getLHS()) { 25779ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 25789ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (!lhsExpr->getType()->isVoidType()) 257926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr* LHS = EvalAddr(lhsExpr, refVars)) 25809ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return LHS; 25819ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor } 25829ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor 25839ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 25849ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (C->getRHS()->getType()->isVoidType()) 25859ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return NULL; 258606de276fff91264437fa75111ed76de43097e089Ted Kremenek 258726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(C->getRHS(), refVars); 2588fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 258926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 259026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::BlockExprClass: 2591469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures()) 259226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // local block. 259326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 259426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 259526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::AddrLabelExprClass: 259626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // address of label. 25971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 259854b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // For casts, we need to handle conversions from arrays to 259954b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // pointer values, and pointer-to-pointer conversions. 260049badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::ImplicitCastExprClass: 26016eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor case Stmt::CStyleCastExprClass: 2602f85e193739c953358c865005855253af4f68a497John McCall case Stmt::CXXFunctionalCastExprClass: 2603f85e193739c953358c865005855253af4f68a497John McCall case Stmt::ObjCBridgedCastExprClass: { 26040835a3cdeefe714b4959d31127ea155e56393125Argyrios Kyrtzidis Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 260554b5274f2c190331438375ad114dad12ae098b57Ted Kremenek QualType T = SubExpr->getType(); 26061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2607dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (SubExpr->getType()->isPointerType() || 2608dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isBlockPointerType() || 2609dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isObjCQualifiedIdType()) 261026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(SubExpr, refVars); 261154b5274f2c190331438375ad114dad12ae098b57Ted Kremenek else if (T->isArrayType()) 261226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(SubExpr, refVars); 2613fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 261454b5274f2c190331438375ad114dad12ae098b57Ted Kremenek return 0; 2615fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 26161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2617fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // C++ casts. For dynamic casts, static casts, and const casts, we 2618fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // are always converting from a pointer-to-pointer, so we just blow 261949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // through the cast. In the case the dynamic cast doesn't fail (and 262049badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // return NULL), we take the conservative route and report cases 2621fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // where we return the address of a stack variable. For Reinterpre 262249badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // FIXME: The comment about is wrong; we're not always converting 262349badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // from pointer to pointer. I'm guessing that this code should also 26241eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // handle references to objects. 26251eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXStaticCastExprClass: 26261eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXDynamicCastExprClass: 262749badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXConstCastExprClass: 262849badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXReinterpretCastExprClass: { 262949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr(); 2630dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (S->getType()->isPointerType() || S->getType()->isBlockPointerType()) 263126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(S, refVars); 263206de276fff91264437fa75111ed76de43097e089Ted Kremenek else 263306de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 2634fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 26351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 263603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 263703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalAddr( 263803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 263903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor refVars)) 264003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 264103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 264203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 264303e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 2644fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Everything else: we simply don't reason about them. 2645fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner default: 2646fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 264706de276fff91264437fa75111ed76de43097e089Ted Kremenek } 264806de276fff91264437fa75111ed76de43097e089Ted Kremenek} 26491eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 265006de276fff91264437fa75111ed76de43097e089Ted Kremenek 265106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalVal - This function is complements EvalAddr in the mutual recursion. 265206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// See the comments for EvalAddr for more details. 26535f9e272e632e951b1efe824cd16acb4d96077930Chris Lattnerstatic Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars) { 265468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo { 2655e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // We should only be called for evaluating non-pointer expressions, or 2656e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // expressions with a pointer type that are not used as references but instead 2657e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // are l-values (e.g., DeclRefExpr with a pointer type). 26581eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 265906de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 266006de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 266106de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 2662f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne 2663f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne E = E->IgnoreParens(); 266406de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 266568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ImplicitCastExprClass: { 266668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 26675baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall if (IE->getValueKind() == VK_LValue) { 266868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = IE->getSubExpr(); 266968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 267068957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 267168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek return NULL; 267268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 267368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek 2674a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor case Stmt::DeclRefExprClass: { 267526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // When we hit a DeclRefExpr we are looking at code that refers to a 267626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // variable's name. If it's not a reference variable we check if it has 267726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // local storage within the function, and if so, return the expression. 267806de276fff91264437fa75111ed76de43097e089Ted Kremenek DeclRefExpr *DR = cast<DeclRefExpr>(E); 26791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 268006de276fff91264437fa75111ed76de43097e089Ted Kremenek if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 268126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage()) { 268226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!V->getType()->isReferenceType()) 268326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return DR; 268426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 268526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Reference variable, follow through to the expression that 268626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 268726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasInit()) { 268826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 268926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 269026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(V->getInit(), refVars); 269126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 269226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 26931eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 269406de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 269506de276fff91264437fa75111ed76de43097e089Ted Kremenek } 26961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 269706de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::UnaryOperatorClass: { 269806de276fff91264437fa75111ed76de43097e089Ted Kremenek // The only unary operator that make sense to handle here 269906de276fff91264437fa75111ed76de43097e089Ted Kremenek // is Deref. All others don't resolve to a "name." This includes 270006de276fff91264437fa75111ed76de43097e089Ted Kremenek // handling all sorts of rvalues passed to a unary operator. 270106de276fff91264437fa75111ed76de43097e089Ted Kremenek UnaryOperator *U = cast<UnaryOperator>(E); 27021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 27032de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_Deref) 270426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(U->getSubExpr(), refVars); 270506de276fff91264437fa75111ed76de43097e089Ted Kremenek 270606de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 270706de276fff91264437fa75111ed76de43097e089Ted Kremenek } 27081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 270906de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ArraySubscriptExprClass: { 271006de276fff91264437fa75111ed76de43097e089Ted Kremenek // Array subscripts are potential references to data on the stack. We 271106de276fff91264437fa75111ed76de43097e089Ted Kremenek // retrieve the DeclRefExpr* for the array variable if it indeed 271206de276fff91264437fa75111ed76de43097e089Ted Kremenek // has local storage. 271326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars); 271406de276fff91264437fa75111ed76de43097e089Ted Kremenek } 27151eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 271606de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ConditionalOperatorClass: { 271706de276fff91264437fa75111ed76de43097e089Ted Kremenek // For conditional operators we need to see if either the LHS or RHS are 271826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // non-NULL Expr's. If one is non-NULL, we return it. 271906de276fff91264437fa75111ed76de43097e089Ted Kremenek ConditionalOperator *C = cast<ConditionalOperator>(E); 272006de276fff91264437fa75111ed76de43097e089Ted Kremenek 27213907323dd6665c0c4e383435cb145233f4533406Anders Carlsson // Handle the GNU extension for missing LHS. 27223907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (Expr *lhsExpr = C->getLHS()) 272326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr *LHS = EvalVal(lhsExpr, refVars)) 27243907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return LHS; 27253907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 272626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(C->getRHS(), refVars); 272706de276fff91264437fa75111ed76de43097e089Ted Kremenek } 27281eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 272906de276fff91264437fa75111ed76de43097e089Ted Kremenek // Accesses to members are potential references to data on the stack. 273083f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor case Stmt::MemberExprClass: { 273106de276fff91264437fa75111ed76de43097e089Ted Kremenek MemberExpr *M = cast<MemberExpr>(E); 27321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 273306de276fff91264437fa75111ed76de43097e089Ted Kremenek // Check for indirect access. We only want direct field accesses. 2734a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->isArrow()) 2735a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return NULL; 2736a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 2737a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // Check whether the member type is itself a reference, in which case 2738a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // we're not going to refer to the member, but to what the member refers to. 2739a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->getMemberDecl()->getType()->isReferenceType()) 274006de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 2741a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 274226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(M->getBase(), refVars); 274306de276fff91264437fa75111ed76de43097e089Ted Kremenek } 27441eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 274503e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor case Stmt::MaterializeTemporaryExprClass: 274603e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor if (Expr *Result = EvalVal( 274703e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(), 274803e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor refVars)) 274903e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return Result; 275003e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 275103e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor return E; 275203e80030515c800d1ab44125b9052dfffd1bd04cDouglas Gregor 275306de276fff91264437fa75111ed76de43097e089Ted Kremenek default: 275426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Check that we don't return or take the address of a reference to a 275526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // temporary. This is only useful in C++. 275626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!E->isTypeDependent() && E->isRValue()) 275726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; 275826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 275926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Everything else: we simply don't reason about them. 276006de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 276106de276fff91264437fa75111ed76de43097e089Ted Kremenek } 276268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true); 276306de276fff91264437fa75111ed76de43097e089Ted Kremenek} 2764588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2765588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 2766588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2767588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==. 2768588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely 2769588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended. 2770dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieuvoid Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) { 2771588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek bool EmitWarning = true; 27721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2773dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts(); 2774dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr* RightExprSansParen = RHS->IgnoreParenImpCasts(); 2775588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2776588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Special case: check for x == x (which is OK). 2777588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Do not emit warnings for such cases. 2778588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 2779588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 2780588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DRL->getDecl() == DRR->getDecl()) 2781588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 27821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 27831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 27841b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // Special case: check for comparisons against literals that can be exactly 27851b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // represented by APFloat. In such cases, do not emit a warning. This 27861b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // is a heuristic: often comparison against such literals are used to 27871b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // detect if a value in a variable has not changed. This clearly can 27881b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // lead to false negatives. 27891b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (EmitWarning) { 27901b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 27911b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLL->isExact()) 27921b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 2793ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else 27941b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){ 27951b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLR->isExact()) 27961b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 27971b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 27981b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 27991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2800588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Check for comparisons with builtin types. 28010eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 2802588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 28033c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor if (CL->isBuiltinCall(Context)) 2804588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 28051eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 28060eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 2807588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 28083c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor if (CR->isBuiltinCall(Context)) 2809588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 28101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2811588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Emit the diagnostic. 2812588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (EmitWarning) 2813dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Diag(Loc, diag::warn_floatingpoint_eq) 2814dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu << LHS->getSourceRange() << RHS->getSourceRange(); 2815588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek} 2816ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2817f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 2818f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 2819ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2820f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace { 2821ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2822f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued 2823f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression. 2824f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange { 2825f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// The number of bits active in the int. 2826f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned Width; 2827ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2828f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// True if the int is known not to have negative values. 2829f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool NonNegative; 283051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2831f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange(unsigned Width, bool NonNegative) 2832f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : Width(Width), NonNegative(NonNegative) 2833f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall {} 283451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 28351844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of the bool type. 2836f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall static IntRange forBoolType() { 2837f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(1, true); 2838f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 283951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 28401844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of the given integral type. 28411844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfType(ASTContext &C, QualType T) { 28421844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return forValueOfCanonicalType(C, 28431844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T->getCanonicalTypeInternal().getTypePtr()); 284451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 284551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 28461844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of a canonical integral type. 28471844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 2848f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(T->isCanonicalUnqualified()); 284951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2850f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 2851f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = VT->getElementType().getTypePtr(); 2852f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 2853f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = CT->getElementType().getTypePtr(); 2854323ed74658bc8375278eabf074b4777458376540John McCall 2855091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // For enum types, use the known bit width of the enumerators. 2856323ed74658bc8375278eabf074b4777458376540John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) { 2857323ed74658bc8375278eabf074b4777458376540John McCall EnumDecl *Enum = ET->getDecl(); 28585e1cdac63c3d9c9b32fa41fa0b2d242a58a20d49John McCall if (!Enum->isCompleteDefinition()) 2859091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return IntRange(C.getIntWidth(QualType(T, 0)), false); 2860091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2861323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumPositive = Enum->getNumPositiveBits(); 2862323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumNegative = Enum->getNumNegativeBits(); 2863323ed74658bc8375278eabf074b4777458376540John McCall 2864323ed74658bc8375278eabf074b4777458376540John McCall return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0); 2865323ed74658bc8375278eabf074b4777458376540John McCall } 286651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2867f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const BuiltinType *BT = cast<BuiltinType>(T); 2868f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(BT->isInteger()); 286951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2870f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 287151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 287251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 28731844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the "target" range of a canonical integral type, i.e. 28741844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// the range of values expressible in the type. 28751844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// 28761844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// This matches forValueOfCanonicalType except that enums have the 28771844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// full range of their type, not the range of their enumerators. 28781844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 28791844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(T->isCanonicalUnqualified()); 28801844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 28811844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 28821844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = VT->getElementType().getTypePtr(); 28831844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 28841844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = CT->getElementType().getTypePtr(); 28851844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) 288669ff26bd1e7a2faffec0c3b9740cfb0c6bb354c5Douglas Gregor T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr(); 28871844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 28881844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall const BuiltinType *BT = cast<BuiltinType>(T); 28891844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(BT->isInteger()); 28901844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 28911844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 28921844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall } 28931844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 28941844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the supremum of two ranges: i.e. their conservative merge. 2895c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange join(IntRange L, IntRange R) { 2896f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(std::max(L.Width, R.Width), 289760fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative && R.NonNegative); 289860fad45739b764886f707bd204eae9ecce6db1f2John McCall } 289960fad45739b764886f707bd204eae9ecce6db1f2John McCall 29001844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the infinum of two ranges: i.e. their aggressive merge. 2901c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange meet(IntRange L, IntRange R) { 290260fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange(std::min(L.Width, R.Width), 290360fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative || R.NonNegative); 290451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 2905f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}; 290651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2907f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) { 2908f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isSigned() && value.isNegative()) 2909f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getMinSignedBits(), false); 291051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2911f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.getBitWidth() > MaxWidth) 29129f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad value = value.trunc(MaxWidth); 291351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2914f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // isNonNegative() just checks the sign bit without considering 2915f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // signedness. 2916f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getActiveBits(), true); 291751313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 291851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 29190acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCallIntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 2920f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned MaxWidth) { 2921f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isInt()) 2922f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetValueRange(C, result.getInt(), MaxWidth); 292351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2924f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isVector()) { 29250acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 29260acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 29270acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 29280acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall R = IntRange::join(R, El); 29290acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall } 2930f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return R; 293151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 293251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2933f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isComplexInt()) { 2934f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 2935f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 2936f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(R, I); 2937f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2938f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2939f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // This can happen with lossless casts to intptr_t of "based" lvalues. 2940f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume it might use arbitrary bits. 29410acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // FIXME: The only reason we need to pass the type in here is to get 29420acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // the sign right on this one case. It would be nice if APValue 29430acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // preserved this. 2944f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(result.isLValue()); 29455e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType()); 294651313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 294751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2948f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the 2949f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take. 2950f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 2951f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated 2952f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 295351313c39c84407dd6a323be99a8c322bf8d052a9John McCall E = E->IgnoreParens(); 295451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2955f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Try a full evaluation first. 2956f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall Expr::EvalResult result; 2957f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (E->Evaluate(result, C)) 29580acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall return GetValueRange(C, result.Val, E->getType(), MaxWidth); 295951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2960f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // I think we only want to look through implicit casts here; if the 2961f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // user has an explicit widening cast, we should treat the value as 2962f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // being of the new, wider type. 2963f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 29642de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (CE->getCastKind() == CK_NoOp) 2965f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CE->getSubExpr(), MaxWidth); 296651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 29671844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType()); 296851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 29692de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 297060fad45739b764886f707bd204eae9ecce6db1f2John McCall 2971f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume that non-integer casts can span the full range of the type. 297260fad45739b764886f707bd204eae9ecce6db1f2John McCall if (!isIntegerCast) 2973f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 297451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2975f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange SubRange 2976f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall = GetExprRange(C, CE->getSubExpr(), 2977f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall std::min(MaxWidth, OutputTypeRange.Width)); 297851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2979f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Bail out if the subexpr's range is as wide as the cast type. 2980f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SubRange.Width >= OutputTypeRange.Width) 2981f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 298251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2983f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, we take the smaller width, and we're non-negative if 2984f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // either the output type or the subexpr is. 2985f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(SubRange.Width, 2986f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall SubRange.NonNegative || OutputTypeRange.NonNegative); 2987f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2988f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2989f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 2990f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // If we can fold the condition, just take that operand. 2991f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool CondResult; 2992f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 2993f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CondResult ? CO->getTrueExpr() 2994f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : CO->getFalseExpr(), 2995f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall MaxWidth); 2996f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2997f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, conservatively merge. 2998f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 2999f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 3000f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 300151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 300251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 300351313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 300451313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (BO->getOpcode()) { 300551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3006f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Boolean-valued operations are single-bit and positive. 30072de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LAnd: 30082de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LOr: 30092de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LT: 30102de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GT: 30112de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LE: 30122de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GE: 30132de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_EQ: 30142de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_NE: 3015f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 301651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3017862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // The type of the assignments is the type of the LHS, so the RHS 3018862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // is not necessarily the same type. 30192de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_MulAssign: 30202de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_DivAssign: 30212de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_RemAssign: 30222de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AddAssign: 30232de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_SubAssign: 3024862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_XorAssign: 3025862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_OrAssign: 3026862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 30271844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 3028c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall 3029862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // Simple assignments just pass through the RHS, which will have 3030862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // been coerced to the LHS type. 3031862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall case BO_Assign: 3032862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall // TODO: bitfields? 3033862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 3034862ff87c0d306af8dfdbe7ac59f181a5815546e5John McCall 303551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 30362de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemD: 30372de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemI: 30381844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 303951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 304060fad45739b764886f707bd204eae9ecce6db1f2John McCall // Bitwise-and uses the *infinum* of the two source ranges. 30412de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_And: 30422de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AndAssign: 304360fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 304460fad45739b764886f707bd204eae9ecce6db1f2John McCall GetExprRange(C, BO->getRHS(), MaxWidth)); 304560fad45739b764886f707bd204eae9ecce6db1f2John McCall 304651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Left shift gets black-listed based on a judgement call. 30472de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shl: 30483aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // ...except that we want to treat '1 << (blah)' as logically 30493aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // positive. It's an important idiom. 30503aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (IntegerLiteral *I 30513aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 30523aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (I->getValue() == 1) { 30531844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange R = IntRange::forValueOfType(C, E->getType()); 30543aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall return IntRange(R.Width, /*NonNegative*/ true); 30553aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 30563aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 30573aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // fallthrough 30583aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall 30592de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShlAssign: 30601844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 306151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 306260fad45739b764886f707bd204eae9ecce6db1f2John McCall // Right shift by a constant can narrow its left argument. 30632de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shr: 30642de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShrAssign: { 306560fad45739b764886f707bd204eae9ecce6db1f2John McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 306660fad45739b764886f707bd204eae9ecce6db1f2John McCall 306760fad45739b764886f707bd204eae9ecce6db1f2John McCall // If the shift amount is a positive constant, drop the width by 306860fad45739b764886f707bd204eae9ecce6db1f2John McCall // that much. 306960fad45739b764886f707bd204eae9ecce6db1f2John McCall llvm::APSInt shift; 307060fad45739b764886f707bd204eae9ecce6db1f2John McCall if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 307160fad45739b764886f707bd204eae9ecce6db1f2John McCall shift.isNonNegative()) { 307260fad45739b764886f707bd204eae9ecce6db1f2John McCall unsigned zext = shift.getZExtValue(); 307360fad45739b764886f707bd204eae9ecce6db1f2John McCall if (zext >= L.Width) 307460fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width = (L.NonNegative ? 0 : 1); 307560fad45739b764886f707bd204eae9ecce6db1f2John McCall else 307660fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width -= zext; 307760fad45739b764886f707bd204eae9ecce6db1f2John McCall } 307860fad45739b764886f707bd204eae9ecce6db1f2John McCall 307960fad45739b764886f707bd204eae9ecce6db1f2John McCall return L; 308060fad45739b764886f707bd204eae9ecce6db1f2John McCall } 308160fad45739b764886f707bd204eae9ecce6db1f2John McCall 308260fad45739b764886f707bd204eae9ecce6db1f2John McCall // Comma acts as its right operand. 30832de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Comma: 3084f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 3085f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 308660fad45739b764886f707bd204eae9ecce6db1f2John McCall // Black-list pointer subtractions. 30872de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Sub: 308851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BO->getLHS()->getType()->isPointerType()) 30891844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 309000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall break; 309100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 309200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The width of a division result is mostly determined by the size 309300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // of the LHS. 309400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Div: { 309500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 309600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 309700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 309800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 309900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // If the divisor is constant, use that. 310000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall llvm::APSInt divisor; 310100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) { 310200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned log2 = divisor.logBase2(); // floor(log_2(divisor)) 310300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall if (log2 >= L.Width) 310400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = (L.NonNegative ? 0 : 1); 310500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall else 310600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall L.Width = std::min(L.Width - log2, MaxWidth); 310700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return L; 310800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 310900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 311000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Otherwise, just use the LHS's width. 311100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 311200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return IntRange(L.Width, L.NonNegative && R.NonNegative); 311300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 311400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 311500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The result of a remainder can't be larger than the result of 311600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // either side. 311700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Rem: { 311800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // Don't 'pre-truncate' the operands. 311900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall unsigned opWidth = C.getIntWidth(E->getType()); 312000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), opWidth); 312100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), opWidth); 312200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall 312300fe761849278180b0d73f276e468cf4c54ff2adJohn McCall IntRange meet = IntRange::meet(L, R); 312400fe761849278180b0d73f276e468cf4c54ff2adJohn McCall meet.Width = std::min(meet.Width, MaxWidth); 312500fe761849278180b0d73f276e468cf4c54ff2adJohn McCall return meet; 312600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall } 31274e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 312800fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default behavior is okay for these. 312900fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Mul: 313000fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Add: 313100fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Xor: 313200fe761849278180b0d73f276e468cf4c54ff2adJohn McCall case BO_Or: 3133f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall break; 313451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 3135f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 313600fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // The default case is to treat the operation as if it were closed 313700fe761849278180b0d73f276e468cf4c54ff2adJohn McCall // on the narrowest type that encompasses both operands. 3138f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 3139f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 3140f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 314151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 314251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 314351313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 314451313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (UO->getOpcode()) { 314551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Boolean-valued operations are white-listed. 31462de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_LNot: 3147f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 314851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 314951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 31502de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_Deref: 31512de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_AddrOf: // should be impossible 31521844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 315351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 315451313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 3155f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, UO->getSubExpr(), MaxWidth); 315651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 315751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 31588ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor 31598ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor if (dyn_cast<OffsetOfExpr>(E)) { 31601844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange::forValueOfType(C, E->getType()); 31618ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor } 316251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3163a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith if (FieldDecl *BitField = E->getBitField()) 3164a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith return IntRange(BitField->getBitWidthValue(C), 31655e9ebb3c0fb554d9285aa99c470abdf283272bd9Douglas Gregor BitField->getType()->isUnsignedIntegerOrEnumerationType()); 3166f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 31671844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 3168f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 3169f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3170323ed74658bc8375278eabf074b4777458376540John McCallIntRange GetExprRange(ASTContext &C, Expr *E) { 3171323ed74658bc8375278eabf074b4777458376540John McCall return GetExprRange(C, E, C.getIntWidth(E->getType())); 3172323ed74658bc8375278eabf074b4777458376540John McCall} 3173323ed74658bc8375278eabf074b4777458376540John McCall 3174f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 3175f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 3176f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 3177f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const llvm::APFloat &value, 3178f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 3179f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 3180f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APFloat truncated = value; 3181f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3182f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool ignored; 3183f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 3184f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 3185f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3186f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return truncated.bitwiseIsEqual(value); 318751313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 318851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3189f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 3190f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 3191f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 3192f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 3193f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number). 3194f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const APValue &value, 3195f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 3196f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 3197f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isFloat()) 3198f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 3199f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3200f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isVector()) { 3201f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 3202f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 3203f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return false; 3204f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return true; 3205f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 3206f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3207f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(value.isComplexFloat()); 3208f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 3209f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 3210f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 3211f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3212b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 3213323ed74658bc8375278eabf074b4777458376540John McCall 3214e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) { 3215e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where we are comparing against an enum constant. 3216e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (const DeclRefExpr *DR = 3217e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 3218e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (isa<EnumConstantDecl>(DR->getDecl())) 3219e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 3220e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 3221e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where the '0' value is expanded from a macro. 3222e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (E->getLocStart().isMacroID()) 3223e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 3224e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 3225323ed74658bc8375278eabf074b4777458376540John McCall llvm::APSInt Value; 3226323ed74658bc8375278eabf074b4777458376540John McCall return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 3227323ed74658bc8375278eabf074b4777458376540John McCall} 3228323ed74658bc8375278eabf074b4777458376540John McCall 3229372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) { 3230372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall // Strip off implicit integral promotions. 3231372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 323263b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis if (ICE->getCastKind() != CK_IntegralCast && 323363b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis ICE->getCastKind() != CK_NoOp) 3234372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall break; 323563b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis E = ICE->getSubExpr(); 3236372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall } 3237372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 3238372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall return E->getType()->isEnumeralType(); 3239372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall} 3240372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 3241323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 32422de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = E->getOpcode(); 324314af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor if (E->isValueDependent()) 324414af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor return; 324514af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor 32462de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op == BO_LT && IsZero(S, E->getRHS())) { 3247323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 3248372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "< 0" << "false" << HasEnumType(E->getLHS()) 3249323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 32502de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GE && IsZero(S, E->getRHS())) { 3251323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 3252372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << ">= 0" << "true" << HasEnumType(E->getLHS()) 3253323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 32542de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GT && IsZero(S, E->getLHS())) { 3255323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 3256372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 >" << "false" << HasEnumType(E->getRHS()) 3257323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 32582de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_LE && IsZero(S, E->getLHS())) { 3259323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 3260372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 <=" << "true" << HasEnumType(E->getRHS()) 3261323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 3262323ed74658bc8375278eabf074b4777458376540John McCall } 3263323ed74658bc8375278eabf074b4777458376540John McCall} 3264323ed74658bc8375278eabf074b4777458376540John McCall 3265323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison. Implements the 3266323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison. 3267323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 3268b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 3269b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 3270323ed74658bc8375278eabf074b4777458376540John McCall} 3271f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3272ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare. 3273ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// 3274dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu/// \param E the binary operator to check for warnings 3275323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeComparison(Sema &S, BinaryOperator *E) { 3276323ed74658bc8375278eabf074b4777458376540John McCall // The type the comparison is being performed in. 3277323ed74658bc8375278eabf074b4777458376540John McCall QualType T = E->getLHS()->getType(); 3278323ed74658bc8375278eabf074b4777458376540John McCall assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 3279323ed74658bc8375278eabf074b4777458376540John McCall && "comparison with mismatched types"); 3280323ed74658bc8375278eabf074b4777458376540John McCall 3281323ed74658bc8375278eabf074b4777458376540John McCall // We don't do anything special if this isn't an unsigned integral 3282323ed74658bc8375278eabf074b4777458376540John McCall // comparison: we're only interested in integral comparisons, and 3283323ed74658bc8375278eabf074b4777458376540John McCall // signed comparisons only happen in cases we don't care to warn about. 32843e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // 32853e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // We also don't care about value-dependent expressions or expressions 32863e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // whose result is a constant. 32873e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor if (!T->hasUnsignedIntegerRepresentation() 32883e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor || E->isValueDependent() || E->isIntegerConstantExpr(S.Context)) 3289323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 3290323ed74658bc8375278eabf074b4777458376540John McCall 3291dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr *LHS = E->getLHS()->IgnoreParenImpCasts(); 3292dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu Expr *RHS = E->getRHS()->IgnoreParenImpCasts(); 3293323ed74658bc8375278eabf074b4777458376540John McCall 3294323ed74658bc8375278eabf074b4777458376540John McCall // Check to see if one of the (unmodified) operands is of different 3295323ed74658bc8375278eabf074b4777458376540John McCall // signedness. 3296323ed74658bc8375278eabf074b4777458376540John McCall Expr *signedOperand, *unsignedOperand; 3297dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu if (LHS->getType()->hasSignedIntegerRepresentation()) { 3298dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu assert(!RHS->getType()->hasSignedIntegerRepresentation() && 3299323ed74658bc8375278eabf074b4777458376540John McCall "unsigned comparison between two signed integer expressions?"); 3300dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = LHS; 3301dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = RHS; 3302dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu } else if (RHS->getType()->hasSignedIntegerRepresentation()) { 3303dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu signedOperand = RHS; 3304dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu unsignedOperand = LHS; 3305ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } else { 3306323ed74658bc8375278eabf074b4777458376540John McCall CheckTrivialUnsignedComparison(S, E); 3307323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 3308ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } 3309ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3310323ed74658bc8375278eabf074b4777458376540John McCall // Otherwise, calculate the effective range of the signed operand. 3311323ed74658bc8375278eabf074b4777458376540John McCall IntRange signedRange = GetExprRange(S.Context, signedOperand); 3312f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 3313323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and analyze implicit conversions in the operands. Note 3314323ed74658bc8375278eabf074b4777458376540John McCall // that we skip the implicit conversions on both sides. 3315dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc()); 3316dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc()); 3317ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3318323ed74658bc8375278eabf074b4777458376540John McCall // If the signed range is non-negative, -Wsign-compare won't fire, 3319323ed74658bc8375278eabf074b4777458376540John McCall // but we should still check for comparisons which are always true 3320323ed74658bc8375278eabf074b4777458376540John McCall // or false. 3321323ed74658bc8375278eabf074b4777458376540John McCall if (signedRange.NonNegative) 3322323ed74658bc8375278eabf074b4777458376540John McCall return CheckTrivialUnsignedComparison(S, E); 3323ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3324ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // For (in)equality comparisons, if the unsigned operand is a 3325ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // constant which cannot collide with a overflowed signed operand, 3326ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // then reinterpreting the signed operand as unsigned will not 3327ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // change the result of the comparison. 3328323ed74658bc8375278eabf074b4777458376540John McCall if (E->isEqualityOp()) { 3329323ed74658bc8375278eabf074b4777458376540John McCall unsigned comparisonWidth = S.Context.getIntWidth(T); 3330323ed74658bc8375278eabf074b4777458376540John McCall IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 3331323ed74658bc8375278eabf074b4777458376540John McCall 3332323ed74658bc8375278eabf074b4777458376540John McCall // We should never be unable to prove that the unsigned operand is 3333323ed74658bc8375278eabf074b4777458376540John McCall // non-negative. 3334323ed74658bc8375278eabf074b4777458376540John McCall assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 3335ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 3336323ed74658bc8375278eabf074b4777458376540John McCall if (unsignedRange.Width < comparisonWidth) 3337323ed74658bc8375278eabf074b4777458376540John McCall return; 3338323ed74658bc8375278eabf074b4777458376540John McCall } 3339323ed74658bc8375278eabf074b4777458376540John McCall 3340323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison) 3341dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu << LHS->getType() << RHS->getType() 3342dd22509c82eb7681a0f46b41d61cb2e25a4d8fa1Richard Trieu << LHS->getSourceRange() << RHS->getSourceRange(); 3343ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall} 3344ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 334515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield. 334615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// 334715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt. 334815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallbool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 334915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall SourceLocation InitLoc) { 335015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall assert(Bitfield->isBitField()); 335115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Bitfield->isInvalidDecl()) 335215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 335315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 335491b6014876e9186f968f74a8975ab8fc08ef1b68John McCall // White-list bool bitfields. 335591b6014876e9186f968f74a8975ab8fc08ef1b68John McCall if (Bitfield->getType()->isBooleanType()) 335691b6014876e9186f968f74a8975ab8fc08ef1b68John McCall return false; 335791b6014876e9186f968f74a8975ab8fc08ef1b68John McCall 335846ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor // Ignore value- or type-dependent expressions. 335946ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor if (Bitfield->getBitWidth()->isValueDependent() || 336046ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Bitfield->getBitWidth()->isTypeDependent() || 336146ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isValueDependent() || 336246ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isTypeDependent()) 336346ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor return false; 336446ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor 336515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *OriginalInit = Init->IgnoreParenImpCasts(); 336615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 336715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr::EvalResult InitValue; 3368a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith if (!OriginalInit->Evaluate(InitValue, S.Context) || 336915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall !InitValue.Val.isInt()) 337015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 337115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 337215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall const llvm::APSInt &Value = InitValue.Val.getInt(); 337315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned OriginalWidth = Value.getBitWidth(); 3374a6b8b2c09610b8bc4330e948ece8b940c2386406Richard Smith unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context); 337515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 337615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (OriginalWidth <= FieldWidth) 337715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 337815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 33799f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad llvm::APSInt TruncatedValue = Value.trunc(FieldWidth); 338015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 338115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // It's fairly common to write values into signed bitfields 338215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // that, if sign-extended, would end up becoming a different 338315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // value. We don't want to warn about that. 338415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value.isSigned() && Value.isNegative()) 33859f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad TruncatedValue = TruncatedValue.sext(OriginalWidth); 338615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall else 33879f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad TruncatedValue = TruncatedValue.zext(OriginalWidth); 338815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 338915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value == TruncatedValue) 339015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 339115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 339215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyValue = Value.toString(10); 339315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyTrunc = TruncatedValue.toString(10); 339415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 339515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 339615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << PrettyValue << PrettyTrunc << OriginalInit->getType() 339715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << Init->getSourceRange(); 339815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 339915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return true; 340015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 340115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 3402beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy 3403beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations. 3404beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCallvoid AnalyzeAssignment(Sema &S, BinaryOperator *E) { 3405beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Just recurse on the LHS. 3406beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 3407beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 3408beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // We want to recurse on the RHS as normal unless we're assigning to 3409beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // a bitfield. 3410beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (FieldDecl *Bitfield = E->getLHS()->getBitField()) { 341115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 341215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc())) { 341315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // Recurse, ignoring any implicit conversions on the RHS. 341415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 341515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc()); 3416beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 3417beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 3418beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 3419beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 3420beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall} 3421beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 342251313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 34235a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregorvoid DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T, 34245a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceLocation CContext, unsigned diag) { 34255a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor S.Diag(E->getExprLoc(), diag) 34265a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor << SourceType << T << E->getSourceRange() << SourceRange(CContext); 34275a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor} 34285a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 3429e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 3430e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruthvoid DiagnoseImpCast(Sema &S, Expr *E, QualType T, SourceLocation CContext, 3431e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth unsigned diag) { 3432e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth DiagnoseImpCast(S, E, E->getType(), T, CContext, diag); 3433e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth} 3434e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth 34359ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// Diagnose an implicit cast from a literal expression. Does not warn when the 34369ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay/// cast wouldn't lose information. 3437f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruthvoid DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T, 3438f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth SourceLocation CContext) { 34399ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay // Try to convert the literal exactly to an integer. If we can, don't warn. 3440f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth bool isExact = false; 34419ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay const llvm::APFloat &Value = FL->getValue(); 34423e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin llvm::APSInt IntegerValue(S.Context.getIntWidth(T), 34433e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin T->hasUnsignedIntegerRepresentation()); 34443e1ef7849845a9e7bf79156bbb8a2c26d77a1d2eJeffrey Yasskin if (Value.convertToInteger(IntegerValue, 3445f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth llvm::APFloat::rmTowardZero, &isExact) 34469ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay == llvm::APFloat::opOK && isExact) 3447f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth return; 3448f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 34499ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer) 34509ce6377714a8eb8f577c87028300421e72b00dc9Matt Beaumont-Gay << FL->getType() << T << FL->getSourceRange() << SourceRange(CContext); 3451f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth} 3452f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 3453091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 3454091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Range.Width) return "0"; 3455091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3456091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt ValueInRange = Value; 3457091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.setIsSigned(!Range.NonNegative); 34589f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad ValueInRange = ValueInRange.trunc(Range.Width); 3459091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return ValueInRange.toString(10); 3460091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall} 3461091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3462ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenekstatic bool isFromSystemMacro(Sema &S, SourceLocation loc) { 3463ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceManager &smgr = S.Context.getSourceManager(); 3464ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return loc.isMacroID() && smgr.isInSystemHeader(smgr.getSpellingLoc(loc)); 3465ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek} 3466f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth 3467323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T, 3468b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool *ICContext = 0) { 3469323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) return; 347051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3471323ed74658bc8375278eabf074b4777458376540John McCall const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 3472323ed74658bc8375278eabf074b4777458376540John McCall const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 3473323ed74658bc8375278eabf074b4777458376540John McCall if (Source == Target) return; 3474323ed74658bc8375278eabf074b4777458376540John McCall if (Target->isDependentType()) return; 347551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3476108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // If the conversion context location is invalid don't complain. We also 3477108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // don't want to emit a warning if the issue occurs from the expansion of 3478108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // a system macro. The problem is that 'getSpellingLoc()' is slow, so we 3479108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // delay this check as long as possible. Once we detect we are in that 3480108f756bebd991eaa980cfb9994353612a2e5ff6Chandler Carruth // scenario, we just return. 3481ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (CC.isInvalid()) 3482b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return; 3483b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 3484f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Diagnose implicit casts to bool. 3485f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (Target->isSpecificBuiltinType(BuiltinType::Bool)) { 3486f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (isa<StringLiteral>(E)) 3487f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Warn on string literal to bool. Checks for string literals in logical 3488f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // expressions, for instances, assert(0 && "error here"), is prevented 3489f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // by a check in AnalyzeImplicitConversions(). 3490f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu return DiagnoseImpCast(S, E, T, CC, 3491f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu diag::warn_impcast_string_literal_to_bool); 3492e37cdc42bf7298a974dfdfa9c03ef11398e7c889David Blaikie return; // Other casts to bool are not checked. 3493f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 349451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 349551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip vector types. 349651313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<VectorType>(Source)) { 3497ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<VectorType>(Target)) { 3498ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3499ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3500b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 3501ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 3502b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner 3503b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // If the vector cast is cast between two vectors of the same size, it is 3504b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // a bitcast, not a conversion. 3505b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target)) 3506b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner return; 350751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 350851313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 350951313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 351051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 351151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 351251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip complex types. 351351313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<ComplexType>(Source)) { 3514ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<ComplexType>(Target)) { 3515ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3516ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3517ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3518b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 3519ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 352051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 352151313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 352251313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 352351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 352451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 352551313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 352651313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 352751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 352851313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the source is floating point... 352951313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT && SourceBT->isFloatingPoint()) { 353051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...and the target is floating point... 353151313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (TargetBT && TargetBT->isFloatingPoint()) { 353251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...then warn if we're dropping FP rank. 353351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 353451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Builtin FP kinds are ordered by increasing FP rank. 353551313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT->getKind() > TargetBT->getKind()) { 353651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Don't warn about float constants that are precisely 353751313c39c84407dd6a323be99a8c322bf8d052a9John McCall // representable in the target type. 353851313c39c84407dd6a323be99a8c322bf8d052a9John McCall Expr::EvalResult result; 3539323ed74658bc8375278eabf074b4777458376540John McCall if (E->Evaluate(result, S.Context)) { 354051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Value might be a float, a float vector, or a float complex. 354151313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (IsSameFloatAfterCast(result.Val, 3542323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 3543323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 354451313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 354551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 354651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3547ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3548ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3549ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3550b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 355151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 355251313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 355351313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 355451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3555ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // If the target is integral, always warn. 3556a5b9332418f25338f118358e27303cd510d54107Chandler Carruth if ((TargetBT && TargetBT->isInteger())) { 3557ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3558ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3559ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3560a5b9332418f25338f118358e27303cd510d54107Chandler Carruth Expr *InnerE = E->IgnoreParenImpCasts(); 3561634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay // We also want to warn on, e.g., "int i = -1.234" 3562634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE)) 3563634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus) 3564634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay InnerE = UOp->getSubExpr()->IgnoreParenImpCasts(); 3565634c8af0805ba33b1530470e03aa314141036aa2Matt Beaumont-Gay 3566f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) { 3567f65076ebf5e8bc5ae7b77fe3c3a65dc5db8d763fChandler Carruth DiagnoseFloatingLiteralImpCast(S, FL, T, CC); 3568a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } else { 3569a5b9332418f25338f118358e27303cd510d54107Chandler Carruth DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 3570a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 3571a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 357251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 357351313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 357451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 357551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3576f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!Source->isIntegerType() || !Target->isIntegerType()) 357751313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 357851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 35791838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu if ((E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull) 35801838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu == Expr::NPCK_GNUNull) && Target->isIntegerType()) { 35811838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu S.Diag(E->getExprLoc(), diag::warn_impcast_null_pointer_to_integer) 35821838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu << E->getSourceRange() << clang::SourceRange(CC); 35831838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu return; 35841838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu } 35851838ca5618bc6c84ca3d13d84717bf32d9862bb3Richard Trieu 3586323ed74658bc8375278eabf074b4777458376540John McCall IntRange SourceRange = GetExprRange(S.Context, E); 35871844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 358851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3589f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width > TargetRange.Width) { 3590091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // If the source is a constant, use a default-on diagnostic. 3591091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // TODO: this should happen for bitfield stores, too. 3592091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt Value(32); 3593091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (E->isIntegerConstantExpr(Value, S.Context)) { 3594ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3595ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3596ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3597091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettySourceValue = Value.toString(10); 3598091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 3599091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3600091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall S.Diag(E->getExprLoc(), diag::warn_impcast_integer_precision_constant) 3601091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall << PrettySourceValue << PrettyTargetValue 3602091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall << E->getType() << T << E->getSourceRange() << clang::SourceRange(CC); 3603091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return; 3604091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall } 3605091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 3606b792b30ce3d31e3eb3cfee3321238cf3cc2165b0Chris Lattner // People want to build with -Wshorten-64-to-32 and not -Wconversion. 3607ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3608ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3609ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3610f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width == 64 && TargetRange.Width == 32) 3611b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32); 3612b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 3613323ed74658bc8375278eabf074b4777458376540John McCall } 3614323ed74658bc8375278eabf074b4777458376540John McCall 3615323ed74658bc8375278eabf074b4777458376540John McCall if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 3616323ed74658bc8375278eabf074b4777458376540John McCall (!TargetRange.NonNegative && SourceRange.NonNegative && 3617323ed74658bc8375278eabf074b4777458376540John McCall SourceRange.Width == TargetRange.Width)) { 3618ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3619ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3620ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3621ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 3622323ed74658bc8375278eabf074b4777458376540John McCall unsigned DiagID = diag::warn_impcast_integer_sign; 3623323ed74658bc8375278eabf074b4777458376540John McCall 3624323ed74658bc8375278eabf074b4777458376540John McCall // Traditionally, gcc has warned about this under -Wsign-compare. 3625323ed74658bc8375278eabf074b4777458376540John McCall // We also want to warn about it in -Wconversion. 3626323ed74658bc8375278eabf074b4777458376540John McCall // So if -Wconversion is off, use a completely identical diagnostic 3627323ed74658bc8375278eabf074b4777458376540John McCall // in the sign-compare group. 3628323ed74658bc8375278eabf074b4777458376540John McCall // The conditional-checking code will 3629323ed74658bc8375278eabf074b4777458376540John McCall if (ICContext) { 3630323ed74658bc8375278eabf074b4777458376540John McCall DiagID = diag::warn_impcast_integer_sign_conditional; 3631323ed74658bc8375278eabf074b4777458376540John McCall *ICContext = true; 3632323ed74658bc8375278eabf074b4777458376540John McCall } 3633323ed74658bc8375278eabf074b4777458376540John McCall 3634b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, DiagID); 363551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 363651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3637284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor // Diagnose conversions between different enumeration types. 36385a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // In C, we pretend that the type of an EnumConstantDecl is its enumeration 36395a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // type, to give us better diagnostics. 36405a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor QualType SourceType = E->getType(); 36415a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (!S.getLangOptions().CPlusPlus) { 36425a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 36435a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) { 36445a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext()); 36455a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceType = S.Context.getTypeDeclType(Enum); 36465a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor Source = S.Context.getCanonicalType(SourceType).getTypePtr(); 36475a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 36485a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 36495a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 3650284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *SourceEnum = Source->getAs<EnumType>()) 3651284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *TargetEnum = Target->getAs<EnumType>()) 3652284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if ((SourceEnum->getDecl()->getIdentifier() || 3653162e1c1b487352434552147967c3dd296ebee2f7Richard Smith SourceEnum->getDecl()->getTypedefNameForAnonDecl()) && 3654284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor (TargetEnum->getDecl()->getIdentifier() || 3655162e1c1b487352434552147967c3dd296ebee2f7Richard Smith TargetEnum->getDecl()->getTypedefNameForAnonDecl()) && 3656ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceEnum != TargetEnum) { 3657ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 3658ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 3659ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 36605a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor return DiagnoseImpCast(S, E, SourceType, T, CC, 3661284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor diag::warn_impcast_different_enum_types); 3662ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 3663284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor 366451313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 366551313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 366651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 3667323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T); 3668323ed74658bc8375278eabf074b4777458376540John McCall 3669323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T, 3670b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool &ICContext) { 3671323ed74658bc8375278eabf074b4777458376540John McCall E = E->IgnoreParenImpCasts(); 3672323ed74658bc8375278eabf074b4777458376540John McCall 3673323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) 3674323ed74658bc8375278eabf074b4777458376540John McCall return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T); 3675323ed74658bc8375278eabf074b4777458376540John McCall 3676b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E, CC); 3677323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 3678b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return CheckImplicitConversion(S, E, T, CC, &ICContext); 3679323ed74658bc8375278eabf074b4777458376540John McCall return; 3680323ed74658bc8375278eabf074b4777458376540John McCall} 3681323ed74658bc8375278eabf074b4777458376540John McCall 3682323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) { 3683b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC = E->getQuestionLoc(); 3684b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 3685b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getCond(), CC); 3686323ed74658bc8375278eabf074b4777458376540John McCall 3687323ed74658bc8375278eabf074b4777458376540John McCall bool Suspicious = false; 3688b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 3689b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 3690323ed74658bc8375278eabf074b4777458376540John McCall 3691323ed74658bc8375278eabf074b4777458376540John McCall // If -Wconversion would have warned about either of the candidates 3692323ed74658bc8375278eabf074b4777458376540John McCall // for a signedness conversion to the context type... 3693323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) return; 3694323ed74658bc8375278eabf074b4777458376540John McCall 3695323ed74658bc8375278eabf074b4777458376540John McCall // ...but it's currently ignored... 36960827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional, 36970827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis CC)) 3698323ed74658bc8375278eabf074b4777458376540John McCall return; 3699323ed74658bc8375278eabf074b4777458376540John McCall 3700323ed74658bc8375278eabf074b4777458376540John McCall // ...then check whether it would have warned about either of the 3701323ed74658bc8375278eabf074b4777458376540John McCall // candidates for a signedness conversion to the condition type. 37025254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (E->getType() == T) return; 37035254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu 37045254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu Suspicious = false; 37055254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 37065254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu E->getType(), CC, &Suspicious); 37075254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu if (!Suspicious) 37085254161b269829b74e7a9379b1bdfa27de72d7ccRichard Trieu CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 3709b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 3710323ed74658bc8375278eabf074b4777458376540John McCall} 3711323ed74658bc8375278eabf074b4777458376540John McCall 3712323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting 3713323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression. There are a couple 3714323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare. 3715b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 3716323ed74658bc8375278eabf074b4777458376540John McCall QualType T = OrigE->getType(); 3717323ed74658bc8375278eabf074b4777458376540John McCall Expr *E = OrigE->IgnoreParenImpCasts(); 3718323ed74658bc8375278eabf074b4777458376540John McCall 3719f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 3720f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor return; 3721f8b6e1591b5c5085cf4dec8df657e32a68053b12Douglas Gregor 3722323ed74658bc8375278eabf074b4777458376540John McCall // For conditional operators, we analyze the arguments as if they 3723323ed74658bc8375278eabf074b4777458376540John McCall // were being fed directly into the output. 3724323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) { 3725323ed74658bc8375278eabf074b4777458376540John McCall ConditionalOperator *CO = cast<ConditionalOperator>(E); 3726323ed74658bc8375278eabf074b4777458376540John McCall CheckConditionalOperator(S, CO, T); 3727323ed74658bc8375278eabf074b4777458376540John McCall return; 3728323ed74658bc8375278eabf074b4777458376540John McCall } 3729323ed74658bc8375278eabf074b4777458376540John McCall 3730323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and check any implicit conversions we might have skipped. 3731323ed74658bc8375278eabf074b4777458376540John McCall // The non-canonical typecheck is just an optimization; 3732323ed74658bc8375278eabf074b4777458376540John McCall // CheckImplicitConversion will filter out dead implicit conversions. 3733323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 3734b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckImplicitConversion(S, E, T, CC); 3735323ed74658bc8375278eabf074b4777458376540John McCall 3736323ed74658bc8375278eabf074b4777458376540John McCall // Now continue drilling into this expression. 3737323ed74658bc8375278eabf074b4777458376540John McCall 3738323ed74658bc8375278eabf074b4777458376540John McCall // Skip past explicit casts. 3739323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ExplicitCastExpr>(E)) { 3740323ed74658bc8375278eabf074b4777458376540John McCall E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 3741b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return AnalyzeImplicitConversions(S, E, CC); 3742323ed74658bc8375278eabf074b4777458376540John McCall } 3743323ed74658bc8375278eabf074b4777458376540John McCall 3744beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 3745beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Do a somewhat different check with comparison operators. 3746beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isComparisonOp()) 3747beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeComparison(S, BO); 3748beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 3749beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // And with assignments and compound assignments. 3750beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isAssignmentOp()) 3751beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeAssignment(S, BO); 3752beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 3753323ed74658bc8375278eabf074b4777458376540John McCall 3754323ed74658bc8375278eabf074b4777458376540John McCall // These break the otherwise-useful invariant below. Fortunately, 3755323ed74658bc8375278eabf074b4777458376540John McCall // we don't really need to recurse into them, because any internal 3756323ed74658bc8375278eabf074b4777458376540John McCall // expressions should have been analyzed already when they were 3757323ed74658bc8375278eabf074b4777458376540John McCall // built into statements. 3758323ed74658bc8375278eabf074b4777458376540John McCall if (isa<StmtExpr>(E)) return; 3759323ed74658bc8375278eabf074b4777458376540John McCall 3760323ed74658bc8375278eabf074b4777458376540John McCall // Don't descend into unevaluated contexts. 3761f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne if (isa<UnaryExprOrTypeTraitExpr>(E)) return; 3762323ed74658bc8375278eabf074b4777458376540John McCall 3763323ed74658bc8375278eabf074b4777458376540John McCall // Now just recurse over the expression's children. 3764b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CC = E->getExprLoc(); 3765f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu BinaryOperator *BO = dyn_cast<BinaryOperator>(E); 3766f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu bool IsLogicalOperator = BO && BO->isLogicalOp(); 3767f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu for (Stmt::child_range I = E->children(); I; ++I) { 3768f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu Expr *ChildExpr = cast<Expr>(*I); 3769f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu if (IsLogicalOperator && 3770f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts())) 3771f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu // Ignore checking string literals that are in logical operators. 3772f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu continue; 3773f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu AnalyzeImplicitConversions(S, ChildExpr, CC); 3774f1f8b1a404d9ce6f0eb78e97b598a220d8ca9090Richard Trieu } 3775323ed74658bc8375278eabf074b4777458376540John McCall} 3776323ed74658bc8375278eabf074b4777458376540John McCall 3777323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace 3778323ed74658bc8375278eabf074b4777458376540John McCall 3779323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given 3780323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression). Implements -Wconversion 3781323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare. 3782b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// 3783b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e. 3784b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// the most location of the syntactic entity requiring the implicit 3785b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// conversion 3786b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 3787323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose in unevaluated contexts. 3788323ed74658bc8375278eabf074b4777458376540John McCall if (ExprEvalContexts.back().Context == Sema::Unevaluated) 3789323ed74658bc8375278eabf074b4777458376540John McCall return; 3790323ed74658bc8375278eabf074b4777458376540John McCall 3791323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose for value- or type-dependent expressions. 3792323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) 3793323ed74658bc8375278eabf074b4777458376540John McCall return; 3794323ed74658bc8375278eabf074b4777458376540John McCall 3795d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Check for array bounds violations in cases where the check isn't triggered 3796d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // elsewhere for other Expr types (like BinaryOperators), e.g. when an 3797d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // ArraySubscriptExpr is on the RHS of a variable initialization. 3798d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain CheckArrayAccess(E); 3799d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 3800b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // This is not the right CC for (e.g.) a variable initialization. 3801b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(*this, E, CC); 3802323ed74658bc8375278eabf074b4777458376540John McCall} 3803323ed74658bc8375278eabf074b4777458376540John McCall 380415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 380515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall FieldDecl *BitField, 380615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *Init) { 380715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 380815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 380915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 3810f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given 3811f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This 3812f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the 3813f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function 3814f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete. 381582aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregorbool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd, 381682aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor bool CheckParameterNames) { 3817f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump bool HasInvalidParm = false; 381882aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor for (; P != PEnd; ++P) { 381982aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor ParmVarDecl *Param = *P; 382082aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor 3821f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.7.5.3p4: the parameters in a parameter type list in a 3822f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // function declarator that is part of a function definition of 3823f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // that function shall not have incomplete type. 3824f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // 3825f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // This is also C++ [dcl.fct]p6. 3826f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump if (!Param->isInvalidDecl() && 3827f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump RequireCompleteType(Param->getLocation(), Param->getType(), 3828f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump diag::err_typecheck_decl_incomplete_type)) { 3829f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Param->setInvalidDecl(); 3830f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump HasInvalidParm = true; 3831f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 3832f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 3833f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.9.1p5: If the declarator includes a parameter type list, the 3834f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // declaration of each parameter shall include an identifier. 383582aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor if (CheckParameterNames && 383682aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor Param->getIdentifier() == 0 && 3837f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !Param->isImplicit() && 3838f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !getLangOptions().CPlusPlus) 3839f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Diag(Param->getLocation(), diag::err_parameter_name_omitted); 3840d17e340e2d516139931768697bf080f60920ba9dSam Weinig 3841d17e340e2d516139931768697bf080f60920ba9dSam Weinig // C99 6.7.5.3p12: 3842d17e340e2d516139931768697bf080f60920ba9dSam Weinig // If the function declarator is not part of a definition of that 3843d17e340e2d516139931768697bf080f60920ba9dSam Weinig // function, parameters may have incomplete type and may use the [*] 3844d17e340e2d516139931768697bf080f60920ba9dSam Weinig // notation in their sequences of declarator specifiers to specify 3845d17e340e2d516139931768697bf080f60920ba9dSam Weinig // variable length array types. 3846d17e340e2d516139931768697bf080f60920ba9dSam Weinig QualType PType = Param->getOriginalType(); 3847d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (const ArrayType *AT = Context.getAsArrayType(PType)) { 3848d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (AT->getSizeModifier() == ArrayType::Star) { 3849d17e340e2d516139931768697bf080f60920ba9dSam Weinig // FIXME: This diagnosic should point the the '[*]' if source-location 3850d17e340e2d516139931768697bf080f60920ba9dSam Weinig // information is added for it. 3851d17e340e2d516139931768697bf080f60920ba9dSam Weinig Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 3852d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 3853d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 3854f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 3855f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 3856f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump return HasInvalidParm; 3857f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump} 3858b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3859b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a 3860b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements. 3861b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 3862b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // This is actually a lot of work to potentially be doing on every 3863b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // cast; don't do it if we're ignoring -Wcast_align (as is the default). 38640827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align, 38650827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis TRange.getBegin()) 3866d6471f7c1921c7802804ce3ff6fe9768310f72b9David Blaikie == DiagnosticsEngine::Ignored) 3867b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 3868b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3869b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Ignore dependent types. 3870b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (T->isDependentType() || Op->getType()->isDependentType()) 3871b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 3872b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3873b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the destination be a pointer type. 3874b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *DestPtr = T->getAs<PointerType>(); 3875b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!DestPtr) return; 3876b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3877b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // If the destination has alignment 1, we're done. 3878b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType DestPointee = DestPtr->getPointeeType(); 3879b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestPointee->isIncompleteType()) return; 3880b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 3881b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestAlign.isOne()) return; 3882b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3883b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the source be a pointer type. 3884b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 3885b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!SrcPtr) return; 3886b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType SrcPointee = SrcPtr->getPointeeType(); 3887b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3888b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Whitelist casts from cv void*. We already implicitly 3889b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // whitelisted casts to cv void*, since they have alignment 1. 3890b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Also whitelist casts involving incomplete types, which implicitly 3891b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // includes 'void'. 3892b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcPointee->isIncompleteType()) return; 3893b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3894b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 3895b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcAlign >= DestAlign) return; 3896b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3897b7f4ffe073fa419613946461a2583ba2fcb72280John McCall Diag(TRange.getBegin(), diag::warn_cast_align) 3898b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << Op->getType() << T 3899b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(SrcAlign.getQuantity()) 3900b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(DestAlign.getQuantity()) 3901b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << TRange << Op->getSourceRange(); 3902b7f4ffe073fa419613946461a2583ba2fcb72280John McCall} 3903b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3904d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainstatic const Type* getElementType(const Expr *BaseExpr) { 3905d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* EltType = BaseExpr->getType().getTypePtr(); 3906d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (EltType->isAnyPointerType()) 3907d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getPointeeType().getTypePtr(); 3908d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain else if (EltType->isArrayType()) 3909d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType->getBaseElementTypeUnsafe(); 3910d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return EltType; 3911d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain} 3912d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 3913c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// \brief Check whether this array fits the idiom of a size-one tail padded 3914c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// array member of a struct. 3915c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// 3916c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// We avoid emitting out-of-bounds access warnings for such arrays as they are 3917c268434b332bbe57950d977633369bf5822d9554Chandler Carruth/// commonly used to emulate flexible arrays in C89 code. 3918c268434b332bbe57950d977633369bf5822d9554Chandler Carruthstatic bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size, 3919c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const NamedDecl *ND) { 3920c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (Size != 1 || !ND) return false; 3921c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 3922c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const FieldDecl *FD = dyn_cast<FieldDecl>(ND); 3923c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!FD) return false; 3924c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 3925c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // Don't consider sizes resulting from macro expansions or template argument 3926c268434b332bbe57950d977633369bf5822d9554Chandler Carruth // substitution to form C89 tail-padded arrays. 3927c268434b332bbe57950d977633369bf5822d9554Chandler Carruth ConstantArrayTypeLoc TL = 3928c268434b332bbe57950d977633369bf5822d9554Chandler Carruth cast<ConstantArrayTypeLoc>(FD->getTypeSourceInfo()->getTypeLoc()); 3929c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const Expr *SizeExpr = dyn_cast<IntegerLiteral>(TL.getSizeExpr()); 3930c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!SizeExpr || SizeExpr->getExprLoc().isMacroID()) 3931c268434b332bbe57950d977633369bf5822d9554Chandler Carruth return false; 3932c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 3933c268434b332bbe57950d977633369bf5822d9554Chandler Carruth const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext()); 3934c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (!RD || !RD->isStruct()) 3935c268434b332bbe57950d977633369bf5822d9554Chandler Carruth return false; 3936c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 393722d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer // See if this is the last field decl in the record. 393822d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer const Decl *D = FD; 393922d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer while ((D = D->getNextDeclInContext())) 394022d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer if (isa<FieldDecl>(D)) 394122d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return false; 394222d4fed17df02f5fa07165a69228b0b0f1a73a28Benjamin Kramer return true; 3943c268434b332bbe57950d977633369bf5822d9554Chandler Carruth} 3944c268434b332bbe57950d977633369bf5822d9554Chandler Carruth 3945d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrainvoid Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr, 3946d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain bool isSubscript, bool AllowOnePastEnd) { 3947d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* EffectiveType = getElementType(BaseExpr); 3948d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain BaseExpr = BaseExpr->IgnoreParenCasts(); 3949d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain IndexExpr = IndexExpr->IgnoreParenCasts(); 3950d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 39513406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const ConstantArrayType *ArrayTy = 3952d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain Context.getAsConstantArrayType(BaseExpr->getType()); 39533406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (!ArrayTy) 3954a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 395535001ca261f895817916b468379b696d6d45959dChandler Carruth 39563406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (IndexExpr->isValueDependent()) 3957a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 39583406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth llvm::APSInt index; 3959d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (!IndexExpr->isIntegerConstantExpr(index, Context)) 3960a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 39618fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek 3962ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth const NamedDecl *ND = NULL; 3963ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 3964ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(DRE->getDecl()); 3965c268434b332bbe57950d977633369bf5822d9554Chandler Carruth if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 3966ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 3967ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 39689e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek if (index.isUnsigned() || !index.isNegative()) { 396925b3b849e3ad340b04442707038c86980035765bTed Kremenek llvm::APInt size = ArrayTy->getSize(); 397035001ca261f895817916b468379b696d6d45959dChandler Carruth if (!size.isStrictlyPositive()) 397135001ca261f895817916b468379b696d6d45959dChandler Carruth return; 3972d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 3973d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const Type* BaseType = getElementType(BaseExpr); 3974de5998f1d7dcecb777257ec932142d65de636eb8Nico Weber if (BaseType != EffectiveType) { 3975d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Make sure we're comparing apples to apples when comparing index to size 3976d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType); 3977d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t array_typesize = Context.getTypeSize(BaseType); 3978d10f4bc5a05ce0cdc1646dbb0f706bb9d3dfc0c5Kaelyn Uhrain // Handle ptrarith_typesize being zero, such as when casting to void* 397918f169770d9d3f826bad8f1359c8c5770c5ab16fKaelyn Uhrain if (!ptrarith_typesize) ptrarith_typesize = 1; 3980d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize != array_typesize) { 3981d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // There's a cast to a different size type involved 3982d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain uint64_t ratio = array_typesize / ptrarith_typesize; 3983d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // TODO: Be smarter about handling cases where array_typesize is not a 3984d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // multiple of ptrarith_typesize 3985d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (ptrarith_typesize * ratio == array_typesize) 3986d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain size *= llvm::APInt(size.getBitWidth(), ratio); 3987d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 3988d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 3989d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 39903406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (size.getBitWidth() > index.getBitWidth()) 39913406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth index = index.sext(size.getBitWidth()); 399225b3b849e3ad340b04442707038c86980035765bTed Kremenek else if (size.getBitWidth() < index.getBitWidth()) 399325b3b849e3ad340b04442707038c86980035765bTed Kremenek size = size.sext(index.getBitWidth()); 399425b3b849e3ad340b04442707038c86980035765bTed Kremenek 3995d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // For array subscripting the index must be less than size, but for pointer 3996d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // arithmetic also allow the index (offset) to be equal to size since 3997d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // computing the next address after the end of the array is legal and 3998d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // commonly done e.g. in C++ iterators and range-based for loops. 3999d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (AllowOnePastEnd ? index.sle(size) : index.slt(size)) 4000ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth return; 4001ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth 4002ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // Also don't warn for arrays of size 1 which are members of some 4003ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // structure. These are often used to approximate flexible arrays in C89 4004ba44712b0e578a851751e199bb75dbbff5836fedChandler Carruth // code. 4005d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (IsTailPaddedMemberArray(*this, size, ND)) 40068fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek return; 40073406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth 4008d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds; 4009d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (isSubscript) 4010d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_array_index_exceeds_bounds; 4011d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 4012d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 4013d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 4014d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << size.toString(10, true) 4015d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << (unsigned)size.getLimitedValue(~0U) 4016d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 40173406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth } else { 4018d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain unsigned DiagID = diag::warn_array_index_precedes_bounds; 4019d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (!isSubscript) { 4020d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagID = diag::warn_ptr_arith_precedes_bounds; 4021d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain if (index.isNegative()) index = -index; 4022d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 4023d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain 4024d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr, 4025d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(DiagID) << index.toString(10, true) 4026d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << IndexExpr->getSourceRange()); 4027a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek } 402835001ca261f895817916b468379b696d6d45959dChandler Carruth 402935001ca261f895817916b468379b696d6d45959dChandler Carruth if (ND) 4030d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain DiagRuntimeBehavior(ND->getLocStart(), BaseExpr, 4031d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain PDiag(diag::note_array_index_out_of_bounds) 4032d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain << ND->getDeclName()); 40333aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek} 40343aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek 40353aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) { 4036d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain int AllowOnePastEnd = 0; 4037d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain while (expr) { 4038d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = expr->IgnoreParenImpCasts(); 40393aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek switch (expr->getStmtClass()) { 4040d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::ArraySubscriptExprClass: { 4041d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr); 4042d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain CheckArrayAccess(ASE->getBase(), ASE->getIdx(), true, 4043d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd > 0); 40443aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 4045d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 4046d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case Stmt::UnaryOperatorClass: { 4047d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain // Only unwrap the * and & unary operators 4048d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain const UnaryOperator *UO = cast<UnaryOperator>(expr); 4049d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain expr = UO->getSubExpr(); 4050d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain switch (UO->getOpcode()) { 4051d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_AddrOf: 4052d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd++; 4053d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 4054d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain case UO_Deref: 4055d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain AllowOnePastEnd--; 4056d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 4057d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain default: 4058d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain return; 4059d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 4060d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain break; 4061d6c8865e6f306556b7eef972ceec2cc8ba026a0dKaelyn Uhrain } 40623aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek case Stmt::ConditionalOperatorClass: { 40633aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek const ConditionalOperator *cond = cast<ConditionalOperator>(expr); 40643aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *lhs = cond->getLHS()) 40653aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(lhs); 40663aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *rhs = cond->getRHS()) 40673aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(rhs); 40683aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 40693aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 40703aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek default: 40713aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 40723aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 4073f111d935722ed488144600cea5ed03a6b5069e8fPeter Collingbourne } 4074a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek} 4075f85e193739c953358c865005855253af4f68a497John McCall 4076f85e193739c953358c865005855253af4f68a497John McCall//===--- CHECK: Objective-C retain cycles ----------------------------------// 4077f85e193739c953358c865005855253af4f68a497John McCall 4078f85e193739c953358c865005855253af4f68a497John McCallnamespace { 4079f85e193739c953358c865005855253af4f68a497John McCall struct RetainCycleOwner { 4080f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner() : Variable(0), Indirect(false) {} 4081f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 4082f85e193739c953358c865005855253af4f68a497John McCall SourceRange Range; 4083f85e193739c953358c865005855253af4f68a497John McCall SourceLocation Loc; 4084f85e193739c953358c865005855253af4f68a497John McCall bool Indirect; 4085f85e193739c953358c865005855253af4f68a497John McCall 4086f85e193739c953358c865005855253af4f68a497John McCall void setLocsFrom(Expr *e) { 4087f85e193739c953358c865005855253af4f68a497John McCall Loc = e->getExprLoc(); 4088f85e193739c953358c865005855253af4f68a497John McCall Range = e->getSourceRange(); 4089f85e193739c953358c865005855253af4f68a497John McCall } 4090f85e193739c953358c865005855253af4f68a497John McCall }; 4091f85e193739c953358c865005855253af4f68a497John McCall} 4092f85e193739c953358c865005855253af4f68a497John McCall 4093f85e193739c953358c865005855253af4f68a497John McCall/// Consider whether capturing the given variable can possibly lead to 4094f85e193739c953358c865005855253af4f68a497John McCall/// a retain cycle. 4095f85e193739c953358c865005855253af4f68a497John McCallstatic bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) { 4096f85e193739c953358c865005855253af4f68a497John McCall // In ARC, it's captured strongly iff the variable has __strong 4097f85e193739c953358c865005855253af4f68a497John McCall // lifetime. In MRR, it's captured strongly if the variable is 4098f85e193739c953358c865005855253af4f68a497John McCall // __block and has an appropriate type. 4099f85e193739c953358c865005855253af4f68a497John McCall if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 4100f85e193739c953358c865005855253af4f68a497John McCall return false; 4101f85e193739c953358c865005855253af4f68a497John McCall 4102f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = var; 4103f85e193739c953358c865005855253af4f68a497John McCall owner.setLocsFrom(ref); 4104f85e193739c953358c865005855253af4f68a497John McCall return true; 4105f85e193739c953358c865005855253af4f68a497John McCall} 4106f85e193739c953358c865005855253af4f68a497John McCall 4107f85e193739c953358c865005855253af4f68a497John McCallstatic bool findRetainCycleOwner(Expr *e, RetainCycleOwner &owner) { 4108f85e193739c953358c865005855253af4f68a497John McCall while (true) { 4109f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParens(); 4110f85e193739c953358c865005855253af4f68a497John McCall if (CastExpr *cast = dyn_cast<CastExpr>(e)) { 4111f85e193739c953358c865005855253af4f68a497John McCall switch (cast->getCastKind()) { 4112f85e193739c953358c865005855253af4f68a497John McCall case CK_BitCast: 4113f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueBitCast: 4114f85e193739c953358c865005855253af4f68a497John McCall case CK_LValueToRValue: 411533e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall case CK_ARCReclaimReturnedObject: 4116f85e193739c953358c865005855253af4f68a497John McCall e = cast->getSubExpr(); 4117f85e193739c953358c865005855253af4f68a497John McCall continue; 4118f85e193739c953358c865005855253af4f68a497John McCall 4119f85e193739c953358c865005855253af4f68a497John McCall case CK_GetObjCProperty: { 4120f85e193739c953358c865005855253af4f68a497John McCall // Bail out if this isn't a strong explicit property. 4121f85e193739c953358c865005855253af4f68a497John McCall const ObjCPropertyRefExpr *pre = cast->getSubExpr()->getObjCProperty(); 4122f85e193739c953358c865005855253af4f68a497John McCall if (pre->isImplicitProperty()) return false; 4123f85e193739c953358c865005855253af4f68a497John McCall ObjCPropertyDecl *property = pre->getExplicitProperty(); 4124265941bc308d65cc270d5c4de5806f37ce405606John McCall if (!property->isRetaining() && 4125f85e193739c953358c865005855253af4f68a497John McCall !(property->getPropertyIvarDecl() && 4126f85e193739c953358c865005855253af4f68a497John McCall property->getPropertyIvarDecl()->getType() 4127f85e193739c953358c865005855253af4f68a497John McCall .getObjCLifetime() == Qualifiers::OCL_Strong)) 4128f85e193739c953358c865005855253af4f68a497John McCall return false; 4129f85e193739c953358c865005855253af4f68a497John McCall 4130f85e193739c953358c865005855253af4f68a497John McCall owner.Indirect = true; 4131f85e193739c953358c865005855253af4f68a497John McCall e = const_cast<Expr*>(pre->getBase()); 4132f85e193739c953358c865005855253af4f68a497John McCall continue; 4133f85e193739c953358c865005855253af4f68a497John McCall } 4134f85e193739c953358c865005855253af4f68a497John McCall 4135f85e193739c953358c865005855253af4f68a497John McCall default: 4136f85e193739c953358c865005855253af4f68a497John McCall return false; 4137f85e193739c953358c865005855253af4f68a497John McCall } 4138f85e193739c953358c865005855253af4f68a497John McCall } 4139f85e193739c953358c865005855253af4f68a497John McCall 4140f85e193739c953358c865005855253af4f68a497John McCall if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) { 4141f85e193739c953358c865005855253af4f68a497John McCall ObjCIvarDecl *ivar = ref->getDecl(); 4142f85e193739c953358c865005855253af4f68a497John McCall if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong) 4143f85e193739c953358c865005855253af4f68a497John McCall return false; 4144f85e193739c953358c865005855253af4f68a497John McCall 4145f85e193739c953358c865005855253af4f68a497John McCall // Try to find a retain cycle in the base. 4146f85e193739c953358c865005855253af4f68a497John McCall if (!findRetainCycleOwner(ref->getBase(), owner)) 4147f85e193739c953358c865005855253af4f68a497John McCall return false; 4148f85e193739c953358c865005855253af4f68a497John McCall 4149f85e193739c953358c865005855253af4f68a497John McCall if (ref->isFreeIvar()) owner.setLocsFrom(ref); 4150f85e193739c953358c865005855253af4f68a497John McCall owner.Indirect = true; 4151f85e193739c953358c865005855253af4f68a497John McCall return true; 4152f85e193739c953358c865005855253af4f68a497John McCall } 4153f85e193739c953358c865005855253af4f68a497John McCall 4154f85e193739c953358c865005855253af4f68a497John McCall if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) { 4155f85e193739c953358c865005855253af4f68a497John McCall VarDecl *var = dyn_cast<VarDecl>(ref->getDecl()); 4156f85e193739c953358c865005855253af4f68a497John McCall if (!var) return false; 4157f85e193739c953358c865005855253af4f68a497John McCall return considerVariable(var, ref, owner); 4158f85e193739c953358c865005855253af4f68a497John McCall } 4159f85e193739c953358c865005855253af4f68a497John McCall 4160f85e193739c953358c865005855253af4f68a497John McCall if (BlockDeclRefExpr *ref = dyn_cast<BlockDeclRefExpr>(e)) { 4161f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = ref->getDecl(); 4162f85e193739c953358c865005855253af4f68a497John McCall owner.setLocsFrom(ref); 4163f85e193739c953358c865005855253af4f68a497John McCall return true; 4164f85e193739c953358c865005855253af4f68a497John McCall } 4165f85e193739c953358c865005855253af4f68a497John McCall 4166f85e193739c953358c865005855253af4f68a497John McCall if (MemberExpr *member = dyn_cast<MemberExpr>(e)) { 4167f85e193739c953358c865005855253af4f68a497John McCall if (member->isArrow()) return false; 4168f85e193739c953358c865005855253af4f68a497John McCall 4169f85e193739c953358c865005855253af4f68a497John McCall // Don't count this as an indirect ownership. 4170f85e193739c953358c865005855253af4f68a497John McCall e = member->getBase(); 4171f85e193739c953358c865005855253af4f68a497John McCall continue; 4172f85e193739c953358c865005855253af4f68a497John McCall } 4173f85e193739c953358c865005855253af4f68a497John McCall 4174f85e193739c953358c865005855253af4f68a497John McCall // Array ivars? 4175f85e193739c953358c865005855253af4f68a497John McCall 4176f85e193739c953358c865005855253af4f68a497John McCall return false; 4177f85e193739c953358c865005855253af4f68a497John McCall } 4178f85e193739c953358c865005855253af4f68a497John McCall} 4179f85e193739c953358c865005855253af4f68a497John McCall 4180f85e193739c953358c865005855253af4f68a497John McCallnamespace { 4181f85e193739c953358c865005855253af4f68a497John McCall struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> { 4182f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor(ASTContext &Context, VarDecl *variable) 4183f85e193739c953358c865005855253af4f68a497John McCall : EvaluatedExprVisitor<FindCaptureVisitor>(Context), 4184f85e193739c953358c865005855253af4f68a497John McCall Variable(variable), Capturer(0) {} 4185f85e193739c953358c865005855253af4f68a497John McCall 4186f85e193739c953358c865005855253af4f68a497John McCall VarDecl *Variable; 4187f85e193739c953358c865005855253af4f68a497John McCall Expr *Capturer; 4188f85e193739c953358c865005855253af4f68a497John McCall 4189f85e193739c953358c865005855253af4f68a497John McCall void VisitDeclRefExpr(DeclRefExpr *ref) { 4190f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 4191f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 4192f85e193739c953358c865005855253af4f68a497John McCall } 4193f85e193739c953358c865005855253af4f68a497John McCall 4194f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockDeclRefExpr(BlockDeclRefExpr *ref) { 4195f85e193739c953358c865005855253af4f68a497John McCall if (ref->getDecl() == Variable && !Capturer) 4196f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 4197f85e193739c953358c865005855253af4f68a497John McCall } 4198f85e193739c953358c865005855253af4f68a497John McCall 4199f85e193739c953358c865005855253af4f68a497John McCall void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) { 4200f85e193739c953358c865005855253af4f68a497John McCall if (Capturer) return; 4201f85e193739c953358c865005855253af4f68a497John McCall Visit(ref->getBase()); 4202f85e193739c953358c865005855253af4f68a497John McCall if (Capturer && ref->isFreeIvar()) 4203f85e193739c953358c865005855253af4f68a497John McCall Capturer = ref; 4204f85e193739c953358c865005855253af4f68a497John McCall } 4205f85e193739c953358c865005855253af4f68a497John McCall 4206f85e193739c953358c865005855253af4f68a497John McCall void VisitBlockExpr(BlockExpr *block) { 4207f85e193739c953358c865005855253af4f68a497John McCall // Look inside nested blocks 4208f85e193739c953358c865005855253af4f68a497John McCall if (block->getBlockDecl()->capturesVariable(Variable)) 4209f85e193739c953358c865005855253af4f68a497John McCall Visit(block->getBlockDecl()->getBody()); 4210f85e193739c953358c865005855253af4f68a497John McCall } 4211f85e193739c953358c865005855253af4f68a497John McCall }; 4212f85e193739c953358c865005855253af4f68a497John McCall} 4213f85e193739c953358c865005855253af4f68a497John McCall 4214f85e193739c953358c865005855253af4f68a497John McCall/// Check whether the given argument is a block which captures a 4215f85e193739c953358c865005855253af4f68a497John McCall/// variable. 4216f85e193739c953358c865005855253af4f68a497John McCallstatic Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) { 4217f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 4218f85e193739c953358c865005855253af4f68a497John McCall 4219f85e193739c953358c865005855253af4f68a497John McCall e = e->IgnoreParenCasts(); 4220f85e193739c953358c865005855253af4f68a497John McCall BlockExpr *block = dyn_cast<BlockExpr>(e); 4221f85e193739c953358c865005855253af4f68a497John McCall if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable)) 4222f85e193739c953358c865005855253af4f68a497John McCall return 0; 4223f85e193739c953358c865005855253af4f68a497John McCall 4224f85e193739c953358c865005855253af4f68a497John McCall FindCaptureVisitor visitor(S.Context, owner.Variable); 4225f85e193739c953358c865005855253af4f68a497John McCall visitor.Visit(block->getBlockDecl()->getBody()); 4226f85e193739c953358c865005855253af4f68a497John McCall return visitor.Capturer; 4227f85e193739c953358c865005855253af4f68a497John McCall} 4228f85e193739c953358c865005855253af4f68a497John McCall 4229f85e193739c953358c865005855253af4f68a497John McCallstatic void diagnoseRetainCycle(Sema &S, Expr *capturer, 4230f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner &owner) { 4231f85e193739c953358c865005855253af4f68a497John McCall assert(capturer); 4232f85e193739c953358c865005855253af4f68a497John McCall assert(owner.Variable && owner.Loc.isValid()); 4233f85e193739c953358c865005855253af4f68a497John McCall 4234f85e193739c953358c865005855253af4f68a497John McCall S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle) 4235f85e193739c953358c865005855253af4f68a497John McCall << owner.Variable << capturer->getSourceRange(); 4236f85e193739c953358c865005855253af4f68a497John McCall S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner) 4237f85e193739c953358c865005855253af4f68a497John McCall << owner.Indirect << owner.Range; 4238f85e193739c953358c865005855253af4f68a497John McCall} 4239f85e193739c953358c865005855253af4f68a497John McCall 4240f85e193739c953358c865005855253af4f68a497John McCall/// Check for a keyword selector that starts with the word 'add' or 4241f85e193739c953358c865005855253af4f68a497John McCall/// 'set'. 4242f85e193739c953358c865005855253af4f68a497John McCallstatic bool isSetterLikeSelector(Selector sel) { 4243f85e193739c953358c865005855253af4f68a497John McCall if (sel.isUnarySelector()) return false; 4244f85e193739c953358c865005855253af4f68a497John McCall 42455f9e272e632e951b1efe824cd16acb4d96077930Chris Lattner StringRef str = sel.getNameForSlot(0); 4246f85e193739c953358c865005855253af4f68a497John McCall while (!str.empty() && str.front() == '_') str = str.substr(1); 4247f85e193739c953358c865005855253af4f68a497John McCall if (str.startswith("set") || str.startswith("add")) 4248f85e193739c953358c865005855253af4f68a497John McCall str = str.substr(3); 4249f85e193739c953358c865005855253af4f68a497John McCall else 4250f85e193739c953358c865005855253af4f68a497John McCall return false; 4251f85e193739c953358c865005855253af4f68a497John McCall 4252f85e193739c953358c865005855253af4f68a497John McCall if (str.empty()) return true; 4253f85e193739c953358c865005855253af4f68a497John McCall return !islower(str.front()); 4254f85e193739c953358c865005855253af4f68a497John McCall} 4255f85e193739c953358c865005855253af4f68a497John McCall 4256f85e193739c953358c865005855253af4f68a497John McCall/// Check a message send to see if it's likely to cause a retain cycle. 4257f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(ObjCMessageExpr *msg) { 4258f85e193739c953358c865005855253af4f68a497John McCall // Only check instance methods whose selector looks like a setter. 4259f85e193739c953358c865005855253af4f68a497John McCall if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector())) 4260f85e193739c953358c865005855253af4f68a497John McCall return; 4261f85e193739c953358c865005855253af4f68a497John McCall 4262f85e193739c953358c865005855253af4f68a497John McCall // Try to find a variable that the receiver is strongly owned by. 4263f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 4264f85e193739c953358c865005855253af4f68a497John McCall if (msg->getReceiverKind() == ObjCMessageExpr::Instance) { 4265f85e193739c953358c865005855253af4f68a497John McCall if (!findRetainCycleOwner(msg->getInstanceReceiver(), owner)) 4266f85e193739c953358c865005855253af4f68a497John McCall return; 4267f85e193739c953358c865005855253af4f68a497John McCall } else { 4268f85e193739c953358c865005855253af4f68a497John McCall assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance); 4269f85e193739c953358c865005855253af4f68a497John McCall owner.Variable = getCurMethodDecl()->getSelfDecl(); 4270f85e193739c953358c865005855253af4f68a497John McCall owner.Loc = msg->getSuperLoc(); 4271f85e193739c953358c865005855253af4f68a497John McCall owner.Range = msg->getSuperLoc(); 4272f85e193739c953358c865005855253af4f68a497John McCall } 4273f85e193739c953358c865005855253af4f68a497John McCall 4274f85e193739c953358c865005855253af4f68a497John McCall // Check whether the receiver is captured by any of the arguments. 4275f85e193739c953358c865005855253af4f68a497John McCall for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i) 4276f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner)) 4277f85e193739c953358c865005855253af4f68a497John McCall return diagnoseRetainCycle(*this, capturer, owner); 4278f85e193739c953358c865005855253af4f68a497John McCall} 4279f85e193739c953358c865005855253af4f68a497John McCall 4280f85e193739c953358c865005855253af4f68a497John McCall/// Check a property assign to see if it's likely to cause a retain cycle. 4281f85e193739c953358c865005855253af4f68a497John McCallvoid Sema::checkRetainCycles(Expr *receiver, Expr *argument) { 4282f85e193739c953358c865005855253af4f68a497John McCall RetainCycleOwner owner; 4283f85e193739c953358c865005855253af4f68a497John McCall if (!findRetainCycleOwner(receiver, owner)) 4284f85e193739c953358c865005855253af4f68a497John McCall return; 4285f85e193739c953358c865005855253af4f68a497John McCall 4286f85e193739c953358c865005855253af4f68a497John McCall if (Expr *capturer = findCapturingExpr(*this, argument, owner)) 4287f85e193739c953358c865005855253af4f68a497John McCall diagnoseRetainCycle(*this, capturer, owner); 4288f85e193739c953358c865005855253af4f68a497John McCall} 4289f85e193739c953358c865005855253af4f68a497John McCall 4290921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianbool Sema::checkUnsafeAssigns(SourceLocation Loc, 4291f85e193739c953358c865005855253af4f68a497John McCall QualType LHS, Expr *RHS) { 4292f85e193739c953358c865005855253af4f68a497John McCall Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime(); 4293f85e193739c953358c865005855253af4f68a497John McCall if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone) 4294921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return false; 4295921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // strip off any implicit cast added to get to the one arc-specific 4296921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 429733e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 4298f85e193739c953358c865005855253af4f68a497John McCall Diag(Loc, diag::warn_arc_retained_assign) 4299f85e193739c953358c865005855253af4f68a497John McCall << (LT == Qualifiers::OCL_ExplicitNone) 4300f85e193739c953358c865005855253af4f68a497John McCall << RHS->getSourceRange(); 4301921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return true; 4302921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4303921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 4304921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4305921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return false; 4306f85e193739c953358c865005855253af4f68a497John McCall} 4307f85e193739c953358c865005855253af4f68a497John McCall 4308921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanianvoid Sema::checkUnsafeExprAssigns(SourceLocation Loc, 4309921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Expr *LHS, Expr *RHS) { 4310921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian QualType LHSType = LHS->getType(); 4311921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (checkUnsafeAssigns(Loc, LHSType, RHS)) 4312921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4313921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime(); 4314921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian // FIXME. Check for other life times. 4315921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (LT != Qualifiers::OCL_None) 4316921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4317921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 4318921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (ObjCPropertyRefExpr *PRE = dyn_cast<ObjCPropertyRefExpr>(LHS)) { 4319921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (PRE->isImplicitProperty()) 4320921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4321921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian const ObjCPropertyDecl *PD = PRE->getExplicitProperty(); 4322921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (!PD) 4323921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4324921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian 4325921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian unsigned Attributes = PD->getPropertyAttributes(); 4326921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) 4327921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) { 432833e56f3273457bfa22c7c50bc46cf5a18216863dJohn McCall if (cast->getCastKind() == CK_ARCConsumeObject) { 4329921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian Diag(Loc, diag::warn_arc_retained_property_assign) 4330921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian << RHS->getSourceRange(); 4331921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian return; 4332921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4333921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian RHS = cast->getSubExpr(); 4334921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4335921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian } 4336921c14322977253a60dcb171f45e468c95fe41f8Fariborz Jahanian} 4337