SemaChecking.cpp revision e1b02e00d851389415a5b7a1398de26c382887c6
159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===// 259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// The LLVM Compiler Infrastructure 459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 50bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// This file is distributed under the University of Illinois Open Source 60bc735ffcfb223c0186419547abaa5c84482663eChris Lattner// License. See LICENSE.TXT for details. 759907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 101eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump// This file implements extra semantic analysis beyond what is enforced 1159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// by the C type system. 1259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner// 1359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner//===----------------------------------------------------------------------===// 1459907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 15e737f5041a36d0befb39ffeed8d50ba15916d3daDouglas Gregor#include "clang/Sema/Sema.h" 162d88708cbe4e4ec5e04e4acb6bd7f5be68557379John McCall#include "clang/Sema/SemaInternal.h" 17781472fe99a120098c631b0cbe33c89f8cef5e70John McCall#include "clang/Sema/ScopeInfo.h" 18826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek#include "clang/Analysis/Analyses/FormatString.h" 1959907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/AST/ASTContext.h" 20199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck#include "clang/AST/CharUnits.h" 21384aff8b94bb0d1ad6c5667b90621e5699815bb2John McCall#include "clang/AST/DeclCXX.h" 22c4a1dea2dc56bd1357ec91b829a0b9e68229a13eDaniel Dunbar#include "clang/AST/DeclObjC.h" 232324512285caac0332bbbc6e4cab6245d2a370a1Ted Kremenek#include "clang/AST/ExprCXX.h" 247ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek#include "clang/AST/ExprObjC.h" 25f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/DeclObjC.h" 26f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtCXX.h" 27f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "clang/AST/StmtObjC.h" 2859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner#include "clang/Lex/Preprocessor.h" 29f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/BitVector.h" 30f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump#include "llvm/ADT/STLExtras.h" 313bfc5f49e0e37e235bb0d33bcbcb36af9d1f84abTom Care#include "llvm/Support/raw_ostream.h" 32691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher#include "clang/Basic/TargetBuiltins.h" 3326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman#include "clang/Basic/TargetInfo.h" 347da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian#include "clang/Basic/ConvertUTF.h" 35a1f3dba77b7418575c1ff539ffa74ebaa068280cZhongxing Xu#include <limits> 3659907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnerusing namespace clang; 37781472fe99a120098c631b0cbe33c89f8cef5e70John McCallusing namespace sema; 3859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 3960800081361b0ffc114877b8abbc81cb57b4edf6Chris LattnerSourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL, 4060800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner unsigned ByteNo) const { 4108f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner return SL->getLocationOfByte(ByteNo, PP.getSourceManager(), 4208f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner PP.getLangOptions(), PP.getTargetInfo()); 4360800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner} 4408f92e3a5dead1f1ee656678a7f06e43279d6e50Chris Lattner 4560800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 464403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// CheckablePrintfAttr - does a function call have a "printf" attribute 474403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn/// and arguments that merit checking? 484403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynnbool Sema::CheckablePrintfAttr(const FormatAttr *Format, CallExpr *TheCall) { 494403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf") return true; 504403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (Format->getType() == "printf0") { 514403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn // printf0 allows null "format" string; if so don't check format/args 524403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn unsigned format_idx = Format->getFormatIdx() - 1; 534a2614e94672c47395abcde60518776fbebec589Sebastian Redl // Does the index refer to the implicit object argument? 544a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 554a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (format_idx == 0) 564a2614e94672c47395abcde60518776fbebec589Sebastian Redl return false; 574a2614e94672c47395abcde60518776fbebec589Sebastian Redl --format_idx; 584a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 594403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn if (format_idx < TheCall->getNumArgs()) { 604403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn Expr *Format = TheCall->getArg(format_idx)->IgnoreParenCasts(); 61efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!Format->isNullPointerConstant(Context, 62efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek Expr::NPC_ValueDependentIsNull)) 634403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return true; 644403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 654403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn } 664403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn return false; 674403a5e1f956fa86d515492dbe7c7a2817d8780dRyan Flynn} 6860800081361b0ffc114877b8abbc81cb57b4edf6Chris Lattner 698e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// Checks that a call expression's argument count is the desired number. 708e10f3b9cc1db43645bbc2999eb163af8997d468John McCall/// This is useful when doing custom type-checking. Returns true on error. 718e10f3b9cc1db43645bbc2999eb163af8997d468John McCallstatic bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) { 728e10f3b9cc1db43645bbc2999eb163af8997d468John McCall unsigned argCount = call->getNumArgs(); 738e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount == desiredArgCount) return false; 748e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 758e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (argCount < desiredArgCount) 768e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args) 778e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 788e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getSourceRange(); 798e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 808e10f3b9cc1db43645bbc2999eb163af8997d468John McCall // Highlight all the excess arguments. 818e10f3b9cc1db43645bbc2999eb163af8997d468John McCall SourceRange range(call->getArg(desiredArgCount)->getLocStart(), 828e10f3b9cc1db43645bbc2999eb163af8997d468John McCall call->getArg(argCount - 1)->getLocEnd()); 838e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 848e10f3b9cc1db43645bbc2999eb163af8997d468John McCall return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args) 858e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << 0 /*function call*/ << desiredArgCount << argCount 868e10f3b9cc1db43645bbc2999eb163af8997d468John McCall << call->getArg(1)->getSourceRange(); 878e10f3b9cc1db43645bbc2999eb163af8997d468John McCall} 888e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 8960d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 90d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders CarlssonSema::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 9160d7b3a319d84d688752be3870615ac0f111fb16John McCall ExprResult TheCallResult(Owned(TheCall)); 922def48394f6d48bde0dec2b514193c2b533265b5Douglas Gregor 93946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Find out if any arguments are required to be integer constant expressions. 94946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner unsigned ICEArguments = 0; 95946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ASTContext::GetBuiltinTypeError Error; 96946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner Context.GetBuiltinType(BuiltinID, Error, &ICEArguments); 97946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (Error != ASTContext::GE_None) 98946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments = 0; // Don't diagnose previously diagnosed errors. 99946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 100946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // If any arguments are required to be ICE's, check and diagnose. 101946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) { 102946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner // Skip arguments not required to be ICE's. 103946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if ((ICEArguments & (1 << ArgNo)) == 0) continue; 104946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 105946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner llvm::APSInt Result; 106946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 107946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner return true; 108946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner ICEArguments &= ~(1 << ArgNo); 109946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner } 110946928f48c96bddf3cfa126862f5ab69c2d904a0Chris Lattner 111d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson switch (BuiltinID) { 11230ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin___CFStringMakeConstantString: 113925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner assert(TheCall->getNumArgs() == 1 && 1141b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner "Wrong # arguments to builtin CFStringMakeConstantString"); 115690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner if (CheckObjCString(TheCall->getArg(0))) 1160eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 117d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 11849ff7a1c8c67d56e62d3b4627463b705c0d5008cTed Kremenek case Builtin::BI__builtin_stdarg_start: 11930ce344307f8a8b00054021307015571f83c7364Chris Lattner case Builtin::BI__builtin_va_start: 1200eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinVAStart(TheCall)) 1210eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 122d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1231b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreater: 1241b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isgreaterequal: 1251b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isless: 1261b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessequal: 1271b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_islessgreater: 1281b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner case Builtin::BI__builtin_isunordered: 1290eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinUnorderedCompare(TheCall)) 1300eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 131d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 132e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer case Builtin::BI__builtin_fpclassify: 133e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer if (SemaBuiltinFPClassification(TheCall, 6)) 134e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer return ExprError(); 135e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer break; 1369ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isfinite: 1379ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf: 1389ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isinf_sign: 1399ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnan: 1409ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman case Builtin::BI__builtin_isnormal: 1413b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (SemaBuiltinFPClassification(TheCall, 1)) 1429ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return ExprError(); 1439ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman break; 144d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman case Builtin::BI__builtin_shufflevector: 1450eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return SemaBuiltinShuffleVector(TheCall); 1460eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // TheCall will be freed by the smart pointer here, but that's fine, since 1470eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl // SemaBuiltinShuffleVector guts it, but then doesn't release it. 1484493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar case Builtin::BI__builtin_prefetch: 1490eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinPrefetch(TheCall)) 1500eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 151d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 152d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar case Builtin::BI__builtin_object_size: 1530eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (SemaBuiltinObjectSize(TheCall)) 1540eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(); 155d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 156d875fed28578835de89cd407e9db4be788596d7cEli Friedman case Builtin::BI__builtin_longjmp: 157d875fed28578835de89cd407e9db4be788596d7cEli Friedman if (SemaBuiltinLongjmp(TheCall)) 158d875fed28578835de89cd407e9db4be788596d7cEli Friedman return ExprError(); 159d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson break; 1608e10f3b9cc1db43645bbc2999eb163af8997d468John McCall 1618e10f3b9cc1db43645bbc2999eb163af8997d468John McCall case Builtin::BI__builtin_classify_type: 1628e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1638e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 1648e10f3b9cc1db43645bbc2999eb163af8997d468John McCall break; 16575c29a012793292ff4578015a9113bf086156d7fChris Lattner case Builtin::BI__builtin_constant_p: 1668e10f3b9cc1db43645bbc2999eb163af8997d468John McCall if (checkArgCount(*this, TheCall, 1)) return true; 1678e10f3b9cc1db43645bbc2999eb163af8997d468John McCall TheCall->setType(Context.IntTy); 16875c29a012793292ff4578015a9113bf086156d7fChris Lattner break; 1695caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: 1705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: 1715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: 1725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: 1735caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: 1745caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_add_and_fetch: 1755caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_sub_and_fetch: 1765caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_and_and_fetch: 1775caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_or_and_fetch: 1785caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_xor_and_fetch: 1795caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 1805caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 1815caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_test_and_set: 1825caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 183d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return SemaBuiltinAtomicOverloaded(move(TheCallResult)); 18426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 18526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 18626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // Since the target specific builtins for each arch overlap, only check those 18726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman // of the arch we are compiling for. 18826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (BuiltinID >= Builtin::FirstTSBuiltin) { 18926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman switch (Context.Target.getTriple().getArch()) { 19026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::arm: 19126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman case llvm::Triple::thumb: 19226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall)) 19326a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return ExprError(); 19426a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 19526a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman default: 19626a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman break; 19726a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 19826a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman } 19926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 20026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return move(TheCallResult); 20126a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman} 20226a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman 20361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman// Get the valid immediate range for the specified NEON type code. 20461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begemanstatic unsigned RFT(unsigned t, bool shift = false) { 20561eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman bool quad = t & 0x10; 20661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 20761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman switch (t & 0x7) { 20861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 0: // i8 209d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 7 : (8 << (int)quad) - 1; 21061eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 1: // i16 211d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 15 : (4 << (int)quad) - 1; 21261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 2: // i32 213d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 31 : (2 << (int)quad) - 1; 21461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 3: // i64 215d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return shift ? 63 : (1 << (int)quad) - 1; 21661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 4: // f32 21761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift float types!"); 218d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (2 << (int)quad) - 1; 21961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 5: // poly8 22042499f94069c73d7a9c82da98a4245ea9fe2c526Bob Wilson return shift ? 7 : (8 << (int)quad) - 1; 22161eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 6: // poly16 22242499f94069c73d7a9c82da98a4245ea9fe2c526Bob Wilson return shift ? 15 : (4 << (int)quad) - 1; 22361eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman case 7: // float16 22461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman assert(!shift && "cannot shift float types!"); 225d69ec16b1b03b4a97c571ff14f15769fe13c1e5aNate Begeman return (4 << (int)quad) - 1; 22661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman } 22761eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman return 0; 22861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman} 22961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman 23026a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begemanbool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { 2311c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman llvm::APSInt Result; 2321c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2330d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned mask = 0; 23461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned TV = 0; 2351c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman switch (BuiltinID) { 236a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_OVERLOAD_CHECK 237a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 238a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_OVERLOAD_CHECK 2391c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman } 2401c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2410d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which are overloaded on vector element type, validate 2420d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // the immediate which specifies which variant to emit. 2430d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (mask) { 2440d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned ArgNo = TheCall->getNumArgs()-1; 2450d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, ArgNo, Result)) 2460d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 2470d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 24861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman TV = Result.getLimitedValue(32); 24961eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if ((TV > 31) || (mask & (1 << TV)) == 0) 2500d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code) 2510d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman << TheCall->getArg(ArgNo)->getSourceRange(); 2520d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman } 2531c2a88cfaeb11227d3a6bf7204207e0c8cf6de6fNate Begeman 2540d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // For NEON intrinsics which take an immediate value as part of the 2550d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman // instruction, range check them here. 25661eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman unsigned i = 0, l = 0, u = 0; 2570d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman switch (BuiltinID) { 2580d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman default: return false; 259bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break; 260bb37f50c2d0d72e1fa5b349d5f6a11fdc5acb86eNate Begeman case ARM::BI__builtin_arm_usat: i = 1; u = 31; break; 26199c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_f: 26299c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break; 263a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#define GET_NEON_IMMEDIATE_CHECK 264a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#include "clang/Basic/arm_neon.inc" 265a23326b5c244a03bf61ebb86db60a777ea26f926Nate Begeman#undef GET_NEON_IMMEDIATE_CHECK 2660d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman }; 2670d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 26861eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Check that the immediate argument is actually a constant. 2690d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman if (SemaBuiltinConstantArg(TheCall, i, Result)) 2700d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return true; 2710d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 27261eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman // Range check against the upper/lower values for this isntruction. 2730d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman unsigned Val = Result.getZExtValue(); 27461eecf5aea018ea65c9ab0bccacd2996b15c632dNate Begeman if (Val < l || Val > (u + l)) 2750d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 276476d8b863cb65b2b5833235d97315cdb46e6f5aaBenjamin Kramer << l << u+l << TheCall->getArg(i)->getSourceRange(); 2770d15c5321a11a5fee53b17ca8e9e0d72d6192b23Nate Begeman 27899c40bb13b523d58d7aeb6446e4f486d6918ca58Nate Begeman // FIXME: VFP Intrinsics should error if VFP not present. 27926a31428f130b66f61834d1b4d1cf72f590f70b9Nate Begeman return false; 280d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson} 281d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 282d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// CheckFunctionCall - Check a direct function call for various correctness 283d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson/// and safety properties not strictly enforced by the C type system. 284d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall) { 285d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // Get the IdentifierInfo* for the called function. 286d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson IdentifierInfo *FnInfo = FDecl->getIdentifier(); 287de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 288d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // None of the checks below are needed for functions that don't have 289d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson // simple names (e.g., C++ conversion functions). 290d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson if (!FnInfo) 291d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 2921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 293de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // FIXME: This mechanism should be abstracted to be less fragile and 294de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // more efficient. For example, just map function ids to custom 295de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar // handlers. 296de45428f923b38d80407dbb9ede0df504256f9f6Daniel Dunbar 297c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek // Printf and scanf checking. 298c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<FormatAttr> 299c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<FormatAttr>(), 300c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<FormatAttr>(); i != e ; ++i) { 301c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek 302c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek const FormatAttr *Format = *i; 303826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 304826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (b || CheckablePrintfAttr(Format, TheCall)) { 3053d692df4b9c58895f9843b03543ec57447c93679Ted Kremenek bool HasVAListArg = Format->getFirstArg() == 0; 306826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, 307826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Format->getFormatIdx() - 1, 308826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, 309826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek !b); 3103c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor } 31159907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner } 3121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 313c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek for (specific_attr_iterator<NonNullAttr> 314c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek i = FDecl->specific_attr_begin<NonNullAttr>(), 315c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek e = FDecl->specific_attr_end<NonNullAttr>(); i != e; ++i) { 316909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky CheckNonNullArguments(*i, TheCall->getArgs(), 317909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky TheCall->getCallee()->getLocStart()); 318c82faca0be59b072b38bed375e21bd24f1f72647Ted Kremenek } 3190eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 320d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 32171993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson} 32271993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 323d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlssonbool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall) { 324725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian // Printf checking. 32540b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis const FormatAttr *Format = NDecl->getAttr<FormatAttr>(); 326725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Format) 327d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3281eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 329725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian const VarDecl *V = dyn_cast<VarDecl>(NDecl); 330725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!V) 331d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 333725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian QualType Ty = V->getType(); 334725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian if (!Ty->isBlockPointerType()) 335d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 337826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const bool b = Format->getType() == "scanf"; 338826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!b && !CheckablePrintfAttr(Format, TheCall)) 339d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 3401eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 341d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson bool HasVAListArg = Format->getFirstArg() == 0; 342826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfScanfArguments(TheCall, HasVAListArg, Format->getFormatIdx() - 1, 343826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg ? 0 : Format->getFirstArg() - 1, !b); 344d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson 345d406bf0e8c17012110a8476d03c6f9a97b56ecf7Anders Carlsson return false; 346725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian} 347725165f2846bd37d3aaf863747fa30126992085eFariborz Jahanian 3485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// SemaBuiltinAtomicOverloaded - We have a call to a function like 3495caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// __sync_fetch_and_add, which is an overloaded function based on the pointer 3505caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// type of its first argument. The main ActOnCallExpr routines have already 3515caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// promoted the types of arguments because all of these calls are prototyped as 3525caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// void(...). 3535caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// 3545caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// This function goes through and does final semantic checking for these 3555caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner/// builtins, 35660d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult 35760d7b3a319d84d688752be3870615ac0f111fb16John McCallSema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) { 358d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth CallExpr *TheCall = (CallExpr *)TheCallResult.get(); 3595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 3605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 3615caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 3625caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Ensure that we have at least one argument to do type inference from. 363d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1) { 364d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 365d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1 << TheCall->getNumArgs() 366d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 367d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 368d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 3691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 3705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Inspect the first argument of the atomic builtin. This should always be 3715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // a pointer type, whose element is an integral scalar or pointer type. 3725caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Because it is a pointer type, we don't have to worry about any implicit 3735caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // casts here. 374d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth // FIXME: We don't allow floating point scalars as input. 3755caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *FirstArg = TheCall->getArg(0); 376d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (!FirstArg->getType()->isPointerType()) { 377d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer) 378d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 379d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 380d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 3811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 382d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth QualType ValType = 383d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth FirstArg->getType()->getAs<PointerType>()->getPointeeType(); 384dd5fa7a21ca9db9d620001ca977681a1b724e3feChris Lattner if (!ValType->isIntegerType() && !ValType->isAnyPointerType() && 385d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth !ValType->isBlockPointerType()) { 386d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr) 387d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 388d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 389d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 3905caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 3918d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // The majority of builtins return a value, but a few have special return 3928d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth // types, so allow them to override appropriately below. 3938d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth QualType ResultType = ValType; 3948d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth 3955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // We need to figure out which concrete builtin this maps onto. For example, 3965caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add with a 2 byte object turns into 3975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // __sync_fetch_and_add_2. 3985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner#define BUILTIN_ROW(x) \ 3995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \ 4005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Builtin::BI##x##_8, Builtin::BI##x##_16 } 4011eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner static const unsigned BuiltinIndices[][5] = { 4035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_add), 4045caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_sub), 4055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_or), 4065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_and), 4075caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_fetch_and_xor), 4081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4095caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_add_and_fetch), 4105caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_sub_and_fetch), 4115caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_and_and_fetch), 4125caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_or_and_fetch), 4135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_xor_and_fetch), 4141eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_val_compare_and_swap), 4165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_bool_compare_and_swap), 4175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_test_and_set), 4185caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner BUILTIN_ROW(__sync_lock_release) 4195caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner }; 4201eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump#undef BUILTIN_ROW 4211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4225caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Determine the index of the size. 4235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned SizeIndex; 424199c3d6cd16aebbb9c7f0d42af9d922c9628bf70Ken Dyck switch (Context.getTypeSizeInChars(ValType).getQuantity()) { 4255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 1: SizeIndex = 0; break; 4265caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 2: SizeIndex = 1; break; 4275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 4: SizeIndex = 2; break; 4285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 8: SizeIndex = 3; break; 4295caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case 16: SizeIndex = 4; break; 4305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: 431d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size) 432d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << FirstArg->getType() << FirstArg->getSourceRange(); 433d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 4345caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 4351eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4365caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Each of these builtins has one pointer argument, followed by some number of 4375caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // values (0, 1 or 2) followed by a potentially empty varags list of stuff 4385caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // that we ignore. Find out which row of BuiltinIndices to read from as well 4395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // as the number of fixed args. 4407814e6d6645d587891293d59ecf6576defcfac92Douglas Gregor unsigned BuiltinID = FDecl->getBuiltinID(); 4415caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner unsigned BuiltinIndex, NumFixed = 1; 4425caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner switch (BuiltinID) { 4435caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner default: assert(0 && "Unknown overloaded atomic builtin!"); 4445caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_add: BuiltinIndex = 0; break; 4455caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_sub: BuiltinIndex = 1; break; 4465caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_or: BuiltinIndex = 2; break; 4475caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_and: BuiltinIndex = 3; break; 4485caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_fetch_and_xor: BuiltinIndex = 4; break; 4491eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4507eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_add_and_fetch: BuiltinIndex = 5; break; 4517eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_sub_and_fetch: BuiltinIndex = 6; break; 4527eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_and_and_fetch: BuiltinIndex = 7; break; 4537eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_or_and_fetch: BuiltinIndex = 8; break; 4547eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_xor_and_fetch: BuiltinIndex = 9; break; 4551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4565caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_val_compare_and_swap: 4577eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 10; 4585caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 4595caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 4605caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_bool_compare_and_swap: 4617eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 11; 4625caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 2; 4638d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.BoolTy; 4645caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 4657eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar case Builtin::BI__sync_lock_test_and_set: BuiltinIndex = 12; break; 4665caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner case Builtin::BI__sync_lock_release: 4677eff7c4153faf45b19b5919ef409ee5f6794eb25Daniel Dunbar BuiltinIndex = 13; 4685caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner NumFixed = 0; 4698d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth ResultType = Context.VoidTy; 4705caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner break; 4715caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 4721eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4735caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Now that we know how many fixed arguments we expect, first check that we 4745caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // have at least that many. 475d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth if (TheCall->getNumArgs() < 1+NumFixed) { 476d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least) 477d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << 0 << 1+NumFixed << TheCall->getNumArgs() 478d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth << TheCall->getCallee()->getSourceRange(); 479d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 480d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth } 4811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 482e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // Get the decl for the concrete builtin from this, we can tell what the 483e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner // concrete integer type we should convert to is. 484e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex]; 485e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID); 486e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner IdentifierInfo *NewBuiltinII = PP.getIdentifierInfo(NewBuiltinName); 4871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump FunctionDecl *NewBuiltinDecl = 488e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner cast<FunctionDecl>(LazilyCreateBuiltin(NewBuiltinII, NewBuiltinID, 489e7ac0a94f1dee3fae9292eb8372962b6d70b3e0dChris Lattner TUScope, false, DRE->getLocStart())); 490d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 491f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // The first argument --- the pointer --- has a fixed type; we 492f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // deduce the types of the rest of the arguments accordingly. Walk 493f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall // the remaining arguments, converting them to the deduced value type. 4945caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner for (unsigned i = 0; i != NumFixed; ++i) { 4955caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *Arg = TheCall->getArg(i+1); 4961eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 4975caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // If the argument is an implicit cast, then there was a promotion due to 4985caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // "...", just remove it now. 4995caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) { 5005caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Arg = ICE->getSubExpr(); 5015caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner ICE->setSubExpr(0); 5025caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner TheCall->setArg(i+1, Arg); 5035caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 5041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5055caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // GCC does an implicit conversion to the pointer or integer ValType. This 5065caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // can fail in some cases (1i -> int**), check for this error case now. 507daa8e4e888758d55a7a759dd4a91b83921cef222John McCall CastKind Kind = CK_Invalid; 508f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall ExprValueKind VK = VK_RValue; 509f871d0cc377a1367b519a6cce26be74607566ebaJohn McCall CXXCastPath BasePath; 510f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall if (CheckCastTypes(Arg->getSourceRange(), ValType, Arg, Kind, VK, BasePath)) 511d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return ExprError(); 5121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5135caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Okay, we have something that *can* be converted to the right type. Check 5145caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // to see if there is a potentially weird extension going on here. This can 5155caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // happen when you do an atomic operation on something like an char* and 5165caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // pass in 42. The 42 gets converted to char. This is even more strange 5175caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // for things like 45.123 -> char, etc. 5181eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // FIXME: Do this check. 519f89e55ab1bfb3ea997f8b02997c611a02254eb2dJohn McCall ImpCastExprToType(Arg, ValType, Kind, VK, &BasePath); 5205caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner TheCall->setArg(i+1, Arg); 5215caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner } 5221eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5235caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Switch the DeclRefExpr to refer to the new decl. 5245caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DRE->setDecl(NewBuiltinDecl); 5255caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner DRE->setType(NewBuiltinDecl->getType()); 5261eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5275caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // Set the callee in the CallExpr. 5285caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner // FIXME: This leaks the original parens and implicit casts. 5295caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner Expr *PromotedCall = DRE; 5305caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner UsualUnaryConversions(PromotedCall); 5315caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner TheCall->setCallee(PromotedCall); 5321eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 533db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // Change the result type of the call to match the original value type. This 534db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // is arbitrary, but the codegen for these builtins ins design to handle it 535db4325b098eff5e9e660db19f0148423fb21f27fChandler Carruth // gracefully. 5368d13d221cf7c1657404c611efaadf3ac19d899b3Chandler Carruth TheCall->setType(ResultType); 537d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth 538d201457cc781f1b13d0f4b1268ff934e6004cbffChandler Carruth return move(TheCallResult); 5395caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner} 5405caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 5415caa370ea6f70bd3e7e4a9cc3b69ac1a849c8534Chris Lattner 542690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattner/// CheckObjCString - Checks that the argument to the builtin 54371993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson/// CFString constructor is correct 544fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// Note: It might also make sense to do the UTF-16 conversion here (would 545fd942628abfe30e30427875db953222ae99b4325Steve Naroff/// simplify the backend). 546690398188ea5b428f06aa13c7d4ce6eb741ad4f9Chris Lattnerbool Sema::CheckObjCString(Expr *Arg) { 54756f349400c5932a196509c0480ff6f99a9a0b48fChris Lattner Arg = Arg->IgnoreParenCasts(); 54871993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson StringLiteral *Literal = dyn_cast<StringLiteral>(Arg); 54971993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson 55071993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson if (!Literal || Literal->isWide()) { 551fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant) 552fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << Arg->getSourceRange(); 5539cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return true; 55471993dd85eed9cc42c6b2fa61ee5c53026b74817Anders Carlsson } 5551eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 5567da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Literal->containsNonAsciiOrNull()) { 5577da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian llvm::StringRef String = Literal->getString(); 5587da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian unsigned NumBytes = String.size(); 5597da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian llvm::SmallVector<UTF16, 128> ToBuf(NumBytes); 5607da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian const UTF8 *FromPtr = (UTF8 *)String.data(); 5617da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian UTF16 *ToPtr = &ToBuf[0]; 5627da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian 5637da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes, 5647da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian &ToPtr, ToPtr + NumBytes, 5657da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian strictConversion); 5667da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian // Check for conversion failure. 5677da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian if (Result != conversionOK) 5687da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian Diag(Arg->getLocStart(), 5697da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian diag::warn_cfstring_truncated) << Arg->getSourceRange(); 5707da71020b97c69b95831bd03d35e8e8404bfdea0Fariborz Jahanian } 5719cdc4d3834f203dcde3ff274b8928e4620a914d5Anders Carlsson return false; 57259907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner} 57359907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner 574c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity. 575c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner/// Emit an error and return true on failure, return false on success. 576925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinVAStart(CallExpr *TheCall) { 577925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *Fn = TheCall->getCallee(); 578925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) { 5792c21a073525cdfa68e4439b7af551385dc2796abChris Lattner Diag(TheCall->getArg(2)->getLocStart(), 580fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 581ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 582ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << Fn->getSourceRange() 5831eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(2)->getLocStart(), 584fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 58530ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 58630ce344307f8a8b00054021307015571f83c7364Chris Lattner } 58756f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 58856f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman if (TheCall->getNumArgs() < 2) { 589d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher return Diag(TheCall->getLocEnd(), 590d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 591d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs(); 59256f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman } 59356f20ae1010aa71defd7572f660b41288c56cdd1Eli Friedman 594c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner // Determine whether the current function is variadic or not. 5959ea9bdbc14374f7bacdb50d3e52c664ff12150ffDouglas Gregor BlockScopeInfo *CurBlock = getCurBlock(); 596c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner bool isVariadic; 597cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 598c71a4915ca216847599d03cab4ed1c5086b0eb43John McCall isVariadic = CurBlock->TheDecl->isVariadic(); 5999498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else if (FunctionDecl *FD = getCurFunctionDecl()) 6009498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek isVariadic = FD->isVariadic(); 6019498d388810d284d3970aef0d69fa4d069fd6cafTed Kremenek else 60253d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis isVariadic = getCurMethodDecl()->isVariadic(); 6031eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 604c27c665c88b49dfb212aedc7bab8b9bf67658b9eChris Lattner if (!isVariadic) { 60530ce344307f8a8b00054021307015571f83c7364Chris Lattner Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function); 60630ce344307f8a8b00054021307015571f83c7364Chris Lattner return true; 60730ce344307f8a8b00054021307015571f83c7364Chris Lattner } 6081eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 60930ce344307f8a8b00054021307015571f83c7364Chris Lattner // Verify that the second argument to the builtin is the last argument of the 61030ce344307f8a8b00054021307015571f83c7364Chris Lattner // current function or method. 61130ce344307f8a8b00054021307015571f83c7364Chris Lattner bool SecondArgIsLastNamedArgument = false; 612e2c14103dec39cbd24dac9d7b3e91277b109c14fAnders Carlsson const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts(); 6131eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 61488cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) { 61588cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) { 61630ce344307f8a8b00054021307015571f83c7364Chris Lattner // FIXME: This isn't correct for methods (results in bogus warning). 61730ce344307f8a8b00054021307015571f83c7364Chris Lattner // Get the last formal in the current function. 61888cf226caee50956ef47edd4d44cf7b80703a26cAnders Carlsson const ParmVarDecl *LastArg; 619cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff if (CurBlock) 620cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff LastArg = *(CurBlock->TheDecl->param_end()-1); 621cd9c51433c06705645d1ee5a13da3c9a72d7d025Steve Naroff else if (FunctionDecl *FD = getCurFunctionDecl()) 622371f258e61e1365b951b17931a3c5ac1530fd1a0Chris Lattner LastArg = *(FD->param_end()-1); 62330ce344307f8a8b00054021307015571f83c7364Chris Lattner else 62453d0ea5f5bfa647ec23418bf3a3b7c183b51e4bdArgyrios Kyrtzidis LastArg = *(getCurMethodDecl()->param_end()-1); 62530ce344307f8a8b00054021307015571f83c7364Chris Lattner SecondArgIsLastNamedArgument = PV == LastArg; 62630ce344307f8a8b00054021307015571f83c7364Chris Lattner } 62730ce344307f8a8b00054021307015571f83c7364Chris Lattner } 6281eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 62930ce344307f8a8b00054021307015571f83c7364Chris Lattner if (!SecondArgIsLastNamedArgument) 6301eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(1)->getLocStart(), 63130ce344307f8a8b00054021307015571f83c7364Chris Lattner diag::warn_second_parameter_of_va_start_not_last_named_argument); 63230ce344307f8a8b00054021307015571f83c7364Chris Lattner return false; 6336cfda23b3768f93a6eb0b2a9135c8334a20125bbEli Friedman} 63430ce344307f8a8b00054021307015571f83c7364Chris Lattner 6351b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and 6361b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner/// friends. This is declared to take (...), so we have to check everything. 637925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattnerbool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) { 638925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() < 2) 6392c21a073525cdfa68e4439b7af551385dc2796abChris Lattner return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 640d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << 2 << TheCall->getNumArgs()/*function call*/; 641925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (TheCall->getNumArgs() > 2) 6421eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(TheCall->getArg(2)->getLocStart(), 643fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_too_many_args) 644ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 2 << TheCall->getNumArgs() 645fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(TheCall->getArg(2)->getLocStart(), 646fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner (*(TheCall->arg_end()-1))->getLocEnd()); 6471eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 648925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *OrigArg0 = TheCall->getArg(0); 649925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner Expr *OrigArg1 = TheCall->getArg(1); 650cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 6511b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // Do standard promotions between the two arguments, returning their common 6521b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // type. 653925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false); 654403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar 655403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // Make sure any conversions are pushed back into the call; this is 656403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // type safe since unordered compare builtins are declared as "_Bool 657403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar // foo(...)". 658403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar TheCall->setArg(0, OrigArg0); 659403bc2bd9edffe51d73776643fa87696c9417678Daniel Dunbar TheCall->setArg(1, OrigArg1); 6601eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 661cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (OrigArg0->isTypeDependent() || OrigArg1->isTypeDependent()) 662cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 663cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 6641b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // If the common type isn't a real floating type, then the arguments were 6651b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner // invalid for this operation. 6661b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner if (!Res->isRealFloatingType()) 6671eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg0->getLocStart(), 668fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_typecheck_call_invalid_ordered_compare) 669d162584991885ab004a02573a73ce06422b921fcChris Lattner << OrigArg0->getType() << OrigArg1->getType() 670fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << SourceRange(OrigArg0->getLocStart(), OrigArg1->getLocEnd()); 6711eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 6721b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner return false; 6731b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner} 6741b9a0793955070738cac6f04b5abe9496be9b317Chris Lattner 675e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like 676e771a7ac11fb27f0e734e5de4d858f2c268895e5Benjamin Kramer/// __builtin_isnan and friends. This is declared to take (...), so we have 6773b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// to check everything. We expect the last argument to be a floating point 6783b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer/// value. 6793b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramerbool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) { 6803b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() < NumArgs) 6819ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args) 682d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << 0 << NumArgs << TheCall->getNumArgs()/*function call*/; 6833b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer if (TheCall->getNumArgs() > NumArgs) 6843b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer return Diag(TheCall->getArg(NumArgs)->getLocStart(), 6859ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_too_many_args) 686ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << NumArgs << TheCall->getNumArgs() 6873b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer << SourceRange(TheCall->getArg(NumArgs)->getLocStart(), 6889ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman (*(TheCall->arg_end()-1))->getLocEnd()); 6899ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 6903b1e26b708e8d00d4ba10ff857201bae2aff6baeBenjamin Kramer Expr *OrigArg = TheCall->getArg(NumArgs-1); 6911eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 6929ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (OrigArg->isTypeDependent()) 6939ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 6949ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 69581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // This operation requires a non-_Complex floating-point number. 6969ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman if (!OrigArg->getType()->isRealFloatingType()) 6971eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return Diag(OrigArg->getLocStart(), 6989ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman diag::err_typecheck_call_invalid_unary_fp) 6999ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman << OrigArg->getType() << OrigArg->getSourceRange(); 7001eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 70181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner // If this is an implicit conversion from float -> double, remove it. 70281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) { 70381368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Expr *CastArg = Cast->getSubExpr(); 70481368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) { 70581368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) && 70681368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner "promotion from float to double is the only expected cast here"); 70781368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner Cast->setSubExpr(0); 70881368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner TheCall->setArg(NumArgs-1, CastArg); 70981368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner OrigArg = CastArg; 71081368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 71181368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner } 71281368fbfd6d57150f66c993dc9041d62a7a32c4fChris Lattner 7139ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman return false; 7149ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman} 7159ac6f62a77be5b281a7ddc24a16669b457ac47c2Eli Friedman 716d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector. 717d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman// This is declared to take (...), so we have to check everything. 71860d7b3a319d84d688752be3870615ac0f111fb16John McCallExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) { 71937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() < 2) 7200eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocEnd(), 721d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher diag::err_typecheck_call_too_few_args_at_least) 72237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << 0 /*function call*/ << 2 << TheCall->getNumArgs() 723d77b9a29651d748f0e30a8dad8969635fc04f725Eric Christopher << TheCall->getSourceRange()); 724d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 72537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Determine which of the following types of shufflevector we're checking: 72637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 1) unary, vector mask: (lhs, mask) 72737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 2) binary, vector mask: (lhs, rhs, mask) 72837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // 3) binary, scalar mask: (lhs, rhs, index, ..., index) 72937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType resType = TheCall->getArg(0)->getType(); 73037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numElements = 0; 73137b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 732cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (!TheCall->getArg(0)->isTypeDependent() && 733cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor !TheCall->getArg(1)->isTypeDependent()) { 73437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType LHSType = TheCall->getArg(0)->getType(); 73537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType RHSType = TheCall->getArg(1)->getType(); 73637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 73737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!LHSType->isVectorType() || !RHSType->isVectorType()) { 738cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_non_vector) 7391eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 740cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 741cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 742cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 74337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 74437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numElements = LHSType->getAs<VectorType>()->getNumElements(); 74537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman unsigned numResElements = TheCall->getNumArgs() - 2; 74637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman 74737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // Check to see if we have a call with 2 vector arguments, the unary shuffle 74837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // with mask. If so, verify that RHS is an integer vector type with the 74937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman // same number of elts as lhs. 75037b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (TheCall->getNumArgs() == 2) { 751f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (!RHSType->hasIntegerRepresentation() || 75237b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman RHSType->getAs<VectorType>()->getNumElements() != numElements) 75337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 75437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << SourceRange(TheCall->getArg(1)->getLocStart(), 75537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman TheCall->getArg(1)->getLocEnd()); 75637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman numResElements = numElements; 75737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } 75837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) { 759cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor Diag(TheCall->getLocStart(), diag::err_shufflevector_incompatible_vector) 7601eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump << SourceRange(TheCall->getArg(0)->getLocStart(), 761cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(1)->getLocEnd()); 762cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return ExprError(); 76337b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman } else if (numElements != numResElements) { 76437b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman QualType eltType = LHSType->getAs<VectorType>()->getElementType(); 765788b0fd67e1992f23555454efcdb16a19dfefac3Chris Lattner resType = Context.getVectorType(eltType, numResElements, 766e86d78cf4754a6aef2cf9a33d847aa15338e276fBob Wilson VectorType::GenericVector); 767cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor } 768d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 769d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 770d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman for (unsigned i = 2; i < TheCall->getNumArgs(); i++) { 771cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (TheCall->getArg(i)->isTypeDependent() || 772cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor TheCall->getArg(i)->isValueDependent()) 773cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor continue; 774cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 77537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman llvm::APSInt Result(32); 77637b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context)) 77737b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman return ExprError(Diag(TheCall->getLocStart(), 77837b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman diag::err_shufflevector_nonconstant_argument) 77937b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman << TheCall->getArg(i)->getSourceRange()); 7800eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl 781d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2) 7820eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl return ExprError(Diag(TheCall->getLocStart(), 783fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner diag::err_shufflevector_argument_too_large) 7840eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl << TheCall->getArg(i)->getSourceRange()); 785d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 786d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 787d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman llvm::SmallVector<Expr*, 32> exprs; 788d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 789d1a0b6d3dfb208f638d3d750b588d9c0daa49289Chris Lattner for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) { 790d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman exprs.push_back(TheCall->getArg(i)); 791d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman TheCall->setArg(i, 0); 792d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman } 793d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman 794a88dc3079bedf70a5cfc39791727e43a10383006Nate Begeman return Owned(new (Context) ShuffleVectorExpr(Context, exprs.begin(), 79537b6a5731a47f811d754f0d48aa93edf30e30513Nate Begeman exprs.size(), resType, 7968189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getCallee()->getLocStart(), 7978189cde56b4f6f938cd65f53c932fe1860d0204cTed Kremenek TheCall->getRParenLoc())); 798d38617c8a50f9729c254ab76cd359af797c6739bEli Friedman} 79930ce344307f8a8b00054021307015571f83c7364Chris Lattner 8004493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar/// SemaBuiltinPrefetch - Handle __builtin_prefetch. 8014493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// This is declared to take (const void*, ...) and can take two 8024493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar// optional constant int args. 8034493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbarbool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) { 804fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner unsigned NumArgs = TheCall->getNumArgs(); 8054493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 806fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (NumArgs > 3) 807ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher return Diag(TheCall->getLocEnd(), 808ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher diag::err_typecheck_call_too_many_args_at_most) 809ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << 0 /*function call*/ << 3 << NumArgs 810ccfa9639f8d09733bcf1c2572c5bd3daba5bd632Eric Christopher << TheCall->getSourceRange(); 8114493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 8124493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // Argument 0 is checked for us and the remaining arguments must be 8134493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // constant integers. 814fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner for (unsigned i = 1; i != NumArgs; ++i) { 8154493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar Expr *Arg = TheCall->getArg(i); 816691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 8179aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman llvm::APSInt Result; 818691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, i, Result)) 819691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 8201eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 8214493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // FIXME: gcc issues a warning and rewrites these to 0. These 8224493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // seems especially odd for the third argument since the default 8234493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar // is 3. 824fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner if (i == 1) { 8259aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 1) 826fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 82721fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "1" << Arg->getSourceRange(); 8284493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } else { 8299aef7263d84d9224575e113878cfbb06b8343cbfEli Friedman if (Result.getLimitedValue() > 3) 830fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 83121fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner << "0" << "3" << Arg->getSourceRange(); 8324493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 8334493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar } 8344493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 835fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return false; 8364493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar} 8374493f79fce48cd9cbd9f55fa9d452cde736747a0Daniel Dunbar 838691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr 839691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher/// TheCall is a constant expression. 840691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopherbool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum, 841691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt &Result) { 842691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(ArgNum); 843691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts()); 844691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl()); 845691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 846691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Arg->isTypeDependent() || Arg->isValueDependent()) return false; 847691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 848691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (!Arg->isIntegerConstantExpr(Result, Context)) 849691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type) 8505e8965525282a48fd34af05183b8c3705a5b00d5Eric Christopher << FDecl->getDeclName() << Arg->getSourceRange(); 851691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 85221fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner return false; 85321fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner} 85421fb98ee003e992b0c4e204d98a19e0ef544cae3Chris Lattner 855d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// SemaBuiltinObjectSize - Handle __builtin_object_size(void *ptr, 856d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// int type). This simply type checks that type is one of the defined 857d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar/// constants (0-3). 858fee667f35e64751baa7fefe70b4e7bab06c8cd86Eric Christopher// For compatability check 0-3, llvm only handles 0 and 2. 859d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbarbool Sema::SemaBuiltinObjectSize(CallExpr *TheCall) { 860691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 861691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 862691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // Check constant-ness first. 863691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 864691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 865d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 866691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher Expr *Arg = TheCall->getArg(1); 867d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar if (Result.getSExtValue() < 0 || Result.getSExtValue() > 3) { 868fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range) 869fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << "0" << "3" << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 870d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar } 871d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 872d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar return false; 873d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar} 874d5f8a4fd4d6dfb0415b93bb7ab721bba5cab1332Daniel Dunbar 875586d6a81428da2d1ce70bcb98df29d749361cbf3Eli Friedman/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val). 876d875fed28578835de89cd407e9db4be788596d7cEli Friedman/// This checks that val is a constant 1. 877d875fed28578835de89cd407e9db4be788596d7cEli Friedmanbool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { 878d875fed28578835de89cd407e9db4be788596d7cEli Friedman Expr *Arg = TheCall->getArg(1); 879691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher llvm::APSInt Result; 880cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor 881691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher // TODO: This is less than ideal. Overload this to take a value. 882691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (SemaBuiltinConstantArg(TheCall, 1, Result)) 883691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher return true; 884691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher 885691ebc3f3225542e5abd85e107ebdbec907cf510Eric Christopher if (Result != 1) 886d875fed28578835de89cd407e9db4be788596d7cEli Friedman return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val) 887d875fed28578835de89cd407e9db4be788596d7cEli Friedman << SourceRange(Arg->getLocStart(), Arg->getLocEnd()); 888d875fed28578835de89cd407e9db4be788596d7cEli Friedman 889d875fed28578835de89cd407e9db4be788596d7cEli Friedman return false; 890d875fed28578835de89cd407e9db4be788596d7cEli Friedman} 891d875fed28578835de89cd407e9db4be788596d7cEli Friedman 892b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek// Handle i > 1 ? "x" : "y", recursively. 893082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenekbool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall, 894082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool HasVAListArg, 895826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 896826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 8974fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek tryAgain: 898cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor if (E->isTypeDependent() || E->isValueDependent()) 899cde01739dffe574c53a6ba1def1a57a2cc7b4a8bDouglas Gregor return false; 900d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 901d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek switch (E->getStmtClass()) { 90256ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::BinaryConditionalOperatorClass: 903d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ConditionalOperatorClass: { 90456ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall const AbstractConditionalOperator *C = cast<AbstractConditionalOperator>(E); 905826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return SemaCheckStringLiteral(C->getTrueExpr(), TheCall, HasVAListArg, 906826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf) 90756ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall && SemaCheckStringLiteral(C->getFalseExpr(), TheCall, HasVAListArg, 908826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf); 909d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 910d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 91195355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek case Stmt::IntegerLiteralClass: 91295355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // Technically -Wformat-nonliteral does not warn about this case. 91395355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // The behavior of printf and friends in this case is implementation 91495355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // dependent. Ideally if the format string cannot be null then 91595355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek // it should have a 'nonnull' attribute in the function prototype. 91695355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek return true; 91795355bb53ef3145e463b98c6fd26f8f95e26e26cTed Kremenek 918d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ImplicitCastExprClass: { 9194fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ImplicitCastExpr>(E)->getSubExpr(); 9204fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 921d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 922d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 923d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek case Stmt::ParenExprClass: { 9244fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek E = cast<ParenExpr>(E)->getSubExpr(); 9254fe6441a558e471f2ad3c6bddf07c77332539f6bTed Kremenek goto tryAgain; 926d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 9271eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 92856ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall case Stmt::OpaqueValueExprClass: 92956ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) { 93056ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall E = src; 93156ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall goto tryAgain; 93256ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall } 93356ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall return false; 93456ca35d396d8692c384c785f9aeebcf22563fe1eJohn McCall 935b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek case Stmt::PredefinedExprClass: 936b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // While __func__, etc., are technically not string literals, they 937b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // cannot contain format specifiers and thus are not a security 938b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek // liability. 939b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek return true; 940b43e8ad893706a2499c4901b8f5cb289553d66b1Ted Kremenek 941082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::DeclRefExprClass: { 942082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const DeclRefExpr *DR = cast<DeclRefExpr>(E); 9431eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 944082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // As an exception, do not flag errors for variables binding to 945082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek // const string literals. 946082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) { 947082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek bool isConstant = false; 948082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek QualType T = DR->getType(); 949082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek 950082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ArrayType *AT = Context.getAsArrayType(T)) { 951082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek isConstant = AT->getElementType().isConstant(Context); 952ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (const PointerType *PT = T->getAs<PointerType>()) { 9531eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump isConstant = T.isConstant(Context) && 954082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek PT->getPointeeType().isConstant(Context); 955082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 9561eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 957082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (isConstant) { 95831310a21fb2a9f13950f864f681c86080b05d5b2Sebastian Redl if (const Expr *Init = VD->getAnyInitializer()) 959082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return SemaCheckStringLiteral(Init, TheCall, 960826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, format_idx, firstDataArg, 961826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isPrintf); 962082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 9631eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 964d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // For vprintf* functions (i.e., HasVAListArg==true), we add a 965d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // special check to see if the format string is a function parameter 966d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // of the function calling the printf function. If the function 967d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // has an attribute indicating it is a printf-like function, then we 968d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // should suppress warnings concerning non-literals being used in a call 969d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // to a vprintf function. For example: 970d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 971d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // void 972d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){ 973d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_list ap; 974d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // va_start(ap, fmt); 975d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // vprintf(fmt, ap); // Do NOT emit a warning about "fmt". 976d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // ... 977d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 978d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // 979d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // FIXME: We don't have full attribute support yet, so just check to see 980d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // if the argument is a DeclRefExpr that references a parameter. We'll 981d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson // add proper support for checking the attribute later. 982d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (HasVAListArg) 983d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson if (isa<ParmVarDecl>(VD)) 984d966a55bccae13f34d18958877c5e71dd643a125Anders Carlsson return true; 985082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 9861eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 987082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 988082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek } 989d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 9908f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson case Stmt::CallExprClass: { 9918f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const CallExpr *CE = cast<CallExpr>(E); 9921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump if (const ImplicitCastExpr *ICE 9938f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson = dyn_cast<ImplicitCastExpr>(CE->getCallee())) { 9948f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr())) { 9958f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(DRE->getDecl())) { 99640b598eea1310ec9ed554d56ce3e25b34c585458Argyrios Kyrtzidis if (const FormatArgAttr *FA = FD->getAttr<FormatArgAttr>()) { 9978f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson unsigned ArgIndex = FA->getFormatIdx(); 9988f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson const Expr *Arg = CE->getArg(ArgIndex - 1); 9991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10001eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump return SemaCheckStringLiteral(Arg, TheCall, HasVAListArg, 1001826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek format_idx, firstDataArg, isPrintf); 10028f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 10038f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 10048f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 10058f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 10061eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 10078f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson return false; 10088f031b3b14e726b093fb8693c2be4ab6d779e331Anders Carlsson } 1009082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::ObjCStringLiteralClass: 1010082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek case Stmt::StringLiteralClass: { 1011082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const StringLiteral *StrE = NULL; 10121eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1013082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E)) 1014d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek StrE = ObjCFExpr->getString(); 1015d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek else 1016082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek StrE = cast<StringLiteral>(E); 10171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1018d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek if (StrE) { 1019826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatString(StrE, E, TheCall, HasVAListArg, format_idx, 1020826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek firstDataArg, isPrintf); 1021d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return true; 1022d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 10231eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1024d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek return false; 1025d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 10261eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1027082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek default: 1028082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek return false; 1029d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek } 1030d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1031d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1032e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanianvoid 10331eb4433ac451dc16f4133a88af2d002ac26c58efMike StumpSema::CheckNonNullArguments(const NonNullAttr *NonNull, 1034909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr * const *ExprArgs, 1035909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky SourceLocation CallSiteLoc) { 1036cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt for (NonNullAttr::args_iterator i = NonNull->args_begin(), 1037cf807c4dfdb23e8fa3f400e0b24ef5b79db7a530Sean Hunt e = NonNull->args_end(); 1038e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian i != e; ++i) { 1039909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky const Expr *ArgExpr = ExprArgs[*i]; 10404e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (ArgExpr->isNullPointerConstant(Context, 1041ce94049b69f75b44c18584fe79cd238978b6b0d5Douglas Gregor Expr::NPC_ValueDependentIsNotNull)) 1042909a70d8a185f701c20bacc3c76f8f5979cbbc7cNick Lewycky Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange(); 1043e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian } 1044e898f8a94947c6074d76ff83943b47d5bbdf210dFariborz Jahanian} 1045d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1046826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// CheckPrintfScanfArguments - Check calls to printf and scanf (and similar 1047826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek/// functions) for correct use of format strings. 104859907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattnervoid 1049826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSema::CheckPrintfScanfArguments(const CallExpr *TheCall, bool HasVAListArg, 1050826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1051826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 1052826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1053082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *Fn = TheCall->getCallee(); 1054925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner 10554a2614e94672c47395abcde60518776fbebec589Sebastian Redl // The way the format attribute works in GCC, the implicit this argument 10564a2614e94672c47395abcde60518776fbebec589Sebastian Redl // of member functions is counted. However, it doesn't appear in our own 10574a2614e94672c47395abcde60518776fbebec589Sebastian Redl // lists, so decrement format_idx in that case. 10584a2614e94672c47395abcde60518776fbebec589Sebastian Redl if (isa<CXXMemberCallExpr>(TheCall)) { 10599263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth const CXXMethodDecl *method_decl = 10609263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth dyn_cast<CXXMethodDecl>(TheCall->getCalleeDecl()); 10619263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if (method_decl && method_decl->isInstance()) { 10629263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth // Catch a format attribute mistakenly referring to the object argument. 10639263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if (format_idx == 0) 10649263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth return; 10659263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth --format_idx; 10669263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth if(firstDataArg != 0) 10679263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth --firstDataArg; 10689263a3060087eb7b5954ec4ee1ff2c22227b422eChandler Carruth } 10694a2614e94672c47395abcde60518776fbebec589Sebastian Redl } 10704a2614e94672c47395abcde60518776fbebec589Sebastian Redl 1071826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // CHECK: printf/scanf-like function is called with no format string. 1072925e60d3fa706f31886027c876989af79eb0e0d2Chris Lattner if (format_idx >= TheCall->getNumArgs()) { 1073826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Diag(TheCall->getRParenLoc(), diag::warn_missing_format_string) 1074dcd5ef12488e4c7ea844327835896ca86b609a97Chris Lattner << Fn->getSourceRange(); 107571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek return; 107671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek } 10771eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1078082d936a5b8323ac2c04558d8bca277a647831a3Ted Kremenek const Expr *OrigFormatExpr = TheCall->getArg(format_idx)->IgnoreParenCasts(); 10791eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 108059907c4d8f6fc8aacfdaa0273bd7a9c140fbb45fChris Lattner // CHECK: format string is not a string literal. 10811eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // 108271895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // Dynamically generated format strings are difficult to 108371895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // automatically vet at compile time. Requiring that format strings 108471895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // are string literals: (1) permits the checking of format strings by 108571895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // the compiler and thereby (2) can practically remove the source of 108671895b9aa3ad71957359497e136b50fcb6136bdfTed Kremenek // many format string exploits. 10877ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek 10881eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // Format string can be either ObjC string (e.g. @"%d") or 10897ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // C string (e.g. "%d") 10901eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // ObjC string uses the same format specifiers as C string, so we can use 10917ff22b259d4d4729f701679e3a7f0e242365e07fTed Kremenek // the same format string checking logic for both ObjC and C strings. 10921cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner if (SemaCheckStringLiteral(OrigFormatExpr, TheCall, HasVAListArg, format_idx, 1093826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek firstDataArg, isPrintf)) 10941cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner return; // Literal format string found, check done! 10951cd3e1f72c3a1c256fb6a5c3d4512bca1f1b751dChris Lattner 1096655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // If there are no arguments specified, warn with -Wformat-security, otherwise 1097655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner // warn only with -Wformat-nonliteral. 1098655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner if (TheCall->getNumArgs() == format_idx+1) 10991eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1100826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral_noargs) 1101655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1102655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner else 11031eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump Diag(TheCall->getArg(format_idx)->getLocStart(), 1104826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_nonliteral) 1105655f141f4d4c92eeebcc880211313e84c0a8b2f2Chris Lattner << OrigFormatExpr->getSourceRange(); 1106d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek} 1107d30ef87f34015d18bde20b9632032d0063d761aaTed Kremenek 1108e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremeneknamespace { 1109826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckFormatHandler : public analyze_format_string::FormatStringHandler { 1110826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1111e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Sema &S; 1112e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const StringLiteral *FExpr; 1113e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const Expr *OrigFormatExpr; 11146ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const unsigned FirstDataArg; 1115e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const unsigned NumDataArgs; 1116e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const bool IsObjCLiteral; 1117e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *Beg; // Start of format string. 11180d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const bool HasVAListArg; 11190d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const CallExpr *TheCall; 11200d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek unsigned FormatIdx; 11217f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek llvm::BitVector CoveredArgs; 1122efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool usesPositionalArgs; 1123efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek bool atFirstArg; 11244e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenekpublic: 1125826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckFormatHandler(Sema &s, const StringLiteral *fexpr, 11266ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1127e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 11280d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const char *beg, bool hasVAListArg, 11290d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1130e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr), 11316ee765348b2855c702fa593fb030ef6abe0d01f6Ted Kremenek FirstDataArg(firstDataArg), 11327f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek NumDataArgs(numDataArgs), 11330d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek IsObjCLiteral(isObjCLiteral), Beg(beg), 11340d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek HasVAListArg(hasVAListArg), 1135efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek TheCall(theCall), FormatIdx(formatIdx), 1136efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek usesPositionalArgs(false), atFirstArg(true) { 11377f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.resize(numDataArgs); 11387f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.reset(); 11397f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 11404e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 114107d161f38e708a91486bf1c031d525faebbb249dTed Kremenek void DoneProcessing(); 11424e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1143826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIncompleteSpecifier(const char *startSpecifier, 1144826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1145826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1146efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleInvalidPosition(const char *startSpecifier, 1147efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned specifierLen, 1148826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p); 1149efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1150efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek virtual void HandleZeroPosition(const char *startPos, unsigned posLen); 1151efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1152e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek void HandleNullChar(const char *nullCharacter); 11534e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1154826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekprotected: 1155c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc, 1156c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1157c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1158c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, unsigned csLen); 1159c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1160f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek SourceRange getFormatStringRange(); 1161826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CharSourceRange getSpecifierRange(const char *startSpecifier, 1162826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1163e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek SourceLocation getLocationOfByte(const char *x); 11644e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 11650d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek const Expr *getDataArg(unsigned i) const; 1166666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1167666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS, 1168666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1169666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, 1170666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek unsigned argIndex); 1171e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek}; 1172e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1173e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1174826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceRange CheckFormatHandler::getFormatStringRange() { 1175e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return OrigFormatExpr->getSourceRange(); 1176e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1177e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1178826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCharSourceRange CheckFormatHandler:: 1179826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekgetSpecifierRange(const char *startSpecifier, unsigned specifierLen) { 118045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation Start = getLocationOfByte(startSpecifier); 118145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1); 118245f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 118345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care // Advance the end SourceLocation by one due to half-open ranges. 118445f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care End = End.getFileLocWithOffset(1); 118545f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care 118645f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care return CharSourceRange::getCharRange(Start, End); 1187f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek} 1188f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek 1189826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekSourceLocation CheckFormatHandler::getLocationOfByte(const char *x) { 11904e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek return S.getLocationOfStringLiteralByte(FExpr, x - Beg); 1191e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1192e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1193826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier, 1194826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen){ 1195808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek SourceLocation Loc = getLocationOfByte(startSpecifier); 1196808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek S.Diag(Loc, diag::warn_printf_incomplete_specifier) 1197826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1198808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek} 1199808015a18bd97781ce437831a95a92fdfc8d5136Ted Kremenek 1200efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenekvoid 1201826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen, 1202826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek analyze_format_string::PositionContext p) { 1203efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek SourceLocation Loc = getLocationOfByte(startPos); 1204826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(Loc, diag::warn_format_invalid_positional_specifier) 1205826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << (unsigned) p << getSpecifierRange(startPos, posLen); 1206efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1207efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1208826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleZeroPosition(const char *startPos, 1209efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek unsigned posLen) { 1210efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek SourceLocation Loc = getLocationOfByte(startPos); 1211826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(Loc, diag::warn_format_zero_positional_specifier) 1212826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startPos, posLen); 1213efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek} 1214efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 1215826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::HandleNullChar(const char *nullCharacter) { 12160c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek if (!IsObjCLiteral) { 12170c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek // The presence of a null character is likely an error. 12180c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek S.Diag(getLocationOfByte(nullCharacter), 12190c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek diag::warn_printf_format_string_contains_null_char) 12200c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek << getFormatStringRange(); 12210c06944f5ef31cc6356e30da2971fa5439c4c8efTed Kremenek } 1222826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1223826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1224826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekconst Expr *CheckFormatHandler::getDataArg(unsigned i) const { 1225826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return TheCall->getArg(FirstDataArg + i); 1226826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 12274e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1228826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckFormatHandler::DoneProcessing() { 1229826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Does the number of data arguments exceed the number of 1230826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // format conversions in the format string? 1231826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!HasVAListArg) { 1232826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Find any arguments that weren't covered. 1233826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.flip(); 1234826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek signed notCoveredArg = CoveredArgs.find_first(); 1235826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (notCoveredArg >= 0) { 1236826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek assert((unsigned)notCoveredArg < NumDataArgs); 1237826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getDataArg((unsigned) notCoveredArg)->getLocStart(), 1238826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_printf_data_arg_not_used) 1239826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getFormatStringRange(); 1240826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1241826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1242826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1243826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1244c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool 1245c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted KremenekCheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex, 1246c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek SourceLocation Loc, 1247c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpec, 1248c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen, 1249c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *csStart, 1250c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned csLen) { 1251c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1252c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool keepGoing = true; 1253c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek if (argIndex < NumDataArgs) { 1254c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // Consider the argument coverered, even though the specifier doesn't 1255c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // make sense. 1256c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CoveredArgs.set(argIndex); 1257c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1258c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek else { 1259c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // If argIndex exceeds the number of data arguments we 1260c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // don't issue a warning because that is just a cascade of warnings (and 1261c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // they may have intended '%%' anyway). We don't want to continue processing 1262c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // the format string after this point, however, as we will like just get 1263c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek // gibberish when trying to match arguments. 1264c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek keepGoing = false; 1265c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek } 1266c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1267c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek S.Diag(Loc, diag::warn_format_invalid_conversion) 1268c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek << llvm::StringRef(csStart, csLen) 1269c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek << getSpecifierRange(startSpec, specifierLen); 1270c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1271c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return keepGoing; 1272c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1273c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1274666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenekbool 1275666a197deb75d95c78ddd39274af1a54240828d8Ted KremenekCheckFormatHandler::CheckNumArgs( 1276666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::FormatSpecifier &FS, 1277666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const analyze_format_string::ConversionSpecifier &CS, 1278666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek const char *startSpecifier, unsigned specifierLen, unsigned argIndex) { 1279666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1280666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (argIndex >= NumDataArgs) { 1281666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (FS.usesPositionalArg()) { 1282666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1283666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek diag::warn_printf_positional_arg_exceeds_data_args) 1284666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << (argIndex+1) << NumDataArgs 1285666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1286666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1287666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek else { 1288666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1289666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek diag::warn_printf_insufficient_data_args) 1290666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1291666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1292666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1293666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return false; 1294666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek } 1295666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek return true; 1296666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek} 1297666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek 1298826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Printf format string checking ------------------------------===// 1299826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1300826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 1301826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckPrintfHandler : public CheckFormatHandler { 1302826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 1303826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler(Sema &s, const StringLiteral *fexpr, 1304826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1305826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 1306826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 1307826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1308826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1309826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 1310826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek theCall, formatIdx) {} 1311826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1312826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1313826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleInvalidPrintfConversionSpecifier( 1314826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1315826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1316826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1317826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1318826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS, 1319826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1320826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1321826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1322826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k, 1323826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1324826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS, 1325826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalAmount &Amt, 1326826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned type, 1327826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1328826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1329826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1330826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1331826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS, 1332826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &ignoredFlag, 1333826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::OptionalFlag &flag, 1334826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, unsigned specifierLen); 1335826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 1336826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1337826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1338826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier( 1339826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1340826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1341826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 13426ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 1343c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 1344826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1345c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1346c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 1347c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 1348c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 134926ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek} 135026ac2e07b46bfb4d4f00752c96481c0a98c79c69Ted Kremenek 1351826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckPrintfHandler::HandleAmount( 1352826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_format_string::OptionalAmount &Amt, 1353826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned k, const char *startSpecifier, 1354826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 13550d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 13560d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (Amt.hasDataArgument()) { 13570d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek if (!HasVAListArg) { 13587f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = Amt.getArgIndex(); 13597f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (argIndex >= NumDataArgs) { 1360efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1361efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek diag::warn_printf_asterisk_missing_arg) 1362826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << k << getSpecifierRange(startSpecifier, specifierLen); 13630d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 13640d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 13650d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 13660d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 13674e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 13680d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Type check the data argument. It should be an 'int'. 136931f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // Although not in conformance with C99, we also allow the argument to be 137031f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // an 'unsigned int' as that is a reasonably safe case. GCC also 137131f8e32788adb299acad455363eb7fd244642c82Ted Kremenek // doesn't emit a warning for that case. 13727f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek CoveredArgs.set(argIndex); 13737f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek const Expr *Arg = getDataArg(argIndex); 13740d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek QualType T = Arg->getType(); 13754e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 13764e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek const analyze_printf::ArgTypeResult &ATR = Amt.getArgType(S.Context); 13774e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek assert(ATR.isValid()); 13784e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 13794e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek if (!ATR.matchesType(S.Context, T)) { 1380efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1381efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek diag::warn_printf_asterisk_wrong_type) 1382efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek << k 13834e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek << ATR.getRepresentativeType(S.Context) << T 1384826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1385d635c5fcc45c952b75743dd2f4c86d6950e4954eTed Kremenek << Arg->getSourceRange(); 13860d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // Don't do any more checking. We will just emit 13870d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // spurious errors. 13880d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 13890d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 13900d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 13910d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 13920d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return true; 13930d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek} 13940d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1395e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleInvalidAmount( 1396826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1397e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalAmount &Amt, 1398e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned type, 1399e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1400e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 14016ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 14026ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1403e4ee9663168dfb2b4122c768091e30217328c9faTom Care switch (Amt.getHowSpecified()) { 1404e4ee9663168dfb2b4122c768091e30217328c9faTom Care case analyze_printf::OptionalAmount::Constant: 1405e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(Amt.getStart()), 1406e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_optional_amount) 1407e4ee9663168dfb2b4122c768091e30217328c9faTom Care << type 1408e4ee9663168dfb2b4122c768091e30217328c9faTom Care << CS.toString() 1409826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1410826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(), 1411e4ee9663168dfb2b4122c768091e30217328c9faTom Care Amt.getConstantLength())); 1412e4ee9663168dfb2b4122c768091e30217328c9faTom Care break; 1413e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1414e4ee9663168dfb2b4122c768091e30217328c9faTom Care default: 1415e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(Amt.getStart()), 1416e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_optional_amount) 1417e4ee9663168dfb2b4122c768091e30217328c9faTom Care << type 1418e4ee9663168dfb2b4122c768091e30217328c9faTom Care << CS.toString() 1419826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1420e4ee9663168dfb2b4122c768091e30217328c9faTom Care break; 1421e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1422e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1423e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1424826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS, 1425e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 1426e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1427e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 1428e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about pointless flag with a fixit removal. 14296ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_printf::PrintfConversionSpecifier &CS = 14306ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek FS.getConversionSpecifier(); 1431e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(flag.getPosition()), 1432e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_nonsensical_flag) 1433e4ee9663168dfb2b4122c768091e30217328c9faTom Care << flag.toString() << CS.toString() 1434826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1435826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(flag.getPosition(), 1)); 1436e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1437e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1438e4ee9663168dfb2b4122c768091e30217328c9faTom Carevoid CheckPrintfHandler::HandleIgnoredFlag( 1439826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_printf::PrintfSpecifier &FS, 1440e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &ignoredFlag, 1441e4ee9663168dfb2b4122c768091e30217328c9faTom Care const analyze_printf::OptionalFlag &flag, 1442e4ee9663168dfb2b4122c768091e30217328c9faTom Care const char *startSpecifier, 1443e4ee9663168dfb2b4122c768091e30217328c9faTom Care unsigned specifierLen) { 1444e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Warn about ignored flag with a fixit removal. 1445e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(ignoredFlag.getPosition()), 1446e4ee9663168dfb2b4122c768091e30217328c9faTom Care diag::warn_printf_ignored_flag) 1447e4ee9663168dfb2b4122c768091e30217328c9faTom Care << ignoredFlag.toString() << flag.toString() 1448826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1449826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange( 1450e4ee9663168dfb2b4122c768091e30217328c9faTom Care ignoredFlag.getPosition(), 1)); 1451e4ee9663168dfb2b4122c768091e30217328c9faTom Care} 1452e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1453e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenekbool 1454826a3457f737f1fc45a22954fd1bfde38160c165Ted KremenekCheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier 14555c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek &FS, 1456e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek const char *startSpecifier, 1457e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek unsigned specifierLen) { 1458e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 14596ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek using namespace analyze_format_string; 1460efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek using namespace analyze_printf; 14616ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const PrintfConversionSpecifier &CS = FS.getConversionSpecifier(); 1462e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1463baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 1464baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 1465baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 1466baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 1467baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1468baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 1469baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Cannot mix-and-match positional and non-positional arguments. 1470baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1471baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek diag::warn_format_mix_positional_nonpositional_args) 1472baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1473baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 1474baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1475efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek } 1476efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek 14770d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // First check if the field width, precision, and conversion specifier 14780d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek // have matching data arguments. 1479efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0, 1480efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 14810d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 14820d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 14834e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1484efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek if (!HandleAmount(FS.getPrecision(), /* precision */ 1, 1485efaff195ba1fa55b6fe0b0b2435b81451387d241Ted Kremenek startSpecifier, specifierLen)) { 14860d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek return false; 14870d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek } 14880d27735c51f5bd392e673cf39a675e14e9442387Ted Kremenek 1489f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek if (!CS.consumesDataArgument()) { 1490f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // FIXME: Technically specifying a precision or field width here 1491f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek // makes no sense. Worth issuing a warning at some point. 14920e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek return true; 1493f88c8e02da48afea6a04091f675af5c4facd99f1Ted Kremenek } 14944e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 14957f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Consume the argument. 14967f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek unsigned argIndex = FS.getArgIndex(); 1497e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek if (argIndex < NumDataArgs) { 1498e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // The check to see if the argIndex is valid will come later. 1499e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // We set the bit here because we may exit early from this 1500e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek // function if we encounter some other error. 1501e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek CoveredArgs.set(argIndex); 1502e3fc54790250076e33ad25b14e5be293514fe5eaTed Kremenek } 15037f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek 15047f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // Check for using an Objective-C specific conversion specifier 15057f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek // in a non-ObjC literal. 15067f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek if (!IsObjCLiteral && CS.isObjCArg()) { 1507826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier, 1508826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek specifierLen); 15097f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 15104e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1511e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of field width 1512e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidFieldWidth()) { 151345f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0, 1514e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1515e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1516e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1517e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check for invalid use of precision 1518e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPrecision()) { 1519e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1, 1520e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1521e4ee9663168dfb2b4122c768091e30217328c9faTom Care } 1522e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1523e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check each flag does not conflict with any other component. 152465197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek if (!FS.hasValidThousandsGroupingPrefix()) 152565197b4b0c55bb74af0450230d61ee9461223721Ted Kremenek HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen); 1526e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeadingZeros()) 1527e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen); 1528e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidPlusPrefix()) 1529e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen); 153045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (!FS.hasValidSpacePrefix()) 153145f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen); 1532e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidAlternativeForm()) 1533e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen); 1534e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLeftJustified()) 1535e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen); 1536e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1537e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check that flags are not ignored by another flag 153845f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+' 153945f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(), 154045f9b7e8f23072d662ee1cc758f4ecb0da5e3322Tom Care startSpecifier, specifierLen); 1541e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-' 1542e4ee9663168dfb2b4122c768091e30217328c9faTom Care HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(), 1543e4ee9663168dfb2b4122c768091e30217328c9faTom Care startSpecifier, specifierLen); 1544e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1545e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Check the length modifier is valid with the given conversion specifier. 1546e4ee9663168dfb2b4122c768091e30217328c9faTom Care const LengthModifier &LM = FS.getLengthModifier(); 1547e4ee9663168dfb2b4122c768091e30217328c9faTom Care if (!FS.hasValidLengthModifier()) 1548e4ee9663168dfb2b4122c768091e30217328c9faTom Care S.Diag(getLocationOfByte(LM.getStart()), 1549649aecf55670682efb2a04a85810eef4d038c527Ted Kremenek diag::warn_format_nonsensical_length) 1550e4ee9663168dfb2b4122c768091e30217328c9faTom Care << LM.toString() << CS.toString() 1551826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 1552826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 1553e4ee9663168dfb2b4122c768091e30217328c9faTom Care LM.getLength())); 1554e4ee9663168dfb2b4122c768091e30217328c9faTom Care 1555e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Are we using '%n'? 155635d353b47bce29200b910371dd9b8ba7f3058ab8Ted Kremenek if (CS.getKind() == ConversionSpecifier::nArg) { 1557e4ee9663168dfb2b4122c768091e30217328c9faTom Care // Issue a warning about this being a possible security issue. 1558e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), diag::warn_printf_write_back) 1559826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1560e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek // Continue checking the other format specifiers. 1561e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek return true; 1562e82d804ee761006250543d6fe6e98ee7896cd756Ted Kremenek } 15635c41ee8c49995fb4fd76d686b239c15cbab261eaTed Kremenek 1564da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek // The remaining checks depend on the data arguments. 1565da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek if (HasVAListArg) 1566da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return true; 15674e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 1568666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 1569da51f0d136df131a0137c0ec1069fb586d8a296aTed Kremenek return false; 15704e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 157196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Now type check the data expression that matches the 157296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // format specifier. 157396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const Expr *Ex = getDataArg(argIndex); 157496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer const analyze_printf::ArgTypeResult &ATR = FS.getArgType(S.Context); 157596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (ATR.isValid() && !ATR.matchesType(S.Context, Ex->getType())) { 157696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Check if we didn't match because of an implicit cast from a 'char' 157796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // or 'short' to an 'int'. This is done because printf is a varargs 157896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // function. 157996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Ex)) 15804d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ICE->getType() == S.Context.IntTy) { 15814d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek // All further checking is done on the subexpression. 15824d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek Ex = ICE->getSubExpr(); 15834d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek if (ATR.matchesType(S.Context, Ex->getType())) 158496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer return true; 15854d8ae4d57ed18d60da4d3786fb740607aa7c3688Ted Kremenek } 158696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 158796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // We may be able to offer a FixItHint if it is a supported type. 158896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer PrintfSpecifier fixedFS = FS; 158996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer bool success = fixedFS.fixType(Ex->getType()); 159096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 159196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer if (success) { 159296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer // Get the fix string from the fixed format specifier 159396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::SmallString<128> buf; 159496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer llvm::raw_svector_ostream os(buf); 159596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer fixedFS.toString(os); 159696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 15979325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // FIXME: getRepresentativeType() perhaps should return a string 15989325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // instead of a QualType to better handle when the representative 15999325eaf08fcccbc0d038e703f570c64daacdaa31Ted Kremenek // type is 'wint_t' (which is defined in the system headers). 160096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer S.Diag(getLocationOfByte(CS.getStart()), 160196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer diag::warn_printf_conversion_argument_type_mismatch) 160296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << ATR.getRepresentativeType(S.Context) << Ex->getType() 160396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << getSpecifierRange(startSpecifier, specifierLen) 160496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << Ex->getSourceRange() 160596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << FixItHint::CreateReplacement( 160696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer getSpecifierRange(startSpecifier, specifierLen), 160796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer os.str()); 160896827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 160996827eb52405a71c65c200949f3e644368e86454Michael J. Spencer else { 161096827eb52405a71c65c200949f3e644368e86454Michael J. Spencer S.Diag(getLocationOfByte(CS.getStart()), 161196827eb52405a71c65c200949f3e644368e86454Michael J. Spencer diag::warn_printf_conversion_argument_type_mismatch) 161296827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << ATR.getRepresentativeType(S.Context) << Ex->getType() 161396827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << getSpecifierRange(startSpecifier, specifierLen) 161496827eb52405a71c65c200949f3e644368e86454Michael J. Spencer << Ex->getSourceRange(); 161596827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 161696827eb52405a71c65c200949f3e644368e86454Michael J. Spencer } 161796827eb52405a71c65c200949f3e644368e86454Michael J. Spencer 1618e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return true; 1619e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek} 1620e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1621826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek//===--- CHECK: Scanf format string checking ------------------------------===// 1622826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1623826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremeneknamespace { 1624826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekclass CheckScanfHandler : public CheckFormatHandler { 1625826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekpublic: 1626826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler(Sema &s, const StringLiteral *fexpr, 1627826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const Expr *origFormatExpr, unsigned firstDataArg, 1628826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned numDataArgs, bool isObjCLiteral, 1629826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *beg, bool hasVAListArg, 1630826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CallExpr *theCall, unsigned formatIdx) 1631826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg, 1632826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek numDataArgs, isObjCLiteral, beg, hasVAListArg, 1633826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek theCall, formatIdx) {} 1634826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1635826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS, 1636826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1637826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen); 1638c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1639c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek bool HandleInvalidScanfConversionSpecifier( 1640c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1641c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 1642c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen); 1643b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 1644b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek void HandleIncompleteScanList(const char *start, const char *end); 1645826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek}; 1646826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek} 1647826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1648b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenekvoid CheckScanfHandler::HandleIncompleteScanList(const char *start, 1649b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek const char *end) { 1650b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek S.Diag(getLocationOfByte(end), diag::warn_scanf_scanlist_incomplete) 1651b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek << getSpecifierRange(start, end - start); 1652b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek} 1653b7c21018ec1049580cf6df88db09e606550a7baaTed Kremenek 1654c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenekbool CheckScanfHandler::HandleInvalidScanfConversionSpecifier( 1655c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1656c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek const char *startSpecifier, 1657c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek unsigned specifierLen) { 1658c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 16596ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const analyze_scanf::ScanfConversionSpecifier &CS = 1660c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek FS.getConversionSpecifier(); 1661c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1662c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek return HandleInvalidConversionSpecifier(FS.getArgIndex(), 1663c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek getLocationOfByte(CS.getStart()), 1664c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek startSpecifier, specifierLen, 1665c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek CS.getStart(), CS.getLength()); 1666c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek} 1667c09b6a59e02ae265fce51b8c11e2a045bcdaa888Ted Kremenek 1668826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekbool CheckScanfHandler::HandleScanfSpecifier( 1669826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const analyze_scanf::ScanfSpecifier &FS, 1670826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const char *startSpecifier, 1671826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned specifierLen) { 1672826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1673826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_scanf; 1674826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek using namespace analyze_format_string; 1675826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 16766ecb950c65329f8d6ce9ad0514632df35a5ab61fTed Kremenek const ScanfConversionSpecifier &CS = FS.getConversionSpecifier(); 1677826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1678baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Handle case where '%' and '*' don't consume an argument. These shouldn't 1679baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // be used to decide if we are using positional arguments consistently. 1680baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (FS.consumesDataArgument()) { 1681baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek if (atFirstArg) { 1682baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek atFirstArg = false; 1683baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek usesPositionalArgs = FS.usesPositionalArg(); 1684baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1685baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek else if (usesPositionalArgs != FS.usesPositionalArg()) { 1686baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek // Cannot mix-and-match positional and non-positional arguments. 1687baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek S.Diag(getLocationOfByte(CS.getStart()), 1688baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek diag::warn_format_mix_positional_nonpositional_args) 1689baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen); 1690baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek return false; 1691baa400654bd6f8396f9a07188445ae7955b060a3Ted Kremenek } 1692826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1693826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1694826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Check if the field with is non-zero. 1695826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const OptionalAmount &Amt = FS.getFieldWidth(); 1696826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getHowSpecified() == OptionalAmount::Constant) { 1697826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (Amt.getConstantAmount() == 0) { 1698826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek const CharSourceRange &R = getSpecifierRange(Amt.getStart(), 1699826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Amt.getConstantLength()); 1700826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek S.Diag(getLocationOfByte(Amt.getStart()), 1701826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_scanf_nonzero_width) 1702826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek << R << FixItHint::CreateRemoval(R); 17037f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 17047f70dc85d5055c19c8003f43a59135de211ad1b9Ted Kremenek } 1705826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1706826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!FS.consumesDataArgument()) { 1707826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Technically specifying a precision or field width here 1708826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // makes no sense. Worth issuing a warning at some point. 1709826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 1710826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1711826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1712826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // Consume the argument. 1713826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned argIndex = FS.getArgIndex(); 1714826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (argIndex < NumDataArgs) { 1715826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The check to see if the argIndex is valid will come later. 1716826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // We set the bit here because we may exit early from this 1717826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // function if we encounter some other error. 1718826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CoveredArgs.set(argIndex); 1719826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1720826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 17211e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek // Check the length modifier is valid with the given conversion specifier. 17221e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek const LengthModifier &LM = FS.getLengthModifier(); 17231e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek if (!FS.hasValidLengthModifier()) { 17241e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek S.Diag(getLocationOfByte(LM.getStart()), 17251e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek diag::warn_format_nonsensical_length) 17261e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << LM.toString() << CS.toString() 17271e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << getSpecifierRange(startSpecifier, specifierLen) 17281e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek << FixItHint::CreateRemoval(getSpecifierRange(LM.getStart(), 17291e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek LM.getLength())); 17301e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek } 17311e51c200b17cb6b0238c10a8760ae04765688f16Ted Kremenek 1732826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // The remaining checks depend on the data arguments. 1733826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (HasVAListArg) 1734826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 1735826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1736666a197deb75d95c78ddd39274af1a54240828d8Ted Kremenek if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex)) 1737826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return false; 1738826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1739826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek // FIXME: Check that the argument type matches the format specifier. 1740826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1741826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek return true; 174207d161f38e708a91486bf1c031d525faebbb249dTed Kremenek} 1743e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek 1744826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenekvoid Sema::CheckFormatString(const StringLiteral *FExpr, 17450e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const Expr *OrigFormatExpr, 17460e5675de2b67eeca754754ae8d3dacba425a38e8Ted Kremenek const CallExpr *TheCall, bool HasVAListArg, 1747826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek unsigned format_idx, unsigned firstDataArg, 1748826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek bool isPrintf) { 1749826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1750e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: is the format string a wide literal? 1751e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek if (FExpr->isWide()) { 1752e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek Diag(FExpr->getLocStart(), 1753826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek diag::warn_format_string_is_wide_literal) 1754e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek << OrigFormatExpr->getSourceRange(); 1755e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 1756e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 1757826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1758e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // Str - The format string. NOTE: this is NOT null-terminated! 17592f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer llvm::StringRef StrRef = FExpr->getString(); 17602f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer const char *Str = StrRef.data(); 17612f4eaef37476ae6891ede8ba215d0f6fd093629bBenjamin Kramer unsigned StrLen = StrRef.size(); 1762826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1763e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek // CHECK: empty format string? 1764e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek if (StrLen == 0) { 1765826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek Diag(FExpr->getLocStart(), diag::warn_empty_format_string) 1766e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek << OrigFormatExpr->getSourceRange(); 1767e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek return; 1768e0e5313c25f3870d0d18fc67e1b3a3a0e1ef8e07Ted Kremenek } 1769826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1770826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (isPrintf) { 1771826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 1772826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek TheCall->getNumArgs() - firstDataArg, 1773826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isa<ObjCStringLiteral>(OrigFormatExpr), Str, 1774826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, TheCall, format_idx); 1775826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1776826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen)) 1777826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 1778826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1779826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek else { 1780826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, 1781826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek TheCall->getNumArgs() - firstDataArg, 1782826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek isa<ObjCStringLiteral>(OrigFormatExpr), Str, 1783826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek HasVAListArg, TheCall, format_idx); 1784826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek 1785826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen)) 1786826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek H.DoneProcessing(); 1787826a3457f737f1fc45a22954fd1bfde38160c165Ted Kremenek } 1788ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek} 1789ce7024e8a3793b05861a4904ecdb1272924ada14Ted Kremenek 179006de276fff91264437fa75111ed76de43097e089Ted Kremenek//===--- CHECK: Return Address of Stack Variable --------------------------===// 179106de276fff91264437fa75111ed76de43097e089Ted Kremenek 179226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, llvm::SmallVectorImpl<DeclRefExpr *> &refVars); 179326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidisstatic Expr *EvalAddr(Expr* E, llvm::SmallVectorImpl<DeclRefExpr *> &refVars); 179406de276fff91264437fa75111ed76de43097e089Ted Kremenek 179506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// CheckReturnStackAddr - Check if a return statement returns the address 179606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// of a stack variable. 179706de276fff91264437fa75111ed76de43097e089Ted Kremenekvoid 179806de276fff91264437fa75111ed76de43097e089Ted KremenekSema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType, 179906de276fff91264437fa75111ed76de43097e089Ted Kremenek SourceLocation ReturnLoc) { 18001eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 180126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Expr *stackE = 0; 180226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis llvm::SmallVector<DeclRefExpr *, 8> refVars; 18034e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 180426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Perform checking for returned stack addresses, local blocks, 180526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // label addresses or references to temporaries. 180626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (lhsType->isPointerType() || lhsType->isBlockPointerType()) { 180726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalAddr(RetValExp, refVars); 1808ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else if (lhsType->isReferenceType()) { 180926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis stackE = EvalVal(RetValExp, refVars); 181026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 181126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 181226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (stackE == 0) 181326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return; // Nothing suspicious was found. 181426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 181526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceLocation diagLoc; 181626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange diagRange; 181726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (refVars.empty()) { 181826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = stackE->getLocStart(); 181926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = stackE->getSourceRange(); 182026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { 182126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // We followed through a reference variable. 'stackE' contains the 182226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // problematic expression but we will warn at the return statement pointing 182326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // at the reference variable. We will later display the "trail" of 182426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // reference variables using notes. 182526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagLoc = refVars[0]->getLocStart(); 182626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis diagRange = refVars[0]->getSourceRange(); 182726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 182826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 182926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var. 183026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref 183126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_stack_addr) 183226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << DR->getDecl()->getDeclName() << diagRange; 183326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<BlockExpr>(stackE)) { // local block. 183426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::err_ret_local_block) << diagRange; 183526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else if (isa<AddrLabelExpr>(stackE)) { // address of label. 183626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, diag::warn_ret_addr_label) << diagRange; 183726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } else { // local temporary. 183826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref 183926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : diag::warn_ret_local_temp_addr) 184026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << diagRange; 184126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 184226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 184326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Display the "trail" of reference variables that we followed until we 184426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // found the problematic expression using notes. 184526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis for (unsigned i = 0, e = refVars.size(); i != e; ++i) { 184626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl()); 184726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this var binds to another reference var, show the range of the next 184826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // var, otherwise the var binds to the problematic expression, in which case 184926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // show the range of the expression. 185026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange() 185126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis : stackE->getSourceRange(); 185226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis Diag(VD->getLocation(), diag::note_ref_var_local_bind) 185326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis << VD->getDeclName() << range; 185406de276fff91264437fa75111ed76de43097e089Ted Kremenek } 185506de276fff91264437fa75111ed76de43097e089Ted Kremenek} 185606de276fff91264437fa75111ed76de43097e089Ted Kremenek 185706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that 185806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// check if the expression in a return statement evaluates to an address 185926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// to a location on the stack, a local block, an address of a label, or a 186026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// reference to local temporary. The recursion is used to traverse the 186106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// AST of the return expression, with recursion backtracking when we 186226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// encounter a subexpression that (1) clearly does not lead to one of the 186326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// above problematic expressions (2) is something we cannot determine leads to 186426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// a problematic expression based on such local checking. 186526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 186626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// Both EvalAddr and EvalVal follow through reference variables to evaluate 186726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// the expression that they point to. Such variables are added to the 186826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// 'refVars' vector so that we know what the reference variable "trail" was. 186906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 1870e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// EvalAddr processes expressions that are pointers that are used as 1871e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek/// references (and not L-values). EvalVal handles all other values. 187226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// At the base case of the recursion is a check for the above problematic 187326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis/// expressions. 187406de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 187506de276fff91264437fa75111ed76de43097e089Ted Kremenek/// This implementation handles: 187606de276fff91264437fa75111ed76de43097e089Ted Kremenek/// 187706de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer-to-pointer casts 187806de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * implicit conversions from array references to pointers 187906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of fields 188006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * arbitrary interplay between "&" and "*" operators 188106de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * pointer arithmetic from an address of a stack variable 188206de276fff91264437fa75111ed76de43097e089Ted Kremenek/// * taking the address of an array element where the array is on the stack 188326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidisstatic Expr *EvalAddr(Expr *E, llvm::SmallVectorImpl<DeclRefExpr *> &refVars) { 188426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (E->isTypeDependent()) 188526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 188626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 188706de276fff91264437fa75111ed76de43097e089Ted Kremenek // We should only be called for evaluating pointer expressions. 18880f436560640a1cff5b6d96f80f540770f139453fDavid Chisnall assert((E->getType()->isAnyPointerType() || 1889dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff E->getType()->isBlockPointerType() || 1890a526c5c67e5a0473c340903ee542ce570119665fTed Kremenek E->getType()->isObjCQualifiedIdType()) && 1891fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner "EvalAddr only works on pointers"); 18921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 189306de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 189406de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 189506de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 189606de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 1897fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ParenExprClass: 1898fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Ignore parentheses. 189926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(cast<ParenExpr>(E)->getSubExpr(), refVars); 190026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 190126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::DeclRefExprClass: { 190226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis DeclRefExpr *DR = cast<DeclRefExpr>(E); 190326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 190426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 190526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // If this is a reference variable, follow through to the expression that 190626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 190726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage() && 190826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis V->getType()->isReferenceType() && V->hasInit()) { 190926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 191026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 191126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(V->getInit(), refVars); 191226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 191326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 191426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 191526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 191606de276fff91264437fa75111ed76de43097e089Ted Kremenek 1917fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::UnaryOperatorClass: { 1918fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // The only unary operator that make sense to handle here 1919fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // is AddrOf. All others don't make sense as pointers. 1920fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner UnaryOperator *U = cast<UnaryOperator>(E); 19211eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 19222de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_AddrOf) 192326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(U->getSubExpr(), refVars); 1924fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 1925fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 1926fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 19271eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1928fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::BinaryOperatorClass: { 1929fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle pointer arithmetic. All other binary operators are not valid 1930fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // in this context. 1931fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner BinaryOperator *B = cast<BinaryOperator>(E); 19322de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = B->getOpcode(); 19331eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 19342de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op != BO_Add && op != BO_Sub) 1935fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 19361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1937fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner Expr *Base = B->getLHS(); 19383907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 1939fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Determine which argument is the real pointer base. It could be 1940fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // the RHS argument instead of the LHS. 1941fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner if (!Base->getType()->isPointerType()) Base = B->getRHS(); 19421eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1943fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner assert (Base->getType()->isPointerType()); 194426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(Base, refVars); 1945fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 194661f40a2b67fc2046768e14f66b617e564cbcc3d8Steve Naroff 1947fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // For conditional operators we need to see if either the LHS or RHS are 1948fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // valid DeclRefExpr*s. If one of them is valid, we return it. 1949fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner case Stmt::ConditionalOperatorClass: { 1950fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner ConditionalOperator *C = cast<ConditionalOperator>(E); 19511eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1952fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Handle the GNU extension for missing LHS. 19539ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (Expr *lhsExpr = C->getLHS()) { 19549ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 19559ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (!lhsExpr->getType()->isVoidType()) 195626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr* LHS = EvalAddr(lhsExpr, refVars)) 19579ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return LHS; 19589ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor } 19599ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor 19609ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor // In C++, we can have a throw-expression, which has 'void' type. 19619ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor if (C->getRHS()->getType()->isVoidType()) 19629ee5ee84f0ad8246bff105786a128c7a909fdf12Douglas Gregor return NULL; 196306de276fff91264437fa75111ed76de43097e089Ted Kremenek 196426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(C->getRHS(), refVars); 1965fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 196626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 196726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::BlockExprClass: 1968469a1eb996e1cb0be54f9b210f836afbddcbb2ccJohn McCall if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures()) 196926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // local block. 197026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return NULL; 197126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 197226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis case Stmt::AddrLabelExprClass: 197326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; // address of label. 19741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 197554b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // For casts, we need to handle conversions from arrays to 197654b5274f2c190331438375ad114dad12ae098b57Ted Kremenek // pointer values, and pointer-to-pointer conversions. 197749badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::ImplicitCastExprClass: 19786eec8e883de118b431e3ead5b1e604a6ac68ff6bDouglas Gregor case Stmt::CStyleCastExprClass: 197949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXFunctionalCastExprClass: { 19800835a3cdeefe714b4959d31127ea155e56393125Argyrios Kyrtzidis Expr* SubExpr = cast<CastExpr>(E)->getSubExpr(); 198154b5274f2c190331438375ad114dad12ae098b57Ted Kremenek QualType T = SubExpr->getType(); 19821eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1983dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (SubExpr->getType()->isPointerType() || 1984dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isBlockPointerType() || 1985dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff SubExpr->getType()->isObjCQualifiedIdType()) 198626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(SubExpr, refVars); 198754b5274f2c190331438375ad114dad12ae098b57Ted Kremenek else if (T->isArrayType()) 198826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(SubExpr, refVars); 1989fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner else 199054b5274f2c190331438375ad114dad12ae098b57Ted Kremenek return 0; 1991fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 19921eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 1993fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // C++ casts. For dynamic casts, static casts, and const casts, we 1994fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // are always converting from a pointer-to-pointer, so we just blow 199549badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // through the cast. In the case the dynamic cast doesn't fail (and 199649badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // return NULL), we take the conservative route and report cases 1997fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // where we return the address of a stack variable. For Reinterpre 199849badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // FIXME: The comment about is wrong; we're not always converting 199949badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor // from pointer to pointer. I'm guessing that this code should also 20001eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump // handle references to objects. 20011eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXStaticCastExprClass: 20021eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump case Stmt::CXXDynamicCastExprClass: 200349badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXConstCastExprClass: 200449badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor case Stmt::CXXReinterpretCastExprClass: { 200549badde06e066d058d6c7fcf4e628a72999b65a9Douglas Gregor Expr *S = cast<CXXNamedCastExpr>(E)->getSubExpr(); 2006dd972f20dc2bd3609d833893e5c6544ac09b59a9Steve Naroff if (S->getType()->isPointerType() || S->getType()->isBlockPointerType()) 200726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(S, refVars); 200806de276fff91264437fa75111ed76de43097e089Ted Kremenek else 200906de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 2010fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner } 20111eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2012fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner // Everything else: we simply don't reason about them. 2013fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner default: 2014fae3f1f6565c74d3238747b58357a6e56fbb0e9cChris Lattner return NULL; 201506de276fff91264437fa75111ed76de43097e089Ted Kremenek } 201606de276fff91264437fa75111ed76de43097e089Ted Kremenek} 20171eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 201806de276fff91264437fa75111ed76de43097e089Ted Kremenek 201906de276fff91264437fa75111ed76de43097e089Ted Kremenek/// EvalVal - This function is complements EvalAddr in the mutual recursion. 202006de276fff91264437fa75111ed76de43097e089Ted Kremenek/// See the comments for EvalAddr for more details. 202126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidisstatic Expr *EvalVal(Expr *E, llvm::SmallVectorImpl<DeclRefExpr *> &refVars) { 202268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenekdo { 2023e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // We should only be called for evaluating non-pointer expressions, or 2024e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // expressions with a pointer type that are not used as references but instead 2025e8c600f9fedf2cfd69cdd2cb4bde4a9b39ce2873Ted Kremenek // are l-values (e.g., DeclRefExpr with a pointer type). 20261eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 202706de276fff91264437fa75111ed76de43097e089Ted Kremenek // Our "symbolic interpreter" is just a dispatch off the currently 202806de276fff91264437fa75111ed76de43097e089Ted Kremenek // viewed AST node. We then recursively traverse the AST by calling 202906de276fff91264437fa75111ed76de43097e089Ted Kremenek // EvalAddr and EvalVal appropriately. 203006de276fff91264437fa75111ed76de43097e089Ted Kremenek switch (E->getStmtClass()) { 203168957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ImplicitCastExprClass: { 203268957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E); 20335baba9d98364a3525d6afa15a04cdad82fd6dd30John McCall if (IE->getValueKind() == VK_LValue) { 203468957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = IE->getSubExpr(); 203568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 203668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 203768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek return NULL; 203868957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 203968957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek 2040a2813cec2605ce7878d1b13471d685f689b251afDouglas Gregor case Stmt::DeclRefExprClass: { 204126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // When we hit a DeclRefExpr we are looking at code that refers to a 204226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // variable's name. If it's not a reference variable we check if it has 204326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // local storage within the function, and if so, return the expression. 204406de276fff91264437fa75111ed76de43097e089Ted Kremenek DeclRefExpr *DR = cast<DeclRefExpr>(E); 20451eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 204606de276fff91264437fa75111ed76de43097e089Ted Kremenek if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) 204726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasLocalStorage()) { 204826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!V->getType()->isReferenceType()) 204926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return DR; 205026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 205126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Reference variable, follow through to the expression that 205226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // it points to. 205326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (V->hasInit()) { 205426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Add the reference variable to the "trail". 205526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis refVars.push_back(DR); 205626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(V->getInit(), refVars); 205726e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 205826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis } 20591eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 206006de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 206106de276fff91264437fa75111ed76de43097e089Ted Kremenek } 20621eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 206368957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek case Stmt::ParenExprClass: { 206406de276fff91264437fa75111ed76de43097e089Ted Kremenek // Ignore parentheses. 206568957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek E = cast<ParenExpr>(E)->getSubExpr(); 206668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek continue; 206768957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek } 20681eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 206906de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::UnaryOperatorClass: { 207006de276fff91264437fa75111ed76de43097e089Ted Kremenek // The only unary operator that make sense to handle here 207106de276fff91264437fa75111ed76de43097e089Ted Kremenek // is Deref. All others don't resolve to a "name." This includes 207206de276fff91264437fa75111ed76de43097e089Ted Kremenek // handling all sorts of rvalues passed to a unary operator. 207306de276fff91264437fa75111ed76de43097e089Ted Kremenek UnaryOperator *U = cast<UnaryOperator>(E); 20741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 20752de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (U->getOpcode() == UO_Deref) 207626e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(U->getSubExpr(), refVars); 207706de276fff91264437fa75111ed76de43097e089Ted Kremenek 207806de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 207906de276fff91264437fa75111ed76de43097e089Ted Kremenek } 20801eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 208106de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ArraySubscriptExprClass: { 208206de276fff91264437fa75111ed76de43097e089Ted Kremenek // Array subscripts are potential references to data on the stack. We 208306de276fff91264437fa75111ed76de43097e089Ted Kremenek // retrieve the DeclRefExpr* for the array variable if it indeed 208406de276fff91264437fa75111ed76de43097e089Ted Kremenek // has local storage. 208526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars); 208606de276fff91264437fa75111ed76de43097e089Ted Kremenek } 20871eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 208806de276fff91264437fa75111ed76de43097e089Ted Kremenek case Stmt::ConditionalOperatorClass: { 208906de276fff91264437fa75111ed76de43097e089Ted Kremenek // For conditional operators we need to see if either the LHS or RHS are 209026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // non-NULL Expr's. If one is non-NULL, we return it. 209106de276fff91264437fa75111ed76de43097e089Ted Kremenek ConditionalOperator *C = cast<ConditionalOperator>(E); 209206de276fff91264437fa75111ed76de43097e089Ted Kremenek 20933907323dd6665c0c4e383435cb145233f4533406Anders Carlsson // Handle the GNU extension for missing LHS. 20943907323dd6665c0c4e383435cb145233f4533406Anders Carlsson if (Expr *lhsExpr = C->getLHS()) 209526e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (Expr *LHS = EvalVal(lhsExpr, refVars)) 20963907323dd6665c0c4e383435cb145233f4533406Anders Carlsson return LHS; 20973907323dd6665c0c4e383435cb145233f4533406Anders Carlsson 209826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(C->getRHS(), refVars); 209906de276fff91264437fa75111ed76de43097e089Ted Kremenek } 21001eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 210106de276fff91264437fa75111ed76de43097e089Ted Kremenek // Accesses to members are potential references to data on the stack. 210283f6faf37d9bf58986bedc9bc0ea897a56b4dbadDouglas Gregor case Stmt::MemberExprClass: { 210306de276fff91264437fa75111ed76de43097e089Ted Kremenek MemberExpr *M = cast<MemberExpr>(E); 21041eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 210506de276fff91264437fa75111ed76de43097e089Ted Kremenek // Check for indirect access. We only want direct field accesses. 2106a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->isArrow()) 2107a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek return NULL; 2108a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 2109a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // Check whether the member type is itself a reference, in which case 2110a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek // we're not going to refer to the member, but to what the member refers to. 2111a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek if (M->getMemberDecl()->getType()->isReferenceType()) 211206de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 2113a423e81a4d04b7c1882d2787d1189cbc14540c16Ted Kremenek 211426e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return EvalVal(M->getBase(), refVars); 211506de276fff91264437fa75111ed76de43097e089Ted Kremenek } 21161eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 211706de276fff91264437fa75111ed76de43097e089Ted Kremenek default: 211826e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Check that we don't return or take the address of a reference to a 211926e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // temporary. This is only useful in C++. 212026e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis if (!E->isTypeDependent() && E->isRValue()) 212126e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis return E; 212226e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis 212326e10bea3d2e9d2979194890e51b98ecea165a96Argyrios Kyrtzidis // Everything else: we simply don't reason about them. 212406de276fff91264437fa75111ed76de43097e089Ted Kremenek return NULL; 212506de276fff91264437fa75111ed76de43097e089Ted Kremenek } 212668957a919084ab8bbd1f01d534db1d6f31d0f459Ted Kremenek} while (true); 212706de276fff91264437fa75111ed76de43097e089Ted Kremenek} 2128588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2129588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===// 2130588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2131588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Check for comparisons of floating point operands using != and ==. 2132588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// Issue a warning if these are no self-comparisons, as they are not likely 2133588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek/// to do what the programmer intended. 2134588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenekvoid Sema::CheckFloatComparison(SourceLocation loc, Expr* lex, Expr *rex) { 2135588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek bool EmitWarning = true; 21361eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2137f6a1648197562e0b133440d612d9af297d0a86ccJohn McCall Expr* LeftExprSansParen = lex->IgnoreParenImpCasts(); 2138f6a1648197562e0b133440d612d9af297d0a86ccJohn McCall Expr* RightExprSansParen = rex->IgnoreParenImpCasts(); 2139588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek 2140588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Special case: check for x == x (which is OK). 2141588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Do not emit warnings for such cases. 2142588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen)) 2143588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen)) 2144588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (DRL->getDecl() == DRR->getDecl()) 2145588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 21461eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 21471eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 21481b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // Special case: check for comparisons against literals that can be exactly 21491b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // represented by APFloat. In such cases, do not emit a warning. This 21501b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // is a heuristic: often comparison against such literals are used to 21511b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // detect if a value in a variable has not changed. This clearly can 21521b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek // lead to false negatives. 21531b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (EmitWarning) { 21541b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) { 21551b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLL->isExact()) 21561b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 2157ac5fc7c6bcb494b60fee7ce615ac931c5db6135eMike Stump } else 21581b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen)){ 21591b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek if (FLR->isExact()) 21601b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek EmitWarning = false; 21611b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 21621b500bb0d40aa3ebf1ace47340bb5f401a9ae99cTed Kremenek } 21631eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2164588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Check for comparisons with builtin types. 21650eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 2166588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen)) 21673c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor if (CL->isBuiltinCall(Context)) 2168588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 21691eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 21700eb23307222bda7ad95d968eac4e1ab30864b213Sebastian Redl if (EmitWarning) 2171588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen)) 21723c385e5f8d9008fff18597ca302be19fa86e51f6Douglas Gregor if (CR->isBuiltinCall(Context)) 2173588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek EmitWarning = false; 21741eb4433ac451dc16f4133a88af2d002ac26c58efMike Stump 2175588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek // Emit the diagnostic. 2176588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek if (EmitWarning) 2177fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner Diag(loc, diag::warn_floatingpoint_eq) 2178fa25bbb351f4fdd977f51254119cdfc2b525ce90Chris Lattner << lex->getSourceRange() << rex->getSourceRange(); 2179588e5ebee2db045c3611e0c8f601bc4495ebd0f3Ted Kremenek} 2180ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2181f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===// 2182f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===// 2183ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2184f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallnamespace { 2185ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2186f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Structure recording the 'active' range of an integer-valued 2187f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// expression. 2188f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallstruct IntRange { 2189f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// The number of bits active in the int. 2190f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned Width; 2191ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2192f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall /// True if the int is known not to have negative values. 2193f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool NonNegative; 219451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2195f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange(unsigned Width, bool NonNegative) 2196f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : Width(Width), NonNegative(NonNegative) 2197f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall {} 219851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 21991844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of the bool type. 2200f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall static IntRange forBoolType() { 2201f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(1, true); 2202f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 220351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 22041844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of the given integral type. 22051844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfType(ASTContext &C, QualType T) { 22061844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return forValueOfCanonicalType(C, 22071844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T->getCanonicalTypeInternal().getTypePtr()); 220851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 220951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 22101844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the range of an opaque value of a canonical integral type. 22111844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) { 2212f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(T->isCanonicalUnqualified()); 221351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2214f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 2215f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = VT->getElementType().getTypePtr(); 2216f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 2217f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall T = CT->getElementType().getTypePtr(); 2218323ed74658bc8375278eabf074b4777458376540John McCall 2219091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // For enum types, use the known bit width of the enumerators. 2220323ed74658bc8375278eabf074b4777458376540John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) { 2221323ed74658bc8375278eabf074b4777458376540John McCall EnumDecl *Enum = ET->getDecl(); 2222091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Enum->isDefinition()) 2223091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return IntRange(C.getIntWidth(QualType(T, 0)), false); 2224091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2225323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumPositive = Enum->getNumPositiveBits(); 2226323ed74658bc8375278eabf074b4777458376540John McCall unsigned NumNegative = Enum->getNumNegativeBits(); 2227323ed74658bc8375278eabf074b4777458376540John McCall 2228323ed74658bc8375278eabf074b4777458376540John McCall return IntRange(std::max(NumPositive, NumNegative), NumNegative == 0); 2229323ed74658bc8375278eabf074b4777458376540John McCall } 223051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2231f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const BuiltinType *BT = cast<BuiltinType>(T); 2232f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(BT->isInteger()); 223351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2234f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 223551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 223651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 22371844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the "target" range of a canonical integral type, i.e. 22381844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// the range of values expressible in the type. 22391844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// 22401844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// This matches forValueOfCanonicalType except that enums have the 22411844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// full range of their type, not the range of their enumerators. 22421844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) { 22431844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(T->isCanonicalUnqualified()); 22441844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 22451844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const VectorType *VT = dyn_cast<VectorType>(T)) 22461844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = VT->getElementType().getTypePtr(); 22471844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const ComplexType *CT = dyn_cast<ComplexType>(T)) 22481844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = CT->getElementType().getTypePtr(); 22491844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall if (const EnumType *ET = dyn_cast<EnumType>(T)) 22501844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall T = ET->getDecl()->getIntegerType().getTypePtr(); 22511844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 22521844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall const BuiltinType *BT = cast<BuiltinType>(T); 22531844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall assert(BT->isInteger()); 22541844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 22551844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger()); 22561844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall } 22571844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall 22581844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the supremum of two ranges: i.e. their conservative merge. 2259c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange join(IntRange L, IntRange R) { 2260f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(std::max(L.Width, R.Width), 226160fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative && R.NonNegative); 226260fad45739b764886f707bd204eae9ecce6db1f2John McCall } 226360fad45739b764886f707bd204eae9ecce6db1f2John McCall 22641844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall /// Returns the infinum of two ranges: i.e. their aggressive merge. 2265c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall static IntRange meet(IntRange L, IntRange R) { 226660fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange(std::min(L.Width, R.Width), 226760fad45739b764886f707bd204eae9ecce6db1f2John McCall L.NonNegative || R.NonNegative); 226851313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 2269f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall}; 227051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2271f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetValueRange(ASTContext &C, llvm::APSInt &value, unsigned MaxWidth) { 2272f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isSigned() && value.isNegative()) 2273f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getMinSignedBits(), false); 227451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2275f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.getBitWidth() > MaxWidth) 22769f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad value = value.trunc(MaxWidth); 227751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2278f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // isNonNegative() just checks the sign bit without considering 2279f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // signedness. 2280f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(value.getActiveBits(), true); 228151313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 228251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 22830acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCallIntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty, 2284f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned MaxWidth) { 2285f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isInt()) 2286f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetValueRange(C, result.getInt(), MaxWidth); 228751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2288f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isVector()) { 22890acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth); 22900acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) { 22910acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth); 22920acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall R = IntRange::join(R, El); 22930acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall } 2294f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return R; 229551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 229651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2297f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (result.isComplexInt()) { 2298f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth); 2299f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth); 2300f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(R, I); 2301f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2302f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2303f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // This can happen with lossless casts to intptr_t of "based" lvalues. 2304f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume it might use arbitrary bits. 23050acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // FIXME: The only reason we need to pass the type in here is to get 23060acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // the sign right on this one case. It would be nice if APValue 23070acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall // preserved this. 2308f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(result.isLValue()); 23090acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall return IntRange(MaxWidth, Ty->isUnsignedIntegerType()); 231051313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 231151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2312f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Pseudo-evaluate the given integer expression, estimating the 2313f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// range of values it might take. 2314f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 2315f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// \param MaxWidth - the width to which the value will be truncated 2316f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallIntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) { 231751313c39c84407dd6a323be99a8c322bf8d052a9John McCall E = E->IgnoreParens(); 231851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2319f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Try a full evaluation first. 2320f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall Expr::EvalResult result; 2321f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (E->Evaluate(result, C)) 23220acc311bf73c85fd34ce6f89a4e786b7ecd214aaJohn McCall return GetValueRange(C, result.Val, E->getType(), MaxWidth); 232351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2324f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // I think we only want to look through implicit casts here; if the 2325f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // user has an explicit widening cast, we should treat the value as 2326f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // being of the new, wider type. 2327f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) { 23282de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (CE->getCastKind() == CK_NoOp) 2329f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CE->getSubExpr(), MaxWidth); 233051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 23311844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange OutputTypeRange = IntRange::forValueOfType(C, CE->getType()); 233251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 23332de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast); 233460fad45739b764886f707bd204eae9ecce6db1f2John McCall 2335f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Assume that non-integer casts can span the full range of the type. 233660fad45739b764886f707bd204eae9ecce6db1f2John McCall if (!isIntegerCast) 2337f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 233851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2339f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange SubRange 2340f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall = GetExprRange(C, CE->getSubExpr(), 2341f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall std::min(MaxWidth, OutputTypeRange.Width)); 234251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2343f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Bail out if the subexpr's range is as wide as the cast type. 2344f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SubRange.Width >= OutputTypeRange.Width) 2345f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return OutputTypeRange; 234651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2347f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, we take the smaller width, and we're non-negative if 2348f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // either the output type or the subexpr is. 2349f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(SubRange.Width, 2350f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall SubRange.NonNegative || OutputTypeRange.NonNegative); 2351f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2352f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2353f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 2354f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // If we can fold the condition, just take that operand. 2355f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool CondResult; 2356f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C)) 2357f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, CondResult ? CO->getTrueExpr() 2358f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall : CO->getFalseExpr(), 2359f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall MaxWidth); 2360f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2361f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Otherwise, conservatively merge. 2362f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth); 2363f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth); 2364f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 236551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 236651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 236751313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 236851313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (BO->getOpcode()) { 236951313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2370f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Boolean-valued operations are single-bit and positive. 23712de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LAnd: 23722de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LOr: 23732de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LT: 23742de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GT: 23752de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_LE: 23762de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_GE: 23772de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_EQ: 23782de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_NE: 2379f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 238051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2381c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall // The type of these compound assignments is the type of the LHS, 2382c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall // so the RHS is not necessarily an integer. 23832de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_MulAssign: 23842de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_DivAssign: 23852de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_RemAssign: 23862de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AddAssign: 23872de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_SubAssign: 23881844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 2389c0cd21d2a3301a7a88e0052aebdd09c2441f826dJohn McCall 239051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 23912de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemD: 23922de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_PtrMemI: 23931844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 239451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 239560fad45739b764886f707bd204eae9ecce6db1f2John McCall // Bitwise-and uses the *infinum* of the two source ranges. 23962de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_And: 23972de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_AndAssign: 239860fad45739b764886f707bd204eae9ecce6db1f2John McCall return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth), 239960fad45739b764886f707bd204eae9ecce6db1f2John McCall GetExprRange(C, BO->getRHS(), MaxWidth)); 240060fad45739b764886f707bd204eae9ecce6db1f2John McCall 240151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Left shift gets black-listed based on a judgement call. 24022de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shl: 24033aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // ...except that we want to treat '1 << (blah)' as logically 24043aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // positive. It's an important idiom. 24053aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (IntegerLiteral *I 24063aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) { 24073aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall if (I->getValue() == 1) { 24081844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange R = IntRange::forValueOfType(C, E->getType()); 24093aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall return IntRange(R.Width, /*NonNegative*/ true); 24103aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 24113aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall } 24123aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall // fallthrough 24133aae6093dd8f3aecb66d7ff1f4b44e6a86765db4John McCall 24142de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShlAssign: 24151844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 241651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 241760fad45739b764886f707bd204eae9ecce6db1f2John McCall // Right shift by a constant can narrow its left argument. 24182de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Shr: 24192de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_ShrAssign: { 242060fad45739b764886f707bd204eae9ecce6db1f2John McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 242160fad45739b764886f707bd204eae9ecce6db1f2John McCall 242260fad45739b764886f707bd204eae9ecce6db1f2John McCall // If the shift amount is a positive constant, drop the width by 242360fad45739b764886f707bd204eae9ecce6db1f2John McCall // that much. 242460fad45739b764886f707bd204eae9ecce6db1f2John McCall llvm::APSInt shift; 242560fad45739b764886f707bd204eae9ecce6db1f2John McCall if (BO->getRHS()->isIntegerConstantExpr(shift, C) && 242660fad45739b764886f707bd204eae9ecce6db1f2John McCall shift.isNonNegative()) { 242760fad45739b764886f707bd204eae9ecce6db1f2John McCall unsigned zext = shift.getZExtValue(); 242860fad45739b764886f707bd204eae9ecce6db1f2John McCall if (zext >= L.Width) 242960fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width = (L.NonNegative ? 0 : 1); 243060fad45739b764886f707bd204eae9ecce6db1f2John McCall else 243160fad45739b764886f707bd204eae9ecce6db1f2John McCall L.Width -= zext; 243260fad45739b764886f707bd204eae9ecce6db1f2John McCall } 243360fad45739b764886f707bd204eae9ecce6db1f2John McCall 243460fad45739b764886f707bd204eae9ecce6db1f2John McCall return L; 243560fad45739b764886f707bd204eae9ecce6db1f2John McCall } 243660fad45739b764886f707bd204eae9ecce6db1f2John McCall 243760fad45739b764886f707bd204eae9ecce6db1f2John McCall // Comma acts as its right operand. 24382de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Comma: 2439f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, BO->getRHS(), MaxWidth); 2440f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 244160fad45739b764886f707bd204eae9ecce6db1f2John McCall // Black-list pointer subtractions. 24422de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case BO_Sub: 244351313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (BO->getLHS()->getType()->isPointerType()) 24441844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 244551313c39c84407dd6a323be99a8c322bf8d052a9John McCall // fallthrough 24464e4b30ec62d78b24e6556fea2624855c193d0e3eTed Kremenek 244751313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 2448f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall break; 244951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 2450f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2451f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // Treat every other operator as if it were closed on the 2452f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall // narrowest type that encompasses both operands. 2453f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth); 2454f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth); 2455f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::join(L, R); 245651313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 245751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 245851313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) { 245951313c39c84407dd6a323be99a8c322bf8d052a9John McCall switch (UO->getOpcode()) { 246051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Boolean-valued operations are white-listed. 24612de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_LNot: 2462f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange::forBoolType(); 246351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 246451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Operations with opaque sources are black-listed. 24652de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_Deref: 24662de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall case UO_AddrOf: // should be impossible 24671844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 246851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 246951313c39c84407dd6a323be99a8c322bf8d052a9John McCall default: 2470f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return GetExprRange(C, UO->getSubExpr(), MaxWidth); 247151313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 247251313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 24738ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor 24748ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor if (dyn_cast<OffsetOfExpr>(E)) { 24751844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange::forValueOfType(C, E->getType()); 24768ecdb65716cd7914ffb2eeee993fa9039fcd31e8Douglas Gregor } 247751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2478f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall FieldDecl *BitField = E->getBitField(); 2479f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (BitField) { 2480f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APSInt BitWidthAP = BitField->getBitWidth()->EvaluateAsInt(C); 2481f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall unsigned BitWidth = BitWidthAP.getZExtValue(); 248251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2483f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IntRange(BitWidth, BitField->getType()->isUnsignedIntegerType()); 2484f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2485f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 24861844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall return IntRange::forValueOfType(C, E->getType()); 2487f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 2488f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2489323ed74658bc8375278eabf074b4777458376540John McCallIntRange GetExprRange(ASTContext &C, Expr *E) { 2490323ed74658bc8375278eabf074b4777458376540John McCall return GetExprRange(C, E, C.getIntWidth(E->getType())); 2491323ed74658bc8375278eabf074b4777458376540John McCall} 2492323ed74658bc8375278eabf074b4777458376540John McCall 2493f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 2494f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 2495f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 2496f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const llvm::APFloat &value, 2497f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 2498f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 2499f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall llvm::APFloat truncated = value; 2500f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2501f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall bool ignored; 2502f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored); 2503f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored); 2504f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2505f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return truncated.bitwiseIsEqual(value); 250651313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 250751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2508f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// Checks whether the given value, which currently has the given 2509f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// source semantics, has the same value when coerced through the 2510f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// target semantics. 2511f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// 2512f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall/// The value might be a vector of floats (or a complex number). 2513f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCallbool IsSameFloatAfterCast(const APValue &value, 2514f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Src, 2515f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall const llvm::fltSemantics &Tgt) { 2516f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isFloat()) 2517f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return IsSameFloatAfterCast(value.getFloat(), Src, Tgt); 2518f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2519f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (value.isVector()) { 2520f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i) 2521f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt)) 2522f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return false; 2523f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return true; 2524f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall } 2525f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2526f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall assert(value.isComplexFloat()); 2527f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) && 2528f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt)); 2529f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall} 2530f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2531b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC); 2532323ed74658bc8375278eabf074b4777458376540John McCall 2533e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenekstatic bool IsZero(Sema &S, Expr *E) { 2534e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where we are comparing against an enum constant. 2535e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (const DeclRefExpr *DR = 2536e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts())) 2537e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (isa<EnumConstantDecl>(DR->getDecl())) 2538e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 2539e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 2540e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek // Suppress cases where the '0' value is expanded from a macro. 2541e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek if (E->getLocStart().isMacroID()) 2542e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek return false; 2543e3b159c0d4a93db8586861ff011b5a10de4ae6efTed Kremenek 2544323ed74658bc8375278eabf074b4777458376540John McCall llvm::APSInt Value; 2545323ed74658bc8375278eabf074b4777458376540John McCall return E->isIntegerConstantExpr(Value, S.Context) && Value == 0; 2546323ed74658bc8375278eabf074b4777458376540John McCall} 2547323ed74658bc8375278eabf074b4777458376540John McCall 2548372e103dab4239ec52b65b9eda69fd43c0b348d4John McCallstatic bool HasEnumType(Expr *E) { 2549372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall // Strip off implicit integral promotions. 2550372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) { 255163b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis if (ICE->getCastKind() != CK_IntegralCast && 255263b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis ICE->getCastKind() != CK_NoOp) 2553372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall break; 255463b57aeeebb5bb758ecebf9b41b5131781f32bf3Argyrios Kyrtzidis E = ICE->getSubExpr(); 2555372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall } 2556372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 2557372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall return E->getType()->isEnumeralType(); 2558372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall} 2559372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall 2560323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) { 25612de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall BinaryOperatorKind op = E->getOpcode(); 256214af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor if (E->isValueDependent()) 256314af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor return; 256414af91a38c8cf89f0a5e1835d7d8e0fa220e17a9Douglas Gregor 25652de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall if (op == BO_LT && IsZero(S, E->getRHS())) { 2566323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 2567372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "< 0" << "false" << HasEnumType(E->getLHS()) 2568323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 25692de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GE && IsZero(S, E->getRHS())) { 2570323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison) 2571372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << ">= 0" << "true" << HasEnumType(E->getLHS()) 2572323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 25732de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_GT && IsZero(S, E->getLHS())) { 2574323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 2575372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 >" << "false" << HasEnumType(E->getRHS()) 2576323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 25772de56d1d0c3a504ad1529de2677628bdfbb95cd4John McCall } else if (op == BO_LE && IsZero(S, E->getLHS())) { 2578323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison) 2579372e103dab4239ec52b65b9eda69fd43c0b348d4John McCall << "0 <=" << "true" << HasEnumType(E->getRHS()) 2580323ed74658bc8375278eabf074b4777458376540John McCall << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange(); 2581323ed74658bc8375278eabf074b4777458376540John McCall } 2582323ed74658bc8375278eabf074b4777458376540John McCall} 2583323ed74658bc8375278eabf074b4777458376540John McCall 2584323ed74658bc8375278eabf074b4777458376540John McCall/// Analyze the operands of the given comparison. Implements the 2585323ed74658bc8375278eabf074b4777458376540John McCall/// fallback case from AnalyzeComparison. 2586323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) { 2587b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 2588b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 2589323ed74658bc8375278eabf074b4777458376540John McCall} 2590f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2591ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \brief Implements -Wsign-compare. 2592ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// 2593ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \param lex the left-hand expression 2594ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \param rex the right-hand expression 2595ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall/// \param OpLoc the location of the joining operator 2596d1b47bf17fde73fac67d8664bd65273742c00ecdJohn McCall/// \param BinOpc binary opcode or 0 2597323ed74658bc8375278eabf074b4777458376540John McCallvoid AnalyzeComparison(Sema &S, BinaryOperator *E) { 2598323ed74658bc8375278eabf074b4777458376540John McCall // The type the comparison is being performed in. 2599323ed74658bc8375278eabf074b4777458376540John McCall QualType T = E->getLHS()->getType(); 2600323ed74658bc8375278eabf074b4777458376540John McCall assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) 2601323ed74658bc8375278eabf074b4777458376540John McCall && "comparison with mismatched types"); 2602323ed74658bc8375278eabf074b4777458376540John McCall 2603323ed74658bc8375278eabf074b4777458376540John McCall // We don't do anything special if this isn't an unsigned integral 2604323ed74658bc8375278eabf074b4777458376540John McCall // comparison: we're only interested in integral comparisons, and 2605323ed74658bc8375278eabf074b4777458376540John McCall // signed comparisons only happen in cases we don't care to warn about. 26063e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // 26073e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // We also don't care about value-dependent expressions or expressions 26083e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor // whose result is a constant. 26093e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor if (!T->hasUnsignedIntegerRepresentation() 26103e026e323f1bd820fb9c880b1db951c87df94bb4Douglas Gregor || E->isValueDependent() || E->isIntegerConstantExpr(S.Context)) 2611323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 2612323ed74658bc8375278eabf074b4777458376540John McCall 2613323ed74658bc8375278eabf074b4777458376540John McCall Expr *lex = E->getLHS()->IgnoreParenImpCasts(); 2614323ed74658bc8375278eabf074b4777458376540John McCall Expr *rex = E->getRHS()->IgnoreParenImpCasts(); 2615323ed74658bc8375278eabf074b4777458376540John McCall 2616323ed74658bc8375278eabf074b4777458376540John McCall // Check to see if one of the (unmodified) operands is of different 2617323ed74658bc8375278eabf074b4777458376540John McCall // signedness. 2618323ed74658bc8375278eabf074b4777458376540John McCall Expr *signedOperand, *unsignedOperand; 2619f60946222721d9ba3c059563935c17b84703187aDouglas Gregor if (lex->getType()->hasSignedIntegerRepresentation()) { 2620f60946222721d9ba3c059563935c17b84703187aDouglas Gregor assert(!rex->getType()->hasSignedIntegerRepresentation() && 2621323ed74658bc8375278eabf074b4777458376540John McCall "unsigned comparison between two signed integer expressions?"); 2622323ed74658bc8375278eabf074b4777458376540John McCall signedOperand = lex; 2623323ed74658bc8375278eabf074b4777458376540John McCall unsignedOperand = rex; 2624f60946222721d9ba3c059563935c17b84703187aDouglas Gregor } else if (rex->getType()->hasSignedIntegerRepresentation()) { 2625323ed74658bc8375278eabf074b4777458376540John McCall signedOperand = rex; 2626323ed74658bc8375278eabf074b4777458376540John McCall unsignedOperand = lex; 2627ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } else { 2628323ed74658bc8375278eabf074b4777458376540John McCall CheckTrivialUnsignedComparison(S, E); 2629323ed74658bc8375278eabf074b4777458376540John McCall return AnalyzeImpConvsInComparison(S, E); 2630ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall } 2631ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2632323ed74658bc8375278eabf074b4777458376540John McCall // Otherwise, calculate the effective range of the signed operand. 2633323ed74658bc8375278eabf074b4777458376540John McCall IntRange signedRange = GetExprRange(S.Context, signedOperand); 2634f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall 2635323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and analyze implicit conversions in the operands. Note 2636323ed74658bc8375278eabf074b4777458376540John McCall // that we skip the implicit conversions on both sides. 2637b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, lex, E->getOperatorLoc()); 2638b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, rex, E->getOperatorLoc()); 2639ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2640323ed74658bc8375278eabf074b4777458376540John McCall // If the signed range is non-negative, -Wsign-compare won't fire, 2641323ed74658bc8375278eabf074b4777458376540John McCall // but we should still check for comparisons which are always true 2642323ed74658bc8375278eabf074b4777458376540John McCall // or false. 2643323ed74658bc8375278eabf074b4777458376540John McCall if (signedRange.NonNegative) 2644323ed74658bc8375278eabf074b4777458376540John McCall return CheckTrivialUnsignedComparison(S, E); 2645ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2646ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // For (in)equality comparisons, if the unsigned operand is a 2647ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // constant which cannot collide with a overflowed signed operand, 2648ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // then reinterpreting the signed operand as unsigned will not 2649ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall // change the result of the comparison. 2650323ed74658bc8375278eabf074b4777458376540John McCall if (E->isEqualityOp()) { 2651323ed74658bc8375278eabf074b4777458376540John McCall unsigned comparisonWidth = S.Context.getIntWidth(T); 2652323ed74658bc8375278eabf074b4777458376540John McCall IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand); 2653323ed74658bc8375278eabf074b4777458376540John McCall 2654323ed74658bc8375278eabf074b4777458376540John McCall // We should never be unable to prove that the unsigned operand is 2655323ed74658bc8375278eabf074b4777458376540John McCall // non-negative. 2656323ed74658bc8375278eabf074b4777458376540John McCall assert(unsignedRange.NonNegative && "unsigned range includes negative?"); 2657ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 2658323ed74658bc8375278eabf074b4777458376540John McCall if (unsignedRange.Width < comparisonWidth) 2659323ed74658bc8375278eabf074b4777458376540John McCall return; 2660323ed74658bc8375278eabf074b4777458376540John McCall } 2661323ed74658bc8375278eabf074b4777458376540John McCall 2662323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getOperatorLoc(), diag::warn_mixed_sign_comparison) 2663323ed74658bc8375278eabf074b4777458376540John McCall << lex->getType() << rex->getType() 2664323ed74658bc8375278eabf074b4777458376540John McCall << lex->getSourceRange() << rex->getSourceRange(); 2665ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall} 2666ba26e58c64b4f6233dfc4bcd3ef6ce83aab47ffcJohn McCall 266715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Analyzes an attempt to assign the given value to a bitfield. 266815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// 266915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall/// Returns true if there was something fishy about the attempt. 267015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallbool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init, 267115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall SourceLocation InitLoc) { 267215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall assert(Bitfield->isBitField()); 267315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Bitfield->isInvalidDecl()) 267415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 267515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 267691b6014876e9186f968f74a8975ab8fc08ef1b68John McCall // White-list bool bitfields. 267791b6014876e9186f968f74a8975ab8fc08ef1b68John McCall if (Bitfield->getType()->isBooleanType()) 267891b6014876e9186f968f74a8975ab8fc08ef1b68John McCall return false; 267991b6014876e9186f968f74a8975ab8fc08ef1b68John McCall 268046ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor // Ignore value- or type-dependent expressions. 268146ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor if (Bitfield->getBitWidth()->isValueDependent() || 268246ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Bitfield->getBitWidth()->isTypeDependent() || 268346ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isValueDependent() || 268446ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor Init->isTypeDependent()) 268546ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor return false; 268646ff3034d14aaa92b530e96480741f3d5d458cb8Douglas Gregor 268715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *OriginalInit = Init->IgnoreParenImpCasts(); 268815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 268915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall llvm::APSInt Width(32); 269015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr::EvalResult InitValue; 269115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (!Bitfield->getBitWidth()->isIntegerConstantExpr(Width, S.Context) || 269291b6014876e9186f968f74a8975ab8fc08ef1b68John McCall !OriginalInit->Evaluate(InitValue, S.Context) || 269315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall !InitValue.Val.isInt()) 269415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 269515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 269615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall const llvm::APSInt &Value = InitValue.Val.getInt(); 269715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned OriginalWidth = Value.getBitWidth(); 269815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall unsigned FieldWidth = Width.getZExtValue(); 269915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 270015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (OriginalWidth <= FieldWidth) 270115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 270215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 27039f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad llvm::APSInt TruncatedValue = Value.trunc(FieldWidth); 270415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 270515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // It's fairly common to write values into signed bitfields 270615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // that, if sign-extended, would end up becoming a different 270715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // value. We don't want to warn about that. 270815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value.isSigned() && Value.isNegative()) 27099f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad TruncatedValue = TruncatedValue.sext(OriginalWidth); 271015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall else 27119f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad TruncatedValue = TruncatedValue.zext(OriginalWidth); 271215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 271315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (Value == TruncatedValue) 271415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return false; 271515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 271615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyValue = Value.toString(10); 271715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall std::string PrettyTrunc = TruncatedValue.toString(10); 271815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 271915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant) 272015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << PrettyValue << PrettyTrunc << OriginalInit->getType() 272115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall << Init->getSourceRange(); 272215d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 272315d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return true; 272415d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 272515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 2726beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// Analyze the given simple or compound assignment for warning-worthy 2727beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall/// operations. 2728beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCallvoid AnalyzeAssignment(Sema &S, BinaryOperator *E) { 2729beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Just recurse on the LHS. 2730beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc()); 2731beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 2732beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // We want to recurse on the RHS as normal unless we're assigning to 2733beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // a bitfield. 2734beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (FieldDecl *Bitfield = E->getLHS()->getBitField()) { 273515d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(), 273615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc())) { 273715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall // Recurse, ignoring any implicit conversions on the RHS. 273815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(), 273915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall E->getOperatorLoc()); 2740beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 2741beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 2742beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 2743beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc()); 2744beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall} 2745beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 274651313c39c84407dd6a323be99a8c322bf8d052a9John McCall/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 27475a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregorvoid DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T, 27485a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceLocation CContext, unsigned diag) { 27495a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor S.Diag(E->getExprLoc(), diag) 27505a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor << SourceType << T << E->getSourceRange() << SourceRange(CContext); 27515a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor} 27525a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 2753e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion. 2754e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruthvoid DiagnoseImpCast(Sema &S, Expr *E, QualType T, SourceLocation CContext, 2755e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth unsigned diag) { 2756e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth DiagnoseImpCast(S, E, E->getType(), T, CContext, diag); 2757e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth} 2758e1b02e00d851389415a5b7a1398de26c382887c6Chandler Carruth 2759091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCallstd::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) { 2760091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (!Range.Width) return "0"; 2761091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2762091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt ValueInRange = Value; 2763091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall ValueInRange.setIsSigned(!Range.NonNegative); 27649f71a8f4c7a182a5236da9e747d57cc1d1bd24c2Jay Foad ValueInRange = ValueInRange.trunc(Range.Width); 2765091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return ValueInRange.toString(10); 2766091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall} 2767091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2768ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenekstatic bool isFromSystemMacro(Sema &S, SourceLocation loc) { 2769ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceManager &smgr = S.Context.getSourceManager(); 2770ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return loc.isMacroID() && smgr.isInSystemHeader(smgr.getSpellingLoc(loc)); 2771ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek} 2772ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 2773323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckImplicitConversion(Sema &S, Expr *E, QualType T, 2774b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool *ICContext = 0) { 2775323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) return; 277651313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2777323ed74658bc8375278eabf074b4777458376540John McCall const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr(); 2778323ed74658bc8375278eabf074b4777458376540John McCall const Type *Target = S.Context.getCanonicalType(T).getTypePtr(); 2779323ed74658bc8375278eabf074b4777458376540John McCall if (Source == Target) return; 2780323ed74658bc8375278eabf074b4777458376540John McCall if (Target->isDependentType()) return; 278151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2782ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // If the conversion context location is invalid don't complain. 2783ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // We also don't want to emit a warning if the issue occurs from the 2784ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // instantiation of a system macro. The problem is that 'getSpellingLoc()' 2785ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // is slow, so we delay this check as long as possible. Once we detect 2786ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // we are in that scenario, we just return. 2787ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (CC.isInvalid()) 2788b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return; 2789b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 279051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Never diagnose implicit casts to bool. 279151313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (Target->isSpecificBuiltinType(BuiltinType::Bool)) 279251313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 279351313c39c84407dd6a323be99a8c322bf8d052a9John McCall 279451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip vector types. 279551313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<VectorType>(Source)) { 2796ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<VectorType>(Target)) { 2797ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 2798ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 2799b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar); 2800ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 280151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 280251313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<VectorType>(Source)->getElementType().getTypePtr(); 280351313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<VectorType>(Target)->getElementType().getTypePtr(); 280451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 280551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 280651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Strip complex types. 280751313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (isa<ComplexType>(Source)) { 2808ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (!isa<ComplexType>(Target)) { 2809ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 2810ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 2811ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 2812b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar); 2813ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 281451313c39c84407dd6a323be99a8c322bf8d052a9John McCall 281551313c39c84407dd6a323be99a8c322bf8d052a9John McCall Source = cast<ComplexType>(Source)->getElementType().getTypePtr(); 281651313c39c84407dd6a323be99a8c322bf8d052a9John McCall Target = cast<ComplexType>(Target)->getElementType().getTypePtr(); 281751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 281851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 281951313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source); 282051313c39c84407dd6a323be99a8c322bf8d052a9John McCall const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target); 282151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 282251313c39c84407dd6a323be99a8c322bf8d052a9John McCall // If the source is floating point... 282351313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT && SourceBT->isFloatingPoint()) { 282451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...and the target is floating point... 282551313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (TargetBT && TargetBT->isFloatingPoint()) { 282651313c39c84407dd6a323be99a8c322bf8d052a9John McCall // ...then warn if we're dropping FP rank. 282751313c39c84407dd6a323be99a8c322bf8d052a9John McCall 282851313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Builtin FP kinds are ordered by increasing FP rank. 282951313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (SourceBT->getKind() > TargetBT->getKind()) { 283051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Don't warn about float constants that are precisely 283151313c39c84407dd6a323be99a8c322bf8d052a9John McCall // representable in the target type. 283251313c39c84407dd6a323be99a8c322bf8d052a9John McCall Expr::EvalResult result; 2833323ed74658bc8375278eabf074b4777458376540John McCall if (E->Evaluate(result, S.Context)) { 283451313c39c84407dd6a323be99a8c322bf8d052a9John McCall // Value might be a float, a float vector, or a float complex. 283551313c39c84407dd6a323be99a8c322bf8d052a9John McCall if (IsSameFloatAfterCast(result.Val, 2836323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)), 2837323ed74658bc8375278eabf074b4777458376540John McCall S.Context.getFloatTypeSemantics(QualType(SourceBT, 0)))) 283851313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 283951313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 284051313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2841ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 2842ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 2843ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 2844b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision); 284551313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 284651313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 284751313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 284851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2849ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek // If the target is integral, always warn. 2850a5b9332418f25338f118358e27303cd510d54107Chandler Carruth if ((TargetBT && TargetBT->isInteger())) { 2851ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 2852ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 2853ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 2854a5b9332418f25338f118358e27303cd510d54107Chandler Carruth Expr *InnerE = E->IgnoreParenImpCasts(); 2855a5b9332418f25338f118358e27303cd510d54107Chandler Carruth if (FloatingLiteral *LiteralExpr = dyn_cast<FloatingLiteral>(InnerE)) { 2856a5b9332418f25338f118358e27303cd510d54107Chandler Carruth DiagnoseImpCast(S, LiteralExpr, T, CC, 2857a5b9332418f25338f118358e27303cd510d54107Chandler Carruth diag::warn_impcast_literal_float_to_integer); 2858a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } else { 2859a5b9332418f25338f118358e27303cd510d54107Chandler Carruth DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer); 2860a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 2861a5b9332418f25338f118358e27303cd510d54107Chandler Carruth } 286251313c39c84407dd6a323be99a8c322bf8d052a9John McCall 286351313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 286451313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 286551313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2866f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (!Source->isIntegerType() || !Target->isIntegerType()) 286751313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 286851313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2869323ed74658bc8375278eabf074b4777458376540John McCall IntRange SourceRange = GetExprRange(S.Context, E); 28701844a6e1074a5c1fd8eadac7fc7317c3e29d4653John McCall IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target); 287151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2872f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width > TargetRange.Width) { 2873091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // If the source is a constant, use a default-on diagnostic. 2874091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall // TODO: this should happen for bitfield stores, too. 2875091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall llvm::APSInt Value(32); 2876091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall if (E->isIntegerConstantExpr(Value, S.Context)) { 2877ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 2878ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 2879ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 2880091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettySourceValue = Value.toString(10); 2881091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange); 2882091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 2883091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall S.Diag(E->getExprLoc(), diag::warn_impcast_integer_precision_constant) 2884091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall << PrettySourceValue << PrettyTargetValue 2885091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall << E->getType() << T << E->getSourceRange() << clang::SourceRange(CC); 2886091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall return; 2887091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall } 2888091f23f1d6d4bcffd6641cda72a6831e08c02ea7John McCall 288951313c39c84407dd6a323be99a8c322bf8d052a9John McCall // People want to build with -Wshorten-64-to-32 and not -Wconversion 289051313c39c84407dd6a323be99a8c322bf8d052a9John McCall // and by god we'll let them. 2891ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 2892ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 2893ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 2894ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 2895f2370c9b4aade940e2253b5b33262ba507d1d71fJohn McCall if (SourceRange.Width == 64 && TargetRange.Width == 32) 2896b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32); 2897b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision); 2898323ed74658bc8375278eabf074b4777458376540John McCall } 2899323ed74658bc8375278eabf074b4777458376540John McCall 2900323ed74658bc8375278eabf074b4777458376540John McCall if ((TargetRange.NonNegative && !SourceRange.NonNegative) || 2901323ed74658bc8375278eabf074b4777458376540John McCall (!TargetRange.NonNegative && SourceRange.NonNegative && 2902323ed74658bc8375278eabf074b4777458376540John McCall SourceRange.Width == TargetRange.Width)) { 2903ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 2904ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 2905ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 2906ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 2907323ed74658bc8375278eabf074b4777458376540John McCall unsigned DiagID = diag::warn_impcast_integer_sign; 2908323ed74658bc8375278eabf074b4777458376540John McCall 2909323ed74658bc8375278eabf074b4777458376540John McCall // Traditionally, gcc has warned about this under -Wsign-compare. 2910323ed74658bc8375278eabf074b4777458376540John McCall // We also want to warn about it in -Wconversion. 2911323ed74658bc8375278eabf074b4777458376540John McCall // So if -Wconversion is off, use a completely identical diagnostic 2912323ed74658bc8375278eabf074b4777458376540John McCall // in the sign-compare group. 2913323ed74658bc8375278eabf074b4777458376540John McCall // The conditional-checking code will 2914323ed74658bc8375278eabf074b4777458376540John McCall if (ICContext) { 2915323ed74658bc8375278eabf074b4777458376540John McCall DiagID = diag::warn_impcast_integer_sign_conditional; 2916323ed74658bc8375278eabf074b4777458376540John McCall *ICContext = true; 2917323ed74658bc8375278eabf074b4777458376540John McCall } 2918323ed74658bc8375278eabf074b4777458376540John McCall 2919b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return DiagnoseImpCast(S, E, T, CC, DiagID); 292051313c39c84407dd6a323be99a8c322bf8d052a9John McCall } 292151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2922284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor // Diagnose conversions between different enumeration types. 29235a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // In C, we pretend that the type of an EnumConstantDecl is its enumeration 29245a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor // type, to give us better diagnostics. 29255a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor QualType SourceType = E->getType(); 29265a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (!S.getLangOptions().CPlusPlus) { 29275a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) 29285a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) { 29295a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext()); 29305a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor SourceType = S.Context.getTypeDeclType(Enum); 29315a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor Source = S.Context.getCanonicalType(SourceType).getTypePtr(); 29325a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 29335a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor } 29345a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor 2935284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *SourceEnum = Source->getAs<EnumType>()) 2936284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if (const EnumType *TargetEnum = Target->getAs<EnumType>()) 2937284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor if ((SourceEnum->getDecl()->getIdentifier() || 2938284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor SourceEnum->getDecl()->getTypedefForAnonDecl()) && 2939284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor (TargetEnum->getDecl()->getIdentifier() || 2940284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor TargetEnum->getDecl()->getTypedefForAnonDecl()) && 2941ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek SourceEnum != TargetEnum) { 2942ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek if (isFromSystemMacro(S, CC)) 2943ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek return; 2944ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek 29455a5b38f4afaf4f203b96a11ba79890c7cd4cc4b8Douglas Gregor return DiagnoseImpCast(S, E, SourceType, T, CC, 2946284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor diag::warn_impcast_different_enum_types); 2947ef9ff88f54ff26ac9782d98a34b74aa424149be1Ted Kremenek } 2948284cc8d8a90ae6558e0a4b60b7dc1ddcfd220758Douglas Gregor 294951313c39c84407dd6a323be99a8c322bf8d052a9John McCall return; 295051313c39c84407dd6a323be99a8c322bf8d052a9John McCall} 295151313c39c84407dd6a323be99a8c322bf8d052a9John McCall 2952323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T); 2953323ed74658bc8375278eabf074b4777458376540John McCall 2954323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperand(Sema &S, Expr *E, QualType T, 2955b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC, bool &ICContext) { 2956323ed74658bc8375278eabf074b4777458376540John McCall E = E->IgnoreParenImpCasts(); 2957323ed74658bc8375278eabf074b4777458376540John McCall 2958323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) 2959323ed74658bc8375278eabf074b4777458376540John McCall return CheckConditionalOperator(S, cast<ConditionalOperator>(E), T); 2960323ed74658bc8375278eabf074b4777458376540John McCall 2961b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E, CC); 2962323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 2963b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return CheckImplicitConversion(S, E, T, CC, &ICContext); 2964323ed74658bc8375278eabf074b4777458376540John McCall return; 2965323ed74658bc8375278eabf074b4777458376540John McCall} 2966323ed74658bc8375278eabf074b4777458376540John McCall 2967323ed74658bc8375278eabf074b4777458376540John McCallvoid CheckConditionalOperator(Sema &S, ConditionalOperator *E, QualType T) { 2968b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall SourceLocation CC = E->getQuestionLoc(); 2969b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall 2970b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, E->getCond(), CC); 2971323ed74658bc8375278eabf074b4777458376540John McCall 2972323ed74658bc8375278eabf074b4777458376540John McCall bool Suspicious = false; 2973b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious); 2974b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious); 2975323ed74658bc8375278eabf074b4777458376540John McCall 2976323ed74658bc8375278eabf074b4777458376540John McCall // If -Wconversion would have warned about either of the candidates 2977323ed74658bc8375278eabf074b4777458376540John McCall // for a signedness conversion to the context type... 2978323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) return; 2979323ed74658bc8375278eabf074b4777458376540John McCall 2980323ed74658bc8375278eabf074b4777458376540John McCall // ...but it's currently ignored... 29810827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (S.Diags.getDiagnosticLevel(diag::warn_impcast_integer_sign_conditional, 29820827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis CC)) 2983323ed74658bc8375278eabf074b4777458376540John McCall return; 2984323ed74658bc8375278eabf074b4777458376540John McCall 2985323ed74658bc8375278eabf074b4777458376540John McCall // ...and -Wsign-compare isn't... 29860827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (!S.Diags.getDiagnosticLevel(diag::warn_mixed_sign_conditional, CC)) 2987323ed74658bc8375278eabf074b4777458376540John McCall return; 2988323ed74658bc8375278eabf074b4777458376540John McCall 2989323ed74658bc8375278eabf074b4777458376540John McCall // ...then check whether it would have warned about either of the 2990323ed74658bc8375278eabf074b4777458376540John McCall // candidates for a signedness conversion to the condition type. 2991323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) { 2992323ed74658bc8375278eabf074b4777458376540John McCall Suspicious = false; 2993323ed74658bc8375278eabf074b4777458376540John McCall CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(), 2994b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 2995323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) 2996323ed74658bc8375278eabf074b4777458376540John McCall CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(), 2997b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall E->getType(), CC, &Suspicious); 2998323ed74658bc8375278eabf074b4777458376540John McCall if (!Suspicious) 2999323ed74658bc8375278eabf074b4777458376540John McCall return; 3000323ed74658bc8375278eabf074b4777458376540John McCall } 3001323ed74658bc8375278eabf074b4777458376540John McCall 3002323ed74658bc8375278eabf074b4777458376540John McCall // If so, emit a diagnostic under -Wsign-compare. 3003323ed74658bc8375278eabf074b4777458376540John McCall Expr *lex = E->getTrueExpr()->IgnoreParenImpCasts(); 3004323ed74658bc8375278eabf074b4777458376540John McCall Expr *rex = E->getFalseExpr()->IgnoreParenImpCasts(); 3005323ed74658bc8375278eabf074b4777458376540John McCall S.Diag(E->getQuestionLoc(), diag::warn_mixed_sign_conditional) 3006323ed74658bc8375278eabf074b4777458376540John McCall << lex->getType() << rex->getType() 3007323ed74658bc8375278eabf074b4777458376540John McCall << lex->getSourceRange() << rex->getSourceRange(); 3008323ed74658bc8375278eabf074b4777458376540John McCall} 3009323ed74658bc8375278eabf074b4777458376540John McCall 3010323ed74658bc8375278eabf074b4777458376540John McCall/// AnalyzeImplicitConversions - Find and report any interesting 3011323ed74658bc8375278eabf074b4777458376540John McCall/// implicit conversions in the given expression. There are a couple 3012323ed74658bc8375278eabf074b4777458376540John McCall/// of competing diagnostics here, -Wconversion and -Wsign-compare. 3013b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) { 3014323ed74658bc8375278eabf074b4777458376540John McCall QualType T = OrigE->getType(); 3015323ed74658bc8375278eabf074b4777458376540John McCall Expr *E = OrigE->IgnoreParenImpCasts(); 3016323ed74658bc8375278eabf074b4777458376540John McCall 3017323ed74658bc8375278eabf074b4777458376540John McCall // For conditional operators, we analyze the arguments as if they 3018323ed74658bc8375278eabf074b4777458376540John McCall // were being fed directly into the output. 3019323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ConditionalOperator>(E)) { 3020323ed74658bc8375278eabf074b4777458376540John McCall ConditionalOperator *CO = cast<ConditionalOperator>(E); 3021323ed74658bc8375278eabf074b4777458376540John McCall CheckConditionalOperator(S, CO, T); 3022323ed74658bc8375278eabf074b4777458376540John McCall return; 3023323ed74658bc8375278eabf074b4777458376540John McCall } 3024323ed74658bc8375278eabf074b4777458376540John McCall 3025323ed74658bc8375278eabf074b4777458376540John McCall // Go ahead and check any implicit conversions we might have skipped. 3026323ed74658bc8375278eabf074b4777458376540John McCall // The non-canonical typecheck is just an optimization; 3027323ed74658bc8375278eabf074b4777458376540John McCall // CheckImplicitConversion will filter out dead implicit conversions. 3028323ed74658bc8375278eabf074b4777458376540John McCall if (E->getType() != T) 3029b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CheckImplicitConversion(S, E, T, CC); 3030323ed74658bc8375278eabf074b4777458376540John McCall 3031323ed74658bc8375278eabf074b4777458376540John McCall // Now continue drilling into this expression. 3032323ed74658bc8375278eabf074b4777458376540John McCall 3033323ed74658bc8375278eabf074b4777458376540John McCall // Skip past explicit casts. 3034323ed74658bc8375278eabf074b4777458376540John McCall if (isa<ExplicitCastExpr>(E)) { 3035323ed74658bc8375278eabf074b4777458376540John McCall E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts(); 3036b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall return AnalyzeImplicitConversions(S, E, CC); 3037323ed74658bc8375278eabf074b4777458376540John McCall } 3038323ed74658bc8375278eabf074b4777458376540John McCall 3039beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 3040beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // Do a somewhat different check with comparison operators. 3041beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isComparisonOp()) 3042beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeComparison(S, BO); 3043beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall 3044beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall // And with assignments and compound assignments. 3045beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall if (BO->isAssignmentOp()) 3046beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall return AnalyzeAssignment(S, BO); 3047beb22aaa22e255241d6a81e8b0a9239f5fa584f3John McCall } 3048323ed74658bc8375278eabf074b4777458376540John McCall 3049323ed74658bc8375278eabf074b4777458376540John McCall // These break the otherwise-useful invariant below. Fortunately, 3050323ed74658bc8375278eabf074b4777458376540John McCall // we don't really need to recurse into them, because any internal 3051323ed74658bc8375278eabf074b4777458376540John McCall // expressions should have been analyzed already when they were 3052323ed74658bc8375278eabf074b4777458376540John McCall // built into statements. 3053323ed74658bc8375278eabf074b4777458376540John McCall if (isa<StmtExpr>(E)) return; 3054323ed74658bc8375278eabf074b4777458376540John McCall 3055323ed74658bc8375278eabf074b4777458376540John McCall // Don't descend into unevaluated contexts. 3056f4e3cfbe8abd124be6341ef5d714819b4fbd9082Peter Collingbourne if (isa<UnaryExprOrTypeTraitExpr>(E)) return; 3057323ed74658bc8375278eabf074b4777458376540John McCall 3058323ed74658bc8375278eabf074b4777458376540John McCall // Now just recurse over the expression's children. 3059b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall CC = E->getExprLoc(); 30607502c1d3ce8bb97bcc4f7bebef507040bd93b26fJohn McCall for (Stmt::child_range I = E->children(); I; ++I) 3061b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(S, cast<Expr>(*I), CC); 3062323ed74658bc8375278eabf074b4777458376540John McCall} 3063323ed74658bc8375278eabf074b4777458376540John McCall 3064323ed74658bc8375278eabf074b4777458376540John McCall} // end anonymous namespace 3065323ed74658bc8375278eabf074b4777458376540John McCall 3066323ed74658bc8375278eabf074b4777458376540John McCall/// Diagnoses "dangerous" implicit conversions within the given 3067323ed74658bc8375278eabf074b4777458376540John McCall/// expression (which is a full expression). Implements -Wconversion 3068323ed74658bc8375278eabf074b4777458376540John McCall/// and -Wsign-compare. 3069b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// 3070b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// \param CC the "context" location of the implicit conversion, i.e. 3071b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// the most location of the syntactic entity requiring the implicit 3072b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall/// conversion 3073b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCallvoid Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) { 3074323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose in unevaluated contexts. 3075323ed74658bc8375278eabf074b4777458376540John McCall if (ExprEvalContexts.back().Context == Sema::Unevaluated) 3076323ed74658bc8375278eabf074b4777458376540John McCall return; 3077323ed74658bc8375278eabf074b4777458376540John McCall 3078323ed74658bc8375278eabf074b4777458376540John McCall // Don't diagnose for value- or type-dependent expressions. 3079323ed74658bc8375278eabf074b4777458376540John McCall if (E->isTypeDependent() || E->isValueDependent()) 3080323ed74658bc8375278eabf074b4777458376540John McCall return; 3081323ed74658bc8375278eabf074b4777458376540John McCall 3082b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall // This is not the right CC for (e.g.) a variable initialization. 3083b4eb64d8426c0eaa58d398961e0e74ff85063d7cJohn McCall AnalyzeImplicitConversions(*this, E, CC); 3084323ed74658bc8375278eabf074b4777458376540John McCall} 3085323ed74658bc8375278eabf074b4777458376540John McCall 308615d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCallvoid Sema::CheckBitFieldInitialization(SourceLocation InitLoc, 308715d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall FieldDecl *BitField, 308815d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall Expr *Init) { 308915d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc); 309015d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall} 309115d7d12226f83de24f96f4bf4e27ebba30fef51eJohn McCall 3092f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// CheckParmsForFunctionDef - Check that the parameters of the given 3093f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// function are appropriate for the definition of a function. This 3094f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// takes care of any checks that cannot be performed on the 3095f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// declaration itself, e.g., that the types of each of the function 3096f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump/// parameters are complete. 309782aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregorbool Sema::CheckParmsForFunctionDef(ParmVarDecl **P, ParmVarDecl **PEnd, 309882aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor bool CheckParameterNames) { 3099f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump bool HasInvalidParm = false; 310082aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor for (; P != PEnd; ++P) { 310182aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor ParmVarDecl *Param = *P; 310282aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor 3103f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.7.5.3p4: the parameters in a parameter type list in a 3104f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // function declarator that is part of a function definition of 3105f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // that function shall not have incomplete type. 3106f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // 3107f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // This is also C++ [dcl.fct]p6. 3108f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump if (!Param->isInvalidDecl() && 3109f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump RequireCompleteType(Param->getLocation(), Param->getType(), 3110f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump diag::err_typecheck_decl_incomplete_type)) { 3111f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Param->setInvalidDecl(); 3112f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump HasInvalidParm = true; 3113f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 3114f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 3115f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // C99 6.9.1p5: If the declarator includes a parameter type list, the 3116f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump // declaration of each parameter shall include an identifier. 311782aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor if (CheckParameterNames && 311882aa713bcda99f388836c2a30bb868d9c9974817Douglas Gregor Param->getIdentifier() == 0 && 3119f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !Param->isImplicit() && 3120f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump !getLangOptions().CPlusPlus) 3121f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump Diag(Param->getLocation(), diag::err_parameter_name_omitted); 3122d17e340e2d516139931768697bf080f60920ba9dSam Weinig 3123d17e340e2d516139931768697bf080f60920ba9dSam Weinig // C99 6.7.5.3p12: 3124d17e340e2d516139931768697bf080f60920ba9dSam Weinig // If the function declarator is not part of a definition of that 3125d17e340e2d516139931768697bf080f60920ba9dSam Weinig // function, parameters may have incomplete type and may use the [*] 3126d17e340e2d516139931768697bf080f60920ba9dSam Weinig // notation in their sequences of declarator specifiers to specify 3127d17e340e2d516139931768697bf080f60920ba9dSam Weinig // variable length array types. 3128d17e340e2d516139931768697bf080f60920ba9dSam Weinig QualType PType = Param->getOriginalType(); 3129d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (const ArrayType *AT = Context.getAsArrayType(PType)) { 3130d17e340e2d516139931768697bf080f60920ba9dSam Weinig if (AT->getSizeModifier() == ArrayType::Star) { 3131d17e340e2d516139931768697bf080f60920ba9dSam Weinig // FIXME: This diagnosic should point the the '[*]' if source-location 3132d17e340e2d516139931768697bf080f60920ba9dSam Weinig // information is added for it. 3133d17e340e2d516139931768697bf080f60920ba9dSam Weinig Diag(Param->getLocation(), diag::err_array_star_in_function_definition); 3134d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 3135d17e340e2d516139931768697bf080f60920ba9dSam Weinig } 3136f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump } 3137f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump 3138f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump return HasInvalidParm; 3139f8c4921c73d73123e2b79221ad4f1775ce984cfdMike Stump} 3140b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3141b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// CheckCastAlign - Implements -Wcast-align, which warns when a 3142b7f4ffe073fa419613946461a2583ba2fcb72280John McCall/// pointer cast increases the alignment requirements. 3143b7f4ffe073fa419613946461a2583ba2fcb72280John McCallvoid Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { 3144b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // This is actually a lot of work to potentially be doing on every 3145b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // cast; don't do it if we're ignoring -Wcast_align (as is the default). 31460827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis if (getDiagnostics().getDiagnosticLevel(diag::warn_cast_align, 31470827408865e32789e0ec4b8113a302ccdc531423Argyrios Kyrtzidis TRange.getBegin()) 3148b7f4ffe073fa419613946461a2583ba2fcb72280John McCall == Diagnostic::Ignored) 3149b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 3150b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3151b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Ignore dependent types. 3152b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (T->isDependentType() || Op->getType()->isDependentType()) 3153b7f4ffe073fa419613946461a2583ba2fcb72280John McCall return; 3154b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3155b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the destination be a pointer type. 3156b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *DestPtr = T->getAs<PointerType>(); 3157b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!DestPtr) return; 3158b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3159b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // If the destination has alignment 1, we're done. 3160b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType DestPointee = DestPtr->getPointeeType(); 3161b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestPointee->isIncompleteType()) return; 3162b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee); 3163b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (DestAlign.isOne()) return; 3164b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3165b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Require that the source be a pointer type. 3166b7f4ffe073fa419613946461a2583ba2fcb72280John McCall const PointerType *SrcPtr = Op->getType()->getAs<PointerType>(); 3167b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (!SrcPtr) return; 3168b7f4ffe073fa419613946461a2583ba2fcb72280John McCall QualType SrcPointee = SrcPtr->getPointeeType(); 3169b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3170b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Whitelist casts from cv void*. We already implicitly 3171b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // whitelisted casts to cv void*, since they have alignment 1. 3172b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // Also whitelist casts involving incomplete types, which implicitly 3173b7f4ffe073fa419613946461a2583ba2fcb72280John McCall // includes 'void'. 3174b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcPointee->isIncompleteType()) return; 3175b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3176b7f4ffe073fa419613946461a2583ba2fcb72280John McCall CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee); 3177b7f4ffe073fa419613946461a2583ba2fcb72280John McCall if (SrcAlign >= DestAlign) return; 3178b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 3179b7f4ffe073fa419613946461a2583ba2fcb72280John McCall Diag(TRange.getBegin(), diag::warn_cast_align) 3180b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << Op->getType() << T 3181b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(SrcAlign.getQuantity()) 3182b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << static_cast<unsigned>(DestAlign.getQuantity()) 3183b7f4ffe073fa419613946461a2583ba2fcb72280John McCall << TRange << Op->getSourceRange(); 3184b7f4ffe073fa419613946461a2583ba2fcb72280John McCall} 3185b7f4ffe073fa419613946461a2583ba2fcb72280John McCall 31863aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekstatic void CheckArrayAccess_Check(Sema &S, 31873aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek const clang::ArraySubscriptExpr *E) { 318835001ca261f895817916b468379b696d6d45959dChandler Carruth const Expr *BaseExpr = E->getBase()->IgnoreParenImpCasts(); 31893406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const ConstantArrayType *ArrayTy = 31903aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek S.Context.getAsConstantArrayType(BaseExpr->getType()); 31913406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (!ArrayTy) 3192a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 319335001ca261f895817916b468379b696d6d45959dChandler Carruth 31943406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth const Expr *IndexExpr = E->getIdx(); 31953406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (IndexExpr->isValueDependent()) 3196a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 31973406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth llvm::APSInt index; 31983aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (!IndexExpr->isIntegerConstantExpr(index, S.Context)) 3199a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek return; 32008fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek 32019e060ca641a1f845cecb3371b3a3018d306a5198Ted Kremenek if (index.isUnsigned() || !index.isNegative()) { 320225b3b849e3ad340b04442707038c86980035765bTed Kremenek llvm::APInt size = ArrayTy->getSize(); 320335001ca261f895817916b468379b696d6d45959dChandler Carruth if (!size.isStrictlyPositive()) 320435001ca261f895817916b468379b696d6d45959dChandler Carruth return; 32053406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (size.getBitWidth() > index.getBitWidth()) 32063406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth index = index.sext(size.getBitWidth()); 320725b3b849e3ad340b04442707038c86980035765bTed Kremenek else if (size.getBitWidth() < index.getBitWidth()) 320825b3b849e3ad340b04442707038c86980035765bTed Kremenek size = size.sext(index.getBitWidth()); 320925b3b849e3ad340b04442707038c86980035765bTed Kremenek 32103406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth if (index.slt(size)) 32118fd0a5dfb025a51f48b7931b95efbf35d3c5dfc3Ted Kremenek return; 32123406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth 32133aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek S.DiagRuntimeBehavior(E->getBase()->getLocStart(), BaseExpr, 32143aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek S.PDiag(diag::warn_array_index_exceeds_bounds) 32153aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek << index.toString(10, true) 32163aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek << size.toString(10, true) 32173aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek << IndexExpr->getSourceRange()); 32183406458512c3cdfe2076c46b9aedb4621297efd5Chandler Carruth } else { 32193aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek S.DiagRuntimeBehavior(E->getBase()->getLocStart(), BaseExpr, 32203aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek S.PDiag(diag::warn_array_index_precedes_bounds) 32213aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek << index.toString(10, true) 32223aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek << IndexExpr->getSourceRange()); 3223a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek } 322435001ca261f895817916b468379b696d6d45959dChandler Carruth 322535001ca261f895817916b468379b696d6d45959dChandler Carruth const NamedDecl *ND = NULL; 322635001ca261f895817916b468379b696d6d45959dChandler Carruth if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr)) 322735001ca261f895817916b468379b696d6d45959dChandler Carruth ND = dyn_cast<NamedDecl>(DRE->getDecl()); 322835001ca261f895817916b468379b696d6d45959dChandler Carruth if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr)) 322935001ca261f895817916b468379b696d6d45959dChandler Carruth ND = dyn_cast<NamedDecl>(ME->getMemberDecl()); 323035001ca261f895817916b468379b696d6d45959dChandler Carruth if (ND) 32313aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek S.DiagRuntimeBehavior(ND->getLocStart(), BaseExpr, 32323aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek S.PDiag(diag::note_array_index_out_of_bounds) 32333aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek << ND->getDeclName()); 32343aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek} 32353aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek 32363aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenekvoid Sema::CheckArrayAccess(const Expr *expr) { 32373aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek while (true) 32383aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek switch (expr->getStmtClass()) { 32393aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek case Stmt::ParenExprClass: 32403aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek expr = cast<ParenExpr>(expr)->getSubExpr(); 32413aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek continue; 32423aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek case Stmt::ArraySubscriptExprClass: 32433aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess_Check(*this, cast<ArraySubscriptExpr>(expr)); 32443aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 32453aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek case Stmt::ConditionalOperatorClass: { 32463aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek const ConditionalOperator *cond = cast<ConditionalOperator>(expr); 32473aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *lhs = cond->getLHS()) 32483aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(lhs); 32493aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek if (const Expr *rhs = cond->getRHS()) 32503aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek CheckArrayAccess(rhs); 32513aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 32523aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 32533aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek default: 32543aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek return; 32553aea4dac830cb03d883a13ab30c28a3a53beca58Ted Kremenek } 3256a0125d8520f65aca581378c235384e7affefa1fcTed Kremenek} 3257